]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Merge from emacs-24; up to 2012-04-20T05:47:55Z!eliz@gnu.org
[gnu-emacs] / src / ChangeLog
1 2012-05-05 Jim Meyering <meyering@redhat.com>
2
3 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4
5 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
6
7 * data.c (PUT_ERROR): New macro.
8 (syms_of_data): Use it. Add new error type `user-error'.
9 * undo.c (user_error): New function.
10 (Fprimitive_undo): Use it.
11 * print.c (print_error_message): Adjust print style for `user-error'.
12 * keyboard.c (user_error): New function.
13 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
14
15 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
16
17 Do not limit current-time-string to years 1000..9999.
18 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
19 (Fcurrent_time_string): Support any year that is supported by the
20 underlying localtime representation. Don't use asctime, as it
21 has undefined behavior for years outside the range -999..9999.
22
23 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
24
25 Fix race conditions involving setenv, gmtime, localtime, asctime.
26 Without this fix, interrupts could mess up code that uses these
27 nonreentrant functions, since setting TZ invalidates existing
28 tm_zone or tzname values, and since most of these functions return
29 pointers to static storage.
30 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
31 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
32 Grow the critical sections to include not just invoking
33 localtime/gmtime, but also accessing these functions' results
34 including their tm_zone values if any, and any related TZ setting.
35 (format_time_string): Last arg is now struct tm *, not struct tm **,
36 so that the struct tm is saved in the critical section.
37 All callers changed. Simplify allocation of initial buffer, partly
38 motivated by the fact that memory allocation needs to be outside
39 the critical section.
40
41 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
42
43 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
44 with RESET_INTERVAL.
45
46 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
47 Remove duplicated buffer name initialization.
48
49 2012-05-02 Jim Meyering <jim@meyering.net>
50
51 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
52
53 * xfns.c (x_window): Use xstrdup (Bug#11375).
54
55 2012-05-02 Eli Zaretskii <eliz@gnu.org>
56
57 * xdisp.c (pos_visible_p): If already at a newline from the
58 display string before the 'while' loop, don't walk back the glyphs
59 from it3.glyph_row. Solves assertion violation when the display
60 string begins with a newline (egg.el). (Bug#11367)
61
62 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
63
64 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
65 Move to simple.el.
66
67 2012-05-01 Glenn Morris <rgm@gnu.org>
68
69 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
70 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
71 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
72 All were removed before 23.1.
73
74 * dispnew.c: Remove HAVE_LIBNCURSES test;
75 it is always true on relevant platforms.
76
77 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
78 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
79
80 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
81
82 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
83
84 * .gdbinit (xpr): Remove checks for no longer existing misc types.
85 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
86 Remove.
87
88 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
89
90 Do not avoid creating empty evaporating overlays (Bug#9642).
91 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
92 That is, do not delete an evaporating overlay if it becomes
93 empty after its bounds are adjusted to fit within its buffer.
94 This fix caused other problems, and I'm reverting it until we get
95 to the bottom of them.
96
97 2012-04-27 Chong Yidong <cyd@gnu.org>
98
99 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
100
101 2012-04-27 Eli Zaretskii <eliz@gnu.org>
102
103 * xdisp.c (pos_visible_p): If the window start position is beyond
104 ZV, start the display from buffer beginning. Prevents assertion
105 violation in init_iterator when the minibuffer window is scrolled
106 via the scroll bar.
107
108 * window.c (window_scroll_pixel_based): Likewise.
109
110 2012-04-27 Chong Yidong <cyd@gnu.org>
111
112 * keymap.c (where_is_internal): Doc fix (Bug#10872).
113
114 2012-04-27 Glenn Morris <rgm@gnu.org>
115
116 * fileio.c (Fcopy_file, Fset_file_selinux_context):
117 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
118
119 2012-04-27 Eli Zaretskii <eliz@gnu.org>
120
121 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
122 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
123
124 2012-04-26 Eli Zaretskii <eliz@gnu.org>
125
126 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
127 display element, check also the underlying string or buffer
128 character. (Bug#11341)
129
130 * w32menu.c: Include w32heap.h.
131 (add_menu_item): If the call to AppendMenuW (via
132 unicode_append_menu) fails, disable Unicode menus only if we are
133 running on Windows 9X/Me.
134
135 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
136
137 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
138 (xgetint): Add missing shift for LSB tags.
139
140 2012-04-24 Martin Rudalics <rudalics@gmx.at>
141
142 * keyboard.c (read_char): Don't wipe echo area for select window
143 events: These might get delayed via `mouse-autoselect-window'
144 (Bug#11304).
145
146 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
147
148 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
149 manipulation of :loaded-from data.
150
151 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
152
153 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
154 now a cons (bug#11311).
155
156 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
157
158 Do not create empty overlays with the evaporate property (Bug#9642).
159 * buffer.c (Fmove_overlay): Delete an evaporating overlay
160 if it becomes empty after its bounds are adjusted to fit within
161 its buffer. Without this fix, in a nonempty buffer (let ((o
162 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
163 yields an empty overlay that has the evaporate property, which is
164 not supposed to happen.
165
166 Fix minor GTK3 problems found by static checking.
167 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
168 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
169 (struct _EmacsFixedClass, emacs_fixed_get_type):
170 Move decls here from emacsgtkfixed.h, since they needn't be public.
171 (emacs_fixed_get_type): Now static.
172 (emacs_fixed_class_init): Omit unused local.
173 (emacs_fixed_child_type): Remove; unused.
174 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
175 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
176 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
177 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
178 (EMACS_FIXED_GET_CLASS): Remove; unused.
179 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
180
181 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
182 Problem reported by Juanma Barranquero for Windows -Wunused-function.
183
184 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
185
186 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
187 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
188 (__malloc_size_t, __malloc_ptrdiff_t):
189 Remove. All uses removed, replaced by the definiens if needed,
190 since we can assume C89 or better now.
191 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
192 (protect_malloc_state, align, get_contiguous_space)
193 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
194 (malloc_atfork_handler_child, malloc_enable_thread)
195 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
196 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
197 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
198 (special_realloc, _realloc_internal_nolock, _realloc_internal)
199 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
200 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
201 Define using prototypes, not old style.
202 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
203 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
204 (align): Don't assume that signed integer overflow wraps around.
205 Omit unused local var.
206 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
207 (_free_internal_nolock, memalign, mallochook, reallochook):
208 Omit no-longer-needed casts.
209 (valloc): Use getpagesize, not __getpagesize.
210 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
211 (struct hdr): The 'magic' member is now size_t, not unsigned long.
212
213 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
214
215 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
216
217 Move functions from C to Lisp. Make non-blocking method calls
218 the default. Implement further D-Bus standard interfaces.
219
220 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
221 (QCdbus_request_name_allow_replacement)
222 (QCdbus_request_name_replace_existing)
223 (QCdbus_request_name_do_not_queue)
224 (QCdbus_request_name_reply_primary_owner)
225 (QCdbus_request_name_reply_in_queue)
226 (QCdbus_request_name_reply_exists)
227 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
228 (QCdbus_registered_serial, QCdbus_registered_method)
229 (QCdbus_registered_signal): New Lisp objects.
230 (XD_DEBUG_MESSAGE): Use sizeof.
231 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
232 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
233 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
234 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
235 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
236 (xd_signature, xd_append_arg): Allow float for integer types.
237 (xd_get_connection_references): New function.
238 (xd_get_connection_address): Rename from xd_initialize.
239 Return cached address.
240 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
241 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
242 level.
243 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
244 Return number of recounts.
245 (Fdbus_get_unique_name): Make stronger parameter check.
246 (Fdbus_message_internal): New defun.
247 (Fdbus_call_method, Fdbus_call_method_asynchronously)
248 (Fdbus_method_return_internal, Fdbus_method_error_internal)
249 (Fdbus_send_signal, Fdbus_register_service)
250 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
251 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
252 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
253 (Vdbus_compiled_version, Vdbus_runtime_version)
254 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
255 (Vdbus_message_type_method_return, Vdbus_message_type_error)
256 (Vdbus_message_type_signal): New defvars.
257 (Vdbus_registered_buses, Vdbus_registered_objects_table):
258 Adapt docstring.
259
260 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
261
262 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
263 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
264 Do not assume ptrdiff_t is the same width as 'int'.
265
266 * alloc.c: Handle unusual debugging option combinations.
267 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
268 since the two debugging options are incompatible.
269 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
270 is defined.
271 (mem_init, mem_insert, mem_insert_fixup):
272 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
273 (NEED_MEM_INSERT): Remove; no longer needed.
274
275 2012-04-22 Leo Liu <sdl.web@gmail.com>
276
277 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
278
279 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
280
281 * sysdep.c [__FreeBSD__]: Minor cleanups.
282 (list_system_processes, system_process_attributes) [__FreeBSD__]:
283 Use Emacs indenting style more consistently. Avoid some casts.
284 Use 'double' consistently rather than mixing 'float' and 'double'.
285
286 2012-04-21 Eduard Wiebe <usenet@pusto.de>
287
288 * sysdep.c (list_system_processes, system_process_attributes):
289 Add implementation for FreeBSD (Bug#5243).
290
291 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
292
293 * lisp.mk (lisp): Update.
294
295 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
296
297 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
298 It is never used otherwise.
299
300 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
301
302 * print.c (print_preprocess): Only check print_depth if print-circle
303 is nil.
304 (print_object): Check for cycles even when print-circle is nil and
305 print-gensym is t, but only check print_depth if print-circle is nil.
306
307 2012-04-20 Chong Yidong <cyd@gnu.org>
308
309 * process.c (wait_reading_process_output): If EIO occurs on a pty,
310 set the status to "failed" and ensure that sentinel is run.
311
312 2012-04-20 Glenn Morris <rgm@gnu.org>
313
314 * process.c (Fset_process_inherit_coding_system_flag)
315 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
316 (Fmake_network_process, Fmake_serial_process): Doc fix.
317
318 2012-04-20 Eli Zaretskii <eliz@gnu.org>
319
320 * xdisp.c (string_buffer_position_lim): Limit starting position to
321 BEGV.
322 (set_cursor_from_row): If called for a mode-line or header-line
323 row, return zero immediately.
324 (try_cursor_movement): If inside continuation line, don't back up
325 farther than the first row after the header line, if any.
326 Don't consider the header-line row as "partially visible", even if
327 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
328
329 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
330
331 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
332 (bug#11238).
333
334 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
335 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
336
337 configure: new option --enable-gcc-warnings (Bug#11207)
338 * Makefile.in (C_WARNINGS_SWITCH): Remove.
339 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
340 (ALL_CFLAGS): Use new macros rather than old.
341 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
342 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
343 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
344 -Wunused-result, -Wunused-variable. This should go away once
345 the Emacs and Gnulib regex code is merged.
346 (xmalloc, xrealloc): Now static.
347
348 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
349
350 * dired.c (Fsystem_groups): Remove unused local.
351
352 2012-04-17 Glenn Morris <rgm@gnu.org>
353
354 * dired.c (Fsystem_users): Doc fix.
355
356 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
357
358 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
359 (syms_of_dired): Add them.
360
361 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
362
363 Fix minor alloc.c problems found by static checking.
364 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
365 New extern decls, to avoid calling undeclared functions.
366 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
367 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
368 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
369 (NEED_MEM_INSERT): New macro.
370 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
371 Remove one incorrect comment and fix another.
372
373 Fix minor ralloc.c problems found by static checking.
374 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
375 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
376 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
377 (r_alloc_sbrk): Now static.
378
379 Improve ralloc.c interface checking.
380 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
381 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
382 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
383 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
384 [REL_ALLOC]: ... to here, to check interface.
385 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
386 Remove decls. This fixes an "It stinks!".
387
388 * alloc.c (which_symbols): Fix alignment issue / type clash.
389
390 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
391
392 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
393 (struct Lisp_Misc_Any): Likewise.
394 (struct Lisp_Free): Likewise.
395 * alloc.c (union aligned_Lisp_Symbol): Define.
396 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
397 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
398 (union aligned_Lisp_Misc): Define.
399 (MARKER_BLOCK_SIZE, struct marker_block): Use union
400 aligned_Lisp_Misc instead of union Lisp_Misc.
401 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
402
403 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
404
405 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
406 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
407 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
408 * s/netbsd.h, s/sol2-6.h:
409 Remove definition of GC_MARK_STACK, since the default now works.
410 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
411 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
412 no longer the default.
413 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
414
415 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
416
417 * lread.c (lisp_file_lexically_bound_p):
418 Fix hang at ";-*-\n" (bug#11238).
419
420 2012-04-14 Eli Zaretskii <eliz@gnu.org>
421
422 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
423 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
424
425 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
426
427 * nsterm.m (constrainFrameRect): Always constrain when there is only
428 one screen (Bug#10962).
429
430 2012-04-13 Ken Brown <kbrown@cornell.edu>
431
432 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
433
434 2012-04-13 Reuben Thomas <rrt@sc3d.org>
435
436 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
437
438 2012-04-11 Daniel Colascione <dancol@dancol.org>
439
440 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
441 against is gone. It's better to use vfork now so that when Cygwin
442 gains a new, working vfork, we use it automatically (bug#10398).
443
444 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
445
446 * window.c (save_window_save): Obey window-point-insertion-type.
447
448 2012-04-11 Glenn Morris <rgm@gnu.org>
449
450 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
451
452 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
453
454 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
455
456 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
457
458 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
459 (force_quit_count): New var.
460 (handle_interrupt): Use it.
461
462 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
463
464 * w32.c (w32_delayed_load): Record the full path of the library
465 being loaded (bug#10424).
466
467 2012-04-09 Glenn Morris <rgm@gnu.org>
468
469 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
470 not just in the obarray, before snarfing them. (Bug#11036)
471
472 * Makefile.in ($(leimdir)/leim-list.el):
473 Pass EMACS rather than BUILT_EMACS.
474
475 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
476
477 * process.c (make_process):
478 * process.h: Add integer `gnutls_handshakes_tried' member to
479 process struct.
480
481 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
482 Add convenience `GNUTLS_LOG2i' macro.
483
484 * gnutls.c (gnutls_log_function2i): Convenience log function.
485 (emacs_gnutls_read): Use new log functions,
486 `gnutls_handshakes_tried' process member, and
487 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
488 attempts per process (connection).
489
490 2012-04-09 Chong Yidong <cyd@gnu.org>
491
492 * eval.c (Fuser_variable_p, user_variable_p_eh)
493 (lisp_indirect_variable): Functions deleted.
494 (Fdefvar): Caller changed.
495
496 * callint.c (Finteractive, Fcall_interactively):
497 * minibuf.c (Fread_variable): Callers changed.
498
499 2012-04-09 Eli Zaretskii <eliz@gnu.org>
500
501 * xdisp.c (set_cursor_from_row): If the display string appears in
502 the buffer at position that is closer to point than the position
503 after the display string, display the cursor on the first glyph of
504 the display string. Fixes cursor display when a 'display' text
505 property immediately follows invisible text. (Bug#11094)
506
507 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
508
509 composite.c: use 'double' consistently
510 * composite.c (get_composition_id): Use 'double' consistently
511 instead of converting 'float' to 'double' and vice versa; this is
512 easier to understand and avoids a GCC warning.
513
514 2012-04-09 Glenn Morris <rgm@gnu.org>
515
516 * Makefile.in: Generate leim-list with bootstrap-emacs, in
517 preparation for dumping it with emacs. (Bug#4789)
518 (leimdir): New variable.
519 ($(leimdir)/leim-list.el): New rule.
520 (emacs$(EXEEXT)): Depend on leim-list.el.
521
522 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
523 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
524 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
525
526 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
527
528 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
529 proper alignment.
530
531 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
532
533 * xml.c (init_libxml2_functions) [WINDOWSNT]:
534 Remove unused local variable.
535
536 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
537
538 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
539 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
540 (mark_memory): Mark Lisp_Objects only if pointers might hide in
541 objects, as mark_maybe_pointer will catch them otherwise.
542 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
543 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
544
545 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
546
547 Fix typo that broke non-Windows builds.
548 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
549
550 2012-04-07 Eli Zaretskii <eliz@gnu.org>
551
552 Support building on MS-Windows with libxml2.
553
554 * makefile.w32-in (OBJ2): Add xml.$(O).
555 (GLOBAL_SOURCES): Add xml.c.
556 ($(BLD)/xml.$(O)): New dependency list.
557
558 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
559 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
560 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
561 [!WINDOWSNT]: New macros.
562 (init_libxml2_functions, libxml2_loaded_p): New functions.
563 (parse_region): Call fn_xmlCheckVersion instead of using the macro
564 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
565 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
566 Calls xmlCleanupParser only if libxml2 was loaded (or statically
567 linked in).
568 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
569 Call init_libxml2_functions before calling libxml2 functions.
570 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
571
572 * emacs.c: Don't include libxml/parser.h.
573 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
574 xmlCleanupParser directly.
575
576 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
577
578 2012-04-07 Eli Zaretskii <eliz@gnu.org>
579
580 * indent.c (Fvertical_motion): If there is a display string at
581 point, use it.vpos to compute how many lines to backtrack after
582 move_it_to point. (Bug#11133)
583
584 2012-04-06 Eli Zaretskii <eliz@gnu.org>
585
586 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
587 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
588 about subtle differences between FETCH_CHAR* and STRING_CHAR*
589 macros related to unification of CJK characters. For the details,
590 see the discussion following the message here:
591 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
592
593 2012-04-04 Chong Yidong <cyd@gnu.org>
594
595 * keyboard.c (Vdelayed_warnings_list): Doc fix.
596
597 2012-04-01 Eli Zaretskii <eliz@gnu.org>
598
599 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
600 instead of alloca. (Bug#11138)
601
602 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
603
604 * w32menu.c (is_simple_dialog): Properly check lisp types.
605 (Bug#11141)
606
607 2012-03-31 Eli Zaretskii <eliz@gnu.org>
608
609 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
610 position we get to after a call to move_it_to fails the
611 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
612 only if we wind up in a string from display property. (Bug#11063)
613
614 * window.c (Fdelete_other_windows_internal): Invalidate the row
615 and column information about mouse highlight, so that redisplay
616 restores it after reallocating the glyph matrices. (Bug#7464)
617
618 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
619 string comes from a `display' text property, use the buffer
620 position of that property as if we actually saw that position in
621 the row's glyphs.
622 (move_it_by_lines): Remove the assertion that
623 "it->current_x == 0 && it->hpos == 0" which can be legitimately
624 violated when there's a before-string at the beginning of a line.
625 (Bug#11063)
626
627 2012-03-30 Eli Zaretskii <eliz@gnu.org>
628
629 * xdisp.c (append_space_for_newline): If the default face was
630 remapped, use the remapped face for the appended newline.
631 (extend_face_to_end_of_line): Use the remapped default face for
632 extending the face to the end of the line.
633 (display_line): Call extend_face_to_end_of_line when the default
634 face was remapped. (Bug#11068)
635
636 2012-03-29 Eli Zaretskii <eliz@gnu.org>
637
638 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
639
640 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
641
642 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
643
644 2012-03-27 Glenn Morris <rgm@gnu.org>
645
646 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
647 Doc fixes.
648
649 2012-03-26 Kenichi Handa <handa@m17n.org>
650
651 * dispextern.h (struct glyph): Fix previous change. Change the
652 bit length of glyphless.ch to 25 (Bug#11082).
653
654 2012-03-26 Chong Yidong <cyd@gnu.org>
655
656 * keyboard.c (Vselection_inhibit_update_commands): New variable.
657 (command_loop_1): Use it; inhibit selection update for
658 handle-select-window too (Bug#8996).
659
660 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
661
662 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
663
664 2012-03-25 Kenichi Handa <handa@m17n.org>
665
666 * dispextern.h (struct glyph): Change the bit length of
667 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
668
669 2012-03-24 Eli Zaretskii <eliz@gnu.org>
670
671 * s/ms-w32.h (tzname): Include time.h before redirecting to
672 _tzname. Fixes the MSVC build. (Bug#9960)
673
674 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
675
676 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
677 characters.
678
679 * xterm.c (XTread_socket): Only modify handling_signal if
680 !SYNC_INPUT. (Bug#11080)
681
682 2012-03-23 Eli Zaretskii <eliz@gnu.org>
683
684 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
685 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
686 when fetching a multibyte character consumes more bytes than
687 CHAR_BYTES returns, due to unification of CJK characters in
688 string_char. (Bug#11073)
689
690 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
691
692 * process.c (wait_reading_process_output): Handle pty disconnect
693 by refraining from sending oneself a SIGCHLD (bug#10933).
694
695 2012-03-22 Chong Yidong <cyd@gnu.org>
696
697 * dispextern.h (struct it): New member string_from_prefix_prop_p.
698
699 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
700 Mark string as coming from a prefix property.
701 (handle_face_prop): Use default face for prefix strings (Bug#4281).
702 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
703
704 2012-03-21 Chong Yidong <cyd@gnu.org>
705
706 * xfaces.c (Vface_remapping_alist): Doc fix.
707
708 2012-03-20 Eli Zaretskii <eliz@gnu.org>
709
710 * w32proc.c (Fw32_set_console_codepage)
711 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
712 Doc fixes.
713
714 2012-03-20 Chong Yidong <cyd@gnu.org>
715
716 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
717 to reflect default non-nil value of redisplay-dont-pause.
718
719 2012-03-19 Kenichi Handa <handa@m17n.org>
720
721 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
722 it fit in a valid range (Bug#11003).
723
724 2012-03-18 Eli Zaretskii <eliz@gnu.org>
725
726 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
727 that is not from display property, accept the row as a "cursor
728 row" if one of the string's character has a non-nil `cursor'
729 property. Fixes cursor positioning when there are newlines in
730 overlay strings, e.g. in icomplete.el. (Bug#11035)
731
732 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
733
734 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
735
736 2012-03-12 Chong Yidong <cyd@gnu.org>
737
738 * eval.c (inhibit_lisp_code): Rename from
739 inhibit_window_configuration_change_hook; move from window.c.
740
741 * xfns.c (unwind_create_frame_1, Fx_create_frame):
742 * window.c (run_window_configuration_change_hook)
743 (syms_of_window): Callers changed.
744
745 2012-03-11 Chong Yidong <cyd@gnu.org>
746
747 * keymap.c (Fkey_description): Doc fix (Bug#9700).
748
749 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
750
751 2012-03-10 Chong Yidong <cyd@gnu.org>
752
753 * frame.c (other_visible_frames): Don't assume the selected frame
754 is visible (Bug#10955).
755
756 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
757
758 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
759
760 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
761
762 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
763 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
764 zero (Bug#10954).
765
766 2012-03-03 Glenn Morris <rgm@gnu.org>
767
768 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
769
770 2012-03-02 Eli Zaretskii <eliz@gnu.org>
771
772 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
773 position past the first glyph_row that ends at ZV. (Bug#10902)
774 (redisplay_window, next_element_from_string): Fix typos in
775 comments.
776 (redisplay_window): Pass to move_it_vertically the margin in
777 pixels, not in screen lines.
778
779 2012-03-02 Glenn Morris <rgm@gnu.org>
780
781 * buffer.c (buffer-list-update-hook): Doc fix.
782
783 2012-02-29 Eli Zaretskii <eliz@gnu.org>
784
785 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
786 push_it before setting up the iterator for the first overlay
787 string, even if we have an empty string loaded.
788 (next_overlay_string): If there's an empty string on the iterator
789 stack, pop the stack. (Bug#10903)
790
791 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
792
793 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
794 Suggested by Stefan Monnier in
795 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
796 * alloc.c (widen_to_Lisp_Object): New static function.
797 (mark_memory): Also mark Lisp_Objects by fetching pointer words
798 and widening them to Lisp_Objects. This would work even if
799 USE_LSB_TAG is defined and wide integers are used, which might
800 happen in a future version of Emacs.
801
802 2012-02-25 Chong Yidong <cyd@gnu.org>
803
804 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
805 Doc fix.
806
807 * xselect.c (Fx_selection_exists_p): Doc fix.
808 (x_clipboard_manager_save_all): Print an informative message
809 before saving to clipboard manager.
810
811 2012-02-24 Chong Yidong <cyd@gnu.org>
812
813 * keyboard.c (process_special_events): Handle all X selection
814 requests in kbd_buffer, not just the next one (Bug#8869).
815
816 2012-02-23 Chong Yidong <cyd@gnu.org>
817
818 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
819 call when setting menu-bar-lines and tool-bar-lines parameters.
820 (unwind_create_frame_1): New helper function.
821
822 * window.c (inhibit_window_configuration_change_hook): New var.
823 (run_window_configuration_change_hook): Obey it.
824 (syms_of_window): Initialize it.
825
826 2012-02-22 Chong Yidong <cyd@gnu.org>
827
828 * xterm.c (x_draw_image_relief): Add missing type check for
829 Vtool_bar_button_margin (Bug#10743).
830
831 2012-02-21 Chong Yidong <cyd@gnu.org>
832
833 * fileio.c (Vfile_name_handler_alist): Doc fix.
834
835 * buffer.c (Fget_file_buffer): Protect against invalid file
836 handler return value.
837
838 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
839
840 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
841 when computing $valmask.
842
843 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
844 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
845 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
846 It's useless in that case, and it can cause problems on hosts
847 that allocate halves of EMACS_INT values separately.
848 Reported by Dan Horák. Diagnosed by Andreas Schwab in
849 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
850 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
851 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
852 it avoids undefined behavior on hosts where shifting right by more
853 than the word width has undefined behavior.
854
855 2012-02-19 Chong Yidong <cyd@gnu.org>
856
857 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
858 (Funhandled_file_name_directory, Ffile_name_as_directory)
859 (Fdirectory_file_name, Fexpand_file_name)
860 (Fsubstitute_in_file_name): Protect against invalid file handler
861 return values (Bug#10845).
862
863 2012-02-18 Eli Zaretskii <eliz@gnu.org>
864
865 * .gdbinit (pitx): Fix incorrect references to fields of the
866 iterator stack.
867
868 2012-02-17 Chong Yidong <cyd@gnu.org>
869
870 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
871
872 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
873
874 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
875 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
876
877 2012-02-15 Chong Yidong <cyd@gnu.org>
878
879 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
880 marked as special. Also, starting docstrings with * is obsolete.
881
882 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
883
884 * gnutls.c (emacs_gnutls_write): Fix last change.
885
886 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
887
888 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
889 send_process.
890
891 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
892
893 * keymap.c (Fsingle_key_description): Handle char ranges.
894
895 2012-02-12 Chong Yidong <cyd@gnu.org>
896
897 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
898 as that creates a dangerous corner case.
899
900 * window.c (Fdelete_window_internal): Invalidate the mouse
901 highlight (Bug#9904).
902
903 2012-02-12 Glenn Morris <rgm@gnu.org>
904
905 * xselect.c (Fx_own_selection_internal)
906 (Fx_get_selection_internal, Fx_disown_selection_internal)
907 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
908 * nsselect.m (Fx_own_selection_internal)
909 (Fx_disown_selection_internal, Fx_selection_exists_p)
910 (Fx_selection_owner_p, Fx_get_selection_internal):
911 Sync docs and argument specs with the xselect.c versions.
912
913 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
914
915 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
916
917 2012-02-11 Eli Zaretskii <eliz@gnu.org>
918
919 * w32select.c (Fx_selection_exists_p): Sync doc string and
920 argument list with xselect.c. (Bug#10783)
921
922 * w16select.c (Fx_selection_exists_p): Sync doc string and
923 argument list with xselect.c. (Bug#10783)
924
925 2012-02-10 Glenn Morris <rgm@gnu.org>
926
927 * fns.c (Fsecure_hash): Doc fix.
928
929 2012-02-09 Kenichi Handa <handa@m17n.org>
930
931 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
932
933 2012-02-07 Chong Yidong <cyd@gnu.org>
934
935 * buffer.c (Fbuffer_local_variables)
936 (buffer_lisp_local_variables): Handle unbound vars correctly;
937 don't let Qunbound leak into Lisp.
938
939 2012-02-07 Glenn Morris <rgm@gnu.org>
940
941 * image.c (Fimagemagick_types): Doc fix.
942
943 * image.c (imagemagick-render-type): Change it from a lisp object
944 to an integer. Move the doc here from the lisp manual.
945 Treat all values not equal to 0 the same.
946
947 2012-02-06 Chong Yidong <cyd@gnu.org>
948
949 * doc.c (store_function_docstring): Avoid applying docstring of
950 alias to base function (Bug#2603).
951
952 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
953
954 * .gdbinit (pp1, pv1): Remove redundant defines.
955 (pr): Use pp.
956
957 2012-02-04 Chong Yidong <cyd@gnu.org>
958
959 * nsterm.m: Declare a global (Bug#10694).
960
961 2012-02-04 Eli Zaretskii <eliz@gnu.org>
962
963 * w32.c (get_emacs_configuration_options):
964 Include --enable-checking, if specified, in the return value.
965
966 2012-02-04 Martin Rudalics <rudalics@gmx.at>
967
968 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
969 after rounding frame sizes. (Bug#9723)
970
971 2012-02-04 Eli Zaretskii <eliz@gnu.org>
972
973 * keyboard.c (adjust_point_for_property): Don't position point
974 before BEGV. (Bug#10696)
975
976 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
977
978 Handle overflow when computing char display width (Bug#9496).
979 * character.c (char_width): Return EMACS_INT, not int.
980 (char_width, c_string_width): Check for overflow when
981 computing the width; this is possible now that individual
982 characters can have unbounded width. Problem introduced
983 by merge from Emacs 23 on 2012-01-19.
984
985 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
986
987 * dbusbind.c (Fdbus_register_method): Mention the return value
988 :ignore in the docstring.
989
990 2012-02-02 Glenn Morris <rgm@gnu.org>
991
992 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
993
994 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
995 Unconditionally set to t. (Bug#10673)
996 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
997 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
998 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
999
1000 2012-02-02 Kenichi Handa <handa@m17n.org>
1001
1002 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
1003 0, do not call append_composite_glyph.
1004
1005 2012-02-02 Kenichi Handa <handa@m17n.org>
1006
1007 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
1008 NULL (Bug#6988).
1009 (x_produce_glyphs): If the component of a composition is a null
1010 string, set it->pixel_width to 1 to avoid zero-width glyph.
1011
1012 2012-02-01 Eli Zaretskii <eliz@gnu.org>
1013
1014 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1015 first 2 arguments are identical. This makes inserting large
1016 output from a subprocess an order of magnitude faster on
1017 MS-Windows, where all sbrk'ed memory is always contiguous.
1018
1019 2012-01-31 Glenn Morris <rgm@gnu.org>
1020
1021 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1022 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1023 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1024
1025 2012-01-29 Glenn Morris <rgm@gnu.org>
1026
1027 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1028
1029 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1030
1031 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1032
1033 2012-01-28 Chong Yidong <cyd@gnu.org>
1034
1035 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1036
1037 2012-01-26 Chong Yidong <cyd@gnu.org>
1038
1039 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1040
1041 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1042 repeat counts (Bug#10507).
1043
1044 2012-01-26 Glenn Morris <rgm@gnu.org>
1045
1046 * lread.c (syms_of_lread): Doc fix.
1047
1048 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1049
1050 * coding.c (encode_designation_at_bol): Change return value to
1051 EMACS_INT.
1052
1053 2012-01-25 Chong Yidong <cyd@gnu.org>
1054
1055 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1056
1057 2012-01-21 Chong Yidong <cyd@gnu.org>
1058
1059 * floatfns.c (Fcopysign): Make the second argument non-optional,
1060 since nil is not allowed anyway.
1061
1062 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1063
1064 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1065 (send_process): Likewise.
1066
1067 2012-01-19 Martin Rudalics <rudalics@gmx.at>
1068
1069 * window.c (save_window_save, Fcurrent_window_configuration)
1070 (Vwindow_persistent_parameters): Do not use Qstate.
1071 Rewrite doc-strings.
1072
1073 2012-01-19 Kenichi Handa <handa@m17n.org>
1074
1075 * character.c (char_width): New function.
1076 (Fchar_width, c_string_width, lisp_string_width):
1077 Use char_width (Bug#9496).
1078
1079 2012-01-16 Martin Rudalics <rudalics@gmx.at>
1080
1081 * window.c (Vwindow_persistent_parameters): New variable.
1082 (Fset_window_configuration, save_window_save): Handle persistent
1083 window parameters.
1084
1085 2012-01-14 Eli Zaretskii <eliz@gnu.org>
1086
1087 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1088 thrashing the stack of the thread. (Bug#9087)
1089
1090 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1091
1092 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1093
1094 2012-01-11 Eli Zaretskii <eliz@gnu.org>
1095
1096 * xdisp.c (rows_from_pos_range): Handle the case where the
1097 highlight ends on a newline. (Bug#10464)
1098 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1099 he end column for display of highlight that ends on a newline
1100 before a R2L line.
1101
1102 2012-01-11 Glenn Morris <rgm@gnu.org>
1103
1104 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1105 from load-path also when installation-directory is nil. (Bug#10208)
1106
1107 2012-01-10 Glenn Morris <rgm@gnu.org>
1108
1109 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1110
1111 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1112 Update template values to be closer to their typical values these days.
1113
1114 2012-01-09 Eli Zaretskii <eliz@gnu.org>
1115
1116 * xdisp.c (rows_from_pos_range): Accept additional argument
1117 DISP_STRING, and accept any glyph in a row whose object is that
1118 string as eligible for mouse highlight. Fixes mouse highlight of
1119 display strings from overlays. (Bug#10464)
1120
1121 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
1122
1123 emacs: fix an auto-save permissions race condition (Bug#10400)
1124 * fileio.c (auto_saving_dir_umask): New static var.
1125 (Fmake_directory_internal): Use it.
1126 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1127 creating the directory. The old code temporarily assigns
1128 too-generous permissions to the directory.
1129 (do_auto_save_eh): Clear it.
1130 (Fdo_auto_save): Catch all errors, not just file errors, so
1131 that the var is always cleared.
1132
1133 2012-01-07 Eli Zaretskii <eliz@gnu.org>
1134
1135 * search.c (scan_buffer): Pass character positions to
1136 know_region_cache, not byte positions. (Bug#6540)
1137
1138 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
1139
1140 * w32.c (sys_rename): Report EXDEV when rename of a directory
1141 fails because the target is on another logical disk. (Bug#10284)
1142
1143 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1144
1145 * xterm.c (x_embed_request_focus): New function.
1146
1147 * xterm.h: Add prototype.
1148
1149 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1150
1151 2012-01-05 Glenn Morris <rgm@gnu.org>
1152
1153 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1154
1155 2012-01-01 Eli Zaretskii <eliz@gnu.org>
1156
1157 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1158 Load gnutls_transport_set_lowat only if GnuTLS version is below
1159 2.11.1.
1160 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1161 GnuTLS versions below 2.11.1.
1162
1163 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1164
1165 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1166 to the doc string advising against its use for altering the way
1167 windows are scrolled.
1168
1169 2011-12-28 Kenichi Handa <handa@m17n.org>
1170
1171 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1172 coding-system ASCII compatible only when it does not produce BOM
1173 on encoding (Bug#10383).
1174
1175 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1176
1177 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1178 can scroll.
1179 (create_and_show_popup_menu): Always use menu_position_func for
1180 Gtk3 (Bug#10361).
1181
1182 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1183
1184 * callint.c (Fcall_interactively): Don't truncate prompt string.
1185
1186 2011-12-23 Eli Zaretskii <eliz@gnu.org>
1187
1188 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1189 property that ends at ZV, so that the bidi iteration could be
1190 resumed from there (after widening). (Bug#10360)
1191
1192 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1193
1194 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1195
1196 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1197
1198 * nsterm.m (x_free_frame_resources):
1199 Release f->output_data.ns->miniimage.
1200 (ns_index_color): Fix indentation. Do not retain
1201 color_table->colors[i].
1202
1203 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1204 before returning.
1205
1206 * nsfns.m (x_set_background_color): Assign return value from
1207 ns_index_color to face-background instead of NSColor*.
1208 (ns_implicitly_set_icon_type): Fix indentation.
1209 Change assignment in for loop to comparison.
1210
1211 * emacs.c (ns_pool): New variable.
1212 (main): Assign ns_pool.
1213 (Fkill_emacs): Call ns_release_autorelease_pool.
1214
1215 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1216 autorelease fdesc, release fdAttrs and tdict.
1217 (ns_get_covering_families): Release charset.
1218 (ns_findfonts): Release NSFontDescriptor created with new.
1219 (ns_uni_to_glyphs): Fix indentation.
1220 (setString): Release attrStr before assigning new value.
1221
1222 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1223
1224 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1225 and NS_IMPL_COCOA.
1226 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1227 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1228
1229 2011-12-18 David Reitter <reitter@cmu.edu>
1230
1231 * nsterm.m (ns_term_init): Subscribe for notifications
1232 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1233 to method trackingNotification in EmacsMenu.
1234
1235 * nsmenu.m (trackingMenu): New variable.
1236 (trackingNotification): New method (from Aquamacs).
1237 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1238 from Aquamacs (Bug#7030).
1239
1240 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1241
1242 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1243 (symbol_to_nsstring): Fix indentation.
1244 (ns_symbol_to_pb): New function.
1245 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1246 (Fns_rotate_cut_buffers_internal): Remove.
1247 (Fns_store_selection_internal): Rename from
1248 Fns_store_cut_buffer_internal.
1249 (ns_get_foreign_selection, Fx_own_selection_internal)
1250 (Fx_disown_selection_internal, Fx_selection_exists_p)
1251 (Fns_get_selection_internal, Fns_store_selection_internal):
1252 Use ns_symbol_to_pb and check if return value is nil.
1253 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1254 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1255 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1256 renamed to Sns_store_selection_internal.
1257 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1258 and remove this function.
1259 (ns_handle_selection_clear): Remove, never used.
1260 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1261 here.
1262
1263 2011-12-17 Ken Brown <kbrown@cornell.edu>
1264
1265 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1266 GID is unknown (Bug#10257).
1267
1268 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1269
1270 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1271 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1272 which caused a build failure on GNU/Linux IA-64. This problem was
1273 introduced by my 2011-10-07 patch.
1274
1275 2011-12-15 Juri Linkov <juri@jurta.org>
1276
1277 * image.c (imagemagick_error): New function. (Bug#10112)
1278 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1279 Use `imagemagick_error' where ImageMagick functions return
1280 `MagickFalse'.
1281 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1282 proper order.
1283
1284 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1285
1286 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1287 fill background (Bug#8992).
1288
1289 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1290
1291 * window.c (Vwindow_combination_resize)
1292 (Vwindow_combination_limit): Use t instead of non-nil in
1293 doc-strings.
1294 (Vrecenter_redisplay): Add first sentence of doc-string on
1295 separate line.
1296 (Frecenter): Fix doc-string typo.
1297
1298 2011-12-11 Kenichi Handa <handa@m17n.org>
1299
1300 * coding.c (Funencodable_char_position): Pay attention to the
1301 buffer text relocation (Bug#9389).
1302
1303 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1304
1305 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1306 gtk_init (Bug#10100).
1307
1308 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1309
1310 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1311 IT->string is nil. (Bug#10263)
1312
1313 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1314
1315 * nsterm.h (x_free_frame_resources): Declare.
1316
1317 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1318 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1319
1320 * nsterm.h (ns_get_defaults_value): Declare.
1321
1322 * nsterm.m (ns_default): Call ns_get_defaults_value.
1323
1324 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1325
1326 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1327 (Bug#10170)
1328
1329 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1330
1331 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1332 that where the value of an _OBJC_* symbol points to is in the .bss
1333 section (Bug#10240).
1334
1335 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1336
1337 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1338 after the loop to call ccl_driver at least once (Bug#8619).
1339
1340 2011-12-08 Kenichi Handa <handa@m17n.org>
1341
1342 * ftfont.c (get_adstyle_property): Fix previous change
1343 (Bug#10233).
1344
1345 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1346
1347 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1348 dirs from the default value of EMACSLOADPATH (bug#10208).
1349
1350 2011-12-07 Glenn Morris <rgm@gnu.org>
1351
1352 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1353 installation and source directories as well. (Bug#10208)
1354
1355 2011-12-06 Chong Yidong <cyd@gnu.org>
1356
1357 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1358
1359 2011-12-06 Glenn Morris <rgm@gnu.org>
1360
1361 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1362 as an error, not just -1. (Bug#10217)
1363
1364 2011-12-05 Chong Yidong <cyd@gnu.org>
1365
1366 * keyboard.c (process_special_events): New function.
1367 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1368
1369 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1370
1371 * coding.c (encode_designation_at_bol): Don't use uninitialized
1372 local variable (Bug#9318).
1373
1374 2011-12-05 Kenichi Handa <handa@m17n.org>
1375
1376 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1377 return Qnil (Bug#8046, Bug#10193).
1378
1379 2011-12-05 Kenichi Handa <handa@m17n.org>
1380
1381 * coding.c (encode_designation_at_bol): New args charbuf_end and
1382 dst. Return the number of produced bytes. Callers changed.
1383 (coding_set_source): Return how many bytes coding->source was
1384 relocated.
1385 (coding_set_destination): Return how many bytes
1386 coding->destination was relocated.
1387 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1388 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1389
1390 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1391
1392 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1393 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1394 macro (Bug#9318).
1395
1396 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1397
1398 The following changes are to fix Bug#9318.
1399
1400 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1401 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1402 (encode_coding_iso_2022, encode_coding_sjis)
1403 (encode_coding_big5, encode_coding_charset): Use the above macros.
1404
1405 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1406
1407 * lisp.h (process_quit_flag): Fix external declaration.
1408
1409 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1410
1411 Don't macro-inline non-performance-critical code.
1412 * eval.c (process_quit_flag): New function.
1413 * lisp.h (QUIT): Use it.
1414
1415 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1416
1417 * nsfns.m (get_geometry_from_preferences): New function.
1418 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1419
1420 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1421
1422 * emacs.c (Qkill_emacs): Define.
1423 (syms_of_emacs): Initialize it.
1424 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1425 Qquit_flag to `kill-emacs' instead.
1426 (quit_throw_to_read_char): Add parameter `from_signal'.
1427 All callers changed. Call Fkill_emacs if requested and safe.
1428 * lisp.h (QUIT): Call Fkill_emacs if requested.
1429
1430 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1431
1432 * widget.c (update_wm_hints): Return if wmshell is null.
1433 (widget_update_wm_size_hints): New function.
1434
1435 * widget.h (widget_update_wm_size_hints): Declare.
1436
1437 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1438 widget_update_wm_size_hints (Bug#10104).
1439
1440 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1441
1442 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1443 before a newline, prepare the bidi iterator for consuming the
1444 newline, and keep the current paragraph direction. (Bug#10183)
1445 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1446
1447 2011-12-02 Juri Linkov <juri@jurta.org>
1448
1449 * search.c (Fword_search_regexp): New Lisp function created from
1450 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1451 (Fword_search_backward, Fword_search_forward)
1452 (Fword_search_backward_lax, Fword_search_forward_lax):
1453 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1454 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1455
1456 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1457
1458 * fileio.c (Finsert_file_contents): Move after-change-function call
1459 to before the "handled:" label, since all "goto handled" appear in
1460 cases where the *-change-functions have already been properly called
1461 (bug#10117).
1462
1463 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1464
1465 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1466 waiting for input. (Bug#10169)
1467
1468 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1469
1470 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1471 verifies glyph row's hash code--we have just reallocated the
1472 glyphs, so their contents can be complete garbage. (Bug#10164)
1473
1474 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1475
1476 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1477
1478 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1479
1480 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1481 attributes are tested _before_ calling verify_row_hash, to protect
1482 against GCC re-ordering of the tests. (Bug#10164)
1483
1484 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1485
1486 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1487
1488 * xterm.c (handle_one_xevent): Only set async_visible and friends
1489 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1490 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1491 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1492
1493 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1494
1495 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1496 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1497 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1498 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1499 All uses changed to use GCPRO1 etc.
1500 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1501 Revert to old implementation (i.e., before 2011-03-11).
1502
1503 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1504
1505 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1506 of scroll runs so as to avoid assigning disabled bogus rows and
1507 unnecessary graphics copy operations.
1508
1509 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1510
1511 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1512 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1513 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1514 (malloc, free, realloc, calloc): Redirect to e_* only when
1515 compiling Emacs.
1516
1517 * lisp.h (GCTYPEBITS): Move before first use.
1518 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1519 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1520 this macro definition.
1521
1522 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1523 _MSC_VER.
1524
1525 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1526
1527 * gtkutil.c (xg_create_frame_widgets):
1528 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1529 present with Gtk+ 2.0.
1530
1531 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1532
1533 * fileio.c (Finsert_file_contents): Undo previous change; see
1534 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1535
1536 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1537
1538 Rename locals to avoid shadowing.
1539 * fileio.c (Finsert_file_contents):
1540 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1541 * process.c (wait_reading_process_output):
1542 Rename inner 'proc' to 'p' to avoid shadowing.
1543 Indent for consistency with usual Emacs style.
1544
1545 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1546
1547 * xdisp.c (redisplay_window): If cursor row is not fully visible
1548 after recentering, and scroll-conservatively is set to a large
1549 number, scroll window by a few more lines to make the cursor fully
1550 visible and out of scroll-margin. (Bug#10105)
1551 (start_display): Don't move to the next line if the display should
1552 start at a newline that is part of a display vector or an overlay
1553 string. (Bug#10119)
1554
1555 2011-11-24 Juri Linkov <juri@jurta.org>
1556
1557 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1558 after the `MagickPingImage' call. (Bug#10112)
1559
1560 2011-11-23 Chong Yidong <cyd@gnu.org>
1561
1562 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1563
1564 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1565
1566 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1567 making another buffer current. (Bug#10114)
1568
1569 2011-11-23 Glenn Morris <rgm@gnu.org>
1570
1571 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1572
1573 2011-11-23 Chong Yidong <cyd@gnu.org>
1574
1575 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1576 using it (Bug#5984).
1577
1578 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1579
1580 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1581 and header-lines, as they don't have one computed for them.
1582 (Bug#10098)
1583
1584 * .gdbinit (prow): Make displayed values more self-explaining.
1585 Add row's hash code.
1586
1587 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1588
1589 * process.c (wait_reading_process_output): Fix asynchrounous
1590 GnuTLS socket handling on some versions of the GnuTLS library.
1591 (wait_reading_process_output): Add comment and URL.
1592
1593 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1594
1595 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1596
1597 2011-11-21 Chong Yidong <cyd@gnu.org>
1598
1599 * window.c (Fnext_window, Fprevious_window): Doc fix.
1600
1601 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1602
1603 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1604
1605 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1606
1607 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1608
1609 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1610
1611 * window.c (Fset_window_combination_limit): Rename argument
1612 STATUS to LIMIT.
1613 (Vwindow_combination_limit): Remove "status" from doc-string.
1614
1615 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1616
1617 * m/ibms390.h: Remove.
1618 * m/ibms390x.h: Don't include "ibms390.h".
1619
1620 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1621
1622 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1623 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1624
1625 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1626
1627 * casetab.c (Fset_case_table):
1628 * charset.c (Fcharset_after): Fix typos.
1629
1630 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1631
1632 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1633 Otherwise, valgrind does not work on some platforms.
1634 Problem reported by Andreas Schwab in
1635 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1636 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1637 is set, removing the need for VIRT_ADDRESS_VARIES.
1638 (PURE_P): Use a more-efficient implementation that needs just one
1639 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1640 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1641 to 4 (xorl, subq, cmpq, setbe).
1642 * alloc.c (pure): Always extern now, since that's the
1643 VIRT_ADDR_VARIES behavior.
1644 (PURE_POINTER_P): Use a single comparison, not two, for
1645 consistency with the new puresize.h.
1646 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1647 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1648 Remove VIRT_ADDR_VARIES no longer needed.
1649
1650 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1651
1652 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1653 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1654 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1655 behave as if the cursor position were at the window margin.
1656
1657 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1658 and the cursor position is out of bounds, behave as if the cursor
1659 position were at the window margin. (Bug#10075)
1660
1661 2011-11-18 Chong Yidong <cyd@gnu.org>
1662
1663 * window.c (Fwindow_combination_limit): Make first argument
1664 non-optional, since it is meaningless for live windows like the
1665 selected window.
1666
1667 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1668
1669 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1670
1671 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1672
1673 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1674 (graft_intervals_into_buffer): Simplify.
1675
1676 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1677
1678 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1679 hash values of the two rows.
1680 (copy_row_except_pointers): Preserve the used[] arrays and the
1681 hash values of the two rows. (Bug#10035)
1682 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1683
1684 * xdisp.c (row_hash): New function, body extracted from
1685 compute_line_metrics.
1686 (compute_line_metrics): Call row_hash, instead of computing the
1687 hash code inline.
1688
1689 * dispnew.c (verify_row_hash): Call row_hash for computing the
1690 hash code of a row, instead of duplicating code from xdisp.c.
1691
1692 * dispextern.h (row_hash): Add prototype.
1693
1694 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1695
1696 * frame.c (delete_frame): Don't delete the terminal when the last
1697 X frame is closed if emacs is built with GTK toolkit.
1698
1699 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1700
1701 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1702
1703 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1704
1705 * window.c (Vwindow_splits): Rename to
1706 Vwindow_combination_resize. Suggested by Juri Linkov.
1707 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1708 of Vwindow_splits.
1709
1710 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1711
1712 * nsfns.m (Fns_font_name):
1713 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1714
1715 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1716
1717 * window.h (window): Rename slot "nest" to "combination_limit".
1718 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1719 (Fset_window_nest): Rename to Fset_window_combination_limit.
1720 (Vwindow_nest): Rename to Vwindow_combination_limit.
1721 (recombine_windows, make_parent_window, make_window)
1722 (Fsplit_window_internal, saved_window)
1723 (Fset_window_configuration, save_window_save): Rename all
1724 occurrences of window_nest to window_combination_limit.
1725
1726 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1727
1728 * image.c (imagemagick_load_image): Fix typo.
1729
1730 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1731
1732 * xdisp.c (display_line): Move the call to
1733 highlight_trailing_whitespace before the call to
1734 compute_line_metrics, since the latter needs to see the final
1735 faces of all the glyphs to compute ROW's hash value.
1736 Fixes assertion violations in row_equal_p. (Bug#10035)
1737
1738 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1739
1740 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1741 just return (bug#10044).
1742
1743 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1744
1745 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1746 with user-defined heap size. Bump the default size of the temacs
1747 heap to 27MB, to avoid memory warning when running temacs.
1748 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1749
1750 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1751 current_matrix and desired_matrix. (Bug#9990)
1752 (verify_row_hash) [XASSERTS]: New function.
1753 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1754 that the hash value of glyph rows is correct.
1755
1756 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1757
1758 * window.h (window): Remove splits slot.
1759 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1760 (Fdelete_other_windows_internal, make_parent_window)
1761 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1762 (Fset_window_configuration, save_window_save): Don't deal with
1763 split status of windows.
1764 (saved_window): Remove splits slot.
1765 (Vwindow_splits): Rewrite doc-string.
1766
1767 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1768
1769 * xfns.c (unwind_create_frame):
1770 * nsfns.m (unwind_create_frame):
1771 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1772 Vframe_list (Bug#9999).
1773
1774 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1775
1776 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1777
1778 2011-11-11 Kenichi Handa <handa@m17n.org>
1779
1780 * callproc.c (Fcall_process): Set the member dst_multibyte of
1781 process_coding.
1782
1783 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1784
1785 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1786 avoid a crash (bug#9496).
1787
1788 2011-11-09 Chong Yidong <cyd@gnu.org>
1789
1790 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1791 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1792
1793 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1794
1795 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1796
1797 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1798
1799 Avoid some portability problems by eschewing 'extern inline' functions.
1800 The trivial performance wins aren't worth the portability hassles; see
1801 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1802 et seq.
1803 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1804 (window_box_width, window_box_left, window_box_left_offset)
1805 (window_box_right, window_box_right_offset): Undo previous change,
1806 by removing the "extern"s.
1807 * intervals.c (adjust_intervals_for_insertion)
1808 (adjust_intervals_for_deletion): Undo previous change,
1809 making these static again.
1810 (offset_intervals, temp_set_point_both, temp_set_point)
1811 (copy_intervals_to_string): No longer inline.
1812 * xdisp.c (window_text_bottom_y, window_box_width)
1813 (window_box_height, window_box_left_offset)
1814 (window_box_right_offset, window_box_left, window_box_right)
1815 (window_box): No longer inline.
1816
1817 2011-11-08 Chong Yidong <cyd@gnu.org>
1818
1819 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1820 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1821 Signal an error if not a live window.
1822 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1823 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1824
1825 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1826
1827 * lisp.h (syms_of_abbrev): Remove declaration.
1828 Reported by CHENG Gao <chenggao@royau.me>.
1829
1830 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1831
1832 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1833 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1834 of temacs in GUI mode.
1835
1836 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1837
1838 * window.h: Declare delete_all_child_windows instead of
1839 delete_all_subwindows.
1840 * window.c (Fwindow_nest, Fset_window_nest)
1841 (Fset_window_new_total, Fset_window_new_normal)
1842 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1843 (delete_all_subwindows): Rename to delete_all_child_windows.
1844 (Fdelete_other_windows_internal, Fset_window_configuration):
1845 Call delete_all_child_windows instead of delete_all_subwindows.
1846 * frame.c (delete_frame): Call delete_all_child_windows instead
1847 of delete_all_subwindows.
1848
1849 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1850
1851 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1852 This is also needed for porting to any host where GC_MARK_STACK is
1853 not GC_MAKE_GCPROS_NOOPS.
1854 (which_symbols): Use it.
1855
1856 2011-11-07 Kenichi Handa <handa@m17n.org>
1857
1858 * coding.c (coding_set_destination): Check coding->src_pos only
1859 when coding->src_object is a buffer (bug#9910).
1860
1861 * process.c (send_process): Set the member src_multibyte of coding
1862 to 0 (bug#9911) when sending a unibyte text.
1863
1864 * callproc.c (Fcall_process): Set the member src_multibyte of
1865 process_coding to 0 (bug#9912).
1866
1867 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1868
1869 * xmenu.c (cleanup_widget_value_tree): New function.
1870 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1871 calling free_menubar_widget_value_tree directly (Bug#9830).
1872
1873 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1874
1875 Fix some portability problems with 'inline'.
1876 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1877 (window_box_width, window_box_left, window_box_left_offset)
1878 (window_box_right, window_box_right_offset): Declare extern.
1879 Otherwise, these inline functions do not conform to C99 and
1880 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1881 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1882 * intervals.c (adjust_intervals_for_insertion)
1883 (adjust_intervals_for_deletion): Now extern, because otherwise the
1884 extern inline functions 'offset_intervals' couldn't refer to it.
1885 (static_offset_intervals): Remove.
1886 (offset_intervals): Rewrite using the old contents of
1887 static_offset_intervals. The old version didn't conform to C99
1888 because an extern inline function contained a reference to an
1889 identifier with static linkage.
1890
1891 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1892
1893 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1894 GC.
1895
1896 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1897
1898 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1899 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1900 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1901 return Qleft_to_right.
1902
1903 2011-11-06 Chong Yidong <cyd@gnu.org>
1904
1905 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1906 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1907 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1908 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1909 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1910 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1911 (Fwindow_vscroll): Doc fix.
1912 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1913 argument, since it makes no sense to pass a live window and for
1914 consistency with window-child.
1915
1916 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1917
1918 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1919 support MSVC.
1920
1921 2011-11-05 Jason Rumney <jasonr@gnu.org>
1922
1923 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1924 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1925 fonts (Bug#6029).
1926 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1927 bitwise arithmetic preventing use of unicode-sip and non-truetype
1928 opentype fonts.
1929
1930 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1931
1932 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1933 "emacs"-only part.
1934
1935 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1936 initialization code to keep similarity to xfns.c after changes
1937 from 2011-11-05.
1938
1939 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1940
1941 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1942 (unwind_create_frame): New function (Bug#9943).
1943 (Fx_create_frame): Restructure code to be more similar to the one in
1944 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1945 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1946 Move terminal->reference_count++ just before making the frame official
1947 (Bug#9943).
1948
1949 * nsterm.m (x_free_frame_resources): New function.
1950 (x_destroy_window): Move code to x_free_frame_resources.
1951
1952 * xfns.c (unwind_create_frame): Fix comment.
1953 (Fx_create_frame, x_create_tip_frame):
1954 Move terminal->reference_count++ just before making the frame
1955 official. Move initialization of image_cache_refcount and
1956 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1957
1958 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1959
1960 Support MSVC build with newer versions of Visual Studio.
1961 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1962 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1963 nt/gmake.defs.
1964
1965 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1966 which are not supported by MSVC.
1967 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1968 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1969 bitfields.
1970 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1971 types in bitfields.
1972 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1973
1974 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1975
1976 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1977
1978 Support MSVC build with newer versions of Visual Studio.
1979 * w32.c: Don't include w32api.h for MSVC.
1980 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1981
1982 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1983 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1984 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1985 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1986 e_* cousins.
1987 (alloca) [_MSC_VER]: Define to _alloca.
1988
1989 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1990
1991 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1992
1993 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1994
1995 * xdisp.c (note_mouse_highlight): If either of
1996 previous/next-single-property-change returns nil, treat that as
1997 the beginning or the end of the buffer. (Bug#9955)
1998
1999 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
2000
2001 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
2002 label is not null (Bug#9951).
2003 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
2004 may be NULL.
2005
2006 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2007
2008 * window.c (Fwindow_body_size): Mention in the doc string that the
2009 return value is in frame's canonical units. (Bug#9949)
2010
2011 2011-11-03 Eli Zaretskii <eliz@gnu.org>
2012
2013 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2014
2015 * w32fns.c (unwind_create_frame): If needed, free the glyph
2016 matrices of the partially constructed frame. (Bug#9943)
2017 * xfns.c (unwind_create_frame): Likewise.
2018
2019 2011-11-01 Eli Zaretskii <eliz@gnu.org>
2020
2021 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2022 Don't stop backward scan on the continuation glyph, even though
2023 its CHARPOS is positive.
2024 (mouse_face_from_buffer_pos, note_mouse_highlight):
2025 Rename cover_string to disp_string.
2026
2027 2011-11-01 Martin Rudalics <rudalics@gmx.at>
2028
2029 * window.c (temp_output_buffer_show): Don't use
2030 Vtemp_buffer_show_specifiers.
2031 (Vtemp_buffer_show_specifiers): Remove unused variable.
2032
2033 2011-10-30 Eli Zaretskii <eliz@gnu.org>
2034
2035 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2036 past the beginning of the current glyph matrix.
2037
2038 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
2039
2040 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2041 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2042 HAVE_GTK3 (Bug#9869).
2043
2044 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2045 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2046
2047 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2048
2049 * xterm.c: Declare x_handle_net_wm_state to return int.
2050 (handle_one_xevent): Check if we are iconified but don't have
2051 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2052 (get_current_wm_state): Return non-zero if not hidden,
2053 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2054 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2055 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2056 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2057
2058 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2059
2060 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2061 so that this new function doesn't get optimized away by a
2062 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2063
2064 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2065
2066 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2067
2068 2011-10-29 Eli Zaretskii <eliz@gnu.org>
2069
2070 Fix the `xbytecode' command.
2071 * .gdbinit (xprintbytestr): New command.
2072 (xwhichsymbols): Rename from `which'; all callers changed.
2073 (xbytecode): Print the byte-code string as well.
2074
2075 2011-10-29 Kim Storm <storm@cua.dk>
2076
2077 * alloc.c (which_symbols): New function.
2078
2079 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2080
2081 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2082 line. (Bug#9903)
2083
2084 2011-10-29 Glenn Morris <rgm@gnu.org>
2085
2086 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2087 Not clear what it was for, and it causes various bugs. (Bug#9839)
2088
2089 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2090
2091 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2092 possible random value that matches one of those tested as
2093 condition to clear the mouse face.
2094
2095 2011-10-28 Chong Yidong <cyd@gnu.org>
2096
2097 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2098
2099 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2100
2101 * window.c (make_window): Initialize phys_cursor_on_p.
2102
2103 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2104
2105 * lisp.h (struct Lisp_Symbol): Update comments.
2106
2107 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
2108
2109 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2110
2111 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2112
2113 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2114 <oslsachem@gmail.com> for helping to debug this.
2115
2116 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2117 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2118 (g_b_init_get_glyph_outline_w): New static variables.
2119 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2120 (GetGlyphOutlineW_Proc): New typedefs.
2121 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
2122 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2123 New functions.
2124 (w32font_open_internal, compute_metrics):
2125 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
2126 instead of calling the "wide" APIs directly.
2127
2128 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2129
2130 * w32.h (syms_of_w32font): Add prototype.
2131
2132 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2133
2134 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2135 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2136 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2137 (Fmove_to_window_line): Doc fix.
2138
2139 2011-10-27 Chong Yidong <cyd@gnu.org>
2140
2141 * process.c (make_process): Set gnutls_state to NULL.
2142
2143 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2144 non-NULL, regardless of GNUTLS_INITSTAGE.
2145 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2146 an error. Set process slots as soon as we allocate them.
2147
2148 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2149
2150 2011-10-27 Chong Yidong <cyd@gnu.org>
2151
2152 * gnutls.c (emacs_gnutls_deinit): New function.
2153 Deallocate credentials structures as well as calling gnutls_deinit.
2154 (Fgnutls_deinit, Fgnutls_boot): Use it.
2155
2156 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2157 (deactivate_process): Call emacs_gnutls_deinit.
2158
2159 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2160
2161 * image.c (x_create_x_image_and_pixmap):
2162 * w32.c (sys_rename, w32_delayed_load):
2163 * w32font.c (fill_in_logfont):
2164 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2165
2166 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
2167
2168 * w32fns.c (w32_default_color_map): New function,
2169 extracted from Fw32_default_color_map.
2170 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
2171
2172 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2173
2174 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2175
2176 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2177
2178 * keyboard.c (test_undefined): New function (bug#9751).
2179 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2180
2181 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2182
2183 * sysdep.c (init_sys_modes): Fix the check for the controlling
2184 terminal (Bug#6649).
2185
2186 2011-10-20 Eli Zaretskii <eliz@gnu.org>
2187
2188 * dispextern.h (struct bidi_it): New member next_en_type.
2189
2190 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2191 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2192 current character, check also for next_en_type being WEAK_EN.
2193 (bidi_resolve_weak): Don't enter the expensive loop if the current
2194 position is before next_en_pos. Record the bidi type of the first
2195 non-ET, non-BN character we find, in addition to its position.
2196 (bidi_level_of_next_char): Invalidate next_en_type when
2197 next_en_pos is over-stepped.
2198
2199 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2200
2201 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2202 * editfns.c: Rewrite current-time-zone so that it invokes
2203 the equivalent of (format-time-string "%Z") to get the time zone name.
2204 This fixes a bug when the time zone name contains characters that
2205 need converting from the system time locale to Emacs internal format.
2206 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2207 that patch fixed format-time-string to do the conversion, but
2208 I forgot to fix current-time-zone.
2209 (format_time_string): New function, containing most of
2210 what Fformat_time_string used to contain.
2211 (Fformat_time_string): Rewrite in terms of format_time_string.
2212 This doesn't change this function's behavior.
2213 (current-time-zone): Rewrite to use format_time_string.
2214 This fixes the bug reported by Michael Schierl in
2215 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2216 Jason Rumney's 2007-06-07 change worked around this bug, but
2217 didn't fix it.
2218 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2219
2220 2011-10-19 Eli Zaretskii <eliz@gnu.org>
2221
2222 * xdisp.c (start_display): If the character at POS is displayed
2223 via a display vector, reset IT->current.dpvec_index to zero.
2224 (try_window_reusing_current_matrix): If a line ends in a display
2225 vector or the next line starts in a display vector, continue
2226 redrawing the window even though the character position of
2227 start_row was reached.
2228 (Bug#9771, part 2)
2229
2230 2011-10-18 Chong Yidong <cyd@gnu.org>
2231
2232 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2233 with nobreak-char-display too.
2234
2235 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2236
2237 Fix part 3 of bug#9771.
2238 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2239 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2240 non-neutral characters if the current character is a paragraph
2241 separator (a.k.a. Newline). This avoids running the same
2242 expensive loop twice, once when we consume the preceding newline
2243 and the other time when the line actually needs to be displayed.
2244 Avoid the loop when we see neutrals on the base embedding level
2245 following a character whose directionality is the same as the
2246 paragraph's. This avoids running the expensive loop when a line
2247 ends in a long sequence of neutrals, like control characters.
2248 Add assertion against STRONG_AL type. Slightly rearrange code
2249 that determines the type of a neutral given the first non-neutral
2250 that follows it.
2251 (bidi_level_of_next_char): Set next_en_pos to zero when
2252 invalidating its info.
2253
2254 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2255
2256 * xdisp.c (push_display_prop): Determine whether to record string
2257 or buffer position by IT->string, not by IT->method. Allow
2258 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2259 (move_it_vertically_backward): Don't look for character position
2260 immediately after the newline when in a continuation line.
2261 (Bug#9771, part 1)
2262
2263 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2264
2265 * window.c (coordinates_in_window): Rewrite and delabelize
2266 vertical border check. (Bug#5357) (Bug#9618)
2267
2268 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2269
2270 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2271 errors in XSetWindowBorder (bug#9310).
2272
2273 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2274
2275 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2276 avoid crash when xmalloc overrun checking is enabled.
2277
2278 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2279
2280 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2281 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2282 cursor motion with <left> and <right> arrow keys.
2283
2284 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2285 some callers set that themselves.
2286
2287 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2288
2289 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2290 display string and the previous row comes from the same string and
2291 is empty. (Bug#9739) (Bug#9738)
2292
2293 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2294
2295 * doc.c (get_doc_string): Encode file name (bug#9735).
2296
2297 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2298
2299 * bidi.c (bidi_level_of_next_char):
2300 * xdisp.c (get_visually_first_element): Remove old incorrect
2301 comments regarding the Unicode Line Separator character.
2302
2303 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2304
2305 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2306
2307 * alloc.c (Fgc_status): Do not access beyond zombies array
2308 boundary if nzombies > MAX_ZOMBIES.
2309 * alloc.c (dump_zombies): Add missing format specifier.
2310
2311 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2312
2313 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2314 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2315
2316 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2317 Some packages use them to denote characters with modifiers.
2318
2319 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2320
2321 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2322 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2323 matching a pp-number. Rename parameter var to var1.
2324
2325 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2326
2327 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2328
2329 2011-10-08 Glenn Morris <rgm@gnu.org>
2330
2331 * callint.c (Fcall_interactively): Give a more explicit error for the
2332 'c' case with a non-character input. (Bug#8479)
2333
2334 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2335
2336 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2337 lines.
2338 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2339 lines that are hscrolled on the left.
2340
2341 * dispnew.c (buffer_posn_from_coords): Account for a possible
2342 presence of header-line. (Bug#4426)
2343
2344 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2345
2346 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2347 Don't advertise functionality which we discourage or doesn't work.
2348
2349 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2350
2351 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2352 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2353 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2354 this makes Emacs dump core during garbage collection on rare
2355 occasions. sizeof is obviously inferior to offsetof here, so
2356 stick with offsetof.
2357 (GC_POINTER_ALIGNMENT): New macro.
2358 (mark_memory): Omit 3rd (offset) arg; caller changed.
2359 Don't assume EMACS_INT alignment is the same as pointer alignment.
2360
2361 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2362
2363 * keyboard.c (read_key_sequence_remapped): New var.
2364 (read_key_sequence): Compute remapping in the right buffer.
2365 (command_loop_1): Use read_key_sequence's remapping directly.
2366
2367 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2368
2369 * dired.c (file_name_completion): Don't expand file name.
2370 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2371 before checking file name handler.
2372
2373 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2374 they've been requested explicitly (bug#9591).
2375
2376 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2377
2378 * keymap.c (Fsingle_key_description): Use make_specified_string
2379 instead of build_string to build string from push_key_description.
2380 (Bug#5193)
2381
2382 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2383
2384 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2385 This fixes a Y2038 bug on 64-bit hosts.
2386 * buffer.c (reset_buffer):
2387 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2388 (Fclear_buffer_auto_save_failure):
2389 Use 0, not -1, to represent an unset failure time, since time_t
2390 might not be signed.
2391
2392 Remove dependency on glibc malloc internals.
2393 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2394 Move back here from lisp.h, but with their new implementations.
2395 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2396 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2397 * charset.c (charset_table_init): New static var.
2398 (syms_of_charset): Use it instead of xmalloc. This removes a
2399 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2400 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2401 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2402 Move back to alloc.c.
2403 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2404 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2405
2406 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2407
2408 * nsterm.m (windowDidResize): Call x_set_window_size only when
2409 ns_in_resize is true. Otherwise set pixelwidth/height and
2410 call change_frame_size (Bug#9628).
2411
2412 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2413
2414 Port --enable-checking=all to Fedora 14 x86-64.
2415 * charset.c (syms_of_charset): Also account for glibc malloc's
2416 internal overhead when calculating the initial malloc maximum.
2417
2418 Port --enable-checking=all to Fedora 14 x86.
2419 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2420 Move to lisp.h.
2421 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2422 (overrun_check_realloc, overrun_check_free):
2423 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2424 That way, xmalloc returns a properly-aligned pointer even if
2425 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2426 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2427 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2428 into account when calculating the initial malloc maximum.
2429 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2430 Move here from alloc.c, so that charset.c can use it too.
2431 Properly align; the old code wasn't right for common 32-bit hosts
2432 when configured with --enable-checking=all.
2433 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2434 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2435
2436 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2437
2438 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2439 use EDOM.
2440
2441 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2442
2443 * xdisp.c (compute_display_string_end): If there's no display
2444 string at CHARPOS, return -1.
2445
2446 * bidi.c (bidi_fetch_char): When compute_display_string_end
2447 returns a negative value, treat the character as a normal
2448 character not covered by a display string. (Bug#9624)
2449
2450 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2451
2452 * lread.c (Fread_from_string): Fix typo in docstring.
2453
2454 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2455
2456 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2457 newline, reseat the iterator instead of bidi-iterating there one
2458 character at a time. (Bug#9610)
2459 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2460 TO_CHARPOS if the bidi iterator is at base embedding level.
2461
2462 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2463
2464 * lread.c (readevalloop): Use correct code for NBSP.
2465 (read1): Likewise. (Bug#9608)
2466
2467 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2468
2469 * dbusbind.c (Fdbus_register_signal): When service is not
2470 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2471
2472 2011-09-25 Glenn Morris <rgm@gnu.org>
2473
2474 * buffer.c (truncate-lines): Doc fix.
2475
2476 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2477
2478 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2479 (Fset_window_next_buffers): Doc fix.
2480
2481 2011-09-24 Glenn Morris <rgm@gnu.org>
2482
2483 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2484
2485 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2486
2487 Fix minor problems found by static checking.
2488 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2489 * indent.c (Fvertical_motion): Fix == vs = typo.
2490
2491 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2492
2493 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2494 Default value is now t. Doc fix.
2495
2496 * indent.c (Fvertical_motion): Compute and apply the overshoot
2497 logic when moving up, not only when moving down. Fix the
2498 confusing name and values of the it_overshoot_expected variable;
2499 logic changes accordingly. (Bug#9254) (Bug#9549)
2500
2501 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2502 CHARPOS is covered by a display string which includes newlines.
2503 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2504 is covered by a display string with embedded newlines.
2505
2506 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2507
2508 * dbusbind.c (Fdbus_register_signal): Add match rule to
2509 Vdbus_registered_objects_table. (Bug#9581)
2510 (Fdbus_register_method, Vdbus_registered_objects_table):
2511 Fix docstring.
2512
2513 2011-09-24 Jim Meyering <meyering@redhat.com>
2514
2515 do not ignore write error for any output size
2516 The previous change was incomplete.
2517 While it makes emacs --batch detect the vast majority of stdout
2518 write failures, errors were still ignored whenever the output size is
2519 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2520 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2521 && echo FAIL: ignored write error
2522 FAIL: ignored write error
2523 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2524 && echo FAIL: ignored write error
2525 FAIL: ignored write error
2526 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2527
2528 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2529
2530 * emacs.c (Fkill_emacs): In noninteractive mode exit
2531 non-successfully if a write error occurred on stdout. (Bug#9574)
2532
2533 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2534
2535 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2536 the xassert test.
2537
2538 * dispextern.h (struct it): Update the comment documenting what
2539 can it->OBJECT be.
2540
2541 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2542
2543 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2544 a display string, extend search for cursor position to end of row.
2545 (find_row_edges): If the row ends in a newline from a display
2546 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2547 Handle the case of a display string with multiple newlines.
2548 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2549 non-empty line. Fixes confusing cursor motion with arrow keys at
2550 the beginning of a line that starts with whitespace.
2551
2552 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2553
2554 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2555 (bug#9493).
2556
2557 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2558
2559 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2560 boolean (Bug#9154).
2561
2562 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2563
2564 * xdisp.c (display_line): Record maximum and minimum buffer
2565 positions even if no glyphs were produced (e.g., by a zero-width
2566 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2567 buffer positions that will be removed from the glyph row because
2568 they don't fit.
2569 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2570 column is beyond frame width: don't subtract 1 "pixel" when
2571 computing width of the stretch.
2572 (reseat_at_next_visible_line_start): Undo the change made on
2573 2011-09-17 that saved paragraph information and restored it after
2574 the call to `reseat'. (Bug#9545)
2575
2576 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2577
2578 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2579 and turn window cursor on if cleared (Bug#9415).
2580
2581 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2582
2583 * search.c (boyer_moore): Take unibyte characters from pattern
2584 literally. (Bug#9458)
2585
2586 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2587
2588 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2589
2590 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2591
2592 Fix minor problem found by static checking.
2593 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2594 initialized, to pacify gcc -Wuninitialized.
2595
2596 * fileio.c: Report proper errno when syscall falls.
2597 (Finsert_file_contents): Save and restore errno,
2598 so that report_file_error outputs the correct diagnostic.
2599 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2600
2601 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2602
2603 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2604
2605 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2606
2607 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2608 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2609
2610 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2611
2612 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2613 about the current paragraph and restore it after the call to reseat.
2614
2615 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2616 (bidi_find_paragraph_start): Search back for paragraph beginning
2617 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2618 (bidi_move_to_visually_next): Only trigger paragraph-related
2619 computations when the last character is a newline or at EOB, not
2620 just any NEUTRAL_B. (Bug#9470)
2621
2622 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2623 truncated lines if point is covered by a display string. (Bug#9524)
2624
2625 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2626
2627 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2628 (cons_to_x_long): New function.
2629 (lisp_data_to_selection_data): Use it. Correct the test for
2630 short-versus-long data; it was negated. Break out of vector
2631 loop, for efficiency, when a long datum is discovered.
2632
2633 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2634
2635 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2636
2637 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2638
2639 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2640 GCC PR/17406) by declaring this function with external scope.
2641
2642 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2643
2644 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2645 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2646
2647 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2648
2649 * editfns.c (Fformat): Correctly handle text properties on "%%".
2650
2651 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2652
2653 * xterm.c (x_draw_composite_glyph_string_foreground):
2654 * w32term.c (x_draw_composite_glyph_string_foreground):
2655 * term.c (encode_terminal_code):
2656 * composite.c (composition_update_it, get_composition_id):
2657 * xdisp.c (get_next_display_element)
2658 (fill_composite_glyph_string): Add comments about special meaning
2659 of TAB characters in a composition.
2660
2661 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2662
2663 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2664 This occurs when processing a multibyte format.
2665 Problem reported by Wolfgang Jenker.
2666
2667 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2668
2669 * xdisp.c (try_cursor_movement): Only check for exact match if
2670 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2671
2672 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2673
2674 Remove unused external symbols.
2675 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2676 * xdisp.c (calc_pixel_width_or_height): Now static.
2677 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2678 * indent.c (check_display_width):
2679 * w32term.c: Fix comment to match code.
2680 * xterm.c, xterm.h (x_catching_errors): Remove.
2681
2682 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2683
2684 * xselect.c: Use signed conversions more consistently (Bug#9498).
2685 (selection_data_to_lisp_data): Assume incoming selection data are
2686 signed integers, not unsigned. This is to be consistent with
2687 outgoing selection data, which was modified to use signed integers
2688 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2689 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2690 expects long, not unsigned long.
2691
2692 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2693
2694 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2695 computation of loop end. Reported by Johan Bockgård
2696 <bojohan@gnu.org>.
2697
2698 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2699
2700 * frame.c (Fother_visible_frames_p): Function deleted.
2701
2702 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2703
2704 * indent.c (compute_motion): Process display vector front to back
2705 rather than the other way around. (Bug#2496)
2706
2707 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2708
2709 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2710
2711 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2712
2713 * minibuf.c (Fread_from_minibuffer): Doc fix.
2714
2715 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2716
2717 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2718 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2719
2720 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2721
2722 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2723 value for non-existent files.
2724
2725 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2726
2727 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2728 set its "size" to -1. This will set the modtime_size field of
2729 the corresponding buffer to -1, which is what
2730 verify-visited-file-modtime expects for files that do not exist.
2731 (Bug#9139)
2732
2733 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2734
2735 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2736 here ...
2737 * lisp.h: ... from here. push_key_description is no longer
2738 defined in keyboard.c, so its declaration should not be in
2739 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2740 logically belongs with push_key_description.
2741
2742 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2743
2744 * buffer.h: Include <sys/types.h> instead of <time.h>.
2745 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2746 Problem reported by Herbert J. Skuhra.
2747
2748 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2749
2750 * xml.c (parse_region): Make the parsing work for
2751 non-comment-starting XML files again (bug#9144).
2752
2753 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2754
2755 * image.c (gif_load): Fix calculation of bottom and right corner.
2756 (Bug#9468)
2757
2758 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2759
2760 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2761 redisplay in small windows.
2762
2763 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2764
2765 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2766
2767 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2768
2769 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2770 Operate on live windows only.
2771
2772 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2773
2774 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2775
2776 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2777
2778 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2779 only under bidi iteration.
2780
2781 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2782
2783 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2784
2785 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2786
2787 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2788 Without this fix, the command to link temacs failed due to an
2789 undefined symbol __builtin_isnan. This is because
2790 /usr/include/iso/math_c99.h #defines isnan(x) to
2791 __builtin_isnan(x), but the bundled gcc, which identifies itself
2792 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2793 a __builtin_isnan.
2794 * floatfns.c (isnan): #undef, and then #define to a clone of
2795 what's in data.c.
2796 (Fisnan): Always define, since it's always available now.
2797 (syms_of_floatfns): Always define isnan at the Lisp level.
2798
2799 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2800
2801 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2802
2803 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2804
2805 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2806 The previous code assumed that file offsets (off_t values) fit in
2807 EMACS_INT variables, which is not true on typical 32-bit hosts.
2808 The code messed up by falsely reporting buffer overflow in cases
2809 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2810 when "big" contains more than 2**29 bytes, even though this
2811 inserts just one byte and does not overflow the buffer.
2812 (Finsert_file_contents): Store file offsets as off_t
2813 values, not as EMACS_INT values. Check for overflow when
2814 converting between EMACS_INT and off_t. When checking for
2815 buffer overflow or for overlap, take the offsets into account.
2816 Don't use EMACS_INT for small values where int suffices.
2817 When checking for overlap, fix a typo: ZV was used where
2818 ZV_BYTE was intended.
2819 (Fwrite_region): Don't assume off_t fits into 'long'.
2820 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2821
2822 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2823
2824 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2825
2826 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2827
2828 sprintf-related integer and memory overflow issues (Bug#9412).
2829
2830 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2831 (esprintf, exprintf, evxprintf): New functions.
2832 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2833 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2834 (modify_event_symbol): Do not assume that the length of
2835 name_alist_or_stem is safe to alloca and fits in int.
2836 (Fexecute_extended_command): Likewise for function name and binding.
2837 (Frecursion_depth): Wrap around reliably on integer overflow.
2838 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2839 since some callers pass EMACS_INT values.
2840 (Fsingle_key_description): Don't crash if symbol name contains more
2841 than MAX_ALLOCA bytes.
2842 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2843 (get_minibuffer): Arg is now EMACS_INT, not int.
2844 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2845 (esprintf, exprintf, evxprintf): New decls.
2846 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2847
2848 * dbusbind.c (signature_cat): New function.
2849 (xd_signature, Fdbus_register_signal):
2850 Do not overrun buffer; instead, report string overflow.
2851
2852 * dispnew.c (add_window_display_history): Don't overrun buffer.
2853 Truncate instead; this is OK since it's just a log.
2854
2855 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2856 even if the time zone offset is outlandishly large.
2857 Don't mishandle offset == INT_MIN.
2858
2859 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2860 when creating daemon; the previous buffer-overflow check was incorrect.
2861
2862 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2863 which has the guts of the old verror function.
2864
2865 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2866 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2867
2868 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2869 (font_unparse_xlfd): Don't blindly alloca long strings.
2870 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2871 fits in int, when using sprintf. Use single snprintf to count
2872 length of string rather than counting it via multiple sprintfs;
2873 that's simpler and more reliable.
2874 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2875 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2876 sprintf, in case result does not fit in int.
2877
2878 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2879 (fontset_from_font): Print it.
2880
2881 * frame.c (tty_frame_count): Now printmax_t, not int.
2882 (make_terminal_frame, set_term_frame_name): Print it.
2883 (x_report_frame_params): In X, window IDs are unsigned long,
2884 not signed long, so print them as unsigned.
2885 (validate_x_resource_name): Check for implausibly long names,
2886 and don't assume name length fits in 'int'.
2887 (x_get_resource_string): Don't blindly alloca invocation name;
2888 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2889 not fit in int.
2890
2891 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2892 (xg_check_special_colors, xg_set_geometry):
2893 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2894
2895 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2896 Use esprintf, not sprintf, in case result does not fit in int.
2897
2898 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2899 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2900 it as a large positive number.
2901 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2902 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2903
2904 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2905 in case result does not fit in int.
2906
2907 * print.c (float_to_string): Detect width overflow more reliably.
2908 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2909 buffer overrun. Don't assume list length fits in 'int'. Treat
2910 print length of 0 as 0, not as infinity; to be consistent with other
2911 uses of print length in this function. Don't overflow print length
2912 index. Don't assume hash table size fits in 'long', or that
2913 vectorlike size fits in 'unsigned long'.
2914
2915 * process.c (make_process): Use printmax_t, not int, to format
2916 process-name gensyms.
2917
2918 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2919
2920 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2921 to avoid potential buffer overrun.
2922
2923 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2924 if X resource line is longer than 512 bytes.
2925
2926 * xfns.c (x_window): Make sprintf buffer a bit bigger
2927 to avoid potential buffer overrun.
2928
2929 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2930
2931 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2932
2933 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2934
2935 Integer overflow fixes for scrolling, etc.
2936 Without these, Emacs silently mishandles large integers sometimes.
2937 For example, "C-u 4294967297 M-x recenter" was treated as if
2938 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2939
2940 * xdisp.c (try_window_id): Check Emacs fixnum range before
2941 converting to 'int'.
2942
2943 * window.c (window_scroll_line_based, Frecenter):
2944 Check that an Emacs fixnum is in range before assigning it to 'int'.
2945 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2946 values converted from Emacs fixnums.
2947 (Frecenter): Don't wrap around a line count if it is out of 'int'
2948 range; instead, treat it as an extreme value.
2949 (Fset_window_configuration, compare_window_configurations):
2950 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2951
2952 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2953 that can exceed INT_MAX. Check that EMACS_INT value is in range
2954 before assigning it to the (possibly-narrower) index.
2955 (match_limit): Don't assume that a fixnum can fit in 'int'.
2956
2957 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2958 exceed INT_MAX.
2959
2960 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2961 (Fvertical_motion): Don't wrap around LINES values that don't fit
2962 in 'int'. Instead, treat them as extreme values. This is good
2963 enough for windows, which can't have more than INT_MAX lines anyway.
2964
2965 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2966
2967 * Require libxml/parser.h to avoid compilation warning.
2968
2969 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2970
2971 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2972 since this reportedly can destroy thread storage.
2973
2974 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2975
2976 * syntax.c (find_defun_start): Update all cache variables if
2977 exiting early (Bug#9401).
2978
2979 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2980
2981 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2982
2983 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2984 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2985 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2986
2987 * term.c (tty_append_glyph): New function.
2988 (produce_stretch_glyph): Static function and its prototype deleted.
2989
2990 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2991 Add prototypes.
2992
2993 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2994
2995 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2996 when checking :margin (Bug#9390).
2997 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2998 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2999 so that the name doesn't mislead. All uses changed.
3000
3001 2011-08-28 Johan Bockgård <bojohan@gnu.org>
3002
3003 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
3004 set_tty_hooks.
3005
3006 2011-08-27 Eli Zaretskii <eliz@gnu.org>
3007
3008 * xdisp.c (move_it_to): Don't bail out early when reaching
3009 position beyond to_charpos, if we are scanning backwards.
3010 (move_it_vertically_backward): When DY == 0, make sure we get to
3011 the first character in the line after the newline.
3012
3013 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3014
3015 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3016 (ccl_driver): Do not generate an out-of-range pointer.
3017 (Fccl_execute_on_string): Remove unnecessary check for
3018 integer overflow, noted by Stefan Monnier in
3019 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3020 Remove a FIXME that didn't need fixing.
3021 Simplify the newly-introduced buffer reallocation code.
3022
3023 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
3024
3025 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3026
3027 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
3028
3029 Integer and memory overflow issues (Bug#9196).
3030
3031 * doc.c (get_doc_string): Rework so that
3032 get_doc_string_buffer_size is the actual buffer size, rather than
3033 being 1 less than the actual buffer size; this makes xpalloc more
3034 convenient.
3035
3036 * image.c (x_allocate_bitmap_record, cache_image):
3037 * xselect.c (Fx_register_dnd_atom):
3038 Simplify previous changes by using xpalloc.
3039
3040 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3041 since either will do and ptrdiff_t is convenient with xpalloc.
3042
3043 * charset.c (charset_table_size)
3044 (struct charset_sort_data.priority): Now ptrdiff_t.
3045 (charset_compare): Don't overflow if priorities differ greatly.
3046 (Fsort_charsets): Don't assume list length fits in int.
3047 Check for size-calculation overflow when allocating sort data.
3048 (syms_of_charset): Allocate an initial charset table that is
3049 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3050
3051 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3052
3053 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3054 The actual value is always <= INT_MAX, and leaving it unsigned made
3055 overflow checking harder.
3056
3057 * dispextern.h (struct glyph_matrix.rows_allocated)
3058 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3059 with xpalloc. The values are still always <= INT_MAX.
3060
3061 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3062
3063 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3064 (SAFE_NALLOCA): New macro.
3065
3066 * region-cache.c (struct boundary.pos, find_cache_boundary)
3067 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3068 (set_cache_region, invalidate_region_cache)
3069 (revalidate_region_cache, know_region_cache, region_cache_forward)
3070 (region_cache_backward, pp_cache):
3071 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3072 so that ptrdiff_t * can be passed to xpalloc.
3073 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3074 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3075 (pp_cache): Don't assume cache_len fits in int.
3076 * region-cache.h: Adjust extern decls to match.
3077
3078 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3079 EMACS_INT, since either will do, for xpalloc.
3080
3081 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3082 (xnmalloc, xnrealloc, xpalloc): New functions.
3083
3084 * bidi.c (bidi_shelve_header_size): New constant.
3085 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3086 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3087
3088 * bidi.c (bidi_cache_shrink):
3089 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3090 (overlay_strings):
3091 Don't update size of array until after memory allocation succeeds,
3092 because xmalloc/xrealloc may not return.
3093 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3094 now that we have proper integer overflow checking.
3095 (record_overlay_string, overlay_strings): Catch overflows when
3096 calculating size of overlay_str_buf.
3097
3098 * callproc.c (Fcall_process): Check for size overflow when
3099 calculating size of args2.
3100 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3101 Normally we prefer signed values, but sticking with ptrdiff_t would
3102 require adding more-complicated checks.
3103
3104 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3105 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3106 Redo buffer-overflow calculations to avoid integer overflow.
3107 Add a FIXME comment where memory seems to be over-allocated.
3108
3109 * character.c (Fstring): Check for size-calculation overflow.
3110
3111 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3112 unnecessary integer overflow. Check for size overflow.
3113 (encode_coding_object): Don't update size until xmalloc succeeds.
3114
3115 * composite.c (get_composition_id): Check for overflow in glyph
3116 length calculations.
3117
3118 Integer and memory overflow fixes for display code.
3119 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3120 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3121 (scrolling_window): Check for overflow in size calculations.
3122 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3123 Don't assume glyph table len fits in int.
3124 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3125 (row_table_size): Now ptrdiff_t, not int.
3126 (scrolling_window): Avoid overflow in size calculations.
3127 Don't update size until allocation succeeds.
3128 * fns.c (concat): Check for overflow in size calculations.
3129 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3130 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3131 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3132
3133 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3134 (get_doc_string): Check for size calculation overflow.
3135 Don't update size until allocation succeeds.
3136 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3137 EMACS_INT, where ptrdiff_t will do.
3138 (Fsubstitute_command_keys): Check for string overflow.
3139
3140 * editfns.c (set_time_zone_rule): Don't assume environment length
3141 fits in int.
3142 (message_length): Now ptrdiff_t, not int.
3143 (Fmessage_box): Don't update size until allocation succeeds.
3144 Don't assume message length fits in int.
3145 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3146
3147 * emacs.c (main): Do not reallocate argv, since there is a null at
3148 the end that can be overwritten, and this way there's no need to
3149 worry about size-calculation overflow.
3150 (sort_args): Check for size-calculation overflow.
3151
3152 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3153 alloc succeeds.
3154 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3155
3156 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3157 (x_set_scroll_bar_width, x_figure_window_size):
3158 Check for integer overflow.
3159 (x_set_alpha): Do not assume XINT fits in int.
3160
3161 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3162 This is for the members text_lines, text_cols, total_lines, total_cols,
3163 where the system imposes an 'int' limit.
3164
3165 * fringe.c (Fdefine_fringe_bitmap):
3166 Don't update size until alloc works.
3167
3168 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3169 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3170
3171 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3172 Check for size-calculation overflow.
3173 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3174 do, as we prefer signed integers.
3175 (id_to_widget.max_size, id_to_widget.used)
3176 (xg_store_widget_in_map, xg_remove_widget_from_map)
3177 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3178 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3179 Use and return ptrdiff_t, not int.
3180 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3181 * gtkutil.h: Change prototypes to match the above.
3182
3183 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3184 are duplicate now that they've been promoted to lisp.h.
3185 (x_allocate_bitmap_record, x_alloc_image_color)
3186 (make_image_cache, cache_image, xpm_load):
3187 Don't update size until alloc is done.
3188 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3189 (x_detect_edges):
3190 Check for size calculation overflow.
3191 (ct_colors_allocated_max): New constant.
3192 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3193 overflow.
3194
3195 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3196 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3197 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3198 Use ptrdiff_t, not int, to count maps.
3199 (read_char_minibuf_menu_prompt): Check for overflow in size
3200 calculations. Don't update size until allocation succeeds.
3201 Redo calculations to avoid overflow.
3202 * keyboard.h: Change prototypes to match the above.
3203
3204 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3205 to count maps.
3206 (current_minor_maps): Check for size calculation overflow.
3207 * keymap.h: Change prototypes to match the above.
3208
3209 * lread.c (read1, init_obarray): Don't update size until alloc done.
3210
3211 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3212 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3213
3214 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3215 Now ptrdiff_t, not int.
3216 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3217 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3218
3219 * process.c (Fnetwork_interface_list): Check for overflow
3220 in size calculation.
3221
3222 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3223
3224 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3225 overflow. Don't bother calling xmalloc when xrealloc will do.
3226
3227 * search.c (Freplace_match): Check for size calculation overflow.
3228 (Fset_match_data): Don't assume list lengths fit in 'int'.
3229
3230 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3231 for command line length. Do not attempt to address one before the
3232 beginning of an array, as that's not portable.
3233
3234 * term.c (max_frame_lines): Remove; unused.
3235 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3236 not int.
3237 (encode_terminal_code, calculate_costs): Check for size
3238 calculation overflow.
3239 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3240 table lengths and related sizes. Don't update size until alloc
3241 done. Redo calculations to avoid overflow.
3242 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3243
3244 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3245 subtracting pointers.
3246 (gobble_line): Check for overflow more carefully. Don't update size
3247 until alloc done.
3248
3249 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3250 Don't update size until alloc done.
3251 Redo size calculations to avoid overflow.
3252 Check for size calculation overflow.
3253 (main) [DEBUG]: Fix typo in invoking tparam1.
3254
3255 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3256 Use ptrdiff_t, not int, for sizes.
3257 (store_mode_line_noprop_char): Don't update size until alloc done.
3258
3259 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3260 Use ptrdiff_t, not int, for sizes.
3261 (Finternal_make_lisp_face, cache_face):
3262 Check for size calculation overflow.
3263 (cache_face): Treat size calculation overflows as if they were
3264 memory exhaustion (the usual treatment), rather than aborting.
3265
3266 * xfns.c (x_encode_text, x_set_name_internal)
3267 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3268 sizes, since they can exceed INT_MAX in size. Check for size
3269 calculation overflow.
3270
3271 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3272 (xg_select): Check for size calculation overflow.
3273 Don't update size until alloc done.
3274
3275 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3276 as sprintf is limited to int lengths.
3277
3278 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3279 (X_LONG_MIN): New macros.
3280 Use them to make the following changes clearer.
3281 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3282 This change doesn't affect the value now, but it may help remind
3283 future maintainers not to raise the value too much later.
3284 (SELECTION_QUANTUM): Remove, replacing with ...
3285 (selection_quantum): ... new function, which avoids overflow.
3286 All uses changed.
3287 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3288 assumption that selection length fits in 'int'.
3289 (x_reply_selection_request, x_handle_selection_request)
3290 (x_get_window_property, receive_incremental_selection)
3291 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3292 (lisp_data_to_selection_data, clean_local_selection_data):
3293 Use ptrdiff_t, not int, to record length of selection.
3294 (x_reply_selection_request, x_get_window_property)
3295 (receive_incremental_selection, x_property_data_to_lisp):
3296 Redo calculations to avoid overflow.
3297 (x_reply_selection_request): When sending hint, ceiling it at
3298 X_LONG_MAX rather than relying on wraparound overflow to send
3299 something.
3300 (x_get_window_property, receive_incremental_selection)
3301 (lisp_data_to_selection_data, x_property_data_to_lisp):
3302 Check for size-calculation overflow.
3303 (x_get_window_property, receive_incremental_selection)
3304 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3305 Don't store size until memory allocation succeeds.
3306 (x_get_window_property): Plug memory leak on memory exhaustion.
3307 Don't double-block input; malloc is safe here. Don't assume 2**34
3308 - 4 fits in unsigned long. Add an xassert to check
3309 XGetWindowProperty overflow. Be more careful about overflow
3310 calculations, and distinguish size from memory overflow better.
3311 (receive_incremental_selection): When tracing, don't assume
3312 unsigned int is less than INT_MAX.
3313 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3314 harmful) conversions of unsigned short to int.
3315 (lisp_data_to_selection_data): Don't assume that integers
3316 in the range -65535 through -1 fit in an X unsigned short.
3317 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3318 result parameters unless successful. Rely on cons_to_unsigned
3319 to report problems with elements; the old code wasn't right anyway.
3320 (x_check_property_data): Check for int overflow; we cannot use
3321 a wider type due to X limits.
3322 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3323
3324 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3325
3326 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3327 (x_term_init): Check for size calculation overflow.
3328 (x_color_cells): Don't store size until memory allocation succeeds.
3329 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3330 Don't assume alloca size is less than MAX_ALLOCA.
3331 (x_term_init): Don't assume length fits in int (sprintf is limited
3332 to int size).
3333
3334 Use ptrdiff_t for composition IDs.
3335 * character.c (lisp_string_width):
3336 * composite.c (composition_table_size, n_compositions)
3337 (get_composition_id, composition_gstring_from_id):
3338 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3339 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3340 * window.c (Frecenter):
3341 Use ptrdiff_t, not int, for composition IDs.
3342 * composite.c (get_composition_id): Check for integer overflow.
3343 * composite.h: Adjust prototypes to match the above changes.
3344
3345 Use ptrdiff_t for hash table indexes.
3346 * category.c (hash_get_category_set):
3347 * ccl.c (ccl_driver):
3348 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3349 * coding.c (coding_system_charset_list, detect_coding_system):
3350 * coding.h (struct coding_system.id):
3351 * composite.c (get_composition_id, gstring_lookup_cache):
3352 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3353 * image.c (xpm_get_color_table_h):
3354 * lisp.h (hash_lookup, hash_put):
3355 * minibuf.c (Ftest_completion):
3356 Use ptrdiff_t for hash table indexes, not int (which is too
3357 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3358 32-bit --with-wide-int hosts).
3359
3360 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3361 Add a FIXME comment about memory leaks.
3362 (syms_of_charset): Don't assume xmalloc returns.
3363
3364 Don't assume that stated character widths fit in int.
3365 * character.c (Fchar_width, c_string_width, lisp_string_width):
3366 * character.h (CHAR_WIDTH):
3367 * indent.c (MULTIBYTE_BYTES_WIDTH):
3368 Use sanitize_char_width to avoid undefined and/or bad behavior
3369 with outlandish widths.
3370 * character.h (sanitize_tab_width): Rename from sanitize_width,
3371 now that we have two such functions. All uses changed.
3372 (sanitize_char_width): New inline function.
3373
3374 Don't assume that tab-width fits in int.
3375 * character.h (sanitize_width): New inline function.
3376 (SANE_TAB_WIDTH): New macro.
3377 (ASCII_CHAR_WIDTH): Use it.
3378 * indent.c (sane_tab_width): Remove. All uses replaced by
3379 SANE_TAB_WIDTH (current_buffer).
3380 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3381
3382 * fileio.c: Integer overflow issues with file modes.
3383 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3384
3385 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3386 Remove unreachable code.
3387 (read_hex, load_charset_map_from_file): Check for integer overflow.
3388
3389 * xterm.c: Don't go over XClientMessageEvent limit.
3390 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3391 (x_send_scroll_bar_event): Likewise. Check that the size does not
3392 exceed limits imposed by XClientMessageEvent, as well as the usual
3393 ptrdiff_t and size_t limits.
3394
3395 * keyboard.c: Overflow, signedness and related fixes.
3396 (make_lispy_movement): Use same integer type in forward decl
3397 that is used in the definition.
3398 (read_key_sequence, keyremap_step):
3399 Change bufsize argument back to int, undoing my 2011-03-30 change.
3400 We prefer signed types, and int is wide enough here.
3401 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3402 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3403 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3404 length, not size_t. Use ptrdiff_t for index, not int.
3405 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3406 possibility of integer overflow.
3407
3408 Overflow, signedness and related fixes for images.
3409
3410 * dispextern.h (struct it.stack[0].u.image.image_id)
3411 (struct_it.image_id, struct image.id, struct image_cache.size)
3412 (struct image_cache.used, struct image_cache.ref_count):
3413 * gtkutil.c (update_frame_tool_bar):
3414 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3415 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3416 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3417 * nsmenu.m (update_frame_tool_bar):
3418 * xdisp.c (calc_pixel_width_or_height):
3419 * xfns.c (image_cache_refcount):
3420 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3421 on typical 64-bit hosts.
3422
3423 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3424 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3425 Omit unnecessary casts to int.
3426 (parse_image_spec): Check that integers fall into 'int' range
3427 when the callers expect that.
3428 (image_ascent): Redo ascent calculation to avoid int overflow.
3429 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3430 (lookup_image): Remove unnecessary tests.
3431 (xbm_image_p): Locals are now of int, not EMACS_INT,
3432 since parse_image_check makes sure they fit into int.
3433 (png_load, gif_load, svg_load_image):
3434 Prefer int to unsigned where either will do.
3435 (tiff_handler): New function, combining the cores of the
3436 old tiff_error_handler and tiff_warning_handler.
3437 This function is rewritten to use vsnprintf and thereby avoid
3438 stack buffer overflows. It uses only the features of vsnprintf
3439 that are common to both POSIX and native Microsoft.
3440 (tiff_error_handler, tiff_warning_handler): Use it.
3441 (tiff_load, gif_load, imagemagick_load_image):
3442 Don't assume :index value fits in 'int'.
3443 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3444 (imagemagick_load_image): Check that crop parameters fit into
3445 the integer types that MagickCropImage accepts. Don't assume
3446 Vimagemagick_render_type has a nonnegative value. Don't assume
3447 size_t fits in 'long'.
3448 (gs_load): Use printmax_t to print the widest integers possible.
3449 Check for integer overflow when computing image height and width.
3450
3451 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3452
3453 * xdisp.c (redisplay_window): Don't force window start if point
3454 will be invisible in the resulting window. (Bug#9324)
3455
3456 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3457
3458 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3459 the display spec is of the form `(space ...)'.
3460 (handle_display_spec): Return the value returned by
3461 handle_single_display_spec, not just 1 or zero.
3462 (handle_single_display_spec): If the display spec is of the form
3463 `(space ...)', and specifies display in the text area, return 2
3464 rather than 1.
3465 (try_cursor_movement): Check for the need to scroll more
3466 accurately, and prefer exact match for point under bidi.
3467 Don't advance `row' beyond the last row of the window.
3468
3469 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3470 into disp_prop; all users changed.
3471
3472 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3473 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3474 for the text covered by the display property.
3475
3476 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3477
3478 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3479 Change return value to nil.
3480 (Frecord_buffer): Delete unused function.
3481
3482 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3483
3484 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3485 buffers, return left-to-right.
3486 (set_cursor_from_row): Consider candidate row a win if its glyph
3487 represents a newline and point is on that newline. Fixes cursor
3488 positioning on the newline at EOL of R2L text within L2R
3489 paragraph, and vice versa.
3490 (try_cursor_movement): Check continued rows, in addition to
3491 continuation rows. Fixes unwarranted scroll when point enters a
3492 continued line of R2L text within an L2R paragraph, or vice versa.
3493 (cursor_row_p): Consider the case of point being equal to
3494 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3495 from the end of a short line to the beginning of a continued line
3496 of R2L text within L2R paragraph.
3497 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3498 composed characters.
3499
3500 * bidi.c (bidi_check_type): Use xassert.
3501 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3502 members.
3503
3504 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3505
3506 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3507 a character.
3508
3509 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3510
3511 * nsfont.m (ns_otf_to_script): Fix typo.
3512
3513 2011-08-22 Kenichi Handa <handa@m17n.org>
3514
3515 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3516 extra slot even if the purpose is char-code-property-table.
3517
3518 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3519
3520 * xdisp.c (redisplay_window): When computing centering_position,
3521 account for the height of the header line. (Bug#8874)
3522
3523 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3524 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3525 candidate is selected by the mouse, and that candidate has a
3526 composed character under the mouse.
3527
3528 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3529 coordinates reported by pos-visible-in-window-p for a composed
3530 character in column zero.
3531
3532 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3533
3534 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3535
3536 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3537
3538 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3539 consider it a hit if to_charpos is anywhere in the range of the
3540 composed buffer positions.
3541
3542 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3543
3544 * image.c (gif_load): Don't assume that each subimage has the same
3545 dimensions as the base image. Handle disposal method that is
3546 "undefined" by the gif spec (Bug#9335).
3547
3548 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3549
3550 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3551 (Fcondition_case): Document `debug' symbol in error handler.
3552
3553 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3554
3555 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3556 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3557 from an Org mode buffer to a Speedbar frame.
3558
3559 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3560 a composition, take its buffer position from IT->cmp_it.charpos.
3561 Fixes cursor positioning at the beginning of a line that begins
3562 with a composed character.
3563
3564 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3565
3566 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3567 character bidirectional type, use STRONG_L instead. Fixes crashes
3568 in a buffer produced by `describe-categories'.
3569
3570 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3571 members before the level stack, so they would be saved and
3572 restored when copying iterator state. Fixes incorrect reordering
3573 around TABs covered by display properties.
3574
3575 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3576
3577 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3578
3579 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3580
3581 * eval.c (internal_condition_case, internal_condition_case_1)
3582 (internal_condition_case_2, internal_condition_case_n):
3583 Remove unnecessary aborts (Bug#9081).
3584
3585 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3586
3587 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3588 has no `load' handler, try opening the file locally. (Bug#9311)
3589
3590 2011-08-16 Ken Brown <kbrown@cornell.edu>
3591
3592 * gmalloc.c: Expand comment.
3593
3594 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3595
3596 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3597 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3598
3599 2011-08-16 Ken Brown <kbrown@cornell.edu>
3600
3601 Fix memory allocation problems in Cygwin build (Bug#9273).
3602
3603 * unexcw.c ( __malloc_initialized): Declare external variable.
3604 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3605
3606 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3607 New variables.
3608 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3609 dumped emacs.
3610 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3611 in the static heap.
3612 [CYGWIN] (special_realloc): New function.
3613 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3614 requests to realloc storage in the static heap.
3615
3616 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3617
3618 * bidi.c (bidi_initialize): Remove unused local.
3619
3620 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3621
3622 * bidimirror.h:
3623 * biditype.h: Remove file.
3624 * makefile.w32-in ($(BLD)/bidi.$(O)):
3625 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3626
3627 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3628
3629 * chartab.c: Improve commentary for the uniprop_table API.
3630
3631 * bidi.c (bidi_paragraph_init): Support zero value of
3632 bidi_ignore_explicit_marks_for_paragraph_level.
3633 (bidi_initialize): Use uniprop_table instead of including
3634 biditype.h and bidimirror.h.
3635
3636 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3637 coordinates of the iterator when restoring from ppos_it.
3638 (Bug#9296)
3639
3640 2011-08-14 Kenichi Handa <handa@m17n.org>
3641
3642 * process.c (create_process): Call setup_process_coding_systems
3643 after the pid of the process is set to -1 (Bug#8162).
3644
3645 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3646
3647 * xdisp.c (move_it_in_display_line_to): Don't invoke
3648 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3649 ppos_it. Fixes vertical cursor motion when line beginning is
3650 covered by an image. (Bug#9296)
3651
3652 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3653
3654 * nsterm.h (ns_run_ascript): Declare.
3655 (NSAPP_DATA2_RUNASSCRIPT): Define.
3656
3657 * nsfns.m (as_script, as_result, as_status): New static variables.
3658 (ns_run_ascript): New function.
3659 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3660 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3661 the event loop. Get status from as_status (Bug#7276).
3662
3663 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3664 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3665 the event loop (Bug#7276).
3666
3667 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3668
3669 * gnutls.c (QCgnutls_bootprop_priority)
3670 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3671 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3672 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3673 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3674 (QCgnutls_bootprop_verify_hostname_error)
3675 (QCgnutls_bootprop_callbacks_verify): Rename from
3676 Qgnutls_bootprop_..., all uses changed.
3677
3678 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3679 uses changed.
3680
3681 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3682
3683 * xfaces.c (Qframe_set_background_mode): Now static.
3684 * dispextern.h (Qframe_set_background_mode): Remove decl.
3685
3686 * process.c (Fnetwork_interface_info): Declare local only if needed.
3687
3688 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3689
3690 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3691 (Fnetwork_interface_list): Allocate in increments of bytes instead
3692 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3693 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3694 sockaddr.
3695 (struct ifflag_def): notrailers is smart on OSX.
3696 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3697 Get hardware address with getifaddrs if available.
3698
3699 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3700
3701 * xdisp.c (iterate_out_of_display_property): xassert that
3702 IT->position is set to within IT->object's boundaries. Break from
3703 the loop as soon as EOB is reached; avoids infloops in redisplay
3704 when IT->position is set up wrongly due to some bug.
3705 Set IT->current to match the bidi iterator unconditionally.
3706 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3707 entry. Force push_it to save on the stack the current
3708 buffer/string position, to be restored by pop_it. Fix flags in
3709 the iterator structure wrt the object coming from a display
3710 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3711 properties. (Bug#9284)
3712
3713 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3714
3715 * fontset.c (fontset_get_font_group): Add proper type checks.
3716 (Bug#9172)
3717
3718 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3719
3720 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3721 and LC_VERSION_MIN_MACOSX.
3722 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3723 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3724
3725 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3726
3727 * xdisp.c (forward_to_next_line_start): Allow to use the
3728 no-display-properties-and-no-overlays under bidi display.
3729 Set disp_pos in the bidi iterator to avoid searches for display
3730 properties and overlays.
3731
3732 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3733
3734 * editfns.c (Fset_time_zone_rule): Document relationship with the
3735 setenv function.
3736
3737 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3738 the font entity extracted from the cache (Bug#8109).
3739
3740 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3741
3742 * composite.c (autocmp_chars): Don't reset point. That is done by
3743 restore_point_unwind (Bug#5984).
3744
3745 2011-08-07 Juri Linkov <juri@jurta.org>
3746
3747 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3748 to show the arg `TIME' instead of `TIMEVAL'.
3749
3750 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3751
3752 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3753 display property strides EOL and includes a newline, as in
3754 longlines-mode. (Bug#9254)
3755 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3756 word-wrap under bidirectional display. (Bug#9224)
3757
3758 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3759 is non-zero, even if the data buffer is NULL. Fixes a crash in
3760 vertical-motion with longlines-mode. (Bug#9254)
3761
3762 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3763
3764 * bidi.c <bidi_cache_total_alloc>: Now static.
3765 (bidi_initialize): Initialize bidi_cache_total_alloc.
3766
3767 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3768 cache. (Bug#9221)
3769
3770 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3771 amount allocated this far in `bidi_cache_total_alloc'.
3772 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3773 non-zero, only free the data buffer without restoring the cache
3774 contents. All callers changed.
3775
3776 * dispextern.h (bidi_unshelve_cache): Update prototype.
3777
3778 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3779 (move_it_in_display_line, move_it_to)
3780 (move_it_vertically_backward, move_it_by_lines): Replace the call
3781 to xfree to an equivalent call to bidi_unshelve_cache.
3782 (move_it_in_display_line_to): Fix logic of returning
3783 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3784
3785 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3786
3787 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3788 came from a string character with a `cursor' property. (Bug#9229)
3789
3790 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3791
3792 * Makefile.in (LIB_PTHREAD): New variable.
3793 (LIBES): Add LIB_PTHREAD (Bug#9216).
3794
3795 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3796 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3797
3798 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3799
3800 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3801
3802 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3803
3804 * xterm.c (x_find_topmost_parent): New function.
3805 (x_set_frame_alpha): Find topmost parent window with
3806 x_find_topmost_parent and set the property there also (bug#9181).
3807 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3808
3809 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3810
3811 * callproc.c (Fcall_process): Avoid vfork clobbering
3812 the local vars buffer, coding_systems, current_dir.
3813
3814 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3815
3816 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3817
3818 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3819
3820 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3821 so that it is not optimized away.
3822
3823 * xdisp.c (compute_display_string_pos): Remove unused local.
3824
3825 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3826
3827 Fix slow cursor motion and scrolling in large buffers with
3828 selective display, like Org Mode buffers. (Bug#9218)
3829
3830 * dispextern.h (struct bidi_it): New member disp_prop_p.
3831
3832 * xdisp.c: Remove one-slot cache of display string positions.
3833 (compute_display_string_pos): Accept an additional argument
3834 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3835 for a display string or property. If found, set DISP_PROP_P
3836 non-zero.
3837
3838 * bidi.c (bidi_fetch_char): Accept an additional argument
3839 DISP_PROP_P, and pass it to compute_display_string_pos.
3840 Only handle text covered by a display string if DISP_PROP_P is returned
3841 non-zero. All callers of bidi_fetch_char changed.
3842
3843 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3844
3845 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3846
3847 2010-12-03 Don March <don@ohspite.net>
3848
3849 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3850 last character M-[char] is translated to ESC [char] (bug#7541).
3851
3852 2011-08-02 Kenichi Handa <handa@m17n.org>
3853
3854 * lisp.h (uniprop_table): Extern it.
3855
3856 * chartab.c (uniprop_table): Make it non-static.
3857
3858 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3859
3860 * xdisp.c (forward_to_next_line_start): Accept additional argument
3861 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3862 on the newline.
3863 (reseat_at_next_visible_line_start): Use the bidi iterator state
3864 returned by forward_to_next_line_start to restore the state of
3865 it->bidi_it after backing up to previous newline. (Bug#9212)
3866
3867 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3868
3869 * regex.c (re_comp): Protoize.
3870 (re_exec): Fix return type.
3871 (regexec): Fix type of `ret'. (Bug#9203)
3872
3873 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3874
3875 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3876 This is needed if max-image-size is a floating-point number.
3877
3878 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3879
3880 * print.c (print_object): Print empty symbol as ##.
3881
3882 * lread.c (read1): Read ## as empty symbol.
3883
3884 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3885
3886 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3887 setting frame foreground color (Bug#9175).
3888 (x_set_background_color): Likewise.
3889
3890 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3891 contents (Bug#9176).
3892 (EmacsTooltip -init): Remove bezels and add shadows to
3893 tooltip windows.
3894
3895 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3896 or scroll bar (Bug#8470).
3897
3898 * nsfont.m (nsfont_open): Remove assignment to voffset and
3899 unnecessary vars hshink, expand, hd, full_height, min_height.
3900 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3901
3902 * nsterm.h (nsfont_info): Remove voffset field.
3903
3904 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3905
3906 Implement strike-through and overline on NextStep (Bug#8863).
3907
3908 * nsfont.m (nsfont_open): Use underline position provided by font,
3909 instead of hard-coded value of 2.
3910 (nsfont_draw): Call ns_draw_text_decoration instead.
3911
3912 * nsterm.h: Add declaration for ns_draw_text_decoration.
3913
3914 * nsterm.m (ns_draw_text_decoration): New function for drawing
3915 underline, overline, and strike-through.
3916 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3917 ns_draw_text_decoration. Change treatment of cursor drawing to
3918 accommodate underlining, etc.
3919
3920 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3921
3922 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3923 default.
3924
3925 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3926
3927 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3928 Without this fix, if a signal arrives just after memory fills up,
3929 'malloc' might be invoked reentrantly.
3930
3931 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3932 In other words, assume that every image size is allowed, on non-X
3933 hosts. This assumption is probably wrong, but it lets Emacs compile.
3934
3935 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3936
3937 * regex.c (re_iswctype): Convert return values to boolean.
3938
3939 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3940
3941 * xdisp.c (compute_display_string_pos): Don't use cached display
3942 string position if the buffer had its restriction changed.
3943 (Bug#9184)
3944
3945 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3946
3947 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3948
3949 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3950
3951 Integer signedness and overflow and related fixes. (Bug#9079)
3952
3953 * bidi.c: Integer size and overflow fixes.
3954 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3955 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3956 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3957 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3958 (bidi_find_other_level_edge):
3959 Use ptrdiff_t instead of EMACS_INT where either will do.
3960 This works better on 32-bit hosts configured --with-wide-int.
3961 (bidi_cache_ensure_space): Check for size-calculation overflow.
3962 Use % rather than repeated addition, for better worst-case speed.
3963 Don't set bidi_cache_size until after xrealloc returns, because it
3964 might not return.
3965 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3966 (bidi_cache_ensure_space): Also check that the bidi cache size
3967 does not exceed that of the largest Lisp string or buffer. See Eli
3968 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3969
3970 * alloc.c (__malloc_size_t): Remove.
3971 All uses replaced by size_t. See Andreas Schwab's note
3972 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3973
3974 * image.c: Improve checking for integer overflow.
3975 (check_image_size): Assume that f is nonnull, since
3976 it is always nonnull in practice. This is one less thing to
3977 worry about when checking for integer overflow later.
3978 (x_check_image_size): New function, which checks for integer
3979 overflow issues inside X.
3980 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3981 This removes the need for a memory_full check.
3982 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3983 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3984 (xbm_read_bitmap_data): Change locals back to 'int', since
3985 their values must fit in 'int'.
3986 (xpm_load_image, png_load, tiff_load):
3987 Invoke x_create_x_image_and_pixmap earlier,
3988 to avoid much needless work if the image is too large.
3989 (tiff_load): Treat overly large images as if
3990 x_create_x_image_and_pixmap failed, not as malloc failures.
3991 (gs_load): Use x_check_image_size.
3992
3993 * gtkutil.c: Omit integer casts.
3994 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3995 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3996
3997 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3998
3999 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
4000 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
4001 would wrongly return t on a 64-bit host.
4002
4003 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
4004 The plain *_OVERFLOW macros run afoul of GCC bug 49705
4005 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
4006 and therefore cause GCC to emit a bogus diagnostic in some cases.
4007
4008 * image.c: Integer signedness and overflow and related fixes.
4009 This is not an exhaustive set of fixes, but it's time to
4010 record what I've got.
4011 (lookup_pixel_color, check_image_size): Remove redundant decls.
4012 (check_image_size): Don't assume that arbitrary EMACS_INT values
4013 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4014 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4015 (tiff_load, imagemagick_load_image):
4016 Check for overflow in size calculations.
4017 (x_create_x_image_and_pixmap): Remove unnecessary test for
4018 xmalloc returning NULL; that can't happen.
4019 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4020 (xpm_color_bucket): Use better integer hashing function.
4021 (xpm_cache_color): Don't possibly over-allocate memory.
4022 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4023 (gif_memory_source):
4024 Use ptrdiff_t, not int or size_t, to record sizes.
4025 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4026 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4027 either works, as we prefer signed integers.
4028 (tiff_read_from_memory, tiff_write_from_memory):
4029 Return tsize_t, not size_t, since that's what the TIFF API wants.
4030 (tiff_read_from_memory): Don't fail simply because the read would
4031 go past EOF; instead, return a short read.
4032 (tiff_load): Omit no-longer-needed casts.
4033 (Fimagemagick_types): Don't assume size fits into 'int'.
4034
4035 Improve hashing quality when configured --with-wide-int.
4036 * fns.c (hash_string): New function, taken from sxhash_string.
4037 Do not discard information about ASCII character case; this
4038 discarding is no longer needed.
4039 (sxhash-string): Use it. Change sig to match it. Caller changed.
4040 * lisp.h: Declare it.
4041 * lread.c (hash_string): Remove, since we now use fns.c's version.
4042 The fns.c version returns a wider integer if --with-wide-int is
4043 specified, so this should help the quality of the hashing a bit.
4044
4045 * emacs.c: Integer overflow minor fix.
4046 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4047 Define only if GNU_LINUX.
4048 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4049
4050 * dispnew.c: Integer signedness and overflow fixes.
4051 Remove unnecessary forward decls, that were a maintenance hassle.
4052 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4053 All uses changed.
4054 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4055 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4056 (prepare_desired_row, line_draw_cost):
4057 Use int, not unsigned, where either works.
4058 (save_current_matrix, restore_current_matrix):
4059 Use ptrdiff_t, not size_t, where either works.
4060 (init_display): Check for overflow more accurately, and without
4061 relying on undefined behavior.
4062
4063 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4064 Remove, replacing with the new symbols in lisp.h. All uses changed.
4065 * fileio.c (make_temp_name):
4066 * filelock.c (lock_file_1, lock_file):
4067 * xdisp.c (message_dolog):
4068 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4069 Use pMd etc. instead.
4070 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4071 replacing the pWIDE etc. symbols removed from editfns.c.
4072
4073 * keyboard.h (num_input_events): Now uintmax_t.
4074 This is (very slightly) less likely to mess up due to wraparound.
4075 All uses changed.
4076
4077 * buffer.c: Integer signedness fixes.
4078 (alloc_buffer_text, enlarge_buffer_text):
4079 Use ptrdiff_t rather than size_t when either will do, as we prefer
4080 signed integers.
4081
4082 * alloc.c: Integer signedness and overflow fixes.
4083 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4084 (__malloc_size_t): Default to size_t, not to int.
4085 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4086 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4087 Prefer ptrdiff_t to size_t when either would do, as we prefer
4088 signed integers.
4089 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4090 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4091 Now const. Initialize with values that are in range even if char
4092 is signed.
4093 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4094 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4095 These functions do the right thing with sizes > 2**32.
4096 (check_depth): Now ptrdiff_t, not int.
4097 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4098 Adjust to new way of storing sizes. Check for size overflow bugs
4099 in rest of code.
4100 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4101 slightly wrong anyway, as it missed one instance of
4102 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4103 (refill_memory_reserve): Omit needless cast to size_t.
4104 (mark_object_loop_halt): Mark as externally visible.
4105
4106 * xselect.c: Integer signedness and overflow fixes.
4107 (Fx_register_dnd_atom, x_handle_dnd_message):
4108 Use ptrdiff_t, not size_t, since we prefer signed.
4109 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4110 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4111 x_dnd_atoms_size and x_dnd_atoms_length.
4112
4113 * doprnt.c: Prefer signed to unsigned when either works.
4114 * eval.c (verror):
4115 * doprnt.c (doprnt):
4116 * lisp.h (doprnt):
4117 * xdisp.c (vmessage):
4118 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4119 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4120 prefer signed arithmetic to avoid comparison confusion.
4121 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4122 but is a bit tricky.
4123
4124 Assume freestanding C89 headers, string.h, stdlib.h.
4125 * data.c, doprnt.c, floatfns.c, print.c:
4126 Include float.h unconditionally.
4127 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4128 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4129 * regex.c: Likewise for stddef.h, string.h.
4130 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4131 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4132 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4133 (STDC_HEADERS): Remove obsolete defines.
4134 * sysdep.c: Include limits.h unconditionally.
4135
4136 Assume support for memcmp, memcpy, memmove, memset.
4137 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4138 * regex.c (memcmp, memcpy):
4139 Remove; we assume C89 now.
4140
4141 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4142 (__malloc_safe_bcopy): Remove; no longer needed.
4143
4144 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
4145 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4146 well either way, and we prefer signed to unsigned.
4147
4148 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4149
4150 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4151 closes the connection while we're reading (bug#9182).
4152
4153 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
4154
4155 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4156 are specified (Bug#9168).
4157
4158 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4159
4160 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4161 Found by GCC static checking and --with-wide-int on a 32-bit host.
4162
4163 2011-07-25 Eli Zaretskii <eliz@gnu.org>
4164
4165 * xdisp.c (compute_display_string_pos): Fix logic of caching
4166 previous display string position. Initialize cached_prev_pos to
4167 -1. Fixes slow-down at the beginning of a buffer.
4168
4169 2011-07-24 Eli Zaretskii <eliz@gnu.org>
4170
4171 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4172 for attrs[LFACE_FONTSET_INDEX].
4173
4174 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4175
4176 * xml.c (parse_region): Remove unused local
4177 that was recently introduced.
4178
4179 2011-07-23 Eli Zaretskii <eliz@gnu.org>
4180
4181 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4182 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4183
4184 * xdisp.c (move_it_in_display_line_to): Record the best matching
4185 position for TO_CHARPOS while scanning the line, and restore it on
4186 exit if none of the characters scanned was an exact match.
4187 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
4188 when exact match is impossible due to invisible text, and the
4189 lines are truncated.
4190
4191 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4192
4193 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4194 for OSX >= 10.7.
4195
4196 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4197
4198 Fix a significant slow-down of cursor motion with C-n, C-p,
4199 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4200 auto-repeat under bidi redisplay in fontified buffers.
4201 * xdisp.c (compute_stop_pos_backwards): New function.
4202 (next_element_from_buffer): Call compute_stop_pos_backwards to
4203 find a suitable prev_stop when we find ourselves before
4204 base_level_stop.
4205 (reseat): Don't look for prev_stop, as that could mean a very long
4206 run.
4207 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4208 <cached_disp_overlay_modiff>: Cache for last found display string
4209 position.
4210 (compute_display_string_pos): Return the cached position if asked
4211 about the same buffer in the same area of character positions, and
4212 the buffer wasn't changed since the time the display string
4213 position was cached.
4214
4215 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4216
4217 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4218 is an integer, which is important for empty lines. (Bug#9149)
4219
4220 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
4221
4222 * frame.c (Fmodify_frame_parameters): In tty case, update the
4223 default face if necessary (Bug#4238).
4224
4225 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
4226
4227 * editfns.c (Fstring_to_char): No need to explain what a character
4228 is in the docstring (Bug#6576).
4229
4230 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4231
4232 * xml.c (parse_region): Make sure we always return a tree.
4233
4234 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4235
4236 * xml.c (parse_region): If a document contains only comments,
4237 return that, too.
4238
4239 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4240
4241 * xml.c (make_dom): Return comments, too.
4242
4243 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4244
4245 Port to OpenBSD.
4246 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4247 and the surrounding thread.
4248 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4249 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4250 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4251 timer goes off.
4252 * s/openbsd.h (BROKEN_SIGIO): Define.
4253 * unexelf.c (unexec) [__OpenBSD__]:
4254 Don't update the .mdebug section of the Alpha COFF symbol table.
4255
4256 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4257
4258 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4259 (bug#8460).
4260
4261 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4262
4263 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4264 This fixes some race conditions on the permissions of any newly
4265 created file.
4266
4267 * alloc.c (valid_pointer_p): Use pipe, not open.
4268 This fixes some permissions issues when debugging.
4269
4270 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4271 If fchown fails to set both uid and gid, try to set just gid,
4272 as that is sometimes allowed. Adjust the file's mode to eliminate
4273 setuid or setgid bits that are inappropriate if fchown fails.
4274
4275 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4276
4277 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4278 to compare Lisp_Objects.
4279 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4280 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4281 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4282
4283 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4284
4285 * lread.c (read_integer): Unread even EOF character.
4286 (read1): Likewise. Properly record start position of symbol.
4287
4288 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4289 symbol character follows.
4290
4291 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4292
4293 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4294 This works around a problem with the previous change to Fcopy_file.
4295 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4296 and without this change, GCC might complain about discarding
4297 fchown's return value.
4298
4299 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4300
4301 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4302
4303 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4304
4305 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4306
4307 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4308
4309 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4310 it's used from the C level.
4311
4312 * process.c: Use the same condition for POLL_FOR_INPUT in both
4313 keyboard.c and process.c (bug#1858).
4314
4315 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4316
4317 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4318 (Fgnutls_boot): Use it.
4319
4320 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4321
4322 * doc.c (Fsubstitute_command_keys): Revert last change.
4323
4324 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4325
4326 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4327 quotes the next character, and doesn't affect other longer
4328 sequences (bug#8935).
4329
4330 * lread.c (syms_of_lread): Clarify that is isn't only
4331 `eval-buffer' and `eval-defun' that's affected by
4332 `lexical-binding' (bug#8460).
4333
4334 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4335
4336 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4337 bidi redisplay when a line includes both an image and is truncated.
4338
4339 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4340
4341 Fix minor problems found by static checking.
4342 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4343 (elsz): Now a signed constant, not a size_t var. We prefer signed
4344 types to unsigned, to avoid integer comparison confusion. Without
4345 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4346 "cannot optimize loop, the loop counter may overflow", a symptom
4347 of the confusion.
4348 * indent.c (Fvertical_motion): Mark locals as initialized.
4349 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4350
4351 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4352
4353 * search.c (Fre_search_backward): Mention `case-fold-search' in
4354 all the re_search_* functions (bug#8138).
4355
4356 * keyboard.c (Fopen_dribble_file): Document when the file is
4357 closed (bug#8056).
4358
4359 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4360
4361 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4362 bidi_cache_idx.
4363
4364 Support bidi reordering of display and overlay strings.
4365 * xdisp.c (compute_display_string_pos)
4366 (compute_display_string_end): Accept additional argument STRING.
4367 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4368 (reseat_to_string): Initialize bidi_it->string.s and
4369 bidi_it->string.schars.
4370 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4371 NULL (avoids a crash in bidi_paragraph_init).
4372 Initialize itb.string.lstring.
4373 (init_iterator): Call bidi_init_it only of a valid
4374 buffer position was specified. Initialize paragraph_embedding to
4375 L2R.
4376 (reseat_to_string): Initialize the bidi iterator.
4377 (display_string): If we need to ignore text properties of
4378 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4379 original value of -1 will not work with bidi.)
4380 (compute_display_string_pos): First arg is now struct
4381 `text_pos *'; all callers changed. Support display properties on
4382 Lisp strings.
4383 (compute_display_string_end): Support display properties on Lisp
4384 strings.
4385 (init_iterator, reseat_1, reseat_to_string): Initialize the
4386 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4387 when iterating on a string not from display properties).
4388 (compute_display_string_pos, compute_display_string_end):
4389 Fix calculation of the object to scan. Fixes an error when using
4390 arrow keys.
4391 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4392 base_level_stop; instead, set base_level_stop to BEGV.
4393 Fixes crashes in vertical-motion.
4394 (next_element_from_buffer): Improve commentary for when
4395 the iterator is before prev_stop.
4396 (init_iterator): Initialize bidi_p from the default value of
4397 bidi-display-reordering, not from buffer-local value. Use the
4398 buffer-local value only if initializing for buffer iteration.
4399 (handle_invisible_prop): Support invisible properties on strings
4400 that are being bidi-reordered.
4401 (set_iterator_to_next): Support bidi reordering of C strings and
4402 Lisp strings.
4403 (next_element_from_string): Support bidi reordering of Lisp
4404 strings.
4405 (handle_stop_backwards): Support Lisp strings as well.
4406 (display_string): Support display of R2L glyph rows.
4407 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4408 (init_iterator): Don't initialize it->bidi_p for strings
4409 here.
4410 (reseat_to_string): Initialize it->bidi_p for strings here.
4411 (next_element_from_string, next_element_from_c_string)
4412 (next_element_from_buffer): Add xassert's for correspondence
4413 between IT's object being iterated and it->bidi_it.string
4414 structure.
4415 (face_before_or_after_it_pos): Support bidi iteration.
4416 (next_element_from_c_string): Handle the case of the first string
4417 character that is not the first one in the visual order.
4418 (get_visually_first_element): New function, refactored from common
4419 parts of next_element_from_buffer, next_element_from_string, and
4420 next_element_from_c_string.
4421 (tool_bar_lines_needed, redisplay_tool_bar)
4422 (display_menu_bar): Force left-to-right direction. Add a FIXME
4423 comment for making that be controlled by a user option.
4424 (push_it, pop_it): Save and restore the state of the
4425 bidi iterator. Save and restore the bidi_p flag.
4426 (pop_it): Iterate out of display property for string iteration as
4427 well.
4428 (iterate_out_of_display_property): Support iteration over strings.
4429 (handle_single_display_spec): Set up it->bidi_it for iteration
4430 over a display string, and call bidi_init_it.
4431 (handle_single_display_spec, next_overlay_string)
4432 (get_overlay_strings_1, push_display_prop): Set up the bidi
4433 iterator for displaying display or overlay strings.
4434 (forward_to_next_line_start): Don't use the shortcut if
4435 bidi-iterating.
4436 (back_to_previous_visible_line_start): If handle_display_prop
4437 pushed the iterator stack, restore the internal state of the bidi
4438 iterator by calling bidi_pop_it same number of times.
4439 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4440 and we are bidi-iterating, don't decrement the iterator position;
4441 instead, set the first_elt flag in the bidi iterator, to produce
4442 the same effect.
4443 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4444 (push_display_prop): xassert that we are iterating a buffer.
4445 (push_it, pop_it): Save and restore paragraph_embedding member.
4446 (handle_single_display_spec, next_overlay_string)
4447 (get_overlay_strings_1, reseat_1, reseat_to_string)
4448 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4449 correctly. Don't assume unibyte strings are not bidi-reordered.
4450 (compute_display_string_pos)
4451 (compute_display_string_end): Fix handling the case of C string.
4452 (push_it, pop_it): Save and restore from_disp_prop_p.
4453 (handle_single_display_spec, push_display_prop): Set the
4454 from_disp_prop_p flag.
4455 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4456 (pop_it): Call iterate_out_of_display_property only if we are
4457 popping after iteration over a string that came from a display
4458 property. Fix a typo in popping stretch info. Add an assertion
4459 for verifying that the iterator position is in sync with the bidi
4460 iterator.
4461 (handle_single_display_spec, get_overlay_strings_1)
4462 (push_display_prop): Fix initialization of paragraph direction for
4463 string when that of the parent object is not yet determined.
4464 (reseat_1): Call bidi_init_it to resync the bidi
4465 iterator with IT's position. (Bug#7616)
4466 (find_row_edges): If ROW->start.pos gives position
4467 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4468 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4469 Reset the from_disp_prop_p flag.
4470 (SAVE_IT, RESTORE_IT): New macros.
4471 (pos_visible_p, face_before_or_after_it_pos)
4472 (back_to_previous_visible_line_start)
4473 (move_it_in_display_line_to, move_it_in_display_line)
4474 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4475 (try_scrolling, redisplay_window, display_line): Use them when
4476 saving a temporary copy of the iterator and restoring it back.
4477 (back_to_previous_visible_line_start, reseat_1)
4478 (init_iterator): Empty the bidi cache "stack".
4479 (move_it_in_display_line_to): If iterator ended up at
4480 EOL, but we never saw any buffer positions smaller than
4481 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4482 motion in bidi-reordered lines.
4483 (move_it_in_display_line_to): Record prev_method and prev_pos
4484 immediately before the call to set_iterator_to_next. Fixes cursor
4485 motion in bidi-reordered lines with stretch glyphs and strings
4486 displayed in margins. (Bug#8133) (Bug#8867)
4487 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4488 TO_CHARPOS.
4489 (pos_visible_p): Support positions in bidi-reordered lines.
4490 Save and restore bidi cache.
4491
4492 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4493 (bidi_paragraph_info): Delete unused struct.
4494 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4495 (bidi_cache_start): New variable.
4496 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4497 to zero.
4498 (bidi_cache_fetch_state, bidi_cache_search)
4499 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4500 (bidi_cache_find, bidi_peek_at_next_level)
4501 (bidi_level_of_next_char, bidi_find_other_level_edge)
4502 (bidi_move_to_visually_next): Compare cache index with
4503 bidi_cache_start rather than with zero.
4504 (bidi_fetch_char): Accept new argument STRING; all callers
4505 changed. Support iteration over a string. Support strings with
4506 display properties. Support unibyte strings. Fix the type of
4507 `len' according to what STRING_CHAR_AND_LENGTH expects.
4508 (bidi_paragraph_init, bidi_resolve_explicit_1)
4509 (bidi_resolve_explicit, bidi_resolve_weak)
4510 (bidi_level_of_next_char, bidi_move_to_visually_next):
4511 Support iteration over a string.
4512 (bidi_set_sor_type, bidi_resolve_explicit_1)
4513 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4514 can now be zero (for strings); special values 0 and -1 were
4515 changed to -1 and -2, respectively.
4516 (bidi_char_at_pos): New function.
4517 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4518 Call it instead of FETCH_MULTIBYTE_CHAR.
4519 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4520 initialized to valid values.
4521 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4522 values.
4523 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4524 the test for valid cached positions. Fix the logic for looking up
4525 the sentinel state in the cache. GCPRO the Lisp string we are
4526 iterating.
4527 (bidi_push_it, bidi_pop_it): New functions.
4528 (bidi_initialize): Initialize the bidi cache start stack pointer.
4529 (bidi_cache_ensure_space): New function, refactored from part of
4530 bidi_cache_iterator_state. Don't assume the required size is just
4531 one BIDI_CACHE_CHUNK away.
4532 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4533 (bidi_count_bytes, bidi_char_at_pos): New functions.
4534 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4535 always valid if bidi_cache_idx is valid.
4536 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4537 is valid if it's going to be used.
4538 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4539 (bidi_cache_fetch_state, bidi_cache_search)
4540 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4541 (bidi_cache_iterator_state, bidi_cache_find)
4542 (bidi_find_other_level_edge, bidi_cache_start_stack):
4543 All variables related to cache indices are now EMACS_INT.
4544
4545 * dispextern.h (struct bidi_string_data): New structure.
4546 (struct bidi_it): New member `string'. Make flag members be 1-bit
4547 fields, and put them last in the struct.
4548 (compute_display_string_pos, compute_display_string_end):
4549 Update prototypes.
4550 (bidi_push_it, bidi_pop_it): Add prototypes.
4551 (struct iterator_stack_entry): New members bidi_p,
4552 paragraph_embedding, and from_disp_prop_p.
4553 (struct it): Member bidi_p is now a bit field 1 bit wide.
4554 (bidi_shelve_cache, bidi_unshelve_cache):
4555 Declare prototypes.
4556
4557 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4558 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4559 and vector-like objects.
4560
4561 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4562 cache around display iteration.
4563
4564 * window.c (Fwindow_end, window_scroll_pixel_based)
4565 (displayed_window_lines, Frecenter): Save and restore the bidi
4566 cache around display iteration.
4567
4568 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4569
4570 * editfns.c (Fdelete_region): Clarify the use of the named
4571 parameters (bug#6788).
4572
4573 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4574
4575 * indent.c (Fvertical_motion): Set and restore w->pointm when
4576 saving and restoring the window's buffer (Bug#9006).
4577
4578 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4579
4580 * editfns.c (Fstring_to_char): Clarify just what is returned
4581 (bug#6576). Text by Eli Zaretskii.
4582
4583 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4584
4585 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4586
4587 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4588
4589 * buffer.c (mmap_find): Fix a typo.
4590
4591 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4592
4593 Fix execution of x selection hooks.
4594 * xselect.c (Qx_lost_selection_functions)
4595 (Qx_sent_selection_functions): New vars.
4596 (syms_of_xselect): DEFSYM them.
4597 (x_handle_selection_request): Pass Qx_sent_selection_functions
4598 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4599 (x_handle_selection_clear,x_clear_frame_selections):
4600 Pass Qx_lost_selection_functions rather than
4601 Vx_lost_selection_functions to Frun_hook_with_args.
4602
4603 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4604
4605 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4606 The old code sometimes used this field without initializing it.
4607
4608 * alloc.c (gc_sweep): Don't read past end of array.
4609 In theory, the old code could also have corrupted Emacs internals,
4610 though it'd be very unlikely.
4611
4612 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4613
4614 * character.c (Fcharacterp): Don't advertise optional ignored
4615 argument. (Bug#4026)
4616
4617 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4618
4619 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4620 key" (bug#4257).
4621
4622 * window.c (Fset_window_start): Doc fix (bug#4199).
4623 (Fset_window_hscroll): Ditto.
4624
4625 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4626
4627 Fix minor new problems caught by GCC 4.6.1.
4628 * term.c (init_tty): Remove unused local.
4629 * xsettings.c (store_monospaced_changed): Define this function only
4630 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4631 not used otherwise.
4632
4633 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4634
4635 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4636
4637 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4638
4639 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4640 are the mini-buffer and the echo area (bug#3320).
4641
4642 * term.c (init_tty): Remove support for supdup, c10 and perq
4643 terminals, which are no longer supported (bug#1482).
4644
4645 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4646
4647 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4648
4649 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4650
4651 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4652 for non-popups (Bug#3642).
4653
4654 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4655
4656 * alloc.c (reset_malloc_hooks): Protoize.
4657 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4658 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4659 * cm.c (losecursor): Likewise.
4660 * data.c (fmod): Likewise.
4661 * dispnew.c (swap_glyphs_in_rows): Likewise.
4662 * emacs.c (memory_warning_signal): Likewise.
4663 * floatfns.c (float_error): Likewise.
4664 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4665 (otf_open, font_otf_capability, generate_otf_features)
4666 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4667 Likewise.
4668 * image.c (pbm_read_file): Likewise.
4669 * indent.c (string_display_width): Likewise.
4670 * intervals.c (check_for_interval, search_for_interval)
4671 (inc_interval_count, count_intervals, root_interval)
4672 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4673 * lread.c (defalias): Likewise.
4674 * ralloc.c (r_alloc_check): Likewise.
4675 * regex.c (set_image_of_range_1, set_image_of_range)
4676 (regex_grow_registers): Likewise.
4677 * sysdep.c (strerror): Likewise.
4678 * termcap.c (valid_filename_p, tprint, main): Likewise.
4679 * tparam.c (main): Likewise.
4680 * unexhp9k800.c (run_time_remap, save_data_space)
4681 (update_file_ptrs, read_header, write_header, calculate_checksum)
4682 (copy_file, copy_rest, display_header): Likewise.
4683 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4684 Likewise.
4685 * xdisp.c (check_it): Likewise.
4686 * xfaces.c (register_color, unregister_color, unregister_colors):
4687 Likewise.
4688 * xfns.c (print_fontset_result): Likewise.
4689 * xrdb.c (member, fatal, main): Likewise.
4690
4691 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4692
4693 Fix minor problems found by static checking (Bug#9031).
4694 * chartab.c (char_table_set_range, map_sub_char_table):
4695 Remove unused locals.
4696 (uniprop_table): Now static.
4697 * composite.c (_work_char): Remove unused static var.
4698
4699 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4700
4701 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4702
4703 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4704
4705 * gtkutil.c (qttip_cb): Remove code without function.
4706
4707 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4708
4709 * w32.c (pthread_sigmask): New stub.
4710
4711 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4712
4713 Use pthread_sigmask, not sigprocmask (Bug#9010).
4714 sigprocmask is portable only for single-threaded applications, and
4715 Emacs can be multi-threaded when it uses GTK.
4716 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4717 (LIBES): Use it.
4718 * callproc.c (Fcall_process):
4719 * process.c (create_process):
4720 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4721 Use pthread_sigmask, not sigprocmask.
4722
4723 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4724
4725 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4726 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4727 wrong (Bug#8591).
4728
4729 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4730
4731 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4732 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4733 (xg_hide_tooltip): Fix comment.
4734
4735 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4736 in registerServicesMenuSendTypes.
4737 (validRequestorForSendType): Don't check ns_return_types.
4738
4739 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4740 ns_return_type.
4741
4742 2011-07-08 Jason Rumney <jasonr@gnu.org>
4743
4744 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4745 SH_SHOW for hidden windows (Bug#5482).
4746
4747 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4748 frame struct members of non-existent frames (Bug#6284).
4749
4750 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4751
4752 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4753 variable firstTime not needed on OSX >= 10.6.
4754 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4755 >= 10.5. Use setKnobProportion, setDoubleValue.
4756
4757 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4758 (MAC_OS_X_VERSION_10_5): Define if not defined.
4759 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4760 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4761 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4762
4763 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4764 cString and lossyCString on OSX >= 10.4
4765
4766 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4767 sizeToFit on OSX >= 10.2.
4768
4769 * nsimage.m (allocInitFromFile): Don't use deprecated method
4770 bestRepresentationForDevice on OSX >= 10.6.
4771
4772 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4773 to avoid warning.
4774
4775 * emacs.c: Declare unexec_init_emacs_zone.
4776
4777 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4778
4779 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4780
4781 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4782 on svcsMenu (Bug#8842).
4783
4784 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4785 ns_return_types.
4786 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4787
4788 * nsterm.m (QUTF8_STRING): Declare.
4789 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4790 (validRequestorForSendType): Return type is (id).
4791 Change indexOfObjectIdenticalTo to indexOfObject.
4792 Check if we have local selection before returning self (Bug#8842).
4793 (writeSelectionToPasteboard): Put local selection into paste board
4794 if we have a local selection (Bug#8842).
4795 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4796
4797 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4798 (ns_get_local_selection): Declare.
4799
4800 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4801
4802 * keymap.c (describe_map_tree): Don't insert a double newline at
4803 the end of the buffer (bug#1169) and return whether we inserted
4804 something.
4805
4806 * callint.c (Fcall_interactively): Change "reading args" to
4807 "providing args" to try to clarify what it does (bug#1010).
4808
4809 2011-07-07 Kenichi Handa <handa@m17n.org>
4810
4811 * composite.c (composition_compute_stop_pos): Ignore a static
4812 composition starting before CHARPOS (Bug#8915).
4813
4814 * xdisp.c (handle_composition_prop): Likewise.
4815
4816 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4817
4818 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4819 (Bug#9015)
4820
4821 2011-07-07 Kenichi Handa <handa@m17n.org>
4822
4823 * character.h (unicode_category_t): New enum type.
4824
4825 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4826 (Qchar_code_property_table): New variable.
4827 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4828 (UNIPROP_COMPRESSED_FORM_P): New macros.
4829 (char_table_ascii): Uncompress the compressed values.
4830 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4831 Uncompress the compressed values.
4832 (sub_char_table_ref_and_range): Likewise.
4833 (char_table_ref_and_range): Uncompress the compressed values.
4834 (sub_char_table_set): New arg is_uniprop. Callers changed.
4835 Uncompress the compressed values.
4836 (sub_char_table_set_range): Args changed. Callers changed.
4837 (char_table_set_range): Adjuted for the above change.
4838 (map_sub_char_table): Delete args default_val and parent. Add arg
4839 top. Give decoded values to a Lisp function.
4840 (map_char_table): Adjust for the above change. Give decoded
4841 values to a Lisp function. Gcpro more variables.
4842 (uniprop_table_uncompress)
4843 (uniprop_decode_value_run_length): New functions.
4844 (uniprop_decoder, uniprop_decoder_count): New variables.
4845 (uniprop_get_decoder, uniprop_encode_value_character)
4846 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4847 New functions.
4848 (uniprop_encoder, uniprop_encoder_count): New variables.
4849 (uniprop_get_encoder, uniprop_table)
4850 (Funicode_property_table_internal, Fget_unicode_property_internal)
4851 (Fput_unicode_property_internal): New functions.
4852 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4853 Sunicode_property_table_internal, Sget_unicode_property_internal,
4854 and Sput_unicode_property_internal. Defvar_lisp
4855 char-code-property-alist.
4856
4857 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4858 Vunicode_category_table.
4859
4860 * font.c (font_range): Adjust for the change of
4861 Vunicode_category_table.
4862
4863 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4864
4865 * m/iris4d.h: Remove file, move contents ...
4866 * s/irix6-5.h: ... here.
4867
4868 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4869
4870 Remove unportable assumption about struct layout (Bug#8884).
4871 * alloc.c (mark_buffer):
4872 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4873 (clone_per_buffer_values): Don't assume that
4874 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4875 This isn't true in general, and it's particularly not true
4876 if Emacs is configured with --with-wide-int.
4877 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4878 New macros, used in the buffer.c change.
4879
4880 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4881
4882 * xsettings.c: Use both GConf and GSettings if both are available.
4883 (store_config_changed_event): Add comment.
4884 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4885 (store_tool_bar_style_changed): New functions.
4886 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4887 (struct xsettings): Move font inside HAVE_XFT.
4888 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4889 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4890 Move inside HAVE_XFT.
4891 (something_changed_gsettingsCB): Rename from something_changedCB.
4892 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4893 also.
4894 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4895 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4896 (something_changed_gconfCB): Rename from something_changedCB.
4897 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4898 (parse_settings): Move check for font inside HAVE_XFT.
4899 (read_settings, apply_xft_settings): Add comment.
4900 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4901 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4902 call store_font_name_changed.
4903 (xft_settings_event): Add comment.
4904 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4905 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4906 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4907 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4908 (xsettings_initialize): Call init_gsettings last.
4909 (xsettings_get_system_font, xsettings_get_system_normal_font):
4910 Add comment.
4911
4912 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4913
4914 Random fixes. E.g., (random) never returned negative values.
4915 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4916 subseconds part to the entropy, as that's a bit more random.
4917 Prefer signed to unsigned, since the signedness doesn't matter and
4918 in general we prefer signed. When given a limit, use a
4919 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4920 latter isn't right if USE_2_TAGS_FOR_INTS.
4921 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4922 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4923
4924 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4925
4926 * textprop.c (text_property_stickiness):
4927 Obey Vtext_property_default_nonsticky.
4928 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4929 * w32fns.c (syms_of_w32fns):
4930 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4931
4932 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4933
4934 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4935 This is more efficient than Ffile_directory_p and avoids a minor race.
4936
4937 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4938
4939 * buffer.c (Foverlay_put): Say what the return value is
4940 (bug#7835).
4941
4942 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4943 is a directory before asking whether to use the file name
4944 (bug#7564).
4945 (barf_or_query_if_file_exists): Make the "File is a directory"
4946 error be more correct.
4947
4948 * fns.c (Frequire): Remove the mention of the .gz files, since
4949 that's installation-specific, but keep the mention of
4950 `get-load-suffixes'.
4951
4952 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4953
4954 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4955 Report string overflow if the output is too long.
4956
4957 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4958
4959 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4960 (syms_of_gnutls): Remove duplicate DEFSYM for
4961 Qgnutls_bootprop_verify_hostname_error, an error for
4962 Qgnutls_bootprop_verify_error (which is no longer used).
4963
4964 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4965 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4966 Also (re)move comments that are misplaced or no longer relevant.
4967
4968 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4969
4970 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4971
4972 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4973
4974 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4975 and background color parameters if they have been changed.
4976
4977 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4978
4979 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4980
4981 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4982
4983 * xsettings.c (SYSTEM_FONT): Define only when used.
4984 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4985
4986 * keymap.c (access_keymap_1): Now static.
4987
4988 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4989
4990 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4991 leave any prefix arg for the up event (Bug#1586).
4992
4993 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4994
4995 * lread.c (syms_of_lread): Mention single symbols defined by
4996 `defvar' or `defconst' (bug#7154).
4997
4998 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4999 (Frequire): Mention get-load-suffixes.
5000
5001 2011-07-02 Martin Rudalics <rudalics@gmx.at>
5002
5003 * window.h (window): Remove clone_number slot.
5004 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5005 Remove.
5006 (make_parent_window, make_window, saved_window)
5007 (Fset_window_configuration, save_window_save): Don't deal with
5008 clone numbers.
5009 * buffer.c (Qclone_number): Remove declaration.
5010 (sort_overlays, overlay_strings): Don't deal with clone numbers.
5011
5012 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5013
5014 Add multiple inheritance to keymaps.
5015 * keymap.c (Fmake_composed_keymap): New function.
5016 (Fset_keymap_parent): Simplify.
5017 (fix_submap_inheritance): Remove.
5018 (access_keymap_1): New function extracted from access_keymap to handle
5019 embedded parents and handle lists of maps.
5020 (access_keymap): Use it.
5021 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5022 (Fcopy_keymap): Handle embedded parents.
5023 (Fcommand_remapping, define_as_prefix): Simplify.
5024 (Fkey_binding): Simplify.
5025 (syms_of_keymap): Move minibuffer-local-completion-map,
5026 minibuffer-local-filename-completion-map,
5027 minibuffer-local-must-match-map, and
5028 minibuffer-local-filename-must-match-map to Elisp.
5029 (syms_of_keymap): Defsubr make-composed-keymap.
5030 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5031 (parse_menu_item): Trivial simplification.
5032
5033 2011-07-01 Glenn Morris <rgm@gnu.org>
5034
5035 * Makefile.in (SETTINGS_LIBS): Fix typo.
5036
5037 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5038
5039 * coding.c (Fencode_coding_string): Record the last coding system
5040 used, as the function doc string says (bug#8738).
5041
5042 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5043
5044 * xsettings.c (store_monospaced_changed): Take new font as arg and
5045 check for change against current_mono_font.
5046 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5047 (emacs_settings_constructor, emacs_settings_get_property)
5048 (emacs_settings_set_property, emacs_settings_class_init)
5049 (emacs_settings_init, gsettings_obj): Remove.
5050 (something_changedCB): New function for HAVE_GSETTINGS.
5051 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5052 with value as argument.
5053 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5054 g_settings_new (Bug#8967). Do not create gsettings_obj.
5055 Remove calls to g_settings_bind. Connect something_changedCB to
5056 "changed".
5057
5058 * xgselect.c: Add defined (HAVE_GSETTINGS).
5059 (xgselect_initialize): Ditto.
5060
5061 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5062 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5063 xg_select.
5064
5065 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5066
5067 * eval.c (struct backtrace): Simplify and port the data structure.
5068 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5069 signed bit field, as this assumption is not portable and it makes
5070 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5071 "char debug_on_exit : 1" as this is not portable either; instead,
5072 use the portable "unsigned int debug_on_exit : 1". Remove unused
5073 member evalargs. Remove obsolete comments about cc bombing out.
5074
5075 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5076
5077 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
5078 Let HAVE_GSETTINGS override HAVE_GCONF.
5079 (store_monospaced_changed): New function.
5080 (EMACS_SETTINGS): A new type derived from GObject to handle
5081 GSettings notifications.
5082 (emacs_settings_constructor, emacs_settings_get_property)
5083 (emacs_settings_set_property, emacs_settings_class_init):
5084 New functions.
5085 (gsettings_client, gsettings_obj): New variables.
5086 (GSETTINGS_SCHEMA): New define.
5087 (something_changedCB): Call store_monospaced_changed.
5088 (init_gsettings): New function.
5089 (xsettings_initialize): Call init_gsettings.
5090 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5091 to NULL.
5092
5093 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
5094 GCONF_CFLAGS/LIBS.
5095
5096 2011-06-29 Martin Rudalics <rudalics@gmx.at>
5097
5098 * window.c (resize_root_window, grow_mini_window)
5099 (shrink_mini_window): Rename Qresize_root_window to
5100 Qwindow_resize_root_window and Qresize_root_window_vertically to
5101 Qwindow_resize_root_window_vertically.
5102
5103 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5104
5105 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5106
5107 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
5108
5109 * makefile.w32-in: Redesign dependencies so they reflect more
5110 clearly which files are directly included by each source file,
5111 and not through other includes.
5112
5113 2011-06-27 Martin Rudalics <rudalics@gmx.at>
5114
5115 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5116 (sort_overlays, overlay_strings): When an overlay's clone number
5117 matches the window's clone number process the overlay even if
5118 the overlay's window property doesn't match the current window.
5119
5120 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5121 (Fwindow_hchild): Rename to Fwindow_left_child.
5122 (Fwindow_next): Rename to Fwindow_next_sibling.
5123 (Fwindow_prev): Rename to Fwindow_prev_sibling.
5124 (resize_window_check): Rename to window_resize_check.
5125 (resize_window_apply): Rename to window_resize_apply.
5126 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5127 (Fdelete_other_windows_internal, resize_frame_windows)
5128 (Fsplit_window_internal, Fdelete_window_internal)
5129 (grow_mini_window, shrink_mini_window)
5130 (Fresize_mini_window_internal): Fix callers accordingly.
5131
5132 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5133
5134 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5135 (emacs_fixed_set_min_size): Remove.
5136 (emacs_fixed_new): Take frame as argument.
5137
5138 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5139 (_EmacsFixedPrivate): Remove minwidth/height.
5140 Add struct frame *f.
5141 (emacs_fixed_init): Initialize priv->f.
5142 (get_parent_class, emacs_fixed_set_min_size): Remove.
5143 (emacs_fixed_new): Set priv->f to argument.
5144 (emacs_fixed_get_preferred_width)
5145 (emacs_fixed_get_preferred_height): Use min_width/height from
5146 frames size_hint to set minimum and natural (Bug#8919).
5147 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5148 and use min_width/height from frames size_hint to set
5149 min_width/height (Bug#8919).
5150
5151 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
5152 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5153 Fix indentation.
5154
5155 2011-06-26 Eli Zaretskii <eliz@gnu.org>
5156
5157 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5158 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5159 called at ZV.
5160
5161 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
5162
5163 * process.c (wait_reading_process_output): Bypass select if
5164 waiting for a cell while ignoring keyboard input, and input is
5165 pending. Suggested by Jan Djärv (Bug#8869).
5166
5167 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5168
5169 Use gnulib's dup2 module instead of rolling our own.
5170 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5171
5172 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5173
5174 * dispnew.c (scrolling_window): Before scrolling, turn off a
5175 mouse-highlight in the window being scrolled.
5176
5177 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
5178
5179 Move DEFSYM to lisp.h and use everywhere.
5180
5181 * character.h (DEFSYM): Move declaration...
5182 * lisp.h (DEFSYM): ...here.
5183
5184 * gnutls.c:
5185 * minibuf.c:
5186 * w32menu.c:
5187 * w32proc.c:
5188 * w32select.c: Don't include character.h.
5189
5190 * alloc.c (syms_of_alloc):
5191 * buffer.c (syms_of_buffer):
5192 * bytecode.c (syms_of_bytecode):
5193 * callint.c (syms_of_callint):
5194 * casefiddle.c (syms_of_casefiddle):
5195 * casetab.c (init_casetab_once):
5196 * category.c (init_category_once, syms_of_category):
5197 * ccl.c (syms_of_ccl):
5198 * cmds.c (syms_of_cmds):
5199 * composite.c (syms_of_composite):
5200 * dbusbind.c (syms_of_dbusbind):
5201 * dired.c (syms_of_dired):
5202 * dispnew.c (syms_of_display):
5203 * doc.c (syms_of_doc):
5204 * editfns.c (syms_of_editfns):
5205 * emacs.c (syms_of_emacs):
5206 * eval.c (syms_of_eval):
5207 * fileio.c (syms_of_fileio):
5208 * fns.c (syms_of_fns):
5209 * frame.c (syms_of_frame):
5210 * fringe.c (syms_of_fringe):
5211 * insdel.c (syms_of_insdel):
5212 * keymap.c (syms_of_keymap):
5213 * lread.c (init_obarray, syms_of_lread):
5214 * macros.c (syms_of_macros):
5215 * msdos.c (syms_of_msdos):
5216 * print.c (syms_of_print):
5217 * process.c (syms_of_process):
5218 * search.c (syms_of_search):
5219 * sound.c (syms_of_sound):
5220 * syntax.c (init_syntax_once, syms_of_syntax):
5221 * terminal.c (syms_of_terminal):
5222 * textprop.c (syms_of_textprop):
5223 * undo.c (syms_of_undo):
5224 * w32.c (globals_of_w32):
5225 * window.c (syms_of_window):
5226 * xdisp.c (syms_of_xdisp):
5227 * xfaces.c (syms_of_xfaces):
5228 * xfns.c (syms_of_xfns):
5229 * xmenu.c (syms_of_xmenu):
5230 * xsettings.c (syms_of_xsettings):
5231 * xterm.c (syms_of_xterm): Use DEFSYM.
5232
5233 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5234
5235 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5236
5237 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5238
5239 Integer and buffer overflow fixes (Bug#8873).
5240
5241 * print.c (printchar, strout): Check for string overflow.
5242 (PRINTPREPARE, printchar, strout):
5243 Don't set size unless allocation succeeds.
5244
5245 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5246 for sizes. Check for string overflow more accurately.
5247 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5248
5249 * macros.c: Integer and buffer overflow fixes.
5250 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5251 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5252 Use ptrdiff_t, not int, for sizes.
5253 Don't increment bufsize until after realloc succeeds.
5254 Check for size-calculation overflow.
5255 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5256
5257 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5258
5259 * lread.c: Integer overflow fixes.
5260 (read_integer): Radix is now EMACS_INT, not int,
5261 to improve quality of diagnostics for out-of-range radices.
5262 Calculate buffer size correctly for out-of-range radices.
5263 (read1): Check for integer overflow in radices, and in
5264 read-circle numbers.
5265 (read_escape): Avoid int overflow.
5266 (Fload, openp, read_buffer_size, read1)
5267 (substitute_object_recurse, read_vector, read_list, map_obarray):
5268 Use ptrdiff_t, not int, for sizes.
5269 (read1): Use EMACS_INT, not int, for sizes.
5270 Check for size overflow.
5271
5272 * image.c (cache_image): Check for size arithmetic overflow.
5273
5274 * lread.c: Integer overflow issues.
5275 (saved_doc_string_size, saved_doc_string_length)
5276 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5277 Now ptrdiff_t, not int.
5278 (read1): Don't assume doc string length fits in int. Check for
5279 out-of-range doc string lengths.
5280 (read_list): Don't assume file position fits in int.
5281 (read_escape): Check for hex character overflow.
5282
5283 2011-06-22 Leo Liu <sdl.web@gmail.com>
5284
5285 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5286 Move to minibuffer.el.
5287
5288 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5289
5290 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5291 The following patches are for when GLYPH_DEBUG && !XASSERT.
5292 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5293 * dispnew.c (flush_stdout):
5294 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5295 Mark as externally visible.
5296 * dispnew.c (check_window_matrix_pointers): Now static.
5297 * dispnew.c (window_to_frame_vpos):
5298 * xfns.c (unwind_create_frame):
5299 * xterm.c (x_check_font): Remove unused local.
5300 * scroll.c (CHECK_BOUNDS):
5301 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5302 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5303 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5304 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5305 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5306 Now static.
5307 (debug_method_add): Use va_list and vsprintf rather than relying
5308 on undefined behavior with wrong number of arguments.
5309 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5310 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5311 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5312 since we're not interested in debugging glyphs with old libraries.
5313 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5314 GCC 4.6.0's static checking.
5315
5316 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5317
5318 Integer overflow and signedness fixes (Bug#8873).
5319 A few related buffer overrun fixes, too.
5320
5321 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5322
5323 * dispextern.h (struct face.stipple):
5324 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5325 (x_bitmap_mask, x_allocate_bitmap_record)
5326 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5327 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5328 (x_create_bitmap_from_xpm_data):
5329 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5330 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5331 (.bitmaps_last):
5332 * xfaces.c (load_pixmap):
5333 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5334 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5335 (.bitmaps_last, struct x_output.icon_bitmap):
5336 Use ptrdiff_t, not int, for bitmap indexes.
5337 (x_allocate_bitmap_record): Check for size overflow.
5338 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5339
5340 Use ptrdiff_t, not int, for overlay counts.
5341 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5342 * editfns.c (overlays_around, get_pos_property):
5343 * textprop.c (get_char_property_and_overlay):
5344 * xdisp.c (next_overlay_change, note_mouse_highlight):
5345 * xfaces.c (face_at_buffer_position):
5346 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5347 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5348 (Fnext_overlay_change, Fprevious_overlay_change)
5349 (mouse_face_overlay_overlaps, Foverlays_in):
5350 Use ptrdiff_t, not int, for sizes.
5351 (overlays_at, overlays_in): Check for size-calculation overflow.
5352
5353 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5354
5355 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5356 (x_session_initialize): Do not assume string length fits in int.
5357
5358 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5359 This is unlikely, but can occur if DPI is outlandish.
5360
5361 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5362 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5363
5364 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5365 * xrdb.c (magic_file_p, search_magic_path):
5366 Omit last arg SUFFIX; it was always 0. All callers changed.
5367 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5368
5369 * xfont.c (xfont_match): Avoid need for strlen.
5370
5371 * xfns.c: Don't assume strlen fits in int.
5372 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5373
5374 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5375 not unsigned long, as we prefer signed integers. All callers changed.
5376 Detect integer overflow in repeat count.
5377 (message_dolog): Don't assume print length fits in 39 bytes.
5378 (display_mode_element): Don't assume strlen fits in int.
5379
5380 * termcap.c: Don't assume sizes fit in int and never overflow.
5381 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5382 (gobble_line): Check for size-calculation overflow.
5383
5384 * minibuf.c (Fread_buffer):
5385 * lread.c (intern, intern_c_string):
5386 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5387 Don't assume string length fits in int.
5388
5389 * keyboard.c (parse_tool_bar_item):
5390 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5391
5392 * font.c: Don't assume string length fits in int.
5393 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5394 Use ptrdiff_t, not int.
5395 (font_intern_prop): Don't assume string length fits in int.
5396 Don't assume integer property fits in fixnum.
5397 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5398
5399 * filelock.c: Fix some buffer overrun and integer overflow issues.
5400 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5401 Reformulate so as not to need the command string.
5402 Invoke gzip -cd rather than gunzip, as it's more portable.
5403 (lock_info_type, lock_file_1, lock_file):
5404 Don't assume pid_t and time_t fit in unsigned long.
5405 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5406 (current_lock_owner): Prefer signed type for sizes.
5407 Use memcpy, not strncpy, where memcpy is what is really wanted.
5408 Don't assume (via atoi) that time_t and pid_t fit in int.
5409 Check for time_t and/or pid_t out of range, e.g., via a network share.
5410 Don't alloca where an auto var works fine.
5411
5412 * fileio.c: Fix some integer overflow issues.
5413 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5414 Don't assume string length fits in int.
5415 (directory_file_name): Don't assume string length fits in long.
5416 (make_temp_name): Don't assume pid fits in int, or that its print
5417 length is less than 20.
5418
5419 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5420
5421 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5422
5423 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5424
5425 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5426 We prefer signed integers, even for size calculations.
5427
5428 * emacs.c: Don't assume string length fits in 'int'.
5429 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5430 (main): Don't invoke strlen when not needed.
5431
5432 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5433 (XD_DEBUG_MESSAGE): Don't waste a byte.
5434
5435 * callproc.c (getenv_internal_1, getenv_internal)
5436 (Fgetenv_internal):
5437 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5438
5439 * lread.c (invalid_syntax): Omit length argument.
5440 All uses changed. This doesn't fix a bug, but it simplifies the
5441 code away from its former Hollerith-constant appearance, and it's
5442 one less 'int' to worry about when looking at integer-overflow issues.
5443 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5444
5445 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5446 This didn't break anything, but it didn't help either.
5447 It's confusing to put a bogus integer in a place where the actual
5448 value does not matter.
5449 (LIST_END_P): Remove unused macro and its bogus comment.
5450 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5451
5452 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5453 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5454 implementation.
5455 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5456 We prefer signed types, and the value cannot exceed the EMACS_INT
5457 range anyway (because otherwise the length would not be representable).
5458 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5459 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5460 This avoids a GCC warning when WIDE_EMACS_INT.
5461
5462 * indent.c (sane_tab_width): New function.
5463 (current_column, scan_for_column, Findent_to, position_indentation)
5464 (compute_motion): Use it. This is just for clarity.
5465 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5466
5467 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5468
5469 * lisp.h (lint_assume): New macro.
5470 * composite.c (composition_gstring_put_cache):
5471 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5472
5473 * editfns.c, insdel.c:
5474 Omit unnecessary forward decls, to simplify future changes.
5475
5476 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5477
5478 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5479
5480 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5481 Use much-faster test for byte-length change.
5482 Don't assume string byte-length fits in 'int'.
5483 Check that character arg fits in 'int'.
5484 (mapcar1): Declare byte as byte, for clarity.
5485
5486 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5487
5488 * fns.c (concat): Catch string overflow earlier.
5489 Do not rely on integer wraparound.
5490
5491 * dispextern.h (struct it.overlay_strings_charpos)
5492 (struct it.selective): Now EMACS_INT, not int.
5493 * xdisp.c (forward_to_next_line_start)
5494 (back_to_previous_visible_line_start)
5495 (reseat_at_next_visible_line_start, next_element_from_buffer):
5496 Don't arbitrarily truncate the value of 'selective' to int.
5497
5498 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5499
5500 * composite.c: Don't truncate sizes to 'int'.
5501 (composition_gstring_p, composition_reseat_it)
5502 (composition_adjust_point): Use EMACS_INT, not int.
5503 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5504 not EMACS_UINT, for indexes.
5505
5506 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5507
5508 * buffer.c: Include <verify.h>.
5509 (struct sortvec.priority, struct sortstr.priority):
5510 Now EMACS_INT, not int.
5511 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5512 (struct sortstr.size, record_overlay_string)
5513 (struct sortstrlist.size, struct sortlist.used):
5514 Don't truncate size to int.
5515 (record_overlay_string): Check for size-calculation overflow.
5516 (init_buffer_once): Check at compile-time, not run-time.
5517
5518 2011-06-22 Jim Meyering <meyering@redhat.com>
5519
5520 Don't leak an XBM-image-sized buffer
5521 * image.c (xbm_load): Free the image buffer after using it.
5522
5523 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5524
5525 Port to Sun C.
5526 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5527 that Sun C diagnosed.
5528 * fns.c (secure_hash): Fix pointer signedness issue.
5529 * intervals.c (static_offset_intervals): New function.
5530 (offset_intervals): Use it.
5531
5532 2011-06-21 Leo Liu <sdl.web@gmail.com>
5533
5534 * deps.mk (fns.o):
5535 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5536 sha512.h.
5537
5538 * fns.c (secure_hash): Rename from crypto_hash_function and change
5539 the first arg to accept symbols.
5540 (Fsecure_hash): New primitive.
5541 (syms_of_fns): New symbols.
5542
5543 2011-06-20 Deniz Dogan <deniz@dogan.se>
5544
5545 * process.c (Fset_process_buffer): Clarify return value in
5546 docstring.
5547
5548 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5549
5550 * dispnew.c (add_window_display_history): Use BVAR.
5551
5552 * xdisp.c (debug_method_add): Use BVAR.
5553 (check_window_end, dump_glyph_matrix, dump_glyph)
5554 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5555
5556 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5557 Likewise.
5558
5559 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5560 check till after the cache is created in init_frame_faces.
5561
5562 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5563
5564 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5565
5566 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5567
5568 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5569 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5570 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5571
5572 Improve buffer-overflow checking (Bug#8873).
5573 * fileio.c (Finsert_file_contents):
5574 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5575 Remove the old (too-loose) buffer overflow checks.
5576 They weren't needed, since make_gap checks for buffer overflow.
5577 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5578 The old code merely checked for Emacs fixnum overflow, and relied
5579 on undefined (wraparound) behavior. The new code avoids undefined
5580 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5581
5582 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5583 Tune. Don't use wider integers than needed. Don't use alloca.
5584 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5585
5586 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5587
5588 * insdel.c, lisp.h (buffer_overflow): New function.
5589 (insert_from_buffer_1, replace_range, replace_range_2):
5590 * insdel.c (make_gap_larger):
5591 * editfns.c (Finsert_char):
5592 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5593
5594 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5595
5596 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5597
5598 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5599
5600 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5601 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5602
5603 * fileio.c: Don't assume EMACS_INT fits in off_t.
5604 (emacs_lseek): New static function.
5605 (Finsert_file_contents, Fwrite_region): Use it.
5606 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5607
5608 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5609
5610 * fns.c: Don't overflow int when computing a list length.
5611 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5612 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5613 truncation on 64-bit hosts. Check for QUIT every
5614 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5615 faster and is responsive enough.
5616 (Flength): Report an error instead of overflowing an integer.
5617 (Fsafe_length): Return a float if the value is not representable
5618 as a fixnum. This shouldn't happen except in contrived situations.
5619 (Fnthcdr, Fsort): Don't assume list length fits in int.
5620 (Fcopy_sequence): Don't assume vector length fits in int.
5621
5622 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5623 (header_size, word_size): New constants.
5624 (allocate_vectorlike): Don't check size overflow here.
5625 (allocate_vector): Check it here instead, since this is the only
5626 caller of allocate_vectorlike that could cause overflow.
5627 Check that the new vector's length is representable as a fixnum.
5628
5629 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5630 The previous code was bogus. For example, next_almost_prime (32)
5631 returned 39, which is undesirable as it is a multiple of 3; and
5632 next_almost_prime (24) returned 25, which is a multiple of 5 so
5633 why was the code bothering to check for multiples of 7?
5634
5635 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5636
5637 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5638
5639 Variadic C functions now count arguments with ptrdiff_t.
5640 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5641 Back then I didn't know that the Emacs coding style prefers signed int.
5642 Also, in the meantime I found a few more instances where arguments
5643 were being counted with int, which may truncate counts on 64-bit
5644 machines, or EMACS_INT, which may be unnecessarily wide.
5645 * lisp.h (struct Lisp_Subr.function.aMANY)
5646 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5647 Arg counts are now ptrdiff_t, not size_t.
5648 All variadic functions and their callers changed accordingly.
5649 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5650 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5651 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5652 * callint.c (Fcall_interactively): Check arg count for overflow,
5653 to avoid potential buffer overrun. Use signed char, not 'int',
5654 for 'varies' array, so that we needn't bother to check its size
5655 calculation for overflow.
5656 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5657 * eval.c (apply_lambda):
5658 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5659 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5660 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5661
5662 * callint.c (Fcall_interactively): Don't use index var as event count.
5663
5664 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5665 * mem-limits.h (SIZE): Remove; no longer used.
5666
5667 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5668
5669 Remove unnecessary casts.
5670 * xterm.c (x_term_init):
5671 * xfns.c (x_set_border_pixel):
5672 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5673 These aren't needed now that we assume ANSI C.
5674
5675 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5676 It's more likely to cause problems (due to unsigned overflow)
5677 than to cure them.
5678
5679 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5680
5681 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5682
5683 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5684
5685 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5686
5687 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5688
5689 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5690
5691 GLYPH_CODE_FACE returns EMACS_INT, not int.
5692 * dispextern.h (merge_faces):
5693 * xfaces.c (merge_faces):
5694 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5695 Don't assume EMACS_INT fits in int.
5696
5697 * character.h (CHAR_VALID_P): Remove unused parameter.
5698 * fontset.c, lisp.h, xdisp.c: All uses changed.
5699
5700 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5701
5702 * fns.c (concat): Minor tuning based on overflow analysis.
5703 This doesn't fix any bugs. Use int to hold character, instead
5704 of constantly refetching from Emacs object. Use XFASTINT, not
5705 XINT, for value known to be a character. Don't bother comparing
5706 a single byte to 0400, as it's always less.
5707
5708 * floatfns.c (Fexpt):
5709 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5710
5711 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5712 for characters.
5713
5714 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5715
5716 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5717 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5718 incorrectly succeed when S was a string, because 4294967386 was
5719 truncated before it was used.
5720
5721 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5722 Otherwise, an out-of-range integer could cause undefined behavior
5723 on a 64-bit host.
5724
5725 * composite.c: Use int, not EMACS_INT, for characters.
5726 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5727 EMACS_INT, for values that are known to be in character range.
5728 This doesn't fix any bugs but is the usual style inside Emacs and
5729 may generate better code on 32-bit machines.
5730
5731 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5732 This is for reasons similar to the recent CHAR_STRING fix.
5733 * charset.c (Fencode_char): Check that character arg is actually
5734 a character. Pass an int to ENCODE_CHAR.
5735 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5736 wider than 'int', as a compile-time check to prevent future regressions
5737 in this area.
5738
5739 * character.c (char_string): Remove unnecessary casts.
5740
5741 Make sure a 64-bit char is never passed to CHAR_STRING.
5742 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5743 by silently ignoring the top 32 bits, allowing some values
5744 that were far too large to be valid characters.
5745 * character.h: Include <verify.h>.
5746 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5747 arguments are no wider than unsigned, as a compile-time check
5748 to prevent future regressions in this area.
5749 * data.c (Faset):
5750 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5751 (Fsubst_char_in_region):
5752 * fns.c (concat):
5753 * xdisp.c (decode_mode_spec_coding):
5754 Adjust to CHAR_STRING's new requirement.
5755 * editfns.c (Finsert_char, Fsubst_char_in_region):
5756 * fns.c (concat): Check that character args are actually
5757 characters. Without this test, these functions did the wrong
5758 thing with wildly out-of-range values on 64-bit hosts.
5759
5760 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5761 These casts should not be needed on 32-bit hosts, either.
5762 * keyboard.c (read_char):
5763 * lread.c (Fload): Remove casts to unsigned.
5764
5765 * lisp.h (UNSIGNED_CMP): New macro.
5766 This fixes comparison bugs on 64-bit hosts.
5767 (ASCII_CHAR_P): Use it.
5768 * casefiddle.c (casify_object):
5769 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5770 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5771 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5772 * dispextern.h (FACE_FROM_ID):
5773 * keyboard.c (read_char): Use UNSIGNED_CMP.
5774
5775 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5776 not to EMACS_INT, to avoid GCC warning.
5777
5778 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5779
5780 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5781 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5782 isn't needed on 32-bit machines.
5783
5784 * buffer.c (Fgenerate_new_buffer_name):
5785 Use EMACS_INT for count, not int.
5786 (advance_to_char_boundary): Return EMACS_INT, not int.
5787
5788 * data.c (Qcompiled_function): Now static.
5789
5790 * window.c (window_body_lines): Now static.
5791
5792 * image.c (gif_load): Rename local to avoid shadowing.
5793
5794 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5795 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5796 * alloc.c (make_save_value): Integer argument is now of type
5797 ptrdiff_t, not int.
5798 (mark_object): Use ptrdiff_t, not int.
5799 * lisp.h (pD): New macro.
5800 * print.c (print_object): Use it.
5801
5802 * alloc.c: Use EMACS_INT, not int, to count objects.
5803 (total_conses, total_markers, total_symbols, total_vector_size)
5804 (total_free_conses, total_free_markers, total_free_symbols)
5805 (total_free_floats, total_floats, total_free_intervals)
5806 (total_intervals, total_strings, total_free_strings):
5807 Now EMACS_INT, not int. All uses changed.
5808 (Fgarbage_collect): Compute overall total using a double, so that
5809 integer overflow is less likely to be a problem. Check for overflow
5810 when converting back to an integer.
5811 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5812 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5813 These were 'int' variables that could overflow on 64-bit hosts;
5814 they were never used, so remove them instead of repairing them.
5815 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5816 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5817 Previously, this ceilinged at INT_MAX, but that doesn't work on
5818 64-bit machines.
5819 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5820
5821 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5822 (allocate_vectorlike): Check for ptrdiff_t overflow.
5823 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5824 when a (possibly-narrower) signed value would do just as well.
5825 We prefer using signed arithmetic, to avoid comparison confusion.
5826
5827 * alloc.c: Catch some string size overflows that we were missing.
5828 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5829 for convenience in STRING_BYTES_MAX.
5830 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5831 The definition here is exact; the one in lisp.h was approximate.
5832 (allocate_string_data): Check for string overflow. This catches
5833 some instances we weren't catching before. Also, it catches
5834 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5835 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5836 and ptrdiff_t and EMACS_INT are both 64 bits.
5837
5838 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5839 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5840 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5841
5842 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5843
5844 * alloc.c (Fmake_string): Check for out-of-range init.
5845
5846 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5847
5848 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5849
5850 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5851
5852 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5853 xg_get_default_scrollbar_width.
5854
5855 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5856 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5857 (style_changed_cb): Call update_theme_scrollbar_width and call
5858 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5859 all frames (Bug#8505).
5860 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5861 Call gtk_window_set_resizable if HAVE_GTK3.
5862 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5863 and height if HAVE_GTK3 (Bug#8505).
5864 (scroll_bar_width_for_theme): New variable.
5865 (update_theme_scrollbar_width): New function.
5866 (xg_get_default_scrollbar_width): Move code to
5867 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5868 (xg_initialize): Call update_theme_scrollbar_width.
5869
5870 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5871
5872 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5873
5874 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5875
5876 * frame.c (make_frame): Call other_buffer_safely instead of
5877 other_buffer.
5878
5879 * window.c (temp_output_buffer_show): Call display_buffer with
5880 second argument Vtemp_buffer_show_specifiers and reset latter
5881 immediately after the call.
5882 (Vtemp_buffer_show_specifiers): New variable.
5883 (auto_window_vscroll_p, next_screen_context_lines)
5884 (Vscroll_preserve_screen_position): Remove leading asterisks from
5885 doc-strings.
5886
5887 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5888
5889 Fix minor problems found by GCC 4.6.0 static checking.
5890 * buffer.c (Qclone_number): Remove for now, as it's unused.
5891 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5892 (record_buffer): Remove unused local.
5893 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5894 (set_frame_buffer_list): Remove; unused.
5895 * frame.h (other_visible_frames): Remove decl.
5896 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5897 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5898 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5899 if HAVE_GPM.
5900 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5901 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5902 Define only if HAVE_GPM.
5903 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5904 (update_hints_inhibit): Remove; never set. All uses removed.
5905 * widgetprv.h (emacsFrameClassRec): Remove decl.
5906 * window.c (delete_deletable_window): Now returns void, since it
5907 wasn't returning anything.
5908 (compare_window_configurations): Remove unused locals.
5909 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5910 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5911 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5912 the same widths as pointers. This follows up on the 2011-05-06 patch.
5913 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5914 * xterm.h: Likewise.
5915 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5916
5917 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5918
5919 * makefile.w32-in: Update dependencies.
5920 (LISP_H): Add lib/intprops.h.
5921
5922 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5923
5924 * image.c (gif_load): Add animation frame delay to the metadata.
5925 (syms_of_image): Use DEFSYM. New symbol `delay'.
5926
5927 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5928
5929 * window.c (delete_deletable_window): Re-add.
5930 (Fset_window_configuration): Rewrite to handle dead buffers and
5931 consequently deletable windows.
5932 (window_tree, Fwindow_tree): Remove. Supply functionality in
5933 window.el.
5934 (compare_window_configurations): Simplify code.
5935
5936 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5937
5938 * image.c (imagemagick_load_image): Fix type mismatch.
5939 (Fimagemagick_types): Likewise.
5940
5941 * window.h (replace_buffer_in_windows): Declare.
5942
5943 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5944
5945 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5946 Qclone_number. Remove external declaration of Qdelete_window.
5947 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5948 code.
5949 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5950 Run Qbuffer_list_update_hook if allowed.
5951 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5952 buffer list implementation.
5953 (other_buffer_safely): New function.
5954 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5955 calls to replace_buffer_in_windows and
5956 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5957 if allowed.
5958 (record_buffer): Inhibit quitting and rewrite using quittable
5959 functions. Run Qbuffer_list_update_hook if allowed.
5960 (Frecord_buffer, Funrecord_buffer): New functions.
5961 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5962 Move switch-to-buffer to window.el.
5963 (bury-buffer): Move to window.el.
5964 (Vbuffer_list_update_hook): New variable.
5965
5966 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5967 section.
5968
5969 * window.h (resize_frame_windows): Move up in code.
5970 (Fwindow_frame): Remove EXFUN.
5971 (replace_buffer_in_all_windows): Remove prototype.
5972 (replace_buffer_in_windows_safely): Add prototype.
5973
5974 * window.c: Declare Qdelete_window static again. Move down
5975 declaration of select_count.
5976 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5977 (Fother_window): Move to window.el.
5978 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5979 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5980 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5981 window.el.
5982 (replace_buffer_in_windows): Implement by calling
5983 Qreplace_buffer_in_windows.
5984 (replace_buffer_in_all_windows): Remove with some functionality
5985 moved into replace_buffer_in_windows_safely.
5986 (replace_buffer_in_windows_safely): New function.
5987 (select_window_norecord, select_frame_norecord): Move in front
5988 of run_window_configuration_change_hook. Remove now obsolete
5989 declarations.
5990 (Fset_window_buffer): Rewrite doc-string.
5991 Call Qrecord_window_buffer.
5992 (keys_of_window): Move binding for other-window to window.el.
5993
5994 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5995
5996 * dispextern.h (struct image): Replace data member, whose int_val
5997 and ptr_val fields were not used by anything, with a single
5998 lisp_val object.
5999
6000 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
6001 (gif_clear_image, gif_load, imagemagick_load_image)
6002 (gs_clear_image, gs_load): Callers changed.
6003
6004 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
6005
6006 * buffer.h: Include <time.h>, for time_t.
6007 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
6008
6009 Fix minor problems found by static checking.
6010
6011 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6012
6013 Make identifiers static if they are not used in other modules.
6014 * data.c (Qcompiled_function, Qframe, Qvector):
6015 * image.c (QimageMagick, Qsvg):
6016 * minibuf.c (Qmetadata):
6017 * window.c (resize_window_check, resize_root_window): Now static.
6018 * window.h (resize_window_check, resize_root_window): Remove decls.
6019
6020 * window.c (window_deletion_count, delete_deletable_window):
6021 Remove; unused.
6022 (window_body_lines): Now static.
6023 (Fdelete_other_windows_internal): Mark vars as initialized.
6024 Make sure 'resize_failed' is initialized.
6025 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6026 (resize_window_apply): Remove unused local.
6027 * window.h (delete_deletable_window): Remove decl.
6028
6029 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
6030 (imagemagick_load_image): Fix pointer signedness problem by changing
6031 last arg from unsigned char * to char *. All uses changed.
6032 Also, fix a local for similar reasons.
6033 Remove unused locals. Remove locals to avoid shadowing.
6034 (fn_rsvg_handle_free): Remove; unused.
6035 (svg_load, svg_load_image): Fix pointer signedness problem.
6036 (imagemagick_load_image): Don't use garbage pointer image_wand.
6037
6038 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6039
6040 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
6041
6042 * image.c (gif_load): Fix omitted cast error introduced by
6043 2011-06-06 change.
6044
6045 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6046
6047 * window.h (resize_proportionally, orig_total_lines)
6048 (orig_top_line): Remove from window structure.
6049 (set_window_height, set_window_width, change_window_heights)
6050 (Fdelete_window): Remove prototypes.
6051 (resize_frame_windows): Remove duplicate declaration.
6052
6053 2011-06-10 Eli Zaretskii <eliz@gnu.org>
6054
6055 * window.h (resize_frame_windows, resize_window_check)
6056 (delete_deletable_window, resize_root_window)
6057 (resize_frame_windows): Declare prototypes.
6058
6059 * window.c (resize_window_apply): Make definition be "static" to
6060 match the prototype.
6061
6062 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6063
6064 * window.c: Remove declarations of Qwindow_size_fixed,
6065 window_min_size_1, window_min_size_2, window_min_size,
6066 size_window, window_fixed_size_p, enlarge_window, delete_window.
6067 Remove static from declaration of Qdelete_window, it's
6068 temporarily needed by Fbury_buffer.
6069 (replace_window): Don't assign orig_top_line and
6070 orig_total_lines.
6071 (Fdelete_window, delete_window): Remove. Window deletion is
6072 handled by window.el.
6073 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6074 Replace Fdelete_window calls with calls to Qdelete_window.
6075 (Fdelete_other_windows): Remove. Deleting other windows is
6076 handled by window.el.
6077 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6078 handled in window.el.
6079 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6080 Window minimum sizes are handled in window.el.
6081 (shrink_windows, size_window, set_window_height)
6082 (set_window_width, change_window_heights, window_height)
6083 (window_width, CURBEG, CURSIZE, enlarge_window)
6084 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6085 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6086 handled in window.el.
6087 (make_dummy_parent): Rename to make_parent_window and give it a
6088 second argument horflag.
6089 (make_window): Don't set resize_proportionally any more.
6090 (Fsplit_window): Remove. Windows are split in window.el.
6091 (save_restore_action, save_restore_orig_size)
6092 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6093 Resize mini windows in window.el.
6094 (grow_mini_window, shrink_mini_window): Implement by calling
6095 Qresize_root_window_vertically, resize_window_check and
6096 resize_window_apply.
6097 (saved_window, Fset_window_configuration, save_window_save):
6098 Do not handle orig_top_line, orig_total_lines, and
6099 resize_proportionally.
6100 (window_min_height, window_min_width): Move to window.el.
6101 (keys_of_window): Move bindings for delete-other-windows,
6102 split-window, delete-window and enlarge-window to window.el.
6103
6104 * buffer.c: Temporarily extern Qdelete_window.
6105 (Fbury_buffer): Temporarily call Qdelete_window instead of
6106 Fdelete_window (Fbury_buffer will move to window.el soon).
6107
6108 * frame.c (set_menu_bar_lines_1): Remove code handling
6109 orig_top_line and orig_total_lines.
6110
6111 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6112 set_window_height but set heights directly.
6113 (change_frame_size_1): Use resize_frame_windows.
6114
6115 * xdisp.c (init_xdisp): Don't use set_window_height but set
6116 heights directly.
6117
6118 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6119 Use resize_frame_windows instead of change_window_heights and run
6120 run_window_configuration_change_hook.
6121
6122 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6123 instead of change_window_heights and run
6124 run_window_configuration_change_hook.
6125
6126 2011-06-09 Martin Rudalics <rudalics@gmx.at>
6127
6128 * window.c (replace_window): Rename second argument REPLACEMENT to
6129 NEW. New third argument SETFLAG. Rewrite.
6130 (delete_window, make_dummy_parent): Call replace_window with
6131 third argument 1.
6132 (window_list_1): Move down in code.
6133 (run_window_configuration_change_hook): Move set_buffer part
6134 before select_frame_norecord part in order to unwind correctly.
6135 Rename count1 to count.
6136 (recombine_windows, delete_deletable_window, resize_root_window)
6137 (Fdelete_other_windows_internal)
6138 (Frun_window_configuration_change_hook, make_parent_window)
6139 (resize_window_check, resize_window_apply, Fresize_window_apply)
6140 (resize_frame_windows, Fsplit_window_internal)
6141 (Fdelete_window_internal, Fresize_mini_window_internal):
6142 New functions.
6143 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6144
6145 2011-06-08 Martin Rudalics <rudalics@gmx.at>
6146
6147 * window.h (window): Add some new members to window structure -
6148 normal_lines, normal_cols, new_total, new_normal, clone_number,
6149 splits, nest, prev_buffers, next_buffers.
6150 (WINDOW_TOTAL_SIZE): Move here from window.c.
6151 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
6152
6153 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6154 Remove.
6155 (make_dummy_parent): Set new members of windows structure.
6156 (make_window): Move down in code. Handle new members of window
6157 structure.
6158 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6159 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6160 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6161 (Fset_window_prev_buffers, Fwindow_next_buffers)
6162 (Fset_window_next_buffers, Fset_window_clone_number):
6163 New functions.
6164 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6165 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6166 Doc-string fixes.
6167 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6168 Argument WINDOW can be now internal window too.
6169 (Fwindow_use_time): Move up in code.
6170 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6171 Rewrite doc-string.
6172 (Fset_window_configuration, saved_window)
6173 (Fcurrent_window_configuration, save_window_save): Handle new
6174 members of window structure.
6175 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6176 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6177 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6178 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6179 Qget_mru_window, Qresize_root_window,
6180 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6181 Qauto_buffer_name; staticpro them.
6182
6183 2011-06-07 Martin Rudalics <rudalics@gmx.at>
6184
6185 * window.c (Fwindow_total_size, Fwindow_left_column)
6186 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6187 (Fwindow_list_1): New functions.
6188 (window_box_text_cols): Replace with window_body_cols.
6189 (Fwindow_width, Fscroll_left, Fscroll_right):
6190 Use window_body_cols instead of window_box_text_cols.
6191 (delete_window, Fset_window_configuration):
6192 Call delete_all_subwindows with window as argument.
6193 (delete_all_subwindows): Take a window as argument and not a
6194 structure. Rewrite.
6195 (window_loop): Remove handling of GET_LRU_WINDOW and
6196 GET_LARGEST_WINDOW.
6197 (Fget_lru_window, Fget_largest_window): Move to window.el.
6198
6199 * window.h: Extern window_body_cols instead of
6200 window_box_text_cols. delete_all_subwindows now takes a
6201 Lisp_Object as argument.
6202
6203 * indent.c (compute_motion, Fcompute_motion):
6204 Use window_body_cols instead of window_box_text_cols.
6205
6206 * frame.c (delete_frame): Call delete_all_subwindows with root
6207 window as argument.
6208
6209 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6210
6211 * fns.c (Fputhash): Document return value.
6212
6213 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
6214
6215 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6216
6217 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6218
6219 Cons<->int and similar integer overflow fixes (Bug#8794).
6220
6221 Check for overflow when converting integer to cons and back.
6222 * charset.c (Fdefine_charset_internal, Fdecode_char):
6223 Use cons_to_unsigned to catch overflow.
6224 (Fencode_char): Use INTEGER_TO_CONS.
6225 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6226 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6227 * data.c (long_to_cons, cons_to_long): Remove.
6228 (cons_to_unsigned, cons_to_signed): New functions.
6229 These signal an error for invalid or out-of-range values.
6230 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6231 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6232 * font.c (Ffont_variation_glyphs):
6233 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6234 * lisp.h: Include <intprops.h>.
6235 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6236 (cons_to_signed, cons_to_unsigned): New decls.
6237 (long_to_cons, cons_to_long): Remove decls.
6238 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6239 (Fprimitive_undo): Use CONS_TO_INTEGER.
6240 * xfns.c (Fx_window_property): Likewise.
6241 * xselect.c: Include <limits.h>.
6242 (x_own_selection, selection_data_to_lisp_data):
6243 Use INTEGER_TO_CONS.
6244 (x_handle_selection_request, x_handle_selection_clear)
6245 (x_get_foreign_selection, Fx_disown_selection_internal)
6246 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6247 (lisp_data_to_selection_data): Use cons_to_unsigned.
6248 (x_fill_property_data): Use cons_to_signed.
6249 Report values out of range.
6250
6251 Check for buffer and string overflow more precisely.
6252 * buffer.h (BUF_BYTES_MAX): New macro.
6253 * lisp.h (STRING_BYTES_MAX): New macro.
6254 * alloc.c (Fmake_string):
6255 * character.c (string_escape_byte8):
6256 * coding.c (coding_alloc_by_realloc):
6257 * doprnt.c (doprnt):
6258 * editfns.c (Fformat):
6259 * eval.c (verror):
6260 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6261 since they may not be the same number.
6262 * editfns.c (Finsert_char):
6263 * fileio.c (Finsert_file_contents):
6264 Likewise for BUF_BYTES_MAX.
6265
6266 * image.c: Use ptrdiff_t, not int, for sizes.
6267 (slurp_file): Switch from int to ptrdiff_t.
6268 All uses changed.
6269 (slurp_file): Check that file size fits in both size_t (for
6270 malloc) and ptrdiff_t (for sanity and safety).
6271
6272 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6273 if b->modtime has its maximal value.
6274
6275 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6276
6277 Don't assume time_t can fit into int.
6278 * buffer.h (struct buffer.modtime): Now time_t, not int.
6279 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6280 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6281
6282 Minor fixes for signed vs unsigned integers.
6283 * character.h (MAYBE_UNIFY_CHAR):
6284 * charset.c (maybe_unify_char):
6285 * keyboard.c (read_char, reorder_modifiers):
6286 XINT -> XFASTINT, since the integer must be nonnegative.
6287 * ftfont.c (ftfont_spec_pattern):
6288 * keymap.c (access_keymap, silly_event_symbol_error):
6289 XUINT -> XFASTINT, since the integer must be nonnegative.
6290 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6291 since it makes no difference and we prefer signed.
6292 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6293 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6294 nonnegative.
6295
6296 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6297
6298 * window.h (Fwindow_frame): Declare.
6299
6300 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6301
6302 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6303 (SPARE_MEMORY): Always define.
6304 (LARGE_REQUEST): Remove.
6305 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6306
6307 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6308
6309 * lisp.h: Move EXFUNS for Fframe_root_window,
6310 Fframe_first_window and Fset_frame_selected_window to window.h.
6311
6312 * window.h: Move EXFUNS for Fframe_root_window,
6313 Fframe_first_window and Fset_frame_selected_window here from
6314 lisp.h.
6315
6316 * frame.c (Fwindow_frame, Fframe_first_window)
6317 (Fframe_root_window, Fframe_selected_window)
6318 (Fset_frame_selected_window): Move to window.c.
6319 (Factive_minibuffer_window): Move to minibuf.c.
6320 (Fother_visible_frames_p): New function.
6321
6322 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6323
6324 * window.c (decode_window, decode_any_window): Move up in code.
6325 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6326 (inhibit_frame_unsplittable): Remove unused variable.
6327 (Fwindow_buffer): Move up and rewrite doc-string.
6328 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6329 (Fwindow_prev): New functions.
6330 (Fwindow_frame): Move here from frame.c. Accept any window as
6331 argument.
6332 (Fframe_root_window, Fframe_first_window)
6333 (Fframe_selected_window): Move here from frame.c. Accept frame
6334 or arbitrary window as argument. Update doc-strings.
6335 (Fminibuffer_window): Move up in code.
6336 (Fwindow_minibuffer_p): Move up in code and simplify.
6337 (Fset_frame_selected_window): Move here from frame.c.
6338 Marginal rewrite.
6339 (Fselected_window, select_window, Fselect_window): Move up in
6340 code. Minor doc-string fixes.
6341
6342 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6343
6344 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6345 Do not assume that spare memory exists; that assumption is valid
6346 only if SYSTEM_MALLOC.
6347 (LARGE_REQUEST): New macro, so that the issue of large requests
6348 is separated from the issue of spare memory.
6349
6350 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6351
6352 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6353 format. (Bug#8806)
6354
6355 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6356
6357 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6358 before statements.
6359
6360 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6361
6362 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6363
6364 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6365
6366 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6367 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6368
6369 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6370
6371 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6372
6373 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6374
6375 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6376 (x_clipboard_manager_save): Add return value.
6377 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6378 New error handlers.
6379 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6380 Obey Vx_select_enable_clipboard_manager. Catch errors in
6381 x_clipboard_manager_save (Bug#8779).
6382 (Vx_select_enable_clipboard_manager): New variable.
6383 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6384
6385 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6386
6387 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6388
6389 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6390
6391 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6392 in the current matrix if keep_current_p is non-zero.
6393
6394 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6395
6396 * bidi.c (bidi_level_of_next_char): Fix last change.
6397
6398 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6399
6400 Support bidi reordering of text covered by display properties.
6401
6402 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6403 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6404 (bidi_cache_search, bidi_cache_iterator_state)
6405 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6406 (bidi_level_of_next_char, bidi_move_to_visually_next):
6407 Support character positions inside a run of characters covered by a
6408 display string.
6409 (bidi_paragraph_init, bidi_resolve_explicit_1)
6410 (bidi_level_of_next_char): Call bidi_fetch_char and
6411 bidi_fetch_char_advance instead of FETCH_CHAR and
6412 FETCH_CHAR_ADVANCE.
6413 (bidi_init_it): Initialize new members.
6414 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6415 definitions.
6416 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6417 instead of using explicit *_CHAR codes.
6418 (bidi_resolve_explicit, bidi_resolve_weak):
6419 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6420 bidirectional text is supported only in multibyte buffers.
6421 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6422 it to initialize the frame_window_p member of struct bidi_it.
6423 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6424 (bidi_resolve_explicit, bidi_resolve_weak)
6425 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6426 bidi_it->nchars is non-positive.
6427 (bidi_level_of_next_char): Don't try to lookup the cache for the
6428 next/previous character if nothing is cached there yet, or if we
6429 were just reseat()'ed to a new position.
6430
6431 * xdisp.c (set_cursor_from_row): Set start and stop points
6432 according to the row's direction when priming the loop that looks
6433 for the glyph on which to display cursor.
6434 (single_display_spec_intangible_p): Function deleted.
6435 (display_prop_intangible_p): Reimplement to call
6436 handle_display_spec instead of single_display_spec_intangible_p.
6437 Accept 3 additional arguments needed by handle_display_spec.
6438 This fixes incorrect cursor motion across display property with complex
6439 values: lists, `(when COND...)' forms, etc.
6440 (single_display_spec_string_p): Support property values that are
6441 lists with the argument STRING its top-level element.
6442 (display_prop_string_p): Fix the condition for processing a
6443 property that is a list to be consistent with handle_display_spec.
6444 (handle_display_spec): New function, refactored from the
6445 last portion of handle_display_prop.
6446 (compute_display_string_pos): Accept additional argument
6447 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6448 value of a `display' property is a "replacing spec".
6449 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6450 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6451 the display property, but just return a value indicating whether
6452 the display property will replace the characters it covers.
6453 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6454 frame_window_p members of struct bidi_it.
6455 (compute_display_string_pos, compute_display_string_end):
6456 New functions.
6457 (push_it): Accept second argument POSITION, where pop_it should
6458 jump to continue iteration.
6459 (reseat_1): Initialize bidi_it.disp_pos.
6460
6461 * keyboard.c (adjust_point_for_property): Adjust the call to
6462 display_prop_intangible_p to its new signature.
6463
6464 * dispextern.h (struct bidi_it): New member frame_window_p.
6465 (bidi_init_it): Update prototypes.
6466 (display_prop_intangible_p): Update prototype.
6467 (compute_display_string_pos, compute_display_string_end):
6468 Declare prototypes.
6469 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6470 EMACS_INT.
6471
6472 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6473
6474 Malloc failure behavior now depends on size of allocation.
6475 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6476 * lisp.h: Change signatures accordingly.
6477 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6478 All callers changed. (Bug#8762)
6479
6480 * gnutls.c: Use Emacs's memory allocators.
6481 Without this change, the gnutls library would invoke malloc etc.
6482 directly, which causes problems on non-SYNC_INPUT hosts, and which
6483 runs afoul of improving memory_full behavior. (Bug#8761)
6484 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6485 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6486 xfree instead of the default malloc, realloc, free.
6487 (Fgnutls_boot): No need to check for memory allocation failure,
6488 since xmalloc does that for us.
6489
6490 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6491 * category.c (hash_get_category_set):
6492 * ccl.c (ccl_driver):
6493 * charset.c (Fdefine_charset_internal):
6494 * charset.h (struct charset.hash_index):
6495 * composite.c (get_composition_id, gstring_lookup_cache)
6496 (composition_gstring_put_cache):
6497 * composite.h (struct composition.hash_index):
6498 * dispextern.h (struct image.hash):
6499 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6500 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6501 (hashfn_equal, hashfn_user_defined, make_hash_table)
6502 (maybe_resize_hash_table, hash_lookup, hash_put)
6503 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6504 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6505 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6506 * image.c (make_image, search_image_cache, lookup_image)
6507 (xpm_put_color_table_h):
6508 * lisp.h (struct Lisp_Hash_Table):
6509 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6510 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6511 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6512 * alloc.c (allocate_vectorlike):
6513 Check for overflow in vector size calculations.
6514 * ccl.c (ccl_driver):
6515 Check for overflow when converting EMACS_INT to int.
6516 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6517 need to be updated by these changes.
6518 * fns.c (make_hash_table, maybe_resize_hash_table):
6519 Check for integer overflow with large hash tables.
6520 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6521 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6522 (SXHASH_REDUCE): New macro.
6523 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6524 Use it instead of discarding useful hash info with large hash values.
6525 (sxhash_float): New function.
6526 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6527 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6528 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6529 Rewrite to use FIXNUM_BITS, as this simplifies things.
6530 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6531 Adjust signatures to match updated version of code.
6532 (consing_since_gc): Now EMACS_INT, since a single hash table can
6533 use more than INT_MAX bytes.
6534
6535 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6536
6537 Make it possible to build with GCC-4.6+ -O2 -flto.
6538
6539 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6540
6541 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6542
6543 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6544 Call minibuffer-inactive-mode.
6545
6546 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6547
6548 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6549 Update dependencies.
6550
6551 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6552
6553 * data.c (init_data): Remove code for UTS, this system is not
6554 supported anymore.
6555
6556 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6557
6558 Don't force ./temacs to start in terminal mode.
6559
6560 * frame.c (make_initial_frame): Initialize faces in all cases, not
6561 only when CANNOT_DUMP is defined.
6562 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6563
6564 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6565
6566 * dispnew.c (add_window_display_history): Use const for the string
6567 pointer. Remove declaration, not needed.
6568
6569 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6570
6571 Use 'inline', not 'INLINE'.
6572 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6573 * alloc.c, fontset.c (INLINE): Remove.
6574 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6575 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6576 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6577 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6578 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6579
6580 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6581
6582 Make it possible to run ./temacs.
6583
6584 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6585 syms_of_callproc does the same thing. Remove test for
6586 "initialized", do it in the caller.
6587 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6588
6589 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6590
6591 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6592 (read_minibuf): Use get_minibuffer.
6593 (syms_of_minibuf): Use DEFSYM.
6594 (Qmetadata): New var.
6595 * data.c (Qbuffer): Don't make it static.
6596 (syms_of_data): Use DEFSYM.
6597
6598 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6599
6600 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6601 (CCL_CODE_MIN): New macro.
6602
6603 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6604
6605 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6606
6607 * eval.c (Qdebug): Now static.
6608 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6609 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6610 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6611
6612 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6613
6614 * image.c: Various fixes to ImageMagick code comments.
6615 (Fimagemagick_types): Doc fix.
6616
6617 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6618
6619 Minor fixes prompted by GCC 4.6.0 warnings.
6620
6621 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6622
6623 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6624 (x_clipboard_manager_save_all): Move extern decl to ...
6625 * xterm.h: ... here, so that it can be checked for consistency.
6626
6627 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6628
6629 * xselect.c (x_clipboard_manager_save_frame)
6630 (x_clipboard_manager_save_all): New functions.
6631 (Fx_clipboard_manager_save): Lisp function deleted.
6632
6633 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6634 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6635
6636 * xterm.h: Update prototype.
6637
6638 2011-05-28 William Xu <william.xwl@gmail.com>
6639
6640 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6641 exiting (Bug#8239).
6642
6643 2011-05-28 Jim Meyering <meyering@redhat.com>
6644
6645 Avoid a sign-extension bug in crypto_hash_function.
6646 * fns.c (to_uchar): Define.
6647 (crypto_hash_function): Use it to convert some newly-signed
6648 variables to unsigned, to avoid sign-extension bugs. For example,
6649 without this change, (md5 "truc") would evaluate to
6650 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6651 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6652 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6653
6654 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6655
6656 Integer overflow fixes.
6657
6658 * dbusbind.c: Serial number integer overflow fixes.
6659 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6660 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6661 to hold a serial number that is too large for a fixnum.
6662 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6663 Check for serial numbers out of range. Decode any serial number
6664 that was so large that it became a float. (Bug#8722)
6665
6666 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6667 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6668 Use XFASTINT rather than XUINT when numbers are nonnegative.
6669 (xd_append_arg, Fdbus_method_return_internal):
6670 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6671 arguments, check that Lisp number is nonnegative, rather than
6672 silently wrapping negative numbers around. (Bug#8722)
6673 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6674 (Bug#8722)
6675
6676 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6677
6678 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6679
6680 ccl: Add integer overflow checks.
6681 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6682 (IN_INT_RANGE): New macros.
6683 (ccl_driver): Use them to check for integer overflow when
6684 decoding a CCL program. Many of the new checks are whether XINT (x)
6685 fits in int; it doesn't always, on 64-bit hosts. The new version
6686 doesn't catch all possible integer overflows, but it's an
6687 improvement. (Bug#8719)
6688
6689 * alloc.c (make_event_array): Use XINT, not XUINT.
6690 There's no need for unsigned here.
6691
6692 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6693 This follows up to the 2011-05-06 change that substituted uintptr_t
6694 for EMACS_INT. This case wasn't caught back then.
6695
6696 Rework Fformat to avoid integer overflow issues.
6697 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6698 now (part of C89). Include <verify.h>.
6699 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6700 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6701 (Fformat): Avoid the prepass trying to compute sizes; it was only
6702 approximate and thus did not catch overflow reliably. Instead, walk
6703 through the format just once, formatting and computing sizes as we go,
6704 checking for integer overflow at every step, and allocating a larger
6705 buffer as needed. Keep track separately whether the format is
6706 multibyte. Keep only the most-recently calculated precision, rather
6707 than them all. Record whether each argument has been converted to
6708 string. Use EMACS_INT, not int, for byte and char and arg counts.
6709 Support field widths and precisions larger than INT_MAX. Avoid
6710 sprintf's undefined behavior with conversion specifications such as %#d
6711 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6712 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6713 formatting out-of-range floating point numbers with int
6714 formats. (Bug#8668)
6715
6716 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6717
6718 * data.c: Avoid integer truncation in expressions involving floats.
6719 * data.c: Include <intprops.h>.
6720 (arith_driver): When there's an integer overflow in an expression
6721 involving floating point, convert the integers to floating point
6722 so that the resulting value does not suffer from catastrophic
6723 integer truncation. For example, on a 64-bit host (* 4
6724 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6725 Do not rely on undefined behavior after integer overflow.
6726
6727 merge count_size_as_multibyte, parse_str_to_multibyte
6728 * character.c, character.h (count_size_as_multibyte):
6729 Rename from parse_str_to_multibyte; all uses changed.
6730 Check for integer overflow.
6731 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6732 since it's now a duplicate of the other. This is more of
6733 a character than a buffer op, so better that it's in character.c.
6734 * fns.c, print.c: Adjust to above changes.
6735
6736 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6737
6738 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6739
6740 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6741
6742 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6743 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6744 (x_clipboard_manager_save): Now static.
6745 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6746
6747 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6748 (crypto_hash_function): Now static.
6749 Fix pointer signedness problems. Avoid unnecessary initializations.
6750
6751 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6752
6753 * termhooks.h (Vselection_alist): Make it terminal-local.
6754
6755 * terminal.c (create_terminal): Initialize it.
6756
6757 * xselect.c: Support for clipboard managers.
6758 (Vselection_alist): Move to termhooks.h as terminal-local var.
6759 (LOCAL_SELECTION): New macro.
6760 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6761 (symbol_to_x_atom): Remove gratuitous arg.
6762 (x_handle_selection_request, lisp_data_to_selection_data)
6763 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6764 (x_own_selection, x_get_local_selection, x_convert_selection):
6765 New arg, specifying work frame. Use terminal-local Vselection_alist.
6766 (some_frame_on_display): Delete unused function.
6767 (Fx_own_selection_internal, Fx_get_selection_internal)
6768 (Fx_disown_selection_internal, Fx_selection_owner_p)
6769 (Fx_selection_exists_p): New optional frame arg.
6770 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6771 (x_handle_selection_clear): Don't treat other terminals with the
6772 same keyboard specially. Use the terminal-local Vselection_alist.
6773 (x_clear_frame_selections): Use Frun_hook_with_args.
6774
6775 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6776
6777 * xterm.h: Add support for those atoms.
6778
6779 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6780
6781 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6782 (converted_selections, conversion_fail_tag): New global variables.
6783 (x_selection_request_lisp_error): Free the above.
6784 (x_get_local_selection): Remove unnecessary code.
6785 (x_reply_selection_request): Args changed; handle arbitrary array
6786 of converted selections stored in converted_selections.
6787 Separate the XChangeProperty and SelectionNotify steps.
6788 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6789 (x_convert_selection): New function.
6790 (x_handle_selection_event): Simplify.
6791 (x_get_foreign_selection): Don't ignore incoming requests while
6792 waiting for an answer; this will fail when we implement
6793 SAVE_TARGETS, and seems unnecessary anyway.
6794 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6795 (Vx_sent_selection_functions): Doc fix.
6796
6797 2011-05-26 Leo Liu <sdl.web@gmail.com>
6798
6799 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6800
6801 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6802
6803 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6804
6805 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6806 for fringe update if it has periodic bitmap.
6807 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6808 and fringe_bitmap_periodic_p.
6809
6810 * fringe.c (get_fringe_bitmap_data): New function.
6811 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6812 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6813 row. Mark glyph row for fringe update if periodicity changed.
6814
6815 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6816 for fringe update unless it has periodic bitmap.
6817
6818 2011-05-25 Kenichi Handa <handa@m17n.org>
6819
6820 * xdisp.c (get_next_display_element): Set correct it->face_id for
6821 a static composition.
6822
6823 2011-05-24 Leo Liu <sdl.web@gmail.com>
6824
6825 * deps.mk (fns.o):
6826 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6827
6828 * fns.c (crypto_hash_function, Fsha1): New function.
6829 (Fmd5): Use crypto_hash_function.
6830 (syms_of_fns): Add Ssha1.
6831
6832 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6833
6834 * gnutls.c: Remove unused macros.
6835 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6836 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6837 Remove macros that are defined and never used.
6838 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6839
6840 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6841
6842 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6843 (Fx_get_selection_internal): Minor cleanup.
6844 (Fx_own_selection_internal): Rename arguments for consistency with
6845 select.el.
6846
6847 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6848
6849 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6850
6851 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6852
6853 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6854
6855 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6856
6857 * dispnew.c (scrolling_window): Don't exclude the case that the
6858 last enabled row in the desired matrix touches the bottom boundary.
6859
6860 2011-05-21 Glenn Morris <rgm@gnu.org>
6861
6862 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6863 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6864 and add some more files.
6865
6866 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6867
6868 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6869 report_file_error introduced by the change from 2011-05-07.
6870
6871 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6872
6873 * systime.h (Time): Define only if emacs is defined.
6874 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6875 where the include path doesn't have X11/X.h by default. See
6876 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6877
6878 2011-05-20 Kenichi Handa <handa@m17n.org>
6879
6880 * composite.c (find_automatic_composition): Fix previous change.
6881
6882 2011-05-20 Glenn Morris <rgm@gnu.org>
6883
6884 * lisp.mk: New file, split from Makefile.in.
6885 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6886 (shortlisp): Remove.
6887 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6888
6889 2011-05-19 Glenn Morris <rgm@gnu.org>
6890
6891 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6892 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6893 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6894 (lisp): Set the order to that of loadup.el.
6895 (shortlisp): Make it a copy of $lisp.
6896 (SOME_MACHINE_LISP): Remove.
6897 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6898 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6899
6900 2011-05-18 Kenichi Handa <handa@m17n.org>
6901
6902 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6903 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6904 (find_automatic_composition): Mostly rewrite for efficiency.
6905
6906 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6907
6908 * makefile.w32-in: Update dependencies.
6909
6910 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6911
6912 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6913 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6914
6915 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6916
6917 Fix some integer overflow issues, such as string length overflow.
6918
6919 * insdel.c (count_size_as_multibyte): Check for string overflow.
6920
6921 * character.c (lisp_string_width): Check for string overflow.
6922 Use EMACS_INT, not int, for string indexes and lengths; in
6923 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6924 the resulting string length overflows an EMACS_INT; instead,
6925 report a string overflow if no precision given. When checking for
6926 precision exhaustion, use a check that cannot possibly have
6927 integer overflow. (Bug#8675)
6928 * character.h (lisp_string_width): Adjust to new signature.
6929
6930 * alloc.c (string_overflow): New function.
6931 (Fmake_string): Use it. This doesn't change behavior, but saves
6932 a few bytes and will simplify future changes.
6933 * character.c (string_escape_byte8): Likewise.
6934 * lisp.h (string_overflow): New decl.
6935
6936 Fixups, following up to the user-interface timestamp change.
6937 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6938 for UI timestamps, instead of unsigned long.
6939 * msdos.c (mouse_get_pos): Likewise.
6940 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6941 * w32gui.h (Time): Define by including "systime.h" rather than by
6942 declaring it ourselves. (Bug#8664)
6943
6944 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6945 * image.c (clear_image_cache): Likewise.
6946
6947 * term.c (term_mouse_position): Don't assume time_t wraparound.
6948
6949 Be more systematic about user-interface timestamps.
6950 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6951 and sometimes 'EMACS_UINT', to represent these timestamps.
6952 This change causes it to use 'Time' uniformly, as that's what X uses.
6953 This makes the code easier to follow, and makes it easier to catch
6954 integer overflow bugs such as Bug#8664.
6955 * frame.c (Fmouse_position, Fmouse_pixel_position):
6956 Use Time, not unsigned long, for user-interface timestamps.
6957 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6958 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6959 * keyboard.h (last_event_timestamp): Likewise.
6960 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6961 * menu.h (xmenu_show): Likewise.
6962 * term.c (term_mouse_position): Likewise.
6963 * termhooks.h (struct input_event.timestamp): Likewise.
6964 (struct terminal.mouse_position_hook): Likewise.
6965 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6966 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6967 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6968 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6969 what it was before.
6970 * menu.h, termhooks.h: Include "systime.h", for Time.
6971
6972 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6973 Don't assume that the difference between two unsigned long values
6974 can fit into an integer. At this point, we know button_down_time
6975 <= event->timestamp, so the difference must be nonnegative, so
6976 there's no need to cast the result if double-click-time is
6977 nonnegative, as it should be; check that it's nonnegative, just in
6978 case. This bug is triggered when events are more than 2**31 ms
6979 apart (about 25 days). (Bug#8664)
6980
6981 * xselect.c (last_event_timestamp): Remove duplicate decl.
6982 (x_own_selection): Remove needless cast to unsigned long.
6983
6984 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6985 that always fit in int. Use a sentinel instead of a counter, to
6986 avoid a temp and to allay GCC's concerns about possible int overflow.
6987 * frame.h (struct frame): Use int for menu_bar_items_used
6988 instead of EMACS_INT, since it always fits in int.
6989
6990 * menu.c (grow_menu_items): Check for int overflow.
6991
6992 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6993
6994 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6995 Before, the code was not consistent. These values cannot exceed
6996 2**31 - 1 so there's no need to make them unsigned.
6997 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6998 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6999 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
7000 as modifiers.
7001 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
7002
7003 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
7004 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
7005 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
7006 presumably because the widths might not match.
7007
7008 * window.c (size_window): Avoid needless test at loop start.
7009
7010 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
7011
7012 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7013
7014 2011-05-12 Drew Adams <drew.adams@oracle.com>
7015
7016 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7017
7018 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7019
7020 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7021 `width' to `bar_area_x' and `bar_area_width', respectively.
7022 (x_scroll_run): Take account of fringe background extension.
7023
7024 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7025 Rename local vars `left' and `width' to `bar_area_x' and
7026 `bar_area_width', respectively.
7027 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7028 background extension.
7029
7030 2011-05-10 Jim Meyering <meyering@redhat.com>
7031
7032 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7033
7034 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
7035
7036 * image.c (Finit_image_library): Return t for built-in image types,
7037 like pbm and xbm. (Bug#8640)
7038
7039 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7040
7041 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7042
7043 2011-05-07 Eli Zaretskii <eliz@gnu.org>
7044
7045 * w32console.c (Fset_screen_color): Doc fix.
7046 (Fget_screen_color): New function.
7047 (syms_of_ntterm): Defsubr it.
7048
7049 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7050 unlink the temporary file if Fcall_process didn't create it in the
7051 first place.
7052 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7053 child process will be redirected to a file specified with `:file'.
7054 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7055 cue to call_process_cleanup not to close that handle.
7056
7057 2011-05-07 Ben Key <bkey76@gmail.com>
7058
7059 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7060 one of two shell specific rules, either bootstrap-temacs-CMD or
7061 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7062 to the previous implementation of the bootstrap-temacs rule.
7063 The bootstrap-temacs-CMD rule is similar to the previous
7064 implementation of the bootstrap-temacs rule except that it
7065 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7066 variable.
7067
7068 These changes, along with some changes to nt/configure.bat,
7069 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7070 earlier fix to add support for --cflags and --ldflags options
7071 that include quotes so that it works whether make uses cmd or
7072 sh as the shell.
7073
7074 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
7075
7076 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7077 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7078 is a constant.
7079 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7080 a string. Handle both cases.
7081 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7082 (Fdbus_register_method): Use Qinvalid_function.
7083
7084 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7085
7086 * makefile.w32-in: Update dependencies.
7087 (LISP_H): Add inttypes.h and stdin.h.
7088 (PROCESS_H): Add unistd.h.
7089
7090 2011-05-06 Eli Zaretskii <eliz@gnu.org>
7091
7092 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7093 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7094
7095 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
7096
7097 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7098
7099 * term.c (vfatal): Remove stray call to va_end.
7100 It's not needed and the C Standard doesn't allow it here anyway.
7101
7102 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7103 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7104
7105 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7106 bytes.
7107
7108 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7109
7110 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7111
7112 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7113
7114 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7115
7116 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7117
7118 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7119 * charset.c (Fdefine_charset_internal): Don't initialize
7120 charset.code_space[15]. The value was garbage, on hosts with
7121 32-bit int (Bug#8600).
7122
7123 * lread.c (read_integer): Be more consistent with string-to-number.
7124 Use string_to_number to do the actual conversion; this avoids
7125 rounding errors and fixes some other screwups. Without this fix,
7126 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7127 (digit_to_number): Move earlier, for benefit of read_integer.
7128 Return -1 if the digit is out of range for the base, -2 if it is
7129 not a digit in any supported base. (Bug#8602)
7130
7131 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7132
7133 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7134 to match comment at start of function. This also removes a
7135 GCC warning about overflow in a 32+64-bit port.
7136
7137 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7138
7139 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7140 Reported by Stefan Monnier in
7141 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
7142 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7143 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
7144
7145 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7146 (EMACS_UINTPTR): Likewise, with uintptr_t.
7147
7148 * lisp.h: Prefer 64-bit EMACS_INT if available.
7149 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7150 on 32-bit hosts that have 64-bit int, so that they can access
7151 large files.
7152 However, temporarily disable this change unless the temporary
7153 symbol WIDE_EMACS_INT is defined.
7154
7155 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7156
7157 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7158 This removes an assumption that EMACS_INT and long are the same
7159 width as pointers. The assumption is true for Emacs porting targets
7160 now, but we want to make other targets possible.
7161 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7162 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7163 In the rest of the code, change types of integers that hold casted
7164 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7165 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7166 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7167 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7168 No need to cast type when ORing.
7169 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7170 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7171 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7172 assume EMACS_INT is the same width as char *.
7173 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7174 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7175 Remove no-longer-needed casts.
7176 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7177 (xg_tool_bar_help_callback, xg_make_tool_item):
7178 Use EMACS_INTPTR to hold an integer
7179 that will be cast to void *; this can avoid a GCC warning
7180 if EMACS_INT is not the same width as void *.
7181 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7182 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7183 (current_message_1, set_message_1):
7184 Use a local to convert to proper width without a cast.
7185 * xmenu.c (dialog_selection_callback): Likewise.
7186
7187 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7188 Also, don't assume VALBITS / RAND_BITS is less than 5,
7189 and don't rely on undefined behavior when shifting a 1 left into
7190 the sign bit.
7191 * lisp.h (get_random): Change signature to match.
7192
7193 * lread.c (hash_string): Use size_t, not int, for hash computation.
7194 Normally we prefer signed values; but hashing is special, because
7195 it's better to use unsigned division on hash table sizes so that
7196 the remainder is nonnegative. Also, size_t is the natural width
7197 for hashing into memory. The previous code used 'int', which doesn't
7198 retain enough info to hash well into very large tables.
7199 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7200
7201 * dbusbind.c: Don't possibly lose pointer info when converting.
7202 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7203 Use XPNTR rather than XHASH, so that the high-order bits of
7204 the pointer aren't lost when converting through void *.
7205
7206 * eval.c (Fautoload): Don't double-shift a pointer.
7207
7208 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7209
7210 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7211
7212 * gnutls.c (DEF_GNUTLS_FN):
7213 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7214
7215 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7216
7217 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7218 marker. (Bug#8610)
7219
7220 2011-05-05 Eli Zaretskii <eliz@gnu.org>
7221
7222 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7223 New version that can reserve upto 2GB of heap space.
7224
7225 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7226
7227 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7228
7229 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7230
7231 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7232 `gnutls_certificate_set_x509_key_file'.
7233
7234 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7235
7236 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7237 Update dependencies.
7238
7239 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7240
7241 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7242 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7243 Remove unused parameter `fildes'.
7244 * process.c (read_process_output, send_process): Don't pass it.
7245
7246 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7247
7248 Fix previous change: the library cache is defined in w32.c.
7249 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7250 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7251
7252 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7253
7254 Implement dynamic loading of GnuTLS on Windows.
7255
7256 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7257 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7258 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7259 Declare.
7260
7261 * gnutls.c (Qgnutls_dll): Define.
7262 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7263 (gnutls_*): Declare function pointers.
7264 (init_gnutls_functions): New function to initialize function pointers.
7265 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7266 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7267 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7268 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7269 (emacs_gnutls_write, emacs_gnutls_read)
7270 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7271 (Fgnutls_available_p): New function.
7272 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7273 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7274 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7275
7276 * image.c: Include w32.h.
7277 (Vimage_type_cache): Delete.
7278 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7279 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7280 (w32_delayed_load): Move to w32.c.
7281
7282 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7283
7284 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7285 (w32_delayed_load): Move from image.c. When loading a library, record
7286 its filename in the :loaded-from property of the library id.
7287 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7288 Initialize and staticpro them.
7289 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7290
7291 * process.c: Include lisp.h before w32.h, not after.
7292 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7293 instead of gnutls_record_check_pending.
7294
7295 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7296
7297 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7298
7299 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7300 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7301 as passed in.
7302
7303 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7304
7305 * xterm.c (x_set_frame_alpha): Do not set property on anything
7306 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7307
7308 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7309
7310 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7311
7312 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7313
7314 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7315 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7316 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7317 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7318 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7319 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7320 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7321 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7322 (Qgnutls_bootprop_callbacks_verify): Make static.
7323
7324 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7325
7326 * callproc.c: Indentation fixup.
7327
7328 * sysdep.c (wait_for_termination_1): Make static.
7329 (wait_for_termination, interruptible_wait_for_termination):
7330 Move after wait_for_termination_1.
7331
7332 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7333
7334 * sysdep.c (interruptible_wait_for_termination): New function
7335 which is like wait_for_termination, but allows keyboard
7336 interruptions.
7337
7338 * callproc.c (Fcall_process): Add (:file "file") as an option for
7339 the STDOUT buffer.
7340 (Fcall_process_region): Ditto.
7341
7342 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7343
7344 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7345 rather than `XVECTOR (FOO)->size'.
7346
7347 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7348 inttypes.h, as a gnulib replacement is used if it not available in
7349 system headers.
7350
7351 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7352
7353 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7354 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7355 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7356
7357 * coding.c (coding_alloc_by_realloc): Error out if destination
7358 will grow beyond MOST_POSITIVE_FIXNUM.
7359 (decode_coding_emacs_mule): Abort if there isn't enough place in
7360 charbuf for the composition carryover bytes. Reserve an extra
7361 space for up to 2 characters produced in a loop.
7362 (decode_coding_iso_2022): Abort if there isn't enough place in
7363 charbuf for the composition carryover bytes.
7364
7365 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7366
7367 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7368 aborting when %lld or %lll format is passed.
7369 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7370 %llo or %llx format is passed. (Bug#8545)
7371
7372 * window.c (window_scroll_line_based): Use a marker instead of
7373 simple variables to record original value of point. (Bug#7952)
7374
7375 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7376 produced by %s or %c overflows available buffer space. (Bug#8545)
7377
7378 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7379
7380 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7381 (SIZE_MAX): Move defn after all includes, as they might #define it.
7382
7383 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7384
7385 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7386
7387 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7388
7389 * keyboard.c (Qdelayed_warnings_hook): Define.
7390 (command_loop_1): Run `delayed-warnings-hook'
7391 if Vdelayed_warnings_list is non-nil.
7392 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7393 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7394
7395 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7396
7397 * doprnt.c (doprnt): Don't return value smaller than the buffer
7398 size if the message was truncated. (Bug#8545).
7399
7400 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7401
7402 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7403 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7404
7405 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7406
7407 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7408
7409 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7410
7411 * makefile.w32-in: Update dependencies.
7412
7413 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7414
7415 Improve `doprnt' and its usage. (Bug#8545)
7416 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7417 `format_end'. Remove support for %l as a conversion specifier.
7418 Don't use xrealloc. Improve diagnostics when the %l size modifier
7419 is used. Update the commentary.
7420
7421 * eval.c (verror): Simplify calculation of size_t.
7422
7423 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7424 messages.
7425
7426 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7427
7428 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7429 change.
7430
7431 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7432
7433 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7434 This makes this file independent of the recent pseudovector change.
7435
7436 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7437
7438 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7439
7440 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7441 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7442 Remove unused local.
7443 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7444
7445 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7446 GCC 4.6.0 optimizes based on type-based alias analysis.
7447 For example, if b is of type struct buffer * and v of type struct
7448 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7449 != &v->size, and therefore "v->size = 1; b->size = 2; return
7450 v->size;" must therefore return 1. This assumption is incorrect
7451 for Emacs, since it type-puns struct Lisp_Vector * with many other
7452 types. To fix this problem, this patch adds a new type struct
7453 vectorlike_header that documents the constraints on layout of vectors
7454 and pseudovectors, and helps optimizing compilers not get fooled
7455 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7456 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7457 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7458 the size member.
7459 (XSETPVECTYPE): Rewrite in terms of new macro.
7460 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7461 This is a bit clearer, and further avoids the possibility of
7462 undesirable aliasing.
7463 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7464 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7465 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7466 since Lisp_Subr is a special case (no "next" field).
7467 (ASIZE): Now uses header.size rather than size.
7468 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7469 to avoid the hassle of writing XVECTOR (foo)->header.size.
7470 (struct vectorlike_header): New type.
7471 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7472 object, to help avoid aliasing.
7473 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7474 (SUBRP): Likewise, since Lisp_Subr is a special case.
7475 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7476 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7477 (struct Lisp_Hash_Table): Combine first two members into a single
7478 struct vectorlike_header member. All uses of "size" and "next" members
7479 changed to be "header.size" and "header.next".
7480 * buffer.h (struct buffer): Likewise.
7481 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7482 * frame.h (struct frame): Likewise.
7483 * process.h (struct Lisp_Process): Likewise.
7484 * termhooks.h (struct terminal): Likewise.
7485 * window.c (struct save_window_data, struct saved_window): Likewise.
7486 * window.h (struct window): Likewise.
7487 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7488 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7489 * buffer.c (init_buffer_once): Likewise.
7490 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7491 special case.
7492 * process.c (Fformat_network_address): Use local var for size,
7493 for brevity.
7494
7495 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7496
7497 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7498 * data.c (atof): Remove decl; no longer used or needed.
7499 (digit_to_number): Move to lread.c.
7500 (Fstring_to_number): Use new string_to_number function, to be
7501 consistent with how the Lisp reader treats infinities and NaNs.
7502 Do not assume that floating-point numbers represent EMACS_INT
7503 without losing information; this is not true on most 64-bit hosts.
7504 Avoid double-rounding errors, by insisting on integers when
7505 parsing non-base-10 numbers, as the documentation specifies.
7506 * lisp.h (string_to_number): New decl, replacing ...
7507 (isfloat_string): Remove.
7508 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7509 (read1): Do not accept +. and -. as integers; this
7510 appears to have been a coding error. Similarly, do not accept
7511 strings like +-1e0 as floating point numbers. Do not report
7512 overflow for integer overflows unless the base is not 10 which
7513 means we have no simple and reliable way to continue.
7514 Break out the floating-point parsing into a new
7515 function string_to_number, so that Fstring_to_number parses
7516 floating point numbers consistently with the Lisp reader.
7517 (digit_to_number): Move here from data.c. Make it static inline.
7518 (E_CHAR, EXP_INT): Remove, replacing with ...
7519 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7520 (string_to_number): New function, replacing isfloat_string.
7521 This function checks for valid syntax and produces the resulting
7522 Lisp float number too. Rework it so that string-to-number
7523 no longer mishandles examples like "1.0e+". Use strtoumax,
7524 so that overflow for non-base-10 numbers is reported only when
7525 there's no portable and simple way to convert to floating point.
7526
7527 * textprop.c (set_text_properties_1): Rewrite for clarity,
7528 and to avoid GCC warning about integer overflow.
7529
7530 * intervals.h (struct interval): Use EMACS_INT for members
7531 where EMACS_UINT might cause problems. See
7532 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7533 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7534 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7535 All uses changed.
7536 (offset_intervals): Tell GCC not to worry about length overflow
7537 when negating a negative length.
7538
7539 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7540 (overrun_check_free): Likewise.
7541
7542 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7543 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7544 word size.
7545
7546 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7547 (gnutls_make_error): Rename local to avoid shadowing.
7548 (gnutls_emacs_global_deinit): ifdef out; not used.
7549 (Fgnutls_boot): Use const for pointer to readonly storage.
7550 Comment out unused local. Fix pointer signedness problems.
7551
7552 * lread.c (openp): Don't stuff size_t into an 'int'.
7553 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7554 about possible signed overflow.
7555
7556 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7557 (GDK_KEY_g): Don't define if already defined.
7558 (xg_prepare_tooltip): Avoid pointer signedness problem.
7559 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7560
7561 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7562 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7563
7564 * xfns.c (Fx_window_property): Simplify a bit,
7565 to make a bit faster and to avoid GCC 4.6.0 warning.
7566 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7567
7568 * fns.c (internal_equal): Don't assume size_t fits in int.
7569
7570 * alloc.c (compact_small_strings): Tighten assertion a little.
7571
7572 Replace pEd with more-general pI, and fix some printf arg casts.
7573 * lisp.h (pI): New macro, generalizing old pEd macro to other
7574 conversion specifiers. For example, use "...%"pI"d..." rather
7575 than "...%"pEd"...".
7576 (pEd): Remove. All uses replaced with similar uses of pI.
7577 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7578 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7579 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7580 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7581 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7582 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7583 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7584 64-bit hosts.
7585 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7586 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7587 * print.c (safe_debug_print, print_object): Likewise.
7588 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7589 to int.
7590 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7591 avoiding the 0 flag, which is not portable.
7592 * process.c (Fmake_network_process): Use pI to avoid cast.
7593 * region-cache.c (pp_cache): Likewise.
7594 * xdisp.c (decode_mode_spec): Likewise.
7595 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7596 behavior on 64-bit hosts with printf arg.
7597 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7598 (x_stop_queuing_selection_requests): Likewise.
7599 (x_get_window_property): Don't truncate byte count to an 'int'
7600 when tracing.
7601
7602 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7603 here, since it parses constructs like leading '-' and spaces,
7604 which are not wanted; and it overflows with large numbers.
7605 Instead, simply match F[0-9]+, which is what is wanted anyway.
7606
7607 * alloc.c: Remove unportable assumptions about struct layout.
7608 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7609 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7610 (allocate_vectorlike, make_pure_vector): Use the new macros,
7611 plus offsetof, to remove unportable assumptions about struct layout.
7612 These assumptions hold on all porting targets that I know of, but
7613 they are not guaranteed, they're easy to remove, and removing them
7614 makes further changes easier.
7615
7616 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7617 This doesn't fix a bug but makes the code clearer.
7618 (string_overrun_cookie): Now const. Use initializers that
7619 don't formally overflow signed char, to avoid warnings.
7620 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7621 can cause Emacs to crash when string overrun checking is enabled.
7622 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7623 multiple of sizeof (EMACS_INT); it need not be, if
7624 alignof(EMACS_INT) < sizeof (EMACS_INT).
7625 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7626
7627 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7628
7629 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7630
7631 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7632
7633 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7634 supposed to be handshaking. (Bug#8556)
7635 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7636
7637 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7638
7639 * lisp.h (Qdebug): List symbol.
7640 * eval.c (Qdebug): Restore global linkage.
7641 * keyboard.c (debug-on-event): New variable.
7642 (handle_user_signal): Break into debugger when debug-on-event
7643 matches the current signal symbol.
7644
7645 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7646
7647 * alloc.c (check_sblock, check_string_bytes)
7648 (check_string_free_list): Convert to standard C.
7649
7650 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7651
7652 * w32.c (emacs_gnutls_push): Fix typo.
7653
7654 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7655
7656 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7657 "cast to pointer from integer of different size".
7658
7659 Improve doprnt and its use in verror. (Bug#8545)
7660 * doprnt.c (doprnt): Document the set of format control sequences
7661 supported by the function. Use SAFE_ALLOCA instead of always
7662 using `alloca'.
7663
7664 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7665 is one byte too soon. Don't use xrealloc; instead xfree and
7666 xmalloc anew.
7667
7668 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7669
7670 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7671 callbacks stage.
7672
7673 * gnutls.c: Renamed global_initialized to
7674 gnutls_global_initialized. Added internals for the
7675 :verify-hostname-error, :verify-error, and :verify-flags
7676 parameters of `gnutls-boot' and documented those parameters in the
7677 docstring. Start callback support.
7678 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7679 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7680 on error. Return error code.
7681 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7682 (emacs_gnutls_read): Likewise.
7683 (Fgnutls_boot): Return handshake error code.
7684 (emacs_gnutls_handle_error): New function.
7685 (wsaerror_to_errno): Likewise.
7686
7687 * w32.h (emacs_gnutls_pull): Add prototype.
7688 (emacs_gnutls_push): Likewise.
7689
7690 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7691 (emacs_gnutls_push): Likewise.
7692
7693 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7694
7695 * process.c (wait_reading_process_output): Check if GnuTLS
7696 buffered some data internally if no FDs are set for TLS
7697 connections.
7698
7699 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7700 (LIBS): Link to USER_LIBS.
7701 ($(BLD)/gnutls.$(0)): New target.
7702
7703 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7704
7705 * xdisp.c (handle_single_display_spec): Rename the
7706 display_replaced_before_p argument into display_replaced_p, to
7707 make it consistent with the commentary. Fix typos in the
7708 commentary.
7709
7710 * textprop.c (syms_of_textprop): Remove dead code.
7711 (copy_text_properties): Delete obsolete commentary about an
7712 interface that was deleted long ago. Fix typos in the description
7713 of arguments.
7714
7715 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7716 to changes in oldXMenu/XMenu.h from 2011-04-16.
7717 <menu_help_message, prev_menu_help_message>: Constify.
7718 (IT_menu_make_room): menu->help_text is now `const char **';
7719 adjust.
7720
7721 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7722 to changes in oldXMenu/XMenu.h from 2011-04-16.
7723 (struct XMenu): Declare `help_text' `const char **'.
7724
7725 * xfaces.c <Qunspecified>: Make extern again.
7726
7727 * syntax.c: Include sys/types.h before including regex.h, as
7728 required by POSIX.
7729
7730 * doc.c (get_doc_string): Improve the format passed to `error'.
7731
7732 * doprnt.c (doprnt): Improve commentary.
7733
7734 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7735
7736 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7737 them with etags.
7738
7739 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7740 changes in globals.h immediately force recompilation.
7741 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7742 $(CURDIR)/s/ms-w32.h.
7743 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7744
7745 * character.c (Fchar_direction): Function deleted.
7746 (syms_of_character): Don't defsubr it.
7747 <char-direction-table>: Deleted.
7748
7749 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7750
7751 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7752 * doprnt.c: Include limits.h.
7753 (SIZE_MAX): New macro.
7754 (doprnt): Return a size_t value. 2nd arg is now size_t.
7755 Many local variables are now size_t instead of int or unsigned.
7756 Improve overflow protection. Support `l' modifier for integer
7757 conversions. Support %l conversion. Don't assume an EMACS_INT
7758 argument for integer conversions and for %c.
7759
7760 * lisp.h (doprnt): Restore prototype.
7761
7762 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7763 $(SRC)/character.h.
7764
7765 * Makefile.in (base_obj): Add back doprnt.o.
7766
7767 * deps.mk (doprnt.o): Add back prerequisites.
7768 (callint.o): Depend on character.h.
7769
7770 * eval.c (internal_lisp_condition_case): Include the handler
7771 representation in the error message.
7772 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7773 when breaking from the loop.
7774
7775 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7776
7777 * callint.c (Fcall_interactively): When displaying error message
7778 about invalid control letter, pass the character's codepoint, not
7779 a pointer to its multibyte form. Improve display of the character
7780 in octal and display also its hex code.
7781
7782 * character.c (char_string): Use %x to display the (unsigned)
7783 codepoint of an invalid character, to avoid displaying a bogus
7784 negative value.
7785
7786 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7787 `error', not SYMBOL_NAME itself.
7788
7789 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7790 character arguments to `error'.
7791
7792 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7793 to `error' in error message about FINAL_CHAR argument. Make sure
7794 FINAL_CHAR is a character, and use %c when it is passed as
7795 argument to `error'.
7796
7797 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7798
7799 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7800
7801 * w32.c: Include <time.h>.
7802 (sys_localtime): New function.
7803
7804 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7805
7806 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7807
7808 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7809
7810 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7811
7812 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7813 zombies (Bug#8467).
7814
7815 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7816
7817 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7818 gl_state.e_property when gl_state.object is Qt.
7819
7820 * insdel.c (make_gap_larger): Remove limitation of buffer size
7821 to <= INT_MAX.
7822
7823 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7824
7825 * xdisp.c (lookup_glyphless_char_display)
7826 (produce_glyphless_glyph): Handle cons cell entry in
7827 glyphless-char-display.
7828 (Vglyphless_char_display): Document it.
7829
7830 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7831 glyphless-char-display.
7832
7833 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7834
7835 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7836
7837 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7838
7839 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7840 definition for no-X builds.
7841
7842 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7843
7844 Static checks with GCC 4.6.0 and non-default toolkits.
7845
7846 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7847
7848 * process.c (keyboard_bit_set): Define only if SIGIO.
7849 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7850 (send_process): Repair possible setjmp clobbering.
7851
7852 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7853
7854 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7855
7856 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7857
7858 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7859 Define only if needed.
7860
7861 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7862 by pacifying GCC about it. Maybe it's time to retire it?
7863 * xfaces.c (USG, __TIMEVAL__): Likewise.
7864
7865 * dispextern.h (struct redisplay_interface): Rename param
7866 to avoid shadowing.
7867 * termhooks.h (struct terminal): Likewise.
7868 * xterm.c (xembed_send_message): Likewise.
7869
7870 * insdel.c (make_gap_smaller): Define only if
7871 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7872
7873 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7874 it.
7875
7876 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7877 so that we aren't warned about unused symbols.
7878
7879 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7880
7881 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7882
7883 * xfns.c (x_real_positions): Mark locals as initialized.
7884
7885 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7886
7887 * xterm.c: Fix problems found by static analysis with other toolkits.
7888 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7889 (x_dispatch_event): Declare static if USE_GTK, and
7890 define if USE_GTK || USE_X_TOOLKIT.
7891 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7892 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7893 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7894 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7895
7896 * xmenu.c (menu_help_callback): Pointer type fixes.
7897 Use const pointers when pointing at readonly data. Avoid pointer
7898 signedness clashes.
7899 (FALSE): Remove unused macro.
7900 (update_frame_menubar): Remove unused decl.
7901
7902 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7903
7904 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7905 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7906 (single_menu_item): Rename local to avoid shadowing.
7907
7908 * keyboard.c (make_lispy_event): Remove unused local var.
7909
7910 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7911 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7912
7913 * bitmaps: Change bitmaps from unsigned char back to the X11
7914 compatible char. Avoid the old compiler warnings about
7915 out-of-range initializers by using, for example, '\xab' rather
7916 than 0xab.
7917
7918 * xgselect.c (xgselect_initialize): Check vs interface
7919 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7920
7921 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7922
7923 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7924 to read-only memory.
7925
7926 * fns.c (vector): Remove; this old hack is no longer needed.
7927
7928 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7929 Remove unused var.
7930 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7931
7932 * xrdb.c (x_load_resources): Omit unused local.
7933
7934 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7935 (x_window): Rename locals to avoid shadowing.
7936 (USG): Use the kludged USG macro, to pacify gcc.
7937
7938 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7939 (x_term_init): Remove local to avoid shadowing.
7940
7941 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7942
7943 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7944 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7945
7946 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7947
7948 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7949
7950 Fix regex.c, syntax.c and friends for buffers > 2GB.
7951 * syntax.h (struct gl_state_s): Declare character position members
7952 EMACS_INT.
7953
7954 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7955
7956 * textprop.c (verify_interval_modification, interval_of):
7957 Declare arguments EMACS_INT.
7958
7959 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7960 EMACS_INT.
7961
7962 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7963
7964 * indent.c (Fvertical_motion): Local variable it_start is now
7965 EMACS_INT.
7966
7967 * regex.c (re_match, re_match_2, re_match_2_internal)
7968 (bcmp_translate, regcomp, regexec, print_double_string)
7969 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7970 (re_compile_pattern, re_exec): Declare arguments and local
7971 variables `size_t' and `ssize_t' and return values `regoff_t', as
7972 appropriate.
7973 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7974 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7975 <compile_stack_type>: `size' and `avail' are now `size_t'.
7976
7977 * regex.h <regoff_t>: Use ssize_t, not int.
7978 (re_search, re_search_2, re_match, re_match_2): Arguments that
7979 specify buffer/string position and length are now ssize_t and
7980 size_t. Return type is regoff_t.
7981
7982 2011-04-16 Ben Key <bkey76@gmail.com>
7983
7984 * nsfont.m: Fixed bugs in ns_get_family and
7985 ns_descriptor_to_entity that were caused by using free to
7986 deallocate memory blocks that were allocated by xmalloc (via
7987 xstrdup). This caused Emacs to crash when compiled with
7988 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7989 --enable-checking=xmallocoverrun). xfree is now used to
7990 deallocate these memory blocks.
7991
7992 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7993
7994 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7995
7996 emacs_write: Accept and return EMACS_INT for sizes.
7997 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7998 et seq.
7999 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
8000 Accept and return EMACS_INT.
8001 (emacs_gnutls_write): Return the number of bytes written on
8002 partial writes.
8003 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
8004 (emacs_read, emacs_write): Remove check for negative size, as the
8005 Emacs source code has been audited now.
8006 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
8007 (emacs_read, emacs_write): Use it.
8008 * process.c (send_process): Adjust to the new signatures of
8009 emacs_write and emacs_gnutls_write. Do not attempt to store
8010 a byte offset into an 'int'; it might overflow.
8011 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
8012
8013 * sound.c: Don't assume sizes fit in 'int'.
8014 (struct sound_device.period_size, alsa_period_size):
8015 Return EMACS_INT, not int.
8016 (struct sound_device.write, vox_write, alsa_write):
8017 Accept EMACS_INT, not int.
8018 (wav_play, au_play): Use EMACS_INT to store sizes and to
8019 record read return values.
8020
8021 2011-04-15 Ben Key <bkey76@gmail.com>
8022
8023 * keyboard.c (Qundefined): Don't declare static since it is used
8024 in nsfns.m.
8025 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8026 static since they are used in nsfont.m.
8027
8028 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8029
8030 * process.c (Qprocessp): Don't declare static.
8031 * lisp.h (Qprocessp): Declare again.
8032
8033 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
8034
8035 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8036
8037 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8038
8039 Improve C-level modularity by making more things 'static'.
8040
8041 Don't publish debugger-only interfaces to other modules.
8042 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8043 (verify_bytepos, count_markers): Move decls to the only modules
8044 that need them.
8045 * region-cache.h (pp_cache): Likewise.
8046 * window.h (check_all_windows): Likewise.
8047 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8048
8049 * sysdep.c (croak): Now static, if
8050 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8051 * syssignal.h (croak): Declare only if not static.
8052
8053 * alloc.c (refill_memory_reserve): Now static if
8054 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8055 * lisp.h (refill_memory_reserve): Declare only if not static.
8056
8057 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8058 Define only if USE_LUCID.
8059
8060 * xrdb.c (x_customization_string, x_rm_string): Now static.
8061
8062 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8063 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8064
8065 * xdisp.c (draw_row_with_mouse_face): Now static.
8066 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8067
8068 * window.h (check_all_windows): Mark externally visible.
8069
8070 * window.c (window_deletion_count): Now static.
8071
8072 * undo.c: Make symbols static if they're not exported.
8073 (last_undo_buffer, last_boundary_position, pending_boundary):
8074 Now static.
8075
8076 * textprop.c (interval_insert_behind_hooks): Now static.
8077 (interval_insert_in_front_hooks): Likewise.
8078
8079 * term.c: Make symbols static if they're not exported.
8080 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8081 (max_frame_lines, tty_set_terminal_modes):
8082 (tty_reset_terminal_modes, tty_turn_off_highlight):
8083 (get_tty_terminal): Now static.
8084 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8085 * termhooks.h (term_mouse_moveto): Do not declare if
8086 HAVE_WINDOW_SYSTEM.
8087 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8088 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8089
8090 * sysdep.c: Make symbols static if they're not exported.
8091 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8092 Now static.
8093 (sigprocmask_set, full_mask): Remove; unused.
8094 (wait_debugging): Mark as visible.
8095 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8096 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8097
8098 * syntax.c (syntax_temp): Define only if !__GNUC__.
8099
8100 * sound.c (current_sound_device, current_sound): Now static.
8101
8102 * search.c (searchbufs, searchbuf_head): Now static.
8103
8104 * scroll.c (scroll_cost): Remove; unused.
8105 * dispextern.h (scroll_cost): Remove decl.
8106
8107 * region-cache.h (pp_cache): Mark as externally visible.
8108
8109 * process.c: Make symbols static if they're not exported.
8110 (process_tick, update_tick, create_process, chan_process):
8111 (Vprocess_alist, proc_buffered_char, datagram_access):
8112 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8113 (deactivate_process): Mark defn as static, as well as decl.
8114 * lisp.h (create_process): Remove decl.
8115 * process.h (chan_process, Vprocess_alist): Remove decls.
8116
8117 * print.c: Make symbols static if they're not exported.
8118 (print_depth, new_backquote_output, being_printed, print_buffer):
8119 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8120 (print_interval, print_number_index, initial_stderr_stream):
8121 Now static.
8122 * lisp.h (Fprinc): Remove decl.
8123 (debug_output_compilation_hack): Mark as externally visible.
8124
8125 * sysdep.c (croak): Move decl from here to syssignal.h.
8126 * syssignal.h (croak): Put it here, so the API can be checked when
8127 'croak' is called from dissociate_if_controlling_tty.
8128
8129 * minibuf.c: Make symbols static if they're not exported.
8130 (minibuf_save_list, choose_minibuf_frame): Now static.
8131 * lisp.h (choose_minibuf_frame): Remove decl.
8132
8133 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8134
8135 * lread.c: Make symbols static if they're not exported.
8136 (read_objects, initial_obarray, oblookup_last_bucket_number):
8137 Now static.
8138 (make_symbol): Remove; unused.
8139 * lisp.h (initial_obarray, make_symbol): Remove decls.
8140
8141 * keyboard.c: Make symbols static if they're not exported.
8142 (single_kboard, recent_keys_index, total_keys, recent_keys):
8143 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8144 (this_single_command_key_start, echoing, last_auto_save):
8145 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8146 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8147 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8148 (Vlispy_mouse_stem, double_click_count):
8149 Now static.
8150 (force_auto_save_soon): Define only if SIGDANGER.
8151 (ignore_mouse_drag_p): Now static if
8152 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8153 (print_help): Remove; unused.
8154 (stop_character, last_timer_event): Mark as externally visible.
8155 * keyboard.h (ignore_mouse_drag_p): Declare only if
8156 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8157 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8158 * lisp.h (echoing): Remove decl.
8159 (force_auto_save_soon): Declare only if SIGDANGER.
8160 * xdisp.c (redisplay_window): Simplify code, to make it more
8161 obvious that ignore_mouse_drag_p is not accessed if !defined
8162 USE_GTK && !defined HAVE_NS.
8163
8164 * intervals.c: Make symbols static if they're not exported.
8165 (merge_properties_sticky, merge_interval_right, delete_interval):
8166 Now static.
8167 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8168
8169 * insdel.c: Make symbols static if they're not exported.
8170 However, leave prepare_to_modify_buffer alone. It's never
8171 called from outside this function, but that appears to be a bug.
8172 (combine_after_change_list, combine_after_change_buffer):
8173 (adjust_after_replace, signal_before_change): Now static.
8174 (adjust_after_replace_noundo): Remove; unused.
8175 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
8176 (signal_before_change): Remove decls.
8177
8178 * indent.c (val_compute_motion, val_vmotion): Now static.
8179
8180 * image.c: Make symbols static if they're not exported.
8181 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8182 if USE_GTK.
8183 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8184 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8185
8186 * fringe.c (standard_bitmaps): Now static.
8187 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8188
8189 * frame.c: Make symbols static if they're not exported.
8190 (x_report_frame_params, make_terminal_frame): Now static.
8191 (get_frame_param): Now static, unless HAVE_NS.
8192 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8193 (x_get_resource_string): Remove; not used.
8194 * frame.h (make_terminal_frame, x_report_frame_params):
8195 (x_get_resource_string); Remove decls.
8196 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8197 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8198
8199 * font.c, fontset.c: Make symbols static if they're not exported.
8200 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8201 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8202 * font.c (font_close_object): Now static.
8203 * font.h (font_close_object): Remove.
8204 * fontset.c (FONTSET_OBJLIST): Remove.
8205 (free_realized_fontset) #if-0 the body, which does nothing.
8206 (face_suitable_for_char_p): #if-0, as it's never called.
8207 * fontset.h (face_suitable_for_char_p): Remove decl.
8208 * xfaces.c (face_at_string_position):
8209 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
8210 since 0 is always ASCII.
8211
8212 * fns.c (weak_hash_tables): Now static.
8213
8214 * fileio.c: Make symbols static if they're not exported.
8215 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8216 (Vwrite_region_annotation_buffers): Now static.
8217
8218 * eval.c: Make symbols static if they're not exported.
8219 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8220 * lisp.h (backtrace_list): Remove decl.
8221
8222 * emacs.c: Make symbols static if they're not exported.
8223 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8224 (fatal_error_code, fatal_error_signal_hook, standard_args):
8225 Now static.
8226 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8227 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8228 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8229 * lisp.h (fatal_error_signal_hook): Remove decl.
8230 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8231
8232 * editfns.c: Move a (normally-unused) function to its only use.
8233 * editfns.c, lisp.h (get_operating_system_release): Remove.
8234 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8235 worth the hassle of breaking this out.
8236
8237 * xterm.c: Make symbols static if they're not exported.
8238 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8239 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8240 (x_destroy_window, x_delete_display):
8241 Now static.
8242 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8243 (x_mouse_leave): Remove; unused.
8244 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8245 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8246 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8247 Remove decls.
8248 (x_mouse_leave): Declare only if WINDOWSNT.
8249 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8250 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8251 USE_X_TOOLKIT.
8252
8253 * ftxfont.c: Make symbols static if they're not exported.
8254 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8255 HAVE_FREETYPE.
8256 * font.h (ftxfont_driver): Likewise.
8257
8258 * xfns.c: Make symbols static if they're not exported.
8259 (x_last_font_name, x_display_info_for_name):
8260 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8261 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8262 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8263 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8264 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8265 (last_show_tip_args): Now static.
8266 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8267 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8268 (x_screen_planes): Remove; unused.
8269 * dispextern.h (x_screen_planes): Remove decl.
8270
8271 * dispnew.c: Make symbols static if they're not exported.
8272 * dispextern.h (redraw_garbaged_frames, scrolling):
8273 (increment_row_positions): Remove.
8274 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8275 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8276 Now static.
8277 (redraw_garbaged_frames): Remove; unused.
8278
8279 * xfaces.c: Make symbols static if they're not exported.
8280 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8281 Remove decls.
8282 * xterm.h (defined_color): Remove decls.
8283 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8284 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8285 (menu_face_changed_default, defined_color, free_realized_face):
8286 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8287 (ascii_face_of_lisp_face): Remove; unused.
8288
8289 * xdisp.c: Make symbols static if they're not exported.
8290 * dispextern.h (scratch_glyph_row, window_box_edges):
8291 (glyph_to_pixel_coords, set_cursor_from_row):
8292 (get_next_display_element, set_iterator_to_next):
8293 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8294 (show_mouse_face): Remove decls
8295 * frame.h (message_buf_print): Likewise.
8296 * lisp.h (pop_message, set_message, check_point_in_composition):
8297 Likewise.
8298 * xterm.h (set_vertical_scroll_bar): Likewise.
8299 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8300 (message_buf_print, scratch_glyph_row, displayed_buffer):
8301 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8302 (get_next_display_element, show_mouse_face, window_box_edges):
8303 (frame_to_window_pixel_xy, check_point_in_composition):
8304 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8305 (glyph_to_pixel_coords): Remove; unused.
8306
8307 * dired.c (file_name_completion): Now static.
8308
8309 * dbusbind.c (xd_in_read_queued_messages): Now static.
8310
8311 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8312 * data.c (circular_list_error): Remove.
8313
8314 * commands.h (last_point_position, last_point_position_buffer):
8315 (last_point_position_window): Remove decls.
8316 * keyboard.c: Make these variables static.
8317
8318 * coding.h (coding, code_convert_region, encode_coding_gap):
8319 Remove decls.
8320 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8321 (iso_code_class, detect_coding, code_convert_region): Now static.
8322 (encode_coding_gap): Remove; unused.
8323
8324 * chartab.c (chartab_chars, chartab_bits): Now static.
8325
8326 * charset.h (charset_iso_8859_1): Remove decl.
8327 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8328 Now static.
8329
8330 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8331 * ccl.c (Vccl_program_table): Now static.
8332 (check_ccl_update): Remove; unused.
8333
8334 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8335 * category.h: ... from here.
8336 * category.c (check_category_table, set_category_set): Now static.
8337
8338 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8339 * lisp.h: Remove these decls.
8340
8341 * buffer.c (buffer_count): Remove unused var.
8342
8343 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8344 so that it's not optimized away.
8345 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8346 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8347 exported only to the debugger.
8348
8349 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8350 * atimer.h (run_all_atimers): Remove; not exported.
8351
8352 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8353 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8354 was inaccessible from Lisp.
8355 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8356 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8357
8358 alloc.c: Import and export fewer symbols, and remove unused items.
8359 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8360 is defined.
8361 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8362 it's not optimized away by whole-program optimization.
8363 (message_enable_multibyte, free_misc): Remove.
8364 (catchlist, handlerlist, mark_backtrace):
8365 Declare only if BYTE_MARK_STACK.
8366 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8367 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8368 (message_enable_multibyte): Remove decl.
8369 (free_misc, interval_free_list, float_block, float_block_index):
8370 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8371 (cons_free_list, last_marked_index):
8372 Now static.
8373 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8374 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8375 (mark_backtrace): Define only if BYTE_MARK_STACK.
8376 * xdisp.c (message_enable_multibyte): Now static.
8377
8378 Declare Lisp_Object Q* variables to be 'static' if not exported.
8379 This makes it easier for human readers (and static analyzers)
8380 to see whether these variables are used from other modules.
8381 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8382 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8383 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8384 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8385 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8386 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8387 * xmenu.c, xselect.c:
8388 Declare Q* vars static if they are not used in other modules.
8389 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8390 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8391 Remove decls of unexported vars.
8392 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8393
8394 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8395
8396 Make Emacs functions such as Fatom 'static' by default.
8397 This makes it easier for human readers (and static analyzers)
8398 to see whether these functions can be called from other modules.
8399 DEFUN now defines a static function. To make the function external
8400 so that it can be used in other C modules, use the new macro DEFUE.
8401 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8402 (Finit_image_library):
8403 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8404 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8405 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8406 Remove decls, since these functions are now static.
8407 (Funintern, Fget_internal_run_time): New decls, since these functions
8408 were already external.
8409
8410 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8411 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8412 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8413 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8414 * keyboard.c, keymap.c, lread.c:
8415 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8416 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8417 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8418 Mark functions with DEFUE instead of DEFUN,
8419 if they are used in other modules.
8420 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8421 decls for now-static functions.
8422 * buffer.h (Fdelete_overlay): Remove decl.
8423 * callproc.c (Fgetenv_internal): Mark as internal.
8424 * composite.c (Fremove_list_of_text_properties): Remove decl.
8425 (Fcomposition_get_gstring): New forward static decl.
8426 * composite.h (Fcomposite_get_gstring): Remove decl.
8427 * dired.c (Ffile_attributes): New forward static decl.
8428 * doc.c (Fdocumntation_property): New forward static decl.
8429 * eval.c (Ffetch_bytecode): New forward static decl.
8430 (Funintern): Remove extern decl; now in .h file where it belongs.
8431 * fileio.c (Fmake_symbolic_link): New forward static decl.
8432 * image.c (Finit_image_library): New forward static decl.
8433 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8434 * intervals.h (Fprevious_property_change):
8435 (Fremove_list_of_text_properties): Remove decls.
8436 * keyboard.c (Fthis_command_keys): Remove decl.
8437 (Fcommand_execute): New forward static decl.
8438 * keymap.c (Flookup_key): New forward static decl.
8439 (Fcopy_keymap): Now static.
8440 * keymap.h (Flookup_key): Remove decl.
8441 * process.c (Fget_process): New forward static decl.
8442 (Fprocess_datagram_address): Mark as internal.
8443 * syntax.c (Fsyntax_table_p): New forward static decl.
8444 (skip_chars): Remove duplicate decl.
8445 * textprop.c (Fprevious_property_change): New forward static decl.
8446 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8447 Now internal.
8448 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8449 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8450
8451 * editfns.c (Fformat): Remove unreachable code.
8452
8453 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8454
8455 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8456 change. (Bug#8496)
8457
8458 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8459
8460 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8461 when at ZV. (Bug#8487)
8462
8463 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8464
8465 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8466 (Bug#8437)
8467 * keyboard.c (parse_tool_bar_item): Likewise.
8468 * sound.c (sound_cleanup, alsa_close): Likewise.
8469 * termcap.c (tgetent): Likewise.
8470 * xfns.c (x_default_font_parameter): Likewise.
8471 * xsettings.c (read_and_apply_settings): Likewise.
8472
8473 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8474 (overrun_check_free): Protoize.
8475
8476 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8477
8478 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8479 since callers should never pass a negative size.
8480 Change the signature to match that of plain 'read' and 'write'; see
8481 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8482 * lisp.h: Update prototypes of emacs_write and emacs_read.
8483
8484 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8485
8486 * xdisp.c (redisplay_window): Don't try to determine the character
8487 position of the scroll margin if the window start point w->startp
8488 is outside the buffer's accessible region. (Bug#8468)
8489
8490 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8491
8492 Fix write-region and its subroutines for buffers > 2GB.
8493 * fileio.c (a_write, e_write): Modify declaration of arguments and
8494 local variables to support buffers larger than 2GB.
8495 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8496
8497 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8498 argument, local variables, and return value.
8499
8500 * lisp.h: Update prototypes of emacs_write and emacs_read.
8501
8502 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8503
8504 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8505
8506 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8507
8508 Fix more problems found by GCC 4.6.0's static checks.
8509
8510 * xdisp.c (vmessage): Use a better test for character truncation.
8511
8512 * charset.c (load_charset_map): <, not <=, for optimization,
8513 and to avoid potential problems with integer overflow.
8514 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8515 * casetab.c (set_identity, shuffle): Likewise.
8516 * editfns.c (Fformat): Likewise.
8517 * syntax.c (skip_chars): Likewise.
8518
8519 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8520 This also lets GCC 4.6.0 generate slightly better loop code.
8521
8522 * callint.c (Fcall_interactively): <, not <=, for optimization.
8523 (Fcall_interactively): Count the number of arguments produced,
8524 not the number of arguments given. This is simpler and lets GCC
8525 4.6.0 generate slightly better code.
8526
8527 * ftfont.c: Distingish more carefully between FcChar8 and char.
8528 The previous code passed unsigned char * to a functions like
8529 strlen and xstrcasecmp that expect char *, which does not
8530 conform to the C standard.
8531 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8532 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8533 char * when the C standard requires it.
8534
8535 * keyboard.c (read_char): Remove unused var.
8536
8537 * eval.c: Port to Windows vsnprintf (Bug#8435).
8538 Include <limits.h>.
8539 (SIZE_MAX): Define if the headers do not.
8540 (verror): Do not give up if vsnprintf returns a negative count.
8541 Instead, grow the buffer. This ports to Windows vsnprintf, which
8542 does not conform to C99. Problem reported by Eli Zaretskii.
8543 Also, simplify the allocation scheme, by avoiding the need for
8544 calling realloc, and removing the ALLOCATED variable.
8545
8546 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8547
8548 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8549 But keep the doprint source code for now, as we might revamp it
8550 and use it again (Bug#8435).
8551 * lisp.h (doprnt): Remove.
8552 * Makefile.in (base_obj): Remove doprnt.o.
8553 * deps.mk (doprnt.o): Remove.
8554
8555 error: Print 32- and 64-bit integers portably (Bug#8435).
8556 Without this change, on typical 64-bit hosts error ("...%d...", N)
8557 was used to print both 32- and 64-bit integers N, which relied on
8558 undefined behavior.
8559 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8560 * lisp.h (error, verror): Mark as printf-like functions.
8561 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8562 Report overflow in size calculations when allocating printf buffer.
8563 Do not truncate output string at its first null byte.
8564 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8565 Truncate the output at a character boundary, since vsnprintf does not
8566 do that.
8567 * charset.c (check_iso_charset_parameter): Convert internal
8568 character to string before calling 'error', since %c now has the
8569 printf meaning.
8570 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8571 overflow when computing char to be passed to 'error'. Do not
8572 pass Lisp_Object to 'error'; pass the integer instead.
8573 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8574 formatted with plain %d.
8575
8576 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8577
8578 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8579
8580 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8581
8582 * xterm.c (x_catch_errors): Remove duplicate declaration.
8583
8584 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8585
8586 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8587
8588 2011-04-10 Jim Meyering <meyering@redhat.com>
8589
8590 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8591 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8592 return ssize_t not "int", and use size_t as the buffer length.
8593 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8594 * gnutls.h: Update declarations.
8595 * process.c (read_process_output): Use ssize_t, to match.
8596 (send_process): Likewise.
8597
8598 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8599
8600 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8601
8602 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8603
8604 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8605 Use unsigned char, to match FcChar8 type definition.
8606
8607 * xterm.c (handle_one_xevent):
8608 * xmenu.c (create_and_show_popup_menu):
8609 * xselect.c (x_decline_selection_request)
8610 (x_reply_selection_request): Avoid type-punned deref of X events.
8611
8612 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8613
8614 Fix some uses of `int' instead of EMACS_INT.
8615 * search.c (string_match_1, fast_string_match)
8616 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8617 (scan_buffer, find_next_newline_no_quit)
8618 (find_before_next_newline, search_command, Freplace_match)
8619 (Fmatch_data): Make some `int' variables be EMACS_INT.
8620
8621 * xdisp.c (display_count_lines): 3rd argument and return value now
8622 EMACS_INT. All callers changed.
8623 (pint2hrstr): Last argument is now EMACS_INT.
8624
8625 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8626 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8627 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8628 (decode_coding_utf_16, decode_coding_emacs_mule)
8629 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8630 (decode_coding_ccl, decode_coding_charset)
8631 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8632 (decode_coding_iso_2022, decode_coding_emacs_mule)
8633 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8634 <char_offset, last_offset>: Declare EMACS_INT.
8635 (encode_coding_utf_8, encode_coding_utf_16)
8636 (encode_coding_emacs_mule, encode_invocation_designation)
8637 (encode_designation_at_bol, encode_coding_iso_2022)
8638 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8639 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8640 Declare EMACS_INT.
8641 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8642 (encode_invocation_designation): Last argument P_NCHARS is now
8643 EMACS_INT.
8644 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8645 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8646
8647 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8648 All users changed.
8649
8650 * ccl.c (Fccl_execute_on_string): Declare some variables
8651 EMACS_INT.
8652
8653 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8654
8655 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8656
8657 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8658
8659 * process.c (Fformat_network_address): Doc fix.
8660
8661 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8662
8663 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8664
8665 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8666
8667 * keyboard.c (read_char): Call Lisp function help-form-show,
8668 instead of using internal_with_output_to_temp_buffer.
8669 (Qhelp_form_show): New var.
8670 (syms_of_keyboard): Use DEFSYM macro.
8671
8672 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8673
8674 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8675
8676 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8677
8678 * process.c (Flist_processes): Remove to Lisp.
8679 (list_processes_1): Delete.
8680
8681 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8682
8683 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8684
8685 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8686
8687 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8688
8689 Fix more problems found by GCC 4.6.0's static checks.
8690
8691 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8692
8693 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8694
8695 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8696
8697 * xdisp.c (vmessage): Mark as a printf-like function.
8698
8699 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8700
8701 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8702
8703 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8704 printf-like functions.
8705 (tiff_load): Add casts to remove these marks before passing them
8706 to system-supplied API.
8707
8708 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8709
8710 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8711 This avoids several warnings with gcc -Wstrict-overflow.
8712 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8713 directly, rather than having caller test rule sign. This avoids
8714 some unnecessary tests.
8715 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8716 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8717 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8718
8719 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8720 (xfont_open): Avoid unnecessary tests.
8721
8722 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8723
8724 * composite.h, composite.c (composition_gstring_put_cache):
8725 Use EMACS_INT, not int, for length.
8726
8727 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8728 breaking out part of COMPOSITION_DECODE_RULE.
8729 (COMPOSITION_DECODE_RULE): Use it.
8730 * composite.c (get_composition_id): Remove unused local vars,
8731 by using the new macro.
8732
8733 * textprop.c (set_text_properties_1): Change while to do-while,
8734 since the condition is always true at first.
8735
8736 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8737 (interval_deletion_adjustment): Return unsigned value.
8738 All uses changed.
8739
8740 * process.c (list_processes_1, create_pty, read_process_output):
8741 (exec_sentinel): Remove vars that were set but not used.
8742 (create_pty): Remove unnecessary "volatile"s.
8743 (Fnetwork_interface_info): Avoid possibility of int overflow.
8744 (read_process_output): Do adaptive read buffering even if carryover.
8745 (read_process_output): Simplify nbytes computation if buffered.
8746
8747 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8748
8749 * syntax.c (scan_words): Remove var that was set but not used.
8750 (update_syntax_table): Use unsigned instead of int.
8751
8752 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8753 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8754 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8755
8756 * print.c (print_error_message): Avoid int overflow.
8757
8758 * font.c (font_list_entities): Redo for clarity,
8759 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8760
8761 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8762 (font_score): Avoid potential overflow in diff calculation.
8763
8764 * fns.c (substring_both): Remove var that is set but not used.
8765 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8766
8767 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8768
8769 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8770 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8771 can always succeed if overflow has undefined behavior.
8772
8773 * search.c (boyer_moore, wordify): Remove vars set but not used.
8774 (wordify): Omit three unnecessary tests.
8775
8776 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8777 All callers changed. This avoids the need for an unused var.
8778
8779 * casefiddle.c (casify_region): Remove var that is set but not used.
8780
8781 * dired.c (file_name_completion): Remove var that is set but not used.
8782
8783 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8784
8785 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8786 (Finsert_file_contents): Remove unnecessary code checking fd.
8787
8788 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8789 Check for integer overflow on size calculations.
8790
8791 * buffer.c (Fprevious_overlay_change): Remove var that is set
8792 but not used.
8793
8794 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8795 Remove vars that are set but not used.
8796 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8797 (timer_check_2): Mark vars as initialized.
8798
8799 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8800
8801 * image.c (lookup_image): Remove var that is set but not used.
8802 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8803
8804 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8805 that are set but not used.
8806
8807 * xfns.c (make_invisible_cursor): Don't return garbage
8808 if XCreateBitmapFromData fails (Bug#8410).
8809
8810 * xselect.c (x_get_local_selection, x_handle_property_notify):
8811 Remove vars that are set but not used.
8812
8813 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8814 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8815
8816 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8817 Remove var that is set but not used.
8818 (scroll_bar_windows_size): Now size_t, not int.
8819 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8820 Check for overflow.
8821
8822 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8823 (map_tty_color) [!defined MSDOS]: Likewise.
8824
8825 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8826
8827 * coding.c: Remove vars that are set but not used.
8828 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8829 All callers changed.
8830 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8831 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8832 (decode_coding_charset): Remove vars that are set but not used.
8833
8834 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8835 that is set but not used.
8836
8837 * print.c (print_object): Remove var that is set but not used.
8838
8839 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8840 The gnulib version avoids calling malloc in the usual case,
8841 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8842 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8843 * filelock.c (current_lock_owner): Likewise.
8844 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8845 * sysdep.c: Include allocator.h, careadlinkat.h.
8846 (emacs_no_realloc_allocator): New static constant.
8847 (emacs_readlink): New function.
8848 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8849 ../lib/careadlinkat.h.
8850
8851 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8852
8853 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8854 first non-nil return value).
8855
8856 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8857
8858 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8859 if not defined (Bug#8403).
8860
8861 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8862
8863 * xdisp.c (display_count_lines): Remove parameter `start',
8864 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8865 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8866 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8867 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8868 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8869 and thereabouts. All callers changed.
8870 (get_per_char_metric): Remove parameter `f', unused since
8871 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8872
8873 2011-04-02 Jim Meyering <meyering@redhat.com>
8874
8875 do not dereference NULL upon failed strdup
8876 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8877 (ns_get_family): Likewise.
8878
8879 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8880
8881 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8882
8883 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8884
8885 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8886 later (Bug#8403).
8887
8888 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8889
8890 Add lexical binding.
8891
8892 * window.c (Ftemp_output_buffer_show): New fun.
8893 (Fsave_window_excursion):
8894 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8895
8896 * lread.c (lisp_file_lexically_bound_p): New function.
8897 (Fload): Bind Qlexical_binding.
8898 (readevalloop): Remove `evalfun' arg.
8899 Bind Qinternal_interpreter_environment.
8900 (Feval_buffer): Bind Qlexical_binding.
8901 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8902 Mark as dynamic.
8903 (syms_of_lread): Declare `lexical-binding'.
8904
8905 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8906
8907 * keyboard.c (eval_dyn): New fun.
8908 (menu_item_eval_property): Use it.
8909
8910 * image.c (parse_image_spec): Use Ffunctionp.
8911
8912 * fns.c (concat, mapcar1): Accept byte-code-functions.
8913
8914 * eval.c (Fsetq): Handle lexical vars.
8915 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8916 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8917 (FletX, Flet): Obey lexical binding.
8918 (Fcommandp): Handle closures.
8919 (Feval): New `lexical' arg.
8920 (eval_sub): New function extracted from Feval. Use it almost
8921 everywhere where Feval was used. Look up vars in lexical env.
8922 Handle closures.
8923 (Ffunctionp): Move from subr.el.
8924 (Ffuncall): Handle closures.
8925 (apply_lambda): Remove `eval_flags'.
8926 (funcall_lambda): Handle closures and new byte-code-functions.
8927 (Fspecial_variable_p): New function.
8928 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8929 but without exporting it to Lisp.
8930
8931 * doc.c (Fdocumentation, store_function_docstring):
8932 * data.c (Finteractive_form): Handle closures.
8933
8934 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8935 interactive spec.
8936
8937 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8938 New byte-codes.
8939 (exec_byte_code): New function extracted from Fbyte_code to handle new
8940 calling convention for byte-code-functions. Add new byte-codes.
8941
8942 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8943
8944 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8945
8946 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8947
8948 * xdisp.c (redisplay_internal): Fix prototype.
8949
8950 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8951
8952 * xdisp.c (SCROLL_LIMIT): New macro.
8953 (try_scrolling): Use it when setting scroll_limit.
8954 Limit scrolling to 100 screen lines.
8955 (redisplay_window): Even when falling back on "recentering",
8956 position point in the window according to scroll-conservatively,
8957 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8958
8959 (try_scrolling): When point is above the window, allow searching
8960 as far as scroll_max, or one screenful, to compute vertical
8961 distance from PT to the scroll margin position. This prevents
8962 try_scrolling from unnecessarily failing when
8963 scroll-conservatively is set to a value slightly larger than the
8964 window height. Clean up the case of PT below the margin at bottom
8965 of window: scroll_max can no longer be INT_MAX. When aggressive
8966 scrolling is in use, don't let point enter the opposite scroll
8967 margin as result of the scroll.
8968 (syms_of_xdisp) <scroll-conservatively>: Document the
8969 threshold of 100 lines for never-recentering scrolling.
8970
8971 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8972
8973 * dispextern.h (move_it_by_lines):
8974 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8975 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8976 (message_log_check_duplicate): Remove parameters `prev_bol' and
8977 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8978 (redisplay_internal): Remove parameter `preserve_echo_area',
8979 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8980
8981 * indent.c (Fvertical_motion):
8982 * window.c (window_scroll_pixel_based, Frecenter):
8983 Don't pass `need_y_p' to `move_it_by_lines'.
8984
8985 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8986
8987 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8988 steal a few bits to be more compact.
8989 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8990 Remove unneeded casts.
8991
8992 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8993
8994 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8995
8996 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8997 binding" message (bug#7967).
8998
8999 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
9000
9001 Fix more problems found by GCC 4.6.0's static checks.
9002
9003 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
9004 Remove unused local var.
9005
9006 * editfns.c (Fmessage_box): Remove unused local var.
9007
9008 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
9009 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9010 Omit unused local vars.
9011 * window.c (shrink_windows): Omit unused local var.
9012 * menu.c (digest_single_submenu): Omit unused local var.
9013 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9014 Omit unused local var.
9015
9016 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9017 Don't assume string length fits in int.
9018 (keyremap_step, read_key_sequence): Use size_t for sizes.
9019 (read_key_sequence): Don't check last_real_key_start redundantly.
9020
9021 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9022 instead of alloca (Bug#8344).
9023
9024 * eval.c (Fbacktrace): Don't assume nargs fits in int.
9025 (Fbacktrace_frame): Don't assume nframes fits in int.
9026
9027 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9028
9029 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9030 concerns.
9031
9032 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9033
9034 * cm.c (calccost): Turn while-do into do-while, for clarity.
9035
9036 * keyboard.c (syms_of_keyboard): Use the same style as later
9037 in this function when indexing through an array. This also
9038 works around GCC bug 48267.
9039
9040 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9041
9042 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9043
9044 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9045 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9046
9047 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9048 This avoids undefined behavior on integer overflow, and is a bit
9049 more convenient anyway since it is compared to a size_t variable.
9050
9051 Variadic C functions now count arguments with size_t, not int.
9052 This avoids an unnecessary limitation on 64-bit machines, which
9053 caused (substring ...) to crash on large vectors (Bug#8344).
9054 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9055 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
9056 All variadic functions and their callers changed accordingly.
9057 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9058 * data.c (arith_driver, float_arith_driver): Likewise.
9059 * editfns.c (general_insert_function): Likewise.
9060 * eval.c (struct backtrace.nargs, interactive_p)
9061 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9062 (funcall_lambda, mark_backtrace): Likewise.
9063 * fns.c (concat): Likewise.
9064 * frame.c (x_set_frame_parameters): Likewise.
9065 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9066 0 if not found, not -1. All callers changed.
9067
9068 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9069 (stack_copy_size): Now size_t, not int.
9070 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9071
9072 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9073
9074 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9075 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9076 All callers changed.
9077
9078 * lisp.h (multibyte_char_to_unibyte):
9079 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9080 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9081 * character.h (CHAR_TO_BYTE8):
9082 * cmds.c (internal_self_insert):
9083 * editfns.c (general_insert_function):
9084 * keymap.c (push_key_description):
9085 * search.c (Freplace_match):
9086 * xdisp.c (message_dolog, set_message_1): All callers changed.
9087
9088 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9089
9090 * keyboard.c (safe_run_hook_funcall): New function.
9091 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9092 don't set the hook to nil, but remove the offending function instead.
9093 (Qcommand_hook_internal): Remove, unused.
9094 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9095 Vcommand_hook_internal.
9096
9097 * eval.c (enum run_hooks_condition): Remove.
9098 (funcall_nil, funcall_not): New functions.
9099 (run_hook_with_args): Call each function through a `funcall' argument.
9100 Remove `cond' argument, now redundant.
9101 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9102 (Frun_hook_with_args_until_failure): Adjust accordingly.
9103 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9104
9105 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9106
9107 * dispextern.h (string_buffer_position): Remove declaration.
9108
9109 * print.c (strout): Remove parameter `multibyte', unused since
9110 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9111
9112 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9113 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9114 All callers changed.
9115
9116 * w32.c (_wsa_errlist): Use braces for struct initializers.
9117
9118 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9119 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9120 All callers changed.
9121 (string_buffer_position): Likewise. Also, make static (it's never
9122 used outside xdisp.c).
9123 (cursor_row_p): Remove parameter `w', unused since
9124 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9125 (decode_mode_spec): Remove parameter `precision', introduced during
9126 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9127 All callers changed.
9128
9129 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9130
9131 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9132
9133 2011-03-27 Anders Lindgren <andlind@gmail.com>
9134
9135 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9136 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9137 (ns_update_auto_hide_menu_bar): New functions.
9138 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9139 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9140 ns_constrain_all_frames.
9141 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9142 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9143
9144 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9145
9146 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9147
9148 2011-03-27 Glenn Morris <rgm@gnu.org>
9149
9150 * syssignal.h: Replace RETSIGTYPE with void.
9151 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9152 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9153 Replace SIGTYPE with void everywhere.
9154 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9155 * s/template.h (SIGTYPE): Remove commented out definition.
9156
9157 2011-03-26 Eli Zaretskii <eliz@gnu.org>
9158
9159 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9160 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9161
9162 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
9163
9164 * w32.c (read_unc_volume): Use parameter `henum', instead of
9165 global variable `wget_enum_handle'.
9166
9167 * keymap.c (describe_vector): Remove parameters `indices' and
9168 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9169 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9170
9171 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9172
9173 * keyboard.c (timer_check): Remove parameter `do_it_now',
9174 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9175 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9176 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9177
9178 * keyboard.c (read_char):
9179 * w32menu.c (w32_menu_display_help):
9180 * xmenu.c (show_help_event, menu_help_callback):
9181 Adjust calls to `show_help_echo'.
9182
9183 * gtkutil.c (xg_maybe_add_timer):
9184 * keyboard.c (readable_events):
9185 * process.c (wait_reading_process_output):
9186 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9187
9188 * insdel.c (adjust_markers_gap_motion):
9189 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9190 (gap_left, gap_right): Don't call it.
9191
9192 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
9193
9194 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9195 incurred during fontification.
9196
9197 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9198
9199 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9200 (DEFVAR_PER_BUFFER): Don't pass it.
9201
9202 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9203 (scrolling_window): Don't pass it.
9204
9205 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9206
9207 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9208
9209 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9210 and `suffix'.
9211 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9212 of variables specific to SELinux and computation of `encoded_absname'.
9213
9214 * image.c (XPutPixel): Remove unused variable `height'.
9215
9216 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9217
9218 * unexw32.c (get_section_info): Remove unused variable `section'.
9219
9220 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9221 (system_process_attributes): Remove unused variable `sess'.
9222 (sys_read): Remove unused variable `err'.
9223
9224 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9225 (w32_wnd_proc): Remove unused variable `isdead'.
9226 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9227 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9228 (x_create_tip_frame): Remove unused variable `tem'.
9229
9230 * w32inevt.c (w32_console_read_socket):
9231 Remove unused variable `no_events'.
9232
9233 * w32term.c (x_draw_composite_glyph_string_foreground):
9234 Remove unused variable `width'.
9235
9236 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9237
9238 * w32term.c (x_set_glyph_string_clipping):
9239 Don't pass uninitialized region to CombineRgn.
9240
9241 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9242
9243 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9244 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9245 (Fx_close_connection): Remove unused variable `i'.
9246
9247 * w32font.c (w32font_draw): Return number of glyphs.
9248 (w32font_open_internal): Remove unused variable `i'.
9249 (w32font_driver): Add missing initializer.
9250
9251 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9252 (fill_in_menu): Remove unused variable `items_added'.
9253
9254 * w32term.c (last_mouse_press_frame): Remove static global variable.
9255 (w32_clip_to_row): Remove unused variable `f'.
9256 (x_delete_terminal): Remove unused variable `i'.
9257
9258 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9259 (NOTHING): Remove unused static global variable.
9260 (uniscribe_check_otf): Remove unused variable `table'.
9261 (uniscribe_font_driver): Add missing initializers.
9262
9263 2011-03-23 Julien Danjou <julien@danjou.info>
9264
9265 * term.c (Fsuspend_tty, Fresume_tty):
9266 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9267 * window.c (temp_output_buffer_show):
9268 * insdel.c (signal_before_change):
9269 * frame.c (Fhandle_switch_frame):
9270 * fileio.c (Fdo_auto_save):
9271 * emacs.c (Fkill_emacs):
9272 * editfns.c (save_excursion_restore):
9273 * cmds.c (internal_self_insert):
9274 * callint.c (Fcall_interactively):
9275 * buffer.c (Fkill_all_local_variables):
9276 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9277 Use Frun_hooks.
9278 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9279 unconditionally since it does the check itself.
9280
9281 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9282
9283 Fix more problems found by GCC 4.5.2's static checks.
9284
9285 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9286 the first time through the loop, since we know p0 < p1 then.
9287 This also avoids a gcc -Wstrict-overflow warning.
9288
9289 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9290 leading to a memory leak, possible in functions like
9291 load_charset_map_from_file that can allocate an unbounded number
9292 of objects (Bug#8318).
9293
9294 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9295 that could (at least in theory) be that large.
9296
9297 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9298 This is less likely to overflow, and avoids undefined behavior if
9299 overflow does occur. All callers changed. Use strtoul to scan
9300 for the unsigned long integer.
9301 (pint2hrstr): Simplify and tune code slightly.
9302 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9303
9304 * scroll.c (do_scrolling): Work around GCC bug 48228.
9305 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9306
9307 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9308 This also avoids a warning with gcc -Wstrict-overflow.
9309 (validate_x_resource_name): Simplify count usage.
9310 This also avoids a warning with gcc -Wstrict-overflow.
9311
9312 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9313 fail (Bug#8306).
9314
9315 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9316
9317 * process.c (Fmake_network_process): Use socklen_t, not int,
9318 where POSIX says socklen_t is required in portable programs.
9319 This fixes a porting bug on hosts like 64-bit HP-UX, where
9320 socklen_t is wider than int (Bug#8277).
9321 (Fmake_network_process, server_accept_connection):
9322 (wait_reading_process_output, read_process_output):
9323 Likewise.
9324
9325 * process.c: Rename or move locals to avoid shadowing.
9326 (list_processes_1, Fmake_network_process):
9327 (read_process_output_error_handler, exec_sentinel_error_handler):
9328 Rename or move locals.
9329 (Fmake_network_process): Define label "retry_connect" only if needed.
9330 (Fnetwork_interface_info): Fix pointer signedness.
9331 (process_send_signal): Add cast to avoid pointer signedness problem.
9332 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9333 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9334
9335 Make tparam.h and terminfo.c consistent.
9336 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9337 Include tparam.h instead, since it declares them.
9338 * cm.h (PC): Remove extern decl; tparam.h now does this.
9339 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9340 * terminfo.c: Include tparam.h, to check interfaces.
9341 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9342 (tparam): Adjust signature to match interface in tparam.h;
9343 this removes some undefined behavior. Check that outstring and len
9344 are zero, which they always are with Emacs.
9345 * tparam.h (PC, BC, UP): New extern decls.
9346
9347 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9348 (xftfont_open): Rename locals to avoid shadowing.
9349
9350 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9351 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9352 (OTF_TAG_SYM): Omit macro if not needed.
9353 (ftfont_list): Remove unused local.
9354 (get_adstyle_property, ftfont_pattern_entity):
9355 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9356 Rename locals to avoid shadowing.
9357
9358 * xfont.c (xfont_list_family): Mark var as initialized.
9359
9360 * xml.c (make_dom): Now static.
9361
9362 * composite.c (composition_compute_stop_pos): Rename local to
9363 avoid shadowing.
9364 (composition_reseat_it): Remove unused locals.
9365 (find_automatic_composition, composition_adjust_point): Likewise.
9366 (composition_update_it): Mark var as initialized.
9367 (find_automatic_composition): Mark vars as initialized,
9368 with a FIXME (Bug#8290).
9369
9370 character.h: Rename locals to avoid shadowing.
9371 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9372 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9373 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9374 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9375 to avoid shadowing.
9376
9377 * textprop.c (property_change_between_p): Remove; unused.
9378
9379 * intervals.c (interval_start_pos): Now static.
9380
9381 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9382
9383 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9384 Rename locals to avoid shadowing.
9385
9386 * sound.c (wav_play, au_play, Fplay_sound_internal):
9387 Fix pointer signedness.
9388 (alsa_choose_format): Remove unused local var.
9389 (wav_play): Initialize a variable to 0, to prevent undefined
9390 behavior (Bug#8278).
9391
9392 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9393
9394 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9395
9396 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9397 clobbering (Bug#8298).
9398 * sysdep.c (sys_subshell): Likewise.
9399 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9400
9401 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9402 This should get cleaned up, so that child_setup has the
9403 same signature on all platforms.
9404
9405 * callproc.c (call_process_cleanup): Now static.
9406 (relocate_fd): Rename locals to avoid shadowing.
9407
9408 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9409
9410 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9411 not to be necessary, and produces flickering.
9412
9413 2011-03-20 Glenn Morris <rgm@gnu.org>
9414
9415 * config.in: Remove file.
9416
9417 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9418
9419 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9420 are now in src/globals.h.
9421 (syms_of_minibuf): Remove spurious & from previous change.
9422
9423 2011-03-20 Leo Liu <sdl.web@gmail.com>
9424
9425 * minibuf.c (completing-read-function): New variable.
9426 (completing-read-default): Rename from completing-read.
9427 (completing-read): Call completing-read-function.
9428
9429 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9430
9431 * xfaces.c (Fx_load_color_file):
9432 Read color file from absolute filename (bug#8250).
9433
9434 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9435
9436 * makefile.w32-in: Update dependencies.
9437
9438 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9439
9440 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9441
9442 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9443
9444 Fix more problems found by GCC 4.5.2's static checks.
9445
9446 * process.c (make_serial_process_unwind, send_process_trap):
9447 (sigchld_handler): Now static.
9448
9449 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9450 That way, the code declares only the vars that it needs.
9451 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9452 * s/cygwin.h (PTY_ITERATION): Likewise.
9453 * s/darwin.h (PTY_ITERATION): Likewise.
9454 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9455
9456 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9457 * process.c (allocate_pty): Don't declare stb unless it's needed.
9458
9459 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9460 (CONSTANTLIM): Remove; unused.
9461 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9462 Define only if needed.
9463
9464 * unexelf.c (unexec): Name an expression,
9465 to avoid gcc -Wbad-function-cast warning.
9466 Use a different way to cause a compilation error if anyone uses
9467 n rather than nn, a way that does not involve shadowing.
9468 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9469
9470 * deps.mk (unexalpha.o): Remove; unused.
9471
9472 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9473 * unexec.h: New file.
9474 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9475 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9476 Depend on unexec.h.
9477 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9478 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9479 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9480 Change as necessary to match prototype in unexec.h.
9481
9482 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9483 shadowing.
9484 (back_comment, skip_chars): Mark vars as initialized.
9485
9486 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9487 Rename locals to avoid shadowing.
9488
9489 * lread.c (read1): Rewrite so as not to use empty "else".
9490 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9491
9492 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9493
9494 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9495 warning when compiling print.c.
9496
9497 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9498 instead of using an uninitialized var.
9499 (font_sort_entities): Mark var as initialized.
9500
9501 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9502
9503 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9504 pointers to constants.
9505 (font_parse_fcname): Remove unused vars.
9506 (font_delete_unmatched): Now static.
9507 (font_get_spec): Remove; unused.
9508 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9509 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9510 Rename or move locals to avoid shadowing.
9511
9512 * fns.c (require_nesting_list, require_unwind): Now static.
9513 (Ffillarray): Rename locals to avoid shadowing.
9514
9515 * floatfns.c (domain_error2): Define only if needed.
9516 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9517
9518 * alloc.c (mark_backtrace): Move decl from here ...
9519 * lisp.h: ... to here, so that it can be checked.
9520
9521 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9522 (Fdefvar): Rewrite so as not to use empty "else".
9523 (lisp_indirect_variable): Name an expression,
9524 to avoid gcc -Wbad-function-cast warning.
9525 (Fdefvar): Rename locals to avoid shadowing.
9526
9527 * callint.c (quotify_arg, quotify_args): Now static.
9528 (Fcall_interactively): Rename locals to avoid shadowing.
9529 Use const pointer when appropriate.
9530
9531 * lisp.h (get_system_name, get_operating_system_release):
9532 Move decls here, to check interfaces.
9533 * process.c (get_operating_system_release): Move decl to lisp.h.
9534 * xrdb.c (get_system_name): Likewise.
9535 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9536 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9537 some of which prompt warnings from gcc -Wbad-function-cast.
9538 (Fformat_time_string, Fencode_time, Finsert_char):
9539 (Ftranslate_region_internal, Fformat):
9540 Rename or remove local vars to avoid shadowing.
9541 (Ftranslate_region_internal): Mark var as initialized.
9542
9543 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9544 avoid shadowing.
9545
9546 * lisp.h (eassert): Check that the argument compiles, even if
9547 ENABLE_CHECKING is not defined.
9548
9549 * data.c (Findirect_variable): Name an expression, to avoid
9550 gcc -Wbad-function-cast warning.
9551 (default_value, arithcompare, arith_driver, arith_error): Now static.
9552 (store_symval_forwarding): Rename local to avoid shadowing.
9553 (Fmake_variable_buffer_local, Fmake_local_variable):
9554 Mark variables as initialized.
9555 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9556
9557 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9558 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9559 Rename locals to avoid shadowing.
9560 (mark_stack): Move local variables into the #ifdef region where
9561 they're used.
9562 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9563 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9564 needed otherwise.
9565 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9566 (GC_STRING_CHARS): Remove; not used.
9567 (Fmemory_limit): Cast sbrk's returned value to char *.
9568
9569 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9570 avoids undefined behavior in theory.
9571
9572 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9573
9574 Use functions, not macros, for up- and down-casing (Bug#8254).
9575 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9576 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9577 to use the following functions instead of these macros.
9578 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9579 EMACS_INT, since callers assume the returned value fits in int.
9580 (upcase1): Likewise, for UPCASE_TABLE.
9581 (uppercasep, lowercasep, upcase): New static inline functions.
9582 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9583 the race-condition problem in the old DOWNCASE.
9584
9585 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9586 Rename locals to avoid shadowing.
9587 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9588 (regex_compile, re_search_2, re_match_2_internal):
9589 Remove unused local vars.
9590 (FREE_VAR): Rewrite so as not to use empty "else",
9591 which gcc can warn about.
9592 (regex_compile, re_match_2_internal): Mark locals as initialized.
9593 (RETALLOC_IF): Define only if needed.
9594 (WORDCHAR_P): Likewise. This one is never needed, but is used
9595 only in a comment talking about a compiler bug, so put inside
9596 the #if 0 of that comment.
9597 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9598 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9599 Remove; unused.
9600
9601 * search.c (boyer_moore): Rename locals to avoid shadowing.
9602 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9603 (PREV_CHAR_BOUNDARY): Likewise.
9604
9605 * search.c (simple_search): Remove unused var.
9606
9607 * dired.c (compile_pattern): Move decl from here ...
9608 * lisp.h: ... to here, so that it can be checked.
9609 (struct re_registers): New forward decl.
9610
9611 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9612
9613 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9614 All uses changed.
9615 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9616 Rename locals to avoid shadowing.
9617 (Fvertical_motion): Mark locals as initialized.
9618
9619 * casefiddle.c (casify_object, casify_region): Now static.
9620 (casify_region): Mark local as initialized.
9621
9622 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9623
9624 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9625 New macros, so that the caller can use some names other than
9626 gcpro1, gcpro2, etc.
9627 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9628 of the new macros.
9629 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9630 argument, for consistency with GCPRO2_VAR, etc: it is now the
9631 prefix of the variable, not the variable itself. All uses
9632 changed.
9633 * dired.c (directory_files_internal, file_name_completion):
9634 Rename locals to avoid shadowing.
9635
9636 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9637 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9638 dired.c's scmp function, had undefined behavior.
9639 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9640 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9641 * buffer.h: ... to here, because these macros use current_buffer,
9642 and the new implementation with inline functions needs to have
9643 current_buffer in scope now, rather than later when the macros
9644 are used.
9645 (downcase, upcase1): New static inline functions.
9646 (DOWNCASE, UPCASE1): Reimplement using these functions.
9647 This avoids undefined behavior in expressions like
9648 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9649 from race conditions in accessing the global variables
9650 case_temp1 and case_temp2.
9651 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9652 * lisp.h (case_temp1, case_temp2): Remove their decls.
9653 * character.h (ASCII_CHAR_P): Move from here ...
9654 * lisp.h: ... to here, so that the inline functions mentioned
9655 above can use them.
9656
9657 * dired.c (directory_files_internal_unwind): Now static.
9658
9659 * fileio.c (file_name_as_directory, directory_file_name):
9660 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9661 Now static.
9662 (file_name_as_directory): Use const pointers when appropriate.
9663 (Fexpand_file_name): Likewise. In particular, newdir might
9664 point at constant storage, so make it a const pointer.
9665 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9666 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9667 signedness issues.
9668 (Fset_file_times, Finsert_file_contents, auto_save_error):
9669 Rename locals to avoid shadowing.
9670
9671 * minibuf.c (choose_minibuf_frame_1): Now static.
9672 (Ftry_completion, Fall_completions): Rename or remove locals
9673 to avoid shadowing.
9674
9675 * marker.c (bytepos_to_charpos): Remove; unused.
9676
9677 * lisp.h (verify_bytepos, count_markers): New decls,
9678 so that gcc does not warn that these functions aren't declared.
9679
9680 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9681 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9682 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9683 (copy_text): Remove unused local var.
9684
9685 * filelock.c (within_one_second): Now static.
9686 (lock_file_1): Rename local to avoid shadowing.
9687
9688 * buffer.c (fix_overlays_before): Mark locals as initialized.
9689 (fix_start_end_in_overlays): Likewise. This function should be
9690 simplified by using pointers-to-pointers, but that's a different
9691 matter.
9692 (switch_to_buffer_1): Now static.
9693 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9694 (report_overlay_modification): Rename locals to avoid shadowing.
9695
9696 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9697 Fix pointer signedness issue.
9698 (sys_subshell): Mark local as volatile if checking for lint,
9699 to suppress a gcc -Wclobbered warning that does not seem to be right.
9700 (MAXPATHLEN): Define only if needed.
9701
9702 * process.c (serial_open, serial_configure): Move decls from here ...
9703 * systty.h: ... to here, so that they can be checked.
9704
9705 * fns.c (get_random, seed_random): Move extern decls from here ...
9706 * lisp.h: ... to here, so that they can be checked.
9707
9708 * sysdep.c (reset_io): Now static.
9709 (wait_for_termination_signal): Remove; unused.
9710
9711 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9712 (copy_keymap_item, append_key, push_text_char_description):
9713 Now static.
9714 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9715 (DENSE_TABLE_SIZE): Remove; unused.
9716 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9717 (describe_map_tree):
9718 Rename locals to avoid shadowing.
9719
9720 * keyboard.c: Declare functions static if they are not used elsewhere.
9721 (echo_char, echo_dash, cmd_error, top_level_2):
9722 (poll_for_input, handle_async_input): Now static.
9723 (read_char, kbd_buffer_get_event, make_lispy_position):
9724 (make_lispy_event, make_lispy_movement, apply_modifiers):
9725 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9726 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9727 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9728 (read_key_sequence, read_char): Mark locals as initialized.
9729 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9730
9731 * keyboard.h (make_ctrl_char): New decl.
9732 (mark_kboards): Move decl here ...
9733 * alloc.c (mark_kboards): ... from here.
9734
9735 * lisp.h (force_auto_save_soon): New decl.
9736
9737 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9738 (DEFINE_DUMMY_FUNCTION): New macro.
9739 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9740 Use it.
9741 (main): Add casts to avoid warnings
9742 if GCC considers string literals to be constants.
9743
9744 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9745
9746 * dbusbind.c: Pointer signedness fixes.
9747 (xd_signature, xd_append_arg, xd_initialize):
9748 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9749 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9750 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9751 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9752
9753 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9754 if GCC considers string literals to be constants.
9755 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9756
9757 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9758
9759 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9760 (print_preprocess, print_object): New macro to fix last change.
9761
9762 * print.c (print_preprocess): Don't forget font objects.
9763
9764 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9765
9766 * emacs.c (USAGE3): Doc fixes.
9767
9768 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9769
9770 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9771 structure.
9772
9773 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9774
9775 * lisp.h (VWindow_system, Qfile_name_history):
9776 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9777 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9778 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9779
9780 * w32select.c: Don't #include "keyboard.h".
9781 (run_protected): Add extern declaration for waiting_for_input.
9782
9783 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9784 * w32console.c (detect_input_pending, read_input_pending)
9785 (encode_terminal_code):
9786 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9787 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9788 (w32_system_caret_y, Qfile_name_history):
9789 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9790 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9791 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9792 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9793 * w32proc.c (Qlocal, report_file_error):
9794 * w32term.c (Vwindow_system, updating_frame):
9795 * w32uniscribe.c (initialized, uniscribe_font_driver):
9796 Remove unneeded extern declarations.
9797
9798 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9799
9800 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9801
9802 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9803
9804 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9805 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9806 These macros can no longer be used for assignment.
9807
9808 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9809 Assign struct members directly, instead of using BUF_BEGV etc.
9810 (record_buffer_markers, fetch_buffer_markers): New functions for
9811 recording and fetching special buffer markers.
9812 (set_buffer_internal_1, set_buffer_temp): Use them.
9813
9814 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9815
9816 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9817
9818 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9819 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9820
9821 * xdisp.c (hscroll_window_tree):
9822 (reconsider_clip_changes): Use PT instead of BUF_PT.
9823
9824 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9825
9826 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9827 $(EMACS_ROOT)/lib/intprops.h.
9828
9829 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9830
9831 Fix more problems found by GCC 4.5.2's static checks.
9832
9833 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9834 to unsigned char * to avoid compiler diagnostic.
9835 (xg_free_frame_widgets): Make it clear that a local variable is
9836 needed only if USE_GTK_TOOLTIP.
9837 (gdk_window_get_screen): Make it clear that this macro is needed
9838 only if USE_GTK_TOOLTIP.
9839 (int_gtk_range_get_value): New function, which avoids a diagnostic
9840 from gcc -Wbad-function-cast.
9841 (xg_set_toolkit_scroll_bar_thumb): Use it.
9842 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9843 diagnostic from gcc -Wbad-function-cast.
9844 (get_utf8_string, xg_get_file_with_chooser):
9845 Rename locals to avoid shadowing.
9846 (create_dialog): Move locals to avoid shadowing.
9847
9848 * xgselect.c (xg_select): Remove unused var.
9849
9850 * image.c (four_corners_best): Mark locals as initialized.
9851 (gif_load): Initialize transparent_p to zero (Bug#8238).
9852 Mark another local as initialized.
9853 (my_png_error, my_error_exit): Mark with NO_RETURN.
9854
9855 * image.c (clear_image_cache): Now static.
9856 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9857 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9858 (x_edge_detection): Remove unnecessary cast that
9859 gcc -Wbad-function-cast diagnoses.
9860 (gif_load): Fix pointer signedness.
9861 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9862 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9863
9864 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9865
9866 Improve quality of tests for time stamp overflow.
9867 For example, without this patch (encode-time 0 0 0 1 1
9868 1152921504606846976) returns the obviously-bogus value (-948597
9869 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9870 reports time overflow. See
9871 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9872 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9873 * editfns.c: Include limits.h and intprops.h.
9874 (TIME_T_MIN, TIME_T_MAX): New macros.
9875 (time_overflow): Move earlier, to before first use.
9876 (hi_time, lo_time): New functions, for an accurate test for
9877 out-of-range times.
9878 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9879 (Fget_internal_run_time): Don't assume time_t fits in int.
9880 (make_time): Use list2 instead of Fcons twice.
9881 (Fdecode_time): More accurate test for out-of-range times.
9882 (check_tm_member): New function.
9883 (Fencode_time): Use it, to test for out-of-range times.
9884 (lisp_time_argument): Don't rely on undefined left-shift and
9885 right-shift behavior when checking for time stamp overflow.
9886
9887 * editfns.c (time_overflow): New function, refactoring common code.
9888 (Fformat_time_string, Fdecode_time, Fencode_time):
9889 (Fcurrent_time_string): Use it.
9890
9891 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9892 * dired.c (make_time): Move to ...
9893 * editfns.c (make_time): ... here.
9894 * systime.h: Note the move.
9895
9896 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9897
9898 * fringe.c (update_window_fringes): Remove unused variables.
9899
9900 * unexmacosx.c (copy_data_segment): Also copy __got section.
9901 (Bug#8223)
9902
9903 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9904
9905 * termcap.c [MSDOS]: Include "msdos.h".
9906 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9907 Constify `char *' arguments and their references according to
9908 prototypes in tparam.h.
9909
9910 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9911
9912 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9913 Adapt all references accordingly.
9914
9915 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9916
9917 2011-03-11 Tom Tromey <tromey@redhat.com>
9918
9919 * buffer.c (syms_of_buffer): Remove obsolete comment.
9920
9921 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9922
9923 * termhooks.h (encode_terminal_code): Declare prototype.
9924
9925 * msdos.c (encode_terminal_code): Don't declare prototype.
9926
9927 * term.c (encode_terminal_code): Now external again, used by
9928 w32console.c and msdos.c.
9929
9930 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9931 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9932
9933 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9934
9935 Fix some minor problems found by GCC 4.5.2's static checks.
9936
9937 * fringe.c (update_window_fringes): Mark locals as initialized
9938 (Bug#8227).
9939 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9940
9941 * alloc.c (mark_fringe_data): Move decl from here ...
9942 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9943 to check its interface.
9944 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9945
9946 * fontset.c (free_realized_fontset): Now static.
9947 (Fset_fontset_font): Rename local to avoid shadowing.
9948 (fontset_font): Mark local as initialized.
9949 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9950
9951 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9952
9953 * xselect.c (x_disown_buffer_selections): Remove; not used.
9954 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9955 (x_own_selection, Fx_disown_selection_internal): Rename locals
9956 to avoid shadowing.
9957 (x_handle_dnd_message): Remove local to avoid shadowing.
9958
9959 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9960 so that the caller can use some name other than gcpro1.
9961 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9962 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9963 (Fx_backspace_delete_keys_p):
9964 Use them to avoid shadowing, and rename vars to avoid shadowing.
9965 (x_decode_color, x_set_name, x_window): Now static.
9966 (Fx_create_frame): Add braces to silence GCC warning.
9967 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9968 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9969 Remove unused locals.
9970 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9971 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9972 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9973 macros.
9974
9975 * xterm.h (x_mouse_leave): New decl.
9976
9977 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9978 Remove unused functions.
9979 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9980 (x_calc_absolute_position): Now static.
9981 (XTread_socket): Don't define label "out" unless it's used.
9982 Don't declare local "event" unless it's used.
9983 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9984 unless they are used.
9985 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9986 (x_fatal_error_signal): Remove; not used.
9987 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9988 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9989 (x_error_catcher, x_connection_closed, x_error_handler):
9990 (x_error_quitter, xembed_send_message, x_iconify_frame):
9991 (my_log_handler): Rename locals to avoid shadowing.
9992 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9993 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9994
9995 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9996 Rename or move locals to avoid shadowing.
9997 (tty_defined_color, merge_face_heights): Now static.
9998 (free_realized_faces_for_fontset): Remove; not used.
9999 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
10000 does not deduce is never used uninitialized.
10001 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
10002 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
10003
10004 * terminal.c (store_terminal_param): Now static.
10005
10006 * xmenu.c (menu_highlight_callback): Now static.
10007 (set_frame_menubar): Remove unused local.
10008 (xmenu_show): Rename parameter to avoid shadowing.
10009 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
10010 since they might point to immutable storage.
10011 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
10012 since it's unused otherwise.
10013
10014 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
10015 Add a FIXME, since the code still doesn't look right. (Bug#8215)
10016 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10017 avoids a gcc -Wuninitialized diagnostic.
10018 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
10019 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10020 does not deduce are never used uninitialized.
10021
10022 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10023
10024 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
10025 * window.c (window_loop, size_window):
10026 (run_window_configuration_change_hook, enlarge_window): Likewise.
10027
10028 * window.c (display_buffer): Now static.
10029 (size_window): Mark variables that gcc -Wuninitialized
10030 does not deduce are never used uninitialized.
10031 * window.h (check_all_windows): New decl, to forestall
10032 gcc -Wmissing-prototypes diagnostic.
10033 * dispextern.h (bidi_dump_cached_states): Likewise.
10034
10035 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10036 shadowing.
10037 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
10038 Include <limits.h>.
10039 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10040 and to avoid gcc -Wuninitialized warning.
10041 (load_charset_map): Mark variables that gcc -Wuninitialized
10042 does not deduce are never used uninitialized.
10043 (load_charset): Abort instead of using uninitialized var (Bug#8229).
10044
10045 * coding.c (coding_set_source, coding_set_destination):
10046 Use "else { /* comment */ }" rather than "else /* comment */;"
10047 for clarity, and to avoid gcc -Wempty-body warning.
10048 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10049 a block, when the outer 'i' will do.
10050 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10051 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10052 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10053 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10054 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10055 Rename locals to avoid shadowing.
10056 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
10057 * coding.c (emacs_mule_char, encode_invocation_designation):
10058 Now static, since they're not used elsewhere.
10059 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
10060 (decode_coding_object, encode_coding_object, detect_coding_system):
10061 (decode_coding_emacs_mule): Mark variables that gcc
10062 -Wuninitialized does not deduce are never used uninitialized.
10063 (detect_coding_iso_2022): Initialize a local variable that might
10064 be used uninitialized. Leave a FIXME because it's not clear that
10065 this initialization is needed. (Bug#8211)
10066 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10067 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10068 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10069 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10070 Remove unused macros.
10071
10072 * category.c (hash_get_category_set): Remove unused local var.
10073 (copy_category_table): Now static, since it's not used elsewhere.
10074 * character.c (string_count_byte8): Likewise.
10075
10076 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10077 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10078
10079 * chartab.c (copy_sub_char_table): Now static, since it's not used
10080 elsewhere.
10081 (sub_char_table_ref_and_range, char_table_ref_and_range):
10082 Rename locals to avoid shadowing.
10083 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
10084
10085 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
10086 (BIDI_BOB): Remove unused macro.
10087
10088 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10089 deduce are never used uninitialized.
10090 * term.c (encode_terminal_code): Likewise.
10091
10092 * term.c (encode_terminal_code): Now static. Remove unused local.
10093
10094 * tparam.h: New file.
10095 * term.c, tparam.h: Include it.
10096 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10097 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10098 Move these decls to tparam.h, and make them agree with what
10099 is actually in tparam.c. The previous trick of using incompatible
10100 decls in different modules does not conform to the C standard.
10101 All callers of tparam changed to use tparam's actual API.
10102 * tparam.c (tparam1, tparam, tgoto):
10103 Use const pointers where appropriate.
10104
10105 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10106 * cm.h (struct cm): Likewise.
10107 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10108 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10109 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10110 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10111 (turn_on_face, init_tty): Likewise.
10112 * termchar.h (struct tty_display_info): Likewise.
10113
10114 * term.c (term_mouse_position): Rename local to avoid shadowing.
10115
10116 * alloc.c (mark_ttys): Move decl from here ...
10117 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10118
10119 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10120
10121 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10122
10123 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
10124
10125 * search.c (compile_pattern_1): Remove argument regp, unused since
10126 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10127 (compile_pattern): Don't pass it.
10128
10129 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10130
10131 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10132 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10133 for ! HAVE_GTK3.
10134 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10135
10136 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10137
10138 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10139 gdk_window_get_screen, gdk_window_get_geometry,
10140 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10141 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10142 (xg_get_pixbuf_from_pixmap): New function.
10143 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10144 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10145 Call xg_get_pixbuf_from_pixmap instead of
10146 gdk_pixbuf_get_from_drawable.
10147 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10148 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10149 (xg_check_special_colors): Use GtkStyleContext and its functions
10150 for HAVE_GTK3.
10151 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10152 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10153 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
10154 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10155 Call gtk_widget_get_preferred_size.
10156 (xg_frame_resized): gdk_window_get_geometry only takes 5
10157 parameters.
10158 (xg_win_to_widget, xg_event_is_for_menubar):
10159 Call gdk_x11_window_lookup_for_display.
10160 (xg_set_widget_bg): New function.
10161 (delete_cb): New function.
10162 (xg_create_frame_widgets): Connect delete-event to delete_cb.
10163 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
10164 (xg_set_background_color): Call xg_set_widget_bg.
10165 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10166 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10167 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10168 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10169 if ! HAVE_GTK3.
10170 (update_frame_tool_bar): Call gtk_widget_hide.
10171 (xg_initialize): Use GDK_KEY_g.
10172
10173 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10174 if ! HAVE_GTK3
10175 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10176
10177 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10178 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10179 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10180
10181 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
10182
10183 * w32xfns.c (select_palette): Check success of RealizePalette against
10184 GDI_ERROR, not zero.
10185
10186 See ChangeLog.11 for earlier changes.
10187
10188 ;; Local Variables:
10189 ;; coding: utf-8
10190 ;; End:
10191
10192 Copyright (C) 2011-2012 Free Software Foundation, Inc.
10193
10194 This file is part of GNU Emacs.
10195
10196 GNU Emacs is free software: you can redistribute it and/or modify
10197 it under the terms of the GNU General Public License as published by
10198 the Free Software Foundation, either version 3 of the License, or
10199 (at your option) any later version.
10200
10201 GNU Emacs is distributed in the hope that it will be useful,
10202 but WITHOUT ANY WARRANTY; without even the implied warranty of
10203 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10204 GNU General Public License for more details.
10205
10206 You should have received a copy of the GNU General Public License
10207 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.