1 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
4 * lisp.h (WAIT_READING_MAX): New macro.
5 * dispnew.c (Fsleep_for, sit_for):
6 * keyboard.c (kbd_buffer_get_event):
7 * process.c (Faccept_process_output):
8 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
9 This improves on the previous patch, which introduced a bug
10 when time_t is unsigned and as wide as intmax_t.
11 See <http://bugs.gnu.org/9000#51>.
13 2012-06-23 Eli Zaretskii <eliz@gnu.org>
15 * dispnew.c (sit_for, Fsleep_for):
16 * keyboard.c (kbd_buffer_get_event):
17 * process.c (Faccept_process_output): Avoid compiler warnings when
18 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
20 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
22 * makefile.w32-in: Update dependencies.
24 * w32.c (ltime): Add return type and declare static.
25 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
27 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
29 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
30 Privately reported by Herbert J. Skuhra.
31 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
33 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
34 not make_lisp_timeval, when the argument is of type EMACS_TIME.
36 2012-06-23 Eli Zaretskii <eliz@gnu.org>
38 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
39 last argument of make_unibyte_string.
41 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
42 language ID in the event parameters.
44 * w32term.c (w32_read_socket): Put the new keyboard codepage into
45 event.code, not the obscure "character set ID".
47 2012-06-23 Chong Yidong <cyd@gnu.org>
49 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
51 2012-06-23 Eli Zaretskii <eliz@gnu.org>
53 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
54 * w32.c (fdutimens): New function.
56 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
58 * s/ms-w32.h (pselect): Redirect to sys_select.
60 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
62 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
63 in the logic of incrementing and decrementing the value of
64 use_relocatable_buffers.
66 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
68 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
69 Privately reported by Herbert J. Skuhra.
70 [__FreeBSD__]: Remove "*/" typo after "#include".
71 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
72 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
73 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
74 Don't assume EMACS_TIME and struct timeval are the same type.
76 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
78 Support higher-resolution time stamps (Bug#9000).
79 The time stamps are only nanosecond-resolution at the C level,
80 since that's the best that any real-world system supports now.
81 But they are picosecond-resolution at the Lisp level, as that's
82 easy, and leaves room for future OS improvements.
84 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
87 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
88 Don't get current time unless it's needed.
90 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
91 now provides it if it's absent.
92 (start_atimer): Port to higher-res time stamps.
93 Check for time stamp overflow. Don't get current time more
96 * buffer.h (struct buffer): Buffer modtime now has high resolution.
97 Include systime.h, not time.h.
98 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
100 * dired.c: Include stat-time.h.
101 (Ffile-attributes): File times now have higher resolution.
103 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
104 (struct image): Timestamp now has higher resolution.
106 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
107 has at least microseconds now. All uses removed.
108 (update_frame, update_single_window, update_window, update_frame_1)
109 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
111 * editfns.c (time_overflow): Now extern.
112 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
113 (float-time, Fformat_time_string, Fcurrent_time_string)
114 (Fcurrent_time_zone): Accept and generate higher-resolution
116 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
117 (decode_time_components, lisp_seconds_argument): New functions.
118 (make_time): Now static.
119 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
120 Report an error if the time is invalid, rather than having the caller
123 * fileio.c: Include <stat-time.h>
124 (Fcopy_file): Copy higher-resolution time stamps.
125 Prefer to set the time stamp via a file descriptor if that works.
126 (Fset_file_times, Finsert_file_contents, Fwrite_region)
127 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
128 (Fvisited_file_modtime, Fset_visited_file_modtime):
129 Support higher-resolution time stamps.
131 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
133 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
135 * image.c (prepare_image_for_display, clear_image_cache)
136 (lookup_image): Port to higer-resolution time stamps.
138 * keyboard.c (start_polling, bind_polling_period):
139 Check for time stamp overflow.
140 (read_char, kbd_buffer_get_event, timer_start_idle)
141 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
142 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
143 Port to higher-resolution time stamps. Do not assume time_t is signed.
144 (decode_timer): New function. Timers are now vectors of length 9,
145 not 8, to accommodate the picosecond component.
146 (timer_check_2): Use it.
148 * nsterm.m (select_timeout, timeval_subtract): Remove.
149 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
150 as they're a bit more accurate and handle overflow better.
151 (ns_select): Change prototype to be compatible with pselect.
152 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
153 * nsterm.h (ns_select): Adjust prototype.
155 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
156 us-resolution time stamps.
157 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
159 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
161 * lisp.h (time_overflow): New decl.
162 (wait_reading_process_output): First arg is now intmax_t, not int,
163 to accommodate larger waits.
165 * process.h (struct Lisp_Process.read_output_delay):
166 Now counts nanoseconds, not microseconds.
167 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
169 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
170 (wait_reading_process_output):
171 Port to ns-resolution time stamps.
172 (Faccept_process_output, wait_reading_process_output):
173 Check for time stamp overflow. Do not assume time_t is signed.
174 (select_wrapper): Remove; we now use pselect.
175 (Fprocess_attributes): Now generates ns-resolution time stamps.
177 * sysdep.c: Include utimens.h. Don't include utime.h
178 or worry about struct utimbuf; gnulib does that for us now.
179 (gettimeofday): Remove; gnulib provides a substitute.
180 (make_timeval): New function.
181 (set_file_times): Now sets ns-resolution time stamps.
182 New arg FD; all uses changed.
183 (time_from_jiffies, ltime_from_jiffies, get_up_time)
184 (system_process_attributes):
185 Now returns ns-resolution time stamp. All uses changed.
186 Check for time stamp overflow.
188 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
189 provides a substitute now.
191 * systime.h: Include timespec.h rather than sys/time.h and time.h,
192 since it guarantees struct timespec.
193 (EMACS_TIME): Now struct timespec, so that we can support
194 ns-resolution time stamps.
195 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
196 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
197 (EMACS_USECS): Remove.
198 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
199 so multiply the arg by 1000 before storing it.
200 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
202 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
203 Port to ns-resolution time stamps.
204 (EMACS_TIME_NEG_P): Remove; replaced by....
205 (EMACS_TIME_SIGN): New macro.
206 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
207 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
208 (set_file_times, make_time, lisp_time_argument): Adjust signature.
209 (make_timeval, make_lisp_time, decode_time_components): New decls.
210 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
211 that it mishandled time_t overflow. You can't compare by subtracting!
212 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
213 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
215 * term.c: Include <sys/time.h>.
216 (timeval_to_Time): New function, for proper overflow wraparound.
217 (term_mouse_position, term_mouse_click): Use it.
219 * undo.c (record_first_change): Support higher-resolution time stamps
221 (Fprimitive_undo): Use them when restoring time stamps.
223 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
224 (w32_get_internal_run_time):
225 Port to higher-resolution Emacs time stamps.
226 (ltime): Now accepts single 64-bit integer, as that's more convenient
229 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
231 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
232 for compatibility with pselect. Support ns-resolution time stamps.
234 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
236 * xselect.c (wait_for_property_change, x_get_foreign_selection):
237 Check for time stamp overflow, and support ns-resolution time stamps.
239 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
240 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
241 (timeval_subtract): Remove; no longer needed.
242 (XTflash, XTring_bell, x_wait_for_event):
243 Port to ns-resolution time stamps. Don't assume time_t is signed.
245 2012-06-22 Chong Yidong <cyd@gnu.org>
247 * xdisp.c (x_consider_frame_title): Revert last change.
249 2012-06-22 Eli Zaretskii <eliz@gnu.org>
251 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
252 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
253 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
254 staticidx goes up to 1597 out of 1600 = 0x640.)
256 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
258 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
259 Otherwise, the umask might be mistakenly 0 while handling input signals.
261 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
263 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
265 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
267 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
268 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
269 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
270 access to `contents' member of Lisp_Vector objects with AREF and ASET
273 2012-06-19 Chong Yidong <cyd@gnu.org>
275 * frame.c (delete_frame): When selecting a frame on a different
276 text terminal, do not alter the terminal's top-frame.
278 * xdisp.c (format_mode_line_unwind_data): Record the target
279 frame's selected window and its terminal's top-frame.
280 (unwind_format_mode_line): Restore them.
281 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
283 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
284 since tty frames can be explicitly named.
285 (prepare_menu_bars): Likewise.
287 * term.c (Ftty_top_frame): New function.
289 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
291 Port byte-code-meter to modern targets.
292 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
293 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
294 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
295 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
296 (METER_1, METER_2): Simplify.
298 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
300 * data.c (Fdefalias): Return `symbol' (bug#11686).
302 2012-06-18 Martin Rudalics <rudalics@gmx.at>
304 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
305 gets killed during executing of this function (Bug#11665).
306 Try to always return Qt when the buffer has been actually killed.
307 (Vkill_buffer_query_functions): In doc-string say that functions
308 run by this hook should not change the current buffer.
310 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
312 Fix recently-introduced process.c problems found by static checking.
313 * process.c (write_queue_push, write_queue_pop, send_process):
314 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
315 (write_queue_pop): Fix pointer signedness problem.
316 (send_process): Remove unused local.
318 2012-06-17 Chong Yidong <cyd@gnu.org>
320 * xdisp.c (redisplay_internal): No need to redisplay terminal
321 frames that are not on top.
323 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
325 * process.c (make_process): Initialize write_queue.
326 (write_queue_push, write_queue_pop): New functions.
327 (send_process): Use them to maintain correct ordering of process
330 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
332 * lisp.h (eassert): Assume C89 or later.
333 This removes the need for CHECK.
334 (CHECK): Remove. Its comments about always evaluating its
335 argument were confusing, as 'eassert' typically does not evaluate
338 * coding.c (produce_chars): Use ptrdiff_t, not int.
340 * xterm.c (x_draw_underwave): Check for integer overflow.
341 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
343 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
345 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
346 referenced (Bug#11583).
348 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
350 Implement wave-style variant of underlining.
351 * dispextern.h (face_underline_type): New enum.
352 (face): Add field for underline type.
353 * nsterm.m (ns_draw_underwave): New function.
354 (ns_draw_text_decoration): Use it.
355 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
357 (x_draw_glyph_string): Use them.
358 * xfaces.c (Qline, Qwave): New Lisp objects.
359 (check_lface_attrs, merge_face_ref)
360 (Finternal_set_lisp_face_attribute, realize_x_face):
361 Handle wave-style underline face attributes.
362 * xterm.c (x_draw_underwave): New function.
363 (x_draw_glyph_string): Use it.
365 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
367 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
368 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
369 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
370 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
371 ($(BLD)/w32select.$(O)): Update dependencies.
373 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
375 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
376 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
377 * character.c (_fetch_multibyte_char_p): Remove.
378 * alloc.c: Include "character.h" before "buffer.h".
380 * buffer.c: Likewise.
381 * bytecode.c: Likewise.
382 * callint.c: Likewise.
383 * callproc.c: Likewise.
384 * casefiddle.c: Likewise.
385 * casetab.c: Likewise.
386 * category.c: Likewise.
388 * coding.c: Likewise.
389 * composite.c: Likewise.
391 * dispnew.c: Likewise.
393 * dosfns.c: Likewise.
394 * editfns.c: Likewise.
396 * fileio.c: Likewise.
397 * filelock.c: Likewise.
399 * fontset.c: Likewise.
400 * fringe.c: Likewise.
401 * indent.c: Likewise.
402 * insdel.c: Likewise.
403 * intervals.c: Likewise.
404 * keyboard.c: Likewise.
405 * keymap.c: Likewise.
407 * macros.c: Likewise.
408 * marker.c: Likewise.
409 * minibuf.c: Likewise.
411 * nsmenu.m: Likewise.
413 * process.c: Likewise.
415 * region-cache.c: Likewise.
416 * search.c: Likewise.
417 * syntax.c: Likewise.
419 * textprop.c: Likewise.
421 * unexsol.c: Likewise.
422 * w16select.c: Likewise.
423 * w32fns.c: Likewise.
424 * w32menu.c: Likewise.
425 * window.c: Likewise.
430 * xselect.c: Likewise.
432 2012-06-16 Eli Zaretskii <eliz@gnu.org>
434 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
435 If all the glyphs of the glyph row came from strings, and we have no
436 cursor positioning clues, put the cursor on the first glyph of the
438 (handle_face_prop): Use chunk-relative overlay string index when
439 indexing into it->string_overlays array. (Bug#11653)
440 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
441 the rightmost. (Bug#11720)
443 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
445 * category.h (CHAR_HAS_CATEGORY): Define as inline.
446 (CATEGORY_MEMBER): Enforce 1/0 value.
447 * category.c (_temp_category_set): Remove.
449 2012-06-16 Eli Zaretskii <eliz@gnu.org>
451 * window.c (Fdelete_other_windows_internal)
452 (Fdelete_window_internal): Don't access frame's mouse highlight
453 info of the initial frame. (Bug#11677)
455 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
457 * .gdbinit (xgetint): Fix recently-introduced paren typo.
458 Assume USE_2_TAGS_FOR_INTS.
459 (xreload): Adjust $tagmask width to match recent lisp.h change.
461 Simplify lisp.h in minor ways that should not affect code.
462 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
463 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
464 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
465 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
466 (INTTYPEBITS): New macro, for clarity.
467 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
468 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
469 Simplify now that USE_LSB_TAG is always defined.
470 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
471 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
473 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
475 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
477 2012-06-13 Glenn Morris <rgm@gnu.org>
479 * s/bsd-common.h (BSD4_3):
480 * s/usg5-4-common.h (USG5_4): No longer define; unused.
482 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
484 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
487 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
489 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
490 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
491 * alloc.c (widen_to_Lisp_Object): Remove.
492 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
493 * frame.c (delete_frame): Remove outdated comment.
494 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
496 (Fw32_unregister_hot_key): Likewise.
497 (Fw32_toggle_lock_key): Likewise.
498 * w32menu.c (add_menu_item): Likewise.
499 (w32_menu_display_help): Use XIL instead of checking
501 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
502 (init_heap): Likewise.
503 * w32term.c (w32_read_socket): Update comment.
505 2012-06-13 Glenn Morris <rgm@gnu.org>
507 * s/usg5-4-common.h, src/s/unixware.h:
508 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
510 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
512 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
514 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
515 * alloc.c (make_number) [!defined make_number]:
516 Remove, as lisp.h always defines this now.
517 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
518 (roundup_size): Verify that it is a power of 2.
519 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
520 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
521 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
522 -DUSE_LSB_TAG=0, to override the automatically-selected default.
523 USE_LSB_TAG now is always defined to be either 0 or 1.
525 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
526 code works fine either way, and efficiency is not a concern here,
527 as the union type is for debugging, not for production.
528 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
529 Use an inline function on all platforms when using the union type,
530 since this is simpler and 'static inline' can be used portably
532 (LISP_INITIALLY_ZERO): New macro.
533 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
534 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
536 2012-06-12 Glenn Morris <rgm@gnu.org>
538 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
540 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
542 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
543 Move BROKEN_SIGIO to configure.
545 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
546 Move NO_TERMIO to configure.
548 2012-06-12 Chong Yidong <cyd@gnu.org>
550 * image.c (imagemagick_load_image): Use MagickFlattenImage if
551 MagickMergeImageLayers is undefined. Use pixel pusher loop if
552 MagickExportImagePixels is undefined.
554 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
556 * image.c (imagemagick_load_image): Remove unused label.
558 2012-06-11 Glenn Morris <rgm@gnu.org>
560 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
561 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
562 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
563 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
565 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
567 * alloc.c (make_byte_code): New function.
568 (Fmake_byte_code): Use it. Don't purify here.
569 * lread.c (read1): Use it as well to avoid extra allocation.
571 2012-06-11 Chong Yidong <cyd@gnu.org>
573 * image.c (imagemagick_load_image): Implement transparency.
575 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
577 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
578 account for preceding backslashes. (Bug#11663)
580 2012-06-09 Chong Yidong <cyd@gnu.org>
582 * term.c: Support italics in capable terminals (Bug#9652).
583 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
584 (turn_on_face): Output using TS_enter_italic_mode if available.
585 Don't handle unused blinking and alt-charset cases.
586 (turn_off_face): Handle italic case; discard unused tty_blinking_p
587 and tty_alt_charset_p cases.
588 (tty_capable_p, init_tty): Support italics.
590 * termchar.h (struct tty_display_info): Add field for italics.
591 Remove unused blink field.
593 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
596 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
597 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
598 tty_alt_charset_p. Add tty_italic_p.
600 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
602 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
603 dbus_type_is_basic if available.
604 (xd_extract_signed, xd_extract_unsigned): Rename from
605 extract_signed and extract_unsigned, respectively. Adapt callers.
607 2012-06-09 Chong Yidong <cyd@gnu.org>
609 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
611 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
614 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
616 * xdisp.c (vmessage): Treat frame message as multibyte.
617 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
618 would generate the diagnostic "Making \302\247 buffer-local while
621 2012-06-08 Eli Zaretskii <eliz@gnu.org>
623 * dispnew.c (showing_window_margins_p): Undo last change, which
624 was done due to an inadvertent commit.
625 (adjust_frame_glyphs_for_frame_redisplay): Do call
626 showing_window_margins_p.
628 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
630 * eval.c (Fmake_var_non_special): New primitive.
631 (syms_of_eval): Defsubr it.
632 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
634 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
636 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
637 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
639 2012-06-08 Eli Zaretskii <eliz@gnu.org>
641 * alloc.c (allocate_vectorlike): Fix last change.
643 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
645 Block-based vector allocation of small vectors.
646 * lisp.h (struct vectorlike_header): New field `nbytes',
647 adjust comment accordingly.
648 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
649 to denote vector blocks. Adjust users (live_vector_p,
650 mark_maybe_pointer, valid_lisp_object_p) accordingly.
651 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
652 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
653 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
654 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
655 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
656 (roundup_size): New constant.
657 (struct vector_block): New data type.
658 (vector_blocks, vector_free_lists, zero_vector): New variables.
659 (all_vectors): Rename to `large_vectors'.
660 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
661 (sweep_vectors): New functions.
662 (allocate_vectorlike): Return `zero_vector' as the only vector of
663 0 items. Allocate new vector from block if vector size is less than
664 or equal to VBLOCK_BYTES_MAX.
665 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
666 (init_alloc_once): Add call to init_vectors.
668 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
670 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
672 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
674 * doprnt.c (doprnt): Truncate multibyte char correctly.
675 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
676 would mishandle a string argument "Xc" if X was a multibyte
677 character of length 2: it would truncate after X's first byte
678 rather than including all of X.
680 2012-06-06 Chong Yidong <cyd@gnu.org>
682 * buffer.c (word_wrap): Doc fix.
684 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
686 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
688 2012-06-03 Glenn Morris <rgm@gnu.org>
690 * xdisp.c (tool-bar-style): Doc fix.
692 2012-06-03 Ulrich Müller <ulm@gentoo.org>
694 * Makefile.in (PAXCTL): Define.
695 (temacs$(EXEEXT)): Disable memory randomization for the temacs
696 binary via PaX flags if the paxctl utility is available.
697 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
698 Restore PaX flags to their default. (Bug#11398)
700 2012-06-03 Chong Yidong <cyd@gnu.org>
702 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
705 2012-06-03 Chong Yidong <cyd@gnu.org>
707 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
708 (note_mode_line_or_margin_highlight): If there is no help echo,
709 use mode-line-default-help-echo. Handle the case where the mouse
710 position is past the end of the mode line string.
712 * buffer.c (buffer_local_value_1): New function, split from
713 Fbuffer_local_value; can return Qunbound.
714 (Fbuffer_local_value): Use it.
715 (Vmode_line_format): Docstring tweaks.
717 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
719 * sysdep.c (system_process_attributes): Improve comment.
721 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
723 * keyboard.c: Export real-this-command to Elisp.
724 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
725 and DEFVAR it. Update all users.
727 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
729 * minibuf.c (Fassoc_string): Remove duplicate declaration.
731 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
732 Convert pctcpu and pctmem to Lisp float properly.
733 Let the compiler fold better, as 100.0/0x8000 is exact.
735 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
737 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
740 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
742 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
744 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
746 For a 'struct window', replace some Lisp_Object fields to
747 bitfields where appropriate, remove unused fields.
748 * window.h (struct window): Remove unused 'last_mark_x' and
749 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
750 change it's type from Lisp_Object to bitfield.
751 Change type of 'force_start', 'optional_new_start',
752 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
753 fields from Lisp_Object to bitfield. Adjust users accordingly.
755 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
757 Pacify gcc -Wdouble-precision when using Xaw.
758 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
759 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
760 Use 'float' consistently, rather than 'float' in most places
761 and 'double' in a couple of places.
763 2012-05-31 Eli Zaretskii <eliz@gnu.org>
765 * xdisp.c (handle_stop): Detect whether we have overlay strings
766 loaded by testing it->current.overlay_string_index to be
767 non-negative, instead of checking whether n_overlay_strings is
768 positive. (Bug#11587)
770 2012-05-31 Chong Yidong <cyd@gnu.org>
772 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
774 * doc.c (Fsubstitute_command_keys): Doc fix.
776 2012-05-31 Eli Zaretskii <eliz@gnu.org>
778 * search.c (search_buffer): Remove calls to
779 r_alloc_inhibit_buffer_relocation, as it is now called by
780 maybe_unify_char, which was the cause of relocation of buffer text
783 2012-05-31 Eli Zaretskii <eliz@gnu.org>
785 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
786 for the duration of call to load_charset, to avoid problems with
787 callers of maybe_unify_char that access buffer text through C
790 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
791 decrement the inhibition flag, instead of just setting or
794 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
796 Remove obsolete '#define static' cruft.
797 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
798 This #undef was "temporary" in 2000; it is no longer needed
799 now that '#define static' has gone away.
800 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
801 (gray_bitmap_bits): Remove; no longer needed.
802 All uses replaced with definiens.
803 * xterm.c: Include "bitmaps/gray.xbm".
805 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
807 Clean up __executable_start, monstartup when --enable-profiling.
808 The following changes affect the code only when profiling.
809 * dispnew.c (__executable_start): Rename from safe_bcopy.
810 Define only on platforms that need it.
811 * emacs.c: Include <sys/gmon.h> when profiling.
812 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
813 (__executable_start): Remove decl, since lisp.h does it now.
814 (safe_bcopy): Remove decl; no longer has that name.
815 (main): Coalesce #if into single bit of code, for simplicity.
816 Cast pointers to uintptr_t, since standard libraries want integers
818 * lisp.h (__executable_start): New decl.
820 2012-05-31 Glenn Morris <rgm@gnu.org>
822 * image.c (Fimagemagick_types): Doc fix.
824 2012-05-30 Jim Meyering <meyering@redhat.com>
826 * callproc.c (Fcall_process_region): Include directory component
827 in mkstemp error message (Bug#11586).
829 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
831 * alloc.c, lisp.h (make_pure_vector): Now static.
833 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
835 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
837 (Fautoload): Do the hash-doc more carefully.
838 * data.c (Fdefalias): Purify definition, except for keymaps.
839 (Qdefun): Move from eval.c.
840 * lisp.h (Qdefun): Remove.
841 * lread.c (read1): Tiny simplification.
843 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
845 Do not create empty overlays with the evaporate property (Bug#9642).
846 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
847 Bug#9642, but explicitly check that the buffer the overlay would
848 be moved to is live and rearrange lines to make sure that errors
849 will not put the overlay in an inconsistent state.
850 (Fdelete_overlay): Cosmetics.
852 2012-05-28 Eli Zaretskii <eliz@gnu.org>
854 * w32term.c (my_bring_window_to_top): New function.
855 (x_raise_frame): Use handle returned by DeferWindowPos, which
856 could be different from the original one.
857 Call my_bring_window_to_top instead of my_set_foreground_window.
860 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
861 by calling BringWindowToTop.
863 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
864 (WM_EMACS_END): Increase by one.
866 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
868 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
869 This avoids undefined behavior that might cause the eassert
870 to not catch an out-of-range value.
872 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
874 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
877 2012-05-27 Eli Zaretskii <eliz@gnu.org>
879 * bidi.c (bidi_mirror_char): Fix last change.
881 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
883 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
884 when referring to sectname field in printf format.
886 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
888 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
889 Only r_alloc_inhibit_buffer_relocation needed to be added;
890 the others were already declared.
892 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
893 before checking whether it's out of range. Put the check inside
895 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
897 2012-05-27 Ken Brown <kbrown@cornell.edu>
899 * callproc.c (Fcall_process): Restore a line that was accidentally
900 commented out in the 2011-02-13 change (bug#11547).
902 2012-05-27 Eli Zaretskii <eliz@gnu.org>
904 * lisp.h [REL_ALLOC]: Add prototypes for external functions
907 * buffer.c [REL_ALLOC]: Remove prototypes of
908 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
909 they are now on lisp.h.
911 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
913 * search.c (search_buffer): Use it to inhibit relocation of buffer
914 text while re_search_2 is doing its job, because re_search_2 is
915 passed C pointers to buffer text. (Bug#11519)
917 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
920 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
921 state after an additional call to move_it_in_display_line_to, keep
922 the values of it->max_ascent and it->max_descent found for the
924 (pos_visible_p): Revert the comparison against bottom_y to what it
925 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
928 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
930 Fix coding-related core dumps with gcc -ftrapv.
931 The code was computing A - B, where A and B are pointers, and B is
932 random garbage. This can lead to core dumps on platforms that
933 have special pointer registers, and it also leads to core dumps on
934 x86-64 when compiled with gcc -ftrapv. The fix is to compute
935 A - B only when B is initialized properly.
936 * coding.c (coding_set_source, coding_set_destination): Return void.
937 (coding_change_source, coding_change_destinations): New functions,
938 with the old behaviors of coding_set_source and coding_set_destination.
939 All callers that need an offset changed to use these new functions.
941 2012-05-26 Glenn Morris <rgm@gnu.org>
943 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
945 2012-05-26 Eli Zaretskii <eliz@gnu.org>
947 Extend mouse support on W32 text-mode console.
948 * xdisp.c (draw_row_with_mouse_face):
949 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
951 * w32console.c: Include window.h.
952 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
954 (initialize_w32_display): Initialize mouse-highlight data.
956 * w32inevt.c: Include termchar.h and window.h.
957 (do_mouse_event): Support mouse-autoselect-window. When the mouse
958 moves, call note_mouse_highlight. If help_echo changed, call
959 gen_help_event to produce help-echo message in the echo area.
960 Call clear_mouse_face if mouse_face_hidden is set in the mouse
963 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
965 * lread.c (read1): Simplify slightly to avoid an overflow warning
966 with GCC 4.7.0 on x86-64.
968 2012-05-26 Eli Zaretskii <eliz@gnu.org>
970 * bidi.c (bidi_mirror_char): Revert last change: an int is
971 definitely wide enough here.
973 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
975 Fix integer width and related bugs (Bug#9874).
976 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
977 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
978 (string_bytes, check_sblock, allocate_string_data):
979 (compact_small_strings, Fmake_bool_vector, make_string)
980 (make_unibyte_string, make_multibyte_string)
981 (make_string_from_bytes, make_specified_string)
982 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
983 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
985 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
986 (allocate_pseudovector):
987 Use int, not EMACS_INT, where int is wide enough.
988 (inhibit_garbage_collection, Fgarbage_collect):
989 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
990 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
991 int might not be wide enough.
992 (bidi_cache_search, bidi_cache_find, bidi_init_it)
993 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
994 (bidi_at_paragraph_end, bidi_find_paragraph_start)
995 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
996 (bidi_level_of_next_char, bidi_move_to_visually_next):
997 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
998 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
999 (Fkill_buffer, Fset_buffer_major_mode)
1000 (advance_to_char_boundary, Fbuffer_swap_text)
1001 (Fset_buffer_multibyte, overlays_at, overlays_in)
1002 (overlay_touches_p, struct sortvec, record_overlay_string)
1003 (overlay_strings, recenter_overlay_lists)
1004 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1005 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1006 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1007 (Foverlay_recenter, last_overlay_modification_hooks_used)
1008 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1009 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1010 (validate_region): Omit unnecessary test for b <= e,
1011 since that's guaranteed by the previous test.
1012 (adjust_overlays_for_delete): Avoid pos + length overflow.
1013 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1014 (report_overlay_modification):
1015 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1016 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1017 Omit pointer cast, which isn't needed anyway, and doesn't work
1018 after the EMACS_INT -> ptrdiff_t change.
1019 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
1020 * buffer.h: Adjust decls to match defn changes elsewhere.
1021 (struct buffer_text, struct buffer):
1022 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1023 Use EMACS_INT, not int, where int might not be wide enough.
1024 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1025 not int, to avoid needless 32-bit limit on 64-bit hosts.
1026 (exec_byte_code): Use tighter memory-full test, one that checks
1027 for alloca overflow. Don't compute the address of the object just
1028 before an array, as that's not portable. Use EMACS_INT, not
1029 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
1030 * callint.c (Fcall_interactively):
1031 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1032 * callproc.c (call_process_kill, Fcall_process):
1033 Don't assume pid_t fits into an Emacs fixnum.
1034 (call_process_cleanup, Fcall_process, child_setup):
1035 Don't assume pid_t fits into int.
1036 (call_process_cleanup, Fcall_process, delete_temp_file)
1037 (Fcall_process_region):
1038 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1039 (Fcall_process): Simplify handling of volatile integers.
1040 Use int, not EMACS_INT, where int will do.
1041 * casefiddle.c (casify_object, casify_region, operate_on_word)
1042 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1043 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1044 (casify_object): Avoid integer overflow when overallocating buffer.
1045 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
1046 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
1047 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1048 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1049 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1050 integers are now checked earlier. All uses replaced with XINT.
1052 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1053 For CCL_MapSingle, check that content and value are in int range.
1054 (ccl_driver, Fregister_code_conversion_map):
1055 Check that Vcode_version_map_vector is a vector.
1056 (resolve_symbol_ccl_program): Check that vector header is in range.
1057 Always copy the vector, so that we can check its contents reliably
1058 now rather than having to recheck each instruction as it's being
1059 executed. Check that vector words fit in 'int'.
1060 (ccl_get_compiled_code, Fregister_ccl_program)
1061 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1062 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1063 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1064 contents are in range.
1065 (Fccl_execute_on_string): Check that status is in range.
1066 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1067 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1068 Accept and return EMACS_INT, not int, because callers can pass values
1070 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1071 (multibyte_chars_in_text, parse_str_as_multibyte)
1072 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1073 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1074 (string_escape_byte8, Fget_byte):
1075 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1076 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
1077 avoid mishandling large integers.
1078 * character.h: Adjust decls to match defn changes elsewhere.
1079 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1080 (Ffind_charset_region):
1081 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1082 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1083 (load_charset_map_from_vector, Fdefine_charset_internal):
1084 Don't assume fixnum fits in int.
1085 (load_charset_map_from_vector, Fmap_charset_chars):
1086 Remove now-unnecessary CHECK_NATNUMs.
1087 (Fdefine_charset_internal): Check ranges here, more carefully.
1088 Don't rely on undefined behavior with signed left shift overflow.
1089 Don't assume unsigned int fits into fixnum, or that fixnum fits
1090 into unsigned int. Don't require max_code to be a valid fixnum;
1091 that's not true for gb10830 4-byte on a 32-bit host. Allow
1092 invalid_code to be a cons, for the same reason. Require code_offset
1093 to be a character. Avoid int overflow if max_char is close
1095 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1096 this is intended anyway and avoids some undefined behavior.
1097 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1098 INDEX_TO_CODE_POINT, as that's what it expects.
1099 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
1100 * charset.h (DECODE_CHAR): Return int, not unsigned;
1101 this is what was intended anyway, and it avoids undefined behavior.
1102 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1103 integer-overflow issues.
1104 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1105 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1106 where the argument is EMACS_INT, and this behavior is not intended.
1107 * chartab.c (Fmake_char_table, Fset_char_table_range)
1108 (uniprop_get_decoder, uniprop_get_encoder):
1109 Don't assume fixnum fits in int.
1110 * cmds.c (move_point): New function, that does the gist of
1111 Fforward_char and Fbackward_char, but does so while checking
1112 for integer overflow more accurately.
1113 (Fforward_char, Fbackward_char): Use it.
1114 (Fforward_line, Fend_of_line, internal_self_insert)
1115 (internal_self_insert):
1116 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1117 Fix a FIXME, by checking for integer overflow when calculating
1118 target_clm and actual_clm.
1119 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
1120 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
1121 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1122 (coding_alloc_by_making_gap, alloc_destination)
1123 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1124 (encode_coding_utf_16, detect_coding_emacs_mule)
1125 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1126 (detect_coding_iso_2022, decode_coding_iso_2022)
1127 (encode_invocation_designation, encode_designation_at_bol)
1128 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1129 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1130 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1131 (encode_coding_ccl, encode_coding_raw_text)
1132 (detect_coding_charset, decode_coding_charset)
1133 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1134 (produce_composition, produce_charset, produce_annotation)
1135 (decode_coding, handle_composition_annotation)
1136 (handle_charset_annotation, consume_chars, decode_coding_gap)
1137 (decode_coding_object, encode_coding_object, detect_coding_system)
1138 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1139 (code_convert_region, code_convert_string)
1140 (Fdefine_coding_system_internal)
1141 (coding_set_source, coding_set_destination):
1142 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1143 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1144 (Fdefine_coding_system_internal):
1145 Don't assume fixnums fit in int.
1146 (decode_coding_gap, decode_coding_object, encode_coding_object)
1147 (Fread_coding_system, Fdetect_coding_region)
1148 (Funencodable_char_position, Fcheck_coding_systems_region)
1149 (get_translation, handle_composition_annotation, consume_chars):
1150 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1151 (consume_chars): Rewrite to not calculate an address outside buffer.
1152 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
1153 Don't access memory outside of the args array.
1154 (Fdefine_coding_system_internal): Check for charset-id overflow.
1155 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1156 result of ENCODE_CHAR.
1157 * coding.h: Adjust decls to match defn changes elsewhere.
1158 (struct coding_system):
1159 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1160 * composite.c (get_composition_id, find_composition)
1161 (run_composition_function, update_compositions)
1162 (compose_text, composition_gstring_put_cache)
1163 (composition_gstring_p, composition_gstring_width)
1164 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1165 (composition_compute_stop_pos, composition_reseat_it)
1166 (composition_update_it, struct position_record)
1167 (find_automatic_composition, composition_adjust_point)
1168 (Fcomposition_get_gstring, Ffind_composition_internal):
1169 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1170 (update_compositions):
1171 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1172 * composite.h: Adjust decls to match defn changes elsewhere.
1173 (struct composition):
1174 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1175 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1176 Do not attempt to compute the address of the object just before a
1177 buffer; this is not portable.
1179 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1180 (Faset): Use int, not EMACS_INT, where int is wide enough.
1181 (Fstring_to_number): Don't assume fixnums fit in int.
1182 (Frem): Don't assume arg is nonnegative.
1183 * dbusbind.c (xd_append_arg): Check for integers out of range.
1184 (Fdbus_call_method): Don't overflow the timeout int.
1185 (extract_signed, extract_unsigned): New functions.
1186 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1187 (xd_get_connection_references): Return ptrdiff_t, not int.
1189 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1190 (xd_read_message_1):
1191 Use int, not unsigned, where the dbus API uses int.
1192 (Fdbus_message_internal): Don't overflow mtype.
1193 (syms_of_dbusbind): Allocate right-sized buffer for integers.
1194 * dired.c (directory_files_internal, file_name_completion, scmp)
1195 (file_name_completion_stat):
1196 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1197 (file_name_completion): Don't overflow matchcount.
1198 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1199 * dispextern.h: Adjust decls to match defn changes elsewhere.
1200 (struct text_pos, struct glyph, struct bidi_saved_info)
1201 (struct bidi_string_data, struct bidi_it, struct composition_it)
1203 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1204 (struct display_pos, struct composition_it, struct it):
1205 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1206 * dispnew.c (increment_matrix_positions)
1207 (increment_row_positions, mode_line_string)
1208 (marginal_area_string):
1209 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1210 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
1211 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1212 (duration_to_sec_usec): New function, to check for overflow better.
1213 (Fsleep_for, sit_for): Use it.
1214 * doc.c (get_doc_string, store_function_docstring):
1215 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1216 (get_doc_string, Fsnarf_documentation):
1217 Use int, not EMACS_INT, where int is wide enough.
1219 Use SAFE_ALLOCA, not alloca.
1220 Check for overflow when converting EMACS_INT to off_t.
1221 * doprnt.c (doprnt):
1222 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1223 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1224 Don't assume uid_t fits into fixnum.
1225 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1226 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1227 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1228 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1229 (general_insert_function)
1230 (Finsert_char, make_buffer_string, make_buffer_string_both)
1231 (update_buffer_properties, Fbuffer_substring)
1232 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1233 (Fsubst_char_in_region, check_translation)
1234 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1235 (transpose_markers, Ftranspose_regions):
1236 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1237 (clip_to_bounds): Move to lisp.h as an inline function).
1238 (Fconstrain_to_field): Don't assume integers are nonnegative.
1239 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1240 (Fsubst_char_in_region, Fsave_restriction):
1241 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1242 (Femacs_pid): Don't assume pid_t fits into fixnum.
1243 (lo_time): Use int, not EMACS_INT, when int suffices.
1244 (lisp_time_argument): Check for usec out of range.
1245 (Fencode_time): Don't assume fixnum fits in int.
1246 (Fuser_login_name, Fuser_full_name): Signal an error
1247 if a uid argument is out of range, rather than relying on
1249 (Fformat_time_string): Remove now-unnecessary check.
1250 lisp_time_argument checks for out-of-range usec now.
1251 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
1252 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1253 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1254 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1255 (init_cmdargs, Fdump_emacs):
1256 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1257 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1258 the bottom (typically) 32 bits of the fixnum.
1259 * eval.c (specpdl_size, call_debugger):
1260 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1261 (when_entered_debugger, Fbacktrace_debug):
1262 Don't assume fixnum can fit in int.
1263 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1264 the object just before a buffer; this is not portable.
1265 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1266 (grow_specpdl, unbind_to):
1267 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1268 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1269 (grow_specpdl): Simplify allocation by using xpalloc.
1270 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
1271 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1272 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1273 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1274 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1276 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1277 (Fcopy_file, non_regular_nbytes, read_non_regular)
1278 (Finsert_file_contents):
1279 Use int, not EMACS_INT, where int is wide enough.
1280 (READ_BUF_SIZE): Verify that it fits in int.
1281 (Finsert_file_contents): Check that counts are in proper range,
1282 rather than assuming fixnums fit into ptrdiff_t etc.
1283 Don't assume fixnums fit into int.
1284 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
1285 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1286 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
1287 (string_char_to_byte, string_byte_to_char)
1288 (string_make_multibyte, string_to_multibyte)
1289 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1290 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1291 (substring_both, Fdelete, internal_equal, Ffillarray)
1292 (Fclear_string, mapcar1)
1293 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1294 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1295 (larger_vector, make_hash_table, maybe_resize_hash_table)
1296 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1297 (Fmaphash, secure_hash):
1298 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1299 (concat): Check for string index and length overflow.
1300 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1302 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1303 (larger_vector): New API (vec, incr_min, size_max) replaces old
1304 one (vec, new_size, init). This catches size overflow.
1305 INIT was removed because it was always Qnil.
1306 All callers changed.
1307 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1308 the upper bound on a hash table index size.
1309 (make_hash_table, maybe_resize_hash_table): Use it.
1310 (secure_hash): Computer start_byte and end_byte only after
1311 they're known to be in ptrdiff_t range.
1312 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1313 (Ffont_get_glyphs, Ffont_at):
1314 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1315 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1316 (Flist_fonts, Fopen_font):
1317 Don't assume fixnum can fit in int.
1318 (check_gstring): Don't assume index can fit in int.
1319 (font_match_p): Check that fixnum is a character, not a nonnegative
1320 fixnum, since the later code needs to stuff it into an int.
1321 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1322 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1323 conversion overflow issues.
1324 (Fopen_font): Check for integer out of range.
1325 (Ffont_get_glyphs): Don't assume index can fit in int.
1326 * font.h: Adjust decls to match defn changes elsewhere.
1327 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1329 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1330 printmax_t, where ptrdiff_t is wide enough.
1331 (Finternal_char_font):
1332 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1333 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1334 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1335 (Fset_frame_position, x_set_frame_parameters)
1336 (x_set_line_spacing, x_set_border_width)
1337 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1338 Check that fixnums are in proper range for system types.
1339 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1340 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1341 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1342 Use SAFE_ALLOCA_LISP, not alloca.
1343 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1344 intptr_t is wide enough.
1345 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1346 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1347 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1348 Check for fixnum out of range.
1349 * ftfont.c (ftfont_list): Don't assume index fits in int.
1350 Check that fixnums are in proper range for system types.
1351 (ftfont_shape_by_flt):
1352 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1353 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1354 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1355 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1356 Check that fixnums are in proper range for system types.
1357 * gnutls.h: Adjust decls to match defn changes elsewhere.
1358 * gtkutil.c (xg_dialog_run):
1359 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1360 (update_frame_tool_bar):
1361 Check that fixnums are in proper range for system types.
1362 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
1363 (lookup_image): Check that fixnums are in range for system types.
1364 * indent.c (last_known_column, last_known_column_point):
1365 (current_column_bol_cache):
1366 (skip_invisible, current_column, check_display_width):
1367 (check_display_width, scan_for_column, current_column_1)
1368 (Findent_to, Fcurrent_indentation, position_indentation)
1369 (indented_beyond_p, Fmove_to_column, compute_motion):
1370 (Fcompute_motion, Fvertical_motion):
1371 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1372 (last_known_column_modified): Use EMACS_INT, not int.
1373 (check_display_width):
1375 Check that fixnums and floats are in proper range for system types.
1376 (compute_motion): Don't assume index or fixnum fits in int.
1377 (compute_motion, Fcompute_motion):
1378 Use int, not EMACS_INT, when it is wide enough.
1379 (vmotion): Omit local var start_hpos that is always 0; that way
1380 we don't need to worry about overflow in expressions involving it.
1381 * indent.h: Adjust decls to match defn changes elsewhere.
1383 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1384 Use int, not EMACS_INT, where int is wide enough.
1385 Remove unused members ovstring_chars_done and tab_offset;
1387 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1388 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1389 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1390 (make_gap, copy_text, insert, insert_and_inherit)
1391 (insert_before_markers, insert_before_markers_and_inherit)
1392 (insert_1, count_combining_before, count_combining_after)
1393 (insert_1_both, insert_from_string)
1394 (insert_from_string_before_markers, insert_from_string_1)
1395 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1396 (adjust_after_replace, adjust_after_insert, replace_range)
1397 (replace_range_2, del_range, del_range_1, del_range_byte)
1398 (del_range_both, del_range_2, modify_region)
1399 (prepare_to_modify_buffer, signal_before_change)
1400 (signal_after_change, Fcombine_after_change_execute):
1401 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1402 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1403 (balance_an_interval, split_interval_right, split_interval_left)
1404 (find_interval, next_interval, update_interval)
1405 (adjust_intervals_for_insertion, delete_node, delete_interval)
1406 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1407 (static_offset_intervals, offset_intervals)
1408 (merge_interval_right, merge_interval_left, make_new_interval)
1409 (graft_intervals_into_buffer, temp_set_point_both)
1410 (temp_set_point, set_point, adjust_for_invis_intang)
1411 (set_point_both, move_if_not_intangible, get_property_and_range)
1412 (get_local_map, copy_intervals, copy_intervals_to_string)
1413 (compare_string_intervals, set_intervals_multibyte_1):
1414 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1415 * intervals.h: Adjust decls to match defn changes elsewhere.
1417 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1418 * keyboard.c (this_command_key_count, this_single_command_key_start)
1419 (before_command_key_count, before_command_echo_length, echo_now)
1420 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1421 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1422 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1423 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1424 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1425 (last_non_minibuf_size, last_point_position, echo_truncate)
1426 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1427 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1428 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1429 (stuff_buffered_input):
1430 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1431 (last_auto_save, command_loop_1, read_char):
1432 Use EMACS_INT, not int, to avoid integer overflow.
1433 (record_char): Avoid overflow in total_keys computation.
1434 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1435 * keyboard.h: Adjust decls to match defn changes elsewhere.
1436 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1437 (Fkey_description, Fdescribe_vector, Flookup_key):
1438 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1439 (click_position): New function, to check that positions are in range.
1440 (Fcurrent_active_maps):
1442 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1443 (Faccessible_keymaps, Fkey_description):
1444 (preferred_sequence_p):
1445 Don't assume fixnum can fit into int.
1446 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1447 Check for integer overflow in size calculations.
1448 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1449 avoid mishandling large integers.
1450 * lisp.h: Adjust decls to match defn changes elsewhere.
1451 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1452 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1453 (struct Lisp_Marker):
1454 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1455 (clip_to_bounds): Now an inline function, moved here from editfns.c.
1456 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1457 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1458 All callers changed.
1459 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1460 Assume the arg has valid form, since it always does.
1461 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1462 unsigned integer system type.
1463 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1464 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1465 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1466 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1467 (duration_to_sec_usec): New decl.
1468 * lread.c (read_from_string_index, read_from_string_index_byte)
1469 (read_from_string_limit, readchar, unreadchar, openp)
1470 (read_internal_start, read1, oblookup):
1471 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1472 (Fload, readevalloop, Feval_buffer, Feval_region):
1473 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1474 (openp): Check for out-of-range argument to 'access'.
1475 (read1): Use int, not EMACS_INT, where int is wide enough.
1476 Don't assume fixnum fits into int.
1477 Fix off-by-one error that can read outside a buffer.
1478 (read_filtered_event): Use duration_to_sec_usec
1479 to do proper overflow checking on durations.
1480 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1481 in size calculation.
1482 (Fexecute_kbd_macro):
1483 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1484 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1485 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1486 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1487 (set_marker_both, set_marker_restricted_both, marker_position)
1488 (marker_byte_position, Fbuffer_has_markers_at):
1489 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1490 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
1491 * menu.c (ensure_menu_items): Rename from grow_menu_items.
1492 It now merely ensures that the menu is large enough, without
1493 necessarily growing it, as this avoids some integer overflow issues.
1494 All callers changed.
1495 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1496 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1497 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1498 Use SAFE_ALLOCA_LISP, not alloca.
1499 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1500 to EMACS_INT. Check that fixnums are in proper range for system types.
1501 * minibuf.c (minibuf_prompt_width, string_to_object)
1502 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1503 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1505 (get_minibuffer, read_minibuf_unwind):
1506 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1507 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1508 this simplifies overflow checking. All callers changed.
1509 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1511 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1512 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1513 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1514 Check that fixnums are in proper range for system types.
1515 (Fx_create_frame, Fx_show_tip):
1516 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1517 * nsfont.m (ns_findfonts, nsfont_list_family):
1518 Don't assume fixnum fits in long.
1519 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1520 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1521 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1523 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
1524 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1525 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1526 (PRINTDECLARE, PRINTPREPARE):
1527 (strout, print_string):
1528 (print, print_preprocess, print_check_string_charset_prop)
1530 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1532 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1533 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1534 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
1535 (printchar, strout): Use xpalloc to catch size calculation overflow.
1536 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
1537 (print_error_message): Use SAFE_ALLOCA, not alloca.
1538 (print_object): Use int, not EMACS_INT, where int is wide enough.
1539 (print_depth, new_backquote_output, print_number_index):
1540 Use ptrdiff_t, not int, where int might not be wide enough.
1541 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1542 (Fset_process_window_size, Fformat_network_address)
1543 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1545 Check that fixnums are in proper range for system types.
1546 (Fsignal_process): Simplify by avoiding a goto.
1547 Check for process-ids out of pid_t range rather than relying on
1549 (process_tick, update_tick): Use EMACS_INT, not int.
1550 (Fformat_network_address, read_process_output, send_process)
1551 (Fprocess_send_region, status_notify):
1552 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1553 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1554 (wait_reading_process_output, read_process_output, exec_sentinel):
1555 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1556 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1557 (Faccept_process_output): Use duration_to_sec_usec to do proper
1558 overflow checking on durations.
1559 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1560 Don't assume pid_t fits in int.
1561 * process.h (struct Lisp_Process): Members tick and update_tick
1562 are now of type EMACS_INT, not int.
1563 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1564 configured --with-wide-int.
1565 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1566 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1567 * search.c (looking_at_1, string_match_1):
1568 (fast_string_match, fast_c_string_match_ignore_case)
1569 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1570 (scan_newline, find_before_next_newline, search_command)
1571 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1572 (set_search_regs, wordify):
1575 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1576 (string_match_1, search_buffer, set_search_regs):
1578 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1579 (wordify): Check for overflow in size calculation.
1580 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1581 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1582 Check that fixnums are in proper range for system types.
1583 * sound.c (struct sound_device)
1584 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1586 (Fplay_sound_internal):
1587 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1588 * syntax.c (struct lisp_parse_state, find_start_modiff)
1589 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1590 (Fparse_partial_sexp):
1591 Don't assume fixnums can fit in int.
1592 (struct lisp_parse_state, find_start_pos, find_start_value)
1593 (find_start_value_byte, find_start_begv)
1594 (update_syntax_table, char_quoted, dec_bytepos)
1595 (find_defun_start, prev_char_comend_first, back_comment):
1596 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1597 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1598 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1599 (Finternal_describe_syntax_value): Check that match_lisp is a
1600 character, not an integer, since the code stuffs it into int.
1601 (scan_words, scan_sexps_forward):
1602 Check that fixnums are in proper range for system types.
1604 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1605 (scan_sexps_forward):
1606 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1607 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1608 * syntax.h: Adjust decls to match defn changes elsewhere.
1609 (struct gl_state_s):
1610 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1611 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1612 MOST_POSITIVE_FIXNUM.
1613 * sysdep.c (wait_for_termination_1, wait_for_termination)
1614 (interruptible_wait_for_termination, mkdir):
1615 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1616 (emacs_read, emacs_write):
1617 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1618 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1619 and double all fit in int.
1620 * term.c (set_tty_color_mode):
1621 Check that fixnums are in proper range for system types.
1622 * termhooks.h (struct input_event):
1623 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1624 * textprop.c (validate_interval_range, interval_of)
1625 (Fadd_text_properties, set_text_properties_1)
1626 (Fremove_text_properties, Fremove_list_of_text_properties)
1627 (Ftext_property_any, Ftext_property_not_all)
1628 (copy_text_properties, text_property_list, extend_property_ranges)
1629 (verify_interval_modification):
1630 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1631 (Fnext_single_char_property_change)
1632 (Fprevious_single_char_property_change):
1633 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1634 (copy_text_properties):
1635 Check for integer overflow in index calculation.
1636 * undo.c (last_boundary_position, record_point, record_insert)
1637 (record_delete, record_marker_adjustment, record_change)
1638 (record_property_change):
1639 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1640 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1641 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1642 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1643 (Fx_hide_tip, Fx_file_dialog):
1644 * w32menu.c (set_frame_menubar):
1645 Use ptrdiff_t, not int, for consistency with rest of code.
1646 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1647 (select_window, Fdelete_other_windows_internal)
1648 (window_scroll_pixel_based, window_scroll_line_based)
1649 (Frecenter, Fset_window_configuration):
1650 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1651 (Fset_window_hscroll, run_window_configuration_change_hook)
1652 (set_window_buffer, temp_output_buffer_show, scroll_command)
1653 (Fscroll_other_window, Frecenter):
1654 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1655 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1656 Don't assume fixnum fits in int.
1657 (Fset_window_scroll_bars):
1658 Check that fixnums are in proper range for system types.
1659 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1660 (string_pos, c_string_pos, number_of_chars, init_iterator)
1661 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1662 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1663 (compute_display_string_end, handle_face_prop)
1664 (face_before_or_after_it_pos, handle_invisible_prop)
1665 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1666 (display_prop_intangible_p, string_buffer_position_lim)
1667 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1668 (get_overlay_strings_1, get_overlay_strings)
1669 (iterate_out_of_display_property, forward_to_next_line_start)
1670 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1671 (get_next_display_element, set_iterator_to_next)
1672 (get_visually_first_element, compute_stop_pos_backwards)
1673 (handle_stop_backwards, next_element_from_buffer)
1674 (move_it_in_display_line_to, move_it_in_display_line)
1675 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1676 (add_to_log, message_dolog, message_log_check_duplicate)
1677 (message2, message2_nolog, message3, message3_nolog
1678 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1679 (current_message_1, truncate_echo_area, truncate_message_1)
1680 (set_message, set_message_1, store_mode_line_noprop)
1681 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1682 (text_outside_line_unchanged_p, check_point_in_composition)
1683 (reconsider_clip_changes)
1684 (redisplay_internal, set_cursor_from_row, try_scrolling)
1685 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1686 (redisplay_window, find_last_unchanged_at_beg_row)
1687 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1688 (trailing_whitespace_p, find_row_edges, display_line)
1689 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1690 (display_mode_element, store_mode_line_string)
1691 (pint2str, pint2hrstr, decode_mode_spec)
1692 (display_count_lines, display_string, draw_glyphs)
1693 (x_produce_glyphs, x_insert_glyphs)
1694 (rows_from_pos_range, mouse_face_from_buffer_pos)
1695 (fast_find_string_pos, mouse_face_from_string_pos)
1696 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1697 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1698 (safe_call, init_from_display_pos, handle_fontified_prop)
1699 (handle_single_display_spec, load_overlay_strings)
1700 (with_echo_area_buffer, setup_echo_area_for_printing)
1701 (display_echo_area, echo_area_display)
1702 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1703 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1704 (redisplay_window, dump_glyph_row, display_mode_line)
1705 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1706 (handle_display_spec, display_prop_string_p):
1707 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1708 (handle_single_display_spec, build_desired_tool_bar_string)
1709 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1710 (get_specified_cursor_type):
1711 Check that fixnums are in proper range for system types.
1712 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1713 (Flookup_image_map):
1714 Don't assume fixnums fit in int.
1715 (compare_overlay_entries):
1716 Avoid mishandling comparisons due to subtraction overflow.
1717 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1718 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1719 (handle_tool_bar_click):
1720 Use int, not unsigned, since we prefer signed and the signedness
1721 doesn't matter here.
1722 (get_next_display_element, next_element_from_display_vector):
1723 Use int, not EMACS_INT, when int is wide enough.
1724 (start_hourglass): Use duration_to_sec_usec to do proper
1725 overflow checking on durations.
1726 * xfaces.c (Fbitmap_spec_p):
1727 Check that fixnums are in proper range for system types.
1728 (compare_fonts_by_sort_order):
1729 Avoid mishandling comparisons due to subtraction overflow.
1730 (Fx_family_fonts, realize_basic_faces):
1731 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1733 Don't assume fixnum fits in int.
1734 Use SAFE_ALLOCA_LISP, not alloca.
1735 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1736 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1737 (face_at_buffer_position, face_for_overlay_string)
1738 (face_at_string_position):
1739 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1740 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1741 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1743 Check that fixnums are in proper range for system types.
1744 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1745 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1746 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1747 (Fx_change_window_property): Don't assume fixnums fit in int.
1748 * xfont.c (xfont_chars_supported):
1749 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1750 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1751 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1752 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1753 * xml.c (parse_region):
1754 * xrdb.c (magic_file_p):
1755 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1756 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1757 (x_get_local_selection, x_reply_selection_request)
1758 (x_handle_selection_request, wait_for_property_change):
1759 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1760 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1761 short is wide enough.
1762 (x_send_client_event): Don't assume fixnum fits in int.
1763 * xterm.c (x_x_to_emacs_modifiers):
1764 Don't assume EMACS_INT overflows nicely into int.
1765 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1767 (handle_one_xevent): NATNUMP can eval its arg twice.
1768 (x_connection_closed):
1769 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1770 * xterm.h: Adjust decls to match defn changes elsewhere.
1771 (struct scroll_bar): Use struct vectorlike_header
1772 rather than rolling our own approximation.
1773 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1775 2012-05-25 Glenn Morris <rgm@gnu.org>
1777 * lisp.mk (lisp): Update for more files being compiled now.
1779 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1781 * lread.c: Remove `read_pure' which makes no difference.
1782 (read_pure): Remove var.
1783 (unreadpure): Remove function.
1784 (readevalloop): Don't call read_list with -1 flag.
1785 (read1, read_vector): Don't test read_pure any more.
1786 (read_list): Simplify.
1788 * fileio.c, character.h: Minor style tweaks.
1790 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1792 * window.h (clip_changed): Remove useless declaration.
1794 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1796 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1797 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1799 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1802 This directory predates autoconf and is no longer needed nowadays.
1803 Move its few remaining bits of functionality to where they're needed.
1804 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1805 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1806 * m/template.h: Remove.
1807 * Makefile.in (M_FILE): Remove. All uses removed.
1808 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1809 * lisp.h (USE_LSB_TAG):
1810 * mem-limits.h (EXCEEDS_LISP_PTR):
1811 Use VAL_MAX, not VALBITS, in #if.
1812 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1813 (EMACS_UINT): Define unconditionally now.
1814 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1815 (BITS_PER_EMACS_INT): New constants, replacing
1816 what used to be in config.h, but not useful in #if.
1817 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1818 define them any more.
1819 (VAL_MAX): New macro.
1821 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1822 BITS_PER_EMACS_INT, in #if.
1823 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1824 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1825 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1826 * s/ms-w32.h (DATA_START):
1827 Move here from removed file m/intel386.h.
1828 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1829 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1831 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1833 Assume C89 or later.
1834 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1835 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1837 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1838 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1839 * textprop.c, tparam.c (NULL): Remove.
1840 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1841 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1842 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1843 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1844 * xterm.c (input_signal_count): Assume volatile works.
1846 2012-05-21 Ken Brown <kbrown@cornell.edu>
1848 * xgselect.c (xg_select): Fix first argument in call to 'select'
1851 2012-05-20 Ken Brown <kbrown@cornell.edu>
1853 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1854 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1856 2012-05-19 Ken Brown <kbrown@cornell.edu>
1858 * xfns.c (x_in_use): Remove `static' qualifier.
1859 * xterm.h (x_in_use): Declare.
1860 * xgselect.c: Include xterm.h.
1861 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1862 and `display_arg' (bug#9754).
1864 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1866 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1868 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1869 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1871 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1873 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1875 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1876 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1878 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1879 reference to image_cache->refcount.
1880 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1882 2012-05-17 Juri Linkov <juri@jurta.org>
1884 * search.c (Fword_search_regexp, Fword_search_backward)
1885 (Fword_search_forward, Fword_search_backward_lax)
1886 (Fword_search_forward_lax): Move functions to isearch.el
1887 (bug#10145, bug#11381).
1889 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1891 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1893 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1895 * lread.c (init_obarray): Declare Qt and Qnil as special.
1897 2012-05-14 Glenn Morris <rgm@gnu.org>
1899 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1900 Put "libexec" before "bin", for the sake of init_callproc_1.
1902 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1904 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1906 * unexaix.c: Port to more-recent AIX compilers.
1907 (report_error, report_error_1, make_hdr, copy_sym)
1908 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1909 Make arguments const char *, not char *, to avoid violations of C
1910 standard and to fix some AIX warnings reported by Gilles Pion.
1912 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1914 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1915 already have overlays loaded.
1916 (handle_single_display_spec): Before returning without displaying
1917 fringe bitmap, synchronize the bidi iterator with the main display
1918 iterator, by calling iterate_out_of_display_property.
1919 (iterate_out_of_display_property): Detect buffer iteration by
1920 testing that it->string is a Lisp string.
1921 (get_next_display_element): When the current object is exhausted,
1922 and there's something on it->stack, call set_iterator_to_next to
1923 proceed with what's on the stack, instead of returning zero.
1924 (set_iterator_to_next): If called at the end of a Lisp string,
1925 proceed to consider_string_end without incrementing string
1926 position. Don't increment display vector index past the end of
1927 the display vector. (Bug#11417)
1928 (pos_visible_p): Don't report a position visible when move_it_to
1929 stopped at the last line of window, which happens to be scanned
1930 backwards by the bidi iteration. (Bug#11464)
1932 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1934 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1935 and right-margin display specs even if the spec is invalid or we
1936 are on a TTY, and thus unable to display on the fringes.
1937 That's because the text with the property will not be displayed anyway,
1938 so we need to signal to the caller that this is a "replacing"
1939 display spec. This fixes display when the spec is invalid or we
1942 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1944 * unexaix.c (make_hdr): Fix typo in prototype.
1945 This bug broke the build on AIX. Problem reported by Gilles Pion.
1947 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1949 * keyboard.c (kbd_buffer_get_event): Read special events also in
1950 batch mode. (Bug#11415)
1952 2012-05-12 Glenn Morris <rgm@gnu.org>
1954 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1956 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1958 * lisp.mk (lisp): Add newcomment.elc.
1960 2012-05-12 Glenn Morris <rgm@gnu.org>
1962 * Makefile.in (MKDIR_P): New, set by configure.
1963 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1965 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1967 Remove unused function hourglass_started.
1968 * dispextern.h (hourglass_started):
1969 * w32fns.c (hourglass_started):
1970 * xdisp.c (hourglass_started): Remove.
1972 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1974 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1975 Update dependencies.
1977 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1979 * xgselect.c (xg_select): Put maxfds+1 into a var.
1980 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1982 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1984 2012-05-10 Dave Abrahams <dave@boostpro.com>
1986 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1987 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1989 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1991 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1992 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1993 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1994 Initialize xd_registered_buses.
1996 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1998 Untag more efficiently if USE_LSB_TAG.
1999 This is based on a proposal by YAMAMOTO Mitsuharu in
2000 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2001 For an admittedly artificial (nth 8000 longlist) benchmark on
2002 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2003 Emacs's overall text size by 1%.
2004 * lisp.h (XUNTAG): New macro.
2005 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2006 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2007 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2008 * eval.c (Fautoload):
2009 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2010 * frame.h (XFRAME): Use XUNTAG.
2012 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2013 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2014 Remove unportable assumptions about print widths of types like
2016 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2017 intptr_t when converting between pointer and integer, to avoid GCC
2018 warnings about wrong width.
2020 2012-05-09 Eli Zaretskii <eliz@gnu.org>
2022 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2023 stack for each reader_thread, instead of defaulting to 8MB
2024 determined by the linker. This avoids failures in creating
2025 subprocesses on Windows 7, see the discussion in this thread:
2026 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2028 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2030 Fix up display of the *Minibuf-0* buffer in the mini window.
2031 * keyboard.c (read_char): Don't clear the echo area if there's no
2033 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2034 contents of *Minibuf-0*) if there's no message displayed in its stead.
2036 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
2038 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2041 2012-05-06 Chong Yidong <cyd@gnu.org>
2043 * lisp.mk (lisp): Update.
2045 2012-05-05 Jim Meyering <meyering@redhat.com>
2047 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2049 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2051 * data.c (PUT_ERROR): New macro.
2052 (syms_of_data): Use it. Add new error type `user-error'.
2053 * undo.c (user_error): New function.
2054 (Fprimitive_undo): Use it.
2055 * print.c (print_error_message): Adjust print style for `user-error'.
2056 * keyboard.c (user_error): New function.
2057 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2059 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2061 Do not limit current-time-string to years 1000..9999.
2062 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2063 (Fcurrent_time_string): Support any year that is supported by the
2064 underlying localtime representation. Don't use asctime, as it
2065 has undefined behavior for years outside the range -999..9999.
2067 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2069 Fix race conditions involving setenv, gmtime, localtime, asctime.
2070 Without this fix, interrupts could mess up code that uses these
2071 nonreentrant functions, since setting TZ invalidates existing
2072 tm_zone or tzname values, and since most of these functions return
2073 pointers to static storage.
2074 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2075 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2076 Grow the critical sections to include not just invoking
2077 localtime/gmtime, but also accessing these functions' results
2078 including their tm_zone values if any, and any related TZ setting.
2079 (format_time_string): Last arg is now struct tm *, not struct tm **,
2080 so that the struct tm is saved in the critical section.
2081 All callers changed. Simplify allocation of initial buffer, partly
2082 motivated by the fact that memory allocation needs to be outside
2083 the critical section.
2085 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2087 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2088 with RESET_INTERVAL.
2090 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2091 Remove duplicated buffer name initialization.
2093 2012-05-02 Jim Meyering <jim@meyering.net>
2095 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2097 * xfns.c (x_window): Use xstrdup (Bug#11375).
2099 2012-05-02 Eli Zaretskii <eliz@gnu.org>
2101 * xdisp.c (pos_visible_p): If already at a newline from the
2102 display string before the 'while' loop, don't walk back the glyphs
2103 from it3.glyph_row. Solves assertion violation when the display
2104 string begins with a newline (egg.el). (Bug#11367)
2106 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2108 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2111 2012-05-01 Glenn Morris <rgm@gnu.org>
2113 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2114 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2115 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2116 All were removed before 23.1.
2118 * dispnew.c: Remove HAVE_LIBNCURSES test;
2119 it is always true on relevant platforms.
2121 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2122 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2124 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2126 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2128 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2129 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2132 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2134 Do not avoid creating empty evaporating overlays (Bug#9642).
2135 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2136 That is, do not delete an evaporating overlay if it becomes
2137 empty after its bounds are adjusted to fit within its buffer.
2138 This fix caused other problems, and I'm reverting it until we get
2139 to the bottom of them.
2141 2012-04-27 Chong Yidong <cyd@gnu.org>
2143 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2145 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2147 * xdisp.c (pos_visible_p): If the window start position is beyond
2148 ZV, start the display from buffer beginning. Prevents assertion
2149 violation in init_iterator when the minibuffer window is scrolled
2152 * window.c (window_scroll_pixel_based): Likewise.
2154 2012-04-27 Chong Yidong <cyd@gnu.org>
2156 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2158 2012-04-27 Glenn Morris <rgm@gnu.org>
2160 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2161 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2163 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2165 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2166 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
2168 2012-04-26 Eli Zaretskii <eliz@gnu.org>
2170 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2171 display element, check also the underlying string or buffer
2172 character. (Bug#11341)
2174 * w32menu.c: Include w32heap.h.
2175 (add_menu_item): If the call to AppendMenuW (via
2176 unicode_append_menu) fails, disable Unicode menus only if we are
2177 running on Windows 9X/Me.
2179 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2181 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2182 (xgetint): Add missing shift for LSB tags.
2184 2012-04-24 Martin Rudalics <rudalics@gmx.at>
2186 * keyboard.c (read_char): Don't wipe echo area for select window
2187 events: These might get delayed via `mouse-autoselect-window'
2190 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
2192 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2193 manipulation of :loaded-from data.
2195 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
2197 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2198 now a cons (bug#11311).
2200 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2202 Do not create empty overlays with the evaporate property (Bug#9642).
2203 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2204 if it becomes empty after its bounds are adjusted to fit within
2205 its buffer. Without this fix, in a nonempty buffer (let ((o
2206 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2207 yields an empty overlay that has the evaporate property, which is
2208 not supposed to happen.
2210 Fix minor GTK3 problems found by static checking.
2211 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2212 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2213 (struct _EmacsFixedClass, emacs_fixed_get_type):
2214 Move decls here from emacsgtkfixed.h, since they needn't be public.
2215 (emacs_fixed_get_type): Now static.
2216 (emacs_fixed_class_init): Omit unused local.
2217 (emacs_fixed_child_type): Remove; unused.
2218 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2219 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2220 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2221 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2222 (EMACS_FIXED_GET_CLASS): Remove; unused.
2223 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2225 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2226 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2228 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2230 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
2231 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
2232 (__malloc_size_t, __malloc_ptrdiff_t):
2233 Remove. All uses removed, replaced by the definiens if needed,
2234 since we can assume C89 or better now.
2235 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2236 (protect_malloc_state, align, get_contiguous_space)
2237 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2238 (malloc_atfork_handler_child, malloc_enable_thread)
2239 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2240 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2241 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2242 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2243 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2244 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2245 Define using prototypes, not old style.
2246 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2247 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2248 (align): Don't assume that signed integer overflow wraps around.
2249 Omit unused local var.
2250 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2251 (_free_internal_nolock, memalign, mallochook, reallochook):
2252 Omit no-longer-needed casts.
2253 (valloc): Use getpagesize, not __getpagesize.
2254 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2255 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2257 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2259 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
2261 Move functions from C to Lisp. Make non-blocking method calls
2262 the default. Implement further D-Bus standard interfaces.
2264 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2265 (QCdbus_request_name_allow_replacement)
2266 (QCdbus_request_name_replace_existing)
2267 (QCdbus_request_name_do_not_queue)
2268 (QCdbus_request_name_reply_primary_owner)
2269 (QCdbus_request_name_reply_in_queue)
2270 (QCdbus_request_name_reply_exists)
2271 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2272 (QCdbus_registered_serial, QCdbus_registered_method)
2273 (QCdbus_registered_signal): New Lisp objects.
2274 (XD_DEBUG_MESSAGE): Use sizeof.
2275 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2276 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2277 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2278 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2279 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2280 (xd_signature, xd_append_arg): Allow float for integer types.
2281 (xd_get_connection_references): New function.
2282 (xd_get_connection_address): Rename from xd_initialize.
2283 Return cached address.
2284 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2285 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2287 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
2288 Return number of refcounts.
2289 (Fdbus_get_unique_name): Make stronger parameter check.
2290 (Fdbus_message_internal): New defun.
2291 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2292 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2293 (Fdbus_send_signal, Fdbus_register_service)
2294 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2295 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2296 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2297 (Vdbus_compiled_version, Vdbus_runtime_version)
2298 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2299 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2300 (Vdbus_message_type_signal): New defvars.
2301 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2304 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2306 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2307 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2308 Do not assume ptrdiff_t is the same width as 'int'.
2310 * alloc.c: Handle unusual debugging option combinations.
2311 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2312 since the two debugging options are incompatible.
2313 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2315 (mem_init, mem_insert, mem_insert_fixup):
2316 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2317 (NEED_MEM_INSERT): Remove; no longer needed.
2319 2012-04-22 Leo Liu <sdl.web@gmail.com>
2321 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2323 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2325 * sysdep.c [__FreeBSD__]: Minor cleanups.
2326 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2327 Use Emacs indenting style more consistently. Avoid some casts.
2328 Use 'double' consistently rather than mixing 'float' and 'double'.
2330 2012-04-21 Eduard Wiebe <usenet@pusto.de>
2332 * sysdep.c (list_system_processes, system_process_attributes):
2333 Add implementation for FreeBSD (Bug#5243).
2335 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2337 * lisp.mk (lisp): Update.
2339 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2341 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2342 It is never used otherwise.
2344 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2346 * print.c (print_preprocess): Only check print_depth if print-circle
2348 (print_object): Check for cycles even when print-circle is nil and
2349 print-gensym is t, but only check print_depth if print-circle is nil.
2351 2012-04-20 Chong Yidong <cyd@gnu.org>
2353 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2354 set the status to "failed" and ensure that sentinel is run.
2356 2012-04-20 Glenn Morris <rgm@gnu.org>
2358 * process.c (Fset_process_inherit_coding_system_flag)
2359 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
2360 (Fmake_network_process, Fmake_serial_process): Doc fix.
2362 2012-04-20 Eli Zaretskii <eliz@gnu.org>
2364 * xdisp.c (string_buffer_position_lim): Limit starting position to
2366 (set_cursor_from_row): If called for a mode-line or header-line
2367 row, return zero immediately.
2368 (try_cursor_movement): If inside continuation line, don't back up
2369 farther than the first row after the header line, if any.
2370 Don't consider the header-line row as "partially visible", even if
2371 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2373 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2375 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2378 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
2379 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
2381 configure: new option --enable-gcc-warnings (Bug#11207)
2382 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2383 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2384 (ALL_CFLAGS): Use new macros rather than old.
2385 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2386 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2387 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2388 -Wunused-result, -Wunused-variable. This should go away once
2389 the Emacs and Gnulib regex code is merged.
2390 (xmalloc, xrealloc): Now static.
2392 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2394 * dired.c (Fsystem_groups): Remove unused local.
2396 2012-04-17 Glenn Morris <rgm@gnu.org>
2398 * dired.c (Fsystem_users): Doc fix.
2400 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2402 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2403 (syms_of_dired): Add them.
2405 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2407 Fix minor alloc.c problems found by static checking.
2408 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2409 New extern decls, to avoid calling undeclared functions.
2410 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2411 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2412 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2413 (NEED_MEM_INSERT): New macro.
2414 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
2415 Remove one incorrect comment and fix another.
2417 Fix minor ralloc.c problems found by static checking.
2418 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2419 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2420 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2421 (r_alloc_sbrk): Now static.
2423 Improve ralloc.c interface checking.
2424 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2425 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2426 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2427 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2428 [REL_ALLOC]: ... to here, to check interface.
2429 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2430 Remove decls. This fixes an "It stinks!".
2432 * alloc.c (which_symbols): Fix alignment issue / type clash.
2434 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2436 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2437 (struct Lisp_Misc_Any): Likewise.
2438 (struct Lisp_Free): Likewise.
2439 * alloc.c (union aligned_Lisp_Symbol): Define.
2440 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2441 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2442 (union aligned_Lisp_Misc): Define.
2443 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2444 aligned_Lisp_Misc instead of union Lisp_Misc.
2445 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
2447 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2449 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2450 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2451 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2452 * s/netbsd.h, s/sol2-6.h:
2453 Remove definition of GC_MARK_STACK, since the default now works.
2454 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2455 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2456 no longer the default.
2457 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2459 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2461 * lread.c (lisp_file_lexically_bound_p):
2462 Fix hang at ";-*-\n" (bug#11238).
2464 2012-04-14 Eli Zaretskii <eliz@gnu.org>
2466 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2467 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2469 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2471 * nsterm.m (constrainFrameRect): Always constrain when there is only
2472 one screen (Bug#10962).
2474 2012-04-13 Ken Brown <kbrown@cornell.edu>
2476 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2478 2012-04-13 Reuben Thomas <rrt@sc3d.org>
2480 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2482 2012-04-11 Daniel Colascione <dancol@dancol.org>
2484 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2485 against is gone. It's better to use vfork now so that when Cygwin
2486 gains a new, working vfork, we use it automatically (bug#10398).
2488 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2490 * window.c (save_window_save): Obey window-point-insertion-type.
2492 2012-04-11 Glenn Morris <rgm@gnu.org>
2494 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2496 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2498 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2500 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
2502 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2503 (force_quit_count): New var.
2504 (handle_interrupt): Use it.
2506 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
2508 * w32.c (w32_delayed_load): Record the full path of the library
2509 being loaded (bug#10424).
2511 2012-04-09 Glenn Morris <rgm@gnu.org>
2513 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2514 not just in the obarray, before snarfing them. (Bug#11036)
2516 * Makefile.in ($(leimdir)/leim-list.el):
2517 Pass EMACS rather than BUILT_EMACS.
2519 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2521 * process.c (make_process):
2522 * process.h: Add integer `gnutls_handshakes_tried' member to
2525 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2526 Add convenience `GNUTLS_LOG2i' macro.
2528 * gnutls.c (gnutls_log_function2i): Convenience log function.
2529 (emacs_gnutls_read): Use new log functions,
2530 `gnutls_handshakes_tried' process member, and
2531 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2532 attempts per process (connection).
2534 2012-04-09 Chong Yidong <cyd@gnu.org>
2536 * eval.c (Fuser_variable_p, user_variable_p_eh)
2537 (lisp_indirect_variable): Functions deleted.
2538 (Fdefvar): Caller changed.
2540 * callint.c (Finteractive, Fcall_interactively):
2541 * minibuf.c (Fread_variable): Callers changed.
2543 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2545 * xdisp.c (set_cursor_from_row): If the display string appears in
2546 the buffer at position that is closer to point than the position
2547 after the display string, display the cursor on the first glyph of
2548 the display string. Fixes cursor display when a 'display' text
2549 property immediately follows invisible text. (Bug#11094)
2551 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2553 composite.c: use 'double' consistently
2554 * composite.c (get_composition_id): Use 'double' consistently
2555 instead of converting 'float' to 'double' and vice versa; this is
2556 easier to understand and avoids a GCC warning.
2558 2012-04-09 Glenn Morris <rgm@gnu.org>
2560 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2561 preparation for dumping it with emacs. (Bug#4789)
2562 (leimdir): New variable.
2563 ($(leimdir)/leim-list.el): New rule.
2564 (emacs$(EXEEXT)): Depend on leim-list.el.
2566 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2567 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2568 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2570 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2572 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2575 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2577 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2578 Remove unused local variable.
2580 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2582 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2583 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2584 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2585 objects, as mark_maybe_pointer will catch them otherwise.
2586 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2587 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2589 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2591 Fix typo that broke non-Windows builds.
2592 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2594 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2596 Support building on MS-Windows with libxml2.
2598 * makefile.w32-in (OBJ2): Add xml.$(O).
2599 (GLOBAL_SOURCES): Add xml.c.
2600 ($(BLD)/xml.$(O)): New dependency list.
2602 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2603 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2604 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2605 [!WINDOWSNT]: New macros.
2606 (init_libxml2_functions, libxml2_loaded_p): New functions.
2607 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2608 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2609 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2610 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2612 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2613 Call init_libxml2_functions before calling libxml2 functions.
2614 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2616 * emacs.c: Don't include libxml/parser.h.
2617 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2618 xmlCleanupParser directly.
2620 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2622 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2624 * indent.c (Fvertical_motion): If there is a display string at
2625 point, use it.vpos to compute how many lines to backtrack after
2626 move_it_to point. (Bug#11133)
2628 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2630 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2631 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2632 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2633 macros related to unification of CJK characters. For the details,
2634 see the discussion following the message here:
2635 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2637 2012-04-04 Chong Yidong <cyd@gnu.org>
2639 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2641 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2643 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2644 instead of alloca. (Bug#11138)
2646 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2648 * w32menu.c (is_simple_dialog): Properly check lisp types.
2651 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2653 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2654 position we get to after a call to move_it_to fails the
2655 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2656 only if we wind up in a string from display property. (Bug#11063)
2658 * window.c (Fdelete_other_windows_internal): Invalidate the row
2659 and column information about mouse highlight, so that redisplay
2660 restores it after reallocating the glyph matrices. (Bug#7464)
2662 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2663 string comes from a `display' text property, use the buffer
2664 position of that property as if we actually saw that position in
2666 (move_it_by_lines): Remove the assertion that
2667 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2668 violated when there's a before-string at the beginning of a line.
2671 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2673 * xdisp.c (append_space_for_newline): If the default face was
2674 remapped, use the remapped face for the appended newline.
2675 (extend_face_to_end_of_line): Use the remapped default face for
2676 extending the face to the end of the line.
2677 (display_line): Call extend_face_to_end_of_line when the default
2678 face was remapped. (Bug#11068)
2680 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2682 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2684 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2686 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2688 2012-03-27 Glenn Morris <rgm@gnu.org>
2690 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2693 2012-03-26 Kenichi Handa <handa@m17n.org>
2695 * dispextern.h (struct glyph): Fix previous change. Change the
2696 bit length of glyphless.ch to 25 (Bug#11082).
2698 2012-03-26 Chong Yidong <cyd@gnu.org>
2700 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2701 (command_loop_1): Use it; inhibit selection update for
2702 handle-select-window too (Bug#8996).
2704 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2706 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2708 2012-03-25 Kenichi Handa <handa@m17n.org>
2710 * dispextern.h (struct glyph): Change the bit length of
2711 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2713 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2715 * s/ms-w32.h (tzname): Include time.h before redirecting to
2716 _tzname. Fixes the MSVC build. (Bug#9960)
2718 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2720 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2723 * xterm.c (XTread_socket): Only modify handling_signal if
2724 !SYNC_INPUT. (Bug#11080)
2726 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2728 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2729 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2730 when fetching a multibyte character consumes more bytes than
2731 CHAR_BYTES returns, due to unification of CJK characters in
2732 string_char. (Bug#11073)
2734 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2736 * process.c (wait_reading_process_output): Handle pty disconnect
2737 by refraining from sending oneself a SIGCHLD (bug#10933).
2739 2012-03-22 Chong Yidong <cyd@gnu.org>
2741 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2743 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2744 Mark string as coming from a prefix property.
2745 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2746 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2748 2012-03-21 Chong Yidong <cyd@gnu.org>
2750 * xfaces.c (Vface_remapping_alist): Doc fix.
2752 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2754 * w32proc.c (Fw32_set_console_codepage)
2755 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2758 2012-03-20 Chong Yidong <cyd@gnu.org>
2760 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2761 to reflect default non-nil value of redisplay-dont-pause.
2763 2012-03-19 Kenichi Handa <handa@m17n.org>
2765 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2766 it fit in a valid range (Bug#11003).
2768 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2770 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2771 that is not from display property, accept the row as a "cursor
2772 row" if one of the string's character has a non-nil `cursor'
2773 property. Fixes cursor positioning when there are newlines in
2774 overlay strings, e.g. in icomplete.el. (Bug#11035)
2776 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2778 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2780 2012-03-12 Chong Yidong <cyd@gnu.org>
2782 * eval.c (inhibit_lisp_code): Rename from
2783 inhibit_window_configuration_change_hook; move from window.c.
2785 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2786 * window.c (run_window_configuration_change_hook)
2787 (syms_of_window): Callers changed.
2789 2012-03-11 Chong Yidong <cyd@gnu.org>
2791 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2793 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2795 2012-03-10 Chong Yidong <cyd@gnu.org>
2797 * frame.c (other_visible_frames): Don't assume the selected frame
2798 is visible (Bug#10955).
2800 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2802 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2804 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2806 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2807 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2810 2012-03-03 Glenn Morris <rgm@gnu.org>
2812 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2814 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2816 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2817 position past the first glyph_row that ends at ZV. (Bug#10902)
2818 (redisplay_window, next_element_from_string): Fix typos in
2820 (redisplay_window): Pass to move_it_vertically the margin in
2821 pixels, not in screen lines.
2823 2012-03-02 Glenn Morris <rgm@gnu.org>
2825 * buffer.c (buffer-list-update-hook): Doc fix.
2827 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2829 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2830 push_it before setting up the iterator for the first overlay
2831 string, even if we have an empty string loaded.
2832 (next_overlay_string): If there's an empty string on the iterator
2833 stack, pop the stack. (Bug#10903)
2835 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2837 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2838 Suggested by Stefan Monnier in
2839 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2840 * alloc.c (widen_to_Lisp_Object): New static function.
2841 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2842 and widening them to Lisp_Objects. This would work even if
2843 USE_LSB_TAG is defined and wide integers are used, which might
2844 happen in a future version of Emacs.
2846 2012-02-25 Chong Yidong <cyd@gnu.org>
2848 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2851 * xselect.c (Fx_selection_exists_p): Doc fix.
2852 (x_clipboard_manager_save_all): Print an informative message
2853 before saving to clipboard manager.
2855 2012-02-24 Chong Yidong <cyd@gnu.org>
2857 * keyboard.c (process_special_events): Handle all X selection
2858 requests in kbd_buffer, not just the next one (Bug#8869).
2860 2012-02-23 Chong Yidong <cyd@gnu.org>
2862 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2863 call when setting menu-bar-lines and tool-bar-lines parameters.
2864 (unwind_create_frame_1): New helper function.
2866 * window.c (inhibit_window_configuration_change_hook): New var.
2867 (run_window_configuration_change_hook): Obey it.
2868 (syms_of_window): Initialize it.
2870 2012-02-22 Chong Yidong <cyd@gnu.org>
2872 * xterm.c (x_draw_image_relief): Add missing type check for
2873 Vtool_bar_button_margin (Bug#10743).
2875 2012-02-21 Chong Yidong <cyd@gnu.org>
2877 * fileio.c (Vfile_name_handler_alist): Doc fix.
2879 * buffer.c (Fget_file_buffer): Protect against invalid file
2880 handler return value.
2882 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2884 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2885 when computing $valmask.
2887 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2888 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2889 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2890 It's useless in that case, and it can cause problems on hosts
2891 that allocate halves of EMACS_INT values separately.
2892 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2893 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2894 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2895 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2896 it avoids undefined behavior on hosts where shifting right by more
2897 than the word width has undefined behavior.
2899 2012-02-19 Chong Yidong <cyd@gnu.org>
2901 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2902 (Funhandled_file_name_directory, Ffile_name_as_directory)
2903 (Fdirectory_file_name, Fexpand_file_name)
2904 (Fsubstitute_in_file_name): Protect against invalid file handler
2905 return values (Bug#10845).
2907 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2909 * .gdbinit (pitx): Fix incorrect references to fields of the
2912 2012-02-17 Chong Yidong <cyd@gnu.org>
2914 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2916 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2918 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2919 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2921 2012-02-15 Chong Yidong <cyd@gnu.org>
2923 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2924 marked as special. Also, starting docstrings with * is obsolete.
2926 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2928 * gnutls.c (emacs_gnutls_write): Fix last change.
2930 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2932 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2935 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2937 * keymap.c (Fsingle_key_description): Handle char ranges.
2939 2012-02-12 Chong Yidong <cyd@gnu.org>
2941 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2942 as that creates a dangerous corner case.
2944 * window.c (Fdelete_window_internal): Invalidate the mouse
2945 highlight (Bug#9904).
2947 2012-02-12 Glenn Morris <rgm@gnu.org>
2949 * xselect.c (Fx_own_selection_internal)
2950 (Fx_get_selection_internal, Fx_disown_selection_internal)
2951 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2952 * nsselect.m (Fx_own_selection_internal)
2953 (Fx_disown_selection_internal, Fx_selection_exists_p)
2954 (Fx_selection_owner_p, Fx_get_selection_internal):
2955 Sync docs and argument specs with the xselect.c versions.
2957 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2959 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2961 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2963 * w32select.c (Fx_selection_exists_p): Sync doc string and
2964 argument list with xselect.c. (Bug#10783)
2966 * w16select.c (Fx_selection_exists_p): Sync doc string and
2967 argument list with xselect.c. (Bug#10783)
2969 2012-02-10 Glenn Morris <rgm@gnu.org>
2971 * fns.c (Fsecure_hash): Doc fix.
2973 2012-02-09 Kenichi Handa <handa@m17n.org>
2975 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2977 2012-02-07 Chong Yidong <cyd@gnu.org>
2979 * buffer.c (Fbuffer_local_variables)
2980 (buffer_lisp_local_variables): Handle unbound vars correctly;
2981 don't let Qunbound leak into Lisp.
2983 2012-02-07 Glenn Morris <rgm@gnu.org>
2985 * image.c (Fimagemagick_types): Doc fix.
2987 * image.c (imagemagick-render-type): Change it from a lisp object
2988 to an integer. Move the doc here from the lisp manual.
2989 Treat all values not equal to 0 the same.
2991 2012-02-06 Chong Yidong <cyd@gnu.org>
2993 * doc.c (store_function_docstring): Avoid applying docstring of
2994 alias to base function (Bug#2603).
2996 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2998 * .gdbinit (pp1, pv1): Remove redundant defines.
3001 2012-02-04 Chong Yidong <cyd@gnu.org>
3003 * nsterm.m: Declare a global (Bug#10694).
3005 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3007 * w32.c (get_emacs_configuration_options):
3008 Include --enable-checking, if specified, in the return value.
3010 2012-02-04 Martin Rudalics <rudalics@gmx.at>
3012 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3013 after rounding frame sizes. (Bug#9723)
3015 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3017 * keyboard.c (adjust_point_for_property): Don't position point
3018 before BEGV. (Bug#10696)
3020 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3022 Handle overflow when computing char display width (Bug#9496).
3023 * character.c (char_width): Return EMACS_INT, not int.
3024 (char_width, c_string_width): Check for overflow when
3025 computing the width; this is possible now that individual
3026 characters can have unbounded width. Problem introduced
3027 by merge from Emacs 23 on 2012-01-19.
3029 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
3031 * dbusbind.c (Fdbus_register_method): Mention the return value
3032 :ignore in the docstring.
3034 2012-02-02 Glenn Morris <rgm@gnu.org>
3036 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3038 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3039 Unconditionally set to t. (Bug#10673)
3040 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3041 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3042 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3044 2012-02-02 Kenichi Handa <handa@m17n.org>
3046 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3047 0, do not call append_composite_glyph.
3049 2012-02-02 Kenichi Handa <handa@m17n.org>
3051 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3053 (x_produce_glyphs): If the component of a composition is a null
3054 string, set it->pixel_width to 1 to avoid zero-width glyph.
3056 2012-02-01 Eli Zaretskii <eliz@gnu.org>
3058 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3059 first 2 arguments are identical. This makes inserting large
3060 output from a subprocess an order of magnitude faster on
3061 MS-Windows, where all sbrk'ed memory is always contiguous.
3063 2012-01-31 Glenn Morris <rgm@gnu.org>
3065 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3066 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3067 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3069 2012-01-29 Glenn Morris <rgm@gnu.org>
3071 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3073 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3075 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3077 2012-01-28 Chong Yidong <cyd@gnu.org>
3079 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3081 2012-01-26 Chong Yidong <cyd@gnu.org>
3083 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3085 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3086 repeat counts (Bug#10507).
3088 2012-01-26 Glenn Morris <rgm@gnu.org>
3090 * lread.c (syms_of_lread): Doc fix.
3092 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3094 * coding.c (encode_designation_at_bol): Change return value to
3097 2012-01-25 Chong Yidong <cyd@gnu.org>
3099 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3101 2012-01-21 Chong Yidong <cyd@gnu.org>
3103 * floatfns.c (Fcopysign): Make the second argument non-optional,
3104 since nil is not allowed anyway.
3106 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3108 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3109 (send_process): Likewise.
3111 2012-01-19 Martin Rudalics <rudalics@gmx.at>
3113 * window.c (save_window_save, Fcurrent_window_configuration)
3114 (Vwindow_persistent_parameters): Do not use Qstate.
3115 Rewrite doc-strings.
3117 2012-01-19 Kenichi Handa <handa@m17n.org>
3119 * character.c (char_width): New function.
3120 (Fchar_width, c_string_width, lisp_string_width):
3121 Use char_width (Bug#9496).
3123 2012-01-16 Martin Rudalics <rudalics@gmx.at>
3125 * window.c (Vwindow_persistent_parameters): New variable.
3126 (Fset_window_configuration, save_window_save): Handle persistent
3129 2012-01-14 Eli Zaretskii <eliz@gnu.org>
3131 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3132 thrashing the stack of the thread. (Bug#9087)
3134 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3136 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3138 2012-01-11 Eli Zaretskii <eliz@gnu.org>
3140 * xdisp.c (rows_from_pos_range): Handle the case where the
3141 highlight ends on a newline. (Bug#10464)
3142 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3143 he end column for display of highlight that ends on a newline
3146 2012-01-11 Glenn Morris <rgm@gnu.org>
3148 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3149 from load-path also when installation-directory is nil. (Bug#10208)
3151 2012-01-10 Glenn Morris <rgm@gnu.org>
3153 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3155 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3156 Update template values to be closer to their typical values these days.
3158 2012-01-09 Eli Zaretskii <eliz@gnu.org>
3160 * xdisp.c (rows_from_pos_range): Accept additional argument
3161 DISP_STRING, and accept any glyph in a row whose object is that
3162 string as eligible for mouse highlight. Fixes mouse highlight of
3163 display strings from overlays. (Bug#10464)
3165 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
3167 emacs: fix an auto-save permissions race condition (Bug#10400)
3168 * fileio.c (auto_saving_dir_umask): New static var.
3169 (Fmake_directory_internal): Use it.
3170 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3171 creating the directory. The old code temporarily assigns
3172 too-generous permissions to the directory.
3173 (do_auto_save_eh): Clear it.
3174 (Fdo_auto_save): Catch all errors, not just file errors, so
3175 that the var is always cleared.
3177 2012-01-07 Eli Zaretskii <eliz@gnu.org>
3179 * search.c (scan_buffer): Pass character positions to
3180 know_region_cache, not byte positions. (Bug#6540)
3182 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
3184 * w32.c (sys_rename): Report EXDEV when rename of a directory
3185 fails because the target is on another logical disk. (Bug#10284)
3187 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3189 * xterm.c (x_embed_request_focus): New function.
3191 * xterm.h: Add prototype.
3193 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3195 2012-01-05 Glenn Morris <rgm@gnu.org>
3197 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3199 2012-01-01 Eli Zaretskii <eliz@gnu.org>
3201 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3202 Load gnutls_transport_set_lowat only if GnuTLS version is below
3204 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3205 GnuTLS versions below 2.11.1.
3207 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3209 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3210 to the doc string advising against its use for altering the way
3211 windows are scrolled.
3213 2011-12-28 Kenichi Handa <handa@m17n.org>
3215 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3216 coding-system ASCII compatible only when it does not produce BOM
3217 on encoding (Bug#10383).
3219 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3221 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3223 (create_and_show_popup_menu): Always use menu_position_func for
3226 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3228 * callint.c (Fcall_interactively): Don't truncate prompt string.
3230 2011-12-23 Eli Zaretskii <eliz@gnu.org>
3232 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3233 property that ends at ZV, so that the bidi iteration could be
3234 resumed from there (after widening). (Bug#10360)
3236 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3238 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3240 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3242 * nsterm.m (x_free_frame_resources):
3243 Release f->output_data.ns->miniimage.
3244 (ns_index_color): Fix indentation. Do not retain
3245 color_table->colors[i].
3247 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3250 * nsfns.m (x_set_background_color): Assign return value from
3251 ns_index_color to face-background instead of NSColor*.
3252 (ns_implicitly_set_icon_type): Fix indentation.
3253 Change assignment in for loop to comparison.
3255 * emacs.c (ns_pool): New variable.
3256 (main): Assign ns_pool.
3257 (Fkill_emacs): Call ns_release_autorelease_pool.
3259 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3260 autorelease fdesc, release fdAttrs and tdict.
3261 (ns_get_covering_families): Release charset.
3262 (ns_findfonts): Release NSFontDescriptor created with new.
3263 (ns_uni_to_glyphs): Fix indentation.
3264 (setString): Release attrStr before assigning new value.
3266 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3268 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3270 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3271 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3273 2011-12-18 David Reitter <reitter@cmu.edu>
3275 * nsterm.m (ns_term_init): Subscribe for notifications
3276 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3277 to method trackingNotification in EmacsMenu.
3279 * nsmenu.m (trackingMenu): New variable.
3280 (trackingNotification): New method (from Aquamacs).
3281 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3282 from Aquamacs (Bug#7030).
3284 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3286 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3287 (symbol_to_nsstring): Fix indentation.
3288 (ns_symbol_to_pb): New function.
3289 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3290 (Fns_rotate_cut_buffers_internal): Remove.
3291 (Fns_store_selection_internal): Rename from
3292 Fns_store_cut_buffer_internal.
3293 (ns_get_foreign_selection, Fx_own_selection_internal)
3294 (Fx_disown_selection_internal, Fx_selection_exists_p)
3295 (Fns_get_selection_internal, Fns_store_selection_internal):
3296 Use ns_symbol_to_pb and check if return value is nil.
3297 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3298 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
3299 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3300 renamed to Sns_store_selection_internal.
3301 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3302 and remove this function.
3303 (ns_handle_selection_clear): Remove, never used.
3304 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3307 2011-12-17 Ken Brown <kbrown@cornell.edu>
3309 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3310 GID is unknown (Bug#10257).
3312 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3314 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3315 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3316 which caused a build failure on GNU/Linux IA-64. This problem was
3317 introduced by my 2011-10-07 patch.
3319 2011-12-15 Juri Linkov <juri@jurta.org>
3321 * image.c (imagemagick_error): New function. (Bug#10112)
3322 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3323 Use `imagemagick_error' where ImageMagick functions return
3325 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3328 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3330 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3331 fill background (Bug#8992).
3333 2011-12-13 Martin Rudalics <rudalics@gmx.at>
3335 * window.c (Vwindow_combination_resize)
3336 (Vwindow_combination_limit): Use t instead of non-nil in
3338 (Vrecenter_redisplay): Add first sentence of doc-string on
3340 (Frecenter): Fix doc-string typo.
3342 2011-12-11 Kenichi Handa <handa@m17n.org>
3344 * coding.c (Funencodable_char_position): Pay attention to the
3345 buffer text relocation (Bug#9389).
3347 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3349 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3350 gtk_init (Bug#10100).
3352 2011-12-10 Eli Zaretskii <eliz@gnu.org>
3354 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3355 IT->string is nil. (Bug#10263)
3357 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3359 * nsterm.h (x_free_frame_resources): Declare.
3361 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3362 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3364 * nsterm.h (ns_get_defaults_value): Declare.
3366 * nsterm.m (ns_default): Call ns_get_defaults_value.
3368 2011-12-09 Eli Zaretskii <eliz@gnu.org>
3370 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3373 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3375 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3376 that where the value of an _OBJC_* symbol points to is in the .bss
3377 section (Bug#10240).
3379 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3381 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
3382 after the loop to call ccl_driver at least once (Bug#8619).
3384 2011-12-08 Kenichi Handa <handa@m17n.org>
3386 * ftfont.c (get_adstyle_property): Fix previous change
3389 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
3391 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3392 dirs from the default value of EMACSLOADPATH (bug#10208).
3394 2011-12-07 Glenn Morris <rgm@gnu.org>
3396 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3397 installation and source directories as well. (Bug#10208)
3399 2011-12-06 Chong Yidong <cyd@gnu.org>
3401 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3403 2011-12-06 Glenn Morris <rgm@gnu.org>
3405 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3406 as an error, not just -1. (Bug#10217)
3408 2011-12-05 Chong Yidong <cyd@gnu.org>
3410 * keyboard.c (process_special_events): New function.
3411 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3413 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3415 * coding.c (encode_designation_at_bol): Don't use uninitialized
3416 local variable (Bug#9318).
3418 2011-12-05 Kenichi Handa <handa@m17n.org>
3420 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3421 return Qnil (Bug#8046, Bug#10193).
3423 2011-12-05 Kenichi Handa <handa@m17n.org>
3425 * coding.c (encode_designation_at_bol): New args charbuf_end and
3426 dst. Return the number of produced bytes. Callers changed.
3427 (coding_set_source): Return how many bytes coding->source was
3429 (coding_set_destination): Return how many bytes
3430 coding->destination was relocated.
3431 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
3432 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
3434 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3436 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3437 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3440 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3442 The following changes are to fix Bug#9318.
3444 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
3445 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3446 (encode_coding_iso_2022, encode_coding_sjis)
3447 (encode_coding_big5, encode_coding_charset): Use the above macros.
3449 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
3451 * lisp.h (process_quit_flag): Fix external declaration.
3453 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3455 Don't macro-inline non-performance-critical code.
3456 * eval.c (process_quit_flag): New function.
3457 * lisp.h (QUIT): Use it.
3459 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3461 * nsfns.m (get_geometry_from_preferences): New function.
3462 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3464 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3466 * emacs.c (Qkill_emacs): Define.
3467 (syms_of_emacs): Initialize it.
3468 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3469 Qquit_flag to `kill-emacs' instead.
3470 (quit_throw_to_read_char): Add parameter `from_signal'.
3471 All callers changed. Call Fkill_emacs if requested and safe.
3472 * lisp.h (QUIT): Call Fkill_emacs if requested.
3474 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3476 * widget.c (update_wm_hints): Return if wmshell is null.
3477 (widget_update_wm_size_hints): New function.
3479 * widget.h (widget_update_wm_size_hints): Declare.
3481 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3482 widget_update_wm_size_hints (Bug#10104).
3484 2011-12-03 Eli Zaretskii <eliz@gnu.org>
3486 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3487 before a newline, prepare the bidi iterator for consuming the
3488 newline, and keep the current paragraph direction. (Bug#10183)
3489 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
3491 2011-12-02 Juri Linkov <juri@jurta.org>
3493 * search.c (Fword_search_regexp): New Lisp function created from
3494 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3495 (Fword_search_backward, Fword_search_forward)
3496 (Fword_search_backward_lax, Fword_search_forward_lax):
3497 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3498 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3500 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3502 * fileio.c (Finsert_file_contents): Move after-change-function call
3503 to before the "handled:" label, since all "goto handled" appear in
3504 cases where the *-change-functions have already been properly called
3507 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3509 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3510 waiting for input. (Bug#10169)
3512 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3514 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3515 verifies glyph row's hash code--we have just reallocated the
3516 glyphs, so their contents can be complete garbage. (Bug#10164)
3518 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
3520 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3522 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3524 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3525 attributes are tested _before_ calling verify_row_hash, to protect
3526 against GCC re-ordering of the tests. (Bug#10164)
3528 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3530 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3532 * xterm.c (handle_one_xevent): Only set async_visible and friends
3533 if net_wm_state_hidden_seen is non-zero (Bug#10002)
3534 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
3535 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3537 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3539 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3540 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3541 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3542 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3543 All uses changed to use GCPRO1 etc.
3544 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3545 Revert to old implementation (i.e., before 2011-03-11).
3547 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3549 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3550 of scroll runs so as to avoid assigning disabled bogus rows and
3551 unnecessary graphics copy operations.
3553 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3555 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3556 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3557 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3558 (malloc, free, realloc, calloc): Redirect to e_* only when
3561 * lisp.h (GCTYPEBITS): Move before first use.
3562 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3563 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3564 this macro definition.
3566 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3569 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3571 * gtkutil.c (xg_create_frame_widgets):
3572 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3573 present with Gtk+ 2.0.
3575 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3577 * fileio.c (Finsert_file_contents): Undo previous change; see
3578 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3580 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3582 Rename locals to avoid shadowing.
3583 * fileio.c (Finsert_file_contents):
3584 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3585 * process.c (wait_reading_process_output):
3586 Rename inner 'proc' to 'p' to avoid shadowing.
3587 Indent for consistency with usual Emacs style.
3589 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3591 * xdisp.c (redisplay_window): If cursor row is not fully visible
3592 after recentering, and scroll-conservatively is set to a large
3593 number, scroll window by a few more lines to make the cursor fully
3594 visible and out of scroll-margin. (Bug#10105)
3595 (start_display): Don't move to the next line if the display should
3596 start at a newline that is part of a display vector or an overlay
3599 2011-11-24 Juri Linkov <juri@jurta.org>
3601 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3602 after the `MagickPingImage' call. (Bug#10112)
3604 2011-11-23 Chong Yidong <cyd@gnu.org>
3606 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3608 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3610 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3611 making another buffer current. (Bug#10114)
3613 2011-11-23 Glenn Morris <rgm@gnu.org>
3615 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3617 2011-11-23 Chong Yidong <cyd@gnu.org>
3619 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3620 using it (Bug#5984).
3622 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3624 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3625 and header-lines, as they don't have one computed for them.
3628 * .gdbinit (prow): Make displayed values more self-explaining.
3629 Add row's hash code.
3631 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3633 * process.c (wait_reading_process_output): Fix asynchrounous
3634 GnuTLS socket handling on some versions of the GnuTLS library.
3635 (wait_reading_process_output): Add comment and URL.
3637 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3639 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3641 2011-11-21 Chong Yidong <cyd@gnu.org>
3643 * window.c (Fnext_window, Fprevious_window): Doc fix.
3645 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3647 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3649 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3651 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3653 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3655 * window.c (Fset_window_combination_limit): Rename argument
3657 (Vwindow_combination_limit): Remove "status" from doc-string.
3659 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3661 * m/ibms390.h: Remove.
3662 * m/ibms390x.h: Don't include "ibms390.h".
3664 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3666 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3667 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3669 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3671 * casetab.c (Fset_case_table):
3672 * charset.c (Fcharset_after): Fix typos.
3674 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3676 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3677 Otherwise, valgrind does not work on some platforms.
3678 Problem reported by Andreas Schwab in
3679 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3680 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3681 is set, removing the need for VIRT_ADDRESS_VARIES.
3682 (PURE_P): Use a more-efficient implementation that needs just one
3683 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3684 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3685 to 4 (xorl, subq, cmpq, setbe).
3686 * alloc.c (pure): Always extern now, since that's the
3687 VIRT_ADDR_VARIES behavior.
3688 (PURE_POINTER_P): Use a single comparison, not two, for
3689 consistency with the new puresize.h.
3690 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3691 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3692 Remove VIRT_ADDR_VARIES no longer needed.
3694 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3696 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3697 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3698 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3699 behave as if the cursor position were at the window margin.
3701 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3702 and the cursor position is out of bounds, behave as if the cursor
3703 position were at the window margin. (Bug#10075)
3705 2011-11-18 Chong Yidong <cyd@gnu.org>
3707 * window.c (Fwindow_combination_limit): Make first argument
3708 non-optional, since it is meaningless for live windows like the
3711 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3713 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3715 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3717 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3718 (graft_intervals_into_buffer): Simplify.
3720 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3722 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3723 hash values of the two rows.
3724 (copy_row_except_pointers): Preserve the used[] arrays and the
3725 hash values of the two rows. (Bug#10035)
3726 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3728 * xdisp.c (row_hash): New function, body extracted from
3729 compute_line_metrics.
3730 (compute_line_metrics): Call row_hash, instead of computing the
3733 * dispnew.c (verify_row_hash): Call row_hash for computing the
3734 hash code of a row, instead of duplicating code from xdisp.c.
3736 * dispextern.h (row_hash): Add prototype.
3738 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3740 * frame.c (delete_frame): Don't delete the terminal when the last
3741 X frame is closed if emacs is built with GTK toolkit.
3743 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3745 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3747 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3749 * window.c (Vwindow_splits): Rename to
3750 Vwindow_combination_resize. Suggested by Juri Linkov.
3751 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3754 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3756 * nsfns.m (Fns_font_name):
3757 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3759 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3761 * window.h (window): Rename slot "nest" to "combination_limit".
3762 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3763 (Fset_window_nest): Rename to Fset_window_combination_limit.
3764 (Vwindow_nest): Rename to Vwindow_combination_limit.
3765 (recombine_windows, make_parent_window, make_window)
3766 (Fsplit_window_internal, saved_window)
3767 (Fset_window_configuration, save_window_save): Rename all
3768 occurrences of window_nest to window_combination_limit.
3770 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3772 * image.c (imagemagick_load_image): Fix typo.
3774 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3776 * xdisp.c (display_line): Move the call to
3777 highlight_trailing_whitespace before the call to
3778 compute_line_metrics, since the latter needs to see the final
3779 faces of all the glyphs to compute ROW's hash value.
3780 Fixes assertion violations in row_equal_p. (Bug#10035)
3782 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3784 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3785 just return (bug#10044).
3787 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3789 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3790 with user-defined heap size. Bump the default size of the temacs
3791 heap to 27MB, to avoid memory warning when running temacs.
3792 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3794 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3795 current_matrix and desired_matrix. (Bug#9990)
3796 (verify_row_hash) [XASSERTS]: New function.
3797 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3798 that the hash value of glyph rows is correct.
3800 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3802 * window.h (window): Remove splits slot.
3803 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3804 (Fdelete_other_windows_internal, make_parent_window)
3805 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3806 (Fset_window_configuration, save_window_save): Don't deal with
3807 split status of windows.
3808 (saved_window): Remove splits slot.
3809 (Vwindow_splits): Rewrite doc-string.
3811 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3813 * xfns.c (unwind_create_frame):
3814 * nsfns.m (unwind_create_frame):
3815 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3816 Vframe_list (Bug#9999).
3818 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3820 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3822 2011-11-11 Kenichi Handa <handa@m17n.org>
3824 * callproc.c (Fcall_process): Set the member dst_multibyte of
3827 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3829 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3830 avoid a crash (bug#9496).
3832 2011-11-09 Chong Yidong <cyd@gnu.org>
3834 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3835 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3837 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3839 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3841 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3843 Avoid some portability problems by eschewing 'extern inline' functions.
3844 The trivial performance wins aren't worth the portability hassles; see
3845 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3847 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3848 (window_box_width, window_box_left, window_box_left_offset)
3849 (window_box_right, window_box_right_offset): Undo previous change,
3850 by removing the "extern"s.
3851 * intervals.c (adjust_intervals_for_insertion)
3852 (adjust_intervals_for_deletion): Undo previous change,
3853 making these static again.
3854 (offset_intervals, temp_set_point_both, temp_set_point)
3855 (copy_intervals_to_string): No longer inline.
3856 * xdisp.c (window_text_bottom_y, window_box_width)
3857 (window_box_height, window_box_left_offset)
3858 (window_box_right_offset, window_box_left, window_box_right)
3859 (window_box): No longer inline.
3861 2011-11-08 Chong Yidong <cyd@gnu.org>
3863 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3864 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3865 Signal an error if not a live window.
3866 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3867 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3869 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3871 * lisp.h (syms_of_abbrev): Remove declaration.
3872 Reported by CHENG Gao <chenggao@royau.me>.
3874 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3876 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3877 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3878 of temacs in GUI mode.
3880 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3882 * window.h: Declare delete_all_child_windows instead of
3883 delete_all_subwindows.
3884 * window.c (Fwindow_nest, Fset_window_nest)
3885 (Fset_window_new_total, Fset_window_new_normal)
3886 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3887 (delete_all_subwindows): Rename to delete_all_child_windows.
3888 (Fdelete_other_windows_internal, Fset_window_configuration):
3889 Call delete_all_child_windows instead of delete_all_subwindows.
3890 * frame.c (delete_frame): Call delete_all_child_windows instead
3891 of delete_all_subwindows.
3893 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3895 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3896 This is also needed for porting to any host where GC_MARK_STACK is
3897 not GC_MAKE_GCPROS_NOOPS.
3898 (which_symbols): Use it.
3900 2011-11-07 Kenichi Handa <handa@m17n.org>
3902 * coding.c (coding_set_destination): Check coding->src_pos only
3903 when coding->src_object is a buffer (bug#9910).
3905 * process.c (send_process): Set the member src_multibyte of coding
3906 to 0 (bug#9911) when sending a unibyte text.
3908 * callproc.c (Fcall_process): Set the member src_multibyte of
3909 process_coding to 0 (bug#9912).
3911 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3913 * xmenu.c (cleanup_widget_value_tree): New function.
3914 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3915 calling free_menubar_widget_value_tree directly (Bug#9830).
3917 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3919 Fix some portability problems with 'inline'.
3920 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3921 (window_box_width, window_box_left, window_box_left_offset)
3922 (window_box_right, window_box_right_offset): Declare extern.
3923 Otherwise, these inline functions do not conform to C99 and
3924 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3925 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3926 * intervals.c (adjust_intervals_for_insertion)
3927 (adjust_intervals_for_deletion): Now extern, because otherwise the
3928 extern inline functions 'offset_intervals' couldn't refer to it.
3929 (static_offset_intervals): Remove.
3930 (offset_intervals): Rewrite using the old contents of
3931 static_offset_intervals. The old version didn't conform to C99
3932 because an extern inline function contained a reference to an
3933 identifier with static linkage.
3935 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3937 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3940 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3942 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3943 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3944 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3945 return Qleft_to_right.
3947 2011-11-06 Chong Yidong <cyd@gnu.org>
3949 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3950 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3951 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3952 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3953 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3954 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3955 (Fwindow_vscroll): Doc fix.
3956 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3957 argument, since it makes no sense to pass a live window and for
3958 consistency with window-child.
3960 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3962 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3965 2011-11-05 Jason Rumney <jasonr@gnu.org>
3967 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3968 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3970 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3971 bitwise arithmetic preventing use of unicode-sip and non-truetype
3974 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3976 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3979 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3980 initialization code to keep similarity to xfns.c after changes
3983 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3985 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3986 (unwind_create_frame): New function (Bug#9943).
3987 (Fx_create_frame): Restructure code to be more similar to the one in
3988 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3989 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3990 Move terminal->reference_count++ just before making the frame official
3993 * nsterm.m (x_free_frame_resources): New function.
3994 (x_destroy_window): Move code to x_free_frame_resources.
3996 * xfns.c (unwind_create_frame): Fix comment.
3997 (Fx_create_frame, x_create_tip_frame):
3998 Move terminal->reference_count++ just before making the frame
3999 official. Move initialization of image_cache_refcount and
4000 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4002 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4004 Support MSVC build with newer versions of Visual Studio.
4005 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4006 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4009 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4010 which are not supported by MSVC.
4011 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4012 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4014 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4016 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4018 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4020 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
4022 Support MSVC build with newer versions of Visual Studio.
4023 * w32.c: Don't include w32api.h for MSVC.
4024 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4026 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4027 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4028 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4029 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4031 (alloca) [_MSC_VER]: Define to _alloca.
4033 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4035 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4037 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4039 * xdisp.c (note_mouse_highlight): If either of
4040 previous/next-single-property-change returns nil, treat that as
4041 the beginning or the end of the buffer. (Bug#9955)
4043 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4045 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
4046 label is not null (Bug#9951).
4047 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4050 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4052 * window.c (Fwindow_body_size): Mention in the doc string that the
4053 return value is in frame's canonical units. (Bug#9949)
4055 2011-11-03 Eli Zaretskii <eliz@gnu.org>
4057 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4059 * w32fns.c (unwind_create_frame): If needed, free the glyph
4060 matrices of the partially constructed frame. (Bug#9943)
4061 * xfns.c (unwind_create_frame): Likewise.
4063 2011-11-01 Eli Zaretskii <eliz@gnu.org>
4065 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4066 Don't stop backward scan on the continuation glyph, even though
4067 its CHARPOS is positive.
4068 (mouse_face_from_buffer_pos, note_mouse_highlight):
4069 Rename cover_string to disp_string.
4071 2011-11-01 Martin Rudalics <rudalics@gmx.at>
4073 * window.c (temp_output_buffer_show): Don't use
4074 Vtemp_buffer_show_specifiers.
4075 (Vtemp_buffer_show_specifiers): Remove unused variable.
4077 2011-10-30 Eli Zaretskii <eliz@gnu.org>
4079 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4080 past the beginning of the current glyph matrix.
4082 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
4084 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4085 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4086 HAVE_GTK3 (Bug#9869).
4088 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4089 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4091 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4093 * xterm.c: Declare x_handle_net_wm_state to return int.
4094 (handle_one_xevent): Check if we are iconified but don't have
4095 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4096 (get_current_wm_state): Return non-zero if not hidden,
4097 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4098 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4099 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4100 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4102 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4104 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4105 so that this new function doesn't get optimized away by a
4106 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4108 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4110 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4112 2011-10-29 Eli Zaretskii <eliz@gnu.org>
4114 Fix the `xbytecode' command.
4115 * .gdbinit (xprintbytestr): New command.
4116 (xwhichsymbols): Rename from `which'; all callers changed.
4117 (xbytecode): Print the byte-code string as well.
4119 2011-10-29 Kim Storm <storm@cua.dk>
4121 * alloc.c (which_symbols): New function.
4123 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4125 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4128 2011-10-29 Glenn Morris <rgm@gnu.org>
4130 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4131 Not clear what it was for, and it causes various bugs. (Bug#9839)
4133 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4135 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4136 possible random value that matches one of those tested as
4137 condition to clear the mouse face.
4139 2011-10-28 Chong Yidong <cyd@gnu.org>
4141 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4143 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4145 * window.c (make_window): Initialize phys_cursor_on_p.
4147 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4149 * lisp.h (struct Lisp_Symbol): Update comments.
4151 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
4153 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4155 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4157 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4158 <oslsachem@gmail.com> for helping to debug this.
4160 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4161 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4162 (g_b_init_get_glyph_outline_w): New static variables.
4163 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4164 (GetGlyphOutlineW_Proc): New typedefs.
4165 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
4166 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4168 (w32font_open_internal, compute_metrics):
4169 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
4170 instead of calling the "wide" APIs directly.
4172 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4174 * w32.h (syms_of_w32font): Add prototype.
4176 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4178 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4179 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4180 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4181 (Fmove_to_window_line): Doc fix.
4183 2011-10-27 Chong Yidong <cyd@gnu.org>
4185 * process.c (make_process): Set gnutls_state to NULL.
4187 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4188 non-NULL, regardless of GNUTLS_INITSTAGE.
4189 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4190 an error. Set process slots as soon as we allocate them.
4192 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4194 2011-10-27 Chong Yidong <cyd@gnu.org>
4196 * gnutls.c (emacs_gnutls_deinit): New function.
4197 Deallocate credentials structures as well as calling gnutls_deinit.
4198 (Fgnutls_deinit, Fgnutls_boot): Use it.
4200 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4201 (deactivate_process): Call emacs_gnutls_deinit.
4203 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4205 * image.c (x_create_x_image_and_pixmap):
4206 * w32.c (sys_rename, w32_delayed_load):
4207 * w32font.c (fill_in_logfont):
4208 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4210 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
4212 * w32fns.c (w32_default_color_map): New function,
4213 extracted from Fw32_default_color_map.
4214 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
4216 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4218 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4220 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4222 * keyboard.c (test_undefined): New function (bug#9751).
4223 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4225 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4227 * sysdep.c (init_sys_modes): Fix the check for the controlling
4228 terminal (Bug#6649).
4230 2011-10-20 Eli Zaretskii <eliz@gnu.org>
4232 * dispextern.h (struct bidi_it): New member next_en_type.
4234 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4235 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4236 current character, check also for next_en_type being WEAK_EN.
4237 (bidi_resolve_weak): Don't enter the expensive loop if the current
4238 position is before next_en_pos. Record the bidi type of the first
4239 non-ET, non-BN character we find, in addition to its position.
4240 (bidi_level_of_next_char): Invalidate next_en_type when
4241 next_en_pos is over-stepped.
4243 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4245 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4246 * editfns.c: Rewrite current-time-zone so that it invokes
4247 the equivalent of (format-time-string "%Z") to get the time zone name.
4248 This fixes a bug when the time zone name contains characters that
4249 need converting from the system time locale to Emacs internal format.
4250 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4251 that patch fixed format-time-string to do the conversion, but
4252 I forgot to fix current-time-zone.
4253 (format_time_string): New function, containing most of
4254 what Fformat_time_string used to contain.
4255 (Fformat_time_string): Rewrite in terms of format_time_string.
4256 This doesn't change this function's behavior.
4257 (current-time-zone): Rewrite to use format_time_string.
4258 This fixes the bug reported by Michael Schierl in
4259 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4260 Jason Rumney's 2007-06-07 change worked around this bug, but
4262 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4264 2011-10-19 Eli Zaretskii <eliz@gnu.org>
4266 * xdisp.c (start_display): If the character at POS is displayed
4267 via a display vector, reset IT->current.dpvec_index to zero.
4268 (try_window_reusing_current_matrix): If a line ends in a display
4269 vector or the next line starts in a display vector, continue
4270 redrawing the window even though the character position of
4271 start_row was reached.
4274 2011-10-18 Chong Yidong <cyd@gnu.org>
4276 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4277 with nobreak-char-display too.
4279 2011-10-18 Eli Zaretskii <eliz@gnu.org>
4281 Fix part 3 of bug#9771.
4282 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4283 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4284 non-neutral characters if the current character is a paragraph
4285 separator (a.k.a. Newline). This avoids running the same
4286 expensive loop twice, once when we consume the preceding newline
4287 and the other time when the line actually needs to be displayed.
4288 Avoid the loop when we see neutrals on the base embedding level
4289 following a character whose directionality is the same as the
4290 paragraph's. This avoids running the expensive loop when a line
4291 ends in a long sequence of neutrals, like control characters.
4292 Add assertion against STRONG_AL type. Slightly rearrange code
4293 that determines the type of a neutral given the first non-neutral
4295 (bidi_level_of_next_char): Set next_en_pos to zero when
4296 invalidating its info.
4298 2011-10-17 Eli Zaretskii <eliz@gnu.org>
4300 * xdisp.c (push_display_prop): Determine whether to record string
4301 or buffer position by IT->string, not by IT->method. Allow
4302 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
4303 (move_it_vertically_backward): Don't look for character position
4304 immediately after the newline when in a continuation line.
4307 2011-10-15 Martin Rudalics <rudalics@gmx.at>
4309 * window.c (coordinates_in_window): Rewrite and delabelize
4310 vertical border check. (Bug#5357) (Bug#9618)
4312 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4314 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4315 errors in XSetWindowBorder (bug#9310).
4317 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4319 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4320 avoid crash when xmalloc overrun checking is enabled.
4322 2011-10-13 Eli Zaretskii <eliz@gnu.org>
4324 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4325 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4326 cursor motion with <left> and <right> arrow keys.
4328 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4329 some callers set that themselves.
4331 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4333 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4334 display string and the previous row comes from the same string and
4335 is empty. (Bug#9739) (Bug#9738)
4337 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4339 * doc.c (get_doc_string): Encode file name (bug#9735).
4341 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4343 * bidi.c (bidi_level_of_next_char):
4344 * xdisp.c (get_visually_first_element): Remove old incorrect
4345 comments regarding the Unicode Line Separator character.
4347 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4349 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4351 * alloc.c (Fgc_status): Do not access beyond zombies array
4352 boundary if nzombies > MAX_ZOMBIES.
4353 * alloc.c (dump_zombies): Add missing format specifier.
4355 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4357 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4358 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4360 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4361 Some packages use them to denote characters with modifiers.
4363 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4365 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4366 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4367 matching a pp-number. Rename parameter var to var1.
4369 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4371 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4373 2011-10-08 Glenn Morris <rgm@gnu.org>
4375 * callint.c (Fcall_interactively): Give a more explicit error for the
4376 'c' case with a non-character input. (Bug#8479)
4378 2011-10-08 Eli Zaretskii <eliz@gnu.org>
4380 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4382 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4383 lines that are hscrolled on the left.
4385 * dispnew.c (buffer_posn_from_coords): Account for a possible
4386 presence of header-line. (Bug#4426)
4388 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4390 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4391 Don't advertise functionality which we discourage or doesn't work.
4393 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4395 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4396 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4397 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4398 this makes Emacs dump core during garbage collection on rare
4399 occasions. sizeof is obviously inferior to offsetof here, so
4400 stick with offsetof.
4401 (GC_POINTER_ALIGNMENT): New macro.
4402 (mark_memory): Omit 3rd (offset) arg; caller changed.
4403 Don't assume EMACS_INT alignment is the same as pointer alignment.
4405 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4407 * keyboard.c (read_key_sequence_remapped): New var.
4408 (read_key_sequence): Compute remapping in the right buffer.
4409 (command_loop_1): Use read_key_sequence's remapping directly.
4411 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4413 * dired.c (file_name_completion): Don't expand file name.
4414 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4415 before checking file name handler.
4417 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4418 they've been requested explicitly (bug#9591).
4420 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
4422 * keymap.c (Fsingle_key_description): Use make_specified_string
4423 instead of build_string to build string from push_key_description.
4426 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4428 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4429 This fixes a Y2038 bug on 64-bit hosts.
4430 * buffer.c (reset_buffer):
4431 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4432 (Fclear_buffer_auto_save_failure):
4433 Use 0, not -1, to represent an unset failure time, since time_t
4434 might not be signed.
4436 Remove dependency on glibc malloc internals.
4437 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4438 Move back here from lisp.h, but with their new implementations.
4439 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4440 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4441 * charset.c (charset_table_init): New static var.
4442 (syms_of_charset): Use it instead of xmalloc. This removes a
4443 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4444 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4445 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4446 Move back to alloc.c.
4447 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4448 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4450 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4452 * nsterm.m (windowDidResize): Call x_set_window_size only when
4453 ns_in_resize is true. Otherwise set pixelwidth/height and
4454 call change_frame_size (Bug#9628).
4456 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4458 Port --enable-checking=all to Fedora 14 x86-64.
4459 * charset.c (syms_of_charset): Also account for glibc malloc's
4460 internal overhead when calculating the initial malloc maximum.
4462 Port --enable-checking=all to Fedora 14 x86.
4463 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4465 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4466 (overrun_check_realloc, overrun_check_free):
4467 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4468 That way, xmalloc returns a properly-aligned pointer even if
4469 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4470 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4471 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4472 into account when calculating the initial malloc maximum.
4473 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4474 Move here from alloc.c, so that charset.c can use it too.
4475 Properly align; the old code wasn't right for common 32-bit hosts
4476 when configured with --enable-checking=all.
4477 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4478 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4480 2011-09-29 Eli Zaretskii <eliz@gnu.org>
4482 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
4485 2011-09-28 Eli Zaretskii <eliz@gnu.org>
4487 * xdisp.c (compute_display_string_end): If there's no display
4488 string at CHARPOS, return -1.
4490 * bidi.c (bidi_fetch_char): When compute_display_string_end
4491 returns a negative value, treat the character as a normal
4492 character not covered by a display string. (Bug#9624)
4494 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
4496 * lread.c (Fread_from_string): Fix typo in docstring.
4498 2011-09-27 Eli Zaretskii <eliz@gnu.org>
4500 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4501 newline, reseat the iterator instead of bidi-iterating there one
4502 character at a time. (Bug#9610)
4503 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4504 TO_CHARPOS if the bidi iterator is at base embedding level.
4506 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4508 * lread.c (readevalloop): Use correct code for NBSP.
4509 (read1): Likewise. (Bug#9608)
4511 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
4513 * dbusbind.c (Fdbus_register_signal): When service is not
4514 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4516 2011-09-25 Glenn Morris <rgm@gnu.org>
4518 * buffer.c (truncate-lines): Doc fix.
4520 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
4522 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4523 (Fset_window_next_buffers): Doc fix.
4525 2011-09-24 Glenn Morris <rgm@gnu.org>
4527 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4529 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4531 Fix minor problems found by static checking.
4532 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
4533 * indent.c (Fvertical_motion): Fix == vs = typo.
4535 2011-09-24 Eli Zaretskii <eliz@gnu.org>
4537 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4538 Default value is now t. Doc fix.
4540 * indent.c (Fvertical_motion): Compute and apply the overshoot
4541 logic when moving up, not only when moving down. Fix the
4542 confusing name and values of the it_overshoot_expected variable;
4543 logic changes accordingly. (Bug#9254) (Bug#9549)
4545 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4546 CHARPOS is covered by a display string which includes newlines.
4547 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4548 is covered by a display string with embedded newlines.
4550 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4552 * dbusbind.c (Fdbus_register_signal): Add match rule to
4553 Vdbus_registered_objects_table. (Bug#9581)
4554 (Fdbus_register_method, Vdbus_registered_objects_table):
4557 2011-09-24 Jim Meyering <meyering@redhat.com>
4559 do not ignore write error for any output size
4560 The previous change was incomplete.
4561 While it makes emacs --batch detect the vast majority of stdout
4562 write failures, errors were still ignored whenever the output size is
4563 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4564 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4565 && echo FAIL: ignored write error
4566 FAIL: ignored write error
4567 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4568 && echo FAIL: ignored write error
4569 FAIL: ignored write error
4570 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4572 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4574 * emacs.c (Fkill_emacs): In noninteractive mode exit
4575 non-successfully if a write error occurred on stdout. (Bug#9574)
4577 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4579 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4582 * dispextern.h (struct it): Update the comment documenting what
4585 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4587 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4588 a display string, extend search for cursor position to end of row.
4589 (find_row_edges): If the row ends in a newline from a display
4590 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4591 Handle the case of a display string with multiple newlines.
4592 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4593 non-empty line. Fixes confusing cursor motion with arrow keys at
4594 the beginning of a line that starts with whitespace.
4596 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4598 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4601 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4603 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4606 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4608 * xdisp.c (display_line): Record maximum and minimum buffer
4609 positions even if no glyphs were produced (e.g., by a zero-width
4610 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4611 buffer positions that will be removed from the glyph row because
4613 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4614 column is beyond frame width: don't subtract 1 "pixel" when
4615 computing width of the stretch.
4616 (reseat_at_next_visible_line_start): Undo the change made on
4617 2011-09-17 that saved paragraph information and restored it after
4618 the call to `reseat'. (Bug#9545)
4620 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4622 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4623 and turn window cursor on if cleared (Bug#9415).
4625 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4627 * search.c (boyer_moore): Take unibyte characters from pattern
4628 literally. (Bug#9458)
4630 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4632 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4634 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4636 Fix minor problem found by static checking.
4637 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4638 initialized, to pacify gcc -Wuninitialized.
4640 * fileio.c: Report proper errno when syscall falls.
4641 (Finsert_file_contents): Save and restore errno,
4642 so that report_file_error outputs the correct diagnostic.
4643 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4645 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4647 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4649 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4651 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4652 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4654 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4656 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4657 about the current paragraph and restore it after the call to reseat.
4659 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4660 (bidi_find_paragraph_start): Search back for paragraph beginning
4661 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4662 (bidi_move_to_visually_next): Only trigger paragraph-related
4663 computations when the last character is a newline or at EOB, not
4664 just any NEUTRAL_B. (Bug#9470)
4666 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4667 truncated lines if point is covered by a display string. (Bug#9524)
4669 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4671 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4672 (cons_to_x_long): New function.
4673 (lisp_data_to_selection_data): Use it. Correct the test for
4674 short-versus-long data; it was negated. Break out of vector
4675 loop, for efficiency, when a long datum is discovered.
4677 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4679 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4681 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4683 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4684 GCC PR/17406) by declaring this function with external scope.
4686 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4688 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4689 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4691 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4693 * editfns.c (Fformat): Correctly handle text properties on "%%".
4695 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4697 * xterm.c (x_draw_composite_glyph_string_foreground):
4698 * w32term.c (x_draw_composite_glyph_string_foreground):
4699 * term.c (encode_terminal_code):
4700 * composite.c (composition_update_it, get_composition_id):
4701 * xdisp.c (get_next_display_element)
4702 (fill_composite_glyph_string): Add comments about special meaning
4703 of TAB characters in a composition.
4705 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4707 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4708 This occurs when processing a multibyte format.
4709 Problem reported by Wolfgang Jenker.
4711 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4713 * xdisp.c (try_cursor_movement): Only check for exact match if
4714 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4716 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4718 Remove unused external symbols.
4719 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4720 * xdisp.c (calc_pixel_width_or_height): Now static.
4721 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4722 * indent.c (check_display_width):
4723 * w32term.c: Fix comment to match code.
4724 * xterm.c, xterm.h (x_catching_errors): Remove.
4726 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4728 * xselect.c: Use signed conversions more consistently (Bug#9498).
4729 (selection_data_to_lisp_data): Assume incoming selection data are
4730 signed integers, not unsigned. This is to be consistent with
4731 outgoing selection data, which was modified to use signed integers
4732 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4733 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4734 expects long, not unsigned long.
4736 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4738 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4739 computation of loop end. Reported by Johan Bockgård
4742 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4744 * frame.c (Fother_visible_frames_p): Function deleted.
4746 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4748 * indent.c (compute_motion): Process display vector front to back
4749 rather than the other way around. (Bug#2496)
4751 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4753 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4755 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4757 * minibuf.c (Fread_from_minibuffer): Doc fix.
4759 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4761 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4762 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4764 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4766 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4767 value for non-existent files.
4769 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4771 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4772 set its "size" to -1. This will set the modtime_size field of
4773 the corresponding buffer to -1, which is what
4774 verify-visited-file-modtime expects for files that do not exist.
4777 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4779 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4781 * lisp.h: ... from here. push_key_description is no longer
4782 defined in keyboard.c, so its declaration should not be in
4783 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4784 logically belongs with push_key_description.
4786 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4788 * buffer.h: Include <sys/types.h> instead of <time.h>.
4789 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4790 Problem reported by Herbert J. Skuhra.
4792 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4794 * xml.c (parse_region): Make the parsing work for
4795 non-comment-starting XML files again (bug#9144).
4797 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4799 * image.c (gif_load): Fix calculation of bottom and right corner.
4802 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4804 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4805 redisplay in small windows.
4807 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4809 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4811 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4813 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4814 Operate on live windows only.
4816 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4818 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4820 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4822 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4823 only under bidi iteration.
4825 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4827 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4829 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4831 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4832 Without this fix, the command to link temacs failed due to an
4833 undefined symbol __builtin_isnan. This is because
4834 /usr/include/iso/math_c99.h #defines isnan(x) to
4835 __builtin_isnan(x), but the bundled gcc, which identifies itself
4836 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4838 * floatfns.c (isnan): #undef, and then #define to a clone of
4840 (Fisnan): Always define, since it's always available now.
4841 (syms_of_floatfns): Always define isnan at the Lisp level.
4843 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4845 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4847 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4849 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4850 The previous code assumed that file offsets (off_t values) fit in
4851 EMACS_INT variables, which is not true on typical 32-bit hosts.
4852 The code messed up by falsely reporting buffer overflow in cases
4853 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4854 when "big" contains more than 2**29 bytes, even though this
4855 inserts just one byte and does not overflow the buffer.
4856 (Finsert_file_contents): Store file offsets as off_t
4857 values, not as EMACS_INT values. Check for overflow when
4858 converting between EMACS_INT and off_t. When checking for
4859 buffer overflow or for overlap, take the offsets into account.
4860 Don't use EMACS_INT for small values where int suffices.
4861 When checking for overlap, fix a typo: ZV was used where
4862 ZV_BYTE was intended.
4863 (Fwrite_region): Don't assume off_t fits into 'long'.
4864 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4866 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4868 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4870 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4872 sprintf-related integer and memory overflow issues (Bug#9412).
4874 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4875 (esprintf, exprintf, evxprintf): New functions.
4876 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4877 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4878 (modify_event_symbol): Do not assume that the length of
4879 name_alist_or_stem is safe to alloca and fits in int.
4880 (Fexecute_extended_command): Likewise for function name and binding.
4881 (Frecursion_depth): Wrap around reliably on integer overflow.
4882 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4883 since some callers pass EMACS_INT values.
4884 (Fsingle_key_description): Don't crash if symbol name contains more
4885 than MAX_ALLOCA bytes.
4886 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4887 (get_minibuffer): Arg is now EMACS_INT, not int.
4888 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4889 (esprintf, exprintf, evxprintf): New decls.
4890 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4892 * dbusbind.c (signature_cat): New function.
4893 (xd_signature, Fdbus_register_signal):
4894 Do not overrun buffer; instead, report string overflow.
4896 * dispnew.c (add_window_display_history): Don't overrun buffer.
4897 Truncate instead; this is OK since it's just a log.
4899 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4900 even if the time zone offset is outlandishly large.
4901 Don't mishandle offset == INT_MIN.
4903 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4904 when creating daemon; the previous buffer-overflow check was incorrect.
4906 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4907 which has the guts of the old verror function.
4909 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4910 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4912 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4913 (font_unparse_xlfd): Don't blindly alloca long strings.
4914 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4915 fits in int, when using sprintf. Use single snprintf to count
4916 length of string rather than counting it via multiple sprintfs;
4917 that's simpler and more reliable.
4918 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4919 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4920 sprintf, in case result does not fit in int.
4922 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4923 (fontset_from_font): Print it.
4925 * frame.c (tty_frame_count): Now printmax_t, not int.
4926 (make_terminal_frame, set_term_frame_name): Print it.
4927 (x_report_frame_params): In X, window IDs are unsigned long,
4928 not signed long, so print them as unsigned.
4929 (validate_x_resource_name): Check for implausibly long names,
4930 and don't assume name length fits in 'int'.
4931 (x_get_resource_string): Don't blindly alloca invocation name;
4932 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4935 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4936 (xg_check_special_colors, xg_set_geometry):
4937 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4939 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4940 Use esprintf, not sprintf, in case result does not fit in int.
4942 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4943 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4944 it as a large positive number.
4945 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4946 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4948 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4949 in case result does not fit in int.
4951 * print.c (float_to_string): Detect width overflow more reliably.
4952 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4953 buffer overrun. Don't assume list length fits in 'int'. Treat
4954 print length of 0 as 0, not as infinity; to be consistent with other
4955 uses of print length in this function. Don't overflow print length
4956 index. Don't assume hash table size fits in 'long', or that
4957 vectorlike size fits in 'unsigned long'.
4959 * process.c (make_process): Use printmax_t, not int, to format
4960 process-name gensyms.
4962 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4964 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4965 to avoid potential buffer overrun.
4967 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4968 if X resource line is longer than 512 bytes.
4970 * xfns.c (x_window): Make sprintf buffer a bit bigger
4971 to avoid potential buffer overrun.
4973 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4975 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4977 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4979 Integer overflow fixes for scrolling, etc.
4980 Without these, Emacs silently mishandles large integers sometimes.
4981 For example, "C-u 4294967297 M-x recenter" was treated as if
4982 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4984 * xdisp.c (try_window_id): Check Emacs fixnum range before
4985 converting to 'int'.
4987 * window.c (window_scroll_line_based, Frecenter):
4988 Check that an Emacs fixnum is in range before assigning it to 'int'.
4989 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4990 values converted from Emacs fixnums.
4991 (Frecenter): Don't wrap around a line count if it is out of 'int'
4992 range; instead, treat it as an extreme value.
4993 (Fset_window_configuration, compare_window_configurations):
4994 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4996 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4997 that can exceed INT_MAX. Check that EMACS_INT value is in range
4998 before assigning it to the (possibly-narrower) index.
4999 (match_limit): Don't assume that a fixnum can fit in 'int'.
5001 * print.c (print_object): Use ptrdiff_t, not int, for index that can
5004 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
5005 (Fvertical_motion): Don't wrap around LINES values that don't fit
5006 in 'int'. Instead, treat them as extreme values. This is good
5007 enough for windows, which can't have more than INT_MAX lines anyway.
5009 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5011 * Require libxml/parser.h to avoid compilation warning.
5013 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5015 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5016 since this reportedly can destroy thread storage.
5018 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
5020 * syntax.c (find_defun_start): Update all cache variables if
5021 exiting early (Bug#9401).
5023 2011-08-30 Eli Zaretskii <eliz@gnu.org>
5025 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5027 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5028 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5029 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5031 * term.c (tty_append_glyph): New function.
5032 (produce_stretch_glyph): Static function and its prototype deleted.
5034 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5037 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5039 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5040 when checking :margin (Bug#9390).
5041 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
5042 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
5043 so that the name doesn't mislead. All uses changed.
5045 2011-08-28 Johan Bockgård <bojohan@gnu.org>
5047 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5050 2011-08-27 Eli Zaretskii <eliz@gnu.org>
5052 * xdisp.c (move_it_to): Don't bail out early when reaching
5053 position beyond to_charpos, if we are scanning backwards.
5054 (move_it_vertically_backward): When DY == 0, make sure we get to
5055 the first character in the line after the newline.
5057 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5059 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5060 (ccl_driver): Do not generate an out-of-range pointer.
5061 (Fccl_execute_on_string): Remove unnecessary check for
5062 integer overflow, noted by Stefan Monnier in
5063 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5064 Remove a FIXME that didn't need fixing.
5065 Simplify the newly-introduced buffer reallocation code.
5067 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
5069 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5071 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
5073 Integer and memory overflow issues (Bug#9196).
5075 * doc.c (get_doc_string): Rework so that
5076 get_doc_string_buffer_size is the actual buffer size, rather than
5077 being 1 less than the actual buffer size; this makes xpalloc more
5080 * image.c (x_allocate_bitmap_record, cache_image):
5081 * xselect.c (Fx_register_dnd_atom):
5082 Simplify previous changes by using xpalloc.
5084 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5085 since either will do and ptrdiff_t is convenient with xpalloc.
5087 * charset.c (charset_table_size)
5088 (struct charset_sort_data.priority): Now ptrdiff_t.
5089 (charset_compare): Don't overflow if priorities differ greatly.
5090 (Fsort_charsets): Don't assume list length fits in int.
5091 Check for size-calculation overflow when allocating sort data.
5092 (syms_of_charset): Allocate an initial charset table that is
5093 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5095 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5097 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5098 The actual value is always <= INT_MAX, and leaving it unsigned made
5099 overflow checking harder.
5101 * dispextern.h (struct glyph_matrix.rows_allocated)
5102 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5103 with xpalloc. The values are still always <= INT_MAX.
5105 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5107 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5108 (SAFE_NALLOCA): New macro.
5110 * region-cache.c (struct boundary.pos, find_cache_boundary)
5111 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5112 (set_cache_region, invalidate_region_cache)
5113 (revalidate_region_cache, know_region_cache, region_cache_forward)
5114 (region_cache_backward, pp_cache):
5115 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5116 so that ptrdiff_t * can be passed to xpalloc.
5117 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5118 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5119 (pp_cache): Don't assume cache_len fits in int.
5120 * region-cache.h: Adjust extern decls to match.
5122 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5123 EMACS_INT, since either will do, for xpalloc.
5125 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5126 (xnmalloc, xnrealloc, xpalloc): New functions.
5128 * bidi.c (bidi_shelve_header_size): New constant.
5129 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5130 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5132 * bidi.c (bidi_cache_shrink):
5133 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5135 Don't update size of array until after memory allocation succeeds,
5136 because xmalloc/xrealloc may not return.
5137 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5138 now that we have proper integer overflow checking.
5139 (record_overlay_string, overlay_strings): Catch overflows when
5140 calculating size of overlay_str_buf.
5142 * callproc.c (Fcall_process): Check for size overflow when
5143 calculating size of args2.
5144 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5145 Normally we prefer signed values, but sticking with ptrdiff_t would
5146 require adding more-complicated checks.
5148 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5149 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5150 Redo buffer-overflow calculations to avoid integer overflow.
5151 Add a FIXME comment where memory seems to be over-allocated.
5153 * character.c (Fstring): Check for size-calculation overflow.
5155 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5156 unnecessary integer overflow. Check for size overflow.
5157 (encode_coding_object): Don't update size until xmalloc succeeds.
5159 * composite.c (get_composition_id): Check for overflow in glyph
5160 length calculations.
5162 Integer and memory overflow fixes for display code.
5163 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5164 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5165 (scrolling_window): Check for overflow in size calculations.
5166 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5167 Don't assume glyph table len fits in int.
5168 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5169 (row_table_size): Now ptrdiff_t, not int.
5170 (scrolling_window): Avoid overflow in size calculations.
5171 Don't update size until allocation succeeds.
5172 * fns.c (concat): Check for overflow in size calculations.
5173 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5174 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5175 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5177 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5178 (get_doc_string): Check for size calculation overflow.
5179 Don't update size until allocation succeeds.
5180 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5181 EMACS_INT, where ptrdiff_t will do.
5182 (Fsubstitute_command_keys): Check for string overflow.
5184 * editfns.c (set_time_zone_rule): Don't assume environment length
5186 (message_length): Now ptrdiff_t, not int.
5187 (Fmessage_box): Don't update size until allocation succeeds.
5188 Don't assume message length fits in int.
5189 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5191 * emacs.c (main): Do not reallocate argv, since there is a null at
5192 the end that can be overwritten, and this way there's no need to
5193 worry about size-calculation overflow.
5194 (sort_args): Check for size-calculation overflow.
5196 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5198 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5200 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5201 (x_set_scroll_bar_width, x_figure_window_size):
5202 Check for integer overflow.
5203 (x_set_alpha): Do not assume XINT fits in int.
5205 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5206 This is for the members text_lines, text_cols, total_lines, total_cols,
5207 where the system imposes an 'int' limit.
5209 * fringe.c (Fdefine_fringe_bitmap):
5210 Don't update size until alloc works.
5212 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5213 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5215 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5216 Check for size-calculation overflow.
5217 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5218 do, as we prefer signed integers.
5219 (id_to_widget.max_size, id_to_widget.used)
5220 (xg_store_widget_in_map, xg_remove_widget_from_map)
5221 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5222 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5223 Use and return ptrdiff_t, not int.
5224 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5225 * gtkutil.h: Change prototypes to match the above.
5227 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5228 are duplicate now that they've been promoted to lisp.h.
5229 (x_allocate_bitmap_record, x_alloc_image_color)
5230 (make_image_cache, cache_image, xpm_load):
5231 Don't update size until alloc is done.
5232 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5234 Check for size calculation overflow.
5235 (ct_colors_allocated_max): New constant.
5236 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5239 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5240 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5241 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5242 Use ptrdiff_t, not int, to count maps.
5243 (read_char_minibuf_menu_prompt): Check for overflow in size
5244 calculations. Don't update size until allocation succeeds.
5245 Redo calculations to avoid overflow.
5246 * keyboard.h: Change prototypes to match the above.
5248 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5250 (current_minor_maps): Check for size calculation overflow.
5251 * keymap.h: Change prototypes to match the above.
5253 * lread.c (read1, init_obarray): Don't update size until alloc done.
5255 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5256 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5258 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5259 Now ptrdiff_t, not int.
5260 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5261 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5263 * process.c (Fnetwork_interface_list): Check for overflow
5264 in size calculation.
5266 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5268 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5269 overflow. Don't bother calling xmalloc when xrealloc will do.
5271 * search.c (Freplace_match): Check for size calculation overflow.
5272 (Fset_match_data): Don't assume list lengths fit in 'int'.
5274 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5275 for command line length. Do not attempt to address one before the
5276 beginning of an array, as that's not portable.
5278 * term.c (max_frame_lines): Remove; unused.
5279 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5281 (encode_terminal_code, calculate_costs): Check for size
5282 calculation overflow.
5283 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5284 table lengths and related sizes. Don't update size until alloc
5285 done. Redo calculations to avoid overflow.
5286 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5288 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5289 subtracting pointers.
5290 (gobble_line): Check for overflow more carefully. Don't update size
5293 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5294 Don't update size until alloc done.
5295 Redo size calculations to avoid overflow.
5296 Check for size calculation overflow.
5297 (main) [DEBUG]: Fix typo in invoking tparam1.
5299 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5300 Use ptrdiff_t, not int, for sizes.
5301 (store_mode_line_noprop_char): Don't update size until alloc done.
5303 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5304 Use ptrdiff_t, not int, for sizes.
5305 (Finternal_make_lisp_face, cache_face):
5306 Check for size calculation overflow.
5307 (cache_face): Treat size calculation overflows as if they were
5308 memory exhaustion (the usual treatment), rather than aborting.
5310 * xfns.c (x_encode_text, x_set_name_internal)
5311 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5312 sizes, since they can exceed INT_MAX in size. Check for size
5313 calculation overflow.
5315 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5316 (xg_select): Check for size calculation overflow.
5317 Don't update size until alloc done.
5319 * xrdb.c (get_environ_db): Don't assume path length fits in int,
5320 as sprintf is limited to int lengths.
5322 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5323 (X_LONG_MIN): New macros.
5324 Use them to make the following changes clearer.
5325 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5326 This change doesn't affect the value now, but it may help remind
5327 future maintainers not to raise the value too much later.
5328 (SELECTION_QUANTUM): Remove, replacing with ...
5329 (selection_quantum): ... new function, which avoids overflow.
5331 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5332 assumption that selection length fits in 'int'.
5333 (x_reply_selection_request, x_handle_selection_request)
5334 (x_get_window_property, receive_incremental_selection)
5335 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5336 (lisp_data_to_selection_data, clean_local_selection_data):
5337 Use ptrdiff_t, not int, to record length of selection.
5338 (x_reply_selection_request, x_get_window_property)
5339 (receive_incremental_selection, x_property_data_to_lisp):
5340 Redo calculations to avoid overflow.
5341 (x_reply_selection_request): When sending hint, ceiling it at
5342 X_LONG_MAX rather than relying on wraparound overflow to send
5344 (x_get_window_property, receive_incremental_selection)
5345 (lisp_data_to_selection_data, x_property_data_to_lisp):
5346 Check for size-calculation overflow.
5347 (x_get_window_property, receive_incremental_selection)
5348 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5349 Don't store size until memory allocation succeeds.
5350 (x_get_window_property): Plug memory leak on memory exhaustion.
5351 Don't double-block input; malloc is safe here. Don't assume 2**34
5352 - 4 fits in unsigned long. Add an xassert to check
5353 XGetWindowProperty overflow. Be more careful about overflow
5354 calculations, and distinguish size from memory overflow better.
5355 (receive_incremental_selection): When tracing, don't assume
5356 unsigned int is less than INT_MAX.
5357 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5358 harmful) conversions of unsigned short to int.
5359 (lisp_data_to_selection_data): Don't assume that integers
5360 in the range -65535 through -1 fit in an X unsigned short.
5361 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5362 result parameters unless successful. Rely on cons_to_unsigned
5363 to report problems with elements; the old code wasn't right anyway.
5364 (x_check_property_data): Check for int overflow; we cannot use
5365 a wider type due to X limits.
5366 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5368 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
5370 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5371 (x_term_init): Check for size calculation overflow.
5372 (x_color_cells): Don't store size until memory allocation succeeds.
5373 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
5374 Don't assume alloca size is less than MAX_ALLOCA.
5375 (x_term_init): Don't assume length fits in int (sprintf is limited
5378 Use ptrdiff_t for composition IDs.
5379 * character.c (lisp_string_width):
5380 * composite.c (composition_table_size, n_compositions)
5381 (get_composition_id, composition_gstring_from_id):
5382 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5383 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5384 * window.c (Frecenter):
5385 Use ptrdiff_t, not int, for composition IDs.
5386 * composite.c (get_composition_id): Check for integer overflow.
5387 * composite.h: Adjust prototypes to match the above changes.
5389 Use ptrdiff_t for hash table indexes.
5390 * category.c (hash_get_category_set):
5391 * ccl.c (ccl_driver):
5392 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5393 * coding.c (coding_system_charset_list, detect_coding_system):
5394 * coding.h (struct coding_system.id):
5395 * composite.c (get_composition_id, gstring_lookup_cache):
5396 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5397 * image.c (xpm_get_color_table_h):
5398 * lisp.h (hash_lookup, hash_put):
5399 * minibuf.c (Ftest_completion):
5400 Use ptrdiff_t for hash table indexes, not int (which is too
5401 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5402 32-bit --with-wide-int hosts).
5404 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5405 Add a FIXME comment about memory leaks.
5406 (syms_of_charset): Don't assume xmalloc returns.
5408 Don't assume that stated character widths fit in int.
5409 * character.c (Fchar_width, c_string_width, lisp_string_width):
5410 * character.h (CHAR_WIDTH):
5411 * indent.c (MULTIBYTE_BYTES_WIDTH):
5412 Use sanitize_char_width to avoid undefined and/or bad behavior
5413 with outlandish widths.
5414 * character.h (sanitize_tab_width): Rename from sanitize_width,
5415 now that we have two such functions. All uses changed.
5416 (sanitize_char_width): New inline function.
5418 Don't assume that tab-width fits in int.
5419 * character.h (sanitize_width): New inline function.
5420 (SANE_TAB_WIDTH): New macro.
5421 (ASCII_CHAR_WIDTH): Use it.
5422 * indent.c (sane_tab_width): Remove. All uses replaced by
5423 SANE_TAB_WIDTH (current_buffer).
5424 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5426 * fileio.c: Integer overflow issues with file modes.
5427 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5429 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5430 Remove unreachable code.
5431 (read_hex, load_charset_map_from_file): Check for integer overflow.
5433 * xterm.c: Don't go over XClientMessageEvent limit.
5434 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5435 (x_send_scroll_bar_event): Likewise. Check that the size does not
5436 exceed limits imposed by XClientMessageEvent, as well as the usual
5437 ptrdiff_t and size_t limits.
5439 * keyboard.c: Overflow, signedness and related fixes.
5440 (make_lispy_movement): Use same integer type in forward decl
5441 that is used in the definition.
5442 (read_key_sequence, keyremap_step):
5443 Change bufsize argument back to int, undoing my 2011-03-30 change.
5444 We prefer signed types, and int is wide enough here.
5445 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5446 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5447 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5448 length, not size_t. Use ptrdiff_t for index, not int.
5449 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5450 possibility of integer overflow.
5452 Overflow, signedness and related fixes for images.
5454 * dispextern.h (struct it.stack[0].u.image.image_id)
5455 (struct_it.image_id, struct image.id, struct image_cache.size)
5456 (struct image_cache.used, struct image_cache.ref_count):
5457 * gtkutil.c (update_frame_tool_bar):
5458 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5459 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5460 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5461 * nsmenu.m (update_frame_tool_bar):
5462 * xdisp.c (calc_pixel_width_or_height):
5463 * xfns.c (image_cache_refcount):
5464 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5465 on typical 64-bit hosts.
5467 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5468 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5469 Omit unnecessary casts to int.
5470 (parse_image_spec): Check that integers fall into 'int' range
5471 when the callers expect that.
5472 (image_ascent): Redo ascent calculation to avoid int overflow.
5473 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5474 (lookup_image): Remove unnecessary tests.
5475 (xbm_image_p): Locals are now of int, not EMACS_INT,
5476 since parse_image_check makes sure they fit into int.
5477 (png_load, gif_load, svg_load_image):
5478 Prefer int to unsigned where either will do.
5479 (tiff_handler): New function, combining the cores of the
5480 old tiff_error_handler and tiff_warning_handler.
5481 This function is rewritten to use vsnprintf and thereby avoid
5482 stack buffer overflows. It uses only the features of vsnprintf
5483 that are common to both POSIX and native Microsoft.
5484 (tiff_error_handler, tiff_warning_handler): Use it.
5485 (tiff_load, gif_load, imagemagick_load_image):
5486 Don't assume :index value fits in 'int'.
5487 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5488 (imagemagick_load_image): Check that crop parameters fit into
5489 the integer types that MagickCropImage accepts. Don't assume
5490 Vimagemagick_render_type has a nonnegative value. Don't assume
5491 size_t fits in 'long'.
5492 (gs_load): Use printmax_t to print the widest integers possible.
5493 Check for integer overflow when computing image height and width.
5495 2011-08-26 Eli Zaretskii <eliz@gnu.org>
5497 * xdisp.c (redisplay_window): Don't force window start if point
5498 will be invisible in the resulting window. (Bug#9324)
5500 2011-08-25 Eli Zaretskii <eliz@gnu.org>
5502 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5503 the display spec is of the form `(space ...)'.
5504 (handle_display_spec): Return the value returned by
5505 handle_single_display_spec, not just 1 or zero.
5506 (handle_single_display_spec): If the display spec is of the form
5507 `(space ...)', and specifies display in the text area, return 2
5509 (try_cursor_movement): Check for the need to scroll more
5510 accurately, and prefer exact match for point under bidi.
5511 Don't advance `row' beyond the last row of the window.
5513 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5514 into disp_prop; all users changed.
5516 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5517 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5518 for the text covered by the display property.
5520 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
5522 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5523 Change return value to nil.
5524 (Frecord_buffer): Delete unused function.
5526 2011-08-24 Eli Zaretskii <eliz@gnu.org>
5528 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5529 buffers, return left-to-right.
5530 (set_cursor_from_row): Consider candidate row a win if its glyph
5531 represents a newline and point is on that newline. Fixes cursor
5532 positioning on the newline at EOL of R2L text within L2R
5533 paragraph, and vice versa.
5534 (try_cursor_movement): Check continued rows, in addition to
5535 continuation rows. Fixes unwarranted scroll when point enters a
5536 continued line of R2L text within an L2R paragraph, or vice versa.
5537 (cursor_row_p): Consider the case of point being equal to
5538 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5539 from the end of a short line to the beginning of a continued line
5540 of R2L text within L2R paragraph.
5541 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5542 composed characters.
5544 * bidi.c (bidi_check_type): Use xassert.
5545 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5548 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5550 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5553 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5555 * nsfont.m (ns_otf_to_script): Fix typo.
5557 2011-08-22 Kenichi Handa <handa@m17n.org>
5559 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5560 extra slot even if the purpose is char-code-property-table.
5562 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5564 * xdisp.c (redisplay_window): When computing centering_position,
5565 account for the height of the header line. (Bug#8874)
5567 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5568 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5569 candidate is selected by the mouse, and that candidate has a
5570 composed character under the mouse.
5572 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5573 coordinates reported by pos-visible-in-window-p for a composed
5574 character in column zero.
5576 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5578 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5580 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5582 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5583 consider it a hit if to_charpos is anywhere in the range of the
5584 composed buffer positions.
5586 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5588 * image.c (gif_load): Don't assume that each subimage has the same
5589 dimensions as the base image. Handle disposal method that is
5590 "undefined" by the gif spec (Bug#9335).
5592 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5594 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5595 (Fcondition_case): Document `debug' symbol in error handler.
5597 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5599 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5600 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5601 from an Org mode buffer to a Speedbar frame.
5603 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5604 a composition, take its buffer position from IT->cmp_it.charpos.
5605 Fixes cursor positioning at the beginning of a line that begins
5606 with a composed character.
5608 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5610 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5611 character bidirectional type, use STRONG_L instead. Fixes crashes
5612 in a buffer produced by `describe-categories'.
5614 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5615 members before the level stack, so they would be saved and
5616 restored when copying iterator state. Fixes incorrect reordering
5617 around TABs covered by display properties.
5619 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5621 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5623 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5625 * eval.c (internal_condition_case, internal_condition_case_1)
5626 (internal_condition_case_2, internal_condition_case_n):
5627 Remove unnecessary aborts (Bug#9081).
5629 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5631 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5632 has no `load' handler, try opening the file locally. (Bug#9311)
5634 2011-08-16 Ken Brown <kbrown@cornell.edu>
5636 * gmalloc.c: Expand comment.
5638 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5640 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5641 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5643 2011-08-16 Ken Brown <kbrown@cornell.edu>
5645 Fix memory allocation problems in Cygwin build (Bug#9273).
5647 * unexcw.c ( __malloc_initialized): Declare external variable.
5648 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5650 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5652 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5654 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5656 [CYGWIN] (special_realloc): New function.
5657 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5658 requests to realloc storage in the static heap.
5660 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5662 * bidi.c (bidi_initialize): Remove unused local.
5664 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5667 * biditype.h: Remove file.
5668 * makefile.w32-in ($(BLD)/bidi.$(O)):
5669 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5671 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5673 * chartab.c: Improve commentary for the uniprop_table API.
5675 * bidi.c (bidi_paragraph_init): Support zero value of
5676 bidi_ignore_explicit_marks_for_paragraph_level.
5677 (bidi_initialize): Use uniprop_table instead of including
5678 biditype.h and bidimirror.h.
5680 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5681 coordinates of the iterator when restoring from ppos_it.
5684 2011-08-14 Kenichi Handa <handa@m17n.org>
5686 * process.c (create_process): Call setup_process_coding_systems
5687 after the pid of the process is set to -1 (Bug#8162).
5689 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5691 * xdisp.c (move_it_in_display_line_to): Don't invoke
5692 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5693 ppos_it. Fixes vertical cursor motion when line beginning is
5694 covered by an image. (Bug#9296)
5696 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5698 * nsterm.h (ns_run_ascript): Declare.
5699 (NSAPP_DATA2_RUNASSCRIPT): Define.
5701 * nsfns.m (as_script, as_result, as_status): New static variables.
5702 (ns_run_ascript): New function.
5703 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5704 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5705 the event loop. Get status from as_status (Bug#7276).
5707 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5708 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5709 the event loop (Bug#7276).
5711 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5713 * gnutls.c (QCgnutls_bootprop_priority)
5714 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5715 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5716 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5717 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5718 (QCgnutls_bootprop_verify_hostname_error)
5719 (QCgnutls_bootprop_callbacks_verify): Rename from
5720 Qgnutls_bootprop_..., all uses changed.
5722 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5725 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5727 * xfaces.c (Qframe_set_background_mode): Now static.
5728 * dispextern.h (Qframe_set_background_mode): Remove decl.
5730 * process.c (Fnetwork_interface_info): Declare local only if needed.
5732 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5734 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5735 (Fnetwork_interface_list): Allocate in increments of bytes instead
5736 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5737 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5739 (struct ifflag_def): notrailers is smart on OSX.
5740 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5741 Get hardware address with getifaddrs if available.
5743 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5745 * xdisp.c (iterate_out_of_display_property): xassert that
5746 IT->position is set to within IT->object's boundaries. Break from
5747 the loop as soon as EOB is reached; avoids infloops in redisplay
5748 when IT->position is set up wrongly due to some bug.
5749 Set IT->current to match the bidi iterator unconditionally.
5750 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5751 entry. Force push_it to save on the stack the current
5752 buffer/string position, to be restored by pop_it. Fix flags in
5753 the iterator structure wrt the object coming from a display
5754 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5755 properties. (Bug#9284)
5757 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5759 * fontset.c (fontset_get_font_group): Add proper type checks.
5762 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5764 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5765 and LC_VERSION_MIN_MACOSX.
5766 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5767 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5769 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5771 * xdisp.c (forward_to_next_line_start): Allow to use the
5772 no-display-properties-and-no-overlays under bidi display.
5773 Set disp_pos in the bidi iterator to avoid searches for display
5774 properties and overlays.
5776 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5778 * editfns.c (Fset_time_zone_rule): Document relationship with the
5781 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5782 the font entity extracted from the cache (Bug#8109).
5784 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5786 * composite.c (autocmp_chars): Don't reset point. That is done by
5787 restore_point_unwind (Bug#5984).
5789 2011-08-07 Juri Linkov <juri@jurta.org>
5791 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5792 to show the arg `TIME' instead of `TIMEVAL'.
5794 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5796 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5797 display property strides EOL and includes a newline, as in
5798 longlines-mode. (Bug#9254)
5799 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5800 word-wrap under bidirectional display. (Bug#9224)
5802 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5803 is non-zero, even if the data buffer is NULL. Fixes a crash in
5804 vertical-motion with longlines-mode. (Bug#9254)
5806 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5808 * bidi.c <bidi_cache_total_alloc>: Now static.
5809 (bidi_initialize): Initialize bidi_cache_total_alloc.
5811 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5814 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5815 amount allocated this far in `bidi_cache_total_alloc'.
5816 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5817 non-zero, only free the data buffer without restoring the cache
5818 contents. All callers changed.
5820 * dispextern.h (bidi_unshelve_cache): Update prototype.
5822 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5823 (move_it_in_display_line, move_it_to)
5824 (move_it_vertically_backward, move_it_by_lines): Replace the call
5825 to xfree to an equivalent call to bidi_unshelve_cache.
5826 (move_it_in_display_line_to): Fix logic of returning
5827 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5829 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5831 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5832 came from a string character with a `cursor' property. (Bug#9229)
5834 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5836 * Makefile.in (LIB_PTHREAD): New variable.
5837 (LIBES): Add LIB_PTHREAD (Bug#9216).
5839 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5840 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5842 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5844 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5846 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5848 * xterm.c (x_find_topmost_parent): New function.
5849 (x_set_frame_alpha): Find topmost parent window with
5850 x_find_topmost_parent and set the property there also (bug#9181).
5851 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5853 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5855 * callproc.c (Fcall_process): Avoid vfork clobbering
5856 the local vars buffer, coding_systems, current_dir.
5858 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5860 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5862 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5864 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5865 so that it is not optimized away.
5867 * xdisp.c (compute_display_string_pos): Remove unused local.
5869 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5871 Fix slow cursor motion and scrolling in large buffers with
5872 selective display, like Org Mode buffers. (Bug#9218)
5874 * dispextern.h (struct bidi_it): New member disp_prop_p.
5876 * xdisp.c: Remove one-slot cache of display string positions.
5877 (compute_display_string_pos): Accept an additional argument
5878 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5879 for a display string or property. If found, set DISP_PROP_P
5882 * bidi.c (bidi_fetch_char): Accept an additional argument
5883 DISP_PROP_P, and pass it to compute_display_string_pos.
5884 Only handle text covered by a display string if DISP_PROP_P is returned
5885 non-zero. All callers of bidi_fetch_char changed.
5887 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5889 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5891 2010-12-03 Don March <don@ohspite.net>
5893 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5894 last character M-[char] is translated to ESC [char] (bug#7541).
5896 2011-08-02 Kenichi Handa <handa@m17n.org>
5898 * lisp.h (uniprop_table): Extern it.
5900 * chartab.c (uniprop_table): Make it non-static.
5902 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5904 * xdisp.c (forward_to_next_line_start): Accept additional argument
5905 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5907 (reseat_at_next_visible_line_start): Use the bidi iterator state
5908 returned by forward_to_next_line_start to restore the state of
5909 it->bidi_it after backing up to previous newline. (Bug#9212)
5911 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5913 * regex.c (re_comp): Protoize.
5914 (re_exec): Fix return type.
5915 (regexec): Fix type of `ret'. (Bug#9203)
5917 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5919 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5920 This is needed if max-image-size is a floating-point number.
5922 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5924 * print.c (print_object): Print empty symbol as ##.
5926 * lread.c (read1): Read ## as empty symbol.
5928 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5930 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5931 setting frame foreground color (Bug#9175).
5932 (x_set_background_color): Likewise.
5934 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5935 contents (Bug#9176).
5936 (EmacsTooltip -init): Remove bezels and add shadows to
5939 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5940 or scroll bar (Bug#8470).
5942 * nsfont.m (nsfont_open): Remove assignment to voffset and
5943 unnecessary vars hshink, expand, hd, full_height, min_height.
5944 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5946 * nsterm.h (nsfont_info): Remove voffset field.
5948 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5950 Implement strike-through and overline on NextStep (Bug#8863).
5952 * nsfont.m (nsfont_open): Use underline position provided by font,
5953 instead of hard-coded value of 2.
5954 (nsfont_draw): Call ns_draw_text_decoration instead.
5956 * nsterm.h: Add declaration for ns_draw_text_decoration.
5958 * nsterm.m (ns_draw_text_decoration): New function for drawing
5959 underline, overline, and strike-through.
5960 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5961 ns_draw_text_decoration. Change treatment of cursor drawing to
5962 accommodate underlining, etc.
5964 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5966 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5969 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5971 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5972 Without this fix, if a signal arrives just after memory fills up,
5973 'malloc' might be invoked reentrantly.
5975 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5976 In other words, assume that every image size is allowed, on non-X
5977 hosts. This assumption is probably wrong, but it lets Emacs compile.
5979 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5981 * regex.c (re_iswctype): Convert return values to boolean.
5983 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5985 * xdisp.c (compute_display_string_pos): Don't use cached display
5986 string position if the buffer had its restriction changed.
5989 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5991 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5993 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5995 Integer signedness and overflow and related fixes. (Bug#9079)
5997 * bidi.c: Integer size and overflow fixes.
5998 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5999 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6000 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6001 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6002 (bidi_find_other_level_edge):
6003 Use ptrdiff_t instead of EMACS_INT where either will do.
6004 This works better on 32-bit hosts configured --with-wide-int.
6005 (bidi_cache_ensure_space): Check for size-calculation overflow.
6006 Use % rather than repeated addition, for better worst-case speed.
6007 Don't set bidi_cache_size until after xrealloc returns, because it
6009 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
6010 (bidi_cache_ensure_space): Also check that the bidi cache size
6011 does not exceed that of the largest Lisp string or buffer. See Eli
6012 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
6014 * alloc.c (__malloc_size_t): Remove.
6015 All uses replaced by size_t. See Andreas Schwab's note
6016 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6018 * image.c: Improve checking for integer overflow.
6019 (check_image_size): Assume that f is nonnull, since
6020 it is always nonnull in practice. This is one less thing to
6021 worry about when checking for integer overflow later.
6022 (x_check_image_size): New function, which checks for integer
6023 overflow issues inside X.
6024 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6025 This removes the need for a memory_full check.
6026 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6027 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6028 (xbm_read_bitmap_data): Change locals back to 'int', since
6029 their values must fit in 'int'.
6030 (xpm_load_image, png_load, tiff_load):
6031 Invoke x_create_x_image_and_pixmap earlier,
6032 to avoid much needless work if the image is too large.
6033 (tiff_load): Treat overly large images as if
6034 x_create_x_image_and_pixmap failed, not as malloc failures.
6035 (gs_load): Use x_check_image_size.
6037 * gtkutil.c: Omit integer casts.
6038 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6039 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6041 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6043 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6044 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6045 would wrongly return t on a 64-bit host.
6047 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6048 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6049 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6050 and therefore cause GCC to emit a bogus diagnostic in some cases.
6052 * image.c: Integer signedness and overflow and related fixes.
6053 This is not an exhaustive set of fixes, but it's time to
6054 record what I've got.
6055 (lookup_pixel_color, check_image_size): Remove redundant decls.
6056 (check_image_size): Don't assume that arbitrary EMACS_INT values
6057 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6058 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6059 (tiff_load, imagemagick_load_image):
6060 Check for overflow in size calculations.
6061 (x_create_x_image_and_pixmap): Remove unnecessary test for
6062 xmalloc returning NULL; that can't happen.
6063 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6064 (xpm_color_bucket): Use better integer hashing function.
6065 (xpm_cache_color): Don't possibly over-allocate memory.
6066 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6067 (gif_memory_source):
6068 Use ptrdiff_t, not int or size_t, to record sizes.
6069 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6070 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6071 either works, as we prefer signed integers.
6072 (tiff_read_from_memory, tiff_write_from_memory):
6073 Return tsize_t, not size_t, since that's what the TIFF API wants.
6074 (tiff_read_from_memory): Don't fail simply because the read would
6075 go past EOF; instead, return a short read.
6076 (tiff_load): Omit no-longer-needed casts.
6077 (Fimagemagick_types): Don't assume size fits into 'int'.
6079 Improve hashing quality when configured --with-wide-int.
6080 * fns.c (hash_string): New function, taken from sxhash_string.
6081 Do not discard information about ASCII character case; this
6082 discarding is no longer needed.
6083 (sxhash-string): Use it. Change sig to match it. Caller changed.
6084 * lisp.h: Declare it.
6085 * lread.c (hash_string): Remove, since we now use fns.c's version.
6086 The fns.c version returns a wider integer if --with-wide-int is
6087 specified, so this should help the quality of the hashing a bit.
6089 * emacs.c: Integer overflow minor fix.
6090 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6091 Define only if GNU_LINUX.
6092 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6094 * dispnew.c: Integer signedness and overflow fixes.
6095 Remove unnecessary forward decls, that were a maintenance hassle.
6096 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6098 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6099 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6100 (prepare_desired_row, line_draw_cost):
6101 Use int, not unsigned, where either works.
6102 (save_current_matrix, restore_current_matrix):
6103 Use ptrdiff_t, not size_t, where either works.
6104 (init_display): Check for overflow more accurately, and without
6105 relying on undefined behavior.
6107 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6108 Remove, replacing with the new symbols in lisp.h. All uses changed.
6109 * fileio.c (make_temp_name):
6110 * filelock.c (lock_file_1, lock_file):
6111 * xdisp.c (message_dolog):
6112 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6113 Use pMd etc. instead.
6114 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6115 replacing the pWIDE etc. symbols removed from editfns.c.
6117 * keyboard.h (num_input_events): Now uintmax_t.
6118 This is (very slightly) less likely to mess up due to wraparound.
6121 * buffer.c: Integer signedness fixes.
6122 (alloc_buffer_text, enlarge_buffer_text):
6123 Use ptrdiff_t rather than size_t when either will do, as we prefer
6126 * alloc.c: Integer signedness and overflow fixes.
6127 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6128 (__malloc_size_t): Default to size_t, not to int.
6129 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6130 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6131 Prefer ptrdiff_t to size_t when either would do, as we prefer
6133 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6134 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6135 Now const. Initialize with values that are in range even if char
6137 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6138 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6139 These functions do the right thing with sizes > 2**32.
6140 (check_depth): Now ptrdiff_t, not int.
6141 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6142 Adjust to new way of storing sizes. Check for size overflow bugs
6144 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6145 slightly wrong anyway, as it missed one instance of
6146 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6147 (refill_memory_reserve): Omit needless cast to size_t.
6148 (mark_object_loop_halt): Mark as externally visible.
6150 * xselect.c: Integer signedness and overflow fixes.
6151 (Fx_register_dnd_atom, x_handle_dnd_message):
6152 Use ptrdiff_t, not size_t, since we prefer signed.
6153 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6154 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6155 x_dnd_atoms_size and x_dnd_atoms_length.
6157 * doprnt.c: Prefer signed to unsigned when either works.
6159 * doprnt.c (doprnt):
6161 * xdisp.c (vmessage):
6162 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6163 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6164 prefer signed arithmetic to avoid comparison confusion.
6165 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6166 but is a bit tricky.
6168 Assume freestanding C89 headers, string.h, stdlib.h.
6169 * data.c, doprnt.c, floatfns.c, print.c:
6170 Include float.h unconditionally.
6171 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6172 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6173 * regex.c: Likewise for stddef.h, string.h.
6174 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6175 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6176 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6177 (STDC_HEADERS): Remove obsolete defines.
6178 * sysdep.c: Include limits.h unconditionally.
6180 Assume support for memcmp, memcpy, memmove, memset.
6181 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6182 * regex.c (memcmp, memcpy):
6183 Remove; we assume C89 now.
6185 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6186 (__malloc_safe_bcopy): Remove; no longer needed.
6188 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6189 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6190 well either way, and we prefer signed to unsigned.
6192 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6194 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6195 closes the connection while we're reading (bug#9182).
6197 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
6199 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6200 are specified (Bug#9168).
6202 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6204 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6205 Found by GCC static checking and --with-wide-int on a 32-bit host.
6207 2011-07-25 Eli Zaretskii <eliz@gnu.org>
6209 * xdisp.c (compute_display_string_pos): Fix logic of caching
6210 previous display string position. Initialize cached_prev_pos to
6211 -1. Fixes slow-down at the beginning of a buffer.
6213 2011-07-24 Eli Zaretskii <eliz@gnu.org>
6215 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6216 for attrs[LFACE_FONTSET_INDEX].
6218 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6220 * xml.c (parse_region): Remove unused local
6221 that was recently introduced.
6223 2011-07-23 Eli Zaretskii <eliz@gnu.org>
6225 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6226 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6228 * xdisp.c (move_it_in_display_line_to): Record the best matching
6229 position for TO_CHARPOS while scanning the line, and restore it on
6230 exit if none of the characters scanned was an exact match.
6231 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
6232 when exact match is impossible due to invisible text, and the
6233 lines are truncated.
6235 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6237 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6240 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6242 Fix a significant slow-down of cursor motion with C-n, C-p,
6243 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6244 auto-repeat under bidi redisplay in fontified buffers.
6245 * xdisp.c (compute_stop_pos_backwards): New function.
6246 (next_element_from_buffer): Call compute_stop_pos_backwards to
6247 find a suitable prev_stop when we find ourselves before
6249 (reseat): Don't look for prev_stop, as that could mean a very long
6251 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6252 <cached_disp_overlay_modiff>: Cache for last found display string
6254 (compute_display_string_pos): Return the cached position if asked
6255 about the same buffer in the same area of character positions, and
6256 the buffer wasn't changed since the time the display string
6257 position was cached.
6259 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6261 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6262 is an integer, which is important for empty lines. (Bug#9149)
6264 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
6266 * frame.c (Fmodify_frame_parameters): In tty case, update the
6267 default face if necessary (Bug#4238).
6269 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
6271 * editfns.c (Fstring_to_char): No need to explain what a character
6272 is in the docstring (Bug#6576).
6274 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6276 * xml.c (parse_region): Make sure we always return a tree.
6278 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6280 * xml.c (parse_region): If a document contains only comments,
6283 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6285 * xml.c (make_dom): Return comments, too.
6287 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6290 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6291 and the surrounding thread.
6292 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6293 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6294 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6296 * s/openbsd.h (BROKEN_SIGIO): Define.
6297 * unexelf.c (unexec) [__OpenBSD__]:
6298 Don't update the .mdebug section of the Alpha COFF symbol table.
6300 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6302 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6305 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6307 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6308 This fixes some race conditions on the permissions of any newly
6311 * alloc.c (valid_pointer_p): Use pipe, not open.
6312 This fixes some permissions issues when debugging.
6314 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6315 If fchown fails to set both uid and gid, try to set just gid,
6316 as that is sometimes allowed. Adjust the file's mode to eliminate
6317 setuid or setgid bits that are inappropriate if fchown fails.
6319 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6321 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6322 to compare Lisp_Objects.
6323 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6324 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6325 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6327 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6329 * lread.c (read_integer): Unread even EOF character.
6330 (read1): Likewise. Properly record start position of symbol.
6332 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6333 symbol character follows.
6335 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6337 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6338 This works around a problem with the previous change to Fcopy_file.
6339 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6340 and without this change, GCC might complain about discarding
6341 fchown's return value.
6343 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
6345 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6347 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6349 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6351 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6353 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6354 it's used from the C level.
6356 * process.c: Use the same condition for POLL_FOR_INPUT in both
6357 keyboard.c and process.c (bug#1858).
6359 2011-07-09 Lawrence Mitchell <wence@gmx.li>
6361 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6362 (Fgnutls_boot): Use it.
6364 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6366 * doc.c (Fsubstitute_command_keys): Revert last change.
6368 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6370 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6371 quotes the next character, and doesn't affect other longer
6372 sequences (bug#8935).
6374 * lread.c (syms_of_lread): Clarify that is isn't only
6375 `eval-buffer' and `eval-defun' that's affected by
6376 `lexical-binding' (bug#8460).
6378 2011-07-15 Eli Zaretskii <eliz@gnu.org>
6380 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6381 bidi redisplay when a line includes both an image and is truncated.
6383 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6385 Fix minor problems found by static checking.
6386 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6387 (elsz): Now a signed constant, not a size_t var. We prefer signed
6388 types to unsigned, to avoid integer comparison confusion. Without
6389 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6390 "cannot optimize loop, the loop counter may overflow", a symptom
6392 * indent.c (Fvertical_motion): Mark locals as initialized.
6393 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6395 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6397 * search.c (Fre_search_backward): Mention `case-fold-search' in
6398 all the re_search_* functions (bug#8138).
6400 * keyboard.c (Fopen_dribble_file): Document when the file is
6403 2011-07-14 Eli Zaretskii <eliz@gnu.org>
6405 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6408 Support bidi reordering of display and overlay strings.
6409 * xdisp.c (compute_display_string_pos)
6410 (compute_display_string_end): Accept additional argument STRING.
6411 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6412 (reseat_to_string): Initialize bidi_it->string.s and
6413 bidi_it->string.schars.
6414 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
6415 NULL (avoids a crash in bidi_paragraph_init).
6416 Initialize itb.string.lstring.
6417 (init_iterator): Call bidi_init_it only of a valid
6418 buffer position was specified. Initialize paragraph_embedding to
6420 (reseat_to_string): Initialize the bidi iterator.
6421 (display_string): If we need to ignore text properties of
6422 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6423 original value of -1 will not work with bidi.)
6424 (compute_display_string_pos): First arg is now struct
6425 `text_pos *'; all callers changed. Support display properties on
6427 (compute_display_string_end): Support display properties on Lisp
6429 (init_iterator, reseat_1, reseat_to_string): Initialize the
6430 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6431 when iterating on a string not from display properties).
6432 (compute_display_string_pos, compute_display_string_end):
6433 Fix calculation of the object to scan. Fixes an error when using
6435 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
6436 base_level_stop; instead, set base_level_stop to BEGV.
6437 Fixes crashes in vertical-motion.
6438 (next_element_from_buffer): Improve commentary for when
6439 the iterator is before prev_stop.
6440 (init_iterator): Initialize bidi_p from the default value of
6441 bidi-display-reordering, not from buffer-local value. Use the
6442 buffer-local value only if initializing for buffer iteration.
6443 (handle_invisible_prop): Support invisible properties on strings
6444 that are being bidi-reordered.
6445 (set_iterator_to_next): Support bidi reordering of C strings and
6447 (next_element_from_string): Support bidi reordering of Lisp
6449 (handle_stop_backwards): Support Lisp strings as well.
6450 (display_string): Support display of R2L glyph rows.
6451 Use IT_STRING_CHARPOS when displaying from a Lisp string.
6452 (init_iterator): Don't initialize it->bidi_p for strings
6454 (reseat_to_string): Initialize it->bidi_p for strings here.
6455 (next_element_from_string, next_element_from_c_string)
6456 (next_element_from_buffer): Add xassert's for correspondence
6457 between IT's object being iterated and it->bidi_it.string
6459 (face_before_or_after_it_pos): Support bidi iteration.
6460 (next_element_from_c_string): Handle the case of the first string
6461 character that is not the first one in the visual order.
6462 (get_visually_first_element): New function, refactored from common
6463 parts of next_element_from_buffer, next_element_from_string, and
6464 next_element_from_c_string.
6465 (tool_bar_lines_needed, redisplay_tool_bar)
6466 (display_menu_bar): Force left-to-right direction. Add a FIXME
6467 comment for making that be controlled by a user option.
6468 (push_it, pop_it): Save and restore the state of the
6469 bidi iterator. Save and restore the bidi_p flag.
6470 (pop_it): Iterate out of display property for string iteration as
6472 (iterate_out_of_display_property): Support iteration over strings.
6473 (handle_single_display_spec): Set up it->bidi_it for iteration
6474 over a display string, and call bidi_init_it.
6475 (handle_single_display_spec, next_overlay_string)
6476 (get_overlay_strings_1, push_display_prop): Set up the bidi
6477 iterator for displaying display or overlay strings.
6478 (forward_to_next_line_start): Don't use the shortcut if
6480 (back_to_previous_visible_line_start): If handle_display_prop
6481 pushed the iterator stack, restore the internal state of the bidi
6482 iterator by calling bidi_pop_it same number of times.
6483 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6484 and we are bidi-iterating, don't decrement the iterator position;
6485 instead, set the first_elt flag in the bidi iterator, to produce
6487 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6488 (push_display_prop): xassert that we are iterating a buffer.
6489 (push_it, pop_it): Save and restore paragraph_embedding member.
6490 (handle_single_display_spec, next_overlay_string)
6491 (get_overlay_strings_1, reseat_1, reseat_to_string)
6492 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6493 correctly. Don't assume unibyte strings are not bidi-reordered.
6494 (compute_display_string_pos)
6495 (compute_display_string_end): Fix handling the case of C string.
6496 (push_it, pop_it): Save and restore from_disp_prop_p.
6497 (handle_single_display_spec, push_display_prop): Set the
6498 from_disp_prop_p flag.
6499 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6500 (pop_it): Call iterate_out_of_display_property only if we are
6501 popping after iteration over a string that came from a display
6502 property. Fix a typo in popping stretch info. Add an assertion
6503 for verifying that the iterator position is in sync with the bidi
6505 (handle_single_display_spec, get_overlay_strings_1)
6506 (push_display_prop): Fix initialization of paragraph direction for
6507 string when that of the parent object is not yet determined.
6508 (reseat_1): Call bidi_init_it to resync the bidi
6509 iterator with IT's position. (Bug#7616)
6510 (find_row_edges): If ROW->start.pos gives position
6511 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6512 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6513 Reset the from_disp_prop_p flag.
6514 (SAVE_IT, RESTORE_IT): New macros.
6515 (pos_visible_p, face_before_or_after_it_pos)
6516 (back_to_previous_visible_line_start)
6517 (move_it_in_display_line_to, move_it_in_display_line)
6518 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6519 (try_scrolling, redisplay_window, display_line): Use them when
6520 saving a temporary copy of the iterator and restoring it back.
6521 (back_to_previous_visible_line_start, reseat_1)
6522 (init_iterator): Empty the bidi cache "stack".
6523 (move_it_in_display_line_to): If iterator ended up at
6524 EOL, but we never saw any buffer positions smaller than
6525 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6526 motion in bidi-reordered lines.
6527 (move_it_in_display_line_to): Record prev_method and prev_pos
6528 immediately before the call to set_iterator_to_next. Fixes cursor
6529 motion in bidi-reordered lines with stretch glyphs and strings
6530 displayed in margins. (Bug#8133) (Bug#8867)
6531 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6533 (pos_visible_p): Support positions in bidi-reordered lines.
6534 Save and restore bidi cache.
6536 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6537 (bidi_paragraph_info): Delete unused struct.
6538 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6539 (bidi_cache_start): New variable.
6540 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6542 (bidi_cache_fetch_state, bidi_cache_search)
6543 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6544 (bidi_cache_find, bidi_peek_at_next_level)
6545 (bidi_level_of_next_char, bidi_find_other_level_edge)
6546 (bidi_move_to_visually_next): Compare cache index with
6547 bidi_cache_start rather than with zero.
6548 (bidi_fetch_char): Accept new argument STRING; all callers
6549 changed. Support iteration over a string. Support strings with
6550 display properties. Support unibyte strings. Fix the type of
6551 `len' according to what STRING_CHAR_AND_LENGTH expects.
6552 (bidi_paragraph_init, bidi_resolve_explicit_1)
6553 (bidi_resolve_explicit, bidi_resolve_weak)
6554 (bidi_level_of_next_char, bidi_move_to_visually_next):
6555 Support iteration over a string.
6556 (bidi_set_sor_type, bidi_resolve_explicit_1)
6557 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6558 can now be zero (for strings); special values 0 and -1 were
6559 changed to -1 and -2, respectively.
6560 (bidi_char_at_pos): New function.
6561 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6562 Call it instead of FETCH_MULTIBYTE_CHAR.
6563 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6564 initialized to valid values.
6565 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6567 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6568 the test for valid cached positions. Fix the logic for looking up
6569 the sentinel state in the cache. GCPRO the Lisp string we are
6571 (bidi_push_it, bidi_pop_it): New functions.
6572 (bidi_initialize): Initialize the bidi cache start stack pointer.
6573 (bidi_cache_ensure_space): New function, refactored from part of
6574 bidi_cache_iterator_state. Don't assume the required size is just
6575 one BIDI_CACHE_CHUNK away.
6576 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6577 (bidi_count_bytes, bidi_char_at_pos): New functions.
6578 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6579 always valid if bidi_cache_idx is valid.
6580 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6581 is valid if it's going to be used.
6582 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6583 (bidi_cache_fetch_state, bidi_cache_search)
6584 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6585 (bidi_cache_iterator_state, bidi_cache_find)
6586 (bidi_find_other_level_edge, bidi_cache_start_stack):
6587 All variables related to cache indices are now EMACS_INT.
6589 * dispextern.h (struct bidi_string_data): New structure.
6590 (struct bidi_it): New member `string'. Make flag members be 1-bit
6591 fields, and put them last in the struct.
6592 (compute_display_string_pos, compute_display_string_end):
6594 (bidi_push_it, bidi_pop_it): Add prototypes.
6595 (struct iterator_stack_entry): New members bidi_p,
6596 paragraph_embedding, and from_disp_prop_p.
6597 (struct it): Member bidi_p is now a bit field 1 bit wide.
6598 (bidi_shelve_cache, bidi_unshelve_cache):
6601 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6602 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6603 and vector-like objects.
6605 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6606 cache around display iteration.
6608 * window.c (Fwindow_end, window_scroll_pixel_based)
6609 (displayed_window_lines, Frecenter): Save and restore the bidi
6610 cache around display iteration.
6612 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6614 * editfns.c (Fdelete_region): Clarify the use of the named
6615 parameters (bug#6788).
6617 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6619 * indent.c (Fvertical_motion): Set and restore w->pointm when
6620 saving and restoring the window's buffer (Bug#9006).
6622 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6624 * editfns.c (Fstring_to_char): Clarify just what is returned
6625 (bug#6576). Text by Eli Zaretskii.
6627 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6629 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6631 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6633 * buffer.c (mmap_find): Fix a typo.
6635 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6637 Fix execution of x selection hooks.
6638 * xselect.c (Qx_lost_selection_functions)
6639 (Qx_sent_selection_functions): New vars.
6640 (syms_of_xselect): DEFSYM them.
6641 (x_handle_selection_request): Pass Qx_sent_selection_functions
6642 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6643 (x_handle_selection_clear,x_clear_frame_selections):
6644 Pass Qx_lost_selection_functions rather than
6645 Vx_lost_selection_functions to Frun_hook_with_args.
6647 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6649 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6650 The old code sometimes used this field without initializing it.
6652 * alloc.c (gc_sweep): Don't read past end of array.
6653 In theory, the old code could also have corrupted Emacs internals,
6654 though it'd be very unlikely.
6656 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6658 * character.c (Fcharacterp): Don't advertise optional ignored
6659 argument. (Bug#4026)
6661 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6663 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6666 * window.c (Fset_window_start): Doc fix (bug#4199).
6667 (Fset_window_hscroll): Ditto.
6669 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6671 Fix minor new problems caught by GCC 4.6.1.
6672 * term.c (init_tty): Remove unused local.
6673 * xsettings.c (store_monospaced_changed): Define this function only
6674 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6677 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6679 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6681 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6683 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6684 are the mini-buffer and the echo area (bug#3320).
6686 * term.c (init_tty): Remove support for supdup, c10 and perq
6687 terminals, which are no longer supported (bug#1482).
6689 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6691 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6693 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6695 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6696 for non-popups (Bug#3642).
6698 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6700 * alloc.c (reset_malloc_hooks): Protoize.
6701 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6702 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6703 * cm.c (losecursor): Likewise.
6704 * data.c (fmod): Likewise.
6705 * dispnew.c (swap_glyphs_in_rows): Likewise.
6706 * emacs.c (memory_warning_signal): Likewise.
6707 * floatfns.c (float_error): Likewise.
6708 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6709 (otf_open, font_otf_capability, generate_otf_features)
6710 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6712 * image.c (pbm_read_file): Likewise.
6713 * indent.c (string_display_width): Likewise.
6714 * intervals.c (check_for_interval, search_for_interval)
6715 (inc_interval_count, count_intervals, root_interval)
6716 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6717 * lread.c (defalias): Likewise.
6718 * ralloc.c (r_alloc_check): Likewise.
6719 * regex.c (set_image_of_range_1, set_image_of_range)
6720 (regex_grow_registers): Likewise.
6721 * sysdep.c (strerror): Likewise.
6722 * termcap.c (valid_filename_p, tprint, main): Likewise.
6723 * tparam.c (main): Likewise.
6724 * unexhp9k800.c (run_time_remap, save_data_space)
6725 (update_file_ptrs, read_header, write_header, calculate_checksum)
6726 (copy_file, copy_rest, display_header): Likewise.
6727 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6729 * xdisp.c (check_it): Likewise.
6730 * xfaces.c (register_color, unregister_color, unregister_colors):
6732 * xfns.c (print_fontset_result): Likewise.
6733 * xrdb.c (member, fatal, main): Likewise.
6735 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6737 Fix minor problems found by static checking (Bug#9031).
6738 * chartab.c (char_table_set_range, map_sub_char_table):
6739 Remove unused locals.
6740 (uniprop_table): Now static.
6741 * composite.c (_work_char): Remove unused static var.
6743 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6745 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6747 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6749 * gtkutil.c (qttip_cb): Remove code without function.
6751 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6753 * w32.c (pthread_sigmask): New stub.
6755 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6757 Use pthread_sigmask, not sigprocmask (Bug#9010).
6758 sigprocmask is portable only for single-threaded applications, and
6759 Emacs can be multi-threaded when it uses GTK.
6760 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6762 * callproc.c (Fcall_process):
6763 * process.c (create_process):
6764 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6765 Use pthread_sigmask, not sigprocmask.
6767 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6769 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6770 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6773 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6775 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6776 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6777 (xg_hide_tooltip): Fix comment.
6779 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6780 in registerServicesMenuSendTypes.
6781 (validRequestorForSendType): Don't check ns_return_types.
6783 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6786 2011-07-08 Jason Rumney <jasonr@gnu.org>
6788 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6789 SH_SHOW for hidden windows (Bug#5482).
6791 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6792 frame struct members of non-existent frames (Bug#6284).
6794 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6796 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6797 variable firstTime not needed on OSX >= 10.6.
6798 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6799 >= 10.5. Use setKnobProportion, setDoubleValue.
6801 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6802 (MAC_OS_X_VERSION_10_5): Define if not defined.
6803 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6804 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6805 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6807 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6808 cString and lossyCString on OSX >= 10.4
6810 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6811 sizeToFit on OSX >= 10.2.
6813 * nsimage.m (allocInitFromFile): Don't use deprecated method
6814 bestRepresentationForDevice on OSX >= 10.6.
6816 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6819 * emacs.c: Declare unexec_init_emacs_zone.
6821 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6823 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6825 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6826 on svcsMenu (Bug#8842).
6828 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6830 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6832 * nsterm.m (QUTF8_STRING): Declare.
6833 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6834 (validRequestorForSendType): Return type is (id).
6835 Change indexOfObjectIdenticalTo to indexOfObject.
6836 Check if we have local selection before returning self (Bug#8842).
6837 (writeSelectionToPasteboard): Put local selection into paste board
6838 if we have a local selection (Bug#8842).
6839 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6841 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6842 (ns_get_local_selection): Declare.
6844 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6846 * keymap.c (describe_map_tree): Don't insert a double newline at
6847 the end of the buffer (bug#1169) and return whether we inserted
6850 * callint.c (Fcall_interactively): Change "reading args" to
6851 "providing args" to try to clarify what it does (bug#1010).
6853 2011-07-07 Kenichi Handa <handa@m17n.org>
6855 * composite.c (composition_compute_stop_pos): Ignore a static
6856 composition starting before CHARPOS (Bug#8915).
6858 * xdisp.c (handle_composition_prop): Likewise.
6860 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6862 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6865 2011-07-07 Kenichi Handa <handa@m17n.org>
6867 * character.h (unicode_category_t): New enum type.
6869 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6870 (Qchar_code_property_table): New variable.
6871 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6872 (UNIPROP_COMPRESSED_FORM_P): New macros.
6873 (char_table_ascii): Uncompress the compressed values.
6874 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6875 Uncompress the compressed values.
6876 (sub_char_table_ref_and_range): Likewise.
6877 (char_table_ref_and_range): Uncompress the compressed values.
6878 (sub_char_table_set): New arg is_uniprop. Callers changed.
6879 Uncompress the compressed values.
6880 (sub_char_table_set_range): Args changed. Callers changed.
6881 (char_table_set_range): Adjuted for the above change.
6882 (map_sub_char_table): Delete args default_val and parent. Add arg
6883 top. Give decoded values to a Lisp function.
6884 (map_char_table): Adjust for the above change. Give decoded
6885 values to a Lisp function. Gcpro more variables.
6886 (uniprop_table_uncompress)
6887 (uniprop_decode_value_run_length): New functions.
6888 (uniprop_decoder, uniprop_decoder_count): New variables.
6889 (uniprop_get_decoder, uniprop_encode_value_character)
6890 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6892 (uniprop_encoder, uniprop_encoder_count): New variables.
6893 (uniprop_get_encoder, uniprop_table)
6894 (Funicode_property_table_internal, Fget_unicode_property_internal)
6895 (Fput_unicode_property_internal): New functions.
6896 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6897 Sunicode_property_table_internal, Sget_unicode_property_internal,
6898 and Sput_unicode_property_internal. Defvar_lisp
6899 char-code-property-alist.
6901 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6902 Vunicode_category_table.
6904 * font.c (font_range): Adjust for the change of
6905 Vunicode_category_table.
6907 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6909 * m/iris4d.h: Remove file, move contents ...
6910 * s/irix6-5.h: ... here.
6912 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6914 Remove unportable assumption about struct layout (Bug#8884).
6915 * alloc.c (mark_buffer):
6916 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6917 (clone_per_buffer_values): Don't assume that
6918 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6919 This isn't true in general, and it's particularly not true
6920 if Emacs is configured with --with-wide-int.
6921 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6922 New macros, used in the buffer.c change.
6924 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6926 * xsettings.c: Use both GConf and GSettings if both are available.
6927 (store_config_changed_event): Add comment.
6928 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6929 (store_tool_bar_style_changed): New functions.
6930 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6931 (struct xsettings): Move font inside HAVE_XFT.
6932 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6933 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6934 Move inside HAVE_XFT.
6935 (something_changed_gsettingsCB): Rename from something_changedCB.
6936 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6938 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6939 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6940 (something_changed_gconfCB): Rename from something_changedCB.
6941 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6942 (parse_settings): Move check for font inside HAVE_XFT.
6943 (read_settings, apply_xft_settings): Add comment.
6944 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6945 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6946 call store_font_name_changed.
6947 (xft_settings_event): Add comment.
6948 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6949 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6950 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6951 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6952 (xsettings_initialize): Call init_gsettings last.
6953 (xsettings_get_system_font, xsettings_get_system_normal_font):
6956 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6958 Random fixes. E.g., (random) never returned negative values.
6959 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6960 subseconds part to the entropy, as that's a bit more random.
6961 Prefer signed to unsigned, since the signedness doesn't matter and
6962 in general we prefer signed. When given a limit, use a
6963 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6964 latter isn't right if USE_2_TAGS_FOR_INTS.
6965 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6966 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6968 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6970 * textprop.c (text_property_stickiness):
6971 Obey Vtext_property_default_nonsticky.
6972 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6973 * w32fns.c (syms_of_w32fns):
6974 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6976 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6978 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6979 This is more efficient than Ffile_directory_p and avoids a minor race.
6981 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6983 * buffer.c (Foverlay_put): Say what the return value is
6986 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6987 is a directory before asking whether to use the file name
6989 (barf_or_query_if_file_exists): Make the "File is a directory"
6990 error be more correct.
6992 * fns.c (Frequire): Remove the mention of the .gz files, since
6993 that's installation-specific, but keep the mention of
6994 `get-load-suffixes'.
6996 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6998 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6999 Report string overflow if the output is too long.
7001 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
7003 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7004 (syms_of_gnutls): Remove duplicate DEFSYM for
7005 Qgnutls_bootprop_verify_hostname_error, an error for
7006 Qgnutls_bootprop_verify_error (which is no longer used).
7008 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7009 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7010 Also (re)move comments that are misplaced or no longer relevant.
7012 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7014 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7016 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
7018 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7019 and background color parameters if they have been changed.
7021 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7023 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7025 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7027 * xsettings.c (SYSTEM_FONT): Define only when used.
7028 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7030 * keymap.c (access_keymap_1): Now static.
7032 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
7034 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7035 leave any prefix arg for the up event (Bug#1586).
7037 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7039 * lread.c (syms_of_lread): Mention single symbols defined by
7040 `defvar' or `defconst' (bug#7154).
7042 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7043 (Frequire): Mention get-load-suffixes.
7045 2011-07-02 Martin Rudalics <rudalics@gmx.at>
7047 * window.h (window): Remove clone_number slot.
7048 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7050 (make_parent_window, make_window, saved_window)
7051 (Fset_window_configuration, save_window_save): Don't deal with
7053 * buffer.c (Qclone_number): Remove declaration.
7054 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7056 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7058 Add multiple inheritance to keymaps.
7059 * keymap.c (Fmake_composed_keymap): New function.
7060 (Fset_keymap_parent): Simplify.
7061 (fix_submap_inheritance): Remove.
7062 (access_keymap_1): New function extracted from access_keymap to handle
7063 embedded parents and handle lists of maps.
7064 (access_keymap): Use it.
7065 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7066 (Fcopy_keymap): Handle embedded parents.
7067 (Fcommand_remapping, define_as_prefix): Simplify.
7068 (Fkey_binding): Simplify.
7069 (syms_of_keymap): Move minibuffer-local-completion-map,
7070 minibuffer-local-filename-completion-map,
7071 minibuffer-local-must-match-map, and
7072 minibuffer-local-filename-must-match-map to Elisp.
7073 (syms_of_keymap): Defsubr make-composed-keymap.
7074 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7075 (parse_menu_item): Trivial simplification.
7077 2011-07-01 Glenn Morris <rgm@gnu.org>
7079 * Makefile.in (SETTINGS_LIBS): Fix typo.
7081 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7083 * coding.c (Fencode_coding_string): Record the last coding system
7084 used, as the function doc string says (bug#8738).
7086 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7088 * xsettings.c (store_monospaced_changed): Take new font as arg and
7089 check for change against current_mono_font.
7090 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7091 (emacs_settings_constructor, emacs_settings_get_property)
7092 (emacs_settings_set_property, emacs_settings_class_init)
7093 (emacs_settings_init, gsettings_obj): Remove.
7094 (something_changedCB): New function for HAVE_GSETTINGS.
7095 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7096 with value as argument.
7097 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7098 g_settings_new (Bug#8967). Do not create gsettings_obj.
7099 Remove calls to g_settings_bind. Connect something_changedCB to
7102 * xgselect.c: Add defined (HAVE_GSETTINGS).
7103 (xgselect_initialize): Ditto.
7105 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7106 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7109 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7111 * eval.c (struct backtrace): Simplify and port the data structure.
7112 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7113 signed bit field, as this assumption is not portable and it makes
7114 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7115 "char debug_on_exit : 1" as this is not portable either; instead,
7116 use the portable "unsigned int debug_on_exit : 1". Remove unused
7117 member evalargs. Remove obsolete comments about cc bombing out.
7119 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7121 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
7122 Let HAVE_GSETTINGS override HAVE_GCONF.
7123 (store_monospaced_changed): New function.
7124 (EMACS_SETTINGS): A new type derived from GObject to handle
7125 GSettings notifications.
7126 (emacs_settings_constructor, emacs_settings_get_property)
7127 (emacs_settings_set_property, emacs_settings_class_init):
7129 (gsettings_client, gsettings_obj): New variables.
7130 (GSETTINGS_SCHEMA): New define.
7131 (something_changedCB): Call store_monospaced_changed.
7132 (init_gsettings): New function.
7133 (xsettings_initialize): Call init_gsettings.
7134 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7137 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
7140 2011-06-29 Martin Rudalics <rudalics@gmx.at>
7142 * window.c (resize_root_window, grow_mini_window)
7143 (shrink_mini_window): Rename Qresize_root_window to
7144 Qwindow_resize_root_window and Qresize_root_window_vertically to
7145 Qwindow_resize_root_window_vertically.
7147 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7149 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7151 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
7153 * makefile.w32-in: Redesign dependencies so they reflect more
7154 clearly which files are directly included by each source file,
7155 and not through other includes.
7157 2011-06-27 Martin Rudalics <rudalics@gmx.at>
7159 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7160 (sort_overlays, overlay_strings): When an overlay's clone number
7161 matches the window's clone number process the overlay even if
7162 the overlay's window property doesn't match the current window.
7164 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7165 (Fwindow_hchild): Rename to Fwindow_left_child.
7166 (Fwindow_next): Rename to Fwindow_next_sibling.
7167 (Fwindow_prev): Rename to Fwindow_prev_sibling.
7168 (resize_window_check): Rename to window_resize_check.
7169 (resize_window_apply): Rename to window_resize_apply.
7170 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7171 (Fdelete_other_windows_internal, resize_frame_windows)
7172 (Fsplit_window_internal, Fdelete_window_internal)
7173 (grow_mini_window, shrink_mini_window)
7174 (Fresize_mini_window_internal): Fix callers accordingly.
7176 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7178 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7179 (emacs_fixed_set_min_size): Remove.
7180 (emacs_fixed_new): Take frame as argument.
7182 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7183 (_EmacsFixedPrivate): Remove minwidth/height.
7184 Add struct frame *f.
7185 (emacs_fixed_init): Initialize priv->f.
7186 (get_parent_class, emacs_fixed_set_min_size): Remove.
7187 (emacs_fixed_new): Set priv->f to argument.
7188 (emacs_fixed_get_preferred_width)
7189 (emacs_fixed_get_preferred_height): Use min_width/height from
7190 frames size_hint to set minimum and natural (Bug#8919).
7191 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7192 and use min_width/height from frames size_hint to set
7193 min_width/height (Bug#8919).
7195 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
7196 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7199 2011-06-26 Eli Zaretskii <eliz@gnu.org>
7201 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7202 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7205 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
7207 * process.c (wait_reading_process_output): Bypass select if
7208 waiting for a cell while ignoring keyboard input, and input is
7209 pending. Suggested by Jan Djärv (Bug#8869).
7211 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7213 Use gnulib's dup2 module instead of rolling our own.
7214 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7216 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7218 * dispnew.c (scrolling_window): Before scrolling, turn off a
7219 mouse-highlight in the window being scrolled.
7221 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
7223 Move DEFSYM to lisp.h and use everywhere.
7225 * character.h (DEFSYM): Move declaration...
7226 * lisp.h (DEFSYM): ...here.
7232 * w32select.c: Don't include character.h.
7234 * alloc.c (syms_of_alloc):
7235 * buffer.c (syms_of_buffer):
7236 * bytecode.c (syms_of_bytecode):
7237 * callint.c (syms_of_callint):
7238 * casefiddle.c (syms_of_casefiddle):
7239 * casetab.c (init_casetab_once):
7240 * category.c (init_category_once, syms_of_category):
7241 * ccl.c (syms_of_ccl):
7242 * cmds.c (syms_of_cmds):
7243 * composite.c (syms_of_composite):
7244 * dbusbind.c (syms_of_dbusbind):
7245 * dired.c (syms_of_dired):
7246 * dispnew.c (syms_of_display):
7247 * doc.c (syms_of_doc):
7248 * editfns.c (syms_of_editfns):
7249 * emacs.c (syms_of_emacs):
7250 * eval.c (syms_of_eval):
7251 * fileio.c (syms_of_fileio):
7252 * fns.c (syms_of_fns):
7253 * frame.c (syms_of_frame):
7254 * fringe.c (syms_of_fringe):
7255 * insdel.c (syms_of_insdel):
7256 * keymap.c (syms_of_keymap):
7257 * lread.c (init_obarray, syms_of_lread):
7258 * macros.c (syms_of_macros):
7259 * msdos.c (syms_of_msdos):
7260 * print.c (syms_of_print):
7261 * process.c (syms_of_process):
7262 * search.c (syms_of_search):
7263 * sound.c (syms_of_sound):
7264 * syntax.c (init_syntax_once, syms_of_syntax):
7265 * terminal.c (syms_of_terminal):
7266 * textprop.c (syms_of_textprop):
7267 * undo.c (syms_of_undo):
7268 * w32.c (globals_of_w32):
7269 * window.c (syms_of_window):
7270 * xdisp.c (syms_of_xdisp):
7271 * xfaces.c (syms_of_xfaces):
7272 * xfns.c (syms_of_xfns):
7273 * xmenu.c (syms_of_xmenu):
7274 * xsettings.c (syms_of_xsettings):
7275 * xterm.c (syms_of_xterm): Use DEFSYM.
7277 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7279 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
7281 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7283 Integer and buffer overflow fixes (Bug#8873).
7285 * print.c (printchar, strout): Check for string overflow.
7286 (PRINTPREPARE, printchar, strout):
7287 Don't set size unless allocation succeeds.
7289 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7290 for sizes. Check for string overflow more accurately.
7291 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7293 * macros.c: Integer and buffer overflow fixes.
7294 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7295 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7296 Use ptrdiff_t, not int, for sizes.
7297 Don't increment bufsize until after realloc succeeds.
7298 Check for size-calculation overflow.
7299 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7301 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7303 * lread.c: Integer overflow fixes.
7304 (read_integer): Radix is now EMACS_INT, not int,
7305 to improve quality of diagnostics for out-of-range radices.
7306 Calculate buffer size correctly for out-of-range radices.
7307 (read1): Check for integer overflow in radices, and in
7308 read-circle numbers.
7309 (read_escape): Avoid int overflow.
7310 (Fload, openp, read_buffer_size, read1)
7311 (substitute_object_recurse, read_vector, read_list, map_obarray):
7312 Use ptrdiff_t, not int, for sizes.
7313 (read1): Use EMACS_INT, not int, for sizes.
7314 Check for size overflow.
7316 * image.c (cache_image): Check for size arithmetic overflow.
7318 * lread.c: Integer overflow issues.
7319 (saved_doc_string_size, saved_doc_string_length)
7320 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7321 Now ptrdiff_t, not int.
7322 (read1): Don't assume doc string length fits in int. Check for
7323 out-of-range doc string lengths.
7324 (read_list): Don't assume file position fits in int.
7325 (read_escape): Check for hex character overflow.
7327 2011-06-22 Leo Liu <sdl.web@gmail.com>
7329 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7330 Move to minibuffer.el.
7332 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7334 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
7335 The following patches are for when GLYPH_DEBUG && !XASSERT.
7336 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7337 * dispnew.c (flush_stdout):
7338 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7339 Mark as externally visible.
7340 * dispnew.c (check_window_matrix_pointers): Now static.
7341 * dispnew.c (window_to_frame_vpos):
7342 * xfns.c (unwind_create_frame):
7343 * xterm.c (x_check_font): Remove unused local.
7344 * scroll.c (CHECK_BOUNDS):
7345 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7346 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7347 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7348 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7349 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7351 (debug_method_add): Use va_list and vsprintf rather than relying
7352 on undefined behavior with wrong number of arguments.
7353 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7354 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7355 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7356 since we're not interested in debugging glyphs with old libraries.
7357 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7358 GCC 4.6.0's static checking.
7360 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7362 Integer overflow and signedness fixes (Bug#8873).
7363 A few related buffer overrun fixes, too.
7365 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7367 * dispextern.h (struct face.stipple):
7368 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7369 (x_bitmap_mask, x_allocate_bitmap_record)
7370 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7371 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7372 (x_create_bitmap_from_xpm_data):
7373 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7374 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7376 * xfaces.c (load_pixmap):
7377 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7378 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7379 (.bitmaps_last, struct x_output.icon_bitmap):
7380 Use ptrdiff_t, not int, for bitmap indexes.
7381 (x_allocate_bitmap_record): Check for size overflow.
7382 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7384 Use ptrdiff_t, not int, for overlay counts.
7385 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7386 * editfns.c (overlays_around, get_pos_property):
7387 * textprop.c (get_char_property_and_overlay):
7388 * xdisp.c (next_overlay_change, note_mouse_highlight):
7389 * xfaces.c (face_at_buffer_position):
7390 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7391 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7392 (Fnext_overlay_change, Fprevious_overlay_change)
7393 (mouse_face_overlay_overlaps, Foverlays_in):
7394 Use ptrdiff_t, not int, for sizes.
7395 (overlays_at, overlays_in): Check for size-calculation overflow.
7397 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7399 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7400 (x_session_initialize): Do not assume string length fits in int.
7402 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7403 This is unlikely, but can occur if DPI is outlandish.
7405 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
7406 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7408 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7409 * xrdb.c (magic_file_p, search_magic_path):
7410 Omit last arg SUFFIX; it was always 0. All callers changed.
7411 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7413 * xfont.c (xfont_match): Avoid need for strlen.
7415 * xfns.c: Don't assume strlen fits in int.
7416 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7418 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7419 not unsigned long, as we prefer signed integers. All callers changed.
7420 Detect integer overflow in repeat count.
7421 (message_dolog): Don't assume print length fits in 39 bytes.
7422 (display_mode_element): Don't assume strlen fits in int.
7424 * termcap.c: Don't assume sizes fit in int and never overflow.
7425 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7426 (gobble_line): Check for size-calculation overflow.
7428 * minibuf.c (Fread_buffer):
7429 * lread.c (intern, intern_c_string):
7430 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7431 Don't assume string length fits in int.
7433 * keyboard.c (parse_tool_bar_item):
7434 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7436 * font.c: Don't assume string length fits in int.
7437 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7438 Use ptrdiff_t, not int.
7439 (font_intern_prop): Don't assume string length fits in int.
7440 Don't assume integer property fits in fixnum.
7441 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
7443 * filelock.c: Fix some buffer overrun and integer overflow issues.
7444 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
7445 Reformulate so as not to need the command string.
7446 Invoke gzip -cd rather than gunzip, as it's more portable.
7447 (lock_info_type, lock_file_1, lock_file):
7448 Don't assume pid_t and time_t fit in unsigned long.
7449 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7450 (current_lock_owner): Prefer signed type for sizes.
7451 Use memcpy, not strncpy, where memcpy is what is really wanted.
7452 Don't assume (via atoi) that time_t and pid_t fit in int.
7453 Check for time_t and/or pid_t out of range, e.g., via a network share.
7454 Don't alloca where an auto var works fine.
7456 * fileio.c: Fix some integer overflow issues.
7457 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7458 Don't assume string length fits in int.
7459 (directory_file_name): Don't assume string length fits in long.
7460 (make_temp_name): Don't assume pid fits in int, or that its print
7461 length is less than 20.
7463 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7465 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7467 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7469 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7470 We prefer signed integers, even for size calculations.
7472 * emacs.c: Don't assume string length fits in 'int'.
7473 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7474 (main): Don't invoke strlen when not needed.
7476 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7477 (XD_DEBUG_MESSAGE): Don't waste a byte.
7479 * callproc.c (getenv_internal_1, getenv_internal)
7481 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7483 * lread.c (invalid_syntax): Omit length argument.
7484 All uses changed. This doesn't fix a bug, but it simplifies the
7485 code away from its former Hollerith-constant appearance, and it's
7486 one less 'int' to worry about when looking at integer-overflow issues.
7487 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
7489 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7490 This didn't break anything, but it didn't help either.
7491 It's confusing to put a bogus integer in a place where the actual
7492 value does not matter.
7493 (LIST_END_P): Remove unused macro and its bogus comment.
7494 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
7496 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7497 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7499 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7500 We prefer signed types, and the value cannot exceed the EMACS_INT
7501 range anyway (because otherwise the length would not be representable).
7502 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7503 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7504 This avoids a GCC warning when WIDE_EMACS_INT.
7506 * indent.c (sane_tab_width): New function.
7507 (current_column, scan_for_column, Findent_to, position_indentation)
7508 (compute_motion): Use it. This is just for clarity.
7509 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
7511 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
7513 * lisp.h (lint_assume): New macro.
7514 * composite.c (composition_gstring_put_cache):
7515 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7517 * editfns.c, insdel.c:
7518 Omit unnecessary forward decls, to simplify future changes.
7520 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7522 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7524 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
7525 Use much-faster test for byte-length change.
7526 Don't assume string byte-length fits in 'int'.
7527 Check that character arg fits in 'int'.
7528 (mapcar1): Declare byte as byte, for clarity.
7530 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7532 * fns.c (concat): Catch string overflow earlier.
7533 Do not rely on integer wraparound.
7535 * dispextern.h (struct it.overlay_strings_charpos)
7536 (struct it.selective): Now EMACS_INT, not int.
7537 * xdisp.c (forward_to_next_line_start)
7538 (back_to_previous_visible_line_start)
7539 (reseat_at_next_visible_line_start, next_element_from_buffer):
7540 Don't arbitrarily truncate the value of 'selective' to int.
7542 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7544 * composite.c: Don't truncate sizes to 'int'.
7545 (composition_gstring_p, composition_reseat_it)
7546 (composition_adjust_point): Use EMACS_INT, not int.
7547 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7548 not EMACS_UINT, for indexes.
7550 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7552 * buffer.c: Include <verify.h>.
7553 (struct sortvec.priority, struct sortstr.priority):
7554 Now EMACS_INT, not int.
7555 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7556 (struct sortstr.size, record_overlay_string)
7557 (struct sortstrlist.size, struct sortlist.used):
7558 Don't truncate size to int.
7559 (record_overlay_string): Check for size-calculation overflow.
7560 (init_buffer_once): Check at compile-time, not run-time.
7562 2011-06-22 Jim Meyering <meyering@redhat.com>
7564 Don't leak an XBM-image-sized buffer
7565 * image.c (xbm_load): Free the image buffer after using it.
7567 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7570 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7571 that Sun C diagnosed.
7572 * fns.c (secure_hash): Fix pointer signedness issue.
7573 * intervals.c (static_offset_intervals): New function.
7574 (offset_intervals): Use it.
7576 2011-06-21 Leo Liu <sdl.web@gmail.com>
7579 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7582 * fns.c (secure_hash): Rename from crypto_hash_function and change
7583 the first arg to accept symbols.
7584 (Fsecure_hash): New primitive.
7585 (syms_of_fns): New symbols.
7587 2011-06-20 Deniz Dogan <deniz@dogan.se>
7589 * process.c (Fset_process_buffer): Clarify return value in
7592 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7594 * dispnew.c (add_window_display_history): Use BVAR.
7596 * xdisp.c (debug_method_add): Use BVAR.
7597 (check_window_end, dump_glyph_matrix, dump_glyph)
7598 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7600 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7603 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7604 check till after the cache is created in init_frame_faces.
7606 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7608 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7610 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7612 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7613 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7614 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7616 Improve buffer-overflow checking (Bug#8873).
7617 * fileio.c (Finsert_file_contents):
7618 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7619 Remove the old (too-loose) buffer overflow checks.
7620 They weren't needed, since make_gap checks for buffer overflow.
7621 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7622 The old code merely checked for Emacs fixnum overflow, and relied
7623 on undefined (wraparound) behavior. The new code avoids undefined
7624 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7626 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7627 Tune. Don't use wider integers than needed. Don't use alloca.
7628 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7630 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7632 * insdel.c, lisp.h (buffer_overflow): New function.
7633 (insert_from_buffer_1, replace_range, replace_range_2):
7634 * insdel.c (make_gap_larger):
7635 * editfns.c (Finsert_char):
7636 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7638 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7640 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7642 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7644 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7645 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7647 * fileio.c: Don't assume EMACS_INT fits in off_t.
7648 (emacs_lseek): New static function.
7649 (Finsert_file_contents, Fwrite_region): Use it.
7650 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7652 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7654 * fns.c: Don't overflow int when computing a list length.
7655 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7656 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7657 truncation on 64-bit hosts. Check for QUIT every
7658 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7659 faster and is responsive enough.
7660 (Flength): Report an error instead of overflowing an integer.
7661 (Fsafe_length): Return a float if the value is not representable
7662 as a fixnum. This shouldn't happen except in contrived situations.
7663 (Fnthcdr, Fsort): Don't assume list length fits in int.
7664 (Fcopy_sequence): Don't assume vector length fits in int.
7666 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7667 (header_size, word_size): New constants.
7668 (allocate_vectorlike): Don't check size overflow here.
7669 (allocate_vector): Check it here instead, since this is the only
7670 caller of allocate_vectorlike that could cause overflow.
7671 Check that the new vector's length is representable as a fixnum.
7673 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7674 The previous code was bogus. For example, next_almost_prime (32)
7675 returned 39, which is undesirable as it is a multiple of 3; and
7676 next_almost_prime (24) returned 25, which is a multiple of 5 so
7677 why was the code bothering to check for multiples of 7?
7679 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7681 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7683 Variadic C functions now count arguments with ptrdiff_t.
7684 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7685 Back then I didn't know that the Emacs coding style prefers signed int.
7686 Also, in the meantime I found a few more instances where arguments
7687 were being counted with int, which may truncate counts on 64-bit
7688 machines, or EMACS_INT, which may be unnecessarily wide.
7689 * lisp.h (struct Lisp_Subr.function.aMANY)
7690 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7691 Arg counts are now ptrdiff_t, not size_t.
7692 All variadic functions and their callers changed accordingly.
7693 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7694 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7695 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7696 * callint.c (Fcall_interactively): Check arg count for overflow,
7697 to avoid potential buffer overrun. Use signed char, not 'int',
7698 for 'varies' array, so that we needn't bother to check its size
7699 calculation for overflow.
7700 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7701 * eval.c (apply_lambda):
7702 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7703 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7704 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7706 * callint.c (Fcall_interactively): Don't use index var as event count.
7708 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7709 * mem-limits.h (SIZE): Remove; no longer used.
7711 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7713 Remove unnecessary casts.
7714 * xterm.c (x_term_init):
7715 * xfns.c (x_set_border_pixel):
7716 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7717 These aren't needed now that we assume ANSI C.
7719 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7720 It's more likely to cause problems (due to unsigned overflow)
7723 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7725 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7727 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7729 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7731 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7733 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7735 GLYPH_CODE_FACE returns EMACS_INT, not int.
7736 * dispextern.h (merge_faces):
7737 * xfaces.c (merge_faces):
7738 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7739 Don't assume EMACS_INT fits in int.
7741 * character.h (CHAR_VALID_P): Remove unused parameter.
7742 * fontset.c, lisp.h, xdisp.c: All uses changed.
7744 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7746 * fns.c (concat): Minor tuning based on overflow analysis.
7747 This doesn't fix any bugs. Use int to hold character, instead
7748 of constantly refetching from Emacs object. Use XFASTINT, not
7749 XINT, for value known to be a character. Don't bother comparing
7750 a single byte to 0400, as it's always less.
7752 * floatfns.c (Fexpt):
7753 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7755 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7758 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7760 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7761 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7762 incorrectly succeed when S was a string, because 4294967386 was
7763 truncated before it was used.
7765 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7766 Otherwise, an out-of-range integer could cause undefined behavior
7769 * composite.c: Use int, not EMACS_INT, for characters.
7770 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7771 EMACS_INT, for values that are known to be in character range.
7772 This doesn't fix any bugs but is the usual style inside Emacs and
7773 may generate better code on 32-bit machines.
7775 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7776 This is for reasons similar to the recent CHAR_STRING fix.
7777 * charset.c (Fencode_char): Check that character arg is actually
7778 a character. Pass an int to ENCODE_CHAR.
7779 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7780 wider than 'int', as a compile-time check to prevent future regressions
7783 * character.c (char_string): Remove unnecessary casts.
7785 Make sure a 64-bit char is never passed to CHAR_STRING.
7786 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7787 by silently ignoring the top 32 bits, allowing some values
7788 that were far too large to be valid characters.
7789 * character.h: Include <verify.h>.
7790 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7791 arguments are no wider than unsigned, as a compile-time check
7792 to prevent future regressions in this area.
7794 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7795 (Fsubst_char_in_region):
7797 * xdisp.c (decode_mode_spec_coding):
7798 Adjust to CHAR_STRING's new requirement.
7799 * editfns.c (Finsert_char, Fsubst_char_in_region):
7800 * fns.c (concat): Check that character args are actually
7801 characters. Without this test, these functions did the wrong
7802 thing with wildly out-of-range values on 64-bit hosts.
7804 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7805 These casts should not be needed on 32-bit hosts, either.
7806 * keyboard.c (read_char):
7807 * lread.c (Fload): Remove casts to unsigned.
7809 * lisp.h (UNSIGNED_CMP): New macro.
7810 This fixes comparison bugs on 64-bit hosts.
7811 (ASCII_CHAR_P): Use it.
7812 * casefiddle.c (casify_object):
7813 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7814 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7815 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7816 * dispextern.h (FACE_FROM_ID):
7817 * keyboard.c (read_char): Use UNSIGNED_CMP.
7819 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7820 not to EMACS_INT, to avoid GCC warning.
7822 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7824 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7825 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7826 isn't needed on 32-bit machines.
7828 * buffer.c (Fgenerate_new_buffer_name):
7829 Use EMACS_INT for count, not int.
7830 (advance_to_char_boundary): Return EMACS_INT, not int.
7832 * data.c (Qcompiled_function): Now static.
7834 * window.c (window_body_lines): Now static.
7836 * image.c (gif_load): Rename local to avoid shadowing.
7838 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7839 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7840 * alloc.c (make_save_value): Integer argument is now of type
7842 (mark_object): Use ptrdiff_t, not int.
7843 * lisp.h (pD): New macro.
7844 * print.c (print_object): Use it.
7846 * alloc.c: Use EMACS_INT, not int, to count objects.
7847 (total_conses, total_markers, total_symbols, total_vector_size)
7848 (total_free_conses, total_free_markers, total_free_symbols)
7849 (total_free_floats, total_floats, total_free_intervals)
7850 (total_intervals, total_strings, total_free_strings):
7851 Now EMACS_INT, not int. All uses changed.
7852 (Fgarbage_collect): Compute overall total using a double, so that
7853 integer overflow is less likely to be a problem. Check for overflow
7854 when converting back to an integer.
7855 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7856 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7857 These were 'int' variables that could overflow on 64-bit hosts;
7858 they were never used, so remove them instead of repairing them.
7859 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7860 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7861 Previously, this ceilinged at INT_MAX, but that doesn't work on
7863 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7865 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7866 (allocate_vectorlike): Check for ptrdiff_t overflow.
7867 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7868 when a (possibly-narrower) signed value would do just as well.
7869 We prefer using signed arithmetic, to avoid comparison confusion.
7871 * alloc.c: Catch some string size overflows that we were missing.
7872 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7873 for convenience in STRING_BYTES_MAX.
7874 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7875 The definition here is exact; the one in lisp.h was approximate.
7876 (allocate_string_data): Check for string overflow. This catches
7877 some instances we weren't catching before. Also, it catches
7878 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7879 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7880 and ptrdiff_t and EMACS_INT are both 64 bits.
7882 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7883 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7884 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7886 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7888 * alloc.c (Fmake_string): Check for out-of-range init.
7890 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7892 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7894 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7896 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7897 xg_get_default_scrollbar_width.
7899 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7900 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7901 (style_changed_cb): Call update_theme_scrollbar_width and call
7902 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7903 all frames (Bug#8505).
7904 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7905 Call gtk_window_set_resizable if HAVE_GTK3.
7906 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7907 and height if HAVE_GTK3 (Bug#8505).
7908 (scroll_bar_width_for_theme): New variable.
7909 (update_theme_scrollbar_width): New function.
7910 (xg_get_default_scrollbar_width): Move code to
7911 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7912 (xg_initialize): Call update_theme_scrollbar_width.
7914 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7916 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7918 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7920 * frame.c (make_frame): Call other_buffer_safely instead of
7923 * window.c (temp_output_buffer_show): Call display_buffer with
7924 second argument Vtemp_buffer_show_specifiers and reset latter
7925 immediately after the call.
7926 (Vtemp_buffer_show_specifiers): New variable.
7927 (auto_window_vscroll_p, next_screen_context_lines)
7928 (Vscroll_preserve_screen_position): Remove leading asterisks from
7931 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7933 Fix minor problems found by GCC 4.6.0 static checking.
7934 * buffer.c (Qclone_number): Remove for now, as it's unused.
7935 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7936 (record_buffer): Remove unused local.
7937 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7938 (set_frame_buffer_list): Remove; unused.
7939 * frame.h (other_visible_frames): Remove decl.
7940 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7941 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7942 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7944 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7945 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7946 Define only if HAVE_GPM.
7947 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7948 (update_hints_inhibit): Remove; never set. All uses removed.
7949 * widgetprv.h (emacsFrameClassRec): Remove decl.
7950 * window.c (delete_deletable_window): Now returns void, since it
7951 wasn't returning anything.
7952 (compare_window_configurations): Remove unused locals.
7953 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7954 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7955 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7956 the same widths as pointers. This follows up on the 2011-05-06 patch.
7957 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7958 * xterm.h: Likewise.
7959 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7961 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7963 * makefile.w32-in: Update dependencies.
7964 (LISP_H): Add lib/intprops.h.
7966 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7968 * image.c (gif_load): Add animation frame delay to the metadata.
7969 (syms_of_image): Use DEFSYM. New symbol `delay'.
7971 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7973 * window.c (delete_deletable_window): Re-add.
7974 (Fset_window_configuration): Rewrite to handle dead buffers and
7975 consequently deletable windows.
7976 (window_tree, Fwindow_tree): Remove. Supply functionality in
7978 (compare_window_configurations): Simplify code.
7980 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7982 * image.c (imagemagick_load_image): Fix type mismatch.
7983 (Fimagemagick_types): Likewise.
7985 * window.h (replace_buffer_in_windows): Declare.
7987 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7989 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7990 Qclone_number. Remove external declaration of Qdelete_window.
7991 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7993 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7994 Run Qbuffer_list_update_hook if allowed.
7995 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7996 buffer list implementation.
7997 (other_buffer_safely): New function.
7998 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7999 calls to replace_buffer_in_windows and
8000 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8002 (record_buffer): Inhibit quitting and rewrite using quittable
8003 functions. Run Qbuffer_list_update_hook if allowed.
8004 (Frecord_buffer, Funrecord_buffer): New functions.
8005 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8006 Move switch-to-buffer to window.el.
8007 (bury-buffer): Move to window.el.
8008 (Vbuffer_list_update_hook): New variable.
8010 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8013 * window.h (resize_frame_windows): Move up in code.
8014 (Fwindow_frame): Remove EXFUN.
8015 (replace_buffer_in_all_windows): Remove prototype.
8016 (replace_buffer_in_windows_safely): Add prototype.
8018 * window.c: Declare Qdelete_window static again. Move down
8019 declaration of select_count.
8020 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8021 (Fother_window): Move to window.el.
8022 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8023 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8024 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8026 (replace_buffer_in_windows): Implement by calling
8027 Qreplace_buffer_in_windows.
8028 (replace_buffer_in_all_windows): Remove with some functionality
8029 moved into replace_buffer_in_windows_safely.
8030 (replace_buffer_in_windows_safely): New function.
8031 (select_window_norecord, select_frame_norecord): Move in front
8032 of run_window_configuration_change_hook. Remove now obsolete
8034 (Fset_window_buffer): Rewrite doc-string.
8035 Call Qrecord_window_buffer.
8036 (keys_of_window): Move binding for other-window to window.el.
8038 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8040 * dispextern.h (struct image): Replace data member, whose int_val
8041 and ptr_val fields were not used by anything, with a single
8044 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8045 (gif_clear_image, gif_load, imagemagick_load_image)
8046 (gs_clear_image, gs_load): Callers changed.
8048 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8050 * buffer.h: Include <time.h>, for time_t.
8051 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8053 Fix minor problems found by static checking.
8055 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8057 Make identifiers static if they are not used in other modules.
8058 * data.c (Qcompiled_function, Qframe, Qvector):
8059 * image.c (QimageMagick, Qsvg):
8060 * minibuf.c (Qmetadata):
8061 * window.c (resize_window_check, resize_root_window): Now static.
8062 * window.h (resize_window_check, resize_root_window): Remove decls.
8064 * window.c (window_deletion_count, delete_deletable_window):
8066 (window_body_lines): Now static.
8067 (Fdelete_other_windows_internal): Mark vars as initialized.
8068 Make sure 'resize_failed' is initialized.
8069 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8070 (resize_window_apply): Remove unused local.
8071 * window.h (delete_deletable_window): Remove decl.
8073 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
8074 (imagemagick_load_image): Fix pointer signedness problem by changing
8075 last arg from unsigned char * to char *. All uses changed.
8076 Also, fix a local for similar reasons.
8077 Remove unused locals. Remove locals to avoid shadowing.
8078 (fn_rsvg_handle_free): Remove; unused.
8079 (svg_load, svg_load_image): Fix pointer signedness problem.
8080 (imagemagick_load_image): Don't use garbage pointer image_wand.
8082 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8084 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
8086 * image.c (gif_load): Fix omitted cast error introduced by
8089 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8091 * window.h (resize_proportionally, orig_total_lines)
8092 (orig_top_line): Remove from window structure.
8093 (set_window_height, set_window_width, change_window_heights)
8094 (Fdelete_window): Remove prototypes.
8095 (resize_frame_windows): Remove duplicate declaration.
8097 2011-06-10 Eli Zaretskii <eliz@gnu.org>
8099 * window.h (resize_frame_windows, resize_window_check)
8100 (delete_deletable_window, resize_root_window)
8101 (resize_frame_windows): Declare prototypes.
8103 * window.c (resize_window_apply): Make definition be "static" to
8104 match the prototype.
8106 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8108 * window.c: Remove declarations of Qwindow_size_fixed,
8109 window_min_size_1, window_min_size_2, window_min_size,
8110 size_window, window_fixed_size_p, enlarge_window, delete_window.
8111 Remove static from declaration of Qdelete_window, it's
8112 temporarily needed by Fbury_buffer.
8113 (replace_window): Don't assign orig_top_line and
8115 (Fdelete_window, delete_window): Remove. Window deletion is
8116 handled by window.el.
8117 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8118 Replace Fdelete_window calls with calls to Qdelete_window.
8119 (Fdelete_other_windows): Remove. Deleting other windows is
8120 handled by window.el.
8121 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8122 handled in window.el.
8123 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8124 Window minimum sizes are handled in window.el.
8125 (shrink_windows, size_window, set_window_height)
8126 (set_window_width, change_window_heights, window_height)
8127 (window_width, CURBEG, CURSIZE, enlarge_window)
8128 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8129 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8130 handled in window.el.
8131 (make_dummy_parent): Rename to make_parent_window and give it a
8132 second argument horflag.
8133 (make_window): Don't set resize_proportionally any more.
8134 (Fsplit_window): Remove. Windows are split in window.el.
8135 (save_restore_action, save_restore_orig_size)
8136 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8137 Resize mini windows in window.el.
8138 (grow_mini_window, shrink_mini_window): Implement by calling
8139 Qresize_root_window_vertically, resize_window_check and
8140 resize_window_apply.
8141 (saved_window, Fset_window_configuration, save_window_save):
8142 Do not handle orig_top_line, orig_total_lines, and
8143 resize_proportionally.
8144 (window_min_height, window_min_width): Move to window.el.
8145 (keys_of_window): Move bindings for delete-other-windows,
8146 split-window, delete-window and enlarge-window to window.el.
8148 * buffer.c: Temporarily extern Qdelete_window.
8149 (Fbury_buffer): Temporarily call Qdelete_window instead of
8150 Fdelete_window (Fbury_buffer will move to window.el soon).
8152 * frame.c (set_menu_bar_lines_1): Remove code handling
8153 orig_top_line and orig_total_lines.
8155 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8156 set_window_height but set heights directly.
8157 (change_frame_size_1): Use resize_frame_windows.
8159 * xdisp.c (init_xdisp): Don't use set_window_height but set
8162 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8163 Use resize_frame_windows instead of change_window_heights and run
8164 run_window_configuration_change_hook.
8166 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8167 instead of change_window_heights and run
8168 run_window_configuration_change_hook.
8170 2011-06-09 Martin Rudalics <rudalics@gmx.at>
8172 * window.c (replace_window): Rename second argument REPLACEMENT to
8173 NEW. New third argument SETFLAG. Rewrite.
8174 (delete_window, make_dummy_parent): Call replace_window with
8176 (window_list_1): Move down in code.
8177 (run_window_configuration_change_hook): Move set_buffer part
8178 before select_frame_norecord part in order to unwind correctly.
8179 Rename count1 to count.
8180 (recombine_windows, delete_deletable_window, resize_root_window)
8181 (Fdelete_other_windows_internal)
8182 (Frun_window_configuration_change_hook, make_parent_window)
8183 (resize_window_check, resize_window_apply, Fresize_window_apply)
8184 (resize_frame_windows, Fsplit_window_internal)
8185 (Fdelete_window_internal, Fresize_mini_window_internal):
8187 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8189 2011-06-08 Martin Rudalics <rudalics@gmx.at>
8191 * window.h (window): Add some new members to window structure -
8192 normal_lines, normal_cols, new_total, new_normal, clone_number,
8193 splits, nest, prev_buffers, next_buffers.
8194 (WINDOW_TOTAL_SIZE): Move here from window.c.
8195 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
8197 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8199 (make_dummy_parent): Set new members of windows structure.
8200 (make_window): Move down in code. Handle new members of window
8202 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8203 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8204 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8205 (Fset_window_prev_buffers, Fwindow_next_buffers)
8206 (Fset_window_next_buffers, Fset_window_clone_number):
8208 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8209 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8211 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8212 Argument WINDOW can be now internal window too.
8213 (Fwindow_use_time): Move up in code.
8214 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8216 (Fset_window_configuration, saved_window)
8217 (Fcurrent_window_configuration, save_window_save): Handle new
8218 members of window structure.
8219 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8220 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8221 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8222 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8223 Qget_mru_window, Qresize_root_window,
8224 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8225 Qauto_buffer_name; staticpro them.
8227 2011-06-07 Martin Rudalics <rudalics@gmx.at>
8229 * window.c (Fwindow_total_size, Fwindow_left_column)
8230 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8231 (Fwindow_list_1): New functions.
8232 (window_box_text_cols): Replace with window_body_cols.
8233 (Fwindow_width, Fscroll_left, Fscroll_right):
8234 Use window_body_cols instead of window_box_text_cols.
8235 (delete_window, Fset_window_configuration):
8236 Call delete_all_subwindows with window as argument.
8237 (delete_all_subwindows): Take a window as argument and not a
8239 (window_loop): Remove handling of GET_LRU_WINDOW and
8241 (Fget_lru_window, Fget_largest_window): Move to window.el.
8243 * window.h: Extern window_body_cols instead of
8244 window_box_text_cols. delete_all_subwindows now takes a
8245 Lisp_Object as argument.
8247 * indent.c (compute_motion, Fcompute_motion):
8248 Use window_body_cols instead of window_box_text_cols.
8250 * frame.c (delete_frame): Call delete_all_subwindows with root
8253 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8255 * fns.c (Fputhash): Document return value.
8257 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
8259 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8261 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8263 Cons<->int and similar integer overflow fixes (Bug#8794).
8265 Check for overflow when converting integer to cons and back.
8266 * charset.c (Fdefine_charset_internal, Fdecode_char):
8267 Use cons_to_unsigned to catch overflow.
8268 (Fencode_char): Use INTEGER_TO_CONS.
8269 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8270 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8271 * data.c (long_to_cons, cons_to_long): Remove.
8272 (cons_to_unsigned, cons_to_signed): New functions.
8273 These signal an error for invalid or out-of-range values.
8274 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8275 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8276 * font.c (Ffont_variation_glyphs):
8277 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8278 * lisp.h: Include <intprops.h>.
8279 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8280 (cons_to_signed, cons_to_unsigned): New decls.
8281 (long_to_cons, cons_to_long): Remove decls.
8282 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8283 (Fprimitive_undo): Use CONS_TO_INTEGER.
8284 * xfns.c (Fx_window_property): Likewise.
8285 * xselect.c: Include <limits.h>.
8286 (x_own_selection, selection_data_to_lisp_data):
8287 Use INTEGER_TO_CONS.
8288 (x_handle_selection_request, x_handle_selection_clear)
8289 (x_get_foreign_selection, Fx_disown_selection_internal)
8290 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8291 (lisp_data_to_selection_data): Use cons_to_unsigned.
8292 (x_fill_property_data): Use cons_to_signed.
8293 Report values out of range.
8295 Check for buffer and string overflow more precisely.
8296 * buffer.h (BUF_BYTES_MAX): New macro.
8297 * lisp.h (STRING_BYTES_MAX): New macro.
8298 * alloc.c (Fmake_string):
8299 * character.c (string_escape_byte8):
8300 * coding.c (coding_alloc_by_realloc):
8301 * doprnt.c (doprnt):
8302 * editfns.c (Fformat):
8304 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8305 since they may not be the same number.
8306 * editfns.c (Finsert_char):
8307 * fileio.c (Finsert_file_contents):
8308 Likewise for BUF_BYTES_MAX.
8310 * image.c: Use ptrdiff_t, not int, for sizes.
8311 (slurp_file): Switch from int to ptrdiff_t.
8313 (slurp_file): Check that file size fits in both size_t (for
8314 malloc) and ptrdiff_t (for sanity and safety).
8316 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8317 if b->modtime has its maximal value.
8319 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8321 Don't assume time_t can fit into int.
8322 * buffer.h (struct buffer.modtime): Now time_t, not int.
8323 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8324 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8326 Minor fixes for signed vs unsigned integers.
8327 * character.h (MAYBE_UNIFY_CHAR):
8328 * charset.c (maybe_unify_char):
8329 * keyboard.c (read_char, reorder_modifiers):
8330 XINT -> XFASTINT, since the integer must be nonnegative.
8331 * ftfont.c (ftfont_spec_pattern):
8332 * keymap.c (access_keymap, silly_event_symbol_error):
8333 XUINT -> XFASTINT, since the integer must be nonnegative.
8334 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8335 since it makes no difference and we prefer signed.
8336 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8337 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8340 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8342 * window.h (Fwindow_frame): Declare.
8344 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8346 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8347 (SPARE_MEMORY): Always define.
8348 (LARGE_REQUEST): Remove.
8349 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8351 2011-06-06 Martin Rudalics <rudalics@gmx.at>
8353 * lisp.h: Move EXFUNS for Fframe_root_window,
8354 Fframe_first_window and Fset_frame_selected_window to window.h.
8356 * window.h: Move EXFUNS for Fframe_root_window,
8357 Fframe_first_window and Fset_frame_selected_window here from
8360 * frame.c (Fwindow_frame, Fframe_first_window)
8361 (Fframe_root_window, Fframe_selected_window)
8362 (Fset_frame_selected_window): Move to window.c.
8363 (Factive_minibuffer_window): Move to minibuf.c.
8364 (Fother_visible_frames_p): New function.
8366 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8368 * window.c (decode_window, decode_any_window): Move up in code.
8369 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8370 (inhibit_frame_unsplittable): Remove unused variable.
8371 (Fwindow_buffer): Move up and rewrite doc-string.
8372 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8373 (Fwindow_prev): New functions.
8374 (Fwindow_frame): Move here from frame.c. Accept any window as
8376 (Fframe_root_window, Fframe_first_window)
8377 (Fframe_selected_window): Move here from frame.c. Accept frame
8378 or arbitrary window as argument. Update doc-strings.
8379 (Fminibuffer_window): Move up in code.
8380 (Fwindow_minibuffer_p): Move up in code and simplify.
8381 (Fset_frame_selected_window): Move here from frame.c.
8383 (Fselected_window, select_window, Fselect_window): Move up in
8384 code. Minor doc-string fixes.
8386 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8388 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8389 Do not assume that spare memory exists; that assumption is valid
8390 only if SYSTEM_MALLOC.
8391 (LARGE_REQUEST): New macro, so that the issue of large requests
8392 is separated from the issue of spare memory.
8394 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8396 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8399 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8401 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8404 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8406 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8408 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8410 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8411 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8413 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
8415 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8417 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
8419 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8420 (x_clipboard_manager_save): Add return value.
8421 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8423 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8424 Obey Vx_select_enable_clipboard_manager. Catch errors in
8425 x_clipboard_manager_save (Bug#8779).
8426 (Vx_select_enable_clipboard_manager): New variable.
8427 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
8429 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8431 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8433 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8435 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8436 in the current matrix if keep_current_p is non-zero.
8438 2011-06-04 Eli Zaretskii <eliz@gnu.org>
8440 * bidi.c (bidi_level_of_next_char): Fix last change.
8442 2011-06-03 Eli Zaretskii <eliz@gnu.org>
8444 Support bidi reordering of text covered by display properties.
8446 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8447 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8448 (bidi_cache_search, bidi_cache_iterator_state)
8449 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
8450 (bidi_level_of_next_char, bidi_move_to_visually_next):
8451 Support character positions inside a run of characters covered by a
8453 (bidi_paragraph_init, bidi_resolve_explicit_1)
8454 (bidi_level_of_next_char): Call bidi_fetch_char and
8455 bidi_fetch_char_advance instead of FETCH_CHAR and
8457 (bidi_init_it): Initialize new members.
8458 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8460 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8461 instead of using explicit *_CHAR codes.
8462 (bidi_resolve_explicit, bidi_resolve_weak):
8463 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
8464 bidirectional text is supported only in multibyte buffers.
8465 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8466 it to initialize the frame_window_p member of struct bidi_it.
8467 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8468 (bidi_resolve_explicit, bidi_resolve_weak)
8469 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8470 bidi_it->nchars is non-positive.
8471 (bidi_level_of_next_char): Don't try to lookup the cache for the
8472 next/previous character if nothing is cached there yet, or if we
8473 were just reseat()'ed to a new position.
8475 * xdisp.c (set_cursor_from_row): Set start and stop points
8476 according to the row's direction when priming the loop that looks
8477 for the glyph on which to display cursor.
8478 (single_display_spec_intangible_p): Function deleted.
8479 (display_prop_intangible_p): Reimplement to call
8480 handle_display_spec instead of single_display_spec_intangible_p.
8481 Accept 3 additional arguments needed by handle_display_spec.
8482 This fixes incorrect cursor motion across display property with complex
8483 values: lists, `(when COND...)' forms, etc.
8484 (single_display_spec_string_p): Support property values that are
8485 lists with the argument STRING its top-level element.
8486 (display_prop_string_p): Fix the condition for processing a
8487 property that is a list to be consistent with handle_display_spec.
8488 (handle_display_spec): New function, refactored from the
8489 last portion of handle_display_prop.
8490 (compute_display_string_pos): Accept additional argument
8491 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8492 value of a `display' property is a "replacing spec".
8493 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8494 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8495 the display property, but just return a value indicating whether
8496 the display property will replace the characters it covers.
8497 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8498 frame_window_p members of struct bidi_it.
8499 (compute_display_string_pos, compute_display_string_end):
8501 (push_it): Accept second argument POSITION, where pop_it should
8502 jump to continue iteration.
8503 (reseat_1): Initialize bidi_it.disp_pos.
8505 * keyboard.c (adjust_point_for_property): Adjust the call to
8506 display_prop_intangible_p to its new signature.
8508 * dispextern.h (struct bidi_it): New member frame_window_p.
8509 (bidi_init_it): Update prototypes.
8510 (display_prop_intangible_p): Update prototype.
8511 (compute_display_string_pos, compute_display_string_end):
8513 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8516 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
8518 Malloc failure behavior now depends on size of allocation.
8519 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8520 * lisp.h: Change signatures accordingly.
8521 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8522 All callers changed. (Bug#8762)
8524 * gnutls.c: Use Emacs's memory allocators.
8525 Without this change, the gnutls library would invoke malloc etc.
8526 directly, which causes problems on non-SYNC_INPUT hosts, and which
8527 runs afoul of improving memory_full behavior. (Bug#8761)
8528 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8529 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8530 xfree instead of the default malloc, realloc, free.
8531 (Fgnutls_boot): No need to check for memory allocation failure,
8532 since xmalloc does that for us.
8534 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
8535 * category.c (hash_get_category_set):
8536 * ccl.c (ccl_driver):
8537 * charset.c (Fdefine_charset_internal):
8538 * charset.h (struct charset.hash_index):
8539 * composite.c (get_composition_id, gstring_lookup_cache)
8540 (composition_gstring_put_cache):
8541 * composite.h (struct composition.hash_index):
8542 * dispextern.h (struct image.hash):
8543 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8544 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8545 (hashfn_equal, hashfn_user_defined, make_hash_table)
8546 (maybe_resize_hash_table, hash_lookup, hash_put)
8547 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8548 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8549 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8550 * image.c (make_image, search_image_cache, lookup_image)
8551 (xpm_put_color_table_h):
8552 * lisp.h (struct Lisp_Hash_Table):
8553 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8554 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8555 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8556 * alloc.c (allocate_vectorlike):
8557 Check for overflow in vector size calculations.
8558 * ccl.c (ccl_driver):
8559 Check for overflow when converting EMACS_INT to int.
8560 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8561 need to be updated by these changes.
8562 * fns.c (make_hash_table, maybe_resize_hash_table):
8563 Check for integer overflow with large hash tables.
8564 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8565 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8566 (SXHASH_REDUCE): New macro.
8567 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8568 Use it instead of discarding useful hash info with large hash values.
8569 (sxhash_float): New function.
8570 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8571 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8572 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8573 Rewrite to use FIXNUM_BITS, as this simplifies things.
8574 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8575 Adjust signatures to match updated version of code.
8576 (consing_since_gc): Now EMACS_INT, since a single hash table can
8577 use more than INT_MAX bytes.
8579 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8581 Make it possible to build with GCC-4.6+ -O2 -flto.
8583 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8585 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8587 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8588 Call minibuffer-inactive-mode.
8590 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8592 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8593 Update dependencies.
8595 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8597 * data.c (init_data): Remove code for UTS, this system is not
8600 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8602 Don't force ./temacs to start in terminal mode.
8604 * frame.c (make_initial_frame): Initialize faces in all cases, not
8605 only when CANNOT_DUMP is defined.
8606 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8608 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8610 * dispnew.c (add_window_display_history): Use const for the string
8611 pointer. Remove declaration, not needed.
8613 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8615 Use 'inline', not 'INLINE'.
8616 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8617 * alloc.c, fontset.c (INLINE): Remove.
8618 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8619 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8620 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8621 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8622 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8624 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8626 Make it possible to run ./temacs.
8628 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8629 syms_of_callproc does the same thing. Remove test for
8630 "initialized", do it in the caller.
8631 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8633 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8635 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8636 (read_minibuf): Use get_minibuffer.
8637 (syms_of_minibuf): Use DEFSYM.
8638 (Qmetadata): New var.
8639 * data.c (Qbuffer): Don't make it static.
8640 (syms_of_data): Use DEFSYM.
8642 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8644 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8645 (CCL_CODE_MIN): New macro.
8647 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8649 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8651 * eval.c (Qdebug): Now static.
8652 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8653 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8654 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8656 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8658 * image.c: Various fixes to ImageMagick code comments.
8659 (Fimagemagick_types): Doc fix.
8661 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8663 Minor fixes prompted by GCC 4.6.0 warnings.
8665 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8667 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8668 (x_clipboard_manager_save_all): Move extern decl to ...
8669 * xterm.h: ... here, so that it can be checked for consistency.
8671 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8673 * xselect.c (x_clipboard_manager_save_frame)
8674 (x_clipboard_manager_save_all): New functions.
8675 (Fx_clipboard_manager_save): Lisp function deleted.
8677 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8678 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8680 * xterm.h: Update prototype.
8682 2011-05-28 William Xu <william.xwl@gmail.com>
8684 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8687 2011-05-28 Jim Meyering <meyering@redhat.com>
8689 Avoid a sign-extension bug in crypto_hash_function.
8690 * fns.c (to_uchar): Define.
8691 (crypto_hash_function): Use it to convert some newly-signed
8692 variables to unsigned, to avoid sign-extension bugs. For example,
8693 without this change, (md5 "truc") would evaluate to
8694 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8695 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8696 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8698 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8700 Integer overflow fixes.
8702 * dbusbind.c: Serial number integer overflow fixes.
8703 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8704 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8705 to hold a serial number that is too large for a fixnum.
8706 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8707 Check for serial numbers out of range. Decode any serial number
8708 that was so large that it became a float. (Bug#8722)
8710 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8711 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8712 Use XFASTINT rather than XUINT when numbers are nonnegative.
8713 (xd_append_arg, Fdbus_method_return_internal):
8714 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8715 arguments, check that Lisp number is nonnegative, rather than
8716 silently wrapping negative numbers around. (Bug#8722)
8717 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8720 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8722 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8724 ccl: Add integer overflow checks.
8725 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8726 (IN_INT_RANGE): New macros.
8727 (ccl_driver): Use them to check for integer overflow when
8728 decoding a CCL program. Many of the new checks are whether XINT (x)
8729 fits in int; it doesn't always, on 64-bit hosts. The new version
8730 doesn't catch all possible integer overflows, but it's an
8731 improvement. (Bug#8719)
8733 * alloc.c (make_event_array): Use XINT, not XUINT.
8734 There's no need for unsigned here.
8736 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8737 This follows up to the 2011-05-06 change that substituted uintptr_t
8738 for EMACS_INT. This case wasn't caught back then.
8740 Rework Fformat to avoid integer overflow issues.
8741 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8742 now (part of C89). Include <verify.h>.
8743 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8744 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8745 (Fformat): Avoid the prepass trying to compute sizes; it was only
8746 approximate and thus did not catch overflow reliably. Instead, walk
8747 through the format just once, formatting and computing sizes as we go,
8748 checking for integer overflow at every step, and allocating a larger
8749 buffer as needed. Keep track separately whether the format is
8750 multibyte. Keep only the most-recently calculated precision, rather
8751 than them all. Record whether each argument has been converted to
8752 string. Use EMACS_INT, not int, for byte and char and arg counts.
8753 Support field widths and precisions larger than INT_MAX. Avoid
8754 sprintf's undefined behavior with conversion specifications such as %#d
8755 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8756 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8757 formatting out-of-range floating point numbers with int
8760 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8762 * data.c: Avoid integer truncation in expressions involving floats.
8763 * data.c: Include <intprops.h>.
8764 (arith_driver): When there's an integer overflow in an expression
8765 involving floating point, convert the integers to floating point
8766 so that the resulting value does not suffer from catastrophic
8767 integer truncation. For example, on a 64-bit host (* 4
8768 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8769 Do not rely on undefined behavior after integer overflow.
8771 merge count_size_as_multibyte, parse_str_to_multibyte
8772 * character.c, character.h (count_size_as_multibyte):
8773 Rename from parse_str_to_multibyte; all uses changed.
8774 Check for integer overflow.
8775 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8776 since it's now a duplicate of the other. This is more of
8777 a character than a buffer op, so better that it's in character.c.
8778 * fns.c, print.c: Adjust to above changes.
8780 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8782 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8784 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8786 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8787 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8788 (x_clipboard_manager_save): Now static.
8789 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8791 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8792 (crypto_hash_function): Now static.
8793 Fix pointer signedness problems. Avoid unnecessary initializations.
8795 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8797 * termhooks.h (Vselection_alist): Make it terminal-local.
8799 * terminal.c (create_terminal): Initialize it.
8801 * xselect.c: Support for clipboard managers.
8802 (Vselection_alist): Move to termhooks.h as terminal-local var.
8803 (LOCAL_SELECTION): New macro.
8804 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8805 (symbol_to_x_atom): Remove gratuitous arg.
8806 (x_handle_selection_request, lisp_data_to_selection_data)
8807 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8808 (x_own_selection, x_get_local_selection, x_convert_selection):
8809 New arg, specifying work frame. Use terminal-local Vselection_alist.
8810 (some_frame_on_display): Delete unused function.
8811 (Fx_own_selection_internal, Fx_get_selection_internal)
8812 (Fx_disown_selection_internal, Fx_selection_owner_p)
8813 (Fx_selection_exists_p): New optional frame arg.
8814 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8815 (x_handle_selection_clear): Don't treat other terminals with the
8816 same keyboard specially. Use the terminal-local Vselection_alist.
8817 (x_clear_frame_selections): Use Frun_hook_with_args.
8819 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8821 * xterm.h: Add support for those atoms.
8823 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8825 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8826 (converted_selections, conversion_fail_tag): New global variables.
8827 (x_selection_request_lisp_error): Free the above.
8828 (x_get_local_selection): Remove unnecessary code.
8829 (x_reply_selection_request): Args changed; handle arbitrary array
8830 of converted selections stored in converted_selections.
8831 Separate the XChangeProperty and SelectionNotify steps.
8832 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8833 (x_convert_selection): New function.
8834 (x_handle_selection_event): Simplify.
8835 (x_get_foreign_selection): Don't ignore incoming requests while
8836 waiting for an answer; this will fail when we implement
8837 SAVE_TARGETS, and seems unnecessary anyway.
8838 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8839 (Vx_sent_selection_functions): Doc fix.
8841 2011-05-26 Leo Liu <sdl.web@gmail.com>
8843 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8845 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8847 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8849 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8850 for fringe update if it has periodic bitmap.
8851 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8852 and fringe_bitmap_periodic_p.
8854 * fringe.c (get_fringe_bitmap_data): New function.
8855 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8856 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8857 row. Mark glyph row for fringe update if periodicity changed.
8859 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8860 for fringe update unless it has periodic bitmap.
8862 2011-05-25 Kenichi Handa <handa@m17n.org>
8864 * xdisp.c (get_next_display_element): Set correct it->face_id for
8865 a static composition.
8867 2011-05-24 Leo Liu <sdl.web@gmail.com>
8870 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8872 * fns.c (crypto_hash_function, Fsha1): New function.
8873 (Fmd5): Use crypto_hash_function.
8874 (syms_of_fns): Add Ssha1.
8876 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8878 * gnutls.c: Remove unused macros.
8879 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8880 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8881 Remove macros that are defined and never used.
8882 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8884 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8886 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8887 (Fx_get_selection_internal): Minor cleanup.
8888 (Fx_own_selection_internal): Rename arguments for consistency with
8891 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8893 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8895 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8897 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8899 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8901 * dispnew.c (scrolling_window): Don't exclude the case that the
8902 last enabled row in the desired matrix touches the bottom boundary.
8904 2011-05-21 Glenn Morris <rgm@gnu.org>
8906 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8907 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8908 and add some more files.
8910 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8912 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8913 report_file_error introduced by the change from 2011-05-07.
8915 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8917 * systime.h (Time): Define only if emacs is defined.
8918 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8919 where the include path doesn't have X11/X.h by default. See
8920 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8922 2011-05-20 Kenichi Handa <handa@m17n.org>
8924 * composite.c (find_automatic_composition): Fix previous change.
8926 2011-05-20 Glenn Morris <rgm@gnu.org>
8928 * lisp.mk: New file, split from Makefile.in.
8929 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8930 (shortlisp): Remove.
8931 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8933 2011-05-19 Glenn Morris <rgm@gnu.org>
8935 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8936 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8937 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8938 (lisp): Set the order to that of loadup.el.
8939 (shortlisp): Make it a copy of $lisp.
8940 (SOME_MACHINE_LISP): Remove.
8941 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8942 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8944 2011-05-18 Kenichi Handa <handa@m17n.org>
8946 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8947 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8948 (find_automatic_composition): Mostly rewrite for efficiency.
8950 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8952 * makefile.w32-in: Update dependencies.
8954 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8956 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8957 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8959 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8961 Fix some integer overflow issues, such as string length overflow.
8963 * insdel.c (count_size_as_multibyte): Check for string overflow.
8965 * character.c (lisp_string_width): Check for string overflow.
8966 Use EMACS_INT, not int, for string indexes and lengths; in
8967 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8968 the resulting string length overflows an EMACS_INT; instead,
8969 report a string overflow if no precision given. When checking for
8970 precision exhaustion, use a check that cannot possibly have
8971 integer overflow. (Bug#8675)
8972 * character.h (lisp_string_width): Adjust to new signature.
8974 * alloc.c (string_overflow): New function.
8975 (Fmake_string): Use it. This doesn't change behavior, but saves
8976 a few bytes and will simplify future changes.
8977 * character.c (string_escape_byte8): Likewise.
8978 * lisp.h (string_overflow): New decl.
8980 Fixups, following up to the user-interface timestamp change.
8981 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8982 for UI timestamps, instead of unsigned long.
8983 * msdos.c (mouse_get_pos): Likewise.
8984 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8985 * w32gui.h (Time): Define by including "systime.h" rather than by
8986 declaring it ourselves. (Bug#8664)
8988 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8989 * image.c (clear_image_cache): Likewise.
8991 * term.c (term_mouse_position): Don't assume time_t wraparound.
8993 Be more systematic about user-interface timestamps.
8994 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8995 and sometimes 'EMACS_UINT', to represent these timestamps.
8996 This change causes it to use 'Time' uniformly, as that's what X uses.
8997 This makes the code easier to follow, and makes it easier to catch
8998 integer overflow bugs such as Bug#8664.
8999 * frame.c (Fmouse_position, Fmouse_pixel_position):
9000 Use Time, not unsigned long, for user-interface timestamps.
9001 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9002 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9003 * keyboard.h (last_event_timestamp): Likewise.
9004 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9005 * menu.h (xmenu_show): Likewise.
9006 * term.c (term_mouse_position): Likewise.
9007 * termhooks.h (struct input_event.timestamp): Likewise.
9008 (struct terminal.mouse_position_hook): Likewise.
9009 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9010 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9011 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9012 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9014 * menu.h, termhooks.h: Include "systime.h", for Time.
9016 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9017 Don't assume that the difference between two unsigned long values
9018 can fit into an integer. At this point, we know button_down_time
9019 <= event->timestamp, so the difference must be nonnegative, so
9020 there's no need to cast the result if double-click-time is
9021 nonnegative, as it should be; check that it's nonnegative, just in
9022 case. This bug is triggered when events are more than 2**31 ms
9023 apart (about 25 days). (Bug#8664)
9025 * xselect.c (last_event_timestamp): Remove duplicate decl.
9026 (x_own_selection): Remove needless cast to unsigned long.
9028 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9029 that always fit in int. Use a sentinel instead of a counter, to
9030 avoid a temp and to allay GCC's concerns about possible int overflow.
9031 * frame.h (struct frame): Use int for menu_bar_items_used
9032 instead of EMACS_INT, since it always fits in int.
9034 * menu.c (grow_menu_items): Check for int overflow.
9036 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9038 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9039 Before, the code was not consistent. These values cannot exceed
9040 2**31 - 1 so there's no need to make them unsigned.
9041 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9042 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9043 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9045 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9047 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9048 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9049 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9050 presumably because the widths might not match.
9052 * window.c (size_window): Avoid needless test at loop start.
9054 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9056 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9058 2011-05-12 Drew Adams <drew.adams@oracle.com>
9060 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9062 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9064 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9065 `width' to `bar_area_x' and `bar_area_width', respectively.
9066 (x_scroll_run): Take account of fringe background extension.
9068 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9069 Rename local vars `left' and `width' to `bar_area_x' and
9070 `bar_area_width', respectively.
9071 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9072 background extension.
9074 2011-05-10 Jim Meyering <meyering@redhat.com>
9076 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9078 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
9080 * image.c (Finit_image_library): Return t for built-in image types,
9081 like pbm and xbm. (Bug#8640)
9083 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9085 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9087 2011-05-07 Eli Zaretskii <eliz@gnu.org>
9089 * w32console.c (Fset_screen_color): Doc fix.
9090 (Fget_screen_color): New function.
9091 (syms_of_ntterm): Defsubr it.
9093 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9094 unlink the temporary file if Fcall_process didn't create it in the
9096 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9097 child process will be redirected to a file specified with `:file'.
9098 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9099 cue to call_process_cleanup not to close that handle.
9101 2011-05-07 Ben Key <bkey76@gmail.com>
9103 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9104 one of two shell specific rules, either bootstrap-temacs-CMD or
9105 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9106 to the previous implementation of the bootstrap-temacs rule.
9107 The bootstrap-temacs-CMD rule is similar to the previous
9108 implementation of the bootstrap-temacs rule except that it
9109 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9112 These changes, along with some changes to nt/configure.bat,
9113 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9114 earlier fix to add support for --cflags and --ldflags options
9115 that include quotes so that it works whether make uses cmd or
9118 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
9120 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9121 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9123 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9124 a string. Handle both cases.
9125 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9126 (Fdbus_register_method): Use Qinvalid_function.
9128 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9130 * makefile.w32-in: Update dependencies.
9131 (LISP_H): Add inttypes.h and stdin.h.
9132 (PROCESS_H): Add unistd.h.
9134 2011-05-06 Eli Zaretskii <eliz@gnu.org>
9136 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9137 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9139 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
9141 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9143 * term.c (vfatal): Remove stray call to va_end.
9144 It's not needed and the C Standard doesn't allow it here anyway.
9146 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9147 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9149 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9152 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9154 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9156 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9158 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9160 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9162 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9163 * charset.c (Fdefine_charset_internal): Don't initialize
9164 charset.code_space[15]. The value was garbage, on hosts with
9165 32-bit int (Bug#8600).
9167 * lread.c (read_integer): Be more consistent with string-to-number.
9168 Use string_to_number to do the actual conversion; this avoids
9169 rounding errors and fixes some other screwups. Without this fix,
9170 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9171 (digit_to_number): Move earlier, for benefit of read_integer.
9172 Return -1 if the digit is out of range for the base, -2 if it is
9173 not a digit in any supported base. (Bug#8602)
9175 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9177 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9178 to match comment at start of function. This also removes a
9179 GCC warning about overflow in a 32+64-bit port.
9181 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9183 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9184 Reported by Stefan Monnier in
9185 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
9186 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9187 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
9189 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9190 (EMACS_UINTPTR): Likewise, with uintptr_t.
9192 * lisp.h: Prefer 64-bit EMACS_INT if available.
9193 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9194 on 32-bit hosts that have 64-bit int, so that they can access
9196 However, temporarily disable this change unless the temporary
9197 symbol WIDE_EMACS_INT is defined.
9199 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9201 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9202 This removes an assumption that EMACS_INT and long are the same
9203 width as pointers. The assumption is true for Emacs porting targets
9204 now, but we want to make other targets possible.
9205 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9206 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9207 In the rest of the code, change types of integers that hold casted
9208 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9209 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9210 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9211 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9212 No need to cast type when ORing.
9213 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9214 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9215 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9216 assume EMACS_INT is the same width as char *.
9217 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9218 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9219 Remove no-longer-needed casts.
9220 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9221 (xg_tool_bar_help_callback, xg_make_tool_item):
9222 Use EMACS_INTPTR to hold an integer
9223 that will be cast to void *; this can avoid a GCC warning
9224 if EMACS_INT is not the same width as void *.
9225 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9226 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9227 (current_message_1, set_message_1):
9228 Use a local to convert to proper width without a cast.
9229 * xmenu.c (dialog_selection_callback): Likewise.
9231 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9232 Also, don't assume VALBITS / RAND_BITS is less than 5,
9233 and don't rely on undefined behavior when shifting a 1 left into
9235 * lisp.h (get_random): Change signature to match.
9237 * lread.c (hash_string): Use size_t, not int, for hash computation.
9238 Normally we prefer signed values; but hashing is special, because
9239 it's better to use unsigned division on hash table sizes so that
9240 the remainder is nonnegative. Also, size_t is the natural width
9241 for hashing into memory. The previous code used 'int', which doesn't
9242 retain enough info to hash well into very large tables.
9243 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9245 * dbusbind.c: Don't possibly lose pointer info when converting.
9246 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9247 Use XPNTR rather than XHASH, so that the high-order bits of
9248 the pointer aren't lost when converting through void *.
9250 * eval.c (Fautoload): Don't double-shift a pointer.
9252 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9254 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9256 * gnutls.c (DEF_GNUTLS_FN):
9257 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9259 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9261 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9264 2011-05-05 Eli Zaretskii <eliz@gnu.org>
9266 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9267 New version that can reserve upto 2GB of heap space.
9269 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
9271 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9273 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9275 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9276 `gnutls_certificate_set_x509_key_file'.
9278 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
9280 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9281 Update dependencies.
9283 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9285 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9286 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9287 Remove unused parameter `fildes'.
9288 * process.c (read_process_output, send_process): Don't pass it.
9290 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9292 Fix previous change: the library cache is defined in w32.c.
9293 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9294 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9296 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9298 Implement dynamic loading of GnuTLS on Windows.
9300 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9301 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9302 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9305 * gnutls.c (Qgnutls_dll): Define.
9306 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9307 (gnutls_*): Declare function pointers.
9308 (init_gnutls_functions): New function to initialize function pointers.
9309 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9310 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9311 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9312 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9313 (emacs_gnutls_write, emacs_gnutls_read)
9314 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9315 (Fgnutls_available_p): New function.
9316 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9317 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9318 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9320 * image.c: Include w32.h.
9321 (Vimage_type_cache): Delete.
9322 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9323 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9324 (w32_delayed_load): Move to w32.c.
9326 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9328 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9329 (w32_delayed_load): Move from image.c. When loading a library, record
9330 its filename in the :loaded-from property of the library id.
9331 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9332 Initialize and staticpro them.
9333 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9335 * process.c: Include lisp.h before w32.h, not after.
9336 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9337 instead of gnutls_record_check_pending.
9339 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9341 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9343 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9344 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9347 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9349 * xterm.c (x_set_frame_alpha): Do not set property on anything
9350 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9352 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9354 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9356 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9358 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9359 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9360 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9361 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9362 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9363 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9364 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9365 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9366 (Qgnutls_bootprop_callbacks_verify): Make static.
9368 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9370 * callproc.c: Indentation fixup.
9372 * sysdep.c (wait_for_termination_1): Make static.
9373 (wait_for_termination, interruptible_wait_for_termination):
9374 Move after wait_for_termination_1.
9376 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9378 * sysdep.c (interruptible_wait_for_termination): New function
9379 which is like wait_for_termination, but allows keyboard
9382 * callproc.c (Fcall_process): Add (:file "file") as an option for
9384 (Fcall_process_region): Ditto.
9386 2011-04-30 Eli Zaretskii <eliz@gnu.org>
9388 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9389 rather than `XVECTOR (FOO)->size'.
9391 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9392 inttypes.h, as a gnulib replacement is used if it not available in
9395 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9397 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9398 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9399 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9401 * coding.c (coding_alloc_by_realloc): Error out if destination
9402 will grow beyond MOST_POSITIVE_FIXNUM.
9403 (decode_coding_emacs_mule): Abort if there isn't enough place in
9404 charbuf for the composition carryover bytes. Reserve an extra
9405 space for up to 2 characters produced in a loop.
9406 (decode_coding_iso_2022): Abort if there isn't enough place in
9407 charbuf for the composition carryover bytes.
9409 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9411 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9412 aborting when %lld or %lll format is passed.
9413 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9414 %llo or %llx format is passed. (Bug#8545)
9416 * window.c (window_scroll_line_based): Use a marker instead of
9417 simple variables to record original value of point. (Bug#7952)
9419 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9420 produced by %s or %c overflows available buffer space. (Bug#8545)
9422 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9424 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
9425 (SIZE_MAX): Move defn after all includes, as they might #define it.
9427 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9429 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9431 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9433 * keyboard.c (Qdelayed_warnings_hook): Define.
9434 (command_loop_1): Run `delayed-warnings-hook'
9435 if Vdelayed_warnings_list is non-nil.
9436 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9437 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9439 2011-04-28 Eli Zaretskii <eliz@gnu.org>
9441 * doprnt.c (doprnt): Don't return value smaller than the buffer
9442 size if the message was truncated. (Bug#8545).
9444 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9446 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9447 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9449 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9451 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9453 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
9455 * makefile.w32-in: Update dependencies.
9457 2011-04-27 Eli Zaretskii <eliz@gnu.org>
9459 Improve `doprnt' and its usage. (Bug#8545)
9460 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9461 `format_end'. Remove support for %l as a conversion specifier.
9462 Don't use xrealloc. Improve diagnostics when the %l size modifier
9463 is used. Update the commentary.
9465 * eval.c (verror): Simplify calculation of size_t.
9467 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9470 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9472 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9475 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9477 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9478 This makes this file independent of the recent pseudovector change.
9480 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
9482 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9484 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
9485 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
9486 Remove unused local.
9487 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
9489 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
9490 GCC 4.6.0 optimizes based on type-based alias analysis.
9491 For example, if b is of type struct buffer * and v of type struct
9492 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9493 != &v->size, and therefore "v->size = 1; b->size = 2; return
9494 v->size;" must therefore return 1. This assumption is incorrect
9495 for Emacs, since it type-puns struct Lisp_Vector * with many other
9496 types. To fix this problem, this patch adds a new type struct
9497 vectorlike_header that documents the constraints on layout of vectors
9498 and pseudovectors, and helps optimizing compilers not get fooled
9499 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9500 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
9501 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9503 (XSETPVECTYPE): Rewrite in terms of new macro.
9504 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9505 This is a bit clearer, and further avoids the possibility of
9506 undesirable aliasing.
9507 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
9508 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
9509 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9510 since Lisp_Subr is a special case (no "next" field).
9511 (ASIZE): Now uses header.size rather than size.
9512 All previous uses of XVECTOR (foo)->size replaced to use this macro,
9513 to avoid the hassle of writing XVECTOR (foo)->header.size.
9514 (struct vectorlike_header): New type.
9515 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9516 object, to help avoid aliasing.
9517 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9518 (SUBRP): Likewise, since Lisp_Subr is a special case.
9519 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9520 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9521 (struct Lisp_Hash_Table): Combine first two members into a single
9522 struct vectorlike_header member. All uses of "size" and "next" members
9523 changed to be "header.size" and "header.next".
9524 * buffer.h (struct buffer): Likewise.
9525 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9526 * frame.h (struct frame): Likewise.
9527 * process.h (struct Lisp_Process): Likewise.
9528 * termhooks.h (struct terminal): Likewise.
9529 * window.c (struct save_window_data, struct saved_window): Likewise.
9530 * window.h (struct window): Likewise.
9531 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9532 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9533 * buffer.c (init_buffer_once): Likewise.
9534 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9536 * process.c (Fformat_network_address): Use local var for size,
9539 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9541 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9542 * data.c (atof): Remove decl; no longer used or needed.
9543 (digit_to_number): Move to lread.c.
9544 (Fstring_to_number): Use new string_to_number function, to be
9545 consistent with how the Lisp reader treats infinities and NaNs.
9546 Do not assume that floating-point numbers represent EMACS_INT
9547 without losing information; this is not true on most 64-bit hosts.
9548 Avoid double-rounding errors, by insisting on integers when
9549 parsing non-base-10 numbers, as the documentation specifies.
9550 * lisp.h (string_to_number): New decl, replacing ...
9551 (isfloat_string): Remove.
9552 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9553 (read1): Do not accept +. and -. as integers; this
9554 appears to have been a coding error. Similarly, do not accept
9555 strings like +-1e0 as floating point numbers. Do not report
9556 overflow for integer overflows unless the base is not 10 which
9557 means we have no simple and reliable way to continue.
9558 Break out the floating-point parsing into a new
9559 function string_to_number, so that Fstring_to_number parses
9560 floating point numbers consistently with the Lisp reader.
9561 (digit_to_number): Move here from data.c. Make it static inline.
9562 (E_CHAR, EXP_INT): Remove, replacing with ...
9563 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9564 (string_to_number): New function, replacing isfloat_string.
9565 This function checks for valid syntax and produces the resulting
9566 Lisp float number too. Rework it so that string-to-number
9567 no longer mishandles examples like "1.0e+". Use strtoumax,
9568 so that overflow for non-base-10 numbers is reported only when
9569 there's no portable and simple way to convert to floating point.
9571 * textprop.c (set_text_properties_1): Rewrite for clarity,
9572 and to avoid GCC warning about integer overflow.
9574 * intervals.h (struct interval): Use EMACS_INT for members
9575 where EMACS_UINT might cause problems. See
9576 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9577 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9578 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9580 (offset_intervals): Tell GCC not to worry about length overflow
9581 when negating a negative length.
9583 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9584 (overrun_check_free): Likewise.
9586 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9587 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9590 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9591 (gnutls_make_error): Rename local to avoid shadowing.
9592 (gnutls_emacs_global_deinit): ifdef out; not used.
9593 (Fgnutls_boot): Use const for pointer to readonly storage.
9594 Comment out unused local. Fix pointer signedness problems.
9596 * lread.c (openp): Don't stuff size_t into an 'int'.
9597 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9598 about possible signed overflow.
9600 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9601 (GDK_KEY_g): Don't define if already defined.
9602 (xg_prepare_tooltip): Avoid pointer signedness problem.
9603 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9605 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9606 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9608 * xfns.c (Fx_window_property): Simplify a bit,
9609 to make a bit faster and to avoid GCC 4.6.0 warning.
9610 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9612 * fns.c (internal_equal): Don't assume size_t fits in int.
9614 * alloc.c (compact_small_strings): Tighten assertion a little.
9616 Replace pEd with more-general pI, and fix some printf arg casts.
9617 * lisp.h (pI): New macro, generalizing old pEd macro to other
9618 conversion specifiers. For example, use "...%"pI"d..." rather
9619 than "...%"pEd"...".
9620 (pEd): Remove. All uses replaced with similar uses of pI.
9621 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9622 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9623 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9624 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9625 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9626 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9627 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9629 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9630 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9631 * print.c (safe_debug_print, print_object): Likewise.
9632 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9634 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9635 avoiding the 0 flag, which is not portable.
9636 * process.c (Fmake_network_process): Use pI to avoid cast.
9637 * region-cache.c (pp_cache): Likewise.
9638 * xdisp.c (decode_mode_spec): Likewise.
9639 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9640 behavior on 64-bit hosts with printf arg.
9641 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9642 (x_stop_queuing_selection_requests): Likewise.
9643 (x_get_window_property): Don't truncate byte count to an 'int'
9646 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9647 here, since it parses constructs like leading '-' and spaces,
9648 which are not wanted; and it overflows with large numbers.
9649 Instead, simply match F[0-9]+, which is what is wanted anyway.
9651 * alloc.c: Remove unportable assumptions about struct layout.
9652 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9653 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9654 (allocate_vectorlike, make_pure_vector): Use the new macros,
9655 plus offsetof, to remove unportable assumptions about struct layout.
9656 These assumptions hold on all porting targets that I know of, but
9657 they are not guaranteed, they're easy to remove, and removing them
9658 makes further changes easier.
9660 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9661 This doesn't fix a bug but makes the code clearer.
9662 (string_overrun_cookie): Now const. Use initializers that
9663 don't formally overflow signed char, to avoid warnings.
9664 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9665 can cause Emacs to crash when string overrun checking is enabled.
9666 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9667 multiple of sizeof (EMACS_INT); it need not be, if
9668 alignof(EMACS_INT) < sizeof (EMACS_INT).
9669 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9671 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9673 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9675 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9677 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9678 supposed to be handshaking. (Bug#8556)
9679 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9681 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9683 * lisp.h (Qdebug): List symbol.
9684 * eval.c (Qdebug): Restore global linkage.
9685 * keyboard.c (debug-on-event): New variable.
9686 (handle_user_signal): Break into debugger when debug-on-event
9687 matches the current signal symbol.
9689 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9691 * alloc.c (check_sblock, check_string_bytes)
9692 (check_string_free_list): Convert to standard C.
9694 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9696 * w32.c (emacs_gnutls_push): Fix typo.
9698 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9700 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9701 "cast to pointer from integer of different size".
9703 Improve doprnt and its use in verror. (Bug#8545)
9704 * doprnt.c (doprnt): Document the set of format control sequences
9705 supported by the function. Use SAFE_ALLOCA instead of always
9708 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9709 is one byte too soon. Don't use xrealloc; instead xfree and
9712 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9714 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9717 * gnutls.c: Renamed global_initialized to
9718 gnutls_global_initialized. Added internals for the
9719 :verify-hostname-error, :verify-error, and :verify-flags
9720 parameters of `gnutls-boot' and documented those parameters in the
9721 docstring. Start callback support.
9722 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9723 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9724 on error. Return error code.
9725 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9726 (emacs_gnutls_read): Likewise.
9727 (Fgnutls_boot): Return handshake error code.
9728 (emacs_gnutls_handle_error): New function.
9729 (wsaerror_to_errno): Likewise.
9731 * w32.h (emacs_gnutls_pull): Add prototype.
9732 (emacs_gnutls_push): Likewise.
9734 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9735 (emacs_gnutls_push): Likewise.
9737 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9739 * process.c (wait_reading_process_output): Check if GnuTLS
9740 buffered some data internally if no FDs are set for TLS
9743 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9744 (LIBS): Link to USER_LIBS.
9745 ($(BLD)/gnutls.$(0)): New target.
9747 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9749 * xdisp.c (handle_single_display_spec): Rename the
9750 display_replaced_before_p argument into display_replaced_p, to
9751 make it consistent with the commentary. Fix typos in the
9754 * textprop.c (syms_of_textprop): Remove dead code.
9755 (copy_text_properties): Delete obsolete commentary about an
9756 interface that was deleted long ago. Fix typos in the description
9759 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9760 to changes in oldXMenu/XMenu.h from 2011-04-16.
9761 <menu_help_message, prev_menu_help_message>: Constify.
9762 (IT_menu_make_room): menu->help_text is now `const char **';
9765 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9766 to changes in oldXMenu/XMenu.h from 2011-04-16.
9767 (struct XMenu): Declare `help_text' `const char **'.
9769 * xfaces.c <Qunspecified>: Make extern again.
9771 * syntax.c: Include sys/types.h before including regex.h, as
9774 * doc.c (get_doc_string): Improve the format passed to `error'.
9776 * doprnt.c (doprnt): Improve commentary.
9778 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9780 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9783 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9784 changes in globals.h immediately force recompilation.
9785 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9786 $(CURDIR)/s/ms-w32.h.
9787 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9789 * character.c (Fchar_direction): Function deleted.
9790 (syms_of_character): Don't defsubr it.
9791 <char-direction-table>: Deleted.
9793 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9795 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9796 * doprnt.c: Include limits.h.
9797 (SIZE_MAX): New macro.
9798 (doprnt): Return a size_t value. 2nd arg is now size_t.
9799 Many local variables are now size_t instead of int or unsigned.
9800 Improve overflow protection. Support `l' modifier for integer
9801 conversions. Support %l conversion. Don't assume an EMACS_INT
9802 argument for integer conversions and for %c.
9804 * lisp.h (doprnt): Restore prototype.
9806 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9809 * Makefile.in (base_obj): Add back doprnt.o.
9811 * deps.mk (doprnt.o): Add back prerequisites.
9812 (callint.o): Depend on character.h.
9814 * eval.c (internal_lisp_condition_case): Include the handler
9815 representation in the error message.
9816 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9817 when breaking from the loop.
9819 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9821 * callint.c (Fcall_interactively): When displaying error message
9822 about invalid control letter, pass the character's codepoint, not
9823 a pointer to its multibyte form. Improve display of the character
9824 in octal and display also its hex code.
9826 * character.c (char_string): Use %x to display the (unsigned)
9827 codepoint of an invalid character, to avoid displaying a bogus
9830 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9831 `error', not SYMBOL_NAME itself.
9833 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9834 character arguments to `error'.
9836 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9837 to `error' in error message about FINAL_CHAR argument. Make sure
9838 FINAL_CHAR is a character, and use %c when it is passed as
9839 argument to `error'.
9841 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9843 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9845 * w32.c: Include <time.h>.
9846 (sys_localtime): New function.
9848 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9850 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9852 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9854 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9856 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9859 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9861 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9862 gl_state.e_property when gl_state.object is Qt.
9864 * insdel.c (make_gap_larger): Remove limitation of buffer size
9867 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9869 * xdisp.c (lookup_glyphless_char_display)
9870 (produce_glyphless_glyph): Handle cons cell entry in
9871 glyphless-char-display.
9872 (Vglyphless_char_display): Document it.
9874 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9875 glyphless-char-display.
9877 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9879 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9881 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9883 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9884 definition for no-X builds.
9886 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9888 Static checks with GCC 4.6.0 and non-default toolkits.
9890 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9892 * process.c (keyboard_bit_set): Define only if SIGIO.
9893 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9894 (send_process): Repair possible setjmp clobbering.
9896 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9898 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9900 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9902 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9903 Define only if needed.
9905 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9906 by pacifying GCC about it. Maybe it's time to retire it?
9907 * xfaces.c (USG, __TIMEVAL__): Likewise.
9909 * dispextern.h (struct redisplay_interface): Rename param
9911 * termhooks.h (struct terminal): Likewise.
9912 * xterm.c (xembed_send_message): Likewise.
9914 * insdel.c (make_gap_smaller): Define only if
9915 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9917 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9920 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9921 so that we aren't warned about unused symbols.
9923 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9925 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9927 * xfns.c (x_real_positions): Mark locals as initialized.
9929 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9931 * xterm.c: Fix problems found by static analysis with other toolkits.
9932 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9933 (x_dispatch_event): Declare static if USE_GTK, and
9934 define if USE_GTK || USE_X_TOOLKIT.
9935 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9936 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9937 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9938 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9940 * xmenu.c (menu_help_callback): Pointer type fixes.
9941 Use const pointers when pointing at readonly data. Avoid pointer
9943 (FALSE): Remove unused macro.
9944 (update_frame_menubar): Remove unused decl.
9946 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9948 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9949 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9950 (single_menu_item): Rename local to avoid shadowing.
9952 * keyboard.c (make_lispy_event): Remove unused local var.
9954 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9955 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9957 * bitmaps: Change bitmaps from unsigned char back to the X11
9958 compatible char. Avoid the old compiler warnings about
9959 out-of-range initializers by using, for example, '\xab' rather
9962 * xgselect.c (xgselect_initialize): Check vs interface
9963 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9965 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9967 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9968 to read-only memory.
9970 * fns.c (vector): Remove; this old hack is no longer needed.
9972 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9974 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9976 * xrdb.c (x_load_resources): Omit unused local.
9978 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9979 (x_window): Rename locals to avoid shadowing.
9980 (USG): Use the kludged USG macro, to pacify gcc.
9982 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9983 (x_term_init): Remove local to avoid shadowing.
9985 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9987 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9988 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9990 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9992 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9994 Fix regex.c, syntax.c and friends for buffers > 2GB.
9995 * syntax.h (struct gl_state_s): Declare character position members
9998 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10000 * textprop.c (verify_interval_modification, interval_of):
10001 Declare arguments EMACS_INT.
10003 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10006 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10008 * indent.c (Fvertical_motion): Local variable it_start is now
10011 * regex.c (re_match, re_match_2, re_match_2_internal)
10012 (bcmp_translate, regcomp, regexec, print_double_string)
10013 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10014 (re_compile_pattern, re_exec): Declare arguments and local
10015 variables `size_t' and `ssize_t' and return values `regoff_t', as
10017 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10018 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10019 <compile_stack_type>: `size' and `avail' are now `size_t'.
10021 * regex.h <regoff_t>: Use ssize_t, not int.
10022 (re_search, re_search_2, re_match, re_match_2): Arguments that
10023 specify buffer/string position and length are now ssize_t and
10024 size_t. Return type is regoff_t.
10026 2011-04-16 Ben Key <bkey76@gmail.com>
10028 * nsfont.m: Fixed bugs in ns_get_family and
10029 ns_descriptor_to_entity that were caused by using free to
10030 deallocate memory blocks that were allocated by xmalloc (via
10031 xstrdup). This caused Emacs to crash when compiled with
10032 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10033 --enable-checking=xmallocoverrun). xfree is now used to
10034 deallocate these memory blocks.
10036 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
10038 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10040 emacs_write: Accept and return EMACS_INT for sizes.
10041 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10043 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10044 Accept and return EMACS_INT.
10045 (emacs_gnutls_write): Return the number of bytes written on
10047 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
10048 (emacs_read, emacs_write): Remove check for negative size, as the
10049 Emacs source code has been audited now.
10050 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10051 (emacs_read, emacs_write): Use it.
10052 * process.c (send_process): Adjust to the new signatures of
10053 emacs_write and emacs_gnutls_write. Do not attempt to store
10054 a byte offset into an 'int'; it might overflow.
10055 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
10057 * sound.c: Don't assume sizes fit in 'int'.
10058 (struct sound_device.period_size, alsa_period_size):
10059 Return EMACS_INT, not int.
10060 (struct sound_device.write, vox_write, alsa_write):
10061 Accept EMACS_INT, not int.
10062 (wav_play, au_play): Use EMACS_INT to store sizes and to
10063 record read return values.
10065 2011-04-15 Ben Key <bkey76@gmail.com>
10067 * keyboard.c (Qundefined): Don't declare static since it is used
10069 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10070 static since they are used in nsfont.m.
10072 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10074 * process.c (Qprocessp): Don't declare static.
10075 * lisp.h (Qprocessp): Declare again.
10077 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
10079 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10081 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10083 Improve C-level modularity by making more things 'static'.
10085 Don't publish debugger-only interfaces to other modules.
10086 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10087 (verify_bytepos, count_markers): Move decls to the only modules
10089 * region-cache.h (pp_cache): Likewise.
10090 * window.h (check_all_windows): Likewise.
10091 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10093 * sysdep.c (croak): Now static, if
10094 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10095 * syssignal.h (croak): Declare only if not static.
10097 * alloc.c (refill_memory_reserve): Now static if
10098 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10099 * lisp.h (refill_memory_reserve): Declare only if not static.
10101 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10102 Define only if USE_LUCID.
10104 * xrdb.c (x_customization_string, x_rm_string): Now static.
10106 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10107 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10109 * xdisp.c (draw_row_with_mouse_face): Now static.
10110 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10112 * window.h (check_all_windows): Mark externally visible.
10114 * window.c (window_deletion_count): Now static.
10116 * undo.c: Make symbols static if they're not exported.
10117 (last_undo_buffer, last_boundary_position, pending_boundary):
10120 * textprop.c (interval_insert_behind_hooks): Now static.
10121 (interval_insert_in_front_hooks): Likewise.
10123 * term.c: Make symbols static if they're not exported.
10124 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10125 (max_frame_lines, tty_set_terminal_modes):
10126 (tty_reset_terminal_modes, tty_turn_off_highlight):
10127 (get_tty_terminal): Now static.
10128 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10129 * termhooks.h (term_mouse_moveto): Do not declare if
10130 HAVE_WINDOW_SYSTEM.
10131 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10132 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10134 * sysdep.c: Make symbols static if they're not exported.
10135 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10137 (sigprocmask_set, full_mask): Remove; unused.
10138 (wait_debugging): Mark as visible.
10139 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10140 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10142 * syntax.c (syntax_temp): Define only if !__GNUC__.
10144 * sound.c (current_sound_device, current_sound): Now static.
10146 * search.c (searchbufs, searchbuf_head): Now static.
10148 * scroll.c (scroll_cost): Remove; unused.
10149 * dispextern.h (scroll_cost): Remove decl.
10151 * region-cache.h (pp_cache): Mark as externally visible.
10153 * process.c: Make symbols static if they're not exported.
10154 (process_tick, update_tick, create_process, chan_process):
10155 (Vprocess_alist, proc_buffered_char, datagram_access):
10156 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10157 (deactivate_process): Mark defn as static, as well as decl.
10158 * lisp.h (create_process): Remove decl.
10159 * process.h (chan_process, Vprocess_alist): Remove decls.
10161 * print.c: Make symbols static if they're not exported.
10162 (print_depth, new_backquote_output, being_printed, print_buffer):
10163 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10164 (print_interval, print_number_index, initial_stderr_stream):
10166 * lisp.h (Fprinc): Remove decl.
10167 (debug_output_compilation_hack): Mark as externally visible.
10169 * sysdep.c (croak): Move decl from here to syssignal.h.
10170 * syssignal.h (croak): Put it here, so the API can be checked when
10171 'croak' is called from dissociate_if_controlling_tty.
10173 * minibuf.c: Make symbols static if they're not exported.
10174 (minibuf_save_list, choose_minibuf_frame): Now static.
10175 * lisp.h (choose_minibuf_frame): Remove decl.
10177 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10179 * lread.c: Make symbols static if they're not exported.
10180 (read_objects, initial_obarray, oblookup_last_bucket_number):
10182 (make_symbol): Remove; unused.
10183 * lisp.h (initial_obarray, make_symbol): Remove decls.
10185 * keyboard.c: Make symbols static if they're not exported.
10186 (single_kboard, recent_keys_index, total_keys, recent_keys):
10187 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10188 (this_single_command_key_start, echoing, last_auto_save):
10189 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10190 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10191 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10192 (Vlispy_mouse_stem, double_click_count):
10194 (force_auto_save_soon): Define only if SIGDANGER.
10195 (ignore_mouse_drag_p): Now static if
10196 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10197 (print_help): Remove; unused.
10198 (stop_character, last_timer_event): Mark as externally visible.
10199 * keyboard.h (ignore_mouse_drag_p): Declare only if
10200 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10201 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10202 * lisp.h (echoing): Remove decl.
10203 (force_auto_save_soon): Declare only if SIGDANGER.
10204 * xdisp.c (redisplay_window): Simplify code, to make it more
10205 obvious that ignore_mouse_drag_p is not accessed if !defined
10206 USE_GTK && !defined HAVE_NS.
10208 * intervals.c: Make symbols static if they're not exported.
10209 (merge_properties_sticky, merge_interval_right, delete_interval):
10211 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10213 * insdel.c: Make symbols static if they're not exported.
10214 However, leave prepare_to_modify_buffer alone. It's never
10215 called from outside this function, but that appears to be a bug.
10216 (combine_after_change_list, combine_after_change_buffer):
10217 (adjust_after_replace, signal_before_change): Now static.
10218 (adjust_after_replace_noundo): Remove; unused.
10219 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
10220 (signal_before_change): Remove decls.
10222 * indent.c (val_compute_motion, val_vmotion): Now static.
10224 * image.c: Make symbols static if they're not exported.
10225 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10227 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10228 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10230 * fringe.c (standard_bitmaps): Now static.
10231 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10233 * frame.c: Make symbols static if they're not exported.
10234 (x_report_frame_params, make_terminal_frame): Now static.
10235 (get_frame_param): Now static, unless HAVE_NS.
10236 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10237 (x_get_resource_string): Remove; not used.
10238 * frame.h (make_terminal_frame, x_report_frame_params):
10239 (x_get_resource_string); Remove decls.
10240 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10241 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10243 * font.c, fontset.c: Make symbols static if they're not exported.
10244 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10245 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10246 * font.c (font_close_object): Now static.
10247 * font.h (font_close_object): Remove.
10248 * fontset.c (FONTSET_OBJLIST): Remove.
10249 (free_realized_fontset) #if-0 the body, which does nothing.
10250 (face_suitable_for_char_p): #if-0, as it's never called.
10251 * fontset.h (face_suitable_for_char_p): Remove decl.
10252 * xfaces.c (face_at_string_position):
10253 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
10254 since 0 is always ASCII.
10256 * fns.c (weak_hash_tables): Now static.
10258 * fileio.c: Make symbols static if they're not exported.
10259 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10260 (Vwrite_region_annotation_buffers): Now static.
10262 * eval.c: Make symbols static if they're not exported.
10263 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10264 * lisp.h (backtrace_list): Remove decl.
10266 * emacs.c: Make symbols static if they're not exported.
10267 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10268 (fatal_error_code, fatal_error_signal_hook, standard_args):
10270 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10271 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10272 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10273 * lisp.h (fatal_error_signal_hook): Remove decl.
10274 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10276 * editfns.c: Move a (normally-unused) function to its only use.
10277 * editfns.c, lisp.h (get_operating_system_release): Remove.
10278 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10279 worth the hassle of breaking this out.
10281 * xterm.c: Make symbols static if they're not exported.
10282 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10283 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10284 (x_destroy_window, x_delete_display):
10286 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10287 (x_mouse_leave): Remove; unused.
10288 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10289 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10290 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10292 (x_mouse_leave): Declare only if WINDOWSNT.
10293 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10294 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10297 * ftxfont.c: Make symbols static if they're not exported.
10298 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10300 * font.h (ftxfont_driver): Likewise.
10302 * xfns.c: Make symbols static if they're not exported.
10303 (x_last_font_name, x_display_info_for_name):
10304 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10305 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10306 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10307 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10308 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10309 (last_show_tip_args): Now static.
10310 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10311 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10312 (x_screen_planes): Remove; unused.
10313 * dispextern.h (x_screen_planes): Remove decl.
10315 * dispnew.c: Make symbols static if they're not exported.
10316 * dispextern.h (redraw_garbaged_frames, scrolling):
10317 (increment_row_positions): Remove.
10318 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10319 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10321 (redraw_garbaged_frames): Remove; unused.
10323 * xfaces.c: Make symbols static if they're not exported.
10324 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10326 * xterm.h (defined_color): Remove decls.
10327 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10328 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10329 (menu_face_changed_default, defined_color, free_realized_face):
10330 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10331 (ascii_face_of_lisp_face): Remove; unused.
10333 * xdisp.c: Make symbols static if they're not exported.
10334 * dispextern.h (scratch_glyph_row, window_box_edges):
10335 (glyph_to_pixel_coords, set_cursor_from_row):
10336 (get_next_display_element, set_iterator_to_next):
10337 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10338 (show_mouse_face): Remove decls
10339 * frame.h (message_buf_print): Likewise.
10340 * lisp.h (pop_message, set_message, check_point_in_composition):
10342 * xterm.h (set_vertical_scroll_bar): Likewise.
10343 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10344 (message_buf_print, scratch_glyph_row, displayed_buffer):
10345 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10346 (get_next_display_element, show_mouse_face, window_box_edges):
10347 (frame_to_window_pixel_xy, check_point_in_composition):
10348 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10349 (glyph_to_pixel_coords): Remove; unused.
10351 * dired.c (file_name_completion): Now static.
10353 * dbusbind.c (xd_in_read_queued_messages): Now static.
10355 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10356 * data.c (circular_list_error): Remove.
10358 * commands.h (last_point_position, last_point_position_buffer):
10359 (last_point_position_window): Remove decls.
10360 * keyboard.c: Make these variables static.
10362 * coding.h (coding, code_convert_region, encode_coding_gap):
10364 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10365 (iso_code_class, detect_coding, code_convert_region): Now static.
10366 (encode_coding_gap): Remove; unused.
10368 * chartab.c (chartab_chars, chartab_bits): Now static.
10370 * charset.h (charset_iso_8859_1): Remove decl.
10371 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10374 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10375 * ccl.c (Vccl_program_table): Now static.
10376 (check_ccl_update): Remove; unused.
10378 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10379 * category.h: ... from here.
10380 * category.c (check_category_table, set_category_set): Now static.
10382 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10383 * lisp.h: Remove these decls.
10385 * buffer.c (buffer_count): Remove unused var.
10387 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10388 so that it's not optimized away.
10389 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10390 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10391 exported only to the debugger.
10393 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
10394 * atimer.h (run_all_atimers): Remove; not exported.
10396 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10397 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10398 was inaccessible from Lisp.
10399 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10400 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10402 alloc.c: Import and export fewer symbols, and remove unused items.
10403 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10405 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10406 it's not optimized away by whole-program optimization.
10407 (message_enable_multibyte, free_misc): Remove.
10408 (catchlist, handlerlist, mark_backtrace):
10409 Declare only if BYTE_MARK_STACK.
10410 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10411 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10412 (message_enable_multibyte): Remove decl.
10413 (free_misc, interval_free_list, float_block, float_block_index):
10414 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10415 (cons_free_list, last_marked_index):
10417 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10418 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10419 (mark_backtrace): Define only if BYTE_MARK_STACK.
10420 * xdisp.c (message_enable_multibyte): Now static.
10422 Declare Lisp_Object Q* variables to be 'static' if not exported.
10423 This makes it easier for human readers (and static analyzers)
10424 to see whether these variables are used from other modules.
10425 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10426 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10427 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10428 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10429 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10430 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10431 * xmenu.c, xselect.c:
10432 Declare Q* vars static if they are not used in other modules.
10433 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10434 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10435 Remove decls of unexported vars.
10436 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10438 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10440 Make Emacs functions such as Fatom 'static' by default.
10441 This makes it easier for human readers (and static analyzers)
10442 to see whether these functions can be called from other modules.
10443 DEFUN now defines a static function. To make the function external
10444 so that it can be used in other C modules, use the new macro DEFUE.
10445 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10446 (Finit_image_library):
10447 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10448 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10449 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10450 Remove decls, since these functions are now static.
10451 (Funintern, Fget_internal_run_time): New decls, since these functions
10452 were already external.
10454 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10455 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10456 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10457 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10458 * keyboard.c, keymap.c, lread.c:
10459 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10460 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10461 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10462 Mark functions with DEFUE instead of DEFUN,
10463 if they are used in other modules.
10464 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10465 decls for now-static functions.
10466 * buffer.h (Fdelete_overlay): Remove decl.
10467 * callproc.c (Fgetenv_internal): Mark as internal.
10468 * composite.c (Fremove_list_of_text_properties): Remove decl.
10469 (Fcomposition_get_gstring): New forward static decl.
10470 * composite.h (Fcomposite_get_gstring): Remove decl.
10471 * dired.c (Ffile_attributes): New forward static decl.
10472 * doc.c (Fdocumntation_property): New forward static decl.
10473 * eval.c (Ffetch_bytecode): New forward static decl.
10474 (Funintern): Remove extern decl; now in .h file where it belongs.
10475 * fileio.c (Fmake_symbolic_link): New forward static decl.
10476 * image.c (Finit_image_library): New forward static decl.
10477 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10478 * intervals.h (Fprevious_property_change):
10479 (Fremove_list_of_text_properties): Remove decls.
10480 * keyboard.c (Fthis_command_keys): Remove decl.
10481 (Fcommand_execute): New forward static decl.
10482 * keymap.c (Flookup_key): New forward static decl.
10483 (Fcopy_keymap): Now static.
10484 * keymap.h (Flookup_key): Remove decl.
10485 * process.c (Fget_process): New forward static decl.
10486 (Fprocess_datagram_address): Mark as internal.
10487 * syntax.c (Fsyntax_table_p): New forward static decl.
10488 (skip_chars): Remove duplicate decl.
10489 * textprop.c (Fprevious_property_change): New forward static decl.
10490 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10492 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10493 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10495 * editfns.c (Fformat): Remove unreachable code.
10497 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10499 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10502 2011-04-13 Eli Zaretskii <eliz@gnu.org>
10504 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10505 when at ZV. (Bug#8487)
10507 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10509 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10511 * keyboard.c (parse_tool_bar_item): Likewise.
10512 * sound.c (sound_cleanup, alsa_close): Likewise.
10513 * termcap.c (tgetent): Likewise.
10514 * xfns.c (x_default_font_parameter): Likewise.
10515 * xsettings.c (read_and_apply_settings): Likewise.
10517 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10518 (overrun_check_free): Protoize.
10520 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10522 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10523 since callers should never pass a negative size.
10524 Change the signature to match that of plain 'read' and 'write'; see
10525 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10526 * lisp.h: Update prototypes of emacs_write and emacs_read.
10528 2011-04-11 Eli Zaretskii <eliz@gnu.org>
10530 * xdisp.c (redisplay_window): Don't try to determine the character
10531 position of the scroll margin if the window start point w->startp
10532 is outside the buffer's accessible region. (Bug#8468)
10534 2011-04-10 Eli Zaretskii <eliz@gnu.org>
10536 Fix write-region and its subroutines for buffers > 2GB.
10537 * fileio.c (a_write, e_write): Modify declaration of arguments and
10538 local variables to support buffers larger than 2GB.
10539 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10541 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10542 argument, local variables, and return value.
10544 * lisp.h: Update prototypes of emacs_write and emacs_read.
10546 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10548 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10550 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10552 Fix more problems found by GCC 4.6.0's static checks.
10554 * xdisp.c (vmessage): Use a better test for character truncation.
10556 * charset.c (load_charset_map): <, not <=, for optimization,
10557 and to avoid potential problems with integer overflow.
10558 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10559 * casetab.c (set_identity, shuffle): Likewise.
10560 * editfns.c (Fformat): Likewise.
10561 * syntax.c (skip_chars): Likewise.
10563 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10564 This also lets GCC 4.6.0 generate slightly better loop code.
10566 * callint.c (Fcall_interactively): <, not <=, for optimization.
10567 (Fcall_interactively): Count the number of arguments produced,
10568 not the number of arguments given. This is simpler and lets GCC
10569 4.6.0 generate slightly better code.
10571 * ftfont.c: Distingish more carefully between FcChar8 and char.
10572 The previous code passed unsigned char * to a functions like
10573 strlen and xstrcasecmp that expect char *, which does not
10574 conform to the C standard.
10575 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10576 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10577 char * when the C standard requires it.
10579 * keyboard.c (read_char): Remove unused var.
10581 * eval.c: Port to Windows vsnprintf (Bug#8435).
10582 Include <limits.h>.
10583 (SIZE_MAX): Define if the headers do not.
10584 (verror): Do not give up if vsnprintf returns a negative count.
10585 Instead, grow the buffer. This ports to Windows vsnprintf, which
10586 does not conform to C99. Problem reported by Eli Zaretskii.
10587 Also, simplify the allocation scheme, by avoiding the need for
10588 calling realloc, and removing the ALLOCATED variable.
10590 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10592 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10593 But keep the doprint source code for now, as we might revamp it
10594 and use it again (Bug#8435).
10595 * lisp.h (doprnt): Remove.
10596 * Makefile.in (base_obj): Remove doprnt.o.
10597 * deps.mk (doprnt.o): Remove.
10599 error: Print 32- and 64-bit integers portably (Bug#8435).
10600 Without this change, on typical 64-bit hosts error ("...%d...", N)
10601 was used to print both 32- and 64-bit integers N, which relied on
10602 undefined behavior.
10603 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10604 * lisp.h (error, verror): Mark as printf-like functions.
10605 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10606 Report overflow in size calculations when allocating printf buffer.
10607 Do not truncate output string at its first null byte.
10608 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10609 Truncate the output at a character boundary, since vsnprintf does not
10611 * charset.c (check_iso_charset_parameter): Convert internal
10612 character to string before calling 'error', since %c now has the
10614 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10615 overflow when computing char to be passed to 'error'. Do not
10616 pass Lisp_Object to 'error'; pass the integer instead.
10617 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10618 formatted with plain %d.
10620 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10622 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10624 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10626 * xterm.c (x_catch_errors): Remove duplicate declaration.
10628 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10630 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10632 2011-04-10 Jim Meyering <meyering@redhat.com>
10634 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10635 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10636 return ssize_t not "int", and use size_t as the buffer length.
10637 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10638 * gnutls.h: Update declarations.
10639 * process.c (read_process_output): Use ssize_t, to match.
10640 (send_process): Likewise.
10642 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10644 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10646 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10648 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10649 Use unsigned char, to match FcChar8 type definition.
10651 * xterm.c (handle_one_xevent):
10652 * xmenu.c (create_and_show_popup_menu):
10653 * xselect.c (x_decline_selection_request)
10654 (x_reply_selection_request): Avoid type-punned deref of X events.
10656 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10658 Fix some uses of `int' instead of EMACS_INT.
10659 * search.c (string_match_1, fast_string_match)
10660 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10661 (scan_buffer, find_next_newline_no_quit)
10662 (find_before_next_newline, search_command, Freplace_match)
10663 (Fmatch_data): Make some `int' variables be EMACS_INT.
10665 * xdisp.c (display_count_lines): 3rd argument and return value now
10666 EMACS_INT. All callers changed.
10667 (pint2hrstr): Last argument is now EMACS_INT.
10669 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10670 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10671 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10672 (decode_coding_utf_16, decode_coding_emacs_mule)
10673 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10674 (decode_coding_ccl, decode_coding_charset)
10675 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10676 (decode_coding_iso_2022, decode_coding_emacs_mule)
10677 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10678 <char_offset, last_offset>: Declare EMACS_INT.
10679 (encode_coding_utf_8, encode_coding_utf_16)
10680 (encode_coding_emacs_mule, encode_invocation_designation)
10681 (encode_designation_at_bol, encode_coding_iso_2022)
10682 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10683 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10685 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10686 (encode_invocation_designation): Last argument P_NCHARS is now
10688 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10689 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10691 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10694 * ccl.c (Fccl_execute_on_string): Declare some variables
10697 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10699 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10701 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10703 * process.c (Fformat_network_address): Doc fix.
10705 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10707 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10709 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10711 * keyboard.c (read_char): Call Lisp function help-form-show,
10712 instead of using internal_with_output_to_temp_buffer.
10713 (Qhelp_form_show): New var.
10714 (syms_of_keyboard): Use DEFSYM macro.
10716 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10718 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10720 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10722 * process.c (Flist_processes): Remove to Lisp.
10723 (list_processes_1): Delete.
10725 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10727 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10729 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10731 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10733 Fix more problems found by GCC 4.6.0's static checks.
10735 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10737 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10739 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10741 * xdisp.c (vmessage): Mark as a printf-like function.
10743 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10745 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10747 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10748 printf-like functions.
10749 (tiff_load): Add casts to remove these marks before passing them
10750 to system-supplied API.
10752 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10754 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10755 This avoids several warnings with gcc -Wstrict-overflow.
10756 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10757 directly, rather than having caller test rule sign. This avoids
10758 some unnecessary tests.
10759 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10760 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10761 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10763 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10764 (xfont_open): Avoid unnecessary tests.
10766 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10768 * composite.h, composite.c (composition_gstring_put_cache):
10769 Use EMACS_INT, not int, for length.
10771 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10772 breaking out part of COMPOSITION_DECODE_RULE.
10773 (COMPOSITION_DECODE_RULE): Use it.
10774 * composite.c (get_composition_id): Remove unused local vars,
10775 by using the new macro.
10777 * textprop.c (set_text_properties_1): Change while to do-while,
10778 since the condition is always true at first.
10780 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10781 (interval_deletion_adjustment): Return unsigned value.
10784 * process.c (list_processes_1, create_pty, read_process_output):
10785 (exec_sentinel): Remove vars that were set but not used.
10786 (create_pty): Remove unnecessary "volatile"s.
10787 (Fnetwork_interface_info): Avoid possibility of int overflow.
10788 (read_process_output): Do adaptive read buffering even if carryover.
10789 (read_process_output): Simplify nbytes computation if buffered.
10791 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10793 * syntax.c (scan_words): Remove var that was set but not used.
10794 (update_syntax_table): Use unsigned instead of int.
10796 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10797 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10798 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10800 * print.c (print_error_message): Avoid int overflow.
10802 * font.c (font_list_entities): Redo for clarity,
10803 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10805 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10806 (font_score): Avoid potential overflow in diff calculation.
10808 * fns.c (substring_both): Remove var that is set but not used.
10809 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10811 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10813 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10814 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10815 can always succeed if overflow has undefined behavior.
10817 * search.c (boyer_moore, wordify): Remove vars set but not used.
10818 (wordify): Omit three unnecessary tests.
10820 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10821 All callers changed. This avoids the need for an unused var.
10823 * casefiddle.c (casify_region): Remove var that is set but not used.
10825 * dired.c (file_name_completion): Remove var that is set but not used.
10827 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10829 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10830 (Finsert_file_contents): Remove unnecessary code checking fd.
10832 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10833 Check for integer overflow on size calculations.
10835 * buffer.c (Fprevious_overlay_change): Remove var that is set
10838 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10839 Remove vars that are set but not used.
10840 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10841 (timer_check_2): Mark vars as initialized.
10843 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10845 * image.c (lookup_image): Remove var that is set but not used.
10846 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10848 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10849 that are set but not used.
10851 * xfns.c (make_invisible_cursor): Don't return garbage
10852 if XCreateBitmapFromData fails (Bug#8410).
10854 * xselect.c (x_get_local_selection, x_handle_property_notify):
10855 Remove vars that are set but not used.
10857 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10858 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10860 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10861 Remove var that is set but not used.
10862 (scroll_bar_windows_size): Now size_t, not int.
10863 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10864 Check for overflow.
10866 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10867 (map_tty_color) [!defined MSDOS]: Likewise.
10869 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10871 * coding.c: Remove vars that are set but not used.
10872 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10873 All callers changed.
10874 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10875 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10876 (decode_coding_charset): Remove vars that are set but not used.
10878 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10879 that is set but not used.
10881 * print.c (print_object): Remove var that is set but not used.
10883 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10884 The gnulib version avoids calling malloc in the usual case,
10885 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10886 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10887 * filelock.c (current_lock_owner): Likewise.
10888 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10889 * sysdep.c: Include allocator.h, careadlinkat.h.
10890 (emacs_no_realloc_allocator): New static constant.
10891 (emacs_readlink): New function.
10892 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10893 ../lib/careadlinkat.h.
10895 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10897 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10898 first non-nil return value).
10900 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10902 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10903 if not defined (Bug#8403).
10905 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10907 * xdisp.c (display_count_lines): Remove parameter `start',
10908 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10909 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10910 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10911 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10912 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10913 and thereabouts. All callers changed.
10914 (get_per_char_metric): Remove parameter `f', unused since
10915 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10917 2011-04-02 Jim Meyering <meyering@redhat.com>
10919 do not dereference NULL upon failed strdup
10920 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10921 (ns_get_family): Likewise.
10923 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10925 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10927 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10929 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10932 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10934 Add lexical binding.
10936 * window.c (Ftemp_output_buffer_show): New fun.
10937 (Fsave_window_excursion):
10938 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10940 * lread.c (lisp_file_lexically_bound_p): New function.
10941 (Fload): Bind Qlexical_binding.
10942 (readevalloop): Remove `evalfun' arg.
10943 Bind Qinternal_interpreter_environment.
10944 (Feval_buffer): Bind Qlexical_binding.
10945 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10947 (syms_of_lread): Declare `lexical-binding'.
10949 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10951 * keyboard.c (eval_dyn): New fun.
10952 (menu_item_eval_property): Use it.
10954 * image.c (parse_image_spec): Use Ffunctionp.
10956 * fns.c (concat, mapcar1): Accept byte-code-functions.
10958 * eval.c (Fsetq): Handle lexical vars.
10959 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10960 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10961 (FletX, Flet): Obey lexical binding.
10962 (Fcommandp): Handle closures.
10963 (Feval): New `lexical' arg.
10964 (eval_sub): New function extracted from Feval. Use it almost
10965 everywhere where Feval was used. Look up vars in lexical env.
10967 (Ffunctionp): Move from subr.el.
10968 (Ffuncall): Handle closures.
10969 (apply_lambda): Remove `eval_flags'.
10970 (funcall_lambda): Handle closures and new byte-code-functions.
10971 (Fspecial_variable_p): New function.
10972 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10973 but without exporting it to Lisp.
10975 * doc.c (Fdocumentation, store_function_docstring):
10976 * data.c (Finteractive_form): Handle closures.
10978 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10981 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10983 (exec_byte_code): New function extracted from Fbyte_code to handle new
10984 calling convention for byte-code-functions. Add new byte-codes.
10986 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10988 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10990 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10992 * xdisp.c (redisplay_internal): Fix prototype.
10994 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10996 * xdisp.c (SCROLL_LIMIT): New macro.
10997 (try_scrolling): Use it when setting scroll_limit.
10998 Limit scrolling to 100 screen lines.
10999 (redisplay_window): Even when falling back on "recentering",
11000 position point in the window according to scroll-conservatively,
11001 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11003 (try_scrolling): When point is above the window, allow searching
11004 as far as scroll_max, or one screenful, to compute vertical
11005 distance from PT to the scroll margin position. This prevents
11006 try_scrolling from unnecessarily failing when
11007 scroll-conservatively is set to a value slightly larger than the
11008 window height. Clean up the case of PT below the margin at bottom
11009 of window: scroll_max can no longer be INT_MAX. When aggressive
11010 scrolling is in use, don't let point enter the opposite scroll
11011 margin as result of the scroll.
11012 (syms_of_xdisp) <scroll-conservatively>: Document the
11013 threshold of 100 lines for never-recentering scrolling.
11015 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11017 * dispextern.h (move_it_by_lines):
11018 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11019 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11020 (message_log_check_duplicate): Remove parameters `prev_bol' and
11021 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11022 (redisplay_internal): Remove parameter `preserve_echo_area',
11023 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11025 * indent.c (Fvertical_motion):
11026 * window.c (window_scroll_pixel_based, Frecenter):
11027 Don't pass `need_y_p' to `move_it_by_lines'.
11029 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11031 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11032 steal a few bits to be more compact.
11033 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11034 Remove unneeded casts.
11036 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11038 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11040 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11041 binding" message (bug#7967).
11043 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11045 Fix more problems found by GCC 4.6.0's static checks.
11047 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11048 Remove unused local var.
11050 * editfns.c (Fmessage_box): Remove unused local var.
11052 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11053 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11054 Omit unused local vars.
11055 * window.c (shrink_windows): Omit unused local var.
11056 * menu.c (digest_single_submenu): Omit unused local var.
11057 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11058 Omit unused local var.
11060 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11061 Don't assume string length fits in int.
11062 (keyremap_step, read_key_sequence): Use size_t for sizes.
11063 (read_key_sequence): Don't check last_real_key_start redundantly.
11065 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11066 instead of alloca (Bug#8344).
11068 * eval.c (Fbacktrace): Don't assume nargs fits in int.
11069 (Fbacktrace_frame): Don't assume nframes fits in int.
11071 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11073 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11076 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11078 * cm.c (calccost): Turn while-do into do-while, for clarity.
11080 * keyboard.c (syms_of_keyboard): Use the same style as later
11081 in this function when indexing through an array. This also
11082 works around GCC bug 48267.
11084 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11086 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11088 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11089 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11091 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11092 This avoids undefined behavior on integer overflow, and is a bit
11093 more convenient anyway since it is compared to a size_t variable.
11095 Variadic C functions now count arguments with size_t, not int.
11096 This avoids an unnecessary limitation on 64-bit machines, which
11097 caused (substring ...) to crash on large vectors (Bug#8344).
11098 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11099 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
11100 All variadic functions and their callers changed accordingly.
11101 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11102 * data.c (arith_driver, float_arith_driver): Likewise.
11103 * editfns.c (general_insert_function): Likewise.
11104 * eval.c (struct backtrace.nargs, interactive_p)
11105 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11106 (funcall_lambda, mark_backtrace): Likewise.
11107 * fns.c (concat): Likewise.
11108 * frame.c (x_set_frame_parameters): Likewise.
11109 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11110 0 if not found, not -1. All callers changed.
11112 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11113 (stack_copy_size): Now size_t, not int.
11114 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11116 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11118 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11119 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11120 All callers changed.
11122 * lisp.h (multibyte_char_to_unibyte):
11123 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11124 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11125 * character.h (CHAR_TO_BYTE8):
11126 * cmds.c (internal_self_insert):
11127 * editfns.c (general_insert_function):
11128 * keymap.c (push_key_description):
11129 * search.c (Freplace_match):
11130 * xdisp.c (message_dolog, set_message_1): All callers changed.
11132 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11134 * keyboard.c (safe_run_hook_funcall): New function.
11135 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11136 don't set the hook to nil, but remove the offending function instead.
11137 (Qcommand_hook_internal): Remove, unused.
11138 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11139 Vcommand_hook_internal.
11141 * eval.c (enum run_hooks_condition): Remove.
11142 (funcall_nil, funcall_not): New functions.
11143 (run_hook_with_args): Call each function through a `funcall' argument.
11144 Remove `cond' argument, now redundant.
11145 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11146 (Frun_hook_with_args_until_failure): Adjust accordingly.
11147 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11149 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11151 * dispextern.h (string_buffer_position): Remove declaration.
11153 * print.c (strout): Remove parameter `multibyte', unused since
11154 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11156 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11157 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11158 All callers changed.
11160 * w32.c (_wsa_errlist): Use braces for struct initializers.
11162 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11163 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11164 All callers changed.
11165 (string_buffer_position): Likewise. Also, make static (it's never
11166 used outside xdisp.c).
11167 (cursor_row_p): Remove parameter `w', unused since
11168 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11169 (decode_mode_spec): Remove parameter `precision', introduced during
11170 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11171 All callers changed.
11173 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11175 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11177 2011-03-27 Anders Lindgren <andlind@gmail.com>
11179 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11180 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11181 (ns_update_auto_hide_menu_bar): New functions.
11182 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11183 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11184 ns_constrain_all_frames.
11185 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11186 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11188 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11190 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11192 2011-03-27 Glenn Morris <rgm@gnu.org>
11194 * syssignal.h: Replace RETSIGTYPE with void.
11195 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11196 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11197 Replace SIGTYPE with void everywhere.
11198 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11199 * s/template.h (SIGTYPE): Remove commented out definition.
11201 2011-03-26 Eli Zaretskii <eliz@gnu.org>
11203 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11204 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11206 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
11208 * w32.c (read_unc_volume): Use parameter `henum', instead of
11209 global variable `wget_enum_handle'.
11211 * keymap.c (describe_vector): Remove parameters `indices' and
11212 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11213 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11215 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11217 * keyboard.c (timer_check): Remove parameter `do_it_now',
11218 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11219 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11220 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11222 * keyboard.c (read_char):
11223 * w32menu.c (w32_menu_display_help):
11224 * xmenu.c (show_help_event, menu_help_callback):
11225 Adjust calls to `show_help_echo'.
11227 * gtkutil.c (xg_maybe_add_timer):
11228 * keyboard.c (readable_events):
11229 * process.c (wait_reading_process_output):
11230 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11232 * insdel.c (adjust_markers_gap_motion):
11233 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11234 (gap_left, gap_right): Don't call it.
11236 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
11238 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11239 incurred during fontification.
11241 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11243 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11244 (DEFVAR_PER_BUFFER): Don't pass it.
11246 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11247 (scrolling_window): Don't pass it.
11249 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11251 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11253 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11255 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11256 of variables specific to SELinux and computation of `encoded_absname'.
11258 * image.c (XPutPixel): Remove unused variable `height'.
11260 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11262 * unexw32.c (get_section_info): Remove unused variable `section'.
11264 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11265 (system_process_attributes): Remove unused variable `sess'.
11266 (sys_read): Remove unused variable `err'.
11268 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11269 (w32_wnd_proc): Remove unused variable `isdead'.
11270 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11271 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11272 (x_create_tip_frame): Remove unused variable `tem'.
11274 * w32inevt.c (w32_console_read_socket):
11275 Remove unused variable `no_events'.
11277 * w32term.c (x_draw_composite_glyph_string_foreground):
11278 Remove unused variable `width'.
11280 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
11282 * w32term.c (x_set_glyph_string_clipping):
11283 Don't pass uninitialized region to CombineRgn.
11285 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
11287 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11288 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11289 (Fx_close_connection): Remove unused variable `i'.
11291 * w32font.c (w32font_draw): Return number of glyphs.
11292 (w32font_open_internal): Remove unused variable `i'.
11293 (w32font_driver): Add missing initializer.
11295 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11296 (fill_in_menu): Remove unused variable `items_added'.
11298 * w32term.c (last_mouse_press_frame): Remove static global variable.
11299 (w32_clip_to_row): Remove unused variable `f'.
11300 (x_delete_terminal): Remove unused variable `i'.
11302 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11303 (NOTHING): Remove unused static global variable.
11304 (uniscribe_check_otf): Remove unused variable `table'.
11305 (uniscribe_font_driver): Add missing initializers.
11307 2011-03-23 Julien Danjou <julien@danjou.info>
11309 * term.c (Fsuspend_tty, Fresume_tty):
11310 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11311 * window.c (temp_output_buffer_show):
11312 * insdel.c (signal_before_change):
11313 * frame.c (Fhandle_switch_frame):
11314 * fileio.c (Fdo_auto_save):
11315 * emacs.c (Fkill_emacs):
11316 * editfns.c (save_excursion_restore):
11317 * cmds.c (internal_self_insert):
11318 * callint.c (Fcall_interactively):
11319 * buffer.c (Fkill_all_local_variables):
11320 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11322 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
11323 unconditionally since it does the check itself.
11325 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
11327 Fix more problems found by GCC 4.5.2's static checks.
11329 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11330 the first time through the loop, since we know p0 < p1 then.
11331 This also avoids a gcc -Wstrict-overflow warning.
11333 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11334 leading to a memory leak, possible in functions like
11335 load_charset_map_from_file that can allocate an unbounded number
11336 of objects (Bug#8318).
11338 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11339 that could (at least in theory) be that large.
11341 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11342 This is less likely to overflow, and avoids undefined behavior if
11343 overflow does occur. All callers changed. Use strtoul to scan
11344 for the unsigned long integer.
11345 (pint2hrstr): Simplify and tune code slightly.
11346 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
11348 * scroll.c (do_scrolling): Work around GCC bug 48228.
11349 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11351 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11352 This also avoids a warning with gcc -Wstrict-overflow.
11353 (validate_x_resource_name): Simplify count usage.
11354 This also avoids a warning with gcc -Wstrict-overflow.
11356 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11359 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
11361 * process.c (Fmake_network_process): Use socklen_t, not int,
11362 where POSIX says socklen_t is required in portable programs.
11363 This fixes a porting bug on hosts like 64-bit HP-UX, where
11364 socklen_t is wider than int (Bug#8277).
11365 (Fmake_network_process, server_accept_connection):
11366 (wait_reading_process_output, read_process_output):
11369 * process.c: Rename or move locals to avoid shadowing.
11370 (list_processes_1, Fmake_network_process):
11371 (read_process_output_error_handler, exec_sentinel_error_handler):
11372 Rename or move locals.
11373 (Fmake_network_process): Define label "retry_connect" only if needed.
11374 (Fnetwork_interface_info): Fix pointer signedness.
11375 (process_send_signal): Add cast to avoid pointer signedness problem.
11376 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
11377 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
11379 Make tparam.h and terminfo.c consistent.
11380 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11381 Include tparam.h instead, since it declares them.
11382 * cm.h (PC): Remove extern decl; tparam.h now does this.
11383 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11384 * terminfo.c: Include tparam.h, to check interfaces.
11385 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11386 (tparam): Adjust signature to match interface in tparam.h;
11387 this removes some undefined behavior. Check that outstring and len
11388 are zero, which they always are with Emacs.
11389 * tparam.h (PC, BC, UP): New extern decls.
11391 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
11392 (xftfont_open): Rename locals to avoid shadowing.
11394 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
11395 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11396 (OTF_TAG_SYM): Omit macro if not needed.
11397 (ftfont_list): Remove unused local.
11398 (get_adstyle_property, ftfont_pattern_entity):
11399 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11400 Rename locals to avoid shadowing.
11402 * xfont.c (xfont_list_family): Mark var as initialized.
11404 * xml.c (make_dom): Now static.
11406 * composite.c (composition_compute_stop_pos): Rename local to
11408 (composition_reseat_it): Remove unused locals.
11409 (find_automatic_composition, composition_adjust_point): Likewise.
11410 (composition_update_it): Mark var as initialized.
11411 (find_automatic_composition): Mark vars as initialized,
11412 with a FIXME (Bug#8290).
11414 character.h: Rename locals to avoid shadowing.
11415 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11416 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11417 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11418 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11419 to avoid shadowing.
11421 * textprop.c (property_change_between_p): Remove; unused.
11423 * intervals.c (interval_start_pos): Now static.
11425 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11427 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11428 Rename locals to avoid shadowing.
11430 * sound.c (wav_play, au_play, Fplay_sound_internal):
11431 Fix pointer signedness.
11432 (alsa_choose_format): Remove unused local var.
11433 (wav_play): Initialize a variable to 0, to prevent undefined
11434 behavior (Bug#8278).
11436 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11438 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11440 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11441 clobbering (Bug#8298).
11442 * sysdep.c (sys_subshell): Likewise.
11443 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
11445 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11446 This should get cleaned up, so that child_setup has the
11447 same signature on all platforms.
11449 * callproc.c (call_process_cleanup): Now static.
11450 (relocate_fd): Rename locals to avoid shadowing.
11452 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
11454 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11455 not to be necessary, and produces flickering.
11457 2011-03-20 Glenn Morris <rgm@gnu.org>
11459 * config.in: Remove file.
11461 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
11463 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11464 are now in src/globals.h.
11465 (syms_of_minibuf): Remove spurious & from previous change.
11467 2011-03-20 Leo Liu <sdl.web@gmail.com>
11469 * minibuf.c (completing-read-function): New variable.
11470 (completing-read-default): Rename from completing-read.
11471 (completing-read): Call completing-read-function.
11473 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11475 * xfaces.c (Fx_load_color_file):
11476 Read color file from absolute filename (bug#8250).
11478 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11480 * makefile.w32-in: Update dependencies.
11482 2011-03-17 Eli Zaretskii <eliz@gnu.org>
11484 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11486 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11488 Fix more problems found by GCC 4.5.2's static checks.
11490 * process.c (make_serial_process_unwind, send_process_trap):
11491 (sigchld_handler): Now static.
11493 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11494 That way, the code declares only the vars that it needs.
11495 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11496 * s/cygwin.h (PTY_ITERATION): Likewise.
11497 * s/darwin.h (PTY_ITERATION): Likewise.
11498 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11500 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11501 * process.c (allocate_pty): Don't declare stb unless it's needed.
11503 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
11504 (CONSTANTLIM): Remove; unused.
11505 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11506 Define only if needed.
11508 * unexelf.c (unexec): Name an expression,
11509 to avoid gcc -Wbad-function-cast warning.
11510 Use a different way to cause a compilation error if anyone uses
11511 n rather than nn, a way that does not involve shadowing.
11512 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
11514 * deps.mk (unexalpha.o): Remove; unused.
11516 New file unexec.h, the (simple) interface for unexec (Bug#8267).
11517 * unexec.h: New file.
11518 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11519 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11520 Depend on unexec.h.
11521 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11522 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11523 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
11524 Change as necessary to match prototype in unexec.h.
11526 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11528 (back_comment, skip_chars): Mark vars as initialized.
11530 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11531 Rename locals to avoid shadowing.
11533 * lread.c (read1): Rewrite so as not to use empty "else".
11534 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
11536 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11538 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11539 warning when compiling print.c.
11541 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11542 instead of using an uninitialized var.
11543 (font_sort_entities): Mark var as initialized.
11545 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11547 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11548 pointers to constants.
11549 (font_parse_fcname): Remove unused vars.
11550 (font_delete_unmatched): Now static.
11551 (font_get_spec): Remove; unused.
11552 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11553 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11554 Rename or move locals to avoid shadowing.
11556 * fns.c (require_nesting_list, require_unwind): Now static.
11557 (Ffillarray): Rename locals to avoid shadowing.
11559 * floatfns.c (domain_error2): Define only if needed.
11560 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11562 * alloc.c (mark_backtrace): Move decl from here ...
11563 * lisp.h: ... to here, so that it can be checked.
11565 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11566 (Fdefvar): Rewrite so as not to use empty "else".
11567 (lisp_indirect_variable): Name an expression,
11568 to avoid gcc -Wbad-function-cast warning.
11569 (Fdefvar): Rename locals to avoid shadowing.
11571 * callint.c (quotify_arg, quotify_args): Now static.
11572 (Fcall_interactively): Rename locals to avoid shadowing.
11573 Use const pointer when appropriate.
11575 * lisp.h (get_system_name, get_operating_system_release):
11576 Move decls here, to check interfaces.
11577 * process.c (get_operating_system_release): Move decl to lisp.h.
11578 * xrdb.c (get_system_name): Likewise.
11579 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11580 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11581 some of which prompt warnings from gcc -Wbad-function-cast.
11582 (Fformat_time_string, Fencode_time, Finsert_char):
11583 (Ftranslate_region_internal, Fformat):
11584 Rename or remove local vars to avoid shadowing.
11585 (Ftranslate_region_internal): Mark var as initialized.
11587 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11590 * lisp.h (eassert): Check that the argument compiles, even if
11591 ENABLE_CHECKING is not defined.
11593 * data.c (Findirect_variable): Name an expression, to avoid
11594 gcc -Wbad-function-cast warning.
11595 (default_value, arithcompare, arith_driver, arith_error): Now static.
11596 (store_symval_forwarding): Rename local to avoid shadowing.
11597 (Fmake_variable_buffer_local, Fmake_local_variable):
11598 Mark variables as initialized.
11599 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11601 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11602 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11603 Rename locals to avoid shadowing.
11604 (mark_stack): Move local variables into the #ifdef region where
11606 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11607 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11609 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11610 (GC_STRING_CHARS): Remove; not used.
11611 (Fmemory_limit): Cast sbrk's returned value to char *.
11613 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11614 avoids undefined behavior in theory.
11616 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11618 Use functions, not macros, for up- and down-casing (Bug#8254).
11619 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11620 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11621 to use the following functions instead of these macros.
11622 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11623 EMACS_INT, since callers assume the returned value fits in int.
11624 (upcase1): Likewise, for UPCASE_TABLE.
11625 (uppercasep, lowercasep, upcase): New static inline functions.
11626 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11627 the race-condition problem in the old DOWNCASE.
11629 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11630 Rename locals to avoid shadowing.
11631 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11632 (regex_compile, re_search_2, re_match_2_internal):
11633 Remove unused local vars.
11634 (FREE_VAR): Rewrite so as not to use empty "else",
11635 which gcc can warn about.
11636 (regex_compile, re_match_2_internal): Mark locals as initialized.
11637 (RETALLOC_IF): Define only if needed.
11638 (WORDCHAR_P): Likewise. This one is never needed, but is used
11639 only in a comment talking about a compiler bug, so put inside
11640 the #if 0 of that comment.
11641 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11642 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11645 * search.c (boyer_moore): Rename locals to avoid shadowing.
11646 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11647 (PREV_CHAR_BOUNDARY): Likewise.
11649 * search.c (simple_search): Remove unused var.
11651 * dired.c (compile_pattern): Move decl from here ...
11652 * lisp.h: ... to here, so that it can be checked.
11653 (struct re_registers): New forward decl.
11655 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11657 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11659 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11660 Rename locals to avoid shadowing.
11661 (Fvertical_motion): Mark locals as initialized.
11663 * casefiddle.c (casify_object, casify_region): Now static.
11664 (casify_region): Mark local as initialized.
11666 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11668 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11669 New macros, so that the caller can use some names other than
11670 gcpro1, gcpro2, etc.
11671 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11673 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11674 argument, for consistency with GCPRO2_VAR, etc: it is now the
11675 prefix of the variable, not the variable itself. All uses
11677 * dired.c (directory_files_internal, file_name_completion):
11678 Rename locals to avoid shadowing.
11680 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11681 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11682 dired.c's scmp function, had undefined behavior.
11683 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11684 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11685 * buffer.h: ... to here, because these macros use current_buffer,
11686 and the new implementation with inline functions needs to have
11687 current_buffer in scope now, rather than later when the macros
11689 (downcase, upcase1): New static inline functions.
11690 (DOWNCASE, UPCASE1): Reimplement using these functions.
11691 This avoids undefined behavior in expressions like
11692 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11693 from race conditions in accessing the global variables
11694 case_temp1 and case_temp2.
11695 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11696 * lisp.h (case_temp1, case_temp2): Remove their decls.
11697 * character.h (ASCII_CHAR_P): Move from here ...
11698 * lisp.h: ... to here, so that the inline functions mentioned
11699 above can use them.
11701 * dired.c (directory_files_internal_unwind): Now static.
11703 * fileio.c (file_name_as_directory, directory_file_name):
11704 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11706 (file_name_as_directory): Use const pointers when appropriate.
11707 (Fexpand_file_name): Likewise. In particular, newdir might
11708 point at constant storage, so make it a const pointer.
11709 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11710 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11712 (Fset_file_times, Finsert_file_contents, auto_save_error):
11713 Rename locals to avoid shadowing.
11715 * minibuf.c (choose_minibuf_frame_1): Now static.
11716 (Ftry_completion, Fall_completions): Rename or remove locals
11717 to avoid shadowing.
11719 * marker.c (bytepos_to_charpos): Remove; unused.
11721 * lisp.h (verify_bytepos, count_markers): New decls,
11722 so that gcc does not warn that these functions aren't declared.
11724 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11725 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11726 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11727 (copy_text): Remove unused local var.
11729 * filelock.c (within_one_second): Now static.
11730 (lock_file_1): Rename local to avoid shadowing.
11732 * buffer.c (fix_overlays_before): Mark locals as initialized.
11733 (fix_start_end_in_overlays): Likewise. This function should be
11734 simplified by using pointers-to-pointers, but that's a different
11736 (switch_to_buffer_1): Now static.
11737 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11738 (report_overlay_modification): Rename locals to avoid shadowing.
11740 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11741 Fix pointer signedness issue.
11742 (sys_subshell): Mark local as volatile if checking for lint,
11743 to suppress a gcc -Wclobbered warning that does not seem to be right.
11744 (MAXPATHLEN): Define only if needed.
11746 * process.c (serial_open, serial_configure): Move decls from here ...
11747 * systty.h: ... to here, so that they can be checked.
11749 * fns.c (get_random, seed_random): Move extern decls from here ...
11750 * lisp.h: ... to here, so that they can be checked.
11752 * sysdep.c (reset_io): Now static.
11753 (wait_for_termination_signal): Remove; unused.
11755 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11756 (copy_keymap_item, append_key, push_text_char_description):
11758 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11759 (DENSE_TABLE_SIZE): Remove; unused.
11760 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11761 (describe_map_tree):
11762 Rename locals to avoid shadowing.
11764 * keyboard.c: Declare functions static if they are not used elsewhere.
11765 (echo_char, echo_dash, cmd_error, top_level_2):
11766 (poll_for_input, handle_async_input): Now static.
11767 (read_char, kbd_buffer_get_event, make_lispy_position):
11768 (make_lispy_event, make_lispy_movement, apply_modifiers):
11769 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11770 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11771 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11772 (read_key_sequence, read_char): Mark locals as initialized.
11773 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11775 * keyboard.h (make_ctrl_char): New decl.
11776 (mark_kboards): Move decl here ...
11777 * alloc.c (mark_kboards): ... from here.
11779 * lisp.h (force_auto_save_soon): New decl.
11781 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11782 (DEFINE_DUMMY_FUNCTION): New macro.
11783 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11785 (main): Add casts to avoid warnings
11786 if GCC considers string literals to be constants.
11788 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11790 * dbusbind.c: Pointer signedness fixes.
11791 (xd_signature, xd_append_arg, xd_initialize):
11792 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11793 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11794 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11795 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11797 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11798 if GCC considers string literals to be constants.
11799 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11801 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11803 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11804 (print_preprocess, print_object): New macro to fix last change.
11806 * print.c (print_preprocess): Don't forget font objects.
11808 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11810 * emacs.c (USAGE3): Doc fixes.
11812 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11814 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11817 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11819 * lisp.h (VWindow_system, Qfile_name_history):
11820 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11821 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11822 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11824 * w32select.c: Don't #include "keyboard.h".
11825 (run_protected): Add extern declaration for waiting_for_input.
11827 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11828 * w32console.c (detect_input_pending, read_input_pending)
11829 (encode_terminal_code):
11830 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11831 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11832 (w32_system_caret_y, Qfile_name_history):
11833 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11834 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11835 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11836 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11837 * w32proc.c (Qlocal, report_file_error):
11838 * w32term.c (Vwindow_system, updating_frame):
11839 * w32uniscribe.c (initialized, uniscribe_font_driver):
11840 Remove unneeded extern declarations.
11842 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11844 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11846 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11848 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11849 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11850 These macros can no longer be used for assignment.
11852 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11853 Assign struct members directly, instead of using BUF_BEGV etc.
11854 (record_buffer_markers, fetch_buffer_markers): New functions for
11855 recording and fetching special buffer markers.
11856 (set_buffer_internal_1, set_buffer_temp): Use them.
11858 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11860 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11862 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11863 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11865 * xdisp.c (hscroll_window_tree):
11866 (reconsider_clip_changes): Use PT instead of BUF_PT.
11868 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11870 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11871 $(EMACS_ROOT)/lib/intprops.h.
11873 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11875 Fix more problems found by GCC 4.5.2's static checks.
11877 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11878 to unsigned char * to avoid compiler diagnostic.
11879 (xg_free_frame_widgets): Make it clear that a local variable is
11880 needed only if USE_GTK_TOOLTIP.
11881 (gdk_window_get_screen): Make it clear that this macro is needed
11882 only if USE_GTK_TOOLTIP.
11883 (int_gtk_range_get_value): New function, which avoids a diagnostic
11884 from gcc -Wbad-function-cast.
11885 (xg_set_toolkit_scroll_bar_thumb): Use it.
11886 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11887 diagnostic from gcc -Wbad-function-cast.
11888 (get_utf8_string, xg_get_file_with_chooser):
11889 Rename locals to avoid shadowing.
11890 (create_dialog): Move locals to avoid shadowing.
11892 * xgselect.c (xg_select): Remove unused var.
11894 * image.c (four_corners_best): Mark locals as initialized.
11895 (gif_load): Initialize transparent_p to zero (Bug#8238).
11896 Mark another local as initialized.
11897 (my_png_error, my_error_exit): Mark with NO_RETURN.
11899 * image.c (clear_image_cache): Now static.
11900 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11901 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11902 (x_edge_detection): Remove unnecessary cast that
11903 gcc -Wbad-function-cast diagnoses.
11904 (gif_load): Fix pointer signedness.
11905 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11906 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11908 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11910 Improve quality of tests for time stamp overflow.
11911 For example, without this patch (encode-time 0 0 0 1 1
11912 1152921504606846976) returns the obviously-bogus value (-948597
11913 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11914 reports time overflow. See
11915 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11916 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11917 * editfns.c: Include limits.h and intprops.h.
11918 (TIME_T_MIN, TIME_T_MAX): New macros.
11919 (time_overflow): Move earlier, to before first use.
11920 (hi_time, lo_time): New functions, for an accurate test for
11921 out-of-range times.
11922 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11923 (Fget_internal_run_time): Don't assume time_t fits in int.
11924 (make_time): Use list2 instead of Fcons twice.
11925 (Fdecode_time): More accurate test for out-of-range times.
11926 (check_tm_member): New function.
11927 (Fencode_time): Use it, to test for out-of-range times.
11928 (lisp_time_argument): Don't rely on undefined left-shift and
11929 right-shift behavior when checking for time stamp overflow.
11931 * editfns.c (time_overflow): New function, refactoring common code.
11932 (Fformat_time_string, Fdecode_time, Fencode_time):
11933 (Fcurrent_time_string): Use it.
11935 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11936 * dired.c (make_time): Move to ...
11937 * editfns.c (make_time): ... here.
11938 * systime.h: Note the move.
11940 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11942 * fringe.c (update_window_fringes): Remove unused variables.
11944 * unexmacosx.c (copy_data_segment): Also copy __got section.
11947 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11949 * termcap.c [MSDOS]: Include "msdos.h".
11950 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11951 Constify `char *' arguments and their references according to
11952 prototypes in tparam.h.
11954 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11956 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11957 Adapt all references accordingly.
11959 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11961 2011-03-11 Tom Tromey <tromey@redhat.com>
11963 * buffer.c (syms_of_buffer): Remove obsolete comment.
11965 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11967 * termhooks.h (encode_terminal_code): Declare prototype.
11969 * msdos.c (encode_terminal_code): Don't declare prototype.
11971 * term.c (encode_terminal_code): Now external again, used by
11972 w32console.c and msdos.c.
11974 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11975 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11977 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11979 Fix some minor problems found by GCC 4.5.2's static checks.
11981 * fringe.c (update_window_fringes): Mark locals as initialized
11983 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11985 * alloc.c (mark_fringe_data): Move decl from here ...
11986 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11987 to check its interface.
11988 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11990 * fontset.c (free_realized_fontset): Now static.
11991 (Fset_fontset_font): Rename local to avoid shadowing.
11992 (fontset_font): Mark local as initialized.
11993 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11995 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11997 * xselect.c (x_disown_buffer_selections): Remove; not used.
11998 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11999 (x_own_selection, Fx_disown_selection_internal): Rename locals
12000 to avoid shadowing.
12001 (x_handle_dnd_message): Remove local to avoid shadowing.
12003 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12004 so that the caller can use some name other than gcpro1.
12005 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
12006 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12007 (Fx_backspace_delete_keys_p):
12008 Use them to avoid shadowing, and rename vars to avoid shadowing.
12009 (x_decode_color, x_set_name, x_window): Now static.
12010 (Fx_create_frame): Add braces to silence GCC warning.
12011 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
12012 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12013 Remove unused locals.
12014 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12015 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12016 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12019 * xterm.h (x_mouse_leave): New decl.
12021 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12022 Remove unused functions.
12023 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12024 (x_calc_absolute_position): Now static.
12025 (XTread_socket): Don't define label "out" unless it's used.
12026 Don't declare local "event" unless it's used.
12027 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12028 unless they are used.
12029 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12030 (x_fatal_error_signal): Remove; not used.
12031 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12032 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12033 (x_error_catcher, x_connection_closed, x_error_handler):
12034 (x_error_quitter, xembed_send_message, x_iconify_frame):
12035 (my_log_handler): Rename locals to avoid shadowing.
12036 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
12037 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
12039 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12040 Rename or move locals to avoid shadowing.
12041 (tty_defined_color, merge_face_heights): Now static.
12042 (free_realized_faces_for_fontset): Remove; not used.
12043 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12044 does not deduce is never used uninitialized.
12045 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12046 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
12048 * terminal.c (store_terminal_param): Now static.
12050 * xmenu.c (menu_highlight_callback): Now static.
12051 (set_frame_menubar): Remove unused local.
12052 (xmenu_show): Rename parameter to avoid shadowing.
12053 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12054 since they might point to immutable storage.
12055 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12056 since it's unused otherwise.
12058 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
12059 Add a FIXME, since the code still doesn't look right. (Bug#8215)
12060 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12061 avoids a gcc -Wuninitialized diagnostic.
12062 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
12063 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12064 does not deduce are never used uninitialized.
12066 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12068 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
12069 * window.c (window_loop, size_window):
12070 (run_window_configuration_change_hook, enlarge_window): Likewise.
12072 * window.c (display_buffer): Now static.
12073 (size_window): Mark variables that gcc -Wuninitialized
12074 does not deduce are never used uninitialized.
12075 * window.h (check_all_windows): New decl, to forestall
12076 gcc -Wmissing-prototypes diagnostic.
12077 * dispextern.h (bidi_dump_cached_states): Likewise.
12079 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12081 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
12082 Include <limits.h>.
12083 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12084 and to avoid gcc -Wuninitialized warning.
12085 (load_charset_map): Mark variables that gcc -Wuninitialized
12086 does not deduce are never used uninitialized.
12087 (load_charset): Abort instead of using uninitialized var (Bug#8229).
12089 * coding.c (coding_set_source, coding_set_destination):
12090 Use "else { /* comment */ }" rather than "else /* comment */;"
12091 for clarity, and to avoid gcc -Wempty-body warning.
12092 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12093 a block, when the outer 'i' will do.
12094 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12095 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12096 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12097 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12098 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12099 Rename locals to avoid shadowing.
12100 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
12101 * coding.c (emacs_mule_char, encode_invocation_designation):
12102 Now static, since they're not used elsewhere.
12103 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
12104 (decode_coding_object, encode_coding_object, detect_coding_system):
12105 (decode_coding_emacs_mule): Mark variables that gcc
12106 -Wuninitialized does not deduce are never used uninitialized.
12107 (detect_coding_iso_2022): Initialize a local variable that might
12108 be used uninitialized. Leave a FIXME because it's not clear that
12109 this initialization is needed. (Bug#8211)
12110 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12111 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12112 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12113 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12114 Remove unused macros.
12116 * category.c (hash_get_category_set): Remove unused local var.
12117 (copy_category_table): Now static, since it's not used elsewhere.
12118 * character.c (string_count_byte8): Likewise.
12120 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12121 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12123 * chartab.c (copy_sub_char_table): Now static, since it's not used
12125 (sub_char_table_ref_and_range, char_table_ref_and_range):
12126 Rename locals to avoid shadowing.
12127 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
12129 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
12130 (BIDI_BOB): Remove unused macro.
12132 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12133 deduce are never used uninitialized.
12134 * term.c (encode_terminal_code): Likewise.
12136 * term.c (encode_terminal_code): Now static. Remove unused local.
12138 * tparam.h: New file.
12139 * term.c, tparam.h: Include it.
12140 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12141 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12142 Move these decls to tparam.h, and make them agree with what
12143 is actually in tparam.c. The previous trick of using incompatible
12144 decls in different modules does not conform to the C standard.
12145 All callers of tparam changed to use tparam's actual API.
12146 * tparam.c (tparam1, tparam, tgoto):
12147 Use const pointers where appropriate.
12149 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12150 * cm.h (struct cm): Likewise.
12151 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12152 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12153 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12154 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12155 (turn_on_face, init_tty): Likewise.
12156 * termchar.h (struct tty_display_info): Likewise.
12158 * term.c (term_mouse_position): Rename local to avoid shadowing.
12160 * alloc.c (mark_ttys): Move decl from here ...
12161 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12163 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12165 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12167 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
12169 * search.c (compile_pattern_1): Remove argument regp, unused since
12170 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12171 (compile_pattern): Don't pass it.
12173 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12175 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12176 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12178 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12180 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12182 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12183 gdk_window_get_screen, gdk_window_get_geometry,
12184 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12185 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12186 (xg_get_pixbuf_from_pixmap): New function.
12187 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12188 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12189 Call xg_get_pixbuf_from_pixmap instead of
12190 gdk_pixbuf_get_from_drawable.
12191 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12192 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12193 (xg_check_special_colors): Use GtkStyleContext and its functions
12195 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12196 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12197 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
12198 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12199 Call gtk_widget_get_preferred_size.
12200 (xg_frame_resized): gdk_window_get_geometry only takes 5
12202 (xg_win_to_widget, xg_event_is_for_menubar):
12203 Call gdk_x11_window_lookup_for_display.
12204 (xg_set_widget_bg): New function.
12205 (delete_cb): New function.
12206 (xg_create_frame_widgets): Connect delete-event to delete_cb.
12207 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
12208 (xg_set_background_color): Call xg_set_widget_bg.
12209 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12210 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12211 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12212 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12214 (update_frame_tool_bar): Call gtk_widget_hide.
12215 (xg_initialize): Use GDK_KEY_g.
12217 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12219 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12221 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12222 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12223 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12225 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
12227 * w32xfns.c (select_palette): Check success of RealizePalette against
12228 GDI_ERROR, not zero.
12230 See ChangeLog.11 for earlier changes.
12232 ;; Local Variables:
12236 Copyright (C) 2011-2012 Free Software Foundation, Inc.
12238 This file is part of GNU Emacs.
12240 GNU Emacs is free software: you can redistribute it and/or modify
12241 it under the terms of the GNU General Public License as published by
12242 the Free Software Foundation, either version 3 of the License, or
12243 (at your option) any later version.
12245 GNU Emacs is distributed in the hope that it will be useful,
12246 but WITHOUT ANY WARRANTY; without even the implied warranty of
12247 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12248 GNU General Public License for more details.
12250 You should have received a copy of the GNU General Public License
12251 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.