1 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6 * nsterm.h (ns_get_defaults_value): Declare.
8 * nsterm.m (ns_default): Call ns_get_defaults_value.
10 2011-12-09 Eli Zaretskii <eliz@gnu.org>
12 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
15 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
17 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
18 that where the value of an _OBJC_* symbol points to is in the .bss
21 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
23 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
24 after the loop to call ccl_driver at least once (Bug#8619).
26 2011-12-08 Kenichi Handa <handa@m17n.org>
28 * ftfont.c (get_adstyle_property): Fix previous change
31 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
33 * w32.c (init_environment): If no_site_lisp, remove site-lisp
34 dirs from the default value of EMACSLOADPATH (bug#10208).
36 2011-12-07 Glenn Morris <rgm@gnu.org>
38 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
39 installation and source directories as well. (Bug#10208)
41 2011-12-06 Chong Yidong <cyd@gnu.org>
43 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
45 2011-12-06 Glenn Morris <rgm@gnu.org>
47 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
48 as an error, not just -1. (Bug#10217)
50 2011-12-05 Chong Yidong <cyd@gnu.org>
52 * keyboard.c (process_special_events): New function.
53 (swallow_events, Finput_pending_p): Use it (Bug#10195).
55 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
57 * coding.c (encode_designation_at_bol): Don't use uninitialized
58 local variable (Bug#9318).
60 2011-12-05 Kenichi Handa <handa@m17n.org>
62 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
63 return Qnil (Bug#8046, Bug#10193).
65 2011-12-05 Kenichi Handa <handa@m17n.org>
67 * coding.c (encode_designation_at_bol): New args charbuf_end and
68 dst. Return the number of produced bytes. Callers changed.
69 (coding_set_source): Return how many bytes coding->source was
71 (coding_set_destination): Return how many bytes
72 coding->destination was relocated.
73 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
74 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
76 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
78 * coding.c (CODING_CHAR_CHARSET_P): New macro.
79 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
82 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
84 The following changes are to fix Bug#9318.
86 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
87 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
88 (encode_coding_iso_2022, encode_coding_sjis)
89 (encode_coding_big5, encode_coding_charset): Use the above macros.
91 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
93 * lisp.h (process_quit_flag): Fix external declaration.
95 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
97 Don't macro-inline non-performance-critical code.
98 * eval.c (process_quit_flag): New function.
99 * lisp.h (QUIT): Use it.
101 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
103 * nsfns.m (get_geometry_from_preferences): New function.
104 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
106 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
108 * emacs.c (Qkill_emacs): Define.
109 (syms_of_emacs): Initialize it.
110 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
111 Qquit_flag to `kill-emacs' instead.
112 (quit_throw_to_read_char): Add parameter `from_signal'.
113 All callers changed. Call Fkill_emacs if requested and safe.
114 * lisp.h (QUIT): Call Fkill_emacs if requested.
116 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
118 * widget.c (update_wm_hints): Return if wmshell is null.
119 (widget_update_wm_size_hints): New function.
121 * widget.h (widget_update_wm_size_hints): Declare.
123 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
124 widget_update_wm_size_hints (Bug#10104).
126 2011-12-03 Eli Zaretskii <eliz@gnu.org>
128 * xdisp.c (handle_invisible_prop): If the invisible text ends just
129 before a newline, prepare the bidi iterator for consuming the
130 newline, and keep the current paragraph direction. (Bug#10183)
131 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
133 2011-12-02 Juri Linkov <juri@jurta.org>
135 * search.c (Fword_search_regexp): New Lisp function created from
136 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
137 (Fword_search_backward, Fword_search_forward)
138 (Fword_search_backward_lax, Fword_search_forward_lax):
139 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
140 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
142 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
144 * fileio.c (Finsert_file_contents): Move after-change-function call
145 to before the "handled:" label, since all "goto handled" appear in
146 cases where the *-change-functions have already been properly called
149 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
151 * keyboard.c (interrupt_signal): Don't call kill-emacs when
152 waiting for input. (Bug#10169)
154 2011-11-30 Eli Zaretskii <eliz@gnu.org>
156 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
157 verifies glyph row's hash code--we have just reallocated the
158 glyphs, so their contents can be complete garbage. (Bug#10164)
160 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
162 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
164 2011-11-30 Eli Zaretskii <eliz@gnu.org>
166 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
167 attributes are tested _before_ calling verify_row_hash, to protect
168 against GCC re-ordering of the tests. (Bug#10164)
170 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
172 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
174 * xterm.c (handle_one_xevent): Only set async_visible and friends
175 if net_wm_state_hidden_seen is non-zero (Bug#10002)
176 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
177 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
179 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
181 Remove GCPRO-related macros that exist only to avoid shadowing locals.
182 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
183 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
184 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
185 All uses changed to use GCPRO1 etc.
186 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
187 Revert to old implementation (i.e., before 2011-03-11).
189 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
191 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
192 of scroll runs so as to avoid assigning disabled bogus rows and
193 unnecessary graphics copy operations.
195 2011-11-27 Eli Zaretskii <eliz@gnu.org>
197 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
198 (snprintf) [_MSC_VER]: Redirect to _snprintf.
199 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
200 (malloc, free, realloc, calloc): Redirect to e_* only when
203 * lisp.h (GCTYPEBITS): Move before first use.
204 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
205 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
206 this macro definition.
208 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
211 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
213 * gtkutil.c (xg_create_frame_widgets):
214 Call gtk_window_set_has_resize_grip (FALSE) if that function is
215 present with Gtk+ 2.0.
217 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
219 * fileio.c (Finsert_file_contents): Undo previous change; see
220 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
222 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
224 Rename locals to avoid shadowing.
225 * fileio.c (Finsert_file_contents):
226 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
227 * process.c (wait_reading_process_output):
228 Rename inner 'proc' to 'p' to avoid shadowing.
229 Indent for consistency with usual Emacs style.
231 2011-11-25 Eli Zaretskii <eliz@gnu.org>
233 * xdisp.c (redisplay_window): If cursor row is not fully visible
234 after recentering, and scroll-conservatively is set to a large
235 number, scroll window by a few more lines to make the cursor fully
236 visible and out of scroll-margin. (Bug#10105)
237 (start_display): Don't move to the next line if the display should
238 start at a newline that is part of a display vector or an overlay
241 2011-11-24 Juri Linkov <juri@jurta.org>
243 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
244 after the `MagickPingImage' call. (Bug#10112)
246 2011-11-23 Chong Yidong <cyd@gnu.org>
248 * window.c (Fcoordinates_in_window_p): Accept only live windows.
250 2011-11-23 Martin Rudalics <rudalics@gmx.at>
252 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
253 making another buffer current. (Bug#10114)
255 2011-11-23 Glenn Morris <rgm@gnu.org>
257 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
259 2011-11-23 Chong Yidong <cyd@gnu.org>
261 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
264 2011-11-22 Eli Zaretskii <eliz@gnu.org>
266 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
267 and header-lines, as they don't have one computed for them.
270 * .gdbinit (prow): Make displayed values more self-explaining.
273 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
275 * process.c (wait_reading_process_output): Fix asynchrounous
276 GnuTLS socket handling on some versions of the GnuTLS library.
277 (wait_reading_process_output): Add comment and URL.
279 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
281 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
283 2011-11-21 Chong Yidong <cyd@gnu.org>
285 * window.c (Fnext_window, Fprevious_window): Doc fix.
287 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
289 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
291 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
293 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
295 2011-11-20 Martin Rudalics <rudalics@gmx.at>
297 * window.c (Fset_window_combination_limit): Rename argument
299 (Vwindow_combination_limit): Remove "status" from doc-string.
301 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
303 * m/ibms390.h: Remove.
304 * m/ibms390x.h: Don't include "ibms390.h".
306 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
308 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
309 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
311 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
313 * casetab.c (Fset_case_table):
314 * charset.c (Fcharset_after): Fix typos.
316 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
318 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
319 Otherwise, valgrind does not work on some platforms.
320 Problem reported by Andreas Schwab in
321 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
322 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
323 is set, removing the need for VIRT_ADDRESS_VARIES.
324 (PURE_P): Use a more-efficient implementation that needs just one
325 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
326 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
327 to 4 (xorl, subq, cmpq, setbe).
328 * alloc.c (pure): Always extern now, since that's the
329 VIRT_ADDR_VARIES behavior.
330 (PURE_POINTER_P): Use a single comparison, not two, for
331 consistency with the new puresize.h.
332 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
333 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
334 Remove VIRT_ADDR_VARIES no longer needed.
336 2011-11-19 Eli Zaretskii <eliz@gnu.org>
338 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
339 (erase_phys_cursor, update_window_cursor, show_mouse_face)
340 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
341 behave as if the cursor position were at the window margin.
343 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
344 and the cursor position is out of bounds, behave as if the cursor
345 position were at the window margin. (Bug#10075)
347 2011-11-18 Chong Yidong <cyd@gnu.org>
349 * window.c (Fwindow_combination_limit): Make first argument
350 non-optional, since it is meaningless for live windows like the
353 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
355 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
357 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
359 * intervals.c: Fix grafting over the whole buffer (bug#10071).
360 (graft_intervals_into_buffer): Simplify.
362 2011-11-18 Eli Zaretskii <eliz@gnu.org>
364 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
365 hash values of the two rows.
366 (copy_row_except_pointers): Preserve the used[] arrays and the
367 hash values of the two rows. (Bug#10035)
368 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
370 * xdisp.c (row_hash): New function, body extracted from
371 compute_line_metrics.
372 (compute_line_metrics): Call row_hash, instead of computing the
375 * dispnew.c (verify_row_hash): Call row_hash for computing the
376 hash code of a row, instead of duplicating code from xdisp.c.
378 * dispextern.h (row_hash): Add prototype.
380 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
382 * frame.c (delete_frame): Don't delete the terminal when the last
383 X frame is closed if emacs is built with GTK toolkit.
385 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
387 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
389 2011-11-17 Martin Rudalics <rudalics@gmx.at>
391 * window.c (Vwindow_splits): Rename to
392 Vwindow_combination_resize. Suggested by Juri Linkov.
393 (Fsplit_window_internal): Use Vwindow_combination_resize instead
396 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
398 * nsfns.m (Fns_font_name):
399 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
401 2011-11-16 Martin Rudalics <rudalics@gmx.at>
403 * window.h (window): Rename slot "nest" to "combination_limit".
404 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
405 (Fset_window_nest): Rename to Fset_window_combination_limit.
406 (Vwindow_nest): Rename to Vwindow_combination_limit.
407 (recombine_windows, make_parent_window, make_window)
408 (Fsplit_window_internal, saved_window)
409 (Fset_window_configuration, save_window_save): Rename all
410 occurrences of window_nest to window_combination_limit.
412 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
414 * image.c (imagemagick_load_image): Fix typo.
416 2011-11-14 Eli Zaretskii <eliz@gnu.org>
418 * xdisp.c (display_line): Move the call to
419 highlight_trailing_whitespace before the call to
420 compute_line_metrics, since the latter needs to see the final
421 faces of all the glyphs to compute ROW's hash value.
422 Fixes assertion violations in row_equal_p. (Bug#10035)
424 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
426 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
427 just return (bug#10044).
429 2011-11-12 Eli Zaretskii <eliz@gnu.org>
431 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
432 with user-defined heap size. Bump the default size of the temacs
433 heap to 27MB, to avoid memory warning when running temacs.
434 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
436 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
437 current_matrix and desired_matrix. (Bug#9990)
438 (verify_row_hash) [XASSERTS]: New function.
439 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
440 that the hash value of glyph rows is correct.
442 2011-11-12 Martin Rudalics <rudalics@gmx.at>
444 * window.h (window): Remove splits slot.
445 * window.c (Fwindow_splits, Fset_window_splits): Remove.
446 (Fdelete_other_windows_internal, make_parent_window)
447 (make_window, Fsplit_window_internal, Fdelete_window_internal)
448 (Fset_window_configuration, save_window_save): Don't deal with
449 split status of windows.
450 (saved_window): Remove splits slot.
451 (Vwindow_splits): Rewrite doc-string.
453 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
455 * xfns.c (unwind_create_frame):
456 * nsfns.m (unwind_create_frame):
457 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
458 Vframe_list (Bug#9999).
460 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
462 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
464 2011-11-11 Kenichi Handa <handa@m17n.org>
466 * callproc.c (Fcall_process): Set the member dst_multibyte of
469 2011-11-11 Johan Bockgård <bojohan@gnu.org>
471 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
472 avoid a crash (bug#9496).
474 2011-11-09 Chong Yidong <cyd@gnu.org>
476 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
477 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
479 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
481 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
483 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
485 Avoid some portability problems by eschewing 'extern inline' functions.
486 The trivial performance wins aren't worth the portability hassles; see
487 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
489 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
490 (window_box_width, window_box_left, window_box_left_offset)
491 (window_box_right, window_box_right_offset): Undo previous change,
492 by removing the "extern"s.
493 * intervals.c (adjust_intervals_for_insertion)
494 (adjust_intervals_for_deletion): Undo previous change,
495 making these static again.
496 (offset_intervals, temp_set_point_both, temp_set_point)
497 (copy_intervals_to_string): No longer inline.
498 * xdisp.c (window_text_bottom_y, window_box_width)
499 (window_box_height, window_box_left_offset)
500 (window_box_right_offset, window_box_left, window_box_right)
501 (window_box): No longer inline.
503 2011-11-08 Chong Yidong <cyd@gnu.org>
505 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
506 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
507 Signal an error if not a live window.
508 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
509 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
511 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
513 * lisp.h (syms_of_abbrev): Remove declaration.
514 Reported by CHENG Gao <chenggao@royau.me>.
516 2011-11-07 Eli Zaretskii <eliz@gnu.org>
518 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
519 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
520 of temacs in GUI mode.
522 2011-11-07 Martin Rudalics <rudalics@gmx.at>
524 * window.h: Declare delete_all_child_windows instead of
525 delete_all_subwindows.
526 * window.c (Fwindow_nest, Fset_window_nest)
527 (Fset_window_new_total, Fset_window_new_normal)
528 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
529 (delete_all_subwindows): Rename to delete_all_child_windows.
530 (Fdelete_other_windows_internal, Fset_window_configuration):
531 Call delete_all_child_windows instead of delete_all_subwindows.
532 * frame.c (delete_frame): Call delete_all_child_windows instead
533 of delete_all_subwindows.
535 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
537 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
538 This is also needed for porting to any host where GC_MARK_STACK is
539 not GC_MAKE_GCPROS_NOOPS.
540 (which_symbols): Use it.
542 2011-11-07 Kenichi Handa <handa@m17n.org>
544 * coding.c (coding_set_destination): Check coding->src_pos only
545 when coding->src_object is a buffer (bug#9910).
547 * process.c (send_process): Set the member src_multibyte of coding
548 to 0 (bug#9911) when sending a unibyte text.
550 * callproc.c (Fcall_process): Set the member src_multibyte of
551 process_coding to 0 (bug#9912).
553 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
555 * xmenu.c (cleanup_widget_value_tree): New function.
556 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
557 calling free_menubar_widget_value_tree directly (Bug#9830).
559 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
561 Fix some portability problems with 'inline'.
562 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
563 (window_box_width, window_box_left, window_box_left_offset)
564 (window_box_right, window_box_right_offset): Declare extern.
565 Otherwise, these inline functions do not conform to C99 and
566 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
567 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
568 * intervals.c (adjust_intervals_for_insertion)
569 (adjust_intervals_for_deletion): Now extern, because otherwise the
570 extern inline functions 'offset_intervals' couldn't refer to it.
571 (static_offset_intervals): Remove.
572 (offset_intervals): Rewrite using the old contents of
573 static_offset_intervals. The old version didn't conform to C99
574 because an extern inline function contained a reference to an
575 identifier with static linkage.
577 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
579 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
582 2011-11-06 Eli Zaretskii <eliz@gnu.org>
584 * xdisp.c (init_iterator, reseat_to_string): Don't set the
585 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
586 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
587 return Qleft_to_right.
589 2011-11-06 Chong Yidong <cyd@gnu.org>
591 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
592 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
593 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
594 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
595 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
596 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
597 (Fwindow_vscroll): Doc fix.
598 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
599 argument, since it makes no sense to pass a live window and for
600 consistency with window-child.
602 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
604 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
607 2011-11-05 Jason Rumney <jasonr@gnu.org>
609 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
610 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
612 (add_font_entity_to_list): Fix logic errors in mixed boolean and
613 bitwise arithmetic preventing use of unicode-sip and non-truetype
616 2011-11-05 Eli Zaretskii <eliz@gnu.org>
618 * s/ms-w32.h (fstat, stat, utime): Move redirections to
621 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
622 initialization code to keep similarity to xfns.c after changes
625 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
627 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
628 (unwind_create_frame): New function (Bug#9943).
629 (Fx_create_frame): Restructure code to be more similar to the one in
630 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
631 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
632 Move terminal->reference_count++ just before making the frame official
635 * nsterm.m (x_free_frame_resources): New function.
636 (x_destroy_window): Move code to x_free_frame_resources.
638 * xfns.c (unwind_create_frame): Fix comment.
639 (Fx_create_frame, x_create_tip_frame):
640 Move terminal->reference_count++ just before making the frame
641 official. Move initialization of image_cache_refcount and
642 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
644 2011-11-05 Eli Zaretskii <eliz@gnu.org>
646 Support MSVC build with newer versions of Visual Studio.
647 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
648 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
651 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
652 which are not supported by MSVC.
653 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
654 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
656 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
658 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
660 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
662 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
664 Support MSVC build with newer versions of Visual Studio.
665 * w32.c: Don't include w32api.h for MSVC.
666 (init_environment) [_MSC_VER]: Call sys_access, not _access.
668 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
669 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
670 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
671 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
673 (alloca) [_MSC_VER]: Define to _alloca.
675 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
677 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
679 2011-11-04 Eli Zaretskii <eliz@gnu.org>
681 * xdisp.c (note_mouse_highlight): If either of
682 previous/next-single-property-change returns nil, treat that as
683 the beginning or the end of the buffer. (Bug#9955)
685 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
687 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
688 label is not null (Bug#9951).
689 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
692 2011-11-04 Eli Zaretskii <eliz@gnu.org>
694 * window.c (Fwindow_body_size): Mention in the doc string that the
695 return value is in frame's canonical units. (Bug#9949)
697 2011-11-03 Eli Zaretskii <eliz@gnu.org>
699 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
701 * w32fns.c (unwind_create_frame): If needed, free the glyph
702 matrices of the partially constructed frame. (Bug#9943)
703 * xfns.c (unwind_create_frame): Likewise.
705 2011-11-01 Eli Zaretskii <eliz@gnu.org>
707 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
708 Don't stop backward scan on the continuation glyph, even though
709 its CHARPOS is positive.
710 (mouse_face_from_buffer_pos, note_mouse_highlight):
711 Rename cover_string to disp_string.
713 2011-11-01 Martin Rudalics <rudalics@gmx.at>
715 * window.c (temp_output_buffer_show): Don't use
716 Vtemp_buffer_show_specifiers.
717 (Vtemp_buffer_show_specifiers): Remove unused variable.
719 2011-10-30 Eli Zaretskii <eliz@gnu.org>
721 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
722 past the beginning of the current glyph matrix.
724 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
726 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
727 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
728 HAVE_GTK3 (Bug#9869).
730 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
731 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
733 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
735 * xterm.c: Declare x_handle_net_wm_state to return int.
736 (handle_one_xevent): Check if we are iconified but don't have
737 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
738 (get_current_wm_state): Return non-zero if not hidden,
739 check for _NET_WM_STATE_HIDDEN (Bug#9893).
740 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
741 (x_handle_net_wm_state): Return what get_current_wm_state returns.
742 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
744 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
746 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
747 so that this new function doesn't get optimized away by a
748 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
750 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
752 * frame.h (MOUSE_HL_INFO): Remove excess parens.
754 2011-10-29 Eli Zaretskii <eliz@gnu.org>
756 Fix the `xbytecode' command.
757 * .gdbinit (xprintbytestr): New command.
758 (xwhichsymbols): Rename from `which'; all callers changed.
759 (xbytecode): Print the byte-code string as well.
761 2011-10-29 Kim Storm <storm@cua.dk>
763 * alloc.c (which_symbols): New function.
765 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
767 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
770 2011-10-29 Glenn Morris <rgm@gnu.org>
772 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
773 Not clear what it was for, and it causes various bugs. (Bug#9839)
775 2011-10-28 Eli Zaretskii <eliz@gnu.org>
777 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
778 possible random value that matches one of those tested as
779 condition to clear the mouse face.
781 2011-10-28 Chong Yidong <cyd@gnu.org>
783 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
785 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
787 * window.c (make_window): Initialize phys_cursor_on_p.
789 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
791 * lisp.h (struct Lisp_Symbol): Update comments.
793 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
795 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
797 2011-10-28 Eli Zaretskii <eliz@gnu.org>
799 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
800 <oslsachem@gmail.com> for helping to debug this.
802 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
803 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
804 (g_b_init_get_glyph_outline_w): New static variables.
805 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
806 (GetGlyphOutlineW_Proc): New typedefs.
807 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
808 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
810 (w32font_open_internal, compute_metrics):
811 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
812 instead of calling the "wide" APIs directly.
814 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
816 * w32.h (syms_of_w32font): Add prototype.
818 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
820 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
821 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
822 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
823 (Fmove_to_window_line): Doc fix.
825 2011-10-27 Chong Yidong <cyd@gnu.org>
827 * process.c (make_process): Set gnutls_state to NULL.
829 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
830 non-NULL, regardless of GNUTLS_INITSTAGE.
831 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
832 an error. Set process slots as soon as we allocate them.
834 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
836 2011-10-27 Chong Yidong <cyd@gnu.org>
838 * gnutls.c (emacs_gnutls_deinit): New function.
839 Deallocate credentials structures as well as calling gnutls_deinit.
840 (Fgnutls_deinit, Fgnutls_boot): Use it.
842 * process.c (make_process): Initialize GnuTLS credentials to NULL.
843 (deactivate_process): Call emacs_gnutls_deinit.
845 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
847 * image.c (x_create_x_image_and_pixmap):
848 * w32.c (sys_rename, w32_delayed_load):
849 * w32font.c (fill_in_logfont):
850 * w32reg.c (x_get_string_resource): Silence compiler warnings.
852 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
854 * w32fns.c (w32_default_color_map): New function,
855 extracted from Fw32_default_color_map.
856 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
858 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
860 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
862 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
864 * keyboard.c (test_undefined): New function (bug#9751).
865 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
867 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
869 * sysdep.c (init_sys_modes): Fix the check for the controlling
872 2011-10-20 Eli Zaretskii <eliz@gnu.org>
874 * dispextern.h (struct bidi_it): New member next_en_type.
876 * bidi.c (bidi_line_init): Initialize the next_en_type member.
877 (bidi_resolve_explicit_1): When next_en_pos is valid for the
878 current character, check also for next_en_type being WEAK_EN.
879 (bidi_resolve_weak): Don't enter the expensive loop if the current
880 position is before next_en_pos. Record the bidi type of the first
881 non-ET, non-BN character we find, in addition to its position.
882 (bidi_level_of_next_char): Invalidate next_en_type when
883 next_en_pos is over-stepped.
885 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
887 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
888 * editfns.c: Rewrite current-time-zone so that it invokes
889 the equivalent of (format-time-string "%Z") to get the time zone name.
890 This fixes a bug when the time zone name contains characters that
891 need converting from the system time locale to Emacs internal format.
892 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
893 that patch fixed format-time-string to do the conversion, but
894 I forgot to fix current-time-zone.
895 (format_time_string): New function, containing most of
896 what Fformat_time_string used to contain.
897 (Fformat_time_string): Rewrite in terms of format_time_string.
898 This doesn't change this function's behavior.
899 (current-time-zone): Rewrite to use format_time_string.
900 This fixes the bug reported by Michael Schierl in
901 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
902 Jason Rumney's 2007-06-07 change worked around this bug, but
904 * systime.h (tzname, timezone): Remove no-longer-used declarations.
906 2011-10-19 Eli Zaretskii <eliz@gnu.org>
908 * xdisp.c (start_display): If the character at POS is displayed
909 via a display vector, reset IT->current.dpvec_index to zero.
910 (try_window_reusing_current_matrix): If a line ends in a display
911 vector or the next line starts in a display vector, continue
912 redrawing the window even though the character position of
913 start_row was reached.
916 2011-10-18 Chong Yidong <cyd@gnu.org>
918 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
919 with nobreak-char-display too.
921 2011-10-18 Eli Zaretskii <eliz@gnu.org>
923 Fix part 3 of bug#9771.
924 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
925 (bidi_resolve_neutral): Don't enter the expensive loop looking for
926 non-neutral characters if the current character is a paragraph
927 separator (a.k.a. Newline). This avoids running the same
928 expensive loop twice, once when we consume the preceding newline
929 and the other time when the line actually needs to be displayed.
930 Avoid the loop when we see neutrals on the base embedding level
931 following a character whose directionality is the same as the
932 paragraph's. This avoids running the expensive loop when a line
933 ends in a long sequence of neutrals, like control characters.
934 Add assertion against STRONG_AL type. Slightly rearrange code
935 that determines the type of a neutral given the first non-neutral
937 (bidi_level_of_next_char): Set next_en_pos to zero when
938 invalidating its info.
940 2011-10-17 Eli Zaretskii <eliz@gnu.org>
942 * xdisp.c (push_display_prop): Determine whether to record string
943 or buffer position by IT->string, not by IT->method. Allow
944 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
945 (move_it_vertically_backward): Don't look for character position
946 immediately after the newline when in a continuation line.
949 2011-10-15 Martin Rudalics <rudalics@gmx.at>
951 * window.c (coordinates_in_window): Rewrite and delabelize
952 vertical border check. (Bug#5357) (Bug#9618)
954 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
956 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
957 errors in XSetWindowBorder (bug#9310).
959 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
961 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
962 avoid crash when xmalloc overrun checking is enabled.
964 2011-10-13 Eli Zaretskii <eliz@gnu.org>
966 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
967 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
968 cursor motion with <left> and <right> arrow keys.
970 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
971 some callers set that themselves.
973 2011-10-12 Eli Zaretskii <eliz@gnu.org>
975 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
976 display string and the previous row comes from the same string and
977 is empty. (Bug#9739) (Bug#9738)
979 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
981 * doc.c (get_doc_string): Encode file name (bug#9735).
983 2011-10-12 Eli Zaretskii <eliz@gnu.org>
985 * bidi.c (bidi_level_of_next_char):
986 * xdisp.c (get_visually_first_element): Remove old incorrect
987 comments regarding the Unicode Line Separator character.
989 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
991 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
993 * alloc.c (Fgc_status): Do not access beyond zombies array
994 boundary if nzombies > MAX_ZOMBIES.
995 * alloc.c (dump_zombies): Add missing format specifier.
997 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
999 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1000 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1002 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1003 Some packages use them to denote characters with modifiers.
1005 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1007 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1008 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1009 matching a pp-number. Rename parameter var to var1.
1011 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1013 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1015 2011-10-08 Glenn Morris <rgm@gnu.org>
1017 * callint.c (Fcall_interactively): Give a more explicit error for the
1018 'c' case with a non-character input. (Bug#8479)
1020 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1022 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1024 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1025 lines that are hscrolled on the left.
1027 * dispnew.c (buffer_posn_from_coords): Account for a possible
1028 presence of header-line. (Bug#4426)
1030 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1032 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1033 Don't advertise functionality which we discourage or doesn't work.
1035 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1037 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1038 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1039 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1040 this makes Emacs dump core during garbage collection on rare
1041 occasions. sizeof is obviously inferior to offsetof here, so
1042 stick with offsetof.
1043 (GC_POINTER_ALIGNMENT): New macro.
1044 (mark_memory): Omit 3rd (offset) arg; caller changed.
1045 Don't assume EMACS_INT alignment is the same as pointer alignment.
1047 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1049 * keyboard.c (read_key_sequence_remapped): New var.
1050 (read_key_sequence): Compute remapping in the right buffer.
1051 (command_loop_1): Use read_key_sequence's remapping directly.
1053 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1055 * dired.c (file_name_completion): Don't expand file name.
1056 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1057 before checking file name handler.
1059 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1060 they've been requested explicitly (bug#9591).
1062 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1064 * keymap.c (Fsingle_key_description): Use make_specified_string
1065 instead of build_string to build string from push_key_description.
1068 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1070 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1071 This fixes a Y2038 bug on 64-bit hosts.
1072 * buffer.c (reset_buffer):
1073 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1074 (Fclear_buffer_auto_save_failure):
1075 Use 0, not -1, to represent an unset failure time, since time_t
1076 might not be signed.
1078 Remove dependency on glibc malloc internals.
1079 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1080 Move back here from lisp.h, but with their new implementations.
1081 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1082 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1083 * charset.c (charset_table_init): New static var.
1084 (syms_of_charset): Use it instead of xmalloc. This removes a
1085 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1086 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1087 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1088 Move back to alloc.c.
1089 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1090 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1092 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1094 * nsterm.m (windowDidResize): Call x_set_window_size only when
1095 ns_in_resize is true. Otherwise set pixelwidth/height and
1096 call change_frame_size (Bug#9628).
1098 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1100 Port --enable-checking=all to Fedora 14 x86-64.
1101 * charset.c (syms_of_charset): Also account for glibc malloc's
1102 internal overhead when calculating the initial malloc maximum.
1104 Port --enable-checking=all to Fedora 14 x86.
1105 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1107 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1108 (overrun_check_realloc, overrun_check_free):
1109 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1110 That way, xmalloc returns a properly-aligned pointer even if
1111 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1112 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1113 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1114 into account when calculating the initial malloc maximum.
1115 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1116 Move here from alloc.c, so that charset.c can use it too.
1117 Properly align; the old code wasn't right for common 32-bit hosts
1118 when configured with --enable-checking=all.
1119 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1120 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1122 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1124 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1127 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1129 * xdisp.c (compute_display_string_end): If there's no display
1130 string at CHARPOS, return -1.
1132 * bidi.c (bidi_fetch_char): When compute_display_string_end
1133 returns a negative value, treat the character as a normal
1134 character not covered by a display string. (Bug#9624)
1136 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1138 * lread.c (Fread_from_string): Fix typo in docstring.
1140 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1142 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1143 newline, reseat the iterator instead of bidi-iterating there one
1144 character at a time. (Bug#9610)
1145 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1146 TO_CHARPOS if the bidi iterator is at base embedding level.
1148 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1150 * lread.c (readevalloop): Use correct code for NBSP.
1151 (read1): Likewise. (Bug#9608)
1153 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1155 * dbusbind.c (Fdbus_register_signal): When service is not
1156 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1158 2011-09-25 Glenn Morris <rgm@gnu.org>
1160 * buffer.c (truncate-lines): Doc fix.
1162 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1164 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1165 (Fset_window_next_buffers): Doc fix.
1167 2011-09-24 Glenn Morris <rgm@gnu.org>
1169 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1171 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1173 Fix minor problems found by static checking.
1174 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1175 * indent.c (Fvertical_motion): Fix == vs = typo.
1177 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1179 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1180 Default value is now t. Doc fix.
1182 * indent.c (Fvertical_motion): Compute and apply the overshoot
1183 logic when moving up, not only when moving down. Fix the
1184 confusing name and values of the it_overshoot_expected variable;
1185 logic changes accordingly. (Bug#9254) (Bug#9549)
1187 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1188 CHARPOS is covered by a display string which includes newlines.
1189 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1190 is covered by a display string with embedded newlines.
1192 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1194 * dbusbind.c (Fdbus_register_signal): Add match rule to
1195 Vdbus_registered_objects_table. (Bug#9581)
1196 (Fdbus_register_method, Vdbus_registered_objects_table):
1199 2011-09-24 Jim Meyering <meyering@redhat.com>
1201 do not ignore write error for any output size
1202 The previous change was incomplete.
1203 While it makes emacs --batch detect the vast majority of stdout
1204 write failures, errors were still ignored whenever the output size is
1205 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1206 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1207 && echo FAIL: ignored write error
1208 FAIL: ignored write error
1209 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1210 && echo FAIL: ignored write error
1211 FAIL: ignored write error
1212 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1214 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1216 * emacs.c (Fkill_emacs): In noninteractive mode exit
1217 non-successfully if a write error occurred on stdout. (Bug#9574)
1219 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1221 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1224 * dispextern.h (struct it): Update the comment documenting what
1227 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1229 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1230 a display string, extend search for cursor position to end of row.
1231 (find_row_edges): If the row ends in a newline from a display
1232 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1233 Handle the case of a display string with multiple newlines.
1234 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1235 non-empty line. Fixes confusing cursor motion with arrow keys at
1236 the beginning of a line that starts with whitespace.
1238 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1240 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1243 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1245 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1248 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1250 * xdisp.c (display_line): Record maximum and minimum buffer
1251 positions even if no glyphs were produced (e.g., by a zero-width
1252 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1253 buffer positions that will be removed from the glyph row because
1255 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1256 column is beyond frame width: don't subtract 1 "pixel" when
1257 computing width of the stretch.
1258 (reseat_at_next_visible_line_start): Undo the change made on
1259 2011-09-17 that saved paragraph information and restored it after
1260 the call to `reseat'. (Bug#9545)
1262 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1264 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1265 and turn window cursor on if cleared (Bug#9415).
1267 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1269 * search.c (boyer_moore): Take unibyte characters from pattern
1270 literally. (Bug#9458)
1272 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1274 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1276 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1278 Fix minor problem found by static checking.
1279 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1280 initialized, to pacify gcc -Wuninitialized.
1282 * fileio.c: Report proper errno when syscall falls.
1283 (Finsert_file_contents): Save and restore errno,
1284 so that report_file_error outputs the correct diagnostic.
1285 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1287 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1289 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1291 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1293 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1294 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1296 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1298 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1299 about the current paragraph and restore it after the call to reseat.
1301 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1302 (bidi_find_paragraph_start): Search back for paragraph beginning
1303 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1304 (bidi_move_to_visually_next): Only trigger paragraph-related
1305 computations when the last character is a newline or at EOB, not
1306 just any NEUTRAL_B. (Bug#9470)
1308 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1309 truncated lines if point is covered by a display string. (Bug#9524)
1311 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1313 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1314 (cons_to_x_long): New function.
1315 (lisp_data_to_selection_data): Use it. Correct the test for
1316 short-versus-long data; it was negated. Break out of vector
1317 loop, for efficiency, when a long datum is discovered.
1319 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1321 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1323 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1325 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1326 GCC PR/17406) by declaring this function with external scope.
1328 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1330 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1331 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1333 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1335 * editfns.c (Fformat): Correctly handle text properties on "%%".
1337 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1339 * xterm.c (x_draw_composite_glyph_string_foreground):
1340 * w32term.c (x_draw_composite_glyph_string_foreground):
1341 * term.c (encode_terminal_code):
1342 * composite.c (composition_update_it, get_composition_id):
1343 * xdisp.c (get_next_display_element)
1344 (fill_composite_glyph_string): Add comments about special meaning
1345 of TAB characters in a composition.
1347 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1349 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1350 This occurs when processing a multibyte format.
1351 Problem reported by Wolfgang Jenker.
1353 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1355 * xdisp.c (try_cursor_movement): Only check for exact match if
1356 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1358 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1360 Remove unused external symbols.
1361 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1362 * xdisp.c (calc_pixel_width_or_height): Now static.
1363 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1364 * indent.c (check_display_width):
1365 * w32term.c: Fix comment to match code.
1366 * xterm.c, xterm.h (x_catching_errors): Remove.
1368 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1370 * xselect.c: Use signed conversions more consistently (Bug#9498).
1371 (selection_data_to_lisp_data): Assume incoming selection data are
1372 signed integers, not unsigned. This is to be consistent with
1373 outgoing selection data, which was modified to use signed integers
1374 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1375 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1376 expects long, not unsigned long.
1378 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1380 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1381 computation of loop end. Reported by Johan Bockgård
1384 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1386 * frame.c (Fother_visible_frames_p): Function deleted.
1388 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1390 * indent.c (compute_motion): Process display vector front to back
1391 rather than the other way around. (Bug#2496)
1393 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1395 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1397 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1399 * minibuf.c (Fread_from_minibuffer): Doc fix.
1401 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1403 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1404 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1406 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1408 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1409 value for non-existent files.
1411 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1413 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1414 set its "size" to -1. This will set the modtime_size field of
1415 the corresponding buffer to -1, which is what
1416 verify-visited-file-modtime expects for files that do not exist.
1419 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1421 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1423 * lisp.h: ... from here. push_key_description is no longer
1424 defined in keyboard.c, so its declaration should not be in
1425 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1426 logically belongs with push_key_description.
1428 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1430 * buffer.h: Include <sys/types.h> instead of <time.h>.
1431 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1432 Problem reported by Herbert J. Skuhra.
1434 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1436 * xml.c (parse_region): Make the parsing work for
1437 non-comment-starting XML files again (bug#9144).
1439 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1441 * image.c (gif_load): Fix calculation of bottom and right corner.
1444 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1446 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1447 redisplay in small windows.
1449 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1451 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1453 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1455 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1456 Operate on live windows only.
1458 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1460 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1462 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1464 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1465 only under bidi iteration.
1467 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1469 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1471 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1473 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1474 Without this fix, the command to link temacs failed due to an
1475 undefined symbol __builtin_isnan. This is because
1476 /usr/include/iso/math_c99.h #defines isnan(x) to
1477 __builtin_isnan(x), but the bundled gcc, which identifies itself
1478 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1480 * floatfns.c (isnan): #undef, and then #define to a clone of
1482 (Fisnan): Always define, since it's always available now.
1483 (syms_of_floatfns): Always define isnan at the Lisp level.
1485 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1487 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1489 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1491 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1492 The previous code assumed that file offsets (off_t values) fit in
1493 EMACS_INT variables, which is not true on typical 32-bit hosts.
1494 The code messed up by falsely reporting buffer overflow in cases
1495 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1496 when "big" contains more than 2**29 bytes, even though this
1497 inserts just one byte and does not overflow the buffer.
1498 (Finsert_file_contents): Store file offsets as off_t
1499 values, not as EMACS_INT values. Check for overflow when
1500 converting between EMACS_INT and off_t. When checking for
1501 buffer overflow or for overlap, take the offsets into account.
1502 Don't use EMACS_INT for small values where int suffices.
1503 When checking for overlap, fix a typo: ZV was used where
1504 ZV_BYTE was intended.
1505 (Fwrite_region): Don't assume off_t fits into 'long'.
1506 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1508 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1510 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1512 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1514 sprintf-related integer and memory overflow issues (Bug#9412).
1516 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1517 (esprintf, exprintf, evxprintf): New functions.
1518 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1519 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1520 (modify_event_symbol): Do not assume that the length of
1521 name_alist_or_stem is safe to alloca and fits in int.
1522 (Fexecute_extended_command): Likewise for function name and binding.
1523 (Frecursion_depth): Wrap around reliably on integer overflow.
1524 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1525 since some callers pass EMACS_INT values.
1526 (Fsingle_key_description): Don't crash if symbol name contains more
1527 than MAX_ALLOCA bytes.
1528 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1529 (get_minibuffer): Arg is now EMACS_INT, not int.
1530 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1531 (esprintf, exprintf, evxprintf): New decls.
1532 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1534 * dbusbind.c (signature_cat): New function.
1535 (xd_signature, Fdbus_register_signal):
1536 Do not overrun buffer; instead, report string overflow.
1538 * dispnew.c (add_window_display_history): Don't overrun buffer.
1539 Truncate instead; this is OK since it's just a log.
1541 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1542 even if the time zone offset is outlandishly large.
1543 Don't mishandle offset == INT_MIN.
1545 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1546 when creating daemon; the previous buffer-overflow check was incorrect.
1548 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1549 which has the guts of the old verror function.
1551 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1552 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1554 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1555 (font_unparse_xlfd): Don't blindly alloca long strings.
1556 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1557 fits in int, when using sprintf. Use single snprintf to count
1558 length of string rather than counting it via multiple sprintfs;
1559 that's simpler and more reliable.
1560 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1561 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1562 sprintf, in case result does not fit in int.
1564 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1565 (fontset_from_font): Print it.
1567 * frame.c (tty_frame_count): Now printmax_t, not int.
1568 (make_terminal_frame, set_term_frame_name): Print it.
1569 (x_report_frame_params): In X, window IDs are unsigned long,
1570 not signed long, so print them as unsigned.
1571 (validate_x_resource_name): Check for implausibly long names,
1572 and don't assume name length fits in 'int'.
1573 (x_get_resource_string): Don't blindly alloca invocation name;
1574 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1577 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1578 (xg_check_special_colors, xg_set_geometry):
1579 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1581 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1582 Use esprintf, not sprintf, in case result does not fit in int.
1584 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1585 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1586 it as a large positive number.
1587 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1588 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1590 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1591 in case result does not fit in int.
1593 * print.c (float_to_string): Detect width overflow more reliably.
1594 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1595 buffer overrun. Don't assume list length fits in 'int'. Treat
1596 print length of 0 as 0, not as infinity; to be consistent with other
1597 uses of print length in this function. Don't overflow print length
1598 index. Don't assume hash table size fits in 'long', or that
1599 vectorlike size fits in 'unsigned long'.
1601 * process.c (make_process): Use printmax_t, not int, to format
1602 process-name gensyms.
1604 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1606 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1607 to avoid potential buffer overrun.
1609 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1610 if X resource line is longer than 512 bytes.
1612 * xfns.c (x_window): Make sprintf buffer a bit bigger
1613 to avoid potential buffer overrun.
1615 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1617 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1619 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1621 Integer overflow fixes for scrolling, etc.
1622 Without these, Emacs silently mishandles large integers sometimes.
1623 For example, "C-u 4294967297 M-x recenter" was treated as if
1624 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1626 * xdisp.c (try_window_id): Check Emacs fixnum range before
1627 converting to 'int'.
1629 * window.c (window_scroll_line_based, Frecenter):
1630 Check that an Emacs fixnum is in range before assigning it to 'int'.
1631 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1632 values converted from Emacs fixnums.
1633 (Frecenter): Don't wrap around a line count if it is out of 'int'
1634 range; instead, treat it as an extreme value.
1635 (Fset_window_configuration, compare_window_configurations):
1636 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1638 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1639 that can exceed INT_MAX. Check that EMACS_INT value is in range
1640 before assigning it to the (possibly-narrower) index.
1641 (match_limit): Don't assume that a fixnum can fit in 'int'.
1643 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1646 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1647 (Fvertical_motion): Don't wrap around LINES values that don't fit
1648 in 'int'. Instead, treat them as extreme values. This is good
1649 enough for windows, which can't have more than INT_MAX lines anyway.
1651 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1653 * Require libxml/parser.h to avoid compilation warning.
1655 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1657 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1658 since this reportedly can destroy thread storage.
1660 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1662 * syntax.c (find_defun_start): Update all cache variables if
1663 exiting early (Bug#9401).
1665 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1667 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1669 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1670 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1671 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1673 * term.c (tty_append_glyph): New function.
1674 (produce_stretch_glyph): Static function and its prototype deleted.
1676 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1679 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1681 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1682 when checking :margin (Bug#9390).
1683 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1684 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1685 so that the name doesn't mislead. All uses changed.
1687 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1689 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1692 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1694 * xdisp.c (move_it_to): Don't bail out early when reaching
1695 position beyond to_charpos, if we are scanning backwards.
1696 (move_it_vertically_backward): When DY == 0, make sure we get to
1697 the first character in the line after the newline.
1699 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1701 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1702 (ccl_driver): Do not generate an out-of-range pointer.
1703 (Fccl_execute_on_string): Remove unnecessary check for
1704 integer overflow, noted by Stefan Monnier in
1705 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1706 Remove a FIXME that didn't need fixing.
1707 Simplify the newly-introduced buffer reallocation code.
1709 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1711 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1713 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1715 Integer and memory overflow issues (Bug#9196).
1717 * doc.c (get_doc_string): Rework so that
1718 get_doc_string_buffer_size is the actual buffer size, rather than
1719 being 1 less than the actual buffer size; this makes xpalloc more
1722 * image.c (x_allocate_bitmap_record, cache_image):
1723 * xselect.c (Fx_register_dnd_atom):
1724 Simplify previous changes by using xpalloc.
1726 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1727 since either will do and ptrdiff_t is convenient with xpalloc.
1729 * charset.c (charset_table_size)
1730 (struct charset_sort_data.priority): Now ptrdiff_t.
1731 (charset_compare): Don't overflow if priorities differ greatly.
1732 (Fsort_charsets): Don't assume list length fits in int.
1733 Check for size-calculation overflow when allocating sort data.
1734 (syms_of_charset): Allocate an initial charset table that is
1735 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1737 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1739 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1740 The actual value is always <= INT_MAX, and leaving it unsigned made
1741 overflow checking harder.
1743 * dispextern.h (struct glyph_matrix.rows_allocated)
1744 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1745 with xpalloc. The values are still always <= INT_MAX.
1747 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1749 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1750 (SAFE_NALLOCA): New macro.
1752 * region-cache.c (struct boundary.pos, find_cache_boundary)
1753 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1754 (set_cache_region, invalidate_region_cache)
1755 (revalidate_region_cache, know_region_cache, region_cache_forward)
1756 (region_cache_backward, pp_cache):
1757 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1758 so that ptrdiff_t * can be passed to xpalloc.
1759 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1760 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1761 (pp_cache): Don't assume cache_len fits in int.
1762 * region-cache.h: Adjust extern decls to match.
1764 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1765 EMACS_INT, since either will do, for xpalloc.
1767 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1768 (xnmalloc, xnrealloc, xpalloc): New functions.
1770 * bidi.c (bidi_shelve_header_size): New constant.
1771 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1772 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1774 * bidi.c (bidi_cache_shrink):
1775 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1777 Don't update size of array until after memory allocation succeeds,
1778 because xmalloc/xrealloc may not return.
1779 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1780 now that we have proper integer overflow checking.
1781 (record_overlay_string, overlay_strings): Catch overflows when
1782 calculating size of overlay_str_buf.
1784 * callproc.c (Fcall_process): Check for size overflow when
1785 calculating size of args2.
1786 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1787 Normally we prefer signed values, but sticking with ptrdiff_t would
1788 require adding more-complicated checks.
1790 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1791 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1792 Redo buffer-overflow calculations to avoid integer overflow.
1793 Add a FIXME comment where memory seems to be over-allocated.
1795 * character.c (Fstring): Check for size-calculation overflow.
1797 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1798 unnecessary integer overflow. Check for size overflow.
1799 (encode_coding_object): Don't update size until xmalloc succeeds.
1801 * composite.c (get_composition_id): Check for overflow in glyph
1802 length calculations.
1804 Integer and memory overflow fixes for display code.
1805 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1806 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1807 (scrolling_window): Check for overflow in size calculations.
1808 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1809 Don't assume glyph table len fits in int.
1810 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1811 (row_table_size): Now ptrdiff_t, not int.
1812 (scrolling_window): Avoid overflow in size calculations.
1813 Don't update size until allocation succeeds.
1814 * fns.c (concat): Check for overflow in size calculations.
1815 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1816 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1817 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1819 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1820 (get_doc_string): Check for size calculation overflow.
1821 Don't update size until allocation succeeds.
1822 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1823 EMACS_INT, where ptrdiff_t will do.
1824 (Fsubstitute_command_keys): Check for string overflow.
1826 * editfns.c (set_time_zone_rule): Don't assume environment length
1828 (message_length): Now ptrdiff_t, not int.
1829 (Fmessage_box): Don't update size until allocation succeeds.
1830 Don't assume message length fits in int.
1831 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1833 * emacs.c (main): Do not reallocate argv, since there is a null at
1834 the end that can be overwritten, and this way there's no need to
1835 worry about size-calculation overflow.
1836 (sort_args): Check for size-calculation overflow.
1838 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1840 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1842 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1843 (x_set_scroll_bar_width, x_figure_window_size):
1844 Check for integer overflow.
1845 (x_set_alpha): Do not assume XINT fits in int.
1847 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1848 This is for the members text_lines, text_cols, total_lines, total_cols,
1849 where the system imposes an 'int' limit.
1851 * fringe.c (Fdefine_fringe_bitmap):
1852 Don't update size until alloc works.
1854 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1855 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1857 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1858 Check for size-calculation overflow.
1859 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1860 do, as we prefer signed integers.
1861 (id_to_widget.max_size, id_to_widget.used)
1862 (xg_store_widget_in_map, xg_remove_widget_from_map)
1863 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1864 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1865 Use and return ptrdiff_t, not int.
1866 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1867 * gtkutil.h: Change prototypes to match the above.
1869 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1870 are duplicate now that they've been promoted to lisp.h.
1871 (x_allocate_bitmap_record, x_alloc_image_color)
1872 (make_image_cache, cache_image, xpm_load):
1873 Don't update size until alloc is done.
1874 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1876 Check for size calculation overflow.
1877 (ct_colors_allocated_max): New constant.
1878 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1881 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1882 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1883 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1884 Use ptrdiff_t, not int, to count maps.
1885 (read_char_minibuf_menu_prompt): Check for overflow in size
1886 calculations. Don't update size until allocation succeeds.
1887 Redo calculations to avoid overflow.
1888 * keyboard.h: Change prototypes to match the above.
1890 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1892 (current_minor_maps): Check for size calculation overflow.
1893 * keymap.h: Change prototypes to match the above.
1895 * lread.c (read1, init_obarray): Don't update size until alloc done.
1897 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1898 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1900 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1901 Now ptrdiff_t, not int.
1902 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1903 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1905 * process.c (Fnetwork_interface_list): Check for overflow
1906 in size calculation.
1908 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1910 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1911 overflow. Don't bother calling xmalloc when xrealloc will do.
1913 * search.c (Freplace_match): Check for size calculation overflow.
1914 (Fset_match_data): Don't assume list lengths fit in 'int'.
1916 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1917 for command line length. Do not attempt to address one before the
1918 beginning of an array, as that's not portable.
1920 * term.c (max_frame_lines): Remove; unused.
1921 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1923 (encode_terminal_code, calculate_costs): Check for size
1924 calculation overflow.
1925 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1926 table lengths and related sizes. Don't update size until alloc
1927 done. Redo calculations to avoid overflow.
1928 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1930 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1931 subtracting pointers.
1932 (gobble_line): Check for overflow more carefully. Don't update size
1935 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1936 Don't update size until alloc done.
1937 Redo size calculations to avoid overflow.
1938 Check for size calculation overflow.
1939 (main) [DEBUG]: Fix typo in invoking tparam1.
1941 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1942 Use ptrdiff_t, not int, for sizes.
1943 (store_mode_line_noprop_char): Don't update size until alloc done.
1945 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1946 Use ptrdiff_t, not int, for sizes.
1947 (Finternal_make_lisp_face, cache_face):
1948 Check for size calculation overflow.
1949 (cache_face): Treat size calculation overflows as if they were
1950 memory exhaustion (the usual treatment), rather than aborting.
1952 * xfns.c (x_encode_text, x_set_name_internal)
1953 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1954 sizes, since they can exceed INT_MAX in size. Check for size
1955 calculation overflow.
1957 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1958 (xg_select): Check for size calculation overflow.
1959 Don't update size until alloc done.
1961 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1962 as sprintf is limited to int lengths.
1964 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1965 (X_LONG_MIN): New macros.
1966 Use them to make the following changes clearer.
1967 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1968 This change doesn't affect the value now, but it may help remind
1969 future maintainers not to raise the value too much later.
1970 (SELECTION_QUANTUM): Remove, replacing with ...
1971 (selection_quantum): ... new function, which avoids overflow.
1973 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1974 assumption that selection length fits in 'int'.
1975 (x_reply_selection_request, x_handle_selection_request)
1976 (x_get_window_property, receive_incremental_selection)
1977 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1978 (lisp_data_to_selection_data, clean_local_selection_data):
1979 Use ptrdiff_t, not int, to record length of selection.
1980 (x_reply_selection_request, x_get_window_property)
1981 (receive_incremental_selection, x_property_data_to_lisp):
1982 Redo calculations to avoid overflow.
1983 (x_reply_selection_request): When sending hint, ceiling it at
1984 X_LONG_MAX rather than relying on wraparound overflow to send
1986 (x_get_window_property, receive_incremental_selection)
1987 (lisp_data_to_selection_data, x_property_data_to_lisp):
1988 Check for size-calculation overflow.
1989 (x_get_window_property, receive_incremental_selection)
1990 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1991 Don't store size until memory allocation succeeds.
1992 (x_get_window_property): Plug memory leak on memory exhaustion.
1993 Don't double-block input; malloc is safe here. Don't assume 2**34
1994 - 4 fits in unsigned long. Add an xassert to check
1995 XGetWindowProperty overflow. Be more careful about overflow
1996 calculations, and distinguish size from memory overflow better.
1997 (receive_incremental_selection): When tracing, don't assume
1998 unsigned int is less than INT_MAX.
1999 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2000 harmful) conversions of unsigned short to int.
2001 (lisp_data_to_selection_data): Don't assume that integers
2002 in the range -65535 through -1 fit in an X unsigned short.
2003 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2004 result parameters unless successful. Rely on cons_to_unsigned
2005 to report problems with elements; the old code wasn't right anyway.
2006 (x_check_property_data): Check for int overflow; we cannot use
2007 a wider type due to X limits.
2008 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2010 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2012 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2013 (x_term_init): Check for size calculation overflow.
2014 (x_color_cells): Don't store size until memory allocation succeeds.
2015 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2016 Don't assume alloca size is less than MAX_ALLOCA.
2017 (x_term_init): Don't assume length fits in int (sprintf is limited
2020 Use ptrdiff_t for composition IDs.
2021 * character.c (lisp_string_width):
2022 * composite.c (composition_table_size, n_compositions)
2023 (get_composition_id, composition_gstring_from_id):
2024 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2025 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2026 * window.c (Frecenter):
2027 Use ptrdiff_t, not int, for composition IDs.
2028 * composite.c (get_composition_id): Check for integer overflow.
2029 * composite.h: Adjust prototypes to match the above changes.
2031 Use ptrdiff_t for hash table indexes.
2032 * category.c (hash_get_category_set):
2033 * ccl.c (ccl_driver):
2034 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2035 * coding.c (coding_system_charset_list, detect_coding_system):
2036 * coding.h (struct coding_system.id):
2037 * composite.c (get_composition_id, gstring_lookup_cache):
2038 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2039 * image.c (xpm_get_color_table_h):
2040 * lisp.h (hash_lookup, hash_put):
2041 * minibuf.c (Ftest_completion):
2042 Use ptrdiff_t for hash table indexes, not int (which is too
2043 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2044 32-bit --with-wide-int hosts).
2046 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2047 Add a FIXME comment about memory leaks.
2048 (syms_of_charset): Don't assume xmalloc returns.
2050 Don't assume that stated character widths fit in int.
2051 * character.c (Fchar_width, c_string_width, lisp_string_width):
2052 * character.h (CHAR_WIDTH):
2053 * indent.c (MULTIBYTE_BYTES_WIDTH):
2054 Use sanitize_char_width to avoid undefined and/or bad behavior
2055 with outlandish widths.
2056 * character.h (sanitize_tab_width): Rename from sanitize_width,
2057 now that we have two such functions. All uses changed.
2058 (sanitize_char_width): New inline function.
2060 Don't assume that tab-width fits in int.
2061 * character.h (sanitize_width): New inline function.
2062 (SANE_TAB_WIDTH): New macro.
2063 (ASCII_CHAR_WIDTH): Use it.
2064 * indent.c (sane_tab_width): Remove. All uses replaced by
2065 SANE_TAB_WIDTH (current_buffer).
2066 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2068 * fileio.c: Integer overflow issues with file modes.
2069 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2071 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2072 Remove unreachable code.
2073 (read_hex, load_charset_map_from_file): Check for integer overflow.
2075 * xterm.c: don't go over XClientMessageEvent limit
2076 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2077 (x_send_scroll_bar_event): Likewise. Check that the size does not
2078 exceed limits imposed by XClientMessageEvent, as well as the usual
2079 ptrdiff_t and size_t limits.
2081 * keyboard.c: Overflow, signedness and related fixes.
2082 (make_lispy_movement): Use same integer type in forward decl
2083 that is used in the definition.
2084 (read_key_sequence, keyremap_step):
2085 Change bufsize argument back to int, undoing my 2011-03-30 change.
2086 We prefer signed types, and int is wide enough here.
2087 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2088 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2089 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2090 length, not size_t. Use ptrdiff_t for index, not int.
2091 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2092 possibility of integer overflow.
2094 Overflow, signedness and related fixes for images.
2096 * dispextern.h (struct it.stack[0].u.image.image_id)
2097 (struct_it.image_id, struct image.id, struct image_cache.size)
2098 (struct image_cache.used, struct image_cache.ref_count):
2099 * gtkutil.c (update_frame_tool_bar):
2100 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2101 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2102 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2103 * nsmenu.m (update_frame_tool_bar):
2104 * xdisp.c (calc_pixel_width_or_height):
2105 * xfns.c (image_cache_refcount):
2106 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2107 on typical 64-bit hosts.
2109 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2110 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2111 Omit unnecessary casts to int.
2112 (parse_image_spec): Check that integers fall into 'int' range
2113 when the callers expect that.
2114 (image_ascent): Redo ascent calculation to avoid int overflow.
2115 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2116 (lookup_image): Remove unnecessary tests.
2117 (xbm_image_p): Locals are now of int, not EMACS_INT,
2118 since parse_image_check makes sure they fit into int.
2119 (png_load, gif_load, svg_load_image):
2120 Prefer int to unsigned where either will do.
2121 (tiff_handler): New function, combining the cores of the
2122 old tiff_error_handler and tiff_warning_handler.
2123 This function is rewritten to use vsnprintf and thereby avoid
2124 stack buffer overflows. It uses only the features of vsnprintf
2125 that are common to both POSIX and native Microsoft.
2126 (tiff_error_handler, tiff_warning_handler): Use it.
2127 (tiff_load, gif_load, imagemagick_load_image):
2128 Don't assume :index value fits in 'int'.
2129 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2130 (imagemagick_load_image): Check that crop parameters fit into
2131 the integer types that MagickCropImage accepts. Don't assume
2132 Vimagemagick_render_type has a nonnegative value. Don't assume
2133 size_t fits in 'long'.
2134 (gs_load): Use printmax_t to print the widest integers possible.
2135 Check for integer overflow when computing image height and width.
2137 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2139 * xdisp.c (redisplay_window): Don't force window start if point
2140 will be invisible in the resulting window. (Bug#9324)
2142 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2144 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2145 the display spec is of the form `(space ...)'.
2146 (handle_display_spec): Return the value returned by
2147 handle_single_display_spec, not just 1 or zero.
2148 (handle_single_display_spec): If the display spec is of the form
2149 `(space ...)', and specifies display in the text area, return 2
2151 (try_cursor_movement): Check for the need to scroll more
2152 accurately, and prefer exact match for point under bidi.
2153 Don't advance `row' beyond the last row of the window.
2155 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2156 into disp_prop; all users changed.
2158 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2159 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2160 for the text covered by the display property.
2162 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2164 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2165 Change return value to nil.
2166 (Frecord_buffer): Delete unused function.
2168 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2170 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2171 buffers, return left-to-right.
2172 (set_cursor_from_row): Consider candidate row a win if its glyph
2173 represents a newline and point is on that newline. Fixes cursor
2174 positioning on the newline at EOL of R2L text within L2R
2175 paragraph, and vice versa.
2176 (try_cursor_movement): Check continued rows, in addition to
2177 continuation rows. Fixes unwarranted scroll when point enters a
2178 continued line of R2L text within an L2R paragraph, or vice versa.
2179 (cursor_row_p): Consider the case of point being equal to
2180 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2181 from the end of a short line to the beginning of a continued line
2182 of R2L text within L2R paragraph.
2183 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2184 composed characters.
2186 * bidi.c (bidi_check_type): Use xassert.
2187 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2190 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2192 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2195 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2197 * nsfont.m (ns_otf_to_script): Fix typo.
2199 2011-08-22 Kenichi Handa <handa@m17n.org>
2201 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2202 extra slot even if the purpose is char-code-property-table.
2204 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2206 * xdisp.c (redisplay_window): When computing centering_position,
2207 account for the height of the header line. (Bug#8874)
2209 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2210 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2211 candidate is selected by the mouse, and that candidate has a
2212 composed character under the mouse.
2214 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2215 coordinates reported by pos-visible-in-window-p for a composed
2216 character in column zero.
2218 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2220 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2222 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2224 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2225 consider it a hit if to_charpos is anywhere in the range of the
2226 composed buffer positions.
2228 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2230 * image.c (gif_load): Don't assume that each subimage has the same
2231 dimensions as the base image. Handle disposal method that is
2232 "undefined" by the gif spec (Bug#9335).
2234 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2236 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2237 (Fcondition_case): Document `debug' symbol in error handler.
2239 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2241 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2242 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2243 from an Org mode buffer to a Speedbar frame.
2245 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2246 a composition, take its buffer position from IT->cmp_it.charpos.
2247 Fixes cursor positioning at the beginning of a line that begins
2248 with a composed character.
2250 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2252 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2253 character bidirectional type, use STRONG_L instead. Fixes crashes
2254 in a buffer produced by `describe-categories'.
2256 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2257 members before the level stack, so they would be saved and
2258 restored when copying iterator state. Fixes incorrect reordering
2259 around TABs covered by display properties.
2261 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2263 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2265 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2267 * eval.c (internal_condition_case, internal_condition_case_1)
2268 (internal_condition_case_2, internal_condition_case_n):
2269 Remove unnecessary aborts (Bug#9081).
2271 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2273 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2274 has no `load' handler, try opening the file locally. (Bug#9311)
2276 2011-08-16 Ken Brown <kbrown@cornell.edu>
2278 * gmalloc.c: Expand comment.
2280 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2282 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2283 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2285 2011-08-16 Ken Brown <kbrown@cornell.edu>
2287 Fix memory allocation problems in Cygwin build (Bug#9273).
2289 * unexcw.c ( __malloc_initialized): Declare external variable.
2290 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2292 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2294 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2296 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2298 [CYGWIN] (special_realloc): New function.
2299 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2300 requests to realloc storage in the static heap.
2302 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2304 * bidi.c (bidi_initialize): Remove unused local.
2306 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2309 * biditype.h: Remove file.
2310 * makefile.w32-in ($(BLD)/bidi.$(O)):
2311 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2313 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2315 * chartab.c: Improve commentary for the uniprop_table API.
2317 * bidi.c (bidi_paragraph_init): Support zero value of
2318 bidi_ignore_explicit_marks_for_paragraph_level.
2319 (bidi_initialize): Use uniprop_table instead of including
2320 biditype.h and bidimirror.h.
2322 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2323 coordinates of the iterator when restoring from ppos_it.
2326 2011-08-14 Kenichi Handa <handa@m17n.org>
2328 * process.c (create_process): Call setup_process_coding_systems
2329 after the pid of the process is set to -1 (Bug#8162).
2331 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2333 * xdisp.c (move_it_in_display_line_to): Don't invoke
2334 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2335 ppos_it. Fixes vertical cursor motion when line beginning is
2336 covered by an image. (Bug#9296)
2338 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2340 * nsterm.h (ns_run_ascript): Declare.
2341 (NSAPP_DATA2_RUNASSCRIPT): Define.
2343 * nsfns.m (as_script, as_result, as_status): New static variables.
2344 (ns_run_ascript): New function.
2345 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2346 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2347 the event loop. Get status from as_status (Bug#7276).
2349 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2350 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2351 the event loop (Bug#7276).
2353 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2355 * gnutls.c (QCgnutls_bootprop_priority)
2356 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2357 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2358 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2359 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2360 (QCgnutls_bootprop_verify_hostname_error)
2361 (QCgnutls_bootprop_callbacks_verify): Rename from
2362 Qgnutls_bootprop_..., all uses changed.
2364 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2367 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2369 * xfaces.c (Qframe_set_background_mode): Now static.
2370 * dispextern.h (Qframe_set_background_mode): Remove decl.
2372 * process.c (Fnetwork_interface_info): Declare local only if needed.
2374 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2376 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2377 (Fnetwork_interface_list): Allocate in increments of bytes instead
2378 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2379 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2381 (struct ifflag_def): notrailers is smart on OSX.
2382 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2383 Get hardware address with getifaddrs if available.
2385 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2387 * xdisp.c (iterate_out_of_display_property): xassert that
2388 IT->position is set to within IT->object's boundaries. Break from
2389 the loop as soon as EOB is reached; avoids infloops in redisplay
2390 when IT->position is set up wrongly due to some bug.
2391 Set IT->current to match the bidi iterator unconditionally.
2392 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2393 entry. Force push_it to save on the stack the current
2394 buffer/string position, to be restored by pop_it. Fix flags in
2395 the iterator structure wrt the object coming from a display
2396 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2397 properties. (Bug#9284)
2399 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2401 * fontset.c (fontset_get_font_group): Add proper type checks.
2404 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2406 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2407 and LC_VERSION_MIN_MACOSX.
2408 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2409 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2411 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2413 * xdisp.c (forward_to_next_line_start): Allow to use the
2414 no-display-properties-and-no-overlays under bidi display.
2415 Set disp_pos in the bidi iterator to avoid searches for display
2416 properties and overlays.
2418 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2420 * editfns.c (Fset_time_zone_rule): Document relationship with the
2423 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2424 the font entity extracted from the cache (Bug#8109).
2426 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2428 * composite.c (autocmp_chars): Don't reset point. That is done by
2429 restore_point_unwind (Bug#5984).
2431 2011-08-07 Juri Linkov <juri@jurta.org>
2433 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2434 to show the arg `TIME' instead of `TIMEVAL'.
2436 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2438 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2439 display property strides EOL and includes a newline, as in
2440 longlines-mode. (Bug#9254)
2441 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2442 word-wrap under bidirectional display. (Bug#9224)
2444 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2445 is non-zero, even if the data buffer is NULL. Fixes a crash in
2446 vertical-motion with longlines-mode. (Bug#9254)
2448 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2450 * bidi.c <bidi_cache_total_alloc>: Now static.
2451 (bidi_initialize): Initialize bidi_cache_total_alloc.
2453 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2456 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2457 amount allocated this far in `bidi_cache_total_alloc'.
2458 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2459 non-zero, only free the data buffer without restoring the cache
2460 contents. All callers changed.
2462 * dispextern.h (bidi_unshelve_cache): Update prototype.
2464 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2465 (move_it_in_display_line, move_it_to)
2466 (move_it_vertically_backward, move_it_by_lines): Replace the call
2467 to xfree to an equivalent call to bidi_unshelve_cache.
2468 (move_it_in_display_line_to): Fix logic of returning
2469 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2471 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2473 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2474 came from a string character with a `cursor' property. (Bug#9229)
2476 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2478 * Makefile.in (LIB_PTHREAD): New variable.
2479 (LIBES): Add LIB_PTHREAD (Bug#9216).
2481 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2482 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2484 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2486 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2488 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2490 * xterm.c (x_find_topmost_parent): New function.
2491 (x_set_frame_alpha): Find topmost parent window with
2492 x_find_topmost_parent and set the property there also (bug#9181).
2493 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2495 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2497 * callproc.c (Fcall_process): Avoid vfork clobbering
2498 the local vars buffer, coding_systems, current_dir.
2500 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2502 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2504 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2506 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2507 so that it is not optimized away.
2509 * xdisp.c (compute_display_string_pos): Remove unused local.
2511 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2513 Fix slow cursor motion and scrolling in large buffers with
2514 selective display, like Org Mode buffers. (Bug#9218)
2516 * dispextern.h (struct bidi_it): New member disp_prop_p.
2518 * xdisp.c: Remove one-slot cache of display string positions.
2519 (compute_display_string_pos): Accept an additional argument
2520 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2521 for a display string or property. If found, set DISP_PROP_P
2524 * bidi.c (bidi_fetch_char): Accept an additional argument
2525 DISP_PROP_P, and pass it to compute_display_string_pos.
2526 Only handle text covered by a display string if DISP_PROP_P is returned
2527 non-zero. All callers of bidi_fetch_char changed.
2529 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2531 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2533 2010-12-03 Don March <don@ohspite.net>
2535 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2536 last character M-[char] is translated to ESC [char] (bug#7541).
2538 2011-08-02 Kenichi Handa <handa@m17n.org>
2540 * lisp.h (uniprop_table): Extern it.
2542 * chartab.c (uniprop_table): Make it non-static.
2544 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2546 * xdisp.c (forward_to_next_line_start): Accept additional argument
2547 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2549 (reseat_at_next_visible_line_start): Use the bidi iterator state
2550 returned by forward_to_next_line_start to restore the state of
2551 it->bidi_it after backing up to previous newline. (Bug#9212)
2553 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2555 * regex.c (re_comp): Protoize.
2556 (re_exec): Fix return type.
2557 (regexec): Fix type of `ret'. (Bug#9203)
2559 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2561 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2562 This is needed if max-image-size is a floating-point number.
2564 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2566 * print.c (print_object): Print empty symbol as ##.
2568 * lread.c (read1): Read ## as empty symbol.
2570 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2572 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2573 setting frame foreground color (Bug#9175).
2574 (x_set_background_color): Likewise.
2576 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2577 contents (Bug#9176).
2578 (EmacsTooltip -init): Remove bezels and add shadows to
2581 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2582 or scroll bar (Bug#8470).
2584 * nsfont.m (nsfont_open): Remove assignment to voffset and
2585 unnecessary vars hshink, expand, hd, full_height, min_height.
2586 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2588 * nsterm.h (nsfont_info): Remove voffset field.
2590 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2592 Implement strike-through and overline on NextStep (Bug#8863).
2594 * nsfont.m (nsfont_open): Use underline position provided by font,
2595 instead of hard-coded value of 2.
2596 (nsfont_draw): Call ns_draw_text_decoration instead.
2598 * nsterm.h: Add declaration for ns_draw_text_decoration.
2600 * nsterm.m (ns_draw_text_decoration): New function for drawing
2601 underline, overline, and strike-through.
2602 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2603 ns_draw_text_decoration. Change treatment of cursor drawing to
2604 accommodate underlining, etc.
2606 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2608 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2611 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2613 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2614 Without this fix, if a signal arrives just after memory fills up,
2615 'malloc' might be invoked reentrantly.
2617 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2618 In other words, assume that every image size is allowed, on non-X
2619 hosts. This assumption is probably wrong, but it lets Emacs compile.
2621 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2623 * regex.c (re_iswctype): Convert return values to boolean.
2625 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2627 * xdisp.c (compute_display_string_pos): Don't use cached display
2628 string position if the buffer had its restriction changed.
2631 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2633 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2635 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2637 Integer signedness and overflow and related fixes. (Bug#9079)
2639 * bidi.c: Integer size and overflow fixes.
2640 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2641 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2642 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2643 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2644 (bidi_find_other_level_edge):
2645 Use ptrdiff_t instead of EMACS_INT where either will do.
2646 This works better on 32-bit hosts configured --with-wide-int.
2647 (bidi_cache_ensure_space): Check for size-calculation overflow.
2648 Use % rather than repeated addition, for better worst-case speed.
2649 Don't set bidi_cache_size until after xrealloc returns, because it
2651 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2652 (bidi_cache_ensure_space): Also check that the bidi cache size
2653 does not exceed that of the largest Lisp string or buffer. See Eli
2654 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2656 * alloc.c (__malloc_size_t): Remove.
2657 All uses replaced by size_t. See Andreas Schwab's note
2658 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2660 * image.c: Improve checking for integer overflow.
2661 (check_image_size): Assume that f is nonnull, since
2662 it is always nonnull in practice. This is one less thing to
2663 worry about when checking for integer overflow later.
2664 (x_check_image_size): New function, which checks for integer
2665 overflow issues inside X.
2666 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2667 This removes the need for a memory_full check.
2668 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2669 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2670 (xbm_read_bitmap_data): Change locals back to 'int', since
2671 their values must fit in 'int'.
2672 (xpm_load_image, png_load, tiff_load):
2673 Invoke x_create_x_image_and_pixmap earlier,
2674 to avoid much needless work if the image is too large.
2675 (tiff_load): Treat overly large images as if
2676 x_create_x_image_and_pixmap failed, not as malloc failures.
2677 (gs_load): Use x_check_image_size.
2679 * gtkutil.c: Omit integer casts.
2680 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2681 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2683 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2685 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2686 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2687 would wrongly return t on a 64-bit host.
2689 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2690 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2691 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2692 and therefore cause GCC to emit a bogus diagnostic in some cases.
2694 * image.c: Integer signedness and overflow and related fixes.
2695 This is not an exhaustive set of fixes, but it's time to
2696 record what I've got.
2697 (lookup_pixel_color, check_image_size): Remove redundant decls.
2698 (check_image_size): Don't assume that arbitrary EMACS_INT values
2699 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2700 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2701 (tiff_load, imagemagick_load_image):
2702 Check for overflow in size calculations.
2703 (x_create_x_image_and_pixmap): Remove unnecessary test for
2704 xmalloc returning NULL; that can't happen.
2705 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2706 (xpm_color_bucket): Use better integer hashing function.
2707 (xpm_cache_color): Don't possibly over-allocate memory.
2708 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2709 (gif_memory_source):
2710 Use ptrdiff_t, not int or size_t, to record sizes.
2711 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2712 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2713 either works, as we prefer signed integers.
2714 (tiff_read_from_memory, tiff_write_from_memory):
2715 Return tsize_t, not size_t, since that's what the TIFF API wants.
2716 (tiff_read_from_memory): Don't fail simply because the read would
2717 go past EOF; instead, return a short read.
2718 (tiff_load): Omit no-longer-needed casts.
2719 (Fimagemagick_types): Don't assume size fits into 'int'.
2721 Improve hashing quality when configured --with-wide-int.
2722 * fns.c (hash_string): New function, taken from sxhash_string.
2723 Do not discard information about ASCII character case; this
2724 discarding is no longer needed.
2725 (sxhash-string): Use it. Change sig to match it. Caller changed.
2726 * lisp.h: Declare it.
2727 * lread.c (hash_string): Remove, since we now use fns.c's version.
2728 The fns.c version returns a wider integer if --with-wide-int is
2729 specified, so this should help the quality of the hashing a bit.
2731 * emacs.c: Integer overflow minor fix.
2732 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2733 Define only if GNU_LINUX.
2734 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2736 * dispnew.c: Integer signedness and overflow fixes.
2737 Remove unnecessary forward decls, that were a maintenance hassle.
2738 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2740 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2741 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2742 (prepare_desired_row, line_draw_cost):
2743 Use int, not unsigned, where either works.
2744 (save_current_matrix, restore_current_matrix):
2745 Use ptrdiff_t, not size_t, where either works.
2746 (init_display): Check for overflow more accurately, and without
2747 relying on undefined behavior.
2749 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2750 Remove, replacing with the new symbols in lisp.h. All uses changed.
2751 * fileio.c (make_temp_name):
2752 * filelock.c (lock_file_1, lock_file):
2753 * xdisp.c (message_dolog):
2754 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2755 Use pMd etc. instead.
2756 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2757 replacing the pWIDE etc. symbols removed from editfns.c.
2759 * keyboard.h (num_input_events): Now uintmax_t.
2760 This is (very slightly) less likely to mess up due to wraparound.
2763 * buffer.c: Integer signedness fixes.
2764 (alloc_buffer_text, enlarge_buffer_text):
2765 Use ptrdiff_t rather than size_t when either will do, as we prefer
2768 * alloc.c: Integer signedness and overflow fixes.
2769 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2770 (__malloc_size_t): Default to size_t, not to int.
2771 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2772 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2773 Prefer ptrdiff_t to size_t when either would do, as we prefer
2775 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2776 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2777 Now const. Initialize with values that are in range even if char
2779 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2780 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2781 These functions do the right thing with sizes > 2**32.
2782 (check_depth): Now ptrdiff_t, not int.
2783 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2784 Adjust to new way of storing sizes. Check for size overflow bugs
2786 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2787 slightly wrong anyway, as it missed one instance of
2788 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2789 (refill_memory_reserve): Omit needless cast to size_t.
2790 (mark_object_loop_halt): Mark as externally visible.
2792 * xselect.c: Integer signedness and overflow fixes.
2793 (Fx_register_dnd_atom, x_handle_dnd_message):
2794 Use ptrdiff_t, not size_t, since we prefer signed.
2795 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2796 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2797 x_dnd_atoms_size and x_dnd_atoms_length.
2799 * doprnt.c: Prefer signed to unsigned when either works.
2801 * doprnt.c (doprnt):
2803 * xdisp.c (vmessage):
2804 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2805 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2806 prefer signed arithmetic to avoid comparison confusion.
2807 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2808 but is a bit tricky.
2810 Assume freestanding C89 headers, string.h, stdlib.h.
2811 * data.c, doprnt.c, floatfns.c, print.c:
2812 Include float.h unconditionally.
2813 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2814 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2815 * regex.c: Likewise for stddef.h, string.h.
2816 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2817 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2818 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2819 (STDC_HEADERS): Remove obsolete defines.
2820 * sysdep.c: Include limits.h unconditionally.
2822 Assume support for memcmp, memcpy, memmove, memset.
2823 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2824 * regex.c (memcmp, memcpy):
2825 Remove; we assume C89 now.
2827 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2828 (__malloc_safe_bcopy): Remove; no longer needed.
2830 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2831 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2832 well either way, and we prefer signed to unsigned.
2834 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2836 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2837 closes the connection while we're reading (bug#9182).
2839 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2841 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2842 are specified (Bug#9168).
2844 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2846 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2847 Found by GCC static checking and --with-wide-int on a 32-bit host.
2849 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2851 * xdisp.c (compute_display_string_pos): Fix logic of caching
2852 previous display string position. Initialize cached_prev_pos to
2853 -1. Fixes slow-down at the beginning of a buffer.
2855 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2857 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2858 for attrs[LFACE_FONTSET_INDEX].
2860 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2862 * xml.c (parse_region): Remove unused local
2863 that was recently introduced.
2865 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2867 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2868 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2870 * xdisp.c (move_it_in_display_line_to): Record the best matching
2871 position for TO_CHARPOS while scanning the line, and restore it on
2872 exit if none of the characters scanned was an exact match.
2873 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2874 when exact match is impossible due to invisible text, and the
2875 lines are truncated.
2877 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2879 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2882 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2884 Fix a significant slow-down of cursor motion with C-n, C-p,
2885 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2886 auto-repeat under bidi redisplay in fontified buffers.
2887 * xdisp.c (compute_stop_pos_backwards): New function.
2888 (next_element_from_buffer): Call compute_stop_pos_backwards to
2889 find a suitable prev_stop when we find ourselves before
2891 (reseat): Don't look for prev_stop, as that could mean a very long
2893 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2894 <cached_disp_overlay_modiff>: Cache for last found display string
2896 (compute_display_string_pos): Return the cached position if asked
2897 about the same buffer in the same area of character positions, and
2898 the buffer wasn't changed since the time the display string
2899 position was cached.
2901 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2903 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2904 is an integer, which is important for empty lines. (Bug#9149)
2906 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2908 * frame.c (Fmodify_frame_parameters): In tty case, update the
2909 default face if necessary (Bug#4238).
2911 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2913 * editfns.c (Fstring_to_char): No need to explain what a character
2914 is in the docstring (Bug#6576).
2916 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2918 * xml.c (parse_region): Make sure we always return a tree.
2920 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2922 * xml.c (parse_region): If a document contains only comments,
2925 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2927 * xml.c (make_dom): Return comments, too.
2929 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2932 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2933 and the surrounding thread.
2934 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2935 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2936 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2938 * s/openbsd.h (BROKEN_SIGIO): Define.
2939 * unexelf.c (unexec) [__OpenBSD__]:
2940 Don't update the .mdebug section of the Alpha COFF symbol table.
2942 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2944 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2947 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2949 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2950 This fixes some race conditions on the permissions of any newly
2953 * alloc.c (valid_pointer_p): Use pipe, not open.
2954 This fixes some permissions issues when debugging.
2956 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2957 If fchown fails to set both uid and gid, try to set just gid,
2958 as that is sometimes allowed. Adjust the file's mode to eliminate
2959 setuid or setgid bits that are inappropriate if fchown fails.
2961 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2963 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2964 to compare Lisp_Objects.
2965 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2966 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2967 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2969 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2971 * lread.c (read_integer): Unread even EOF character.
2972 (read1): Likewise. Properly record start position of symbol.
2974 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2975 symbol character follows.
2977 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2979 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2980 This works around a problem with the previous change to Fcopy_file.
2981 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2982 and without this change, GCC might complain about discarding
2983 fchown's return value.
2985 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2987 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2989 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2991 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2993 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2995 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2996 it's used from the C level.
2998 * process.c: Use the same condition for POLL_FOR_INPUT in both
2999 keyboard.c and process.c (bug#1858).
3001 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3003 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3004 (Fgnutls_boot): Use it.
3006 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3008 * doc.c (Fsubstitute_command_keys): Revert last change.
3010 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3012 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3013 quotes the next character, and doesn't affect other longer
3014 sequences (bug#8935).
3016 * lread.c (syms_of_lread): Clarify that is isn't only
3017 `eval-buffer' and `eval-defun' that's affected by
3018 `lexical-binding' (bug#8460).
3020 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3022 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3023 bidi redisplay when a line includes both an image and is truncated.
3025 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3027 Fix minor problems found by static checking.
3028 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3029 (elsz): Now a signed constant, not a size_t var. We prefer signed
3030 types to unsigned, to avoid integer comparison confusion. Without
3031 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3032 "cannot optimize loop, the loop counter may overflow", a symptom
3034 * indent.c (Fvertical_motion): Mark locals as initialized.
3035 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3037 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3039 * search.c (Fre_search_backward): Mention `case-fold-search' in
3040 all the re_search_* functions (bug#8138).
3042 * keyboard.c (Fopen_dribble_file): Document when the file is
3045 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3047 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3050 Support bidi reordering of display and overlay strings.
3051 * xdisp.c (compute_display_string_pos)
3052 (compute_display_string_end): Accept additional argument STRING.
3053 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3054 (reseat_to_string): Initialize bidi_it->string.s and
3055 bidi_it->string.schars.
3056 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3057 NULL (avoids a crash in bidi_paragraph_init).
3058 Initialize itb.string.lstring.
3059 (init_iterator): Call bidi_init_it only of a valid
3060 buffer position was specified. Initialize paragraph_embedding to
3062 (reseat_to_string): Initialize the bidi iterator.
3063 (display_string): If we need to ignore text properties of
3064 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3065 original value of -1 will not work with bidi.)
3066 (compute_display_string_pos): First arg is now struct
3067 `text_pos *'; all callers changed. Support display properties on
3069 (compute_display_string_end): Support display properties on Lisp
3071 (init_iterator, reseat_1, reseat_to_string): Initialize the
3072 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3073 when iterating on a string not from display properties).
3074 (compute_display_string_pos, compute_display_string_end):
3075 Fix calculation of the object to scan. Fixes an error when using
3077 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3078 base_level_stop; instead, set base_level_stop to BEGV.
3079 Fixes crashes in vertical-motion.
3080 (next_element_from_buffer): Improve commentary for when
3081 the iterator is before prev_stop.
3082 (init_iterator): Initialize bidi_p from the default value of
3083 bidi-display-reordering, not from buffer-local value. Use the
3084 buffer-local value only if initializing for buffer iteration.
3085 (handle_invisible_prop): Support invisible properties on strings
3086 that are being bidi-reordered.
3087 (set_iterator_to_next): Support bidi reordering of C strings and
3089 (next_element_from_string): Support bidi reordering of Lisp
3091 (handle_stop_backwards): Support Lisp strings as well.
3092 (display_string): Support display of R2L glyph rows.
3093 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3094 (init_iterator): Don't initialize it->bidi_p for strings
3096 (reseat_to_string): Initialize it->bidi_p for strings here.
3097 (next_element_from_string, next_element_from_c_string)
3098 (next_element_from_buffer): Add xassert's for correspondence
3099 between IT's object being iterated and it->bidi_it.string
3101 (face_before_or_after_it_pos): Support bidi iteration.
3102 (next_element_from_c_string): Handle the case of the first string
3103 character that is not the first one in the visual order.
3104 (get_visually_first_element): New function, refactored from common
3105 parts of next_element_from_buffer, next_element_from_string, and
3106 next_element_from_c_string.
3107 (tool_bar_lines_needed, redisplay_tool_bar)
3108 (display_menu_bar): Force left-to-right direction. Add a FIXME
3109 comment for making that be controlled by a user option.
3110 (push_it, pop_it): Save and restore the state of the
3111 bidi iterator. Save and restore the bidi_p flag.
3112 (pop_it): Iterate out of display property for string iteration as
3114 (iterate_out_of_display_property): Support iteration over strings.
3115 (handle_single_display_spec): Set up it->bidi_it for iteration
3116 over a display string, and call bidi_init_it.
3117 (handle_single_display_spec, next_overlay_string)
3118 (get_overlay_strings_1, push_display_prop): Set up the bidi
3119 iterator for displaying display or overlay strings.
3120 (forward_to_next_line_start): Don't use the shortcut if
3122 (back_to_previous_visible_line_start): If handle_display_prop
3123 pushed the iterator stack, restore the internal state of the bidi
3124 iterator by calling bidi_pop_it same number of times.
3125 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3126 and we are bidi-iterating, don't decrement the iterator position;
3127 instead, set the first_elt flag in the bidi iterator, to produce
3129 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3130 (push_display_prop): xassert that we are iterating a buffer.
3131 (push_it, pop_it): Save and restore paragraph_embedding member.
3132 (handle_single_display_spec, next_overlay_string)
3133 (get_overlay_strings_1, reseat_1, reseat_to_string)
3134 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3135 correctly. Don't assume unibyte strings are not bidi-reordered.
3136 (compute_display_string_pos)
3137 (compute_display_string_end): Fix handling the case of C string.
3138 (push_it, pop_it): Save and restore from_disp_prop_p.
3139 (handle_single_display_spec, push_display_prop): Set the
3140 from_disp_prop_p flag.
3141 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3142 (pop_it): Call iterate_out_of_display_property only if we are
3143 popping after iteration over a string that came from a display
3144 property. Fix a typo in popping stretch info. Add an assertion
3145 for verifying that the iterator position is in sync with the bidi
3147 (handle_single_display_spec, get_overlay_strings_1)
3148 (push_display_prop): Fix initialization of paragraph direction for
3149 string when that of the parent object is not yet determined.
3150 (reseat_1): Call bidi_init_it to resync the bidi
3151 iterator with IT's position. (Bug#7616)
3152 (find_row_edges): If ROW->start.pos gives position
3153 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3154 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3155 Reset the from_disp_prop_p flag.
3156 (SAVE_IT, RESTORE_IT): New macros.
3157 (pos_visible_p, face_before_or_after_it_pos)
3158 (back_to_previous_visible_line_start)
3159 (move_it_in_display_line_to, move_it_in_display_line)
3160 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3161 (try_scrolling, redisplay_window, display_line): Use them when
3162 saving a temporary copy of the iterator and restoring it back.
3163 (back_to_previous_visible_line_start, reseat_1)
3164 (init_iterator): Empty the bidi cache "stack".
3165 (move_it_in_display_line_to): If iterator ended up at
3166 EOL, but we never saw any buffer positions smaller than
3167 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3168 motion in bidi-reordered lines.
3169 (move_it_in_display_line_to): Record prev_method and prev_pos
3170 immediately before the call to set_iterator_to_next. Fixes cursor
3171 motion in bidi-reordered lines with stretch glyphs and strings
3172 displayed in margins. (Bug#8133) (Bug#8867)
3173 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3175 (pos_visible_p): Support positions in bidi-reordered lines.
3176 Save and restore bidi cache.
3178 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3179 (bidi_paragraph_info): Delete unused struct.
3180 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3181 (bidi_cache_start): New variable.
3182 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3184 (bidi_cache_fetch_state, bidi_cache_search)
3185 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3186 (bidi_cache_find, bidi_peek_at_next_level)
3187 (bidi_level_of_next_char, bidi_find_other_level_edge)
3188 (bidi_move_to_visually_next): Compare cache index with
3189 bidi_cache_start rather than with zero.
3190 (bidi_fetch_char): Accept new argument STRING; all callers
3191 changed. Support iteration over a string. Support strings with
3192 display properties. Support unibyte strings. Fix the type of
3193 `len' according to what STRING_CHAR_AND_LENGTH expects.
3194 (bidi_paragraph_init, bidi_resolve_explicit_1)
3195 (bidi_resolve_explicit, bidi_resolve_weak)
3196 (bidi_level_of_next_char, bidi_move_to_visually_next):
3197 Support iteration over a string.
3198 (bidi_set_sor_type, bidi_resolve_explicit_1)
3199 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3200 can now be zero (for strings); special values 0 and -1 were
3201 changed to -1 and -2, respectively.
3202 (bidi_char_at_pos): New function.
3203 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3204 Call it instead of FETCH_MULTIBYTE_CHAR.
3205 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3206 initialized to valid values.
3207 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3209 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3210 the test for valid cached positions. Fix the logic for looking up
3211 the sentinel state in the cache. GCPRO the Lisp string we are
3213 (bidi_push_it, bidi_pop_it): New functions.
3214 (bidi_initialize): Initialize the bidi cache start stack pointer.
3215 (bidi_cache_ensure_space): New function, refactored from part of
3216 bidi_cache_iterator_state. Don't assume the required size is just
3217 one BIDI_CACHE_CHUNK away.
3218 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3219 (bidi_count_bytes, bidi_char_at_pos): New functions.
3220 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3221 always valid if bidi_cache_idx is valid.
3222 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3223 is valid if it's going to be used.
3224 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3225 (bidi_cache_fetch_state, bidi_cache_search)
3226 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3227 (bidi_cache_iterator_state, bidi_cache_find)
3228 (bidi_find_other_level_edge, bidi_cache_start_stack):
3229 All variables related to cache indices are now EMACS_INT.
3231 * dispextern.h (struct bidi_string_data): New structure.
3232 (struct bidi_it): New member `string'. Make flag members be 1-bit
3233 fields, and put them last in the struct.
3234 (compute_display_string_pos, compute_display_string_end):
3236 (bidi_push_it, bidi_pop_it): Add prototypes.
3237 (struct iterator_stack_entry): New members bidi_p,
3238 paragraph_embedding, and from_disp_prop_p.
3239 (struct it): Member bidi_p is now a bit field 1 bit wide.
3240 (bidi_shelve_cache, bidi_unshelve_cache):
3243 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3244 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3245 and vector-like objects.
3247 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3248 cache around display iteration.
3250 * window.c (Fwindow_end, window_scroll_pixel_based)
3251 (displayed_window_lines, Frecenter): Save and restore the bidi
3252 cache around display iteration.
3254 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3256 * editfns.c (Fdelete_region): Clarify the use of the named
3257 parameters (bug#6788).
3259 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3261 * indent.c (Fvertical_motion): Set and restore w->pointm when
3262 saving and restoring the window's buffer (Bug#9006).
3264 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3266 * editfns.c (Fstring_to_char): Clarify just what is returned
3267 (bug#6576). Text by Eli Zaretskii.
3269 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3271 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3273 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3275 * buffer.c (mmap_find): Fix a typo.
3277 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3279 Fix execution of x selection hooks.
3280 * xselect.c (Qx_lost_selection_functions)
3281 (Qx_sent_selection_functions): New vars.
3282 (syms_of_xselect): DEFSYM them.
3283 (x_handle_selection_request): Pass Qx_sent_selection_functions
3284 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3285 (x_handle_selection_clear,x_clear_frame_selections):
3286 Pass Qx_lost_selection_functions rather than
3287 Vx_lost_selection_functions to Frun_hook_with_args.
3289 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3291 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3292 The old code sometimes used this field without initializing it.
3294 * alloc.c (gc_sweep): Don't read past end of array.
3295 In theory, the old code could also have corrupted Emacs internals,
3296 though it'd be very unlikely.
3298 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3300 * character.c (Fcharacterp): Don't advertise optional ignored
3301 argument. (Bug#4026)
3303 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3305 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3308 * window.c (Fset_window_start): Doc fix (bug#4199).
3309 (Fset_window_hscroll): Ditto.
3311 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3313 Fix minor new problems caught by GCC 4.6.1.
3314 * term.c (init_tty): Remove unused local.
3315 * xsettings.c (store_monospaced_changed): Define this function only
3316 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3319 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3321 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3323 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3325 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3326 are the mini-buffer and the echo area (bug#3320).
3328 * term.c (init_tty): Remove support for supdup, c10 and perq
3329 terminals, which are no longer supported (bug#1482).
3331 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3333 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3335 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3337 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3338 for non-popups (Bug#3642).
3340 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3342 * alloc.c (reset_malloc_hooks): Protoize.
3343 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3344 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3345 * cm.c (losecursor): Likewise.
3346 * data.c (fmod): Likewise.
3347 * dispnew.c (swap_glyphs_in_rows): Likewise.
3348 * emacs.c (memory_warning_signal): Likewise.
3349 * floatfns.c (float_error): Likewise.
3350 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3351 (otf_open, font_otf_capability, generate_otf_features)
3352 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3354 * image.c (pbm_read_file): Likewise.
3355 * indent.c (string_display_width): Likewise.
3356 * intervals.c (check_for_interval, search_for_interval)
3357 (inc_interval_count, count_intervals, root_interval)
3358 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3359 * lread.c (defalias): Likewise.
3360 * ralloc.c (r_alloc_check): Likewise.
3361 * regex.c (set_image_of_range_1, set_image_of_range)
3362 (regex_grow_registers): Likewise.
3363 * sysdep.c (strerror): Likewise.
3364 * termcap.c (valid_filename_p, tprint, main): Likewise.
3365 * tparam.c (main): Likewise.
3366 * unexhp9k800.c (run_time_remap, save_data_space)
3367 (update_file_ptrs, read_header, write_header, calculate_checksum)
3368 (copy_file, copy_rest, display_header): Likewise.
3369 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3371 * xdisp.c (check_it): Likewise.
3372 * xfaces.c (register_color, unregister_color, unregister_colors):
3374 * xfns.c (print_fontset_result): Likewise.
3375 * xrdb.c (member, fatal, main): Likewise.
3377 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3379 Fix minor problems found by static checking (Bug#9031).
3380 * chartab.c (char_table_set_range, map_sub_char_table):
3381 Remove unused locals.
3382 (uniprop_table): Now static.
3383 * composite.c (_work_char): Remove unused static var.
3385 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3387 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3389 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3391 * gtkutil.c (qttip_cb): Remove code without function.
3393 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3395 * w32.c (pthread_sigmask): New stub.
3397 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3399 Use pthread_sigmask, not sigprocmask (Bug#9010).
3400 sigprocmask is portable only for single-threaded applications, and
3401 Emacs can be multi-threaded when it uses GTK.
3402 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3404 * callproc.c (Fcall_process):
3405 * process.c (create_process):
3406 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3407 Use pthread_sigmask, not sigprocmask.
3409 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3411 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3412 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3415 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3417 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3418 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3419 (xg_hide_tooltip): Fix comment.
3421 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3422 in registerServicesMenuSendTypes.
3423 (validRequestorForSendType): Don't check ns_return_types.
3425 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3428 2011-07-08 Jason Rumney <jasonr@gnu.org>
3430 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3431 SH_SHOW for hidden windows (Bug#5482).
3433 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3434 frame struct members of non-existent frames (Bug#6284).
3436 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3438 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3439 variable firstTime not needed on OSX >= 10.6.
3440 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3441 >= 10.5. Use setKnobProportion, setDoubleValue.
3443 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3444 (MAC_OS_X_VERSION_10_5): Define if not defined.
3445 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3446 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3447 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3449 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3450 cString and lossyCString on OSX >= 10.4
3452 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3453 sizeToFit on OSX >= 10.2.
3455 * nsimage.m (allocInitFromFile): Don't use deprecated method
3456 bestRepresentationForDevice on OSX >= 10.6.
3458 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3461 * emacs.c: Declare unexec_init_emacs_zone.
3463 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3465 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3467 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3468 on svcsMenu (Bug#8842).
3470 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3472 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3474 * nsterm.m (QUTF8_STRING): Declare.
3475 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3476 (validRequestorForSendType): Return type is (id).
3477 Change indexOfObjectIdenticalTo to indexOfObject.
3478 Check if we have local selection before returning self (Bug#8842).
3479 (writeSelectionToPasteboard): Put local selection into paste board
3480 if we have a local selection (Bug#8842).
3481 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3483 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3484 (ns_get_local_selection): Declare.
3486 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3488 * keymap.c (describe_map_tree): Don't insert a double newline at
3489 the end of the buffer (bug#1169) and return whether we inserted
3492 * callint.c (Fcall_interactively): Change "reading args" to
3493 "providing args" to try to clarify what it does (bug#1010).
3495 2011-07-07 Kenichi Handa <handa@m17n.org>
3497 * composite.c (composition_compute_stop_pos): Ignore a static
3498 composition starting before CHARPOS (Bug#8915).
3500 * xdisp.c (handle_composition_prop): Likewise.
3502 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3504 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3507 2011-07-07 Kenichi Handa <handa@m17n.org>
3509 * character.h (unicode_category_t): New enum type.
3511 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3512 (Qchar_code_property_table): New variable.
3513 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3514 (UNIPROP_COMPRESSED_FORM_P): New macros.
3515 (char_table_ascii): Uncompress the compressed values.
3516 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3517 Uncompress the compressed values.
3518 (sub_char_table_ref_and_range): Likewise.
3519 (char_table_ref_and_range): Uncompress the compressed values.
3520 (sub_char_table_set): New arg is_uniprop. Callers changed.
3521 Uncompress the compressed values.
3522 (sub_char_table_set_range): Args changed. Callers changed.
3523 (char_table_set_range): Adjuted for the above change.
3524 (map_sub_char_table): Delete args default_val and parent. Add arg
3525 top. Give decoded values to a Lisp function.
3526 (map_char_table): Adjust for the above change. Give decoded
3527 values to a Lisp function. Gcpro more variables.
3528 (uniprop_table_uncompress)
3529 (uniprop_decode_value_run_length): New functions.
3530 (uniprop_decoder, uniprop_decoder_count): New variables.
3531 (uniprop_get_decoder, uniprop_encode_value_character)
3532 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3534 (uniprop_encoder, uniprop_encoder_count): New variables.
3535 (uniprop_get_encoder, uniprop_table)
3536 (Funicode_property_table_internal, Fget_unicode_property_internal)
3537 (Fput_unicode_property_internal): New functions.
3538 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3539 Sunicode_property_table_internal, Sget_unicode_property_internal,
3540 and Sput_unicode_property_internal. Defvar_lisp
3541 char-code-property-alist.
3543 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3544 Vunicode_category_table.
3546 * font.c (font_range): Adjust for the change of
3547 Vunicode_category_table.
3549 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3551 * m/iris4d.h: Remove file, move contents ...
3552 * s/irix6-5.h: ... here.
3554 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3556 Remove unportable assumption about struct layout (Bug#8884).
3557 * alloc.c (mark_buffer):
3558 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3559 (clone_per_buffer_values): Don't assume that
3560 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3561 This isn't true in general, and it's particularly not true
3562 if Emacs is configured with --with-wide-int.
3563 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3564 New macros, used in the buffer.c change.
3566 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3568 * xsettings.c: Use both GConf and GSettings if both are available.
3569 (store_config_changed_event): Add comment.
3570 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3571 (store_tool_bar_style_changed): New functions.
3572 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3573 (struct xsettings): Move font inside HAVE_XFT.
3574 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3575 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3576 Move inside HAVE_XFT.
3577 (something_changed_gsettingsCB): Rename from something_changedCB.
3578 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3580 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3581 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3582 (something_changed_gconfCB): Rename from something_changedCB.
3583 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3584 (parse_settings): Move check for font inside HAVE_XFT.
3585 (read_settings, apply_xft_settings): Add comment.
3586 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3587 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3588 call store_font_name_changed.
3589 (xft_settings_event): Add comment.
3590 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3591 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3592 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3593 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3594 (xsettings_initialize): Call init_gsettings last.
3595 (xsettings_get_system_font, xsettings_get_system_normal_font):
3598 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3600 Random fixes. E.g., (random) never returned negative values.
3601 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3602 subseconds part to the entropy, as that's a bit more random.
3603 Prefer signed to unsigned, since the signedness doesn't matter and
3604 in general we prefer signed. When given a limit, use a
3605 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3606 latter isn't right if USE_2_TAGS_FOR_INTS.
3607 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3608 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3610 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3612 * textprop.c (text_property_stickiness):
3613 Obey Vtext_property_default_nonsticky.
3614 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3615 * w32fns.c (syms_of_w32fns):
3616 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3618 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3620 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3621 This is more efficient than Ffile_directory_p and avoids a minor race.
3623 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3625 * buffer.c (Foverlay_put): Say what the return value is
3628 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3629 is a directory before asking whether to use the file name
3631 (barf_or_query_if_file_exists): Make the "File is a directory"
3632 error be more correct.
3634 * fns.c (Frequire): Remove the mention of the .gz files, since
3635 that's installation-specific, but keep the mention of
3636 `get-load-suffixes'.
3638 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3640 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3641 Report string overflow if the output is too long.
3643 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3645 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3646 (syms_of_gnutls): Remove duplicate DEFSYM for
3647 Qgnutls_bootprop_verify_hostname_error, an error for
3648 Qgnutls_bootprop_verify_error (which is no longer used).
3650 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3651 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3652 Also (re)move comments that are misplaced or no longer relevant.
3654 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3656 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3658 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3660 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3661 and background color parameters if they have been changed.
3663 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3665 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3667 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3669 * xsettings.c (SYSTEM_FONT): Define only when used.
3670 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3672 * keymap.c (access_keymap_1): Now static.
3674 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3676 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3677 leave any prefix arg for the up event (Bug#1586).
3679 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3681 * lread.c (syms_of_lread): Mention single symbols defined by
3682 `defvar' or `defconst' (bug#7154).
3684 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3685 (Frequire): Mention get-load-suffixes.
3687 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3689 * window.h (window): Remove clone_number slot.
3690 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3692 (make_parent_window, make_window, saved_window)
3693 (Fset_window_configuration, save_window_save): Don't deal with
3695 * buffer.c (Qclone_number): Remove declaration.
3696 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3698 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3700 Add multiple inheritance to keymaps.
3701 * keymap.c (Fmake_composed_keymap): New function.
3702 (Fset_keymap_parent): Simplify.
3703 (fix_submap_inheritance): Remove.
3704 (access_keymap_1): New function extracted from access_keymap to handle
3705 embedded parents and handle lists of maps.
3706 (access_keymap): Use it.
3707 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3708 (Fcopy_keymap): Handle embedded parents.
3709 (Fcommand_remapping, define_as_prefix): Simplify.
3710 (Fkey_binding): Simplify.
3711 (syms_of_keymap): Move minibuffer-local-completion-map,
3712 minibuffer-local-filename-completion-map,
3713 minibuffer-local-must-match-map, and
3714 minibuffer-local-filename-must-match-map to Elisp.
3715 (syms_of_keymap): Defsubr make-composed-keymap.
3716 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3717 (parse_menu_item): Trivial simplification.
3719 2011-07-01 Glenn Morris <rgm@gnu.org>
3721 * Makefile.in (SETTINGS_LIBS): Fix typo.
3723 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3725 * coding.c (Fencode_coding_string): Record the last coding system
3726 used, as the function doc string says (bug#8738).
3728 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3730 * xsettings.c (store_monospaced_changed): Take new font as arg and
3731 check for change against current_mono_font.
3732 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3733 (emacs_settings_constructor, emacs_settings_get_property)
3734 (emacs_settings_set_property, emacs_settings_class_init)
3735 (emacs_settings_init, gsettings_obj): Remove.
3736 (something_changedCB): New function for HAVE_GSETTINGS.
3737 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3738 with value as argument.
3739 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3740 g_settings_new (Bug#8967). Do not create gsettings_obj.
3741 Remove calls to g_settings_bind. Connect something_changedCB to
3744 * xgselect.c: Add defined (HAVE_GSETTINGS).
3745 (xgselect_initialize): Ditto.
3747 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3748 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3751 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3753 * eval.c (struct backtrace): Simplify and port the data structure.
3754 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3755 signed bit field, as this assumption is not portable and it makes
3756 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3757 "char debug_on_exit : 1" as this is not portable either; instead,
3758 use the portable "unsigned int debug_on_exit : 1". Remove unused
3759 member evalargs. Remove obsolete comments about cc bombing out.
3761 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3763 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3764 Let HAVE_GSETTINGS override HAVE_GCONF.
3765 (store_monospaced_changed): New function.
3766 (EMACS_SETTINGS): A new type derived from GObject to handle
3767 GSettings notifications.
3768 (emacs_settings_constructor, emacs_settings_get_property)
3769 (emacs_settings_set_property, emacs_settings_class_init):
3771 (gsettings_client, gsettings_obj): New variables.
3772 (GSETTINGS_SCHEMA): New define.
3773 (something_changedCB): Call store_monospaced_changed.
3774 (init_gsettings): New function.
3775 (xsettings_initialize): Call init_gsettings.
3776 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3779 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3782 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3784 * window.c (resize_root_window, grow_mini_window)
3785 (shrink_mini_window): Rename Qresize_root_window to
3786 Qwindow_resize_root_window and Qresize_root_window_vertically to
3787 Qwindow_resize_root_window_vertically.
3789 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3791 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3793 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3795 * makefile.w32-in: Redesign dependencies so they reflect more
3796 clearly which files are directly included by each source file,
3797 and not through other includes.
3799 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3801 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3802 (sort_overlays, overlay_strings): When an overlay's clone number
3803 matches the window's clone number process the overlay even if
3804 the overlay's window property doesn't match the current window.
3806 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3807 (Fwindow_hchild): Rename to Fwindow_left_child.
3808 (Fwindow_next): Rename to Fwindow_next_sibling.
3809 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3810 (resize_window_check): Rename to window_resize_check.
3811 (resize_window_apply): Rename to window_resize_apply.
3812 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3813 (Fdelete_other_windows_internal, resize_frame_windows)
3814 (Fsplit_window_internal, Fdelete_window_internal)
3815 (grow_mini_window, shrink_mini_window)
3816 (Fresize_mini_window_internal): Fix callers accordingly.
3818 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3820 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3821 (emacs_fixed_set_min_size): Remove.
3822 (emacs_fixed_new): Take frame as argument.
3824 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3825 (_EmacsFixedPrivate): Remove minwidth/height.
3826 Add struct frame *f.
3827 (emacs_fixed_init): Initialize priv->f.
3828 (get_parent_class, emacs_fixed_set_min_size): Remove.
3829 (emacs_fixed_new): Set priv->f to argument.
3830 (emacs_fixed_get_preferred_width)
3831 (emacs_fixed_get_preferred_height): Use min_width/height from
3832 frames size_hint to set minimum and natural (Bug#8919).
3833 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3834 and use min_width/height from frames size_hint to set
3835 min_width/height (Bug#8919).
3837 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3838 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3841 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3843 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3844 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3847 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3849 * process.c (wait_reading_process_output): Bypass select if
3850 waiting for a cell while ignoring keyboard input, and input is
3851 pending. Suggested by Jan Djärv (Bug#8869).
3853 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3855 Use gnulib's dup2 module instead of rolling our own.
3856 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3858 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3860 * dispnew.c (scrolling_window): Before scrolling, turn off a
3861 mouse-highlight in the window being scrolled.
3863 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3865 Move DEFSYM to lisp.h and use everywhere.
3867 * character.h (DEFSYM): Move declaration...
3868 * lisp.h (DEFSYM): ...here.
3874 * w32select.c: Don't include character.h.
3876 * alloc.c (syms_of_alloc):
3877 * buffer.c (syms_of_buffer):
3878 * bytecode.c (syms_of_bytecode):
3879 * callint.c (syms_of_callint):
3880 * casefiddle.c (syms_of_casefiddle):
3881 * casetab.c (init_casetab_once):
3882 * category.c (init_category_once, syms_of_category):
3883 * ccl.c (syms_of_ccl):
3884 * cmds.c (syms_of_cmds):
3885 * composite.c (syms_of_composite):
3886 * dbusbind.c (syms_of_dbusbind):
3887 * dired.c (syms_of_dired):
3888 * dispnew.c (syms_of_display):
3889 * doc.c (syms_of_doc):
3890 * editfns.c (syms_of_editfns):
3891 * emacs.c (syms_of_emacs):
3892 * eval.c (syms_of_eval):
3893 * fileio.c (syms_of_fileio):
3894 * fns.c (syms_of_fns):
3895 * frame.c (syms_of_frame):
3896 * fringe.c (syms_of_fringe):
3897 * insdel.c (syms_of_insdel):
3898 * keymap.c (syms_of_keymap):
3899 * lread.c (init_obarray, syms_of_lread):
3900 * macros.c (syms_of_macros):
3901 * msdos.c (syms_of_msdos):
3902 * print.c (syms_of_print):
3903 * process.c (syms_of_process):
3904 * search.c (syms_of_search):
3905 * sound.c (syms_of_sound):
3906 * syntax.c (init_syntax_once, syms_of_syntax):
3907 * terminal.c (syms_of_terminal):
3908 * textprop.c (syms_of_textprop):
3909 * undo.c (syms_of_undo):
3910 * w32.c (globals_of_w32):
3911 * window.c (syms_of_window):
3912 * xdisp.c (syms_of_xdisp):
3913 * xfaces.c (syms_of_xfaces):
3914 * xfns.c (syms_of_xfns):
3915 * xmenu.c (syms_of_xmenu):
3916 * xsettings.c (syms_of_xsettings):
3917 * xterm.c (syms_of_xterm): Use DEFSYM.
3919 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3921 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3923 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3925 Integer and buffer overflow fixes (Bug#8873).
3927 * print.c (printchar, strout): Check for string overflow.
3928 (PRINTPREPARE, printchar, strout):
3929 Don't set size unless allocation succeeds.
3931 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3932 for sizes. Check for string overflow more accurately.
3933 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3935 * macros.c: Integer and buffer overflow fixes.
3936 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3937 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3938 Use ptrdiff_t, not int, for sizes.
3939 Don't increment bufsize until after realloc succeeds.
3940 Check for size-calculation overflow.
3941 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3943 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3945 * lread.c: Integer overflow fixes.
3946 (read_integer): Radix is now EMACS_INT, not int,
3947 to improve quality of diagnostics for out-of-range radices.
3948 Calculate buffer size correctly for out-of-range radices.
3949 (read1): Check for integer overflow in radices, and in
3950 read-circle numbers.
3951 (read_escape): Avoid int overflow.
3952 (Fload, openp, read_buffer_size, read1)
3953 (substitute_object_recurse, read_vector, read_list, map_obarray):
3954 Use ptrdiff_t, not int, for sizes.
3955 (read1): Use EMACS_INT, not int, for sizes.
3956 Check for size overflow.
3958 * image.c (cache_image): Check for size arithmetic overflow.
3960 * lread.c: Integer overflow issues.
3961 (saved_doc_string_size, saved_doc_string_length)
3962 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3963 Now ptrdiff_t, not int.
3964 (read1): Don't assume doc string length fits in int. Check for
3965 out-of-range doc string lengths.
3966 (read_list): Don't assume file position fits in int.
3967 (read_escape): Check for hex character overflow.
3969 2011-06-22 Leo Liu <sdl.web@gmail.com>
3971 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3972 Move to minibuffer.el.
3974 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3976 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3977 The following patches are for when GLYPH_DEBUG && !XASSERT.
3978 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3979 * dispnew.c (flush_stdout):
3980 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3981 Mark as externally visible.
3982 * dispnew.c (check_window_matrix_pointers): Now static.
3983 * dispnew.c (window_to_frame_vpos):
3984 * xfns.c (unwind_create_frame):
3985 * xterm.c (x_check_font): Remove unused local.
3986 * scroll.c (CHECK_BOUNDS):
3987 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3988 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3989 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3990 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3991 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3993 (debug_method_add): Use va_list and vsprintf rather than relying
3994 on undefined behavior with wrong number of arguments.
3995 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3996 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3997 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3998 since we're not interested in debugging glyphs with old libraries.
3999 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4000 GCC 4.6.0's static checking.
4002 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4004 Integer overflow and signedness fixes (Bug#8873).
4005 A few related buffer overrun fixes, too.
4007 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4009 * dispextern.h (struct face.stipple):
4010 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4011 (x_bitmap_mask, x_allocate_bitmap_record)
4012 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4013 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4014 (x_create_bitmap_from_xpm_data):
4015 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4016 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4018 * xfaces.c (load_pixmap):
4019 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4020 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4021 (.bitmaps_last, struct x_output.icon_bitmap):
4022 Use ptrdiff_t, not int, for bitmap indexes.
4023 (x_allocate_bitmap_record): Check for size overflow.
4024 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4026 Use ptrdiff_t, not int, for overlay counts.
4027 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4028 * editfns.c (overlays_around, get_pos_property):
4029 * textprop.c (get_char_property_and_overlay):
4030 * xdisp.c (next_overlay_change, note_mouse_highlight):
4031 * xfaces.c (face_at_buffer_position):
4032 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4033 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4034 (Fnext_overlay_change, Fprevious_overlay_change)
4035 (mouse_face_overlay_overlaps, Foverlays_in):
4036 Use ptrdiff_t, not int, for sizes.
4037 (overlays_at, overlays_in): Check for size-calculation overflow.
4039 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4041 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4042 (x_session_initialize): Do not assume string length fits in int.
4044 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4045 This is unlikely, but can occur if DPI is outlandish.
4047 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4048 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4050 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4051 * xrdb.c (magic_file_p, search_magic_path):
4052 Omit last arg SUFFIX; it was always 0. All callers changed.
4053 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4055 * xfont.c (xfont_match): Avoid need for strlen.
4057 * xfns.c: Don't assume strlen fits in int.
4058 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4060 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4061 not unsigned long, as we prefer signed integers. All callers changed.
4062 Detect integer overflow in repeat count.
4063 (message_dolog): Don't assume print length fits in 39 bytes.
4064 (display_mode_element): Don't assume strlen fits in int.
4066 * termcap.c: Don't assume sizes fit in int and never overflow.
4067 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4068 (gobble_line): Check for size-calculation overflow.
4070 * minibuf.c (Fread_buffer):
4071 * lread.c (intern, intern_c_string):
4072 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4073 Don't assume string length fits in int.
4075 * keyboard.c (parse_tool_bar_item):
4076 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4078 * font.c: Don't assume string length fits in int.
4079 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4080 Use ptrdiff_t, not int.
4081 (font_intern_prop): Don't assume string length fits in int.
4082 Don't assume integer property fits in fixnum.
4083 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4085 * filelock.c: Fix some buffer overrun and integer overflow issues.
4086 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4087 Reformulate so as not to need the command string.
4088 Invoke gzip -cd rather than gunzip, as it's more portable.
4089 (lock_info_type, lock_file_1, lock_file):
4090 Don't assume pid_t and time_t fit in unsigned long.
4091 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4092 (current_lock_owner): Prefer signed type for sizes.
4093 Use memcpy, not strncpy, where memcpy is what is really wanted.
4094 Don't assume (via atoi) that time_t and pid_t fit in int.
4095 Check for time_t and/or pid_t out of range, e.g., via a network share.
4096 Don't alloca where an auto var works fine.
4098 * fileio.c: Fix some integer overflow issues.
4099 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4100 Don't assume string length fits in int.
4101 (directory_file_name): Don't assume string length fits in long.
4102 (make_temp_name): Don't assume pid fits in int, or that its print
4103 length is less than 20.
4105 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4107 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4109 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4111 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4112 We prefer signed integers, even for size calculations.
4114 * emacs.c: Don't assume string length fits in 'int'.
4115 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4116 (main): Don't invoke strlen when not needed.
4118 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4119 (XD_DEBUG_MESSAGE): Don't waste a byte.
4121 * callproc.c (getenv_internal_1, getenv_internal)
4123 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4125 * lread.c (invalid_syntax): Omit length argument.
4126 All uses changed. This doesn't fix a bug, but it simplifies the
4127 code away from its former Hollerith-constant appearance, and it's
4128 one less 'int' to worry about when looking at integer-overflow issues.
4129 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4131 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4132 This didn't break anything, but it didn't help either.
4133 It's confusing to put a bogus integer in a place where the actual
4134 value does not matter.
4135 (LIST_END_P): Remove unused macro and its bogus comment.
4136 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4138 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4139 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4141 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4142 We prefer signed types, and the value cannot exceed the EMACS_INT
4143 range anyway (because otherwise the length would not be representable).
4144 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4145 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4146 This avoids a GCC warning when WIDE_EMACS_INT.
4148 * indent.c (sane_tab_width): New function.
4149 (current_column, scan_for_column, Findent_to, position_indentation)
4150 (compute_motion): Use it. This is just for clarity.
4151 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4153 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4155 * lisp.h (lint_assume): New macro.
4156 * composite.c (composition_gstring_put_cache):
4157 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4159 * editfns.c, insdel.c:
4160 Omit unnecessary forward decls, to simplify future changes.
4162 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4164 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4166 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4167 Use much-faster test for byte-length change.
4168 Don't assume string byte-length fits in 'int'.
4169 Check that character arg fits in 'int'.
4170 (mapcar1): Declare byte as byte, for clarity.
4172 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4174 * fns.c (concat): Catch string overflow earlier.
4175 Do not rely on integer wraparound.
4177 * dispextern.h (struct it.overlay_strings_charpos)
4178 (struct it.selective): Now EMACS_INT, not int.
4179 * xdisp.c (forward_to_next_line_start)
4180 (back_to_previous_visible_line_start)
4181 (reseat_at_next_visible_line_start, next_element_from_buffer):
4182 Don't arbitrarily truncate the value of 'selective' to int.
4184 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4186 * composite.c: Don't truncate sizes to 'int'.
4187 (composition_gstring_p, composition_reseat_it)
4188 (composition_adjust_point): Use EMACS_INT, not int.
4189 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4190 not EMACS_UINT, for indexes.
4192 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4194 * buffer.c: Include <verify.h>.
4195 (struct sortvec.priority, struct sortstr.priority):
4196 Now EMACS_INT, not int.
4197 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4198 (struct sortstr.size, record_overlay_string)
4199 (struct sortstrlist.size, struct sortlist.used):
4200 Don't truncate size to int.
4201 (record_overlay_string): Check for size-calculation overflow.
4202 (init_buffer_once): Check at compile-time, not run-time.
4204 2011-06-22 Jim Meyering <meyering@redhat.com>
4206 Don't leak an XBM-image-sized buffer
4207 * image.c (xbm_load): Free the image buffer after using it.
4209 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4212 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4213 that Sun C diagnosed.
4214 * fns.c (secure_hash): Fix pointer signedness issue.
4215 * intervals.c (static_offset_intervals): New function.
4216 (offset_intervals): Use it.
4218 2011-06-21 Leo Liu <sdl.web@gmail.com>
4221 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4224 * fns.c (secure_hash): Rename from crypto_hash_function and change
4225 the first arg to accept symbols.
4226 (Fsecure_hash): New primitive.
4227 (syms_of_fns): New symbols.
4229 2011-06-20 Deniz Dogan <deniz@dogan.se>
4231 * process.c (Fset_process_buffer): Clarify return value in
4234 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4236 * dispnew.c (add_window_display_history): Use BVAR.
4238 * xdisp.c (debug_method_add): Use BVAR.
4239 (check_window_end, dump_glyph_matrix, dump_glyph)
4240 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4242 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4245 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4246 check till after the cache is created in init_frame_faces.
4248 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4250 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4252 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4254 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4255 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4256 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4258 Improve buffer-overflow checking (Bug#8873).
4259 * fileio.c (Finsert_file_contents):
4260 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4261 Remove the old (too-loose) buffer overflow checks.
4262 They weren't needed, since make_gap checks for buffer overflow.
4263 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4264 The old code merely checked for Emacs fixnum overflow, and relied
4265 on undefined (wraparound) behavior. The new code avoids undefined
4266 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4268 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4269 Tune. Don't use wider integers than needed. Don't use alloca.
4270 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4272 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4274 * insdel.c, lisp.h (buffer_overflow): New function.
4275 (insert_from_buffer_1, replace_range, replace_range_2):
4276 * insdel.c (make_gap_larger):
4277 * editfns.c (Finsert_char):
4278 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4280 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4282 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4284 Integer overflow and signedness fixes (Bug#8873).
4286 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4287 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4289 * fileio.c: Don't assume EMACS_INT fits in off_t.
4290 (emacs_lseek): New static function.
4291 (Finsert_file_contents, Fwrite_region): Use it.
4292 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4294 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4296 * fns.c: Don't overflow int when computing a list length.
4297 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4298 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4299 truncation on 64-bit hosts. Check for QUIT every
4300 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4301 faster and is responsive enough.
4302 (Flength): Report an error instead of overflowing an integer.
4303 (Fsafe_length): Return a float if the value is not representable
4304 as a fixnum. This shouldn't happen except in contrived situations.
4305 (Fnthcdr, Fsort): Don't assume list length fits in int.
4306 (Fcopy_sequence): Don't assume vector length fits in int.
4308 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4309 (header_size, word_size): New constants.
4310 (allocate_vectorlike): Don't check size overflow here.
4311 (allocate_vector): Check it here instead, since this is the only
4312 caller of allocate_vectorlike that could cause overflow.
4313 Check that the new vector's length is representable as a fixnum.
4315 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4316 The previous code was bogus. For example, next_almost_prime (32)
4317 returned 39, which is undesirable as it is a multiple of 3; and
4318 next_almost_prime (24) returned 25, which is a multiple of 5 so
4319 why was the code bothering to check for multiples of 7?
4321 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4323 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4325 Variadic C functions now count arguments with ptrdiff_t.
4326 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4327 Back then I didn't know that the Emacs coding style prefers signed int.
4328 Also, in the meantime I found a few more instances where arguments
4329 were being counted with int, which may truncate counts on 64-bit
4330 machines, or EMACS_INT, which may be unnecessarily wide.
4331 * lisp.h (struct Lisp_Subr.function.aMANY)
4332 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4333 Arg counts are now ptrdiff_t, not size_t.
4334 All variadic functions and their callers changed accordingly.
4335 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4336 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4337 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4338 * callint.c (Fcall_interactively): Check arg count for overflow,
4339 to avoid potential buffer overrun. Use signed char, not 'int',
4340 for 'varies' array, so that we needn't bother to check its size
4341 calculation for overflow.
4342 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4343 * eval.c (apply_lambda):
4344 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4345 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4346 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4348 * callint.c (Fcall_interactively): Don't use index var as event count.
4350 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4351 * mem-limits.h (SIZE): Remove; no longer used.
4353 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4355 Remove unnecessary casts.
4356 * xterm.c (x_term_init):
4357 * xfns.c (x_set_border_pixel):
4358 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4359 These aren't needed now that we assume ANSI C.
4361 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4362 It's more likely to cause problems (due to unsigned overflow)
4365 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4367 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4369 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4371 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4373 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4375 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4377 GLYPH_CODE_FACE returns EMACS_INT, not int.
4378 * dispextern.h (merge_faces):
4379 * xfaces.c (merge_faces):
4380 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4381 Don't assume EMACS_INT fits in int.
4383 * character.h (CHAR_VALID_P): Remove unused parameter.
4384 * fontset.c, lisp.h, xdisp.c: All uses changed.
4386 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4388 * fns.c (concat): Minor tuning based on overflow analysis.
4389 This doesn't fix any bugs. Use int to hold character, instead
4390 of constantly refetching from Emacs object. Use XFASTINT, not
4391 XINT, for value known to be a character. Don't bother comparing
4392 a single byte to 0400, as it's always less.
4394 * floatfns.c (Fexpt):
4395 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4397 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4400 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4402 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4403 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4404 incorrectly succeed when S was a string, because 4294967386 was
4405 truncated before it was used.
4407 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4408 Otherwise, an out-of-range integer could cause undefined behavior
4411 * composite.c: Use int, not EMACS_INT, for characters.
4412 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4413 EMACS_INT, for values that are known to be in character range.
4414 This doesn't fix any bugs but is the usual style inside Emacs and
4415 may generate better code on 32-bit machines.
4417 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4418 This is for reasons similar to the recent CHAR_STRING fix.
4419 * charset.c (Fencode_char): Check that character arg is actually
4420 a character. Pass an int to ENCODE_CHAR.
4421 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4422 wider than 'int', as a compile-time check to prevent future regressions
4425 * character.c (char_string): Remove unnecessary casts.
4427 Make sure a 64-bit char is never passed to CHAR_STRING.
4428 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4429 by silently ignoring the top 32 bits, allowing some values
4430 that were far too large to be valid characters.
4431 * character.h: Include <verify.h>.
4432 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4433 arguments are no wider than unsigned, as a compile-time check
4434 to prevent future regressions in this area.
4436 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4437 (Fsubst_char_in_region):
4439 * xdisp.c (decode_mode_spec_coding):
4440 Adjust to CHAR_STRING's new requirement.
4441 * editfns.c (Finsert_char, Fsubst_char_in_region):
4442 * fns.c (concat): Check that character args are actually
4443 characters. Without this test, these functions did the wrong
4444 thing with wildly out-of-range values on 64-bit hosts.
4446 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4447 These casts should not be needed on 32-bit hosts, either.
4448 * keyboard.c (read_char):
4449 * lread.c (Fload): Remove casts to unsigned.
4451 * lisp.h (UNSIGNED_CMP): New macro.
4452 This fixes comparison bugs on 64-bit hosts.
4453 (ASCII_CHAR_P): Use it.
4454 * casefiddle.c (casify_object):
4455 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4456 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4457 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4458 * dispextern.h (FACE_FROM_ID):
4459 * keyboard.c (read_char): Use UNSIGNED_CMP.
4461 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4462 not to EMACS_INT, to avoid GCC warning.
4464 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4466 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4467 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4468 isn't needed on 32-bit machines.
4470 * buffer.c (Fgenerate_new_buffer_name):
4471 Use EMACS_INT for count, not int.
4472 (advance_to_char_boundary): Return EMACS_INT, not int.
4474 * data.c (Qcompiled_function): Now static.
4476 * window.c (window_body_lines): Now static.
4478 * image.c (gif_load): Rename local to avoid shadowing.
4480 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4481 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4482 * alloc.c (make_save_value): Integer argument is now of type
4484 (mark_object): Use ptrdiff_t, not int.
4485 * lisp.h (pD): New macro.
4486 * print.c (print_object): Use it.
4488 * alloc.c: Use EMACS_INT, not int, to count objects.
4489 (total_conses, total_markers, total_symbols, total_vector_size)
4490 (total_free_conses, total_free_markers, total_free_symbols)
4491 (total_free_floats, total_floats, total_free_intervals)
4492 (total_intervals, total_strings, total_free_strings):
4493 Now EMACS_INT, not int. All uses changed.
4494 (Fgarbage_collect): Compute overall total using a double, so that
4495 integer overflow is less likely to be a problem. Check for overflow
4496 when converting back to an integer.
4497 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4498 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4499 These were 'int' variables that could overflow on 64-bit hosts;
4500 they were never used, so remove them instead of repairing them.
4501 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4502 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4503 Previously, this ceilinged at INT_MAX, but that doesn't work on
4505 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4507 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4508 (allocate_vectorlike): Check for ptrdiff_t overflow.
4509 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4510 when a (possibly-narrower) signed value would do just as well.
4511 We prefer using signed arithmetic, to avoid comparison confusion.
4513 * alloc.c: Catch some string size overflows that we were missing.
4514 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4515 for convenience in STRING_BYTES_MAX.
4516 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4517 The definition here is exact; the one in lisp.h was approximate.
4518 (allocate_string_data): Check for string overflow. This catches
4519 some instances we weren't catching before. Also, it catches
4520 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4521 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4522 and ptrdiff_t and EMACS_INT are both 64 bits.
4524 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4525 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4526 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4528 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4530 * alloc.c (Fmake_string): Check for out-of-range init.
4532 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4534 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4536 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4538 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4539 xg_get_default_scrollbar_width.
4541 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4542 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4543 (style_changed_cb): Call update_theme_scrollbar_width and call
4544 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4545 all frames (Bug#8505).
4546 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4547 Call gtk_window_set_resizable if HAVE_GTK3.
4548 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4549 and height if HAVE_GTK3 (Bug#8505).
4550 (scroll_bar_width_for_theme): New variable.
4551 (update_theme_scrollbar_width): New function.
4552 (xg_get_default_scrollbar_width): Move code to
4553 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4554 (xg_initialize): Call update_theme_scrollbar_width.
4556 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4558 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4560 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4562 * frame.c (make_frame): Call other_buffer_safely instead of
4565 * window.c (temp_output_buffer_show): Call display_buffer with
4566 second argument Vtemp_buffer_show_specifiers and reset latter
4567 immediately after the call.
4568 (Vtemp_buffer_show_specifiers): New variable.
4569 (auto_window_vscroll_p, next_screen_context_lines)
4570 (Vscroll_preserve_screen_position): Remove leading asterisks from
4573 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4575 Fix minor problems found by GCC 4.6.0 static checking.
4576 * buffer.c (Qclone_number): Remove for now, as it's unused.
4577 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4578 (record_buffer): Remove unused local.
4579 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4580 (set_frame_buffer_list): Remove; unused.
4581 * frame.h (other_visible_frames): Remove decl.
4582 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4583 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4584 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4586 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4587 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4588 Define only if HAVE_GPM.
4589 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4590 (update_hints_inhibit): Remove; never set. All uses removed.
4591 * widgetprv.h (emacsFrameClassRec): Remove decl.
4592 * window.c (delete_deletable_window): Now returns void, since it
4593 wasn't returning anything.
4594 (compare_window_configurations): Remove unused locals.
4595 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4596 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4597 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4598 the same widths as pointers. This follows up on the 2011-05-06 patch.
4599 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4600 * xterm.h: Likewise.
4601 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4603 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4605 * makefile.w32-in: Update dependencies.
4606 (LISP_H): Add lib/intprops.h.
4608 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4610 * image.c (gif_load): Add animation frame delay to the metadata.
4611 (syms_of_image): Use DEFSYM. New symbol `delay'.
4613 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4615 * window.c (delete_deletable_window): Re-add.
4616 (Fset_window_configuration): Rewrite to handle dead buffers and
4617 consequently deletable windows.
4618 (window_tree, Fwindow_tree): Remove. Supply functionality in
4620 (compare_window_configurations): Simplify code.
4622 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4624 * image.c (imagemagick_load_image): Fix type mismatch.
4625 (Fimagemagick_types): Likewise.
4627 * window.h (replace_buffer_in_windows): Declare.
4629 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4631 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4632 Qclone_number. Remove external declaration of Qdelete_window.
4633 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4635 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4636 Run Qbuffer_list_update_hook if allowed.
4637 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4638 buffer list implementation.
4639 (other_buffer_safely): New function.
4640 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4641 calls to replace_buffer_in_windows and
4642 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4644 (record_buffer): Inhibit quitting and rewrite using quittable
4645 functions. Run Qbuffer_list_update_hook if allowed.
4646 (Frecord_buffer, Funrecord_buffer): New functions.
4647 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4648 Move switch-to-buffer to window.el.
4649 (bury-buffer): Move to window.el.
4650 (Vbuffer_list_update_hook): New variable.
4652 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4655 * window.h (resize_frame_windows): Move up in code.
4656 (Fwindow_frame): Remove EXFUN.
4657 (replace_buffer_in_all_windows): Remove prototype.
4658 (replace_buffer_in_windows_safely): Add prototype.
4660 * window.c: Declare Qdelete_window static again. Move down
4661 declaration of select_count.
4662 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4663 (Fother_window): Move to window.el.
4664 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4665 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4666 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4668 (replace_buffer_in_windows): Implement by calling
4669 Qreplace_buffer_in_windows.
4670 (replace_buffer_in_all_windows): Remove with some functionality
4671 moved into replace_buffer_in_windows_safely.
4672 (replace_buffer_in_windows_safely): New function.
4673 (select_window_norecord, select_frame_norecord): Move in front
4674 of run_window_configuration_change_hook. Remove now obsolete
4676 (Fset_window_buffer): Rewrite doc-string.
4677 Call Qrecord_window_buffer.
4678 (keys_of_window): Move binding for other-window to window.el.
4680 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4682 * dispextern.h (struct image): Replace data member, whose int_val
4683 and ptr_val fields were not used by anything, with a single
4686 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4687 (gif_clear_image, gif_load, imagemagick_load_image)
4688 (gs_clear_image, gs_load): Callers changed.
4690 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4692 * buffer.h: Include <time.h>, for time_t.
4693 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4695 Fix minor problems found by static checking.
4697 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4699 Make identifiers static if they are not used in other modules.
4700 * data.c (Qcompiled_function, Qframe, Qvector):
4701 * image.c (QimageMagick, Qsvg):
4702 * minibuf.c (Qmetadata):
4703 * window.c (resize_window_check, resize_root_window): Now static.
4704 * window.h (resize_window_check, resize_root_window): Remove decls.
4706 * window.c (window_deletion_count, delete_deletable_window):
4708 (window_body_lines): Now static.
4709 (Fdelete_other_windows_internal): Mark vars as initialized.
4710 Make sure 'resize_failed' is initialized.
4711 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4712 (resize_window_apply): Remove unused local.
4713 * window.h (delete_deletable_window): Remove decl.
4715 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4716 (imagemagick_load_image): Fix pointer signedness problem by changing
4717 last arg from unsigned char * to char *. All uses changed.
4718 Also, fix a local for similar reasons.
4719 Remove unused locals. Remove locals to avoid shadowing.
4720 (fn_rsvg_handle_free): Remove; unused.
4721 (svg_load, svg_load_image): Fix pointer signedness problem.
4722 (imagemagick_load_image): Don't use garbage pointer image_wand.
4724 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4726 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4728 * image.c (gif_load): Fix omitted cast error introduced by
4731 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4733 * window.h (resize_proportionally, orig_total_lines)
4734 (orig_top_line): Remove from window structure.
4735 (set_window_height, set_window_width, change_window_heights)
4736 (Fdelete_window): Remove prototypes.
4737 (resize_frame_windows): Remove duplicate declaration.
4739 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4741 * window.h (resize_frame_windows, resize_window_check)
4742 (delete_deletable_window, resize_root_window)
4743 (resize_frame_windows): Declare prototypes.
4745 * window.c (resize_window_apply): Make definition be "static" to
4746 match the prototype.
4748 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4750 * window.c: Remove declarations of Qwindow_size_fixed,
4751 window_min_size_1, window_min_size_2, window_min_size,
4752 size_window, window_fixed_size_p, enlarge_window, delete_window.
4753 Remove static from declaration of Qdelete_window, it's
4754 temporarily needed by Fbury_buffer.
4755 (replace_window): Don't assign orig_top_line and
4757 (Fdelete_window, delete_window): Remove. Window deletion is
4758 handled by window.el.
4759 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4760 Replace Fdelete_window calls with calls to Qdelete_window.
4761 (Fdelete_other_windows): Remove. Deleting other windows is
4762 handled by window.el.
4763 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4764 handled in window.el.
4765 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4766 Window minimum sizes are handled in window.el.
4767 (shrink_windows, size_window, set_window_height)
4768 (set_window_width, change_window_heights, window_height)
4769 (window_width, CURBEG, CURSIZE, enlarge_window)
4770 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4771 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4772 handled in window.el.
4773 (make_dummy_parent): Rename to make_parent_window and give it a
4774 second argument horflag.
4775 (make_window): Don't set resize_proportionally any more.
4776 (Fsplit_window): Remove. Windows are split in window.el.
4777 (save_restore_action, save_restore_orig_size)
4778 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4779 Resize mini windows in window.el.
4780 (grow_mini_window, shrink_mini_window): Implement by calling
4781 Qresize_root_window_vertically, resize_window_check and
4782 resize_window_apply.
4783 (saved_window, Fset_window_configuration, save_window_save):
4784 Do not handle orig_top_line, orig_total_lines, and
4785 resize_proportionally.
4786 (window_min_height, window_min_width): Move to window.el.
4787 (keys_of_window): Move bindings for delete-other-windows,
4788 split-window, delete-window and enlarge-window to window.el.
4790 * buffer.c: Temporarily extern Qdelete_window.
4791 (Fbury_buffer): Temporarily call Qdelete_window instead of
4792 Fdelete_window (Fbury_buffer will move to window.el soon).
4794 * frame.c (set_menu_bar_lines_1): Remove code handling
4795 orig_top_line and orig_total_lines.
4797 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4798 set_window_height but set heights directly.
4799 (change_frame_size_1): Use resize_frame_windows.
4801 * xdisp.c (init_xdisp): Don't use set_window_height but set
4804 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4805 Use resize_frame_windows instead of change_window_heights and run
4806 run_window_configuration_change_hook.
4808 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4809 instead of change_window_heights and run
4810 run_window_configuration_change_hook.
4812 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4814 * window.c (replace_window): Rename second argument REPLACEMENT to
4815 NEW. New third argument SETFLAG. Rewrite.
4816 (delete_window, make_dummy_parent): Call replace_window with
4818 (window_list_1): Move down in code.
4819 (run_window_configuration_change_hook): Move set_buffer part
4820 before select_frame_norecord part in order to unwind correctly.
4821 Rename count1 to count.
4822 (recombine_windows, delete_deletable_window, resize_root_window)
4823 (Fdelete_other_windows_internal)
4824 (Frun_window_configuration_change_hook, make_parent_window)
4825 (resize_window_check, resize_window_apply, Fresize_window_apply)
4826 (resize_frame_windows, Fsplit_window_internal)
4827 (Fdelete_window_internal, Fresize_mini_window_internal):
4829 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4831 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4833 * window.h (window): Add some new members to window structure -
4834 normal_lines, normal_cols, new_total, new_normal, clone_number,
4835 splits, nest, prev_buffers, next_buffers.
4836 (WINDOW_TOTAL_SIZE): Move here from window.c.
4837 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4839 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4841 (make_dummy_parent): Set new members of windows structure.
4842 (make_window): Move down in code. Handle new members of window
4844 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4845 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4846 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4847 (Fset_window_prev_buffers, Fwindow_next_buffers)
4848 (Fset_window_next_buffers, Fset_window_clone_number):
4850 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4851 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4853 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4854 Argument WINDOW can be now internal window too.
4855 (Fwindow_use_time): Move up in code.
4856 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4858 (Fset_window_configuration, saved_window)
4859 (Fcurrent_window_configuration, save_window_save): Handle new
4860 members of window structure.
4861 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4862 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4863 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4864 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4865 Qget_mru_window, Qresize_root_window,
4866 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4867 Qauto_buffer_name; staticpro them.
4869 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4871 * window.c (Fwindow_total_size, Fwindow_left_column)
4872 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4873 (Fwindow_list_1): New functions.
4874 (window_box_text_cols): Replace with window_body_cols.
4875 (Fwindow_width, Fscroll_left, Fscroll_right):
4876 Use window_body_cols instead of window_box_text_cols.
4877 (delete_window, Fset_window_configuration):
4878 Call delete_all_subwindows with window as argument.
4879 (delete_all_subwindows): Take a window as argument and not a
4881 (window_loop): Remove handling of GET_LRU_WINDOW and
4883 (Fget_lru_window, Fget_largest_window): Move to window.el.
4885 * window.h: Extern window_body_cols instead of
4886 window_box_text_cols. delete_all_subwindows now takes a
4887 Lisp_Object as argument.
4889 * indent.c (compute_motion, Fcompute_motion):
4890 Use window_body_cols instead of window_box_text_cols.
4892 * frame.c (delete_frame): Call delete_all_subwindows with root
4895 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4897 * fns.c (Fputhash): Document return value.
4899 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4901 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4903 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4905 Cons<->int and similar integer overflow fixes (Bug#8794).
4907 Check for overflow when converting integer to cons and back.
4908 * charset.c (Fdefine_charset_internal, Fdecode_char):
4909 Use cons_to_unsigned to catch overflow.
4910 (Fencode_char): Use INTEGER_TO_CONS.
4911 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4912 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4913 * data.c (long_to_cons, cons_to_long): Remove.
4914 (cons_to_unsigned, cons_to_signed): New functions.
4915 These signal an error for invalid or out-of-range values.
4916 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4917 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4918 * font.c (Ffont_variation_glyphs):
4919 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4920 * lisp.h: Include <intprops.h>.
4921 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4922 (cons_to_signed, cons_to_unsigned): New decls.
4923 (long_to_cons, cons_to_long): Remove decls.
4924 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4925 (Fprimitive_undo): Use CONS_TO_INTEGER.
4926 * xfns.c (Fx_window_property): Likewise.
4927 * xselect.c: Include <limits.h>.
4928 (x_own_selection, selection_data_to_lisp_data):
4929 Use INTEGER_TO_CONS.
4930 (x_handle_selection_request, x_handle_selection_clear)
4931 (x_get_foreign_selection, Fx_disown_selection_internal)
4932 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4933 (lisp_data_to_selection_data): Use cons_to_unsigned.
4934 (x_fill_property_data): Use cons_to_signed.
4935 Report values out of range.
4937 Check for buffer and string overflow more precisely.
4938 * buffer.h (BUF_BYTES_MAX): New macro.
4939 * lisp.h (STRING_BYTES_MAX): New macro.
4940 * alloc.c (Fmake_string):
4941 * character.c (string_escape_byte8):
4942 * coding.c (coding_alloc_by_realloc):
4943 * doprnt.c (doprnt):
4944 * editfns.c (Fformat):
4946 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4947 since they may not be the same number.
4948 * editfns.c (Finsert_char):
4949 * fileio.c (Finsert_file_contents):
4950 Likewise for BUF_BYTES_MAX.
4952 * image.c: Use ptrdiff_t, not int, for sizes.
4953 (slurp_file): Switch from int to ptrdiff_t.
4955 (slurp_file): Check that file size fits in both size_t (for
4956 malloc) and ptrdiff_t (for sanity and safety).
4958 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4959 if b->modtime has its maximal value.
4961 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4963 Don't assume time_t can fit into int.
4964 * buffer.h (struct buffer.modtime): Now time_t, not int.
4965 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4966 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4968 Minor fixes for signed vs unsigned integers.
4969 * character.h (MAYBE_UNIFY_CHAR):
4970 * charset.c (maybe_unify_char):
4971 * keyboard.c (read_char, reorder_modifiers):
4972 XINT -> XFASTINT, since the integer must be nonnegative.
4973 * ftfont.c (ftfont_spec_pattern):
4974 * keymap.c (access_keymap, silly_event_symbol_error):
4975 XUINT -> XFASTINT, since the integer must be nonnegative.
4976 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4977 since it makes no difference and we prefer signed.
4978 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4979 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4982 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4984 * window.h (Fwindow_frame): Declare.
4986 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4988 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4989 (SPARE_MEMORY): Always define.
4990 (LARGE_REQUEST): Remove.
4991 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4993 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4995 * lisp.h: Move EXFUNS for Fframe_root_window,
4996 Fframe_first_window and Fset_frame_selected_window to window.h.
4998 * window.h: Move EXFUNS for Fframe_root_window,
4999 Fframe_first_window and Fset_frame_selected_window here from
5002 * frame.c (Fwindow_frame, Fframe_first_window)
5003 (Fframe_root_window, Fframe_selected_window)
5004 (Fset_frame_selected_window): Move to window.c.
5005 (Factive_minibuffer_window): Move to minibuf.c.
5006 (Fother_visible_frames_p): New function.
5008 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5010 * window.c (decode_window, decode_any_window): Move up in code.
5011 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5012 (inhibit_frame_unsplittable): Remove unused variable.
5013 (Fwindow_buffer): Move up and rewrite doc-string.
5014 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5015 (Fwindow_prev): New functions.
5016 (Fwindow_frame): Move here from frame.c. Accept any window as
5018 (Fframe_root_window, Fframe_first_window)
5019 (Fframe_selected_window): Move here from frame.c. Accept frame
5020 or arbitrary window as argument. Update doc-strings.
5021 (Fminibuffer_window): Move up in code.
5022 (Fwindow_minibuffer_p): Move up in code and simplify.
5023 (Fset_frame_selected_window): Move here from frame.c.
5025 (Fselected_window, select_window, Fselect_window): Move up in
5026 code. Minor doc-string fixes.
5028 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5030 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5031 Do not assume that spare memory exists; that assumption is valid
5032 only if SYSTEM_MALLOC.
5033 (LARGE_REQUEST): New macro, so that the issue of large requests
5034 is separated from the issue of spare memory.
5036 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5038 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5041 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5043 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5046 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5048 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5050 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5052 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5053 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5055 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5057 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5059 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5061 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5062 (x_clipboard_manager_save): Add return value.
5063 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5065 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5066 Obey Vx_select_enable_clipboard_manager. Catch errors in
5067 x_clipboard_manager_save (Bug#8779).
5068 (Vx_select_enable_clipboard_manager): New variable.
5069 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5071 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5073 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5075 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5077 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5078 in the current matrix if keep_current_p is non-zero.
5080 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5082 * bidi.c (bidi_level_of_next_char): Fix last change.
5084 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5086 Support bidi reordering of text covered by display properties.
5088 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5089 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5090 (bidi_cache_search, bidi_cache_iterator_state)
5091 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5092 (bidi_level_of_next_char, bidi_move_to_visually_next):
5093 Support character positions inside a run of characters covered by a
5095 (bidi_paragraph_init, bidi_resolve_explicit_1)
5096 (bidi_level_of_next_char): Call bidi_fetch_char and
5097 bidi_fetch_char_advance instead of FETCH_CHAR and
5099 (bidi_init_it): Initialize new members.
5100 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5102 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5103 instead of using explicit *_CHAR codes.
5104 (bidi_resolve_explicit, bidi_resolve_weak):
5105 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5106 bidirectional text is supported only in multibyte buffers.
5107 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5108 it to initialize the frame_window_p member of struct bidi_it.
5109 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5110 (bidi_resolve_explicit, bidi_resolve_weak)
5111 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5112 bidi_it->nchars is non-positive.
5113 (bidi_level_of_next_char): Don't try to lookup the cache for the
5114 next/previous character if nothing is cached there yet, or if we
5115 were just reseat()'ed to a new position.
5117 * xdisp.c (set_cursor_from_row): Set start and stop points
5118 according to the row's direction when priming the loop that looks
5119 for the glyph on which to display cursor.
5120 (single_display_spec_intangible_p): Function deleted.
5121 (display_prop_intangible_p): Reimplement to call
5122 handle_display_spec instead of single_display_spec_intangible_p.
5123 Accept 3 additional arguments needed by handle_display_spec.
5124 This fixes incorrect cursor motion across display property with complex
5125 values: lists, `(when COND...)' forms, etc.
5126 (single_display_spec_string_p): Support property values that are
5127 lists with the argument STRING its top-level element.
5128 (display_prop_string_p): Fix the condition for processing a
5129 property that is a list to be consistent with handle_display_spec.
5130 (handle_display_spec): New function, refactored from the
5131 last portion of handle_display_prop.
5132 (compute_display_string_pos): Accept additional argument
5133 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5134 value of a `display' property is a "replacing spec".
5135 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5136 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5137 the display property, but just return a value indicating whether
5138 the display property will replace the characters it covers.
5139 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5140 frame_window_p members of struct bidi_it.
5141 (compute_display_string_pos, compute_display_string_end):
5143 (push_it): Accept second argument POSITION, where pop_it should
5144 jump to continue iteration.
5145 (reseat_1): Initialize bidi_it.disp_pos.
5147 * keyboard.c (adjust_point_for_property): Adjust the call to
5148 display_prop_intangible_p to its new signature.
5150 * dispextern.h (struct bidi_it): New member frame_window_p.
5151 (bidi_init_it): Update prototypes.
5152 (display_prop_intangible_p): Update prototype.
5153 (compute_display_string_pos, compute_display_string_end):
5155 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5158 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5160 Malloc failure behavior now depends on size of allocation.
5161 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5162 * lisp.h: Change signatures accordingly.
5163 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5164 All callers changed. (Bug#8762)
5166 * gnutls.c: Use Emacs's memory allocators.
5167 Without this change, the gnutls library would invoke malloc etc.
5168 directly, which causes problems on non-SYNC_INPUT hosts, and which
5169 runs afoul of improving memory_full behavior. (Bug#8761)
5170 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5171 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5172 xfree instead of the default malloc, realloc, free.
5173 (Fgnutls_boot): No need to check for memory allocation failure,
5174 since xmalloc does that for us.
5176 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5177 * category.c (hash_get_category_set):
5178 * ccl.c (ccl_driver):
5179 * charset.c (Fdefine_charset_internal):
5180 * charset.h (struct charset.hash_index):
5181 * composite.c (get_composition_id, gstring_lookup_cache)
5182 (composition_gstring_put_cache):
5183 * composite.h (struct composition.hash_index):
5184 * dispextern.h (struct image.hash):
5185 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5186 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5187 (hashfn_equal, hashfn_user_defined, make_hash_table)
5188 (maybe_resize_hash_table, hash_lookup, hash_put)
5189 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5190 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5191 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5192 * image.c (make_image, search_image_cache, lookup_image)
5193 (xpm_put_color_table_h):
5194 * lisp.h (struct Lisp_Hash_Table):
5195 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5196 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5197 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5198 * alloc.c (allocate_vectorlike):
5199 Check for overflow in vector size calculations.
5200 * ccl.c (ccl_driver):
5201 Check for overflow when converting EMACS_INT to int.
5202 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5203 need to be updated by these changes.
5204 * fns.c (make_hash_table, maybe_resize_hash_table):
5205 Check for integer overflow with large hash tables.
5206 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5207 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5208 (SXHASH_REDUCE): New macro.
5209 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5210 Use it instead of discarding useful hash info with large hash values.
5211 (sxhash_float): New function.
5212 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5213 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5214 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5215 Rewrite to use FIXNUM_BITS, as this simplifies things.
5216 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5217 Adjust signatures to match updated version of code.
5218 (consing_since_gc): Now EMACS_INT, since a single hash table can
5219 use more than INT_MAX bytes.
5221 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5223 Make it possible to build with GCC-4.6+ -O2 -flto.
5225 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5227 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5229 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5230 Call minibuffer-inactive-mode.
5232 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5234 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5235 Update dependencies.
5237 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5239 * data.c (init_data): Remove code for UTS, this system is not
5242 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5244 Don't force ./temacs to start in terminal mode.
5246 * frame.c (make_initial_frame): Initialize faces in all cases, not
5247 only when CANNOT_DUMP is defined.
5248 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5250 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5252 * dispnew.c (add_window_display_history): Use const for the string
5253 pointer. Remove declaration, not needed.
5255 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5257 Use 'inline', not 'INLINE'.
5258 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5259 * alloc.c, fontset.c (INLINE): Remove.
5260 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5261 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5262 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5263 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5264 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5266 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5268 Make it possible to run ./temacs.
5270 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5271 syms_of_callproc does the same thing. Remove test for
5272 "initialized", do it in the caller.
5273 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5275 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5277 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5278 (read_minibuf): Use get_minibuffer.
5279 (syms_of_minibuf): Use DEFSYM.
5280 (Qmetadata): New var.
5281 * data.c (Qbuffer): Don't make it static.
5282 (syms_of_data): Use DEFSYM.
5284 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5286 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5287 (CCL_CODE_MIN): New macro.
5289 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5291 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5293 * eval.c (Qdebug): Now static.
5294 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5295 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5296 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5298 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5300 * image.c: Various fixes to ImageMagick code comments.
5301 (Fimagemagick_types): Doc fix.
5303 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5305 Minor fixes prompted by GCC 4.6.0 warnings.
5307 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5309 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5310 (x_clipboard_manager_save_all): Move extern decl to ...
5311 * xterm.h: ... here, so that it can be checked for consistency.
5313 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5315 * xselect.c (x_clipboard_manager_save_frame)
5316 (x_clipboard_manager_save_all): New functions.
5317 (Fx_clipboard_manager_save): Lisp function deleted.
5319 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5320 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5322 * xterm.h: Update prototype.
5324 2011-05-28 William Xu <william.xwl@gmail.com>
5326 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5329 2011-05-28 Jim Meyering <meyering@redhat.com>
5331 Avoid a sign-extension bug in crypto_hash_function.
5332 * fns.c (to_uchar): Define.
5333 (crypto_hash_function): Use it to convert some newly-signed
5334 variables to unsigned, to avoid sign-extension bugs. For example,
5335 without this change, (md5 "truc") would evaluate to
5336 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5337 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5338 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5340 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5342 Integer overflow fixes.
5344 * dbusbind.c: Serial number integer overflow fixes.
5345 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5346 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5347 to hold a serial number that is too large for a fixnum.
5348 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5349 Check for serial numbers out of range. Decode any serial number
5350 that was so large that it became a float. (Bug#8722)
5352 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5353 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5354 Use XFASTINT rather than XUINT when numbers are nonnegative.
5355 (xd_append_arg, Fdbus_method_return_internal):
5356 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5357 arguments, check that Lisp number is nonnegative, rather than
5358 silently wrapping negative numbers around. (Bug#8722)
5359 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5362 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5364 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5366 ccl: add integer overflow checks
5367 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5368 (IN_INT_RANGE): New macros.
5369 (ccl_driver): Use them to check for integer overflow when
5370 decoding a CCL program. Many of the new checks are whether XINT (x)
5371 fits in int; it doesn't always, on 64-bit hosts. The new version
5372 doesn't catch all possible integer overflows, but it's an
5373 improvement. (Bug#8719)
5375 * alloc.c (make_event_array): Use XINT, not XUINT.
5376 There's no need for unsigned here.
5378 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5379 This follows up to the 2011-05-06 change that substituted uintptr_t
5380 for EMACS_INT. This case wasn't caught back then.
5382 Rework Fformat to avoid integer overflow issues.
5383 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5384 now (part of C89). Include <verify.h>.
5385 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5386 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5387 (Fformat): Avoid the prepass trying to compute sizes; it was only
5388 approximate and thus did not catch overflow reliably. Instead, walk
5389 through the format just once, formatting and computing sizes as we go,
5390 checking for integer overflow at every step, and allocating a larger
5391 buffer as needed. Keep track separately whether the format is
5392 multibyte. Keep only the most-recently calculated precision, rather
5393 than them all. Record whether each argument has been converted to
5394 string. Use EMACS_INT, not int, for byte and char and arg counts.
5395 Support field widths and precisions larger than INT_MAX. Avoid
5396 sprintf's undefined behavior with conversion specifications such as %#d
5397 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5398 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5399 formatting out-of-range floating point numbers with int
5402 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5404 * data.c: Avoid integer truncation in expressions involving floats.
5405 * data.c: Include <intprops.h>.
5406 (arith_driver): When there's an integer overflow in an expression
5407 involving floating point, convert the integers to floating point
5408 so that the resulting value does not suffer from catastrophic
5409 integer truncation. For example, on a 64-bit host (* 4
5410 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5411 Do not rely on undefined behavior after integer overflow.
5413 merge count_size_as_multibyte, parse_str_to_multibyte
5414 * character.c, character.h (count_size_as_multibyte):
5415 Rename from parse_str_to_multibyte; all uses changed.
5416 Check for integer overflow.
5417 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5418 since it's now a duplicate of the other. This is more of
5419 a character than a buffer op, so better that it's in character.c.
5420 * fns.c, print.c: Adjust to above changes.
5422 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5424 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5426 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5428 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5429 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5430 (x_clipboard_manager_save): Now static.
5431 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5433 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5434 (crypto_hash_function): Now static.
5435 Fix pointer signedness problems. Avoid unnecessary initializations.
5437 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5439 * termhooks.h (Vselection_alist): Make it terminal-local.
5441 * terminal.c (create_terminal): Initialize it.
5443 * xselect.c: Support for clipboard managers.
5444 (Vselection_alist): Move to termhooks.h as terminal-local var.
5445 (LOCAL_SELECTION): New macro.
5446 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5447 (symbol_to_x_atom): Remove gratuitous arg.
5448 (x_handle_selection_request, lisp_data_to_selection_data)
5449 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5450 (x_own_selection, x_get_local_selection, x_convert_selection):
5451 New arg, specifying work frame. Use terminal-local Vselection_alist.
5452 (some_frame_on_display): Delete unused function.
5453 (Fx_own_selection_internal, Fx_get_selection_internal)
5454 (Fx_disown_selection_internal, Fx_selection_owner_p)
5455 (Fx_selection_exists_p): New optional frame arg.
5456 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5457 (x_handle_selection_clear): Don't treat other terminals with the
5458 same keyboard specially. Use the terminal-local Vselection_alist.
5459 (x_clear_frame_selections): Use Frun_hook_with_args.
5461 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5463 * xterm.h: Add support for those atoms.
5465 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5467 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5468 (converted_selections, conversion_fail_tag): New global variables.
5469 (x_selection_request_lisp_error): Free the above.
5470 (x_get_local_selection): Remove unnecessary code.
5471 (x_reply_selection_request): Args changed; handle arbitrary array
5472 of converted selections stored in converted_selections.
5473 Separate the XChangeProperty and SelectionNotify steps.
5474 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5475 (x_convert_selection): New function.
5476 (x_handle_selection_event): Simplify.
5477 (x_get_foreign_selection): Don't ignore incoming requests while
5478 waiting for an answer; this will fail when we implement
5479 SAVE_TARGETS, and seems unnecessary anyway.
5480 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5481 (Vx_sent_selection_functions): Doc fix.
5483 2011-05-26 Leo Liu <sdl.web@gmail.com>
5485 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5487 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5489 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5491 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5492 for fringe update if it has periodic bitmap.
5493 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5494 and fringe_bitmap_periodic_p.
5496 * fringe.c (get_fringe_bitmap_data): New function.
5497 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5498 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5499 row. Mark glyph row for fringe update if periodicity changed.
5501 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5502 for fringe update unless it has periodic bitmap.
5504 2011-05-25 Kenichi Handa <handa@m17n.org>
5506 * xdisp.c (get_next_display_element): Set correct it->face_id for
5507 a static composition.
5509 2011-05-24 Leo Liu <sdl.web@gmail.com>
5512 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5514 * fns.c (crypto_hash_function, Fsha1): New function.
5515 (Fmd5): Use crypto_hash_function.
5516 (syms_of_fns): Add Ssha1.
5518 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5520 * gnutls.c: Remove unused macros.
5521 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5522 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5523 Remove macros that are defined and never used.
5524 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5526 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5528 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5529 (Fx_get_selection_internal): Minor cleanup.
5530 (Fx_own_selection_internal): Rename arguments for consistency with
5533 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5535 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5537 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5539 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5541 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5543 * dispnew.c (scrolling_window): Don't exclude the case that the
5544 last enabled row in the desired matrix touches the bottom boundary.
5546 2011-05-21 Glenn Morris <rgm@gnu.org>
5548 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5549 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5550 and add some more files.
5552 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5554 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5555 report_file_error introduced by the change from 2011-05-07.
5557 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5559 * systime.h (Time): Define only if emacs is defined.
5560 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5561 where the include path doesn't have X11/X.h by default. See
5562 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5564 2011-05-20 Kenichi Handa <handa@m17n.org>
5566 * composite.c (find_automatic_composition): Fix previous change.
5568 2011-05-20 Glenn Morris <rgm@gnu.org>
5570 * lisp.mk: New file, split from Makefile.in.
5571 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5572 (shortlisp): Remove.
5573 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5575 2011-05-19 Glenn Morris <rgm@gnu.org>
5577 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5578 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5579 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5580 (lisp): Set the order to that of loadup.el.
5581 (shortlisp): Make it a copy of $lisp.
5582 (SOME_MACHINE_LISP): Remove.
5583 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5584 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5586 2011-05-18 Kenichi Handa <handa@m17n.org>
5588 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5589 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5590 (find_automatic_composition): Mostly rewrite for efficiency.
5592 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5594 * makefile.w32-in: Update dependencies.
5596 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5598 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5599 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5601 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5603 Fix some integer overflow issues, such as string length overflow.
5605 * insdel.c (count_size_as_multibyte): Check for string overflow.
5607 * character.c (lisp_string_width): Check for string overflow.
5608 Use EMACS_INT, not int, for string indexes and lengths; in
5609 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5610 the resulting string length overflows an EMACS_INT; instead,
5611 report a string overflow if no precision given. When checking for
5612 precision exhaustion, use a check that cannot possibly have
5613 integer overflow. (Bug#8675)
5614 * character.h (lisp_string_width): Adjust to new signature.
5616 * alloc.c (string_overflow): New function.
5617 (Fmake_string): Use it. This doesn't change behavior, but saves
5618 a few bytes and will simplify future changes.
5619 * character.c (string_escape_byte8): Likewise.
5620 * lisp.h (string_overflow): New decl.
5622 Fixups, following up to the user-interface timestamp change.
5623 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5624 for UI timestamps, instead of unsigned long.
5625 * msdos.c (mouse_get_pos): Likewise.
5626 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5627 * w32gui.h (Time): Define by including "systime.h" rather than by
5628 declaring it ourselves. (Bug#8664)
5630 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5631 * image.c (clear_image_cache): Likewise.
5633 * term.c (term_mouse_position): Don't assume time_t wraparound.
5635 Be more systematic about user-interface timestamps.
5636 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5637 and sometimes 'EMACS_UINT', to represent these timestamps.
5638 This change causes it to use 'Time' uniformly, as that's what X uses.
5639 This makes the code easier to follow, and makes it easier to catch
5640 integer overflow bugs such as Bug#8664.
5641 * frame.c (Fmouse_position, Fmouse_pixel_position):
5642 Use Time, not unsigned long, for user-interface timestamps.
5643 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5644 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5645 * keyboard.h (last_event_timestamp): Likewise.
5646 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5647 * menu.h (xmenu_show): Likewise.
5648 * term.c (term_mouse_position): Likewise.
5649 * termhooks.h (struct input_event.timestamp): Likewise.
5650 (struct terminal.mouse_position_hook): Likewise.
5651 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5652 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5653 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5654 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5656 * menu.h, termhooks.h: Include "systime.h", for Time.
5658 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5659 Don't assume that the difference between two unsigned long values
5660 can fit into an integer. At this point, we know button_down_time
5661 <= event->timestamp, so the difference must be nonnegative, so
5662 there's no need to cast the result if double-click-time is
5663 nonnegative, as it should be; check that it's nonnegative, just in
5664 case. This bug is triggered when events are more than 2**31 ms
5665 apart (about 25 days). (Bug#8664)
5667 * xselect.c (last_event_timestamp): Remove duplicate decl.
5668 (x_own_selection): Remove needless cast to unsigned long.
5670 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5671 that always fit in int. Use a sentinel instead of a counter, to
5672 avoid a temp and to allay GCC's concerns about possible int overflow.
5673 * frame.h (struct frame): Use int for menu_bar_items_used
5674 instead of EMACS_INT, since it always fits in int.
5676 * menu.c (grow_menu_items): Check for int overflow.
5678 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5680 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5681 Before, the code was not consistent. These values cannot exceed
5682 2**31 - 1 so there's no need to make them unsigned.
5683 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5684 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5685 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5687 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5689 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5690 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5691 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5692 presumably because the widths might not match.
5694 * window.c (size_window): Avoid needless test at loop start.
5696 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5698 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5700 2011-05-12 Drew Adams <drew.adams@oracle.com>
5702 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5704 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5706 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5707 `width' to `bar_area_x' and `bar_area_width', respectively.
5708 (x_scroll_run): Take account of fringe background extension.
5710 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5711 Rename local vars `left' and `width' to `bar_area_x' and
5712 `bar_area_width', respectively.
5713 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5714 background extension.
5716 2011-05-10 Jim Meyering <meyering@redhat.com>
5718 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5720 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5722 * image.c (Finit_image_library): Return t for built-in image types,
5723 like pbm and xbm. (Bug#8640)
5725 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5727 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5729 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5731 * w32console.c (Fset_screen_color): Doc fix.
5732 (Fget_screen_color): New function.
5733 (syms_of_ntterm): Defsubr it.
5735 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5736 unlink the temporary file if Fcall_process didn't create it in the
5738 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5739 child process will be redirected to a file specified with `:file'.
5740 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5741 cue to call_process_cleanup not to close that handle.
5743 2011-05-07 Ben Key <bkey76@gmail.com>
5745 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5746 one of two shell specific rules, either bootstrap-temacs-CMD or
5747 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5748 to the previous implementation of the bootstrap-temacs rule.
5749 The bootstrap-temacs-CMD rule is similar to the previous
5750 implementation of the bootstrap-temacs rule except that it
5751 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5754 These changes, along with some changes to nt/configure.bat,
5755 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5756 earlier fix to add support for --cflags and --ldflags options
5757 that include quotes so that it works whether make uses cmd or
5760 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5762 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5763 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5765 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5766 a string. Handle both cases.
5767 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5768 (Fdbus_register_method): Use Qinvalid_function.
5770 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5772 * makefile.w32-in: Update dependencies.
5773 (LISP_H): Add inttypes.h and stdin.h.
5774 (PROCESS_H): Add unistd.h.
5776 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5778 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5779 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5781 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5783 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5785 * term.c (vfatal): Remove stray call to va_end.
5786 It's not needed and the C Standard doesn't allow it here anyway.
5788 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5789 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5791 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5794 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5796 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5798 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5800 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5802 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5804 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5805 * charset.c (Fdefine_charset_internal): Don't initialize
5806 charset.code_space[15]. The value was garbage, on hosts with
5807 32-bit int (Bug#8600).
5809 * lread.c (read_integer): Be more consistent with string-to-number.
5810 Use string_to_number to do the actual conversion; this avoids
5811 rounding errors and fixes some other screwups. Without this fix,
5812 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5813 (digit_to_number): Move earlier, for benefit of read_integer.
5814 Return -1 if the digit is out of range for the base, -2 if it is
5815 not a digit in any supported base. (Bug#8602)
5817 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5819 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5820 to match comment at start of function. This also removes a
5821 GCC warning about overflow in a 32+64-bit port.
5823 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5825 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5826 Reported by Stefan Monnier in
5827 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5828 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5829 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5831 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5832 (EMACS_UINTPTR): Likewise, with uintptr_t.
5834 * lisp.h: Prefer 64-bit EMACS_INT if available.
5835 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5836 on 32-bit hosts that have 64-bit int, so that they can access
5838 However, temporarily disable this change unless the temporary
5839 symbol WIDE_EMACS_INT is defined.
5841 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5843 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5844 This removes an assumption that EMACS_INT and long are the same
5845 width as pointers. The assumption is true for Emacs porting targets
5846 now, but we want to make other targets possible.
5847 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5848 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5849 In the rest of the code, change types of integers that hold casted
5850 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5851 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5852 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5853 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5854 No need to cast type when ORing.
5855 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5856 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5857 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5858 assume EMACS_INT is the same width as char *.
5859 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5860 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5861 Remove no-longer-needed casts.
5862 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5863 (xg_tool_bar_help_callback, xg_make_tool_item):
5864 Use EMACS_INTPTR to hold an integer
5865 that will be cast to void *; this can avoid a GCC warning
5866 if EMACS_INT is not the same width as void *.
5867 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5868 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5869 (current_message_1, set_message_1):
5870 Use a local to convert to proper width without a cast.
5871 * xmenu.c (dialog_selection_callback): Likewise.
5873 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5874 Also, don't assume VALBITS / RAND_BITS is less than 5,
5875 and don't rely on undefined behavior when shifting a 1 left into
5877 * lisp.h (get_random): Change signature to match.
5879 * lread.c (hash_string): Use size_t, not int, for hash computation.
5880 Normally we prefer signed values; but hashing is special, because
5881 it's better to use unsigned division on hash table sizes so that
5882 the remainder is nonnegative. Also, size_t is the natural width
5883 for hashing into memory. The previous code used 'int', which doesn't
5884 retain enough info to hash well into very large tables.
5885 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5887 * dbusbind.c: Don't possibly lose pointer info when converting.
5888 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5889 Use XPNTR rather than XHASH, so that the high-order bits of
5890 the pointer aren't lost when converting through void *.
5892 * eval.c (Fautoload): Don't double-shift a pointer.
5894 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5896 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5898 * gnutls.c (DEF_GNUTLS_FN):
5899 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5901 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5903 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5906 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5908 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5909 New version that can reserve upto 2GB of heap space.
5911 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5913 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5915 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5917 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5918 `gnutls_certificate_set_x509_key_file'.
5920 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5922 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5923 Update dependencies.
5925 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5927 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5928 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5929 Remove unused parameter `fildes'.
5930 * process.c (read_process_output, send_process): Don't pass it.
5932 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5934 Fix previous change: the library cache is defined in w32.c.
5935 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5936 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5938 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5940 Implement dynamic loading of GnuTLS on Windows.
5942 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5943 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5944 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5947 * gnutls.c (Qgnutls_dll): Define.
5948 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5949 (gnutls_*): Declare function pointers.
5950 (init_gnutls_functions): New function to initialize function pointers.
5951 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5952 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5953 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5954 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5955 (emacs_gnutls_write, emacs_gnutls_read)
5956 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5957 (Fgnutls_available_p): New function.
5958 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5959 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5960 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5962 * image.c: Include w32.h.
5963 (Vimage_type_cache): Delete.
5964 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5965 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5966 (w32_delayed_load): Move to w32.c.
5968 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5970 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5971 (w32_delayed_load): Move from image.c. When loading a library, record
5972 its filename in the :loaded-from property of the library id.
5973 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5974 Initialize and staticpro them.
5975 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5977 * process.c: Include lisp.h before w32.h, not after.
5978 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5979 instead of gnutls_record_check_pending.
5981 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5983 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5985 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5986 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5989 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5991 * xterm.c (x_set_frame_alpha): Do not set property on anything
5992 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5994 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5996 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5998 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6000 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6001 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6002 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6003 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6004 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6005 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6006 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6007 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6008 (Qgnutls_bootprop_callbacks_verify): Make static.
6010 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6012 * callproc.c: Indentation fixup.
6014 * sysdep.c (wait_for_termination_1): Make static.
6015 (wait_for_termination, interruptible_wait_for_termination):
6016 Move after wait_for_termination_1.
6018 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6020 * sysdep.c (interruptible_wait_for_termination): New function
6021 which is like wait_for_termination, but allows keyboard
6024 * callproc.c (Fcall_process): Add (:file "file") as an option for
6026 (Fcall_process_region): Ditto.
6028 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6030 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6031 rather than `XVECTOR (FOO)->size'.
6033 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6034 inttypes.h, as a gnulib replacement is used if it not available in
6037 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6039 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6040 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6041 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6043 * coding.c (coding_alloc_by_realloc): Error out if destination
6044 will grow beyond MOST_POSITIVE_FIXNUM.
6045 (decode_coding_emacs_mule): Abort if there isn't enough place in
6046 charbuf for the composition carryover bytes. Reserve an extra
6047 space for up to 2 characters produced in a loop.
6048 (decode_coding_iso_2022): Abort if there isn't enough place in
6049 charbuf for the composition carryover bytes.
6051 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6053 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6054 aborting when %lld or %lll format is passed.
6055 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6056 %llo or %llx format is passed. (Bug#8545)
6058 * window.c (window_scroll_line_based): Use a marker instead of
6059 simple variables to record original value of point. (Bug#7952)
6061 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6062 produced by %s or %c overflows available buffer space. (Bug#8545)
6064 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6066 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6067 (SIZE_MAX): Move defn after all includes, as they might #define it.
6069 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6071 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6073 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6075 * keyboard.c (Qdelayed_warnings_hook): Define.
6076 (command_loop_1): Run `delayed-warnings-hook'
6077 if Vdelayed_warnings_list is non-nil.
6078 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6079 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6081 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6083 * doprnt.c (doprnt): Don't return value smaller than the buffer
6084 size if the message was truncated. (Bug#8545).
6086 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6088 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6089 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6091 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6093 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6095 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6097 * makefile.w32-in: Update dependencies.
6099 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6101 Improve `doprnt' and its usage. (Bug#8545)
6102 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6103 `format_end'. Remove support for %l as a conversion specifier.
6104 Don't use xrealloc. Improve diagnostics when the %l size modifier
6105 is used. Update the commentary.
6107 * eval.c (verror): Simplify calculation of size_t.
6109 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6112 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6114 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6117 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6119 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6120 This makes this file independent of the recent pseudovector change.
6122 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6124 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6126 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6127 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6128 Remove unused local.
6129 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6131 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6132 GCC 4.6.0 optimizes based on type-based alias analysis.
6133 For example, if b is of type struct buffer * and v of type struct
6134 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6135 != &v->size, and therefore "v->size = 1; b->size = 2; return
6136 v->size;" must therefore return 1. This assumption is incorrect
6137 for Emacs, since it type-puns struct Lisp_Vector * with many other
6138 types. To fix this problem, this patch adds a new type struct
6139 vectorlike_header that documents the constraints on layout of vectors
6140 and pseudovectors, and helps optimizing compilers not get fooled
6141 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6142 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6143 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6145 (XSETPVECTYPE): Rewrite in terms of new macro.
6146 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6147 This is a bit clearer, and further avoids the possibility of
6148 undesirable aliasing.
6149 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6150 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6151 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6152 since Lisp_Subr is a special case (no "next" field).
6153 (ASIZE): Now uses header.size rather than size.
6154 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6155 to avoid the hassle of writing XVECTOR (foo)->header.size.
6156 (struct vectorlike_header): New type.
6157 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6158 object, to help avoid aliasing.
6159 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6160 (SUBRP): Likewise, since Lisp_Subr is a special case.
6161 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6162 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6163 (struct Lisp_Hash_Table): Combine first two members into a single
6164 struct vectorlike_header member. All uses of "size" and "next" members
6165 changed to be "header.size" and "header.next".
6166 * buffer.h (struct buffer): Likewise.
6167 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6168 * frame.h (struct frame): Likewise.
6169 * process.h (struct Lisp_Process): Likewise.
6170 * termhooks.h (struct terminal): Likewise.
6171 * window.c (struct save_window_data, struct saved_window): Likewise.
6172 * window.h (struct window): Likewise.
6173 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6174 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6175 * buffer.c (init_buffer_once): Likewise.
6176 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6178 * process.c (Fformat_network_address): Use local var for size,
6181 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6183 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6184 * data.c (atof): Remove decl; no longer used or needed.
6185 (digit_to_number): Move to lread.c.
6186 (Fstring_to_number): Use new string_to_number function, to be
6187 consistent with how the Lisp reader treats infinities and NaNs.
6188 Do not assume that floating-point numbers represent EMACS_INT
6189 without losing information; this is not true on most 64-bit hosts.
6190 Avoid double-rounding errors, by insisting on integers when
6191 parsing non-base-10 numbers, as the documentation specifies.
6192 * lisp.h (string_to_number): New decl, replacing ...
6193 (isfloat_string): Remove.
6194 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6195 (read1): Do not accept +. and -. as integers; this
6196 appears to have been a coding error. Similarly, do not accept
6197 strings like +-1e0 as floating point numbers. Do not report
6198 overflow for integer overflows unless the base is not 10 which
6199 means we have no simple and reliable way to continue.
6200 Break out the floating-point parsing into a new
6201 function string_to_number, so that Fstring_to_number parses
6202 floating point numbers consistently with the Lisp reader.
6203 (digit_to_number): Move here from data.c. Make it static inline.
6204 (E_CHAR, EXP_INT): Remove, replacing with ...
6205 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6206 (string_to_number): New function, replacing isfloat_string.
6207 This function checks for valid syntax and produces the resulting
6208 Lisp float number too. Rework it so that string-to-number
6209 no longer mishandles examples like "1.0e+". Use strtoumax,
6210 so that overflow for non-base-10 numbers is reported only when
6211 there's no portable and simple way to convert to floating point.
6213 * textprop.c (set_text_properties_1): Rewrite for clarity,
6214 and to avoid GCC warning about integer overflow.
6216 * intervals.h (struct interval): Use EMACS_INT for members
6217 where EMACS_UINT might cause problems. See
6218 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6219 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6220 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6222 (offset_intervals): Tell GCC not to worry about length overflow
6223 when negating a negative length.
6225 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6226 (overrun_check_free): Likewise.
6228 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6229 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6232 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6233 (gnutls_make_error): Rename local to avoid shadowing.
6234 (gnutls_emacs_global_deinit): ifdef out; not used.
6235 (Fgnutls_boot): Use const for pointer to readonly storage.
6236 Comment out unused local. Fix pointer signedness problems.
6238 * lread.c (openp): Don't stuff size_t into an 'int'.
6239 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6240 about possible signed overflow.
6242 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6243 (GDK_KEY_g): Don't define if already defined.
6244 (xg_prepare_tooltip): Avoid pointer signedness problem.
6245 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6247 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6248 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6250 * xfns.c (Fx_window_property): Simplify a bit,
6251 to make a bit faster and to avoid GCC 4.6.0 warning.
6252 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6254 * fns.c (internal_equal): Don't assume size_t fits in int.
6256 * alloc.c (compact_small_strings): Tighten assertion a little.
6258 Replace pEd with more-general pI, and fix some printf arg casts.
6259 * lisp.h (pI): New macro, generalizing old pEd macro to other
6260 conversion specifiers. For example, use "...%"pI"d..." rather
6261 than "...%"pEd"...".
6262 (pEd): Remove. All uses replaced with similar uses of pI.
6263 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6264 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6265 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6266 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6267 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6268 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6269 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6271 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6272 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6273 * print.c (safe_debug_print, print_object): Likewise.
6274 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6276 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6277 avoiding the 0 flag, which is not portable.
6278 * process.c (Fmake_network_process): Use pI to avoid cast.
6279 * region-cache.c (pp_cache): Likewise.
6280 * xdisp.c (decode_mode_spec): Likewise.
6281 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6282 behavior on 64-bit hosts with printf arg.
6283 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6284 (x_stop_queuing_selection_requests): Likewise.
6285 (x_get_window_property): Don't truncate byte count to an 'int'
6288 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6289 here, since it parses constructs like leading '-' and spaces,
6290 which are not wanted; and it overflows with large numbers.
6291 Instead, simply match F[0-9]+, which is what is wanted anyway.
6293 * alloc.c: Remove unportable assumptions about struct layout.
6294 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6295 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6296 (allocate_vectorlike, make_pure_vector): Use the new macros,
6297 plus offsetof, to remove unportable assumptions about struct layout.
6298 These assumptions hold on all porting targets that I know of, but
6299 they are not guaranteed, they're easy to remove, and removing them
6300 makes further changes easier.
6302 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6303 This doesn't fix a bug but makes the code clearer.
6304 (string_overrun_cookie): Now const. Use initializers that
6305 don't formally overflow signed char, to avoid warnings.
6306 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6307 can cause Emacs to crash when string overrun checking is enabled.
6308 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6309 multiple of sizeof (EMACS_INT); it need not be, if
6310 alignof(EMACS_INT) < sizeof (EMACS_INT).
6311 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6313 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6315 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6317 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6319 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6320 supposed to be handshaking. (Bug#8556)
6321 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6323 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6325 * lisp.h (Qdebug): List symbol.
6326 * eval.c (Qdebug): Restore global linkage.
6327 * keyboard.c (debug-on-event): New variable.
6328 (handle_user_signal): Break into debugger when debug-on-event
6329 matches the current signal symbol.
6331 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6333 * alloc.c (check_sblock, check_string_bytes)
6334 (check_string_free_list): Convert to standard C.
6336 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6338 * w32.c (emacs_gnutls_push): Fix typo.
6340 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6342 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6343 "cast to pointer from integer of different size".
6345 Improve doprnt and its use in verror. (Bug#8545)
6346 * doprnt.c (doprnt): Document the set of format control sequences
6347 supported by the function. Use SAFE_ALLOCA instead of always
6350 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6351 is one byte too soon. Don't use xrealloc; instead xfree and
6354 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6356 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6359 * gnutls.c: Renamed global_initialized to
6360 gnutls_global_initialized. Added internals for the
6361 :verify-hostname-error, :verify-error, and :verify-flags
6362 parameters of `gnutls-boot' and documented those parameters in the
6363 docstring. Start callback support.
6364 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6365 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6366 on error. Return error code.
6367 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6368 (emacs_gnutls_read): Likewise.
6369 (Fgnutls_boot): Return handshake error code.
6370 (emacs_gnutls_handle_error): New function.
6371 (wsaerror_to_errno): Likewise.
6373 * w32.h (emacs_gnutls_pull): Add prototype.
6374 (emacs_gnutls_push): Likewise.
6376 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6377 (emacs_gnutls_push): Likewise.
6379 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6381 * process.c (wait_reading_process_output): Check if GnuTLS
6382 buffered some data internally if no FDs are set for TLS
6385 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6386 (LIBS): Link to USER_LIBS.
6387 ($(BLD)/gnutls.$(0)): New target.
6389 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6391 * xdisp.c (handle_single_display_spec): Rename the
6392 display_replaced_before_p argument into display_replaced_p, to
6393 make it consistent with the commentary. Fix typos in the
6396 * textprop.c (syms_of_textprop): Remove dead code.
6397 (copy_text_properties): Delete obsolete commentary about an
6398 interface that was deleted long ago. Fix typos in the description
6401 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6402 to changes in oldXMenu/XMenu.h from 2011-04-16.
6403 <menu_help_message, prev_menu_help_message>: Constify.
6404 (IT_menu_make_room): menu->help_text is now `const char **';
6407 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6408 to changes in oldXMenu/XMenu.h from 2011-04-16.
6409 (struct XMenu): Declare `help_text' `const char **'.
6411 * xfaces.c <Qunspecified>: Make extern again.
6413 * syntax.c: Include sys/types.h before including regex.h, as
6416 * doc.c (get_doc_string): Improve the format passed to `error'.
6418 * doprnt.c (doprnt): Improve commentary.
6420 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6422 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6425 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6426 changes in globals.h immediately force recompilation.
6427 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6428 $(CURDIR)/s/ms-w32.h.
6429 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6431 * character.c (Fchar_direction): Function deleted.
6432 (syms_of_character): Don't defsubr it.
6433 <char-direction-table>: Deleted.
6435 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6437 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6438 * doprnt.c: Include limits.h.
6439 (SIZE_MAX): New macro.
6440 (doprnt): Return a size_t value. 2nd arg is now size_t.
6441 Many local variables are now size_t instead of int or unsigned.
6442 Improve overflow protection. Support `l' modifier for integer
6443 conversions. Support %l conversion. Don't assume an EMACS_INT
6444 argument for integer conversions and for %c.
6446 * lisp.h (doprnt): Restore prototype.
6448 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6451 * Makefile.in (base_obj): Add back doprnt.o.
6453 * deps.mk (doprnt.o): Add back prerequisites.
6454 (callint.o): Depend on character.h.
6456 * eval.c (internal_lisp_condition_case): Include the handler
6457 representation in the error message.
6458 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6459 when breaking from the loop.
6461 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6463 * callint.c (Fcall_interactively): When displaying error message
6464 about invalid control letter, pass the character's codepoint, not
6465 a pointer to its multibyte form. Improve display of the character
6466 in octal and display also its hex code.
6468 * character.c (char_string): Use %x to display the (unsigned)
6469 codepoint of an invalid character, to avoid displaying a bogus
6472 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6473 `error', not SYMBOL_NAME itself.
6475 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6476 character arguments to `error'.
6478 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6479 to `error' in error message about FINAL_CHAR argument. Make sure
6480 FINAL_CHAR is a character, and use %c when it is passed as
6481 argument to `error'.
6483 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6485 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6487 * w32.c: Include <time.h>.
6488 (sys_localtime): New function.
6490 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6492 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6494 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6496 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6498 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6501 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6503 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6504 gl_state.e_property when gl_state.object is Qt.
6506 * insdel.c (make_gap_larger): Remove limitation of buffer size
6509 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6511 * xdisp.c (lookup_glyphless_char_display)
6512 (produce_glyphless_glyph): Handle cons cell entry in
6513 glyphless-char-display.
6514 (Vglyphless_char_display): Document it.
6516 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6517 glyphless-char-display.
6519 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6521 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6523 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6525 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6526 definition for no-X builds.
6528 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6530 Static checks with GCC 4.6.0 and non-default toolkits.
6532 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6534 * process.c (keyboard_bit_set): Define only if SIGIO.
6535 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6536 (send_process): Repair possible setjmp clobbering.
6538 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6540 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6542 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6544 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6545 Define only if needed.
6547 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6548 by pacifying GCC about it. Maybe it's time to retire it?
6549 * xfaces.c (USG, __TIMEVAL__): Likewise.
6551 * dispextern.h (struct redisplay_interface): Rename param
6553 * termhooks.h (struct terminal): Likewise.
6554 * xterm.c (xembed_send_message): Likewise.
6556 * insdel.c (make_gap_smaller): Define only if
6557 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6559 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6562 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6563 so that we aren't warned about unused symbols.
6565 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6567 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6569 * xfns.c (x_real_positions): Mark locals as initialized.
6571 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6573 * xterm.c: Fix problems found by static analysis with other toolkits.
6574 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6575 (x_dispatch_event): Declare static if USE_GTK, and
6576 define if USE_GTK || USE_X_TOOLKIT.
6577 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6578 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6579 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6580 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6582 * xmenu.c (menu_help_callback): Pointer type fixes.
6583 Use const pointers when pointing at readonly data. Avoid pointer
6585 (FALSE): Remove unused macro.
6586 (update_frame_menubar): Remove unused decl.
6588 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6590 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6591 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6592 (single_menu_item): Rename local to avoid shadowing.
6594 * keyboard.c (make_lispy_event): Remove unused local var.
6596 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6597 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6599 * bitmaps: Change bitmaps from unsigned char back to the X11
6600 compatible char. Avoid the old compiler warnings about
6601 out-of-range initializers by using, for example, '\xab' rather
6604 * xgselect.c (xgselect_initialize): Check vs interface
6605 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6607 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6609 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6610 to read-only memory.
6612 * fns.c (vector): Remove; this old hack is no longer needed.
6614 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6616 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6618 * xrdb.c (x_load_resources): Omit unused local.
6620 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6621 (x_window): Rename locals to avoid shadowing.
6622 (USG): Use the kludged USG macro, to pacify gcc.
6624 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6625 (x_term_init): Remove local to avoid shadowing.
6627 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6629 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6630 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6632 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6634 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6636 Fix regex.c, syntax.c and friends for buffers > 2GB.
6637 * syntax.h (struct gl_state_s): Declare character position members
6640 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6642 * textprop.c (verify_interval_modification, interval_of):
6643 Declare arguments EMACS_INT.
6645 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6648 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6650 * indent.c (Fvertical_motion): Local variable it_start is now
6653 * regex.c (re_match, re_match_2, re_match_2_internal)
6654 (bcmp_translate, regcomp, regexec, print_double_string)
6655 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6656 (re_compile_pattern, re_exec): Declare arguments and local
6657 variables `size_t' and `ssize_t' and return values `regoff_t', as
6659 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6660 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6661 <compile_stack_type>: `size' and `avail' are now `size_t'.
6663 * regex.h <regoff_t>: Use ssize_t, not int.
6664 (re_search, re_search_2, re_match, re_match_2): Arguments that
6665 specify buffer/string position and length are now ssize_t and
6666 size_t. Return type is regoff_t.
6668 2011-04-16 Ben Key <bkey76@gmail.com>
6670 * nsfont.m: Fixed bugs in ns_get_family and
6671 ns_descriptor_to_entity that were caused by using free to
6672 deallocate memory blocks that were allocated by xmalloc (via
6673 xstrdup). This caused Emacs to crash when compiled with
6674 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6675 --enable-checking=xmallocoverrun). xfree is now used to
6676 deallocate these memory blocks.
6678 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6680 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6682 emacs_write: Accept and return EMACS_INT for sizes.
6683 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6685 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6686 Accept and return EMACS_INT.
6687 (emacs_gnutls_write): Return the number of bytes written on
6689 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6690 (emacs_read, emacs_write): Remove check for negative size, as the
6691 Emacs source code has been audited now.
6692 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6693 (emacs_read, emacs_write): Use it.
6694 * process.c (send_process): Adjust to the new signatures of
6695 emacs_write and emacs_gnutls_write. Do not attempt to store
6696 a byte offset into an 'int'; it might overflow.
6697 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6699 * sound.c: Don't assume sizes fit in 'int'.
6700 (struct sound_device.period_size, alsa_period_size):
6701 Return EMACS_INT, not int.
6702 (struct sound_device.write, vox_write, alsa_write):
6703 Accept EMACS_INT, not int.
6704 (wav_play, au_play): Use EMACS_INT to store sizes and to
6705 record read return values.
6707 2011-04-15 Ben Key <bkey76@gmail.com>
6709 * keyboard.c (Qundefined): Don't declare static since it is used
6711 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6712 static since they are used in nsfont.m.
6714 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6716 * process.c (Qprocessp): Don't declare static.
6717 * lisp.h (Qprocessp): Declare again.
6719 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6721 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6723 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6725 Improve C-level modularity by making more things 'static'.
6727 Don't publish debugger-only interfaces to other modules.
6728 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6729 (verify_bytepos, count_markers): Move decls to the only modules
6731 * region-cache.h (pp_cache): Likewise.
6732 * window.h (check_all_windows): Likewise.
6733 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6735 * sysdep.c (croak): Now static, if
6736 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6737 * syssignal.h (croak): Declare only if not static.
6739 * alloc.c (refill_memory_reserve): Now static if
6740 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6741 * lisp.h (refill_memory_reserve): Declare only if not static.
6743 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6744 Define only if USE_LUCID.
6746 * xrdb.c (x_customization_string, x_rm_string): Now static.
6748 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6749 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6751 * xdisp.c (draw_row_with_mouse_face): Now static.
6752 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6754 * window.h (check_all_windows): Mark externally visible.
6756 * window.c (window_deletion_count): Now static.
6758 * undo.c: Make symbols static if they're not exported.
6759 (last_undo_buffer, last_boundary_position, pending_boundary):
6762 * textprop.c (interval_insert_behind_hooks): Now static.
6763 (interval_insert_in_front_hooks): Likewise.
6765 * term.c: Make symbols static if they're not exported.
6766 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6767 (max_frame_lines, tty_set_terminal_modes):
6768 (tty_reset_terminal_modes, tty_turn_off_highlight):
6769 (get_tty_terminal): Now static.
6770 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6771 * termhooks.h (term_mouse_moveto): Do not declare if
6773 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6774 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6776 * sysdep.c: Make symbols static if they're not exported.
6777 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6779 (sigprocmask_set, full_mask): Remove; unused.
6780 (wait_debugging): Mark as visible.
6781 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6782 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6784 * syntax.c (syntax_temp): Define only if !__GNUC__.
6786 * sound.c (current_sound_device, current_sound): Now static.
6788 * search.c (searchbufs, searchbuf_head): Now static.
6790 * scroll.c (scroll_cost): Remove; unused.
6791 * dispextern.h (scroll_cost): Remove decl.
6793 * region-cache.h (pp_cache): Mark as externally visible.
6795 * process.c: Make symbols static if they're not exported.
6796 (process_tick, update_tick, create_process, chan_process):
6797 (Vprocess_alist, proc_buffered_char, datagram_access):
6798 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6799 (deactivate_process): Mark defn as static, as well as decl.
6800 * lisp.h (create_process): Remove decl.
6801 * process.h (chan_process, Vprocess_alist): Remove decls.
6803 * print.c: Make symbols static if they're not exported.
6804 (print_depth, new_backquote_output, being_printed, print_buffer):
6805 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6806 (print_interval, print_number_index, initial_stderr_stream):
6808 * lisp.h (Fprinc): Remove decl.
6809 (debug_output_compilation_hack): Mark as externally visible.
6811 * sysdep.c (croak): Move decl from here to syssignal.h.
6812 * syssignal.h (croak): Put it here, so the API can be checked when
6813 'croak' is called from dissociate_if_controlling_tty.
6815 * minibuf.c: Make symbols static if they're not exported.
6816 (minibuf_save_list, choose_minibuf_frame): Now static.
6817 * lisp.h (choose_minibuf_frame): Remove decl.
6819 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6821 * lread.c: Make symbols static if they're not exported.
6822 (read_objects, initial_obarray, oblookup_last_bucket_number):
6824 (make_symbol): Remove; unused.
6825 * lisp.h (initial_obarray, make_symbol): Remove decls.
6827 * keyboard.c: Make symbols static if they're not exported.
6828 (single_kboard, recent_keys_index, total_keys, recent_keys):
6829 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6830 (this_single_command_key_start, echoing, last_auto_save):
6831 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6832 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6833 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6834 (Vlispy_mouse_stem, double_click_count):
6836 (force_auto_save_soon): Define only if SIGDANGER.
6837 (ignore_mouse_drag_p): Now static if
6838 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6839 (print_help): Remove; unused.
6840 (stop_character, last_timer_event): Mark as externally visible.
6841 * keyboard.h (ignore_mouse_drag_p): Declare only if
6842 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6843 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6844 * lisp.h (echoing): Remove decl.
6845 (force_auto_save_soon): Declare only if SIGDANGER.
6846 * xdisp.c (redisplay_window): Simplify code, to make it more
6847 obvious that ignore_mouse_drag_p is not accessed if !defined
6848 USE_GTK && !defined HAVE_NS.
6850 * intervals.c: Make symbols static if they're not exported.
6851 (merge_properties_sticky, merge_interval_right, delete_interval):
6853 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6855 * insdel.c: Make symbols static if they're not exported.
6856 However, leave prepare_to_modify_buffer alone. It's never
6857 called from outside this function, but that appears to be a bug.
6858 (combine_after_change_list, combine_after_change_buffer):
6859 (adjust_after_replace, signal_before_change): Now static.
6860 (adjust_after_replace_noundo): Remove; unused.
6861 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6862 (signal_before_change): Remove decls.
6864 * indent.c (val_compute_motion, val_vmotion): Now static.
6866 * image.c: Make symbols static if they're not exported.
6867 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6869 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6870 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6872 * fringe.c (standard_bitmaps): Now static.
6873 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6875 * frame.c: Make symbols static if they're not exported.
6876 (x_report_frame_params, make_terminal_frame): Now static.
6877 (get_frame_param): Now static, unless HAVE_NS.
6878 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6879 (x_get_resource_string): Remove; not used.
6880 * frame.h (make_terminal_frame, x_report_frame_params):
6881 (x_get_resource_string); Remove decls.
6882 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6883 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6885 * font.c, fontset.c: Make symbols static if they're not exported.
6886 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6887 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6888 * font.c (font_close_object): Now static.
6889 * font.h (font_close_object): Remove.
6890 * fontset.c (FONTSET_OBJLIST): Remove.
6891 (free_realized_fontset) #if-0 the body, which does nothing.
6892 (face_suitable_for_char_p): #if-0, as it's never called.
6893 * fontset.h (face_suitable_for_char_p): Remove decl.
6894 * xfaces.c (face_at_string_position):
6895 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6896 since 0 is always ASCII.
6898 * fns.c (weak_hash_tables): Now static.
6900 * fileio.c: Make symbols static if they're not exported.
6901 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6902 (Vwrite_region_annotation_buffers): Now static.
6904 * eval.c: Make symbols static if they're not exported.
6905 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6906 * lisp.h (backtrace_list): Remove decl.
6908 * emacs.c: Make symbols static if they're not exported.
6909 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6910 (fatal_error_code, fatal_error_signal_hook, standard_args):
6912 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6913 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6914 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6915 * lisp.h (fatal_error_signal_hook): Remove decl.
6916 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6918 * editfns.c: Move a (normally-unused) function to its only use.
6919 * editfns.c, lisp.h (get_operating_system_release): Remove.
6920 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6921 worth the hassle of breaking this out.
6923 * xterm.c: Make symbols static if they're not exported.
6924 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6925 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6926 (x_destroy_window, x_delete_display):
6928 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6929 (x_mouse_leave): Remove; unused.
6930 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6931 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6932 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6934 (x_mouse_leave): Declare only if WINDOWSNT.
6935 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6936 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6939 * ftxfont.c: Make symbols static if they're not exported.
6940 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6942 * font.h (ftxfont_driver): Likewise.
6944 * xfns.c: Make symbols static if they're not exported.
6945 (x_last_font_name, x_display_info_for_name):
6946 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6947 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6948 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6949 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6950 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6951 (last_show_tip_args): Now static.
6952 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6953 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6954 (x_screen_planes): Remove; unused.
6955 * dispextern.h (x_screen_planes): Remove decl.
6957 * dispnew.c: Make symbols static if they're not exported.
6958 * dispextern.h (redraw_garbaged_frames, scrolling):
6959 (increment_row_positions): Remove.
6960 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6961 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6963 (redraw_garbaged_frames): Remove; unused.
6965 * xfaces.c: Make symbols static if they're not exported.
6966 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6968 * xterm.h (defined_color): Remove decls.
6969 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6970 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6971 (menu_face_changed_default, defined_color, free_realized_face):
6972 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6973 (ascii_face_of_lisp_face): Remove; unused.
6975 * xdisp.c: Make symbols static if they're not exported.
6976 * dispextern.h (scratch_glyph_row, window_box_edges):
6977 (glyph_to_pixel_coords, set_cursor_from_row):
6978 (get_next_display_element, set_iterator_to_next):
6979 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6980 (show_mouse_face): Remove decls
6981 * frame.h (message_buf_print): Likewise.
6982 * lisp.h (pop_message, set_message, check_point_in_composition):
6984 * xterm.h (set_vertical_scroll_bar): Likewise.
6985 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6986 (message_buf_print, scratch_glyph_row, displayed_buffer):
6987 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6988 (get_next_display_element, show_mouse_face, window_box_edges):
6989 (frame_to_window_pixel_xy, check_point_in_composition):
6990 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6991 (glyph_to_pixel_coords): Remove; unused.
6993 * dired.c (file_name_completion): Now static.
6995 * dbusbind.c (xd_in_read_queued_messages): Now static.
6997 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6998 * data.c (circular_list_error): Remove.
7000 * commands.h (last_point_position, last_point_position_buffer):
7001 (last_point_position_window): Remove decls.
7002 * keyboard.c: Make these variables static.
7004 * coding.h (coding, code_convert_region, encode_coding_gap):
7006 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7007 (iso_code_class, detect_coding, code_convert_region): Now static.
7008 (encode_coding_gap): Remove; unused.
7010 * chartab.c (chartab_chars, chartab_bits): Now static.
7012 * charset.h (charset_iso_8859_1): Remove decl.
7013 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7016 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7017 * ccl.c (Vccl_program_table): Now static.
7018 (check_ccl_update): Remove; unused.
7020 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7021 * category.h: ... from here.
7022 * category.c (check_category_table, set_category_set): Now static.
7024 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7025 * lisp.h: Remove these decls.
7027 * buffer.c (buffer_count): Remove unused var.
7029 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7030 so that it's not optimized away.
7031 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7032 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7033 exported only to the debugger.
7035 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7036 * atimer.h (run_all_atimers): Remove; not exported.
7038 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7039 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7040 was inaccessible from Lisp.
7041 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7042 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7044 alloc.c: Import and export fewer symbols, and remove unused items.
7045 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7047 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7048 it's not optimized away by whole-program optimization.
7049 (message_enable_multibyte, free_misc): Remove.
7050 (catchlist, handlerlist, mark_backtrace):
7051 Declare only if BYTE_MARK_STACK.
7052 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7053 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7054 (message_enable_multibyte): Remove decl.
7055 (free_misc, interval_free_list, float_block, float_block_index):
7056 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7057 (cons_free_list, last_marked_index):
7059 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7060 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7061 (mark_backtrace): Define only if BYTE_MARK_STACK.
7062 * xdisp.c (message_enable_multibyte): Now static.
7064 Declare Lisp_Object Q* variables to be 'static' if not exported.
7065 This makes it easier for human readers (and static analyzers)
7066 to see whether these variables are used from other modules.
7067 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7068 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7069 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7070 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7071 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7072 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7073 * xmenu.c, xselect.c:
7074 Declare Q* vars static if they are not used in other modules.
7075 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7076 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7077 Remove decls of unexported vars.
7078 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7080 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7082 Make Emacs functions such as Fatom 'static' by default.
7083 This makes it easier for human readers (and static analyzers)
7084 to see whether these functions can be called from other modules.
7085 DEFUN now defines a static function. To make the function external
7086 so that it can be used in other C modules, use the new macro DEFUE.
7087 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7088 (Finit_image_library):
7089 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7090 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7091 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7092 Remove decls, since these functions are now static.
7093 (Funintern, Fget_internal_run_time): New decls, since these functions
7094 were already external.
7096 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7097 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7098 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7099 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7100 * keyboard.c, keymap.c, lread.c:
7101 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7102 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7103 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7104 Mark functions with DEFUE instead of DEFUN,
7105 if they are used in other modules.
7106 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7107 decls for now-static functions.
7108 * buffer.h (Fdelete_overlay): Remove decl.
7109 * callproc.c (Fgetenv_internal): Mark as internal.
7110 * composite.c (Fremove_list_of_text_properties): Remove decl.
7111 (Fcomposition_get_gstring): New forward static decl.
7112 * composite.h (Fcomposite_get_gstring): Remove decl.
7113 * dired.c (Ffile_attributes): New forward static decl.
7114 * doc.c (Fdocumntation_property): New forward static decl.
7115 * eval.c (Ffetch_bytecode): New forward static decl.
7116 (Funintern): Remove extern decl; now in .h file where it belongs.
7117 * fileio.c (Fmake_symbolic_link): New forward static decl.
7118 * image.c (Finit_image_library): New forward static decl.
7119 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7120 * intervals.h (Fprevious_property_change):
7121 (Fremove_list_of_text_properties): Remove decls.
7122 * keyboard.c (Fthis_command_keys): Remove decl.
7123 (Fcommand_execute): New forward static decl.
7124 * keymap.c (Flookup_key): New forward static decl.
7125 (Fcopy_keymap): Now static.
7126 * keymap.h (Flookup_key): Remove decl.
7127 * process.c (Fget_process): New forward static decl.
7128 (Fprocess_datagram_address): Mark as internal.
7129 * syntax.c (Fsyntax_table_p): New forward static decl.
7130 (skip_chars): Remove duplicate decl.
7131 * textprop.c (Fprevious_property_change): New forward static decl.
7132 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7134 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7135 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7137 * editfns.c (Fformat): Remove unreachable code.
7139 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7141 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7144 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7146 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7147 when at ZV. (Bug#8487)
7149 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7151 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7153 * keyboard.c (parse_tool_bar_item): Likewise.
7154 * sound.c (sound_cleanup, alsa_close): Likewise.
7155 * termcap.c (tgetent): Likewise.
7156 * xfns.c (x_default_font_parameter): Likewise.
7157 * xsettings.c (read_and_apply_settings): Likewise.
7159 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7160 (overrun_check_free): Protoize.
7162 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7164 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7165 since callers should never pass a negative size.
7166 Change the signature to match that of plain 'read' and 'write'; see
7167 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7168 * lisp.h: Update prototypes of emacs_write and emacs_read.
7170 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7172 * xdisp.c (redisplay_window): Don't try to determine the character
7173 position of the scroll margin if the window start point w->startp
7174 is outside the buffer's accessible region. (Bug#8468)
7176 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7178 Fix write-region and its subroutines for buffers > 2GB.
7179 * fileio.c (a_write, e_write): Modify declaration of arguments and
7180 local variables to support buffers larger than 2GB.
7181 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7183 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7184 argument, local variables, and return value.
7186 * lisp.h: Update prototypes of emacs_write and emacs_read.
7188 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7190 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7192 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7194 Fix more problems found by GCC 4.6.0's static checks.
7196 * xdisp.c (vmessage): Use a better test for character truncation.
7198 * charset.c (load_charset_map): <, not <=, for optimization,
7199 and to avoid potential problems with integer overflow.
7200 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7201 * casetab.c (set_identity, shuffle): Likewise.
7202 * editfns.c (Fformat): Likewise.
7203 * syntax.c (skip_chars): Likewise.
7205 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7206 This also lets GCC 4.6.0 generate slightly better loop code.
7208 * callint.c (Fcall_interactively): <, not <=, for optimization.
7209 (Fcall_interactively): Count the number of arguments produced,
7210 not the number of arguments given. This is simpler and lets GCC
7211 4.6.0 generate slightly better code.
7213 * ftfont.c: Distingish more carefully between FcChar8 and char.
7214 The previous code passed unsigned char * to a functions like
7215 strlen and xstrcasecmp that expect char *, which does not
7216 conform to the C standard.
7217 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7218 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7219 char * when the C standard requires it.
7221 * keyboard.c (read_char): Remove unused var.
7223 * eval.c: Port to Windows vsnprintf (Bug#8435).
7225 (SIZE_MAX): Define if the headers do not.
7226 (verror): Do not give up if vsnprintf returns a negative count.
7227 Instead, grow the buffer. This ports to Windows vsnprintf, which
7228 does not conform to C99. Problem reported by Eli Zaretskii.
7229 Also, simplify the allocation scheme, by avoiding the need for
7230 calling realloc, and removing the ALLOCATED variable.
7232 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7234 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7235 But keep the doprint source code for now, as we might revamp it
7236 and use it again (Bug#8435).
7237 * lisp.h (doprnt): Remove.
7238 * Makefile.in (base_obj): Remove doprnt.o.
7239 * deps.mk (doprnt.o): Remove.
7241 error: Print 32- and 64-bit integers portably (Bug#8435).
7242 Without this change, on typical 64-bit hosts error ("...%d...", N)
7243 was used to print both 32- and 64-bit integers N, which relied on
7245 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7247 * lisp.h (error, verror): Mark as printf-like functions.
7248 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7249 Report overflow in size calculations when allocating printf buffer.
7250 Do not truncate output string at its first null byte.
7251 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7252 Truncate the output at a character boundary, since vsnprintf does not
7254 * charset.c (check_iso_charset_parameter): Convert internal
7255 character to string before calling 'error', since %c now has the
7257 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7258 overflow when computing char to be passed to 'error'. Do not
7259 pass Lisp_Object to 'error'; pass the integer instead.
7260 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7261 formatted with plain %d.
7263 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7265 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7267 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7269 * xterm.c (x_catch_errors): Remove duplicate declaration.
7271 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7273 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7275 2011-04-10 Jim Meyering <meyering@redhat.com>
7277 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7278 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7279 return ssize_t not "int", and use size_t as the buffer length.
7280 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7281 * gnutls.h: Update declarations.
7282 * process.c (read_process_output): Use ssize_t, to match.
7283 (send_process): Likewise.
7285 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7287 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7289 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7291 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7292 Use unsigned char, to match FcChar8 type definition.
7294 * xterm.c (handle_one_xevent):
7295 * xmenu.c (create_and_show_popup_menu):
7296 * xselect.c (x_decline_selection_request)
7297 (x_reply_selection_request): Avoid type-punned deref of X events.
7299 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7301 Fix some uses of `int' instead of EMACS_INT.
7302 * search.c (string_match_1, fast_string_match)
7303 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7304 (scan_buffer, find_next_newline_no_quit)
7305 (find_before_next_newline, search_command, Freplace_match)
7306 (Fmatch_data): Make some `int' variables be EMACS_INT.
7308 * xdisp.c (display_count_lines): 3rd argument and return value now
7309 EMACS_INT. All callers changed.
7310 (pint2hrstr): Last argument is now EMACS_INT.
7312 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7313 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7314 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7315 (decode_coding_utf_16, decode_coding_emacs_mule)
7316 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7317 (decode_coding_ccl, decode_coding_charset)
7318 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7319 (decode_coding_iso_2022, decode_coding_emacs_mule)
7320 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7321 <char_offset, last_offset>: Declare EMACS_INT.
7322 (encode_coding_utf_8, encode_coding_utf_16)
7323 (encode_coding_emacs_mule, encode_invocation_designation)
7324 (encode_designation_at_bol, encode_coding_iso_2022)
7325 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7326 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7328 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7329 (encode_invocation_designation): Last argument P_NCHARS is now
7331 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7332 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7334 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7337 * ccl.c (Fccl_execute_on_string): Declare some variables
7340 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7342 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7344 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7346 * process.c (Fformat_network_address): Doc fix.
7348 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7350 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7352 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7354 * keyboard.c (read_char): Call Lisp function help-form-show,
7355 instead of using internal_with_output_to_temp_buffer.
7356 (Qhelp_form_show): New var.
7357 (syms_of_keyboard): Use DEFSYM macro.
7359 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7361 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7363 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7365 * process.c (Flist_processes): Remove to Lisp.
7366 (list_processes_1): Delete.
7368 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7370 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7372 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7374 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7376 Fix more problems found by GCC 4.6.0's static checks.
7378 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7380 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7382 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7384 * xdisp.c (vmessage): Mark as a printf-like function.
7386 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7388 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7390 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7391 printf-like functions.
7392 (tiff_load): Add casts to remove these marks before passing them
7393 to system-supplied API.
7395 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7397 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7398 This avoids several warnings with gcc -Wstrict-overflow.
7399 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7400 directly, rather than having caller test rule sign. This avoids
7401 some unnecessary tests.
7402 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7403 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7404 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7406 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7407 (xfont_open): Avoid unnecessary tests.
7409 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7411 * composite.h, composite.c (composition_gstring_put_cache):
7412 Use EMACS_INT, not int, for length.
7414 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7415 breaking out part of COMPOSITION_DECODE_RULE.
7416 (COMPOSITION_DECODE_RULE): Use it.
7417 * composite.c (get_composition_id): Remove unused local vars,
7418 by using the new macro.
7420 * textprop.c (set_text_properties_1): Change while to do-while,
7421 since the condition is always true at first.
7423 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7424 (interval_deletion_adjustment): Return unsigned value.
7427 * process.c (list_processes_1, create_pty, read_process_output):
7428 (exec_sentinel): Remove vars that were set but not used.
7429 (create_pty): Remove unnecessary "volatile"s.
7430 (Fnetwork_interface_info): Avoid possibility of int overflow.
7431 (read_process_output): Do adaptive read buffering even if carryover.
7432 (read_process_output): Simplify nbytes computation if buffered.
7434 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7436 * syntax.c (scan_words): Remove var that was set but not used.
7437 (update_syntax_table): Use unsigned instead of int.
7439 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7440 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7441 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7443 * print.c (print_error_message): Avoid int overflow.
7445 * font.c (font_list_entities): Redo for clarity,
7446 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7448 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7449 (font_score): Avoid potential overflow in diff calculation.
7451 * fns.c (substring_both): Remove var that is set but not used.
7452 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7454 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7456 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7457 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7458 can always succeed if overflow has undefined behavior.
7460 * search.c (boyer_moore, wordify): Remove vars set but not used.
7461 (wordify): Omit three unnecessary tests.
7463 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7464 All callers changed. This avoids the need for an unused var.
7466 * casefiddle.c (casify_region): Remove var that is set but not used.
7468 * dired.c (file_name_completion): Remove var that is set but not used.
7470 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7472 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7473 (Finsert_file_contents): Remove unnecessary code checking fd.
7475 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7476 Check for integer overflow on size calculations.
7478 * buffer.c (Fprevious_overlay_change): Remove var that is set
7481 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7482 Remove vars that are set but not used.
7483 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7484 (timer_check_2): Mark vars as initialized.
7486 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7488 * image.c (lookup_image): Remove var that is set but not used.
7489 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7491 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7492 that are set but not used.
7494 * xfns.c (make_invisible_cursor): Don't return garbage
7495 if XCreateBitmapFromData fails (Bug#8410).
7497 * xselect.c (x_get_local_selection, x_handle_property_notify):
7498 Remove vars that are set but not used.
7500 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7501 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7503 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7504 Remove var that is set but not used.
7505 (scroll_bar_windows_size): Now size_t, not int.
7506 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7509 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7510 (map_tty_color) [!defined MSDOS]: Likewise.
7512 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7514 * coding.c: Remove vars that are set but not used.
7515 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7516 All callers changed.
7517 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7518 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7519 (decode_coding_charset): Remove vars that are set but not used.
7521 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7522 that is set but not used.
7524 * print.c (print_object): Remove var that is set but not used.
7526 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7527 The gnulib version avoids calling malloc in the usual case,
7528 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7529 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7530 * filelock.c (current_lock_owner): Likewise.
7531 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7532 * sysdep.c: Include allocator.h, careadlinkat.h.
7533 (emacs_no_realloc_allocator): New static constant.
7534 (emacs_readlink): New function.
7535 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7536 ../lib/careadlinkat.h.
7538 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7540 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7541 first non-nil return value).
7543 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7545 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7546 if not defined (Bug#8403).
7548 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7550 * xdisp.c (display_count_lines): Remove parameter `start',
7551 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7552 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7553 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7554 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7555 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7556 and thereabouts. All callers changed.
7557 (get_per_char_metric): Remove parameter `f', unused since
7558 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7560 2011-04-02 Jim Meyering <meyering@redhat.com>
7562 do not dereference NULL upon failed strdup
7563 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7564 (ns_get_family): Likewise.
7566 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7568 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7570 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7572 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7575 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7577 Add lexical binding.
7579 * window.c (Ftemp_output_buffer_show): New fun.
7580 (Fsave_window_excursion):
7581 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7583 * lread.c (lisp_file_lexically_bound_p): New function.
7584 (Fload): Bind Qlexical_binding.
7585 (readevalloop): Remove `evalfun' arg.
7586 Bind Qinternal_interpreter_environment.
7587 (Feval_buffer): Bind Qlexical_binding.
7588 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7590 (syms_of_lread): Declare `lexical-binding'.
7592 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7594 * keyboard.c (eval_dyn): New fun.
7595 (menu_item_eval_property): Use it.
7597 * image.c (parse_image_spec): Use Ffunctionp.
7599 * fns.c (concat, mapcar1): Accept byte-code-functions.
7601 * eval.c (Fsetq): Handle lexical vars.
7602 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7603 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7604 (FletX, Flet): Obey lexical binding.
7605 (Fcommandp): Handle closures.
7606 (Feval): New `lexical' arg.
7607 (eval_sub): New function extracted from Feval. Use it almost
7608 everywhere where Feval was used. Look up vars in lexical env.
7610 (Ffunctionp): Move from subr.el.
7611 (Ffuncall): Handle closures.
7612 (apply_lambda): Remove `eval_flags'.
7613 (funcall_lambda): Handle closures and new byte-code-functions.
7614 (Fspecial_variable_p): New function.
7615 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7616 but without exporting it to Lisp.
7618 * doc.c (Fdocumentation, store_function_docstring):
7619 * data.c (Finteractive_form): Handle closures.
7621 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7624 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7626 (exec_byte_code): New function extracted from Fbyte_code to handle new
7627 calling convention for byte-code-functions. Add new byte-codes.
7629 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7631 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7633 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7635 * xdisp.c (redisplay_internal): Fix prototype.
7637 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7639 * xdisp.c (SCROLL_LIMIT): New macro.
7640 (try_scrolling): Use it when setting scroll_limit.
7641 Limit scrolling to 100 screen lines.
7642 (redisplay_window): Even when falling back on "recentering",
7643 position point in the window according to scroll-conservatively,
7644 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7646 (try_scrolling): When point is above the window, allow searching
7647 as far as scroll_max, or one screenful, to compute vertical
7648 distance from PT to the scroll margin position. This prevents
7649 try_scrolling from unnecessarily failing when
7650 scroll-conservatively is set to a value slightly larger than the
7651 window height. Clean up the case of PT below the margin at bottom
7652 of window: scroll_max can no longer be INT_MAX. When aggressive
7653 scrolling is in use, don't let point enter the opposite scroll
7654 margin as result of the scroll.
7655 (syms_of_xdisp) <scroll-conservatively>: Document the
7656 threshold of 100 lines for never-recentering scrolling.
7658 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7660 * dispextern.h (move_it_by_lines):
7661 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7662 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7663 (message_log_check_duplicate): Remove parameters `prev_bol' and
7664 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7665 (redisplay_internal): Remove parameter `preserve_echo_area',
7666 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7668 * indent.c (Fvertical_motion):
7669 * window.c (window_scroll_pixel_based, Frecenter):
7670 Don't pass `need_y_p' to `move_it_by_lines'.
7672 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7674 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7675 steal a few bits to be more compact.
7676 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7677 Remove unneeded casts.
7679 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7681 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7683 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7684 binding" message (bug#7967).
7686 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7688 Fix more problems found by GCC 4.6.0's static checks.
7690 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7691 Remove unused local var.
7693 * editfns.c (Fmessage_box): Remove unused local var.
7695 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7696 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7697 Omit unused local vars.
7698 * window.c (shrink_windows): Omit unused local var.
7699 * menu.c (digest_single_submenu): Omit unused local var.
7700 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7701 Omit unused local var.
7703 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7704 Don't assume string length fits in int.
7705 (keyremap_step, read_key_sequence): Use size_t for sizes.
7706 (read_key_sequence): Don't check last_real_key_start redundantly.
7708 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7709 instead of alloca (Bug#8344).
7711 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7712 (Fbacktrace_frame): Don't assume nframes fits in int.
7714 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7716 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7719 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7721 * cm.c (calccost): Turn while-do into do-while, for clarity.
7723 * keyboard.c (syms_of_keyboard): Use the same style as later
7724 in this function when indexing through an array. This also
7725 works around GCC bug 48267.
7727 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7729 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7731 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7732 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7734 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7735 This avoids undefined behavior on integer overflow, and is a bit
7736 more convenient anyway since it is compared to a size_t variable.
7738 Variadic C functions now count arguments with size_t, not int.
7739 This avoids an unnecessary limitation on 64-bit machines, which
7740 caused (substring ...) to crash on large vectors (Bug#8344).
7741 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7742 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7743 All variadic functions and their callers changed accordingly.
7744 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7745 * data.c (arith_driver, float_arith_driver): Likewise.
7746 * editfns.c (general_insert_function): Likewise.
7747 * eval.c (struct backtrace.nargs, interactive_p)
7748 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7749 (funcall_lambda, mark_backtrace): Likewise.
7750 * fns.c (concat): Likewise.
7751 * frame.c (x_set_frame_parameters): Likewise.
7752 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7753 0 if not found, not -1. All callers changed.
7755 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7756 (stack_copy_size): Now size_t, not int.
7757 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7759 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7761 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7762 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7763 All callers changed.
7765 * lisp.h (multibyte_char_to_unibyte):
7766 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7767 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7768 * character.h (CHAR_TO_BYTE8):
7769 * cmds.c (internal_self_insert):
7770 * editfns.c (general_insert_function):
7771 * keymap.c (push_key_description):
7772 * search.c (Freplace_match):
7773 * xdisp.c (message_dolog, set_message_1): All callers changed.
7775 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7777 * keyboard.c (safe_run_hook_funcall): New function.
7778 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7779 don't set the hook to nil, but remove the offending function instead.
7780 (Qcommand_hook_internal): Remove, unused.
7781 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7782 Vcommand_hook_internal.
7784 * eval.c (enum run_hooks_condition): Remove.
7785 (funcall_nil, funcall_not): New functions.
7786 (run_hook_with_args): Call each function through a `funcall' argument.
7787 Remove `cond' argument, now redundant.
7788 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7789 (Frun_hook_with_args_until_failure): Adjust accordingly.
7790 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7792 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7794 * dispextern.h (string_buffer_position): Remove declaration.
7796 * print.c (strout): Remove parameter `multibyte', unused since
7797 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7799 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7800 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7801 All callers changed.
7803 * w32.c (_wsa_errlist): Use braces for struct initializers.
7805 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7806 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7807 All callers changed.
7808 (string_buffer_position): Likewise. Also, make static (it's never
7809 used outside xdisp.c).
7810 (cursor_row_p): Remove parameter `w', unused since
7811 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7812 (decode_mode_spec): Remove parameter `precision', introduced during
7813 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7814 All callers changed.
7816 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7818 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7820 2011-03-27 Anders Lindgren <andlind@gmail.com>
7822 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7823 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7824 (ns_update_auto_hide_menu_bar): New functions.
7825 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7826 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7827 ns_constrain_all_frames.
7828 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7829 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7831 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7833 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7835 2011-03-27 Glenn Morris <rgm@gnu.org>
7837 * syssignal.h: Replace RETSIGTYPE with void.
7838 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7839 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7840 Replace SIGTYPE with void everywhere.
7841 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7842 * s/template.h (SIGTYPE): Remove commented out definition.
7844 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7846 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7847 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7849 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7851 * w32.c (read_unc_volume): Use parameter `henum', instead of
7852 global variable `wget_enum_handle'.
7854 * keymap.c (describe_vector): Remove parameters `indices' and
7855 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7856 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7858 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7860 * keyboard.c (timer_check): Remove parameter `do_it_now',
7861 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7862 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7863 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7865 * keyboard.c (read_char):
7866 * w32menu.c (w32_menu_display_help):
7867 * xmenu.c (show_help_event, menu_help_callback):
7868 Adjust calls to `show_help_echo'.
7870 * gtkutil.c (xg_maybe_add_timer):
7871 * keyboard.c (readable_events):
7872 * process.c (wait_reading_process_output):
7873 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7875 * insdel.c (adjust_markers_gap_motion):
7876 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7877 (gap_left, gap_right): Don't call it.
7879 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7881 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7882 incurred during fontification.
7884 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7886 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7887 (DEFVAR_PER_BUFFER): Don't pass it.
7889 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7890 (scrolling_window): Don't pass it.
7892 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7894 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7896 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7898 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7899 of variables specific to SELinux and computation of `encoded_absname'.
7901 * image.c (XPutPixel): Remove unused variable `height'.
7903 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7905 * unexw32.c (get_section_info): Remove unused variable `section'.
7907 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7908 (system_process_attributes): Remove unused variable `sess'.
7909 (sys_read): Remove unused variable `err'.
7911 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7912 (w32_wnd_proc): Remove unused variable `isdead'.
7913 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7914 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7915 (x_create_tip_frame): Remove unused variable `tem'.
7917 * w32inevt.c (w32_console_read_socket):
7918 Remove unused variable `no_events'.
7920 * w32term.c (x_draw_composite_glyph_string_foreground):
7921 Remove unused variable `width'.
7923 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7925 * w32term.c (x_set_glyph_string_clipping):
7926 Don't pass uninitialized region to CombineRgn.
7928 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7930 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7931 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7932 (Fx_close_connection): Remove unused variable `i'.
7934 * w32font.c (w32font_draw): Return number of glyphs.
7935 (w32font_open_internal): Remove unused variable `i'.
7936 (w32font_driver): Add missing initializer.
7938 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7939 (fill_in_menu): Remove unused variable `items_added'.
7941 * w32term.c (last_mouse_press_frame): Remove static global variable.
7942 (w32_clip_to_row): Remove unused variable `f'.
7943 (x_delete_terminal): Remove unused variable `i'.
7945 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7946 (NOTHING): Remove unused static global variable.
7947 (uniscribe_check_otf): Remove unused variable `table'.
7948 (uniscribe_font_driver): Add missing initializers.
7950 2011-03-23 Julien Danjou <julien@danjou.info>
7952 * term.c (Fsuspend_tty, Fresume_tty):
7953 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7954 * window.c (temp_output_buffer_show):
7955 * insdel.c (signal_before_change):
7956 * frame.c (Fhandle_switch_frame):
7957 * fileio.c (Fdo_auto_save):
7958 * emacs.c (Fkill_emacs):
7959 * editfns.c (save_excursion_restore):
7960 * cmds.c (internal_self_insert):
7961 * callint.c (Fcall_interactively):
7962 * buffer.c (Fkill_all_local_variables):
7963 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7965 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7966 unconditionally since it does the check itself.
7968 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7970 Fix more problems found by GCC 4.5.2's static checks.
7972 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7973 the first time through the loop, since we know p0 < p1 then.
7974 This also avoids a gcc -Wstrict-overflow warning.
7976 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7977 leading to a memory leak, possible in functions like
7978 load_charset_map_from_file that can allocate an unbounded number
7979 of objects (Bug#8318).
7981 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7982 that could (at least in theory) be that large.
7984 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7985 This is less likely to overflow, and avoids undefined behavior if
7986 overflow does occur. All callers changed. Use strtoul to scan
7987 for the unsigned long integer.
7988 (pint2hrstr): Simplify and tune code slightly.
7989 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7991 * scroll.c (do_scrolling): Work around GCC bug 48228.
7992 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7994 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7995 This also avoids a warning with gcc -Wstrict-overflow.
7996 (validate_x_resource_name): Simplify count usage.
7997 This also avoids a warning with gcc -Wstrict-overflow.
7999 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8002 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8004 * process.c (Fmake_network_process): Use socklen_t, not int,
8005 where POSIX says socklen_t is required in portable programs.
8006 This fixes a porting bug on hosts like 64-bit HP-UX, where
8007 socklen_t is wider than int (Bug#8277).
8008 (Fmake_network_process, server_accept_connection):
8009 (wait_reading_process_output, read_process_output):
8012 * process.c: Rename or move locals to avoid shadowing.
8013 (list_processes_1, Fmake_network_process):
8014 (read_process_output_error_handler, exec_sentinel_error_handler):
8015 Rename or move locals.
8016 (Fmake_network_process): Define label "retry_connect" only if needed.
8017 (Fnetwork_interface_info): Fix pointer signedness.
8018 (process_send_signal): Add cast to avoid pointer signedness problem.
8019 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8020 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8022 Make tparam.h and terminfo.c consistent.
8023 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8024 Include tparam.h instead, since it declares them.
8025 * cm.h (PC): Remove extern decl; tparam.h now does this.
8026 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8027 * terminfo.c: Include tparam.h, to check interfaces.
8028 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8029 (tparam): Adjust signature to match interface in tparam.h;
8030 this removes some undefined behavior. Check that outstring and len
8031 are zero, which they always are with Emacs.
8032 * tparam.h (PC, BC, UP): New extern decls.
8034 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8035 (xftfont_open): Rename locals to avoid shadowing.
8037 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8038 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8039 (OTF_TAG_SYM): Omit macro if not needed.
8040 (ftfont_list): Remove unused local.
8041 (get_adstyle_property, ftfont_pattern_entity):
8042 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8043 Rename locals to avoid shadowing.
8045 * xfont.c (xfont_list_family): Mark var as initialized.
8047 * xml.c (make_dom): Now static.
8049 * composite.c (composition_compute_stop_pos): Rename local to
8051 (composition_reseat_it): Remove unused locals.
8052 (find_automatic_composition, composition_adjust_point): Likewise.
8053 (composition_update_it): Mark var as initialized.
8054 (find_automatic_composition): Mark vars as initialized,
8055 with a FIXME (Bug#8290).
8057 character.h: Rename locals to avoid shadowing.
8058 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8059 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8060 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8061 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8064 * textprop.c (property_change_between_p): Remove; unused.
8066 * intervals.c (interval_start_pos): Now static.
8068 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8070 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8071 Rename locals to avoid shadowing.
8073 * sound.c (wav_play, au_play, Fplay_sound_internal):
8074 Fix pointer signedness.
8075 (alsa_choose_format): Remove unused local var.
8076 (wav_play): Initialize a variable to 0, to prevent undefined
8077 behavior (Bug#8278).
8079 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8081 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8083 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8084 clobbering (Bug#8298).
8085 * sysdep.c (sys_subshell): Likewise.
8086 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8088 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8089 This should get cleaned up, so that child_setup has the
8090 same signature on all platforms.
8092 * callproc.c (call_process_cleanup): Now static.
8093 (relocate_fd): Rename locals to avoid shadowing.
8095 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8097 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8098 not to be necessary, and produces flickering.
8100 2011-03-20 Glenn Morris <rgm@gnu.org>
8102 * config.in: Remove file.
8104 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8106 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8107 are now in src/globals.h.
8108 (syms_of_minibuf): Remove spurious & from previous change.
8110 2011-03-20 Leo <sdl.web@gmail.com>
8112 * minibuf.c (completing-read-function): New variable.
8113 (completing-read-default): Rename from completing-read.
8114 (completing-read): Call completing-read-function.
8116 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8118 * xfaces.c (Fx_load_color_file):
8119 Read color file from absolute filename (bug#8250).
8121 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8123 * makefile.w32-in: Update dependencies.
8125 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8127 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8129 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8131 Fix more problems found by GCC 4.5.2's static checks.
8133 * process.c (make_serial_process_unwind, send_process_trap):
8134 (sigchld_handler): Now static.
8136 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8137 That way, the code declares only the vars that it needs.
8138 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8139 * s/cygwin.h (PTY_ITERATION): Likewise.
8140 * s/darwin.h (PTY_ITERATION): Likewise.
8141 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8143 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8144 * process.c (allocate_pty): Don't declare stb unless it's needed.
8146 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8147 (CONSTANTLIM): Remove; unused.
8148 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8149 Define only if needed.
8151 * unexelf.c (unexec): Name an expression,
8152 to avoid gcc -Wbad-function-cast warning.
8153 Use a different way to cause a compilation error if anyone uses
8154 n rather than nn, a way that does not involve shadowing.
8155 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8157 * deps.mk (unexalpha.o): Remove; unused.
8159 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8160 * unexec.h: New file.
8161 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8162 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8164 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8165 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8166 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8167 Change as necessary to match prototype in unexec.h.
8169 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8171 (back_comment, skip_chars): Mark vars as initialized.
8173 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8174 Rename locals to avoid shadowing.
8176 * lread.c (read1): Rewrite so as not to use empty "else".
8177 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8179 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8181 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8182 warning when compiling print.c.
8184 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8185 instead of using an uninitialized var.
8186 (font_sort_entities): Mark var as initialized.
8188 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8190 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8191 pointers to constants.
8192 (font_parse_fcname): Remove unused vars.
8193 (font_delete_unmatched): Now static.
8194 (font_get_spec): Remove; unused.
8195 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8196 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8197 Rename or move locals to avoid shadowing.
8199 * fns.c (require_nesting_list, require_unwind): Now static.
8200 (Ffillarray): Rename locals to avoid shadowing.
8202 * floatfns.c (domain_error2): Define only if needed.
8203 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8205 * alloc.c (mark_backtrace): Move decl from here ...
8206 * lisp.h: ... to here, so that it can be checked.
8208 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8209 (Fdefvar): Rewrite so as not to use empty "else".
8210 (lisp_indirect_variable): Name an expression,
8211 to avoid gcc -Wbad-function-cast warning.
8212 (Fdefvar): Rename locals to avoid shadowing.
8214 * callint.c (quotify_arg, quotify_args): Now static.
8215 (Fcall_interactively): Rename locals to avoid shadowing.
8216 Use const pointer when appropriate.
8218 * lisp.h (get_system_name, get_operating_system_release):
8219 Move decls here, to check interfaces.
8220 * process.c (get_operating_system_release): Move decl to lisp.h.
8221 * xrdb.c (get_system_name): Likewise.
8222 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8223 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8224 some of which prompt warnings from gcc -Wbad-function-cast.
8225 (Fformat_time_string, Fencode_time, Finsert_char):
8226 (Ftranslate_region_internal, Fformat):
8227 Rename or remove local vars to avoid shadowing.
8228 (Ftranslate_region_internal): Mark var as initialized.
8230 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8233 * lisp.h (eassert): Check that the argument compiles, even if
8234 ENABLE_CHECKING is not defined.
8236 * data.c (Findirect_variable): Name an expression, to avoid
8237 gcc -Wbad-function-cast warning.
8238 (default_value, arithcompare, arith_driver, arith_error): Now static.
8239 (store_symval_forwarding): Rename local to avoid shadowing.
8240 (Fmake_variable_buffer_local, Fmake_local_variable):
8241 Mark variables as initialized.
8242 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8244 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8245 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8246 Rename locals to avoid shadowing.
8247 (mark_stack): Move local variables into the #ifdef region where
8249 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8250 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8252 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8253 (GC_STRING_CHARS): Remove; not used.
8254 (Fmemory_limit): Cast sbrk's returned value to char *.
8256 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8257 avoids undefined behavior in theory.
8259 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8261 Use functions, not macros, for up- and down-casing (Bug#8254).
8262 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8263 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8264 to use the following functions instead of these macros.
8265 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8266 EMACS_INT, since callers assume the returned value fits in int.
8267 (upcase1): Likewise, for UPCASE_TABLE.
8268 (uppercasep, lowercasep, upcase): New static inline functions.
8269 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8270 the race-condition problem in the old DOWNCASE.
8272 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8273 Rename locals to avoid shadowing.
8274 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8275 (regex_compile, re_search_2, re_match_2_internal):
8276 Remove unused local vars.
8277 (FREE_VAR): Rewrite so as not to use empty "else",
8278 which gcc can warn about.
8279 (regex_compile, re_match_2_internal): Mark locals as initialized.
8280 (RETALLOC_IF): Define only if needed.
8281 (WORDCHAR_P): Likewise. This one is never needed, but is used
8282 only in a comment talking about a compiler bug, so put inside
8283 the #if 0 of that comment.
8284 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8285 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8288 * search.c (boyer_moore): Rename locals to avoid shadowing.
8289 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8290 (PREV_CHAR_BOUNDARY): Likewise.
8292 * search.c (simple_search): Remove unused var.
8294 * dired.c (compile_pattern): Move decl from here ...
8295 * lisp.h: ... to here, so that it can be checked.
8296 (struct re_registers): New forward decl.
8298 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8300 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8302 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8303 Rename locals to avoid shadowing.
8304 (Fvertical_motion): Mark locals as initialized.
8306 * casefiddle.c (casify_object, casify_region): Now static.
8307 (casify_region): Mark local as initialized.
8309 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8311 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8312 New macros, so that the caller can use some names other than
8313 gcpro1, gcpro2, etc.
8314 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8316 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8317 argument, for consistency with GCPRO2_VAR, etc: it is now the
8318 prefix of the variable, not the variable itself. All uses
8320 * dired.c (directory_files_internal, file_name_completion):
8321 Rename locals to avoid shadowing.
8323 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8324 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8325 dired.c's scmp function, had undefined behavior.
8326 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8327 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8328 * buffer.h: ... to here, because these macros use current_buffer,
8329 and the new implementation with inline functions needs to have
8330 current_buffer in scope now, rather than later when the macros
8332 (downcase, upcase1): New static inline functions.
8333 (DOWNCASE, UPCASE1): Reimplement using these functions.
8334 This avoids undefined behavior in expressions like
8335 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8336 from race conditions in accessing the global variables
8337 case_temp1 and case_temp2.
8338 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8339 * lisp.h (case_temp1, case_temp2): Remove their decls.
8340 * character.h (ASCII_CHAR_P): Move from here ...
8341 * lisp.h: ... to here, so that the inline functions mentioned
8344 * dired.c (directory_files_internal_unwind): Now static.
8346 * fileio.c (file_name_as_directory, directory_file_name):
8347 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8349 (file_name_as_directory): Use const pointers when appropriate.
8350 (Fexpand_file_name): Likewise. In particular, newdir might
8351 point at constant storage, so make it a const pointer.
8352 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8353 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8355 (Fset_file_times, Finsert_file_contents, auto_save_error):
8356 Rename locals to avoid shadowing.
8358 * minibuf.c (choose_minibuf_frame_1): Now static.
8359 (Ftry_completion, Fall_completions): Rename or remove locals
8362 * marker.c (bytepos_to_charpos): Remove; unused.
8364 * lisp.h (verify_bytepos, count_markers): New decls,
8365 so that gcc does not warn that these functions aren't declared.
8367 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8368 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8369 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8370 (copy_text): Remove unused local var.
8372 * filelock.c (within_one_second): Now static.
8373 (lock_file_1): Rename local to avoid shadowing.
8375 * buffer.c (fix_overlays_before): Mark locals as initialized.
8376 (fix_start_end_in_overlays): Likewise. This function should be
8377 simplified by using pointers-to-pointers, but that's a different
8379 (switch_to_buffer_1): Now static.
8380 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8381 (report_overlay_modification): Rename locals to avoid shadowing.
8383 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8384 Fix pointer signedness issue.
8385 (sys_subshell): Mark local as volatile if checking for lint,
8386 to suppress a gcc -Wclobbered warning that does not seem to be right.
8387 (MAXPATHLEN): Define only if needed.
8389 * process.c (serial_open, serial_configure): Move decls from here ...
8390 * systty.h: ... to here, so that they can be checked.
8392 * fns.c (get_random, seed_random): Move extern decls from here ...
8393 * lisp.h: ... to here, so that they can be checked.
8395 * sysdep.c (reset_io): Now static.
8396 (wait_for_termination_signal): Remove; unused.
8398 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8399 (copy_keymap_item, append_key, push_text_char_description):
8401 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8402 (DENSE_TABLE_SIZE): Remove; unused.
8403 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8404 (describe_map_tree):
8405 Rename locals to avoid shadowing.
8407 * keyboard.c: Declare functions static if they are not used elsewhere.
8408 (echo_char, echo_dash, cmd_error, top_level_2):
8409 (poll_for_input, handle_async_input): Now static.
8410 (read_char, kbd_buffer_get_event, make_lispy_position):
8411 (make_lispy_event, make_lispy_movement, apply_modifiers):
8412 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8413 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8414 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8415 (read_key_sequence, read_char): Mark locals as initialized.
8416 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8418 * keyboard.h (make_ctrl_char): New decl.
8419 (mark_kboards): Move decl here ...
8420 * alloc.c (mark_kboards): ... from here.
8422 * lisp.h (force_auto_save_soon): New decl.
8424 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8425 (DEFINE_DUMMY_FUNCTION): New macro.
8426 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8428 (main): Add casts to avoid warnings
8429 if GCC considers string literals to be constants.
8431 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8433 * dbusbind.c: Pointer signedness fixes.
8434 (xd_signature, xd_append_arg, xd_initialize):
8435 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8436 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8437 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8438 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8440 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8441 if GCC considers string literals to be constants.
8442 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8444 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8446 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8447 (print_preprocess, print_object): New macro to fix last change.
8449 * print.c (print_preprocess): Don't forget font objects.
8451 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8453 * emacs.c (USAGE3): Doc fixes.
8455 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8457 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8460 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8462 * lisp.h (VWindow_system, Qfile_name_history):
8463 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8464 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8465 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8467 * w32select.c: Don't #include "keyboard.h".
8468 (run_protected): Add extern declaration for waiting_for_input.
8470 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8471 * w32console.c (detect_input_pending, read_input_pending)
8472 (encode_terminal_code):
8473 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8474 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8475 (w32_system_caret_y, Qfile_name_history):
8476 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8477 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8478 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8479 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8480 * w32proc.c (Qlocal, report_file_error):
8481 * w32term.c (Vwindow_system, updating_frame):
8482 * w32uniscribe.c (initialized, uniscribe_font_driver):
8483 Remove unneeded extern declarations.
8485 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8487 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8489 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8491 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8492 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8493 These macros can no longer be used for assignment.
8495 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8496 Assign struct members directly, instead of using BUF_BEGV etc.
8497 (record_buffer_markers, fetch_buffer_markers): New functions for
8498 recording and fetching special buffer markers.
8499 (set_buffer_internal_1, set_buffer_temp): Use them.
8501 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8503 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8505 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8506 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8508 * xdisp.c (hscroll_window_tree):
8509 (reconsider_clip_changes): Use PT instead of BUF_PT.
8511 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8513 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8514 $(EMACS_ROOT)/lib/intprops.h.
8516 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8518 Fix more problems found by GCC 4.5.2's static checks.
8520 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8521 to unsigned char * to avoid compiler diagnostic.
8522 (xg_free_frame_widgets): Make it clear that a local variable is
8523 needed only if USE_GTK_TOOLTIP.
8524 (gdk_window_get_screen): Make it clear that this macro is needed
8525 only if USE_GTK_TOOLTIP.
8526 (int_gtk_range_get_value): New function, which avoids a diagnostic
8527 from gcc -Wbad-function-cast.
8528 (xg_set_toolkit_scroll_bar_thumb): Use it.
8529 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8530 diagnostic from gcc -Wbad-function-cast.
8531 (get_utf8_string, xg_get_file_with_chooser):
8532 Rename locals to avoid shadowing.
8533 (create_dialog): Move locals to avoid shadowing.
8535 * xgselect.c (xg_select): Remove unused var.
8537 * image.c (four_corners_best): Mark locals as initialized.
8538 (gif_load): Initialize transparent_p to zero (Bug#8238).
8539 Mark another local as initialized.
8540 (my_png_error, my_error_exit): Mark with NO_RETURN.
8542 * image.c (clear_image_cache): Now static.
8543 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8544 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8545 (x_edge_detection): Remove unnecessary cast that
8546 gcc -Wbad-function-cast diagnoses.
8547 (gif_load): Fix pointer signedness.
8548 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8549 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8551 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8553 Improve quality of tests for time stamp overflow.
8554 For example, without this patch (encode-time 0 0 0 1 1
8555 1152921504606846976) returns the obviously-bogus value (-948597
8556 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8557 reports time overflow. See
8558 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8559 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8560 * editfns.c: Include limits.h and intprops.h.
8561 (TIME_T_MIN, TIME_T_MAX): New macros.
8562 (time_overflow): Move earlier, to before first use.
8563 (hi_time, lo_time): New functions, for an accurate test for
8565 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8566 (Fget_internal_run_time): Don't assume time_t fits in int.
8567 (make_time): Use list2 instead of Fcons twice.
8568 (Fdecode_time): More accurate test for out-of-range times.
8569 (check_tm_member): New function.
8570 (Fencode_time): Use it, to test for out-of-range times.
8571 (lisp_time_argument): Don't rely on undefined left-shift and
8572 right-shift behavior when checking for time stamp overflow.
8574 * editfns.c (time_overflow): New function, refactoring common code.
8575 (Fformat_time_string, Fdecode_time, Fencode_time):
8576 (Fcurrent_time_string): Use it.
8578 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8579 * dired.c (make_time): Move to ...
8580 * editfns.c (make_time): ... here.
8581 * systime.h: Note the move.
8583 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8585 * fringe.c (update_window_fringes): Remove unused variables.
8587 * unexmacosx.c (copy_data_segment): Also copy __got section.
8590 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8592 * termcap.c [MSDOS]: Include "msdos.h".
8593 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8594 Constify `char *' arguments and their references according to
8595 prototypes in tparam.h.
8597 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8599 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8600 Adapt all references accordingly.
8602 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8604 2011-03-11 Tom Tromey <tromey@redhat.com>
8606 * buffer.c (syms_of_buffer): Remove obsolete comment.
8608 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8610 * termhooks.h (encode_terminal_code): Declare prototype.
8612 * msdos.c (encode_terminal_code): Don't declare prototype.
8614 * term.c (encode_terminal_code): Now external again, used by
8615 w32console.c and msdos.c.
8617 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8618 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8620 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8622 Fix some minor problems found by GCC 4.5.2's static checks.
8624 * fringe.c (update_window_fringes): Mark locals as initialized
8626 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8628 * alloc.c (mark_fringe_data): Move decl from here ...
8629 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8630 to check its interface.
8631 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8633 * fontset.c (free_realized_fontset): Now static.
8634 (Fset_fontset_font): Rename local to avoid shadowing.
8635 (fontset_font): Mark local as initialized.
8636 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8638 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8640 * xselect.c (x_disown_buffer_selections): Remove; not used.
8641 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8642 (x_own_selection, Fx_disown_selection_internal): Rename locals
8644 (x_handle_dnd_message): Remove local to avoid shadowing.
8646 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8647 so that the caller can use some name other than gcpro1.
8648 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8649 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8650 (Fx_backspace_delete_keys_p):
8651 Use them to avoid shadowing, and rename vars to avoid shadowing.
8652 (x_decode_color, x_set_name, x_window): Now static.
8653 (Fx_create_frame): Add braces to silence GCC warning.
8654 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8655 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8656 Remove unused locals.
8657 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8658 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8659 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8662 * xterm.h (x_mouse_leave): New decl.
8664 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8665 Remove unused functions.
8666 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8667 (x_calc_absolute_position): Now static.
8668 (XTread_socket): Don't define label "out" unless it's used.
8669 Don't declare local "event" unless it's used.
8670 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8671 unless they are used.
8672 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8673 (x_fatal_error_signal): Remove; not used.
8674 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8675 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8676 (x_error_catcher, x_connection_closed, x_error_handler):
8677 (x_error_quitter, xembed_send_message, x_iconify_frame):
8678 (my_log_handler): Rename locals to avoid shadowing.
8679 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8680 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8682 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8683 Rename or move locals to avoid shadowing.
8684 (tty_defined_color, merge_face_heights): Now static.
8685 (free_realized_faces_for_fontset): Remove; not used.
8686 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8687 does not deduce is never used uninitialized.
8688 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8689 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8691 * terminal.c (store_terminal_param): Now static.
8693 * xmenu.c (menu_highlight_callback): Now static.
8694 (set_frame_menubar): Remove unused local.
8695 (xmenu_show): Rename parameter to avoid shadowing.
8696 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8697 since they might point to immutable storage.
8698 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8699 since it's unused otherwise.
8701 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8702 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8703 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8704 avoids a gcc -Wuninitialized diagnostic.
8705 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8706 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8707 does not deduce are never used uninitialized.
8709 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8711 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8712 * window.c (window_loop, size_window):
8713 (run_window_configuration_change_hook, enlarge_window): Likewise.
8715 * window.c (display_buffer): Now static.
8716 (size_window): Mark variables that gcc -Wuninitialized
8717 does not deduce are never used uninitialized.
8718 * window.h (check_all_windows): New decl, to forestall
8719 gcc -Wmissing-prototypes diagnostic.
8720 * dispextern.h (bidi_dump_cached_states): Likewise.
8722 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8724 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8726 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8727 and to avoid gcc -Wuninitialized warning.
8728 (load_charset_map): Mark variables that gcc -Wuninitialized
8729 does not deduce are never used uninitialized.
8730 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8732 * coding.c (coding_set_source, coding_set_destination):
8733 Use "else { /* comment */ }" rather than "else /* comment */;"
8734 for clarity, and to avoid gcc -Wempty-body warning.
8735 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8736 a block, when the outer 'i' will do.
8737 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8738 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8739 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8740 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8741 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8742 Rename locals to avoid shadowing.
8743 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8744 * coding.c (emacs_mule_char, encode_invocation_designation):
8745 Now static, since they're not used elsewhere.
8746 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8747 (decode_coding_object, encode_coding_object, detect_coding_system):
8748 (decode_coding_emacs_mule): Mark variables that gcc
8749 -Wuninitialized does not deduce are never used uninitialized.
8750 (detect_coding_iso_2022): Initialize a local variable that might
8751 be used uninitialized. Leave a FIXME because it's not clear that
8752 this initialization is needed. (Bug#8211)
8753 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8754 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8755 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8756 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8757 Remove unused macros.
8759 * category.c (hash_get_category_set): Remove unused local var.
8760 (copy_category_table): Now static, since it's not used elsewhere.
8761 * character.c (string_count_byte8): Likewise.
8763 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8764 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8766 * chartab.c (copy_sub_char_table): Now static, since it's not used
8768 (sub_char_table_ref_and_range, char_table_ref_and_range):
8769 Rename locals to avoid shadowing.
8770 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8772 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8773 (BIDI_BOB): Remove unused macro.
8775 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8776 deduce are never used uninitialized.
8777 * term.c (encode_terminal_code): Likewise.
8779 * term.c (encode_terminal_code): Now static. Remove unused local.
8781 * tparam.h: New file.
8782 * term.c, tparam.h: Include it.
8783 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8784 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8785 Move these decls to tparam.h, and make them agree with what
8786 is actually in tparam.c. The previous trick of using incompatible
8787 decls in different modules does not conform to the C standard.
8788 All callers of tparam changed to use tparam's actual API.
8789 * tparam.c (tparam1, tparam, tgoto):
8790 Use const pointers where appropriate.
8792 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8793 * cm.h (struct cm): Likewise.
8794 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8795 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8796 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8797 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8798 (turn_on_face, init_tty): Likewise.
8799 * termchar.h (struct tty_display_info): Likewise.
8801 * term.c (term_mouse_position): Rename local to avoid shadowing.
8803 * alloc.c (mark_ttys): Move decl from here ...
8804 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8806 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8808 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8810 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8812 * search.c (compile_pattern_1): Remove argument regp, unused since
8813 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8814 (compile_pattern): Don't pass it.
8816 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8818 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8819 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8821 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8823 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8825 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8826 gdk_window_get_screen, gdk_window_get_geometry,
8827 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8828 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8829 (xg_get_pixbuf_from_pixmap): New function.
8830 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8831 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8832 Call xg_get_pixbuf_from_pixmap instead of
8833 gdk_pixbuf_get_from_drawable.
8834 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8835 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8836 (xg_check_special_colors): Use GtkStyleContext and its functions
8838 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8839 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8840 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8841 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8842 Call gtk_widget_get_preferred_size.
8843 (xg_frame_resized): gdk_window_get_geometry only takes 5
8845 (xg_win_to_widget, xg_event_is_for_menubar):
8846 Call gdk_x11_window_lookup_for_display.
8847 (xg_set_widget_bg): New function.
8848 (delete_cb): New function.
8849 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8850 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
8851 (xg_set_background_color): Call xg_set_widget_bg.
8852 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8853 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8854 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8855 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8857 (update_frame_tool_bar): Call gtk_widget_hide.
8858 (xg_initialize): Use GDK_KEY_g.
8860 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8862 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8864 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8865 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8866 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8868 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8870 * w32xfns.c (select_palette): Check success of RealizePalette against
8871 GDI_ERROR, not zero.
8873 See ChangeLog.11 for earlier changes.
8879 Copyright (C) 2011 Free Software Foundation, Inc.
8881 This file is part of GNU Emacs.
8883 GNU Emacs is free software: you can redistribute it and/or modify
8884 it under the terms of the GNU General Public License as published by
8885 the Free Software Foundation, either version 3 of the License, or
8886 (at your option) any later version.
8888 GNU Emacs is distributed in the hope that it will be useful,
8889 but WITHOUT ANY WARRANTY; without even the implied warranty of
8890 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8891 GNU General Public License for more details.
8893 You should have received a copy of the GNU General Public License
8894 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.