]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Don't use FILE_SYSTEM_CASE in MS-DOS, or anywhere else.
[gnu-emacs] / src / ChangeLog
1 2012-07-14 Eli Zaretskii <eliz@gnu.org>
2
3 Remove FILE_SYSTEM_CASE.
4 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
5
6 * fileio.c (FILE_SYSTEM_CASE): Don't define.
7 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
8 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
9 call-process-region passes it through expand-file-name.
10
11 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
12
13 2012-07-12 Andreas Schwab <schwab@linux-m68k.org>
14
15 Fix crash when creating indirect buffer (Bug#11917)
16 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
17 Don't handle unbound variables specially if non-zero.
18 (Fbuffer_local_variables): Pass zero.
19 (clone_per_buffer_values): Pass non-zero.
20
21 2012-06-28 Andreas Schwab <schwab@linux-m68k.org>
22
23 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
24 to make the loop interruptible.
25
26 2012-06-26 Andreas Schwab <schwab@linux-m68k.org>
27
28 * gnutls.c (emacs_gnutls_handshake): Only retry if
29 GNUTLS_E_INTERRUPTED.
30
31 2012-06-23 Eli Zaretskii <eliz@gnu.org>
32
33 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
34 in the logic of incrementing and decrementing the value of
35 use_relocatable_buffers.
36
37 2012-06-21 Glenn Morris <rgm@gnu.org>
38
39 * charset.c (init_charset): Make lack of etc/charsets fatal.
40
41 2012-06-11 Jan Djärv <jan.h.d@swipnet.se>
42
43 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
44 referenced (Bug#11583).
45
46 2012-06-01 Chong Yidong <cyd@gnu.org>
47
48 * Version 24.1 released.
49
50 2012-05-30 Eli Zaretskii <eliz@gnu.org>
51
52 * xdisp.c (handle_stop): Detect whether we have overlay strings
53 loaded by testing it->current.overlay_string_index to be
54 non-negative, instead of checking whether n_overlay_strings is
55 positive. (Bug#11587)
56
57 2012-05-30 Chong Yidong <cyd@gnu.org>
58
59 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
60
61 * doc.c (Fsubstitute_command_keys): Doc fix.
62
63 2012-05-29 Eli Zaretskii <eliz@gnu.org>
64
65 * search.c (search_buffer): Remove calls to
66 r_alloc_inhibit_buffer_relocation, as it is now called by
67 maybe_unify_char, which was the cause of relocation of buffer text
68 in bug#11519.
69
70 2012-05-23 Eli Zaretskii <eliz@gnu.org>
71
72 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
73 for the duration of call to load_charset, to avoid problems with
74 callers of maybe_unify_char that access buffer text through C
75 pointers.
76
77 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
78 decrement the inhibition flag, instead of just setting or
79 resetting it.
80
81 2012-05-24 Ken Brown <kbrown@cornell.edu>
82
83 * callproc.c (Fcall_process): Restore a line that was accidentally
84 commented out in the 2011-02-13 change (bug#11547).
85
86 2012-05-23 Eli Zaretskii <eliz@gnu.org>
87
88 * lisp.h [REL_ALLOC]: Add prototypes for external functions
89 defined on ralloc.c.
90
91 * buffer.c [REL_ALLOC]: Remove prototypes of
92 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
93 they are now on lisp.h.
94
95 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
96
97 * search.c (search_buffer): Use it to inhibit relocation of buffer
98 text while re_search_2 is doing its job, because re_search_2 is
99 passed C pointers to buffer text. (Bug#11519)
100
101 2012-05-21 Eli Zaretskii <eliz@gnu.org>
102
103 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
104 Update value to 24.
105
106 2012-05-19 Eli Zaretskii <eliz@gnu.org>
107
108 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
109 state after an additional call to move_it_in_display_line_to, keep
110 the values of it->max_ascent and it->max_descent found for the
111 entire line.
112 (pos_visible_p): Revert the comparison against bottom_y to what it
113 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
114 (Bug#11464)
115
116 2012-05-15 Eli Zaretskii <eliz@gnu.org>
117
118 * xdisp.c (pos_visible_p): Fix last change. (Bug#11464)
119
120 2012-05-13 Eli Zaretskii <eliz@gnu.org>
121
122 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
123 already have overlays loaded.
124 (handle_single_display_spec): Before returning without displaying
125 fringe bitmap, synchronize the bidi iterator with the main display
126 iterator, by calling iterate_out_of_display_property.
127 (iterate_out_of_display_property): Detect buffer iteration by
128 testing that it->string is a Lisp string.
129 (get_next_display_element): When the current object is exhausted,
130 and there's something on it->stack, call set_iterator_to_next to
131 proceed with what's on the stack, instead of returning zero.
132 (set_iterator_to_next): If called at the end of a Lisp string,
133 proceed to consider_string_end without incrementing string
134 position. Don't increment display vector index past the end of
135 the display vector. (Bug#11417)
136 (pos_visible_p): Don't report a position visible when move_it_to
137 stopped at the last line of window, which happens to be scanned
138 backwards by the bidi iteration. (Bug#11464)
139
140 2012-05-11 Eli Zaretskii <eliz@gnu.org>
141
142 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
143 and right-margin display specs even if the spec is invalid or we
144 are on a TTY, and thus unable to display on the fringes. That's
145 because the text with the property will not be displayed anyway,
146 so we need to signal to the caller that this is a "replacing"
147 display spec. This fixes display when the spec is invalid or we
148 are on a TTY.
149
150 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
151
152 * unexaix.c (make_hdr): Fix typo in prototype.
153 This bug broke the build on AIX. Problem reported by Gilles Pion.
154
155 2012-05-05 Eli Zaretskii <eliz@gnu.org>
156
157 * w32proc.c (new_child): Force Windows to reserve only 64KB of
158 stack for each reader_thread, instead of defaulting to 8MB
159 determined by the linker. This avoids failures in creating
160 subprocesses on Windows 7, see the discussion in this thread:
161 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
162
163 2012-05-02 Jim Meyering <meyering@redhat.com>
164
165 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
166
167 2012-04-29 Eli Zaretskii <eliz@gnu.org>
168
169 * xdisp.c (pos_visible_p): If already at a newline from the
170 display string before the 'while' loop, don't walk back the glyphs
171 from it3.glyph_row. Solves assertion violation when the display
172 string begins with a newline (egg.el). (Bug#11367)
173
174 2012-04-24 Chong Yidong <cyd@gnu.org>
175
176 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
177
178 2012-04-23 Eli Zaretskii <eliz@gnu.org>
179
180 * xdisp.c (pos_visible_p): If the window start position is beyond
181 ZV, start the display from buffer beginning. Prevents assertion
182 violation in init_iterator when the minibuffer window is scrolled
183 via the scroll bar.
184
185 * window.c (window_scroll_pixel_based): Likewise.
186
187 2012-04-23 Chong Yidong <cyd@gnu.org>
188
189 * keymap.c (where_is_internal): Doc fix (Bug#10872).
190
191 2012-04-20 Glenn Morris <rgm@gnu.org>
192
193 * fileio.c (Fcopy_file, Fset_file_selinux_context):
194 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
195
196 2012-04-20 Eli Zaretskii <eliz@gnu.org>
197
198 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
199 overrun array limits of glyph row's used[] array. (Bug#11288)
200
201 2012-04-20 Chong Yidong <cyd@gnu.org>
202
203 * process.c (wait_reading_process_output): If EIO occurs on a pty,
204 set the status to "failed" and ensure that sentinel is run.
205
206 2012-04-18 Glenn Morris <rgm@gnu.org>
207
208 * process.c (Fset_process_inherit_coding_system_flag)
209 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
210 (Fmake_network_process, Fmake_serial_process): Doc fix.
211
212 2012-04-17 Eli Zaretskii <eliz@gnu.org>
213
214 * xdisp.c (string_buffer_position_lim): Limit starting position to
215 BEGV.
216 (set_cursor_from_row): If called for a mode-line or header-line
217 row, return zero immediately.
218 (try_cursor_movement): If inside continuation line, don't back up
219 farther than the first row after the header line, if any. Don't
220 consider the header-line row as "partially visible", even if
221 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
222
223 2012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
224
225 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
226
227 2012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
228
229 * process.c (make_process):
230 * process.h: Add integer `gnutls_handshakes_tried' member to
231 process struct.
232
233 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
234 Add convenience `GNUTLS_LOG2i' macro.
235
236 * gnutls.c (gnutls_log_function2i): Convenience log function.
237 (emacs_gnutls_read): Use new log functions,
238 `gnutls_handshakes_tried' process member, and
239 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
240 attempts per process (connection).
241
242 2012-04-09 Eli Zaretskii <eliz@gnu.org>
243
244 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
245 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
246
247 2012-04-09 Jan Djärv <jan.h.d@swipnet.se>
248
249 * nsterm.m (constrainFrameRect): Always constrain when there is only
250 one screen (Bug#10962).
251
252 2012-04-06 Eli Zaretskii <eliz@gnu.org>
253
254 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
255 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
256 about subtle differences between FETCH_CHAR* and STRING_CHAR*
257 macros related to unification of CJK characters. For the details,
258 see the discussion following the message here:
259 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
260
261 2012-04-04 Chong Yidong <cyd@gnu.org>
262
263 * keyboard.c (Vdelayed_warnings_list): Doc fix.
264
265 2012-04-01 Eli Zaretskii <eliz@gnu.org>
266
267 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
268 instead of alloca. (Bug#11138)
269
270 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
271
272 * w32menu.c (is_simple_dialog): Properly check lisp types.
273 (Bug#11141)
274
275 2012-03-31 Eli Zaretskii <eliz@gnu.org>
276
277 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
278 position we get to after a call to move_it_to fails the
279 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
280 only if we wind up in a string from display property. (Bug#11063)
281
282 * window.c (Fdelete_other_windows_internal): Invalidate the row
283 and column information about mouse highlight, so that redisplay
284 restores it after reallocating the glyph matrices. (Bug#7464)
285
286 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
287 string comes from a `display' text property, use the buffer
288 position of that property as if we actually saw that position in
289 the row's glyphs.
290 (move_it_by_lines): Remove the assertion that
291 "it->current_x == 0 && it->hpos == 0" which can be legitimately
292 violated when there's a before-string at the beginning of a line.
293 (Bug#11063)
294
295 2012-03-30 Eli Zaretskii <eliz@gnu.org>
296
297 * xdisp.c (append_space_for_newline): If the default face was
298 remapped, use the remapped face for the appended newline.
299 (extend_face_to_end_of_line): Use the remapped default face for
300 extending the face to the end of the line.
301 (display_line): Call extend_face_to_end_of_line when the default
302 face was remapped. (Bug#11068)
303
304 2012-03-29 Eli Zaretskii <eliz@gnu.org>
305
306 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
307
308 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
309
310 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
311
312 2012-03-27 Glenn Morris <rgm@gnu.org>
313
314 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
315 Doc fixes.
316
317 2012-03-26 Kenichi Handa <handa@m17n.org>
318
319 * dispextern.h (struct glyph): Fix previous change. Change the
320 bit length of glyphless.ch to 25 (Bug#11082).
321
322 2012-03-26 Chong Yidong <cyd@gnu.org>
323
324 * keyboard.c (Vselection_inhibit_update_commands): New variable.
325 (command_loop_1): Use it; inhibit selection update for
326 handle-select-window too (Bug#8996).
327
328 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
329
330 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
331
332 2012-03-25 Kenichi Handa <handa@m17n.org>
333
334 * dispextern.h (struct glyph): Change the bit length of
335 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
336
337 2012-03-24 Eli Zaretskii <eliz@gnu.org>
338
339 * s/ms-w32.h (tzname): Include time.h before redirecting to
340 _tzname. Fixes the MSVC build. (Bug#9960)
341
342 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
343
344 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
345 characters.
346
347 * xterm.c (XTread_socket): Only modify handling_signal if
348 !SYNC_INPUT. (Bug#11080)
349
350 2012-03-23 Eli Zaretskii <eliz@gnu.org>
351
352 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
353 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
354 when fetching a multibyte character consumes more bytes than
355 CHAR_BYTES returns, due to unification of CJK characters in
356 string_char. (Bug#11073)
357
358 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
359
360 * process.c (wait_reading_process_output): Handle pty disconnect
361 by refraining from sending oneself a SIGCHLD (bug#10933).
362
363 2012-03-22 Chong Yidong <cyd@gnu.org>
364
365 * dispextern.h (struct it): New member string_from_prefix_prop_p.
366
367 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
368 Mark string as coming from a prefix property.
369 (handle_face_prop): Use default face for prefix strings (Bug#4281).
370 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
371
372 2012-03-21 Chong Yidong <cyd@gnu.org>
373
374 * xfaces.c (Vface_remapping_alist): Doc fix.
375
376 2012-03-20 Eli Zaretskii <eliz@gnu.org>
377
378 * w32proc.c (Fw32_set_console_codepage)
379 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
380 Doc fixes.
381
382 2012-03-20 Chong Yidong <cyd@gnu.org>
383
384 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
385 to reflect default non-nil value of redisplay-dont-pause.
386
387 2012-03-19 Kenichi Handa <handa@m17n.org>
388
389 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
390 it fit in a valid range (Bug#11003).
391
392 2012-03-18 Eli Zaretskii <eliz@gnu.org>
393
394 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
395 that is not from display property, accept the row as a "cursor
396 row" if one of the string's character has a non-nil `cursor'
397 property. Fixes cursor positioning when there are newlines in
398 overlay strings, e.g. in icomplete.el. (Bug#11035)
399
400 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
401
402 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
403
404 2012-03-12 Chong Yidong <cyd@gnu.org>
405
406 * eval.c (inhibit_lisp_code): Rename from
407 inhibit_window_configuration_change_hook; move from window.c.
408
409 * xfns.c (unwind_create_frame_1, Fx_create_frame):
410 * window.c (run_window_configuration_change_hook)
411 (syms_of_window): Callers changed.
412
413 2012-03-11 Chong Yidong <cyd@gnu.org>
414
415 * keymap.c (Fkey_description): Doc fix (Bug#9700).
416
417 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
418
419 2012-03-10 Chong Yidong <cyd@gnu.org>
420
421 * frame.c (other_visible_frames): Don't assume the selected frame
422 is visible (Bug#10955).
423
424 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
425
426 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
427
428 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
429
430 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
431 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
432 zero (Bug#10954).
433
434 2012-03-03 Glenn Morris <rgm@gnu.org>
435
436 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
437
438 2012-03-02 Eli Zaretskii <eliz@gnu.org>
439
440 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
441 position past the first glyph_row that ends at ZV. (Bug#10902)
442 (redisplay_window, next_element_from_string): Fix typos in
443 comments.
444 (redisplay_window): Pass to move_it_vertically the margin in
445 pixels, not in screen lines.
446
447 2012-03-02 Glenn Morris <rgm@gnu.org>
448
449 * buffer.c (buffer-list-update-hook): Doc fix.
450
451 2012-02-29 Eli Zaretskii <eliz@gnu.org>
452
453 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
454 push_it before setting up the iterator for the first overlay
455 string, even if we have an empty string loaded.
456 (next_overlay_string): If there's an empty string on the iterator
457 stack, pop the stack. (Bug#10903)
458
459 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
460
461 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
462 Suggested by Stefan Monnier in
463 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
464 * alloc.c (widen_to_Lisp_Object): New static function.
465 (mark_memory): Also mark Lisp_Objects by fetching pointer words
466 and widening them to Lisp_Objects. This would work even if
467 USE_LSB_TAG is defined and wide integers are used, which might
468 happen in a future version of Emacs.
469
470 2012-02-25 Chong Yidong <cyd@gnu.org>
471
472 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
473 Doc fix.
474
475 * xselect.c (Fx_selection_exists_p): Doc fix.
476 (x_clipboard_manager_save_all): Print an informative message
477 before saving to clipboard manager.
478
479 2012-02-24 Chong Yidong <cyd@gnu.org>
480
481 * keyboard.c (process_special_events): Handle all X selection
482 requests in kbd_buffer, not just the next one (Bug#8869).
483
484 2012-02-23 Chong Yidong <cyd@gnu.org>
485
486 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
487 call when setting menu-bar-lines and tool-bar-lines parameters.
488 (unwind_create_frame_1): New helper function.
489
490 * window.c (inhibit_window_configuration_change_hook): New var.
491 (run_window_configuration_change_hook): Obey it.
492 (syms_of_window): Initialize it.
493
494 2012-02-22 Chong Yidong <cyd@gnu.org>
495
496 * xterm.c (x_draw_image_relief): Add missing type check for
497 Vtool_bar_button_margin (Bug#10743).
498
499 2012-02-21 Chong Yidong <cyd@gnu.org>
500
501 * fileio.c (Vfile_name_handler_alist): Doc fix.
502
503 * buffer.c (Fget_file_buffer): Protect against invalid file
504 handler return value.
505
506 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
507
508 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
509 when computing $valmask.
510
511 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
512 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
513 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
514 It's useless in that case, and it can cause problems on hosts
515 that allocate halves of EMACS_INT values separately.
516 Reported by Dan Horák. Diagnosed by Andreas Schwab in
517 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
518 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
519 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
520 it avoids undefined behavior on hosts where shifting right by more
521 than the word width has undefined behavior.
522
523 2012-02-19 Chong Yidong <cyd@gnu.org>
524
525 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
526 (Funhandled_file_name_directory, Ffile_name_as_directory)
527 (Fdirectory_file_name, Fexpand_file_name)
528 (Fsubstitute_in_file_name): Protect against invalid file handler
529 return values (Bug#10845).
530
531 2012-02-18 Eli Zaretskii <eliz@gnu.org>
532
533 * .gdbinit (pitx): Fix incorrect references to fields of the
534 iterator stack.
535
536 2012-02-17 Chong Yidong <cyd@gnu.org>
537
538 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
539
540 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
541
542 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
543 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
544
545 2012-02-15 Chong Yidong <cyd@gnu.org>
546
547 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
548 marked as special. Also, starting docstrings with * is obsolete.
549
550 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
551
552 * gnutls.c (emacs_gnutls_write): Fix last change.
553
554 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
555
556 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
557 send_process.
558
559 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
560
561 * keymap.c (Fsingle_key_description): Handle char ranges.
562
563 2012-02-12 Chong Yidong <cyd@gnu.org>
564
565 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
566 as that creates a dangerous corner case.
567
568 * window.c (Fdelete_window_internal): Invalidate the mouse
569 highlight (Bug#9904).
570
571 2012-02-12 Glenn Morris <rgm@gnu.org>
572
573 * xselect.c (Fx_own_selection_internal)
574 (Fx_get_selection_internal, Fx_disown_selection_internal)
575 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
576 * nsselect.m (Fx_own_selection_internal)
577 (Fx_disown_selection_internal, Fx_selection_exists_p)
578 (Fx_selection_owner_p, Fx_get_selection_internal):
579 Sync docs and argument specs with the xselect.c versions.
580
581 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
582
583 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
584
585 2012-02-11 Eli Zaretskii <eliz@gnu.org>
586
587 * w32select.c (Fx_selection_exists_p): Sync doc string and
588 argument list with xselect.c. (Bug#10783)
589
590 * w16select.c (Fx_selection_exists_p): Sync doc string and
591 argument list with xselect.c. (Bug#10783)
592
593 2012-02-10 Glenn Morris <rgm@gnu.org>
594
595 * fns.c (Fsecure_hash): Doc fix.
596
597 2012-02-09 Kenichi Handa <handa@m17n.org>
598
599 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
600
601 2012-02-07 Chong Yidong <cyd@gnu.org>
602
603 * buffer.c (Fbuffer_local_variables)
604 (buffer_lisp_local_variables): Handle unbound vars correctly;
605 don't let Qunbound leak into Lisp.
606
607 2012-02-07 Glenn Morris <rgm@gnu.org>
608
609 * image.c (Fimagemagick_types): Doc fix.
610
611 * image.c (imagemagick-render-type): Change it from a lisp object
612 to an integer. Move the doc here from the lisp manual.
613 Treat all values not equal to 0 the same.
614
615 2012-02-06 Chong Yidong <cyd@gnu.org>
616
617 * doc.c (store_function_docstring): Avoid applying docstring of
618 alias to base function (Bug#2603).
619
620 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
621
622 * .gdbinit (pp1, pv1): Remove redundant defines.
623 (pr): Use pp.
624
625 2012-02-04 Chong Yidong <cyd@gnu.org>
626
627 * nsterm.m: Declare a global (Bug#10694).
628
629 2012-02-04 Eli Zaretskii <eliz@gnu.org>
630
631 * w32.c (get_emacs_configuration_options):
632 Include --enable-checking, if specified, in the return value.
633
634 2012-02-04 Martin Rudalics <rudalics@gmx.at>
635
636 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
637 after rounding frame sizes. (Bug#9723)
638
639 2012-02-04 Eli Zaretskii <eliz@gnu.org>
640
641 * keyboard.c (adjust_point_for_property): Don't position point
642 before BEGV. (Bug#10696)
643
644 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
645
646 Handle overflow when computing char display width (Bug#9496).
647 * character.c (char_width): Return EMACS_INT, not int.
648 (char_width, c_string_width): Check for overflow when
649 computing the width; this is possible now that individual
650 characters can have unbounded width. Problem introduced
651 by merge from Emacs 23 on 2012-01-19.
652
653 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
654
655 * dbusbind.c (Fdbus_register_method): Mention the return value
656 :ignore in the docstring.
657
658 2012-02-02 Glenn Morris <rgm@gnu.org>
659
660 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
661
662 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
663 Unconditionally set to t. (Bug#10673)
664 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
665 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
666 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
667
668 2012-02-02 Kenichi Handa <handa@m17n.org>
669
670 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
671 0, do not call append_composite_glyph.
672
673 2012-02-02 Kenichi Handa <handa@m17n.org>
674
675 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
676 NULL (Bug#6988).
677 (x_produce_glyphs): If the component of a composition is a null
678 string, set it->pixel_width to 1 to avoid zero-width glyph.
679
680 2012-02-01 Eli Zaretskii <eliz@gnu.org>
681
682 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
683 first 2 arguments are identical. This makes inserting large
684 output from a subprocess an order of magnitude faster on
685 MS-Windows, where all sbrk'ed memory is always contiguous.
686
687 2012-01-31 Glenn Morris <rgm@gnu.org>
688
689 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
690 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
691 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
692
693 2012-01-29 Glenn Morris <rgm@gnu.org>
694
695 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
696
697 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
698
699 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
700
701 2012-01-28 Chong Yidong <cyd@gnu.org>
702
703 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
704
705 2012-01-26 Chong Yidong <cyd@gnu.org>
706
707 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
708
709 * search.c (Fsearch_forward, Fsearch_backward): Document negative
710 repeat counts (Bug#10507).
711
712 2012-01-26 Glenn Morris <rgm@gnu.org>
713
714 * lread.c (syms_of_lread): Doc fix.
715
716 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
717
718 * coding.c (encode_designation_at_bol): Change return value to
719 EMACS_INT.
720
721 2012-01-25 Chong Yidong <cyd@gnu.org>
722
723 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
724
725 2012-01-21 Chong Yidong <cyd@gnu.org>
726
727 * floatfns.c (Fcopysign): Make the second argument non-optional,
728 since nil is not allowed anyway.
729
730 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
731
732 * process.c (read_process_output): Use p instead of XPROCESS (proc).
733 (send_process): Likewise.
734
735 2012-01-19 Martin Rudalics <rudalics@gmx.at>
736
737 * window.c (save_window_save, Fcurrent_window_configuration)
738 (Vwindow_persistent_parameters): Do not use Qstate.
739 Rewrite doc-strings.
740
741 2012-01-19 Kenichi Handa <handa@m17n.org>
742
743 * character.c (char_width): New function.
744 (Fchar_width, c_string_width, lisp_string_width):
745 Use char_width (Bug#9496).
746
747 2012-01-16 Martin Rudalics <rudalics@gmx.at>
748
749 * window.c (Vwindow_persistent_parameters): New variable.
750 (Fset_window_configuration, save_window_save): Handle persistent
751 window parameters.
752
753 2012-01-14 Eli Zaretskii <eliz@gnu.org>
754
755 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
756 thrashing the stack of the thread. (Bug#9087)
757
758 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
759
760 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
761
762 2012-01-11 Eli Zaretskii <eliz@gnu.org>
763
764 * xdisp.c (rows_from_pos_range): Handle the case where the
765 highlight ends on a newline. (Bug#10464)
766 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
767 he end column for display of highlight that ends on a newline
768 before a R2L line.
769
770 2012-01-11 Glenn Morris <rgm@gnu.org>
771
772 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
773 from load-path also when installation-directory is nil. (Bug#10208)
774
775 2012-01-10 Glenn Morris <rgm@gnu.org>
776
777 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
778
779 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
780 Update template values to be closer to their typical values these days.
781
782 2012-01-09 Eli Zaretskii <eliz@gnu.org>
783
784 * xdisp.c (rows_from_pos_range): Accept additional argument
785 DISP_STRING, and accept any glyph in a row whose object is that
786 string as eligible for mouse highlight. Fixes mouse highlight of
787 display strings from overlays. (Bug#10464)
788
789 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
790
791 emacs: fix an auto-save permissions race condition (Bug#10400)
792 * fileio.c (auto_saving_dir_umask): New static var.
793 (Fmake_directory_internal): Use it.
794 (do_auto_save_make_dir): Set it, instead of invoking chmod after
795 creating the directory. The old code temporarily assigns
796 too-generous permissions to the directory.
797 (do_auto_save_eh): Clear it.
798 (Fdo_auto_save): Catch all errors, not just file errors, so
799 that the var is always cleared.
800
801 2012-01-07 Eli Zaretskii <eliz@gnu.org>
802
803 * search.c (scan_buffer): Pass character positions to
804 know_region_cache, not byte positions. (Bug#6540)
805
806 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
807
808 * w32.c (sys_rename): Report EXDEV when rename of a directory
809 fails because the target is on another logical disk. (Bug#10284)
810
811 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
812
813 * xterm.c (x_embed_request_focus): New function.
814
815 * xterm.h: Add prototype.
816
817 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
818
819 2012-01-05 Glenn Morris <rgm@gnu.org>
820
821 * emacs.c (emacs_copyright): Update short copyright year to 2012.
822
823 2012-01-01 Eli Zaretskii <eliz@gnu.org>
824
825 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
826 Load gnutls_transport_set_lowat only if GnuTLS version is below
827 2.11.1.
828 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
829 GnuTLS versions below 2.11.1.
830
831 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
832
833 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
834 to the doc string advising against its use for altering the way
835 windows are scrolled.
836
837 2011-12-28 Kenichi Handa <handa@m17n.org>
838
839 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
840 coding-system ASCII compatible only when it does not produce BOM
841 on encoding (Bug#10383).
842
843 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
844
845 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
846 can scroll.
847 (create_and_show_popup_menu): Always use menu_position_func for
848 Gtk3 (Bug#10361).
849
850 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
851
852 * callint.c (Fcall_interactively): Don't truncate prompt string.
853
854 2011-12-23 Eli Zaretskii <eliz@gnu.org>
855
856 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
857 property that ends at ZV, so that the bidi iteration could be
858 resumed from there (after widening). (Bug#10360)
859
860 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
861
862 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
863
864 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
865
866 * nsterm.m (x_free_frame_resources):
867 Release f->output_data.ns->miniimage.
868 (ns_index_color): Fix indentation. Do not retain
869 color_table->colors[i].
870
871 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
872 before returning.
873
874 * nsfns.m (x_set_background_color): Assign return value from
875 ns_index_color to face-background instead of NSColor*.
876 (ns_implicitly_set_icon_type): Fix indentation.
877 Change assignment in for loop to comparison.
878
879 * emacs.c (ns_pool): New variable.
880 (main): Assign ns_pool.
881 (Fkill_emacs): Call ns_release_autorelease_pool.
882
883 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
884 autorelease fdesc, release fdAttrs and tdict.
885 (ns_get_covering_families): Release charset.
886 (ns_findfonts): Release NSFontDescriptor created with new.
887 (ns_uni_to_glyphs): Fix indentation.
888 (setString): Release attrStr before assigning new value.
889
890 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
891
892 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
893 and NS_IMPL_COCOA.
894 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
895 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
896
897 2011-12-18 David Reitter <reitter@cmu.edu>
898
899 * nsterm.m (ns_term_init): Subscribe for notifications
900 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
901 to method trackingNotification in EmacsMenu.
902
903 * nsmenu.m (trackingMenu): New variable.
904 (trackingNotification): New method (from Aquamacs).
905 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
906 from Aquamacs (Bug#7030).
907
908 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
909
910 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
911 (symbol_to_nsstring): Fix indentation.
912 (ns_symbol_to_pb): New function.
913 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
914 (Fns_rotate_cut_buffers_internal): Remove.
915 (Fns_store_selection_internal): Rename from
916 Fns_store_cut_buffer_internal.
917 (ns_get_foreign_selection, Fx_own_selection_internal)
918 (Fx_disown_selection_internal, Fx_selection_exists_p)
919 (Fns_get_selection_internal, Fns_store_selection_internal):
920 Use ns_symbol_to_pb and check if return value is nil.
921 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
922 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
923 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
924 renamed to Sns_store_selection_internal.
925 (ns_handle_selection_request): Move code to Fx_own_selection_internal
926 and remove this function.
927 (ns_handle_selection_clear): Remove, never used.
928 (Fx_own_selection_internal): Move code from ns_handle_selection_request
929 here.
930
931 2011-12-17 Ken Brown <kbrown@cornell.edu>
932
933 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
934 GID is unknown (Bug#10257).
935
936 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
937
938 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
939 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
940 which caused a build failure on GNU/Linux IA-64. This problem was
941 introduced by my 2011-10-07 patch.
942
943 2011-12-15 Juri Linkov <juri@jurta.org>
944
945 * image.c (imagemagick_error): New function. (Bug#10112)
946 (imagemagick_load_image): Comment out `MagickSetResolution' call.
947 Use `imagemagick_error' where ImageMagick functions return
948 `MagickFalse'.
949 (Fimagemagick_types): Add `Fnreverse' to return the list in the
950 proper order.
951
952 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
953
954 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
955 fill background (Bug#8992).
956
957 2011-12-13 Martin Rudalics <rudalics@gmx.at>
958
959 * window.c (Vwindow_combination_resize)
960 (Vwindow_combination_limit): Use t instead of non-nil in
961 doc-strings.
962 (Vrecenter_redisplay): Add first sentence of doc-string on
963 separate line.
964 (Frecenter): Fix doc-string typo.
965
966 2011-12-11 Kenichi Handa <handa@m17n.org>
967
968 * coding.c (Funencodable_char_position): Pay attention to the
969 buffer text relocation (Bug#9389).
970
971 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
972
973 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
974 gtk_init (Bug#10100).
975
976 2011-12-10 Eli Zaretskii <eliz@gnu.org>
977
978 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
979 IT->string is nil. (Bug#10263)
980
981 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
982
983 * nsterm.h (x_free_frame_resources): Declare.
984
985 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
986 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
987
988 * nsterm.h (ns_get_defaults_value): Declare.
989
990 * nsterm.m (ns_default): Call ns_get_defaults_value.
991
992 2011-12-09 Eli Zaretskii <eliz@gnu.org>
993
994 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
995 (Bug#10170)
996
997 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
998
999 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1000 that where the value of an _OBJC_* symbol points to is in the .bss
1001 section (Bug#10240).
1002
1003 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1004
1005 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1006 after the loop to call ccl_driver at least once (Bug#8619).
1007
1008 2011-12-08 Kenichi Handa <handa@m17n.org>
1009
1010 * ftfont.c (get_adstyle_property): Fix previous change
1011 (Bug#10233).
1012
1013 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1014
1015 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1016 dirs from the default value of EMACSLOADPATH (bug#10208).
1017
1018 2011-12-07 Glenn Morris <rgm@gnu.org>
1019
1020 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1021 installation and source directories as well. (Bug#10208)
1022
1023 2011-12-06 Chong Yidong <cyd@gnu.org>
1024
1025 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1026
1027 2011-12-06 Glenn Morris <rgm@gnu.org>
1028
1029 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1030 as an error, not just -1. (Bug#10217)
1031
1032 2011-12-05 Chong Yidong <cyd@gnu.org>
1033
1034 * keyboard.c (process_special_events): New function.
1035 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1036
1037 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1038
1039 * coding.c (encode_designation_at_bol): Don't use uninitialized
1040 local variable (Bug#9318).
1041
1042 2011-12-05 Kenichi Handa <handa@m17n.org>
1043
1044 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1045 return Qnil (Bug#8046, Bug#10193).
1046
1047 2011-12-05 Kenichi Handa <handa@m17n.org>
1048
1049 * coding.c (encode_designation_at_bol): New args charbuf_end and
1050 dst. Return the number of produced bytes. Callers changed.
1051 (coding_set_source): Return how many bytes coding->source was
1052 relocated.
1053 (coding_set_destination): Return how many bytes
1054 coding->destination was relocated.
1055 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1056 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1057
1058 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1059
1060 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1061 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1062 macro (Bug#9318).
1063
1064 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1065
1066 The following changes are to fix Bug#9318.
1067
1068 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1069 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1070 (encode_coding_iso_2022, encode_coding_sjis)
1071 (encode_coding_big5, encode_coding_charset): Use the above macros.
1072
1073 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1074
1075 * lisp.h (process_quit_flag): Fix external declaration.
1076
1077 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1078
1079 Don't macro-inline non-performance-critical code.
1080 * eval.c (process_quit_flag): New function.
1081 * lisp.h (QUIT): Use it.
1082
1083 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1084
1085 * nsfns.m (get_geometry_from_preferences): New function.
1086 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1087
1088 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1089
1090 * emacs.c (Qkill_emacs): Define.
1091 (syms_of_emacs): Initialize it.
1092 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1093 Qquit_flag to `kill-emacs' instead.
1094 (quit_throw_to_read_char): Add parameter `from_signal'.
1095 All callers changed. Call Fkill_emacs if requested and safe.
1096 * lisp.h (QUIT): Call Fkill_emacs if requested.
1097
1098 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1099
1100 * widget.c (update_wm_hints): Return if wmshell is null.
1101 (widget_update_wm_size_hints): New function.
1102
1103 * widget.h (widget_update_wm_size_hints): Declare.
1104
1105 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1106 widget_update_wm_size_hints (Bug#10104).
1107
1108 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1109
1110 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1111 before a newline, prepare the bidi iterator for consuming the
1112 newline, and keep the current paragraph direction. (Bug#10183)
1113 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1114
1115 2011-12-02 Juri Linkov <juri@jurta.org>
1116
1117 * search.c (Fword_search_regexp): New Lisp function created from
1118 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1119 (Fword_search_backward, Fword_search_forward)
1120 (Fword_search_backward_lax, Fword_search_forward_lax):
1121 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1122 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1123
1124 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1125
1126 * fileio.c (Finsert_file_contents): Move after-change-function call
1127 to before the "handled:" label, since all "goto handled" appear in
1128 cases where the *-change-functions have already been properly called
1129 (bug#10117).
1130
1131 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1132
1133 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1134 waiting for input. (Bug#10169)
1135
1136 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1137
1138 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1139 verifies glyph row's hash code--we have just reallocated the
1140 glyphs, so their contents can be complete garbage. (Bug#10164)
1141
1142 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1143
1144 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1145
1146 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1147
1148 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1149 attributes are tested _before_ calling verify_row_hash, to protect
1150 against GCC re-ordering of the tests. (Bug#10164)
1151
1152 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1153
1154 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1155
1156 * xterm.c (handle_one_xevent): Only set async_visible and friends
1157 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1158 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1159 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1160
1161 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1162
1163 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1164 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1165 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1166 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1167 All uses changed to use GCPRO1 etc.
1168 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1169 Revert to old implementation (i.e., before 2011-03-11).
1170
1171 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1172
1173 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1174 of scroll runs so as to avoid assigning disabled bogus rows and
1175 unnecessary graphics copy operations.
1176
1177 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1178
1179 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1180 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1181 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1182 (malloc, free, realloc, calloc): Redirect to e_* only when
1183 compiling Emacs.
1184
1185 * lisp.h (GCTYPEBITS): Move before first use.
1186 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1187 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1188 this macro definition.
1189
1190 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1191 _MSC_VER.
1192
1193 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1194
1195 * gtkutil.c (xg_create_frame_widgets):
1196 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1197 present with Gtk+ 2.0.
1198
1199 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1200
1201 * fileio.c (Finsert_file_contents): Undo previous change; see
1202 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1203
1204 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1205
1206 Rename locals to avoid shadowing.
1207 * fileio.c (Finsert_file_contents):
1208 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1209 * process.c (wait_reading_process_output):
1210 Rename inner 'proc' to 'p' to avoid shadowing.
1211 Indent for consistency with usual Emacs style.
1212
1213 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1214
1215 * xdisp.c (redisplay_window): If cursor row is not fully visible
1216 after recentering, and scroll-conservatively is set to a large
1217 number, scroll window by a few more lines to make the cursor fully
1218 visible and out of scroll-margin. (Bug#10105)
1219 (start_display): Don't move to the next line if the display should
1220 start at a newline that is part of a display vector or an overlay
1221 string. (Bug#10119)
1222
1223 2011-11-24 Juri Linkov <juri@jurta.org>
1224
1225 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1226 after the `MagickPingImage' call. (Bug#10112)
1227
1228 2011-11-23 Chong Yidong <cyd@gnu.org>
1229
1230 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1231
1232 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1233
1234 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1235 making another buffer current. (Bug#10114)
1236
1237 2011-11-23 Glenn Morris <rgm@gnu.org>
1238
1239 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1240
1241 2011-11-23 Chong Yidong <cyd@gnu.org>
1242
1243 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1244 using it (Bug#5984).
1245
1246 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1247
1248 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1249 and header-lines, as they don't have one computed for them.
1250 (Bug#10098)
1251
1252 * .gdbinit (prow): Make displayed values more self-explaining.
1253 Add row's hash code.
1254
1255 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1256
1257 * process.c (wait_reading_process_output): Fix asynchrounous
1258 GnuTLS socket handling on some versions of the GnuTLS library.
1259 (wait_reading_process_output): Add comment and URL.
1260
1261 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1262
1263 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1264
1265 2011-11-21 Chong Yidong <cyd@gnu.org>
1266
1267 * window.c (Fnext_window, Fprevious_window): Doc fix.
1268
1269 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1270
1271 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1272
1273 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1274
1275 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1276
1277 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1278
1279 * window.c (Fset_window_combination_limit): Rename argument
1280 STATUS to LIMIT.
1281 (Vwindow_combination_limit): Remove "status" from doc-string.
1282
1283 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1284
1285 * m/ibms390.h: Remove.
1286 * m/ibms390x.h: Don't include "ibms390.h".
1287
1288 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1289
1290 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1291 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1292
1293 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1294
1295 * casetab.c (Fset_case_table):
1296 * charset.c (Fcharset_after): Fix typos.
1297
1298 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1299
1300 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1301 Otherwise, valgrind does not work on some platforms.
1302 Problem reported by Andreas Schwab in
1303 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1304 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1305 is set, removing the need for VIRT_ADDRESS_VARIES.
1306 (PURE_P): Use a more-efficient implementation that needs just one
1307 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1308 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1309 to 4 (xorl, subq, cmpq, setbe).
1310 * alloc.c (pure): Always extern now, since that's the
1311 VIRT_ADDR_VARIES behavior.
1312 (PURE_POINTER_P): Use a single comparison, not two, for
1313 consistency with the new puresize.h.
1314 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1315 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1316 Remove VIRT_ADDR_VARIES no longer needed.
1317
1318 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1319
1320 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1321 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1322 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1323 behave as if the cursor position were at the window margin.
1324
1325 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1326 and the cursor position is out of bounds, behave as if the cursor
1327 position were at the window margin. (Bug#10075)
1328
1329 2011-11-18 Chong Yidong <cyd@gnu.org>
1330
1331 * window.c (Fwindow_combination_limit): Make first argument
1332 non-optional, since it is meaningless for live windows like the
1333 selected window.
1334
1335 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1336
1337 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1338
1339 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1340
1341 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1342 (graft_intervals_into_buffer): Simplify.
1343
1344 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1345
1346 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1347 hash values of the two rows.
1348 (copy_row_except_pointers): Preserve the used[] arrays and the
1349 hash values of the two rows. (Bug#10035)
1350 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1351
1352 * xdisp.c (row_hash): New function, body extracted from
1353 compute_line_metrics.
1354 (compute_line_metrics): Call row_hash, instead of computing the
1355 hash code inline.
1356
1357 * dispnew.c (verify_row_hash): Call row_hash for computing the
1358 hash code of a row, instead of duplicating code from xdisp.c.
1359
1360 * dispextern.h (row_hash): Add prototype.
1361
1362 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1363
1364 * frame.c (delete_frame): Don't delete the terminal when the last
1365 X frame is closed if emacs is built with GTK toolkit.
1366
1367 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1368
1369 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1370
1371 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1372
1373 * window.c (Vwindow_splits): Rename to
1374 Vwindow_combination_resize. Suggested by Juri Linkov.
1375 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1376 of Vwindow_splits.
1377
1378 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1379
1380 * nsfns.m (Fns_font_name):
1381 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1382
1383 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1384
1385 * window.h (window): Rename slot "nest" to "combination_limit".
1386 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1387 (Fset_window_nest): Rename to Fset_window_combination_limit.
1388 (Vwindow_nest): Rename to Vwindow_combination_limit.
1389 (recombine_windows, make_parent_window, make_window)
1390 (Fsplit_window_internal, saved_window)
1391 (Fset_window_configuration, save_window_save): Rename all
1392 occurrences of window_nest to window_combination_limit.
1393
1394 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1395
1396 * image.c (imagemagick_load_image): Fix typo.
1397
1398 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1399
1400 * xdisp.c (display_line): Move the call to
1401 highlight_trailing_whitespace before the call to
1402 compute_line_metrics, since the latter needs to see the final
1403 faces of all the glyphs to compute ROW's hash value.
1404 Fixes assertion violations in row_equal_p. (Bug#10035)
1405
1406 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1407
1408 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1409 just return (bug#10044).
1410
1411 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1412
1413 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1414 with user-defined heap size. Bump the default size of the temacs
1415 heap to 27MB, to avoid memory warning when running temacs.
1416 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1417
1418 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1419 current_matrix and desired_matrix. (Bug#9990)
1420 (verify_row_hash) [XASSERTS]: New function.
1421 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1422 that the hash value of glyph rows is correct.
1423
1424 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1425
1426 * window.h (window): Remove splits slot.
1427 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1428 (Fdelete_other_windows_internal, make_parent_window)
1429 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1430 (Fset_window_configuration, save_window_save): Don't deal with
1431 split status of windows.
1432 (saved_window): Remove splits slot.
1433 (Vwindow_splits): Rewrite doc-string.
1434
1435 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1436
1437 * xfns.c (unwind_create_frame):
1438 * nsfns.m (unwind_create_frame):
1439 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1440 Vframe_list (Bug#9999).
1441
1442 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1443
1444 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1445
1446 2011-11-11 Kenichi Handa <handa@m17n.org>
1447
1448 * callproc.c (Fcall_process): Set the member dst_multibyte of
1449 process_coding.
1450
1451 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1452
1453 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1454 avoid a crash (bug#9496).
1455
1456 2011-11-09 Chong Yidong <cyd@gnu.org>
1457
1458 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1459 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1460
1461 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1462
1463 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1464
1465 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1466
1467 Avoid some portability problems by eschewing 'extern inline' functions.
1468 The trivial performance wins aren't worth the portability hassles; see
1469 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1470 et seq.
1471 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1472 (window_box_width, window_box_left, window_box_left_offset)
1473 (window_box_right, window_box_right_offset): Undo previous change,
1474 by removing the "extern"s.
1475 * intervals.c (adjust_intervals_for_insertion)
1476 (adjust_intervals_for_deletion): Undo previous change,
1477 making these static again.
1478 (offset_intervals, temp_set_point_both, temp_set_point)
1479 (copy_intervals_to_string): No longer inline.
1480 * xdisp.c (window_text_bottom_y, window_box_width)
1481 (window_box_height, window_box_left_offset)
1482 (window_box_right_offset, window_box_left, window_box_right)
1483 (window_box): No longer inline.
1484
1485 2011-11-08 Chong Yidong <cyd@gnu.org>
1486
1487 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1488 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1489 Signal an error if not a live window.
1490 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1491 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1492
1493 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1494
1495 * lisp.h (syms_of_abbrev): Remove declaration.
1496 Reported by CHENG Gao <chenggao@royau.me>.
1497
1498 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1499
1500 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1501 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1502 of temacs in GUI mode.
1503
1504 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1505
1506 * window.h: Declare delete_all_child_windows instead of
1507 delete_all_subwindows.
1508 * window.c (Fwindow_nest, Fset_window_nest)
1509 (Fset_window_new_total, Fset_window_new_normal)
1510 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1511 (delete_all_subwindows): Rename to delete_all_child_windows.
1512 (Fdelete_other_windows_internal, Fset_window_configuration):
1513 Call delete_all_child_windows instead of delete_all_subwindows.
1514 * frame.c (delete_frame): Call delete_all_child_windows instead
1515 of delete_all_subwindows.
1516
1517 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1518
1519 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1520 This is also needed for porting to any host where GC_MARK_STACK is
1521 not GC_MAKE_GCPROS_NOOPS.
1522 (which_symbols): Use it.
1523
1524 2011-11-07 Kenichi Handa <handa@m17n.org>
1525
1526 * coding.c (coding_set_destination): Check coding->src_pos only
1527 when coding->src_object is a buffer (bug#9910).
1528
1529 * process.c (send_process): Set the member src_multibyte of coding
1530 to 0 (bug#9911) when sending a unibyte text.
1531
1532 * callproc.c (Fcall_process): Set the member src_multibyte of
1533 process_coding to 0 (bug#9912).
1534
1535 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1536
1537 * xmenu.c (cleanup_widget_value_tree): New function.
1538 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1539 calling free_menubar_widget_value_tree directly (Bug#9830).
1540
1541 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1542
1543 Fix some portability problems with 'inline'.
1544 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1545 (window_box_width, window_box_left, window_box_left_offset)
1546 (window_box_right, window_box_right_offset): Declare extern.
1547 Otherwise, these inline functions do not conform to C99 and
1548 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1549 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1550 * intervals.c (adjust_intervals_for_insertion)
1551 (adjust_intervals_for_deletion): Now extern, because otherwise the
1552 extern inline functions 'offset_intervals' couldn't refer to it.
1553 (static_offset_intervals): Remove.
1554 (offset_intervals): Rewrite using the old contents of
1555 static_offset_intervals. The old version didn't conform to C99
1556 because an extern inline function contained a reference to an
1557 identifier with static linkage.
1558
1559 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1560
1561 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1562 GC.
1563
1564 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1565
1566 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1567 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1568 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1569 return Qleft_to_right.
1570
1571 2011-11-06 Chong Yidong <cyd@gnu.org>
1572
1573 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1574 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1575 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1576 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1577 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1578 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1579 (Fwindow_vscroll): Doc fix.
1580 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1581 argument, since it makes no sense to pass a live window and for
1582 consistency with window-child.
1583
1584 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1585
1586 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1587 support MSVC.
1588
1589 2011-11-05 Jason Rumney <jasonr@gnu.org>
1590
1591 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1592 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1593 fonts (Bug#6029).
1594 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1595 bitwise arithmetic preventing use of unicode-sip and non-truetype
1596 opentype fonts.
1597
1598 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1599
1600 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1601 "emacs"-only part.
1602
1603 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1604 initialization code to keep similarity to xfns.c after changes
1605 from 2011-11-05.
1606
1607 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1608
1609 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1610 (unwind_create_frame): New function (Bug#9943).
1611 (Fx_create_frame): Restructure code to be more similar to the one in
1612 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1613 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1614 Move terminal->reference_count++ just before making the frame official
1615 (Bug#9943).
1616
1617 * nsterm.m (x_free_frame_resources): New function.
1618 (x_destroy_window): Move code to x_free_frame_resources.
1619
1620 * xfns.c (unwind_create_frame): Fix comment.
1621 (Fx_create_frame, x_create_tip_frame):
1622 Move terminal->reference_count++ just before making the frame
1623 official. Move initialization of image_cache_refcount and
1624 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1625
1626 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1627
1628 Support MSVC build with newer versions of Visual Studio.
1629 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1630 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1631 nt/gmake.defs.
1632
1633 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1634 which are not supported by MSVC.
1635 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1636 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1637 bitfields.
1638 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1639 types in bitfields.
1640 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1641
1642 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1643
1644 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1645
1646 Support MSVC build with newer versions of Visual Studio.
1647 * w32.c: Don't include w32api.h for MSVC.
1648 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1649
1650 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1651 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1652 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1653 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1654 e_* cousins.
1655 (alloca) [_MSC_VER]: Define to _alloca.
1656
1657 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1658
1659 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1660
1661 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1662
1663 * xdisp.c (note_mouse_highlight): If either of
1664 previous/next-single-property-change returns nil, treat that as
1665 the beginning or the end of the buffer. (Bug#9955)
1666
1667 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1668
1669 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1670 label is not null (Bug#9951).
1671 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1672 may be NULL.
1673
1674 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1675
1676 * window.c (Fwindow_body_size): Mention in the doc string that the
1677 return value is in frame's canonical units. (Bug#9949)
1678
1679 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1680
1681 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1682
1683 * w32fns.c (unwind_create_frame): If needed, free the glyph
1684 matrices of the partially constructed frame. (Bug#9943)
1685 * xfns.c (unwind_create_frame): Likewise.
1686
1687 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1688
1689 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1690 Don't stop backward scan on the continuation glyph, even though
1691 its CHARPOS is positive.
1692 (mouse_face_from_buffer_pos, note_mouse_highlight):
1693 Rename cover_string to disp_string.
1694
1695 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1696
1697 * window.c (temp_output_buffer_show): Don't use
1698 Vtemp_buffer_show_specifiers.
1699 (Vtemp_buffer_show_specifiers): Remove unused variable.
1700
1701 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1702
1703 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1704 past the beginning of the current glyph matrix.
1705
1706 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1707
1708 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1709 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1710 HAVE_GTK3 (Bug#9869).
1711
1712 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1713 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1714
1715 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1716
1717 * xterm.c: Declare x_handle_net_wm_state to return int.
1718 (handle_one_xevent): Check if we are iconified but don't have
1719 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1720 (get_current_wm_state): Return non-zero if not hidden,
1721 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1722 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1723 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1724 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1725
1726 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1727
1728 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1729 so that this new function doesn't get optimized away by a
1730 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1731
1732 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1733
1734 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1735
1736 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1737
1738 Fix the `xbytecode' command.
1739 * .gdbinit (xprintbytestr): New command.
1740 (xwhichsymbols): Rename from `which'; all callers changed.
1741 (xbytecode): Print the byte-code string as well.
1742
1743 2011-10-29 Kim Storm <storm@cua.dk>
1744
1745 * alloc.c (which_symbols): New function.
1746
1747 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1748
1749 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1750 line. (Bug#9903)
1751
1752 2011-10-29 Glenn Morris <rgm@gnu.org>
1753
1754 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1755 Not clear what it was for, and it causes various bugs. (Bug#9839)
1756
1757 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1758
1759 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1760 possible random value that matches one of those tested as
1761 condition to clear the mouse face.
1762
1763 2011-10-28 Chong Yidong <cyd@gnu.org>
1764
1765 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1766
1767 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1768
1769 * window.c (make_window): Initialize phys_cursor_on_p.
1770
1771 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1772
1773 * lisp.h (struct Lisp_Symbol): Update comments.
1774
1775 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1776
1777 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1778
1779 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1780
1781 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1782 <oslsachem@gmail.com> for helping to debug this.
1783
1784 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1785 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1786 (g_b_init_get_glyph_outline_w): New static variables.
1787 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1788 (GetGlyphOutlineW_Proc): New typedefs.
1789 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1790 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1791 New functions.
1792 (w32font_open_internal, compute_metrics):
1793 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1794 instead of calling the "wide" APIs directly.
1795
1796 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1797
1798 * w32.h (syms_of_w32font): Add prototype.
1799
1800 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1801
1802 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1803 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1804 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1805 (Fmove_to_window_line): Doc fix.
1806
1807 2011-10-27 Chong Yidong <cyd@gnu.org>
1808
1809 * process.c (make_process): Set gnutls_state to NULL.
1810
1811 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1812 non-NULL, regardless of GNUTLS_INITSTAGE.
1813 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1814 an error. Set process slots as soon as we allocate them.
1815
1816 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1817
1818 2011-10-27 Chong Yidong <cyd@gnu.org>
1819
1820 * gnutls.c (emacs_gnutls_deinit): New function.
1821 Deallocate credentials structures as well as calling gnutls_deinit.
1822 (Fgnutls_deinit, Fgnutls_boot): Use it.
1823
1824 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1825 (deactivate_process): Call emacs_gnutls_deinit.
1826
1827 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1828
1829 * image.c (x_create_x_image_and_pixmap):
1830 * w32.c (sys_rename, w32_delayed_load):
1831 * w32font.c (fill_in_logfont):
1832 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1833
1834 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1835
1836 * w32fns.c (w32_default_color_map): New function,
1837 extracted from Fw32_default_color_map.
1838 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1839
1840 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1841
1842 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1843
1844 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1845
1846 * keyboard.c (test_undefined): New function (bug#9751).
1847 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1848
1849 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1850
1851 * sysdep.c (init_sys_modes): Fix the check for the controlling
1852 terminal (Bug#6649).
1853
1854 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1855
1856 * dispextern.h (struct bidi_it): New member next_en_type.
1857
1858 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1859 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1860 current character, check also for next_en_type being WEAK_EN.
1861 (bidi_resolve_weak): Don't enter the expensive loop if the current
1862 position is before next_en_pos. Record the bidi type of the first
1863 non-ET, non-BN character we find, in addition to its position.
1864 (bidi_level_of_next_char): Invalidate next_en_type when
1865 next_en_pos is over-stepped.
1866
1867 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1868
1869 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1870 * editfns.c: Rewrite current-time-zone so that it invokes
1871 the equivalent of (format-time-string "%Z") to get the time zone name.
1872 This fixes a bug when the time zone name contains characters that
1873 need converting from the system time locale to Emacs internal format.
1874 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1875 that patch fixed format-time-string to do the conversion, but
1876 I forgot to fix current-time-zone.
1877 (format_time_string): New function, containing most of
1878 what Fformat_time_string used to contain.
1879 (Fformat_time_string): Rewrite in terms of format_time_string.
1880 This doesn't change this function's behavior.
1881 (current-time-zone): Rewrite to use format_time_string.
1882 This fixes the bug reported by Michael Schierl in
1883 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1884 Jason Rumney's 2007-06-07 change worked around this bug, but
1885 didn't fix it.
1886 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1887
1888 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1889
1890 * xdisp.c (start_display): If the character at POS is displayed
1891 via a display vector, reset IT->current.dpvec_index to zero.
1892 (try_window_reusing_current_matrix): If a line ends in a display
1893 vector or the next line starts in a display vector, continue
1894 redrawing the window even though the character position of
1895 start_row was reached.
1896 (Bug#9771, part 2)
1897
1898 2011-10-18 Chong Yidong <cyd@gnu.org>
1899
1900 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1901 with nobreak-char-display too.
1902
1903 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1904
1905 Fix part 3 of bug#9771.
1906 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1907 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1908 non-neutral characters if the current character is a paragraph
1909 separator (a.k.a. Newline). This avoids running the same
1910 expensive loop twice, once when we consume the preceding newline
1911 and the other time when the line actually needs to be displayed.
1912 Avoid the loop when we see neutrals on the base embedding level
1913 following a character whose directionality is the same as the
1914 paragraph's. This avoids running the expensive loop when a line
1915 ends in a long sequence of neutrals, like control characters.
1916 Add assertion against STRONG_AL type. Slightly rearrange code
1917 that determines the type of a neutral given the first non-neutral
1918 that follows it.
1919 (bidi_level_of_next_char): Set next_en_pos to zero when
1920 invalidating its info.
1921
1922 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1923
1924 * xdisp.c (push_display_prop): Determine whether to record string
1925 or buffer position by IT->string, not by IT->method. Allow
1926 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1927 (move_it_vertically_backward): Don't look for character position
1928 immediately after the newline when in a continuation line.
1929 (Bug#9771, part 1)
1930
1931 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1932
1933 * window.c (coordinates_in_window): Rewrite and delabelize
1934 vertical border check. (Bug#5357) (Bug#9618)
1935
1936 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1937
1938 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1939 errors in XSetWindowBorder (bug#9310).
1940
1941 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1942
1943 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1944 avoid crash when xmalloc overrun checking is enabled.
1945
1946 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1947
1948 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1949 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1950 cursor motion with <left> and <right> arrow keys.
1951
1952 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1953 some callers set that themselves.
1954
1955 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1956
1957 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1958 display string and the previous row comes from the same string and
1959 is empty. (Bug#9739) (Bug#9738)
1960
1961 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1962
1963 * doc.c (get_doc_string): Encode file name (bug#9735).
1964
1965 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1966
1967 * bidi.c (bidi_level_of_next_char):
1968 * xdisp.c (get_visually_first_element): Remove old incorrect
1969 comments regarding the Unicode Line Separator character.
1970
1971 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1972
1973 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1974
1975 * alloc.c (Fgc_status): Do not access beyond zombies array
1976 boundary if nzombies > MAX_ZOMBIES.
1977 * alloc.c (dump_zombies): Add missing format specifier.
1978
1979 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1980
1981 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1982 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1983
1984 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1985 Some packages use them to denote characters with modifiers.
1986
1987 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1988
1989 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1990 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1991 matching a pp-number. Rename parameter var to var1.
1992
1993 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1994
1995 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1996
1997 2011-10-08 Glenn Morris <rgm@gnu.org>
1998
1999 * callint.c (Fcall_interactively): Give a more explicit error for the
2000 'c' case with a non-character input. (Bug#8479)
2001
2002 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2003
2004 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2005 lines.
2006 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2007 lines that are hscrolled on the left.
2008
2009 * dispnew.c (buffer_posn_from_coords): Account for a possible
2010 presence of header-line. (Bug#4426)
2011
2012 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2013
2014 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2015 Don't advertise functionality which we discourage or doesn't work.
2016
2017 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2018
2019 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2020 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2021 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2022 this makes Emacs dump core during garbage collection on rare
2023 occasions. sizeof is obviously inferior to offsetof here, so
2024 stick with offsetof.
2025 (GC_POINTER_ALIGNMENT): New macro.
2026 (mark_memory): Omit 3rd (offset) arg; caller changed.
2027 Don't assume EMACS_INT alignment is the same as pointer alignment.
2028
2029 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2030
2031 * keyboard.c (read_key_sequence_remapped): New var.
2032 (read_key_sequence): Compute remapping in the right buffer.
2033 (command_loop_1): Use read_key_sequence's remapping directly.
2034
2035 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2036
2037 * dired.c (file_name_completion): Don't expand file name.
2038 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2039 before checking file name handler.
2040
2041 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2042 they've been requested explicitly (bug#9591).
2043
2044 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2045
2046 * keymap.c (Fsingle_key_description): Use make_specified_string
2047 instead of build_string to build string from push_key_description.
2048 (Bug#5193)
2049
2050 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2051
2052 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2053 This fixes a Y2038 bug on 64-bit hosts.
2054 * buffer.c (reset_buffer):
2055 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2056 (Fclear_buffer_auto_save_failure):
2057 Use 0, not -1, to represent an unset failure time, since time_t
2058 might not be signed.
2059
2060 Remove dependency on glibc malloc internals.
2061 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2062 Move back here from lisp.h, but with their new implementations.
2063 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2064 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2065 * charset.c (charset_table_init): New static var.
2066 (syms_of_charset): Use it instead of xmalloc. This removes a
2067 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2068 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2069 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2070 Move back to alloc.c.
2071 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2072 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2073
2074 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2075
2076 * nsterm.m (windowDidResize): Call x_set_window_size only when
2077 ns_in_resize is true. Otherwise set pixelwidth/height and
2078 call change_frame_size (Bug#9628).
2079
2080 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2081
2082 Port --enable-checking=all to Fedora 14 x86-64.
2083 * charset.c (syms_of_charset): Also account for glibc malloc's
2084 internal overhead when calculating the initial malloc maximum.
2085
2086 Port --enable-checking=all to Fedora 14 x86.
2087 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2088 Move to lisp.h.
2089 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2090 (overrun_check_realloc, overrun_check_free):
2091 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2092 That way, xmalloc returns a properly-aligned pointer even if
2093 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2094 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2095 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2096 into account when calculating the initial malloc maximum.
2097 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2098 Move here from alloc.c, so that charset.c can use it too.
2099 Properly align; the old code wasn't right for common 32-bit hosts
2100 when configured with --enable-checking=all.
2101 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2102 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2103
2104 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2105
2106 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2107 use EDOM.
2108
2109 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2110
2111 * xdisp.c (compute_display_string_end): If there's no display
2112 string at CHARPOS, return -1.
2113
2114 * bidi.c (bidi_fetch_char): When compute_display_string_end
2115 returns a negative value, treat the character as a normal
2116 character not covered by a display string. (Bug#9624)
2117
2118 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2119
2120 * lread.c (Fread_from_string): Fix typo in docstring.
2121
2122 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2123
2124 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2125 newline, reseat the iterator instead of bidi-iterating there one
2126 character at a time. (Bug#9610)
2127 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2128 TO_CHARPOS if the bidi iterator is at base embedding level.
2129
2130 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2131
2132 * lread.c (readevalloop): Use correct code for NBSP.
2133 (read1): Likewise. (Bug#9608)
2134
2135 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2136
2137 * dbusbind.c (Fdbus_register_signal): When service is not
2138 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2139
2140 2011-09-25 Glenn Morris <rgm@gnu.org>
2141
2142 * buffer.c (truncate-lines): Doc fix.
2143
2144 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2145
2146 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2147 (Fset_window_next_buffers): Doc fix.
2148
2149 2011-09-24 Glenn Morris <rgm@gnu.org>
2150
2151 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2152
2153 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2154
2155 Fix minor problems found by static checking.
2156 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2157 * indent.c (Fvertical_motion): Fix == vs = typo.
2158
2159 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2160
2161 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2162 Default value is now t. Doc fix.
2163
2164 * indent.c (Fvertical_motion): Compute and apply the overshoot
2165 logic when moving up, not only when moving down. Fix the
2166 confusing name and values of the it_overshoot_expected variable;
2167 logic changes accordingly. (Bug#9254) (Bug#9549)
2168
2169 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2170 CHARPOS is covered by a display string which includes newlines.
2171 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2172 is covered by a display string with embedded newlines.
2173
2174 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2175
2176 * dbusbind.c (Fdbus_register_signal): Add match rule to
2177 Vdbus_registered_objects_table. (Bug#9581)
2178 (Fdbus_register_method, Vdbus_registered_objects_table):
2179 Fix docstring.
2180
2181 2011-09-24 Jim Meyering <meyering@redhat.com>
2182
2183 do not ignore write error for any output size
2184 The previous change was incomplete.
2185 While it makes emacs --batch detect the vast majority of stdout
2186 write failures, errors were still ignored whenever the output size is
2187 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2188 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2189 && echo FAIL: ignored write error
2190 FAIL: ignored write error
2191 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2192 && echo FAIL: ignored write error
2193 FAIL: ignored write error
2194 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2195
2196 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2197
2198 * emacs.c (Fkill_emacs): In noninteractive mode exit
2199 non-successfully if a write error occurred on stdout. (Bug#9574)
2200
2201 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2202
2203 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2204 the xassert test.
2205
2206 * dispextern.h (struct it): Update the comment documenting what
2207 can it->OBJECT be.
2208
2209 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2210
2211 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2212 a display string, extend search for cursor position to end of row.
2213 (find_row_edges): If the row ends in a newline from a display
2214 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2215 Handle the case of a display string with multiple newlines.
2216 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2217 non-empty line. Fixes confusing cursor motion with arrow keys at
2218 the beginning of a line that starts with whitespace.
2219
2220 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2221
2222 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2223 (bug#9493).
2224
2225 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2226
2227 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2228 boolean (Bug#9154).
2229
2230 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2231
2232 * xdisp.c (display_line): Record maximum and minimum buffer
2233 positions even if no glyphs were produced (e.g., by a zero-width
2234 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2235 buffer positions that will be removed from the glyph row because
2236 they don't fit.
2237 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2238 column is beyond frame width: don't subtract 1 "pixel" when
2239 computing width of the stretch.
2240 (reseat_at_next_visible_line_start): Undo the change made on
2241 2011-09-17 that saved paragraph information and restored it after
2242 the call to `reseat'. (Bug#9545)
2243
2244 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2245
2246 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2247 and turn window cursor on if cleared (Bug#9415).
2248
2249 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2250
2251 * search.c (boyer_moore): Take unibyte characters from pattern
2252 literally. (Bug#9458)
2253
2254 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2255
2256 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2257
2258 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2259
2260 Fix minor problem found by static checking.
2261 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2262 initialized, to pacify gcc -Wuninitialized.
2263
2264 * fileio.c: Report proper errno when syscall falls.
2265 (Finsert_file_contents): Save and restore errno,
2266 so that report_file_error outputs the correct diagnostic.
2267 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2268
2269 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2270
2271 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2272
2273 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2274
2275 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2276 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2277
2278 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2279
2280 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2281 about the current paragraph and restore it after the call to reseat.
2282
2283 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2284 (bidi_find_paragraph_start): Search back for paragraph beginning
2285 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2286 (bidi_move_to_visually_next): Only trigger paragraph-related
2287 computations when the last character is a newline or at EOB, not
2288 just any NEUTRAL_B. (Bug#9470)
2289
2290 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2291 truncated lines if point is covered by a display string. (Bug#9524)
2292
2293 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2294
2295 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2296 (cons_to_x_long): New function.
2297 (lisp_data_to_selection_data): Use it. Correct the test for
2298 short-versus-long data; it was negated. Break out of vector
2299 loop, for efficiency, when a long datum is discovered.
2300
2301 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2302
2303 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2304
2305 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2306
2307 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2308 GCC PR/17406) by declaring this function with external scope.
2309
2310 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2311
2312 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2313 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2314
2315 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2316
2317 * editfns.c (Fformat): Correctly handle text properties on "%%".
2318
2319 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2320
2321 * xterm.c (x_draw_composite_glyph_string_foreground):
2322 * w32term.c (x_draw_composite_glyph_string_foreground):
2323 * term.c (encode_terminal_code):
2324 * composite.c (composition_update_it, get_composition_id):
2325 * xdisp.c (get_next_display_element)
2326 (fill_composite_glyph_string): Add comments about special meaning
2327 of TAB characters in a composition.
2328
2329 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2330
2331 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2332 This occurs when processing a multibyte format.
2333 Problem reported by Wolfgang Jenker.
2334
2335 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2336
2337 * xdisp.c (try_cursor_movement): Only check for exact match if
2338 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2339
2340 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2341
2342 Remove unused external symbols.
2343 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2344 * xdisp.c (calc_pixel_width_or_height): Now static.
2345 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2346 * indent.c (check_display_width):
2347 * w32term.c: Fix comment to match code.
2348 * xterm.c, xterm.h (x_catching_errors): Remove.
2349
2350 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2351
2352 * xselect.c: Use signed conversions more consistently (Bug#9498).
2353 (selection_data_to_lisp_data): Assume incoming selection data are
2354 signed integers, not unsigned. This is to be consistent with
2355 outgoing selection data, which was modified to use signed integers
2356 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2357 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2358 expects long, not unsigned long.
2359
2360 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2361
2362 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2363 computation of loop end. Reported by Johan Bockgård
2364 <bojohan@gnu.org>.
2365
2366 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2367
2368 * frame.c (Fother_visible_frames_p): Function deleted.
2369
2370 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2371
2372 * indent.c (compute_motion): Process display vector front to back
2373 rather than the other way around. (Bug#2496)
2374
2375 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2376
2377 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2378
2379 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2380
2381 * minibuf.c (Fread_from_minibuffer): Doc fix.
2382
2383 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2384
2385 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2386 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2387
2388 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2389
2390 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2391 value for non-existent files.
2392
2393 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2394
2395 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2396 set its "size" to -1. This will set the modtime_size field of
2397 the corresponding buffer to -1, which is what
2398 verify-visited-file-modtime expects for files that do not exist.
2399 (Bug#9139)
2400
2401 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2402
2403 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2404 here ...
2405 * lisp.h: ... from here. push_key_description is no longer
2406 defined in keyboard.c, so its declaration should not be in
2407 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2408 logically belongs with push_key_description.
2409
2410 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2411
2412 * buffer.h: Include <sys/types.h> instead of <time.h>.
2413 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2414 Problem reported by Herbert J. Skuhra.
2415
2416 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2417
2418 * xml.c (parse_region): Make the parsing work for
2419 non-comment-starting XML files again (bug#9144).
2420
2421 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2422
2423 * image.c (gif_load): Fix calculation of bottom and right corner.
2424 (Bug#9468)
2425
2426 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2427
2428 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2429 redisplay in small windows.
2430
2431 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2432
2433 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2434
2435 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2436
2437 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2438 Operate on live windows only.
2439
2440 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2441
2442 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2443
2444 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2445
2446 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2447 only under bidi iteration.
2448
2449 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2450
2451 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2452
2453 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2454
2455 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2456 Without this fix, the command to link temacs failed due to an
2457 undefined symbol __builtin_isnan. This is because
2458 /usr/include/iso/math_c99.h #defines isnan(x) to
2459 __builtin_isnan(x), but the bundled gcc, which identifies itself
2460 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2461 a __builtin_isnan.
2462 * floatfns.c (isnan): #undef, and then #define to a clone of
2463 what's in data.c.
2464 (Fisnan): Always define, since it's always available now.
2465 (syms_of_floatfns): Always define isnan at the Lisp level.
2466
2467 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2468
2469 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2470
2471 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2472
2473 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2474 The previous code assumed that file offsets (off_t values) fit in
2475 EMACS_INT variables, which is not true on typical 32-bit hosts.
2476 The code messed up by falsely reporting buffer overflow in cases
2477 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2478 when "big" contains more than 2**29 bytes, even though this
2479 inserts just one byte and does not overflow the buffer.
2480 (Finsert_file_contents): Store file offsets as off_t
2481 values, not as EMACS_INT values. Check for overflow when
2482 converting between EMACS_INT and off_t. When checking for
2483 buffer overflow or for overlap, take the offsets into account.
2484 Don't use EMACS_INT for small values where int suffices.
2485 When checking for overlap, fix a typo: ZV was used where
2486 ZV_BYTE was intended.
2487 (Fwrite_region): Don't assume off_t fits into 'long'.
2488 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2489
2490 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2491
2492 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2493
2494 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2495
2496 sprintf-related integer and memory overflow issues (Bug#9412).
2497
2498 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2499 (esprintf, exprintf, evxprintf): New functions.
2500 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2501 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2502 (modify_event_symbol): Do not assume that the length of
2503 name_alist_or_stem is safe to alloca and fits in int.
2504 (Fexecute_extended_command): Likewise for function name and binding.
2505 (Frecursion_depth): Wrap around reliably on integer overflow.
2506 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2507 since some callers pass EMACS_INT values.
2508 (Fsingle_key_description): Don't crash if symbol name contains more
2509 than MAX_ALLOCA bytes.
2510 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2511 (get_minibuffer): Arg is now EMACS_INT, not int.
2512 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2513 (esprintf, exprintf, evxprintf): New decls.
2514 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2515
2516 * dbusbind.c (signature_cat): New function.
2517 (xd_signature, Fdbus_register_signal):
2518 Do not overrun buffer; instead, report string overflow.
2519
2520 * dispnew.c (add_window_display_history): Don't overrun buffer.
2521 Truncate instead; this is OK since it's just a log.
2522
2523 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2524 even if the time zone offset is outlandishly large.
2525 Don't mishandle offset == INT_MIN.
2526
2527 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2528 when creating daemon; the previous buffer-overflow check was incorrect.
2529
2530 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2531 which has the guts of the old verror function.
2532
2533 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2534 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2535
2536 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2537 (font_unparse_xlfd): Don't blindly alloca long strings.
2538 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2539 fits in int, when using sprintf. Use single snprintf to count
2540 length of string rather than counting it via multiple sprintfs;
2541 that's simpler and more reliable.
2542 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2543 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2544 sprintf, in case result does not fit in int.
2545
2546 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2547 (fontset_from_font): Print it.
2548
2549 * frame.c (tty_frame_count): Now printmax_t, not int.
2550 (make_terminal_frame, set_term_frame_name): Print it.
2551 (x_report_frame_params): In X, window IDs are unsigned long,
2552 not signed long, so print them as unsigned.
2553 (validate_x_resource_name): Check for implausibly long names,
2554 and don't assume name length fits in 'int'.
2555 (x_get_resource_string): Don't blindly alloca invocation name;
2556 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2557 not fit in int.
2558
2559 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2560 (xg_check_special_colors, xg_set_geometry):
2561 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2562
2563 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2564 Use esprintf, not sprintf, in case result does not fit in int.
2565
2566 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2567 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2568 it as a large positive number.
2569 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2570 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2571
2572 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2573 in case result does not fit in int.
2574
2575 * print.c (float_to_string): Detect width overflow more reliably.
2576 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2577 buffer overrun. Don't assume list length fits in 'int'. Treat
2578 print length of 0 as 0, not as infinity; to be consistent with other
2579 uses of print length in this function. Don't overflow print length
2580 index. Don't assume hash table size fits in 'long', or that
2581 vectorlike size fits in 'unsigned long'.
2582
2583 * process.c (make_process): Use printmax_t, not int, to format
2584 process-name gensyms.
2585
2586 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2587
2588 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2589 to avoid potential buffer overrun.
2590
2591 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2592 if X resource line is longer than 512 bytes.
2593
2594 * xfns.c (x_window): Make sprintf buffer a bit bigger
2595 to avoid potential buffer overrun.
2596
2597 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2598
2599 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2600
2601 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2602
2603 Integer overflow fixes for scrolling, etc.
2604 Without these, Emacs silently mishandles large integers sometimes.
2605 For example, "C-u 4294967297 M-x recenter" was treated as if
2606 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2607
2608 * xdisp.c (try_window_id): Check Emacs fixnum range before
2609 converting to 'int'.
2610
2611 * window.c (window_scroll_line_based, Frecenter):
2612 Check that an Emacs fixnum is in range before assigning it to 'int'.
2613 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2614 values converted from Emacs fixnums.
2615 (Frecenter): Don't wrap around a line count if it is out of 'int'
2616 range; instead, treat it as an extreme value.
2617 (Fset_window_configuration, compare_window_configurations):
2618 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2619
2620 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2621 that can exceed INT_MAX. Check that EMACS_INT value is in range
2622 before assigning it to the (possibly-narrower) index.
2623 (match_limit): Don't assume that a fixnum can fit in 'int'.
2624
2625 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2626 exceed INT_MAX.
2627
2628 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2629 (Fvertical_motion): Don't wrap around LINES values that don't fit
2630 in 'int'. Instead, treat them as extreme values. This is good
2631 enough for windows, which can't have more than INT_MAX lines anyway.
2632
2633 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2634
2635 * Require libxml/parser.h to avoid compilation warning.
2636
2637 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2638
2639 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2640 since this reportedly can destroy thread storage.
2641
2642 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2643
2644 * syntax.c (find_defun_start): Update all cache variables if
2645 exiting early (Bug#9401).
2646
2647 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2648
2649 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2650
2651 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2652 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2653 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2654
2655 * term.c (tty_append_glyph): New function.
2656 (produce_stretch_glyph): Static function and its prototype deleted.
2657
2658 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2659 Add prototypes.
2660
2661 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2662
2663 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2664 when checking :margin (Bug#9390).
2665 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2666 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2667 so that the name doesn't mislead. All uses changed.
2668
2669 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2670
2671 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2672 set_tty_hooks.
2673
2674 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2675
2676 * xdisp.c (move_it_to): Don't bail out early when reaching
2677 position beyond to_charpos, if we are scanning backwards.
2678 (move_it_vertically_backward): When DY == 0, make sure we get to
2679 the first character in the line after the newline.
2680
2681 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2682
2683 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2684 (ccl_driver): Do not generate an out-of-range pointer.
2685 (Fccl_execute_on_string): Remove unnecessary check for
2686 integer overflow, noted by Stefan Monnier in
2687 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2688 Remove a FIXME that didn't need fixing.
2689 Simplify the newly-introduced buffer reallocation code.
2690
2691 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2692
2693 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2694
2695 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2696
2697 Integer and memory overflow issues (Bug#9196).
2698
2699 * doc.c (get_doc_string): Rework so that
2700 get_doc_string_buffer_size is the actual buffer size, rather than
2701 being 1 less than the actual buffer size; this makes xpalloc more
2702 convenient.
2703
2704 * image.c (x_allocate_bitmap_record, cache_image):
2705 * xselect.c (Fx_register_dnd_atom):
2706 Simplify previous changes by using xpalloc.
2707
2708 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2709 since either will do and ptrdiff_t is convenient with xpalloc.
2710
2711 * charset.c (charset_table_size)
2712 (struct charset_sort_data.priority): Now ptrdiff_t.
2713 (charset_compare): Don't overflow if priorities differ greatly.
2714 (Fsort_charsets): Don't assume list length fits in int.
2715 Check for size-calculation overflow when allocating sort data.
2716 (syms_of_charset): Allocate an initial charset table that is
2717 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2718
2719 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2720
2721 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2722 The actual value is always <= INT_MAX, and leaving it unsigned made
2723 overflow checking harder.
2724
2725 * dispextern.h (struct glyph_matrix.rows_allocated)
2726 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2727 with xpalloc. The values are still always <= INT_MAX.
2728
2729 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2730
2731 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2732 (SAFE_NALLOCA): New macro.
2733
2734 * region-cache.c (struct boundary.pos, find_cache_boundary)
2735 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2736 (set_cache_region, invalidate_region_cache)
2737 (revalidate_region_cache, know_region_cache, region_cache_forward)
2738 (region_cache_backward, pp_cache):
2739 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2740 so that ptrdiff_t * can be passed to xpalloc.
2741 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2742 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2743 (pp_cache): Don't assume cache_len fits in int.
2744 * region-cache.h: Adjust extern decls to match.
2745
2746 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2747 EMACS_INT, since either will do, for xpalloc.
2748
2749 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2750 (xnmalloc, xnrealloc, xpalloc): New functions.
2751
2752 * bidi.c (bidi_shelve_header_size): New constant.
2753 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2754 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2755
2756 * bidi.c (bidi_cache_shrink):
2757 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2758 (overlay_strings):
2759 Don't update size of array until after memory allocation succeeds,
2760 because xmalloc/xrealloc may not return.
2761 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2762 now that we have proper integer overflow checking.
2763 (record_overlay_string, overlay_strings): Catch overflows when
2764 calculating size of overlay_str_buf.
2765
2766 * callproc.c (Fcall_process): Check for size overflow when
2767 calculating size of args2.
2768 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2769 Normally we prefer signed values, but sticking with ptrdiff_t would
2770 require adding more-complicated checks.
2771
2772 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2773 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2774 Redo buffer-overflow calculations to avoid integer overflow.
2775 Add a FIXME comment where memory seems to be over-allocated.
2776
2777 * character.c (Fstring): Check for size-calculation overflow.
2778
2779 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2780 unnecessary integer overflow. Check for size overflow.
2781 (encode_coding_object): Don't update size until xmalloc succeeds.
2782
2783 * composite.c (get_composition_id): Check for overflow in glyph
2784 length calculations.
2785
2786 Integer and memory overflow fixes for display code.
2787 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2788 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2789 (scrolling_window): Check for overflow in size calculations.
2790 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2791 Don't assume glyph table len fits in int.
2792 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2793 (row_table_size): Now ptrdiff_t, not int.
2794 (scrolling_window): Avoid overflow in size calculations.
2795 Don't update size until allocation succeeds.
2796 * fns.c (concat): Check for overflow in size calculations.
2797 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2798 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2799 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2800
2801 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2802 (get_doc_string): Check for size calculation overflow.
2803 Don't update size until allocation succeeds.
2804 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2805 EMACS_INT, where ptrdiff_t will do.
2806 (Fsubstitute_command_keys): Check for string overflow.
2807
2808 * editfns.c (set_time_zone_rule): Don't assume environment length
2809 fits in int.
2810 (message_length): Now ptrdiff_t, not int.
2811 (Fmessage_box): Don't update size until allocation succeeds.
2812 Don't assume message length fits in int.
2813 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2814
2815 * emacs.c (main): Do not reallocate argv, since there is a null at
2816 the end that can be overwritten, and this way there's no need to
2817 worry about size-calculation overflow.
2818 (sort_args): Check for size-calculation overflow.
2819
2820 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2821 alloc succeeds.
2822 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2823
2824 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2825 (x_set_scroll_bar_width, x_figure_window_size):
2826 Check for integer overflow.
2827 (x_set_alpha): Do not assume XINT fits in int.
2828
2829 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2830 This is for the members text_lines, text_cols, total_lines, total_cols,
2831 where the system imposes an 'int' limit.
2832
2833 * fringe.c (Fdefine_fringe_bitmap):
2834 Don't update size until alloc works.
2835
2836 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2837 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2838
2839 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2840 Check for size-calculation overflow.
2841 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2842 do, as we prefer signed integers.
2843 (id_to_widget.max_size, id_to_widget.used)
2844 (xg_store_widget_in_map, xg_remove_widget_from_map)
2845 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2846 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2847 Use and return ptrdiff_t, not int.
2848 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2849 * gtkutil.h: Change prototypes to match the above.
2850
2851 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2852 are duplicate now that they've been promoted to lisp.h.
2853 (x_allocate_bitmap_record, x_alloc_image_color)
2854 (make_image_cache, cache_image, xpm_load):
2855 Don't update size until alloc is done.
2856 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2857 (x_detect_edges):
2858 Check for size calculation overflow.
2859 (ct_colors_allocated_max): New constant.
2860 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2861 overflow.
2862
2863 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2864 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2865 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2866 Use ptrdiff_t, not int, to count maps.
2867 (read_char_minibuf_menu_prompt): Check for overflow in size
2868 calculations. Don't update size until allocation succeeds.
2869 Redo calculations to avoid overflow.
2870 * keyboard.h: Change prototypes to match the above.
2871
2872 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2873 to count maps.
2874 (current_minor_maps): Check for size calculation overflow.
2875 * keymap.h: Change prototypes to match the above.
2876
2877 * lread.c (read1, init_obarray): Don't update size until alloc done.
2878
2879 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2880 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2881
2882 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2883 Now ptrdiff_t, not int.
2884 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2885 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2886
2887 * process.c (Fnetwork_interface_list): Check for overflow
2888 in size calculation.
2889
2890 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2891
2892 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2893 overflow. Don't bother calling xmalloc when xrealloc will do.
2894
2895 * search.c (Freplace_match): Check for size calculation overflow.
2896 (Fset_match_data): Don't assume list lengths fit in 'int'.
2897
2898 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2899 for command line length. Do not attempt to address one before the
2900 beginning of an array, as that's not portable.
2901
2902 * term.c (max_frame_lines): Remove; unused.
2903 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2904 not int.
2905 (encode_terminal_code, calculate_costs): Check for size
2906 calculation overflow.
2907 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2908 table lengths and related sizes. Don't update size until alloc
2909 done. Redo calculations to avoid overflow.
2910 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2911
2912 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2913 subtracting pointers.
2914 (gobble_line): Check for overflow more carefully. Don't update size
2915 until alloc done.
2916
2917 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2918 Don't update size until alloc done.
2919 Redo size calculations to avoid overflow.
2920 Check for size calculation overflow.
2921 (main) [DEBUG]: Fix typo in invoking tparam1.
2922
2923 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2924 Use ptrdiff_t, not int, for sizes.
2925 (store_mode_line_noprop_char): Don't update size until alloc done.
2926
2927 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2928 Use ptrdiff_t, not int, for sizes.
2929 (Finternal_make_lisp_face, cache_face):
2930 Check for size calculation overflow.
2931 (cache_face): Treat size calculation overflows as if they were
2932 memory exhaustion (the usual treatment), rather than aborting.
2933
2934 * xfns.c (x_encode_text, x_set_name_internal)
2935 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2936 sizes, since they can exceed INT_MAX in size. Check for size
2937 calculation overflow.
2938
2939 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2940 (xg_select): Check for size calculation overflow.
2941 Don't update size until alloc done.
2942
2943 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2944 as sprintf is limited to int lengths.
2945
2946 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2947 (X_LONG_MIN): New macros.
2948 Use them to make the following changes clearer.
2949 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2950 This change doesn't affect the value now, but it may help remind
2951 future maintainers not to raise the value too much later.
2952 (SELECTION_QUANTUM): Remove, replacing with ...
2953 (selection_quantum): ... new function, which avoids overflow.
2954 All uses changed.
2955 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2956 assumption that selection length fits in 'int'.
2957 (x_reply_selection_request, x_handle_selection_request)
2958 (x_get_window_property, receive_incremental_selection)
2959 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2960 (lisp_data_to_selection_data, clean_local_selection_data):
2961 Use ptrdiff_t, not int, to record length of selection.
2962 (x_reply_selection_request, x_get_window_property)
2963 (receive_incremental_selection, x_property_data_to_lisp):
2964 Redo calculations to avoid overflow.
2965 (x_reply_selection_request): When sending hint, ceiling it at
2966 X_LONG_MAX rather than relying on wraparound overflow to send
2967 something.
2968 (x_get_window_property, receive_incremental_selection)
2969 (lisp_data_to_selection_data, x_property_data_to_lisp):
2970 Check for size-calculation overflow.
2971 (x_get_window_property, receive_incremental_selection)
2972 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2973 Don't store size until memory allocation succeeds.
2974 (x_get_window_property): Plug memory leak on memory exhaustion.
2975 Don't double-block input; malloc is safe here. Don't assume 2**34
2976 - 4 fits in unsigned long. Add an xassert to check
2977 XGetWindowProperty overflow. Be more careful about overflow
2978 calculations, and distinguish size from memory overflow better.
2979 (receive_incremental_selection): When tracing, don't assume
2980 unsigned int is less than INT_MAX.
2981 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2982 harmful) conversions of unsigned short to int.
2983 (lisp_data_to_selection_data): Don't assume that integers
2984 in the range -65535 through -1 fit in an X unsigned short.
2985 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2986 result parameters unless successful. Rely on cons_to_unsigned
2987 to report problems with elements; the old code wasn't right anyway.
2988 (x_check_property_data): Check for int overflow; we cannot use
2989 a wider type due to X limits.
2990 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2991
2992 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2993
2994 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2995 (x_term_init): Check for size calculation overflow.
2996 (x_color_cells): Don't store size until memory allocation succeeds.
2997 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2998 Don't assume alloca size is less than MAX_ALLOCA.
2999 (x_term_init): Don't assume length fits in int (sprintf is limited
3000 to int size).
3001
3002 Use ptrdiff_t for composition IDs.
3003 * character.c (lisp_string_width):
3004 * composite.c (composition_table_size, n_compositions)
3005 (get_composition_id, composition_gstring_from_id):
3006 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3007 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3008 * window.c (Frecenter):
3009 Use ptrdiff_t, not int, for composition IDs.
3010 * composite.c (get_composition_id): Check for integer overflow.
3011 * composite.h: Adjust prototypes to match the above changes.
3012
3013 Use ptrdiff_t for hash table indexes.
3014 * category.c (hash_get_category_set):
3015 * ccl.c (ccl_driver):
3016 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3017 * coding.c (coding_system_charset_list, detect_coding_system):
3018 * coding.h (struct coding_system.id):
3019 * composite.c (get_composition_id, gstring_lookup_cache):
3020 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3021 * image.c (xpm_get_color_table_h):
3022 * lisp.h (hash_lookup, hash_put):
3023 * minibuf.c (Ftest_completion):
3024 Use ptrdiff_t for hash table indexes, not int (which is too
3025 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3026 32-bit --with-wide-int hosts).
3027
3028 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3029 Add a FIXME comment about memory leaks.
3030 (syms_of_charset): Don't assume xmalloc returns.
3031
3032 Don't assume that stated character widths fit in int.
3033 * character.c (Fchar_width, c_string_width, lisp_string_width):
3034 * character.h (CHAR_WIDTH):
3035 * indent.c (MULTIBYTE_BYTES_WIDTH):
3036 Use sanitize_char_width to avoid undefined and/or bad behavior
3037 with outlandish widths.
3038 * character.h (sanitize_tab_width): Rename from sanitize_width,
3039 now that we have two such functions. All uses changed.
3040 (sanitize_char_width): New inline function.
3041
3042 Don't assume that tab-width fits in int.
3043 * character.h (sanitize_width): New inline function.
3044 (SANE_TAB_WIDTH): New macro.
3045 (ASCII_CHAR_WIDTH): Use it.
3046 * indent.c (sane_tab_width): Remove. All uses replaced by
3047 SANE_TAB_WIDTH (current_buffer).
3048 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3049
3050 * fileio.c: Integer overflow issues with file modes.
3051 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3052
3053 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3054 Remove unreachable code.
3055 (read_hex, load_charset_map_from_file): Check for integer overflow.
3056
3057 * xterm.c: Don't go over XClientMessageEvent limit.
3058 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3059 (x_send_scroll_bar_event): Likewise. Check that the size does not
3060 exceed limits imposed by XClientMessageEvent, as well as the usual
3061 ptrdiff_t and size_t limits.
3062
3063 * keyboard.c: Overflow, signedness and related fixes.
3064 (make_lispy_movement): Use same integer type in forward decl
3065 that is used in the definition.
3066 (read_key_sequence, keyremap_step):
3067 Change bufsize argument back to int, undoing my 2011-03-30 change.
3068 We prefer signed types, and int is wide enough here.
3069 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3070 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3071 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3072 length, not size_t. Use ptrdiff_t for index, not int.
3073 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3074 possibility of integer overflow.
3075
3076 Overflow, signedness and related fixes for images.
3077
3078 * dispextern.h (struct it.stack[0].u.image.image_id)
3079 (struct_it.image_id, struct image.id, struct image_cache.size)
3080 (struct image_cache.used, struct image_cache.ref_count):
3081 * gtkutil.c (update_frame_tool_bar):
3082 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3083 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3084 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3085 * nsmenu.m (update_frame_tool_bar):
3086 * xdisp.c (calc_pixel_width_or_height):
3087 * xfns.c (image_cache_refcount):
3088 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3089 on typical 64-bit hosts.
3090
3091 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3092 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3093 Omit unnecessary casts to int.
3094 (parse_image_spec): Check that integers fall into 'int' range
3095 when the callers expect that.
3096 (image_ascent): Redo ascent calculation to avoid int overflow.
3097 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3098 (lookup_image): Remove unnecessary tests.
3099 (xbm_image_p): Locals are now of int, not EMACS_INT,
3100 since parse_image_check makes sure they fit into int.
3101 (png_load, gif_load, svg_load_image):
3102 Prefer int to unsigned where either will do.
3103 (tiff_handler): New function, combining the cores of the
3104 old tiff_error_handler and tiff_warning_handler.
3105 This function is rewritten to use vsnprintf and thereby avoid
3106 stack buffer overflows. It uses only the features of vsnprintf
3107 that are common to both POSIX and native Microsoft.
3108 (tiff_error_handler, tiff_warning_handler): Use it.
3109 (tiff_load, gif_load, imagemagick_load_image):
3110 Don't assume :index value fits in 'int'.
3111 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3112 (imagemagick_load_image): Check that crop parameters fit into
3113 the integer types that MagickCropImage accepts. Don't assume
3114 Vimagemagick_render_type has a nonnegative value. Don't assume
3115 size_t fits in 'long'.
3116 (gs_load): Use printmax_t to print the widest integers possible.
3117 Check for integer overflow when computing image height and width.
3118
3119 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3120
3121 * xdisp.c (redisplay_window): Don't force window start if point
3122 will be invisible in the resulting window. (Bug#9324)
3123
3124 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3125
3126 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3127 the display spec is of the form `(space ...)'.
3128 (handle_display_spec): Return the value returned by
3129 handle_single_display_spec, not just 1 or zero.
3130 (handle_single_display_spec): If the display spec is of the form
3131 `(space ...)', and specifies display in the text area, return 2
3132 rather than 1.
3133 (try_cursor_movement): Check for the need to scroll more
3134 accurately, and prefer exact match for point under bidi.
3135 Don't advance `row' beyond the last row of the window.
3136
3137 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3138 into disp_prop; all users changed.
3139
3140 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3141 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3142 for the text covered by the display property.
3143
3144 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3145
3146 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3147 Change return value to nil.
3148 (Frecord_buffer): Delete unused function.
3149
3150 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3151
3152 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3153 buffers, return left-to-right.
3154 (set_cursor_from_row): Consider candidate row a win if its glyph
3155 represents a newline and point is on that newline. Fixes cursor
3156 positioning on the newline at EOL of R2L text within L2R
3157 paragraph, and vice versa.
3158 (try_cursor_movement): Check continued rows, in addition to
3159 continuation rows. Fixes unwarranted scroll when point enters a
3160 continued line of R2L text within an L2R paragraph, or vice versa.
3161 (cursor_row_p): Consider the case of point being equal to
3162 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3163 from the end of a short line to the beginning of a continued line
3164 of R2L text within L2R paragraph.
3165 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3166 composed characters.
3167
3168 * bidi.c (bidi_check_type): Use xassert.
3169 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3170 members.
3171
3172 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3173
3174 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3175 a character.
3176
3177 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3178
3179 * nsfont.m (ns_otf_to_script): Fix typo.
3180
3181 2011-08-22 Kenichi Handa <handa@m17n.org>
3182
3183 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3184 extra slot even if the purpose is char-code-property-table.
3185
3186 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3187
3188 * xdisp.c (redisplay_window): When computing centering_position,
3189 account for the height of the header line. (Bug#8874)
3190
3191 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3192 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3193 candidate is selected by the mouse, and that candidate has a
3194 composed character under the mouse.
3195
3196 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3197 coordinates reported by pos-visible-in-window-p for a composed
3198 character in column zero.
3199
3200 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3201
3202 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3203
3204 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3205
3206 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3207 consider it a hit if to_charpos is anywhere in the range of the
3208 composed buffer positions.
3209
3210 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3211
3212 * image.c (gif_load): Don't assume that each subimage has the same
3213 dimensions as the base image. Handle disposal method that is
3214 "undefined" by the gif spec (Bug#9335).
3215
3216 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3217
3218 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3219 (Fcondition_case): Document `debug' symbol in error handler.
3220
3221 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3222
3223 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3224 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3225 from an Org mode buffer to a Speedbar frame.
3226
3227 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3228 a composition, take its buffer position from IT->cmp_it.charpos.
3229 Fixes cursor positioning at the beginning of a line that begins
3230 with a composed character.
3231
3232 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3233
3234 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3235 character bidirectional type, use STRONG_L instead. Fixes crashes
3236 in a buffer produced by `describe-categories'.
3237
3238 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3239 members before the level stack, so they would be saved and
3240 restored when copying iterator state. Fixes incorrect reordering
3241 around TABs covered by display properties.
3242
3243 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3244
3245 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3246
3247 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3248
3249 * eval.c (internal_condition_case, internal_condition_case_1)
3250 (internal_condition_case_2, internal_condition_case_n):
3251 Remove unnecessary aborts (Bug#9081).
3252
3253 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3254
3255 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3256 has no `load' handler, try opening the file locally. (Bug#9311)
3257
3258 2011-08-16 Ken Brown <kbrown@cornell.edu>
3259
3260 * gmalloc.c: Expand comment.
3261
3262 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3263
3264 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3265 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3266
3267 2011-08-16 Ken Brown <kbrown@cornell.edu>
3268
3269 Fix memory allocation problems in Cygwin build (Bug#9273).
3270
3271 * unexcw.c ( __malloc_initialized): Declare external variable.
3272 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3273
3274 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3275 New variables.
3276 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3277 dumped emacs.
3278 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3279 in the static heap.
3280 [CYGWIN] (special_realloc): New function.
3281 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3282 requests to realloc storage in the static heap.
3283
3284 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3285
3286 * bidi.c (bidi_initialize): Remove unused local.
3287
3288 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3289
3290 * bidimirror.h:
3291 * biditype.h: Remove file.
3292 * makefile.w32-in ($(BLD)/bidi.$(O)):
3293 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3294
3295 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3296
3297 * chartab.c: Improve commentary for the uniprop_table API.
3298
3299 * bidi.c (bidi_paragraph_init): Support zero value of
3300 bidi_ignore_explicit_marks_for_paragraph_level.
3301 (bidi_initialize): Use uniprop_table instead of including
3302 biditype.h and bidimirror.h.
3303
3304 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3305 coordinates of the iterator when restoring from ppos_it.
3306 (Bug#9296)
3307
3308 2011-08-14 Kenichi Handa <handa@m17n.org>
3309
3310 * process.c (create_process): Call setup_process_coding_systems
3311 after the pid of the process is set to -1 (Bug#8162).
3312
3313 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3314
3315 * xdisp.c (move_it_in_display_line_to): Don't invoke
3316 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3317 ppos_it. Fixes vertical cursor motion when line beginning is
3318 covered by an image. (Bug#9296)
3319
3320 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3321
3322 * nsterm.h (ns_run_ascript): Declare.
3323 (NSAPP_DATA2_RUNASSCRIPT): Define.
3324
3325 * nsfns.m (as_script, as_result, as_status): New static variables.
3326 (ns_run_ascript): New function.
3327 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3328 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3329 the event loop. Get status from as_status (Bug#7276).
3330
3331 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3332 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3333 the event loop (Bug#7276).
3334
3335 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3336
3337 * gnutls.c (QCgnutls_bootprop_priority)
3338 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3339 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3340 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3341 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3342 (QCgnutls_bootprop_verify_hostname_error)
3343 (QCgnutls_bootprop_callbacks_verify): Rename from
3344 Qgnutls_bootprop_..., all uses changed.
3345
3346 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3347 uses changed.
3348
3349 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3350
3351 * xfaces.c (Qframe_set_background_mode): Now static.
3352 * dispextern.h (Qframe_set_background_mode): Remove decl.
3353
3354 * process.c (Fnetwork_interface_info): Declare local only if needed.
3355
3356 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3357
3358 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3359 (Fnetwork_interface_list): Allocate in increments of bytes instead
3360 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3361 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3362 sockaddr.
3363 (struct ifflag_def): notrailers is smart on OSX.
3364 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3365 Get hardware address with getifaddrs if available.
3366
3367 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3368
3369 * xdisp.c (iterate_out_of_display_property): xassert that
3370 IT->position is set to within IT->object's boundaries. Break from
3371 the loop as soon as EOB is reached; avoids infloops in redisplay
3372 when IT->position is set up wrongly due to some bug.
3373 Set IT->current to match the bidi iterator unconditionally.
3374 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3375 entry. Force push_it to save on the stack the current
3376 buffer/string position, to be restored by pop_it. Fix flags in
3377 the iterator structure wrt the object coming from a display
3378 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3379 properties. (Bug#9284)
3380
3381 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3382
3383 * fontset.c (fontset_get_font_group): Add proper type checks.
3384 (Bug#9172)
3385
3386 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3387
3388 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3389 and LC_VERSION_MIN_MACOSX.
3390 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3391 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3392
3393 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3394
3395 * xdisp.c (forward_to_next_line_start): Allow to use the
3396 no-display-properties-and-no-overlays under bidi display.
3397 Set disp_pos in the bidi iterator to avoid searches for display
3398 properties and overlays.
3399
3400 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3401
3402 * editfns.c (Fset_time_zone_rule): Document relationship with the
3403 setenv function.
3404
3405 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3406 the font entity extracted from the cache (Bug#8109).
3407
3408 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3409
3410 * composite.c (autocmp_chars): Don't reset point. That is done by
3411 restore_point_unwind (Bug#5984).
3412
3413 2011-08-07 Juri Linkov <juri@jurta.org>
3414
3415 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3416 to show the arg `TIME' instead of `TIMEVAL'.
3417
3418 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3419
3420 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3421 display property strides EOL and includes a newline, as in
3422 longlines-mode. (Bug#9254)
3423 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3424 word-wrap under bidirectional display. (Bug#9224)
3425
3426 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3427 is non-zero, even if the data buffer is NULL. Fixes a crash in
3428 vertical-motion with longlines-mode. (Bug#9254)
3429
3430 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3431
3432 * bidi.c <bidi_cache_total_alloc>: Now static.
3433 (bidi_initialize): Initialize bidi_cache_total_alloc.
3434
3435 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3436 cache. (Bug#9221)
3437
3438 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3439 amount allocated this far in `bidi_cache_total_alloc'.
3440 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3441 non-zero, only free the data buffer without restoring the cache
3442 contents. All callers changed.
3443
3444 * dispextern.h (bidi_unshelve_cache): Update prototype.
3445
3446 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3447 (move_it_in_display_line, move_it_to)
3448 (move_it_vertically_backward, move_it_by_lines): Replace the call
3449 to xfree to an equivalent call to bidi_unshelve_cache.
3450 (move_it_in_display_line_to): Fix logic of returning
3451 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3452
3453 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3454
3455 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3456 came from a string character with a `cursor' property. (Bug#9229)
3457
3458 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3459
3460 * Makefile.in (LIB_PTHREAD): New variable.
3461 (LIBES): Add LIB_PTHREAD (Bug#9216).
3462
3463 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3464 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3465
3466 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3467
3468 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3469
3470 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3471
3472 * xterm.c (x_find_topmost_parent): New function.
3473 (x_set_frame_alpha): Find topmost parent window with
3474 x_find_topmost_parent and set the property there also (bug#9181).
3475 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3476
3477 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3478
3479 * callproc.c (Fcall_process): Avoid vfork clobbering
3480 the local vars buffer, coding_systems, current_dir.
3481
3482 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3483
3484 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3485
3486 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3487
3488 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3489 so that it is not optimized away.
3490
3491 * xdisp.c (compute_display_string_pos): Remove unused local.
3492
3493 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3494
3495 Fix slow cursor motion and scrolling in large buffers with
3496 selective display, like Org Mode buffers. (Bug#9218)
3497
3498 * dispextern.h (struct bidi_it): New member disp_prop_p.
3499
3500 * xdisp.c: Remove one-slot cache of display string positions.
3501 (compute_display_string_pos): Accept an additional argument
3502 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3503 for a display string or property. If found, set DISP_PROP_P
3504 non-zero.
3505
3506 * bidi.c (bidi_fetch_char): Accept an additional argument
3507 DISP_PROP_P, and pass it to compute_display_string_pos.
3508 Only handle text covered by a display string if DISP_PROP_P is returned
3509 non-zero. All callers of bidi_fetch_char changed.
3510
3511 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3512
3513 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3514
3515 2010-12-03 Don March <don@ohspite.net>
3516
3517 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3518 last character M-[char] is translated to ESC [char] (bug#7541).
3519
3520 2011-08-02 Kenichi Handa <handa@m17n.org>
3521
3522 * lisp.h (uniprop_table): Extern it.
3523
3524 * chartab.c (uniprop_table): Make it non-static.
3525
3526 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3527
3528 * xdisp.c (forward_to_next_line_start): Accept additional argument
3529 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3530 on the newline.
3531 (reseat_at_next_visible_line_start): Use the bidi iterator state
3532 returned by forward_to_next_line_start to restore the state of
3533 it->bidi_it after backing up to previous newline. (Bug#9212)
3534
3535 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3536
3537 * regex.c (re_comp): Protoize.
3538 (re_exec): Fix return type.
3539 (regexec): Fix type of `ret'. (Bug#9203)
3540
3541 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3542
3543 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3544 This is needed if max-image-size is a floating-point number.
3545
3546 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3547
3548 * print.c (print_object): Print empty symbol as ##.
3549
3550 * lread.c (read1): Read ## as empty symbol.
3551
3552 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3553
3554 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3555 setting frame foreground color (Bug#9175).
3556 (x_set_background_color): Likewise.
3557
3558 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3559 contents (Bug#9176).
3560 (EmacsTooltip -init): Remove bezels and add shadows to
3561 tooltip windows.
3562
3563 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3564 or scroll bar (Bug#8470).
3565
3566 * nsfont.m (nsfont_open): Remove assignment to voffset and
3567 unnecessary vars hshink, expand, hd, full_height, min_height.
3568 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3569
3570 * nsterm.h (nsfont_info): Remove voffset field.
3571
3572 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3573
3574 Implement strike-through and overline on NextStep (Bug#8863).
3575
3576 * nsfont.m (nsfont_open): Use underline position provided by font,
3577 instead of hard-coded value of 2.
3578 (nsfont_draw): Call ns_draw_text_decoration instead.
3579
3580 * nsterm.h: Add declaration for ns_draw_text_decoration.
3581
3582 * nsterm.m (ns_draw_text_decoration): New function for drawing
3583 underline, overline, and strike-through.
3584 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3585 ns_draw_text_decoration. Change treatment of cursor drawing to
3586 accommodate underlining, etc.
3587
3588 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3589
3590 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3591 default.
3592
3593 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3594
3595 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3596 Without this fix, if a signal arrives just after memory fills up,
3597 'malloc' might be invoked reentrantly.
3598
3599 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3600 In other words, assume that every image size is allowed, on non-X
3601 hosts. This assumption is probably wrong, but it lets Emacs compile.
3602
3603 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3604
3605 * regex.c (re_iswctype): Convert return values to boolean.
3606
3607 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3608
3609 * xdisp.c (compute_display_string_pos): Don't use cached display
3610 string position if the buffer had its restriction changed.
3611 (Bug#9184)
3612
3613 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3614
3615 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3616
3617 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3618
3619 Integer signedness and overflow and related fixes. (Bug#9079)
3620
3621 * bidi.c: Integer size and overflow fixes.
3622 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3623 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3624 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3625 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3626 (bidi_find_other_level_edge):
3627 Use ptrdiff_t instead of EMACS_INT where either will do.
3628 This works better on 32-bit hosts configured --with-wide-int.
3629 (bidi_cache_ensure_space): Check for size-calculation overflow.
3630 Use % rather than repeated addition, for better worst-case speed.
3631 Don't set bidi_cache_size until after xrealloc returns, because it
3632 might not return.
3633 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3634 (bidi_cache_ensure_space): Also check that the bidi cache size
3635 does not exceed that of the largest Lisp string or buffer. See Eli
3636 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3637
3638 * alloc.c (__malloc_size_t): Remove.
3639 All uses replaced by size_t. See Andreas Schwab's note
3640 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3641
3642 * image.c: Improve checking for integer overflow.
3643 (check_image_size): Assume that f is nonnull, since
3644 it is always nonnull in practice. This is one less thing to
3645 worry about when checking for integer overflow later.
3646 (x_check_image_size): New function, which checks for integer
3647 overflow issues inside X.
3648 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3649 This removes the need for a memory_full check.
3650 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3651 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3652 (xbm_read_bitmap_data): Change locals back to 'int', since
3653 their values must fit in 'int'.
3654 (xpm_load_image, png_load, tiff_load):
3655 Invoke x_create_x_image_and_pixmap earlier,
3656 to avoid much needless work if the image is too large.
3657 (tiff_load): Treat overly large images as if
3658 x_create_x_image_and_pixmap failed, not as malloc failures.
3659 (gs_load): Use x_check_image_size.
3660
3661 * gtkutil.c: Omit integer casts.
3662 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3663 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3664
3665 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3666
3667 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3668 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3669 would wrongly return t on a 64-bit host.
3670
3671 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3672 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3673 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3674 and therefore cause GCC to emit a bogus diagnostic in some cases.
3675
3676 * image.c: Integer signedness and overflow and related fixes.
3677 This is not an exhaustive set of fixes, but it's time to
3678 record what I've got.
3679 (lookup_pixel_color, check_image_size): Remove redundant decls.
3680 (check_image_size): Don't assume that arbitrary EMACS_INT values
3681 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3682 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3683 (tiff_load, imagemagick_load_image):
3684 Check for overflow in size calculations.
3685 (x_create_x_image_and_pixmap): Remove unnecessary test for
3686 xmalloc returning NULL; that can't happen.
3687 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3688 (xpm_color_bucket): Use better integer hashing function.
3689 (xpm_cache_color): Don't possibly over-allocate memory.
3690 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3691 (gif_memory_source):
3692 Use ptrdiff_t, not int or size_t, to record sizes.
3693 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3694 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3695 either works, as we prefer signed integers.
3696 (tiff_read_from_memory, tiff_write_from_memory):
3697 Return tsize_t, not size_t, since that's what the TIFF API wants.
3698 (tiff_read_from_memory): Don't fail simply because the read would
3699 go past EOF; instead, return a short read.
3700 (tiff_load): Omit no-longer-needed casts.
3701 (Fimagemagick_types): Don't assume size fits into 'int'.
3702
3703 Improve hashing quality when configured --with-wide-int.
3704 * fns.c (hash_string): New function, taken from sxhash_string.
3705 Do not discard information about ASCII character case; this
3706 discarding is no longer needed.
3707 (sxhash-string): Use it. Change sig to match it. Caller changed.
3708 * lisp.h: Declare it.
3709 * lread.c (hash_string): Remove, since we now use fns.c's version.
3710 The fns.c version returns a wider integer if --with-wide-int is
3711 specified, so this should help the quality of the hashing a bit.
3712
3713 * emacs.c: Integer overflow minor fix.
3714 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3715 Define only if GNU_LINUX.
3716 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3717
3718 * dispnew.c: Integer signedness and overflow fixes.
3719 Remove unnecessary forward decls, that were a maintenance hassle.
3720 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3721 All uses changed.
3722 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3723 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3724 (prepare_desired_row, line_draw_cost):
3725 Use int, not unsigned, where either works.
3726 (save_current_matrix, restore_current_matrix):
3727 Use ptrdiff_t, not size_t, where either works.
3728 (init_display): Check for overflow more accurately, and without
3729 relying on undefined behavior.
3730
3731 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3732 Remove, replacing with the new symbols in lisp.h. All uses changed.
3733 * fileio.c (make_temp_name):
3734 * filelock.c (lock_file_1, lock_file):
3735 * xdisp.c (message_dolog):
3736 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3737 Use pMd etc. instead.
3738 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3739 replacing the pWIDE etc. symbols removed from editfns.c.
3740
3741 * keyboard.h (num_input_events): Now uintmax_t.
3742 This is (very slightly) less likely to mess up due to wraparound.
3743 All uses changed.
3744
3745 * buffer.c: Integer signedness fixes.
3746 (alloc_buffer_text, enlarge_buffer_text):
3747 Use ptrdiff_t rather than size_t when either will do, as we prefer
3748 signed integers.
3749
3750 * alloc.c: Integer signedness and overflow fixes.
3751 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3752 (__malloc_size_t): Default to size_t, not to int.
3753 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3754 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3755 Prefer ptrdiff_t to size_t when either would do, as we prefer
3756 signed integers.
3757 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3758 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3759 Now const. Initialize with values that are in range even if char
3760 is signed.
3761 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3762 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3763 These functions do the right thing with sizes > 2**32.
3764 (check_depth): Now ptrdiff_t, not int.
3765 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3766 Adjust to new way of storing sizes. Check for size overflow bugs
3767 in rest of code.
3768 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3769 slightly wrong anyway, as it missed one instance of
3770 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3771 (refill_memory_reserve): Omit needless cast to size_t.
3772 (mark_object_loop_halt): Mark as externally visible.
3773
3774 * xselect.c: Integer signedness and overflow fixes.
3775 (Fx_register_dnd_atom, x_handle_dnd_message):
3776 Use ptrdiff_t, not size_t, since we prefer signed.
3777 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3778 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3779 x_dnd_atoms_size and x_dnd_atoms_length.
3780
3781 * doprnt.c: Prefer signed to unsigned when either works.
3782 * eval.c (verror):
3783 * doprnt.c (doprnt):
3784 * lisp.h (doprnt):
3785 * xdisp.c (vmessage):
3786 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3787 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3788 prefer signed arithmetic to avoid comparison confusion.
3789 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3790 but is a bit tricky.
3791
3792 Assume freestanding C89 headers, string.h, stdlib.h.
3793 * data.c, doprnt.c, floatfns.c, print.c:
3794 Include float.h unconditionally.
3795 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3796 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3797 * regex.c: Likewise for stddef.h, string.h.
3798 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3799 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3800 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3801 (STDC_HEADERS): Remove obsolete defines.
3802 * sysdep.c: Include limits.h unconditionally.
3803
3804 Assume support for memcmp, memcpy, memmove, memset.
3805 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3806 * regex.c (memcmp, memcpy):
3807 Remove; we assume C89 now.
3808
3809 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3810 (__malloc_safe_bcopy): Remove; no longer needed.
3811
3812 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3813 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3814 well either way, and we prefer signed to unsigned.
3815
3816 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3817
3818 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3819 closes the connection while we're reading (bug#9182).
3820
3821 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3822
3823 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3824 are specified (Bug#9168).
3825
3826 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3827
3828 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3829 Found by GCC static checking and --with-wide-int on a 32-bit host.
3830
3831 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3832
3833 * xdisp.c (compute_display_string_pos): Fix logic of caching
3834 previous display string position. Initialize cached_prev_pos to
3835 -1. Fixes slow-down at the beginning of a buffer.
3836
3837 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3838
3839 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3840 for attrs[LFACE_FONTSET_INDEX].
3841
3842 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3843
3844 * xml.c (parse_region): Remove unused local
3845 that was recently introduced.
3846
3847 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3848
3849 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3850 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3851
3852 * xdisp.c (move_it_in_display_line_to): Record the best matching
3853 position for TO_CHARPOS while scanning the line, and restore it on
3854 exit if none of the characters scanned was an exact match.
3855 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3856 when exact match is impossible due to invisible text, and the
3857 lines are truncated.
3858
3859 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3860
3861 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3862 for OSX >= 10.7.
3863
3864 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3865
3866 Fix a significant slow-down of cursor motion with C-n, C-p,
3867 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3868 auto-repeat under bidi redisplay in fontified buffers.
3869 * xdisp.c (compute_stop_pos_backwards): New function.
3870 (next_element_from_buffer): Call compute_stop_pos_backwards to
3871 find a suitable prev_stop when we find ourselves before
3872 base_level_stop.
3873 (reseat): Don't look for prev_stop, as that could mean a very long
3874 run.
3875 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3876 <cached_disp_overlay_modiff>: Cache for last found display string
3877 position.
3878 (compute_display_string_pos): Return the cached position if asked
3879 about the same buffer in the same area of character positions, and
3880 the buffer wasn't changed since the time the display string
3881 position was cached.
3882
3883 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3884
3885 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3886 is an integer, which is important for empty lines. (Bug#9149)
3887
3888 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3889
3890 * frame.c (Fmodify_frame_parameters): In tty case, update the
3891 default face if necessary (Bug#4238).
3892
3893 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3894
3895 * editfns.c (Fstring_to_char): No need to explain what a character
3896 is in the docstring (Bug#6576).
3897
3898 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3899
3900 * xml.c (parse_region): Make sure we always return a tree.
3901
3902 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3903
3904 * xml.c (parse_region): If a document contains only comments,
3905 return that, too.
3906
3907 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3908
3909 * xml.c (make_dom): Return comments, too.
3910
3911 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3912
3913 Port to OpenBSD.
3914 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3915 and the surrounding thread.
3916 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3917 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3918 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3919 timer goes off.
3920 * s/openbsd.h (BROKEN_SIGIO): Define.
3921 * unexelf.c (unexec) [__OpenBSD__]:
3922 Don't update the .mdebug section of the Alpha COFF symbol table.
3923
3924 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3925
3926 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3927 (bug#8460).
3928
3929 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3930
3931 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3932 This fixes some race conditions on the permissions of any newly
3933 created file.
3934
3935 * alloc.c (valid_pointer_p): Use pipe, not open.
3936 This fixes some permissions issues when debugging.
3937
3938 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3939 If fchown fails to set both uid and gid, try to set just gid,
3940 as that is sometimes allowed. Adjust the file's mode to eliminate
3941 setuid or setgid bits that are inappropriate if fchown fails.
3942
3943 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3944
3945 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3946 to compare Lisp_Objects.
3947 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3948 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3949 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3950
3951 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3952
3953 * lread.c (read_integer): Unread even EOF character.
3954 (read1): Likewise. Properly record start position of symbol.
3955
3956 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3957 symbol character follows.
3958
3959 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3960
3961 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3962 This works around a problem with the previous change to Fcopy_file.
3963 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3964 and without this change, GCC might complain about discarding
3965 fchown's return value.
3966
3967 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3968
3969 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3970
3971 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3972
3973 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3974
3975 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3976
3977 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3978 it's used from the C level.
3979
3980 * process.c: Use the same condition for POLL_FOR_INPUT in both
3981 keyboard.c and process.c (bug#1858).
3982
3983 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3984
3985 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3986 (Fgnutls_boot): Use it.
3987
3988 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3989
3990 * doc.c (Fsubstitute_command_keys): Revert last change.
3991
3992 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3993
3994 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3995 quotes the next character, and doesn't affect other longer
3996 sequences (bug#8935).
3997
3998 * lread.c (syms_of_lread): Clarify that is isn't only
3999 `eval-buffer' and `eval-defun' that's affected by
4000 `lexical-binding' (bug#8460).
4001
4002 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4003
4004 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4005 bidi redisplay when a line includes both an image and is truncated.
4006
4007 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4008
4009 Fix minor problems found by static checking.
4010 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4011 (elsz): Now a signed constant, not a size_t var. We prefer signed
4012 types to unsigned, to avoid integer comparison confusion. Without
4013 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4014 "cannot optimize loop, the loop counter may overflow", a symptom
4015 of the confusion.
4016 * indent.c (Fvertical_motion): Mark locals as initialized.
4017 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4018
4019 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4020
4021 * search.c (Fre_search_backward): Mention `case-fold-search' in
4022 all the re_search_* functions (bug#8138).
4023
4024 * keyboard.c (Fopen_dribble_file): Document when the file is
4025 closed (bug#8056).
4026
4027 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4028
4029 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4030 bidi_cache_idx.
4031
4032 Support bidi reordering of display and overlay strings.
4033 * xdisp.c (compute_display_string_pos)
4034 (compute_display_string_end): Accept additional argument STRING.
4035 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4036 (reseat_to_string): Initialize bidi_it->string.s and
4037 bidi_it->string.schars.
4038 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4039 NULL (avoids a crash in bidi_paragraph_init).
4040 Initialize itb.string.lstring.
4041 (init_iterator): Call bidi_init_it only of a valid
4042 buffer position was specified. Initialize paragraph_embedding to
4043 L2R.
4044 (reseat_to_string): Initialize the bidi iterator.
4045 (display_string): If we need to ignore text properties of
4046 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4047 original value of -1 will not work with bidi.)
4048 (compute_display_string_pos): First arg is now struct
4049 `text_pos *'; all callers changed. Support display properties on
4050 Lisp strings.
4051 (compute_display_string_end): Support display properties on Lisp
4052 strings.
4053 (init_iterator, reseat_1, reseat_to_string): Initialize the
4054 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4055 when iterating on a string not from display properties).
4056 (compute_display_string_pos, compute_display_string_end):
4057 Fix calculation of the object to scan. Fixes an error when using
4058 arrow keys.
4059 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4060 base_level_stop; instead, set base_level_stop to BEGV.
4061 Fixes crashes in vertical-motion.
4062 (next_element_from_buffer): Improve commentary for when
4063 the iterator is before prev_stop.
4064 (init_iterator): Initialize bidi_p from the default value of
4065 bidi-display-reordering, not from buffer-local value. Use the
4066 buffer-local value only if initializing for buffer iteration.
4067 (handle_invisible_prop): Support invisible properties on strings
4068 that are being bidi-reordered.
4069 (set_iterator_to_next): Support bidi reordering of C strings and
4070 Lisp strings.
4071 (next_element_from_string): Support bidi reordering of Lisp
4072 strings.
4073 (handle_stop_backwards): Support Lisp strings as well.
4074 (display_string): Support display of R2L glyph rows.
4075 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4076 (init_iterator): Don't initialize it->bidi_p for strings
4077 here.
4078 (reseat_to_string): Initialize it->bidi_p for strings here.
4079 (next_element_from_string, next_element_from_c_string)
4080 (next_element_from_buffer): Add xassert's for correspondence
4081 between IT's object being iterated and it->bidi_it.string
4082 structure.
4083 (face_before_or_after_it_pos): Support bidi iteration.
4084 (next_element_from_c_string): Handle the case of the first string
4085 character that is not the first one in the visual order.
4086 (get_visually_first_element): New function, refactored from common
4087 parts of next_element_from_buffer, next_element_from_string, and
4088 next_element_from_c_string.
4089 (tool_bar_lines_needed, redisplay_tool_bar)
4090 (display_menu_bar): Force left-to-right direction. Add a FIXME
4091 comment for making that be controlled by a user option.
4092 (push_it, pop_it): Save and restore the state of the
4093 bidi iterator. Save and restore the bidi_p flag.
4094 (pop_it): Iterate out of display property for string iteration as
4095 well.
4096 (iterate_out_of_display_property): Support iteration over strings.
4097 (handle_single_display_spec): Set up it->bidi_it for iteration
4098 over a display string, and call bidi_init_it.
4099 (handle_single_display_spec, next_overlay_string)
4100 (get_overlay_strings_1, push_display_prop): Set up the bidi
4101 iterator for displaying display or overlay strings.
4102 (forward_to_next_line_start): Don't use the shortcut if
4103 bidi-iterating.
4104 (back_to_previous_visible_line_start): If handle_display_prop
4105 pushed the iterator stack, restore the internal state of the bidi
4106 iterator by calling bidi_pop_it same number of times.
4107 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4108 and we are bidi-iterating, don't decrement the iterator position;
4109 instead, set the first_elt flag in the bidi iterator, to produce
4110 the same effect.
4111 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4112 (push_display_prop): xassert that we are iterating a buffer.
4113 (push_it, pop_it): Save and restore paragraph_embedding member.
4114 (handle_single_display_spec, next_overlay_string)
4115 (get_overlay_strings_1, reseat_1, reseat_to_string)
4116 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4117 correctly. Don't assume unibyte strings are not bidi-reordered.
4118 (compute_display_string_pos)
4119 (compute_display_string_end): Fix handling the case of C string.
4120 (push_it, pop_it): Save and restore from_disp_prop_p.
4121 (handle_single_display_spec, push_display_prop): Set the
4122 from_disp_prop_p flag.
4123 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4124 (pop_it): Call iterate_out_of_display_property only if we are
4125 popping after iteration over a string that came from a display
4126 property. Fix a typo in popping stretch info. Add an assertion
4127 for verifying that the iterator position is in sync with the bidi
4128 iterator.
4129 (handle_single_display_spec, get_overlay_strings_1)
4130 (push_display_prop): Fix initialization of paragraph direction for
4131 string when that of the parent object is not yet determined.
4132 (reseat_1): Call bidi_init_it to resync the bidi
4133 iterator with IT's position. (Bug#7616)
4134 (find_row_edges): If ROW->start.pos gives position
4135 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4136 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4137 Reset the from_disp_prop_p flag.
4138 (SAVE_IT, RESTORE_IT): New macros.
4139 (pos_visible_p, face_before_or_after_it_pos)
4140 (back_to_previous_visible_line_start)
4141 (move_it_in_display_line_to, move_it_in_display_line)
4142 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4143 (try_scrolling, redisplay_window, display_line): Use them when
4144 saving a temporary copy of the iterator and restoring it back.
4145 (back_to_previous_visible_line_start, reseat_1)
4146 (init_iterator): Empty the bidi cache "stack".
4147 (move_it_in_display_line_to): If iterator ended up at
4148 EOL, but we never saw any buffer positions smaller than
4149 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4150 motion in bidi-reordered lines.
4151 (move_it_in_display_line_to): Record prev_method and prev_pos
4152 immediately before the call to set_iterator_to_next. Fixes cursor
4153 motion in bidi-reordered lines with stretch glyphs and strings
4154 displayed in margins. (Bug#8133) (Bug#8867)
4155 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4156 TO_CHARPOS.
4157 (pos_visible_p): Support positions in bidi-reordered lines.
4158 Save and restore bidi cache.
4159
4160 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4161 (bidi_paragraph_info): Delete unused struct.
4162 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4163 (bidi_cache_start): New variable.
4164 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4165 to zero.
4166 (bidi_cache_fetch_state, bidi_cache_search)
4167 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4168 (bidi_cache_find, bidi_peek_at_next_level)
4169 (bidi_level_of_next_char, bidi_find_other_level_edge)
4170 (bidi_move_to_visually_next): Compare cache index with
4171 bidi_cache_start rather than with zero.
4172 (bidi_fetch_char): Accept new argument STRING; all callers
4173 changed. Support iteration over a string. Support strings with
4174 display properties. Support unibyte strings. Fix the type of
4175 `len' according to what STRING_CHAR_AND_LENGTH expects.
4176 (bidi_paragraph_init, bidi_resolve_explicit_1)
4177 (bidi_resolve_explicit, bidi_resolve_weak)
4178 (bidi_level_of_next_char, bidi_move_to_visually_next):
4179 Support iteration over a string.
4180 (bidi_set_sor_type, bidi_resolve_explicit_1)
4181 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4182 can now be zero (for strings); special values 0 and -1 were
4183 changed to -1 and -2, respectively.
4184 (bidi_char_at_pos): New function.
4185 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4186 Call it instead of FETCH_MULTIBYTE_CHAR.
4187 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4188 initialized to valid values.
4189 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4190 values.
4191 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4192 the test for valid cached positions. Fix the logic for looking up
4193 the sentinel state in the cache. GCPRO the Lisp string we are
4194 iterating.
4195 (bidi_push_it, bidi_pop_it): New functions.
4196 (bidi_initialize): Initialize the bidi cache start stack pointer.
4197 (bidi_cache_ensure_space): New function, refactored from part of
4198 bidi_cache_iterator_state. Don't assume the required size is just
4199 one BIDI_CACHE_CHUNK away.
4200 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4201 (bidi_count_bytes, bidi_char_at_pos): New functions.
4202 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4203 always valid if bidi_cache_idx is valid.
4204 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4205 is valid if it's going to be used.
4206 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4207 (bidi_cache_fetch_state, bidi_cache_search)
4208 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4209 (bidi_cache_iterator_state, bidi_cache_find)
4210 (bidi_find_other_level_edge, bidi_cache_start_stack):
4211 All variables related to cache indices are now EMACS_INT.
4212
4213 * dispextern.h (struct bidi_string_data): New structure.
4214 (struct bidi_it): New member `string'. Make flag members be 1-bit
4215 fields, and put them last in the struct.
4216 (compute_display_string_pos, compute_display_string_end):
4217 Update prototypes.
4218 (bidi_push_it, bidi_pop_it): Add prototypes.
4219 (struct iterator_stack_entry): New members bidi_p,
4220 paragraph_embedding, and from_disp_prop_p.
4221 (struct it): Member bidi_p is now a bit field 1 bit wide.
4222 (bidi_shelve_cache, bidi_unshelve_cache):
4223 Declare prototypes.
4224
4225 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4226 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4227 and vector-like objects.
4228
4229 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4230 cache around display iteration.
4231
4232 * window.c (Fwindow_end, window_scroll_pixel_based)
4233 (displayed_window_lines, Frecenter): Save and restore the bidi
4234 cache around display iteration.
4235
4236 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4237
4238 * editfns.c (Fdelete_region): Clarify the use of the named
4239 parameters (bug#6788).
4240
4241 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4242
4243 * indent.c (Fvertical_motion): Set and restore w->pointm when
4244 saving and restoring the window's buffer (Bug#9006).
4245
4246 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4247
4248 * editfns.c (Fstring_to_char): Clarify just what is returned
4249 (bug#6576). Text by Eli Zaretskii.
4250
4251 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4252
4253 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4254
4255 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4256
4257 * buffer.c (mmap_find): Fix a typo.
4258
4259 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4260
4261 Fix execution of x selection hooks.
4262 * xselect.c (Qx_lost_selection_functions)
4263 (Qx_sent_selection_functions): New vars.
4264 (syms_of_xselect): DEFSYM them.
4265 (x_handle_selection_request): Pass Qx_sent_selection_functions
4266 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4267 (x_handle_selection_clear,x_clear_frame_selections):
4268 Pass Qx_lost_selection_functions rather than
4269 Vx_lost_selection_functions to Frun_hook_with_args.
4270
4271 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4272
4273 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4274 The old code sometimes used this field without initializing it.
4275
4276 * alloc.c (gc_sweep): Don't read past end of array.
4277 In theory, the old code could also have corrupted Emacs internals,
4278 though it'd be very unlikely.
4279
4280 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4281
4282 * character.c (Fcharacterp): Don't advertise optional ignored
4283 argument. (Bug#4026)
4284
4285 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4286
4287 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4288 key" (bug#4257).
4289
4290 * window.c (Fset_window_start): Doc fix (bug#4199).
4291 (Fset_window_hscroll): Ditto.
4292
4293 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4294
4295 Fix minor new problems caught by GCC 4.6.1.
4296 * term.c (init_tty): Remove unused local.
4297 * xsettings.c (store_monospaced_changed): Define this function only
4298 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4299 not used otherwise.
4300
4301 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4302
4303 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4304
4305 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4306
4307 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4308 are the mini-buffer and the echo area (bug#3320).
4309
4310 * term.c (init_tty): Remove support for supdup, c10 and perq
4311 terminals, which are no longer supported (bug#1482).
4312
4313 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4314
4315 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4316
4317 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4318
4319 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4320 for non-popups (Bug#3642).
4321
4322 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4323
4324 * alloc.c (reset_malloc_hooks): Protoize.
4325 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4326 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4327 * cm.c (losecursor): Likewise.
4328 * data.c (fmod): Likewise.
4329 * dispnew.c (swap_glyphs_in_rows): Likewise.
4330 * emacs.c (memory_warning_signal): Likewise.
4331 * floatfns.c (float_error): Likewise.
4332 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4333 (otf_open, font_otf_capability, generate_otf_features)
4334 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4335 Likewise.
4336 * image.c (pbm_read_file): Likewise.
4337 * indent.c (string_display_width): Likewise.
4338 * intervals.c (check_for_interval, search_for_interval)
4339 (inc_interval_count, count_intervals, root_interval)
4340 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4341 * lread.c (defalias): Likewise.
4342 * ralloc.c (r_alloc_check): Likewise.
4343 * regex.c (set_image_of_range_1, set_image_of_range)
4344 (regex_grow_registers): Likewise.
4345 * sysdep.c (strerror): Likewise.
4346 * termcap.c (valid_filename_p, tprint, main): Likewise.
4347 * tparam.c (main): Likewise.
4348 * unexhp9k800.c (run_time_remap, save_data_space)
4349 (update_file_ptrs, read_header, write_header, calculate_checksum)
4350 (copy_file, copy_rest, display_header): Likewise.
4351 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4352 Likewise.
4353 * xdisp.c (check_it): Likewise.
4354 * xfaces.c (register_color, unregister_color, unregister_colors):
4355 Likewise.
4356 * xfns.c (print_fontset_result): Likewise.
4357 * xrdb.c (member, fatal, main): Likewise.
4358
4359 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4360
4361 Fix minor problems found by static checking (Bug#9031).
4362 * chartab.c (char_table_set_range, map_sub_char_table):
4363 Remove unused locals.
4364 (uniprop_table): Now static.
4365 * composite.c (_work_char): Remove unused static var.
4366
4367 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4368
4369 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4370
4371 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4372
4373 * gtkutil.c (qttip_cb): Remove code without function.
4374
4375 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4376
4377 * w32.c (pthread_sigmask): New stub.
4378
4379 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4380
4381 Use pthread_sigmask, not sigprocmask (Bug#9010).
4382 sigprocmask is portable only for single-threaded applications, and
4383 Emacs can be multi-threaded when it uses GTK.
4384 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4385 (LIBES): Use it.
4386 * callproc.c (Fcall_process):
4387 * process.c (create_process):
4388 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4389 Use pthread_sigmask, not sigprocmask.
4390
4391 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4392
4393 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4394 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4395 wrong (Bug#8591).
4396
4397 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4398
4399 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4400 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4401 (xg_hide_tooltip): Fix comment.
4402
4403 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4404 in registerServicesMenuSendTypes.
4405 (validRequestorForSendType): Don't check ns_return_types.
4406
4407 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4408 ns_return_type.
4409
4410 2011-07-08 Jason Rumney <jasonr@gnu.org>
4411
4412 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4413 SH_SHOW for hidden windows (Bug#5482).
4414
4415 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4416 frame struct members of non-existent frames (Bug#6284).
4417
4418 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4419
4420 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4421 variable firstTime not needed on OSX >= 10.6.
4422 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4423 >= 10.5. Use setKnobProportion, setDoubleValue.
4424
4425 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4426 (MAC_OS_X_VERSION_10_5): Define if not defined.
4427 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4428 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4429 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4430
4431 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4432 cString and lossyCString on OSX >= 10.4
4433
4434 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4435 sizeToFit on OSX >= 10.2.
4436
4437 * nsimage.m (allocInitFromFile): Don't use deprecated method
4438 bestRepresentationForDevice on OSX >= 10.6.
4439
4440 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4441 to avoid warning.
4442
4443 * emacs.c: Declare unexec_init_emacs_zone.
4444
4445 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4446
4447 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4448
4449 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4450 on svcsMenu (Bug#8842).
4451
4452 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4453 ns_return_types.
4454 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4455
4456 * nsterm.m (QUTF8_STRING): Declare.
4457 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4458 (validRequestorForSendType): Return type is (id).
4459 Change indexOfObjectIdenticalTo to indexOfObject.
4460 Check if we have local selection before returning self (Bug#8842).
4461 (writeSelectionToPasteboard): Put local selection into paste board
4462 if we have a local selection (Bug#8842).
4463 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4464
4465 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4466 (ns_get_local_selection): Declare.
4467
4468 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4469
4470 * keymap.c (describe_map_tree): Don't insert a double newline at
4471 the end of the buffer (bug#1169) and return whether we inserted
4472 something.
4473
4474 * callint.c (Fcall_interactively): Change "reading args" to
4475 "providing args" to try to clarify what it does (bug#1010).
4476
4477 2011-07-07 Kenichi Handa <handa@m17n.org>
4478
4479 * composite.c (composition_compute_stop_pos): Ignore a static
4480 composition starting before CHARPOS (Bug#8915).
4481
4482 * xdisp.c (handle_composition_prop): Likewise.
4483
4484 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4485
4486 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4487 (Bug#9015)
4488
4489 2011-07-07 Kenichi Handa <handa@m17n.org>
4490
4491 * character.h (unicode_category_t): New enum type.
4492
4493 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4494 (Qchar_code_property_table): New variable.
4495 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4496 (UNIPROP_COMPRESSED_FORM_P): New macros.
4497 (char_table_ascii): Uncompress the compressed values.
4498 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4499 Uncompress the compressed values.
4500 (sub_char_table_ref_and_range): Likewise.
4501 (char_table_ref_and_range): Uncompress the compressed values.
4502 (sub_char_table_set): New arg is_uniprop. Callers changed.
4503 Uncompress the compressed values.
4504 (sub_char_table_set_range): Args changed. Callers changed.
4505 (char_table_set_range): Adjuted for the above change.
4506 (map_sub_char_table): Delete args default_val and parent. Add arg
4507 top. Give decoded values to a Lisp function.
4508 (map_char_table): Adjust for the above change. Give decoded
4509 values to a Lisp function. Gcpro more variables.
4510 (uniprop_table_uncompress)
4511 (uniprop_decode_value_run_length): New functions.
4512 (uniprop_decoder, uniprop_decoder_count): New variables.
4513 (uniprop_get_decoder, uniprop_encode_value_character)
4514 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4515 New functions.
4516 (uniprop_encoder, uniprop_encoder_count): New variables.
4517 (uniprop_get_encoder, uniprop_table)
4518 (Funicode_property_table_internal, Fget_unicode_property_internal)
4519 (Fput_unicode_property_internal): New functions.
4520 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4521 Sunicode_property_table_internal, Sget_unicode_property_internal,
4522 and Sput_unicode_property_internal. Defvar_lisp
4523 char-code-property-alist.
4524
4525 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4526 Vunicode_category_table.
4527
4528 * font.c (font_range): Adjust for the change of
4529 Vunicode_category_table.
4530
4531 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4532
4533 * m/iris4d.h: Remove file, move contents ...
4534 * s/irix6-5.h: ... here.
4535
4536 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4537
4538 Remove unportable assumption about struct layout (Bug#8884).
4539 * alloc.c (mark_buffer):
4540 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4541 (clone_per_buffer_values): Don't assume that
4542 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4543 This isn't true in general, and it's particularly not true
4544 if Emacs is configured with --with-wide-int.
4545 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4546 New macros, used in the buffer.c change.
4547
4548 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4549
4550 * xsettings.c: Use both GConf and GSettings if both are available.
4551 (store_config_changed_event): Add comment.
4552 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4553 (store_tool_bar_style_changed): New functions.
4554 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4555 (struct xsettings): Move font inside HAVE_XFT.
4556 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4557 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4558 Move inside HAVE_XFT.
4559 (something_changed_gsettingsCB): Rename from something_changedCB.
4560 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4561 also.
4562 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4563 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4564 (something_changed_gconfCB): Rename from something_changedCB.
4565 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4566 (parse_settings): Move check for font inside HAVE_XFT.
4567 (read_settings, apply_xft_settings): Add comment.
4568 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4569 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4570 call store_font_name_changed.
4571 (xft_settings_event): Add comment.
4572 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4573 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4574 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4575 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4576 (xsettings_initialize): Call init_gsettings last.
4577 (xsettings_get_system_font, xsettings_get_system_normal_font):
4578 Add comment.
4579
4580 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4581
4582 Random fixes. E.g., (random) never returned negative values.
4583 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4584 subseconds part to the entropy, as that's a bit more random.
4585 Prefer signed to unsigned, since the signedness doesn't matter and
4586 in general we prefer signed. When given a limit, use a
4587 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4588 latter isn't right if USE_2_TAGS_FOR_INTS.
4589 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4590 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4591
4592 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4593
4594 * textprop.c (text_property_stickiness):
4595 Obey Vtext_property_default_nonsticky.
4596 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4597 * w32fns.c (syms_of_w32fns):
4598 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4599
4600 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4601
4602 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4603 This is more efficient than Ffile_directory_p and avoids a minor race.
4604
4605 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4606
4607 * buffer.c (Foverlay_put): Say what the return value is
4608 (bug#7835).
4609
4610 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4611 is a directory before asking whether to use the file name
4612 (bug#7564).
4613 (barf_or_query_if_file_exists): Make the "File is a directory"
4614 error be more correct.
4615
4616 * fns.c (Frequire): Remove the mention of the .gz files, since
4617 that's installation-specific, but keep the mention of
4618 `get-load-suffixes'.
4619
4620 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4621
4622 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4623 Report string overflow if the output is too long.
4624
4625 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4626
4627 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4628 (syms_of_gnutls): Remove duplicate DEFSYM for
4629 Qgnutls_bootprop_verify_hostname_error, an error for
4630 Qgnutls_bootprop_verify_error (which is no longer used).
4631
4632 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4633 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4634 Also (re)move comments that are misplaced or no longer relevant.
4635
4636 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4637
4638 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4639
4640 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4641
4642 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4643 and background color parameters if they have been changed.
4644
4645 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4646
4647 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4648
4649 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4650
4651 * xsettings.c (SYSTEM_FONT): Define only when used.
4652 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4653
4654 * keymap.c (access_keymap_1): Now static.
4655
4656 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4657
4658 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4659 leave any prefix arg for the up event (Bug#1586).
4660
4661 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4662
4663 * lread.c (syms_of_lread): Mention single symbols defined by
4664 `defvar' or `defconst' (bug#7154).
4665
4666 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4667 (Frequire): Mention get-load-suffixes.
4668
4669 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4670
4671 * window.h (window): Remove clone_number slot.
4672 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4673 Remove.
4674 (make_parent_window, make_window, saved_window)
4675 (Fset_window_configuration, save_window_save): Don't deal with
4676 clone numbers.
4677 * buffer.c (Qclone_number): Remove declaration.
4678 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4679
4680 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4681
4682 Add multiple inheritance to keymaps.
4683 * keymap.c (Fmake_composed_keymap): New function.
4684 (Fset_keymap_parent): Simplify.
4685 (fix_submap_inheritance): Remove.
4686 (access_keymap_1): New function extracted from access_keymap to handle
4687 embedded parents and handle lists of maps.
4688 (access_keymap): Use it.
4689 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4690 (Fcopy_keymap): Handle embedded parents.
4691 (Fcommand_remapping, define_as_prefix): Simplify.
4692 (Fkey_binding): Simplify.
4693 (syms_of_keymap): Move minibuffer-local-completion-map,
4694 minibuffer-local-filename-completion-map,
4695 minibuffer-local-must-match-map, and
4696 minibuffer-local-filename-must-match-map to Elisp.
4697 (syms_of_keymap): Defsubr make-composed-keymap.
4698 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4699 (parse_menu_item): Trivial simplification.
4700
4701 2011-07-01 Glenn Morris <rgm@gnu.org>
4702
4703 * Makefile.in (SETTINGS_LIBS): Fix typo.
4704
4705 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4706
4707 * coding.c (Fencode_coding_string): Record the last coding system
4708 used, as the function doc string says (bug#8738).
4709
4710 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4711
4712 * xsettings.c (store_monospaced_changed): Take new font as arg and
4713 check for change against current_mono_font.
4714 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4715 (emacs_settings_constructor, emacs_settings_get_property)
4716 (emacs_settings_set_property, emacs_settings_class_init)
4717 (emacs_settings_init, gsettings_obj): Remove.
4718 (something_changedCB): New function for HAVE_GSETTINGS.
4719 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4720 with value as argument.
4721 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4722 g_settings_new (Bug#8967). Do not create gsettings_obj.
4723 Remove calls to g_settings_bind. Connect something_changedCB to
4724 "changed".
4725
4726 * xgselect.c: Add defined (HAVE_GSETTINGS).
4727 (xgselect_initialize): Ditto.
4728
4729 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4730 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4731 xg_select.
4732
4733 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4734
4735 * eval.c (struct backtrace): Simplify and port the data structure.
4736 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4737 signed bit field, as this assumption is not portable and it makes
4738 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4739 "char debug_on_exit : 1" as this is not portable either; instead,
4740 use the portable "unsigned int debug_on_exit : 1". Remove unused
4741 member evalargs. Remove obsolete comments about cc bombing out.
4742
4743 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4744
4745 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4746 Let HAVE_GSETTINGS override HAVE_GCONF.
4747 (store_monospaced_changed): New function.
4748 (EMACS_SETTINGS): A new type derived from GObject to handle
4749 GSettings notifications.
4750 (emacs_settings_constructor, emacs_settings_get_property)
4751 (emacs_settings_set_property, emacs_settings_class_init):
4752 New functions.
4753 (gsettings_client, gsettings_obj): New variables.
4754 (GSETTINGS_SCHEMA): New define.
4755 (something_changedCB): Call store_monospaced_changed.
4756 (init_gsettings): New function.
4757 (xsettings_initialize): Call init_gsettings.
4758 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4759 to NULL.
4760
4761 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4762 GCONF_CFLAGS/LIBS.
4763
4764 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4765
4766 * window.c (resize_root_window, grow_mini_window)
4767 (shrink_mini_window): Rename Qresize_root_window to
4768 Qwindow_resize_root_window and Qresize_root_window_vertically to
4769 Qwindow_resize_root_window_vertically.
4770
4771 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4772
4773 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4774
4775 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4776
4777 * makefile.w32-in: Redesign dependencies so they reflect more
4778 clearly which files are directly included by each source file,
4779 and not through other includes.
4780
4781 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4782
4783 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4784 (sort_overlays, overlay_strings): When an overlay's clone number
4785 matches the window's clone number process the overlay even if
4786 the overlay's window property doesn't match the current window.
4787
4788 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4789 (Fwindow_hchild): Rename to Fwindow_left_child.
4790 (Fwindow_next): Rename to Fwindow_next_sibling.
4791 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4792 (resize_window_check): Rename to window_resize_check.
4793 (resize_window_apply): Rename to window_resize_apply.
4794 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4795 (Fdelete_other_windows_internal, resize_frame_windows)
4796 (Fsplit_window_internal, Fdelete_window_internal)
4797 (grow_mini_window, shrink_mini_window)
4798 (Fresize_mini_window_internal): Fix callers accordingly.
4799
4800 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4801
4802 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4803 (emacs_fixed_set_min_size): Remove.
4804 (emacs_fixed_new): Take frame as argument.
4805
4806 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4807 (_EmacsFixedPrivate): Remove minwidth/height.
4808 Add struct frame *f.
4809 (emacs_fixed_init): Initialize priv->f.
4810 (get_parent_class, emacs_fixed_set_min_size): Remove.
4811 (emacs_fixed_new): Set priv->f to argument.
4812 (emacs_fixed_get_preferred_width)
4813 (emacs_fixed_get_preferred_height): Use min_width/height from
4814 frames size_hint to set minimum and natural (Bug#8919).
4815 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4816 and use min_width/height from frames size_hint to set
4817 min_width/height (Bug#8919).
4818
4819 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4820 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4821 Fix indentation.
4822
4823 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4824
4825 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4826 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4827 called at ZV.
4828
4829 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4830
4831 * process.c (wait_reading_process_output): Bypass select if
4832 waiting for a cell while ignoring keyboard input, and input is
4833 pending. Suggested by Jan Djärv (Bug#8869).
4834
4835 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4836
4837 Use gnulib's dup2 module instead of rolling our own.
4838 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4839
4840 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4841
4842 * dispnew.c (scrolling_window): Before scrolling, turn off a
4843 mouse-highlight in the window being scrolled.
4844
4845 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4846
4847 Move DEFSYM to lisp.h and use everywhere.
4848
4849 * character.h (DEFSYM): Move declaration...
4850 * lisp.h (DEFSYM): ...here.
4851
4852 * gnutls.c:
4853 * minibuf.c:
4854 * w32menu.c:
4855 * w32proc.c:
4856 * w32select.c: Don't include character.h.
4857
4858 * alloc.c (syms_of_alloc):
4859 * buffer.c (syms_of_buffer):
4860 * bytecode.c (syms_of_bytecode):
4861 * callint.c (syms_of_callint):
4862 * casefiddle.c (syms_of_casefiddle):
4863 * casetab.c (init_casetab_once):
4864 * category.c (init_category_once, syms_of_category):
4865 * ccl.c (syms_of_ccl):
4866 * cmds.c (syms_of_cmds):
4867 * composite.c (syms_of_composite):
4868 * dbusbind.c (syms_of_dbusbind):
4869 * dired.c (syms_of_dired):
4870 * dispnew.c (syms_of_display):
4871 * doc.c (syms_of_doc):
4872 * editfns.c (syms_of_editfns):
4873 * emacs.c (syms_of_emacs):
4874 * eval.c (syms_of_eval):
4875 * fileio.c (syms_of_fileio):
4876 * fns.c (syms_of_fns):
4877 * frame.c (syms_of_frame):
4878 * fringe.c (syms_of_fringe):
4879 * insdel.c (syms_of_insdel):
4880 * keymap.c (syms_of_keymap):
4881 * lread.c (init_obarray, syms_of_lread):
4882 * macros.c (syms_of_macros):
4883 * msdos.c (syms_of_msdos):
4884 * print.c (syms_of_print):
4885 * process.c (syms_of_process):
4886 * search.c (syms_of_search):
4887 * sound.c (syms_of_sound):
4888 * syntax.c (init_syntax_once, syms_of_syntax):
4889 * terminal.c (syms_of_terminal):
4890 * textprop.c (syms_of_textprop):
4891 * undo.c (syms_of_undo):
4892 * w32.c (globals_of_w32):
4893 * window.c (syms_of_window):
4894 * xdisp.c (syms_of_xdisp):
4895 * xfaces.c (syms_of_xfaces):
4896 * xfns.c (syms_of_xfns):
4897 * xmenu.c (syms_of_xmenu):
4898 * xsettings.c (syms_of_xsettings):
4899 * xterm.c (syms_of_xterm): Use DEFSYM.
4900
4901 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4902
4903 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4904
4905 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4906
4907 Integer and buffer overflow fixes (Bug#8873).
4908
4909 * print.c (printchar, strout): Check for string overflow.
4910 (PRINTPREPARE, printchar, strout):
4911 Don't set size unless allocation succeeds.
4912
4913 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4914 for sizes. Check for string overflow more accurately.
4915 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4916
4917 * macros.c: Integer and buffer overflow fixes.
4918 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4919 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4920 Use ptrdiff_t, not int, for sizes.
4921 Don't increment bufsize until after realloc succeeds.
4922 Check for size-calculation overflow.
4923 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4924
4925 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4926
4927 * lread.c: Integer overflow fixes.
4928 (read_integer): Radix is now EMACS_INT, not int,
4929 to improve quality of diagnostics for out-of-range radices.
4930 Calculate buffer size correctly for out-of-range radices.
4931 (read1): Check for integer overflow in radices, and in
4932 read-circle numbers.
4933 (read_escape): Avoid int overflow.
4934 (Fload, openp, read_buffer_size, read1)
4935 (substitute_object_recurse, read_vector, read_list, map_obarray):
4936 Use ptrdiff_t, not int, for sizes.
4937 (read1): Use EMACS_INT, not int, for sizes.
4938 Check for size overflow.
4939
4940 * image.c (cache_image): Check for size arithmetic overflow.
4941
4942 * lread.c: Integer overflow issues.
4943 (saved_doc_string_size, saved_doc_string_length)
4944 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4945 Now ptrdiff_t, not int.
4946 (read1): Don't assume doc string length fits in int. Check for
4947 out-of-range doc string lengths.
4948 (read_list): Don't assume file position fits in int.
4949 (read_escape): Check for hex character overflow.
4950
4951 2011-06-22 Leo Liu <sdl.web@gmail.com>
4952
4953 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4954 Move to minibuffer.el.
4955
4956 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4957
4958 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4959 The following patches are for when GLYPH_DEBUG && !XASSERT.
4960 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4961 * dispnew.c (flush_stdout):
4962 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4963 Mark as externally visible.
4964 * dispnew.c (check_window_matrix_pointers): Now static.
4965 * dispnew.c (window_to_frame_vpos):
4966 * xfns.c (unwind_create_frame):
4967 * xterm.c (x_check_font): Remove unused local.
4968 * scroll.c (CHECK_BOUNDS):
4969 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4970 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4971 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4972 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4973 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4974 Now static.
4975 (debug_method_add): Use va_list and vsprintf rather than relying
4976 on undefined behavior with wrong number of arguments.
4977 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4978 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4979 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4980 since we're not interested in debugging glyphs with old libraries.
4981 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4982 GCC 4.6.0's static checking.
4983
4984 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4985
4986 Integer overflow and signedness fixes (Bug#8873).
4987 A few related buffer overrun fixes, too.
4988
4989 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4990
4991 * dispextern.h (struct face.stipple):
4992 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4993 (x_bitmap_mask, x_allocate_bitmap_record)
4994 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4995 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4996 (x_create_bitmap_from_xpm_data):
4997 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4998 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4999 (.bitmaps_last):
5000 * xfaces.c (load_pixmap):
5001 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5002 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5003 (.bitmaps_last, struct x_output.icon_bitmap):
5004 Use ptrdiff_t, not int, for bitmap indexes.
5005 (x_allocate_bitmap_record): Check for size overflow.
5006 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5007
5008 Use ptrdiff_t, not int, for overlay counts.
5009 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5010 * editfns.c (overlays_around, get_pos_property):
5011 * textprop.c (get_char_property_and_overlay):
5012 * xdisp.c (next_overlay_change, note_mouse_highlight):
5013 * xfaces.c (face_at_buffer_position):
5014 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5015 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5016 (Fnext_overlay_change, Fprevious_overlay_change)
5017 (mouse_face_overlay_overlaps, Foverlays_in):
5018 Use ptrdiff_t, not int, for sizes.
5019 (overlays_at, overlays_in): Check for size-calculation overflow.
5020
5021 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5022
5023 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5024 (x_session_initialize): Do not assume string length fits in int.
5025
5026 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5027 This is unlikely, but can occur if DPI is outlandish.
5028
5029 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5030 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5031
5032 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5033 * xrdb.c (magic_file_p, search_magic_path):
5034 Omit last arg SUFFIX; it was always 0. All callers changed.
5035 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5036
5037 * xfont.c (xfont_match): Avoid need for strlen.
5038
5039 * xfns.c: Don't assume strlen fits in int.
5040 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5041
5042 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5043 not unsigned long, as we prefer signed integers. All callers changed.
5044 Detect integer overflow in repeat count.
5045 (message_dolog): Don't assume print length fits in 39 bytes.
5046 (display_mode_element): Don't assume strlen fits in int.
5047
5048 * termcap.c: Don't assume sizes fit in int and never overflow.
5049 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5050 (gobble_line): Check for size-calculation overflow.
5051
5052 * minibuf.c (Fread_buffer):
5053 * lread.c (intern, intern_c_string):
5054 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5055 Don't assume string length fits in int.
5056
5057 * keyboard.c (parse_tool_bar_item):
5058 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5059
5060 * font.c: Don't assume string length fits in int.
5061 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5062 Use ptrdiff_t, not int.
5063 (font_intern_prop): Don't assume string length fits in int.
5064 Don't assume integer property fits in fixnum.
5065 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5066
5067 * filelock.c: Fix some buffer overrun and integer overflow issues.
5068 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5069 Reformulate so as not to need the command string.
5070 Invoke gzip -cd rather than gunzip, as it's more portable.
5071 (lock_info_type, lock_file_1, lock_file):
5072 Don't assume pid_t and time_t fit in unsigned long.
5073 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5074 (current_lock_owner): Prefer signed type for sizes.
5075 Use memcpy, not strncpy, where memcpy is what is really wanted.
5076 Don't assume (via atoi) that time_t and pid_t fit in int.
5077 Check for time_t and/or pid_t out of range, e.g., via a network share.
5078 Don't alloca where an auto var works fine.
5079
5080 * fileio.c: Fix some integer overflow issues.
5081 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5082 Don't assume string length fits in int.
5083 (directory_file_name): Don't assume string length fits in long.
5084 (make_temp_name): Don't assume pid fits in int, or that its print
5085 length is less than 20.
5086
5087 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5088
5089 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5090
5091 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5092
5093 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5094 We prefer signed integers, even for size calculations.
5095
5096 * emacs.c: Don't assume string length fits in 'int'.
5097 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5098 (main): Don't invoke strlen when not needed.
5099
5100 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5101 (XD_DEBUG_MESSAGE): Don't waste a byte.
5102
5103 * callproc.c (getenv_internal_1, getenv_internal)
5104 (Fgetenv_internal):
5105 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5106
5107 * lread.c (invalid_syntax): Omit length argument.
5108 All uses changed. This doesn't fix a bug, but it simplifies the
5109 code away from its former Hollerith-constant appearance, and it's
5110 one less 'int' to worry about when looking at integer-overflow issues.
5111 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5112
5113 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5114 This didn't break anything, but it didn't help either.
5115 It's confusing to put a bogus integer in a place where the actual
5116 value does not matter.
5117 (LIST_END_P): Remove unused macro and its bogus comment.
5118 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5119
5120 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5121 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5122 implementation.
5123 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5124 We prefer signed types, and the value cannot exceed the EMACS_INT
5125 range anyway (because otherwise the length would not be representable).
5126 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5127 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5128 This avoids a GCC warning when WIDE_EMACS_INT.
5129
5130 * indent.c (sane_tab_width): New function.
5131 (current_column, scan_for_column, Findent_to, position_indentation)
5132 (compute_motion): Use it. This is just for clarity.
5133 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5134
5135 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5136
5137 * lisp.h (lint_assume): New macro.
5138 * composite.c (composition_gstring_put_cache):
5139 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5140
5141 * editfns.c, insdel.c:
5142 Omit unnecessary forward decls, to simplify future changes.
5143
5144 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5145
5146 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5147
5148 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5149 Use much-faster test for byte-length change.
5150 Don't assume string byte-length fits in 'int'.
5151 Check that character arg fits in 'int'.
5152 (mapcar1): Declare byte as byte, for clarity.
5153
5154 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5155
5156 * fns.c (concat): Catch string overflow earlier.
5157 Do not rely on integer wraparound.
5158
5159 * dispextern.h (struct it.overlay_strings_charpos)
5160 (struct it.selective): Now EMACS_INT, not int.
5161 * xdisp.c (forward_to_next_line_start)
5162 (back_to_previous_visible_line_start)
5163 (reseat_at_next_visible_line_start, next_element_from_buffer):
5164 Don't arbitrarily truncate the value of 'selective' to int.
5165
5166 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5167
5168 * composite.c: Don't truncate sizes to 'int'.
5169 (composition_gstring_p, composition_reseat_it)
5170 (composition_adjust_point): Use EMACS_INT, not int.
5171 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5172 not EMACS_UINT, for indexes.
5173
5174 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5175
5176 * buffer.c: Include <verify.h>.
5177 (struct sortvec.priority, struct sortstr.priority):
5178 Now EMACS_INT, not int.
5179 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5180 (struct sortstr.size, record_overlay_string)
5181 (struct sortstrlist.size, struct sortlist.used):
5182 Don't truncate size to int.
5183 (record_overlay_string): Check for size-calculation overflow.
5184 (init_buffer_once): Check at compile-time, not run-time.
5185
5186 2011-06-22 Jim Meyering <meyering@redhat.com>
5187
5188 Don't leak an XBM-image-sized buffer
5189 * image.c (xbm_load): Free the image buffer after using it.
5190
5191 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5192
5193 Port to Sun C.
5194 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5195 that Sun C diagnosed.
5196 * fns.c (secure_hash): Fix pointer signedness issue.
5197 * intervals.c (static_offset_intervals): New function.
5198 (offset_intervals): Use it.
5199
5200 2011-06-21 Leo Liu <sdl.web@gmail.com>
5201
5202 * deps.mk (fns.o):
5203 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5204 sha512.h.
5205
5206 * fns.c (secure_hash): Rename from crypto_hash_function and change
5207 the first arg to accept symbols.
5208 (Fsecure_hash): New primitive.
5209 (syms_of_fns): New symbols.
5210
5211 2011-06-20 Deniz Dogan <deniz@dogan.se>
5212
5213 * process.c (Fset_process_buffer): Clarify return value in
5214 docstring.
5215
5216 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5217
5218 * dispnew.c (add_window_display_history): Use BVAR.
5219
5220 * xdisp.c (debug_method_add): Use BVAR.
5221 (check_window_end, dump_glyph_matrix, dump_glyph)
5222 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5223
5224 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5225 Likewise.
5226
5227 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5228 check till after the cache is created in init_frame_faces.
5229
5230 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5231
5232 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5233
5234 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5235
5236 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5237 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5238 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5239
5240 Improve buffer-overflow checking (Bug#8873).
5241 * fileio.c (Finsert_file_contents):
5242 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5243 Remove the old (too-loose) buffer overflow checks.
5244 They weren't needed, since make_gap checks for buffer overflow.
5245 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5246 The old code merely checked for Emacs fixnum overflow, and relied
5247 on undefined (wraparound) behavior. The new code avoids undefined
5248 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5249
5250 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5251 Tune. Don't use wider integers than needed. Don't use alloca.
5252 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5253
5254 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5255
5256 * insdel.c, lisp.h (buffer_overflow): New function.
5257 (insert_from_buffer_1, replace_range, replace_range_2):
5258 * insdel.c (make_gap_larger):
5259 * editfns.c (Finsert_char):
5260 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5261
5262 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5263
5264 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5265
5266 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5267
5268 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5269 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5270
5271 * fileio.c: Don't assume EMACS_INT fits in off_t.
5272 (emacs_lseek): New static function.
5273 (Finsert_file_contents, Fwrite_region): Use it.
5274 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5275
5276 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5277
5278 * fns.c: Don't overflow int when computing a list length.
5279 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5280 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5281 truncation on 64-bit hosts. Check for QUIT every
5282 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5283 faster and is responsive enough.
5284 (Flength): Report an error instead of overflowing an integer.
5285 (Fsafe_length): Return a float if the value is not representable
5286 as a fixnum. This shouldn't happen except in contrived situations.
5287 (Fnthcdr, Fsort): Don't assume list length fits in int.
5288 (Fcopy_sequence): Don't assume vector length fits in int.
5289
5290 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5291 (header_size, word_size): New constants.
5292 (allocate_vectorlike): Don't check size overflow here.
5293 (allocate_vector): Check it here instead, since this is the only
5294 caller of allocate_vectorlike that could cause overflow.
5295 Check that the new vector's length is representable as a fixnum.
5296
5297 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5298 The previous code was bogus. For example, next_almost_prime (32)
5299 returned 39, which is undesirable as it is a multiple of 3; and
5300 next_almost_prime (24) returned 25, which is a multiple of 5 so
5301 why was the code bothering to check for multiples of 7?
5302
5303 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5304
5305 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5306
5307 Variadic C functions now count arguments with ptrdiff_t.
5308 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5309 Back then I didn't know that the Emacs coding style prefers signed int.
5310 Also, in the meantime I found a few more instances where arguments
5311 were being counted with int, which may truncate counts on 64-bit
5312 machines, or EMACS_INT, which may be unnecessarily wide.
5313 * lisp.h (struct Lisp_Subr.function.aMANY)
5314 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5315 Arg counts are now ptrdiff_t, not size_t.
5316 All variadic functions and their callers changed accordingly.
5317 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5318 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5319 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5320 * callint.c (Fcall_interactively): Check arg count for overflow,
5321 to avoid potential buffer overrun. Use signed char, not 'int',
5322 for 'varies' array, so that we needn't bother to check its size
5323 calculation for overflow.
5324 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5325 * eval.c (apply_lambda):
5326 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5327 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5328 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5329
5330 * callint.c (Fcall_interactively): Don't use index var as event count.
5331
5332 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5333 * mem-limits.h (SIZE): Remove; no longer used.
5334
5335 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5336
5337 Remove unnecessary casts.
5338 * xterm.c (x_term_init):
5339 * xfns.c (x_set_border_pixel):
5340 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5341 These aren't needed now that we assume ANSI C.
5342
5343 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5344 It's more likely to cause problems (due to unsigned overflow)
5345 than to cure them.
5346
5347 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5348
5349 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5350
5351 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5352
5353 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5354
5355 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5356
5357 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5358
5359 GLYPH_CODE_FACE returns EMACS_INT, not int.
5360 * dispextern.h (merge_faces):
5361 * xfaces.c (merge_faces):
5362 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5363 Don't assume EMACS_INT fits in int.
5364
5365 * character.h (CHAR_VALID_P): Remove unused parameter.
5366 * fontset.c, lisp.h, xdisp.c: All uses changed.
5367
5368 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5369
5370 * fns.c (concat): Minor tuning based on overflow analysis.
5371 This doesn't fix any bugs. Use int to hold character, instead
5372 of constantly refetching from Emacs object. Use XFASTINT, not
5373 XINT, for value known to be a character. Don't bother comparing
5374 a single byte to 0400, as it's always less.
5375
5376 * floatfns.c (Fexpt):
5377 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5378
5379 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5380 for characters.
5381
5382 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5383
5384 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5385 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5386 incorrectly succeed when S was a string, because 4294967386 was
5387 truncated before it was used.
5388
5389 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5390 Otherwise, an out-of-range integer could cause undefined behavior
5391 on a 64-bit host.
5392
5393 * composite.c: Use int, not EMACS_INT, for characters.
5394 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5395 EMACS_INT, for values that are known to be in character range.
5396 This doesn't fix any bugs but is the usual style inside Emacs and
5397 may generate better code on 32-bit machines.
5398
5399 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5400 This is for reasons similar to the recent CHAR_STRING fix.
5401 * charset.c (Fencode_char): Check that character arg is actually
5402 a character. Pass an int to ENCODE_CHAR.
5403 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5404 wider than 'int', as a compile-time check to prevent future regressions
5405 in this area.
5406
5407 * character.c (char_string): Remove unnecessary casts.
5408
5409 Make sure a 64-bit char is never passed to CHAR_STRING.
5410 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5411 by silently ignoring the top 32 bits, allowing some values
5412 that were far too large to be valid characters.
5413 * character.h: Include <verify.h>.
5414 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5415 arguments are no wider than unsigned, as a compile-time check
5416 to prevent future regressions in this area.
5417 * data.c (Faset):
5418 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5419 (Fsubst_char_in_region):
5420 * fns.c (concat):
5421 * xdisp.c (decode_mode_spec_coding):
5422 Adjust to CHAR_STRING's new requirement.
5423 * editfns.c (Finsert_char, Fsubst_char_in_region):
5424 * fns.c (concat): Check that character args are actually
5425 characters. Without this test, these functions did the wrong
5426 thing with wildly out-of-range values on 64-bit hosts.
5427
5428 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5429 These casts should not be needed on 32-bit hosts, either.
5430 * keyboard.c (read_char):
5431 * lread.c (Fload): Remove casts to unsigned.
5432
5433 * lisp.h (UNSIGNED_CMP): New macro.
5434 This fixes comparison bugs on 64-bit hosts.
5435 (ASCII_CHAR_P): Use it.
5436 * casefiddle.c (casify_object):
5437 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5438 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5439 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5440 * dispextern.h (FACE_FROM_ID):
5441 * keyboard.c (read_char): Use UNSIGNED_CMP.
5442
5443 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5444 not to EMACS_INT, to avoid GCC warning.
5445
5446 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5447
5448 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5449 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5450 isn't needed on 32-bit machines.
5451
5452 * buffer.c (Fgenerate_new_buffer_name):
5453 Use EMACS_INT for count, not int.
5454 (advance_to_char_boundary): Return EMACS_INT, not int.
5455
5456 * data.c (Qcompiled_function): Now static.
5457
5458 * window.c (window_body_lines): Now static.
5459
5460 * image.c (gif_load): Rename local to avoid shadowing.
5461
5462 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5463 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5464 * alloc.c (make_save_value): Integer argument is now of type
5465 ptrdiff_t, not int.
5466 (mark_object): Use ptrdiff_t, not int.
5467 * lisp.h (pD): New macro.
5468 * print.c (print_object): Use it.
5469
5470 * alloc.c: Use EMACS_INT, not int, to count objects.
5471 (total_conses, total_markers, total_symbols, total_vector_size)
5472 (total_free_conses, total_free_markers, total_free_symbols)
5473 (total_free_floats, total_floats, total_free_intervals)
5474 (total_intervals, total_strings, total_free_strings):
5475 Now EMACS_INT, not int. All uses changed.
5476 (Fgarbage_collect): Compute overall total using a double, so that
5477 integer overflow is less likely to be a problem. Check for overflow
5478 when converting back to an integer.
5479 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5480 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5481 These were 'int' variables that could overflow on 64-bit hosts;
5482 they were never used, so remove them instead of repairing them.
5483 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5484 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5485 Previously, this ceilinged at INT_MAX, but that doesn't work on
5486 64-bit machines.
5487 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5488
5489 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5490 (allocate_vectorlike): Check for ptrdiff_t overflow.
5491 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5492 when a (possibly-narrower) signed value would do just as well.
5493 We prefer using signed arithmetic, to avoid comparison confusion.
5494
5495 * alloc.c: Catch some string size overflows that we were missing.
5496 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5497 for convenience in STRING_BYTES_MAX.
5498 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5499 The definition here is exact; the one in lisp.h was approximate.
5500 (allocate_string_data): Check for string overflow. This catches
5501 some instances we weren't catching before. Also, it catches
5502 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5503 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5504 and ptrdiff_t and EMACS_INT are both 64 bits.
5505
5506 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5507 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5508 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5509
5510 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5511
5512 * alloc.c (Fmake_string): Check for out-of-range init.
5513
5514 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5515
5516 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5517
5518 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5519
5520 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5521 xg_get_default_scrollbar_width.
5522
5523 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5524 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5525 (style_changed_cb): Call update_theme_scrollbar_width and call
5526 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5527 all frames (Bug#8505).
5528 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5529 Call gtk_window_set_resizable if HAVE_GTK3.
5530 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5531 and height if HAVE_GTK3 (Bug#8505).
5532 (scroll_bar_width_for_theme): New variable.
5533 (update_theme_scrollbar_width): New function.
5534 (xg_get_default_scrollbar_width): Move code to
5535 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5536 (xg_initialize): Call update_theme_scrollbar_width.
5537
5538 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5539
5540 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5541
5542 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5543
5544 * frame.c (make_frame): Call other_buffer_safely instead of
5545 other_buffer.
5546
5547 * window.c (temp_output_buffer_show): Call display_buffer with
5548 second argument Vtemp_buffer_show_specifiers and reset latter
5549 immediately after the call.
5550 (Vtemp_buffer_show_specifiers): New variable.
5551 (auto_window_vscroll_p, next_screen_context_lines)
5552 (Vscroll_preserve_screen_position): Remove leading asterisks from
5553 doc-strings.
5554
5555 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5556
5557 Fix minor problems found by GCC 4.6.0 static checking.
5558 * buffer.c (Qclone_number): Remove for now, as it's unused.
5559 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5560 (record_buffer): Remove unused local.
5561 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5562 (set_frame_buffer_list): Remove; unused.
5563 * frame.h (other_visible_frames): Remove decl.
5564 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5565 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5566 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5567 if HAVE_GPM.
5568 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5569 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5570 Define only if HAVE_GPM.
5571 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5572 (update_hints_inhibit): Remove; never set. All uses removed.
5573 * widgetprv.h (emacsFrameClassRec): Remove decl.
5574 * window.c (delete_deletable_window): Now returns void, since it
5575 wasn't returning anything.
5576 (compare_window_configurations): Remove unused locals.
5577 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5578 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5579 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5580 the same widths as pointers. This follows up on the 2011-05-06 patch.
5581 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5582 * xterm.h: Likewise.
5583 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5584
5585 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5586
5587 * makefile.w32-in: Update dependencies.
5588 (LISP_H): Add lib/intprops.h.
5589
5590 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5591
5592 * image.c (gif_load): Add animation frame delay to the metadata.
5593 (syms_of_image): Use DEFSYM. New symbol `delay'.
5594
5595 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5596
5597 * window.c (delete_deletable_window): Re-add.
5598 (Fset_window_configuration): Rewrite to handle dead buffers and
5599 consequently deletable windows.
5600 (window_tree, Fwindow_tree): Remove. Supply functionality in
5601 window.el.
5602 (compare_window_configurations): Simplify code.
5603
5604 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5605
5606 * image.c (imagemagick_load_image): Fix type mismatch.
5607 (Fimagemagick_types): Likewise.
5608
5609 * window.h (replace_buffer_in_windows): Declare.
5610
5611 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5612
5613 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5614 Qclone_number. Remove external declaration of Qdelete_window.
5615 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5616 code.
5617 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5618 Run Qbuffer_list_update_hook if allowed.
5619 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5620 buffer list implementation.
5621 (other_buffer_safely): New function.
5622 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5623 calls to replace_buffer_in_windows and
5624 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5625 if allowed.
5626 (record_buffer): Inhibit quitting and rewrite using quittable
5627 functions. Run Qbuffer_list_update_hook if allowed.
5628 (Frecord_buffer, Funrecord_buffer): New functions.
5629 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5630 Move switch-to-buffer to window.el.
5631 (bury-buffer): Move to window.el.
5632 (Vbuffer_list_update_hook): New variable.
5633
5634 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5635 section.
5636
5637 * window.h (resize_frame_windows): Move up in code.
5638 (Fwindow_frame): Remove EXFUN.
5639 (replace_buffer_in_all_windows): Remove prototype.
5640 (replace_buffer_in_windows_safely): Add prototype.
5641
5642 * window.c: Declare Qdelete_window static again. Move down
5643 declaration of select_count.
5644 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5645 (Fother_window): Move to window.el.
5646 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5647 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5648 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5649 window.el.
5650 (replace_buffer_in_windows): Implement by calling
5651 Qreplace_buffer_in_windows.
5652 (replace_buffer_in_all_windows): Remove with some functionality
5653 moved into replace_buffer_in_windows_safely.
5654 (replace_buffer_in_windows_safely): New function.
5655 (select_window_norecord, select_frame_norecord): Move in front
5656 of run_window_configuration_change_hook. Remove now obsolete
5657 declarations.
5658 (Fset_window_buffer): Rewrite doc-string.
5659 Call Qrecord_window_buffer.
5660 (keys_of_window): Move binding for other-window to window.el.
5661
5662 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5663
5664 * dispextern.h (struct image): Replace data member, whose int_val
5665 and ptr_val fields were not used by anything, with a single
5666 lisp_val object.
5667
5668 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5669 (gif_clear_image, gif_load, imagemagick_load_image)
5670 (gs_clear_image, gs_load): Callers changed.
5671
5672 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5673
5674 * buffer.h: Include <time.h>, for time_t.
5675 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5676
5677 Fix minor problems found by static checking.
5678
5679 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5680
5681 Make identifiers static if they are not used in other modules.
5682 * data.c (Qcompiled_function, Qframe, Qvector):
5683 * image.c (QimageMagick, Qsvg):
5684 * minibuf.c (Qmetadata):
5685 * window.c (resize_window_check, resize_root_window): Now static.
5686 * window.h (resize_window_check, resize_root_window): Remove decls.
5687
5688 * window.c (window_deletion_count, delete_deletable_window):
5689 Remove; unused.
5690 (window_body_lines): Now static.
5691 (Fdelete_other_windows_internal): Mark vars as initialized.
5692 Make sure 'resize_failed' is initialized.
5693 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5694 (resize_window_apply): Remove unused local.
5695 * window.h (delete_deletable_window): Remove decl.
5696
5697 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5698 (imagemagick_load_image): Fix pointer signedness problem by changing
5699 last arg from unsigned char * to char *. All uses changed.
5700 Also, fix a local for similar reasons.
5701 Remove unused locals. Remove locals to avoid shadowing.
5702 (fn_rsvg_handle_free): Remove; unused.
5703 (svg_load, svg_load_image): Fix pointer signedness problem.
5704 (imagemagick_load_image): Don't use garbage pointer image_wand.
5705
5706 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5707
5708 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5709
5710 * image.c (gif_load): Fix omitted cast error introduced by
5711 2011-06-06 change.
5712
5713 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5714
5715 * window.h (resize_proportionally, orig_total_lines)
5716 (orig_top_line): Remove from window structure.
5717 (set_window_height, set_window_width, change_window_heights)
5718 (Fdelete_window): Remove prototypes.
5719 (resize_frame_windows): Remove duplicate declaration.
5720
5721 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5722
5723 * window.h (resize_frame_windows, resize_window_check)
5724 (delete_deletable_window, resize_root_window)
5725 (resize_frame_windows): Declare prototypes.
5726
5727 * window.c (resize_window_apply): Make definition be "static" to
5728 match the prototype.
5729
5730 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5731
5732 * window.c: Remove declarations of Qwindow_size_fixed,
5733 window_min_size_1, window_min_size_2, window_min_size,
5734 size_window, window_fixed_size_p, enlarge_window, delete_window.
5735 Remove static from declaration of Qdelete_window, it's
5736 temporarily needed by Fbury_buffer.
5737 (replace_window): Don't assign orig_top_line and
5738 orig_total_lines.
5739 (Fdelete_window, delete_window): Remove. Window deletion is
5740 handled by window.el.
5741 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5742 Replace Fdelete_window calls with calls to Qdelete_window.
5743 (Fdelete_other_windows): Remove. Deleting other windows is
5744 handled by window.el.
5745 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5746 handled in window.el.
5747 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5748 Window minimum sizes are handled in window.el.
5749 (shrink_windows, size_window, set_window_height)
5750 (set_window_width, change_window_heights, window_height)
5751 (window_width, CURBEG, CURSIZE, enlarge_window)
5752 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5753 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5754 handled in window.el.
5755 (make_dummy_parent): Rename to make_parent_window and give it a
5756 second argument horflag.
5757 (make_window): Don't set resize_proportionally any more.
5758 (Fsplit_window): Remove. Windows are split in window.el.
5759 (save_restore_action, save_restore_orig_size)
5760 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5761 Resize mini windows in window.el.
5762 (grow_mini_window, shrink_mini_window): Implement by calling
5763 Qresize_root_window_vertically, resize_window_check and
5764 resize_window_apply.
5765 (saved_window, Fset_window_configuration, save_window_save):
5766 Do not handle orig_top_line, orig_total_lines, and
5767 resize_proportionally.
5768 (window_min_height, window_min_width): Move to window.el.
5769 (keys_of_window): Move bindings for delete-other-windows,
5770 split-window, delete-window and enlarge-window to window.el.
5771
5772 * buffer.c: Temporarily extern Qdelete_window.
5773 (Fbury_buffer): Temporarily call Qdelete_window instead of
5774 Fdelete_window (Fbury_buffer will move to window.el soon).
5775
5776 * frame.c (set_menu_bar_lines_1): Remove code handling
5777 orig_top_line and orig_total_lines.
5778
5779 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5780 set_window_height but set heights directly.
5781 (change_frame_size_1): Use resize_frame_windows.
5782
5783 * xdisp.c (init_xdisp): Don't use set_window_height but set
5784 heights directly.
5785
5786 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5787 Use resize_frame_windows instead of change_window_heights and run
5788 run_window_configuration_change_hook.
5789
5790 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5791 instead of change_window_heights and run
5792 run_window_configuration_change_hook.
5793
5794 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5795
5796 * window.c (replace_window): Rename second argument REPLACEMENT to
5797 NEW. New third argument SETFLAG. Rewrite.
5798 (delete_window, make_dummy_parent): Call replace_window with
5799 third argument 1.
5800 (window_list_1): Move down in code.
5801 (run_window_configuration_change_hook): Move set_buffer part
5802 before select_frame_norecord part in order to unwind correctly.
5803 Rename count1 to count.
5804 (recombine_windows, delete_deletable_window, resize_root_window)
5805 (Fdelete_other_windows_internal)
5806 (Frun_window_configuration_change_hook, make_parent_window)
5807 (resize_window_check, resize_window_apply, Fresize_window_apply)
5808 (resize_frame_windows, Fsplit_window_internal)
5809 (Fdelete_window_internal, Fresize_mini_window_internal):
5810 New functions.
5811 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5812
5813 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5814
5815 * window.h (window): Add some new members to window structure -
5816 normal_lines, normal_cols, new_total, new_normal, clone_number,
5817 splits, nest, prev_buffers, next_buffers.
5818 (WINDOW_TOTAL_SIZE): Move here from window.c.
5819 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5820
5821 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5822 Remove.
5823 (make_dummy_parent): Set new members of windows structure.
5824 (make_window): Move down in code. Handle new members of window
5825 structure.
5826 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5827 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5828 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5829 (Fset_window_prev_buffers, Fwindow_next_buffers)
5830 (Fset_window_next_buffers, Fset_window_clone_number):
5831 New functions.
5832 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5833 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5834 Doc-string fixes.
5835 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5836 Argument WINDOW can be now internal window too.
5837 (Fwindow_use_time): Move up in code.
5838 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5839 Rewrite doc-string.
5840 (Fset_window_configuration, saved_window)
5841 (Fcurrent_window_configuration, save_window_save): Handle new
5842 members of window structure.
5843 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5844 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5845 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5846 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5847 Qget_mru_window, Qresize_root_window,
5848 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5849 Qauto_buffer_name; staticpro them.
5850
5851 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5852
5853 * window.c (Fwindow_total_size, Fwindow_left_column)
5854 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5855 (Fwindow_list_1): New functions.
5856 (window_box_text_cols): Replace with window_body_cols.
5857 (Fwindow_width, Fscroll_left, Fscroll_right):
5858 Use window_body_cols instead of window_box_text_cols.
5859 (delete_window, Fset_window_configuration):
5860 Call delete_all_subwindows with window as argument.
5861 (delete_all_subwindows): Take a window as argument and not a
5862 structure. Rewrite.
5863 (window_loop): Remove handling of GET_LRU_WINDOW and
5864 GET_LARGEST_WINDOW.
5865 (Fget_lru_window, Fget_largest_window): Move to window.el.
5866
5867 * window.h: Extern window_body_cols instead of
5868 window_box_text_cols. delete_all_subwindows now takes a
5869 Lisp_Object as argument.
5870
5871 * indent.c (compute_motion, Fcompute_motion):
5872 Use window_body_cols instead of window_box_text_cols.
5873
5874 * frame.c (delete_frame): Call delete_all_subwindows with root
5875 window as argument.
5876
5877 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5878
5879 * fns.c (Fputhash): Document return value.
5880
5881 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5882
5883 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5884
5885 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5886
5887 Cons<->int and similar integer overflow fixes (Bug#8794).
5888
5889 Check for overflow when converting integer to cons and back.
5890 * charset.c (Fdefine_charset_internal, Fdecode_char):
5891 Use cons_to_unsigned to catch overflow.
5892 (Fencode_char): Use INTEGER_TO_CONS.
5893 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5894 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5895 * data.c (long_to_cons, cons_to_long): Remove.
5896 (cons_to_unsigned, cons_to_signed): New functions.
5897 These signal an error for invalid or out-of-range values.
5898 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5899 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5900 * font.c (Ffont_variation_glyphs):
5901 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5902 * lisp.h: Include <intprops.h>.
5903 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5904 (cons_to_signed, cons_to_unsigned): New decls.
5905 (long_to_cons, cons_to_long): Remove decls.
5906 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5907 (Fprimitive_undo): Use CONS_TO_INTEGER.
5908 * xfns.c (Fx_window_property): Likewise.
5909 * xselect.c: Include <limits.h>.
5910 (x_own_selection, selection_data_to_lisp_data):
5911 Use INTEGER_TO_CONS.
5912 (x_handle_selection_request, x_handle_selection_clear)
5913 (x_get_foreign_selection, Fx_disown_selection_internal)
5914 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5915 (lisp_data_to_selection_data): Use cons_to_unsigned.
5916 (x_fill_property_data): Use cons_to_signed.
5917 Report values out of range.
5918
5919 Check for buffer and string overflow more precisely.
5920 * buffer.h (BUF_BYTES_MAX): New macro.
5921 * lisp.h (STRING_BYTES_MAX): New macro.
5922 * alloc.c (Fmake_string):
5923 * character.c (string_escape_byte8):
5924 * coding.c (coding_alloc_by_realloc):
5925 * doprnt.c (doprnt):
5926 * editfns.c (Fformat):
5927 * eval.c (verror):
5928 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5929 since they may not be the same number.
5930 * editfns.c (Finsert_char):
5931 * fileio.c (Finsert_file_contents):
5932 Likewise for BUF_BYTES_MAX.
5933
5934 * image.c: Use ptrdiff_t, not int, for sizes.
5935 (slurp_file): Switch from int to ptrdiff_t.
5936 All uses changed.
5937 (slurp_file): Check that file size fits in both size_t (for
5938 malloc) and ptrdiff_t (for sanity and safety).
5939
5940 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5941 if b->modtime has its maximal value.
5942
5943 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5944
5945 Don't assume time_t can fit into int.
5946 * buffer.h (struct buffer.modtime): Now time_t, not int.
5947 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5948 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5949
5950 Minor fixes for signed vs unsigned integers.
5951 * character.h (MAYBE_UNIFY_CHAR):
5952 * charset.c (maybe_unify_char):
5953 * keyboard.c (read_char, reorder_modifiers):
5954 XINT -> XFASTINT, since the integer must be nonnegative.
5955 * ftfont.c (ftfont_spec_pattern):
5956 * keymap.c (access_keymap, silly_event_symbol_error):
5957 XUINT -> XFASTINT, since the integer must be nonnegative.
5958 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5959 since it makes no difference and we prefer signed.
5960 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5961 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5962 nonnegative.
5963
5964 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5965
5966 * window.h (Fwindow_frame): Declare.
5967
5968 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5969
5970 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5971 (SPARE_MEMORY): Always define.
5972 (LARGE_REQUEST): Remove.
5973 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5974
5975 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5976
5977 * lisp.h: Move EXFUNS for Fframe_root_window,
5978 Fframe_first_window and Fset_frame_selected_window to window.h.
5979
5980 * window.h: Move EXFUNS for Fframe_root_window,
5981 Fframe_first_window and Fset_frame_selected_window here from
5982 lisp.h.
5983
5984 * frame.c (Fwindow_frame, Fframe_first_window)
5985 (Fframe_root_window, Fframe_selected_window)
5986 (Fset_frame_selected_window): Move to window.c.
5987 (Factive_minibuffer_window): Move to minibuf.c.
5988 (Fother_visible_frames_p): New function.
5989
5990 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5991
5992 * window.c (decode_window, decode_any_window): Move up in code.
5993 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5994 (inhibit_frame_unsplittable): Remove unused variable.
5995 (Fwindow_buffer): Move up and rewrite doc-string.
5996 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5997 (Fwindow_prev): New functions.
5998 (Fwindow_frame): Move here from frame.c. Accept any window as
5999 argument.
6000 (Fframe_root_window, Fframe_first_window)
6001 (Fframe_selected_window): Move here from frame.c. Accept frame
6002 or arbitrary window as argument. Update doc-strings.
6003 (Fminibuffer_window): Move up in code.
6004 (Fwindow_minibuffer_p): Move up in code and simplify.
6005 (Fset_frame_selected_window): Move here from frame.c.
6006 Marginal rewrite.
6007 (Fselected_window, select_window, Fselect_window): Move up in
6008 code. Minor doc-string fixes.
6009
6010 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6011
6012 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6013 Do not assume that spare memory exists; that assumption is valid
6014 only if SYSTEM_MALLOC.
6015 (LARGE_REQUEST): New macro, so that the issue of large requests
6016 is separated from the issue of spare memory.
6017
6018 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6019
6020 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6021 format. (Bug#8806)
6022
6023 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6024
6025 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6026 before statements.
6027
6028 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6029
6030 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6031
6032 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6033
6034 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6035 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6036
6037 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6038
6039 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6040
6041 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6042
6043 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6044 (x_clipboard_manager_save): Add return value.
6045 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6046 New error handlers.
6047 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6048 Obey Vx_select_enable_clipboard_manager. Catch errors in
6049 x_clipboard_manager_save (Bug#8779).
6050 (Vx_select_enable_clipboard_manager): New variable.
6051 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6052
6053 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6054
6055 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6056
6057 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6058
6059 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6060 in the current matrix if keep_current_p is non-zero.
6061
6062 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6063
6064 * bidi.c (bidi_level_of_next_char): Fix last change.
6065
6066 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6067
6068 Support bidi reordering of text covered by display properties.
6069
6070 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6071 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6072 (bidi_cache_search, bidi_cache_iterator_state)
6073 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6074 (bidi_level_of_next_char, bidi_move_to_visually_next):
6075 Support character positions inside a run of characters covered by a
6076 display string.
6077 (bidi_paragraph_init, bidi_resolve_explicit_1)
6078 (bidi_level_of_next_char): Call bidi_fetch_char and
6079 bidi_fetch_char_advance instead of FETCH_CHAR and
6080 FETCH_CHAR_ADVANCE.
6081 (bidi_init_it): Initialize new members.
6082 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6083 definitions.
6084 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6085 instead of using explicit *_CHAR codes.
6086 (bidi_resolve_explicit, bidi_resolve_weak):
6087 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6088 bidirectional text is supported only in multibyte buffers.
6089 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6090 it to initialize the frame_window_p member of struct bidi_it.
6091 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6092 (bidi_resolve_explicit, bidi_resolve_weak)
6093 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6094 bidi_it->nchars is non-positive.
6095 (bidi_level_of_next_char): Don't try to lookup the cache for the
6096 next/previous character if nothing is cached there yet, or if we
6097 were just reseat()'ed to a new position.
6098
6099 * xdisp.c (set_cursor_from_row): Set start and stop points
6100 according to the row's direction when priming the loop that looks
6101 for the glyph on which to display cursor.
6102 (single_display_spec_intangible_p): Function deleted.
6103 (display_prop_intangible_p): Reimplement to call
6104 handle_display_spec instead of single_display_spec_intangible_p.
6105 Accept 3 additional arguments needed by handle_display_spec.
6106 This fixes incorrect cursor motion across display property with complex
6107 values: lists, `(when COND...)' forms, etc.
6108 (single_display_spec_string_p): Support property values that are
6109 lists with the argument STRING its top-level element.
6110 (display_prop_string_p): Fix the condition for processing a
6111 property that is a list to be consistent with handle_display_spec.
6112 (handle_display_spec): New function, refactored from the
6113 last portion of handle_display_prop.
6114 (compute_display_string_pos): Accept additional argument
6115 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6116 value of a `display' property is a "replacing spec".
6117 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6118 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6119 the display property, but just return a value indicating whether
6120 the display property will replace the characters it covers.
6121 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6122 frame_window_p members of struct bidi_it.
6123 (compute_display_string_pos, compute_display_string_end):
6124 New functions.
6125 (push_it): Accept second argument POSITION, where pop_it should
6126 jump to continue iteration.
6127 (reseat_1): Initialize bidi_it.disp_pos.
6128
6129 * keyboard.c (adjust_point_for_property): Adjust the call to
6130 display_prop_intangible_p to its new signature.
6131
6132 * dispextern.h (struct bidi_it): New member frame_window_p.
6133 (bidi_init_it): Update prototypes.
6134 (display_prop_intangible_p): Update prototype.
6135 (compute_display_string_pos, compute_display_string_end):
6136 Declare prototypes.
6137 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6138 EMACS_INT.
6139
6140 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6141
6142 Malloc failure behavior now depends on size of allocation.
6143 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6144 * lisp.h: Change signatures accordingly.
6145 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6146 All callers changed. (Bug#8762)
6147
6148 * gnutls.c: Use Emacs's memory allocators.
6149 Without this change, the gnutls library would invoke malloc etc.
6150 directly, which causes problems on non-SYNC_INPUT hosts, and which
6151 runs afoul of improving memory_full behavior. (Bug#8761)
6152 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6153 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6154 xfree instead of the default malloc, realloc, free.
6155 (Fgnutls_boot): No need to check for memory allocation failure,
6156 since xmalloc does that for us.
6157
6158 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6159 * category.c (hash_get_category_set):
6160 * ccl.c (ccl_driver):
6161 * charset.c (Fdefine_charset_internal):
6162 * charset.h (struct charset.hash_index):
6163 * composite.c (get_composition_id, gstring_lookup_cache)
6164 (composition_gstring_put_cache):
6165 * composite.h (struct composition.hash_index):
6166 * dispextern.h (struct image.hash):
6167 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6168 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6169 (hashfn_equal, hashfn_user_defined, make_hash_table)
6170 (maybe_resize_hash_table, hash_lookup, hash_put)
6171 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6172 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6173 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6174 * image.c (make_image, search_image_cache, lookup_image)
6175 (xpm_put_color_table_h):
6176 * lisp.h (struct Lisp_Hash_Table):
6177 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6178 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6179 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6180 * alloc.c (allocate_vectorlike):
6181 Check for overflow in vector size calculations.
6182 * ccl.c (ccl_driver):
6183 Check for overflow when converting EMACS_INT to int.
6184 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6185 need to be updated by these changes.
6186 * fns.c (make_hash_table, maybe_resize_hash_table):
6187 Check for integer overflow with large hash tables.
6188 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6189 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6190 (SXHASH_REDUCE): New macro.
6191 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6192 Use it instead of discarding useful hash info with large hash values.
6193 (sxhash_float): New function.
6194 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6195 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6196 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6197 Rewrite to use FIXNUM_BITS, as this simplifies things.
6198 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6199 Adjust signatures to match updated version of code.
6200 (consing_since_gc): Now EMACS_INT, since a single hash table can
6201 use more than INT_MAX bytes.
6202
6203 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6204
6205 Make it possible to build with GCC-4.6+ -O2 -flto.
6206
6207 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6208
6209 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6210
6211 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6212 Call minibuffer-inactive-mode.
6213
6214 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6215
6216 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6217 Update dependencies.
6218
6219 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6220
6221 * data.c (init_data): Remove code for UTS, this system is not
6222 supported anymore.
6223
6224 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6225
6226 Don't force ./temacs to start in terminal mode.
6227
6228 * frame.c (make_initial_frame): Initialize faces in all cases, not
6229 only when CANNOT_DUMP is defined.
6230 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6231
6232 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6233
6234 * dispnew.c (add_window_display_history): Use const for the string
6235 pointer. Remove declaration, not needed.
6236
6237 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6238
6239 Use 'inline', not 'INLINE'.
6240 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6241 * alloc.c, fontset.c (INLINE): Remove.
6242 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6243 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6244 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6245 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6246 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6247
6248 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6249
6250 Make it possible to run ./temacs.
6251
6252 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6253 syms_of_callproc does the same thing. Remove test for
6254 "initialized", do it in the caller.
6255 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6256
6257 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6258
6259 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6260 (read_minibuf): Use get_minibuffer.
6261 (syms_of_minibuf): Use DEFSYM.
6262 (Qmetadata): New var.
6263 * data.c (Qbuffer): Don't make it static.
6264 (syms_of_data): Use DEFSYM.
6265
6266 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6267
6268 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6269 (CCL_CODE_MIN): New macro.
6270
6271 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6272
6273 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6274
6275 * eval.c (Qdebug): Now static.
6276 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6277 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6278 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6279
6280 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6281
6282 * image.c: Various fixes to ImageMagick code comments.
6283 (Fimagemagick_types): Doc fix.
6284
6285 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6286
6287 Minor fixes prompted by GCC 4.6.0 warnings.
6288
6289 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6290
6291 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6292 (x_clipboard_manager_save_all): Move extern decl to ...
6293 * xterm.h: ... here, so that it can be checked for consistency.
6294
6295 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6296
6297 * xselect.c (x_clipboard_manager_save_frame)
6298 (x_clipboard_manager_save_all): New functions.
6299 (Fx_clipboard_manager_save): Lisp function deleted.
6300
6301 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6302 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6303
6304 * xterm.h: Update prototype.
6305
6306 2011-05-28 William Xu <william.xwl@gmail.com>
6307
6308 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6309 exiting (Bug#8239).
6310
6311 2011-05-28 Jim Meyering <meyering@redhat.com>
6312
6313 Avoid a sign-extension bug in crypto_hash_function.
6314 * fns.c (to_uchar): Define.
6315 (crypto_hash_function): Use it to convert some newly-signed
6316 variables to unsigned, to avoid sign-extension bugs. For example,
6317 without this change, (md5 "truc") would evaluate to
6318 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6319 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6320 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6321
6322 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6323
6324 Integer overflow fixes.
6325
6326 * dbusbind.c: Serial number integer overflow fixes.
6327 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6328 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6329 to hold a serial number that is too large for a fixnum.
6330 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6331 Check for serial numbers out of range. Decode any serial number
6332 that was so large that it became a float. (Bug#8722)
6333
6334 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6335 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6336 Use XFASTINT rather than XUINT when numbers are nonnegative.
6337 (xd_append_arg, Fdbus_method_return_internal):
6338 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6339 arguments, check that Lisp number is nonnegative, rather than
6340 silently wrapping negative numbers around. (Bug#8722)
6341 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6342 (Bug#8722)
6343
6344 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6345
6346 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6347
6348 ccl: Add integer overflow checks.
6349 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6350 (IN_INT_RANGE): New macros.
6351 (ccl_driver): Use them to check for integer overflow when
6352 decoding a CCL program. Many of the new checks are whether XINT (x)
6353 fits in int; it doesn't always, on 64-bit hosts. The new version
6354 doesn't catch all possible integer overflows, but it's an
6355 improvement. (Bug#8719)
6356
6357 * alloc.c (make_event_array): Use XINT, not XUINT.
6358 There's no need for unsigned here.
6359
6360 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6361 This follows up to the 2011-05-06 change that substituted uintptr_t
6362 for EMACS_INT. This case wasn't caught back then.
6363
6364 Rework Fformat to avoid integer overflow issues.
6365 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6366 now (part of C89). Include <verify.h>.
6367 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6368 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6369 (Fformat): Avoid the prepass trying to compute sizes; it was only
6370 approximate and thus did not catch overflow reliably. Instead, walk
6371 through the format just once, formatting and computing sizes as we go,
6372 checking for integer overflow at every step, and allocating a larger
6373 buffer as needed. Keep track separately whether the format is
6374 multibyte. Keep only the most-recently calculated precision, rather
6375 than them all. Record whether each argument has been converted to
6376 string. Use EMACS_INT, not int, for byte and char and arg counts.
6377 Support field widths and precisions larger than INT_MAX. Avoid
6378 sprintf's undefined behavior with conversion specifications such as %#d
6379 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6380 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6381 formatting out-of-range floating point numbers with int
6382 formats. (Bug#8668)
6383
6384 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6385
6386 * data.c: Avoid integer truncation in expressions involving floats.
6387 * data.c: Include <intprops.h>.
6388 (arith_driver): When there's an integer overflow in an expression
6389 involving floating point, convert the integers to floating point
6390 so that the resulting value does not suffer from catastrophic
6391 integer truncation. For example, on a 64-bit host (* 4
6392 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6393 Do not rely on undefined behavior after integer overflow.
6394
6395 merge count_size_as_multibyte, parse_str_to_multibyte
6396 * character.c, character.h (count_size_as_multibyte):
6397 Rename from parse_str_to_multibyte; all uses changed.
6398 Check for integer overflow.
6399 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6400 since it's now a duplicate of the other. This is more of
6401 a character than a buffer op, so better that it's in character.c.
6402 * fns.c, print.c: Adjust to above changes.
6403
6404 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6405
6406 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6407
6408 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6409
6410 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6411 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6412 (x_clipboard_manager_save): Now static.
6413 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6414
6415 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6416 (crypto_hash_function): Now static.
6417 Fix pointer signedness problems. Avoid unnecessary initializations.
6418
6419 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6420
6421 * termhooks.h (Vselection_alist): Make it terminal-local.
6422
6423 * terminal.c (create_terminal): Initialize it.
6424
6425 * xselect.c: Support for clipboard managers.
6426 (Vselection_alist): Move to termhooks.h as terminal-local var.
6427 (LOCAL_SELECTION): New macro.
6428 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6429 (symbol_to_x_atom): Remove gratuitous arg.
6430 (x_handle_selection_request, lisp_data_to_selection_data)
6431 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6432 (x_own_selection, x_get_local_selection, x_convert_selection):
6433 New arg, specifying work frame. Use terminal-local Vselection_alist.
6434 (some_frame_on_display): Delete unused function.
6435 (Fx_own_selection_internal, Fx_get_selection_internal)
6436 (Fx_disown_selection_internal, Fx_selection_owner_p)
6437 (Fx_selection_exists_p): New optional frame arg.
6438 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6439 (x_handle_selection_clear): Don't treat other terminals with the
6440 same keyboard specially. Use the terminal-local Vselection_alist.
6441 (x_clear_frame_selections): Use Frun_hook_with_args.
6442
6443 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6444
6445 * xterm.h: Add support for those atoms.
6446
6447 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6448
6449 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6450 (converted_selections, conversion_fail_tag): New global variables.
6451 (x_selection_request_lisp_error): Free the above.
6452 (x_get_local_selection): Remove unnecessary code.
6453 (x_reply_selection_request): Args changed; handle arbitrary array
6454 of converted selections stored in converted_selections.
6455 Separate the XChangeProperty and SelectionNotify steps.
6456 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6457 (x_convert_selection): New function.
6458 (x_handle_selection_event): Simplify.
6459 (x_get_foreign_selection): Don't ignore incoming requests while
6460 waiting for an answer; this will fail when we implement
6461 SAVE_TARGETS, and seems unnecessary anyway.
6462 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6463 (Vx_sent_selection_functions): Doc fix.
6464
6465 2011-05-26 Leo Liu <sdl.web@gmail.com>
6466
6467 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6468
6469 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6470
6471 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6472
6473 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6474 for fringe update if it has periodic bitmap.
6475 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6476 and fringe_bitmap_periodic_p.
6477
6478 * fringe.c (get_fringe_bitmap_data): New function.
6479 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6480 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6481 row. Mark glyph row for fringe update if periodicity changed.
6482
6483 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6484 for fringe update unless it has periodic bitmap.
6485
6486 2011-05-25 Kenichi Handa <handa@m17n.org>
6487
6488 * xdisp.c (get_next_display_element): Set correct it->face_id for
6489 a static composition.
6490
6491 2011-05-24 Leo Liu <sdl.web@gmail.com>
6492
6493 * deps.mk (fns.o):
6494 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6495
6496 * fns.c (crypto_hash_function, Fsha1): New function.
6497 (Fmd5): Use crypto_hash_function.
6498 (syms_of_fns): Add Ssha1.
6499
6500 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6501
6502 * gnutls.c: Remove unused macros.
6503 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6504 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6505 Remove macros that are defined and never used.
6506 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6507
6508 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6509
6510 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6511 (Fx_get_selection_internal): Minor cleanup.
6512 (Fx_own_selection_internal): Rename arguments for consistency with
6513 select.el.
6514
6515 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6516
6517 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6518
6519 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6520
6521 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6522
6523 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6524
6525 * dispnew.c (scrolling_window): Don't exclude the case that the
6526 last enabled row in the desired matrix touches the bottom boundary.
6527
6528 2011-05-21 Glenn Morris <rgm@gnu.org>
6529
6530 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6531 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6532 and add some more files.
6533
6534 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6535
6536 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6537 report_file_error introduced by the change from 2011-05-07.
6538
6539 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6540
6541 * systime.h (Time): Define only if emacs is defined.
6542 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6543 where the include path doesn't have X11/X.h by default. See
6544 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6545
6546 2011-05-20 Kenichi Handa <handa@m17n.org>
6547
6548 * composite.c (find_automatic_composition): Fix previous change.
6549
6550 2011-05-20 Glenn Morris <rgm@gnu.org>
6551
6552 * lisp.mk: New file, split from Makefile.in.
6553 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6554 (shortlisp): Remove.
6555 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6556
6557 2011-05-19 Glenn Morris <rgm@gnu.org>
6558
6559 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6560 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6561 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6562 (lisp): Set the order to that of loadup.el.
6563 (shortlisp): Make it a copy of $lisp.
6564 (SOME_MACHINE_LISP): Remove.
6565 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6566 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6567
6568 2011-05-18 Kenichi Handa <handa@m17n.org>
6569
6570 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6571 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6572 (find_automatic_composition): Mostly rewrite for efficiency.
6573
6574 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6575
6576 * makefile.w32-in: Update dependencies.
6577
6578 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6579
6580 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6581 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6582
6583 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6584
6585 Fix some integer overflow issues, such as string length overflow.
6586
6587 * insdel.c (count_size_as_multibyte): Check for string overflow.
6588
6589 * character.c (lisp_string_width): Check for string overflow.
6590 Use EMACS_INT, not int, for string indexes and lengths; in
6591 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6592 the resulting string length overflows an EMACS_INT; instead,
6593 report a string overflow if no precision given. When checking for
6594 precision exhaustion, use a check that cannot possibly have
6595 integer overflow. (Bug#8675)
6596 * character.h (lisp_string_width): Adjust to new signature.
6597
6598 * alloc.c (string_overflow): New function.
6599 (Fmake_string): Use it. This doesn't change behavior, but saves
6600 a few bytes and will simplify future changes.
6601 * character.c (string_escape_byte8): Likewise.
6602 * lisp.h (string_overflow): New decl.
6603
6604 Fixups, following up to the user-interface timestamp change.
6605 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6606 for UI timestamps, instead of unsigned long.
6607 * msdos.c (mouse_get_pos): Likewise.
6608 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6609 * w32gui.h (Time): Define by including "systime.h" rather than by
6610 declaring it ourselves. (Bug#8664)
6611
6612 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6613 * image.c (clear_image_cache): Likewise.
6614
6615 * term.c (term_mouse_position): Don't assume time_t wraparound.
6616
6617 Be more systematic about user-interface timestamps.
6618 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6619 and sometimes 'EMACS_UINT', to represent these timestamps.
6620 This change causes it to use 'Time' uniformly, as that's what X uses.
6621 This makes the code easier to follow, and makes it easier to catch
6622 integer overflow bugs such as Bug#8664.
6623 * frame.c (Fmouse_position, Fmouse_pixel_position):
6624 Use Time, not unsigned long, for user-interface timestamps.
6625 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6626 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6627 * keyboard.h (last_event_timestamp): Likewise.
6628 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6629 * menu.h (xmenu_show): Likewise.
6630 * term.c (term_mouse_position): Likewise.
6631 * termhooks.h (struct input_event.timestamp): Likewise.
6632 (struct terminal.mouse_position_hook): Likewise.
6633 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6634 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6635 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6636 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6637 what it was before.
6638 * menu.h, termhooks.h: Include "systime.h", for Time.
6639
6640 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6641 Don't assume that the difference between two unsigned long values
6642 can fit into an integer. At this point, we know button_down_time
6643 <= event->timestamp, so the difference must be nonnegative, so
6644 there's no need to cast the result if double-click-time is
6645 nonnegative, as it should be; check that it's nonnegative, just in
6646 case. This bug is triggered when events are more than 2**31 ms
6647 apart (about 25 days). (Bug#8664)
6648
6649 * xselect.c (last_event_timestamp): Remove duplicate decl.
6650 (x_own_selection): Remove needless cast to unsigned long.
6651
6652 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6653 that always fit in int. Use a sentinel instead of a counter, to
6654 avoid a temp and to allay GCC's concerns about possible int overflow.
6655 * frame.h (struct frame): Use int for menu_bar_items_used
6656 instead of EMACS_INT, since it always fits in int.
6657
6658 * menu.c (grow_menu_items): Check for int overflow.
6659
6660 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6661
6662 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6663 Before, the code was not consistent. These values cannot exceed
6664 2**31 - 1 so there's no need to make them unsigned.
6665 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6666 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6667 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6668 as modifiers.
6669 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6670
6671 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6672 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6673 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6674 presumably because the widths might not match.
6675
6676 * window.c (size_window): Avoid needless test at loop start.
6677
6678 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6679
6680 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6681
6682 2011-05-12 Drew Adams <drew.adams@oracle.com>
6683
6684 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6685
6686 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6687
6688 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6689 `width' to `bar_area_x' and `bar_area_width', respectively.
6690 (x_scroll_run): Take account of fringe background extension.
6691
6692 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6693 Rename local vars `left' and `width' to `bar_area_x' and
6694 `bar_area_width', respectively.
6695 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6696 background extension.
6697
6698 2011-05-10 Jim Meyering <meyering@redhat.com>
6699
6700 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6701
6702 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6703
6704 * image.c (Finit_image_library): Return t for built-in image types,
6705 like pbm and xbm. (Bug#8640)
6706
6707 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6708
6709 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6710
6711 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6712
6713 * w32console.c (Fset_screen_color): Doc fix.
6714 (Fget_screen_color): New function.
6715 (syms_of_ntterm): Defsubr it.
6716
6717 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6718 unlink the temporary file if Fcall_process didn't create it in the
6719 first place.
6720 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6721 child process will be redirected to a file specified with `:file'.
6722 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6723 cue to call_process_cleanup not to close that handle.
6724
6725 2011-05-07 Ben Key <bkey76@gmail.com>
6726
6727 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6728 one of two shell specific rules, either bootstrap-temacs-CMD or
6729 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6730 to the previous implementation of the bootstrap-temacs rule.
6731 The bootstrap-temacs-CMD rule is similar to the previous
6732 implementation of the bootstrap-temacs rule except that it
6733 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6734 variable.
6735
6736 These changes, along with some changes to nt/configure.bat,
6737 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6738 earlier fix to add support for --cflags and --ldflags options
6739 that include quotes so that it works whether make uses cmd or
6740 sh as the shell.
6741
6742 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6743
6744 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6745 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6746 is a constant.
6747 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6748 a string. Handle both cases.
6749 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6750 (Fdbus_register_method): Use Qinvalid_function.
6751
6752 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6753
6754 * makefile.w32-in: Update dependencies.
6755 (LISP_H): Add inttypes.h and stdin.h.
6756 (PROCESS_H): Add unistd.h.
6757
6758 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6759
6760 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6761 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6762
6763 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6764
6765 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6766
6767 * term.c (vfatal): Remove stray call to va_end.
6768 It's not needed and the C Standard doesn't allow it here anyway.
6769
6770 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6771 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6772
6773 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6774 bytes.
6775
6776 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6777
6778 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6779
6780 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6781
6782 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6783
6784 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6785
6786 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6787 * charset.c (Fdefine_charset_internal): Don't initialize
6788 charset.code_space[15]. The value was garbage, on hosts with
6789 32-bit int (Bug#8600).
6790
6791 * lread.c (read_integer): Be more consistent with string-to-number.
6792 Use string_to_number to do the actual conversion; this avoids
6793 rounding errors and fixes some other screwups. Without this fix,
6794 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6795 (digit_to_number): Move earlier, for benefit of read_integer.
6796 Return -1 if the digit is out of range for the base, -2 if it is
6797 not a digit in any supported base. (Bug#8602)
6798
6799 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6800
6801 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6802 to match comment at start of function. This also removes a
6803 GCC warning about overflow in a 32+64-bit port.
6804
6805 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6806
6807 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6808 Reported by Stefan Monnier in
6809 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6810 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6811 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6812
6813 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6814 (EMACS_UINTPTR): Likewise, with uintptr_t.
6815
6816 * lisp.h: Prefer 64-bit EMACS_INT if available.
6817 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6818 on 32-bit hosts that have 64-bit int, so that they can access
6819 large files.
6820 However, temporarily disable this change unless the temporary
6821 symbol WIDE_EMACS_INT is defined.
6822
6823 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6824
6825 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6826 This removes an assumption that EMACS_INT and long are the same
6827 width as pointers. The assumption is true for Emacs porting targets
6828 now, but we want to make other targets possible.
6829 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6830 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6831 In the rest of the code, change types of integers that hold casted
6832 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6833 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6834 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6835 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6836 No need to cast type when ORing.
6837 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6838 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6839 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6840 assume EMACS_INT is the same width as char *.
6841 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6842 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6843 Remove no-longer-needed casts.
6844 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6845 (xg_tool_bar_help_callback, xg_make_tool_item):
6846 Use EMACS_INTPTR to hold an integer
6847 that will be cast to void *; this can avoid a GCC warning
6848 if EMACS_INT is not the same width as void *.
6849 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6850 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6851 (current_message_1, set_message_1):
6852 Use a local to convert to proper width without a cast.
6853 * xmenu.c (dialog_selection_callback): Likewise.
6854
6855 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6856 Also, don't assume VALBITS / RAND_BITS is less than 5,
6857 and don't rely on undefined behavior when shifting a 1 left into
6858 the sign bit.
6859 * lisp.h (get_random): Change signature to match.
6860
6861 * lread.c (hash_string): Use size_t, not int, for hash computation.
6862 Normally we prefer signed values; but hashing is special, because
6863 it's better to use unsigned division on hash table sizes so that
6864 the remainder is nonnegative. Also, size_t is the natural width
6865 for hashing into memory. The previous code used 'int', which doesn't
6866 retain enough info to hash well into very large tables.
6867 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6868
6869 * dbusbind.c: Don't possibly lose pointer info when converting.
6870 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6871 Use XPNTR rather than XHASH, so that the high-order bits of
6872 the pointer aren't lost when converting through void *.
6873
6874 * eval.c (Fautoload): Don't double-shift a pointer.
6875
6876 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6877
6878 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6879
6880 * gnutls.c (DEF_GNUTLS_FN):
6881 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6882
6883 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6884
6885 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6886 marker. (Bug#8610)
6887
6888 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6889
6890 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6891 New version that can reserve upto 2GB of heap space.
6892
6893 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6894
6895 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6896
6897 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6898
6899 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6900 `gnutls_certificate_set_x509_key_file'.
6901
6902 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6903
6904 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6905 Update dependencies.
6906
6907 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6908
6909 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6910 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6911 Remove unused parameter `fildes'.
6912 * process.c (read_process_output, send_process): Don't pass it.
6913
6914 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6915
6916 Fix previous change: the library cache is defined in w32.c.
6917 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6918 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6919
6920 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6921
6922 Implement dynamic loading of GnuTLS on Windows.
6923
6924 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6925 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6926 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6927 Declare.
6928
6929 * gnutls.c (Qgnutls_dll): Define.
6930 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6931 (gnutls_*): Declare function pointers.
6932 (init_gnutls_functions): New function to initialize function pointers.
6933 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6934 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6935 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6936 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6937 (emacs_gnutls_write, emacs_gnutls_read)
6938 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6939 (Fgnutls_available_p): New function.
6940 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6941 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6942 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6943
6944 * image.c: Include w32.h.
6945 (Vimage_type_cache): Delete.
6946 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6947 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6948 (w32_delayed_load): Move to w32.c.
6949
6950 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6951
6952 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6953 (w32_delayed_load): Move from image.c. When loading a library, record
6954 its filename in the :loaded-from property of the library id.
6955 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6956 Initialize and staticpro them.
6957 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6958
6959 * process.c: Include lisp.h before w32.h, not after.
6960 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6961 instead of gnutls_record_check_pending.
6962
6963 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6964
6965 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6966
6967 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6968 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6969 as passed in.
6970
6971 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6972
6973 * xterm.c (x_set_frame_alpha): Do not set property on anything
6974 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6975
6976 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6977
6978 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6979
6980 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6981
6982 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6983 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6984 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6985 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6986 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6987 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6988 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6989 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6990 (Qgnutls_bootprop_callbacks_verify): Make static.
6991
6992 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6993
6994 * callproc.c: Indentation fixup.
6995
6996 * sysdep.c (wait_for_termination_1): Make static.
6997 (wait_for_termination, interruptible_wait_for_termination):
6998 Move after wait_for_termination_1.
6999
7000 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7001
7002 * sysdep.c (interruptible_wait_for_termination): New function
7003 which is like wait_for_termination, but allows keyboard
7004 interruptions.
7005
7006 * callproc.c (Fcall_process): Add (:file "file") as an option for
7007 the STDOUT buffer.
7008 (Fcall_process_region): Ditto.
7009
7010 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7011
7012 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7013 rather than `XVECTOR (FOO)->size'.
7014
7015 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7016 inttypes.h, as a gnulib replacement is used if it not available in
7017 system headers.
7018
7019 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7020
7021 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7022 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7023 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7024
7025 * coding.c (coding_alloc_by_realloc): Error out if destination
7026 will grow beyond MOST_POSITIVE_FIXNUM.
7027 (decode_coding_emacs_mule): Abort if there isn't enough place in
7028 charbuf for the composition carryover bytes. Reserve an extra
7029 space for up to 2 characters produced in a loop.
7030 (decode_coding_iso_2022): Abort if there isn't enough place in
7031 charbuf for the composition carryover bytes.
7032
7033 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7034
7035 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7036 aborting when %lld or %lll format is passed.
7037 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7038 %llo or %llx format is passed. (Bug#8545)
7039
7040 * window.c (window_scroll_line_based): Use a marker instead of
7041 simple variables to record original value of point. (Bug#7952)
7042
7043 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7044 produced by %s or %c overflows available buffer space. (Bug#8545)
7045
7046 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7047
7048 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7049 (SIZE_MAX): Move defn after all includes, as they might #define it.
7050
7051 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7052
7053 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7054
7055 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7056
7057 * keyboard.c (Qdelayed_warnings_hook): Define.
7058 (command_loop_1): Run `delayed-warnings-hook'
7059 if Vdelayed_warnings_list is non-nil.
7060 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7061 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7062
7063 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7064
7065 * doprnt.c (doprnt): Don't return value smaller than the buffer
7066 size if the message was truncated. (Bug#8545).
7067
7068 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7069
7070 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7071 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7072
7073 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7074
7075 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7076
7077 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7078
7079 * makefile.w32-in: Update dependencies.
7080
7081 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7082
7083 Improve `doprnt' and its usage. (Bug#8545)
7084 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7085 `format_end'. Remove support for %l as a conversion specifier.
7086 Don't use xrealloc. Improve diagnostics when the %l size modifier
7087 is used. Update the commentary.
7088
7089 * eval.c (verror): Simplify calculation of size_t.
7090
7091 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7092 messages.
7093
7094 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7095
7096 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7097 change.
7098
7099 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7100
7101 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7102 This makes this file independent of the recent pseudovector change.
7103
7104 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7105
7106 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7107
7108 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7109 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7110 Remove unused local.
7111 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7112
7113 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7114 GCC 4.6.0 optimizes based on type-based alias analysis.
7115 For example, if b is of type struct buffer * and v of type struct
7116 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7117 != &v->size, and therefore "v->size = 1; b->size = 2; return
7118 v->size;" must therefore return 1. This assumption is incorrect
7119 for Emacs, since it type-puns struct Lisp_Vector * with many other
7120 types. To fix this problem, this patch adds a new type struct
7121 vectorlike_header that documents the constraints on layout of vectors
7122 and pseudovectors, and helps optimizing compilers not get fooled
7123 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7124 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7125 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7126 the size member.
7127 (XSETPVECTYPE): Rewrite in terms of new macro.
7128 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7129 This is a bit clearer, and further avoids the possibility of
7130 undesirable aliasing.
7131 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7132 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7133 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7134 since Lisp_Subr is a special case (no "next" field).
7135 (ASIZE): Now uses header.size rather than size.
7136 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7137 to avoid the hassle of writing XVECTOR (foo)->header.size.
7138 (struct vectorlike_header): New type.
7139 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7140 object, to help avoid aliasing.
7141 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7142 (SUBRP): Likewise, since Lisp_Subr is a special case.
7143 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7144 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7145 (struct Lisp_Hash_Table): Combine first two members into a single
7146 struct vectorlike_header member. All uses of "size" and "next" members
7147 changed to be "header.size" and "header.next".
7148 * buffer.h (struct buffer): Likewise.
7149 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7150 * frame.h (struct frame): Likewise.
7151 * process.h (struct Lisp_Process): Likewise.
7152 * termhooks.h (struct terminal): Likewise.
7153 * window.c (struct save_window_data, struct saved_window): Likewise.
7154 * window.h (struct window): Likewise.
7155 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7156 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7157 * buffer.c (init_buffer_once): Likewise.
7158 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7159 special case.
7160 * process.c (Fformat_network_address): Use local var for size,
7161 for brevity.
7162
7163 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7164
7165 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7166 * data.c (atof): Remove decl; no longer used or needed.
7167 (digit_to_number): Move to lread.c.
7168 (Fstring_to_number): Use new string_to_number function, to be
7169 consistent with how the Lisp reader treats infinities and NaNs.
7170 Do not assume that floating-point numbers represent EMACS_INT
7171 without losing information; this is not true on most 64-bit hosts.
7172 Avoid double-rounding errors, by insisting on integers when
7173 parsing non-base-10 numbers, as the documentation specifies.
7174 * lisp.h (string_to_number): New decl, replacing ...
7175 (isfloat_string): Remove.
7176 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7177 (read1): Do not accept +. and -. as integers; this
7178 appears to have been a coding error. Similarly, do not accept
7179 strings like +-1e0 as floating point numbers. Do not report
7180 overflow for integer overflows unless the base is not 10 which
7181 means we have no simple and reliable way to continue.
7182 Break out the floating-point parsing into a new
7183 function string_to_number, so that Fstring_to_number parses
7184 floating point numbers consistently with the Lisp reader.
7185 (digit_to_number): Move here from data.c. Make it static inline.
7186 (E_CHAR, EXP_INT): Remove, replacing with ...
7187 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7188 (string_to_number): New function, replacing isfloat_string.
7189 This function checks for valid syntax and produces the resulting
7190 Lisp float number too. Rework it so that string-to-number
7191 no longer mishandles examples like "1.0e+". Use strtoumax,
7192 so that overflow for non-base-10 numbers is reported only when
7193 there's no portable and simple way to convert to floating point.
7194
7195 * textprop.c (set_text_properties_1): Rewrite for clarity,
7196 and to avoid GCC warning about integer overflow.
7197
7198 * intervals.h (struct interval): Use EMACS_INT for members
7199 where EMACS_UINT might cause problems. See
7200 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7201 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7202 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7203 All uses changed.
7204 (offset_intervals): Tell GCC not to worry about length overflow
7205 when negating a negative length.
7206
7207 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7208 (overrun_check_free): Likewise.
7209
7210 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7211 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7212 word size.
7213
7214 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7215 (gnutls_make_error): Rename local to avoid shadowing.
7216 (gnutls_emacs_global_deinit): ifdef out; not used.
7217 (Fgnutls_boot): Use const for pointer to readonly storage.
7218 Comment out unused local. Fix pointer signedness problems.
7219
7220 * lread.c (openp): Don't stuff size_t into an 'int'.
7221 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7222 about possible signed overflow.
7223
7224 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7225 (GDK_KEY_g): Don't define if already defined.
7226 (xg_prepare_tooltip): Avoid pointer signedness problem.
7227 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7228
7229 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7230 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7231
7232 * xfns.c (Fx_window_property): Simplify a bit,
7233 to make a bit faster and to avoid GCC 4.6.0 warning.
7234 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7235
7236 * fns.c (internal_equal): Don't assume size_t fits in int.
7237
7238 * alloc.c (compact_small_strings): Tighten assertion a little.
7239
7240 Replace pEd with more-general pI, and fix some printf arg casts.
7241 * lisp.h (pI): New macro, generalizing old pEd macro to other
7242 conversion specifiers. For example, use "...%"pI"d..." rather
7243 than "...%"pEd"...".
7244 (pEd): Remove. All uses replaced with similar uses of pI.
7245 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7246 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7247 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7248 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7249 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7250 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7251 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7252 64-bit hosts.
7253 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7254 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7255 * print.c (safe_debug_print, print_object): Likewise.
7256 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7257 to int.
7258 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7259 avoiding the 0 flag, which is not portable.
7260 * process.c (Fmake_network_process): Use pI to avoid cast.
7261 * region-cache.c (pp_cache): Likewise.
7262 * xdisp.c (decode_mode_spec): Likewise.
7263 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7264 behavior on 64-bit hosts with printf arg.
7265 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7266 (x_stop_queuing_selection_requests): Likewise.
7267 (x_get_window_property): Don't truncate byte count to an 'int'
7268 when tracing.
7269
7270 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7271 here, since it parses constructs like leading '-' and spaces,
7272 which are not wanted; and it overflows with large numbers.
7273 Instead, simply match F[0-9]+, which is what is wanted anyway.
7274
7275 * alloc.c: Remove unportable assumptions about struct layout.
7276 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7277 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7278 (allocate_vectorlike, make_pure_vector): Use the new macros,
7279 plus offsetof, to remove unportable assumptions about struct layout.
7280 These assumptions hold on all porting targets that I know of, but
7281 they are not guaranteed, they're easy to remove, and removing them
7282 makes further changes easier.
7283
7284 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7285 This doesn't fix a bug but makes the code clearer.
7286 (string_overrun_cookie): Now const. Use initializers that
7287 don't formally overflow signed char, to avoid warnings.
7288 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7289 can cause Emacs to crash when string overrun checking is enabled.
7290 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7291 multiple of sizeof (EMACS_INT); it need not be, if
7292 alignof(EMACS_INT) < sizeof (EMACS_INT).
7293 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7294
7295 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7296
7297 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7298
7299 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7300
7301 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7302 supposed to be handshaking. (Bug#8556)
7303 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7304
7305 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7306
7307 * lisp.h (Qdebug): List symbol.
7308 * eval.c (Qdebug): Restore global linkage.
7309 * keyboard.c (debug-on-event): New variable.
7310 (handle_user_signal): Break into debugger when debug-on-event
7311 matches the current signal symbol.
7312
7313 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7314
7315 * alloc.c (check_sblock, check_string_bytes)
7316 (check_string_free_list): Convert to standard C.
7317
7318 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7319
7320 * w32.c (emacs_gnutls_push): Fix typo.
7321
7322 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7323
7324 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7325 "cast to pointer from integer of different size".
7326
7327 Improve doprnt and its use in verror. (Bug#8545)
7328 * doprnt.c (doprnt): Document the set of format control sequences
7329 supported by the function. Use SAFE_ALLOCA instead of always
7330 using `alloca'.
7331
7332 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7333 is one byte too soon. Don't use xrealloc; instead xfree and
7334 xmalloc anew.
7335
7336 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7337
7338 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7339 callbacks stage.
7340
7341 * gnutls.c: Renamed global_initialized to
7342 gnutls_global_initialized. Added internals for the
7343 :verify-hostname-error, :verify-error, and :verify-flags
7344 parameters of `gnutls-boot' and documented those parameters in the
7345 docstring. Start callback support.
7346 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7347 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7348 on error. Return error code.
7349 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7350 (emacs_gnutls_read): Likewise.
7351 (Fgnutls_boot): Return handshake error code.
7352 (emacs_gnutls_handle_error): New function.
7353 (wsaerror_to_errno): Likewise.
7354
7355 * w32.h (emacs_gnutls_pull): Add prototype.
7356 (emacs_gnutls_push): Likewise.
7357
7358 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7359 (emacs_gnutls_push): Likewise.
7360
7361 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7362
7363 * process.c (wait_reading_process_output): Check if GnuTLS
7364 buffered some data internally if no FDs are set for TLS
7365 connections.
7366
7367 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7368 (LIBS): Link to USER_LIBS.
7369 ($(BLD)/gnutls.$(0)): New target.
7370
7371 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7372
7373 * xdisp.c (handle_single_display_spec): Rename the
7374 display_replaced_before_p argument into display_replaced_p, to
7375 make it consistent with the commentary. Fix typos in the
7376 commentary.
7377
7378 * textprop.c (syms_of_textprop): Remove dead code.
7379 (copy_text_properties): Delete obsolete commentary about an
7380 interface that was deleted long ago. Fix typos in the description
7381 of arguments.
7382
7383 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7384 to changes in oldXMenu/XMenu.h from 2011-04-16.
7385 <menu_help_message, prev_menu_help_message>: Constify.
7386 (IT_menu_make_room): menu->help_text is now `const char **';
7387 adjust.
7388
7389 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7390 to changes in oldXMenu/XMenu.h from 2011-04-16.
7391 (struct XMenu): Declare `help_text' `const char **'.
7392
7393 * xfaces.c <Qunspecified>: Make extern again.
7394
7395 * syntax.c: Include sys/types.h before including regex.h, as
7396 required by Posix.
7397
7398 * doc.c (get_doc_string): Improve the format passed to `error'.
7399
7400 * doprnt.c (doprnt): Improve commentary.
7401
7402 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7403
7404 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7405 them with etags.
7406
7407 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7408 changes in globals.h immediately force recompilation.
7409 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7410 $(CURDIR)/s/ms-w32.h.
7411 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7412
7413 * character.c (Fchar_direction): Function deleted.
7414 (syms_of_character): Don't defsubr it.
7415 <char-direction-table>: Deleted.
7416
7417 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7418
7419 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7420 * doprnt.c: Include limits.h.
7421 (SIZE_MAX): New macro.
7422 (doprnt): Return a size_t value. 2nd arg is now size_t.
7423 Many local variables are now size_t instead of int or unsigned.
7424 Improve overflow protection. Support `l' modifier for integer
7425 conversions. Support %l conversion. Don't assume an EMACS_INT
7426 argument for integer conversions and for %c.
7427
7428 * lisp.h (doprnt): Restore prototype.
7429
7430 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7431 $(SRC)/character.h.
7432
7433 * Makefile.in (base_obj): Add back doprnt.o.
7434
7435 * deps.mk (doprnt.o): Add back prerequisites.
7436 (callint.o): Depend on character.h.
7437
7438 * eval.c (internal_lisp_condition_case): Include the handler
7439 representation in the error message.
7440 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7441 when breaking from the loop.
7442
7443 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7444
7445 * callint.c (Fcall_interactively): When displaying error message
7446 about invalid control letter, pass the character's codepoint, not
7447 a pointer to its multibyte form. Improve display of the character
7448 in octal and display also its hex code.
7449
7450 * character.c (char_string): Use %x to display the (unsigned)
7451 codepoint of an invalid character, to avoid displaying a bogus
7452 negative value.
7453
7454 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7455 `error', not SYMBOL_NAME itself.
7456
7457 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7458 character arguments to `error'.
7459
7460 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7461 to `error' in error message about FINAL_CHAR argument. Make sure
7462 FINAL_CHAR is a character, and use %c when it is passed as
7463 argument to `error'.
7464
7465 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7466
7467 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7468
7469 * w32.c: Include <time.h>.
7470 (sys_localtime): New function.
7471
7472 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7473
7474 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7475
7476 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7477
7478 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7479
7480 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7481 zombies (Bug#8467).
7482
7483 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7484
7485 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7486 gl_state.e_property when gl_state.object is Qt.
7487
7488 * insdel.c (make_gap_larger): Remove limitation of buffer size
7489 to <= INT_MAX.
7490
7491 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7492
7493 * xdisp.c (lookup_glyphless_char_display)
7494 (produce_glyphless_glyph): Handle cons cell entry in
7495 glyphless-char-display.
7496 (Vglyphless_char_display): Document it.
7497
7498 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7499 glyphless-char-display.
7500
7501 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7502
7503 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7504
7505 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7506
7507 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7508 definition for no-X builds.
7509
7510 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7511
7512 Static checks with GCC 4.6.0 and non-default toolkits.
7513
7514 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7515
7516 * process.c (keyboard_bit_set): Define only if SIGIO.
7517 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7518 (send_process): Repair possible setjmp clobbering.
7519
7520 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7521
7522 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7523
7524 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7525
7526 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7527 Define only if needed.
7528
7529 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7530 by pacifying GCC about it. Maybe it's time to retire it?
7531 * xfaces.c (USG, __TIMEVAL__): Likewise.
7532
7533 * dispextern.h (struct redisplay_interface): Rename param
7534 to avoid shadowing.
7535 * termhooks.h (struct terminal): Likewise.
7536 * xterm.c (xembed_send_message): Likewise.
7537
7538 * insdel.c (make_gap_smaller): Define only if
7539 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7540
7541 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7542 it.
7543
7544 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7545 so that we aren't warned about unused symbols.
7546
7547 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7548
7549 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7550
7551 * xfns.c (x_real_positions): Mark locals as initialized.
7552
7553 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7554
7555 * xterm.c: Fix problems found by static analysis with other toolkits.
7556 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7557 (x_dispatch_event): Declare static if USE_GTK, and
7558 define if USE_GTK || USE_X_TOOLKIT.
7559 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7560 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7561 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7562 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7563
7564 * xmenu.c (menu_help_callback): Pointer type fixes.
7565 Use const pointers when pointing at readonly data. Avoid pointer
7566 signedness clashes.
7567 (FALSE): Remove unused macro.
7568 (update_frame_menubar): Remove unused decl.
7569
7570 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7571
7572 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7573 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7574 (single_menu_item): Rename local to avoid shadowing.
7575
7576 * keyboard.c (make_lispy_event): Remove unused local var.
7577
7578 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7579 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7580
7581 * bitmaps: Change bitmaps from unsigned char back to the X11
7582 compatible char. Avoid the old compiler warnings about
7583 out-of-range initializers by using, for example, '\xab' rather
7584 than 0xab.
7585
7586 * xgselect.c (xgselect_initialize): Check vs interface
7587 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7588
7589 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7590
7591 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7592 to read-only memory.
7593
7594 * fns.c (vector): Remove; this old hack is no longer needed.
7595
7596 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7597 Remove unused var.
7598 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7599
7600 * xrdb.c (x_load_resources): Omit unused local.
7601
7602 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7603 (x_window): Rename locals to avoid shadowing.
7604 (USG): Use the kludged USG macro, to pacify gcc.
7605
7606 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7607 (x_term_init): Remove local to avoid shadowing.
7608
7609 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7610
7611 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7612 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7613
7614 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7615
7616 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7617
7618 Fix regex.c, syntax.c and friends for buffers > 2GB.
7619 * syntax.h (struct gl_state_s): Declare character position members
7620 EMACS_INT.
7621
7622 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7623
7624 * textprop.c (verify_interval_modification, interval_of):
7625 Declare arguments EMACS_INT.
7626
7627 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7628 EMACS_INT.
7629
7630 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7631
7632 * indent.c (Fvertical_motion): Local variable it_start is now
7633 EMACS_INT.
7634
7635 * regex.c (re_match, re_match_2, re_match_2_internal)
7636 (bcmp_translate, regcomp, regexec, print_double_string)
7637 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7638 (re_compile_pattern, re_exec): Declare arguments and local
7639 variables `size_t' and `ssize_t' and return values `regoff_t', as
7640 appropriate.
7641 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7642 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7643 <compile_stack_type>: `size' and `avail' are now `size_t'.
7644
7645 * regex.h <regoff_t>: Use ssize_t, not int.
7646 (re_search, re_search_2, re_match, re_match_2): Arguments that
7647 specify buffer/string position and length are now ssize_t and
7648 size_t. Return type is regoff_t.
7649
7650 2011-04-16 Ben Key <bkey76@gmail.com>
7651
7652 * nsfont.m: Fixed bugs in ns_get_family and
7653 ns_descriptor_to_entity that were caused by using free to
7654 deallocate memory blocks that were allocated by xmalloc (via
7655 xstrdup). This caused Emacs to crash when compiled with
7656 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7657 --enable-checking=xmallocoverrun). xfree is now used to
7658 deallocate these memory blocks.
7659
7660 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7661
7662 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7663
7664 emacs_write: Accept and return EMACS_INT for sizes.
7665 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7666 et seq.
7667 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7668 Accept and return EMACS_INT.
7669 (emacs_gnutls_write): Return the number of bytes written on
7670 partial writes.
7671 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7672 (emacs_read, emacs_write): Remove check for negative size, as the
7673 Emacs source code has been audited now.
7674 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7675 (emacs_read, emacs_write): Use it.
7676 * process.c (send_process): Adjust to the new signatures of
7677 emacs_write and emacs_gnutls_write. Do not attempt to store
7678 a byte offset into an 'int'; it might overflow.
7679 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7680
7681 * sound.c: Don't assume sizes fit in 'int'.
7682 (struct sound_device.period_size, alsa_period_size):
7683 Return EMACS_INT, not int.
7684 (struct sound_device.write, vox_write, alsa_write):
7685 Accept EMACS_INT, not int.
7686 (wav_play, au_play): Use EMACS_INT to store sizes and to
7687 record read return values.
7688
7689 2011-04-15 Ben Key <bkey76@gmail.com>
7690
7691 * keyboard.c (Qundefined): Don't declare static since it is used
7692 in nsfns.m.
7693 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7694 static since they are used in nsfont.m.
7695
7696 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7697
7698 * process.c (Qprocessp): Don't declare static.
7699 * lisp.h (Qprocessp): Declare again.
7700
7701 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7702
7703 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7704
7705 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7706
7707 Improve C-level modularity by making more things 'static'.
7708
7709 Don't publish debugger-only interfaces to other modules.
7710 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7711 (verify_bytepos, count_markers): Move decls to the only modules
7712 that need them.
7713 * region-cache.h (pp_cache): Likewise.
7714 * window.h (check_all_windows): Likewise.
7715 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7716
7717 * sysdep.c (croak): Now static, if
7718 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7719 * syssignal.h (croak): Declare only if not static.
7720
7721 * alloc.c (refill_memory_reserve): Now static if
7722 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7723 * lisp.h (refill_memory_reserve): Declare only if not static.
7724
7725 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7726 Define only if USE_LUCID.
7727
7728 * xrdb.c (x_customization_string, x_rm_string): Now static.
7729
7730 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7731 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7732
7733 * xdisp.c (draw_row_with_mouse_face): Now static.
7734 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7735
7736 * window.h (check_all_windows): Mark externally visible.
7737
7738 * window.c (window_deletion_count): Now static.
7739
7740 * undo.c: Make symbols static if they're not exported.
7741 (last_undo_buffer, last_boundary_position, pending_boundary):
7742 Now static.
7743
7744 * textprop.c (interval_insert_behind_hooks): Now static.
7745 (interval_insert_in_front_hooks): Likewise.
7746
7747 * term.c: Make symbols static if they're not exported.
7748 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7749 (max_frame_lines, tty_set_terminal_modes):
7750 (tty_reset_terminal_modes, tty_turn_off_highlight):
7751 (get_tty_terminal): Now static.
7752 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7753 * termhooks.h (term_mouse_moveto): Do not declare if
7754 HAVE_WINDOW_SYSTEM.
7755 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7756 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7757
7758 * sysdep.c: Make symbols static if they're not exported.
7759 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7760 Now static.
7761 (sigprocmask_set, full_mask): Remove; unused.
7762 (wait_debugging): Mark as visible.
7763 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7764 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7765
7766 * syntax.c (syntax_temp): Define only if !__GNUC__.
7767
7768 * sound.c (current_sound_device, current_sound): Now static.
7769
7770 * search.c (searchbufs, searchbuf_head): Now static.
7771
7772 * scroll.c (scroll_cost): Remove; unused.
7773 * dispextern.h (scroll_cost): Remove decl.
7774
7775 * region-cache.h (pp_cache): Mark as externally visible.
7776
7777 * process.c: Make symbols static if they're not exported.
7778 (process_tick, update_tick, create_process, chan_process):
7779 (Vprocess_alist, proc_buffered_char, datagram_access):
7780 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7781 (deactivate_process): Mark defn as static, as well as decl.
7782 * lisp.h (create_process): Remove decl.
7783 * process.h (chan_process, Vprocess_alist): Remove decls.
7784
7785 * print.c: Make symbols static if they're not exported.
7786 (print_depth, new_backquote_output, being_printed, print_buffer):
7787 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7788 (print_interval, print_number_index, initial_stderr_stream):
7789 Now static.
7790 * lisp.h (Fprinc): Remove decl.
7791 (debug_output_compilation_hack): Mark as externally visible.
7792
7793 * sysdep.c (croak): Move decl from here to syssignal.h.
7794 * syssignal.h (croak): Put it here, so the API can be checked when
7795 'croak' is called from dissociate_if_controlling_tty.
7796
7797 * minibuf.c: Make symbols static if they're not exported.
7798 (minibuf_save_list, choose_minibuf_frame): Now static.
7799 * lisp.h (choose_minibuf_frame): Remove decl.
7800
7801 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7802
7803 * lread.c: Make symbols static if they're not exported.
7804 (read_objects, initial_obarray, oblookup_last_bucket_number):
7805 Now static.
7806 (make_symbol): Remove; unused.
7807 * lisp.h (initial_obarray, make_symbol): Remove decls.
7808
7809 * keyboard.c: Make symbols static if they're not exported.
7810 (single_kboard, recent_keys_index, total_keys, recent_keys):
7811 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7812 (this_single_command_key_start, echoing, last_auto_save):
7813 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7814 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7815 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7816 (Vlispy_mouse_stem, double_click_count):
7817 Now static.
7818 (force_auto_save_soon): Define only if SIGDANGER.
7819 (ignore_mouse_drag_p): Now static if
7820 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7821 (print_help): Remove; unused.
7822 (stop_character, last_timer_event): Mark as externally visible.
7823 * keyboard.h (ignore_mouse_drag_p): Declare only if
7824 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7825 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7826 * lisp.h (echoing): Remove decl.
7827 (force_auto_save_soon): Declare only if SIGDANGER.
7828 * xdisp.c (redisplay_window): Simplify code, to make it more
7829 obvious that ignore_mouse_drag_p is not accessed if !defined
7830 USE_GTK && !defined HAVE_NS.
7831
7832 * intervals.c: Make symbols static if they're not exported.
7833 (merge_properties_sticky, merge_interval_right, delete_interval):
7834 Now static.
7835 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7836
7837 * insdel.c: Make symbols static if they're not exported.
7838 However, leave prepare_to_modify_buffer alone. It's never
7839 called from outside this function, but that appears to be a bug.
7840 (combine_after_change_list, combine_after_change_buffer):
7841 (adjust_after_replace, signal_before_change): Now static.
7842 (adjust_after_replace_noundo): Remove; unused.
7843 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7844 (signal_before_change): Remove decls.
7845
7846 * indent.c (val_compute_motion, val_vmotion): Now static.
7847
7848 * image.c: Make symbols static if they're not exported.
7849 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7850 if USE_GTK.
7851 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7852 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7853
7854 * fringe.c (standard_bitmaps): Now static.
7855 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7856
7857 * frame.c: Make symbols static if they're not exported.
7858 (x_report_frame_params, make_terminal_frame): Now static.
7859 (get_frame_param): Now static, unless HAVE_NS.
7860 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7861 (x_get_resource_string): Remove; not used.
7862 * frame.h (make_terminal_frame, x_report_frame_params):
7863 (x_get_resource_string); Remove decls.
7864 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7865 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7866
7867 * font.c, fontset.c: Make symbols static if they're not exported.
7868 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7869 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7870 * font.c (font_close_object): Now static.
7871 * font.h (font_close_object): Remove.
7872 * fontset.c (FONTSET_OBJLIST): Remove.
7873 (free_realized_fontset) #if-0 the body, which does nothing.
7874 (face_suitable_for_char_p): #if-0, as it's never called.
7875 * fontset.h (face_suitable_for_char_p): Remove decl.
7876 * xfaces.c (face_at_string_position):
7877 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7878 since 0 is always ASCII.
7879
7880 * fns.c (weak_hash_tables): Now static.
7881
7882 * fileio.c: Make symbols static if they're not exported.
7883 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7884 (Vwrite_region_annotation_buffers): Now static.
7885
7886 * eval.c: Make symbols static if they're not exported.
7887 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7888 * lisp.h (backtrace_list): Remove decl.
7889
7890 * emacs.c: Make symbols static if they're not exported.
7891 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7892 (fatal_error_code, fatal_error_signal_hook, standard_args):
7893 Now static.
7894 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7895 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7896 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7897 * lisp.h (fatal_error_signal_hook): Remove decl.
7898 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7899
7900 * editfns.c: Move a (normally-unused) function to its only use.
7901 * editfns.c, lisp.h (get_operating_system_release): Remove.
7902 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7903 worth the hassle of breaking this out.
7904
7905 * xterm.c: Make symbols static if they're not exported.
7906 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7907 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7908 (x_destroy_window, x_delete_display):
7909 Now static.
7910 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7911 (x_mouse_leave): Remove; unused.
7912 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7913 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7914 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7915 Remove decls.
7916 (x_mouse_leave): Declare only if WINDOWSNT.
7917 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7918 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7919 USE_X_TOOLKIT.
7920
7921 * ftxfont.c: Make symbols static if they're not exported.
7922 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7923 HAVE_FREETYPE.
7924 * font.h (ftxfont_driver): Likewise.
7925
7926 * xfns.c: Make symbols static if they're not exported.
7927 (x_last_font_name, x_display_info_for_name):
7928 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7929 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7930 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7931 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7932 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7933 (last_show_tip_args): Now static.
7934 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7935 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7936 (x_screen_planes): Remove; unused.
7937 * dispextern.h (x_screen_planes): Remove decl.
7938
7939 * dispnew.c: Make symbols static if they're not exported.
7940 * dispextern.h (redraw_garbaged_frames, scrolling):
7941 (increment_row_positions): Remove.
7942 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7943 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7944 Now static.
7945 (redraw_garbaged_frames): Remove; unused.
7946
7947 * xfaces.c: Make symbols static if they're not exported.
7948 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7949 Remove decls.
7950 * xterm.h (defined_color): Remove decls.
7951 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7952 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7953 (menu_face_changed_default, defined_color, free_realized_face):
7954 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7955 (ascii_face_of_lisp_face): Remove; unused.
7956
7957 * xdisp.c: Make symbols static if they're not exported.
7958 * dispextern.h (scratch_glyph_row, window_box_edges):
7959 (glyph_to_pixel_coords, set_cursor_from_row):
7960 (get_next_display_element, set_iterator_to_next):
7961 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7962 (show_mouse_face): Remove decls
7963 * frame.h (message_buf_print): Likewise.
7964 * lisp.h (pop_message, set_message, check_point_in_composition):
7965 Likewise.
7966 * xterm.h (set_vertical_scroll_bar): Likewise.
7967 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7968 (message_buf_print, scratch_glyph_row, displayed_buffer):
7969 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7970 (get_next_display_element, show_mouse_face, window_box_edges):
7971 (frame_to_window_pixel_xy, check_point_in_composition):
7972 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7973 (glyph_to_pixel_coords): Remove; unused.
7974
7975 * dired.c (file_name_completion): Now static.
7976
7977 * dbusbind.c (xd_in_read_queued_messages): Now static.
7978
7979 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7980 * data.c (circular_list_error): Remove.
7981
7982 * commands.h (last_point_position, last_point_position_buffer):
7983 (last_point_position_window): Remove decls.
7984 * keyboard.c: Make these variables static.
7985
7986 * coding.h (coding, code_convert_region, encode_coding_gap):
7987 Remove decls.
7988 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7989 (iso_code_class, detect_coding, code_convert_region): Now static.
7990 (encode_coding_gap): Remove; unused.
7991
7992 * chartab.c (chartab_chars, chartab_bits): Now static.
7993
7994 * charset.h (charset_iso_8859_1): Remove decl.
7995 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7996 Now static.
7997
7998 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7999 * ccl.c (Vccl_program_table): Now static.
8000 (check_ccl_update): Remove; unused.
8001
8002 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8003 * category.h: ... from here.
8004 * category.c (check_category_table, set_category_set): Now static.
8005
8006 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8007 * lisp.h: Remove these decls.
8008
8009 * buffer.c (buffer_count): Remove unused var.
8010
8011 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8012 so that it's not optimized away.
8013 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8014 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8015 exported only to the debugger.
8016
8017 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8018 * atimer.h (run_all_atimers): Remove; not exported.
8019
8020 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8021 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8022 was inaccessible from Lisp.
8023 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8024 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8025
8026 alloc.c: Import and export fewer symbols, and remove unused items.
8027 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8028 is defined.
8029 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8030 it's not optimized away by whole-program optimization.
8031 (message_enable_multibyte, free_misc): Remove.
8032 (catchlist, handlerlist, mark_backtrace):
8033 Declare only if BYTE_MARK_STACK.
8034 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8035 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8036 (message_enable_multibyte): Remove decl.
8037 (free_misc, interval_free_list, float_block, float_block_index):
8038 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8039 (cons_free_list, last_marked_index):
8040 Now static.
8041 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8042 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8043 (mark_backtrace): Define only if BYTE_MARK_STACK.
8044 * xdisp.c (message_enable_multibyte): Now static.
8045
8046 Declare Lisp_Object Q* variables to be 'static' if not exported.
8047 This makes it easier for human readers (and static analyzers)
8048 to see whether these variables are used from other modules.
8049 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8050 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8051 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8052 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8053 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8054 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8055 * xmenu.c, xselect.c:
8056 Declare Q* vars static if they are not used in other modules.
8057 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8058 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8059 Remove decls of unexported vars.
8060 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8061
8062 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8063
8064 Make Emacs functions such as Fatom 'static' by default.
8065 This makes it easier for human readers (and static analyzers)
8066 to see whether these functions can be called from other modules.
8067 DEFUN now defines a static function. To make the function external
8068 so that it can be used in other C modules, use the new macro DEFUE.
8069 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8070 (Finit_image_library):
8071 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8072 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8073 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8074 Remove decls, since these functions are now static.
8075 (Funintern, Fget_internal_run_time): New decls, since these functions
8076 were already external.
8077
8078 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8079 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8080 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8081 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8082 * keyboard.c, keymap.c, lread.c:
8083 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8084 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8085 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8086 Mark functions with DEFUE instead of DEFUN,
8087 if they are used in other modules.
8088 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8089 decls for now-static functions.
8090 * buffer.h (Fdelete_overlay): Remove decl.
8091 * callproc.c (Fgetenv_internal): Mark as internal.
8092 * composite.c (Fremove_list_of_text_properties): Remove decl.
8093 (Fcomposition_get_gstring): New forward static decl.
8094 * composite.h (Fcomposite_get_gstring): Remove decl.
8095 * dired.c (Ffile_attributes): New forward static decl.
8096 * doc.c (Fdocumntation_property): New forward static decl.
8097 * eval.c (Ffetch_bytecode): New forward static decl.
8098 (Funintern): Remove extern decl; now in .h file where it belongs.
8099 * fileio.c (Fmake_symbolic_link): New forward static decl.
8100 * image.c (Finit_image_library): New forward static decl.
8101 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8102 * intervals.h (Fprevious_property_change):
8103 (Fremove_list_of_text_properties): Remove decls.
8104 * keyboard.c (Fthis_command_keys): Remove decl.
8105 (Fcommand_execute): New forward static decl.
8106 * keymap.c (Flookup_key): New forward static decl.
8107 (Fcopy_keymap): Now static.
8108 * keymap.h (Flookup_key): Remove decl.
8109 * process.c (Fget_process): New forward static decl.
8110 (Fprocess_datagram_address): Mark as internal.
8111 * syntax.c (Fsyntax_table_p): New forward static decl.
8112 (skip_chars): Remove duplicate decl.
8113 * textprop.c (Fprevious_property_change): New forward static decl.
8114 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8115 Now internal.
8116 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8117 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8118
8119 * editfns.c (Fformat): Remove unreachable code.
8120
8121 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8122
8123 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8124 change. (Bug#8496)
8125
8126 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8127
8128 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8129 when at ZV. (Bug#8487)
8130
8131 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8132
8133 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8134 (Bug#8437)
8135 * keyboard.c (parse_tool_bar_item): Likewise.
8136 * sound.c (sound_cleanup, alsa_close): Likewise.
8137 * termcap.c (tgetent): Likewise.
8138 * xfns.c (x_default_font_parameter): Likewise.
8139 * xsettings.c (read_and_apply_settings): Likewise.
8140
8141 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8142 (overrun_check_free): Protoize.
8143
8144 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8145
8146 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8147 since callers should never pass a negative size.
8148 Change the signature to match that of plain 'read' and 'write'; see
8149 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8150 * lisp.h: Update prototypes of emacs_write and emacs_read.
8151
8152 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8153
8154 * xdisp.c (redisplay_window): Don't try to determine the character
8155 position of the scroll margin if the window start point w->startp
8156 is outside the buffer's accessible region. (Bug#8468)
8157
8158 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8159
8160 Fix write-region and its subroutines for buffers > 2GB.
8161 * fileio.c (a_write, e_write): Modify declaration of arguments and
8162 local variables to support buffers larger than 2GB.
8163 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8164
8165 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8166 argument, local variables, and return value.
8167
8168 * lisp.h: Update prototypes of emacs_write and emacs_read.
8169
8170 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8171
8172 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8173
8174 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8175
8176 Fix more problems found by GCC 4.6.0's static checks.
8177
8178 * xdisp.c (vmessage): Use a better test for character truncation.
8179
8180 * charset.c (load_charset_map): <, not <=, for optimization,
8181 and to avoid potential problems with integer overflow.
8182 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8183 * casetab.c (set_identity, shuffle): Likewise.
8184 * editfns.c (Fformat): Likewise.
8185 * syntax.c (skip_chars): Likewise.
8186
8187 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8188 This also lets GCC 4.6.0 generate slightly better loop code.
8189
8190 * callint.c (Fcall_interactively): <, not <=, for optimization.
8191 (Fcall_interactively): Count the number of arguments produced,
8192 not the number of arguments given. This is simpler and lets GCC
8193 4.6.0 generate slightly better code.
8194
8195 * ftfont.c: Distingish more carefully between FcChar8 and char.
8196 The previous code passed unsigned char * to a functions like
8197 strlen and xstrcasecmp that expect char *, which does not
8198 conform to the C standard.
8199 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8200 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8201 char * when the C standard requires it.
8202
8203 * keyboard.c (read_char): Remove unused var.
8204
8205 * eval.c: Port to Windows vsnprintf (Bug#8435).
8206 Include <limits.h>.
8207 (SIZE_MAX): Define if the headers do not.
8208 (verror): Do not give up if vsnprintf returns a negative count.
8209 Instead, grow the buffer. This ports to Windows vsnprintf, which
8210 does not conform to C99. Problem reported by Eli Zaretskii.
8211 Also, simplify the allocation scheme, by avoiding the need for
8212 calling realloc, and removing the ALLOCATED variable.
8213
8214 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8215
8216 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8217 But keep the doprint source code for now, as we might revamp it
8218 and use it again (Bug#8435).
8219 * lisp.h (doprnt): Remove.
8220 * Makefile.in (base_obj): Remove doprnt.o.
8221 * deps.mk (doprnt.o): Remove.
8222
8223 error: Print 32- and 64-bit integers portably (Bug#8435).
8224 Without this change, on typical 64-bit hosts error ("...%d...", N)
8225 was used to print both 32- and 64-bit integers N, which relied on
8226 undefined behavior.
8227 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8228 * lisp.h (error, verror): Mark as printf-like functions.
8229 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8230 Report overflow in size calculations when allocating printf buffer.
8231 Do not truncate output string at its first null byte.
8232 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8233 Truncate the output at a character boundary, since vsnprintf does not
8234 do that.
8235 * charset.c (check_iso_charset_parameter): Convert internal
8236 character to string before calling 'error', since %c now has the
8237 printf meaning.
8238 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8239 overflow when computing char to be passed to 'error'. Do not
8240 pass Lisp_Object to 'error'; pass the integer instead.
8241 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8242 formatted with plain %d.
8243
8244 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8245
8246 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8247
8248 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8249
8250 * xterm.c (x_catch_errors): Remove duplicate declaration.
8251
8252 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8253
8254 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8255
8256 2011-04-10 Jim Meyering <meyering@redhat.com>
8257
8258 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8259 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8260 return ssize_t not "int", and use size_t as the buffer length.
8261 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8262 * gnutls.h: Update declarations.
8263 * process.c (read_process_output): Use ssize_t, to match.
8264 (send_process): Likewise.
8265
8266 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8267
8268 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8269
8270 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8271
8272 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8273 Use unsigned char, to match FcChar8 type definition.
8274
8275 * xterm.c (handle_one_xevent):
8276 * xmenu.c (create_and_show_popup_menu):
8277 * xselect.c (x_decline_selection_request)
8278 (x_reply_selection_request): Avoid type-punned deref of X events.
8279
8280 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8281
8282 Fix some uses of `int' instead of EMACS_INT.
8283 * search.c (string_match_1, fast_string_match)
8284 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8285 (scan_buffer, find_next_newline_no_quit)
8286 (find_before_next_newline, search_command, Freplace_match)
8287 (Fmatch_data): Make some `int' variables be EMACS_INT.
8288
8289 * xdisp.c (display_count_lines): 3rd argument and return value now
8290 EMACS_INT. All callers changed.
8291 (pint2hrstr): Last argument is now EMACS_INT.
8292
8293 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8294 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8295 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8296 (decode_coding_utf_16, decode_coding_emacs_mule)
8297 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8298 (decode_coding_ccl, decode_coding_charset)
8299 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8300 (decode_coding_iso_2022, decode_coding_emacs_mule)
8301 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8302 <char_offset, last_offset>: Declare EMACS_INT.
8303 (encode_coding_utf_8, encode_coding_utf_16)
8304 (encode_coding_emacs_mule, encode_invocation_designation)
8305 (encode_designation_at_bol, encode_coding_iso_2022)
8306 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8307 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8308 Declare EMACS_INT.
8309 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8310 (encode_invocation_designation): Last argument P_NCHARS is now
8311 EMACS_INT.
8312 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8313 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8314
8315 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8316 All users changed.
8317
8318 * ccl.c (Fccl_execute_on_string): Declare some variables
8319 EMACS_INT.
8320
8321 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8322
8323 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8324
8325 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8326
8327 * process.c (Fformat_network_address): Doc fix.
8328
8329 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8330
8331 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8332
8333 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8334
8335 * keyboard.c (read_char): Call Lisp function help-form-show,
8336 instead of using internal_with_output_to_temp_buffer.
8337 (Qhelp_form_show): New var.
8338 (syms_of_keyboard): Use DEFSYM macro.
8339
8340 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8341
8342 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8343
8344 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8345
8346 * process.c (Flist_processes): Remove to Lisp.
8347 (list_processes_1): Delete.
8348
8349 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8350
8351 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8352
8353 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8354
8355 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8356
8357 Fix more problems found by GCC 4.6.0's static checks.
8358
8359 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8360
8361 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8362
8363 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8364
8365 * xdisp.c (vmessage): Mark as a printf-like function.
8366
8367 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8368
8369 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8370
8371 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8372 printf-like functions.
8373 (tiff_load): Add casts to remove these marks before passing them
8374 to system-supplied API.
8375
8376 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8377
8378 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8379 This avoids several warnings with gcc -Wstrict-overflow.
8380 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8381 directly, rather than having caller test rule sign. This avoids
8382 some unnecessary tests.
8383 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8384 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8385 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8386
8387 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8388 (xfont_open): Avoid unnecessary tests.
8389
8390 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8391
8392 * composite.h, composite.c (composition_gstring_put_cache):
8393 Use EMACS_INT, not int, for length.
8394
8395 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8396 breaking out part of COMPOSITION_DECODE_RULE.
8397 (COMPOSITION_DECODE_RULE): Use it.
8398 * composite.c (get_composition_id): Remove unused local vars,
8399 by using the new macro.
8400
8401 * textprop.c (set_text_properties_1): Change while to do-while,
8402 since the condition is always true at first.
8403
8404 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8405 (interval_deletion_adjustment): Return unsigned value.
8406 All uses changed.
8407
8408 * process.c (list_processes_1, create_pty, read_process_output):
8409 (exec_sentinel): Remove vars that were set but not used.
8410 (create_pty): Remove unnecessary "volatile"s.
8411 (Fnetwork_interface_info): Avoid possibility of int overflow.
8412 (read_process_output): Do adaptive read buffering even if carryover.
8413 (read_process_output): Simplify nbytes computation if buffered.
8414
8415 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8416
8417 * syntax.c (scan_words): Remove var that was set but not used.
8418 (update_syntax_table): Use unsigned instead of int.
8419
8420 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8421 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8422 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8423
8424 * print.c (print_error_message): Avoid int overflow.
8425
8426 * font.c (font_list_entities): Redo for clarity,
8427 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8428
8429 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8430 (font_score): Avoid potential overflow in diff calculation.
8431
8432 * fns.c (substring_both): Remove var that is set but not used.
8433 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8434
8435 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8436
8437 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8438 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8439 can always succeed if overflow has undefined behavior.
8440
8441 * search.c (boyer_moore, wordify): Remove vars set but not used.
8442 (wordify): Omit three unnecessary tests.
8443
8444 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8445 All callers changed. This avoids the need for an unused var.
8446
8447 * casefiddle.c (casify_region): Remove var that is set but not used.
8448
8449 * dired.c (file_name_completion): Remove var that is set but not used.
8450
8451 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8452
8453 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8454 (Finsert_file_contents): Remove unnecessary code checking fd.
8455
8456 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8457 Check for integer overflow on size calculations.
8458
8459 * buffer.c (Fprevious_overlay_change): Remove var that is set
8460 but not used.
8461
8462 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8463 Remove vars that are set but not used.
8464 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8465 (timer_check_2): Mark vars as initialized.
8466
8467 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8468
8469 * image.c (lookup_image): Remove var that is set but not used.
8470 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8471
8472 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8473 that are set but not used.
8474
8475 * xfns.c (make_invisible_cursor): Don't return garbage
8476 if XCreateBitmapFromData fails (Bug#8410).
8477
8478 * xselect.c (x_get_local_selection, x_handle_property_notify):
8479 Remove vars that are set but not used.
8480
8481 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8482 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8483
8484 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8485 Remove var that is set but not used.
8486 (scroll_bar_windows_size): Now size_t, not int.
8487 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8488 Check for overflow.
8489
8490 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8491 (map_tty_color) [!defined MSDOS]: Likewise.
8492
8493 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8494
8495 * coding.c: Remove vars that are set but not used.
8496 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8497 All callers changed.
8498 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8499 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8500 (decode_coding_charset): Remove vars that are set but not used.
8501
8502 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8503 that is set but not used.
8504
8505 * print.c (print_object): Remove var that is set but not used.
8506
8507 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8508 The gnulib version avoids calling malloc in the usual case,
8509 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8510 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8511 * filelock.c (current_lock_owner): Likewise.
8512 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8513 * sysdep.c: Include allocator.h, careadlinkat.h.
8514 (emacs_no_realloc_allocator): New static constant.
8515 (emacs_readlink): New function.
8516 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8517 ../lib/careadlinkat.h.
8518
8519 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8520
8521 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8522 first non-nil return value).
8523
8524 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8525
8526 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8527 if not defined (Bug#8403).
8528
8529 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8530
8531 * xdisp.c (display_count_lines): Remove parameter `start',
8532 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8533 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8534 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8535 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8536 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8537 and thereabouts. All callers changed.
8538 (get_per_char_metric): Remove parameter `f', unused since
8539 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8540
8541 2011-04-02 Jim Meyering <meyering@redhat.com>
8542
8543 do not dereference NULL upon failed strdup
8544 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8545 (ns_get_family): Likewise.
8546
8547 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8548
8549 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8550
8551 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8552
8553 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8554 later (Bug#8403).
8555
8556 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8557
8558 Add lexical binding.
8559
8560 * window.c (Ftemp_output_buffer_show): New fun.
8561 (Fsave_window_excursion):
8562 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8563
8564 * lread.c (lisp_file_lexically_bound_p): New function.
8565 (Fload): Bind Qlexical_binding.
8566 (readevalloop): Remove `evalfun' arg.
8567 Bind Qinternal_interpreter_environment.
8568 (Feval_buffer): Bind Qlexical_binding.
8569 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8570 Mark as dynamic.
8571 (syms_of_lread): Declare `lexical-binding'.
8572
8573 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8574
8575 * keyboard.c (eval_dyn): New fun.
8576 (menu_item_eval_property): Use it.
8577
8578 * image.c (parse_image_spec): Use Ffunctionp.
8579
8580 * fns.c (concat, mapcar1): Accept byte-code-functions.
8581
8582 * eval.c (Fsetq): Handle lexical vars.
8583 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8584 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8585 (FletX, Flet): Obey lexical binding.
8586 (Fcommandp): Handle closures.
8587 (Feval): New `lexical' arg.
8588 (eval_sub): New function extracted from Feval. Use it almost
8589 everywhere where Feval was used. Look up vars in lexical env.
8590 Handle closures.
8591 (Ffunctionp): Move from subr.el.
8592 (Ffuncall): Handle closures.
8593 (apply_lambda): Remove `eval_flags'.
8594 (funcall_lambda): Handle closures and new byte-code-functions.
8595 (Fspecial_variable_p): New function.
8596 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8597 but without exporting it to Lisp.
8598
8599 * doc.c (Fdocumentation, store_function_docstring):
8600 * data.c (Finteractive_form): Handle closures.
8601
8602 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8603 interactive spec.
8604
8605 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8606 New byte-codes.
8607 (exec_byte_code): New function extracted from Fbyte_code to handle new
8608 calling convention for byte-code-functions. Add new byte-codes.
8609
8610 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8611
8612 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8613
8614 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8615
8616 * xdisp.c (redisplay_internal): Fix prototype.
8617
8618 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8619
8620 * xdisp.c (SCROLL_LIMIT): New macro.
8621 (try_scrolling): Use it when setting scroll_limit.
8622 Limit scrolling to 100 screen lines.
8623 (redisplay_window): Even when falling back on "recentering",
8624 position point in the window according to scroll-conservatively,
8625 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8626
8627 (try_scrolling): When point is above the window, allow searching
8628 as far as scroll_max, or one screenful, to compute vertical
8629 distance from PT to the scroll margin position. This prevents
8630 try_scrolling from unnecessarily failing when
8631 scroll-conservatively is set to a value slightly larger than the
8632 window height. Clean up the case of PT below the margin at bottom
8633 of window: scroll_max can no longer be INT_MAX. When aggressive
8634 scrolling is in use, don't let point enter the opposite scroll
8635 margin as result of the scroll.
8636 (syms_of_xdisp) <scroll-conservatively>: Document the
8637 threshold of 100 lines for never-recentering scrolling.
8638
8639 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8640
8641 * dispextern.h (move_it_by_lines):
8642 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8643 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8644 (message_log_check_duplicate): Remove parameters `prev_bol' and
8645 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8646 (redisplay_internal): Remove parameter `preserve_echo_area',
8647 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8648
8649 * indent.c (Fvertical_motion):
8650 * window.c (window_scroll_pixel_based, Frecenter):
8651 Don't pass `need_y_p' to `move_it_by_lines'.
8652
8653 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8654
8655 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8656 steal a few bits to be more compact.
8657 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8658 Remove unneeded casts.
8659
8660 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8661
8662 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8663
8664 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8665 binding" message (bug#7967).
8666
8667 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8668
8669 Fix more problems found by GCC 4.6.0's static checks.
8670
8671 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8672 Remove unused local var.
8673
8674 * editfns.c (Fmessage_box): Remove unused local var.
8675
8676 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8677 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8678 Omit unused local vars.
8679 * window.c (shrink_windows): Omit unused local var.
8680 * menu.c (digest_single_submenu): Omit unused local var.
8681 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8682 Omit unused local var.
8683
8684 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8685 Don't assume string length fits in int.
8686 (keyremap_step, read_key_sequence): Use size_t for sizes.
8687 (read_key_sequence): Don't check last_real_key_start redundantly.
8688
8689 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8690 instead of alloca (Bug#8344).
8691
8692 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8693 (Fbacktrace_frame): Don't assume nframes fits in int.
8694
8695 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8696
8697 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8698 concerns.
8699
8700 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8701
8702 * cm.c (calccost): Turn while-do into do-while, for clarity.
8703
8704 * keyboard.c (syms_of_keyboard): Use the same style as later
8705 in this function when indexing through an array. This also
8706 works around GCC bug 48267.
8707
8708 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8709
8710 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8711
8712 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8713 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8714
8715 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8716 This avoids undefined behavior on integer overflow, and is a bit
8717 more convenient anyway since it is compared to a size_t variable.
8718
8719 Variadic C functions now count arguments with size_t, not int.
8720 This avoids an unnecessary limitation on 64-bit machines, which
8721 caused (substring ...) to crash on large vectors (Bug#8344).
8722 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8723 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8724 All variadic functions and their callers changed accordingly.
8725 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8726 * data.c (arith_driver, float_arith_driver): Likewise.
8727 * editfns.c (general_insert_function): Likewise.
8728 * eval.c (struct backtrace.nargs, interactive_p)
8729 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8730 (funcall_lambda, mark_backtrace): Likewise.
8731 * fns.c (concat): Likewise.
8732 * frame.c (x_set_frame_parameters): Likewise.
8733 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8734 0 if not found, not -1. All callers changed.
8735
8736 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8737 (stack_copy_size): Now size_t, not int.
8738 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8739
8740 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8741
8742 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8743 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8744 All callers changed.
8745
8746 * lisp.h (multibyte_char_to_unibyte):
8747 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8748 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8749 * character.h (CHAR_TO_BYTE8):
8750 * cmds.c (internal_self_insert):
8751 * editfns.c (general_insert_function):
8752 * keymap.c (push_key_description):
8753 * search.c (Freplace_match):
8754 * xdisp.c (message_dolog, set_message_1): All callers changed.
8755
8756 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8757
8758 * keyboard.c (safe_run_hook_funcall): New function.
8759 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8760 don't set the hook to nil, but remove the offending function instead.
8761 (Qcommand_hook_internal): Remove, unused.
8762 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8763 Vcommand_hook_internal.
8764
8765 * eval.c (enum run_hooks_condition): Remove.
8766 (funcall_nil, funcall_not): New functions.
8767 (run_hook_with_args): Call each function through a `funcall' argument.
8768 Remove `cond' argument, now redundant.
8769 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8770 (Frun_hook_with_args_until_failure): Adjust accordingly.
8771 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8772
8773 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8774
8775 * dispextern.h (string_buffer_position): Remove declaration.
8776
8777 * print.c (strout): Remove parameter `multibyte', unused since
8778 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8779
8780 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8781 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8782 All callers changed.
8783
8784 * w32.c (_wsa_errlist): Use braces for struct initializers.
8785
8786 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8787 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8788 All callers changed.
8789 (string_buffer_position): Likewise. Also, make static (it's never
8790 used outside xdisp.c).
8791 (cursor_row_p): Remove parameter `w', unused since
8792 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8793 (decode_mode_spec): Remove parameter `precision', introduced during
8794 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8795 All callers changed.
8796
8797 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8798
8799 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8800
8801 2011-03-27 Anders Lindgren <andlind@gmail.com>
8802
8803 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8804 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8805 (ns_update_auto_hide_menu_bar): New functions.
8806 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8807 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8808 ns_constrain_all_frames.
8809 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8810 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8811
8812 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8813
8814 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8815
8816 2011-03-27 Glenn Morris <rgm@gnu.org>
8817
8818 * syssignal.h: Replace RETSIGTYPE with void.
8819 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8820 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8821 Replace SIGTYPE with void everywhere.
8822 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8823 * s/template.h (SIGTYPE): Remove commented out definition.
8824
8825 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8826
8827 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8828 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8829
8830 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8831
8832 * w32.c (read_unc_volume): Use parameter `henum', instead of
8833 global variable `wget_enum_handle'.
8834
8835 * keymap.c (describe_vector): Remove parameters `indices' and
8836 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8837 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8838
8839 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8840
8841 * keyboard.c (timer_check): Remove parameter `do_it_now',
8842 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8843 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8844 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8845
8846 * keyboard.c (read_char):
8847 * w32menu.c (w32_menu_display_help):
8848 * xmenu.c (show_help_event, menu_help_callback):
8849 Adjust calls to `show_help_echo'.
8850
8851 * gtkutil.c (xg_maybe_add_timer):
8852 * keyboard.c (readable_events):
8853 * process.c (wait_reading_process_output):
8854 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8855
8856 * insdel.c (adjust_markers_gap_motion):
8857 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8858 (gap_left, gap_right): Don't call it.
8859
8860 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8861
8862 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8863 incurred during fontification.
8864
8865 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8866
8867 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8868 (DEFVAR_PER_BUFFER): Don't pass it.
8869
8870 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8871 (scrolling_window): Don't pass it.
8872
8873 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8874
8875 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8876
8877 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8878 and `suffix'.
8879 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8880 of variables specific to SELinux and computation of `encoded_absname'.
8881
8882 * image.c (XPutPixel): Remove unused variable `height'.
8883
8884 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8885
8886 * unexw32.c (get_section_info): Remove unused variable `section'.
8887
8888 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8889 (system_process_attributes): Remove unused variable `sess'.
8890 (sys_read): Remove unused variable `err'.
8891
8892 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8893 (w32_wnd_proc): Remove unused variable `isdead'.
8894 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8895 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8896 (x_create_tip_frame): Remove unused variable `tem'.
8897
8898 * w32inevt.c (w32_console_read_socket):
8899 Remove unused variable `no_events'.
8900
8901 * w32term.c (x_draw_composite_glyph_string_foreground):
8902 Remove unused variable `width'.
8903
8904 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8905
8906 * w32term.c (x_set_glyph_string_clipping):
8907 Don't pass uninitialized region to CombineRgn.
8908
8909 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8910
8911 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8912 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8913 (Fx_close_connection): Remove unused variable `i'.
8914
8915 * w32font.c (w32font_draw): Return number of glyphs.
8916 (w32font_open_internal): Remove unused variable `i'.
8917 (w32font_driver): Add missing initializer.
8918
8919 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8920 (fill_in_menu): Remove unused variable `items_added'.
8921
8922 * w32term.c (last_mouse_press_frame): Remove static global variable.
8923 (w32_clip_to_row): Remove unused variable `f'.
8924 (x_delete_terminal): Remove unused variable `i'.
8925
8926 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8927 (NOTHING): Remove unused static global variable.
8928 (uniscribe_check_otf): Remove unused variable `table'.
8929 (uniscribe_font_driver): Add missing initializers.
8930
8931 2011-03-23 Julien Danjou <julien@danjou.info>
8932
8933 * term.c (Fsuspend_tty, Fresume_tty):
8934 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8935 * window.c (temp_output_buffer_show):
8936 * insdel.c (signal_before_change):
8937 * frame.c (Fhandle_switch_frame):
8938 * fileio.c (Fdo_auto_save):
8939 * emacs.c (Fkill_emacs):
8940 * editfns.c (save_excursion_restore):
8941 * cmds.c (internal_self_insert):
8942 * callint.c (Fcall_interactively):
8943 * buffer.c (Fkill_all_local_variables):
8944 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8945 Use Frun_hooks.
8946 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8947 unconditionally since it does the check itself.
8948
8949 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8950
8951 Fix more problems found by GCC 4.5.2's static checks.
8952
8953 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8954 the first time through the loop, since we know p0 < p1 then.
8955 This also avoids a gcc -Wstrict-overflow warning.
8956
8957 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8958 leading to a memory leak, possible in functions like
8959 load_charset_map_from_file that can allocate an unbounded number
8960 of objects (Bug#8318).
8961
8962 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8963 that could (at least in theory) be that large.
8964
8965 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8966 This is less likely to overflow, and avoids undefined behavior if
8967 overflow does occur. All callers changed. Use strtoul to scan
8968 for the unsigned long integer.
8969 (pint2hrstr): Simplify and tune code slightly.
8970 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8971
8972 * scroll.c (do_scrolling): Work around GCC bug 48228.
8973 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8974
8975 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8976 This also avoids a warning with gcc -Wstrict-overflow.
8977 (validate_x_resource_name): Simplify count usage.
8978 This also avoids a warning with gcc -Wstrict-overflow.
8979
8980 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8981 fail (Bug#8306).
8982
8983 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8984
8985 * process.c (Fmake_network_process): Use socklen_t, not int,
8986 where POSIX says socklen_t is required in portable programs.
8987 This fixes a porting bug on hosts like 64-bit HP-UX, where
8988 socklen_t is wider than int (Bug#8277).
8989 (Fmake_network_process, server_accept_connection):
8990 (wait_reading_process_output, read_process_output):
8991 Likewise.
8992
8993 * process.c: Rename or move locals to avoid shadowing.
8994 (list_processes_1, Fmake_network_process):
8995 (read_process_output_error_handler, exec_sentinel_error_handler):
8996 Rename or move locals.
8997 (Fmake_network_process): Define label "retry_connect" only if needed.
8998 (Fnetwork_interface_info): Fix pointer signedness.
8999 (process_send_signal): Add cast to avoid pointer signedness problem.
9000 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9001 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9002
9003 Make tparam.h and terminfo.c consistent.
9004 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9005 Include tparam.h instead, since it declares them.
9006 * cm.h (PC): Remove extern decl; tparam.h now does this.
9007 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9008 * terminfo.c: Include tparam.h, to check interfaces.
9009 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9010 (tparam): Adjust signature to match interface in tparam.h;
9011 this removes some undefined behavior. Check that outstring and len
9012 are zero, which they always are with Emacs.
9013 * tparam.h (PC, BC, UP): New extern decls.
9014
9015 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9016 (xftfont_open): Rename locals to avoid shadowing.
9017
9018 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9019 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9020 (OTF_TAG_SYM): Omit macro if not needed.
9021 (ftfont_list): Remove unused local.
9022 (get_adstyle_property, ftfont_pattern_entity):
9023 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9024 Rename locals to avoid shadowing.
9025
9026 * xfont.c (xfont_list_family): Mark var as initialized.
9027
9028 * xml.c (make_dom): Now static.
9029
9030 * composite.c (composition_compute_stop_pos): Rename local to
9031 avoid shadowing.
9032 (composition_reseat_it): Remove unused locals.
9033 (find_automatic_composition, composition_adjust_point): Likewise.
9034 (composition_update_it): Mark var as initialized.
9035 (find_automatic_composition): Mark vars as initialized,
9036 with a FIXME (Bug#8290).
9037
9038 character.h: Rename locals to avoid shadowing.
9039 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9040 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9041 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9042 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9043 to avoid shadowing.
9044
9045 * textprop.c (property_change_between_p): Remove; unused.
9046
9047 * intervals.c (interval_start_pos): Now static.
9048
9049 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9050
9051 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9052 Rename locals to avoid shadowing.
9053
9054 * sound.c (wav_play, au_play, Fplay_sound_internal):
9055 Fix pointer signedness.
9056 (alsa_choose_format): Remove unused local var.
9057 (wav_play): Initialize a variable to 0, to prevent undefined
9058 behavior (Bug#8278).
9059
9060 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9061
9062 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9063
9064 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9065 clobbering (Bug#8298).
9066 * sysdep.c (sys_subshell): Likewise.
9067 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9068
9069 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9070 This should get cleaned up, so that child_setup has the
9071 same signature on all platforms.
9072
9073 * callproc.c (call_process_cleanup): Now static.
9074 (relocate_fd): Rename locals to avoid shadowing.
9075
9076 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9077
9078 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9079 not to be necessary, and produces flickering.
9080
9081 2011-03-20 Glenn Morris <rgm@gnu.org>
9082
9083 * config.in: Remove file.
9084
9085 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9086
9087 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9088 are now in src/globals.h.
9089 (syms_of_minibuf): Remove spurious & from previous change.
9090
9091 2011-03-20 Leo Liu <sdl.web@gmail.com>
9092
9093 * minibuf.c (completing-read-function): New variable.
9094 (completing-read-default): Rename from completing-read.
9095 (completing-read): Call completing-read-function.
9096
9097 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9098
9099 * xfaces.c (Fx_load_color_file):
9100 Read color file from absolute filename (bug#8250).
9101
9102 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9103
9104 * makefile.w32-in: Update dependencies.
9105
9106 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9107
9108 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9109
9110 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9111
9112 Fix more problems found by GCC 4.5.2's static checks.
9113
9114 * process.c (make_serial_process_unwind, send_process_trap):
9115 (sigchld_handler): Now static.
9116
9117 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9118 That way, the code declares only the vars that it needs.
9119 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9120 * s/cygwin.h (PTY_ITERATION): Likewise.
9121 * s/darwin.h (PTY_ITERATION): Likewise.
9122 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9123
9124 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9125 * process.c (allocate_pty): Don't declare stb unless it's needed.
9126
9127 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9128 (CONSTANTLIM): Remove; unused.
9129 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9130 Define only if needed.
9131
9132 * unexelf.c (unexec): Name an expression,
9133 to avoid gcc -Wbad-function-cast warning.
9134 Use a different way to cause a compilation error if anyone uses
9135 n rather than nn, a way that does not involve shadowing.
9136 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9137
9138 * deps.mk (unexalpha.o): Remove; unused.
9139
9140 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9141 * unexec.h: New file.
9142 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9143 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9144 Depend on unexec.h.
9145 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9146 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9147 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9148 Change as necessary to match prototype in unexec.h.
9149
9150 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9151 shadowing.
9152 (back_comment, skip_chars): Mark vars as initialized.
9153
9154 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9155 Rename locals to avoid shadowing.
9156
9157 * lread.c (read1): Rewrite so as not to use empty "else".
9158 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9159
9160 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9161
9162 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9163 warning when compiling print.c.
9164
9165 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9166 instead of using an uninitialized var.
9167 (font_sort_entities): Mark var as initialized.
9168
9169 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9170
9171 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9172 pointers to constants.
9173 (font_parse_fcname): Remove unused vars.
9174 (font_delete_unmatched): Now static.
9175 (font_get_spec): Remove; unused.
9176 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9177 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9178 Rename or move locals to avoid shadowing.
9179
9180 * fns.c (require_nesting_list, require_unwind): Now static.
9181 (Ffillarray): Rename locals to avoid shadowing.
9182
9183 * floatfns.c (domain_error2): Define only if needed.
9184 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9185
9186 * alloc.c (mark_backtrace): Move decl from here ...
9187 * lisp.h: ... to here, so that it can be checked.
9188
9189 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9190 (Fdefvar): Rewrite so as not to use empty "else".
9191 (lisp_indirect_variable): Name an expression,
9192 to avoid gcc -Wbad-function-cast warning.
9193 (Fdefvar): Rename locals to avoid shadowing.
9194
9195 * callint.c (quotify_arg, quotify_args): Now static.
9196 (Fcall_interactively): Rename locals to avoid shadowing.
9197 Use const pointer when appropriate.
9198
9199 * lisp.h (get_system_name, get_operating_system_release):
9200 Move decls here, to check interfaces.
9201 * process.c (get_operating_system_release): Move decl to lisp.h.
9202 * xrdb.c (get_system_name): Likewise.
9203 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9204 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9205 some of which prompt warnings from gcc -Wbad-function-cast.
9206 (Fformat_time_string, Fencode_time, Finsert_char):
9207 (Ftranslate_region_internal, Fformat):
9208 Rename or remove local vars to avoid shadowing.
9209 (Ftranslate_region_internal): Mark var as initialized.
9210
9211 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9212 avoid shadowing.
9213
9214 * lisp.h (eassert): Check that the argument compiles, even if
9215 ENABLE_CHECKING is not defined.
9216
9217 * data.c (Findirect_variable): Name an expression, to avoid
9218 gcc -Wbad-function-cast warning.
9219 (default_value, arithcompare, arith_driver, arith_error): Now static.
9220 (store_symval_forwarding): Rename local to avoid shadowing.
9221 (Fmake_variable_buffer_local, Fmake_local_variable):
9222 Mark variables as initialized.
9223 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9224
9225 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9226 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9227 Rename locals to avoid shadowing.
9228 (mark_stack): Move local variables into the #ifdef region where
9229 they're used.
9230 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9231 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9232 needed otherwise.
9233 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9234 (GC_STRING_CHARS): Remove; not used.
9235 (Fmemory_limit): Cast sbrk's returned value to char *.
9236
9237 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9238 avoids undefined behavior in theory.
9239
9240 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9241
9242 Use functions, not macros, for up- and down-casing (Bug#8254).
9243 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9244 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9245 to use the following functions instead of these macros.
9246 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9247 EMACS_INT, since callers assume the returned value fits in int.
9248 (upcase1): Likewise, for UPCASE_TABLE.
9249 (uppercasep, lowercasep, upcase): New static inline functions.
9250 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9251 the race-condition problem in the old DOWNCASE.
9252
9253 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9254 Rename locals to avoid shadowing.
9255 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9256 (regex_compile, re_search_2, re_match_2_internal):
9257 Remove unused local vars.
9258 (FREE_VAR): Rewrite so as not to use empty "else",
9259 which gcc can warn about.
9260 (regex_compile, re_match_2_internal): Mark locals as initialized.
9261 (RETALLOC_IF): Define only if needed.
9262 (WORDCHAR_P): Likewise. This one is never needed, but is used
9263 only in a comment talking about a compiler bug, so put inside
9264 the #if 0 of that comment.
9265 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9266 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9267 Remove; unused.
9268
9269 * search.c (boyer_moore): Rename locals to avoid shadowing.
9270 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9271 (PREV_CHAR_BOUNDARY): Likewise.
9272
9273 * search.c (simple_search): Remove unused var.
9274
9275 * dired.c (compile_pattern): Move decl from here ...
9276 * lisp.h: ... to here, so that it can be checked.
9277 (struct re_registers): New forward decl.
9278
9279 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9280
9281 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9282 All uses changed.
9283 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9284 Rename locals to avoid shadowing.
9285 (Fvertical_motion): Mark locals as initialized.
9286
9287 * casefiddle.c (casify_object, casify_region): Now static.
9288 (casify_region): Mark local as initialized.
9289
9290 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9291
9292 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9293 New macros, so that the caller can use some names other than
9294 gcpro1, gcpro2, etc.
9295 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9296 of the new macros.
9297 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9298 argument, for consistency with GCPRO2_VAR, etc: it is now the
9299 prefix of the variable, not the variable itself. All uses
9300 changed.
9301 * dired.c (directory_files_internal, file_name_completion):
9302 Rename locals to avoid shadowing.
9303
9304 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9305 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9306 dired.c's scmp function, had undefined behavior.
9307 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9308 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9309 * buffer.h: ... to here, because these macros use current_buffer,
9310 and the new implementation with inline functions needs to have
9311 current_buffer in scope now, rather than later when the macros
9312 are used.
9313 (downcase, upcase1): New static inline functions.
9314 (DOWNCASE, UPCASE1): Reimplement using these functions.
9315 This avoids undefined behavior in expressions like
9316 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9317 from race conditions in accessing the global variables
9318 case_temp1 and case_temp2.
9319 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9320 * lisp.h (case_temp1, case_temp2): Remove their decls.
9321 * character.h (ASCII_CHAR_P): Move from here ...
9322 * lisp.h: ... to here, so that the inline functions mentioned
9323 above can use them.
9324
9325 * dired.c (directory_files_internal_unwind): Now static.
9326
9327 * fileio.c (file_name_as_directory, directory_file_name):
9328 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9329 Now static.
9330 (file_name_as_directory): Use const pointers when appropriate.
9331 (Fexpand_file_name): Likewise. In particular, newdir might
9332 point at constant storage, so make it a const pointer.
9333 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9334 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9335 signedness issues.
9336 (Fset_file_times, Finsert_file_contents, auto_save_error):
9337 Rename locals to avoid shadowing.
9338
9339 * minibuf.c (choose_minibuf_frame_1): Now static.
9340 (Ftry_completion, Fall_completions): Rename or remove locals
9341 to avoid shadowing.
9342
9343 * marker.c (bytepos_to_charpos): Remove; unused.
9344
9345 * lisp.h (verify_bytepos, count_markers): New decls,
9346 so that gcc does not warn that these functions aren't declared.
9347
9348 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9349 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9350 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9351 (copy_text): Remove unused local var.
9352
9353 * filelock.c (within_one_second): Now static.
9354 (lock_file_1): Rename local to avoid shadowing.
9355
9356 * buffer.c (fix_overlays_before): Mark locals as initialized.
9357 (fix_start_end_in_overlays): Likewise. This function should be
9358 simplified by using pointers-to-pointers, but that's a different
9359 matter.
9360 (switch_to_buffer_1): Now static.
9361 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9362 (report_overlay_modification): Rename locals to avoid shadowing.
9363
9364 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9365 Fix pointer signedness issue.
9366 (sys_subshell): Mark local as volatile if checking for lint,
9367 to suppress a gcc -Wclobbered warning that does not seem to be right.
9368 (MAXPATHLEN): Define only if needed.
9369
9370 * process.c (serial_open, serial_configure): Move decls from here ...
9371 * systty.h: ... to here, so that they can be checked.
9372
9373 * fns.c (get_random, seed_random): Move extern decls from here ...
9374 * lisp.h: ... to here, so that they can be checked.
9375
9376 * sysdep.c (reset_io): Now static.
9377 (wait_for_termination_signal): Remove; unused.
9378
9379 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9380 (copy_keymap_item, append_key, push_text_char_description):
9381 Now static.
9382 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9383 (DENSE_TABLE_SIZE): Remove; unused.
9384 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9385 (describe_map_tree):
9386 Rename locals to avoid shadowing.
9387
9388 * keyboard.c: Declare functions static if they are not used elsewhere.
9389 (echo_char, echo_dash, cmd_error, top_level_2):
9390 (poll_for_input, handle_async_input): Now static.
9391 (read_char, kbd_buffer_get_event, make_lispy_position):
9392 (make_lispy_event, make_lispy_movement, apply_modifiers):
9393 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9394 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9395 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9396 (read_key_sequence, read_char): Mark locals as initialized.
9397 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9398
9399 * keyboard.h (make_ctrl_char): New decl.
9400 (mark_kboards): Move decl here ...
9401 * alloc.c (mark_kboards): ... from here.
9402
9403 * lisp.h (force_auto_save_soon): New decl.
9404
9405 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9406 (DEFINE_DUMMY_FUNCTION): New macro.
9407 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9408 Use it.
9409 (main): Add casts to avoid warnings
9410 if GCC considers string literals to be constants.
9411
9412 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9413
9414 * dbusbind.c: Pointer signedness fixes.
9415 (xd_signature, xd_append_arg, xd_initialize):
9416 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9417 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9418 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9419 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9420
9421 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9422 if GCC considers string literals to be constants.
9423 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9424
9425 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9426
9427 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9428 (print_preprocess, print_object): New macro to fix last change.
9429
9430 * print.c (print_preprocess): Don't forget font objects.
9431
9432 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9433
9434 * emacs.c (USAGE3): Doc fixes.
9435
9436 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9437
9438 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9439 structure.
9440
9441 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9442
9443 * lisp.h (VWindow_system, Qfile_name_history):
9444 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9445 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9446 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9447
9448 * w32select.c: Don't #include "keyboard.h".
9449 (run_protected): Add extern declaration for waiting_for_input.
9450
9451 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9452 * w32console.c (detect_input_pending, read_input_pending)
9453 (encode_terminal_code):
9454 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9455 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9456 (w32_system_caret_y, Qfile_name_history):
9457 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9458 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9459 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9460 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9461 * w32proc.c (Qlocal, report_file_error):
9462 * w32term.c (Vwindow_system, updating_frame):
9463 * w32uniscribe.c (initialized, uniscribe_font_driver):
9464 Remove unneeded extern declarations.
9465
9466 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9467
9468 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9469
9470 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9471
9472 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9473 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9474 These macros can no longer be used for assignment.
9475
9476 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9477 Assign struct members directly, instead of using BUF_BEGV etc.
9478 (record_buffer_markers, fetch_buffer_markers): New functions for
9479 recording and fetching special buffer markers.
9480 (set_buffer_internal_1, set_buffer_temp): Use them.
9481
9482 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9483
9484 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9485
9486 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9487 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9488
9489 * xdisp.c (hscroll_window_tree):
9490 (reconsider_clip_changes): Use PT instead of BUF_PT.
9491
9492 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9493
9494 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9495 $(EMACS_ROOT)/lib/intprops.h.
9496
9497 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9498
9499 Fix more problems found by GCC 4.5.2's static checks.
9500
9501 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9502 to unsigned char * to avoid compiler diagnostic.
9503 (xg_free_frame_widgets): Make it clear that a local variable is
9504 needed only if USE_GTK_TOOLTIP.
9505 (gdk_window_get_screen): Make it clear that this macro is needed
9506 only if USE_GTK_TOOLTIP.
9507 (int_gtk_range_get_value): New function, which avoids a diagnostic
9508 from gcc -Wbad-function-cast.
9509 (xg_set_toolkit_scroll_bar_thumb): Use it.
9510 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9511 diagnostic from gcc -Wbad-function-cast.
9512 (get_utf8_string, xg_get_file_with_chooser):
9513 Rename locals to avoid shadowing.
9514 (create_dialog): Move locals to avoid shadowing.
9515
9516 * xgselect.c (xg_select): Remove unused var.
9517
9518 * image.c (four_corners_best): Mark locals as initialized.
9519 (gif_load): Initialize transparent_p to zero (Bug#8238).
9520 Mark another local as initialized.
9521 (my_png_error, my_error_exit): Mark with NO_RETURN.
9522
9523 * image.c (clear_image_cache): Now static.
9524 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9525 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9526 (x_edge_detection): Remove unnecessary cast that
9527 gcc -Wbad-function-cast diagnoses.
9528 (gif_load): Fix pointer signedness.
9529 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9530 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9531
9532 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9533
9534 Improve quality of tests for time stamp overflow.
9535 For example, without this patch (encode-time 0 0 0 1 1
9536 1152921504606846976) returns the obviously-bogus value (-948597
9537 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9538 reports time overflow. See
9539 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9540 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9541 * editfns.c: Include limits.h and intprops.h.
9542 (TIME_T_MIN, TIME_T_MAX): New macros.
9543 (time_overflow): Move earlier, to before first use.
9544 (hi_time, lo_time): New functions, for an accurate test for
9545 out-of-range times.
9546 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9547 (Fget_internal_run_time): Don't assume time_t fits in int.
9548 (make_time): Use list2 instead of Fcons twice.
9549 (Fdecode_time): More accurate test for out-of-range times.
9550 (check_tm_member): New function.
9551 (Fencode_time): Use it, to test for out-of-range times.
9552 (lisp_time_argument): Don't rely on undefined left-shift and
9553 right-shift behavior when checking for time stamp overflow.
9554
9555 * editfns.c (time_overflow): New function, refactoring common code.
9556 (Fformat_time_string, Fdecode_time, Fencode_time):
9557 (Fcurrent_time_string): Use it.
9558
9559 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9560 * dired.c (make_time): Move to ...
9561 * editfns.c (make_time): ... here.
9562 * systime.h: Note the move.
9563
9564 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9565
9566 * fringe.c (update_window_fringes): Remove unused variables.
9567
9568 * unexmacosx.c (copy_data_segment): Also copy __got section.
9569 (Bug#8223)
9570
9571 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9572
9573 * termcap.c [MSDOS]: Include "msdos.h".
9574 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9575 Constify `char *' arguments and their references according to
9576 prototypes in tparam.h.
9577
9578 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9579
9580 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9581 Adapt all references accordingly.
9582
9583 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9584
9585 2011-03-11 Tom Tromey <tromey@redhat.com>
9586
9587 * buffer.c (syms_of_buffer): Remove obsolete comment.
9588
9589 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9590
9591 * termhooks.h (encode_terminal_code): Declare prototype.
9592
9593 * msdos.c (encode_terminal_code): Don't declare prototype.
9594
9595 * term.c (encode_terminal_code): Now external again, used by
9596 w32console.c and msdos.c.
9597
9598 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9599 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9600
9601 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9602
9603 Fix some minor problems found by GCC 4.5.2's static checks.
9604
9605 * fringe.c (update_window_fringes): Mark locals as initialized
9606 (Bug#8227).
9607 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9608
9609 * alloc.c (mark_fringe_data): Move decl from here ...
9610 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9611 to check its interface.
9612 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9613
9614 * fontset.c (free_realized_fontset): Now static.
9615 (Fset_fontset_font): Rename local to avoid shadowing.
9616 (fontset_font): Mark local as initialized.
9617 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9618
9619 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9620
9621 * xselect.c (x_disown_buffer_selections): Remove; not used.
9622 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9623 (x_own_selection, Fx_disown_selection_internal): Rename locals
9624 to avoid shadowing.
9625 (x_handle_dnd_message): Remove local to avoid shadowing.
9626
9627 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9628 so that the caller can use some name other than gcpro1.
9629 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9630 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9631 (Fx_backspace_delete_keys_p):
9632 Use them to avoid shadowing, and rename vars to avoid shadowing.
9633 (x_decode_color, x_set_name, x_window): Now static.
9634 (Fx_create_frame): Add braces to silence GCC warning.
9635 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9636 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9637 Remove unused locals.
9638 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9639 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9640 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9641 macros.
9642
9643 * xterm.h (x_mouse_leave): New decl.
9644
9645 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9646 Remove unused functions.
9647 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9648 (x_calc_absolute_position): Now static.
9649 (XTread_socket): Don't define label "out" unless it's used.
9650 Don't declare local "event" unless it's used.
9651 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9652 unless they are used.
9653 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9654 (x_fatal_error_signal): Remove; not used.
9655 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9656 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9657 (x_error_catcher, x_connection_closed, x_error_handler):
9658 (x_error_quitter, xembed_send_message, x_iconify_frame):
9659 (my_log_handler): Rename locals to avoid shadowing.
9660 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9661 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9662
9663 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9664 Rename or move locals to avoid shadowing.
9665 (tty_defined_color, merge_face_heights): Now static.
9666 (free_realized_faces_for_fontset): Remove; not used.
9667 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9668 does not deduce is never used uninitialized.
9669 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9670 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9671
9672 * terminal.c (store_terminal_param): Now static.
9673
9674 * xmenu.c (menu_highlight_callback): Now static.
9675 (set_frame_menubar): Remove unused local.
9676 (xmenu_show): Rename parameter to avoid shadowing.
9677 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9678 since they might point to immutable storage.
9679 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9680 since it's unused otherwise.
9681
9682 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9683 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9684 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9685 avoids a gcc -Wuninitialized diagnostic.
9686 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9687 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9688 does not deduce are never used uninitialized.
9689
9690 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9691
9692 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9693 * window.c (window_loop, size_window):
9694 (run_window_configuration_change_hook, enlarge_window): Likewise.
9695
9696 * window.c (display_buffer): Now static.
9697 (size_window): Mark variables that gcc -Wuninitialized
9698 does not deduce are never used uninitialized.
9699 * window.h (check_all_windows): New decl, to forestall
9700 gcc -Wmissing-prototypes diagnostic.
9701 * dispextern.h (bidi_dump_cached_states): Likewise.
9702
9703 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9704 shadowing.
9705 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9706 Include <limits.h>.
9707 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9708 and to avoid gcc -Wuninitialized warning.
9709 (load_charset_map): Mark variables that gcc -Wuninitialized
9710 does not deduce are never used uninitialized.
9711 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9712
9713 * coding.c (coding_set_source, coding_set_destination):
9714 Use "else { /* comment */ }" rather than "else /* comment */;"
9715 for clarity, and to avoid gcc -Wempty-body warning.
9716 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9717 a block, when the outer 'i' will do.
9718 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9719 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9720 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9721 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9722 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9723 Rename locals to avoid shadowing.
9724 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9725 * coding.c (emacs_mule_char, encode_invocation_designation):
9726 Now static, since they're not used elsewhere.
9727 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9728 (decode_coding_object, encode_coding_object, detect_coding_system):
9729 (decode_coding_emacs_mule): Mark variables that gcc
9730 -Wuninitialized does not deduce are never used uninitialized.
9731 (detect_coding_iso_2022): Initialize a local variable that might
9732 be used uninitialized. Leave a FIXME because it's not clear that
9733 this initialization is needed. (Bug#8211)
9734 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9735 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9736 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9737 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9738 Remove unused macros.
9739
9740 * category.c (hash_get_category_set): Remove unused local var.
9741 (copy_category_table): Now static, since it's not used elsewhere.
9742 * character.c (string_count_byte8): Likewise.
9743
9744 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9745 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9746
9747 * chartab.c (copy_sub_char_table): Now static, since it's not used
9748 elsewhere.
9749 (sub_char_table_ref_and_range, char_table_ref_and_range):
9750 Rename locals to avoid shadowing.
9751 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9752
9753 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9754 (BIDI_BOB): Remove unused macro.
9755
9756 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9757 deduce are never used uninitialized.
9758 * term.c (encode_terminal_code): Likewise.
9759
9760 * term.c (encode_terminal_code): Now static. Remove unused local.
9761
9762 * tparam.h: New file.
9763 * term.c, tparam.h: Include it.
9764 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9765 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9766 Move these decls to tparam.h, and make them agree with what
9767 is actually in tparam.c. The previous trick of using incompatible
9768 decls in different modules does not conform to the C standard.
9769 All callers of tparam changed to use tparam's actual API.
9770 * tparam.c (tparam1, tparam, tgoto):
9771 Use const pointers where appropriate.
9772
9773 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9774 * cm.h (struct cm): Likewise.
9775 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9776 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9777 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9778 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9779 (turn_on_face, init_tty): Likewise.
9780 * termchar.h (struct tty_display_info): Likewise.
9781
9782 * term.c (term_mouse_position): Rename local to avoid shadowing.
9783
9784 * alloc.c (mark_ttys): Move decl from here ...
9785 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9786
9787 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9788
9789 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9790
9791 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9792
9793 * search.c (compile_pattern_1): Remove argument regp, unused since
9794 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9795 (compile_pattern): Don't pass it.
9796
9797 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9798
9799 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9800 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9801 for ! HAVE_GTK3.
9802 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9803
9804 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9805
9806 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9807 gdk_window_get_screen, gdk_window_get_geometry,
9808 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9809 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9810 (xg_get_pixbuf_from_pixmap): New function.
9811 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9812 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9813 Call xg_get_pixbuf_from_pixmap instead of
9814 gdk_pixbuf_get_from_drawable.
9815 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9816 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9817 (xg_check_special_colors): Use GtkStyleContext and its functions
9818 for HAVE_GTK3.
9819 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9820 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9821 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9822 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9823 Call gtk_widget_get_preferred_size.
9824 (xg_frame_resized): gdk_window_get_geometry only takes 5
9825 parameters.
9826 (xg_win_to_widget, xg_event_is_for_menubar):
9827 Call gdk_x11_window_lookup_for_display.
9828 (xg_set_widget_bg): New function.
9829 (delete_cb): New function.
9830 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9831 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9832 (xg_set_background_color): Call xg_set_widget_bg.
9833 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9834 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9835 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9836 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9837 if ! HAVE_GTK3.
9838 (update_frame_tool_bar): Call gtk_widget_hide.
9839 (xg_initialize): Use GDK_KEY_g.
9840
9841 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9842 if ! HAVE_GTK3
9843 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9844
9845 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9846 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9847 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9848
9849 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9850
9851 * w32xfns.c (select_palette): Check success of RealizePalette against
9852 GDI_ERROR, not zero.
9853
9854 See ChangeLog.11 for earlier changes.
9855
9856 ;; Local Variables:
9857 ;; coding: utf-8
9858 ;; End:
9859
9860 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9861
9862 This file is part of GNU Emacs.
9863
9864 GNU Emacs is free software: you can redistribute it and/or modify
9865 it under the terms of the GNU General Public License as published by
9866 the Free Software Foundation, either version 3 of the License, or
9867 (at your option) any later version.
9868
9869 GNU Emacs is distributed in the hope that it will be useful,
9870 but WITHOUT ANY WARRANTY; without even the implied warranty of
9871 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9872 GNU General Public License for more details.
9873
9874 You should have received a copy of the GNU General Public License
9875 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.