1 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
3 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
4 dbus_type_is_basic if available.
5 (xd_extract_signed, xd_extract_unsigned): Rename from
6 extract_signed and extract_unsigned, respectively. Adapt callers.
8 2012-06-09 Chong Yidong <cyd@gnu.org>
10 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
12 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
15 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
17 * xdisp.c (vmessage): Treat frame message as multibyte.
18 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
19 would generate the diagnostic "Making \302\247 buffer-local while
22 2012-06-08 Eli Zaretskii <eliz@gnu.org>
24 * dispnew.c (showing_window_margins_p): Undo last change, which
25 was done due to an inadvertent commit.
26 (adjust_frame_glyphs_for_frame_redisplay): Do call
27 showing_window_margins_p.
29 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
31 * eval.c (Fmake_var_non_special): New primitive.
32 (syms_of_eval): Defsubr it.
33 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
35 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
37 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
38 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
40 2012-06-08 Eli Zaretskii <eliz@gnu.org>
42 * alloc.c (allocate_vectorlike): Fix last change.
44 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
46 Block-based vector allocation of small vectors.
47 * lisp.h (struct vectorlike_header): New field `nbytes',
48 adjust comment accordingly.
49 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
50 to denote vector blocks. Adjust users (live_vector_p,
51 mark_maybe_pointer, valid_lisp_object_p) accordingly.
52 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
53 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
54 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
55 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
56 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
57 (roundup_size): New constant.
58 (struct vector_block): New data type.
59 (vector_blocks, vector_free_lists, zero_vector): New variables.
60 (all_vectors): Rename to `large_vectors'.
61 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
62 (sweep_vectors): New functions.
63 (allocate_vectorlike): Return `zero_vector' as the only vector of
64 0 items. Allocate new vector from block if vector size is less than
65 or equal to VBLOCK_BYTES_MAX.
66 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
67 (init_alloc_once): Add call to init_vectors.
69 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
71 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
73 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
75 * doprnt.c (doprnt): Truncate multibyte char correctly.
76 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
77 would mishandle a string argument "Xc" if X was a multibyte
78 character of length 2: it would truncate after X's first byte
79 rather than including all of X.
81 2012-06-06 Chong Yidong <cyd@gnu.org>
83 * buffer.c (word_wrap): Doc fix.
85 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
87 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
89 2012-06-03 Glenn Morris <rgm@gnu.org>
91 * xdisp.c (tool-bar-style): Doc fix.
93 2012-06-03 Ulrich Müller <ulm@gentoo.org>
95 * Makefile.in (PAXCTL): Define.
96 (temacs$(EXEEXT)): Disable memory randomization for the temacs
97 binary via PaX flags if the paxctl utility is available.
98 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
99 Restore PaX flags to their default. (Bug#11398)
101 2012-06-03 Chong Yidong <cyd@gnu.org>
103 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
106 2012-06-03 Chong Yidong <cyd@gnu.org>
108 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
109 (note_mode_line_or_margin_highlight): If there is no help echo,
110 use mode-line-default-help-echo. Handle the case where the mouse
111 position is past the end of the mode line string.
113 * buffer.c (buffer_local_value_1): New function, split from
114 Fbuffer_local_value; can return Qunbound.
115 (Fbuffer_local_value): Use it.
116 (Vmode_line_format): Docstring tweaks.
118 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
120 * sysdep.c (system_process_attributes): Improve comment.
122 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
124 * keyboard.c: Export real-this-command to Elisp.
125 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
126 and DEFVAR it. Update all users.
128 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
130 * minibuf.c (Fassoc_string): Remove duplicate declaration.
132 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
133 Convert pctcpu and pctmem to Lisp float properly.
134 Let the compiler fold better, as 100.0/0x8000 is exact.
136 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
138 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
141 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
143 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
145 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
147 For a 'struct window', replace some Lisp_Object fields to
148 bitfields where appropriate, remove unused fields.
149 * window.h (struct window): Remove unused 'last_mark_x' and
150 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
151 change it's type from Lisp_Object to bitfield.
152 Change type of 'force_start', 'optional_new_start',
153 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
154 fields from Lisp_Object to bitfield. Adjust users accordingly.
156 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
158 Pacify gcc -Wdouble-precision when using Xaw.
159 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
160 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
161 Use 'float' consistently, rather than 'float' in most places
162 and 'double' in a couple of places.
164 2012-05-31 Eli Zaretskii <eliz@gnu.org>
166 * xdisp.c (handle_stop): Detect whether we have overlay strings
167 loaded by testing it->current.overlay_string_index to be
168 non-negative, instead of checking whether n_overlay_strings is
169 positive. (Bug#11587)
171 2012-05-31 Chong Yidong <cyd@gnu.org>
173 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
175 * doc.c (Fsubstitute_command_keys): Doc fix.
177 2012-05-31 Eli Zaretskii <eliz@gnu.org>
179 * search.c (search_buffer): Remove calls to
180 r_alloc_inhibit_buffer_relocation, as it is now called by
181 maybe_unify_char, which was the cause of relocation of buffer text
184 2012-05-31 Eli Zaretskii <eliz@gnu.org>
186 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
187 for the duration of call to load_charset, to avoid problems with
188 callers of maybe_unify_char that access buffer text through C
191 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
192 decrement the inhibition flag, instead of just setting or
195 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
197 Remove obsolete '#define static' cruft.
198 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
199 This #undef was "temporary" in 2000; it is no longer needed
200 now that '#define static' has gone away.
201 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
202 (gray_bitmap_bits): Remove; no longer needed.
203 All uses replaced with definiens.
204 * xterm.c: Include "bitmaps/gray.xbm".
206 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
208 Clean up __executable_start, monstartup when --enable-profiling.
209 The following changes affect the code only when profiling.
210 * dispnew.c (__executable_start): Rename from safe_bcopy.
211 Define only on platforms that need it.
212 * emacs.c: Include <sys/gmon.h> when profiling.
213 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
214 (__executable_start): Remove decl, since lisp.h does it now.
215 (safe_bcopy): Remove decl; no longer has that name.
216 (main): Coalesce #if into single bit of code, for simplicity.
217 Cast pointers to uintptr_t, since standard libraries want integers
219 * lisp.h (__executable_start): New decl.
221 2012-05-31 Glenn Morris <rgm@gnu.org>
223 * image.c (Fimagemagick_types): Doc fix.
225 2012-05-30 Jim Meyering <meyering@redhat.com>
227 * callproc.c (Fcall_process_region): Include directory component
228 in mkstemp error message (Bug#11586).
230 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
232 * alloc.c, lisp.h (make_pure_vector): Now static.
234 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
236 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
238 (Fautoload): Do the hash-doc more carefully.
239 * data.c (Fdefalias): Purify definition, except for keymaps.
240 (Qdefun): Move from eval.c.
241 * lisp.h (Qdefun): Remove.
242 * lread.c (read1): Tiny simplification.
244 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
246 Do not create empty overlays with the evaporate property (Bug#9642).
247 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
248 Bug#9642, but explicitly check that the buffer the overlay would
249 be moved to is live and rearrange lines to make sure that errors
250 will not put the overlay in an inconsistent state.
251 (Fdelete_overlay): Cosmetics.
253 2012-05-28 Eli Zaretskii <eliz@gnu.org>
255 * w32term.c (my_bring_window_to_top): New function.
256 (x_raise_frame): Use handle returned by DeferWindowPos, which
257 could be different from the original one.
258 Call my_bring_window_to_top instead of my_set_foreground_window.
261 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
262 by calling BringWindowToTop.
264 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
265 (WM_EMACS_END): Increase by one.
267 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
269 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
270 This avoids undefined behavior that might cause the eassert
271 to not catch an out-of-range value.
273 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
275 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
278 2012-05-27 Eli Zaretskii <eliz@gnu.org>
280 * bidi.c (bidi_mirror_char): Fix last change.
282 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
284 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
285 when referring to sectname field in printf format.
287 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
289 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
290 Only r_alloc_inhibit_buffer_relocation needed to be added;
291 the others were already declared.
293 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
294 before checking whether it's out of range. Put the check inside
296 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
298 2012-05-27 Ken Brown <kbrown@cornell.edu>
300 * callproc.c (Fcall_process): Restore a line that was accidentally
301 commented out in the 2011-02-13 change (bug#11547).
303 2012-05-27 Eli Zaretskii <eliz@gnu.org>
305 * lisp.h [REL_ALLOC]: Add prototypes for external functions
308 * buffer.c [REL_ALLOC]: Remove prototypes of
309 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
310 they are now on lisp.h.
312 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
314 * search.c (search_buffer): Use it to inhibit relocation of buffer
315 text while re_search_2 is doing its job, because re_search_2 is
316 passed C pointers to buffer text. (Bug#11519)
318 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
321 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
322 state after an additional call to move_it_in_display_line_to, keep
323 the values of it->max_ascent and it->max_descent found for the
325 (pos_visible_p): Revert the comparison against bottom_y to what it
326 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
329 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
331 Fix coding-related core dumps with gcc -ftrapv.
332 The code was computing A - B, where A and B are pointers, and B is
333 random garbage. This can lead to core dumps on platforms that
334 have special pointer registers, and it also leads to core dumps on
335 x86-64 when compiled with gcc -ftrapv. The fix is to compute
336 A - B only when B is initialized properly.
337 * coding.c (coding_set_source, coding_set_destination): Return void.
338 (coding_change_source, coding_change_destinations): New functions,
339 with the old behaviors of coding_set_source and coding_set_destination.
340 All callers that need an offset changed to use these new functions.
342 2012-05-26 Glenn Morris <rgm@gnu.org>
344 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
346 2012-05-26 Eli Zaretskii <eliz@gnu.org>
348 Extend mouse support on W32 text-mode console.
349 * xdisp.c (draw_row_with_mouse_face):
350 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
352 * w32console.c: Include window.h.
353 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
355 (initialize_w32_display): Initialize mouse-highlight data.
357 * w32inevt.c: Include termchar.h and window.h.
358 (do_mouse_event): Support mouse-autoselect-window. When the mouse
359 moves, call note_mouse_highlight. If help_echo changed, call
360 gen_help_event to produce help-echo message in the echo area.
361 Call clear_mouse_face if mouse_face_hidden is set in the mouse
364 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
366 * lread.c (read1): Simplify slightly to avoid an overflow warning
367 with GCC 4.7.0 on x86-64.
369 2012-05-26 Eli Zaretskii <eliz@gnu.org>
371 * bidi.c (bidi_mirror_char): Revert last change: an int is
372 definitely wide enough here.
374 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
376 Fix integer width and related bugs (Bug#9874).
377 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
378 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
379 (string_bytes, check_sblock, allocate_string_data):
380 (compact_small_strings, Fmake_bool_vector, make_string)
381 (make_unibyte_string, make_multibyte_string)
382 (make_string_from_bytes, make_specified_string)
383 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
384 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
386 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
387 (allocate_pseudovector):
388 Use int, not EMACS_INT, where int is wide enough.
389 (inhibit_garbage_collection, Fgarbage_collect):
390 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
391 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
392 int might not be wide enough.
393 (bidi_cache_search, bidi_cache_find, bidi_init_it)
394 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
395 (bidi_at_paragraph_end, bidi_find_paragraph_start)
396 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
397 (bidi_level_of_next_char, bidi_move_to_visually_next):
398 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
399 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
400 (Fkill_buffer, Fset_buffer_major_mode)
401 (advance_to_char_boundary, Fbuffer_swap_text)
402 (Fset_buffer_multibyte, overlays_at, overlays_in)
403 (overlay_touches_p, struct sortvec, record_overlay_string)
404 (overlay_strings, recenter_overlay_lists)
405 (adjust_overlays_for_insert, adjust_overlays_for_delete)
406 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
407 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
408 (Foverlay_recenter, last_overlay_modification_hooks_used)
409 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
410 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
411 (validate_region): Omit unnecessary test for b <= e,
412 since that's guaranteed by the previous test.
413 (adjust_overlays_for_delete): Avoid pos + length overflow.
414 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
415 (report_overlay_modification):
416 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
417 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
418 Omit pointer cast, which isn't needed anyway, and doesn't work
419 after the EMACS_INT -> ptrdiff_t change.
420 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
421 * buffer.h: Adjust decls to match defn changes elsewhere.
422 (struct buffer_text, struct buffer):
423 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
424 Use EMACS_INT, not int, where int might not be wide enough.
425 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
426 not int, to avoid needless 32-bit limit on 64-bit hosts.
427 (exec_byte_code): Use tighter memory-full test, one that checks
428 for alloca overflow. Don't compute the address of the object just
429 before an array, as that's not portable. Use EMACS_INT, not
430 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
431 * callint.c (Fcall_interactively):
432 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
433 * callproc.c (call_process_kill, Fcall_process):
434 Don't assume pid_t fits into an Emacs fixnum.
435 (call_process_cleanup, Fcall_process, child_setup):
436 Don't assume pid_t fits into int.
437 (call_process_cleanup, Fcall_process, delete_temp_file)
438 (Fcall_process_region):
439 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
440 (Fcall_process): Simplify handling of volatile integers.
441 Use int, not EMACS_INT, where int will do.
442 * casefiddle.c (casify_object, casify_region, operate_on_word)
443 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
444 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
445 (casify_object): Avoid integer overflow when overallocating buffer.
446 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
447 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
448 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
449 * category.h (CATEGORYP): Don't assume arg is nonnegative.
450 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
451 integers are now checked earlier. All uses replaced with XINT.
453 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
454 For CCL_MapSingle, check that content and value are in int range.
455 (ccl_driver, Fregister_code_conversion_map):
456 Check that Vcode_version_map_vector is a vector.
457 (resolve_symbol_ccl_program): Check that vector header is in range.
458 Always copy the vector, so that we can check its contents reliably
459 now rather than having to recheck each instruction as it's being
460 executed. Check that vector words fit in 'int'.
461 (ccl_get_compiled_code, Fregister_ccl_program)
462 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
463 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
464 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
465 contents are in range.
466 (Fccl_execute_on_string): Check that status is in range.
467 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
468 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
469 Accept and return EMACS_INT, not int, because callers can pass values
471 (c_string_width, strwidth, lisp_string_width, chars_in_text)
472 (multibyte_chars_in_text, parse_str_as_multibyte)
473 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
474 (str_as_unibyte, str_to_unibyte, string_count_byte8)
475 (string_escape_byte8, Fget_byte):
476 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
477 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
478 avoid mishandling large integers.
479 * character.h: Adjust decls to match defn changes elsewhere.
480 * charset.c (load_charset_map_from_file, find_charsets_in_text)
481 (Ffind_charset_region):
482 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
483 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
484 (load_charset_map_from_vector, Fdefine_charset_internal):
485 Don't assume fixnum fits in int.
486 (load_charset_map_from_vector, Fmap_charset_chars):
487 Remove now-unnecessary CHECK_NATNUMs.
488 (Fdefine_charset_internal): Check ranges here, more carefully.
489 Don't rely on undefined behavior with signed left shift overflow.
490 Don't assume unsigned int fits into fixnum, or that fixnum fits
491 into unsigned int. Don't require max_code to be a valid fixnum;
492 that's not true for gb10830 4-byte on a 32-bit host. Allow
493 invalid_code to be a cons, for the same reason. Require code_offset
494 to be a character. Avoid int overflow if max_char is close
496 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
497 this is intended anyway and avoids some undefined behavior.
498 (load_charset_map): Pass unsigned, not int, as 2nd arg of
499 INDEX_TO_CODE_POINT, as that's what it expects.
500 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
501 * charset.h (DECODE_CHAR): Return int, not unsigned;
502 this is what was intended anyway, and it avoids undefined behavior.
503 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
504 integer-overflow issues.
505 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
506 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
507 where the argument is EMACS_INT, and this behavior is not intended.
508 * chartab.c (Fmake_char_table, Fset_char_table_range)
509 (uniprop_get_decoder, uniprop_get_encoder):
510 Don't assume fixnum fits in int.
511 * cmds.c (move_point): New function, that does the gist of
512 Fforward_char and Fbackward_char, but does so while checking
513 for integer overflow more accurately.
514 (Fforward_char, Fbackward_char): Use it.
515 (Fforward_line, Fend_of_line, internal_self_insert)
516 (internal_self_insert):
517 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
518 Fix a FIXME, by checking for integer overflow when calculating
519 target_clm and actual_clm.
520 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
521 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
522 (ASSURE_DESTINATION, coding_alloc_by_realloc)
523 (coding_alloc_by_making_gap, alloc_destination)
524 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
525 (encode_coding_utf_16, detect_coding_emacs_mule)
526 (decode_coding_emacs_mule, encode_coding_emacs_mule)
527 (detect_coding_iso_2022, decode_coding_iso_2022)
528 (encode_invocation_designation, encode_designation_at_bol)
529 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
530 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
531 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
532 (encode_coding_ccl, encode_coding_raw_text)
533 (detect_coding_charset, decode_coding_charset)
534 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
535 (produce_composition, produce_charset, produce_annotation)
536 (decode_coding, handle_composition_annotation)
537 (handle_charset_annotation, consume_chars, decode_coding_gap)
538 (decode_coding_object, encode_coding_object, detect_coding_system)
539 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
540 (code_convert_region, code_convert_string)
541 (Fdefine_coding_system_internal)
542 (coding_set_source, coding_set_destination):
543 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
544 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
545 (Fdefine_coding_system_internal):
546 Don't assume fixnums fit in int.
547 (decode_coding_gap, decode_coding_object, encode_coding_object)
548 (Fread_coding_system, Fdetect_coding_region)
549 (Funencodable_char_position, Fcheck_coding_systems_region)
550 (get_translation, handle_composition_annotation, consume_chars):
551 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
552 (consume_chars): Rewrite to not calculate an address outside buffer.
553 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
554 Don't access memory outside of the args array.
555 (Fdefine_coding_system_internal): Check for charset-id overflow.
556 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
557 result of ENCODE_CHAR.
558 * coding.h: Adjust decls to match defn changes elsewhere.
559 (struct coding_system):
560 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
561 * composite.c (get_composition_id, find_composition)
562 (run_composition_function, update_compositions)
563 (compose_text, composition_gstring_put_cache)
564 (composition_gstring_p, composition_gstring_width)
565 (fill_gstring_header, fill_gstring_body, autocmp_chars)
566 (composition_compute_stop_pos, composition_reseat_it)
567 (composition_update_it, struct position_record)
568 (find_automatic_composition, composition_adjust_point)
569 (Fcomposition_get_gstring, Ffind_composition_internal):
570 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
571 (update_compositions):
572 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
573 * composite.h: Adjust decls to match defn changes elsewhere.
574 (struct composition):
575 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
576 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
577 Do not attempt to compute the address of the object just before a
578 buffer; this is not portable.
580 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
581 (Faset): Use int, not EMACS_INT, where int is wide enough.
582 (Fstring_to_number): Don't assume fixnums fit in int.
583 (Frem): Don't assume arg is nonnegative.
584 * dbusbind.c (xd_append_arg): Check for integers out of range.
585 (Fdbus_call_method): Don't overflow the timeout int.
586 (extract_signed, extract_unsigned): New functions.
587 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
588 (xd_get_connection_references): Return ptrdiff_t, not int.
590 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
592 Use int, not unsigned, where the dbus API uses int.
593 (Fdbus_message_internal): Don't overflow mtype.
594 (syms_of_dbusbind): Allocate right-sized buffer for integers.
595 * dired.c (directory_files_internal, file_name_completion, scmp)
596 (file_name_completion_stat):
597 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
598 (file_name_completion): Don't overflow matchcount.
599 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
600 * dispextern.h: Adjust decls to match defn changes elsewhere.
601 (struct text_pos, struct glyph, struct bidi_saved_info)
602 (struct bidi_string_data, struct bidi_it, struct composition_it)
604 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
605 (struct display_pos, struct composition_it, struct it):
606 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
607 * dispnew.c (increment_matrix_positions)
608 (increment_row_positions, mode_line_string)
609 (marginal_area_string):
610 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
611 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
612 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
613 (duration_to_sec_usec): New function, to check for overflow better.
614 (Fsleep_for, sit_for): Use it.
615 * doc.c (get_doc_string, store_function_docstring):
616 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
617 (get_doc_string, Fsnarf_documentation):
618 Use int, not EMACS_INT, where int is wide enough.
620 Use SAFE_ALLOCA, not alloca.
621 Check for overflow when converting EMACS_INT to off_t.
623 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
624 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
625 Don't assume uid_t fits into fixnum.
626 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
627 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
628 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
629 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
630 (general_insert_function)
631 (Finsert_char, make_buffer_string, make_buffer_string_both)
632 (update_buffer_properties, Fbuffer_substring)
633 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
634 (Fsubst_char_in_region, check_translation)
635 (Ftranslate_region_internal, save_restriction_restore, Fformat)
636 (transpose_markers, Ftranspose_regions):
637 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
638 (clip_to_bounds): Move to lisp.h as an inline function).
639 (Fconstrain_to_field): Don't assume integers are nonnegative.
640 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
641 (Fsubst_char_in_region, Fsave_restriction):
642 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
643 (Femacs_pid): Don't assume pid_t fits into fixnum.
644 (lo_time): Use int, not EMACS_INT, when int suffices.
645 (lisp_time_argument): Check for usec out of range.
646 (Fencode_time): Don't assume fixnum fits in int.
647 (Fuser_login_name, Fuser_full_name): Signal an error
648 if a uid argument is out of range, rather than relying on
650 (Fformat_time_string): Remove now-unnecessary check.
651 lisp_time_argument checks for out-of-range usec now.
652 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
653 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
654 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
655 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
656 (init_cmdargs, Fdump_emacs):
657 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
658 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
659 the bottom (typically) 32 bits of the fixnum.
660 * eval.c (specpdl_size, call_debugger):
661 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
662 (when_entered_debugger, Fbacktrace_debug):
663 Don't assume fixnum can fit in int.
664 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
665 the object just before a buffer; this is not portable.
666 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
667 (grow_specpdl, unbind_to):
668 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
669 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
670 (grow_specpdl): Simplify allocation by using xpalloc.
671 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
672 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
673 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
674 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
675 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
677 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
678 (Fcopy_file, non_regular_nbytes, read_non_regular)
679 (Finsert_file_contents):
680 Use int, not EMACS_INT, where int is wide enough.
681 (READ_BUF_SIZE): Verify that it fits in int.
682 (Finsert_file_contents): Check that counts are in proper range,
683 rather than assuming fixnums fit into ptrdiff_t etc.
684 Don't assume fixnums fit into int.
685 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
686 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
687 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
688 (string_char_to_byte, string_byte_to_char)
689 (string_make_multibyte, string_to_multibyte)
690 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
691 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
692 (substring_both, Fdelete, internal_equal, Ffillarray)
693 (Fclear_string, mapcar1)
694 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
695 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
696 (larger_vector, make_hash_table, maybe_resize_hash_table)
697 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
698 (Fmaphash, secure_hash):
699 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
700 (concat): Check for string index and length overflow.
701 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
703 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
704 (larger_vector): New API (vec, incr_min, size_max) replaces old
705 one (vec, new_size, init). This catches size overflow.
706 INIT was removed because it was always Qnil.
708 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
709 the upper bound on a hash table index size.
710 (make_hash_table, maybe_resize_hash_table): Use it.
711 (secure_hash): Computer start_byte and end_byte only after
712 they're known to be in ptrdiff_t range.
713 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
714 (Ffont_get_glyphs, Ffont_at):
715 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
716 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
717 (Flist_fonts, Fopen_font):
718 Don't assume fixnum can fit in int.
719 (check_gstring): Don't assume index can fit in int.
720 (font_match_p): Check that fixnum is a character, not a nonnegative
721 fixnum, since the later code needs to stuff it into an int.
722 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
723 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
724 conversion overflow issues.
725 (Fopen_font): Check for integer out of range.
726 (Ffont_get_glyphs): Don't assume index can fit in int.
727 * font.h: Adjust decls to match defn changes elsewhere.
728 * fontset.c (reorder_font_vector): Redo score calculation to avoid
730 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
731 printmax_t, where ptrdiff_t is wide enough.
732 (Finternal_char_font):
733 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
734 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
735 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
736 (Fset_frame_position, x_set_frame_parameters)
737 (x_set_line_spacing, x_set_border_width)
738 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
739 Check that fixnums are in proper range for system types.
740 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
741 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
742 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
743 Use SAFE_ALLOCA_LISP, not alloca.
744 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
745 intptr_t is wide enough.
746 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
747 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
748 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
749 Check for fixnum out of range.
750 * ftfont.c (ftfont_list): Don't assume index fits in int.
751 Check that fixnums are in proper range for system types.
752 (ftfont_shape_by_flt):
753 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
754 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
755 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
756 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
757 Check that fixnums are in proper range for system types.
758 * gnutls.h: Adjust decls to match defn changes elsewhere.
759 * gtkutil.c (xg_dialog_run):
760 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
761 (update_frame_tool_bar):
762 Check that fixnums are in proper range for system types.
763 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
764 (lookup_image): Check that fixnums are in range for system types.
765 * indent.c (last_known_column, last_known_column_point):
766 (current_column_bol_cache):
767 (skip_invisible, current_column, check_display_width):
768 (check_display_width, scan_for_column, current_column_1)
769 (Findent_to, Fcurrent_indentation, position_indentation)
770 (indented_beyond_p, Fmove_to_column, compute_motion):
771 (Fcompute_motion, Fvertical_motion):
772 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
773 (last_known_column_modified): Use EMACS_INT, not int.
774 (check_display_width):
776 Check that fixnums and floats are in proper range for system types.
777 (compute_motion): Don't assume index or fixnum fits in int.
778 (compute_motion, Fcompute_motion):
779 Use int, not EMACS_INT, when it is wide enough.
780 (vmotion): Omit local var start_hpos that is always 0; that way
781 we don't need to worry about overflow in expressions involving it.
782 * indent.h: Adjust decls to match defn changes elsewhere.
784 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
785 Use int, not EMACS_INT, where int is wide enough.
786 Remove unused members ovstring_chars_done and tab_offset;
788 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
789 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
790 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
791 (make_gap, copy_text, insert, insert_and_inherit)
792 (insert_before_markers, insert_before_markers_and_inherit)
793 (insert_1, count_combining_before, count_combining_after)
794 (insert_1_both, insert_from_string)
795 (insert_from_string_before_markers, insert_from_string_1)
796 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
797 (adjust_after_replace, adjust_after_insert, replace_range)
798 (replace_range_2, del_range, del_range_1, del_range_byte)
799 (del_range_both, del_range_2, modify_region)
800 (prepare_to_modify_buffer, signal_before_change)
801 (signal_after_change, Fcombine_after_change_execute):
802 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
803 * intervals.c (traverse_intervals, rotate_right, rotate_left)
804 (balance_an_interval, split_interval_right, split_interval_left)
805 (find_interval, next_interval, update_interval)
806 (adjust_intervals_for_insertion, delete_node, delete_interval)
807 (interval_deletion_adjustment, adjust_intervals_for_deletion)
808 (static_offset_intervals, offset_intervals)
809 (merge_interval_right, merge_interval_left, make_new_interval)
810 (graft_intervals_into_buffer, temp_set_point_both)
811 (temp_set_point, set_point, adjust_for_invis_intang)
812 (set_point_both, move_if_not_intangible, get_property_and_range)
813 (get_local_map, copy_intervals, copy_intervals_to_string)
814 (compare_string_intervals, set_intervals_multibyte_1):
815 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
816 * intervals.h: Adjust decls to match defn changes elsewhere.
818 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
819 * keyboard.c (this_command_key_count, this_single_command_key_start)
820 (before_command_key_count, before_command_echo_length, echo_now)
821 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
822 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
823 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
824 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
825 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
826 (last_non_minibuf_size, last_point_position, echo_truncate)
827 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
828 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
829 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
830 (stuff_buffered_input):
831 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
832 (last_auto_save, command_loop_1, read_char):
833 Use EMACS_INT, not int, to avoid integer overflow.
834 (record_char): Avoid overflow in total_keys computation.
835 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
836 * keyboard.h: Adjust decls to match defn changes elsewhere.
837 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
838 (Fkey_description, Fdescribe_vector, Flookup_key):
839 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
840 (click_position): New function, to check that positions are in range.
841 (Fcurrent_active_maps):
843 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
844 (Faccessible_keymaps, Fkey_description):
845 (preferred_sequence_p):
846 Don't assume fixnum can fit into int.
847 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
848 Check for integer overflow in size calculations.
849 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
850 avoid mishandling large integers.
851 * lisp.h: Adjust decls to match defn changes elsewhere.
852 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
853 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
854 (struct Lisp_Marker):
855 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
856 (clip_to_bounds): Now an inline function, moved here from editfns.c.
857 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
858 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
860 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
861 Assume the arg has valid form, since it always does.
862 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
863 unsigned integer system type.
864 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
865 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
866 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
867 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
868 (duration_to_sec_usec): New decl.
869 * lread.c (read_from_string_index, read_from_string_index_byte)
870 (read_from_string_limit, readchar, unreadchar, openp)
871 (read_internal_start, read1, oblookup):
872 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
873 (Fload, readevalloop, Feval_buffer, Feval_region):
874 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
875 (openp): Check for out-of-range argument to 'access'.
876 (read1): Use int, not EMACS_INT, where int is wide enough.
877 Don't assume fixnum fits into int.
878 Fix off-by-one error that can read outside a buffer.
879 (read_filtered_event): Use duration_to_sec_usec
880 to do proper overflow checking on durations.
881 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
883 (Fexecute_kbd_macro):
884 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
885 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
886 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
887 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
888 (set_marker_both, set_marker_restricted_both, marker_position)
889 (marker_byte_position, Fbuffer_has_markers_at):
890 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
891 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
892 * menu.c (ensure_menu_items): Rename from grow_menu_items.
893 It now merely ensures that the menu is large enough, without
894 necessarily growing it, as this avoids some integer overflow issues.
896 (keymap_panes, parse_single_submenu, Fx_popup_menu):
897 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
898 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
899 Use SAFE_ALLOCA_LISP, not alloca.
900 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
901 to EMACS_INT. Check that fixnums are in proper range for system types.
902 * minibuf.c (minibuf_prompt_width, string_to_object)
903 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
904 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
905 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
906 (get_minibuffer, read_minibuf_unwind):
907 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
908 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
909 this simplifies overflow checking. All callers changed.
910 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
912 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
913 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
914 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
915 Check that fixnums are in proper range for system types.
916 (Fx_create_frame, Fx_show_tip):
917 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
918 * nsfont.m (ns_findfonts, nsfont_list_family):
919 Don't assume fixnum fits in long.
920 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
921 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
922 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
924 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
925 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
926 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
927 (PRINTDECLARE, PRINTPREPARE):
928 (strout, print_string):
929 (print, print_preprocess, print_check_string_charset_prop)
931 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
933 (temp_output_buffer_setup, Fprin1_to_string, print_object):
934 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
935 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
936 (printchar, strout): Use xpalloc to catch size calculation overflow.
937 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
938 (print_error_message): Use SAFE_ALLOCA, not alloca.
939 (print_object): Use int, not EMACS_INT, where int is wide enough.
940 (print_depth, new_backquote_output, print_number_index):
941 Use ptrdiff_t, not int, where int might not be wide enough.
942 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
943 (Fset_process_window_size, Fformat_network_address)
944 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
946 Check that fixnums are in proper range for system types.
947 (Fsignal_process): Simplify by avoiding a goto.
948 Check for process-ids out of pid_t range rather than relying on
950 (process_tick, update_tick): Use EMACS_INT, not int.
951 (Fformat_network_address, read_process_output, send_process)
952 (Fprocess_send_region, status_notify):
953 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
954 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
955 (wait_reading_process_output, read_process_output, exec_sentinel):
956 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
957 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
958 (Faccept_process_output): Use duration_to_sec_usec to do proper
959 overflow checking on durations.
960 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
961 Don't assume pid_t fits in int.
962 * process.h (struct Lisp_Process): Members tick and update_tick
963 are now of type EMACS_INT, not int.
964 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
965 configured --with-wide-int.
966 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
967 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
968 * search.c (looking_at_1, string_match_1):
969 (fast_string_match, fast_c_string_match_ignore_case)
970 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
971 (scan_newline, find_before_next_newline, search_command)
972 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
973 (set_search_regs, wordify):
976 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977 (string_match_1, search_buffer, set_search_regs):
979 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
980 (wordify): Check for overflow in size calculation.
981 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
982 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
983 Check that fixnums are in proper range for system types.
984 * sound.c (struct sound_device)
985 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
986 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
987 (Fplay_sound_internal):
988 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
989 * syntax.c (struct lisp_parse_state, find_start_modiff)
990 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
991 (Fparse_partial_sexp):
992 Don't assume fixnums can fit in int.
993 (struct lisp_parse_state, find_start_pos, find_start_value)
994 (find_start_value_byte, find_start_begv)
995 (update_syntax_table, char_quoted, dec_bytepos)
996 (find_defun_start, prev_char_comend_first, back_comment):
997 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
998 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
999 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1000 (Finternal_describe_syntax_value): Check that match_lisp is a
1001 character, not an integer, since the code stuffs it into int.
1002 (scan_words, scan_sexps_forward):
1003 Check that fixnums are in proper range for system types.
1005 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1006 (scan_sexps_forward):
1007 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1008 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1009 * syntax.h: Adjust decls to match defn changes elsewhere.
1010 (struct gl_state_s):
1011 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1012 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1013 MOST_POSITIVE_FIXNUM.
1014 * sysdep.c (wait_for_termination_1, wait_for_termination)
1015 (interruptible_wait_for_termination, mkdir):
1016 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1017 (emacs_read, emacs_write):
1018 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1019 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1020 and double all fit in int.
1021 * term.c (set_tty_color_mode):
1022 Check that fixnums are in proper range for system types.
1023 * termhooks.h (struct input_event):
1024 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1025 * textprop.c (validate_interval_range, interval_of)
1026 (Fadd_text_properties, set_text_properties_1)
1027 (Fremove_text_properties, Fremove_list_of_text_properties)
1028 (Ftext_property_any, Ftext_property_not_all)
1029 (copy_text_properties, text_property_list, extend_property_ranges)
1030 (verify_interval_modification):
1031 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1032 (Fnext_single_char_property_change)
1033 (Fprevious_single_char_property_change):
1034 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1035 (copy_text_properties):
1036 Check for integer overflow in index calculation.
1037 * undo.c (last_boundary_position, record_point, record_insert)
1038 (record_delete, record_marker_adjustment, record_change)
1039 (record_property_change):
1040 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1041 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1042 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1043 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1044 (Fx_hide_tip, Fx_file_dialog):
1045 * w32menu.c (set_frame_menubar):
1046 Use ptrdiff_t, not int, for consistency with rest of code.
1047 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1048 (select_window, Fdelete_other_windows_internal)
1049 (window_scroll_pixel_based, window_scroll_line_based)
1050 (Frecenter, Fset_window_configuration):
1051 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1052 (Fset_window_hscroll, run_window_configuration_change_hook)
1053 (set_window_buffer, temp_output_buffer_show, scroll_command)
1054 (Fscroll_other_window, Frecenter):
1055 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1056 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1057 Don't assume fixnum fits in int.
1058 (Fset_window_scroll_bars):
1059 Check that fixnums are in proper range for system types.
1060 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1061 (string_pos, c_string_pos, number_of_chars, init_iterator)
1062 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1063 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1064 (compute_display_string_end, handle_face_prop)
1065 (face_before_or_after_it_pos, handle_invisible_prop)
1066 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1067 (display_prop_intangible_p, string_buffer_position_lim)
1068 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1069 (get_overlay_strings_1, get_overlay_strings)
1070 (iterate_out_of_display_property, forward_to_next_line_start)
1071 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1072 (get_next_display_element, set_iterator_to_next)
1073 (get_visually_first_element, compute_stop_pos_backwards)
1074 (handle_stop_backwards, next_element_from_buffer)
1075 (move_it_in_display_line_to, move_it_in_display_line)
1076 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1077 (add_to_log, message_dolog, message_log_check_duplicate)
1078 (message2, message2_nolog, message3, message3_nolog
1079 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1080 (current_message_1, truncate_echo_area, truncate_message_1)
1081 (set_message, set_message_1, store_mode_line_noprop)
1082 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1083 (text_outside_line_unchanged_p, check_point_in_composition)
1084 (reconsider_clip_changes)
1085 (redisplay_internal, set_cursor_from_row, try_scrolling)
1086 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1087 (redisplay_window, find_last_unchanged_at_beg_row)
1088 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1089 (trailing_whitespace_p, find_row_edges, display_line)
1090 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1091 (display_mode_element, store_mode_line_string)
1092 (pint2str, pint2hrstr, decode_mode_spec)
1093 (display_count_lines, display_string, draw_glyphs)
1094 (x_produce_glyphs, x_insert_glyphs)
1095 (rows_from_pos_range, mouse_face_from_buffer_pos)
1096 (fast_find_string_pos, mouse_face_from_string_pos)
1097 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1098 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1099 (safe_call, init_from_display_pos, handle_fontified_prop)
1100 (handle_single_display_spec, load_overlay_strings)
1101 (with_echo_area_buffer, setup_echo_area_for_printing)
1102 (display_echo_area, echo_area_display)
1103 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1104 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1105 (redisplay_window, dump_glyph_row, display_mode_line)
1106 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1107 (handle_display_spec, display_prop_string_p):
1108 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1109 (handle_single_display_spec, build_desired_tool_bar_string)
1110 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1111 (get_specified_cursor_type):
1112 Check that fixnums are in proper range for system types.
1113 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1114 (Flookup_image_map):
1115 Don't assume fixnums fit in int.
1116 (compare_overlay_entries):
1117 Avoid mishandling comparisons due to subtraction overflow.
1118 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1119 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1120 (handle_tool_bar_click):
1121 Use int, not unsigned, since we prefer signed and the signedness
1122 doesn't matter here.
1123 (get_next_display_element, next_element_from_display_vector):
1124 Use int, not EMACS_INT, when int is wide enough.
1125 (start_hourglass): Use duration_to_sec_usec to do proper
1126 overflow checking on durations.
1127 * xfaces.c (Fbitmap_spec_p):
1128 Check that fixnums are in proper range for system types.
1129 (compare_fonts_by_sort_order):
1130 Avoid mishandling comparisons due to subtraction overflow.
1131 (Fx_family_fonts, realize_basic_faces):
1132 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1134 Don't assume fixnum fits in int.
1135 Use SAFE_ALLOCA_LISP, not alloca.
1136 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1137 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1138 (face_at_buffer_position, face_for_overlay_string)
1139 (face_at_string_position):
1140 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1141 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1142 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1144 Check that fixnums are in proper range for system types.
1145 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1146 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1147 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1148 (Fx_change_window_property): Don't assume fixnums fit in int.
1149 * xfont.c (xfont_chars_supported):
1150 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1151 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1152 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1153 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1154 * xml.c (parse_region):
1155 * xrdb.c (magic_file_p):
1156 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1157 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1158 (x_get_local_selection, x_reply_selection_request)
1159 (x_handle_selection_request, wait_for_property_change):
1160 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1161 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1162 short is wide enough.
1163 (x_send_client_event): Don't assume fixnum fits in int.
1164 * xterm.c (x_x_to_emacs_modifiers):
1165 Don't assume EMACS_INT overflows nicely into int.
1166 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1168 (handle_one_xevent): NATNUMP can eval its arg twice.
1169 (x_connection_closed):
1170 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1171 * xterm.h: Adjust decls to match defn changes elsewhere.
1172 (struct scroll_bar): Use struct vectorlike_header
1173 rather than rolling our own approximation.
1174 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1176 2012-05-25 Glenn Morris <rgm@gnu.org>
1178 * lisp.mk (lisp): Update for more files being compiled now.
1180 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1182 * lread.c: Remove `read_pure' which makes no difference.
1183 (read_pure): Remove var.
1184 (unreadpure): Remove function.
1185 (readevalloop): Don't call read_list with -1 flag.
1186 (read1, read_vector): Don't test read_pure any more.
1187 (read_list): Simplify.
1189 * fileio.c, character.h: Minor style tweaks.
1191 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1193 * window.h (clip_changed): Remove useless declaration.
1195 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1197 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1198 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1200 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1203 This directory predates autoconf and is no longer needed nowadays.
1204 Move its few remaining bits of functionality to where they're needed.
1205 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1206 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1207 * m/template.h: Remove.
1208 * Makefile.in (M_FILE): Remove. All uses removed.
1209 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1210 * lisp.h (USE_LSB_TAG):
1211 * mem-limits.h (EXCEEDS_LISP_PTR):
1212 Use VAL_MAX, not VALBITS, in #if.
1213 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1214 (EMACS_UINT): Define unconditionally now.
1215 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1216 (BITS_PER_EMACS_INT): New constants, replacing
1217 what used to be in config.h, but not useful in #if.
1218 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1219 define them any more.
1220 (VAL_MAX): New macro.
1222 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1223 BITS_PER_EMACS_INT, in #if.
1224 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1225 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1226 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1227 * s/ms-w32.h (DATA_START):
1228 Move here from removed file m/intel386.h.
1229 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1230 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1232 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1234 Assume C89 or later.
1235 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1236 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1238 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1239 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1240 * textprop.c, tparam.c (NULL): Remove.
1241 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1242 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1243 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1244 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1245 * xterm.c (input_signal_count): Assume volatile works.
1247 2012-05-21 Ken Brown <kbrown@cornell.edu>
1249 * xgselect.c (xg_select): Fix first argument in call to 'select'
1252 2012-05-20 Ken Brown <kbrown@cornell.edu>
1254 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1255 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1257 2012-05-19 Ken Brown <kbrown@cornell.edu>
1259 * xfns.c (x_in_use): Remove `static' qualifier.
1260 * xterm.h (x_in_use): Declare.
1261 * xgselect.c: Include xterm.h.
1262 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1263 and `display_arg' (bug#9754).
1265 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1267 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1269 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1270 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1272 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1274 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1276 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1277 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1279 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1280 reference to image_cache->refcount.
1281 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1283 2012-05-17 Juri Linkov <juri@jurta.org>
1285 * search.c (Fword_search_regexp, Fword_search_backward)
1286 (Fword_search_forward, Fword_search_backward_lax)
1287 (Fword_search_forward_lax): Move functions to isearch.el
1288 (bug#10145, bug#11381).
1290 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1292 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1294 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1296 * lread.c (init_obarray): Declare Qt and Qnil as special.
1298 2012-05-14 Glenn Morris <rgm@gnu.org>
1300 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1301 Put "libexec" before "bin", for the sake of init_callproc_1.
1303 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1305 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1307 * unexaix.c: Port to more-recent AIX compilers.
1308 (report_error, report_error_1, make_hdr, copy_sym)
1309 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1310 Make arguments const char *, not char *, to avoid violations of C
1311 standard and to fix some AIX warnings reported by Gilles Pion.
1313 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1315 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1316 already have overlays loaded.
1317 (handle_single_display_spec): Before returning without displaying
1318 fringe bitmap, synchronize the bidi iterator with the main display
1319 iterator, by calling iterate_out_of_display_property.
1320 (iterate_out_of_display_property): Detect buffer iteration by
1321 testing that it->string is a Lisp string.
1322 (get_next_display_element): When the current object is exhausted,
1323 and there's something on it->stack, call set_iterator_to_next to
1324 proceed with what's on the stack, instead of returning zero.
1325 (set_iterator_to_next): If called at the end of a Lisp string,
1326 proceed to consider_string_end without incrementing string
1327 position. Don't increment display vector index past the end of
1328 the display vector. (Bug#11417)
1329 (pos_visible_p): Don't report a position visible when move_it_to
1330 stopped at the last line of window, which happens to be scanned
1331 backwards by the bidi iteration. (Bug#11464)
1333 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1335 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1336 and right-margin display specs even if the spec is invalid or we
1337 are on a TTY, and thus unable to display on the fringes.
1338 That's because the text with the property will not be displayed anyway,
1339 so we need to signal to the caller that this is a "replacing"
1340 display spec. This fixes display when the spec is invalid or we
1343 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1345 * unexaix.c (make_hdr): Fix typo in prototype.
1346 This bug broke the build on AIX. Problem reported by Gilles Pion.
1348 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1350 * keyboard.c (kbd_buffer_get_event): Read special events also in
1351 batch mode. (Bug#11415)
1353 2012-05-12 Glenn Morris <rgm@gnu.org>
1355 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1357 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1359 * lisp.mk (lisp): Add newcomment.elc.
1361 2012-05-12 Glenn Morris <rgm@gnu.org>
1363 * Makefile.in (MKDIR_P): New, set by configure.
1364 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1366 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1368 Remove unused function hourglass_started.
1369 * dispextern.h (hourglass_started):
1370 * w32fns.c (hourglass_started):
1371 * xdisp.c (hourglass_started): Remove.
1373 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1375 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1376 Update dependencies.
1378 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1380 * xgselect.c (xg_select): Put maxfds+1 into a var.
1381 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1383 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1385 2012-05-10 Dave Abrahams <dave@boostpro.com>
1387 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1388 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1390 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1392 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1393 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1394 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1395 Initialize xd_registered_buses.
1397 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1399 Untag more efficiently if USE_LSB_TAG.
1400 This is based on a proposal by YAMAMOTO Mitsuharu in
1401 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1402 For an admittedly artificial (nth 8000 longlist) benchmark on
1403 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1404 Emacs's overall text size by 1%.
1405 * lisp.h (XUNTAG): New macro.
1406 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1407 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1408 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1409 * eval.c (Fautoload):
1410 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1411 * frame.h (XFRAME): Use XUNTAG.
1413 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1414 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1415 Remove unportable assumptions about print widths of types like
1417 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1418 intptr_t when converting between pointer and integer, to avoid GCC
1419 warnings about wrong width.
1421 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1423 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1424 stack for each reader_thread, instead of defaulting to 8MB
1425 determined by the linker. This avoids failures in creating
1426 subprocesses on Windows 7, see the discussion in this thread:
1427 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1429 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1431 Fix up display of the *Minibuf-0* buffer in the mini window.
1432 * keyboard.c (read_char): Don't clear the echo area if there's no
1434 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1435 contents of *Minibuf-0*) if there's no message displayed in its stead.
1437 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1439 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1442 2012-05-06 Chong Yidong <cyd@gnu.org>
1444 * lisp.mk (lisp): Update.
1446 2012-05-05 Jim Meyering <meyering@redhat.com>
1448 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1450 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1452 * data.c (PUT_ERROR): New macro.
1453 (syms_of_data): Use it. Add new error type `user-error'.
1454 * undo.c (user_error): New function.
1455 (Fprimitive_undo): Use it.
1456 * print.c (print_error_message): Adjust print style for `user-error'.
1457 * keyboard.c (user_error): New function.
1458 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1460 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1462 Do not limit current-time-string to years 1000..9999.
1463 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1464 (Fcurrent_time_string): Support any year that is supported by the
1465 underlying localtime representation. Don't use asctime, as it
1466 has undefined behavior for years outside the range -999..9999.
1468 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1470 Fix race conditions involving setenv, gmtime, localtime, asctime.
1471 Without this fix, interrupts could mess up code that uses these
1472 nonreentrant functions, since setting TZ invalidates existing
1473 tm_zone or tzname values, and since most of these functions return
1474 pointers to static storage.
1475 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1476 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1477 Grow the critical sections to include not just invoking
1478 localtime/gmtime, but also accessing these functions' results
1479 including their tm_zone values if any, and any related TZ setting.
1480 (format_time_string): Last arg is now struct tm *, not struct tm **,
1481 so that the struct tm is saved in the critical section.
1482 All callers changed. Simplify allocation of initial buffer, partly
1483 motivated by the fact that memory allocation needs to be outside
1484 the critical section.
1486 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1488 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1489 with RESET_INTERVAL.
1491 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1492 Remove duplicated buffer name initialization.
1494 2012-05-02 Jim Meyering <jim@meyering.net>
1496 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1498 * xfns.c (x_window): Use xstrdup (Bug#11375).
1500 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1502 * xdisp.c (pos_visible_p): If already at a newline from the
1503 display string before the 'while' loop, don't walk back the glyphs
1504 from it3.glyph_row. Solves assertion violation when the display
1505 string begins with a newline (egg.el). (Bug#11367)
1507 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1509 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1512 2012-05-01 Glenn Morris <rgm@gnu.org>
1514 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1515 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1516 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1517 All were removed before 23.1.
1519 * dispnew.c: Remove HAVE_LIBNCURSES test;
1520 it is always true on relevant platforms.
1522 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1523 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1525 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1527 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1529 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1530 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1533 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1535 Do not avoid creating empty evaporating overlays (Bug#9642).
1536 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1537 That is, do not delete an evaporating overlay if it becomes
1538 empty after its bounds are adjusted to fit within its buffer.
1539 This fix caused other problems, and I'm reverting it until we get
1540 to the bottom of them.
1542 2012-04-27 Chong Yidong <cyd@gnu.org>
1544 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1546 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1548 * xdisp.c (pos_visible_p): If the window start position is beyond
1549 ZV, start the display from buffer beginning. Prevents assertion
1550 violation in init_iterator when the minibuffer window is scrolled
1553 * window.c (window_scroll_pixel_based): Likewise.
1555 2012-04-27 Chong Yidong <cyd@gnu.org>
1557 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1559 2012-04-27 Glenn Morris <rgm@gnu.org>
1561 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1562 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1564 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1566 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1567 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1569 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1571 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1572 display element, check also the underlying string or buffer
1573 character. (Bug#11341)
1575 * w32menu.c: Include w32heap.h.
1576 (add_menu_item): If the call to AppendMenuW (via
1577 unicode_append_menu) fails, disable Unicode menus only if we are
1578 running on Windows 9X/Me.
1580 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1582 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1583 (xgetint): Add missing shift for LSB tags.
1585 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1587 * keyboard.c (read_char): Don't wipe echo area for select window
1588 events: These might get delayed via `mouse-autoselect-window'
1591 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1593 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1594 manipulation of :loaded-from data.
1596 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1598 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1599 now a cons (bug#11311).
1601 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1603 Do not create empty overlays with the evaporate property (Bug#9642).
1604 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1605 if it becomes empty after its bounds are adjusted to fit within
1606 its buffer. Without this fix, in a nonempty buffer (let ((o
1607 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1608 yields an empty overlay that has the evaporate property, which is
1609 not supposed to happen.
1611 Fix minor GTK3 problems found by static checking.
1612 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1613 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1614 (struct _EmacsFixedClass, emacs_fixed_get_type):
1615 Move decls here from emacsgtkfixed.h, since they needn't be public.
1616 (emacs_fixed_get_type): Now static.
1617 (emacs_fixed_class_init): Omit unused local.
1618 (emacs_fixed_child_type): Remove; unused.
1619 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1620 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1621 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1622 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1623 (EMACS_FIXED_GET_CLASS): Remove; unused.
1624 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1626 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1627 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1629 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1631 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1632 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1633 (__malloc_size_t, __malloc_ptrdiff_t):
1634 Remove. All uses removed, replaced by the definiens if needed,
1635 since we can assume C89 or better now.
1636 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1637 (protect_malloc_state, align, get_contiguous_space)
1638 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1639 (malloc_atfork_handler_child, malloc_enable_thread)
1640 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1641 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1642 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1643 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1644 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1645 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1646 Define using prototypes, not old style.
1647 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1648 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1649 (align): Don't assume that signed integer overflow wraps around.
1650 Omit unused local var.
1651 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1652 (_free_internal_nolock, memalign, mallochook, reallochook):
1653 Omit no-longer-needed casts.
1654 (valloc): Use getpagesize, not __getpagesize.
1655 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1656 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1658 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1660 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1662 Move functions from C to Lisp. Make non-blocking method calls
1663 the default. Implement further D-Bus standard interfaces.
1665 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1666 (QCdbus_request_name_allow_replacement)
1667 (QCdbus_request_name_replace_existing)
1668 (QCdbus_request_name_do_not_queue)
1669 (QCdbus_request_name_reply_primary_owner)
1670 (QCdbus_request_name_reply_in_queue)
1671 (QCdbus_request_name_reply_exists)
1672 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1673 (QCdbus_registered_serial, QCdbus_registered_method)
1674 (QCdbus_registered_signal): New Lisp objects.
1675 (XD_DEBUG_MESSAGE): Use sizeof.
1676 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1677 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1678 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1679 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1680 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1681 (xd_signature, xd_append_arg): Allow float for integer types.
1682 (xd_get_connection_references): New function.
1683 (xd_get_connection_address): Rename from xd_initialize.
1684 Return cached address.
1685 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1686 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1688 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1689 Return number of refcounts.
1690 (Fdbus_get_unique_name): Make stronger parameter check.
1691 (Fdbus_message_internal): New defun.
1692 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1693 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1694 (Fdbus_send_signal, Fdbus_register_service)
1695 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1696 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1697 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1698 (Vdbus_compiled_version, Vdbus_runtime_version)
1699 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1700 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1701 (Vdbus_message_type_signal): New defvars.
1702 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1705 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1707 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1708 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1709 Do not assume ptrdiff_t is the same width as 'int'.
1711 * alloc.c: Handle unusual debugging option combinations.
1712 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1713 since the two debugging options are incompatible.
1714 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1716 (mem_init, mem_insert, mem_insert_fixup):
1717 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1718 (NEED_MEM_INSERT): Remove; no longer needed.
1720 2012-04-22 Leo Liu <sdl.web@gmail.com>
1722 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1724 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1726 * sysdep.c [__FreeBSD__]: Minor cleanups.
1727 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1728 Use Emacs indenting style more consistently. Avoid some casts.
1729 Use 'double' consistently rather than mixing 'float' and 'double'.
1731 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1733 * sysdep.c (list_system_processes, system_process_attributes):
1734 Add implementation for FreeBSD (Bug#5243).
1736 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1738 * lisp.mk (lisp): Update.
1740 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1742 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1743 It is never used otherwise.
1745 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1747 * print.c (print_preprocess): Only check print_depth if print-circle
1749 (print_object): Check for cycles even when print-circle is nil and
1750 print-gensym is t, but only check print_depth if print-circle is nil.
1752 2012-04-20 Chong Yidong <cyd@gnu.org>
1754 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1755 set the status to "failed" and ensure that sentinel is run.
1757 2012-04-20 Glenn Morris <rgm@gnu.org>
1759 * process.c (Fset_process_inherit_coding_system_flag)
1760 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1761 (Fmake_network_process, Fmake_serial_process): Doc fix.
1763 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1765 * xdisp.c (string_buffer_position_lim): Limit starting position to
1767 (set_cursor_from_row): If called for a mode-line or header-line
1768 row, return zero immediately.
1769 (try_cursor_movement): If inside continuation line, don't back up
1770 farther than the first row after the header line, if any.
1771 Don't consider the header-line row as "partially visible", even if
1772 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1774 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1776 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1779 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1780 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1782 configure: new option --enable-gcc-warnings (Bug#11207)
1783 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1784 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1785 (ALL_CFLAGS): Use new macros rather than old.
1786 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1787 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1788 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1789 -Wunused-result, -Wunused-variable. This should go away once
1790 the Emacs and Gnulib regex code is merged.
1791 (xmalloc, xrealloc): Now static.
1793 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1795 * dired.c (Fsystem_groups): Remove unused local.
1797 2012-04-17 Glenn Morris <rgm@gnu.org>
1799 * dired.c (Fsystem_users): Doc fix.
1801 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1803 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1804 (syms_of_dired): Add them.
1806 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1808 Fix minor alloc.c problems found by static checking.
1809 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1810 New extern decls, to avoid calling undeclared functions.
1811 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1812 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1813 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1814 (NEED_MEM_INSERT): New macro.
1815 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1816 Remove one incorrect comment and fix another.
1818 Fix minor ralloc.c problems found by static checking.
1819 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1820 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1821 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1822 (r_alloc_sbrk): Now static.
1824 Improve ralloc.c interface checking.
1825 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1826 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1827 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1828 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1829 [REL_ALLOC]: ... to here, to check interface.
1830 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1831 Remove decls. This fixes an "It stinks!".
1833 * alloc.c (which_symbols): Fix alignment issue / type clash.
1835 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1837 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1838 (struct Lisp_Misc_Any): Likewise.
1839 (struct Lisp_Free): Likewise.
1840 * alloc.c (union aligned_Lisp_Symbol): Define.
1841 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1842 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1843 (union aligned_Lisp_Misc): Define.
1844 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1845 aligned_Lisp_Misc instead of union Lisp_Misc.
1846 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1848 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1850 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1851 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1852 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1853 * s/netbsd.h, s/sol2-6.h:
1854 Remove definition of GC_MARK_STACK, since the default now works.
1855 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1856 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1857 no longer the default.
1858 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1860 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1862 * lread.c (lisp_file_lexically_bound_p):
1863 Fix hang at ";-*-\n" (bug#11238).
1865 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1867 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1868 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1870 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1872 * nsterm.m (constrainFrameRect): Always constrain when there is only
1873 one screen (Bug#10962).
1875 2012-04-13 Ken Brown <kbrown@cornell.edu>
1877 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1879 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1881 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1883 2012-04-11 Daniel Colascione <dancol@dancol.org>
1885 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1886 against is gone. It's better to use vfork now so that when Cygwin
1887 gains a new, working vfork, we use it automatically (bug#10398).
1889 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1891 * window.c (save_window_save): Obey window-point-insertion-type.
1893 2012-04-11 Glenn Morris <rgm@gnu.org>
1895 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1897 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1899 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1901 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1903 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1904 (force_quit_count): New var.
1905 (handle_interrupt): Use it.
1907 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1909 * w32.c (w32_delayed_load): Record the full path of the library
1910 being loaded (bug#10424).
1912 2012-04-09 Glenn Morris <rgm@gnu.org>
1914 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1915 not just in the obarray, before snarfing them. (Bug#11036)
1917 * Makefile.in ($(leimdir)/leim-list.el):
1918 Pass EMACS rather than BUILT_EMACS.
1920 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1922 * process.c (make_process):
1923 * process.h: Add integer `gnutls_handshakes_tried' member to
1926 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1927 Add convenience `GNUTLS_LOG2i' macro.
1929 * gnutls.c (gnutls_log_function2i): Convenience log function.
1930 (emacs_gnutls_read): Use new log functions,
1931 `gnutls_handshakes_tried' process member, and
1932 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1933 attempts per process (connection).
1935 2012-04-09 Chong Yidong <cyd@gnu.org>
1937 * eval.c (Fuser_variable_p, user_variable_p_eh)
1938 (lisp_indirect_variable): Functions deleted.
1939 (Fdefvar): Caller changed.
1941 * callint.c (Finteractive, Fcall_interactively):
1942 * minibuf.c (Fread_variable): Callers changed.
1944 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1946 * xdisp.c (set_cursor_from_row): If the display string appears in
1947 the buffer at position that is closer to point than the position
1948 after the display string, display the cursor on the first glyph of
1949 the display string. Fixes cursor display when a 'display' text
1950 property immediately follows invisible text. (Bug#11094)
1952 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1954 composite.c: use 'double' consistently
1955 * composite.c (get_composition_id): Use 'double' consistently
1956 instead of converting 'float' to 'double' and vice versa; this is
1957 easier to understand and avoids a GCC warning.
1959 2012-04-09 Glenn Morris <rgm@gnu.org>
1961 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1962 preparation for dumping it with emacs. (Bug#4789)
1963 (leimdir): New variable.
1964 ($(leimdir)/leim-list.el): New rule.
1965 (emacs$(EXEEXT)): Depend on leim-list.el.
1967 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1968 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1969 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1971 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1973 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1976 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
1978 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1979 Remove unused local variable.
1981 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1983 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1984 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1985 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1986 objects, as mark_maybe_pointer will catch them otherwise.
1987 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1988 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1990 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1992 Fix typo that broke non-Windows builds.
1993 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1995 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1997 Support building on MS-Windows with libxml2.
1999 * makefile.w32-in (OBJ2): Add xml.$(O).
2000 (GLOBAL_SOURCES): Add xml.c.
2001 ($(BLD)/xml.$(O)): New dependency list.
2003 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2004 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2005 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2006 [!WINDOWSNT]: New macros.
2007 (init_libxml2_functions, libxml2_loaded_p): New functions.
2008 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2009 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2010 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2011 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2013 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2014 Call init_libxml2_functions before calling libxml2 functions.
2015 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2017 * emacs.c: Don't include libxml/parser.h.
2018 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2019 xmlCleanupParser directly.
2021 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2023 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2025 * indent.c (Fvertical_motion): If there is a display string at
2026 point, use it.vpos to compute how many lines to backtrack after
2027 move_it_to point. (Bug#11133)
2029 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2031 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2032 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2033 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2034 macros related to unification of CJK characters. For the details,
2035 see the discussion following the message here:
2036 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2038 2012-04-04 Chong Yidong <cyd@gnu.org>
2040 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2042 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2044 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2045 instead of alloca. (Bug#11138)
2047 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2049 * w32menu.c (is_simple_dialog): Properly check lisp types.
2052 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2054 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2055 position we get to after a call to move_it_to fails the
2056 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2057 only if we wind up in a string from display property. (Bug#11063)
2059 * window.c (Fdelete_other_windows_internal): Invalidate the row
2060 and column information about mouse highlight, so that redisplay
2061 restores it after reallocating the glyph matrices. (Bug#7464)
2063 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2064 string comes from a `display' text property, use the buffer
2065 position of that property as if we actually saw that position in
2067 (move_it_by_lines): Remove the assertion that
2068 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2069 violated when there's a before-string at the beginning of a line.
2072 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2074 * xdisp.c (append_space_for_newline): If the default face was
2075 remapped, use the remapped face for the appended newline.
2076 (extend_face_to_end_of_line): Use the remapped default face for
2077 extending the face to the end of the line.
2078 (display_line): Call extend_face_to_end_of_line when the default
2079 face was remapped. (Bug#11068)
2081 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2083 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2085 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2087 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2089 2012-03-27 Glenn Morris <rgm@gnu.org>
2091 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2094 2012-03-26 Kenichi Handa <handa@m17n.org>
2096 * dispextern.h (struct glyph): Fix previous change. Change the
2097 bit length of glyphless.ch to 25 (Bug#11082).
2099 2012-03-26 Chong Yidong <cyd@gnu.org>
2101 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2102 (command_loop_1): Use it; inhibit selection update for
2103 handle-select-window too (Bug#8996).
2105 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2107 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2109 2012-03-25 Kenichi Handa <handa@m17n.org>
2111 * dispextern.h (struct glyph): Change the bit length of
2112 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2114 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2116 * s/ms-w32.h (tzname): Include time.h before redirecting to
2117 _tzname. Fixes the MSVC build. (Bug#9960)
2119 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2121 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2124 * xterm.c (XTread_socket): Only modify handling_signal if
2125 !SYNC_INPUT. (Bug#11080)
2127 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2129 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2130 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2131 when fetching a multibyte character consumes more bytes than
2132 CHAR_BYTES returns, due to unification of CJK characters in
2133 string_char. (Bug#11073)
2135 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2137 * process.c (wait_reading_process_output): Handle pty disconnect
2138 by refraining from sending oneself a SIGCHLD (bug#10933).
2140 2012-03-22 Chong Yidong <cyd@gnu.org>
2142 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2144 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2145 Mark string as coming from a prefix property.
2146 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2147 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2149 2012-03-21 Chong Yidong <cyd@gnu.org>
2151 * xfaces.c (Vface_remapping_alist): Doc fix.
2153 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2155 * w32proc.c (Fw32_set_console_codepage)
2156 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2159 2012-03-20 Chong Yidong <cyd@gnu.org>
2161 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2162 to reflect default non-nil value of redisplay-dont-pause.
2164 2012-03-19 Kenichi Handa <handa@m17n.org>
2166 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2167 it fit in a valid range (Bug#11003).
2169 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2171 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2172 that is not from display property, accept the row as a "cursor
2173 row" if one of the string's character has a non-nil `cursor'
2174 property. Fixes cursor positioning when there are newlines in
2175 overlay strings, e.g. in icomplete.el. (Bug#11035)
2177 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2179 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2181 2012-03-12 Chong Yidong <cyd@gnu.org>
2183 * eval.c (inhibit_lisp_code): Rename from
2184 inhibit_window_configuration_change_hook; move from window.c.
2186 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2187 * window.c (run_window_configuration_change_hook)
2188 (syms_of_window): Callers changed.
2190 2012-03-11 Chong Yidong <cyd@gnu.org>
2192 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2194 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2196 2012-03-10 Chong Yidong <cyd@gnu.org>
2198 * frame.c (other_visible_frames): Don't assume the selected frame
2199 is visible (Bug#10955).
2201 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2203 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2205 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2207 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2208 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2211 2012-03-03 Glenn Morris <rgm@gnu.org>
2213 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2215 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2217 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2218 position past the first glyph_row that ends at ZV. (Bug#10902)
2219 (redisplay_window, next_element_from_string): Fix typos in
2221 (redisplay_window): Pass to move_it_vertically the margin in
2222 pixels, not in screen lines.
2224 2012-03-02 Glenn Morris <rgm@gnu.org>
2226 * buffer.c (buffer-list-update-hook): Doc fix.
2228 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2230 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2231 push_it before setting up the iterator for the first overlay
2232 string, even if we have an empty string loaded.
2233 (next_overlay_string): If there's an empty string on the iterator
2234 stack, pop the stack. (Bug#10903)
2236 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2238 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2239 Suggested by Stefan Monnier in
2240 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2241 * alloc.c (widen_to_Lisp_Object): New static function.
2242 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2243 and widening them to Lisp_Objects. This would work even if
2244 USE_LSB_TAG is defined and wide integers are used, which might
2245 happen in a future version of Emacs.
2247 2012-02-25 Chong Yidong <cyd@gnu.org>
2249 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2252 * xselect.c (Fx_selection_exists_p): Doc fix.
2253 (x_clipboard_manager_save_all): Print an informative message
2254 before saving to clipboard manager.
2256 2012-02-24 Chong Yidong <cyd@gnu.org>
2258 * keyboard.c (process_special_events): Handle all X selection
2259 requests in kbd_buffer, not just the next one (Bug#8869).
2261 2012-02-23 Chong Yidong <cyd@gnu.org>
2263 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2264 call when setting menu-bar-lines and tool-bar-lines parameters.
2265 (unwind_create_frame_1): New helper function.
2267 * window.c (inhibit_window_configuration_change_hook): New var.
2268 (run_window_configuration_change_hook): Obey it.
2269 (syms_of_window): Initialize it.
2271 2012-02-22 Chong Yidong <cyd@gnu.org>
2273 * xterm.c (x_draw_image_relief): Add missing type check for
2274 Vtool_bar_button_margin (Bug#10743).
2276 2012-02-21 Chong Yidong <cyd@gnu.org>
2278 * fileio.c (Vfile_name_handler_alist): Doc fix.
2280 * buffer.c (Fget_file_buffer): Protect against invalid file
2281 handler return value.
2283 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2285 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2286 when computing $valmask.
2288 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2289 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2290 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2291 It's useless in that case, and it can cause problems on hosts
2292 that allocate halves of EMACS_INT values separately.
2293 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2294 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2295 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2296 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2297 it avoids undefined behavior on hosts where shifting right by more
2298 than the word width has undefined behavior.
2300 2012-02-19 Chong Yidong <cyd@gnu.org>
2302 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2303 (Funhandled_file_name_directory, Ffile_name_as_directory)
2304 (Fdirectory_file_name, Fexpand_file_name)
2305 (Fsubstitute_in_file_name): Protect against invalid file handler
2306 return values (Bug#10845).
2308 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2310 * .gdbinit (pitx): Fix incorrect references to fields of the
2313 2012-02-17 Chong Yidong <cyd@gnu.org>
2315 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2317 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2319 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2320 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2322 2012-02-15 Chong Yidong <cyd@gnu.org>
2324 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2325 marked as special. Also, starting docstrings with * is obsolete.
2327 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2329 * gnutls.c (emacs_gnutls_write): Fix last change.
2331 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2333 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2336 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2338 * keymap.c (Fsingle_key_description): Handle char ranges.
2340 2012-02-12 Chong Yidong <cyd@gnu.org>
2342 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2343 as that creates a dangerous corner case.
2345 * window.c (Fdelete_window_internal): Invalidate the mouse
2346 highlight (Bug#9904).
2348 2012-02-12 Glenn Morris <rgm@gnu.org>
2350 * xselect.c (Fx_own_selection_internal)
2351 (Fx_get_selection_internal, Fx_disown_selection_internal)
2352 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2353 * nsselect.m (Fx_own_selection_internal)
2354 (Fx_disown_selection_internal, Fx_selection_exists_p)
2355 (Fx_selection_owner_p, Fx_get_selection_internal):
2356 Sync docs and argument specs with the xselect.c versions.
2358 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2360 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2362 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2364 * w32select.c (Fx_selection_exists_p): Sync doc string and
2365 argument list with xselect.c. (Bug#10783)
2367 * w16select.c (Fx_selection_exists_p): Sync doc string and
2368 argument list with xselect.c. (Bug#10783)
2370 2012-02-10 Glenn Morris <rgm@gnu.org>
2372 * fns.c (Fsecure_hash): Doc fix.
2374 2012-02-09 Kenichi Handa <handa@m17n.org>
2376 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2378 2012-02-07 Chong Yidong <cyd@gnu.org>
2380 * buffer.c (Fbuffer_local_variables)
2381 (buffer_lisp_local_variables): Handle unbound vars correctly;
2382 don't let Qunbound leak into Lisp.
2384 2012-02-07 Glenn Morris <rgm@gnu.org>
2386 * image.c (Fimagemagick_types): Doc fix.
2388 * image.c (imagemagick-render-type): Change it from a lisp object
2389 to an integer. Move the doc here from the lisp manual.
2390 Treat all values not equal to 0 the same.
2392 2012-02-06 Chong Yidong <cyd@gnu.org>
2394 * doc.c (store_function_docstring): Avoid applying docstring of
2395 alias to base function (Bug#2603).
2397 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2399 * .gdbinit (pp1, pv1): Remove redundant defines.
2402 2012-02-04 Chong Yidong <cyd@gnu.org>
2404 * nsterm.m: Declare a global (Bug#10694).
2406 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2408 * w32.c (get_emacs_configuration_options):
2409 Include --enable-checking, if specified, in the return value.
2411 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2413 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2414 after rounding frame sizes. (Bug#9723)
2416 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2418 * keyboard.c (adjust_point_for_property): Don't position point
2419 before BEGV. (Bug#10696)
2421 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2423 Handle overflow when computing char display width (Bug#9496).
2424 * character.c (char_width): Return EMACS_INT, not int.
2425 (char_width, c_string_width): Check for overflow when
2426 computing the width; this is possible now that individual
2427 characters can have unbounded width. Problem introduced
2428 by merge from Emacs 23 on 2012-01-19.
2430 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2432 * dbusbind.c (Fdbus_register_method): Mention the return value
2433 :ignore in the docstring.
2435 2012-02-02 Glenn Morris <rgm@gnu.org>
2437 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2439 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2440 Unconditionally set to t. (Bug#10673)
2441 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2442 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2443 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2445 2012-02-02 Kenichi Handa <handa@m17n.org>
2447 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2448 0, do not call append_composite_glyph.
2450 2012-02-02 Kenichi Handa <handa@m17n.org>
2452 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2454 (x_produce_glyphs): If the component of a composition is a null
2455 string, set it->pixel_width to 1 to avoid zero-width glyph.
2457 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2459 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2460 first 2 arguments are identical. This makes inserting large
2461 output from a subprocess an order of magnitude faster on
2462 MS-Windows, where all sbrk'ed memory is always contiguous.
2464 2012-01-31 Glenn Morris <rgm@gnu.org>
2466 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2467 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2468 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2470 2012-01-29 Glenn Morris <rgm@gnu.org>
2472 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2474 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2476 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2478 2012-01-28 Chong Yidong <cyd@gnu.org>
2480 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2482 2012-01-26 Chong Yidong <cyd@gnu.org>
2484 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2486 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2487 repeat counts (Bug#10507).
2489 2012-01-26 Glenn Morris <rgm@gnu.org>
2491 * lread.c (syms_of_lread): Doc fix.
2493 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2495 * coding.c (encode_designation_at_bol): Change return value to
2498 2012-01-25 Chong Yidong <cyd@gnu.org>
2500 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2502 2012-01-21 Chong Yidong <cyd@gnu.org>
2504 * floatfns.c (Fcopysign): Make the second argument non-optional,
2505 since nil is not allowed anyway.
2507 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2509 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2510 (send_process): Likewise.
2512 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2514 * window.c (save_window_save, Fcurrent_window_configuration)
2515 (Vwindow_persistent_parameters): Do not use Qstate.
2516 Rewrite doc-strings.
2518 2012-01-19 Kenichi Handa <handa@m17n.org>
2520 * character.c (char_width): New function.
2521 (Fchar_width, c_string_width, lisp_string_width):
2522 Use char_width (Bug#9496).
2524 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2526 * window.c (Vwindow_persistent_parameters): New variable.
2527 (Fset_window_configuration, save_window_save): Handle persistent
2530 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2532 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2533 thrashing the stack of the thread. (Bug#9087)
2535 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2537 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2539 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2541 * xdisp.c (rows_from_pos_range): Handle the case where the
2542 highlight ends on a newline. (Bug#10464)
2543 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2544 he end column for display of highlight that ends on a newline
2547 2012-01-11 Glenn Morris <rgm@gnu.org>
2549 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2550 from load-path also when installation-directory is nil. (Bug#10208)
2552 2012-01-10 Glenn Morris <rgm@gnu.org>
2554 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2556 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2557 Update template values to be closer to their typical values these days.
2559 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2561 * xdisp.c (rows_from_pos_range): Accept additional argument
2562 DISP_STRING, and accept any glyph in a row whose object is that
2563 string as eligible for mouse highlight. Fixes mouse highlight of
2564 display strings from overlays. (Bug#10464)
2566 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2568 emacs: fix an auto-save permissions race condition (Bug#10400)
2569 * fileio.c (auto_saving_dir_umask): New static var.
2570 (Fmake_directory_internal): Use it.
2571 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2572 creating the directory. The old code temporarily assigns
2573 too-generous permissions to the directory.
2574 (do_auto_save_eh): Clear it.
2575 (Fdo_auto_save): Catch all errors, not just file errors, so
2576 that the var is always cleared.
2578 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2580 * search.c (scan_buffer): Pass character positions to
2581 know_region_cache, not byte positions. (Bug#6540)
2583 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2585 * w32.c (sys_rename): Report EXDEV when rename of a directory
2586 fails because the target is on another logical disk. (Bug#10284)
2588 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2590 * xterm.c (x_embed_request_focus): New function.
2592 * xterm.h: Add prototype.
2594 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2596 2012-01-05 Glenn Morris <rgm@gnu.org>
2598 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2600 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2602 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2603 Load gnutls_transport_set_lowat only if GnuTLS version is below
2605 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2606 GnuTLS versions below 2.11.1.
2608 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2610 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2611 to the doc string advising against its use for altering the way
2612 windows are scrolled.
2614 2011-12-28 Kenichi Handa <handa@m17n.org>
2616 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2617 coding-system ASCII compatible only when it does not produce BOM
2618 on encoding (Bug#10383).
2620 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2622 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2624 (create_and_show_popup_menu): Always use menu_position_func for
2627 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2629 * callint.c (Fcall_interactively): Don't truncate prompt string.
2631 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2633 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2634 property that ends at ZV, so that the bidi iteration could be
2635 resumed from there (after widening). (Bug#10360)
2637 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2639 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2641 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2643 * nsterm.m (x_free_frame_resources):
2644 Release f->output_data.ns->miniimage.
2645 (ns_index_color): Fix indentation. Do not retain
2646 color_table->colors[i].
2648 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2651 * nsfns.m (x_set_background_color): Assign return value from
2652 ns_index_color to face-background instead of NSColor*.
2653 (ns_implicitly_set_icon_type): Fix indentation.
2654 Change assignment in for loop to comparison.
2656 * emacs.c (ns_pool): New variable.
2657 (main): Assign ns_pool.
2658 (Fkill_emacs): Call ns_release_autorelease_pool.
2660 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2661 autorelease fdesc, release fdAttrs and tdict.
2662 (ns_get_covering_families): Release charset.
2663 (ns_findfonts): Release NSFontDescriptor created with new.
2664 (ns_uni_to_glyphs): Fix indentation.
2665 (setString): Release attrStr before assigning new value.
2667 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2669 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2671 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2672 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2674 2011-12-18 David Reitter <reitter@cmu.edu>
2676 * nsterm.m (ns_term_init): Subscribe for notifications
2677 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2678 to method trackingNotification in EmacsMenu.
2680 * nsmenu.m (trackingMenu): New variable.
2681 (trackingNotification): New method (from Aquamacs).
2682 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2683 from Aquamacs (Bug#7030).
2685 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2687 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2688 (symbol_to_nsstring): Fix indentation.
2689 (ns_symbol_to_pb): New function.
2690 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2691 (Fns_rotate_cut_buffers_internal): Remove.
2692 (Fns_store_selection_internal): Rename from
2693 Fns_store_cut_buffer_internal.
2694 (ns_get_foreign_selection, Fx_own_selection_internal)
2695 (Fx_disown_selection_internal, Fx_selection_exists_p)
2696 (Fns_get_selection_internal, Fns_store_selection_internal):
2697 Use ns_symbol_to_pb and check if return value is nil.
2698 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2699 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2700 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2701 renamed to Sns_store_selection_internal.
2702 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2703 and remove this function.
2704 (ns_handle_selection_clear): Remove, never used.
2705 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2708 2011-12-17 Ken Brown <kbrown@cornell.edu>
2710 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2711 GID is unknown (Bug#10257).
2713 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2715 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2716 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2717 which caused a build failure on GNU/Linux IA-64. This problem was
2718 introduced by my 2011-10-07 patch.
2720 2011-12-15 Juri Linkov <juri@jurta.org>
2722 * image.c (imagemagick_error): New function. (Bug#10112)
2723 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2724 Use `imagemagick_error' where ImageMagick functions return
2726 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2729 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2731 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2732 fill background (Bug#8992).
2734 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2736 * window.c (Vwindow_combination_resize)
2737 (Vwindow_combination_limit): Use t instead of non-nil in
2739 (Vrecenter_redisplay): Add first sentence of doc-string on
2741 (Frecenter): Fix doc-string typo.
2743 2011-12-11 Kenichi Handa <handa@m17n.org>
2745 * coding.c (Funencodable_char_position): Pay attention to the
2746 buffer text relocation (Bug#9389).
2748 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2750 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2751 gtk_init (Bug#10100).
2753 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2755 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2756 IT->string is nil. (Bug#10263)
2758 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2760 * nsterm.h (x_free_frame_resources): Declare.
2762 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2763 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2765 * nsterm.h (ns_get_defaults_value): Declare.
2767 * nsterm.m (ns_default): Call ns_get_defaults_value.
2769 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2771 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2774 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2776 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2777 that where the value of an _OBJC_* symbol points to is in the .bss
2778 section (Bug#10240).
2780 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2782 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2783 after the loop to call ccl_driver at least once (Bug#8619).
2785 2011-12-08 Kenichi Handa <handa@m17n.org>
2787 * ftfont.c (get_adstyle_property): Fix previous change
2790 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2792 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2793 dirs from the default value of EMACSLOADPATH (bug#10208).
2795 2011-12-07 Glenn Morris <rgm@gnu.org>
2797 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2798 installation and source directories as well. (Bug#10208)
2800 2011-12-06 Chong Yidong <cyd@gnu.org>
2802 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2804 2011-12-06 Glenn Morris <rgm@gnu.org>
2806 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2807 as an error, not just -1. (Bug#10217)
2809 2011-12-05 Chong Yidong <cyd@gnu.org>
2811 * keyboard.c (process_special_events): New function.
2812 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2814 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2816 * coding.c (encode_designation_at_bol): Don't use uninitialized
2817 local variable (Bug#9318).
2819 2011-12-05 Kenichi Handa <handa@m17n.org>
2821 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2822 return Qnil (Bug#8046, Bug#10193).
2824 2011-12-05 Kenichi Handa <handa@m17n.org>
2826 * coding.c (encode_designation_at_bol): New args charbuf_end and
2827 dst. Return the number of produced bytes. Callers changed.
2828 (coding_set_source): Return how many bytes coding->source was
2830 (coding_set_destination): Return how many bytes
2831 coding->destination was relocated.
2832 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2833 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2835 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2837 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2838 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2841 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2843 The following changes are to fix Bug#9318.
2845 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2846 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2847 (encode_coding_iso_2022, encode_coding_sjis)
2848 (encode_coding_big5, encode_coding_charset): Use the above macros.
2850 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2852 * lisp.h (process_quit_flag): Fix external declaration.
2854 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2856 Don't macro-inline non-performance-critical code.
2857 * eval.c (process_quit_flag): New function.
2858 * lisp.h (QUIT): Use it.
2860 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2862 * nsfns.m (get_geometry_from_preferences): New function.
2863 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2865 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2867 * emacs.c (Qkill_emacs): Define.
2868 (syms_of_emacs): Initialize it.
2869 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2870 Qquit_flag to `kill-emacs' instead.
2871 (quit_throw_to_read_char): Add parameter `from_signal'.
2872 All callers changed. Call Fkill_emacs if requested and safe.
2873 * lisp.h (QUIT): Call Fkill_emacs if requested.
2875 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2877 * widget.c (update_wm_hints): Return if wmshell is null.
2878 (widget_update_wm_size_hints): New function.
2880 * widget.h (widget_update_wm_size_hints): Declare.
2882 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2883 widget_update_wm_size_hints (Bug#10104).
2885 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2887 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2888 before a newline, prepare the bidi iterator for consuming the
2889 newline, and keep the current paragraph direction. (Bug#10183)
2890 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2892 2011-12-02 Juri Linkov <juri@jurta.org>
2894 * search.c (Fword_search_regexp): New Lisp function created from
2895 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2896 (Fword_search_backward, Fword_search_forward)
2897 (Fword_search_backward_lax, Fword_search_forward_lax):
2898 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2899 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2901 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2903 * fileio.c (Finsert_file_contents): Move after-change-function call
2904 to before the "handled:" label, since all "goto handled" appear in
2905 cases where the *-change-functions have already been properly called
2908 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2910 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2911 waiting for input. (Bug#10169)
2913 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2915 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2916 verifies glyph row's hash code--we have just reallocated the
2917 glyphs, so their contents can be complete garbage. (Bug#10164)
2919 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2921 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2923 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2925 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2926 attributes are tested _before_ calling verify_row_hash, to protect
2927 against GCC re-ordering of the tests. (Bug#10164)
2929 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2931 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2933 * xterm.c (handle_one_xevent): Only set async_visible and friends
2934 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2935 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2936 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2938 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2940 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2941 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2942 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2943 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2944 All uses changed to use GCPRO1 etc.
2945 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2946 Revert to old implementation (i.e., before 2011-03-11).
2948 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2950 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2951 of scroll runs so as to avoid assigning disabled bogus rows and
2952 unnecessary graphics copy operations.
2954 2011-11-27 Eli Zaretskii <eliz@gnu.org>
2956 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2957 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2958 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2959 (malloc, free, realloc, calloc): Redirect to e_* only when
2962 * lisp.h (GCTYPEBITS): Move before first use.
2963 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2964 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2965 this macro definition.
2967 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2970 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2972 * gtkutil.c (xg_create_frame_widgets):
2973 Call gtk_window_set_has_resize_grip (FALSE) if that function is
2974 present with Gtk+ 2.0.
2976 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2978 * fileio.c (Finsert_file_contents): Undo previous change; see
2979 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2981 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2983 Rename locals to avoid shadowing.
2984 * fileio.c (Finsert_file_contents):
2985 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2986 * process.c (wait_reading_process_output):
2987 Rename inner 'proc' to 'p' to avoid shadowing.
2988 Indent for consistency with usual Emacs style.
2990 2011-11-25 Eli Zaretskii <eliz@gnu.org>
2992 * xdisp.c (redisplay_window): If cursor row is not fully visible
2993 after recentering, and scroll-conservatively is set to a large
2994 number, scroll window by a few more lines to make the cursor fully
2995 visible and out of scroll-margin. (Bug#10105)
2996 (start_display): Don't move to the next line if the display should
2997 start at a newline that is part of a display vector or an overlay
3000 2011-11-24 Juri Linkov <juri@jurta.org>
3002 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3003 after the `MagickPingImage' call. (Bug#10112)
3005 2011-11-23 Chong Yidong <cyd@gnu.org>
3007 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3009 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3011 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3012 making another buffer current. (Bug#10114)
3014 2011-11-23 Glenn Morris <rgm@gnu.org>
3016 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3018 2011-11-23 Chong Yidong <cyd@gnu.org>
3020 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3021 using it (Bug#5984).
3023 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3025 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3026 and header-lines, as they don't have one computed for them.
3029 * .gdbinit (prow): Make displayed values more self-explaining.
3030 Add row's hash code.
3032 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3034 * process.c (wait_reading_process_output): Fix asynchrounous
3035 GnuTLS socket handling on some versions of the GnuTLS library.
3036 (wait_reading_process_output): Add comment and URL.
3038 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3040 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3042 2011-11-21 Chong Yidong <cyd@gnu.org>
3044 * window.c (Fnext_window, Fprevious_window): Doc fix.
3046 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3048 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3050 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3052 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3054 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3056 * window.c (Fset_window_combination_limit): Rename argument
3058 (Vwindow_combination_limit): Remove "status" from doc-string.
3060 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3062 * m/ibms390.h: Remove.
3063 * m/ibms390x.h: Don't include "ibms390.h".
3065 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3067 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3068 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3070 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3072 * casetab.c (Fset_case_table):
3073 * charset.c (Fcharset_after): Fix typos.
3075 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3077 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3078 Otherwise, valgrind does not work on some platforms.
3079 Problem reported by Andreas Schwab in
3080 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3081 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3082 is set, removing the need for VIRT_ADDRESS_VARIES.
3083 (PURE_P): Use a more-efficient implementation that needs just one
3084 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3085 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3086 to 4 (xorl, subq, cmpq, setbe).
3087 * alloc.c (pure): Always extern now, since that's the
3088 VIRT_ADDR_VARIES behavior.
3089 (PURE_POINTER_P): Use a single comparison, not two, for
3090 consistency with the new puresize.h.
3091 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3092 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3093 Remove VIRT_ADDR_VARIES no longer needed.
3095 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3097 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3098 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3099 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3100 behave as if the cursor position were at the window margin.
3102 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3103 and the cursor position is out of bounds, behave as if the cursor
3104 position were at the window margin. (Bug#10075)
3106 2011-11-18 Chong Yidong <cyd@gnu.org>
3108 * window.c (Fwindow_combination_limit): Make first argument
3109 non-optional, since it is meaningless for live windows like the
3112 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3114 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3116 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3118 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3119 (graft_intervals_into_buffer): Simplify.
3121 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3123 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3124 hash values of the two rows.
3125 (copy_row_except_pointers): Preserve the used[] arrays and the
3126 hash values of the two rows. (Bug#10035)
3127 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3129 * xdisp.c (row_hash): New function, body extracted from
3130 compute_line_metrics.
3131 (compute_line_metrics): Call row_hash, instead of computing the
3134 * dispnew.c (verify_row_hash): Call row_hash for computing the
3135 hash code of a row, instead of duplicating code from xdisp.c.
3137 * dispextern.h (row_hash): Add prototype.
3139 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3141 * frame.c (delete_frame): Don't delete the terminal when the last
3142 X frame is closed if emacs is built with GTK toolkit.
3144 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3146 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3148 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3150 * window.c (Vwindow_splits): Rename to
3151 Vwindow_combination_resize. Suggested by Juri Linkov.
3152 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3155 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3157 * nsfns.m (Fns_font_name):
3158 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3160 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3162 * window.h (window): Rename slot "nest" to "combination_limit".
3163 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3164 (Fset_window_nest): Rename to Fset_window_combination_limit.
3165 (Vwindow_nest): Rename to Vwindow_combination_limit.
3166 (recombine_windows, make_parent_window, make_window)
3167 (Fsplit_window_internal, saved_window)
3168 (Fset_window_configuration, save_window_save): Rename all
3169 occurrences of window_nest to window_combination_limit.
3171 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3173 * image.c (imagemagick_load_image): Fix typo.
3175 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3177 * xdisp.c (display_line): Move the call to
3178 highlight_trailing_whitespace before the call to
3179 compute_line_metrics, since the latter needs to see the final
3180 faces of all the glyphs to compute ROW's hash value.
3181 Fixes assertion violations in row_equal_p. (Bug#10035)
3183 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3185 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3186 just return (bug#10044).
3188 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3190 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3191 with user-defined heap size. Bump the default size of the temacs
3192 heap to 27MB, to avoid memory warning when running temacs.
3193 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3195 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3196 current_matrix and desired_matrix. (Bug#9990)
3197 (verify_row_hash) [XASSERTS]: New function.
3198 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3199 that the hash value of glyph rows is correct.
3201 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3203 * window.h (window): Remove splits slot.
3204 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3205 (Fdelete_other_windows_internal, make_parent_window)
3206 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3207 (Fset_window_configuration, save_window_save): Don't deal with
3208 split status of windows.
3209 (saved_window): Remove splits slot.
3210 (Vwindow_splits): Rewrite doc-string.
3212 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3214 * xfns.c (unwind_create_frame):
3215 * nsfns.m (unwind_create_frame):
3216 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3217 Vframe_list (Bug#9999).
3219 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3221 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3223 2011-11-11 Kenichi Handa <handa@m17n.org>
3225 * callproc.c (Fcall_process): Set the member dst_multibyte of
3228 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3230 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3231 avoid a crash (bug#9496).
3233 2011-11-09 Chong Yidong <cyd@gnu.org>
3235 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3236 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3238 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3240 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3242 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3244 Avoid some portability problems by eschewing 'extern inline' functions.
3245 The trivial performance wins aren't worth the portability hassles; see
3246 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3248 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3249 (window_box_width, window_box_left, window_box_left_offset)
3250 (window_box_right, window_box_right_offset): Undo previous change,
3251 by removing the "extern"s.
3252 * intervals.c (adjust_intervals_for_insertion)
3253 (adjust_intervals_for_deletion): Undo previous change,
3254 making these static again.
3255 (offset_intervals, temp_set_point_both, temp_set_point)
3256 (copy_intervals_to_string): No longer inline.
3257 * xdisp.c (window_text_bottom_y, window_box_width)
3258 (window_box_height, window_box_left_offset)
3259 (window_box_right_offset, window_box_left, window_box_right)
3260 (window_box): No longer inline.
3262 2011-11-08 Chong Yidong <cyd@gnu.org>
3264 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3265 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3266 Signal an error if not a live window.
3267 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3268 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3270 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3272 * lisp.h (syms_of_abbrev): Remove declaration.
3273 Reported by CHENG Gao <chenggao@royau.me>.
3275 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3277 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3278 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3279 of temacs in GUI mode.
3281 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3283 * window.h: Declare delete_all_child_windows instead of
3284 delete_all_subwindows.
3285 * window.c (Fwindow_nest, Fset_window_nest)
3286 (Fset_window_new_total, Fset_window_new_normal)
3287 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3288 (delete_all_subwindows): Rename to delete_all_child_windows.
3289 (Fdelete_other_windows_internal, Fset_window_configuration):
3290 Call delete_all_child_windows instead of delete_all_subwindows.
3291 * frame.c (delete_frame): Call delete_all_child_windows instead
3292 of delete_all_subwindows.
3294 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3296 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3297 This is also needed for porting to any host where GC_MARK_STACK is
3298 not GC_MAKE_GCPROS_NOOPS.
3299 (which_symbols): Use it.
3301 2011-11-07 Kenichi Handa <handa@m17n.org>
3303 * coding.c (coding_set_destination): Check coding->src_pos only
3304 when coding->src_object is a buffer (bug#9910).
3306 * process.c (send_process): Set the member src_multibyte of coding
3307 to 0 (bug#9911) when sending a unibyte text.
3309 * callproc.c (Fcall_process): Set the member src_multibyte of
3310 process_coding to 0 (bug#9912).
3312 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3314 * xmenu.c (cleanup_widget_value_tree): New function.
3315 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3316 calling free_menubar_widget_value_tree directly (Bug#9830).
3318 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3320 Fix some portability problems with 'inline'.
3321 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3322 (window_box_width, window_box_left, window_box_left_offset)
3323 (window_box_right, window_box_right_offset): Declare extern.
3324 Otherwise, these inline functions do not conform to C99 and
3325 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3326 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3327 * intervals.c (adjust_intervals_for_insertion)
3328 (adjust_intervals_for_deletion): Now extern, because otherwise the
3329 extern inline functions 'offset_intervals' couldn't refer to it.
3330 (static_offset_intervals): Remove.
3331 (offset_intervals): Rewrite using the old contents of
3332 static_offset_intervals. The old version didn't conform to C99
3333 because an extern inline function contained a reference to an
3334 identifier with static linkage.
3336 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3338 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3341 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3343 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3344 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3345 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3346 return Qleft_to_right.
3348 2011-11-06 Chong Yidong <cyd@gnu.org>
3350 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3351 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3352 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3353 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3354 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3355 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3356 (Fwindow_vscroll): Doc fix.
3357 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3358 argument, since it makes no sense to pass a live window and for
3359 consistency with window-child.
3361 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3363 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3366 2011-11-05 Jason Rumney <jasonr@gnu.org>
3368 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3369 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3371 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3372 bitwise arithmetic preventing use of unicode-sip and non-truetype
3375 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3377 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3380 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3381 initialization code to keep similarity to xfns.c after changes
3384 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3386 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3387 (unwind_create_frame): New function (Bug#9943).
3388 (Fx_create_frame): Restructure code to be more similar to the one in
3389 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3390 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3391 Move terminal->reference_count++ just before making the frame official
3394 * nsterm.m (x_free_frame_resources): New function.
3395 (x_destroy_window): Move code to x_free_frame_resources.
3397 * xfns.c (unwind_create_frame): Fix comment.
3398 (Fx_create_frame, x_create_tip_frame):
3399 Move terminal->reference_count++ just before making the frame
3400 official. Move initialization of image_cache_refcount and
3401 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3403 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3405 Support MSVC build with newer versions of Visual Studio.
3406 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3407 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3410 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3411 which are not supported by MSVC.
3412 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3413 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3415 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3417 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3419 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3421 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3423 Support MSVC build with newer versions of Visual Studio.
3424 * w32.c: Don't include w32api.h for MSVC.
3425 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3427 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3428 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3429 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3430 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3432 (alloca) [_MSC_VER]: Define to _alloca.
3434 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3436 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3438 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3440 * xdisp.c (note_mouse_highlight): If either of
3441 previous/next-single-property-change returns nil, treat that as
3442 the beginning or the end of the buffer. (Bug#9955)
3444 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3446 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3447 label is not null (Bug#9951).
3448 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3451 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3453 * window.c (Fwindow_body_size): Mention in the doc string that the
3454 return value is in frame's canonical units. (Bug#9949)
3456 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3458 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3460 * w32fns.c (unwind_create_frame): If needed, free the glyph
3461 matrices of the partially constructed frame. (Bug#9943)
3462 * xfns.c (unwind_create_frame): Likewise.
3464 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3466 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3467 Don't stop backward scan on the continuation glyph, even though
3468 its CHARPOS is positive.
3469 (mouse_face_from_buffer_pos, note_mouse_highlight):
3470 Rename cover_string to disp_string.
3472 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3474 * window.c (temp_output_buffer_show): Don't use
3475 Vtemp_buffer_show_specifiers.
3476 (Vtemp_buffer_show_specifiers): Remove unused variable.
3478 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3480 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3481 past the beginning of the current glyph matrix.
3483 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3485 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3486 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3487 HAVE_GTK3 (Bug#9869).
3489 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3490 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3492 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3494 * xterm.c: Declare x_handle_net_wm_state to return int.
3495 (handle_one_xevent): Check if we are iconified but don't have
3496 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3497 (get_current_wm_state): Return non-zero if not hidden,
3498 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3499 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3500 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3501 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3503 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3505 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3506 so that this new function doesn't get optimized away by a
3507 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3509 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3511 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3513 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3515 Fix the `xbytecode' command.
3516 * .gdbinit (xprintbytestr): New command.
3517 (xwhichsymbols): Rename from `which'; all callers changed.
3518 (xbytecode): Print the byte-code string as well.
3520 2011-10-29 Kim Storm <storm@cua.dk>
3522 * alloc.c (which_symbols): New function.
3524 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3526 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3529 2011-10-29 Glenn Morris <rgm@gnu.org>
3531 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3532 Not clear what it was for, and it causes various bugs. (Bug#9839)
3534 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3536 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3537 possible random value that matches one of those tested as
3538 condition to clear the mouse face.
3540 2011-10-28 Chong Yidong <cyd@gnu.org>
3542 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3544 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3546 * window.c (make_window): Initialize phys_cursor_on_p.
3548 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3550 * lisp.h (struct Lisp_Symbol): Update comments.
3552 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3554 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3556 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3558 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3559 <oslsachem@gmail.com> for helping to debug this.
3561 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3562 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3563 (g_b_init_get_glyph_outline_w): New static variables.
3564 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3565 (GetGlyphOutlineW_Proc): New typedefs.
3566 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3567 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3569 (w32font_open_internal, compute_metrics):
3570 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3571 instead of calling the "wide" APIs directly.
3573 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3575 * w32.h (syms_of_w32font): Add prototype.
3577 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3579 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3580 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3581 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3582 (Fmove_to_window_line): Doc fix.
3584 2011-10-27 Chong Yidong <cyd@gnu.org>
3586 * process.c (make_process): Set gnutls_state to NULL.
3588 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3589 non-NULL, regardless of GNUTLS_INITSTAGE.
3590 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3591 an error. Set process slots as soon as we allocate them.
3593 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3595 2011-10-27 Chong Yidong <cyd@gnu.org>
3597 * gnutls.c (emacs_gnutls_deinit): New function.
3598 Deallocate credentials structures as well as calling gnutls_deinit.
3599 (Fgnutls_deinit, Fgnutls_boot): Use it.
3601 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3602 (deactivate_process): Call emacs_gnutls_deinit.
3604 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3606 * image.c (x_create_x_image_and_pixmap):
3607 * w32.c (sys_rename, w32_delayed_load):
3608 * w32font.c (fill_in_logfont):
3609 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3611 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3613 * w32fns.c (w32_default_color_map): New function,
3614 extracted from Fw32_default_color_map.
3615 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3617 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3619 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3621 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3623 * keyboard.c (test_undefined): New function (bug#9751).
3624 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3626 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3628 * sysdep.c (init_sys_modes): Fix the check for the controlling
3629 terminal (Bug#6649).
3631 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3633 * dispextern.h (struct bidi_it): New member next_en_type.
3635 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3636 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3637 current character, check also for next_en_type being WEAK_EN.
3638 (bidi_resolve_weak): Don't enter the expensive loop if the current
3639 position is before next_en_pos. Record the bidi type of the first
3640 non-ET, non-BN character we find, in addition to its position.
3641 (bidi_level_of_next_char): Invalidate next_en_type when
3642 next_en_pos is over-stepped.
3644 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3646 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3647 * editfns.c: Rewrite current-time-zone so that it invokes
3648 the equivalent of (format-time-string "%Z") to get the time zone name.
3649 This fixes a bug when the time zone name contains characters that
3650 need converting from the system time locale to Emacs internal format.
3651 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3652 that patch fixed format-time-string to do the conversion, but
3653 I forgot to fix current-time-zone.
3654 (format_time_string): New function, containing most of
3655 what Fformat_time_string used to contain.
3656 (Fformat_time_string): Rewrite in terms of format_time_string.
3657 This doesn't change this function's behavior.
3658 (current-time-zone): Rewrite to use format_time_string.
3659 This fixes the bug reported by Michael Schierl in
3660 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3661 Jason Rumney's 2007-06-07 change worked around this bug, but
3663 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3665 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3667 * xdisp.c (start_display): If the character at POS is displayed
3668 via a display vector, reset IT->current.dpvec_index to zero.
3669 (try_window_reusing_current_matrix): If a line ends in a display
3670 vector or the next line starts in a display vector, continue
3671 redrawing the window even though the character position of
3672 start_row was reached.
3675 2011-10-18 Chong Yidong <cyd@gnu.org>
3677 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3678 with nobreak-char-display too.
3680 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3682 Fix part 3 of bug#9771.
3683 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3684 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3685 non-neutral characters if the current character is a paragraph
3686 separator (a.k.a. Newline). This avoids running the same
3687 expensive loop twice, once when we consume the preceding newline
3688 and the other time when the line actually needs to be displayed.
3689 Avoid the loop when we see neutrals on the base embedding level
3690 following a character whose directionality is the same as the
3691 paragraph's. This avoids running the expensive loop when a line
3692 ends in a long sequence of neutrals, like control characters.
3693 Add assertion against STRONG_AL type. Slightly rearrange code
3694 that determines the type of a neutral given the first non-neutral
3696 (bidi_level_of_next_char): Set next_en_pos to zero when
3697 invalidating its info.
3699 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3701 * xdisp.c (push_display_prop): Determine whether to record string
3702 or buffer position by IT->string, not by IT->method. Allow
3703 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3704 (move_it_vertically_backward): Don't look for character position
3705 immediately after the newline when in a continuation line.
3708 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3710 * window.c (coordinates_in_window): Rewrite and delabelize
3711 vertical border check. (Bug#5357) (Bug#9618)
3713 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3715 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3716 errors in XSetWindowBorder (bug#9310).
3718 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3720 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3721 avoid crash when xmalloc overrun checking is enabled.
3723 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3725 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3726 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3727 cursor motion with <left> and <right> arrow keys.
3729 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3730 some callers set that themselves.
3732 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3734 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3735 display string and the previous row comes from the same string and
3736 is empty. (Bug#9739) (Bug#9738)
3738 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3740 * doc.c (get_doc_string): Encode file name (bug#9735).
3742 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3744 * bidi.c (bidi_level_of_next_char):
3745 * xdisp.c (get_visually_first_element): Remove old incorrect
3746 comments regarding the Unicode Line Separator character.
3748 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3750 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3752 * alloc.c (Fgc_status): Do not access beyond zombies array
3753 boundary if nzombies > MAX_ZOMBIES.
3754 * alloc.c (dump_zombies): Add missing format specifier.
3756 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3758 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3759 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3761 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3762 Some packages use them to denote characters with modifiers.
3764 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3766 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3767 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3768 matching a pp-number. Rename parameter var to var1.
3770 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3772 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3774 2011-10-08 Glenn Morris <rgm@gnu.org>
3776 * callint.c (Fcall_interactively): Give a more explicit error for the
3777 'c' case with a non-character input. (Bug#8479)
3779 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3781 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3783 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3784 lines that are hscrolled on the left.
3786 * dispnew.c (buffer_posn_from_coords): Account for a possible
3787 presence of header-line. (Bug#4426)
3789 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3791 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3792 Don't advertise functionality which we discourage or doesn't work.
3794 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3796 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3797 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3798 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3799 this makes Emacs dump core during garbage collection on rare
3800 occasions. sizeof is obviously inferior to offsetof here, so
3801 stick with offsetof.
3802 (GC_POINTER_ALIGNMENT): New macro.
3803 (mark_memory): Omit 3rd (offset) arg; caller changed.
3804 Don't assume EMACS_INT alignment is the same as pointer alignment.
3806 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3808 * keyboard.c (read_key_sequence_remapped): New var.
3809 (read_key_sequence): Compute remapping in the right buffer.
3810 (command_loop_1): Use read_key_sequence's remapping directly.
3812 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3814 * dired.c (file_name_completion): Don't expand file name.
3815 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3816 before checking file name handler.
3818 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3819 they've been requested explicitly (bug#9591).
3821 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3823 * keymap.c (Fsingle_key_description): Use make_specified_string
3824 instead of build_string to build string from push_key_description.
3827 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3829 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3830 This fixes a Y2038 bug on 64-bit hosts.
3831 * buffer.c (reset_buffer):
3832 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3833 (Fclear_buffer_auto_save_failure):
3834 Use 0, not -1, to represent an unset failure time, since time_t
3835 might not be signed.
3837 Remove dependency on glibc malloc internals.
3838 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3839 Move back here from lisp.h, but with their new implementations.
3840 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3841 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3842 * charset.c (charset_table_init): New static var.
3843 (syms_of_charset): Use it instead of xmalloc. This removes a
3844 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3845 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3846 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3847 Move back to alloc.c.
3848 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3849 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3851 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3853 * nsterm.m (windowDidResize): Call x_set_window_size only when
3854 ns_in_resize is true. Otherwise set pixelwidth/height and
3855 call change_frame_size (Bug#9628).
3857 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3859 Port --enable-checking=all to Fedora 14 x86-64.
3860 * charset.c (syms_of_charset): Also account for glibc malloc's
3861 internal overhead when calculating the initial malloc maximum.
3863 Port --enable-checking=all to Fedora 14 x86.
3864 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3866 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3867 (overrun_check_realloc, overrun_check_free):
3868 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3869 That way, xmalloc returns a properly-aligned pointer even if
3870 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3871 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3872 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3873 into account when calculating the initial malloc maximum.
3874 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3875 Move here from alloc.c, so that charset.c can use it too.
3876 Properly align; the old code wasn't right for common 32-bit hosts
3877 when configured with --enable-checking=all.
3878 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3879 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3881 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3883 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3886 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3888 * xdisp.c (compute_display_string_end): If there's no display
3889 string at CHARPOS, return -1.
3891 * bidi.c (bidi_fetch_char): When compute_display_string_end
3892 returns a negative value, treat the character as a normal
3893 character not covered by a display string. (Bug#9624)
3895 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3897 * lread.c (Fread_from_string): Fix typo in docstring.
3899 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3901 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3902 newline, reseat the iterator instead of bidi-iterating there one
3903 character at a time. (Bug#9610)
3904 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3905 TO_CHARPOS if the bidi iterator is at base embedding level.
3907 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3909 * lread.c (readevalloop): Use correct code for NBSP.
3910 (read1): Likewise. (Bug#9608)
3912 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3914 * dbusbind.c (Fdbus_register_signal): When service is not
3915 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3917 2011-09-25 Glenn Morris <rgm@gnu.org>
3919 * buffer.c (truncate-lines): Doc fix.
3921 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3923 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3924 (Fset_window_next_buffers): Doc fix.
3926 2011-09-24 Glenn Morris <rgm@gnu.org>
3928 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3930 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3932 Fix minor problems found by static checking.
3933 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3934 * indent.c (Fvertical_motion): Fix == vs = typo.
3936 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3938 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3939 Default value is now t. Doc fix.
3941 * indent.c (Fvertical_motion): Compute and apply the overshoot
3942 logic when moving up, not only when moving down. Fix the
3943 confusing name and values of the it_overshoot_expected variable;
3944 logic changes accordingly. (Bug#9254) (Bug#9549)
3946 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3947 CHARPOS is covered by a display string which includes newlines.
3948 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3949 is covered by a display string with embedded newlines.
3951 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3953 * dbusbind.c (Fdbus_register_signal): Add match rule to
3954 Vdbus_registered_objects_table. (Bug#9581)
3955 (Fdbus_register_method, Vdbus_registered_objects_table):
3958 2011-09-24 Jim Meyering <meyering@redhat.com>
3960 do not ignore write error for any output size
3961 The previous change was incomplete.
3962 While it makes emacs --batch detect the vast majority of stdout
3963 write failures, errors were still ignored whenever the output size is
3964 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3965 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3966 && echo FAIL: ignored write error
3967 FAIL: ignored write error
3968 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3969 && echo FAIL: ignored write error
3970 FAIL: ignored write error
3971 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3973 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3975 * emacs.c (Fkill_emacs): In noninteractive mode exit
3976 non-successfully if a write error occurred on stdout. (Bug#9574)
3978 2011-09-21 Eli Zaretskii <eliz@gnu.org>
3980 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3983 * dispextern.h (struct it): Update the comment documenting what
3986 2011-09-20 Eli Zaretskii <eliz@gnu.org>
3988 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3989 a display string, extend search for cursor position to end of row.
3990 (find_row_edges): If the row ends in a newline from a display
3991 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3992 Handle the case of a display string with multiple newlines.
3993 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3994 non-empty line. Fixes confusing cursor motion with arrow keys at
3995 the beginning of a line that starts with whitespace.
3997 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3999 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4002 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4004 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4007 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4009 * xdisp.c (display_line): Record maximum and minimum buffer
4010 positions even if no glyphs were produced (e.g., by a zero-width
4011 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4012 buffer positions that will be removed from the glyph row because
4014 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4015 column is beyond frame width: don't subtract 1 "pixel" when
4016 computing width of the stretch.
4017 (reseat_at_next_visible_line_start): Undo the change made on
4018 2011-09-17 that saved paragraph information and restored it after
4019 the call to `reseat'. (Bug#9545)
4021 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4023 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4024 and turn window cursor on if cleared (Bug#9415).
4026 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4028 * search.c (boyer_moore): Take unibyte characters from pattern
4029 literally. (Bug#9458)
4031 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4033 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4035 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4037 Fix minor problem found by static checking.
4038 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4039 initialized, to pacify gcc -Wuninitialized.
4041 * fileio.c: Report proper errno when syscall falls.
4042 (Finsert_file_contents): Save and restore errno,
4043 so that report_file_error outputs the correct diagnostic.
4044 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4046 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4048 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4050 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4052 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4053 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4055 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4057 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4058 about the current paragraph and restore it after the call to reseat.
4060 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4061 (bidi_find_paragraph_start): Search back for paragraph beginning
4062 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4063 (bidi_move_to_visually_next): Only trigger paragraph-related
4064 computations when the last character is a newline or at EOB, not
4065 just any NEUTRAL_B. (Bug#9470)
4067 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4068 truncated lines if point is covered by a display string. (Bug#9524)
4070 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4072 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4073 (cons_to_x_long): New function.
4074 (lisp_data_to_selection_data): Use it. Correct the test for
4075 short-versus-long data; it was negated. Break out of vector
4076 loop, for efficiency, when a long datum is discovered.
4078 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4080 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4082 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4084 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4085 GCC PR/17406) by declaring this function with external scope.
4087 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4089 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4090 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4092 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4094 * editfns.c (Fformat): Correctly handle text properties on "%%".
4096 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4098 * xterm.c (x_draw_composite_glyph_string_foreground):
4099 * w32term.c (x_draw_composite_glyph_string_foreground):
4100 * term.c (encode_terminal_code):
4101 * composite.c (composition_update_it, get_composition_id):
4102 * xdisp.c (get_next_display_element)
4103 (fill_composite_glyph_string): Add comments about special meaning
4104 of TAB characters in a composition.
4106 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4108 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4109 This occurs when processing a multibyte format.
4110 Problem reported by Wolfgang Jenker.
4112 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4114 * xdisp.c (try_cursor_movement): Only check for exact match if
4115 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4117 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4119 Remove unused external symbols.
4120 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4121 * xdisp.c (calc_pixel_width_or_height): Now static.
4122 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4123 * indent.c (check_display_width):
4124 * w32term.c: Fix comment to match code.
4125 * xterm.c, xterm.h (x_catching_errors): Remove.
4127 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4129 * xselect.c: Use signed conversions more consistently (Bug#9498).
4130 (selection_data_to_lisp_data): Assume incoming selection data are
4131 signed integers, not unsigned. This is to be consistent with
4132 outgoing selection data, which was modified to use signed integers
4133 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4134 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4135 expects long, not unsigned long.
4137 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4139 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4140 computation of loop end. Reported by Johan Bockgård
4143 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4145 * frame.c (Fother_visible_frames_p): Function deleted.
4147 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4149 * indent.c (compute_motion): Process display vector front to back
4150 rather than the other way around. (Bug#2496)
4152 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4154 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4156 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4158 * minibuf.c (Fread_from_minibuffer): Doc fix.
4160 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4162 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4163 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4165 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4167 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4168 value for non-existent files.
4170 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4172 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4173 set its "size" to -1. This will set the modtime_size field of
4174 the corresponding buffer to -1, which is what
4175 verify-visited-file-modtime expects for files that do not exist.
4178 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4180 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4182 * lisp.h: ... from here. push_key_description is no longer
4183 defined in keyboard.c, so its declaration should not be in
4184 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4185 logically belongs with push_key_description.
4187 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4189 * buffer.h: Include <sys/types.h> instead of <time.h>.
4190 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4191 Problem reported by Herbert J. Skuhra.
4193 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4195 * xml.c (parse_region): Make the parsing work for
4196 non-comment-starting XML files again (bug#9144).
4198 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4200 * image.c (gif_load): Fix calculation of bottom and right corner.
4203 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4205 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4206 redisplay in small windows.
4208 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4210 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4212 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4214 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4215 Operate on live windows only.
4217 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4219 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4221 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4223 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4224 only under bidi iteration.
4226 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4228 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4230 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4232 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4233 Without this fix, the command to link temacs failed due to an
4234 undefined symbol __builtin_isnan. This is because
4235 /usr/include/iso/math_c99.h #defines isnan(x) to
4236 __builtin_isnan(x), but the bundled gcc, which identifies itself
4237 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4239 * floatfns.c (isnan): #undef, and then #define to a clone of
4241 (Fisnan): Always define, since it's always available now.
4242 (syms_of_floatfns): Always define isnan at the Lisp level.
4244 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4246 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4248 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4250 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4251 The previous code assumed that file offsets (off_t values) fit in
4252 EMACS_INT variables, which is not true on typical 32-bit hosts.
4253 The code messed up by falsely reporting buffer overflow in cases
4254 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4255 when "big" contains more than 2**29 bytes, even though this
4256 inserts just one byte and does not overflow the buffer.
4257 (Finsert_file_contents): Store file offsets as off_t
4258 values, not as EMACS_INT values. Check for overflow when
4259 converting between EMACS_INT and off_t. When checking for
4260 buffer overflow or for overlap, take the offsets into account.
4261 Don't use EMACS_INT for small values where int suffices.
4262 When checking for overlap, fix a typo: ZV was used where
4263 ZV_BYTE was intended.
4264 (Fwrite_region): Don't assume off_t fits into 'long'.
4265 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4267 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4269 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4271 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4273 sprintf-related integer and memory overflow issues (Bug#9412).
4275 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4276 (esprintf, exprintf, evxprintf): New functions.
4277 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4278 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4279 (modify_event_symbol): Do not assume that the length of
4280 name_alist_or_stem is safe to alloca and fits in int.
4281 (Fexecute_extended_command): Likewise for function name and binding.
4282 (Frecursion_depth): Wrap around reliably on integer overflow.
4283 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4284 since some callers pass EMACS_INT values.
4285 (Fsingle_key_description): Don't crash if symbol name contains more
4286 than MAX_ALLOCA bytes.
4287 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4288 (get_minibuffer): Arg is now EMACS_INT, not int.
4289 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4290 (esprintf, exprintf, evxprintf): New decls.
4291 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4293 * dbusbind.c (signature_cat): New function.
4294 (xd_signature, Fdbus_register_signal):
4295 Do not overrun buffer; instead, report string overflow.
4297 * dispnew.c (add_window_display_history): Don't overrun buffer.
4298 Truncate instead; this is OK since it's just a log.
4300 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4301 even if the time zone offset is outlandishly large.
4302 Don't mishandle offset == INT_MIN.
4304 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4305 when creating daemon; the previous buffer-overflow check was incorrect.
4307 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4308 which has the guts of the old verror function.
4310 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4311 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4313 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4314 (font_unparse_xlfd): Don't blindly alloca long strings.
4315 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4316 fits in int, when using sprintf. Use single snprintf to count
4317 length of string rather than counting it via multiple sprintfs;
4318 that's simpler and more reliable.
4319 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4320 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4321 sprintf, in case result does not fit in int.
4323 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4324 (fontset_from_font): Print it.
4326 * frame.c (tty_frame_count): Now printmax_t, not int.
4327 (make_terminal_frame, set_term_frame_name): Print it.
4328 (x_report_frame_params): In X, window IDs are unsigned long,
4329 not signed long, so print them as unsigned.
4330 (validate_x_resource_name): Check for implausibly long names,
4331 and don't assume name length fits in 'int'.
4332 (x_get_resource_string): Don't blindly alloca invocation name;
4333 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4336 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4337 (xg_check_special_colors, xg_set_geometry):
4338 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4340 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4341 Use esprintf, not sprintf, in case result does not fit in int.
4343 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4344 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4345 it as a large positive number.
4346 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4347 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4349 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4350 in case result does not fit in int.
4352 * print.c (float_to_string): Detect width overflow more reliably.
4353 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4354 buffer overrun. Don't assume list length fits in 'int'. Treat
4355 print length of 0 as 0, not as infinity; to be consistent with other
4356 uses of print length in this function. Don't overflow print length
4357 index. Don't assume hash table size fits in 'long', or that
4358 vectorlike size fits in 'unsigned long'.
4360 * process.c (make_process): Use printmax_t, not int, to format
4361 process-name gensyms.
4363 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4365 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4366 to avoid potential buffer overrun.
4368 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4369 if X resource line is longer than 512 bytes.
4371 * xfns.c (x_window): Make sprintf buffer a bit bigger
4372 to avoid potential buffer overrun.
4374 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4376 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4378 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4380 Integer overflow fixes for scrolling, etc.
4381 Without these, Emacs silently mishandles large integers sometimes.
4382 For example, "C-u 4294967297 M-x recenter" was treated as if
4383 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4385 * xdisp.c (try_window_id): Check Emacs fixnum range before
4386 converting to 'int'.
4388 * window.c (window_scroll_line_based, Frecenter):
4389 Check that an Emacs fixnum is in range before assigning it to 'int'.
4390 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4391 values converted from Emacs fixnums.
4392 (Frecenter): Don't wrap around a line count if it is out of 'int'
4393 range; instead, treat it as an extreme value.
4394 (Fset_window_configuration, compare_window_configurations):
4395 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4397 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4398 that can exceed INT_MAX. Check that EMACS_INT value is in range
4399 before assigning it to the (possibly-narrower) index.
4400 (match_limit): Don't assume that a fixnum can fit in 'int'.
4402 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4405 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4406 (Fvertical_motion): Don't wrap around LINES values that don't fit
4407 in 'int'. Instead, treat them as extreme values. This is good
4408 enough for windows, which can't have more than INT_MAX lines anyway.
4410 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4412 * Require libxml/parser.h to avoid compilation warning.
4414 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4416 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4417 since this reportedly can destroy thread storage.
4419 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4421 * syntax.c (find_defun_start): Update all cache variables if
4422 exiting early (Bug#9401).
4424 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4426 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4428 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4429 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4430 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4432 * term.c (tty_append_glyph): New function.
4433 (produce_stretch_glyph): Static function and its prototype deleted.
4435 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4438 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4440 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4441 when checking :margin (Bug#9390).
4442 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4443 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4444 so that the name doesn't mislead. All uses changed.
4446 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4448 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4451 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4453 * xdisp.c (move_it_to): Don't bail out early when reaching
4454 position beyond to_charpos, if we are scanning backwards.
4455 (move_it_vertically_backward): When DY == 0, make sure we get to
4456 the first character in the line after the newline.
4458 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4460 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4461 (ccl_driver): Do not generate an out-of-range pointer.
4462 (Fccl_execute_on_string): Remove unnecessary check for
4463 integer overflow, noted by Stefan Monnier in
4464 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4465 Remove a FIXME that didn't need fixing.
4466 Simplify the newly-introduced buffer reallocation code.
4468 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4470 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4472 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4474 Integer and memory overflow issues (Bug#9196).
4476 * doc.c (get_doc_string): Rework so that
4477 get_doc_string_buffer_size is the actual buffer size, rather than
4478 being 1 less than the actual buffer size; this makes xpalloc more
4481 * image.c (x_allocate_bitmap_record, cache_image):
4482 * xselect.c (Fx_register_dnd_atom):
4483 Simplify previous changes by using xpalloc.
4485 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4486 since either will do and ptrdiff_t is convenient with xpalloc.
4488 * charset.c (charset_table_size)
4489 (struct charset_sort_data.priority): Now ptrdiff_t.
4490 (charset_compare): Don't overflow if priorities differ greatly.
4491 (Fsort_charsets): Don't assume list length fits in int.
4492 Check for size-calculation overflow when allocating sort data.
4493 (syms_of_charset): Allocate an initial charset table that is
4494 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4496 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4498 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4499 The actual value is always <= INT_MAX, and leaving it unsigned made
4500 overflow checking harder.
4502 * dispextern.h (struct glyph_matrix.rows_allocated)
4503 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4504 with xpalloc. The values are still always <= INT_MAX.
4506 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4508 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4509 (SAFE_NALLOCA): New macro.
4511 * region-cache.c (struct boundary.pos, find_cache_boundary)
4512 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4513 (set_cache_region, invalidate_region_cache)
4514 (revalidate_region_cache, know_region_cache, region_cache_forward)
4515 (region_cache_backward, pp_cache):
4516 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4517 so that ptrdiff_t * can be passed to xpalloc.
4518 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4519 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4520 (pp_cache): Don't assume cache_len fits in int.
4521 * region-cache.h: Adjust extern decls to match.
4523 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4524 EMACS_INT, since either will do, for xpalloc.
4526 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4527 (xnmalloc, xnrealloc, xpalloc): New functions.
4529 * bidi.c (bidi_shelve_header_size): New constant.
4530 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4531 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4533 * bidi.c (bidi_cache_shrink):
4534 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4536 Don't update size of array until after memory allocation succeeds,
4537 because xmalloc/xrealloc may not return.
4538 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4539 now that we have proper integer overflow checking.
4540 (record_overlay_string, overlay_strings): Catch overflows when
4541 calculating size of overlay_str_buf.
4543 * callproc.c (Fcall_process): Check for size overflow when
4544 calculating size of args2.
4545 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4546 Normally we prefer signed values, but sticking with ptrdiff_t would
4547 require adding more-complicated checks.
4549 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4550 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4551 Redo buffer-overflow calculations to avoid integer overflow.
4552 Add a FIXME comment where memory seems to be over-allocated.
4554 * character.c (Fstring): Check for size-calculation overflow.
4556 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4557 unnecessary integer overflow. Check for size overflow.
4558 (encode_coding_object): Don't update size until xmalloc succeeds.
4560 * composite.c (get_composition_id): Check for overflow in glyph
4561 length calculations.
4563 Integer and memory overflow fixes for display code.
4564 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4565 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4566 (scrolling_window): Check for overflow in size calculations.
4567 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4568 Don't assume glyph table len fits in int.
4569 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4570 (row_table_size): Now ptrdiff_t, not int.
4571 (scrolling_window): Avoid overflow in size calculations.
4572 Don't update size until allocation succeeds.
4573 * fns.c (concat): Check for overflow in size calculations.
4574 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4575 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4576 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4578 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4579 (get_doc_string): Check for size calculation overflow.
4580 Don't update size until allocation succeeds.
4581 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4582 EMACS_INT, where ptrdiff_t will do.
4583 (Fsubstitute_command_keys): Check for string overflow.
4585 * editfns.c (set_time_zone_rule): Don't assume environment length
4587 (message_length): Now ptrdiff_t, not int.
4588 (Fmessage_box): Don't update size until allocation succeeds.
4589 Don't assume message length fits in int.
4590 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4592 * emacs.c (main): Do not reallocate argv, since there is a null at
4593 the end that can be overwritten, and this way there's no need to
4594 worry about size-calculation overflow.
4595 (sort_args): Check for size-calculation overflow.
4597 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4599 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4601 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4602 (x_set_scroll_bar_width, x_figure_window_size):
4603 Check for integer overflow.
4604 (x_set_alpha): Do not assume XINT fits in int.
4606 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4607 This is for the members text_lines, text_cols, total_lines, total_cols,
4608 where the system imposes an 'int' limit.
4610 * fringe.c (Fdefine_fringe_bitmap):
4611 Don't update size until alloc works.
4613 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4614 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4616 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4617 Check for size-calculation overflow.
4618 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4619 do, as we prefer signed integers.
4620 (id_to_widget.max_size, id_to_widget.used)
4621 (xg_store_widget_in_map, xg_remove_widget_from_map)
4622 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4623 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4624 Use and return ptrdiff_t, not int.
4625 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4626 * gtkutil.h: Change prototypes to match the above.
4628 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4629 are duplicate now that they've been promoted to lisp.h.
4630 (x_allocate_bitmap_record, x_alloc_image_color)
4631 (make_image_cache, cache_image, xpm_load):
4632 Don't update size until alloc is done.
4633 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4635 Check for size calculation overflow.
4636 (ct_colors_allocated_max): New constant.
4637 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4640 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4641 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4642 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4643 Use ptrdiff_t, not int, to count maps.
4644 (read_char_minibuf_menu_prompt): Check for overflow in size
4645 calculations. Don't update size until allocation succeeds.
4646 Redo calculations to avoid overflow.
4647 * keyboard.h: Change prototypes to match the above.
4649 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4651 (current_minor_maps): Check for size calculation overflow.
4652 * keymap.h: Change prototypes to match the above.
4654 * lread.c (read1, init_obarray): Don't update size until alloc done.
4656 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4657 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4659 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4660 Now ptrdiff_t, not int.
4661 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4662 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4664 * process.c (Fnetwork_interface_list): Check for overflow
4665 in size calculation.
4667 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4669 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4670 overflow. Don't bother calling xmalloc when xrealloc will do.
4672 * search.c (Freplace_match): Check for size calculation overflow.
4673 (Fset_match_data): Don't assume list lengths fit in 'int'.
4675 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4676 for command line length. Do not attempt to address one before the
4677 beginning of an array, as that's not portable.
4679 * term.c (max_frame_lines): Remove; unused.
4680 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4682 (encode_terminal_code, calculate_costs): Check for size
4683 calculation overflow.
4684 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4685 table lengths and related sizes. Don't update size until alloc
4686 done. Redo calculations to avoid overflow.
4687 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4689 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4690 subtracting pointers.
4691 (gobble_line): Check for overflow more carefully. Don't update size
4694 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4695 Don't update size until alloc done.
4696 Redo size calculations to avoid overflow.
4697 Check for size calculation overflow.
4698 (main) [DEBUG]: Fix typo in invoking tparam1.
4700 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4701 Use ptrdiff_t, not int, for sizes.
4702 (store_mode_line_noprop_char): Don't update size until alloc done.
4704 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4705 Use ptrdiff_t, not int, for sizes.
4706 (Finternal_make_lisp_face, cache_face):
4707 Check for size calculation overflow.
4708 (cache_face): Treat size calculation overflows as if they were
4709 memory exhaustion (the usual treatment), rather than aborting.
4711 * xfns.c (x_encode_text, x_set_name_internal)
4712 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4713 sizes, since they can exceed INT_MAX in size. Check for size
4714 calculation overflow.
4716 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4717 (xg_select): Check for size calculation overflow.
4718 Don't update size until alloc done.
4720 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4721 as sprintf is limited to int lengths.
4723 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4724 (X_LONG_MIN): New macros.
4725 Use them to make the following changes clearer.
4726 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4727 This change doesn't affect the value now, but it may help remind
4728 future maintainers not to raise the value too much later.
4729 (SELECTION_QUANTUM): Remove, replacing with ...
4730 (selection_quantum): ... new function, which avoids overflow.
4732 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4733 assumption that selection length fits in 'int'.
4734 (x_reply_selection_request, x_handle_selection_request)
4735 (x_get_window_property, receive_incremental_selection)
4736 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4737 (lisp_data_to_selection_data, clean_local_selection_data):
4738 Use ptrdiff_t, not int, to record length of selection.
4739 (x_reply_selection_request, x_get_window_property)
4740 (receive_incremental_selection, x_property_data_to_lisp):
4741 Redo calculations to avoid overflow.
4742 (x_reply_selection_request): When sending hint, ceiling it at
4743 X_LONG_MAX rather than relying on wraparound overflow to send
4745 (x_get_window_property, receive_incremental_selection)
4746 (lisp_data_to_selection_data, x_property_data_to_lisp):
4747 Check for size-calculation overflow.
4748 (x_get_window_property, receive_incremental_selection)
4749 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4750 Don't store size until memory allocation succeeds.
4751 (x_get_window_property): Plug memory leak on memory exhaustion.
4752 Don't double-block input; malloc is safe here. Don't assume 2**34
4753 - 4 fits in unsigned long. Add an xassert to check
4754 XGetWindowProperty overflow. Be more careful about overflow
4755 calculations, and distinguish size from memory overflow better.
4756 (receive_incremental_selection): When tracing, don't assume
4757 unsigned int is less than INT_MAX.
4758 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4759 harmful) conversions of unsigned short to int.
4760 (lisp_data_to_selection_data): Don't assume that integers
4761 in the range -65535 through -1 fit in an X unsigned short.
4762 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4763 result parameters unless successful. Rely on cons_to_unsigned
4764 to report problems with elements; the old code wasn't right anyway.
4765 (x_check_property_data): Check for int overflow; we cannot use
4766 a wider type due to X limits.
4767 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4769 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4771 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4772 (x_term_init): Check for size calculation overflow.
4773 (x_color_cells): Don't store size until memory allocation succeeds.
4774 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4775 Don't assume alloca size is less than MAX_ALLOCA.
4776 (x_term_init): Don't assume length fits in int (sprintf is limited
4779 Use ptrdiff_t for composition IDs.
4780 * character.c (lisp_string_width):
4781 * composite.c (composition_table_size, n_compositions)
4782 (get_composition_id, composition_gstring_from_id):
4783 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4784 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4785 * window.c (Frecenter):
4786 Use ptrdiff_t, not int, for composition IDs.
4787 * composite.c (get_composition_id): Check for integer overflow.
4788 * composite.h: Adjust prototypes to match the above changes.
4790 Use ptrdiff_t for hash table indexes.
4791 * category.c (hash_get_category_set):
4792 * ccl.c (ccl_driver):
4793 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4794 * coding.c (coding_system_charset_list, detect_coding_system):
4795 * coding.h (struct coding_system.id):
4796 * composite.c (get_composition_id, gstring_lookup_cache):
4797 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4798 * image.c (xpm_get_color_table_h):
4799 * lisp.h (hash_lookup, hash_put):
4800 * minibuf.c (Ftest_completion):
4801 Use ptrdiff_t for hash table indexes, not int (which is too
4802 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4803 32-bit --with-wide-int hosts).
4805 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4806 Add a FIXME comment about memory leaks.
4807 (syms_of_charset): Don't assume xmalloc returns.
4809 Don't assume that stated character widths fit in int.
4810 * character.c (Fchar_width, c_string_width, lisp_string_width):
4811 * character.h (CHAR_WIDTH):
4812 * indent.c (MULTIBYTE_BYTES_WIDTH):
4813 Use sanitize_char_width to avoid undefined and/or bad behavior
4814 with outlandish widths.
4815 * character.h (sanitize_tab_width): Rename from sanitize_width,
4816 now that we have two such functions. All uses changed.
4817 (sanitize_char_width): New inline function.
4819 Don't assume that tab-width fits in int.
4820 * character.h (sanitize_width): New inline function.
4821 (SANE_TAB_WIDTH): New macro.
4822 (ASCII_CHAR_WIDTH): Use it.
4823 * indent.c (sane_tab_width): Remove. All uses replaced by
4824 SANE_TAB_WIDTH (current_buffer).
4825 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4827 * fileio.c: Integer overflow issues with file modes.
4828 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4830 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4831 Remove unreachable code.
4832 (read_hex, load_charset_map_from_file): Check for integer overflow.
4834 * xterm.c: Don't go over XClientMessageEvent limit.
4835 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4836 (x_send_scroll_bar_event): Likewise. Check that the size does not
4837 exceed limits imposed by XClientMessageEvent, as well as the usual
4838 ptrdiff_t and size_t limits.
4840 * keyboard.c: Overflow, signedness and related fixes.
4841 (make_lispy_movement): Use same integer type in forward decl
4842 that is used in the definition.
4843 (read_key_sequence, keyremap_step):
4844 Change bufsize argument back to int, undoing my 2011-03-30 change.
4845 We prefer signed types, and int is wide enough here.
4846 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4847 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4848 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4849 length, not size_t. Use ptrdiff_t for index, not int.
4850 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4851 possibility of integer overflow.
4853 Overflow, signedness and related fixes for images.
4855 * dispextern.h (struct it.stack[0].u.image.image_id)
4856 (struct_it.image_id, struct image.id, struct image_cache.size)
4857 (struct image_cache.used, struct image_cache.ref_count):
4858 * gtkutil.c (update_frame_tool_bar):
4859 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4860 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4861 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4862 * nsmenu.m (update_frame_tool_bar):
4863 * xdisp.c (calc_pixel_width_or_height):
4864 * xfns.c (image_cache_refcount):
4865 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4866 on typical 64-bit hosts.
4868 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4869 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4870 Omit unnecessary casts to int.
4871 (parse_image_spec): Check that integers fall into 'int' range
4872 when the callers expect that.
4873 (image_ascent): Redo ascent calculation to avoid int overflow.
4874 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4875 (lookup_image): Remove unnecessary tests.
4876 (xbm_image_p): Locals are now of int, not EMACS_INT,
4877 since parse_image_check makes sure they fit into int.
4878 (png_load, gif_load, svg_load_image):
4879 Prefer int to unsigned where either will do.
4880 (tiff_handler): New function, combining the cores of the
4881 old tiff_error_handler and tiff_warning_handler.
4882 This function is rewritten to use vsnprintf and thereby avoid
4883 stack buffer overflows. It uses only the features of vsnprintf
4884 that are common to both POSIX and native Microsoft.
4885 (tiff_error_handler, tiff_warning_handler): Use it.
4886 (tiff_load, gif_load, imagemagick_load_image):
4887 Don't assume :index value fits in 'int'.
4888 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4889 (imagemagick_load_image): Check that crop parameters fit into
4890 the integer types that MagickCropImage accepts. Don't assume
4891 Vimagemagick_render_type has a nonnegative value. Don't assume
4892 size_t fits in 'long'.
4893 (gs_load): Use printmax_t to print the widest integers possible.
4894 Check for integer overflow when computing image height and width.
4896 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4898 * xdisp.c (redisplay_window): Don't force window start if point
4899 will be invisible in the resulting window. (Bug#9324)
4901 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4903 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4904 the display spec is of the form `(space ...)'.
4905 (handle_display_spec): Return the value returned by
4906 handle_single_display_spec, not just 1 or zero.
4907 (handle_single_display_spec): If the display spec is of the form
4908 `(space ...)', and specifies display in the text area, return 2
4910 (try_cursor_movement): Check for the need to scroll more
4911 accurately, and prefer exact match for point under bidi.
4912 Don't advance `row' beyond the last row of the window.
4914 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4915 into disp_prop; all users changed.
4917 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4918 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4919 for the text covered by the display property.
4921 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4923 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4924 Change return value to nil.
4925 (Frecord_buffer): Delete unused function.
4927 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4929 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4930 buffers, return left-to-right.
4931 (set_cursor_from_row): Consider candidate row a win if its glyph
4932 represents a newline and point is on that newline. Fixes cursor
4933 positioning on the newline at EOL of R2L text within L2R
4934 paragraph, and vice versa.
4935 (try_cursor_movement): Check continued rows, in addition to
4936 continuation rows. Fixes unwarranted scroll when point enters a
4937 continued line of R2L text within an L2R paragraph, or vice versa.
4938 (cursor_row_p): Consider the case of point being equal to
4939 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4940 from the end of a short line to the beginning of a continued line
4941 of R2L text within L2R paragraph.
4942 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4943 composed characters.
4945 * bidi.c (bidi_check_type): Use xassert.
4946 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4949 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4951 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4954 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
4956 * nsfont.m (ns_otf_to_script): Fix typo.
4958 2011-08-22 Kenichi Handa <handa@m17n.org>
4960 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4961 extra slot even if the purpose is char-code-property-table.
4963 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4965 * xdisp.c (redisplay_window): When computing centering_position,
4966 account for the height of the header line. (Bug#8874)
4968 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4969 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4970 candidate is selected by the mouse, and that candidate has a
4971 composed character under the mouse.
4973 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4974 coordinates reported by pos-visible-in-window-p for a composed
4975 character in column zero.
4977 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4979 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4981 2011-08-22 Eli Zaretskii <eliz@gnu.org>
4983 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4984 consider it a hit if to_charpos is anywhere in the range of the
4985 composed buffer positions.
4987 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
4989 * image.c (gif_load): Don't assume that each subimage has the same
4990 dimensions as the base image. Handle disposal method that is
4991 "undefined" by the gif spec (Bug#9335).
4993 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
4995 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
4996 (Fcondition_case): Document `debug' symbol in error handler.
4998 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5000 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5001 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5002 from an Org mode buffer to a Speedbar frame.
5004 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5005 a composition, take its buffer position from IT->cmp_it.charpos.
5006 Fixes cursor positioning at the beginning of a line that begins
5007 with a composed character.
5009 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5011 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5012 character bidirectional type, use STRONG_L instead. Fixes crashes
5013 in a buffer produced by `describe-categories'.
5015 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5016 members before the level stack, so they would be saved and
5017 restored when copying iterator state. Fixes incorrect reordering
5018 around TABs covered by display properties.
5020 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5022 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5024 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5026 * eval.c (internal_condition_case, internal_condition_case_1)
5027 (internal_condition_case_2, internal_condition_case_n):
5028 Remove unnecessary aborts (Bug#9081).
5030 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5032 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5033 has no `load' handler, try opening the file locally. (Bug#9311)
5035 2011-08-16 Ken Brown <kbrown@cornell.edu>
5037 * gmalloc.c: Expand comment.
5039 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5041 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5042 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5044 2011-08-16 Ken Brown <kbrown@cornell.edu>
5046 Fix memory allocation problems in Cygwin build (Bug#9273).
5048 * unexcw.c ( __malloc_initialized): Declare external variable.
5049 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5051 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5053 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5055 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5057 [CYGWIN] (special_realloc): New function.
5058 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5059 requests to realloc storage in the static heap.
5061 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5063 * bidi.c (bidi_initialize): Remove unused local.
5065 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5068 * biditype.h: Remove file.
5069 * makefile.w32-in ($(BLD)/bidi.$(O)):
5070 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5072 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5074 * chartab.c: Improve commentary for the uniprop_table API.
5076 * bidi.c (bidi_paragraph_init): Support zero value of
5077 bidi_ignore_explicit_marks_for_paragraph_level.
5078 (bidi_initialize): Use uniprop_table instead of including
5079 biditype.h and bidimirror.h.
5081 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5082 coordinates of the iterator when restoring from ppos_it.
5085 2011-08-14 Kenichi Handa <handa@m17n.org>
5087 * process.c (create_process): Call setup_process_coding_systems
5088 after the pid of the process is set to -1 (Bug#8162).
5090 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5092 * xdisp.c (move_it_in_display_line_to): Don't invoke
5093 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5094 ppos_it. Fixes vertical cursor motion when line beginning is
5095 covered by an image. (Bug#9296)
5097 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5099 * nsterm.h (ns_run_ascript): Declare.
5100 (NSAPP_DATA2_RUNASSCRIPT): Define.
5102 * nsfns.m (as_script, as_result, as_status): New static variables.
5103 (ns_run_ascript): New function.
5104 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5105 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5106 the event loop. Get status from as_status (Bug#7276).
5108 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5109 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5110 the event loop (Bug#7276).
5112 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5114 * gnutls.c (QCgnutls_bootprop_priority)
5115 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5116 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5117 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5118 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5119 (QCgnutls_bootprop_verify_hostname_error)
5120 (QCgnutls_bootprop_callbacks_verify): Rename from
5121 Qgnutls_bootprop_..., all uses changed.
5123 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5126 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5128 * xfaces.c (Qframe_set_background_mode): Now static.
5129 * dispextern.h (Qframe_set_background_mode): Remove decl.
5131 * process.c (Fnetwork_interface_info): Declare local only if needed.
5133 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5135 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5136 (Fnetwork_interface_list): Allocate in increments of bytes instead
5137 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5138 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5140 (struct ifflag_def): notrailers is smart on OSX.
5141 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5142 Get hardware address with getifaddrs if available.
5144 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5146 * xdisp.c (iterate_out_of_display_property): xassert that
5147 IT->position is set to within IT->object's boundaries. Break from
5148 the loop as soon as EOB is reached; avoids infloops in redisplay
5149 when IT->position is set up wrongly due to some bug.
5150 Set IT->current to match the bidi iterator unconditionally.
5151 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5152 entry. Force push_it to save on the stack the current
5153 buffer/string position, to be restored by pop_it. Fix flags in
5154 the iterator structure wrt the object coming from a display
5155 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5156 properties. (Bug#9284)
5158 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5160 * fontset.c (fontset_get_font_group): Add proper type checks.
5163 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5165 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5166 and LC_VERSION_MIN_MACOSX.
5167 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5168 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5170 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5172 * xdisp.c (forward_to_next_line_start): Allow to use the
5173 no-display-properties-and-no-overlays under bidi display.
5174 Set disp_pos in the bidi iterator to avoid searches for display
5175 properties and overlays.
5177 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5179 * editfns.c (Fset_time_zone_rule): Document relationship with the
5182 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5183 the font entity extracted from the cache (Bug#8109).
5185 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5187 * composite.c (autocmp_chars): Don't reset point. That is done by
5188 restore_point_unwind (Bug#5984).
5190 2011-08-07 Juri Linkov <juri@jurta.org>
5192 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5193 to show the arg `TIME' instead of `TIMEVAL'.
5195 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5197 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5198 display property strides EOL and includes a newline, as in
5199 longlines-mode. (Bug#9254)
5200 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5201 word-wrap under bidirectional display. (Bug#9224)
5203 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5204 is non-zero, even if the data buffer is NULL. Fixes a crash in
5205 vertical-motion with longlines-mode. (Bug#9254)
5207 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5209 * bidi.c <bidi_cache_total_alloc>: Now static.
5210 (bidi_initialize): Initialize bidi_cache_total_alloc.
5212 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5215 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5216 amount allocated this far in `bidi_cache_total_alloc'.
5217 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5218 non-zero, only free the data buffer without restoring the cache
5219 contents. All callers changed.
5221 * dispextern.h (bidi_unshelve_cache): Update prototype.
5223 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5224 (move_it_in_display_line, move_it_to)
5225 (move_it_vertically_backward, move_it_by_lines): Replace the call
5226 to xfree to an equivalent call to bidi_unshelve_cache.
5227 (move_it_in_display_line_to): Fix logic of returning
5228 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5230 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5232 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5233 came from a string character with a `cursor' property. (Bug#9229)
5235 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5237 * Makefile.in (LIB_PTHREAD): New variable.
5238 (LIBES): Add LIB_PTHREAD (Bug#9216).
5240 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5241 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5243 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5245 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5247 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5249 * xterm.c (x_find_topmost_parent): New function.
5250 (x_set_frame_alpha): Find topmost parent window with
5251 x_find_topmost_parent and set the property there also (bug#9181).
5252 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5254 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5256 * callproc.c (Fcall_process): Avoid vfork clobbering
5257 the local vars buffer, coding_systems, current_dir.
5259 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5261 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5263 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5265 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5266 so that it is not optimized away.
5268 * xdisp.c (compute_display_string_pos): Remove unused local.
5270 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5272 Fix slow cursor motion and scrolling in large buffers with
5273 selective display, like Org Mode buffers. (Bug#9218)
5275 * dispextern.h (struct bidi_it): New member disp_prop_p.
5277 * xdisp.c: Remove one-slot cache of display string positions.
5278 (compute_display_string_pos): Accept an additional argument
5279 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5280 for a display string or property. If found, set DISP_PROP_P
5283 * bidi.c (bidi_fetch_char): Accept an additional argument
5284 DISP_PROP_P, and pass it to compute_display_string_pos.
5285 Only handle text covered by a display string if DISP_PROP_P is returned
5286 non-zero. All callers of bidi_fetch_char changed.
5288 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5290 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5292 2010-12-03 Don March <don@ohspite.net>
5294 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5295 last character M-[char] is translated to ESC [char] (bug#7541).
5297 2011-08-02 Kenichi Handa <handa@m17n.org>
5299 * lisp.h (uniprop_table): Extern it.
5301 * chartab.c (uniprop_table): Make it non-static.
5303 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5305 * xdisp.c (forward_to_next_line_start): Accept additional argument
5306 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5308 (reseat_at_next_visible_line_start): Use the bidi iterator state
5309 returned by forward_to_next_line_start to restore the state of
5310 it->bidi_it after backing up to previous newline. (Bug#9212)
5312 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5314 * regex.c (re_comp): Protoize.
5315 (re_exec): Fix return type.
5316 (regexec): Fix type of `ret'. (Bug#9203)
5318 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5320 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5321 This is needed if max-image-size is a floating-point number.
5323 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5325 * print.c (print_object): Print empty symbol as ##.
5327 * lread.c (read1): Read ## as empty symbol.
5329 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5331 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5332 setting frame foreground color (Bug#9175).
5333 (x_set_background_color): Likewise.
5335 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5336 contents (Bug#9176).
5337 (EmacsTooltip -init): Remove bezels and add shadows to
5340 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5341 or scroll bar (Bug#8470).
5343 * nsfont.m (nsfont_open): Remove assignment to voffset and
5344 unnecessary vars hshink, expand, hd, full_height, min_height.
5345 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5347 * nsterm.h (nsfont_info): Remove voffset field.
5349 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5351 Implement strike-through and overline on NextStep (Bug#8863).
5353 * nsfont.m (nsfont_open): Use underline position provided by font,
5354 instead of hard-coded value of 2.
5355 (nsfont_draw): Call ns_draw_text_decoration instead.
5357 * nsterm.h: Add declaration for ns_draw_text_decoration.
5359 * nsterm.m (ns_draw_text_decoration): New function for drawing
5360 underline, overline, and strike-through.
5361 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5362 ns_draw_text_decoration. Change treatment of cursor drawing to
5363 accommodate underlining, etc.
5365 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5367 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5370 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5372 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5373 Without this fix, if a signal arrives just after memory fills up,
5374 'malloc' might be invoked reentrantly.
5376 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5377 In other words, assume that every image size is allowed, on non-X
5378 hosts. This assumption is probably wrong, but it lets Emacs compile.
5380 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5382 * regex.c (re_iswctype): Convert return values to boolean.
5384 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5386 * xdisp.c (compute_display_string_pos): Don't use cached display
5387 string position if the buffer had its restriction changed.
5390 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5392 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5394 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5396 Integer signedness and overflow and related fixes. (Bug#9079)
5398 * bidi.c: Integer size and overflow fixes.
5399 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5400 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5401 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5402 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5403 (bidi_find_other_level_edge):
5404 Use ptrdiff_t instead of EMACS_INT where either will do.
5405 This works better on 32-bit hosts configured --with-wide-int.
5406 (bidi_cache_ensure_space): Check for size-calculation overflow.
5407 Use % rather than repeated addition, for better worst-case speed.
5408 Don't set bidi_cache_size until after xrealloc returns, because it
5410 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5411 (bidi_cache_ensure_space): Also check that the bidi cache size
5412 does not exceed that of the largest Lisp string or buffer. See Eli
5413 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5415 * alloc.c (__malloc_size_t): Remove.
5416 All uses replaced by size_t. See Andreas Schwab's note
5417 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5419 * image.c: Improve checking for integer overflow.
5420 (check_image_size): Assume that f is nonnull, since
5421 it is always nonnull in practice. This is one less thing to
5422 worry about when checking for integer overflow later.
5423 (x_check_image_size): New function, which checks for integer
5424 overflow issues inside X.
5425 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5426 This removes the need for a memory_full check.
5427 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5428 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5429 (xbm_read_bitmap_data): Change locals back to 'int', since
5430 their values must fit in 'int'.
5431 (xpm_load_image, png_load, tiff_load):
5432 Invoke x_create_x_image_and_pixmap earlier,
5433 to avoid much needless work if the image is too large.
5434 (tiff_load): Treat overly large images as if
5435 x_create_x_image_and_pixmap failed, not as malloc failures.
5436 (gs_load): Use x_check_image_size.
5438 * gtkutil.c: Omit integer casts.
5439 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5440 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5442 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5444 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5445 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5446 would wrongly return t on a 64-bit host.
5448 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5449 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5450 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5451 and therefore cause GCC to emit a bogus diagnostic in some cases.
5453 * image.c: Integer signedness and overflow and related fixes.
5454 This is not an exhaustive set of fixes, but it's time to
5455 record what I've got.
5456 (lookup_pixel_color, check_image_size): Remove redundant decls.
5457 (check_image_size): Don't assume that arbitrary EMACS_INT values
5458 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5459 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5460 (tiff_load, imagemagick_load_image):
5461 Check for overflow in size calculations.
5462 (x_create_x_image_and_pixmap): Remove unnecessary test for
5463 xmalloc returning NULL; that can't happen.
5464 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5465 (xpm_color_bucket): Use better integer hashing function.
5466 (xpm_cache_color): Don't possibly over-allocate memory.
5467 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5468 (gif_memory_source):
5469 Use ptrdiff_t, not int or size_t, to record sizes.
5470 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5471 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5472 either works, as we prefer signed integers.
5473 (tiff_read_from_memory, tiff_write_from_memory):
5474 Return tsize_t, not size_t, since that's what the TIFF API wants.
5475 (tiff_read_from_memory): Don't fail simply because the read would
5476 go past EOF; instead, return a short read.
5477 (tiff_load): Omit no-longer-needed casts.
5478 (Fimagemagick_types): Don't assume size fits into 'int'.
5480 Improve hashing quality when configured --with-wide-int.
5481 * fns.c (hash_string): New function, taken from sxhash_string.
5482 Do not discard information about ASCII character case; this
5483 discarding is no longer needed.
5484 (sxhash-string): Use it. Change sig to match it. Caller changed.
5485 * lisp.h: Declare it.
5486 * lread.c (hash_string): Remove, since we now use fns.c's version.
5487 The fns.c version returns a wider integer if --with-wide-int is
5488 specified, so this should help the quality of the hashing a bit.
5490 * emacs.c: Integer overflow minor fix.
5491 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5492 Define only if GNU_LINUX.
5493 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5495 * dispnew.c: Integer signedness and overflow fixes.
5496 Remove unnecessary forward decls, that were a maintenance hassle.
5497 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5499 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5500 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5501 (prepare_desired_row, line_draw_cost):
5502 Use int, not unsigned, where either works.
5503 (save_current_matrix, restore_current_matrix):
5504 Use ptrdiff_t, not size_t, where either works.
5505 (init_display): Check for overflow more accurately, and without
5506 relying on undefined behavior.
5508 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5509 Remove, replacing with the new symbols in lisp.h. All uses changed.
5510 * fileio.c (make_temp_name):
5511 * filelock.c (lock_file_1, lock_file):
5512 * xdisp.c (message_dolog):
5513 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5514 Use pMd etc. instead.
5515 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5516 replacing the pWIDE etc. symbols removed from editfns.c.
5518 * keyboard.h (num_input_events): Now uintmax_t.
5519 This is (very slightly) less likely to mess up due to wraparound.
5522 * buffer.c: Integer signedness fixes.
5523 (alloc_buffer_text, enlarge_buffer_text):
5524 Use ptrdiff_t rather than size_t when either will do, as we prefer
5527 * alloc.c: Integer signedness and overflow fixes.
5528 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5529 (__malloc_size_t): Default to size_t, not to int.
5530 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5531 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5532 Prefer ptrdiff_t to size_t when either would do, as we prefer
5534 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5535 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5536 Now const. Initialize with values that are in range even if char
5538 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5539 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5540 These functions do the right thing with sizes > 2**32.
5541 (check_depth): Now ptrdiff_t, not int.
5542 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5543 Adjust to new way of storing sizes. Check for size overflow bugs
5545 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5546 slightly wrong anyway, as it missed one instance of
5547 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5548 (refill_memory_reserve): Omit needless cast to size_t.
5549 (mark_object_loop_halt): Mark as externally visible.
5551 * xselect.c: Integer signedness and overflow fixes.
5552 (Fx_register_dnd_atom, x_handle_dnd_message):
5553 Use ptrdiff_t, not size_t, since we prefer signed.
5554 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5555 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5556 x_dnd_atoms_size and x_dnd_atoms_length.
5558 * doprnt.c: Prefer signed to unsigned when either works.
5560 * doprnt.c (doprnt):
5562 * xdisp.c (vmessage):
5563 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5564 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5565 prefer signed arithmetic to avoid comparison confusion.
5566 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5567 but is a bit tricky.
5569 Assume freestanding C89 headers, string.h, stdlib.h.
5570 * data.c, doprnt.c, floatfns.c, print.c:
5571 Include float.h unconditionally.
5572 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5573 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5574 * regex.c: Likewise for stddef.h, string.h.
5575 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5576 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5577 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5578 (STDC_HEADERS): Remove obsolete defines.
5579 * sysdep.c: Include limits.h unconditionally.
5581 Assume support for memcmp, memcpy, memmove, memset.
5582 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5583 * regex.c (memcmp, memcpy):
5584 Remove; we assume C89 now.
5586 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5587 (__malloc_safe_bcopy): Remove; no longer needed.
5589 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5590 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5591 well either way, and we prefer signed to unsigned.
5593 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5595 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5596 closes the connection while we're reading (bug#9182).
5598 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5600 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5601 are specified (Bug#9168).
5603 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5605 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5606 Found by GCC static checking and --with-wide-int on a 32-bit host.
5608 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5610 * xdisp.c (compute_display_string_pos): Fix logic of caching
5611 previous display string position. Initialize cached_prev_pos to
5612 -1. Fixes slow-down at the beginning of a buffer.
5614 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5616 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5617 for attrs[LFACE_FONTSET_INDEX].
5619 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5621 * xml.c (parse_region): Remove unused local
5622 that was recently introduced.
5624 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5626 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5627 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5629 * xdisp.c (move_it_in_display_line_to): Record the best matching
5630 position for TO_CHARPOS while scanning the line, and restore it on
5631 exit if none of the characters scanned was an exact match.
5632 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5633 when exact match is impossible due to invisible text, and the
5634 lines are truncated.
5636 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5638 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5641 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5643 Fix a significant slow-down of cursor motion with C-n, C-p,
5644 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5645 auto-repeat under bidi redisplay in fontified buffers.
5646 * xdisp.c (compute_stop_pos_backwards): New function.
5647 (next_element_from_buffer): Call compute_stop_pos_backwards to
5648 find a suitable prev_stop when we find ourselves before
5650 (reseat): Don't look for prev_stop, as that could mean a very long
5652 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5653 <cached_disp_overlay_modiff>: Cache for last found display string
5655 (compute_display_string_pos): Return the cached position if asked
5656 about the same buffer in the same area of character positions, and
5657 the buffer wasn't changed since the time the display string
5658 position was cached.
5660 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5662 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5663 is an integer, which is important for empty lines. (Bug#9149)
5665 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5667 * frame.c (Fmodify_frame_parameters): In tty case, update the
5668 default face if necessary (Bug#4238).
5670 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5672 * editfns.c (Fstring_to_char): No need to explain what a character
5673 is in the docstring (Bug#6576).
5675 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5677 * xml.c (parse_region): Make sure we always return a tree.
5679 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5681 * xml.c (parse_region): If a document contains only comments,
5684 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5686 * xml.c (make_dom): Return comments, too.
5688 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5691 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5692 and the surrounding thread.
5693 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5694 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5695 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5697 * s/openbsd.h (BROKEN_SIGIO): Define.
5698 * unexelf.c (unexec) [__OpenBSD__]:
5699 Don't update the .mdebug section of the Alpha COFF symbol table.
5701 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5703 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5706 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5708 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5709 This fixes some race conditions on the permissions of any newly
5712 * alloc.c (valid_pointer_p): Use pipe, not open.
5713 This fixes some permissions issues when debugging.
5715 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5716 If fchown fails to set both uid and gid, try to set just gid,
5717 as that is sometimes allowed. Adjust the file's mode to eliminate
5718 setuid or setgid bits that are inappropriate if fchown fails.
5720 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5722 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5723 to compare Lisp_Objects.
5724 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5725 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5726 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5728 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5730 * lread.c (read_integer): Unread even EOF character.
5731 (read1): Likewise. Properly record start position of symbol.
5733 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5734 symbol character follows.
5736 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5738 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5739 This works around a problem with the previous change to Fcopy_file.
5740 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5741 and without this change, GCC might complain about discarding
5742 fchown's return value.
5744 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5746 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5748 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5750 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5752 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5754 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5755 it's used from the C level.
5757 * process.c: Use the same condition for POLL_FOR_INPUT in both
5758 keyboard.c and process.c (bug#1858).
5760 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5762 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5763 (Fgnutls_boot): Use it.
5765 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5767 * doc.c (Fsubstitute_command_keys): Revert last change.
5769 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5771 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5772 quotes the next character, and doesn't affect other longer
5773 sequences (bug#8935).
5775 * lread.c (syms_of_lread): Clarify that is isn't only
5776 `eval-buffer' and `eval-defun' that's affected by
5777 `lexical-binding' (bug#8460).
5779 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5781 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5782 bidi redisplay when a line includes both an image and is truncated.
5784 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5786 Fix minor problems found by static checking.
5787 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5788 (elsz): Now a signed constant, not a size_t var. We prefer signed
5789 types to unsigned, to avoid integer comparison confusion. Without
5790 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5791 "cannot optimize loop, the loop counter may overflow", a symptom
5793 * indent.c (Fvertical_motion): Mark locals as initialized.
5794 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5796 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5798 * search.c (Fre_search_backward): Mention `case-fold-search' in
5799 all the re_search_* functions (bug#8138).
5801 * keyboard.c (Fopen_dribble_file): Document when the file is
5804 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5806 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5809 Support bidi reordering of display and overlay strings.
5810 * xdisp.c (compute_display_string_pos)
5811 (compute_display_string_end): Accept additional argument STRING.
5812 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5813 (reseat_to_string): Initialize bidi_it->string.s and
5814 bidi_it->string.schars.
5815 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5816 NULL (avoids a crash in bidi_paragraph_init).
5817 Initialize itb.string.lstring.
5818 (init_iterator): Call bidi_init_it only of a valid
5819 buffer position was specified. Initialize paragraph_embedding to
5821 (reseat_to_string): Initialize the bidi iterator.
5822 (display_string): If we need to ignore text properties of
5823 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5824 original value of -1 will not work with bidi.)
5825 (compute_display_string_pos): First arg is now struct
5826 `text_pos *'; all callers changed. Support display properties on
5828 (compute_display_string_end): Support display properties on Lisp
5830 (init_iterator, reseat_1, reseat_to_string): Initialize the
5831 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5832 when iterating on a string not from display properties).
5833 (compute_display_string_pos, compute_display_string_end):
5834 Fix calculation of the object to scan. Fixes an error when using
5836 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5837 base_level_stop; instead, set base_level_stop to BEGV.
5838 Fixes crashes in vertical-motion.
5839 (next_element_from_buffer): Improve commentary for when
5840 the iterator is before prev_stop.
5841 (init_iterator): Initialize bidi_p from the default value of
5842 bidi-display-reordering, not from buffer-local value. Use the
5843 buffer-local value only if initializing for buffer iteration.
5844 (handle_invisible_prop): Support invisible properties on strings
5845 that are being bidi-reordered.
5846 (set_iterator_to_next): Support bidi reordering of C strings and
5848 (next_element_from_string): Support bidi reordering of Lisp
5850 (handle_stop_backwards): Support Lisp strings as well.
5851 (display_string): Support display of R2L glyph rows.
5852 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5853 (init_iterator): Don't initialize it->bidi_p for strings
5855 (reseat_to_string): Initialize it->bidi_p for strings here.
5856 (next_element_from_string, next_element_from_c_string)
5857 (next_element_from_buffer): Add xassert's for correspondence
5858 between IT's object being iterated and it->bidi_it.string
5860 (face_before_or_after_it_pos): Support bidi iteration.
5861 (next_element_from_c_string): Handle the case of the first string
5862 character that is not the first one in the visual order.
5863 (get_visually_first_element): New function, refactored from common
5864 parts of next_element_from_buffer, next_element_from_string, and
5865 next_element_from_c_string.
5866 (tool_bar_lines_needed, redisplay_tool_bar)
5867 (display_menu_bar): Force left-to-right direction. Add a FIXME
5868 comment for making that be controlled by a user option.
5869 (push_it, pop_it): Save and restore the state of the
5870 bidi iterator. Save and restore the bidi_p flag.
5871 (pop_it): Iterate out of display property for string iteration as
5873 (iterate_out_of_display_property): Support iteration over strings.
5874 (handle_single_display_spec): Set up it->bidi_it for iteration
5875 over a display string, and call bidi_init_it.
5876 (handle_single_display_spec, next_overlay_string)
5877 (get_overlay_strings_1, push_display_prop): Set up the bidi
5878 iterator for displaying display or overlay strings.
5879 (forward_to_next_line_start): Don't use the shortcut if
5881 (back_to_previous_visible_line_start): If handle_display_prop
5882 pushed the iterator stack, restore the internal state of the bidi
5883 iterator by calling bidi_pop_it same number of times.
5884 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5885 and we are bidi-iterating, don't decrement the iterator position;
5886 instead, set the first_elt flag in the bidi iterator, to produce
5888 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5889 (push_display_prop): xassert that we are iterating a buffer.
5890 (push_it, pop_it): Save and restore paragraph_embedding member.
5891 (handle_single_display_spec, next_overlay_string)
5892 (get_overlay_strings_1, reseat_1, reseat_to_string)
5893 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5894 correctly. Don't assume unibyte strings are not bidi-reordered.
5895 (compute_display_string_pos)
5896 (compute_display_string_end): Fix handling the case of C string.
5897 (push_it, pop_it): Save and restore from_disp_prop_p.
5898 (handle_single_display_spec, push_display_prop): Set the
5899 from_disp_prop_p flag.
5900 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5901 (pop_it): Call iterate_out_of_display_property only if we are
5902 popping after iteration over a string that came from a display
5903 property. Fix a typo in popping stretch info. Add an assertion
5904 for verifying that the iterator position is in sync with the bidi
5906 (handle_single_display_spec, get_overlay_strings_1)
5907 (push_display_prop): Fix initialization of paragraph direction for
5908 string when that of the parent object is not yet determined.
5909 (reseat_1): Call bidi_init_it to resync the bidi
5910 iterator with IT's position. (Bug#7616)
5911 (find_row_edges): If ROW->start.pos gives position
5912 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5913 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5914 Reset the from_disp_prop_p flag.
5915 (SAVE_IT, RESTORE_IT): New macros.
5916 (pos_visible_p, face_before_or_after_it_pos)
5917 (back_to_previous_visible_line_start)
5918 (move_it_in_display_line_to, move_it_in_display_line)
5919 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5920 (try_scrolling, redisplay_window, display_line): Use them when
5921 saving a temporary copy of the iterator and restoring it back.
5922 (back_to_previous_visible_line_start, reseat_1)
5923 (init_iterator): Empty the bidi cache "stack".
5924 (move_it_in_display_line_to): If iterator ended up at
5925 EOL, but we never saw any buffer positions smaller than
5926 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5927 motion in bidi-reordered lines.
5928 (move_it_in_display_line_to): Record prev_method and prev_pos
5929 immediately before the call to set_iterator_to_next. Fixes cursor
5930 motion in bidi-reordered lines with stretch glyphs and strings
5931 displayed in margins. (Bug#8133) (Bug#8867)
5932 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5934 (pos_visible_p): Support positions in bidi-reordered lines.
5935 Save and restore bidi cache.
5937 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5938 (bidi_paragraph_info): Delete unused struct.
5939 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5940 (bidi_cache_start): New variable.
5941 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5943 (bidi_cache_fetch_state, bidi_cache_search)
5944 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5945 (bidi_cache_find, bidi_peek_at_next_level)
5946 (bidi_level_of_next_char, bidi_find_other_level_edge)
5947 (bidi_move_to_visually_next): Compare cache index with
5948 bidi_cache_start rather than with zero.
5949 (bidi_fetch_char): Accept new argument STRING; all callers
5950 changed. Support iteration over a string. Support strings with
5951 display properties. Support unibyte strings. Fix the type of
5952 `len' according to what STRING_CHAR_AND_LENGTH expects.
5953 (bidi_paragraph_init, bidi_resolve_explicit_1)
5954 (bidi_resolve_explicit, bidi_resolve_weak)
5955 (bidi_level_of_next_char, bidi_move_to_visually_next):
5956 Support iteration over a string.
5957 (bidi_set_sor_type, bidi_resolve_explicit_1)
5958 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5959 can now be zero (for strings); special values 0 and -1 were
5960 changed to -1 and -2, respectively.
5961 (bidi_char_at_pos): New function.
5962 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5963 Call it instead of FETCH_MULTIBYTE_CHAR.
5964 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5965 initialized to valid values.
5966 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5968 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5969 the test for valid cached positions. Fix the logic for looking up
5970 the sentinel state in the cache. GCPRO the Lisp string we are
5972 (bidi_push_it, bidi_pop_it): New functions.
5973 (bidi_initialize): Initialize the bidi cache start stack pointer.
5974 (bidi_cache_ensure_space): New function, refactored from part of
5975 bidi_cache_iterator_state. Don't assume the required size is just
5976 one BIDI_CACHE_CHUNK away.
5977 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5978 (bidi_count_bytes, bidi_char_at_pos): New functions.
5979 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5980 always valid if bidi_cache_idx is valid.
5981 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5982 is valid if it's going to be used.
5983 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5984 (bidi_cache_fetch_state, bidi_cache_search)
5985 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5986 (bidi_cache_iterator_state, bidi_cache_find)
5987 (bidi_find_other_level_edge, bidi_cache_start_stack):
5988 All variables related to cache indices are now EMACS_INT.
5990 * dispextern.h (struct bidi_string_data): New structure.
5991 (struct bidi_it): New member `string'. Make flag members be 1-bit
5992 fields, and put them last in the struct.
5993 (compute_display_string_pos, compute_display_string_end):
5995 (bidi_push_it, bidi_pop_it): Add prototypes.
5996 (struct iterator_stack_entry): New members bidi_p,
5997 paragraph_embedding, and from_disp_prop_p.
5998 (struct it): Member bidi_p is now a bit field 1 bit wide.
5999 (bidi_shelve_cache, bidi_unshelve_cache):
6002 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6003 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6004 and vector-like objects.
6006 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6007 cache around display iteration.
6009 * window.c (Fwindow_end, window_scroll_pixel_based)
6010 (displayed_window_lines, Frecenter): Save and restore the bidi
6011 cache around display iteration.
6013 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6015 * editfns.c (Fdelete_region): Clarify the use of the named
6016 parameters (bug#6788).
6018 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6020 * indent.c (Fvertical_motion): Set and restore w->pointm when
6021 saving and restoring the window's buffer (Bug#9006).
6023 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6025 * editfns.c (Fstring_to_char): Clarify just what is returned
6026 (bug#6576). Text by Eli Zaretskii.
6028 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6030 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6032 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6034 * buffer.c (mmap_find): Fix a typo.
6036 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6038 Fix execution of x selection hooks.
6039 * xselect.c (Qx_lost_selection_functions)
6040 (Qx_sent_selection_functions): New vars.
6041 (syms_of_xselect): DEFSYM them.
6042 (x_handle_selection_request): Pass Qx_sent_selection_functions
6043 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6044 (x_handle_selection_clear,x_clear_frame_selections):
6045 Pass Qx_lost_selection_functions rather than
6046 Vx_lost_selection_functions to Frun_hook_with_args.
6048 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6050 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6051 The old code sometimes used this field without initializing it.
6053 * alloc.c (gc_sweep): Don't read past end of array.
6054 In theory, the old code could also have corrupted Emacs internals,
6055 though it'd be very unlikely.
6057 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6059 * character.c (Fcharacterp): Don't advertise optional ignored
6060 argument. (Bug#4026)
6062 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6064 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6067 * window.c (Fset_window_start): Doc fix (bug#4199).
6068 (Fset_window_hscroll): Ditto.
6070 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6072 Fix minor new problems caught by GCC 4.6.1.
6073 * term.c (init_tty): Remove unused local.
6074 * xsettings.c (store_monospaced_changed): Define this function only
6075 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6078 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6080 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6082 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6084 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6085 are the mini-buffer and the echo area (bug#3320).
6087 * term.c (init_tty): Remove support for supdup, c10 and perq
6088 terminals, which are no longer supported (bug#1482).
6090 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6092 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6094 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6096 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6097 for non-popups (Bug#3642).
6099 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6101 * alloc.c (reset_malloc_hooks): Protoize.
6102 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6103 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6104 * cm.c (losecursor): Likewise.
6105 * data.c (fmod): Likewise.
6106 * dispnew.c (swap_glyphs_in_rows): Likewise.
6107 * emacs.c (memory_warning_signal): Likewise.
6108 * floatfns.c (float_error): Likewise.
6109 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6110 (otf_open, font_otf_capability, generate_otf_features)
6111 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6113 * image.c (pbm_read_file): Likewise.
6114 * indent.c (string_display_width): Likewise.
6115 * intervals.c (check_for_interval, search_for_interval)
6116 (inc_interval_count, count_intervals, root_interval)
6117 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6118 * lread.c (defalias): Likewise.
6119 * ralloc.c (r_alloc_check): Likewise.
6120 * regex.c (set_image_of_range_1, set_image_of_range)
6121 (regex_grow_registers): Likewise.
6122 * sysdep.c (strerror): Likewise.
6123 * termcap.c (valid_filename_p, tprint, main): Likewise.
6124 * tparam.c (main): Likewise.
6125 * unexhp9k800.c (run_time_remap, save_data_space)
6126 (update_file_ptrs, read_header, write_header, calculate_checksum)
6127 (copy_file, copy_rest, display_header): Likewise.
6128 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6130 * xdisp.c (check_it): Likewise.
6131 * xfaces.c (register_color, unregister_color, unregister_colors):
6133 * xfns.c (print_fontset_result): Likewise.
6134 * xrdb.c (member, fatal, main): Likewise.
6136 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6138 Fix minor problems found by static checking (Bug#9031).
6139 * chartab.c (char_table_set_range, map_sub_char_table):
6140 Remove unused locals.
6141 (uniprop_table): Now static.
6142 * composite.c (_work_char): Remove unused static var.
6144 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6146 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6148 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6150 * gtkutil.c (qttip_cb): Remove code without function.
6152 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6154 * w32.c (pthread_sigmask): New stub.
6156 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6158 Use pthread_sigmask, not sigprocmask (Bug#9010).
6159 sigprocmask is portable only for single-threaded applications, and
6160 Emacs can be multi-threaded when it uses GTK.
6161 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6163 * callproc.c (Fcall_process):
6164 * process.c (create_process):
6165 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6166 Use pthread_sigmask, not sigprocmask.
6168 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6170 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6171 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6174 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6176 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6177 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6178 (xg_hide_tooltip): Fix comment.
6180 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6181 in registerServicesMenuSendTypes.
6182 (validRequestorForSendType): Don't check ns_return_types.
6184 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6187 2011-07-08 Jason Rumney <jasonr@gnu.org>
6189 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6190 SH_SHOW for hidden windows (Bug#5482).
6192 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6193 frame struct members of non-existent frames (Bug#6284).
6195 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6197 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6198 variable firstTime not needed on OSX >= 10.6.
6199 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6200 >= 10.5. Use setKnobProportion, setDoubleValue.
6202 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6203 (MAC_OS_X_VERSION_10_5): Define if not defined.
6204 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6205 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6206 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6208 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6209 cString and lossyCString on OSX >= 10.4
6211 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6212 sizeToFit on OSX >= 10.2.
6214 * nsimage.m (allocInitFromFile): Don't use deprecated method
6215 bestRepresentationForDevice on OSX >= 10.6.
6217 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6220 * emacs.c: Declare unexec_init_emacs_zone.
6222 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6224 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6226 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6227 on svcsMenu (Bug#8842).
6229 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6231 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6233 * nsterm.m (QUTF8_STRING): Declare.
6234 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6235 (validRequestorForSendType): Return type is (id).
6236 Change indexOfObjectIdenticalTo to indexOfObject.
6237 Check if we have local selection before returning self (Bug#8842).
6238 (writeSelectionToPasteboard): Put local selection into paste board
6239 if we have a local selection (Bug#8842).
6240 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6242 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6243 (ns_get_local_selection): Declare.
6245 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6247 * keymap.c (describe_map_tree): Don't insert a double newline at
6248 the end of the buffer (bug#1169) and return whether we inserted
6251 * callint.c (Fcall_interactively): Change "reading args" to
6252 "providing args" to try to clarify what it does (bug#1010).
6254 2011-07-07 Kenichi Handa <handa@m17n.org>
6256 * composite.c (composition_compute_stop_pos): Ignore a static
6257 composition starting before CHARPOS (Bug#8915).
6259 * xdisp.c (handle_composition_prop): Likewise.
6261 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6263 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6266 2011-07-07 Kenichi Handa <handa@m17n.org>
6268 * character.h (unicode_category_t): New enum type.
6270 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6271 (Qchar_code_property_table): New variable.
6272 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6273 (UNIPROP_COMPRESSED_FORM_P): New macros.
6274 (char_table_ascii): Uncompress the compressed values.
6275 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6276 Uncompress the compressed values.
6277 (sub_char_table_ref_and_range): Likewise.
6278 (char_table_ref_and_range): Uncompress the compressed values.
6279 (sub_char_table_set): New arg is_uniprop. Callers changed.
6280 Uncompress the compressed values.
6281 (sub_char_table_set_range): Args changed. Callers changed.
6282 (char_table_set_range): Adjuted for the above change.
6283 (map_sub_char_table): Delete args default_val and parent. Add arg
6284 top. Give decoded values to a Lisp function.
6285 (map_char_table): Adjust for the above change. Give decoded
6286 values to a Lisp function. Gcpro more variables.
6287 (uniprop_table_uncompress)
6288 (uniprop_decode_value_run_length): New functions.
6289 (uniprop_decoder, uniprop_decoder_count): New variables.
6290 (uniprop_get_decoder, uniprop_encode_value_character)
6291 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6293 (uniprop_encoder, uniprop_encoder_count): New variables.
6294 (uniprop_get_encoder, uniprop_table)
6295 (Funicode_property_table_internal, Fget_unicode_property_internal)
6296 (Fput_unicode_property_internal): New functions.
6297 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6298 Sunicode_property_table_internal, Sget_unicode_property_internal,
6299 and Sput_unicode_property_internal. Defvar_lisp
6300 char-code-property-alist.
6302 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6303 Vunicode_category_table.
6305 * font.c (font_range): Adjust for the change of
6306 Vunicode_category_table.
6308 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6310 * m/iris4d.h: Remove file, move contents ...
6311 * s/irix6-5.h: ... here.
6313 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6315 Remove unportable assumption about struct layout (Bug#8884).
6316 * alloc.c (mark_buffer):
6317 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6318 (clone_per_buffer_values): Don't assume that
6319 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6320 This isn't true in general, and it's particularly not true
6321 if Emacs is configured with --with-wide-int.
6322 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6323 New macros, used in the buffer.c change.
6325 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6327 * xsettings.c: Use both GConf and GSettings if both are available.
6328 (store_config_changed_event): Add comment.
6329 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6330 (store_tool_bar_style_changed): New functions.
6331 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6332 (struct xsettings): Move font inside HAVE_XFT.
6333 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6334 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6335 Move inside HAVE_XFT.
6336 (something_changed_gsettingsCB): Rename from something_changedCB.
6337 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6339 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6340 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6341 (something_changed_gconfCB): Rename from something_changedCB.
6342 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6343 (parse_settings): Move check for font inside HAVE_XFT.
6344 (read_settings, apply_xft_settings): Add comment.
6345 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6346 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6347 call store_font_name_changed.
6348 (xft_settings_event): Add comment.
6349 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6350 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6351 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6352 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6353 (xsettings_initialize): Call init_gsettings last.
6354 (xsettings_get_system_font, xsettings_get_system_normal_font):
6357 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6359 Random fixes. E.g., (random) never returned negative values.
6360 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6361 subseconds part to the entropy, as that's a bit more random.
6362 Prefer signed to unsigned, since the signedness doesn't matter and
6363 in general we prefer signed. When given a limit, use a
6364 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6365 latter isn't right if USE_2_TAGS_FOR_INTS.
6366 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6367 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6369 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6371 * textprop.c (text_property_stickiness):
6372 Obey Vtext_property_default_nonsticky.
6373 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6374 * w32fns.c (syms_of_w32fns):
6375 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6377 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6379 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6380 This is more efficient than Ffile_directory_p and avoids a minor race.
6382 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6384 * buffer.c (Foverlay_put): Say what the return value is
6387 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6388 is a directory before asking whether to use the file name
6390 (barf_or_query_if_file_exists): Make the "File is a directory"
6391 error be more correct.
6393 * fns.c (Frequire): Remove the mention of the .gz files, since
6394 that's installation-specific, but keep the mention of
6395 `get-load-suffixes'.
6397 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6399 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6400 Report string overflow if the output is too long.
6402 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6404 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6405 (syms_of_gnutls): Remove duplicate DEFSYM for
6406 Qgnutls_bootprop_verify_hostname_error, an error for
6407 Qgnutls_bootprop_verify_error (which is no longer used).
6409 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6410 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6411 Also (re)move comments that are misplaced or no longer relevant.
6413 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6415 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6417 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6419 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6420 and background color parameters if they have been changed.
6422 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6424 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6426 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6428 * xsettings.c (SYSTEM_FONT): Define only when used.
6429 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6431 * keymap.c (access_keymap_1): Now static.
6433 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6435 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6436 leave any prefix arg for the up event (Bug#1586).
6438 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6440 * lread.c (syms_of_lread): Mention single symbols defined by
6441 `defvar' or `defconst' (bug#7154).
6443 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6444 (Frequire): Mention get-load-suffixes.
6446 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6448 * window.h (window): Remove clone_number slot.
6449 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6451 (make_parent_window, make_window, saved_window)
6452 (Fset_window_configuration, save_window_save): Don't deal with
6454 * buffer.c (Qclone_number): Remove declaration.
6455 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6457 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6459 Add multiple inheritance to keymaps.
6460 * keymap.c (Fmake_composed_keymap): New function.
6461 (Fset_keymap_parent): Simplify.
6462 (fix_submap_inheritance): Remove.
6463 (access_keymap_1): New function extracted from access_keymap to handle
6464 embedded parents and handle lists of maps.
6465 (access_keymap): Use it.
6466 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6467 (Fcopy_keymap): Handle embedded parents.
6468 (Fcommand_remapping, define_as_prefix): Simplify.
6469 (Fkey_binding): Simplify.
6470 (syms_of_keymap): Move minibuffer-local-completion-map,
6471 minibuffer-local-filename-completion-map,
6472 minibuffer-local-must-match-map, and
6473 minibuffer-local-filename-must-match-map to Elisp.
6474 (syms_of_keymap): Defsubr make-composed-keymap.
6475 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6476 (parse_menu_item): Trivial simplification.
6478 2011-07-01 Glenn Morris <rgm@gnu.org>
6480 * Makefile.in (SETTINGS_LIBS): Fix typo.
6482 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6484 * coding.c (Fencode_coding_string): Record the last coding system
6485 used, as the function doc string says (bug#8738).
6487 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6489 * xsettings.c (store_monospaced_changed): Take new font as arg and
6490 check for change against current_mono_font.
6491 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6492 (emacs_settings_constructor, emacs_settings_get_property)
6493 (emacs_settings_set_property, emacs_settings_class_init)
6494 (emacs_settings_init, gsettings_obj): Remove.
6495 (something_changedCB): New function for HAVE_GSETTINGS.
6496 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6497 with value as argument.
6498 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6499 g_settings_new (Bug#8967). Do not create gsettings_obj.
6500 Remove calls to g_settings_bind. Connect something_changedCB to
6503 * xgselect.c: Add defined (HAVE_GSETTINGS).
6504 (xgselect_initialize): Ditto.
6506 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6507 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6510 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6512 * eval.c (struct backtrace): Simplify and port the data structure.
6513 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6514 signed bit field, as this assumption is not portable and it makes
6515 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6516 "char debug_on_exit : 1" as this is not portable either; instead,
6517 use the portable "unsigned int debug_on_exit : 1". Remove unused
6518 member evalargs. Remove obsolete comments about cc bombing out.
6520 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6522 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6523 Let HAVE_GSETTINGS override HAVE_GCONF.
6524 (store_monospaced_changed): New function.
6525 (EMACS_SETTINGS): A new type derived from GObject to handle
6526 GSettings notifications.
6527 (emacs_settings_constructor, emacs_settings_get_property)
6528 (emacs_settings_set_property, emacs_settings_class_init):
6530 (gsettings_client, gsettings_obj): New variables.
6531 (GSETTINGS_SCHEMA): New define.
6532 (something_changedCB): Call store_monospaced_changed.
6533 (init_gsettings): New function.
6534 (xsettings_initialize): Call init_gsettings.
6535 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6538 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6541 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6543 * window.c (resize_root_window, grow_mini_window)
6544 (shrink_mini_window): Rename Qresize_root_window to
6545 Qwindow_resize_root_window and Qresize_root_window_vertically to
6546 Qwindow_resize_root_window_vertically.
6548 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6550 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6552 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6554 * makefile.w32-in: Redesign dependencies so they reflect more
6555 clearly which files are directly included by each source file,
6556 and not through other includes.
6558 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6560 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6561 (sort_overlays, overlay_strings): When an overlay's clone number
6562 matches the window's clone number process the overlay even if
6563 the overlay's window property doesn't match the current window.
6565 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6566 (Fwindow_hchild): Rename to Fwindow_left_child.
6567 (Fwindow_next): Rename to Fwindow_next_sibling.
6568 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6569 (resize_window_check): Rename to window_resize_check.
6570 (resize_window_apply): Rename to window_resize_apply.
6571 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6572 (Fdelete_other_windows_internal, resize_frame_windows)
6573 (Fsplit_window_internal, Fdelete_window_internal)
6574 (grow_mini_window, shrink_mini_window)
6575 (Fresize_mini_window_internal): Fix callers accordingly.
6577 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6579 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6580 (emacs_fixed_set_min_size): Remove.
6581 (emacs_fixed_new): Take frame as argument.
6583 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6584 (_EmacsFixedPrivate): Remove minwidth/height.
6585 Add struct frame *f.
6586 (emacs_fixed_init): Initialize priv->f.
6587 (get_parent_class, emacs_fixed_set_min_size): Remove.
6588 (emacs_fixed_new): Set priv->f to argument.
6589 (emacs_fixed_get_preferred_width)
6590 (emacs_fixed_get_preferred_height): Use min_width/height from
6591 frames size_hint to set minimum and natural (Bug#8919).
6592 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6593 and use min_width/height from frames size_hint to set
6594 min_width/height (Bug#8919).
6596 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6597 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6600 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6602 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6603 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6606 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6608 * process.c (wait_reading_process_output): Bypass select if
6609 waiting for a cell while ignoring keyboard input, and input is
6610 pending. Suggested by Jan Djärv (Bug#8869).
6612 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6614 Use gnulib's dup2 module instead of rolling our own.
6615 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6617 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6619 * dispnew.c (scrolling_window): Before scrolling, turn off a
6620 mouse-highlight in the window being scrolled.
6622 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6624 Move DEFSYM to lisp.h and use everywhere.
6626 * character.h (DEFSYM): Move declaration...
6627 * lisp.h (DEFSYM): ...here.
6633 * w32select.c: Don't include character.h.
6635 * alloc.c (syms_of_alloc):
6636 * buffer.c (syms_of_buffer):
6637 * bytecode.c (syms_of_bytecode):
6638 * callint.c (syms_of_callint):
6639 * casefiddle.c (syms_of_casefiddle):
6640 * casetab.c (init_casetab_once):
6641 * category.c (init_category_once, syms_of_category):
6642 * ccl.c (syms_of_ccl):
6643 * cmds.c (syms_of_cmds):
6644 * composite.c (syms_of_composite):
6645 * dbusbind.c (syms_of_dbusbind):
6646 * dired.c (syms_of_dired):
6647 * dispnew.c (syms_of_display):
6648 * doc.c (syms_of_doc):
6649 * editfns.c (syms_of_editfns):
6650 * emacs.c (syms_of_emacs):
6651 * eval.c (syms_of_eval):
6652 * fileio.c (syms_of_fileio):
6653 * fns.c (syms_of_fns):
6654 * frame.c (syms_of_frame):
6655 * fringe.c (syms_of_fringe):
6656 * insdel.c (syms_of_insdel):
6657 * keymap.c (syms_of_keymap):
6658 * lread.c (init_obarray, syms_of_lread):
6659 * macros.c (syms_of_macros):
6660 * msdos.c (syms_of_msdos):
6661 * print.c (syms_of_print):
6662 * process.c (syms_of_process):
6663 * search.c (syms_of_search):
6664 * sound.c (syms_of_sound):
6665 * syntax.c (init_syntax_once, syms_of_syntax):
6666 * terminal.c (syms_of_terminal):
6667 * textprop.c (syms_of_textprop):
6668 * undo.c (syms_of_undo):
6669 * w32.c (globals_of_w32):
6670 * window.c (syms_of_window):
6671 * xdisp.c (syms_of_xdisp):
6672 * xfaces.c (syms_of_xfaces):
6673 * xfns.c (syms_of_xfns):
6674 * xmenu.c (syms_of_xmenu):
6675 * xsettings.c (syms_of_xsettings):
6676 * xterm.c (syms_of_xterm): Use DEFSYM.
6678 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6680 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6682 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6684 Integer and buffer overflow fixes (Bug#8873).
6686 * print.c (printchar, strout): Check for string overflow.
6687 (PRINTPREPARE, printchar, strout):
6688 Don't set size unless allocation succeeds.
6690 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6691 for sizes. Check for string overflow more accurately.
6692 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6694 * macros.c: Integer and buffer overflow fixes.
6695 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6696 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6697 Use ptrdiff_t, not int, for sizes.
6698 Don't increment bufsize until after realloc succeeds.
6699 Check for size-calculation overflow.
6700 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6702 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6704 * lread.c: Integer overflow fixes.
6705 (read_integer): Radix is now EMACS_INT, not int,
6706 to improve quality of diagnostics for out-of-range radices.
6707 Calculate buffer size correctly for out-of-range radices.
6708 (read1): Check for integer overflow in radices, and in
6709 read-circle numbers.
6710 (read_escape): Avoid int overflow.
6711 (Fload, openp, read_buffer_size, read1)
6712 (substitute_object_recurse, read_vector, read_list, map_obarray):
6713 Use ptrdiff_t, not int, for sizes.
6714 (read1): Use EMACS_INT, not int, for sizes.
6715 Check for size overflow.
6717 * image.c (cache_image): Check for size arithmetic overflow.
6719 * lread.c: Integer overflow issues.
6720 (saved_doc_string_size, saved_doc_string_length)
6721 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6722 Now ptrdiff_t, not int.
6723 (read1): Don't assume doc string length fits in int. Check for
6724 out-of-range doc string lengths.
6725 (read_list): Don't assume file position fits in int.
6726 (read_escape): Check for hex character overflow.
6728 2011-06-22 Leo Liu <sdl.web@gmail.com>
6730 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6731 Move to minibuffer.el.
6733 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6735 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6736 The following patches are for when GLYPH_DEBUG && !XASSERT.
6737 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6738 * dispnew.c (flush_stdout):
6739 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6740 Mark as externally visible.
6741 * dispnew.c (check_window_matrix_pointers): Now static.
6742 * dispnew.c (window_to_frame_vpos):
6743 * xfns.c (unwind_create_frame):
6744 * xterm.c (x_check_font): Remove unused local.
6745 * scroll.c (CHECK_BOUNDS):
6746 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6747 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6748 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6749 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6750 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6752 (debug_method_add): Use va_list and vsprintf rather than relying
6753 on undefined behavior with wrong number of arguments.
6754 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6755 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6756 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6757 since we're not interested in debugging glyphs with old libraries.
6758 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6759 GCC 4.6.0's static checking.
6761 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6763 Integer overflow and signedness fixes (Bug#8873).
6764 A few related buffer overrun fixes, too.
6766 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6768 * dispextern.h (struct face.stipple):
6769 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6770 (x_bitmap_mask, x_allocate_bitmap_record)
6771 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6772 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6773 (x_create_bitmap_from_xpm_data):
6774 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6775 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6777 * xfaces.c (load_pixmap):
6778 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6779 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6780 (.bitmaps_last, struct x_output.icon_bitmap):
6781 Use ptrdiff_t, not int, for bitmap indexes.
6782 (x_allocate_bitmap_record): Check for size overflow.
6783 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6785 Use ptrdiff_t, not int, for overlay counts.
6786 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6787 * editfns.c (overlays_around, get_pos_property):
6788 * textprop.c (get_char_property_and_overlay):
6789 * xdisp.c (next_overlay_change, note_mouse_highlight):
6790 * xfaces.c (face_at_buffer_position):
6791 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6792 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6793 (Fnext_overlay_change, Fprevious_overlay_change)
6794 (mouse_face_overlay_overlaps, Foverlays_in):
6795 Use ptrdiff_t, not int, for sizes.
6796 (overlays_at, overlays_in): Check for size-calculation overflow.
6798 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6800 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6801 (x_session_initialize): Do not assume string length fits in int.
6803 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6804 This is unlikely, but can occur if DPI is outlandish.
6806 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6807 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6809 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6810 * xrdb.c (magic_file_p, search_magic_path):
6811 Omit last arg SUFFIX; it was always 0. All callers changed.
6812 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6814 * xfont.c (xfont_match): Avoid need for strlen.
6816 * xfns.c: Don't assume strlen fits in int.
6817 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6819 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6820 not unsigned long, as we prefer signed integers. All callers changed.
6821 Detect integer overflow in repeat count.
6822 (message_dolog): Don't assume print length fits in 39 bytes.
6823 (display_mode_element): Don't assume strlen fits in int.
6825 * termcap.c: Don't assume sizes fit in int and never overflow.
6826 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6827 (gobble_line): Check for size-calculation overflow.
6829 * minibuf.c (Fread_buffer):
6830 * lread.c (intern, intern_c_string):
6831 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6832 Don't assume string length fits in int.
6834 * keyboard.c (parse_tool_bar_item):
6835 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6837 * font.c: Don't assume string length fits in int.
6838 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6839 Use ptrdiff_t, not int.
6840 (font_intern_prop): Don't assume string length fits in int.
6841 Don't assume integer property fits in fixnum.
6842 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6844 * filelock.c: Fix some buffer overrun and integer overflow issues.
6845 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6846 Reformulate so as not to need the command string.
6847 Invoke gzip -cd rather than gunzip, as it's more portable.
6848 (lock_info_type, lock_file_1, lock_file):
6849 Don't assume pid_t and time_t fit in unsigned long.
6850 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6851 (current_lock_owner): Prefer signed type for sizes.
6852 Use memcpy, not strncpy, where memcpy is what is really wanted.
6853 Don't assume (via atoi) that time_t and pid_t fit in int.
6854 Check for time_t and/or pid_t out of range, e.g., via a network share.
6855 Don't alloca where an auto var works fine.
6857 * fileio.c: Fix some integer overflow issues.
6858 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6859 Don't assume string length fits in int.
6860 (directory_file_name): Don't assume string length fits in long.
6861 (make_temp_name): Don't assume pid fits in int, or that its print
6862 length is less than 20.
6864 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6866 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6868 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6870 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6871 We prefer signed integers, even for size calculations.
6873 * emacs.c: Don't assume string length fits in 'int'.
6874 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6875 (main): Don't invoke strlen when not needed.
6877 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6878 (XD_DEBUG_MESSAGE): Don't waste a byte.
6880 * callproc.c (getenv_internal_1, getenv_internal)
6882 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6884 * lread.c (invalid_syntax): Omit length argument.
6885 All uses changed. This doesn't fix a bug, but it simplifies the
6886 code away from its former Hollerith-constant appearance, and it's
6887 one less 'int' to worry about when looking at integer-overflow issues.
6888 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6890 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6891 This didn't break anything, but it didn't help either.
6892 It's confusing to put a bogus integer in a place where the actual
6893 value does not matter.
6894 (LIST_END_P): Remove unused macro and its bogus comment.
6895 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6897 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6898 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6900 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6901 We prefer signed types, and the value cannot exceed the EMACS_INT
6902 range anyway (because otherwise the length would not be representable).
6903 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6904 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6905 This avoids a GCC warning when WIDE_EMACS_INT.
6907 * indent.c (sane_tab_width): New function.
6908 (current_column, scan_for_column, Findent_to, position_indentation)
6909 (compute_motion): Use it. This is just for clarity.
6910 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6912 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6914 * lisp.h (lint_assume): New macro.
6915 * composite.c (composition_gstring_put_cache):
6916 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6918 * editfns.c, insdel.c:
6919 Omit unnecessary forward decls, to simplify future changes.
6921 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6923 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6925 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6926 Use much-faster test for byte-length change.
6927 Don't assume string byte-length fits in 'int'.
6928 Check that character arg fits in 'int'.
6929 (mapcar1): Declare byte as byte, for clarity.
6931 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6933 * fns.c (concat): Catch string overflow earlier.
6934 Do not rely on integer wraparound.
6936 * dispextern.h (struct it.overlay_strings_charpos)
6937 (struct it.selective): Now EMACS_INT, not int.
6938 * xdisp.c (forward_to_next_line_start)
6939 (back_to_previous_visible_line_start)
6940 (reseat_at_next_visible_line_start, next_element_from_buffer):
6941 Don't arbitrarily truncate the value of 'selective' to int.
6943 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6945 * composite.c: Don't truncate sizes to 'int'.
6946 (composition_gstring_p, composition_reseat_it)
6947 (composition_adjust_point): Use EMACS_INT, not int.
6948 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6949 not EMACS_UINT, for indexes.
6951 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6953 * buffer.c: Include <verify.h>.
6954 (struct sortvec.priority, struct sortstr.priority):
6955 Now EMACS_INT, not int.
6956 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6957 (struct sortstr.size, record_overlay_string)
6958 (struct sortstrlist.size, struct sortlist.used):
6959 Don't truncate size to int.
6960 (record_overlay_string): Check for size-calculation overflow.
6961 (init_buffer_once): Check at compile-time, not run-time.
6963 2011-06-22 Jim Meyering <meyering@redhat.com>
6965 Don't leak an XBM-image-sized buffer
6966 * image.c (xbm_load): Free the image buffer after using it.
6968 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6971 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6972 that Sun C diagnosed.
6973 * fns.c (secure_hash): Fix pointer signedness issue.
6974 * intervals.c (static_offset_intervals): New function.
6975 (offset_intervals): Use it.
6977 2011-06-21 Leo Liu <sdl.web@gmail.com>
6980 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6983 * fns.c (secure_hash): Rename from crypto_hash_function and change
6984 the first arg to accept symbols.
6985 (Fsecure_hash): New primitive.
6986 (syms_of_fns): New symbols.
6988 2011-06-20 Deniz Dogan <deniz@dogan.se>
6990 * process.c (Fset_process_buffer): Clarify return value in
6993 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
6995 * dispnew.c (add_window_display_history): Use BVAR.
6997 * xdisp.c (debug_method_add): Use BVAR.
6998 (check_window_end, dump_glyph_matrix, dump_glyph)
6999 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7001 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7004 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7005 check till after the cache is created in init_frame_faces.
7007 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7009 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7011 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7013 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7014 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7015 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7017 Improve buffer-overflow checking (Bug#8873).
7018 * fileio.c (Finsert_file_contents):
7019 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7020 Remove the old (too-loose) buffer overflow checks.
7021 They weren't needed, since make_gap checks for buffer overflow.
7022 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7023 The old code merely checked for Emacs fixnum overflow, and relied
7024 on undefined (wraparound) behavior. The new code avoids undefined
7025 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7027 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7028 Tune. Don't use wider integers than needed. Don't use alloca.
7029 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7031 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7033 * insdel.c, lisp.h (buffer_overflow): New function.
7034 (insert_from_buffer_1, replace_range, replace_range_2):
7035 * insdel.c (make_gap_larger):
7036 * editfns.c (Finsert_char):
7037 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7039 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7041 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7043 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7045 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7046 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7048 * fileio.c: Don't assume EMACS_INT fits in off_t.
7049 (emacs_lseek): New static function.
7050 (Finsert_file_contents, Fwrite_region): Use it.
7051 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7053 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7055 * fns.c: Don't overflow int when computing a list length.
7056 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7057 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7058 truncation on 64-bit hosts. Check for QUIT every
7059 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7060 faster and is responsive enough.
7061 (Flength): Report an error instead of overflowing an integer.
7062 (Fsafe_length): Return a float if the value is not representable
7063 as a fixnum. This shouldn't happen except in contrived situations.
7064 (Fnthcdr, Fsort): Don't assume list length fits in int.
7065 (Fcopy_sequence): Don't assume vector length fits in int.
7067 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7068 (header_size, word_size): New constants.
7069 (allocate_vectorlike): Don't check size overflow here.
7070 (allocate_vector): Check it here instead, since this is the only
7071 caller of allocate_vectorlike that could cause overflow.
7072 Check that the new vector's length is representable as a fixnum.
7074 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7075 The previous code was bogus. For example, next_almost_prime (32)
7076 returned 39, which is undesirable as it is a multiple of 3; and
7077 next_almost_prime (24) returned 25, which is a multiple of 5 so
7078 why was the code bothering to check for multiples of 7?
7080 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7082 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7084 Variadic C functions now count arguments with ptrdiff_t.
7085 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7086 Back then I didn't know that the Emacs coding style prefers signed int.
7087 Also, in the meantime I found a few more instances where arguments
7088 were being counted with int, which may truncate counts on 64-bit
7089 machines, or EMACS_INT, which may be unnecessarily wide.
7090 * lisp.h (struct Lisp_Subr.function.aMANY)
7091 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7092 Arg counts are now ptrdiff_t, not size_t.
7093 All variadic functions and their callers changed accordingly.
7094 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7095 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7096 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7097 * callint.c (Fcall_interactively): Check arg count for overflow,
7098 to avoid potential buffer overrun. Use signed char, not 'int',
7099 for 'varies' array, so that we needn't bother to check its size
7100 calculation for overflow.
7101 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7102 * eval.c (apply_lambda):
7103 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7104 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7105 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7107 * callint.c (Fcall_interactively): Don't use index var as event count.
7109 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7110 * mem-limits.h (SIZE): Remove; no longer used.
7112 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7114 Remove unnecessary casts.
7115 * xterm.c (x_term_init):
7116 * xfns.c (x_set_border_pixel):
7117 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7118 These aren't needed now that we assume ANSI C.
7120 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7121 It's more likely to cause problems (due to unsigned overflow)
7124 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7126 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7128 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7130 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7132 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7134 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7136 GLYPH_CODE_FACE returns EMACS_INT, not int.
7137 * dispextern.h (merge_faces):
7138 * xfaces.c (merge_faces):
7139 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7140 Don't assume EMACS_INT fits in int.
7142 * character.h (CHAR_VALID_P): Remove unused parameter.
7143 * fontset.c, lisp.h, xdisp.c: All uses changed.
7145 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7147 * fns.c (concat): Minor tuning based on overflow analysis.
7148 This doesn't fix any bugs. Use int to hold character, instead
7149 of constantly refetching from Emacs object. Use XFASTINT, not
7150 XINT, for value known to be a character. Don't bother comparing
7151 a single byte to 0400, as it's always less.
7153 * floatfns.c (Fexpt):
7154 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7156 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7159 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7161 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7162 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7163 incorrectly succeed when S was a string, because 4294967386 was
7164 truncated before it was used.
7166 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7167 Otherwise, an out-of-range integer could cause undefined behavior
7170 * composite.c: Use int, not EMACS_INT, for characters.
7171 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7172 EMACS_INT, for values that are known to be in character range.
7173 This doesn't fix any bugs but is the usual style inside Emacs and
7174 may generate better code on 32-bit machines.
7176 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7177 This is for reasons similar to the recent CHAR_STRING fix.
7178 * charset.c (Fencode_char): Check that character arg is actually
7179 a character. Pass an int to ENCODE_CHAR.
7180 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7181 wider than 'int', as a compile-time check to prevent future regressions
7184 * character.c (char_string): Remove unnecessary casts.
7186 Make sure a 64-bit char is never passed to CHAR_STRING.
7187 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7188 by silently ignoring the top 32 bits, allowing some values
7189 that were far too large to be valid characters.
7190 * character.h: Include <verify.h>.
7191 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7192 arguments are no wider than unsigned, as a compile-time check
7193 to prevent future regressions in this area.
7195 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7196 (Fsubst_char_in_region):
7198 * xdisp.c (decode_mode_spec_coding):
7199 Adjust to CHAR_STRING's new requirement.
7200 * editfns.c (Finsert_char, Fsubst_char_in_region):
7201 * fns.c (concat): Check that character args are actually
7202 characters. Without this test, these functions did the wrong
7203 thing with wildly out-of-range values on 64-bit hosts.
7205 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7206 These casts should not be needed on 32-bit hosts, either.
7207 * keyboard.c (read_char):
7208 * lread.c (Fload): Remove casts to unsigned.
7210 * lisp.h (UNSIGNED_CMP): New macro.
7211 This fixes comparison bugs on 64-bit hosts.
7212 (ASCII_CHAR_P): Use it.
7213 * casefiddle.c (casify_object):
7214 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7215 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7216 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7217 * dispextern.h (FACE_FROM_ID):
7218 * keyboard.c (read_char): Use UNSIGNED_CMP.
7220 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7221 not to EMACS_INT, to avoid GCC warning.
7223 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7225 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7226 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7227 isn't needed on 32-bit machines.
7229 * buffer.c (Fgenerate_new_buffer_name):
7230 Use EMACS_INT for count, not int.
7231 (advance_to_char_boundary): Return EMACS_INT, not int.
7233 * data.c (Qcompiled_function): Now static.
7235 * window.c (window_body_lines): Now static.
7237 * image.c (gif_load): Rename local to avoid shadowing.
7239 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7240 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7241 * alloc.c (make_save_value): Integer argument is now of type
7243 (mark_object): Use ptrdiff_t, not int.
7244 * lisp.h (pD): New macro.
7245 * print.c (print_object): Use it.
7247 * alloc.c: Use EMACS_INT, not int, to count objects.
7248 (total_conses, total_markers, total_symbols, total_vector_size)
7249 (total_free_conses, total_free_markers, total_free_symbols)
7250 (total_free_floats, total_floats, total_free_intervals)
7251 (total_intervals, total_strings, total_free_strings):
7252 Now EMACS_INT, not int. All uses changed.
7253 (Fgarbage_collect): Compute overall total using a double, so that
7254 integer overflow is less likely to be a problem. Check for overflow
7255 when converting back to an integer.
7256 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7257 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7258 These were 'int' variables that could overflow on 64-bit hosts;
7259 they were never used, so remove them instead of repairing them.
7260 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7261 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7262 Previously, this ceilinged at INT_MAX, but that doesn't work on
7264 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7266 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7267 (allocate_vectorlike): Check for ptrdiff_t overflow.
7268 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7269 when a (possibly-narrower) signed value would do just as well.
7270 We prefer using signed arithmetic, to avoid comparison confusion.
7272 * alloc.c: Catch some string size overflows that we were missing.
7273 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7274 for convenience in STRING_BYTES_MAX.
7275 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7276 The definition here is exact; the one in lisp.h was approximate.
7277 (allocate_string_data): Check for string overflow. This catches
7278 some instances we weren't catching before. Also, it catches
7279 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7280 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7281 and ptrdiff_t and EMACS_INT are both 64 bits.
7283 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7284 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7285 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7287 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7289 * alloc.c (Fmake_string): Check for out-of-range init.
7291 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7293 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7295 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7297 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7298 xg_get_default_scrollbar_width.
7300 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7301 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7302 (style_changed_cb): Call update_theme_scrollbar_width and call
7303 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7304 all frames (Bug#8505).
7305 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7306 Call gtk_window_set_resizable if HAVE_GTK3.
7307 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7308 and height if HAVE_GTK3 (Bug#8505).
7309 (scroll_bar_width_for_theme): New variable.
7310 (update_theme_scrollbar_width): New function.
7311 (xg_get_default_scrollbar_width): Move code to
7312 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7313 (xg_initialize): Call update_theme_scrollbar_width.
7315 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7317 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7319 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7321 * frame.c (make_frame): Call other_buffer_safely instead of
7324 * window.c (temp_output_buffer_show): Call display_buffer with
7325 second argument Vtemp_buffer_show_specifiers and reset latter
7326 immediately after the call.
7327 (Vtemp_buffer_show_specifiers): New variable.
7328 (auto_window_vscroll_p, next_screen_context_lines)
7329 (Vscroll_preserve_screen_position): Remove leading asterisks from
7332 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7334 Fix minor problems found by GCC 4.6.0 static checking.
7335 * buffer.c (Qclone_number): Remove for now, as it's unused.
7336 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7337 (record_buffer): Remove unused local.
7338 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7339 (set_frame_buffer_list): Remove; unused.
7340 * frame.h (other_visible_frames): Remove decl.
7341 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7342 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7343 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7345 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7346 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7347 Define only if HAVE_GPM.
7348 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7349 (update_hints_inhibit): Remove; never set. All uses removed.
7350 * widgetprv.h (emacsFrameClassRec): Remove decl.
7351 * window.c (delete_deletable_window): Now returns void, since it
7352 wasn't returning anything.
7353 (compare_window_configurations): Remove unused locals.
7354 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7355 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7356 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7357 the same widths as pointers. This follows up on the 2011-05-06 patch.
7358 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7359 * xterm.h: Likewise.
7360 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7362 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7364 * makefile.w32-in: Update dependencies.
7365 (LISP_H): Add lib/intprops.h.
7367 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7369 * image.c (gif_load): Add animation frame delay to the metadata.
7370 (syms_of_image): Use DEFSYM. New symbol `delay'.
7372 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7374 * window.c (delete_deletable_window): Re-add.
7375 (Fset_window_configuration): Rewrite to handle dead buffers and
7376 consequently deletable windows.
7377 (window_tree, Fwindow_tree): Remove. Supply functionality in
7379 (compare_window_configurations): Simplify code.
7381 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7383 * image.c (imagemagick_load_image): Fix type mismatch.
7384 (Fimagemagick_types): Likewise.
7386 * window.h (replace_buffer_in_windows): Declare.
7388 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7390 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7391 Qclone_number. Remove external declaration of Qdelete_window.
7392 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7394 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7395 Run Qbuffer_list_update_hook if allowed.
7396 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7397 buffer list implementation.
7398 (other_buffer_safely): New function.
7399 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7400 calls to replace_buffer_in_windows and
7401 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7403 (record_buffer): Inhibit quitting and rewrite using quittable
7404 functions. Run Qbuffer_list_update_hook if allowed.
7405 (Frecord_buffer, Funrecord_buffer): New functions.
7406 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7407 Move switch-to-buffer to window.el.
7408 (bury-buffer): Move to window.el.
7409 (Vbuffer_list_update_hook): New variable.
7411 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7414 * window.h (resize_frame_windows): Move up in code.
7415 (Fwindow_frame): Remove EXFUN.
7416 (replace_buffer_in_all_windows): Remove prototype.
7417 (replace_buffer_in_windows_safely): Add prototype.
7419 * window.c: Declare Qdelete_window static again. Move down
7420 declaration of select_count.
7421 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7422 (Fother_window): Move to window.el.
7423 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7424 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7425 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7427 (replace_buffer_in_windows): Implement by calling
7428 Qreplace_buffer_in_windows.
7429 (replace_buffer_in_all_windows): Remove with some functionality
7430 moved into replace_buffer_in_windows_safely.
7431 (replace_buffer_in_windows_safely): New function.
7432 (select_window_norecord, select_frame_norecord): Move in front
7433 of run_window_configuration_change_hook. Remove now obsolete
7435 (Fset_window_buffer): Rewrite doc-string.
7436 Call Qrecord_window_buffer.
7437 (keys_of_window): Move binding for other-window to window.el.
7439 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7441 * dispextern.h (struct image): Replace data member, whose int_val
7442 and ptr_val fields were not used by anything, with a single
7445 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7446 (gif_clear_image, gif_load, imagemagick_load_image)
7447 (gs_clear_image, gs_load): Callers changed.
7449 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7451 * buffer.h: Include <time.h>, for time_t.
7452 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7454 Fix minor problems found by static checking.
7456 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7458 Make identifiers static if they are not used in other modules.
7459 * data.c (Qcompiled_function, Qframe, Qvector):
7460 * image.c (QimageMagick, Qsvg):
7461 * minibuf.c (Qmetadata):
7462 * window.c (resize_window_check, resize_root_window): Now static.
7463 * window.h (resize_window_check, resize_root_window): Remove decls.
7465 * window.c (window_deletion_count, delete_deletable_window):
7467 (window_body_lines): Now static.
7468 (Fdelete_other_windows_internal): Mark vars as initialized.
7469 Make sure 'resize_failed' is initialized.
7470 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7471 (resize_window_apply): Remove unused local.
7472 * window.h (delete_deletable_window): Remove decl.
7474 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7475 (imagemagick_load_image): Fix pointer signedness problem by changing
7476 last arg from unsigned char * to char *. All uses changed.
7477 Also, fix a local for similar reasons.
7478 Remove unused locals. Remove locals to avoid shadowing.
7479 (fn_rsvg_handle_free): Remove; unused.
7480 (svg_load, svg_load_image): Fix pointer signedness problem.
7481 (imagemagick_load_image): Don't use garbage pointer image_wand.
7483 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7485 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7487 * image.c (gif_load): Fix omitted cast error introduced by
7490 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7492 * window.h (resize_proportionally, orig_total_lines)
7493 (orig_top_line): Remove from window structure.
7494 (set_window_height, set_window_width, change_window_heights)
7495 (Fdelete_window): Remove prototypes.
7496 (resize_frame_windows): Remove duplicate declaration.
7498 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7500 * window.h (resize_frame_windows, resize_window_check)
7501 (delete_deletable_window, resize_root_window)
7502 (resize_frame_windows): Declare prototypes.
7504 * window.c (resize_window_apply): Make definition be "static" to
7505 match the prototype.
7507 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7509 * window.c: Remove declarations of Qwindow_size_fixed,
7510 window_min_size_1, window_min_size_2, window_min_size,
7511 size_window, window_fixed_size_p, enlarge_window, delete_window.
7512 Remove static from declaration of Qdelete_window, it's
7513 temporarily needed by Fbury_buffer.
7514 (replace_window): Don't assign orig_top_line and
7516 (Fdelete_window, delete_window): Remove. Window deletion is
7517 handled by window.el.
7518 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7519 Replace Fdelete_window calls with calls to Qdelete_window.
7520 (Fdelete_other_windows): Remove. Deleting other windows is
7521 handled by window.el.
7522 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7523 handled in window.el.
7524 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7525 Window minimum sizes are handled in window.el.
7526 (shrink_windows, size_window, set_window_height)
7527 (set_window_width, change_window_heights, window_height)
7528 (window_width, CURBEG, CURSIZE, enlarge_window)
7529 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7530 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7531 handled in window.el.
7532 (make_dummy_parent): Rename to make_parent_window and give it a
7533 second argument horflag.
7534 (make_window): Don't set resize_proportionally any more.
7535 (Fsplit_window): Remove. Windows are split in window.el.
7536 (save_restore_action, save_restore_orig_size)
7537 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7538 Resize mini windows in window.el.
7539 (grow_mini_window, shrink_mini_window): Implement by calling
7540 Qresize_root_window_vertically, resize_window_check and
7541 resize_window_apply.
7542 (saved_window, Fset_window_configuration, save_window_save):
7543 Do not handle orig_top_line, orig_total_lines, and
7544 resize_proportionally.
7545 (window_min_height, window_min_width): Move to window.el.
7546 (keys_of_window): Move bindings for delete-other-windows,
7547 split-window, delete-window and enlarge-window to window.el.
7549 * buffer.c: Temporarily extern Qdelete_window.
7550 (Fbury_buffer): Temporarily call Qdelete_window instead of
7551 Fdelete_window (Fbury_buffer will move to window.el soon).
7553 * frame.c (set_menu_bar_lines_1): Remove code handling
7554 orig_top_line and orig_total_lines.
7556 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7557 set_window_height but set heights directly.
7558 (change_frame_size_1): Use resize_frame_windows.
7560 * xdisp.c (init_xdisp): Don't use set_window_height but set
7563 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7564 Use resize_frame_windows instead of change_window_heights and run
7565 run_window_configuration_change_hook.
7567 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7568 instead of change_window_heights and run
7569 run_window_configuration_change_hook.
7571 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7573 * window.c (replace_window): Rename second argument REPLACEMENT to
7574 NEW. New third argument SETFLAG. Rewrite.
7575 (delete_window, make_dummy_parent): Call replace_window with
7577 (window_list_1): Move down in code.
7578 (run_window_configuration_change_hook): Move set_buffer part
7579 before select_frame_norecord part in order to unwind correctly.
7580 Rename count1 to count.
7581 (recombine_windows, delete_deletable_window, resize_root_window)
7582 (Fdelete_other_windows_internal)
7583 (Frun_window_configuration_change_hook, make_parent_window)
7584 (resize_window_check, resize_window_apply, Fresize_window_apply)
7585 (resize_frame_windows, Fsplit_window_internal)
7586 (Fdelete_window_internal, Fresize_mini_window_internal):
7588 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7590 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7592 * window.h (window): Add some new members to window structure -
7593 normal_lines, normal_cols, new_total, new_normal, clone_number,
7594 splits, nest, prev_buffers, next_buffers.
7595 (WINDOW_TOTAL_SIZE): Move here from window.c.
7596 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7598 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7600 (make_dummy_parent): Set new members of windows structure.
7601 (make_window): Move down in code. Handle new members of window
7603 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7604 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7605 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7606 (Fset_window_prev_buffers, Fwindow_next_buffers)
7607 (Fset_window_next_buffers, Fset_window_clone_number):
7609 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7610 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7612 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7613 Argument WINDOW can be now internal window too.
7614 (Fwindow_use_time): Move up in code.
7615 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7617 (Fset_window_configuration, saved_window)
7618 (Fcurrent_window_configuration, save_window_save): Handle new
7619 members of window structure.
7620 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7621 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7622 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7623 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7624 Qget_mru_window, Qresize_root_window,
7625 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7626 Qauto_buffer_name; staticpro them.
7628 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7630 * window.c (Fwindow_total_size, Fwindow_left_column)
7631 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7632 (Fwindow_list_1): New functions.
7633 (window_box_text_cols): Replace with window_body_cols.
7634 (Fwindow_width, Fscroll_left, Fscroll_right):
7635 Use window_body_cols instead of window_box_text_cols.
7636 (delete_window, Fset_window_configuration):
7637 Call delete_all_subwindows with window as argument.
7638 (delete_all_subwindows): Take a window as argument and not a
7640 (window_loop): Remove handling of GET_LRU_WINDOW and
7642 (Fget_lru_window, Fget_largest_window): Move to window.el.
7644 * window.h: Extern window_body_cols instead of
7645 window_box_text_cols. delete_all_subwindows now takes a
7646 Lisp_Object as argument.
7648 * indent.c (compute_motion, Fcompute_motion):
7649 Use window_body_cols instead of window_box_text_cols.
7651 * frame.c (delete_frame): Call delete_all_subwindows with root
7654 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7656 * fns.c (Fputhash): Document return value.
7658 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7660 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7662 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7664 Cons<->int and similar integer overflow fixes (Bug#8794).
7666 Check for overflow when converting integer to cons and back.
7667 * charset.c (Fdefine_charset_internal, Fdecode_char):
7668 Use cons_to_unsigned to catch overflow.
7669 (Fencode_char): Use INTEGER_TO_CONS.
7670 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7671 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7672 * data.c (long_to_cons, cons_to_long): Remove.
7673 (cons_to_unsigned, cons_to_signed): New functions.
7674 These signal an error for invalid or out-of-range values.
7675 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7676 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7677 * font.c (Ffont_variation_glyphs):
7678 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7679 * lisp.h: Include <intprops.h>.
7680 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7681 (cons_to_signed, cons_to_unsigned): New decls.
7682 (long_to_cons, cons_to_long): Remove decls.
7683 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7684 (Fprimitive_undo): Use CONS_TO_INTEGER.
7685 * xfns.c (Fx_window_property): Likewise.
7686 * xselect.c: Include <limits.h>.
7687 (x_own_selection, selection_data_to_lisp_data):
7688 Use INTEGER_TO_CONS.
7689 (x_handle_selection_request, x_handle_selection_clear)
7690 (x_get_foreign_selection, Fx_disown_selection_internal)
7691 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7692 (lisp_data_to_selection_data): Use cons_to_unsigned.
7693 (x_fill_property_data): Use cons_to_signed.
7694 Report values out of range.
7696 Check for buffer and string overflow more precisely.
7697 * buffer.h (BUF_BYTES_MAX): New macro.
7698 * lisp.h (STRING_BYTES_MAX): New macro.
7699 * alloc.c (Fmake_string):
7700 * character.c (string_escape_byte8):
7701 * coding.c (coding_alloc_by_realloc):
7702 * doprnt.c (doprnt):
7703 * editfns.c (Fformat):
7705 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7706 since they may not be the same number.
7707 * editfns.c (Finsert_char):
7708 * fileio.c (Finsert_file_contents):
7709 Likewise for BUF_BYTES_MAX.
7711 * image.c: Use ptrdiff_t, not int, for sizes.
7712 (slurp_file): Switch from int to ptrdiff_t.
7714 (slurp_file): Check that file size fits in both size_t (for
7715 malloc) and ptrdiff_t (for sanity and safety).
7717 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7718 if b->modtime has its maximal value.
7720 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7722 Don't assume time_t can fit into int.
7723 * buffer.h (struct buffer.modtime): Now time_t, not int.
7724 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7725 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7727 Minor fixes for signed vs unsigned integers.
7728 * character.h (MAYBE_UNIFY_CHAR):
7729 * charset.c (maybe_unify_char):
7730 * keyboard.c (read_char, reorder_modifiers):
7731 XINT -> XFASTINT, since the integer must be nonnegative.
7732 * ftfont.c (ftfont_spec_pattern):
7733 * keymap.c (access_keymap, silly_event_symbol_error):
7734 XUINT -> XFASTINT, since the integer must be nonnegative.
7735 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7736 since it makes no difference and we prefer signed.
7737 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7738 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7741 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7743 * window.h (Fwindow_frame): Declare.
7745 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7747 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7748 (SPARE_MEMORY): Always define.
7749 (LARGE_REQUEST): Remove.
7750 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7752 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7754 * lisp.h: Move EXFUNS for Fframe_root_window,
7755 Fframe_first_window and Fset_frame_selected_window to window.h.
7757 * window.h: Move EXFUNS for Fframe_root_window,
7758 Fframe_first_window and Fset_frame_selected_window here from
7761 * frame.c (Fwindow_frame, Fframe_first_window)
7762 (Fframe_root_window, Fframe_selected_window)
7763 (Fset_frame_selected_window): Move to window.c.
7764 (Factive_minibuffer_window): Move to minibuf.c.
7765 (Fother_visible_frames_p): New function.
7767 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7769 * window.c (decode_window, decode_any_window): Move up in code.
7770 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7771 (inhibit_frame_unsplittable): Remove unused variable.
7772 (Fwindow_buffer): Move up and rewrite doc-string.
7773 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7774 (Fwindow_prev): New functions.
7775 (Fwindow_frame): Move here from frame.c. Accept any window as
7777 (Fframe_root_window, Fframe_first_window)
7778 (Fframe_selected_window): Move here from frame.c. Accept frame
7779 or arbitrary window as argument. Update doc-strings.
7780 (Fminibuffer_window): Move up in code.
7781 (Fwindow_minibuffer_p): Move up in code and simplify.
7782 (Fset_frame_selected_window): Move here from frame.c.
7784 (Fselected_window, select_window, Fselect_window): Move up in
7785 code. Minor doc-string fixes.
7787 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7789 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7790 Do not assume that spare memory exists; that assumption is valid
7791 only if SYSTEM_MALLOC.
7792 (LARGE_REQUEST): New macro, so that the issue of large requests
7793 is separated from the issue of spare memory.
7795 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7797 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7800 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7802 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7805 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7807 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7809 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7811 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7812 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7814 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7816 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7818 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7820 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7821 (x_clipboard_manager_save): Add return value.
7822 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7824 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7825 Obey Vx_select_enable_clipboard_manager. Catch errors in
7826 x_clipboard_manager_save (Bug#8779).
7827 (Vx_select_enable_clipboard_manager): New variable.
7828 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7830 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7832 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7834 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7836 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7837 in the current matrix if keep_current_p is non-zero.
7839 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7841 * bidi.c (bidi_level_of_next_char): Fix last change.
7843 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7845 Support bidi reordering of text covered by display properties.
7847 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7848 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7849 (bidi_cache_search, bidi_cache_iterator_state)
7850 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7851 (bidi_level_of_next_char, bidi_move_to_visually_next):
7852 Support character positions inside a run of characters covered by a
7854 (bidi_paragraph_init, bidi_resolve_explicit_1)
7855 (bidi_level_of_next_char): Call bidi_fetch_char and
7856 bidi_fetch_char_advance instead of FETCH_CHAR and
7858 (bidi_init_it): Initialize new members.
7859 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7861 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7862 instead of using explicit *_CHAR codes.
7863 (bidi_resolve_explicit, bidi_resolve_weak):
7864 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7865 bidirectional text is supported only in multibyte buffers.
7866 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7867 it to initialize the frame_window_p member of struct bidi_it.
7868 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7869 (bidi_resolve_explicit, bidi_resolve_weak)
7870 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7871 bidi_it->nchars is non-positive.
7872 (bidi_level_of_next_char): Don't try to lookup the cache for the
7873 next/previous character if nothing is cached there yet, or if we
7874 were just reseat()'ed to a new position.
7876 * xdisp.c (set_cursor_from_row): Set start and stop points
7877 according to the row's direction when priming the loop that looks
7878 for the glyph on which to display cursor.
7879 (single_display_spec_intangible_p): Function deleted.
7880 (display_prop_intangible_p): Reimplement to call
7881 handle_display_spec instead of single_display_spec_intangible_p.
7882 Accept 3 additional arguments needed by handle_display_spec.
7883 This fixes incorrect cursor motion across display property with complex
7884 values: lists, `(when COND...)' forms, etc.
7885 (single_display_spec_string_p): Support property values that are
7886 lists with the argument STRING its top-level element.
7887 (display_prop_string_p): Fix the condition for processing a
7888 property that is a list to be consistent with handle_display_spec.
7889 (handle_display_spec): New function, refactored from the
7890 last portion of handle_display_prop.
7891 (compute_display_string_pos): Accept additional argument
7892 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7893 value of a `display' property is a "replacing spec".
7894 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7895 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7896 the display property, but just return a value indicating whether
7897 the display property will replace the characters it covers.
7898 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7899 frame_window_p members of struct bidi_it.
7900 (compute_display_string_pos, compute_display_string_end):
7902 (push_it): Accept second argument POSITION, where pop_it should
7903 jump to continue iteration.
7904 (reseat_1): Initialize bidi_it.disp_pos.
7906 * keyboard.c (adjust_point_for_property): Adjust the call to
7907 display_prop_intangible_p to its new signature.
7909 * dispextern.h (struct bidi_it): New member frame_window_p.
7910 (bidi_init_it): Update prototypes.
7911 (display_prop_intangible_p): Update prototype.
7912 (compute_display_string_pos, compute_display_string_end):
7914 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7917 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7919 Malloc failure behavior now depends on size of allocation.
7920 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7921 * lisp.h: Change signatures accordingly.
7922 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7923 All callers changed. (Bug#8762)
7925 * gnutls.c: Use Emacs's memory allocators.
7926 Without this change, the gnutls library would invoke malloc etc.
7927 directly, which causes problems on non-SYNC_INPUT hosts, and which
7928 runs afoul of improving memory_full behavior. (Bug#8761)
7929 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7930 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7931 xfree instead of the default malloc, realloc, free.
7932 (Fgnutls_boot): No need to check for memory allocation failure,
7933 since xmalloc does that for us.
7935 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7936 * category.c (hash_get_category_set):
7937 * ccl.c (ccl_driver):
7938 * charset.c (Fdefine_charset_internal):
7939 * charset.h (struct charset.hash_index):
7940 * composite.c (get_composition_id, gstring_lookup_cache)
7941 (composition_gstring_put_cache):
7942 * composite.h (struct composition.hash_index):
7943 * dispextern.h (struct image.hash):
7944 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7945 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7946 (hashfn_equal, hashfn_user_defined, make_hash_table)
7947 (maybe_resize_hash_table, hash_lookup, hash_put)
7948 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7949 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7950 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7951 * image.c (make_image, search_image_cache, lookup_image)
7952 (xpm_put_color_table_h):
7953 * lisp.h (struct Lisp_Hash_Table):
7954 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7955 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7956 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7957 * alloc.c (allocate_vectorlike):
7958 Check for overflow in vector size calculations.
7959 * ccl.c (ccl_driver):
7960 Check for overflow when converting EMACS_INT to int.
7961 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7962 need to be updated by these changes.
7963 * fns.c (make_hash_table, maybe_resize_hash_table):
7964 Check for integer overflow with large hash tables.
7965 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7966 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7967 (SXHASH_REDUCE): New macro.
7968 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7969 Use it instead of discarding useful hash info with large hash values.
7970 (sxhash_float): New function.
7971 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7972 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
7973 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7974 Rewrite to use FIXNUM_BITS, as this simplifies things.
7975 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7976 Adjust signatures to match updated version of code.
7977 (consing_since_gc): Now EMACS_INT, since a single hash table can
7978 use more than INT_MAX bytes.
7980 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7982 Make it possible to build with GCC-4.6+ -O2 -flto.
7984 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7986 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7988 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7989 Call minibuffer-inactive-mode.
7991 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
7993 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7994 Update dependencies.
7996 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7998 * data.c (init_data): Remove code for UTS, this system is not
8001 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8003 Don't force ./temacs to start in terminal mode.
8005 * frame.c (make_initial_frame): Initialize faces in all cases, not
8006 only when CANNOT_DUMP is defined.
8007 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8009 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8011 * dispnew.c (add_window_display_history): Use const for the string
8012 pointer. Remove declaration, not needed.
8014 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8016 Use 'inline', not 'INLINE'.
8017 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8018 * alloc.c, fontset.c (INLINE): Remove.
8019 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8020 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8021 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8022 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8023 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8025 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8027 Make it possible to run ./temacs.
8029 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8030 syms_of_callproc does the same thing. Remove test for
8031 "initialized", do it in the caller.
8032 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8034 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8036 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8037 (read_minibuf): Use get_minibuffer.
8038 (syms_of_minibuf): Use DEFSYM.
8039 (Qmetadata): New var.
8040 * data.c (Qbuffer): Don't make it static.
8041 (syms_of_data): Use DEFSYM.
8043 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8045 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8046 (CCL_CODE_MIN): New macro.
8048 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8050 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8052 * eval.c (Qdebug): Now static.
8053 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8054 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8055 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8057 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8059 * image.c: Various fixes to ImageMagick code comments.
8060 (Fimagemagick_types): Doc fix.
8062 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8064 Minor fixes prompted by GCC 4.6.0 warnings.
8066 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8068 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8069 (x_clipboard_manager_save_all): Move extern decl to ...
8070 * xterm.h: ... here, so that it can be checked for consistency.
8072 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8074 * xselect.c (x_clipboard_manager_save_frame)
8075 (x_clipboard_manager_save_all): New functions.
8076 (Fx_clipboard_manager_save): Lisp function deleted.
8078 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8079 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8081 * xterm.h: Update prototype.
8083 2011-05-28 William Xu <william.xwl@gmail.com>
8085 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8088 2011-05-28 Jim Meyering <meyering@redhat.com>
8090 Avoid a sign-extension bug in crypto_hash_function.
8091 * fns.c (to_uchar): Define.
8092 (crypto_hash_function): Use it to convert some newly-signed
8093 variables to unsigned, to avoid sign-extension bugs. For example,
8094 without this change, (md5 "truc") would evaluate to
8095 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8096 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8097 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8099 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8101 Integer overflow fixes.
8103 * dbusbind.c: Serial number integer overflow fixes.
8104 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8105 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8106 to hold a serial number that is too large for a fixnum.
8107 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8108 Check for serial numbers out of range. Decode any serial number
8109 that was so large that it became a float. (Bug#8722)
8111 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8112 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8113 Use XFASTINT rather than XUINT when numbers are nonnegative.
8114 (xd_append_arg, Fdbus_method_return_internal):
8115 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8116 arguments, check that Lisp number is nonnegative, rather than
8117 silently wrapping negative numbers around. (Bug#8722)
8118 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8121 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8123 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8125 ccl: Add integer overflow checks.
8126 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8127 (IN_INT_RANGE): New macros.
8128 (ccl_driver): Use them to check for integer overflow when
8129 decoding a CCL program. Many of the new checks are whether XINT (x)
8130 fits in int; it doesn't always, on 64-bit hosts. The new version
8131 doesn't catch all possible integer overflows, but it's an
8132 improvement. (Bug#8719)
8134 * alloc.c (make_event_array): Use XINT, not XUINT.
8135 There's no need for unsigned here.
8137 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8138 This follows up to the 2011-05-06 change that substituted uintptr_t
8139 for EMACS_INT. This case wasn't caught back then.
8141 Rework Fformat to avoid integer overflow issues.
8142 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8143 now (part of C89). Include <verify.h>.
8144 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8145 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8146 (Fformat): Avoid the prepass trying to compute sizes; it was only
8147 approximate and thus did not catch overflow reliably. Instead, walk
8148 through the format just once, formatting and computing sizes as we go,
8149 checking for integer overflow at every step, and allocating a larger
8150 buffer as needed. Keep track separately whether the format is
8151 multibyte. Keep only the most-recently calculated precision, rather
8152 than them all. Record whether each argument has been converted to
8153 string. Use EMACS_INT, not int, for byte and char and arg counts.
8154 Support field widths and precisions larger than INT_MAX. Avoid
8155 sprintf's undefined behavior with conversion specifications such as %#d
8156 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8157 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8158 formatting out-of-range floating point numbers with int
8161 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8163 * data.c: Avoid integer truncation in expressions involving floats.
8164 * data.c: Include <intprops.h>.
8165 (arith_driver): When there's an integer overflow in an expression
8166 involving floating point, convert the integers to floating point
8167 so that the resulting value does not suffer from catastrophic
8168 integer truncation. For example, on a 64-bit host (* 4
8169 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8170 Do not rely on undefined behavior after integer overflow.
8172 merge count_size_as_multibyte, parse_str_to_multibyte
8173 * character.c, character.h (count_size_as_multibyte):
8174 Rename from parse_str_to_multibyte; all uses changed.
8175 Check for integer overflow.
8176 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8177 since it's now a duplicate of the other. This is more of
8178 a character than a buffer op, so better that it's in character.c.
8179 * fns.c, print.c: Adjust to above changes.
8181 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8183 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8185 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8187 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8188 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8189 (x_clipboard_manager_save): Now static.
8190 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8192 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8193 (crypto_hash_function): Now static.
8194 Fix pointer signedness problems. Avoid unnecessary initializations.
8196 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8198 * termhooks.h (Vselection_alist): Make it terminal-local.
8200 * terminal.c (create_terminal): Initialize it.
8202 * xselect.c: Support for clipboard managers.
8203 (Vselection_alist): Move to termhooks.h as terminal-local var.
8204 (LOCAL_SELECTION): New macro.
8205 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8206 (symbol_to_x_atom): Remove gratuitous arg.
8207 (x_handle_selection_request, lisp_data_to_selection_data)
8208 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8209 (x_own_selection, x_get_local_selection, x_convert_selection):
8210 New arg, specifying work frame. Use terminal-local Vselection_alist.
8211 (some_frame_on_display): Delete unused function.
8212 (Fx_own_selection_internal, Fx_get_selection_internal)
8213 (Fx_disown_selection_internal, Fx_selection_owner_p)
8214 (Fx_selection_exists_p): New optional frame arg.
8215 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8216 (x_handle_selection_clear): Don't treat other terminals with the
8217 same keyboard specially. Use the terminal-local Vselection_alist.
8218 (x_clear_frame_selections): Use Frun_hook_with_args.
8220 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8222 * xterm.h: Add support for those atoms.
8224 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8226 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8227 (converted_selections, conversion_fail_tag): New global variables.
8228 (x_selection_request_lisp_error): Free the above.
8229 (x_get_local_selection): Remove unnecessary code.
8230 (x_reply_selection_request): Args changed; handle arbitrary array
8231 of converted selections stored in converted_selections.
8232 Separate the XChangeProperty and SelectionNotify steps.
8233 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8234 (x_convert_selection): New function.
8235 (x_handle_selection_event): Simplify.
8236 (x_get_foreign_selection): Don't ignore incoming requests while
8237 waiting for an answer; this will fail when we implement
8238 SAVE_TARGETS, and seems unnecessary anyway.
8239 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8240 (Vx_sent_selection_functions): Doc fix.
8242 2011-05-26 Leo Liu <sdl.web@gmail.com>
8244 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8246 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8248 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8250 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8251 for fringe update if it has periodic bitmap.
8252 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8253 and fringe_bitmap_periodic_p.
8255 * fringe.c (get_fringe_bitmap_data): New function.
8256 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8257 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8258 row. Mark glyph row for fringe update if periodicity changed.
8260 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8261 for fringe update unless it has periodic bitmap.
8263 2011-05-25 Kenichi Handa <handa@m17n.org>
8265 * xdisp.c (get_next_display_element): Set correct it->face_id for
8266 a static composition.
8268 2011-05-24 Leo Liu <sdl.web@gmail.com>
8271 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8273 * fns.c (crypto_hash_function, Fsha1): New function.
8274 (Fmd5): Use crypto_hash_function.
8275 (syms_of_fns): Add Ssha1.
8277 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8279 * gnutls.c: Remove unused macros.
8280 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8281 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8282 Remove macros that are defined and never used.
8283 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8285 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8287 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8288 (Fx_get_selection_internal): Minor cleanup.
8289 (Fx_own_selection_internal): Rename arguments for consistency with
8292 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8294 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8296 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8298 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8300 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8302 * dispnew.c (scrolling_window): Don't exclude the case that the
8303 last enabled row in the desired matrix touches the bottom boundary.
8305 2011-05-21 Glenn Morris <rgm@gnu.org>
8307 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8308 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8309 and add some more files.
8311 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8313 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8314 report_file_error introduced by the change from 2011-05-07.
8316 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8318 * systime.h (Time): Define only if emacs is defined.
8319 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8320 where the include path doesn't have X11/X.h by default. See
8321 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8323 2011-05-20 Kenichi Handa <handa@m17n.org>
8325 * composite.c (find_automatic_composition): Fix previous change.
8327 2011-05-20 Glenn Morris <rgm@gnu.org>
8329 * lisp.mk: New file, split from Makefile.in.
8330 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8331 (shortlisp): Remove.
8332 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8334 2011-05-19 Glenn Morris <rgm@gnu.org>
8336 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8337 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8338 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8339 (lisp): Set the order to that of loadup.el.
8340 (shortlisp): Make it a copy of $lisp.
8341 (SOME_MACHINE_LISP): Remove.
8342 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8343 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8345 2011-05-18 Kenichi Handa <handa@m17n.org>
8347 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8348 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8349 (find_automatic_composition): Mostly rewrite for efficiency.
8351 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8353 * makefile.w32-in: Update dependencies.
8355 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8357 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8358 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8360 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8362 Fix some integer overflow issues, such as string length overflow.
8364 * insdel.c (count_size_as_multibyte): Check for string overflow.
8366 * character.c (lisp_string_width): Check for string overflow.
8367 Use EMACS_INT, not int, for string indexes and lengths; in
8368 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8369 the resulting string length overflows an EMACS_INT; instead,
8370 report a string overflow if no precision given. When checking for
8371 precision exhaustion, use a check that cannot possibly have
8372 integer overflow. (Bug#8675)
8373 * character.h (lisp_string_width): Adjust to new signature.
8375 * alloc.c (string_overflow): New function.
8376 (Fmake_string): Use it. This doesn't change behavior, but saves
8377 a few bytes and will simplify future changes.
8378 * character.c (string_escape_byte8): Likewise.
8379 * lisp.h (string_overflow): New decl.
8381 Fixups, following up to the user-interface timestamp change.
8382 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8383 for UI timestamps, instead of unsigned long.
8384 * msdos.c (mouse_get_pos): Likewise.
8385 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8386 * w32gui.h (Time): Define by including "systime.h" rather than by
8387 declaring it ourselves. (Bug#8664)
8389 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8390 * image.c (clear_image_cache): Likewise.
8392 * term.c (term_mouse_position): Don't assume time_t wraparound.
8394 Be more systematic about user-interface timestamps.
8395 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8396 and sometimes 'EMACS_UINT', to represent these timestamps.
8397 This change causes it to use 'Time' uniformly, as that's what X uses.
8398 This makes the code easier to follow, and makes it easier to catch
8399 integer overflow bugs such as Bug#8664.
8400 * frame.c (Fmouse_position, Fmouse_pixel_position):
8401 Use Time, not unsigned long, for user-interface timestamps.
8402 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8403 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8404 * keyboard.h (last_event_timestamp): Likewise.
8405 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8406 * menu.h (xmenu_show): Likewise.
8407 * term.c (term_mouse_position): Likewise.
8408 * termhooks.h (struct input_event.timestamp): Likewise.
8409 (struct terminal.mouse_position_hook): Likewise.
8410 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8411 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8412 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8413 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8415 * menu.h, termhooks.h: Include "systime.h", for Time.
8417 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8418 Don't assume that the difference between two unsigned long values
8419 can fit into an integer. At this point, we know button_down_time
8420 <= event->timestamp, so the difference must be nonnegative, so
8421 there's no need to cast the result if double-click-time is
8422 nonnegative, as it should be; check that it's nonnegative, just in
8423 case. This bug is triggered when events are more than 2**31 ms
8424 apart (about 25 days). (Bug#8664)
8426 * xselect.c (last_event_timestamp): Remove duplicate decl.
8427 (x_own_selection): Remove needless cast to unsigned long.
8429 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8430 that always fit in int. Use a sentinel instead of a counter, to
8431 avoid a temp and to allay GCC's concerns about possible int overflow.
8432 * frame.h (struct frame): Use int for menu_bar_items_used
8433 instead of EMACS_INT, since it always fits in int.
8435 * menu.c (grow_menu_items): Check for int overflow.
8437 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8439 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8440 Before, the code was not consistent. These values cannot exceed
8441 2**31 - 1 so there's no need to make them unsigned.
8442 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8443 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8444 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8446 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8448 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8449 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8450 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8451 presumably because the widths might not match.
8453 * window.c (size_window): Avoid needless test at loop start.
8455 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8457 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8459 2011-05-12 Drew Adams <drew.adams@oracle.com>
8461 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8463 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8465 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8466 `width' to `bar_area_x' and `bar_area_width', respectively.
8467 (x_scroll_run): Take account of fringe background extension.
8469 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8470 Rename local vars `left' and `width' to `bar_area_x' and
8471 `bar_area_width', respectively.
8472 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8473 background extension.
8475 2011-05-10 Jim Meyering <meyering@redhat.com>
8477 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8479 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8481 * image.c (Finit_image_library): Return t for built-in image types,
8482 like pbm and xbm. (Bug#8640)
8484 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8486 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8488 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8490 * w32console.c (Fset_screen_color): Doc fix.
8491 (Fget_screen_color): New function.
8492 (syms_of_ntterm): Defsubr it.
8494 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8495 unlink the temporary file if Fcall_process didn't create it in the
8497 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8498 child process will be redirected to a file specified with `:file'.
8499 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8500 cue to call_process_cleanup not to close that handle.
8502 2011-05-07 Ben Key <bkey76@gmail.com>
8504 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8505 one of two shell specific rules, either bootstrap-temacs-CMD or
8506 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8507 to the previous implementation of the bootstrap-temacs rule.
8508 The bootstrap-temacs-CMD rule is similar to the previous
8509 implementation of the bootstrap-temacs rule except that it
8510 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8513 These changes, along with some changes to nt/configure.bat,
8514 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8515 earlier fix to add support for --cflags and --ldflags options
8516 that include quotes so that it works whether make uses cmd or
8519 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8521 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8522 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8524 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8525 a string. Handle both cases.
8526 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8527 (Fdbus_register_method): Use Qinvalid_function.
8529 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8531 * makefile.w32-in: Update dependencies.
8532 (LISP_H): Add inttypes.h and stdin.h.
8533 (PROCESS_H): Add unistd.h.
8535 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8537 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8538 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8540 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8542 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8544 * term.c (vfatal): Remove stray call to va_end.
8545 It's not needed and the C Standard doesn't allow it here anyway.
8547 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8548 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8550 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8553 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8555 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8557 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8559 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8561 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8563 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8564 * charset.c (Fdefine_charset_internal): Don't initialize
8565 charset.code_space[15]. The value was garbage, on hosts with
8566 32-bit int (Bug#8600).
8568 * lread.c (read_integer): Be more consistent with string-to-number.
8569 Use string_to_number to do the actual conversion; this avoids
8570 rounding errors and fixes some other screwups. Without this fix,
8571 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8572 (digit_to_number): Move earlier, for benefit of read_integer.
8573 Return -1 if the digit is out of range for the base, -2 if it is
8574 not a digit in any supported base. (Bug#8602)
8576 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8578 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8579 to match comment at start of function. This also removes a
8580 GCC warning about overflow in a 32+64-bit port.
8582 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8584 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8585 Reported by Stefan Monnier in
8586 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8587 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8588 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8590 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8591 (EMACS_UINTPTR): Likewise, with uintptr_t.
8593 * lisp.h: Prefer 64-bit EMACS_INT if available.
8594 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8595 on 32-bit hosts that have 64-bit int, so that they can access
8597 However, temporarily disable this change unless the temporary
8598 symbol WIDE_EMACS_INT is defined.
8600 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8602 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8603 This removes an assumption that EMACS_INT and long are the same
8604 width as pointers. The assumption is true for Emacs porting targets
8605 now, but we want to make other targets possible.
8606 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8607 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8608 In the rest of the code, change types of integers that hold casted
8609 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8610 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8611 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8612 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8613 No need to cast type when ORing.
8614 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8615 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8616 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8617 assume EMACS_INT is the same width as char *.
8618 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8619 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8620 Remove no-longer-needed casts.
8621 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8622 (xg_tool_bar_help_callback, xg_make_tool_item):
8623 Use EMACS_INTPTR to hold an integer
8624 that will be cast to void *; this can avoid a GCC warning
8625 if EMACS_INT is not the same width as void *.
8626 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8627 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8628 (current_message_1, set_message_1):
8629 Use a local to convert to proper width without a cast.
8630 * xmenu.c (dialog_selection_callback): Likewise.
8632 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8633 Also, don't assume VALBITS / RAND_BITS is less than 5,
8634 and don't rely on undefined behavior when shifting a 1 left into
8636 * lisp.h (get_random): Change signature to match.
8638 * lread.c (hash_string): Use size_t, not int, for hash computation.
8639 Normally we prefer signed values; but hashing is special, because
8640 it's better to use unsigned division on hash table sizes so that
8641 the remainder is nonnegative. Also, size_t is the natural width
8642 for hashing into memory. The previous code used 'int', which doesn't
8643 retain enough info to hash well into very large tables.
8644 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8646 * dbusbind.c: Don't possibly lose pointer info when converting.
8647 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8648 Use XPNTR rather than XHASH, so that the high-order bits of
8649 the pointer aren't lost when converting through void *.
8651 * eval.c (Fautoload): Don't double-shift a pointer.
8653 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8655 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8657 * gnutls.c (DEF_GNUTLS_FN):
8658 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8660 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8662 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8665 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8667 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8668 New version that can reserve upto 2GB of heap space.
8670 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8672 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8674 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8676 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8677 `gnutls_certificate_set_x509_key_file'.
8679 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8681 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8682 Update dependencies.
8684 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8686 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8687 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8688 Remove unused parameter `fildes'.
8689 * process.c (read_process_output, send_process): Don't pass it.
8691 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8693 Fix previous change: the library cache is defined in w32.c.
8694 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8695 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8697 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8699 Implement dynamic loading of GnuTLS on Windows.
8701 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8702 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8703 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8706 * gnutls.c (Qgnutls_dll): Define.
8707 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8708 (gnutls_*): Declare function pointers.
8709 (init_gnutls_functions): New function to initialize function pointers.
8710 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8711 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8712 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8713 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8714 (emacs_gnutls_write, emacs_gnutls_read)
8715 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8716 (Fgnutls_available_p): New function.
8717 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8718 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8719 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8721 * image.c: Include w32.h.
8722 (Vimage_type_cache): Delete.
8723 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8724 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8725 (w32_delayed_load): Move to w32.c.
8727 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8729 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8730 (w32_delayed_load): Move from image.c. When loading a library, record
8731 its filename in the :loaded-from property of the library id.
8732 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8733 Initialize and staticpro them.
8734 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8736 * process.c: Include lisp.h before w32.h, not after.
8737 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8738 instead of gnutls_record_check_pending.
8740 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8742 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8744 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8745 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8748 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8750 * xterm.c (x_set_frame_alpha): Do not set property on anything
8751 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8753 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8755 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8757 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8759 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8760 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8761 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8762 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8763 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8764 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8765 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8766 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8767 (Qgnutls_bootprop_callbacks_verify): Make static.
8769 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8771 * callproc.c: Indentation fixup.
8773 * sysdep.c (wait_for_termination_1): Make static.
8774 (wait_for_termination, interruptible_wait_for_termination):
8775 Move after wait_for_termination_1.
8777 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8779 * sysdep.c (interruptible_wait_for_termination): New function
8780 which is like wait_for_termination, but allows keyboard
8783 * callproc.c (Fcall_process): Add (:file "file") as an option for
8785 (Fcall_process_region): Ditto.
8787 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8789 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8790 rather than `XVECTOR (FOO)->size'.
8792 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8793 inttypes.h, as a gnulib replacement is used if it not available in
8796 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8798 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8799 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8800 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8802 * coding.c (coding_alloc_by_realloc): Error out if destination
8803 will grow beyond MOST_POSITIVE_FIXNUM.
8804 (decode_coding_emacs_mule): Abort if there isn't enough place in
8805 charbuf for the composition carryover bytes. Reserve an extra
8806 space for up to 2 characters produced in a loop.
8807 (decode_coding_iso_2022): Abort if there isn't enough place in
8808 charbuf for the composition carryover bytes.
8810 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8812 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8813 aborting when %lld or %lll format is passed.
8814 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8815 %llo or %llx format is passed. (Bug#8545)
8817 * window.c (window_scroll_line_based): Use a marker instead of
8818 simple variables to record original value of point. (Bug#7952)
8820 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8821 produced by %s or %c overflows available buffer space. (Bug#8545)
8823 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8825 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8826 (SIZE_MAX): Move defn after all includes, as they might #define it.
8828 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8830 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8832 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8834 * keyboard.c (Qdelayed_warnings_hook): Define.
8835 (command_loop_1): Run `delayed-warnings-hook'
8836 if Vdelayed_warnings_list is non-nil.
8837 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8838 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8840 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8842 * doprnt.c (doprnt): Don't return value smaller than the buffer
8843 size if the message was truncated. (Bug#8545).
8845 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8847 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8848 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8850 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8852 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8854 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8856 * makefile.w32-in: Update dependencies.
8858 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8860 Improve `doprnt' and its usage. (Bug#8545)
8861 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8862 `format_end'. Remove support for %l as a conversion specifier.
8863 Don't use xrealloc. Improve diagnostics when the %l size modifier
8864 is used. Update the commentary.
8866 * eval.c (verror): Simplify calculation of size_t.
8868 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8871 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8873 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8876 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8878 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8879 This makes this file independent of the recent pseudovector change.
8881 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8883 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8885 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8886 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8887 Remove unused local.
8888 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8890 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8891 GCC 4.6.0 optimizes based on type-based alias analysis.
8892 For example, if b is of type struct buffer * and v of type struct
8893 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8894 != &v->size, and therefore "v->size = 1; b->size = 2; return
8895 v->size;" must therefore return 1. This assumption is incorrect
8896 for Emacs, since it type-puns struct Lisp_Vector * with many other
8897 types. To fix this problem, this patch adds a new type struct
8898 vectorlike_header that documents the constraints on layout of vectors
8899 and pseudovectors, and helps optimizing compilers not get fooled
8900 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8901 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8902 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8904 (XSETPVECTYPE): Rewrite in terms of new macro.
8905 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8906 This is a bit clearer, and further avoids the possibility of
8907 undesirable aliasing.
8908 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8909 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8910 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8911 since Lisp_Subr is a special case (no "next" field).
8912 (ASIZE): Now uses header.size rather than size.
8913 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8914 to avoid the hassle of writing XVECTOR (foo)->header.size.
8915 (struct vectorlike_header): New type.
8916 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8917 object, to help avoid aliasing.
8918 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8919 (SUBRP): Likewise, since Lisp_Subr is a special case.
8920 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8921 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8922 (struct Lisp_Hash_Table): Combine first two members into a single
8923 struct vectorlike_header member. All uses of "size" and "next" members
8924 changed to be "header.size" and "header.next".
8925 * buffer.h (struct buffer): Likewise.
8926 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8927 * frame.h (struct frame): Likewise.
8928 * process.h (struct Lisp_Process): Likewise.
8929 * termhooks.h (struct terminal): Likewise.
8930 * window.c (struct save_window_data, struct saved_window): Likewise.
8931 * window.h (struct window): Likewise.
8932 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8933 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8934 * buffer.c (init_buffer_once): Likewise.
8935 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8937 * process.c (Fformat_network_address): Use local var for size,
8940 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8942 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8943 * data.c (atof): Remove decl; no longer used or needed.
8944 (digit_to_number): Move to lread.c.
8945 (Fstring_to_number): Use new string_to_number function, to be
8946 consistent with how the Lisp reader treats infinities and NaNs.
8947 Do not assume that floating-point numbers represent EMACS_INT
8948 without losing information; this is not true on most 64-bit hosts.
8949 Avoid double-rounding errors, by insisting on integers when
8950 parsing non-base-10 numbers, as the documentation specifies.
8951 * lisp.h (string_to_number): New decl, replacing ...
8952 (isfloat_string): Remove.
8953 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8954 (read1): Do not accept +. and -. as integers; this
8955 appears to have been a coding error. Similarly, do not accept
8956 strings like +-1e0 as floating point numbers. Do not report
8957 overflow for integer overflows unless the base is not 10 which
8958 means we have no simple and reliable way to continue.
8959 Break out the floating-point parsing into a new
8960 function string_to_number, so that Fstring_to_number parses
8961 floating point numbers consistently with the Lisp reader.
8962 (digit_to_number): Move here from data.c. Make it static inline.
8963 (E_CHAR, EXP_INT): Remove, replacing with ...
8964 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8965 (string_to_number): New function, replacing isfloat_string.
8966 This function checks for valid syntax and produces the resulting
8967 Lisp float number too. Rework it so that string-to-number
8968 no longer mishandles examples like "1.0e+". Use strtoumax,
8969 so that overflow for non-base-10 numbers is reported only when
8970 there's no portable and simple way to convert to floating point.
8972 * textprop.c (set_text_properties_1): Rewrite for clarity,
8973 and to avoid GCC warning about integer overflow.
8975 * intervals.h (struct interval): Use EMACS_INT for members
8976 where EMACS_UINT might cause problems. See
8977 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8978 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8979 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8981 (offset_intervals): Tell GCC not to worry about length overflow
8982 when negating a negative length.
8984 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8985 (overrun_check_free): Likewise.
8987 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8988 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8991 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8992 (gnutls_make_error): Rename local to avoid shadowing.
8993 (gnutls_emacs_global_deinit): ifdef out; not used.
8994 (Fgnutls_boot): Use const for pointer to readonly storage.
8995 Comment out unused local. Fix pointer signedness problems.
8997 * lread.c (openp): Don't stuff size_t into an 'int'.
8998 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8999 about possible signed overflow.
9001 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9002 (GDK_KEY_g): Don't define if already defined.
9003 (xg_prepare_tooltip): Avoid pointer signedness problem.
9004 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9006 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9007 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9009 * xfns.c (Fx_window_property): Simplify a bit,
9010 to make a bit faster and to avoid GCC 4.6.0 warning.
9011 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9013 * fns.c (internal_equal): Don't assume size_t fits in int.
9015 * alloc.c (compact_small_strings): Tighten assertion a little.
9017 Replace pEd with more-general pI, and fix some printf arg casts.
9018 * lisp.h (pI): New macro, generalizing old pEd macro to other
9019 conversion specifiers. For example, use "...%"pI"d..." rather
9020 than "...%"pEd"...".
9021 (pEd): Remove. All uses replaced with similar uses of pI.
9022 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9023 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9024 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9025 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9026 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9027 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9028 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9030 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9031 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9032 * print.c (safe_debug_print, print_object): Likewise.
9033 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9035 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9036 avoiding the 0 flag, which is not portable.
9037 * process.c (Fmake_network_process): Use pI to avoid cast.
9038 * region-cache.c (pp_cache): Likewise.
9039 * xdisp.c (decode_mode_spec): Likewise.
9040 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9041 behavior on 64-bit hosts with printf arg.
9042 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9043 (x_stop_queuing_selection_requests): Likewise.
9044 (x_get_window_property): Don't truncate byte count to an 'int'
9047 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9048 here, since it parses constructs like leading '-' and spaces,
9049 which are not wanted; and it overflows with large numbers.
9050 Instead, simply match F[0-9]+, which is what is wanted anyway.
9052 * alloc.c: Remove unportable assumptions about struct layout.
9053 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9054 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9055 (allocate_vectorlike, make_pure_vector): Use the new macros,
9056 plus offsetof, to remove unportable assumptions about struct layout.
9057 These assumptions hold on all porting targets that I know of, but
9058 they are not guaranteed, they're easy to remove, and removing them
9059 makes further changes easier.
9061 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9062 This doesn't fix a bug but makes the code clearer.
9063 (string_overrun_cookie): Now const. Use initializers that
9064 don't formally overflow signed char, to avoid warnings.
9065 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9066 can cause Emacs to crash when string overrun checking is enabled.
9067 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9068 multiple of sizeof (EMACS_INT); it need not be, if
9069 alignof(EMACS_INT) < sizeof (EMACS_INT).
9070 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9072 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9074 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9076 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9078 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9079 supposed to be handshaking. (Bug#8556)
9080 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9082 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9084 * lisp.h (Qdebug): List symbol.
9085 * eval.c (Qdebug): Restore global linkage.
9086 * keyboard.c (debug-on-event): New variable.
9087 (handle_user_signal): Break into debugger when debug-on-event
9088 matches the current signal symbol.
9090 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9092 * alloc.c (check_sblock, check_string_bytes)
9093 (check_string_free_list): Convert to standard C.
9095 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9097 * w32.c (emacs_gnutls_push): Fix typo.
9099 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9101 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9102 "cast to pointer from integer of different size".
9104 Improve doprnt and its use in verror. (Bug#8545)
9105 * doprnt.c (doprnt): Document the set of format control sequences
9106 supported by the function. Use SAFE_ALLOCA instead of always
9109 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9110 is one byte too soon. Don't use xrealloc; instead xfree and
9113 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9115 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9118 * gnutls.c: Renamed global_initialized to
9119 gnutls_global_initialized. Added internals for the
9120 :verify-hostname-error, :verify-error, and :verify-flags
9121 parameters of `gnutls-boot' and documented those parameters in the
9122 docstring. Start callback support.
9123 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9124 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9125 on error. Return error code.
9126 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9127 (emacs_gnutls_read): Likewise.
9128 (Fgnutls_boot): Return handshake error code.
9129 (emacs_gnutls_handle_error): New function.
9130 (wsaerror_to_errno): Likewise.
9132 * w32.h (emacs_gnutls_pull): Add prototype.
9133 (emacs_gnutls_push): Likewise.
9135 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9136 (emacs_gnutls_push): Likewise.
9138 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9140 * process.c (wait_reading_process_output): Check if GnuTLS
9141 buffered some data internally if no FDs are set for TLS
9144 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9145 (LIBS): Link to USER_LIBS.
9146 ($(BLD)/gnutls.$(0)): New target.
9148 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9150 * xdisp.c (handle_single_display_spec): Rename the
9151 display_replaced_before_p argument into display_replaced_p, to
9152 make it consistent with the commentary. Fix typos in the
9155 * textprop.c (syms_of_textprop): Remove dead code.
9156 (copy_text_properties): Delete obsolete commentary about an
9157 interface that was deleted long ago. Fix typos in the description
9160 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9161 to changes in oldXMenu/XMenu.h from 2011-04-16.
9162 <menu_help_message, prev_menu_help_message>: Constify.
9163 (IT_menu_make_room): menu->help_text is now `const char **';
9166 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9167 to changes in oldXMenu/XMenu.h from 2011-04-16.
9168 (struct XMenu): Declare `help_text' `const char **'.
9170 * xfaces.c <Qunspecified>: Make extern again.
9172 * syntax.c: Include sys/types.h before including regex.h, as
9175 * doc.c (get_doc_string): Improve the format passed to `error'.
9177 * doprnt.c (doprnt): Improve commentary.
9179 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9181 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9184 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9185 changes in globals.h immediately force recompilation.
9186 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9187 $(CURDIR)/s/ms-w32.h.
9188 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9190 * character.c (Fchar_direction): Function deleted.
9191 (syms_of_character): Don't defsubr it.
9192 <char-direction-table>: Deleted.
9194 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9196 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9197 * doprnt.c: Include limits.h.
9198 (SIZE_MAX): New macro.
9199 (doprnt): Return a size_t value. 2nd arg is now size_t.
9200 Many local variables are now size_t instead of int or unsigned.
9201 Improve overflow protection. Support `l' modifier for integer
9202 conversions. Support %l conversion. Don't assume an EMACS_INT
9203 argument for integer conversions and for %c.
9205 * lisp.h (doprnt): Restore prototype.
9207 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9210 * Makefile.in (base_obj): Add back doprnt.o.
9212 * deps.mk (doprnt.o): Add back prerequisites.
9213 (callint.o): Depend on character.h.
9215 * eval.c (internal_lisp_condition_case): Include the handler
9216 representation in the error message.
9217 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9218 when breaking from the loop.
9220 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9222 * callint.c (Fcall_interactively): When displaying error message
9223 about invalid control letter, pass the character's codepoint, not
9224 a pointer to its multibyte form. Improve display of the character
9225 in octal and display also its hex code.
9227 * character.c (char_string): Use %x to display the (unsigned)
9228 codepoint of an invalid character, to avoid displaying a bogus
9231 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9232 `error', not SYMBOL_NAME itself.
9234 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9235 character arguments to `error'.
9237 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9238 to `error' in error message about FINAL_CHAR argument. Make sure
9239 FINAL_CHAR is a character, and use %c when it is passed as
9240 argument to `error'.
9242 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9244 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9246 * w32.c: Include <time.h>.
9247 (sys_localtime): New function.
9249 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9251 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9253 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9255 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9257 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9260 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9262 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9263 gl_state.e_property when gl_state.object is Qt.
9265 * insdel.c (make_gap_larger): Remove limitation of buffer size
9268 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9270 * xdisp.c (lookup_glyphless_char_display)
9271 (produce_glyphless_glyph): Handle cons cell entry in
9272 glyphless-char-display.
9273 (Vglyphless_char_display): Document it.
9275 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9276 glyphless-char-display.
9278 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9280 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9282 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9284 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9285 definition for no-X builds.
9287 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9289 Static checks with GCC 4.6.0 and non-default toolkits.
9291 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9293 * process.c (keyboard_bit_set): Define only if SIGIO.
9294 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9295 (send_process): Repair possible setjmp clobbering.
9297 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9299 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9301 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9303 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9304 Define only if needed.
9306 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9307 by pacifying GCC about it. Maybe it's time to retire it?
9308 * xfaces.c (USG, __TIMEVAL__): Likewise.
9310 * dispextern.h (struct redisplay_interface): Rename param
9312 * termhooks.h (struct terminal): Likewise.
9313 * xterm.c (xembed_send_message): Likewise.
9315 * insdel.c (make_gap_smaller): Define only if
9316 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9318 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9321 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9322 so that we aren't warned about unused symbols.
9324 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9326 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9328 * xfns.c (x_real_positions): Mark locals as initialized.
9330 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9332 * xterm.c: Fix problems found by static analysis with other toolkits.
9333 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9334 (x_dispatch_event): Declare static if USE_GTK, and
9335 define if USE_GTK || USE_X_TOOLKIT.
9336 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9337 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9338 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9339 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9341 * xmenu.c (menu_help_callback): Pointer type fixes.
9342 Use const pointers when pointing at readonly data. Avoid pointer
9344 (FALSE): Remove unused macro.
9345 (update_frame_menubar): Remove unused decl.
9347 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9349 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9350 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9351 (single_menu_item): Rename local to avoid shadowing.
9353 * keyboard.c (make_lispy_event): Remove unused local var.
9355 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9356 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9358 * bitmaps: Change bitmaps from unsigned char back to the X11
9359 compatible char. Avoid the old compiler warnings about
9360 out-of-range initializers by using, for example, '\xab' rather
9363 * xgselect.c (xgselect_initialize): Check vs interface
9364 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9366 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9368 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9369 to read-only memory.
9371 * fns.c (vector): Remove; this old hack is no longer needed.
9373 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9375 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9377 * xrdb.c (x_load_resources): Omit unused local.
9379 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9380 (x_window): Rename locals to avoid shadowing.
9381 (USG): Use the kludged USG macro, to pacify gcc.
9383 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9384 (x_term_init): Remove local to avoid shadowing.
9386 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9388 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9389 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9391 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9393 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9395 Fix regex.c, syntax.c and friends for buffers > 2GB.
9396 * syntax.h (struct gl_state_s): Declare character position members
9399 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9401 * textprop.c (verify_interval_modification, interval_of):
9402 Declare arguments EMACS_INT.
9404 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9407 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9409 * indent.c (Fvertical_motion): Local variable it_start is now
9412 * regex.c (re_match, re_match_2, re_match_2_internal)
9413 (bcmp_translate, regcomp, regexec, print_double_string)
9414 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9415 (re_compile_pattern, re_exec): Declare arguments and local
9416 variables `size_t' and `ssize_t' and return values `regoff_t', as
9418 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9419 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9420 <compile_stack_type>: `size' and `avail' are now `size_t'.
9422 * regex.h <regoff_t>: Use ssize_t, not int.
9423 (re_search, re_search_2, re_match, re_match_2): Arguments that
9424 specify buffer/string position and length are now ssize_t and
9425 size_t. Return type is regoff_t.
9427 2011-04-16 Ben Key <bkey76@gmail.com>
9429 * nsfont.m: Fixed bugs in ns_get_family and
9430 ns_descriptor_to_entity that were caused by using free to
9431 deallocate memory blocks that were allocated by xmalloc (via
9432 xstrdup). This caused Emacs to crash when compiled with
9433 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9434 --enable-checking=xmallocoverrun). xfree is now used to
9435 deallocate these memory blocks.
9437 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9439 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9441 emacs_write: Accept and return EMACS_INT for sizes.
9442 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9444 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9445 Accept and return EMACS_INT.
9446 (emacs_gnutls_write): Return the number of bytes written on
9448 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9449 (emacs_read, emacs_write): Remove check for negative size, as the
9450 Emacs source code has been audited now.
9451 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9452 (emacs_read, emacs_write): Use it.
9453 * process.c (send_process): Adjust to the new signatures of
9454 emacs_write and emacs_gnutls_write. Do not attempt to store
9455 a byte offset into an 'int'; it might overflow.
9456 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9458 * sound.c: Don't assume sizes fit in 'int'.
9459 (struct sound_device.period_size, alsa_period_size):
9460 Return EMACS_INT, not int.
9461 (struct sound_device.write, vox_write, alsa_write):
9462 Accept EMACS_INT, not int.
9463 (wav_play, au_play): Use EMACS_INT to store sizes and to
9464 record read return values.
9466 2011-04-15 Ben Key <bkey76@gmail.com>
9468 * keyboard.c (Qundefined): Don't declare static since it is used
9470 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9471 static since they are used in nsfont.m.
9473 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9475 * process.c (Qprocessp): Don't declare static.
9476 * lisp.h (Qprocessp): Declare again.
9478 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9480 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9482 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9484 Improve C-level modularity by making more things 'static'.
9486 Don't publish debugger-only interfaces to other modules.
9487 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9488 (verify_bytepos, count_markers): Move decls to the only modules
9490 * region-cache.h (pp_cache): Likewise.
9491 * window.h (check_all_windows): Likewise.
9492 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9494 * sysdep.c (croak): Now static, if
9495 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9496 * syssignal.h (croak): Declare only if not static.
9498 * alloc.c (refill_memory_reserve): Now static if
9499 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9500 * lisp.h (refill_memory_reserve): Declare only if not static.
9502 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9503 Define only if USE_LUCID.
9505 * xrdb.c (x_customization_string, x_rm_string): Now static.
9507 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9508 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9510 * xdisp.c (draw_row_with_mouse_face): Now static.
9511 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9513 * window.h (check_all_windows): Mark externally visible.
9515 * window.c (window_deletion_count): Now static.
9517 * undo.c: Make symbols static if they're not exported.
9518 (last_undo_buffer, last_boundary_position, pending_boundary):
9521 * textprop.c (interval_insert_behind_hooks): Now static.
9522 (interval_insert_in_front_hooks): Likewise.
9524 * term.c: Make symbols static if they're not exported.
9525 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9526 (max_frame_lines, tty_set_terminal_modes):
9527 (tty_reset_terminal_modes, tty_turn_off_highlight):
9528 (get_tty_terminal): Now static.
9529 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9530 * termhooks.h (term_mouse_moveto): Do not declare if
9532 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9533 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9535 * sysdep.c: Make symbols static if they're not exported.
9536 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9538 (sigprocmask_set, full_mask): Remove; unused.
9539 (wait_debugging): Mark as visible.
9540 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9541 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9543 * syntax.c (syntax_temp): Define only if !__GNUC__.
9545 * sound.c (current_sound_device, current_sound): Now static.
9547 * search.c (searchbufs, searchbuf_head): Now static.
9549 * scroll.c (scroll_cost): Remove; unused.
9550 * dispextern.h (scroll_cost): Remove decl.
9552 * region-cache.h (pp_cache): Mark as externally visible.
9554 * process.c: Make symbols static if they're not exported.
9555 (process_tick, update_tick, create_process, chan_process):
9556 (Vprocess_alist, proc_buffered_char, datagram_access):
9557 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9558 (deactivate_process): Mark defn as static, as well as decl.
9559 * lisp.h (create_process): Remove decl.
9560 * process.h (chan_process, Vprocess_alist): Remove decls.
9562 * print.c: Make symbols static if they're not exported.
9563 (print_depth, new_backquote_output, being_printed, print_buffer):
9564 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9565 (print_interval, print_number_index, initial_stderr_stream):
9567 * lisp.h (Fprinc): Remove decl.
9568 (debug_output_compilation_hack): Mark as externally visible.
9570 * sysdep.c (croak): Move decl from here to syssignal.h.
9571 * syssignal.h (croak): Put it here, so the API can be checked when
9572 'croak' is called from dissociate_if_controlling_tty.
9574 * minibuf.c: Make symbols static if they're not exported.
9575 (minibuf_save_list, choose_minibuf_frame): Now static.
9576 * lisp.h (choose_minibuf_frame): Remove decl.
9578 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9580 * lread.c: Make symbols static if they're not exported.
9581 (read_objects, initial_obarray, oblookup_last_bucket_number):
9583 (make_symbol): Remove; unused.
9584 * lisp.h (initial_obarray, make_symbol): Remove decls.
9586 * keyboard.c: Make symbols static if they're not exported.
9587 (single_kboard, recent_keys_index, total_keys, recent_keys):
9588 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9589 (this_single_command_key_start, echoing, last_auto_save):
9590 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9591 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9592 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9593 (Vlispy_mouse_stem, double_click_count):
9595 (force_auto_save_soon): Define only if SIGDANGER.
9596 (ignore_mouse_drag_p): Now static if
9597 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9598 (print_help): Remove; unused.
9599 (stop_character, last_timer_event): Mark as externally visible.
9600 * keyboard.h (ignore_mouse_drag_p): Declare only if
9601 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9602 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9603 * lisp.h (echoing): Remove decl.
9604 (force_auto_save_soon): Declare only if SIGDANGER.
9605 * xdisp.c (redisplay_window): Simplify code, to make it more
9606 obvious that ignore_mouse_drag_p is not accessed if !defined
9607 USE_GTK && !defined HAVE_NS.
9609 * intervals.c: Make symbols static if they're not exported.
9610 (merge_properties_sticky, merge_interval_right, delete_interval):
9612 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9614 * insdel.c: Make symbols static if they're not exported.
9615 However, leave prepare_to_modify_buffer alone. It's never
9616 called from outside this function, but that appears to be a bug.
9617 (combine_after_change_list, combine_after_change_buffer):
9618 (adjust_after_replace, signal_before_change): Now static.
9619 (adjust_after_replace_noundo): Remove; unused.
9620 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9621 (signal_before_change): Remove decls.
9623 * indent.c (val_compute_motion, val_vmotion): Now static.
9625 * image.c: Make symbols static if they're not exported.
9626 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9628 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9629 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9631 * fringe.c (standard_bitmaps): Now static.
9632 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9634 * frame.c: Make symbols static if they're not exported.
9635 (x_report_frame_params, make_terminal_frame): Now static.
9636 (get_frame_param): Now static, unless HAVE_NS.
9637 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9638 (x_get_resource_string): Remove; not used.
9639 * frame.h (make_terminal_frame, x_report_frame_params):
9640 (x_get_resource_string); Remove decls.
9641 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9642 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9644 * font.c, fontset.c: Make symbols static if they're not exported.
9645 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9646 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9647 * font.c (font_close_object): Now static.
9648 * font.h (font_close_object): Remove.
9649 * fontset.c (FONTSET_OBJLIST): Remove.
9650 (free_realized_fontset) #if-0 the body, which does nothing.
9651 (face_suitable_for_char_p): #if-0, as it's never called.
9652 * fontset.h (face_suitable_for_char_p): Remove decl.
9653 * xfaces.c (face_at_string_position):
9654 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9655 since 0 is always ASCII.
9657 * fns.c (weak_hash_tables): Now static.
9659 * fileio.c: Make symbols static if they're not exported.
9660 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9661 (Vwrite_region_annotation_buffers): Now static.
9663 * eval.c: Make symbols static if they're not exported.
9664 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9665 * lisp.h (backtrace_list): Remove decl.
9667 * emacs.c: Make symbols static if they're not exported.
9668 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9669 (fatal_error_code, fatal_error_signal_hook, standard_args):
9671 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9672 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9673 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9674 * lisp.h (fatal_error_signal_hook): Remove decl.
9675 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9677 * editfns.c: Move a (normally-unused) function to its only use.
9678 * editfns.c, lisp.h (get_operating_system_release): Remove.
9679 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9680 worth the hassle of breaking this out.
9682 * xterm.c: Make symbols static if they're not exported.
9683 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9684 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9685 (x_destroy_window, x_delete_display):
9687 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9688 (x_mouse_leave): Remove; unused.
9689 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9690 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9691 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9693 (x_mouse_leave): Declare only if WINDOWSNT.
9694 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9695 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9698 * ftxfont.c: Make symbols static if they're not exported.
9699 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9701 * font.h (ftxfont_driver): Likewise.
9703 * xfns.c: Make symbols static if they're not exported.
9704 (x_last_font_name, x_display_info_for_name):
9705 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9706 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9707 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9708 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9709 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9710 (last_show_tip_args): Now static.
9711 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9712 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9713 (x_screen_planes): Remove; unused.
9714 * dispextern.h (x_screen_planes): Remove decl.
9716 * dispnew.c: Make symbols static if they're not exported.
9717 * dispextern.h (redraw_garbaged_frames, scrolling):
9718 (increment_row_positions): Remove.
9719 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9720 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9722 (redraw_garbaged_frames): Remove; unused.
9724 * xfaces.c: Make symbols static if they're not exported.
9725 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9727 * xterm.h (defined_color): Remove decls.
9728 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9729 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9730 (menu_face_changed_default, defined_color, free_realized_face):
9731 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9732 (ascii_face_of_lisp_face): Remove; unused.
9734 * xdisp.c: Make symbols static if they're not exported.
9735 * dispextern.h (scratch_glyph_row, window_box_edges):
9736 (glyph_to_pixel_coords, set_cursor_from_row):
9737 (get_next_display_element, set_iterator_to_next):
9738 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9739 (show_mouse_face): Remove decls
9740 * frame.h (message_buf_print): Likewise.
9741 * lisp.h (pop_message, set_message, check_point_in_composition):
9743 * xterm.h (set_vertical_scroll_bar): Likewise.
9744 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9745 (message_buf_print, scratch_glyph_row, displayed_buffer):
9746 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9747 (get_next_display_element, show_mouse_face, window_box_edges):
9748 (frame_to_window_pixel_xy, check_point_in_composition):
9749 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9750 (glyph_to_pixel_coords): Remove; unused.
9752 * dired.c (file_name_completion): Now static.
9754 * dbusbind.c (xd_in_read_queued_messages): Now static.
9756 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9757 * data.c (circular_list_error): Remove.
9759 * commands.h (last_point_position, last_point_position_buffer):
9760 (last_point_position_window): Remove decls.
9761 * keyboard.c: Make these variables static.
9763 * coding.h (coding, code_convert_region, encode_coding_gap):
9765 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9766 (iso_code_class, detect_coding, code_convert_region): Now static.
9767 (encode_coding_gap): Remove; unused.
9769 * chartab.c (chartab_chars, chartab_bits): Now static.
9771 * charset.h (charset_iso_8859_1): Remove decl.
9772 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9775 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9776 * ccl.c (Vccl_program_table): Now static.
9777 (check_ccl_update): Remove; unused.
9779 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9780 * category.h: ... from here.
9781 * category.c (check_category_table, set_category_set): Now static.
9783 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9784 * lisp.h: Remove these decls.
9786 * buffer.c (buffer_count): Remove unused var.
9788 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9789 so that it's not optimized away.
9790 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9791 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9792 exported only to the debugger.
9794 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9795 * atimer.h (run_all_atimers): Remove; not exported.
9797 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9798 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9799 was inaccessible from Lisp.
9800 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9801 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9803 alloc.c: Import and export fewer symbols, and remove unused items.
9804 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9806 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9807 it's not optimized away by whole-program optimization.
9808 (message_enable_multibyte, free_misc): Remove.
9809 (catchlist, handlerlist, mark_backtrace):
9810 Declare only if BYTE_MARK_STACK.
9811 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9812 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9813 (message_enable_multibyte): Remove decl.
9814 (free_misc, interval_free_list, float_block, float_block_index):
9815 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9816 (cons_free_list, last_marked_index):
9818 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9819 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9820 (mark_backtrace): Define only if BYTE_MARK_STACK.
9821 * xdisp.c (message_enable_multibyte): Now static.
9823 Declare Lisp_Object Q* variables to be 'static' if not exported.
9824 This makes it easier for human readers (and static analyzers)
9825 to see whether these variables are used from other modules.
9826 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9827 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9828 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9829 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9830 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9831 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9832 * xmenu.c, xselect.c:
9833 Declare Q* vars static if they are not used in other modules.
9834 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9835 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9836 Remove decls of unexported vars.
9837 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9839 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9841 Make Emacs functions such as Fatom 'static' by default.
9842 This makes it easier for human readers (and static analyzers)
9843 to see whether these functions can be called from other modules.
9844 DEFUN now defines a static function. To make the function external
9845 so that it can be used in other C modules, use the new macro DEFUE.
9846 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9847 (Finit_image_library):
9848 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9849 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9850 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9851 Remove decls, since these functions are now static.
9852 (Funintern, Fget_internal_run_time): New decls, since these functions
9853 were already external.
9855 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9856 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9857 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9858 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9859 * keyboard.c, keymap.c, lread.c:
9860 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9861 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9862 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9863 Mark functions with DEFUE instead of DEFUN,
9864 if they are used in other modules.
9865 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9866 decls for now-static functions.
9867 * buffer.h (Fdelete_overlay): Remove decl.
9868 * callproc.c (Fgetenv_internal): Mark as internal.
9869 * composite.c (Fremove_list_of_text_properties): Remove decl.
9870 (Fcomposition_get_gstring): New forward static decl.
9871 * composite.h (Fcomposite_get_gstring): Remove decl.
9872 * dired.c (Ffile_attributes): New forward static decl.
9873 * doc.c (Fdocumntation_property): New forward static decl.
9874 * eval.c (Ffetch_bytecode): New forward static decl.
9875 (Funintern): Remove extern decl; now in .h file where it belongs.
9876 * fileio.c (Fmake_symbolic_link): New forward static decl.
9877 * image.c (Finit_image_library): New forward static decl.
9878 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9879 * intervals.h (Fprevious_property_change):
9880 (Fremove_list_of_text_properties): Remove decls.
9881 * keyboard.c (Fthis_command_keys): Remove decl.
9882 (Fcommand_execute): New forward static decl.
9883 * keymap.c (Flookup_key): New forward static decl.
9884 (Fcopy_keymap): Now static.
9885 * keymap.h (Flookup_key): Remove decl.
9886 * process.c (Fget_process): New forward static decl.
9887 (Fprocess_datagram_address): Mark as internal.
9888 * syntax.c (Fsyntax_table_p): New forward static decl.
9889 (skip_chars): Remove duplicate decl.
9890 * textprop.c (Fprevious_property_change): New forward static decl.
9891 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9893 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9894 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9896 * editfns.c (Fformat): Remove unreachable code.
9898 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9900 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9903 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9905 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9906 when at ZV. (Bug#8487)
9908 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9910 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9912 * keyboard.c (parse_tool_bar_item): Likewise.
9913 * sound.c (sound_cleanup, alsa_close): Likewise.
9914 * termcap.c (tgetent): Likewise.
9915 * xfns.c (x_default_font_parameter): Likewise.
9916 * xsettings.c (read_and_apply_settings): Likewise.
9918 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9919 (overrun_check_free): Protoize.
9921 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9923 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9924 since callers should never pass a negative size.
9925 Change the signature to match that of plain 'read' and 'write'; see
9926 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9927 * lisp.h: Update prototypes of emacs_write and emacs_read.
9929 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9931 * xdisp.c (redisplay_window): Don't try to determine the character
9932 position of the scroll margin if the window start point w->startp
9933 is outside the buffer's accessible region. (Bug#8468)
9935 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9937 Fix write-region and its subroutines for buffers > 2GB.
9938 * fileio.c (a_write, e_write): Modify declaration of arguments and
9939 local variables to support buffers larger than 2GB.
9940 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9942 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9943 argument, local variables, and return value.
9945 * lisp.h: Update prototypes of emacs_write and emacs_read.
9947 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9949 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9951 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9953 Fix more problems found by GCC 4.6.0's static checks.
9955 * xdisp.c (vmessage): Use a better test for character truncation.
9957 * charset.c (load_charset_map): <, not <=, for optimization,
9958 and to avoid potential problems with integer overflow.
9959 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9960 * casetab.c (set_identity, shuffle): Likewise.
9961 * editfns.c (Fformat): Likewise.
9962 * syntax.c (skip_chars): Likewise.
9964 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9965 This also lets GCC 4.6.0 generate slightly better loop code.
9967 * callint.c (Fcall_interactively): <, not <=, for optimization.
9968 (Fcall_interactively): Count the number of arguments produced,
9969 not the number of arguments given. This is simpler and lets GCC
9970 4.6.0 generate slightly better code.
9972 * ftfont.c: Distingish more carefully between FcChar8 and char.
9973 The previous code passed unsigned char * to a functions like
9974 strlen and xstrcasecmp that expect char *, which does not
9975 conform to the C standard.
9976 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9977 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9978 char * when the C standard requires it.
9980 * keyboard.c (read_char): Remove unused var.
9982 * eval.c: Port to Windows vsnprintf (Bug#8435).
9984 (SIZE_MAX): Define if the headers do not.
9985 (verror): Do not give up if vsnprintf returns a negative count.
9986 Instead, grow the buffer. This ports to Windows vsnprintf, which
9987 does not conform to C99. Problem reported by Eli Zaretskii.
9988 Also, simplify the allocation scheme, by avoiding the need for
9989 calling realloc, and removing the ALLOCATED variable.
9991 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9993 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9994 But keep the doprint source code for now, as we might revamp it
9995 and use it again (Bug#8435).
9996 * lisp.h (doprnt): Remove.
9997 * Makefile.in (base_obj): Remove doprnt.o.
9998 * deps.mk (doprnt.o): Remove.
10000 error: Print 32- and 64-bit integers portably (Bug#8435).
10001 Without this change, on typical 64-bit hosts error ("...%d...", N)
10002 was used to print both 32- and 64-bit integers N, which relied on
10003 undefined behavior.
10004 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10005 * lisp.h (error, verror): Mark as printf-like functions.
10006 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10007 Report overflow in size calculations when allocating printf buffer.
10008 Do not truncate output string at its first null byte.
10009 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10010 Truncate the output at a character boundary, since vsnprintf does not
10012 * charset.c (check_iso_charset_parameter): Convert internal
10013 character to string before calling 'error', since %c now has the
10015 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10016 overflow when computing char to be passed to 'error'. Do not
10017 pass Lisp_Object to 'error'; pass the integer instead.
10018 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10019 formatted with plain %d.
10021 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10023 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10025 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10027 * xterm.c (x_catch_errors): Remove duplicate declaration.
10029 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10031 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10033 2011-04-10 Jim Meyering <meyering@redhat.com>
10035 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10036 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10037 return ssize_t not "int", and use size_t as the buffer length.
10038 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10039 * gnutls.h: Update declarations.
10040 * process.c (read_process_output): Use ssize_t, to match.
10041 (send_process): Likewise.
10043 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10045 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10047 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10049 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10050 Use unsigned char, to match FcChar8 type definition.
10052 * xterm.c (handle_one_xevent):
10053 * xmenu.c (create_and_show_popup_menu):
10054 * xselect.c (x_decline_selection_request)
10055 (x_reply_selection_request): Avoid type-punned deref of X events.
10057 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10059 Fix some uses of `int' instead of EMACS_INT.
10060 * search.c (string_match_1, fast_string_match)
10061 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10062 (scan_buffer, find_next_newline_no_quit)
10063 (find_before_next_newline, search_command, Freplace_match)
10064 (Fmatch_data): Make some `int' variables be EMACS_INT.
10066 * xdisp.c (display_count_lines): 3rd argument and return value now
10067 EMACS_INT. All callers changed.
10068 (pint2hrstr): Last argument is now EMACS_INT.
10070 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10071 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10072 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10073 (decode_coding_utf_16, decode_coding_emacs_mule)
10074 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10075 (decode_coding_ccl, decode_coding_charset)
10076 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10077 (decode_coding_iso_2022, decode_coding_emacs_mule)
10078 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10079 <char_offset, last_offset>: Declare EMACS_INT.
10080 (encode_coding_utf_8, encode_coding_utf_16)
10081 (encode_coding_emacs_mule, encode_invocation_designation)
10082 (encode_designation_at_bol, encode_coding_iso_2022)
10083 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10084 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10086 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10087 (encode_invocation_designation): Last argument P_NCHARS is now
10089 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10090 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10092 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10095 * ccl.c (Fccl_execute_on_string): Declare some variables
10098 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10100 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10102 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10104 * process.c (Fformat_network_address): Doc fix.
10106 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10108 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10110 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10112 * keyboard.c (read_char): Call Lisp function help-form-show,
10113 instead of using internal_with_output_to_temp_buffer.
10114 (Qhelp_form_show): New var.
10115 (syms_of_keyboard): Use DEFSYM macro.
10117 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10119 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10121 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10123 * process.c (Flist_processes): Remove to Lisp.
10124 (list_processes_1): Delete.
10126 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10128 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10130 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10132 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10134 Fix more problems found by GCC 4.6.0's static checks.
10136 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10138 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10140 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10142 * xdisp.c (vmessage): Mark as a printf-like function.
10144 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10146 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10148 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10149 printf-like functions.
10150 (tiff_load): Add casts to remove these marks before passing them
10151 to system-supplied API.
10153 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10155 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10156 This avoids several warnings with gcc -Wstrict-overflow.
10157 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10158 directly, rather than having caller test rule sign. This avoids
10159 some unnecessary tests.
10160 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10161 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10162 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10164 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10165 (xfont_open): Avoid unnecessary tests.
10167 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10169 * composite.h, composite.c (composition_gstring_put_cache):
10170 Use EMACS_INT, not int, for length.
10172 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10173 breaking out part of COMPOSITION_DECODE_RULE.
10174 (COMPOSITION_DECODE_RULE): Use it.
10175 * composite.c (get_composition_id): Remove unused local vars,
10176 by using the new macro.
10178 * textprop.c (set_text_properties_1): Change while to do-while,
10179 since the condition is always true at first.
10181 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10182 (interval_deletion_adjustment): Return unsigned value.
10185 * process.c (list_processes_1, create_pty, read_process_output):
10186 (exec_sentinel): Remove vars that were set but not used.
10187 (create_pty): Remove unnecessary "volatile"s.
10188 (Fnetwork_interface_info): Avoid possibility of int overflow.
10189 (read_process_output): Do adaptive read buffering even if carryover.
10190 (read_process_output): Simplify nbytes computation if buffered.
10192 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10194 * syntax.c (scan_words): Remove var that was set but not used.
10195 (update_syntax_table): Use unsigned instead of int.
10197 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10198 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10199 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10201 * print.c (print_error_message): Avoid int overflow.
10203 * font.c (font_list_entities): Redo for clarity,
10204 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10206 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10207 (font_score): Avoid potential overflow in diff calculation.
10209 * fns.c (substring_both): Remove var that is set but not used.
10210 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10212 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10214 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10215 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10216 can always succeed if overflow has undefined behavior.
10218 * search.c (boyer_moore, wordify): Remove vars set but not used.
10219 (wordify): Omit three unnecessary tests.
10221 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10222 All callers changed. This avoids the need for an unused var.
10224 * casefiddle.c (casify_region): Remove var that is set but not used.
10226 * dired.c (file_name_completion): Remove var that is set but not used.
10228 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10230 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10231 (Finsert_file_contents): Remove unnecessary code checking fd.
10233 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10234 Check for integer overflow on size calculations.
10236 * buffer.c (Fprevious_overlay_change): Remove var that is set
10239 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10240 Remove vars that are set but not used.
10241 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10242 (timer_check_2): Mark vars as initialized.
10244 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10246 * image.c (lookup_image): Remove var that is set but not used.
10247 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10249 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10250 that are set but not used.
10252 * xfns.c (make_invisible_cursor): Don't return garbage
10253 if XCreateBitmapFromData fails (Bug#8410).
10255 * xselect.c (x_get_local_selection, x_handle_property_notify):
10256 Remove vars that are set but not used.
10258 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10259 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10261 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10262 Remove var that is set but not used.
10263 (scroll_bar_windows_size): Now size_t, not int.
10264 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10265 Check for overflow.
10267 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10268 (map_tty_color) [!defined MSDOS]: Likewise.
10270 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10272 * coding.c: Remove vars that are set but not used.
10273 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10274 All callers changed.
10275 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10276 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10277 (decode_coding_charset): Remove vars that are set but not used.
10279 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10280 that is set but not used.
10282 * print.c (print_object): Remove var that is set but not used.
10284 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10285 The gnulib version avoids calling malloc in the usual case,
10286 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10287 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10288 * filelock.c (current_lock_owner): Likewise.
10289 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10290 * sysdep.c: Include allocator.h, careadlinkat.h.
10291 (emacs_no_realloc_allocator): New static constant.
10292 (emacs_readlink): New function.
10293 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10294 ../lib/careadlinkat.h.
10296 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10298 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10299 first non-nil return value).
10301 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10303 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10304 if not defined (Bug#8403).
10306 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10308 * xdisp.c (display_count_lines): Remove parameter `start',
10309 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10310 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10311 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10312 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10313 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10314 and thereabouts. All callers changed.
10315 (get_per_char_metric): Remove parameter `f', unused since
10316 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10318 2011-04-02 Jim Meyering <meyering@redhat.com>
10320 do not dereference NULL upon failed strdup
10321 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10322 (ns_get_family): Likewise.
10324 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10326 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10328 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10330 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10333 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10335 Add lexical binding.
10337 * window.c (Ftemp_output_buffer_show): New fun.
10338 (Fsave_window_excursion):
10339 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10341 * lread.c (lisp_file_lexically_bound_p): New function.
10342 (Fload): Bind Qlexical_binding.
10343 (readevalloop): Remove `evalfun' arg.
10344 Bind Qinternal_interpreter_environment.
10345 (Feval_buffer): Bind Qlexical_binding.
10346 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10348 (syms_of_lread): Declare `lexical-binding'.
10350 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10352 * keyboard.c (eval_dyn): New fun.
10353 (menu_item_eval_property): Use it.
10355 * image.c (parse_image_spec): Use Ffunctionp.
10357 * fns.c (concat, mapcar1): Accept byte-code-functions.
10359 * eval.c (Fsetq): Handle lexical vars.
10360 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10361 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10362 (FletX, Flet): Obey lexical binding.
10363 (Fcommandp): Handle closures.
10364 (Feval): New `lexical' arg.
10365 (eval_sub): New function extracted from Feval. Use it almost
10366 everywhere where Feval was used. Look up vars in lexical env.
10368 (Ffunctionp): Move from subr.el.
10369 (Ffuncall): Handle closures.
10370 (apply_lambda): Remove `eval_flags'.
10371 (funcall_lambda): Handle closures and new byte-code-functions.
10372 (Fspecial_variable_p): New function.
10373 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10374 but without exporting it to Lisp.
10376 * doc.c (Fdocumentation, store_function_docstring):
10377 * data.c (Finteractive_form): Handle closures.
10379 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10382 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10384 (exec_byte_code): New function extracted from Fbyte_code to handle new
10385 calling convention for byte-code-functions. Add new byte-codes.
10387 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10389 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10391 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10393 * xdisp.c (redisplay_internal): Fix prototype.
10395 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10397 * xdisp.c (SCROLL_LIMIT): New macro.
10398 (try_scrolling): Use it when setting scroll_limit.
10399 Limit scrolling to 100 screen lines.
10400 (redisplay_window): Even when falling back on "recentering",
10401 position point in the window according to scroll-conservatively,
10402 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10404 (try_scrolling): When point is above the window, allow searching
10405 as far as scroll_max, or one screenful, to compute vertical
10406 distance from PT to the scroll margin position. This prevents
10407 try_scrolling from unnecessarily failing when
10408 scroll-conservatively is set to a value slightly larger than the
10409 window height. Clean up the case of PT below the margin at bottom
10410 of window: scroll_max can no longer be INT_MAX. When aggressive
10411 scrolling is in use, don't let point enter the opposite scroll
10412 margin as result of the scroll.
10413 (syms_of_xdisp) <scroll-conservatively>: Document the
10414 threshold of 100 lines for never-recentering scrolling.
10416 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10418 * dispextern.h (move_it_by_lines):
10419 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10420 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10421 (message_log_check_duplicate): Remove parameters `prev_bol' and
10422 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10423 (redisplay_internal): Remove parameter `preserve_echo_area',
10424 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10426 * indent.c (Fvertical_motion):
10427 * window.c (window_scroll_pixel_based, Frecenter):
10428 Don't pass `need_y_p' to `move_it_by_lines'.
10430 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10432 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10433 steal a few bits to be more compact.
10434 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10435 Remove unneeded casts.
10437 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10439 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10441 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10442 binding" message (bug#7967).
10444 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10446 Fix more problems found by GCC 4.6.0's static checks.
10448 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10449 Remove unused local var.
10451 * editfns.c (Fmessage_box): Remove unused local var.
10453 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10454 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10455 Omit unused local vars.
10456 * window.c (shrink_windows): Omit unused local var.
10457 * menu.c (digest_single_submenu): Omit unused local var.
10458 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10459 Omit unused local var.
10461 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10462 Don't assume string length fits in int.
10463 (keyremap_step, read_key_sequence): Use size_t for sizes.
10464 (read_key_sequence): Don't check last_real_key_start redundantly.
10466 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10467 instead of alloca (Bug#8344).
10469 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10470 (Fbacktrace_frame): Don't assume nframes fits in int.
10472 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10474 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10477 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10479 * cm.c (calccost): Turn while-do into do-while, for clarity.
10481 * keyboard.c (syms_of_keyboard): Use the same style as later
10482 in this function when indexing through an array. This also
10483 works around GCC bug 48267.
10485 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10487 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10489 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10490 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10492 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10493 This avoids undefined behavior on integer overflow, and is a bit
10494 more convenient anyway since it is compared to a size_t variable.
10496 Variadic C functions now count arguments with size_t, not int.
10497 This avoids an unnecessary limitation on 64-bit machines, which
10498 caused (substring ...) to crash on large vectors (Bug#8344).
10499 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10500 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10501 All variadic functions and their callers changed accordingly.
10502 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10503 * data.c (arith_driver, float_arith_driver): Likewise.
10504 * editfns.c (general_insert_function): Likewise.
10505 * eval.c (struct backtrace.nargs, interactive_p)
10506 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10507 (funcall_lambda, mark_backtrace): Likewise.
10508 * fns.c (concat): Likewise.
10509 * frame.c (x_set_frame_parameters): Likewise.
10510 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10511 0 if not found, not -1. All callers changed.
10513 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10514 (stack_copy_size): Now size_t, not int.
10515 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10517 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10519 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10520 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10521 All callers changed.
10523 * lisp.h (multibyte_char_to_unibyte):
10524 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10525 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10526 * character.h (CHAR_TO_BYTE8):
10527 * cmds.c (internal_self_insert):
10528 * editfns.c (general_insert_function):
10529 * keymap.c (push_key_description):
10530 * search.c (Freplace_match):
10531 * xdisp.c (message_dolog, set_message_1): All callers changed.
10533 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10535 * keyboard.c (safe_run_hook_funcall): New function.
10536 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10537 don't set the hook to nil, but remove the offending function instead.
10538 (Qcommand_hook_internal): Remove, unused.
10539 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10540 Vcommand_hook_internal.
10542 * eval.c (enum run_hooks_condition): Remove.
10543 (funcall_nil, funcall_not): New functions.
10544 (run_hook_with_args): Call each function through a `funcall' argument.
10545 Remove `cond' argument, now redundant.
10546 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10547 (Frun_hook_with_args_until_failure): Adjust accordingly.
10548 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10550 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10552 * dispextern.h (string_buffer_position): Remove declaration.
10554 * print.c (strout): Remove parameter `multibyte', unused since
10555 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10557 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10558 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10559 All callers changed.
10561 * w32.c (_wsa_errlist): Use braces for struct initializers.
10563 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10564 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10565 All callers changed.
10566 (string_buffer_position): Likewise. Also, make static (it's never
10567 used outside xdisp.c).
10568 (cursor_row_p): Remove parameter `w', unused since
10569 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10570 (decode_mode_spec): Remove parameter `precision', introduced during
10571 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10572 All callers changed.
10574 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10576 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10578 2011-03-27 Anders Lindgren <andlind@gmail.com>
10580 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10581 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10582 (ns_update_auto_hide_menu_bar): New functions.
10583 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10584 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10585 ns_constrain_all_frames.
10586 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10587 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10589 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10591 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10593 2011-03-27 Glenn Morris <rgm@gnu.org>
10595 * syssignal.h: Replace RETSIGTYPE with void.
10596 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10597 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10598 Replace SIGTYPE with void everywhere.
10599 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10600 * s/template.h (SIGTYPE): Remove commented out definition.
10602 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10604 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10605 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10607 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10609 * w32.c (read_unc_volume): Use parameter `henum', instead of
10610 global variable `wget_enum_handle'.
10612 * keymap.c (describe_vector): Remove parameters `indices' and
10613 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10614 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10616 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10618 * keyboard.c (timer_check): Remove parameter `do_it_now',
10619 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10620 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10621 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10623 * keyboard.c (read_char):
10624 * w32menu.c (w32_menu_display_help):
10625 * xmenu.c (show_help_event, menu_help_callback):
10626 Adjust calls to `show_help_echo'.
10628 * gtkutil.c (xg_maybe_add_timer):
10629 * keyboard.c (readable_events):
10630 * process.c (wait_reading_process_output):
10631 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10633 * insdel.c (adjust_markers_gap_motion):
10634 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10635 (gap_left, gap_right): Don't call it.
10637 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10639 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10640 incurred during fontification.
10642 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10644 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10645 (DEFVAR_PER_BUFFER): Don't pass it.
10647 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10648 (scrolling_window): Don't pass it.
10650 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10652 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10654 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10656 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10657 of variables specific to SELinux and computation of `encoded_absname'.
10659 * image.c (XPutPixel): Remove unused variable `height'.
10661 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10663 * unexw32.c (get_section_info): Remove unused variable `section'.
10665 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10666 (system_process_attributes): Remove unused variable `sess'.
10667 (sys_read): Remove unused variable `err'.
10669 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10670 (w32_wnd_proc): Remove unused variable `isdead'.
10671 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10672 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10673 (x_create_tip_frame): Remove unused variable `tem'.
10675 * w32inevt.c (w32_console_read_socket):
10676 Remove unused variable `no_events'.
10678 * w32term.c (x_draw_composite_glyph_string_foreground):
10679 Remove unused variable `width'.
10681 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10683 * w32term.c (x_set_glyph_string_clipping):
10684 Don't pass uninitialized region to CombineRgn.
10686 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10688 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10689 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10690 (Fx_close_connection): Remove unused variable `i'.
10692 * w32font.c (w32font_draw): Return number of glyphs.
10693 (w32font_open_internal): Remove unused variable `i'.
10694 (w32font_driver): Add missing initializer.
10696 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10697 (fill_in_menu): Remove unused variable `items_added'.
10699 * w32term.c (last_mouse_press_frame): Remove static global variable.
10700 (w32_clip_to_row): Remove unused variable `f'.
10701 (x_delete_terminal): Remove unused variable `i'.
10703 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10704 (NOTHING): Remove unused static global variable.
10705 (uniscribe_check_otf): Remove unused variable `table'.
10706 (uniscribe_font_driver): Add missing initializers.
10708 2011-03-23 Julien Danjou <julien@danjou.info>
10710 * term.c (Fsuspend_tty, Fresume_tty):
10711 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10712 * window.c (temp_output_buffer_show):
10713 * insdel.c (signal_before_change):
10714 * frame.c (Fhandle_switch_frame):
10715 * fileio.c (Fdo_auto_save):
10716 * emacs.c (Fkill_emacs):
10717 * editfns.c (save_excursion_restore):
10718 * cmds.c (internal_self_insert):
10719 * callint.c (Fcall_interactively):
10720 * buffer.c (Fkill_all_local_variables):
10721 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10723 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10724 unconditionally since it does the check itself.
10726 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10728 Fix more problems found by GCC 4.5.2's static checks.
10730 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10731 the first time through the loop, since we know p0 < p1 then.
10732 This also avoids a gcc -Wstrict-overflow warning.
10734 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10735 leading to a memory leak, possible in functions like
10736 load_charset_map_from_file that can allocate an unbounded number
10737 of objects (Bug#8318).
10739 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10740 that could (at least in theory) be that large.
10742 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10743 This is less likely to overflow, and avoids undefined behavior if
10744 overflow does occur. All callers changed. Use strtoul to scan
10745 for the unsigned long integer.
10746 (pint2hrstr): Simplify and tune code slightly.
10747 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10749 * scroll.c (do_scrolling): Work around GCC bug 48228.
10750 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10752 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10753 This also avoids a warning with gcc -Wstrict-overflow.
10754 (validate_x_resource_name): Simplify count usage.
10755 This also avoids a warning with gcc -Wstrict-overflow.
10757 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10760 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10762 * process.c (Fmake_network_process): Use socklen_t, not int,
10763 where POSIX says socklen_t is required in portable programs.
10764 This fixes a porting bug on hosts like 64-bit HP-UX, where
10765 socklen_t is wider than int (Bug#8277).
10766 (Fmake_network_process, server_accept_connection):
10767 (wait_reading_process_output, read_process_output):
10770 * process.c: Rename or move locals to avoid shadowing.
10771 (list_processes_1, Fmake_network_process):
10772 (read_process_output_error_handler, exec_sentinel_error_handler):
10773 Rename or move locals.
10774 (Fmake_network_process): Define label "retry_connect" only if needed.
10775 (Fnetwork_interface_info): Fix pointer signedness.
10776 (process_send_signal): Add cast to avoid pointer signedness problem.
10777 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10778 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10780 Make tparam.h and terminfo.c consistent.
10781 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10782 Include tparam.h instead, since it declares them.
10783 * cm.h (PC): Remove extern decl; tparam.h now does this.
10784 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10785 * terminfo.c: Include tparam.h, to check interfaces.
10786 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10787 (tparam): Adjust signature to match interface in tparam.h;
10788 this removes some undefined behavior. Check that outstring and len
10789 are zero, which they always are with Emacs.
10790 * tparam.h (PC, BC, UP): New extern decls.
10792 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10793 (xftfont_open): Rename locals to avoid shadowing.
10795 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10796 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10797 (OTF_TAG_SYM): Omit macro if not needed.
10798 (ftfont_list): Remove unused local.
10799 (get_adstyle_property, ftfont_pattern_entity):
10800 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10801 Rename locals to avoid shadowing.
10803 * xfont.c (xfont_list_family): Mark var as initialized.
10805 * xml.c (make_dom): Now static.
10807 * composite.c (composition_compute_stop_pos): Rename local to
10809 (composition_reseat_it): Remove unused locals.
10810 (find_automatic_composition, composition_adjust_point): Likewise.
10811 (composition_update_it): Mark var as initialized.
10812 (find_automatic_composition): Mark vars as initialized,
10813 with a FIXME (Bug#8290).
10815 character.h: Rename locals to avoid shadowing.
10816 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10817 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10818 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10819 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10820 to avoid shadowing.
10822 * textprop.c (property_change_between_p): Remove; unused.
10824 * intervals.c (interval_start_pos): Now static.
10826 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10828 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10829 Rename locals to avoid shadowing.
10831 * sound.c (wav_play, au_play, Fplay_sound_internal):
10832 Fix pointer signedness.
10833 (alsa_choose_format): Remove unused local var.
10834 (wav_play): Initialize a variable to 0, to prevent undefined
10835 behavior (Bug#8278).
10837 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10839 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10841 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10842 clobbering (Bug#8298).
10843 * sysdep.c (sys_subshell): Likewise.
10844 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10846 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10847 This should get cleaned up, so that child_setup has the
10848 same signature on all platforms.
10850 * callproc.c (call_process_cleanup): Now static.
10851 (relocate_fd): Rename locals to avoid shadowing.
10853 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10855 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10856 not to be necessary, and produces flickering.
10858 2011-03-20 Glenn Morris <rgm@gnu.org>
10860 * config.in: Remove file.
10862 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10864 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10865 are now in src/globals.h.
10866 (syms_of_minibuf): Remove spurious & from previous change.
10868 2011-03-20 Leo Liu <sdl.web@gmail.com>
10870 * minibuf.c (completing-read-function): New variable.
10871 (completing-read-default): Rename from completing-read.
10872 (completing-read): Call completing-read-function.
10874 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10876 * xfaces.c (Fx_load_color_file):
10877 Read color file from absolute filename (bug#8250).
10879 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10881 * makefile.w32-in: Update dependencies.
10883 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10885 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10887 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10889 Fix more problems found by GCC 4.5.2's static checks.
10891 * process.c (make_serial_process_unwind, send_process_trap):
10892 (sigchld_handler): Now static.
10894 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10895 That way, the code declares only the vars that it needs.
10896 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10897 * s/cygwin.h (PTY_ITERATION): Likewise.
10898 * s/darwin.h (PTY_ITERATION): Likewise.
10899 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10901 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10902 * process.c (allocate_pty): Don't declare stb unless it's needed.
10904 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10905 (CONSTANTLIM): Remove; unused.
10906 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10907 Define only if needed.
10909 * unexelf.c (unexec): Name an expression,
10910 to avoid gcc -Wbad-function-cast warning.
10911 Use a different way to cause a compilation error if anyone uses
10912 n rather than nn, a way that does not involve shadowing.
10913 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10915 * deps.mk (unexalpha.o): Remove; unused.
10917 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10918 * unexec.h: New file.
10919 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10920 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10921 Depend on unexec.h.
10922 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10923 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10924 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10925 Change as necessary to match prototype in unexec.h.
10927 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10929 (back_comment, skip_chars): Mark vars as initialized.
10931 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10932 Rename locals to avoid shadowing.
10934 * lread.c (read1): Rewrite so as not to use empty "else".
10935 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10937 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10939 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10940 warning when compiling print.c.
10942 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10943 instead of using an uninitialized var.
10944 (font_sort_entities): Mark var as initialized.
10946 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10948 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10949 pointers to constants.
10950 (font_parse_fcname): Remove unused vars.
10951 (font_delete_unmatched): Now static.
10952 (font_get_spec): Remove; unused.
10953 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10954 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10955 Rename or move locals to avoid shadowing.
10957 * fns.c (require_nesting_list, require_unwind): Now static.
10958 (Ffillarray): Rename locals to avoid shadowing.
10960 * floatfns.c (domain_error2): Define only if needed.
10961 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10963 * alloc.c (mark_backtrace): Move decl from here ...
10964 * lisp.h: ... to here, so that it can be checked.
10966 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
10967 (Fdefvar): Rewrite so as not to use empty "else".
10968 (lisp_indirect_variable): Name an expression,
10969 to avoid gcc -Wbad-function-cast warning.
10970 (Fdefvar): Rename locals to avoid shadowing.
10972 * callint.c (quotify_arg, quotify_args): Now static.
10973 (Fcall_interactively): Rename locals to avoid shadowing.
10974 Use const pointer when appropriate.
10976 * lisp.h (get_system_name, get_operating_system_release):
10977 Move decls here, to check interfaces.
10978 * process.c (get_operating_system_release): Move decl to lisp.h.
10979 * xrdb.c (get_system_name): Likewise.
10980 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10981 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10982 some of which prompt warnings from gcc -Wbad-function-cast.
10983 (Fformat_time_string, Fencode_time, Finsert_char):
10984 (Ftranslate_region_internal, Fformat):
10985 Rename or remove local vars to avoid shadowing.
10986 (Ftranslate_region_internal): Mark var as initialized.
10988 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10991 * lisp.h (eassert): Check that the argument compiles, even if
10992 ENABLE_CHECKING is not defined.
10994 * data.c (Findirect_variable): Name an expression, to avoid
10995 gcc -Wbad-function-cast warning.
10996 (default_value, arithcompare, arith_driver, arith_error): Now static.
10997 (store_symval_forwarding): Rename local to avoid shadowing.
10998 (Fmake_variable_buffer_local, Fmake_local_variable):
10999 Mark variables as initialized.
11000 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11002 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11003 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11004 Rename locals to avoid shadowing.
11005 (mark_stack): Move local variables into the #ifdef region where
11007 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11008 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11010 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11011 (GC_STRING_CHARS): Remove; not used.
11012 (Fmemory_limit): Cast sbrk's returned value to char *.
11014 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11015 avoids undefined behavior in theory.
11017 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11019 Use functions, not macros, for up- and down-casing (Bug#8254).
11020 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11021 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11022 to use the following functions instead of these macros.
11023 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11024 EMACS_INT, since callers assume the returned value fits in int.
11025 (upcase1): Likewise, for UPCASE_TABLE.
11026 (uppercasep, lowercasep, upcase): New static inline functions.
11027 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11028 the race-condition problem in the old DOWNCASE.
11030 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11031 Rename locals to avoid shadowing.
11032 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11033 (regex_compile, re_search_2, re_match_2_internal):
11034 Remove unused local vars.
11035 (FREE_VAR): Rewrite so as not to use empty "else",
11036 which gcc can warn about.
11037 (regex_compile, re_match_2_internal): Mark locals as initialized.
11038 (RETALLOC_IF): Define only if needed.
11039 (WORDCHAR_P): Likewise. This one is never needed, but is used
11040 only in a comment talking about a compiler bug, so put inside
11041 the #if 0 of that comment.
11042 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11043 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11046 * search.c (boyer_moore): Rename locals to avoid shadowing.
11047 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11048 (PREV_CHAR_BOUNDARY): Likewise.
11050 * search.c (simple_search): Remove unused var.
11052 * dired.c (compile_pattern): Move decl from here ...
11053 * lisp.h: ... to here, so that it can be checked.
11054 (struct re_registers): New forward decl.
11056 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11058 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11060 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11061 Rename locals to avoid shadowing.
11062 (Fvertical_motion): Mark locals as initialized.
11064 * casefiddle.c (casify_object, casify_region): Now static.
11065 (casify_region): Mark local as initialized.
11067 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11069 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11070 New macros, so that the caller can use some names other than
11071 gcpro1, gcpro2, etc.
11072 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11074 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11075 argument, for consistency with GCPRO2_VAR, etc: it is now the
11076 prefix of the variable, not the variable itself. All uses
11078 * dired.c (directory_files_internal, file_name_completion):
11079 Rename locals to avoid shadowing.
11081 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11082 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11083 dired.c's scmp function, had undefined behavior.
11084 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11085 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11086 * buffer.h: ... to here, because these macros use current_buffer,
11087 and the new implementation with inline functions needs to have
11088 current_buffer in scope now, rather than later when the macros
11090 (downcase, upcase1): New static inline functions.
11091 (DOWNCASE, UPCASE1): Reimplement using these functions.
11092 This avoids undefined behavior in expressions like
11093 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11094 from race conditions in accessing the global variables
11095 case_temp1 and case_temp2.
11096 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11097 * lisp.h (case_temp1, case_temp2): Remove their decls.
11098 * character.h (ASCII_CHAR_P): Move from here ...
11099 * lisp.h: ... to here, so that the inline functions mentioned
11100 above can use them.
11102 * dired.c (directory_files_internal_unwind): Now static.
11104 * fileio.c (file_name_as_directory, directory_file_name):
11105 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11107 (file_name_as_directory): Use const pointers when appropriate.
11108 (Fexpand_file_name): Likewise. In particular, newdir might
11109 point at constant storage, so make it a const pointer.
11110 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11111 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11113 (Fset_file_times, Finsert_file_contents, auto_save_error):
11114 Rename locals to avoid shadowing.
11116 * minibuf.c (choose_minibuf_frame_1): Now static.
11117 (Ftry_completion, Fall_completions): Rename or remove locals
11118 to avoid shadowing.
11120 * marker.c (bytepos_to_charpos): Remove; unused.
11122 * lisp.h (verify_bytepos, count_markers): New decls,
11123 so that gcc does not warn that these functions aren't declared.
11125 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11126 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11127 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11128 (copy_text): Remove unused local var.
11130 * filelock.c (within_one_second): Now static.
11131 (lock_file_1): Rename local to avoid shadowing.
11133 * buffer.c (fix_overlays_before): Mark locals as initialized.
11134 (fix_start_end_in_overlays): Likewise. This function should be
11135 simplified by using pointers-to-pointers, but that's a different
11137 (switch_to_buffer_1): Now static.
11138 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11139 (report_overlay_modification): Rename locals to avoid shadowing.
11141 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11142 Fix pointer signedness issue.
11143 (sys_subshell): Mark local as volatile if checking for lint,
11144 to suppress a gcc -Wclobbered warning that does not seem to be right.
11145 (MAXPATHLEN): Define only if needed.
11147 * process.c (serial_open, serial_configure): Move decls from here ...
11148 * systty.h: ... to here, so that they can be checked.
11150 * fns.c (get_random, seed_random): Move extern decls from here ...
11151 * lisp.h: ... to here, so that they can be checked.
11153 * sysdep.c (reset_io): Now static.
11154 (wait_for_termination_signal): Remove; unused.
11156 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11157 (copy_keymap_item, append_key, push_text_char_description):
11159 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11160 (DENSE_TABLE_SIZE): Remove; unused.
11161 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11162 (describe_map_tree):
11163 Rename locals to avoid shadowing.
11165 * keyboard.c: Declare functions static if they are not used elsewhere.
11166 (echo_char, echo_dash, cmd_error, top_level_2):
11167 (poll_for_input, handle_async_input): Now static.
11168 (read_char, kbd_buffer_get_event, make_lispy_position):
11169 (make_lispy_event, make_lispy_movement, apply_modifiers):
11170 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11171 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11172 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11173 (read_key_sequence, read_char): Mark locals as initialized.
11174 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11176 * keyboard.h (make_ctrl_char): New decl.
11177 (mark_kboards): Move decl here ...
11178 * alloc.c (mark_kboards): ... from here.
11180 * lisp.h (force_auto_save_soon): New decl.
11182 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11183 (DEFINE_DUMMY_FUNCTION): New macro.
11184 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11186 (main): Add casts to avoid warnings
11187 if GCC considers string literals to be constants.
11189 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11191 * dbusbind.c: Pointer signedness fixes.
11192 (xd_signature, xd_append_arg, xd_initialize):
11193 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11194 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11195 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11196 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11198 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11199 if GCC considers string literals to be constants.
11200 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11202 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11204 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11205 (print_preprocess, print_object): New macro to fix last change.
11207 * print.c (print_preprocess): Don't forget font objects.
11209 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11211 * emacs.c (USAGE3): Doc fixes.
11213 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11215 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11218 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11220 * lisp.h (VWindow_system, Qfile_name_history):
11221 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11222 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11223 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11225 * w32select.c: Don't #include "keyboard.h".
11226 (run_protected): Add extern declaration for waiting_for_input.
11228 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11229 * w32console.c (detect_input_pending, read_input_pending)
11230 (encode_terminal_code):
11231 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11232 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11233 (w32_system_caret_y, Qfile_name_history):
11234 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11235 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11236 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11237 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11238 * w32proc.c (Qlocal, report_file_error):
11239 * w32term.c (Vwindow_system, updating_frame):
11240 * w32uniscribe.c (initialized, uniscribe_font_driver):
11241 Remove unneeded extern declarations.
11243 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11245 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11247 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11249 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11250 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11251 These macros can no longer be used for assignment.
11253 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11254 Assign struct members directly, instead of using BUF_BEGV etc.
11255 (record_buffer_markers, fetch_buffer_markers): New functions for
11256 recording and fetching special buffer markers.
11257 (set_buffer_internal_1, set_buffer_temp): Use them.
11259 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11261 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11263 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11264 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11266 * xdisp.c (hscroll_window_tree):
11267 (reconsider_clip_changes): Use PT instead of BUF_PT.
11269 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11271 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11272 $(EMACS_ROOT)/lib/intprops.h.
11274 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11276 Fix more problems found by GCC 4.5.2's static checks.
11278 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11279 to unsigned char * to avoid compiler diagnostic.
11280 (xg_free_frame_widgets): Make it clear that a local variable is
11281 needed only if USE_GTK_TOOLTIP.
11282 (gdk_window_get_screen): Make it clear that this macro is needed
11283 only if USE_GTK_TOOLTIP.
11284 (int_gtk_range_get_value): New function, which avoids a diagnostic
11285 from gcc -Wbad-function-cast.
11286 (xg_set_toolkit_scroll_bar_thumb): Use it.
11287 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11288 diagnostic from gcc -Wbad-function-cast.
11289 (get_utf8_string, xg_get_file_with_chooser):
11290 Rename locals to avoid shadowing.
11291 (create_dialog): Move locals to avoid shadowing.
11293 * xgselect.c (xg_select): Remove unused var.
11295 * image.c (four_corners_best): Mark locals as initialized.
11296 (gif_load): Initialize transparent_p to zero (Bug#8238).
11297 Mark another local as initialized.
11298 (my_png_error, my_error_exit): Mark with NO_RETURN.
11300 * image.c (clear_image_cache): Now static.
11301 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11302 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11303 (x_edge_detection): Remove unnecessary cast that
11304 gcc -Wbad-function-cast diagnoses.
11305 (gif_load): Fix pointer signedness.
11306 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11307 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11309 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11311 Improve quality of tests for time stamp overflow.
11312 For example, without this patch (encode-time 0 0 0 1 1
11313 1152921504606846976) returns the obviously-bogus value (-948597
11314 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11315 reports time overflow. See
11316 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11317 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11318 * editfns.c: Include limits.h and intprops.h.
11319 (TIME_T_MIN, TIME_T_MAX): New macros.
11320 (time_overflow): Move earlier, to before first use.
11321 (hi_time, lo_time): New functions, for an accurate test for
11322 out-of-range times.
11323 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11324 (Fget_internal_run_time): Don't assume time_t fits in int.
11325 (make_time): Use list2 instead of Fcons twice.
11326 (Fdecode_time): More accurate test for out-of-range times.
11327 (check_tm_member): New function.
11328 (Fencode_time): Use it, to test for out-of-range times.
11329 (lisp_time_argument): Don't rely on undefined left-shift and
11330 right-shift behavior when checking for time stamp overflow.
11332 * editfns.c (time_overflow): New function, refactoring common code.
11333 (Fformat_time_string, Fdecode_time, Fencode_time):
11334 (Fcurrent_time_string): Use it.
11336 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11337 * dired.c (make_time): Move to ...
11338 * editfns.c (make_time): ... here.
11339 * systime.h: Note the move.
11341 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11343 * fringe.c (update_window_fringes): Remove unused variables.
11345 * unexmacosx.c (copy_data_segment): Also copy __got section.
11348 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11350 * termcap.c [MSDOS]: Include "msdos.h".
11351 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11352 Constify `char *' arguments and their references according to
11353 prototypes in tparam.h.
11355 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11357 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11358 Adapt all references accordingly.
11360 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11362 2011-03-11 Tom Tromey <tromey@redhat.com>
11364 * buffer.c (syms_of_buffer): Remove obsolete comment.
11366 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11368 * termhooks.h (encode_terminal_code): Declare prototype.
11370 * msdos.c (encode_terminal_code): Don't declare prototype.
11372 * term.c (encode_terminal_code): Now external again, used by
11373 w32console.c and msdos.c.
11375 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11376 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11378 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11380 Fix some minor problems found by GCC 4.5.2's static checks.
11382 * fringe.c (update_window_fringes): Mark locals as initialized
11384 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11386 * alloc.c (mark_fringe_data): Move decl from here ...
11387 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11388 to check its interface.
11389 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11391 * fontset.c (free_realized_fontset): Now static.
11392 (Fset_fontset_font): Rename local to avoid shadowing.
11393 (fontset_font): Mark local as initialized.
11394 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11396 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11398 * xselect.c (x_disown_buffer_selections): Remove; not used.
11399 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11400 (x_own_selection, Fx_disown_selection_internal): Rename locals
11401 to avoid shadowing.
11402 (x_handle_dnd_message): Remove local to avoid shadowing.
11404 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11405 so that the caller can use some name other than gcpro1.
11406 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11407 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11408 (Fx_backspace_delete_keys_p):
11409 Use them to avoid shadowing, and rename vars to avoid shadowing.
11410 (x_decode_color, x_set_name, x_window): Now static.
11411 (Fx_create_frame): Add braces to silence GCC warning.
11412 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11413 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11414 Remove unused locals.
11415 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11416 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11417 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11420 * xterm.h (x_mouse_leave): New decl.
11422 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11423 Remove unused functions.
11424 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11425 (x_calc_absolute_position): Now static.
11426 (XTread_socket): Don't define label "out" unless it's used.
11427 Don't declare local "event" unless it's used.
11428 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11429 unless they are used.
11430 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11431 (x_fatal_error_signal): Remove; not used.
11432 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11433 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11434 (x_error_catcher, x_connection_closed, x_error_handler):
11435 (x_error_quitter, xembed_send_message, x_iconify_frame):
11436 (my_log_handler): Rename locals to avoid shadowing.
11437 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11438 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11440 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11441 Rename or move locals to avoid shadowing.
11442 (tty_defined_color, merge_face_heights): Now static.
11443 (free_realized_faces_for_fontset): Remove; not used.
11444 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11445 does not deduce is never used uninitialized.
11446 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11447 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11449 * terminal.c (store_terminal_param): Now static.
11451 * xmenu.c (menu_highlight_callback): Now static.
11452 (set_frame_menubar): Remove unused local.
11453 (xmenu_show): Rename parameter to avoid shadowing.
11454 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11455 since they might point to immutable storage.
11456 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11457 since it's unused otherwise.
11459 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11460 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11461 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11462 avoids a gcc -Wuninitialized diagnostic.
11463 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11464 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11465 does not deduce are never used uninitialized.
11467 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11469 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11470 * window.c (window_loop, size_window):
11471 (run_window_configuration_change_hook, enlarge_window): Likewise.
11473 * window.c (display_buffer): Now static.
11474 (size_window): Mark variables that gcc -Wuninitialized
11475 does not deduce are never used uninitialized.
11476 * window.h (check_all_windows): New decl, to forestall
11477 gcc -Wmissing-prototypes diagnostic.
11478 * dispextern.h (bidi_dump_cached_states): Likewise.
11480 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11482 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11483 Include <limits.h>.
11484 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11485 and to avoid gcc -Wuninitialized warning.
11486 (load_charset_map): Mark variables that gcc -Wuninitialized
11487 does not deduce are never used uninitialized.
11488 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11490 * coding.c (coding_set_source, coding_set_destination):
11491 Use "else { /* comment */ }" rather than "else /* comment */;"
11492 for clarity, and to avoid gcc -Wempty-body warning.
11493 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11494 a block, when the outer 'i' will do.
11495 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11496 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11497 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11498 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11499 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11500 Rename locals to avoid shadowing.
11501 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11502 * coding.c (emacs_mule_char, encode_invocation_designation):
11503 Now static, since they're not used elsewhere.
11504 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11505 (decode_coding_object, encode_coding_object, detect_coding_system):
11506 (decode_coding_emacs_mule): Mark variables that gcc
11507 -Wuninitialized does not deduce are never used uninitialized.
11508 (detect_coding_iso_2022): Initialize a local variable that might
11509 be used uninitialized. Leave a FIXME because it's not clear that
11510 this initialization is needed. (Bug#8211)
11511 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11512 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11513 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11514 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11515 Remove unused macros.
11517 * category.c (hash_get_category_set): Remove unused local var.
11518 (copy_category_table): Now static, since it's not used elsewhere.
11519 * character.c (string_count_byte8): Likewise.
11521 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11522 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11524 * chartab.c (copy_sub_char_table): Now static, since it's not used
11526 (sub_char_table_ref_and_range, char_table_ref_and_range):
11527 Rename locals to avoid shadowing.
11528 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11530 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11531 (BIDI_BOB): Remove unused macro.
11533 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11534 deduce are never used uninitialized.
11535 * term.c (encode_terminal_code): Likewise.
11537 * term.c (encode_terminal_code): Now static. Remove unused local.
11539 * tparam.h: New file.
11540 * term.c, tparam.h: Include it.
11541 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11542 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11543 Move these decls to tparam.h, and make them agree with what
11544 is actually in tparam.c. The previous trick of using incompatible
11545 decls in different modules does not conform to the C standard.
11546 All callers of tparam changed to use tparam's actual API.
11547 * tparam.c (tparam1, tparam, tgoto):
11548 Use const pointers where appropriate.
11550 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11551 * cm.h (struct cm): Likewise.
11552 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11553 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11554 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11555 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11556 (turn_on_face, init_tty): Likewise.
11557 * termchar.h (struct tty_display_info): Likewise.
11559 * term.c (term_mouse_position): Rename local to avoid shadowing.
11561 * alloc.c (mark_ttys): Move decl from here ...
11562 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11564 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11566 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11568 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11570 * search.c (compile_pattern_1): Remove argument regp, unused since
11571 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11572 (compile_pattern): Don't pass it.
11574 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11576 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11577 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11579 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11581 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11583 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11584 gdk_window_get_screen, gdk_window_get_geometry,
11585 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11586 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11587 (xg_get_pixbuf_from_pixmap): New function.
11588 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11589 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11590 Call xg_get_pixbuf_from_pixmap instead of
11591 gdk_pixbuf_get_from_drawable.
11592 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11593 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11594 (xg_check_special_colors): Use GtkStyleContext and its functions
11596 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11597 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11598 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11599 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11600 Call gtk_widget_get_preferred_size.
11601 (xg_frame_resized): gdk_window_get_geometry only takes 5
11603 (xg_win_to_widget, xg_event_is_for_menubar):
11604 Call gdk_x11_window_lookup_for_display.
11605 (xg_set_widget_bg): New function.
11606 (delete_cb): New function.
11607 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11608 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11609 (xg_set_background_color): Call xg_set_widget_bg.
11610 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11611 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11612 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11613 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11615 (update_frame_tool_bar): Call gtk_widget_hide.
11616 (xg_initialize): Use GDK_KEY_g.
11618 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11620 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11622 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11623 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11624 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11626 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11628 * w32xfns.c (select_palette): Check success of RealizePalette against
11629 GDI_ERROR, not zero.
11631 See ChangeLog.11 for earlier changes.
11633 ;; Local Variables:
11637 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11639 This file is part of GNU Emacs.
11641 GNU Emacs is free software: you can redistribute it and/or modify
11642 it under the terms of the GNU General Public License as published by
11643 the Free Software Foundation, either version 3 of the License, or
11644 (at your option) any later version.
11646 GNU Emacs is distributed in the hope that it will be useful,
11647 but WITHOUT ANY WARRANTY; without even the implied warranty of
11648 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11649 GNU General Public License for more details.
11651 You should have received a copy of the GNU General Public License
11652 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.