1 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
3 * bytecode.c (targets): Suppress -Woverride-init warnings.
5 Simplify by avoiding confusing use of strncpy etc.
6 * doc.c (Fsnarf_documentation):
7 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
8 * frame.c (Fmake_terminal_frame):
9 * gtkutil.c (get_utf8_string):
11 * nsmenu.m (ns_update_menubar):
13 Prefer memcpy to strncpy and strncat when either will do.
14 * fileio.c (Fsubstitute_in_file_name):
15 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
16 (menu_separator_name_p):
17 * nsmenu.m (ns_update_menubar):
18 Prefer memcmp to strncmp when either will do.
19 * nsterm.m: Include <ftoastr.h>.
21 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
22 Prefer snprintf to strncpy.
23 * nsterm.m (ns_term_init):
24 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
25 * nsterm.m (ns_term_init):
26 Avoid the need for strncpy, by using build_string or
27 make_unibyte_string directly. Use dtoastr, not snprintf.
28 * process.c (Fmake_network_process): Diagnose service names that
29 are too long, rather than silently truncating them or creating
30 non-null-terminated names.
31 (Fnetwork_interface_info): Likewise, for interface names.
32 * sysdep.c (system_process_attributes) [GNU_LINUX]:
33 Prefer sprintf to strncat.
34 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
35 Prefer vsnprintf to vsprintf + strncpy.
37 2012-07-10 Glenn Morris <rgm@gnu.org>
39 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
40 Clarify fallback case.
42 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
44 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
45 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
46 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
47 * w32menu.c, window.c, xmenu.c: Changed to use XCAR and XCDR
48 where argument type is known to be a Lisp_Cons.
50 2012-07-10 Tom Tromey <tromey@redhat.com>
52 * bytecode.c (BYTE_CODE_THREADED): New macro.
53 (BYTE_CODES): New macro. Replaces all old byte-code defines.
54 (enum byte_code_op): New type.
55 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
56 (exec_byte_code): Use them. Use token threading when applicable.
58 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
60 Optimize pure C strings initialization.
61 * lisp.h (make_pure_string): Fix prototype.
62 (build_pure_c_string): New function, defined as static inline. This
63 provides a better opportunity to optimize away calls to strlen when
64 the function is called with compile-time constant argument.
65 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
66 argument, adjust users accordingly. Use build_pure_c_string where
68 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
69 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
70 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
72 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
74 Avoid calls to strlen in miscellaneous functions.
75 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
76 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
77 * lread.c (openp): Likewise.
79 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
81 Avoid calls to strlen in path processing functions.
82 * fileio.c (file_name_as_directory): Add comment. Change to add
83 srclen argument and return the length of result. Adjust users
85 (directory_file_name): Fix comment. Change to add srclen argument,
86 swap 1st and 2nd arguments to obey the common convention. Adjust
88 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
90 2012-07-10 Glenn Morris <rgm@gnu.org>
92 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
93 Move PENDING_OUTPUT_COUNT definition to configure.
95 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
96 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
97 * s/gnu.h (DATA_START): Move definitions to configure.
99 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
100 We include usg5-4-common.h, which defines them both.
102 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
103 O_RDONLY already includes it).
105 Stop ns builds setting the EMACSLOADPATH environment variable.
106 * nsterm.m (ns_load_path): Rename from ns_init_paths.
107 Now it does not set EMACSLOADPATH, just returns the load-path string.
108 * nsterm.h: Update accordingly.
109 * lread.c [HAVE_NS]: Include nsterm.h.
110 (init_lread) [HAVE_NS]: Use ns_load_path.
111 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
113 2012-07-09 Glenn Morris <rgm@gnu.org>
115 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
116 since the included bsd-common.h does so.
118 Stop ns builds setting the EMACSPATH environment variable.
119 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
120 (ns_init_paths): Do not set EMACSPATH.
121 * nsterm.h (ns_exec_path): Add it.
122 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
125 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
127 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
129 * process.c (wait_reading_process_output): 'waitchannels' was unset
130 when read_kbd || !NILP (wait_for_cell); fix this.
132 Add GCC-style 'const' attribute to functions that can use it.
133 * character.h (char_resolve_modifier_mask):
134 * keyboard.h (make_ctrl_char):
135 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
136 (init_character_once, next_almost_prime, init_fns, init_image)
137 (flush_pending_output, init_sound):
138 * mem-limits.h (start_of_data):
139 * menu.h (finish_menu_items):
141 * emacs.c (DEFINE_DUMMY_FUNCTION):
142 Declare the dummy function with ATTRIBUTE_CONST.
143 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
144 Add decls with ATTRIBUTE_CONST.
146 Minor improvements to make_formatted_string.
147 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
148 where int is good enough, as vsprintf returns an int.
149 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
151 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
153 Use make_formatted_string to avoid double length calculation.
154 * lisp.h (make_formatted_string): New prototype.
155 * alloc.c (make_formatted_string): New function.
156 * buffer.c (Fgenerate_new_buffer_name): Use it.
157 * dbus.c (syms_of_dbusbind): Likewise.
158 * editfns.c (Fcurrent_time_zone): Likewise.
159 * filelock.c (get_boot_time): Likewise.
160 * frame.c (make_terminal_frame, set_term_frame_name)
161 (x_report_frame_params): Likewise.
162 * image.c (gs_load): Likewise.
163 * minibuf.c (get_minibuffer): Likewise.
164 * msdos.c (dos_set_window_size): Likewise.
165 * process.c (make_process): Likewise.
166 * xdisp.c (ensure_echo_area_buffers): Likewise.
167 * xsettings.c (apply_xft_settings): Likewise.
169 2012-07-09 Glenn Morris <rgm@gnu.org>
171 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
172 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
173 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
174 * nsterm.h (ns_etc_directory): Add it.
175 * callproc.c [HAVE_NS]: Include nsterm.h.
176 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
178 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
180 Move marker debugging code under MARKER_DEBUG.
181 * marker.c (MARKER_DEBUG): Move marker debugging code under
182 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
183 for bootstrap with --enable-checking (~3x slowdown reported
184 by Juanma Barranquero <lekktu@gmail.com>).
185 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
187 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
189 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
190 See <http://bugs.gnu.org/11825#29>.
192 2012-07-08 Eli Zaretskii <eliz@gnu.org>
194 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
195 has no font, use the frame's font. (Bug#11813)
196 (display_line): Add commentary about displaying truncation glyphs
198 (produce_special_glyphs): Move here from term.c.
200 * term.c (produce_special_glyphs): Move to xdisp.c.
202 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
205 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
207 * xdisp.c (display_line): Avoid warning about implicit declaration
210 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
212 * lisp.h: Remove empty conditional.
214 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
216 * lread.c (load_path_check): Now static.
218 Fix some minor --with-ns problems found by static checking.
219 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
220 (x_set_font) [!HAVE_X_WINDOWS]:
221 * image.c (xpm_load_image) [HAVE_NS]:
222 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
223 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
225 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
226 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
227 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
228 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
229 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
230 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
231 Fix pointer signedness problem.
232 * xfaces.c (FRAME_X_FONT_TABLE):
233 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
235 2012-07-07 Glenn Morris <rgm@gnu.org>
237 * lread.c (load_path_check): New function, split from init_lread.
238 (init_lread): Reorganize. Motivation:
239 If EMACSLOADPATH is set, check/warn about that rather than the
240 defaults, which we are not going to use. Hence we can remove
241 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
242 Don't warn if site-lisp directories are missing.
243 If not installed, start from a blank load-path, since
244 PATH_LOADSEARCH refers to the eventual installation directories.
246 2012-07-07 Eli Zaretskii <eliz@gnu.org>
248 Support truncation and continuation glyphs on GUI frames, when
249 fringes are disabled. (Bug#11832)
250 * xdisp.c (init_iterator): Get dimensions of truncation and
251 continuation glyphs even if on GUI frames. Adjust
252 it->last_visible_x on GUI frames when the left or right fringes,
254 (start_display, move_it_in_display_line_to): Handle the case of a
255 GUI frame without a fringe to display continuation or truncation
257 (insert_left_trunc_glyphs): Support GUI frames: make sure
258 truncation glyphs overwrite enough glyphs from the current line to
259 have sufficient space in pixels.
260 (display_line): Support truncation and continuation glyphs on GUI
261 frames. If some spare pixels are left on the line after inserting
262 the truncation glyphs, fill that space with a stretch glyph of a
263 suitably computed width.
265 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
266 produce_glyphs, to support GUI sessions.
268 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
270 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
272 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
274 Do not require float-time's arg to fit in time_t (Bug#11825).
275 This works better on hosts where time_t is unsigned, and where
276 float-time is applied to the (negative) difference between two times.
277 * editfns.c (decode_time_components): Last arg is now double *,
278 not int *, and means to store all the result as a double, without
279 worrying about whether the seconds part fits in time_t.
281 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
283 (Ffloat_time): Do not fail merely because the specified time falls
284 outside of time_t range.
286 2012-07-07 Glenn Morris <rgm@gnu.org>
288 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
289 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
290 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
292 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
294 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
297 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
299 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
301 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
302 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
303 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
304 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
305 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
306 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
308 * xfont.c (compare_font_names): Redo to omit the need for casts.
310 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
312 * xfns.c (Fx_change_window_property): Doc fix.
313 * w32fns.c (Fx_change_window_property): Doc fix.
315 * w32fns.c (Fx_window_property): Accept the same arguments as the
316 X Windows version. Doc fix.
317 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
319 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
320 Eli Zaretskii <eliz@gnu.org>
322 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
323 Windows-specific code from nt/config.nt moved here.
324 Obsolete settings removed.
326 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
328 * process.c: Avoid unnecessary calls to gettime.
329 (wait_reading_process_output): Don't get the time of day
330 when gobbling data immediately and not waiting, as there's no need
331 for it in that case. This removes a FIXME.
333 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
335 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
336 is defined (Bug#11768).
338 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
340 Fix marker debugging code.
341 * marker.c (byte_char_debug_check): Do not perform the check
342 if buffer is not multibyte.
343 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
344 Call byte_char_debug_check with correct arguments.
346 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
348 Compile marker debugging code only if ENABLE_CHECKING is defined.
349 * marker.c (byte_char_debug_check, count_markers):
350 Use only if ENABLE_CHECKING is defined.
351 (byte_debug_flag): Remove.
352 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
353 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
355 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
357 Avoid code repetition in marker-related functions.
358 * marker.c (attach_marker): New function.
359 (Fset_marker, set_marker_restricted, set_marker_both)
360 (set_marker_restricted_both): Use it.
361 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
362 Consistently rename charno to charpos.
363 (marker_position): Add eassert.
364 (marker_byte_position): Convert to eassert.
366 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
368 Simplify list operations in unchain_overlay and unchain_marker.
369 * buffer.c (unchain_overlay): Simplify. Add comment.
370 * marker.c (unchain_marker): Simplify. Fix comments.
372 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
374 Introduce fast path for the widely used marker operation.
375 * alloc.c (build_marker): New function.
376 * lisp.h (build_marker): New prototype.
377 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
378 * composite.c (autocmp_chars): Likewise.
379 * editfns.c (buildmark): Remove.
380 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
381 (save_restriction_save): Use build_marker.
382 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
383 * window.c (save_window_save): Likewise.
385 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
387 Do not use Fdelete_overlay in delete_all_overlays
388 to avoid redundant calls to unchain_overlay.
389 * buffer.c (drop_overlay): New function.
390 (delete_all_overlays, Fdelete_overlay): Use it.
391 * minibuf.c (get_minibuffer): Fix comment.
393 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
395 Port to OpenBSD 5.1 amd64.
396 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
397 This is needed for OpenBSD, and should be harmless on all BSD systems.
398 Also, include <sys/sysctl.h>, as it should be available on all
399 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
400 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
401 use p_pid member, not kp_proc.pid.
403 2012-07-06 Glenn Morris <rgm@gnu.org>
405 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
407 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
409 More xmalloc and related cleanup.
410 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
411 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
412 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
413 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
414 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
415 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
416 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
417 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
418 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
420 Omit needless casts involving void * pointers and allocation.
421 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
422 as the former is more robust if P's type is changed.
423 Prefer xzalloc to xmalloc + memset 0.
424 Simplify malloc-or-realloc to realloc.
425 Don't worry about xmalloc returning a null pointer.
426 Prefer xstrdup to xmalloc + strcpy.
427 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
429 * keyboard.c (apply_modifiers_uncached): Prefer local array to
430 alloca of a constant.
432 2012-07-05 Eli Zaretskii <eliz@gnu.org>
434 * xdisp.c (display_line): Fix horizontal pixel coordinates when
435 hscroll is larger than the line width. Fixes long and futile
436 looping inside extend_face_to_end_of_line (on a TTY) producing
437 glyphs that are not needed and thrown away.
439 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
441 * marker.c (set_marker_restricted_both): Simplify by using
444 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
446 * editfns.c (region_limit): Simplify by using clip_to_bounds.
448 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
450 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
451 not defined (Bug#11768).
452 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
453 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
454 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
455 followed by gtk_box_set_homogeneous (Bug#11768).
456 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
457 (update_theme_scrollbar_width, xg_create_scroll_bar):
458 Use gtk_scrollbar_new (Bug#11768).
459 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
460 (is_box_type): New function (Bug#11768).
461 (xg_tool_item_stale_p): Call is_box_type.
462 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
463 with default display (Bug#11768).
465 2012-07-05 Eli Zaretskii <eliz@gnu.org>
467 * xdisp.c (window_hscroll_limited): New function.
468 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
469 coordinates when window's hscroll is set to insanely large
472 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
474 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
475 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
477 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
480 * lisp.h (xzalloc): New prototype. Omit needless casts.
481 * alloc.c (xzalloc): New function. Omit needless casts.
482 * charset.c: Omit needless casts. Convert all calls to
483 xmalloc with following memset to xzalloc.
484 * dispnew.c: Likewise.
485 * fringe.c: Likewise.
489 * w32fns.c: Likewise.
490 * w32font.c: Likewise.
491 * w32term.c: Likewise.
492 * xfaces.c: Likewise.
495 * atimer.c: Omit needless casts.
496 * buffer.c: Likewise.
497 * callproc.c: Likewise.
499 * coding.c: Likewise.
500 * composite.c: Likewise.
502 * doprnt.c: Likewise.
503 * editfns.c: Likewise.
506 * filelock.c: Likewise.
508 * gtkutil.c: Likewise.
509 * keyboard.c: Likewise.
512 * minibuf.c: Likewise.
515 * process.c: Likewise.
516 * region-cache.c: Likewise.
517 * search.c: Likewise.
518 * sysdep.c: Likewise.
519 * termcap.c: Likewise.
520 * terminal.c: Likewise.
521 * tparam.c: Likewise.
522 * w16select.c: Likewise.
524 * w32reg.c: Likewise.
525 * w32select.c: Likewise.
526 * w32uniscribe.c: Likewise.
527 * widget.c: Likewise.
531 * xselect.c: Likewise.
533 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
535 * fileio.c (time_error_value): Check the right error number.
536 Problem reported by Troels Nielsen in
537 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
539 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
541 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
542 This should be fixed in a better way; see Eli Zaretskii in
543 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
544 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
546 * fileio.c (time_error_value): Rename from special_mtime.
547 The old name's problems were noted by Eli Zaretskii in
548 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
550 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
551 This variable's comment says Emacs needs at least one GDB-visible
552 symbol of type enum pvec_type, to work around GDB problems.
553 The symbol's value doesn't matter.
555 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
556 that causes compilation to fail on pre-C99 compilers.
558 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
560 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
561 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
563 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
565 * buffer.c (init_buffer_once): Fix initialization of
566 headers for buffer_defaults and buffer_local_symbols.
567 Reported by Juanma Barranquero <lekktu@gmail.com>.
569 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
571 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
572 * lisp.h (enum pvec_type): Use fewer bits.
573 (PSEUDOVECTOR_SIZE_BITS): New constant.
574 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
575 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
577 (PSEUDOVECTOR_TYPEP): New macro.
578 (TYPED_PSEUDOVECTORP): Use it.
579 * fns.c (internal_equal): Adapt code to extract pvectype.
580 * emacs.c (gdb_pvec_type): Update type.
581 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
582 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
583 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
584 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
585 (sweep_vectors): Use it. Use local var `total_bytes' instead of
586 abusing vector->header.next.nbytes.
587 (live_vector_p): Use PVEC_TYPE.
588 (mark_object): Adapt code to extract pvectype. Use switch.
590 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
592 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
593 Tighten new eassert a bit.
595 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
597 Fix compilation with --enable-gcc-warnings and -O1
599 * doprnt.c (doprnt): Change type of tem to int, initialize
600 to avoid compiler warning. Add eassert.
601 * search.c (simple_search): Initialize match_byte to avoid
602 compiler warning. Add eassert.
604 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
606 Avoid weird behavior with large horizontal scrolls.
607 Without this change, for example, large hscroll values would
608 mess up Emacs's display on Fedora 15 x86, presumably due to
609 overflows in int calculations in the display code.
610 Also, if buffers had long lines, Emacs would freeze.
611 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
612 (set_window_hscroll): New function, containing the old guts of
613 Fset_window_hscroll. Return the clipped value.
614 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
615 This avoids the need to check against PTRDIFF_MAX.
617 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
619 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
621 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
623 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
625 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
626 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
627 since GCC 4.4.6 issues a bogus warning for them.
629 Fix bugs in file timestamp newness comparisons.
630 * fileio.c (Ffile_newer_than_file_p):
631 * lread.c (Fload): Use full timestamp resolution of files,
632 not just the 1-second resolution, so that files that are only
633 slightly newer still count as newer.
634 * fileio.c (Ffile_newer_than_file_p): Don't assume file
635 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
637 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
639 * fileio.c: Improve handling of file time marker. (Bug#11852)
640 (special_mtime): New function.
641 (Finsert_file_contents, Fverify_visited_file_modtime):
642 Use it to set special mtime values consistently.
644 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
646 * fileio.c (Finsert_file_contents): Properly handle st_mtime
647 marker for non-existing file. (Bug#11852)
649 2012-07-03 Glenn Morris <rgm@gnu.org>
651 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
652 and did not make it into globals.h).
654 2012-07-03 Tom Tromey <tromey@redhat.com>
656 * window.c (Fset_window_margins, Fset_window_fringes)
657 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
658 * textprop.c (Fprevious_property_change): No longer static.
659 * syntax.c (Fsyntax_table_p): No longer static.
660 * process.c (Fget_process, Fprocess_datagram_address): No longer
662 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
663 * keyboard.c (Fcommand_execute): No longer static.
665 * insdel.c (Fcombine_after_change_execute): No longer static.
666 * image.c (Finit_image_library): No longer static.
667 * fileio.c (Fmake_symbolic_link): No longer static.
668 * eval.c (Ffetch_bytecode): No longer static.
669 * editfns.c (Fuser_full_name): No longer static.
670 * doc.c (Fdocumentation_property, Fsnarf_documentation):
672 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
674 * dired.c (Ffile_attributes): No longer static.
675 * composite.c (Fcomposition_get_gstring): No longer static.
676 * callproc.c (Fgetenv_internal): No longer static.
678 * ccl.h: Remove EXFUNs.
679 * buffer.h: Remove EXFUNs.
680 * dispextern.h: Remove EXFUNs.
681 * intervals.h: Remove EXFUNs.
682 * fontset.h: Remove EXFUN.
683 * font.h: Remove EXFUNs.
684 * dosfns.c (system_process_attributes): Remove EXFUN.
685 * keymap.h: Remove EXFUNs.
686 * lisp.h: Remove EXFUNs.
687 * w32term.h: Remove EXFUNs.
688 * window.h: Remove EXFUNs.
689 * xsettings.h: Remove EXFUN.
690 * xterm.h: Remove EXFUN.
692 2012-07-03 Glenn Morris <rgm@gnu.org>
694 * lisp.h (Frandom): Make it visible to C.
695 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
696 buffer for invisible buffers. (Bug#1229)
698 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
700 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
701 values which aren't power of 2.
702 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
703 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
706 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
708 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
710 * alloc.c (mark_object): Revert part of last patch to use `switch'.
712 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
714 * alloc.c (allocate_vector_block): Remove redundant
715 calls to mallopt if DOUG_LEA_MALLOC is defined.
716 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
717 avoid calls to mallopt if zero_vector is returned.
719 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
721 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
722 is enabled, avoid dereferencing NULL current_sblock if
725 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
727 Cleanup basic buffer management.
728 * buffer.h (struct buffer): Change layout to use generic vector
729 marking code. Fix some comments. Change type of 'clip_changed'
730 to bitfield. Remove unused #ifndef old.
731 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
732 (GET_OVERLAYS_AT): Fix indentation.
733 (for_each_per_buffer_object_at): New macro.
734 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
735 (Fbuffer_local_variables): Use it.
736 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
737 * alloc.c (allocate_buffer): Adjust to match new layout of
738 struct buffer. Fix comment.
739 (mark_overlay): New function.
740 (mark_buffer): Use it. Use mark_vectorlike to mark normal
741 Lisp area of struct buffer.
742 (mark_object): Use it. Adjust marking of misc objects
743 and related comments.
745 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
747 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
748 wrapper that is not needed because the wrapped code is a no-op (zero
749 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
750 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
752 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
754 * alloc.c (mark_buffer): Simplify. Remove prototype.
755 (mark_object): Add comment. Reorganize marking of vector-like
756 objects. Use CHECK_LIVE for all vector-like objects except buffers
757 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
758 redundant calls to mark_vectorlike for bool vectors.
760 2012-06-30 Glenn Morris <rgm@gnu.org>
762 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
764 * epaths.in (PATH_SITELOADSEARCH): New.
765 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
766 This is rather than relying on --enable-locallisppath elements
767 having "site-lisp" in their names. (Bug#10208#25, 11658)
769 2012-06-30 Eli Zaretskii <eliz@gnu.org>
771 * w32proc.c (sys_select): Accept and ignore one more argument.
773 * w32.c (emacs_gnutls_pull): Call select with one more argument.
775 * sysselect.h [DOS_NT]: Don't include sys/select.h.
776 (pselect) [!MS_DOS]: Redirect to sys_select.
778 * sysdep.c: Don't include dos.h and dosfns.h.
780 * process.c (sys_select):
781 * msdos.c (sys_select): Accept one more argument and ignore it.
783 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
784 adapt data types and code to that.
787 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
788 which clashes with the gnulib function of the same name.
790 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
792 * font.c (font_style_to_value, font_style_symbolic)
793 (font_prop_validate_style): Add type checks for values in
796 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
798 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
801 2012-06-29 Eli Zaretskii <eliz@gnu.org>
803 * xdisp.c (try_window_id): Undo last change.
805 * w32.c (getwd): Adjust commentary about startup_dir.
806 (init_environment): Always call sys_access, even in non-MSVC
807 builds. Don't chdir to the directory of the Emacs executable.
808 This undoes code from 1997 which was justified by the need to
809 "avoid conflicts when removing and renaming directories". But its
810 downside was that every relative file name was being interpreted
811 relative to the directory of the Emacs executable, which can never
812 be TRT. In particular, it broke sys_access when called with
814 (sys_access): Map GetLastError to errno.
816 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
818 * window.h (struct window): Change type of 'fringes_outside_margins'
819 to bitfield. Fix comment. Adjust users accordingly.
820 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
822 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
825 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
827 * gnutls.c (emacs_gnutls_handshake):
828 Add QUIT to make the loop interruptible.
830 2012-06-29 Glenn Morris <rgm@gnu.org>
832 * charset.c (init_charset): Make lack of etc/charsets fatal.
834 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
836 * editfns.c (region_limit): Fix type mismatch.
838 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
840 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
841 undefined. Convert from xassert to eassert.
842 * nsmenu.m: Convert from xassert to eassert.
843 * nsterm.m: Likewise.
845 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
847 * editfns.c (region_limit): Clip to narrowing (bug#11770).
849 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
851 Avoid integer overflow on scroll-left and scroll-right.
852 * window.c (HSCROLL_MAX): New macro.
853 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
854 overflow when requested scroll falls outside ptrdiff_t range.
856 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
858 * window.h (struct window): Change type of 'hscroll',
859 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
860 'last_modified' and 'last_overlay_modified' to EMACS_INT.
861 Adjust users accordingly.
862 * xdisp.c (try_cursor_movement): Replace type check with eassert.
863 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
864 from EMACS_INT to ptrdiff_t.
865 (make_window): Omit redundant initialization.
867 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
869 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
871 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
873 * window.h (struct window): Change type of 'use_time' and
874 'sequence_number' from Lisp_Object to int.
875 * frame.c (make_frame): Adjust users accordingly.
876 * print.c (print_object): Likewise.
877 * window.c (select_window, Fwindow_use_time, make_parent_window)
878 (make_window): Likewise.
880 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
882 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
883 enabled with --enable-checking=[all,glyphs] configure option.
884 Fix GLYPH_DEBUG usage assuming that it may be undefined,
885 adjust comments accordingly.
886 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
887 undefined, adjust comments accordingly.
889 * scroll.c: Likewise.
890 * w32fns.c: Likewise.
891 * w32term.c: Likewise.
893 * xfaces.c: Likewise.
897 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
899 Generalize run-time debugging checks.
900 * dispextern.h (XASSERTS): Remove.
901 * fontset.c (xassert): Remove.
902 Convert from xassert to eassert.
903 * alloc.c: Convert from xassert to eassert.
905 * dispnew.c: Likewise.
907 * fringe.c: Likewise.
908 * ftfont.c: Likewise.
909 * gtkutil.c: Likewise.
911 * keyboard.c: Likewise.
913 * process.c: Likewise.
914 * scroll.c: Likewise.
917 * w32console.c: Likewise.
918 * w32fns.c: Likewise.
919 * w32term.c: Likewise.
920 * window.c: Likewise.
922 * xfaces.c: Likewise.
924 * xselect.c: Likewise.
927 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
929 * fns.c (maybe_resize_hash_table): Output message when growing the
932 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
934 * alloc.c (allocate_string_data): Remove dead code.
935 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
936 avoid GCC warning about unused macro.
938 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
940 * alloc.c (allocate_string): Omit intervals initialization.
941 * alloc.c (make_uninit_multibyte_string): Initialize intervals
942 as in make_pure_string and make_pure_c_string.
944 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
946 * alloc.c (allocate_string): Fix last change.
948 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
950 * alloc.c (allocate_string): Remove two redundant calls
951 to memset, add explicit initialization where appropriate.
953 2012-06-27 Glenn Morris <rgm@gnu.org>
955 * lisp.mk (lisp): Remove paths.elc.
957 2012-06-27 Chong Yidong <cyd@gnu.org>
959 * doc.c (Fsubstitute_command_keys): Fix punctuation.
961 2012-06-26 John Wiegley <johnw@newartisans.com>
963 * unexmacosx.c (copy_data_segment): Add two section names used
964 on Mac OS X Lion: __mod_init_func and __mod_term_func.
966 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
967 when building with Clang.
969 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
971 * eval.c (Fapply): Allow calling it with a single argument.
973 2012-06-26 Eli Zaretskii <eliz@gnu.org>
975 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
976 _stricmp and _strnicmp.
977 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
979 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
981 * alloc.c (allocate_window): Zero out non-Lisp part of newly
983 (allocate_process): Likewise for new process.
984 (allocate_terminal): Change to use offsetof.
985 (allocate_frame): Likewise.
986 * frame.c (make_frame): Omit redundant initialization.
987 * window.c (make_parent_window): Use memset.
988 (make_window): Omit redundant initialization.
989 * process.c (make_process): Omit redundant initialization.
990 * terminal.c (create_terminal): Likewise.
992 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
994 * term.c (delete_tty): Remove redundant call to memset.
996 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
998 * alloc.c: Remove build_string.
999 * lisp.h: Define build_string as static inline. This provides
1000 a better opportunity to optimize away calls to strlen when the
1001 function is called with compile-time constant argument.
1002 * image.c (imagemagick_error): Convert to build_string.
1003 * w32proc.c (sys_spawnve): Likewise.
1004 * xterm.c (x_term_init): Likewise.
1006 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1008 Use sprintf return value instead of invoking strlen on result.
1009 In the old days this wasn't portable, since some sprintf
1010 implementations returned char *. But they died out years ago and
1011 Emacs already assumes sprintf returns int.
1012 Similarly for float_to_string.
1013 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1014 * ccl.c (ccl_driver):
1015 * character.c (string_escape_byte8):
1016 * data.c (Fnumber_to_string):
1017 * doprnt.c (doprnt):
1018 * print.c (print_object):
1019 * xdisp.c (message_dolog):
1020 * xfns.c (syms_of_xfns):
1021 Use sprintf or float_to_string result to avoid need to call strlen.
1022 * data.c (Fnumber_to_string):
1023 Use make_unibyte_string, since the string must be ASCII.
1024 * lisp.h, print.c (float_to_string): Now returns int length.
1025 * term.c (produce_glyphless_glyph):
1026 Use sprintf result rather than recomputing it.
1028 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1029 * Makefile.in (ALL_CFLAGS):
1030 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1031 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1033 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1035 * dispextern.h (xstrcasecmp): Define to library function
1036 strcasecmp if available.
1037 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1039 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1041 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1042 Avoid comma operator.
1043 * menu.c (push_submenu_start, push_submenu_end)
1044 (push_left_right_boundary, push_menu_pane): Likewise.
1045 * msdos.c (dos_rawgetc): Likewise.
1047 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1049 * xfns.c (xic_create_fontsetname): Remove redundant calls
1052 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1054 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1055 sprintf already null-terminates its output.
1057 * xfns.c (x_window): Remove redundant cast.
1059 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1061 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1062 `const char *' to `char *' to avoid compiler warning.
1064 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1066 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1067 instead of truncating it to 63 (admittedly a generous limit).
1069 * process.c: Fix spelling and caps in comments.
1071 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1073 * emacs.c (setpgrp): Remove definition, unused.
1074 * sysdep.c (setpgrp): Remove definition, not used in this file.
1076 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
1078 * makefile.w32-in: Update dependencies.
1080 2012-06-24 Eli Zaretskii <eliz@gnu.org>
1082 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1083 (SYSTIME_H): Add nt/inc/sys/time.h.
1085 * systime.h [WINDOWSNT]: Include sys/time.h.
1087 * s/ms-w32.h (struct timespec): Definition moved from
1088 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1090 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1092 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1093 * buffer.h (buffer_slot_type_mismatch):
1094 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1095 * eval.c (unwind_to_catch):
1096 * image.c (my_png_error, my_error_exit):
1097 * keyboard.c (quit_throw_to_read_char, user_error)
1098 (Fexit_recursive_edit, Fabort_recursive_edit):
1099 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1100 (wrong_type_argument, buffer_overflow, __executable_start)
1101 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1102 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1103 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1105 (child_setup) [!DOS_NT]:
1106 * lread.c (end_of_file_error, invalid_syntax):
1107 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1108 * puresize.h (pure_write_error):
1109 * search.c (matcher_overflow):
1110 * sound.c (sound_perror, alsa_sound_perror):
1111 * sysdep.c, syssignal.h (croak):
1112 * term.c (maybe_fatal, vfatal):
1113 * textprop.c (text_read_only):
1114 * undo.c (user_error):
1115 * unexmacosx.c (unexec_error):
1116 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1117 Use _Noreturn rather than NO_RETURN.
1118 No need for separate decl merely because of _Noreturn.
1119 * sound.c (sound_warning, parse_sound):
1120 Remove unnecessary forward decls.
1122 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1124 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1125 * lisp.h (WAIT_READING_MAX): New macro.
1126 * dispnew.c (Fsleep_for, sit_for):
1127 * keyboard.c (kbd_buffer_get_event):
1128 * process.c (Faccept_process_output):
1129 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1130 This improves on the previous patch, which introduced a bug
1131 when time_t is unsigned and as wide as intmax_t.
1132 See <http://bugs.gnu.org/9000#51>.
1134 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1136 * dispnew.c (sit_for, Fsleep_for):
1137 * keyboard.c (kbd_buffer_get_event):
1138 * process.c (Faccept_process_output): Avoid compiler warnings when
1139 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1141 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
1143 * makefile.w32-in: Update dependencies.
1145 * w32.c (ltime): Add return type and declare static.
1146 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1148 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1150 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1151 Privately reported by Herbert J. Skuhra.
1152 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1154 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1155 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1157 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1159 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1160 last argument of make_unibyte_string.
1162 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1163 language ID in the event parameters.
1165 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1166 event.code, not the obscure "character set ID".
1168 2012-06-23 Chong Yidong <cyd@gnu.org>
1170 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1172 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1174 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1175 * w32.c (fdutimens): New function.
1177 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1179 * s/ms-w32.h (pselect): Redirect to sys_select.
1181 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1183 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1184 in the logic of incrementing and decrementing the value of
1185 use_relocatable_buffers.
1187 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1189 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1190 Privately reported by Herbert J. Skuhra.
1191 [__FreeBSD__]: Remove "*/" typo after "#include".
1192 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1193 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1194 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1195 Don't assume EMACS_TIME and struct timeval are the same type.
1197 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1199 Support higher-resolution time stamps (Bug#9000).
1200 The time stamps are only nanosecond-resolution at the C level,
1201 since that's the best that any real-world system supports now.
1202 But they are picosecond-resolution at the Lisp level, as that's
1203 easy, and leaves room for future OS improvements.
1205 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1208 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1209 Don't get current time unless it's needed.
1211 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1212 now provides it if it's absent.
1213 (start_atimer): Port to higher-res time stamps.
1214 Check for time stamp overflow. Don't get current time more
1215 often than is needed.
1217 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1218 Include systime.h, not time.h.
1219 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1221 * dired.c: Include stat-time.h.
1222 (Ffile-attributes): File times now have higher resolution.
1224 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1225 (struct image): Timestamp now has higher resolution.
1227 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1228 has at least microseconds now. All uses removed.
1229 (update_frame, update_single_window, update_window, update_frame_1)
1230 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1232 * editfns.c (time_overflow): Now extern.
1233 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1234 (float-time, Fformat_time_string, Fcurrent_time_string)
1235 (Fcurrent_time_zone): Accept and generate higher-resolution
1237 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1238 (decode_time_components, lisp_seconds_argument): New functions.
1239 (make_time): Now static.
1240 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1241 Report an error if the time is invalid, rather than having the caller
1244 * fileio.c: Include <stat-time.h>
1245 (Fcopy_file): Copy higher-resolution time stamps.
1246 Prefer to set the time stamp via a file descriptor if that works.
1247 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1248 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1249 (Fvisited_file_modtime, Fset_visited_file_modtime):
1250 Support higher-resolution time stamps.
1252 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1254 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1256 * image.c (prepare_image_for_display, clear_image_cache)
1257 (lookup_image): Port to higer-resolution time stamps.
1259 * keyboard.c (start_polling, bind_polling_period):
1260 Check for time stamp overflow.
1261 (read_char, kbd_buffer_get_event, timer_start_idle)
1262 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1263 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1264 Port to higher-resolution time stamps. Do not assume time_t is signed.
1265 (decode_timer): New function. Timers are now vectors of length 9,
1266 not 8, to accommodate the picosecond component.
1267 (timer_check_2): Use it.
1269 * nsterm.m (select_timeout, timeval_subtract): Remove.
1270 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1271 as they're a bit more accurate and handle overflow better.
1272 (ns_select): Change prototype to be compatible with pselect.
1273 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1274 * nsterm.h (ns_select): Adjust prototype.
1276 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1277 us-resolution time stamps.
1278 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1280 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1282 * lisp.h (time_overflow): New decl.
1283 (wait_reading_process_output): First arg is now intmax_t, not int,
1284 to accommodate larger waits.
1286 * process.h (struct Lisp_Process.read_output_delay):
1287 Now counts nanoseconds, not microseconds.
1288 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1290 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1291 (wait_reading_process_output):
1292 Port to ns-resolution time stamps.
1293 (Faccept_process_output, wait_reading_process_output):
1294 Check for time stamp overflow. Do not assume time_t is signed.
1295 (select_wrapper): Remove; we now use pselect.
1296 (Fprocess_attributes): Now generates ns-resolution time stamps.
1298 * sysdep.c: Include utimens.h. Don't include utime.h
1299 or worry about struct utimbuf; gnulib does that for us now.
1300 (gettimeofday): Remove; gnulib provides a substitute.
1301 (make_timeval): New function.
1302 (set_file_times): Now sets ns-resolution time stamps.
1303 New arg FD; all uses changed.
1304 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1305 (system_process_attributes):
1306 Now returns ns-resolution time stamp. All uses changed.
1307 Check for time stamp overflow.
1309 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1310 provides a substitute now.
1312 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1313 since it guarantees struct timespec.
1314 (EMACS_TIME): Now struct timespec, so that we can support
1315 ns-resolution time stamps.
1316 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1317 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1318 (EMACS_USECS): Remove.
1319 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1320 so multiply the arg by 1000 before storing it.
1321 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1323 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1324 Port to ns-resolution time stamps.
1325 (EMACS_TIME_NEG_P): Remove; replaced by....
1326 (EMACS_TIME_SIGN): New macro.
1327 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1328 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1329 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1330 (make_timeval, make_lisp_time, decode_time_components): New decls.
1331 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1332 that it mishandled time_t overflow. You can't compare by subtracting!
1333 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1334 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1336 * term.c: Include <sys/time.h>.
1337 (timeval_to_Time): New function, for proper overflow wraparound.
1338 (term_mouse_position, term_mouse_click): Use it.
1340 * undo.c (record_first_change): Support higher-resolution time stamps
1342 (Fprimitive_undo): Use them when restoring time stamps.
1344 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1345 (w32_get_internal_run_time):
1346 Port to higher-resolution Emacs time stamps.
1347 (ltime): Now accepts single 64-bit integer, as that's more convenient
1350 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1352 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1353 for compatibility with pselect. Support ns-resolution time stamps.
1355 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1357 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1358 Check for time stamp overflow, and support ns-resolution time stamps.
1360 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1361 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1362 (timeval_subtract): Remove; no longer needed.
1363 (XTflash, XTring_bell, x_wait_for_event):
1364 Port to ns-resolution time stamps. Don't assume time_t is signed.
1366 2012-06-22 Chong Yidong <cyd@gnu.org>
1368 * xdisp.c (x_consider_frame_title): Revert last change.
1370 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1372 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1373 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1374 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1375 staticidx goes up to 1597 out of 1600 = 0x640.)
1377 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1379 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1380 Otherwise, the umask might be mistakenly 0 while handling input signals.
1382 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1384 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1386 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1388 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1389 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1390 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1391 access to `contents' member of Lisp_Vector objects with AREF and ASET
1394 2012-06-19 Chong Yidong <cyd@gnu.org>
1396 * frame.c (delete_frame): When selecting a frame on a different
1397 text terminal, do not alter the terminal's top-frame.
1399 * xdisp.c (format_mode_line_unwind_data): Record the target
1400 frame's selected window and its terminal's top-frame.
1401 (unwind_format_mode_line): Restore them.
1402 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1404 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1405 since tty frames can be explicitly named.
1406 (prepare_menu_bars): Likewise.
1408 * term.c (Ftty_top_frame): New function.
1410 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1412 Port byte-code-meter to modern targets.
1413 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1414 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
1415 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
1416 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1417 (METER_1, METER_2): Simplify.
1419 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1421 * data.c (Fdefalias): Return `symbol' (bug#11686).
1423 2012-06-18 Martin Rudalics <rudalics@gmx.at>
1425 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1426 gets killed during executing of this function (Bug#11665).
1427 Try to always return Qt when the buffer has been actually killed.
1428 (Vkill_buffer_query_functions): In doc-string say that functions
1429 run by this hook should not change the current buffer.
1431 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1433 Fix recently-introduced process.c problems found by static checking.
1434 * process.c (write_queue_push, write_queue_pop, send_process):
1435 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1436 (write_queue_pop): Fix pointer signedness problem.
1437 (send_process): Remove unused local.
1439 2012-06-17 Chong Yidong <cyd@gnu.org>
1441 * xdisp.c (redisplay_internal): No need to redisplay terminal
1442 frames that are not on top.
1444 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1446 * process.c (make_process): Initialize write_queue.
1447 (write_queue_push, write_queue_pop): New functions.
1448 (send_process): Use them to maintain correct ordering of process
1451 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1453 * lisp.h (eassert): Assume C89 or later.
1454 This removes the need for CHECK.
1455 (CHECK): Remove. Its comments about always evaluating its
1456 argument were confusing, as 'eassert' typically does not evaluate
1459 * coding.c (produce_chars): Use ptrdiff_t, not int.
1461 * xterm.c (x_draw_underwave): Check for integer overflow.
1462 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1464 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
1466 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1467 referenced (Bug#11583).
1469 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1471 Implement wave-style variant of underlining.
1472 * dispextern.h (face_underline_type): New enum.
1473 (face): Add field for underline type.
1474 * nsterm.m (ns_draw_underwave): New function.
1475 (ns_draw_text_decoration): Use it.
1476 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1478 (x_draw_glyph_string): Use them.
1479 * xfaces.c (Qline, Qwave): New Lisp objects.
1480 (check_lface_attrs, merge_face_ref)
1481 (Finternal_set_lisp_face_attribute, realize_x_face):
1482 Handle wave-style underline face attributes.
1483 * xterm.c (x_draw_underwave): New function.
1484 (x_draw_glyph_string): Use it.
1486 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
1488 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1489 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1490 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1491 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1492 ($(BLD)/w32select.$(O)): Update dependencies.
1494 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1496 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1497 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1498 * character.c (_fetch_multibyte_char_p): Remove.
1499 * alloc.c: Include "character.h" before "buffer.h".
1501 * buffer.c: Likewise.
1502 * bytecode.c: Likewise.
1503 * callint.c: Likewise.
1504 * callproc.c: Likewise.
1505 * casefiddle.c: Likewise.
1506 * casetab.c: Likewise.
1507 * category.c: Likewise.
1509 * coding.c: Likewise.
1510 * composite.c: Likewise.
1511 * dired.c: Likewise.
1512 * dispnew.c: Likewise.
1514 * dosfns.c: Likewise.
1515 * editfns.c: Likewise.
1516 * emacs.c: Likewise.
1517 * fileio.c: Likewise.
1518 * filelock.c: Likewise.
1520 * fontset.c: Likewise.
1521 * fringe.c: Likewise.
1522 * indent.c: Likewise.
1523 * insdel.c: Likewise.
1524 * intervals.c: Likewise.
1525 * keyboard.c: Likewise.
1526 * keymap.c: Likewise.
1527 * lread.c: Likewise.
1528 * macros.c: Likewise.
1529 * marker.c: Likewise.
1530 * minibuf.c: Likewise.
1531 * nsfns.m: Likewise.
1532 * nsmenu.m: Likewise.
1533 * print.c: Likewise.
1534 * process.c: Likewise.
1535 * regex.c: Likewise.
1536 * region-cache.c: Likewise.
1537 * search.c: Likewise.
1538 * syntax.c: Likewise.
1540 * textprop.c: Likewise.
1542 * unexsol.c: Likewise.
1543 * w16select.c: Likewise.
1544 * w32fns.c: Likewise.
1545 * w32menu.c: Likewise.
1546 * window.c: Likewise.
1547 * xdisp.c: Likewise.
1549 * xmenu.c: Likewise.
1551 * xselect.c: Likewise.
1553 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1555 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1556 If all the glyphs of the glyph row came from strings, and we have no
1557 cursor positioning clues, put the cursor on the first glyph of the
1559 (handle_face_prop): Use chunk-relative overlay string index when
1560 indexing into it->string_overlays array. (Bug#11653)
1561 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1562 the rightmost. (Bug#11720)
1564 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1566 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1567 (CATEGORY_MEMBER): Enforce 1/0 value.
1568 * category.c (_temp_category_set): Remove.
1570 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1572 * window.c (Fdelete_other_windows_internal)
1573 (Fdelete_window_internal): Don't access frame's mouse highlight
1574 info of the initial frame. (Bug#11677)
1576 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1578 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1579 Assume USE_2_TAGS_FOR_INTS.
1580 (xreload): Adjust $tagmask width to match recent lisp.h change.
1582 Simplify lisp.h in minor ways that should not affect code.
1583 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1584 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1585 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1586 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1587 (INTTYPEBITS): New macro, for clarity.
1588 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1589 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1590 Simplify now that USE_LSB_TAG is always defined.
1591 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1592 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1594 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
1596 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1598 2012-06-13 Glenn Morris <rgm@gnu.org>
1600 * s/bsd-common.h (BSD4_3):
1601 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1603 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1605 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1608 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1610 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
1611 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1612 * alloc.c (widen_to_Lisp_Object): Remove.
1613 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1614 * frame.c (delete_frame): Remove outdated comment.
1615 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1616 USE_LISP_UNION_TYPE.
1617 (Fw32_unregister_hot_key): Likewise.
1618 (Fw32_toggle_lock_key): Likewise.
1619 * w32menu.c (add_menu_item): Likewise.
1620 (w32_menu_display_help): Use XIL instead of checking
1621 USE_LISP_UNION_TYPE.
1622 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1623 (init_heap): Likewise.
1624 * w32term.c (w32_read_socket): Update comment.
1626 2012-06-13 Glenn Morris <rgm@gnu.org>
1628 * s/usg5-4-common.h, src/s/unixware.h:
1629 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1631 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1633 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1635 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1636 * alloc.c (make_number) [!defined make_number]:
1637 Remove, as lisp.h always defines this now.
1638 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1639 (roundup_size): Verify that it is a power of 2.
1640 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1641 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1642 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1643 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1644 USE_LSB_TAG now is always defined to be either 0 or 1.
1646 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1647 code works fine either way, and efficiency is not a concern here,
1648 as the union type is for debugging, not for production.
1649 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1650 Use an inline function on all platforms when using the union type,
1651 since this is simpler and 'static inline' can be used portably
1653 (LISP_INITIALLY_ZERO): New macro.
1654 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1655 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1657 2012-06-12 Glenn Morris <rgm@gnu.org>
1659 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1661 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
1663 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1664 Move BROKEN_SIGIO to configure.
1666 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1667 Move NO_TERMIO to configure.
1669 2012-06-12 Chong Yidong <cyd@gnu.org>
1671 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1672 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1673 MagickExportImagePixels is undefined.
1675 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1677 * image.c (imagemagick_load_image): Remove unused label.
1679 2012-06-11 Glenn Morris <rgm@gnu.org>
1681 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1682 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1683 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1684 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1686 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1688 * alloc.c (make_byte_code): New function.
1689 (Fmake_byte_code): Use it. Don't purify here.
1690 * lread.c (read1): Use it as well to avoid extra allocation.
1692 2012-06-11 Chong Yidong <cyd@gnu.org>
1694 * image.c (imagemagick_load_image): Implement transparency.
1696 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1698 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1699 account for preceding backslashes. (Bug#11663)
1701 2012-06-09 Chong Yidong <cyd@gnu.org>
1703 * term.c: Support italics in capable terminals (Bug#9652).
1704 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1705 (turn_on_face): Output using TS_enter_italic_mode if available.
1706 Don't handle unused blinking and alt-charset cases.
1707 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1708 and tty_alt_charset_p cases.
1709 (tty_capable_p, init_tty): Support italics.
1711 * termchar.h (struct tty_display_info): Add field for italics.
1712 Remove unused blink field.
1714 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1717 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1718 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1719 tty_alt_charset_p. Add tty_italic_p.
1721 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
1723 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1724 dbus_type_is_basic if available.
1725 (xd_extract_signed, xd_extract_unsigned): Rename from
1726 extract_signed and extract_unsigned, respectively. Adapt callers.
1728 2012-06-09 Chong Yidong <cyd@gnu.org>
1730 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1732 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1735 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1737 * xdisp.c (vmessage): Treat frame message as multibyte.
1738 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1739 would generate the diagnostic "Making \302\247 buffer-local while
1742 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1744 * dispnew.c (showing_window_margins_p): Undo last change, which
1745 was done due to an inadvertent commit.
1746 (adjust_frame_glyphs_for_frame_redisplay): Do call
1747 showing_window_margins_p.
1749 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1751 * eval.c (Fmake_var_non_special): New primitive.
1752 (syms_of_eval): Defsubr it.
1753 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1755 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
1757 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1758 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1760 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1762 * alloc.c (allocate_vectorlike): Fix last change.
1764 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1766 Block-based vector allocation of small vectors.
1767 * lisp.h (struct vectorlike_header): New field `nbytes',
1768 adjust comment accordingly.
1769 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1770 to denote vector blocks. Adjust users (live_vector_p,
1771 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1772 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1773 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1774 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1775 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1776 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1777 (roundup_size): New constant.
1778 (struct vector_block): New data type.
1779 (vector_blocks, vector_free_lists, zero_vector): New variables.
1780 (all_vectors): Rename to `large_vectors'.
1781 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1782 (sweep_vectors): New functions.
1783 (allocate_vectorlike): Return `zero_vector' as the only vector of
1784 0 items. Allocate new vector from block if vector size is less than
1785 or equal to VBLOCK_BYTES_MAX.
1786 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1787 (init_alloc_once): Add call to init_vectors.
1789 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1791 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1793 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1795 * doprnt.c (doprnt): Truncate multibyte char correctly.
1796 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1797 would mishandle a string argument "Xc" if X was a multibyte
1798 character of length 2: it would truncate after X's first byte
1799 rather than including all of X.
1801 2012-06-06 Chong Yidong <cyd@gnu.org>
1803 * buffer.c (word_wrap): Doc fix.
1805 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1807 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1809 2012-06-03 Glenn Morris <rgm@gnu.org>
1811 * xdisp.c (tool-bar-style): Doc fix.
1813 2012-06-03 Ulrich Müller <ulm@gentoo.org>
1815 * Makefile.in (PAXCTL): Define.
1816 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1817 binary via PaX flags if the paxctl utility is available.
1818 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1819 Restore PaX flags to their default. (Bug#11398)
1821 2012-06-03 Chong Yidong <cyd@gnu.org>
1823 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1826 2012-06-03 Chong Yidong <cyd@gnu.org>
1828 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1829 (note_mode_line_or_margin_highlight): If there is no help echo,
1830 use mode-line-default-help-echo. Handle the case where the mouse
1831 position is past the end of the mode line string.
1833 * buffer.c (buffer_local_value_1): New function, split from
1834 Fbuffer_local_value; can return Qunbound.
1835 (Fbuffer_local_value): Use it.
1836 (Vmode_line_format): Docstring tweaks.
1838 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1840 * sysdep.c (system_process_attributes): Improve comment.
1842 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1844 * keyboard.c: Export real-this-command to Elisp.
1845 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1846 and DEFVAR it. Update all users.
1848 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1850 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1852 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1853 Convert pctcpu and pctmem to Lisp float properly.
1854 Let the compiler fold better, as 100.0/0x8000 is exact.
1856 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1858 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1861 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1863 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1865 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1867 For a 'struct window', replace some Lisp_Object fields to
1868 bitfields where appropriate, remove unused fields.
1869 * window.h (struct window): Remove unused 'last_mark_x' and
1870 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1871 change it's type from Lisp_Object to bitfield.
1872 Change type of 'force_start', 'optional_new_start',
1873 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1874 fields from Lisp_Object to bitfield. Adjust users accordingly.
1876 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1878 Pacify gcc -Wdouble-precision when using Xaw.
1879 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1880 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1881 Use 'float' consistently, rather than 'float' in most places
1882 and 'double' in a couple of places.
1884 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1886 * xdisp.c (handle_stop): Detect whether we have overlay strings
1887 loaded by testing it->current.overlay_string_index to be
1888 non-negative, instead of checking whether n_overlay_strings is
1889 positive. (Bug#11587)
1891 2012-05-31 Chong Yidong <cyd@gnu.org>
1893 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1895 * doc.c (Fsubstitute_command_keys): Doc fix.
1897 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1899 * search.c (search_buffer): Remove calls to
1900 r_alloc_inhibit_buffer_relocation, as it is now called by
1901 maybe_unify_char, which was the cause of relocation of buffer text
1904 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1906 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1907 for the duration of call to load_charset, to avoid problems with
1908 callers of maybe_unify_char that access buffer text through C
1911 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1912 decrement the inhibition flag, instead of just setting or
1915 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1917 Remove obsolete '#define static' cruft.
1918 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1919 This #undef was "temporary" in 2000; it is no longer needed
1920 now that '#define static' has gone away.
1921 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1922 (gray_bitmap_bits): Remove; no longer needed.
1923 All uses replaced with definiens.
1924 * xterm.c: Include "bitmaps/gray.xbm".
1926 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1928 Clean up __executable_start, monstartup when --enable-profiling.
1929 The following changes affect the code only when profiling.
1930 * dispnew.c (__executable_start): Rename from safe_bcopy.
1931 Define only on platforms that need it.
1932 * emacs.c: Include <sys/gmon.h> when profiling.
1933 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1934 (__executable_start): Remove decl, since lisp.h does it now.
1935 (safe_bcopy): Remove decl; no longer has that name.
1936 (main): Coalesce #if into single bit of code, for simplicity.
1937 Cast pointers to uintptr_t, since standard libraries want integers
1939 * lisp.h (__executable_start): New decl.
1941 2012-05-31 Glenn Morris <rgm@gnu.org>
1943 * image.c (Fimagemagick_types): Doc fix.
1945 2012-05-30 Jim Meyering <meyering@redhat.com>
1947 * callproc.c (Fcall_process_region): Include directory component
1948 in mkstemp error message (Bug#11586).
1950 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1952 * alloc.c, lisp.h (make_pure_vector): Now static.
1954 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1956 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1957 Move to byte-run.el.
1958 (Fautoload): Do the hash-doc more carefully.
1959 * data.c (Fdefalias): Purify definition, except for keymaps.
1960 (Qdefun): Move from eval.c.
1961 * lisp.h (Qdefun): Remove.
1962 * lread.c (read1): Tiny simplification.
1964 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1966 Do not create empty overlays with the evaporate property (Bug#9642).
1967 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1968 Bug#9642, but explicitly check that the buffer the overlay would
1969 be moved to is live and rearrange lines to make sure that errors
1970 will not put the overlay in an inconsistent state.
1971 (Fdelete_overlay): Cosmetics.
1973 2012-05-28 Eli Zaretskii <eliz@gnu.org>
1975 * w32term.c (my_bring_window_to_top): New function.
1976 (x_raise_frame): Use handle returned by DeferWindowPos, which
1977 could be different from the original one.
1978 Call my_bring_window_to_top instead of my_set_foreground_window.
1981 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1982 by calling BringWindowToTop.
1984 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1985 (WM_EMACS_END): Increase by one.
1987 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1989 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1990 This avoids undefined behavior that might cause the eassert
1991 to not catch an out-of-range value.
1993 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1995 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1996 Update dependencies.
1998 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2000 * bidi.c (bidi_mirror_char): Fix last change.
2002 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2004 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2005 when referring to sectname field in printf format.
2007 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2009 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2010 Only r_alloc_inhibit_buffer_relocation needed to be added;
2011 the others were already declared.
2013 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2014 before checking whether it's out of range. Put the check inside
2016 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2018 2012-05-27 Ken Brown <kbrown@cornell.edu>
2020 * callproc.c (Fcall_process): Restore a line that was accidentally
2021 commented out in the 2011-02-13 change (bug#11547).
2023 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2025 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2026 defined on ralloc.c.
2028 * buffer.c [REL_ALLOC]: Remove prototypes of
2029 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2030 they are now on lisp.h.
2032 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2034 * search.c (search_buffer): Use it to inhibit relocation of buffer
2035 text while re_search_2 is doing its job, because re_search_2 is
2036 passed C pointers to buffer text. (Bug#11519)
2038 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2041 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2042 state after an additional call to move_it_in_display_line_to, keep
2043 the values of it->max_ascent and it->max_descent found for the
2045 (pos_visible_p): Revert the comparison against bottom_y to what it
2046 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2049 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2051 Fix coding-related core dumps with gcc -ftrapv.
2052 The code was computing A - B, where A and B are pointers, and B is
2053 random garbage. This can lead to core dumps on platforms that
2054 have special pointer registers, and it also leads to core dumps on
2055 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2056 A - B only when B is initialized properly.
2057 * coding.c (coding_set_source, coding_set_destination): Return void.
2058 (coding_change_source, coding_change_destinations): New functions,
2059 with the old behaviors of coding_set_source and coding_set_destination.
2060 All callers that need an offset changed to use these new functions.
2062 2012-05-26 Glenn Morris <rgm@gnu.org>
2064 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2066 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2068 Extend mouse support on W32 text-mode console.
2069 * xdisp.c (draw_row_with_mouse_face):
2070 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
2072 * w32console.c: Include window.h.
2073 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2075 (initialize_w32_display): Initialize mouse-highlight data.
2077 * w32inevt.c: Include termchar.h and window.h.
2078 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2079 moves, call note_mouse_highlight. If help_echo changed, call
2080 gen_help_event to produce help-echo message in the echo area.
2081 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2084 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2086 * lread.c (read1): Simplify slightly to avoid an overflow warning
2087 with GCC 4.7.0 on x86-64.
2089 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2091 * bidi.c (bidi_mirror_char): Revert last change: an int is
2092 definitely wide enough here.
2094 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
2096 Fix integer width and related bugs (Bug#9874).
2097 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
2098 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2099 (string_bytes, check_sblock, allocate_string_data):
2100 (compact_small_strings, Fmake_bool_vector, make_string)
2101 (make_unibyte_string, make_multibyte_string)
2102 (make_string_from_bytes, make_specified_string)
2103 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2104 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2106 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2107 (allocate_pseudovector):
2108 Use int, not EMACS_INT, where int is wide enough.
2109 (inhibit_garbage_collection, Fgarbage_collect):
2110 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2111 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2112 int might not be wide enough.
2113 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2114 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2115 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2116 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2117 (bidi_level_of_next_char, bidi_move_to_visually_next):
2118 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2119 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2120 (Fkill_buffer, Fset_buffer_major_mode)
2121 (advance_to_char_boundary, Fbuffer_swap_text)
2122 (Fset_buffer_multibyte, overlays_at, overlays_in)
2123 (overlay_touches_p, struct sortvec, record_overlay_string)
2124 (overlay_strings, recenter_overlay_lists)
2125 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2126 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2127 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2128 (Foverlay_recenter, last_overlay_modification_hooks_used)
2129 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2130 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2131 (validate_region): Omit unnecessary test for b <= e,
2132 since that's guaranteed by the previous test.
2133 (adjust_overlays_for_delete): Avoid pos + length overflow.
2134 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2135 (report_overlay_modification):
2136 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2137 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2138 Omit pointer cast, which isn't needed anyway, and doesn't work
2139 after the EMACS_INT -> ptrdiff_t change.
2140 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
2141 * buffer.h: Adjust decls to match defn changes elsewhere.
2142 (struct buffer_text, struct buffer):
2143 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2144 Use EMACS_INT, not int, where int might not be wide enough.
2145 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2146 not int, to avoid needless 32-bit limit on 64-bit hosts.
2147 (exec_byte_code): Use tighter memory-full test, one that checks
2148 for alloca overflow. Don't compute the address of the object just
2149 before an array, as that's not portable. Use EMACS_INT, not
2150 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
2151 * callint.c (Fcall_interactively):
2152 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2153 * callproc.c (call_process_kill, Fcall_process):
2154 Don't assume pid_t fits into an Emacs fixnum.
2155 (call_process_cleanup, Fcall_process, child_setup):
2156 Don't assume pid_t fits into int.
2157 (call_process_cleanup, Fcall_process, delete_temp_file)
2158 (Fcall_process_region):
2159 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2160 (Fcall_process): Simplify handling of volatile integers.
2161 Use int, not EMACS_INT, where int will do.
2162 * casefiddle.c (casify_object, casify_region, operate_on_word)
2163 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2164 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2165 (casify_object): Avoid integer overflow when overallocating buffer.
2166 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
2167 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
2168 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2169 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2170 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2171 integers are now checked earlier. All uses replaced with XINT.
2173 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2174 For CCL_MapSingle, check that content and value are in int range.
2175 (ccl_driver, Fregister_code_conversion_map):
2176 Check that Vcode_version_map_vector is a vector.
2177 (resolve_symbol_ccl_program): Check that vector header is in range.
2178 Always copy the vector, so that we can check its contents reliably
2179 now rather than having to recheck each instruction as it's being
2180 executed. Check that vector words fit in 'int'.
2181 (ccl_get_compiled_code, Fregister_ccl_program)
2182 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2183 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2184 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2185 contents are in range.
2186 (Fccl_execute_on_string): Check that status is in range.
2187 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2188 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2189 Accept and return EMACS_INT, not int, because callers can pass values
2191 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2192 (multibyte_chars_in_text, parse_str_as_multibyte)
2193 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2194 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2195 (string_escape_byte8, Fget_byte):
2196 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2197 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
2198 avoid mishandling large integers.
2199 * character.h: Adjust decls to match defn changes elsewhere.
2200 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2201 (Ffind_charset_region):
2202 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2203 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2204 (load_charset_map_from_vector, Fdefine_charset_internal):
2205 Don't assume fixnum fits in int.
2206 (load_charset_map_from_vector, Fmap_charset_chars):
2207 Remove now-unnecessary CHECK_NATNUMs.
2208 (Fdefine_charset_internal): Check ranges here, more carefully.
2209 Don't rely on undefined behavior with signed left shift overflow.
2210 Don't assume unsigned int fits into fixnum, or that fixnum fits
2211 into unsigned int. Don't require max_code to be a valid fixnum;
2212 that's not true for gb10830 4-byte on a 32-bit host. Allow
2213 invalid_code to be a cons, for the same reason. Require code_offset
2214 to be a character. Avoid int overflow if max_char is close
2216 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2217 this is intended anyway and avoids some undefined behavior.
2218 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2219 INDEX_TO_CODE_POINT, as that's what it expects.
2220 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
2221 * charset.h (DECODE_CHAR): Return int, not unsigned;
2222 this is what was intended anyway, and it avoids undefined behavior.
2223 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2224 integer-overflow issues.
2225 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2226 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2227 where the argument is EMACS_INT, and this behavior is not intended.
2228 * chartab.c (Fmake_char_table, Fset_char_table_range)
2229 (uniprop_get_decoder, uniprop_get_encoder):
2230 Don't assume fixnum fits in int.
2231 * cmds.c (move_point): New function, that does the gist of
2232 Fforward_char and Fbackward_char, but does so while checking
2233 for integer overflow more accurately.
2234 (Fforward_char, Fbackward_char): Use it.
2235 (Fforward_line, Fend_of_line, internal_self_insert)
2236 (internal_self_insert):
2237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2238 Fix a FIXME, by checking for integer overflow when calculating
2239 target_clm and actual_clm.
2240 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
2241 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
2242 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2243 (coding_alloc_by_making_gap, alloc_destination)
2244 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2245 (encode_coding_utf_16, detect_coding_emacs_mule)
2246 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2247 (detect_coding_iso_2022, decode_coding_iso_2022)
2248 (encode_invocation_designation, encode_designation_at_bol)
2249 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2250 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2251 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2252 (encode_coding_ccl, encode_coding_raw_text)
2253 (detect_coding_charset, decode_coding_charset)
2254 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2255 (produce_composition, produce_charset, produce_annotation)
2256 (decode_coding, handle_composition_annotation)
2257 (handle_charset_annotation, consume_chars, decode_coding_gap)
2258 (decode_coding_object, encode_coding_object, detect_coding_system)
2259 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2260 (code_convert_region, code_convert_string)
2261 (Fdefine_coding_system_internal)
2262 (coding_set_source, coding_set_destination):
2263 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2264 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2265 (Fdefine_coding_system_internal):
2266 Don't assume fixnums fit in int.
2267 (decode_coding_gap, decode_coding_object, encode_coding_object)
2268 (Fread_coding_system, Fdetect_coding_region)
2269 (Funencodable_char_position, Fcheck_coding_systems_region)
2270 (get_translation, handle_composition_annotation, consume_chars):
2271 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2272 (consume_chars): Rewrite to not calculate an address outside buffer.
2273 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
2274 Don't access memory outside of the args array.
2275 (Fdefine_coding_system_internal): Check for charset-id overflow.
2276 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2277 result of ENCODE_CHAR.
2278 * coding.h: Adjust decls to match defn changes elsewhere.
2279 (struct coding_system):
2280 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2281 * composite.c (get_composition_id, find_composition)
2282 (run_composition_function, update_compositions)
2283 (compose_text, composition_gstring_put_cache)
2284 (composition_gstring_p, composition_gstring_width)
2285 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2286 (composition_compute_stop_pos, composition_reseat_it)
2287 (composition_update_it, struct position_record)
2288 (find_automatic_composition, composition_adjust_point)
2289 (Fcomposition_get_gstring, Ffind_composition_internal):
2290 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2291 (update_compositions):
2292 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2293 * composite.h: Adjust decls to match defn changes elsewhere.
2294 (struct composition):
2295 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2296 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2297 Do not attempt to compute the address of the object just before a
2298 buffer; this is not portable.
2300 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2301 (Faset): Use int, not EMACS_INT, where int is wide enough.
2302 (Fstring_to_number): Don't assume fixnums fit in int.
2303 (Frem): Don't assume arg is nonnegative.
2304 * dbusbind.c (xd_append_arg): Check for integers out of range.
2305 (Fdbus_call_method): Don't overflow the timeout int.
2306 (extract_signed, extract_unsigned): New functions.
2307 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2308 (xd_get_connection_references): Return ptrdiff_t, not int.
2310 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2311 (xd_read_message_1):
2312 Use int, not unsigned, where the dbus API uses int.
2313 (Fdbus_message_internal): Don't overflow mtype.
2314 (syms_of_dbusbind): Allocate right-sized buffer for integers.
2315 * dired.c (directory_files_internal, file_name_completion, scmp)
2316 (file_name_completion_stat):
2317 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2318 (file_name_completion): Don't overflow matchcount.
2319 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2320 * dispextern.h: Adjust decls to match defn changes elsewhere.
2321 (struct text_pos, struct glyph, struct bidi_saved_info)
2322 (struct bidi_string_data, struct bidi_it, struct composition_it)
2324 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2325 (struct display_pos, struct composition_it, struct it):
2326 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2327 * dispnew.c (increment_matrix_positions)
2328 (increment_row_positions, mode_line_string)
2329 (marginal_area_string):
2330 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2331 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
2332 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2333 (duration_to_sec_usec): New function, to check for overflow better.
2334 (Fsleep_for, sit_for): Use it.
2335 * doc.c (get_doc_string, store_function_docstring):
2336 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2337 (get_doc_string, Fsnarf_documentation):
2338 Use int, not EMACS_INT, where int is wide enough.
2340 Use SAFE_ALLOCA, not alloca.
2341 Check for overflow when converting EMACS_INT to off_t.
2342 * doprnt.c (doprnt):
2343 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2344 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2345 Don't assume uid_t fits into fixnum.
2346 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2347 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2348 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2349 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2350 (general_insert_function)
2351 (Finsert_char, make_buffer_string, make_buffer_string_both)
2352 (update_buffer_properties, Fbuffer_substring)
2353 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2354 (Fsubst_char_in_region, check_translation)
2355 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2356 (transpose_markers, Ftranspose_regions):
2357 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2358 (clip_to_bounds): Move to lisp.h as an inline function).
2359 (Fconstrain_to_field): Don't assume integers are nonnegative.
2360 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2361 (Fsubst_char_in_region, Fsave_restriction):
2362 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2363 (Femacs_pid): Don't assume pid_t fits into fixnum.
2364 (lo_time): Use int, not EMACS_INT, when int suffices.
2365 (lisp_time_argument): Check for usec out of range.
2366 (Fencode_time): Don't assume fixnum fits in int.
2367 (Fuser_login_name, Fuser_full_name): Signal an error
2368 if a uid argument is out of range, rather than relying on
2370 (Fformat_time_string): Remove now-unnecessary check.
2371 lisp_time_argument checks for out-of-range usec now.
2372 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2373 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2374 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2375 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2376 (init_cmdargs, Fdump_emacs):
2377 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2378 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2379 the bottom (typically) 32 bits of the fixnum.
2380 * eval.c (specpdl_size, call_debugger):
2381 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2382 (when_entered_debugger, Fbacktrace_debug):
2383 Don't assume fixnum can fit in int.
2384 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2385 the object just before a buffer; this is not portable.
2386 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2387 (grow_specpdl, unbind_to):
2388 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2389 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2390 (grow_specpdl): Simplify allocation by using xpalloc.
2391 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2392 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2393 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2394 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2395 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2397 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2398 (Fcopy_file, non_regular_nbytes, read_non_regular)
2399 (Finsert_file_contents):
2400 Use int, not EMACS_INT, where int is wide enough.
2401 (READ_BUF_SIZE): Verify that it fits in int.
2402 (Finsert_file_contents): Check that counts are in proper range,
2403 rather than assuming fixnums fit into ptrdiff_t etc.
2404 Don't assume fixnums fit into int.
2405 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2406 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2407 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2408 (string_char_to_byte, string_byte_to_char)
2409 (string_make_multibyte, string_to_multibyte)
2410 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2411 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2412 (substring_both, Fdelete, internal_equal, Ffillarray)
2413 (Fclear_string, mapcar1)
2414 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2415 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2416 (larger_vector, make_hash_table, maybe_resize_hash_table)
2417 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2418 (Fmaphash, secure_hash):
2419 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2420 (concat): Check for string index and length overflow.
2421 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2423 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2424 (larger_vector): New API (vec, incr_min, size_max) replaces old
2425 one (vec, new_size, init). This catches size overflow.
2426 INIT was removed because it was always Qnil.
2427 All callers changed.
2428 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2429 the upper bound on a hash table index size.
2430 (make_hash_table, maybe_resize_hash_table): Use it.
2431 (secure_hash): Computer start_byte and end_byte only after
2432 they're known to be in ptrdiff_t range.
2433 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2434 (Ffont_get_glyphs, Ffont_at):
2435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2436 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2437 (Flist_fonts, Fopen_font):
2438 Don't assume fixnum can fit in int.
2439 (check_gstring): Don't assume index can fit in int.
2440 (font_match_p): Check that fixnum is a character, not a nonnegative
2441 fixnum, since the later code needs to stuff it into an int.
2442 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2443 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2444 conversion overflow issues.
2445 (Fopen_font): Check for integer out of range.
2446 (Ffont_get_glyphs): Don't assume index can fit in int.
2447 * font.h: Adjust decls to match defn changes elsewhere.
2448 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2450 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2451 printmax_t, where ptrdiff_t is wide enough.
2452 (Finternal_char_font):
2453 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2454 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2455 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2456 (Fset_frame_position, x_set_frame_parameters)
2457 (x_set_line_spacing, x_set_border_width)
2458 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2459 Check that fixnums are in proper range for system types.
2460 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2461 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2462 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2463 Use SAFE_ALLOCA_LISP, not alloca.
2464 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2465 intptr_t is wide enough.
2466 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2467 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2468 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2469 Check for fixnum out of range.
2470 * ftfont.c (ftfont_list): Don't assume index fits in int.
2471 Check that fixnums are in proper range for system types.
2472 (ftfont_shape_by_flt):
2473 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2474 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2476 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2477 Check that fixnums are in proper range for system types.
2478 * gnutls.h: Adjust decls to match defn changes elsewhere.
2479 * gtkutil.c (xg_dialog_run):
2480 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2481 (update_frame_tool_bar):
2482 Check that fixnums are in proper range for system types.
2483 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
2484 (lookup_image): Check that fixnums are in range for system types.
2485 * indent.c (last_known_column, last_known_column_point):
2486 (current_column_bol_cache):
2487 (skip_invisible, current_column, check_display_width):
2488 (check_display_width, scan_for_column, current_column_1)
2489 (Findent_to, Fcurrent_indentation, position_indentation)
2490 (indented_beyond_p, Fmove_to_column, compute_motion):
2491 (Fcompute_motion, Fvertical_motion):
2492 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2493 (last_known_column_modified): Use EMACS_INT, not int.
2494 (check_display_width):
2496 Check that fixnums and floats are in proper range for system types.
2497 (compute_motion): Don't assume index or fixnum fits in int.
2498 (compute_motion, Fcompute_motion):
2499 Use int, not EMACS_INT, when it is wide enough.
2500 (vmotion): Omit local var start_hpos that is always 0; that way
2501 we don't need to worry about overflow in expressions involving it.
2502 * indent.h: Adjust decls to match defn changes elsewhere.
2504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2505 Use int, not EMACS_INT, where int is wide enough.
2506 Remove unused members ovstring_chars_done and tab_offset;
2508 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2509 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2510 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2511 (make_gap, copy_text, insert, insert_and_inherit)
2512 (insert_before_markers, insert_before_markers_and_inherit)
2513 (insert_1, count_combining_before, count_combining_after)
2514 (insert_1_both, insert_from_string)
2515 (insert_from_string_before_markers, insert_from_string_1)
2516 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2517 (adjust_after_replace, adjust_after_insert, replace_range)
2518 (replace_range_2, del_range, del_range_1, del_range_byte)
2519 (del_range_both, del_range_2, modify_region)
2520 (prepare_to_modify_buffer, signal_before_change)
2521 (signal_after_change, Fcombine_after_change_execute):
2522 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2523 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2524 (balance_an_interval, split_interval_right, split_interval_left)
2525 (find_interval, next_interval, update_interval)
2526 (adjust_intervals_for_insertion, delete_node, delete_interval)
2527 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2528 (static_offset_intervals, offset_intervals)
2529 (merge_interval_right, merge_interval_left, make_new_interval)
2530 (graft_intervals_into_buffer, temp_set_point_both)
2531 (temp_set_point, set_point, adjust_for_invis_intang)
2532 (set_point_both, move_if_not_intangible, get_property_and_range)
2533 (get_local_map, copy_intervals, copy_intervals_to_string)
2534 (compare_string_intervals, set_intervals_multibyte_1):
2535 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2536 * intervals.h: Adjust decls to match defn changes elsewhere.
2538 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2539 * keyboard.c (this_command_key_count, this_single_command_key_start)
2540 (before_command_key_count, before_command_echo_length, echo_now)
2541 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2542 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2543 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2544 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2545 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2546 (last_non_minibuf_size, last_point_position, echo_truncate)
2547 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2548 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2549 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2550 (stuff_buffered_input):
2551 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2552 (last_auto_save, command_loop_1, read_char):
2553 Use EMACS_INT, not int, to avoid integer overflow.
2554 (record_char): Avoid overflow in total_keys computation.
2555 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2556 * keyboard.h: Adjust decls to match defn changes elsewhere.
2557 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2558 (Fkey_description, Fdescribe_vector, Flookup_key):
2559 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2560 (click_position): New function, to check that positions are in range.
2561 (Fcurrent_active_maps):
2563 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2564 (Faccessible_keymaps, Fkey_description):
2565 (preferred_sequence_p):
2566 Don't assume fixnum can fit into int.
2567 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2568 Check for integer overflow in size calculations.
2569 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2570 avoid mishandling large integers.
2571 * lisp.h: Adjust decls to match defn changes elsewhere.
2572 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2573 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2574 (struct Lisp_Marker):
2575 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2576 (clip_to_bounds): Now an inline function, moved here from editfns.c.
2577 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2578 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2579 All callers changed.
2580 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2581 Assume the arg has valid form, since it always does.
2582 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2583 unsigned integer system type.
2584 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2585 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2586 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2587 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2588 (duration_to_sec_usec): New decl.
2589 * lread.c (read_from_string_index, read_from_string_index_byte)
2590 (read_from_string_limit, readchar, unreadchar, openp)
2591 (read_internal_start, read1, oblookup):
2592 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2593 (Fload, readevalloop, Feval_buffer, Feval_region):
2594 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2595 (openp): Check for out-of-range argument to 'access'.
2596 (read1): Use int, not EMACS_INT, where int is wide enough.
2597 Don't assume fixnum fits into int.
2598 Fix off-by-one error that can read outside a buffer.
2599 (read_filtered_event): Use duration_to_sec_usec
2600 to do proper overflow checking on durations.
2601 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2602 in size calculation.
2603 (Fexecute_kbd_macro):
2604 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2605 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2606 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2607 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2608 (set_marker_both, set_marker_restricted_both, marker_position)
2609 (marker_byte_position, Fbuffer_has_markers_at):
2610 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2611 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
2612 * menu.c (ensure_menu_items): Rename from grow_menu_items.
2613 It now merely ensures that the menu is large enough, without
2614 necessarily growing it, as this avoids some integer overflow issues.
2615 All callers changed.
2616 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2617 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2618 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2619 Use SAFE_ALLOCA_LISP, not alloca.
2620 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2621 to EMACS_INT. Check that fixnums are in proper range for system types.
2622 * minibuf.c (minibuf_prompt_width, string_to_object)
2623 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2624 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2625 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2626 (get_minibuffer, read_minibuf_unwind):
2627 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2628 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2629 this simplifies overflow checking. All callers changed.
2630 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2632 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2633 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2634 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2635 Check that fixnums are in proper range for system types.
2636 (Fx_create_frame, Fx_show_tip):
2637 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2638 * nsfont.m (ns_findfonts, nsfont_list_family):
2639 Don't assume fixnum fits in long.
2640 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2641 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2642 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2644 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
2645 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2646 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2647 (PRINTDECLARE, PRINTPREPARE):
2648 (strout, print_string):
2649 (print, print_preprocess, print_check_string_charset_prop)
2651 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2653 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2654 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2655 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
2656 (printchar, strout): Use xpalloc to catch size calculation overflow.
2657 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
2658 (print_error_message): Use SAFE_ALLOCA, not alloca.
2659 (print_object): Use int, not EMACS_INT, where int is wide enough.
2660 (print_depth, new_backquote_output, print_number_index):
2661 Use ptrdiff_t, not int, where int might not be wide enough.
2662 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2663 (Fset_process_window_size, Fformat_network_address)
2664 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
2666 Check that fixnums are in proper range for system types.
2667 (Fsignal_process): Simplify by avoiding a goto.
2668 Check for process-ids out of pid_t range rather than relying on
2670 (process_tick, update_tick): Use EMACS_INT, not int.
2671 (Fformat_network_address, read_process_output, send_process)
2672 (Fprocess_send_region, status_notify):
2673 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2674 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2675 (wait_reading_process_output, read_process_output, exec_sentinel):
2676 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2677 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2678 (Faccept_process_output): Use duration_to_sec_usec to do proper
2679 overflow checking on durations.
2680 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2681 Don't assume pid_t fits in int.
2682 * process.h (struct Lisp_Process): Members tick and update_tick
2683 are now of type EMACS_INT, not int.
2684 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2685 configured --with-wide-int.
2686 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2687 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2688 * search.c (looking_at_1, string_match_1):
2689 (fast_string_match, fast_c_string_match_ignore_case)
2690 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2691 (scan_newline, find_before_next_newline, search_command)
2692 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2693 (set_search_regs, wordify):
2696 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2697 (string_match_1, search_buffer, set_search_regs):
2699 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2700 (wordify): Check for overflow in size calculation.
2701 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2702 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2703 Check that fixnums are in proper range for system types.
2704 * sound.c (struct sound_device)
2705 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2706 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2707 (Fplay_sound_internal):
2708 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2709 * syntax.c (struct lisp_parse_state, find_start_modiff)
2710 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2711 (Fparse_partial_sexp):
2712 Don't assume fixnums can fit in int.
2713 (struct lisp_parse_state, find_start_pos, find_start_value)
2714 (find_start_value_byte, find_start_begv)
2715 (update_syntax_table, char_quoted, dec_bytepos)
2716 (find_defun_start, prev_char_comend_first, back_comment):
2717 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2718 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2719 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2720 (Finternal_describe_syntax_value): Check that match_lisp is a
2721 character, not an integer, since the code stuffs it into int.
2722 (scan_words, scan_sexps_forward):
2723 Check that fixnums are in proper range for system types.
2725 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2726 (scan_sexps_forward):
2727 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2728 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2729 * syntax.h: Adjust decls to match defn changes elsewhere.
2730 (struct gl_state_s):
2731 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2732 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2733 MOST_POSITIVE_FIXNUM.
2734 * sysdep.c (wait_for_termination_1, wait_for_termination)
2735 (interruptible_wait_for_termination, mkdir):
2736 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2737 (emacs_read, emacs_write):
2738 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2739 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2740 and double all fit in int.
2741 * term.c (set_tty_color_mode):
2742 Check that fixnums are in proper range for system types.
2743 * termhooks.h (struct input_event):
2744 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2745 * textprop.c (validate_interval_range, interval_of)
2746 (Fadd_text_properties, set_text_properties_1)
2747 (Fremove_text_properties, Fremove_list_of_text_properties)
2748 (Ftext_property_any, Ftext_property_not_all)
2749 (copy_text_properties, text_property_list, extend_property_ranges)
2750 (verify_interval_modification):
2751 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2752 (Fnext_single_char_property_change)
2753 (Fprevious_single_char_property_change):
2754 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2755 (copy_text_properties):
2756 Check for integer overflow in index calculation.
2757 * undo.c (last_boundary_position, record_point, record_insert)
2758 (record_delete, record_marker_adjustment, record_change)
2759 (record_property_change):
2760 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2761 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2762 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2763 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2764 (Fx_hide_tip, Fx_file_dialog):
2765 * w32menu.c (set_frame_menubar):
2766 Use ptrdiff_t, not int, for consistency with rest of code.
2767 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2768 (select_window, Fdelete_other_windows_internal)
2769 (window_scroll_pixel_based, window_scroll_line_based)
2770 (Frecenter, Fset_window_configuration):
2771 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2772 (Fset_window_hscroll, run_window_configuration_change_hook)
2773 (set_window_buffer, temp_output_buffer_show, scroll_command)
2774 (Fscroll_other_window, Frecenter):
2775 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2776 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2777 Don't assume fixnum fits in int.
2778 (Fset_window_scroll_bars):
2779 Check that fixnums are in proper range for system types.
2780 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2781 (string_pos, c_string_pos, number_of_chars, init_iterator)
2782 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2783 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2784 (compute_display_string_end, handle_face_prop)
2785 (face_before_or_after_it_pos, handle_invisible_prop)
2786 (handle_display_prop, handle_display_spec, handle_single_display_spec)
2787 (display_prop_intangible_p, string_buffer_position_lim)
2788 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2789 (get_overlay_strings_1, get_overlay_strings)
2790 (iterate_out_of_display_property, forward_to_next_line_start)
2791 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2792 (get_next_display_element, set_iterator_to_next)
2793 (get_visually_first_element, compute_stop_pos_backwards)
2794 (handle_stop_backwards, next_element_from_buffer)
2795 (move_it_in_display_line_to, move_it_in_display_line)
2796 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2797 (add_to_log, message_dolog, message_log_check_duplicate)
2798 (message2, message2_nolog, message3, message3_nolog
2799 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2800 (current_message_1, truncate_echo_area, truncate_message_1)
2801 (set_message, set_message_1, store_mode_line_noprop)
2802 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2803 (text_outside_line_unchanged_p, check_point_in_composition)
2804 (reconsider_clip_changes)
2805 (redisplay_internal, set_cursor_from_row, try_scrolling)
2806 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2807 (redisplay_window, find_last_unchanged_at_beg_row)
2808 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2809 (trailing_whitespace_p, find_row_edges, display_line)
2810 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2811 (display_mode_element, store_mode_line_string)
2812 (pint2str, pint2hrstr, decode_mode_spec)
2813 (display_count_lines, display_string, draw_glyphs)
2814 (x_produce_glyphs, x_insert_glyphs)
2815 (rows_from_pos_range, mouse_face_from_buffer_pos)
2816 (fast_find_string_pos, mouse_face_from_string_pos)
2817 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2818 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2819 (safe_call, init_from_display_pos, handle_fontified_prop)
2820 (handle_single_display_spec, load_overlay_strings)
2821 (with_echo_area_buffer, setup_echo_area_for_printing)
2822 (display_echo_area, echo_area_display)
2823 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2824 (update_tool_bar, hscroll_window_tree, redisplay_internal)
2825 (redisplay_window, dump_glyph_row, display_mode_line)
2826 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
2827 (handle_display_spec, display_prop_string_p):
2828 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2829 (handle_single_display_spec, build_desired_tool_bar_string)
2830 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2831 (get_specified_cursor_type):
2832 Check that fixnums are in proper range for system types.
2833 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2834 (Flookup_image_map):
2835 Don't assume fixnums fit in int.
2836 (compare_overlay_entries):
2837 Avoid mishandling comparisons due to subtraction overflow.
2838 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2839 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2840 (handle_tool_bar_click):
2841 Use int, not unsigned, since we prefer signed and the signedness
2842 doesn't matter here.
2843 (get_next_display_element, next_element_from_display_vector):
2844 Use int, not EMACS_INT, when int is wide enough.
2845 (start_hourglass): Use duration_to_sec_usec to do proper
2846 overflow checking on durations.
2847 * xfaces.c (Fbitmap_spec_p):
2848 Check that fixnums are in proper range for system types.
2849 (compare_fonts_by_sort_order):
2850 Avoid mishandling comparisons due to subtraction overflow.
2851 (Fx_family_fonts, realize_basic_faces):
2852 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2854 Don't assume fixnum fits in int.
2855 Use SAFE_ALLOCA_LISP, not alloca.
2856 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2857 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2858 (face_at_buffer_position, face_for_overlay_string)
2859 (face_at_string_position):
2860 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2861 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2862 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2864 Check that fixnums are in proper range for system types.
2865 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2866 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2867 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2868 (Fx_change_window_property): Don't assume fixnums fit in int.
2869 * xfont.c (xfont_chars_supported):
2870 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2871 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2872 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2873 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2874 * xml.c (parse_region):
2875 * xrdb.c (magic_file_p):
2876 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2877 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2878 (x_get_local_selection, x_reply_selection_request)
2879 (x_handle_selection_request, wait_for_property_change):
2880 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2881 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2882 short is wide enough.
2883 (x_send_client_event): Don't assume fixnum fits in int.
2884 * xterm.c (x_x_to_emacs_modifiers):
2885 Don't assume EMACS_INT overflows nicely into int.
2886 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2888 (handle_one_xevent): NATNUMP can eval its arg twice.
2889 (x_connection_closed):
2890 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2891 * xterm.h: Adjust decls to match defn changes elsewhere.
2892 (struct scroll_bar): Use struct vectorlike_header
2893 rather than rolling our own approximation.
2894 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2896 2012-05-25 Glenn Morris <rgm@gnu.org>
2898 * lisp.mk (lisp): Update for more files being compiled now.
2900 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2902 * lread.c: Remove `read_pure' which makes no difference.
2903 (read_pure): Remove var.
2904 (unreadpure): Remove function.
2905 (readevalloop): Don't call read_list with -1 flag.
2906 (read1, read_vector): Don't test read_pure any more.
2907 (read_list): Simplify.
2909 * fileio.c, character.h: Minor style tweaks.
2911 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2913 * window.h (clip_changed): Remove useless declaration.
2915 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2917 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2918 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2920 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2923 This directory predates autoconf and is no longer needed nowadays.
2924 Move its few remaining bits of functionality to where they're needed.
2925 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2926 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2927 * m/template.h: Remove.
2928 * Makefile.in (M_FILE): Remove. All uses removed.
2929 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2930 * lisp.h (USE_LSB_TAG):
2931 * mem-limits.h (EXCEEDS_LISP_PTR):
2932 Use VAL_MAX, not VALBITS, in #if.
2933 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2934 (EMACS_UINT): Define unconditionally now.
2935 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2936 (BITS_PER_EMACS_INT): New constants, replacing
2937 what used to be in config.h, but not useful in #if.
2938 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2939 define them any more.
2940 (VAL_MAX): New macro.
2942 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2943 BITS_PER_EMACS_INT, in #if.
2944 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2945 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2946 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2947 * s/ms-w32.h (DATA_START):
2948 Move here from removed file m/intel386.h.
2949 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2950 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2952 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2954 Assume C89 or later.
2955 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2956 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2958 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2959 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2960 * textprop.c, tparam.c (NULL): Remove.
2961 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2962 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2963 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2964 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2965 * xterm.c (input_signal_count): Assume volatile works.
2967 2012-05-21 Ken Brown <kbrown@cornell.edu>
2969 * xgselect.c (xg_select): Fix first argument in call to 'select'
2972 2012-05-20 Ken Brown <kbrown@cornell.edu>
2974 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
2975 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
2977 2012-05-19 Ken Brown <kbrown@cornell.edu>
2979 * xfns.c (x_in_use): Remove `static' qualifier.
2980 * xterm.h (x_in_use): Declare.
2981 * xgselect.c: Include xterm.h.
2982 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2983 and `display_arg' (bug#9754).
2985 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2987 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2989 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2990 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2992 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2994 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2996 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2997 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
2999 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3000 reference to image_cache->refcount.
3001 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3003 2012-05-17 Juri Linkov <juri@jurta.org>
3005 * search.c (Fword_search_regexp, Fword_search_backward)
3006 (Fword_search_forward, Fword_search_backward_lax)
3007 (Fword_search_forward_lax): Move functions to isearch.el
3008 (bug#10145, bug#11381).
3010 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3012 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3014 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3016 * lread.c (init_obarray): Declare Qt and Qnil as special.
3018 2012-05-14 Glenn Morris <rgm@gnu.org>
3020 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
3021 Put "libexec" before "bin", for the sake of init_callproc_1.
3023 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3025 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3027 * unexaix.c: Port to more-recent AIX compilers.
3028 (report_error, report_error_1, make_hdr, copy_sym)
3029 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3030 Make arguments const char *, not char *, to avoid violations of C
3031 standard and to fix some AIX warnings reported by Gilles Pion.
3033 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3035 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3036 already have overlays loaded.
3037 (handle_single_display_spec): Before returning without displaying
3038 fringe bitmap, synchronize the bidi iterator with the main display
3039 iterator, by calling iterate_out_of_display_property.
3040 (iterate_out_of_display_property): Detect buffer iteration by
3041 testing that it->string is a Lisp string.
3042 (get_next_display_element): When the current object is exhausted,
3043 and there's something on it->stack, call set_iterator_to_next to
3044 proceed with what's on the stack, instead of returning zero.
3045 (set_iterator_to_next): If called at the end of a Lisp string,
3046 proceed to consider_string_end without incrementing string
3047 position. Don't increment display vector index past the end of
3048 the display vector. (Bug#11417)
3049 (pos_visible_p): Don't report a position visible when move_it_to
3050 stopped at the last line of window, which happens to be scanned
3051 backwards by the bidi iteration. (Bug#11464)
3053 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3055 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3056 and right-margin display specs even if the spec is invalid or we
3057 are on a TTY, and thus unable to display on the fringes.
3058 That's because the text with the property will not be displayed anyway,
3059 so we need to signal to the caller that this is a "replacing"
3060 display spec. This fixes display when the spec is invalid or we
3063 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3065 * unexaix.c (make_hdr): Fix typo in prototype.
3066 This bug broke the build on AIX. Problem reported by Gilles Pion.
3068 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
3070 * keyboard.c (kbd_buffer_get_event): Read special events also in
3071 batch mode. (Bug#11415)
3073 2012-05-12 Glenn Morris <rgm@gnu.org>
3075 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3077 2012-05-12 Eli Zaretskii <eliz@gnu.org>
3079 * lisp.mk (lisp): Add newcomment.elc.
3081 2012-05-12 Glenn Morris <rgm@gnu.org>
3083 * Makefile.in (MKDIR_P): New, set by configure.
3084 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3086 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3088 Remove unused function hourglass_started.
3089 * dispextern.h (hourglass_started):
3090 * w32fns.c (hourglass_started):
3091 * xdisp.c (hourglass_started): Remove.
3093 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
3095 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3096 Update dependencies.
3098 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3100 * xgselect.c (xg_select): Put maxfds+1 into a var.
3101 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3103 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3105 2012-05-10 Dave Abrahams <dave@boostpro.com>
3107 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3108 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3110 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
3112 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3113 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3114 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3115 Initialize xd_registered_buses.
3117 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3119 Untag more efficiently if USE_LSB_TAG.
3120 This is based on a proposal by YAMAMOTO Mitsuharu in
3121 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3122 For an admittedly artificial (nth 8000 longlist) benchmark on
3123 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3124 Emacs's overall text size by 1%.
3125 * lisp.h (XUNTAG): New macro.
3126 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3127 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3128 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3129 * eval.c (Fautoload):
3130 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3131 * frame.h (XFRAME): Use XUNTAG.
3133 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3134 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3135 Remove unportable assumptions about print widths of types like
3137 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3138 intptr_t when converting between pointer and integer, to avoid GCC
3139 warnings about wrong width.
3141 2012-05-09 Eli Zaretskii <eliz@gnu.org>
3143 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3144 stack for each reader_thread, instead of defaulting to 8MB
3145 determined by the linker. This avoids failures in creating
3146 subprocesses on Windows 7, see the discussion in this thread:
3147 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3149 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3151 Fix up display of the *Minibuf-0* buffer in the mini window.
3152 * keyboard.c (read_char): Don't clear the echo area if there's no
3154 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
3155 contents of *Minibuf-0*) if there's no message displayed in its stead.
3157 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
3159 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3162 2012-05-06 Chong Yidong <cyd@gnu.org>
3164 * lisp.mk (lisp): Update.
3166 2012-05-05 Jim Meyering <meyering@redhat.com>
3168 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3170 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3172 * data.c (PUT_ERROR): New macro.
3173 (syms_of_data): Use it. Add new error type `user-error'.
3174 * undo.c (user_error): New function.
3175 (Fprimitive_undo): Use it.
3176 * print.c (print_error_message): Adjust print style for `user-error'.
3177 * keyboard.c (user_error): New function.
3178 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3180 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3182 Do not limit current-time-string to years 1000..9999.
3183 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3184 (Fcurrent_time_string): Support any year that is supported by the
3185 underlying localtime representation. Don't use asctime, as it
3186 has undefined behavior for years outside the range -999..9999.
3188 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3190 Fix race conditions involving setenv, gmtime, localtime, asctime.
3191 Without this fix, interrupts could mess up code that uses these
3192 nonreentrant functions, since setting TZ invalidates existing
3193 tm_zone or tzname values, and since most of these functions return
3194 pointers to static storage.
3195 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3196 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3197 Grow the critical sections to include not just invoking
3198 localtime/gmtime, but also accessing these functions' results
3199 including their tm_zone values if any, and any related TZ setting.
3200 (format_time_string): Last arg is now struct tm *, not struct tm **,
3201 so that the struct tm is saved in the critical section.
3202 All callers changed. Simplify allocation of initial buffer, partly
3203 motivated by the fact that memory allocation needs to be outside
3204 the critical section.
3206 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3208 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3209 with RESET_INTERVAL.
3211 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3212 Remove duplicated buffer name initialization.
3214 2012-05-02 Jim Meyering <jim@meyering.net>
3216 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3218 * xfns.c (x_window): Use xstrdup (Bug#11375).
3220 2012-05-02 Eli Zaretskii <eliz@gnu.org>
3222 * xdisp.c (pos_visible_p): If already at a newline from the
3223 display string before the 'while' loop, don't walk back the glyphs
3224 from it3.glyph_row. Solves assertion violation when the display
3225 string begins with a newline (egg.el). (Bug#11367)
3227 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3229 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3232 2012-05-01 Glenn Morris <rgm@gnu.org>
3234 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3235 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3236 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3237 All were removed before 23.1.
3239 * dispnew.c: Remove HAVE_LIBNCURSES test;
3240 it is always true on relevant platforms.
3242 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3243 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3245 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3247 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3249 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3250 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3253 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3255 Do not avoid creating empty evaporating overlays (Bug#9642).
3256 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3257 That is, do not delete an evaporating overlay if it becomes
3258 empty after its bounds are adjusted to fit within its buffer.
3259 This fix caused other problems, and I'm reverting it until we get
3260 to the bottom of them.
3262 2012-04-27 Chong Yidong <cyd@gnu.org>
3264 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3266 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3268 * xdisp.c (pos_visible_p): If the window start position is beyond
3269 ZV, start the display from buffer beginning. Prevents assertion
3270 violation in init_iterator when the minibuffer window is scrolled
3273 * window.c (window_scroll_pixel_based): Likewise.
3275 2012-04-27 Chong Yidong <cyd@gnu.org>
3277 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3279 2012-04-27 Glenn Morris <rgm@gnu.org>
3281 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3282 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3284 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3286 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3287 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
3289 2012-04-26 Eli Zaretskii <eliz@gnu.org>
3291 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3292 display element, check also the underlying string or buffer
3293 character. (Bug#11341)
3295 * w32menu.c: Include w32heap.h.
3296 (add_menu_item): If the call to AppendMenuW (via
3297 unicode_append_menu) fails, disable Unicode menus only if we are
3298 running on Windows 9X/Me.
3300 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3302 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3303 (xgetint): Add missing shift for LSB tags.
3305 2012-04-24 Martin Rudalics <rudalics@gmx.at>
3307 * keyboard.c (read_char): Don't wipe echo area for select window
3308 events: These might get delayed via `mouse-autoselect-window'
3311 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
3313 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3314 manipulation of :loaded-from data.
3316 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
3318 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3319 now a cons (bug#11311).
3321 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3323 Do not create empty overlays with the evaporate property (Bug#9642).
3324 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3325 if it becomes empty after its bounds are adjusted to fit within
3326 its buffer. Without this fix, in a nonempty buffer (let ((o
3327 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3328 yields an empty overlay that has the evaporate property, which is
3329 not supposed to happen.
3331 Fix minor GTK3 problems found by static checking.
3332 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3333 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3334 (struct _EmacsFixedClass, emacs_fixed_get_type):
3335 Move decls here from emacsgtkfixed.h, since they needn't be public.
3336 (emacs_fixed_get_type): Now static.
3337 (emacs_fixed_class_init): Omit unused local.
3338 (emacs_fixed_child_type): Remove; unused.
3339 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3340 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3341 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3342 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3343 (EMACS_FIXED_GET_CLASS): Remove; unused.
3344 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3346 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3347 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3349 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3351 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3352 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3353 (__malloc_size_t, __malloc_ptrdiff_t):
3354 Remove. All uses removed, replaced by the definiens if needed,
3355 since we can assume C89 or better now.
3356 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3357 (protect_malloc_state, align, get_contiguous_space)
3358 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3359 (malloc_atfork_handler_child, malloc_enable_thread)
3360 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3361 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3362 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3363 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3364 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3365 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3366 Define using prototypes, not old style.
3367 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3368 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3369 (align): Don't assume that signed integer overflow wraps around.
3370 Omit unused local var.
3371 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3372 (_free_internal_nolock, memalign, mallochook, reallochook):
3373 Omit no-longer-needed casts.
3374 (valloc): Use getpagesize, not __getpagesize.
3375 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3376 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3378 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3380 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3382 Move functions from C to Lisp. Make non-blocking method calls
3383 the default. Implement further D-Bus standard interfaces.
3385 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3386 (QCdbus_request_name_allow_replacement)
3387 (QCdbus_request_name_replace_existing)
3388 (QCdbus_request_name_do_not_queue)
3389 (QCdbus_request_name_reply_primary_owner)
3390 (QCdbus_request_name_reply_in_queue)
3391 (QCdbus_request_name_reply_exists)
3392 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3393 (QCdbus_registered_serial, QCdbus_registered_method)
3394 (QCdbus_registered_signal): New Lisp objects.
3395 (XD_DEBUG_MESSAGE): Use sizeof.
3396 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3397 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3398 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3399 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3400 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3401 (xd_signature, xd_append_arg): Allow float for integer types.
3402 (xd_get_connection_references): New function.
3403 (xd_get_connection_address): Rename from xd_initialize.
3404 Return cached address.
3405 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3406 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3408 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
3409 Return number of refcounts.
3410 (Fdbus_get_unique_name): Make stronger parameter check.
3411 (Fdbus_message_internal): New defun.
3412 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3413 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3414 (Fdbus_send_signal, Fdbus_register_service)
3415 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3416 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3417 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3418 (Vdbus_compiled_version, Vdbus_runtime_version)
3419 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3420 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3421 (Vdbus_message_type_signal): New defvars.
3422 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3425 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3427 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3428 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3429 Do not assume ptrdiff_t is the same width as 'int'.
3431 * alloc.c: Handle unusual debugging option combinations.
3432 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3433 since the two debugging options are incompatible.
3434 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3436 (mem_init, mem_insert, mem_insert_fixup):
3437 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3438 (NEED_MEM_INSERT): Remove; no longer needed.
3440 2012-04-22 Leo Liu <sdl.web@gmail.com>
3442 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3444 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3446 * sysdep.c [__FreeBSD__]: Minor cleanups.
3447 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3448 Use Emacs indenting style more consistently. Avoid some casts.
3449 Use 'double' consistently rather than mixing 'float' and 'double'.
3451 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3453 * sysdep.c (list_system_processes, system_process_attributes):
3454 Add implementation for FreeBSD (Bug#5243).
3456 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3458 * lisp.mk (lisp): Update.
3460 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3462 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3463 It is never used otherwise.
3465 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3467 * print.c (print_preprocess): Only check print_depth if print-circle
3469 (print_object): Check for cycles even when print-circle is nil and
3470 print-gensym is t, but only check print_depth if print-circle is nil.
3472 2012-04-20 Chong Yidong <cyd@gnu.org>
3474 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3475 set the status to "failed" and ensure that sentinel is run.
3477 2012-04-20 Glenn Morris <rgm@gnu.org>
3479 * process.c (Fset_process_inherit_coding_system_flag)
3480 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
3481 (Fmake_network_process, Fmake_serial_process): Doc fix.
3483 2012-04-20 Eli Zaretskii <eliz@gnu.org>
3485 * xdisp.c (string_buffer_position_lim): Limit starting position to
3487 (set_cursor_from_row): If called for a mode-line or header-line
3488 row, return zero immediately.
3489 (try_cursor_movement): If inside continuation line, don't back up
3490 farther than the first row after the header line, if any.
3491 Don't consider the header-line row as "partially visible", even if
3492 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3494 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3496 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3499 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
3500 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
3502 configure: new option --enable-gcc-warnings (Bug#11207)
3503 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3504 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3505 (ALL_CFLAGS): Use new macros rather than old.
3506 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3507 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3508 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3509 -Wunused-result, -Wunused-variable. This should go away once
3510 the Emacs and Gnulib regex code is merged.
3511 (xmalloc, xrealloc): Now static.
3513 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3515 * dired.c (Fsystem_groups): Remove unused local.
3517 2012-04-17 Glenn Morris <rgm@gnu.org>
3519 * dired.c (Fsystem_users): Doc fix.
3521 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3523 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3524 (syms_of_dired): Add them.
3526 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3528 Fix minor alloc.c problems found by static checking.
3529 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3530 New extern decls, to avoid calling undeclared functions.
3531 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3532 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3533 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3534 (NEED_MEM_INSERT): New macro.
3535 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
3536 Remove one incorrect comment and fix another.
3538 Fix minor ralloc.c problems found by static checking.
3539 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3540 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3541 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3542 (r_alloc_sbrk): Now static.
3544 Improve ralloc.c interface checking.
3545 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3546 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3547 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3548 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3549 [REL_ALLOC]: ... to here, to check interface.
3550 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3551 Remove decls. This fixes an "It stinks!".
3553 * alloc.c (which_symbols): Fix alignment issue / type clash.
3555 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3557 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3558 (struct Lisp_Misc_Any): Likewise.
3559 (struct Lisp_Free): Likewise.
3560 * alloc.c (union aligned_Lisp_Symbol): Define.
3561 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3562 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3563 (union aligned_Lisp_Misc): Define.
3564 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3565 aligned_Lisp_Misc instead of union Lisp_Misc.
3566 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
3568 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3570 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3571 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3572 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3573 * s/netbsd.h, s/sol2-6.h:
3574 Remove definition of GC_MARK_STACK, since the default now works.
3575 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3576 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3577 no longer the default.
3578 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3580 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3582 * lread.c (lisp_file_lexically_bound_p):
3583 Fix hang at ";-*-\n" (bug#11238).
3585 2012-04-14 Eli Zaretskii <eliz@gnu.org>
3587 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3588 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3590 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3592 * nsterm.m (constrainFrameRect): Always constrain when there is only
3593 one screen (Bug#10962).
3595 2012-04-13 Ken Brown <kbrown@cornell.edu>
3597 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3599 2012-04-13 Reuben Thomas <rrt@sc3d.org>
3601 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3603 2012-04-11 Daniel Colascione <dancol@dancol.org>
3605 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3606 against is gone. It's better to use vfork now so that when Cygwin
3607 gains a new, working vfork, we use it automatically (bug#10398).
3609 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3611 * window.c (save_window_save): Obey window-point-insertion-type.
3613 2012-04-11 Glenn Morris <rgm@gnu.org>
3615 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3617 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3619 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3621 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
3623 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3624 (force_quit_count): New var.
3625 (handle_interrupt): Use it.
3627 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
3629 * w32.c (w32_delayed_load): Record the full path of the library
3630 being loaded (bug#10424).
3632 2012-04-09 Glenn Morris <rgm@gnu.org>
3634 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3635 not just in the obarray, before snarfing them. (Bug#11036)
3637 * Makefile.in ($(leimdir)/leim-list.el):
3638 Pass EMACS rather than BUILT_EMACS.
3640 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3642 * process.c (make_process):
3643 * process.h: Add integer `gnutls_handshakes_tried' member to
3646 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3647 Add convenience `GNUTLS_LOG2i' macro.
3649 * gnutls.c (gnutls_log_function2i): Convenience log function.
3650 (emacs_gnutls_read): Use new log functions,
3651 `gnutls_handshakes_tried' process member, and
3652 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3653 attempts per process (connection).
3655 2012-04-09 Chong Yidong <cyd@gnu.org>
3657 * eval.c (Fuser_variable_p, user_variable_p_eh)
3658 (lisp_indirect_variable): Functions deleted.
3659 (Fdefvar): Caller changed.
3661 * callint.c (Finteractive, Fcall_interactively):
3662 * minibuf.c (Fread_variable): Callers changed.
3664 2012-04-09 Eli Zaretskii <eliz@gnu.org>
3666 * xdisp.c (set_cursor_from_row): If the display string appears in
3667 the buffer at position that is closer to point than the position
3668 after the display string, display the cursor on the first glyph of
3669 the display string. Fixes cursor display when a 'display' text
3670 property immediately follows invisible text. (Bug#11094)
3672 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3674 composite.c: use 'double' consistently
3675 * composite.c (get_composition_id): Use 'double' consistently
3676 instead of converting 'float' to 'double' and vice versa; this is
3677 easier to understand and avoids a GCC warning.
3679 2012-04-09 Glenn Morris <rgm@gnu.org>
3681 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3682 preparation for dumping it with emacs. (Bug#4789)
3683 (leimdir): New variable.
3684 ($(leimdir)/leim-list.el): New rule.
3685 (emacs$(EXEEXT)): Depend on leim-list.el.
3687 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3688 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3689 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3691 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3693 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3696 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
3698 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3699 Remove unused local variable.
3701 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3703 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3704 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3705 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3706 objects, as mark_maybe_pointer will catch them otherwise.
3707 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3708 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3710 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3712 Fix typo that broke non-Windows builds.
3713 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3715 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3717 Support building on MS-Windows with libxml2.
3719 * makefile.w32-in (OBJ2): Add xml.$(O).
3720 (GLOBAL_SOURCES): Add xml.c.
3721 ($(BLD)/xml.$(O)): New dependency list.
3723 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3724 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3725 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3726 [!WINDOWSNT]: New macros.
3727 (init_libxml2_functions, libxml2_loaded_p): New functions.
3728 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3729 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3730 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3731 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3733 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3734 Call init_libxml2_functions before calling libxml2 functions.
3735 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3737 * emacs.c: Don't include libxml/parser.h.
3738 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3739 xmlCleanupParser directly.
3741 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3743 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3745 * indent.c (Fvertical_motion): If there is a display string at
3746 point, use it.vpos to compute how many lines to backtrack after
3747 move_it_to point. (Bug#11133)
3749 2012-04-06 Eli Zaretskii <eliz@gnu.org>
3751 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3752 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3753 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3754 macros related to unification of CJK characters. For the details,
3755 see the discussion following the message here:
3756 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3758 2012-04-04 Chong Yidong <cyd@gnu.org>
3760 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3762 2012-04-01 Eli Zaretskii <eliz@gnu.org>
3764 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3765 instead of alloca. (Bug#11138)
3767 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3769 * w32menu.c (is_simple_dialog): Properly check lisp types.
3772 2012-03-31 Eli Zaretskii <eliz@gnu.org>
3774 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3775 position we get to after a call to move_it_to fails the
3776 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3777 only if we wind up in a string from display property. (Bug#11063)
3779 * window.c (Fdelete_other_windows_internal): Invalidate the row
3780 and column information about mouse highlight, so that redisplay
3781 restores it after reallocating the glyph matrices. (Bug#7464)
3783 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3784 string comes from a `display' text property, use the buffer
3785 position of that property as if we actually saw that position in
3787 (move_it_by_lines): Remove the assertion that
3788 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3789 violated when there's a before-string at the beginning of a line.
3792 2012-03-30 Eli Zaretskii <eliz@gnu.org>
3794 * xdisp.c (append_space_for_newline): If the default face was
3795 remapped, use the remapped face for the appended newline.
3796 (extend_face_to_end_of_line): Use the remapped default face for
3797 extending the face to the end of the line.
3798 (display_line): Call extend_face_to_end_of_line when the default
3799 face was remapped. (Bug#11068)
3801 2012-03-29 Eli Zaretskii <eliz@gnu.org>
3803 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3805 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3807 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3809 2012-03-27 Glenn Morris <rgm@gnu.org>
3811 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3814 2012-03-26 Kenichi Handa <handa@m17n.org>
3816 * dispextern.h (struct glyph): Fix previous change. Change the
3817 bit length of glyphless.ch to 25 (Bug#11082).
3819 2012-03-26 Chong Yidong <cyd@gnu.org>
3821 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3822 (command_loop_1): Use it; inhibit selection update for
3823 handle-select-window too (Bug#8996).
3825 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3827 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
3829 2012-03-25 Kenichi Handa <handa@m17n.org>
3831 * dispextern.h (struct glyph): Change the bit length of
3832 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3834 2012-03-24 Eli Zaretskii <eliz@gnu.org>
3836 * s/ms-w32.h (tzname): Include time.h before redirecting to
3837 _tzname. Fixes the MSVC build. (Bug#9960)
3839 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3841 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3844 * xterm.c (XTread_socket): Only modify handling_signal if
3845 !SYNC_INPUT. (Bug#11080)
3847 2012-03-23 Eli Zaretskii <eliz@gnu.org>
3849 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3850 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3851 when fetching a multibyte character consumes more bytes than
3852 CHAR_BYTES returns, due to unification of CJK characters in
3853 string_char. (Bug#11073)
3855 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3857 * process.c (wait_reading_process_output): Handle pty disconnect
3858 by refraining from sending oneself a SIGCHLD (bug#10933).
3860 2012-03-22 Chong Yidong <cyd@gnu.org>
3862 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3864 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
3865 Mark string as coming from a prefix property.
3866 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3867 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3869 2012-03-21 Chong Yidong <cyd@gnu.org>
3871 * xfaces.c (Vface_remapping_alist): Doc fix.
3873 2012-03-20 Eli Zaretskii <eliz@gnu.org>
3875 * w32proc.c (Fw32_set_console_codepage)
3876 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3879 2012-03-20 Chong Yidong <cyd@gnu.org>
3881 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3882 to reflect default non-nil value of redisplay-dont-pause.
3884 2012-03-19 Kenichi Handa <handa@m17n.org>
3886 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3887 it fit in a valid range (Bug#11003).
3889 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3891 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3892 that is not from display property, accept the row as a "cursor
3893 row" if one of the string's character has a non-nil `cursor'
3894 property. Fixes cursor positioning when there are newlines in
3895 overlay strings, e.g. in icomplete.el. (Bug#11035)
3897 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3899 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3901 2012-03-12 Chong Yidong <cyd@gnu.org>
3903 * eval.c (inhibit_lisp_code): Rename from
3904 inhibit_window_configuration_change_hook; move from window.c.
3906 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3907 * window.c (run_window_configuration_change_hook)
3908 (syms_of_window): Callers changed.
3910 2012-03-11 Chong Yidong <cyd@gnu.org>
3912 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3914 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3916 2012-03-10 Chong Yidong <cyd@gnu.org>
3918 * frame.c (other_visible_frames): Don't assume the selected frame
3919 is visible (Bug#10955).
3921 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3923 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3925 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3927 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3928 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3931 2012-03-03 Glenn Morris <rgm@gnu.org>
3933 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3935 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3937 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3938 position past the first glyph_row that ends at ZV. (Bug#10902)
3939 (redisplay_window, next_element_from_string): Fix typos in
3941 (redisplay_window): Pass to move_it_vertically the margin in
3942 pixels, not in screen lines.
3944 2012-03-02 Glenn Morris <rgm@gnu.org>
3946 * buffer.c (buffer-list-update-hook): Doc fix.
3948 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3950 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3951 push_it before setting up the iterator for the first overlay
3952 string, even if we have an empty string loaded.
3953 (next_overlay_string): If there's an empty string on the iterator
3954 stack, pop the stack. (Bug#10903)
3956 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3958 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3959 Suggested by Stefan Monnier in
3960 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3961 * alloc.c (widen_to_Lisp_Object): New static function.
3962 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3963 and widening them to Lisp_Objects. This would work even if
3964 USE_LSB_TAG is defined and wide integers are used, which might
3965 happen in a future version of Emacs.
3967 2012-02-25 Chong Yidong <cyd@gnu.org>
3969 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3972 * xselect.c (Fx_selection_exists_p): Doc fix.
3973 (x_clipboard_manager_save_all): Print an informative message
3974 before saving to clipboard manager.
3976 2012-02-24 Chong Yidong <cyd@gnu.org>
3978 * keyboard.c (process_special_events): Handle all X selection
3979 requests in kbd_buffer, not just the next one (Bug#8869).
3981 2012-02-23 Chong Yidong <cyd@gnu.org>
3983 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3984 call when setting menu-bar-lines and tool-bar-lines parameters.
3985 (unwind_create_frame_1): New helper function.
3987 * window.c (inhibit_window_configuration_change_hook): New var.
3988 (run_window_configuration_change_hook): Obey it.
3989 (syms_of_window): Initialize it.
3991 2012-02-22 Chong Yidong <cyd@gnu.org>
3993 * xterm.c (x_draw_image_relief): Add missing type check for
3994 Vtool_bar_button_margin (Bug#10743).
3996 2012-02-21 Chong Yidong <cyd@gnu.org>
3998 * fileio.c (Vfile_name_handler_alist): Doc fix.
4000 * buffer.c (Fget_file_buffer): Protect against invalid file
4001 handler return value.
4003 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4005 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4006 when computing $valmask.
4008 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4009 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4010 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4011 It's useless in that case, and it can cause problems on hosts
4012 that allocate halves of EMACS_INT values separately.
4013 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4014 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4015 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4016 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4017 it avoids undefined behavior on hosts where shifting right by more
4018 than the word width has undefined behavior.
4020 2012-02-19 Chong Yidong <cyd@gnu.org>
4022 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4023 (Funhandled_file_name_directory, Ffile_name_as_directory)
4024 (Fdirectory_file_name, Fexpand_file_name)
4025 (Fsubstitute_in_file_name): Protect against invalid file handler
4026 return values (Bug#10845).
4028 2012-02-18 Eli Zaretskii <eliz@gnu.org>
4030 * .gdbinit (pitx): Fix incorrect references to fields of the
4033 2012-02-17 Chong Yidong <cyd@gnu.org>
4035 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4037 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4039 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4040 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4042 2012-02-15 Chong Yidong <cyd@gnu.org>
4044 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4045 marked as special. Also, starting docstrings with * is obsolete.
4047 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4049 * gnutls.c (emacs_gnutls_write): Fix last change.
4051 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4053 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4056 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4058 * keymap.c (Fsingle_key_description): Handle char ranges.
4060 2012-02-12 Chong Yidong <cyd@gnu.org>
4062 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4063 as that creates a dangerous corner case.
4065 * window.c (Fdelete_window_internal): Invalidate the mouse
4066 highlight (Bug#9904).
4068 2012-02-12 Glenn Morris <rgm@gnu.org>
4070 * xselect.c (Fx_own_selection_internal)
4071 (Fx_get_selection_internal, Fx_disown_selection_internal)
4072 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4073 * nsselect.m (Fx_own_selection_internal)
4074 (Fx_disown_selection_internal, Fx_selection_exists_p)
4075 (Fx_selection_owner_p, Fx_get_selection_internal):
4076 Sync docs and argument specs with the xselect.c versions.
4078 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4080 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4082 2012-02-11 Eli Zaretskii <eliz@gnu.org>
4084 * w32select.c (Fx_selection_exists_p): Sync doc string and
4085 argument list with xselect.c. (Bug#10783)
4087 * w16select.c (Fx_selection_exists_p): Sync doc string and
4088 argument list with xselect.c. (Bug#10783)
4090 2012-02-10 Glenn Morris <rgm@gnu.org>
4092 * fns.c (Fsecure_hash): Doc fix.
4094 2012-02-09 Kenichi Handa <handa@m17n.org>
4096 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4098 2012-02-07 Chong Yidong <cyd@gnu.org>
4100 * buffer.c (Fbuffer_local_variables)
4101 (buffer_lisp_local_variables): Handle unbound vars correctly;
4102 don't let Qunbound leak into Lisp.
4104 2012-02-07 Glenn Morris <rgm@gnu.org>
4106 * image.c (Fimagemagick_types): Doc fix.
4108 * image.c (imagemagick-render-type): Change it from a lisp object
4109 to an integer. Move the doc here from the lisp manual.
4110 Treat all values not equal to 0 the same.
4112 2012-02-06 Chong Yidong <cyd@gnu.org>
4114 * doc.c (store_function_docstring): Avoid applying docstring of
4115 alias to base function (Bug#2603).
4117 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4119 * .gdbinit (pp1, pv1): Remove redundant defines.
4122 2012-02-04 Chong Yidong <cyd@gnu.org>
4124 * nsterm.m: Declare a global (Bug#10694).
4126 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4128 * w32.c (get_emacs_configuration_options):
4129 Include --enable-checking, if specified, in the return value.
4131 2012-02-04 Martin Rudalics <rudalics@gmx.at>
4133 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4134 after rounding frame sizes. (Bug#9723)
4136 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4138 * keyboard.c (adjust_point_for_property): Don't position point
4139 before BEGV. (Bug#10696)
4141 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4143 Handle overflow when computing char display width (Bug#9496).
4144 * character.c (char_width): Return EMACS_INT, not int.
4145 (char_width, c_string_width): Check for overflow when
4146 computing the width; this is possible now that individual
4147 characters can have unbounded width. Problem introduced
4148 by merge from Emacs 23 on 2012-01-19.
4150 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
4152 * dbusbind.c (Fdbus_register_method): Mention the return value
4153 :ignore in the docstring.
4155 2012-02-02 Glenn Morris <rgm@gnu.org>
4157 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4159 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4160 Unconditionally set to t. (Bug#10673)
4161 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4162 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4163 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4165 2012-02-02 Kenichi Handa <handa@m17n.org>
4167 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4168 0, do not call append_composite_glyph.
4170 2012-02-02 Kenichi Handa <handa@m17n.org>
4172 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4174 (x_produce_glyphs): If the component of a composition is a null
4175 string, set it->pixel_width to 1 to avoid zero-width glyph.
4177 2012-02-01 Eli Zaretskii <eliz@gnu.org>
4179 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4180 first 2 arguments are identical. This makes inserting large
4181 output from a subprocess an order of magnitude faster on
4182 MS-Windows, where all sbrk'ed memory is always contiguous.
4184 2012-01-31 Glenn Morris <rgm@gnu.org>
4186 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4187 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4188 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4190 2012-01-29 Glenn Morris <rgm@gnu.org>
4192 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4194 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4196 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4198 2012-01-28 Chong Yidong <cyd@gnu.org>
4200 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4202 2012-01-26 Chong Yidong <cyd@gnu.org>
4204 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4206 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4207 repeat counts (Bug#10507).
4209 2012-01-26 Glenn Morris <rgm@gnu.org>
4211 * lread.c (syms_of_lread): Doc fix.
4213 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4215 * coding.c (encode_designation_at_bol): Change return value to
4218 2012-01-25 Chong Yidong <cyd@gnu.org>
4220 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4222 2012-01-21 Chong Yidong <cyd@gnu.org>
4224 * floatfns.c (Fcopysign): Make the second argument non-optional,
4225 since nil is not allowed anyway.
4227 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4229 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4230 (send_process): Likewise.
4232 2012-01-19 Martin Rudalics <rudalics@gmx.at>
4234 * window.c (save_window_save, Fcurrent_window_configuration)
4235 (Vwindow_persistent_parameters): Do not use Qstate.
4236 Rewrite doc-strings.
4238 2012-01-19 Kenichi Handa <handa@m17n.org>
4240 * character.c (char_width): New function.
4241 (Fchar_width, c_string_width, lisp_string_width):
4242 Use char_width (Bug#9496).
4244 2012-01-16 Martin Rudalics <rudalics@gmx.at>
4246 * window.c (Vwindow_persistent_parameters): New variable.
4247 (Fset_window_configuration, save_window_save): Handle persistent
4250 2012-01-14 Eli Zaretskii <eliz@gnu.org>
4252 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4253 thrashing the stack of the thread. (Bug#9087)
4255 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4257 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4259 2012-01-11 Eli Zaretskii <eliz@gnu.org>
4261 * xdisp.c (rows_from_pos_range): Handle the case where the
4262 highlight ends on a newline. (Bug#10464)
4263 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4264 he end column for display of highlight that ends on a newline
4267 2012-01-11 Glenn Morris <rgm@gnu.org>
4269 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4270 from load-path also when installation-directory is nil. (Bug#10208)
4272 2012-01-10 Glenn Morris <rgm@gnu.org>
4274 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4276 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4277 Update template values to be closer to their typical values these days.
4279 2012-01-09 Eli Zaretskii <eliz@gnu.org>
4281 * xdisp.c (rows_from_pos_range): Accept additional argument
4282 DISP_STRING, and accept any glyph in a row whose object is that
4283 string as eligible for mouse highlight. Fixes mouse highlight of
4284 display strings from overlays. (Bug#10464)
4286 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
4288 emacs: fix an auto-save permissions race condition (Bug#10400)
4289 * fileio.c (auto_saving_dir_umask): New static var.
4290 (Fmake_directory_internal): Use it.
4291 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4292 creating the directory. The old code temporarily assigns
4293 too-generous permissions to the directory.
4294 (do_auto_save_eh): Clear it.
4295 (Fdo_auto_save): Catch all errors, not just file errors, so
4296 that the var is always cleared.
4298 2012-01-07 Eli Zaretskii <eliz@gnu.org>
4300 * search.c (scan_buffer): Pass character positions to
4301 know_region_cache, not byte positions. (Bug#6540)
4303 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
4305 * w32.c (sys_rename): Report EXDEV when rename of a directory
4306 fails because the target is on another logical disk. (Bug#10284)
4308 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4310 * xterm.c (x_embed_request_focus): New function.
4312 * xterm.h: Add prototype.
4314 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4316 2012-01-05 Glenn Morris <rgm@gnu.org>
4318 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4320 2012-01-01 Eli Zaretskii <eliz@gnu.org>
4322 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4323 Load gnutls_transport_set_lowat only if GnuTLS version is below
4325 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4326 GnuTLS versions below 2.11.1.
4328 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4330 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4331 to the doc string advising against its use for altering the way
4332 windows are scrolled.
4334 2011-12-28 Kenichi Handa <handa@m17n.org>
4336 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4337 coding-system ASCII compatible only when it does not produce BOM
4338 on encoding (Bug#10383).
4340 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4342 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4344 (create_and_show_popup_menu): Always use menu_position_func for
4347 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4349 * callint.c (Fcall_interactively): Don't truncate prompt string.
4351 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4353 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4354 property that ends at ZV, so that the bidi iteration could be
4355 resumed from there (after widening). (Bug#10360)
4357 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4359 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4361 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4363 * nsterm.m (x_free_frame_resources):
4364 Release f->output_data.ns->miniimage.
4365 (ns_index_color): Fix indentation. Do not retain
4366 color_table->colors[i].
4368 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4371 * nsfns.m (x_set_background_color): Assign return value from
4372 ns_index_color to face-background instead of NSColor*.
4373 (ns_implicitly_set_icon_type): Fix indentation.
4374 Change assignment in for loop to comparison.
4376 * emacs.c (ns_pool): New variable.
4377 (main): Assign ns_pool.
4378 (Fkill_emacs): Call ns_release_autorelease_pool.
4380 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4381 autorelease fdesc, release fdAttrs and tdict.
4382 (ns_get_covering_families): Release charset.
4383 (ns_findfonts): Release NSFontDescriptor created with new.
4384 (ns_uni_to_glyphs): Fix indentation.
4385 (setString): Release attrStr before assigning new value.
4387 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4389 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4391 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4392 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4394 2011-12-18 David Reitter <reitter@cmu.edu>
4396 * nsterm.m (ns_term_init): Subscribe for notifications
4397 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4398 to method trackingNotification in EmacsMenu.
4400 * nsmenu.m (trackingMenu): New variable.
4401 (trackingNotification): New method (from Aquamacs).
4402 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4403 from Aquamacs (Bug#7030).
4405 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4407 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4408 (symbol_to_nsstring): Fix indentation.
4409 (ns_symbol_to_pb): New function.
4410 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4411 (Fns_rotate_cut_buffers_internal): Remove.
4412 (Fns_store_selection_internal): Rename from
4413 Fns_store_cut_buffer_internal.
4414 (ns_get_foreign_selection, Fx_own_selection_internal)
4415 (Fx_disown_selection_internal, Fx_selection_exists_p)
4416 (Fns_get_selection_internal, Fns_store_selection_internal):
4417 Use ns_symbol_to_pb and check if return value is nil.
4418 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4419 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
4420 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4421 renamed to Sns_store_selection_internal.
4422 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4423 and remove this function.
4424 (ns_handle_selection_clear): Remove, never used.
4425 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4428 2011-12-17 Ken Brown <kbrown@cornell.edu>
4430 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4431 GID is unknown (Bug#10257).
4433 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4435 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4436 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4437 which caused a build failure on GNU/Linux IA-64. This problem was
4438 introduced by my 2011-10-07 patch.
4440 2011-12-15 Juri Linkov <juri@jurta.org>
4442 * image.c (imagemagick_error): New function. (Bug#10112)
4443 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4444 Use `imagemagick_error' where ImageMagick functions return
4446 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4449 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4451 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4452 fill background (Bug#8992).
4454 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4456 * window.c (Vwindow_combination_resize)
4457 (Vwindow_combination_limit): Use t instead of non-nil in
4459 (Vrecenter_redisplay): Add first sentence of doc-string on
4461 (Frecenter): Fix doc-string typo.
4463 2011-12-11 Kenichi Handa <handa@m17n.org>
4465 * coding.c (Funencodable_char_position): Pay attention to the
4466 buffer text relocation (Bug#9389).
4468 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4470 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4471 gtk_init (Bug#10100).
4473 2011-12-10 Eli Zaretskii <eliz@gnu.org>
4475 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4476 IT->string is nil. (Bug#10263)
4478 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4480 * nsterm.h (x_free_frame_resources): Declare.
4482 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4483 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4485 * nsterm.h (ns_get_defaults_value): Declare.
4487 * nsterm.m (ns_default): Call ns_get_defaults_value.
4489 2011-12-09 Eli Zaretskii <eliz@gnu.org>
4491 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4494 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4496 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4497 that where the value of an _OBJC_* symbol points to is in the .bss
4498 section (Bug#10240).
4500 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4502 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
4503 after the loop to call ccl_driver at least once (Bug#8619).
4505 2011-12-08 Kenichi Handa <handa@m17n.org>
4507 * ftfont.c (get_adstyle_property): Fix previous change
4510 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
4512 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4513 dirs from the default value of EMACSLOADPATH (bug#10208).
4515 2011-12-07 Glenn Morris <rgm@gnu.org>
4517 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4518 installation and source directories as well. (Bug#10208)
4520 2011-12-06 Chong Yidong <cyd@gnu.org>
4522 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4524 2011-12-06 Glenn Morris <rgm@gnu.org>
4526 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4527 as an error, not just -1. (Bug#10217)
4529 2011-12-05 Chong Yidong <cyd@gnu.org>
4531 * keyboard.c (process_special_events): New function.
4532 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4534 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4536 * coding.c (encode_designation_at_bol): Don't use uninitialized
4537 local variable (Bug#9318).
4539 2011-12-05 Kenichi Handa <handa@m17n.org>
4541 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4542 return Qnil (Bug#8046, Bug#10193).
4544 2011-12-05 Kenichi Handa <handa@m17n.org>
4546 * coding.c (encode_designation_at_bol): New args charbuf_end and
4547 dst. Return the number of produced bytes. Callers changed.
4548 (coding_set_source): Return how many bytes coding->source was
4550 (coding_set_destination): Return how many bytes
4551 coding->destination was relocated.
4552 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
4553 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
4555 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4557 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4558 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4561 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4563 The following changes are to fix Bug#9318.
4565 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
4566 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4567 (encode_coding_iso_2022, encode_coding_sjis)
4568 (encode_coding_big5, encode_coding_charset): Use the above macros.
4570 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
4572 * lisp.h (process_quit_flag): Fix external declaration.
4574 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4576 Don't macro-inline non-performance-critical code.
4577 * eval.c (process_quit_flag): New function.
4578 * lisp.h (QUIT): Use it.
4580 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4582 * nsfns.m (get_geometry_from_preferences): New function.
4583 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4585 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4587 * emacs.c (Qkill_emacs): Define.
4588 (syms_of_emacs): Initialize it.
4589 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4590 Qquit_flag to `kill-emacs' instead.
4591 (quit_throw_to_read_char): Add parameter `from_signal'.
4592 All callers changed. Call Fkill_emacs if requested and safe.
4593 * lisp.h (QUIT): Call Fkill_emacs if requested.
4595 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4597 * widget.c (update_wm_hints): Return if wmshell is null.
4598 (widget_update_wm_size_hints): New function.
4600 * widget.h (widget_update_wm_size_hints): Declare.
4602 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4603 widget_update_wm_size_hints (Bug#10104).
4605 2011-12-03 Eli Zaretskii <eliz@gnu.org>
4607 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4608 before a newline, prepare the bidi iterator for consuming the
4609 newline, and keep the current paragraph direction. (Bug#10183)
4610 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
4612 2011-12-02 Juri Linkov <juri@jurta.org>
4614 * search.c (Fword_search_regexp): New Lisp function created from
4615 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4616 (Fword_search_backward, Fword_search_forward)
4617 (Fword_search_backward_lax, Fword_search_forward_lax):
4618 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4619 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4621 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4623 * fileio.c (Finsert_file_contents): Move after-change-function call
4624 to before the "handled:" label, since all "goto handled" appear in
4625 cases where the *-change-functions have already been properly called
4628 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4630 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4631 waiting for input. (Bug#10169)
4633 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4635 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4636 verifies glyph row's hash code--we have just reallocated the
4637 glyphs, so their contents can be complete garbage. (Bug#10164)
4639 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
4641 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4643 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4645 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4646 attributes are tested _before_ calling verify_row_hash, to protect
4647 against GCC re-ordering of the tests. (Bug#10164)
4649 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4651 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4653 * xterm.c (handle_one_xevent): Only set async_visible and friends
4654 if net_wm_state_hidden_seen is non-zero (Bug#10002)
4655 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
4656 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4658 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4660 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4661 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4662 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4663 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4664 All uses changed to use GCPRO1 etc.
4665 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4666 Revert to old implementation (i.e., before 2011-03-11).
4668 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4670 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4671 of scroll runs so as to avoid assigning disabled bogus rows and
4672 unnecessary graphics copy operations.
4674 2011-11-27 Eli Zaretskii <eliz@gnu.org>
4676 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4677 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4678 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4679 (malloc, free, realloc, calloc): Redirect to e_* only when
4682 * lisp.h (GCTYPEBITS): Move before first use.
4683 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4684 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4685 this macro definition.
4687 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4690 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4692 * gtkutil.c (xg_create_frame_widgets):
4693 Call gtk_window_set_has_resize_grip (FALSE) if that function is
4694 present with Gtk+ 2.0.
4696 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4698 * fileio.c (Finsert_file_contents): Undo previous change; see
4699 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4701 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4703 Rename locals to avoid shadowing.
4704 * fileio.c (Finsert_file_contents):
4705 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4706 * process.c (wait_reading_process_output):
4707 Rename inner 'proc' to 'p' to avoid shadowing.
4708 Indent for consistency with usual Emacs style.
4710 2011-11-25 Eli Zaretskii <eliz@gnu.org>
4712 * xdisp.c (redisplay_window): If cursor row is not fully visible
4713 after recentering, and scroll-conservatively is set to a large
4714 number, scroll window by a few more lines to make the cursor fully
4715 visible and out of scroll-margin. (Bug#10105)
4716 (start_display): Don't move to the next line if the display should
4717 start at a newline that is part of a display vector or an overlay
4720 2011-11-24 Juri Linkov <juri@jurta.org>
4722 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4723 after the `MagickPingImage' call. (Bug#10112)
4725 2011-11-23 Chong Yidong <cyd@gnu.org>
4727 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4729 2011-11-23 Martin Rudalics <rudalics@gmx.at>
4731 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4732 making another buffer current. (Bug#10114)
4734 2011-11-23 Glenn Morris <rgm@gnu.org>
4736 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4738 2011-11-23 Chong Yidong <cyd@gnu.org>
4740 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4741 using it (Bug#5984).
4743 2011-11-22 Eli Zaretskii <eliz@gnu.org>
4745 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4746 and header-lines, as they don't have one computed for them.
4749 * .gdbinit (prow): Make displayed values more self-explaining.
4750 Add row's hash code.
4752 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4754 * process.c (wait_reading_process_output): Fix asynchrounous
4755 GnuTLS socket handling on some versions of the GnuTLS library.
4756 (wait_reading_process_output): Add comment and URL.
4758 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4760 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4762 2011-11-21 Chong Yidong <cyd@gnu.org>
4764 * window.c (Fnext_window, Fprevious_window): Doc fix.
4766 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4768 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4770 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4772 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4774 2011-11-20 Martin Rudalics <rudalics@gmx.at>
4776 * window.c (Fset_window_combination_limit): Rename argument
4778 (Vwindow_combination_limit): Remove "status" from doc-string.
4780 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4782 * m/ibms390.h: Remove.
4783 * m/ibms390x.h: Don't include "ibms390.h".
4785 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4787 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4788 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4790 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4792 * casetab.c (Fset_case_table):
4793 * charset.c (Fcharset_after): Fix typos.
4795 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
4797 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4798 Otherwise, valgrind does not work on some platforms.
4799 Problem reported by Andreas Schwab in
4800 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4801 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4802 is set, removing the need for VIRT_ADDRESS_VARIES.
4803 (PURE_P): Use a more-efficient implementation that needs just one
4804 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4805 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4806 to 4 (xorl, subq, cmpq, setbe).
4807 * alloc.c (pure): Always extern now, since that's the
4808 VIRT_ADDR_VARIES behavior.
4809 (PURE_POINTER_P): Use a single comparison, not two, for
4810 consistency with the new puresize.h.
4811 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4812 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4813 Remove VIRT_ADDR_VARIES no longer needed.
4815 2011-11-19 Eli Zaretskii <eliz@gnu.org>
4817 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4818 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4819 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4820 behave as if the cursor position were at the window margin.
4822 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4823 and the cursor position is out of bounds, behave as if the cursor
4824 position were at the window margin. (Bug#10075)
4826 2011-11-18 Chong Yidong <cyd@gnu.org>
4828 * window.c (Fwindow_combination_limit): Make first argument
4829 non-optional, since it is meaningless for live windows like the
4832 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4834 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4836 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4838 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4839 (graft_intervals_into_buffer): Simplify.
4841 2011-11-18 Eli Zaretskii <eliz@gnu.org>
4843 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4844 hash values of the two rows.
4845 (copy_row_except_pointers): Preserve the used[] arrays and the
4846 hash values of the two rows. (Bug#10035)
4847 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
4849 * xdisp.c (row_hash): New function, body extracted from
4850 compute_line_metrics.
4851 (compute_line_metrics): Call row_hash, instead of computing the
4854 * dispnew.c (verify_row_hash): Call row_hash for computing the
4855 hash code of a row, instead of duplicating code from xdisp.c.
4857 * dispextern.h (row_hash): Add prototype.
4859 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4861 * frame.c (delete_frame): Don't delete the terminal when the last
4862 X frame is closed if emacs is built with GTK toolkit.
4864 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
4866 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4868 2011-11-17 Martin Rudalics <rudalics@gmx.at>
4870 * window.c (Vwindow_splits): Rename to
4871 Vwindow_combination_resize. Suggested by Juri Linkov.
4872 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4875 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
4877 * nsfns.m (Fns_font_name):
4878 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4880 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4882 * window.h (window): Rename slot "nest" to "combination_limit".
4883 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4884 (Fset_window_nest): Rename to Fset_window_combination_limit.
4885 (Vwindow_nest): Rename to Vwindow_combination_limit.
4886 (recombine_windows, make_parent_window, make_window)
4887 (Fsplit_window_internal, saved_window)
4888 (Fset_window_configuration, save_window_save): Rename all
4889 occurrences of window_nest to window_combination_limit.
4891 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4893 * image.c (imagemagick_load_image): Fix typo.
4895 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4897 * xdisp.c (display_line): Move the call to
4898 highlight_trailing_whitespace before the call to
4899 compute_line_metrics, since the latter needs to see the final
4900 faces of all the glyphs to compute ROW's hash value.
4901 Fixes assertion violations in row_equal_p. (Bug#10035)
4903 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4905 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4906 just return (bug#10044).
4908 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4910 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4911 with user-defined heap size. Bump the default size of the temacs
4912 heap to 27MB, to avoid memory warning when running temacs.
4913 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4915 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4916 current_matrix and desired_matrix. (Bug#9990)
4917 (verify_row_hash) [XASSERTS]: New function.
4918 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4919 that the hash value of glyph rows is correct.
4921 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4923 * window.h (window): Remove splits slot.
4924 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4925 (Fdelete_other_windows_internal, make_parent_window)
4926 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4927 (Fset_window_configuration, save_window_save): Don't deal with
4928 split status of windows.
4929 (saved_window): Remove splits slot.
4930 (Vwindow_splits): Rewrite doc-string.
4932 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4934 * xfns.c (unwind_create_frame):
4935 * nsfns.m (unwind_create_frame):
4936 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4937 Vframe_list (Bug#9999).
4939 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4941 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4943 2011-11-11 Kenichi Handa <handa@m17n.org>
4945 * callproc.c (Fcall_process): Set the member dst_multibyte of
4948 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4950 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4951 avoid a crash (bug#9496).
4953 2011-11-09 Chong Yidong <cyd@gnu.org>
4955 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4956 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4958 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4960 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4962 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4964 Avoid some portability problems by eschewing 'extern inline' functions.
4965 The trivial performance wins aren't worth the portability hassles; see
4966 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4968 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4969 (window_box_width, window_box_left, window_box_left_offset)
4970 (window_box_right, window_box_right_offset): Undo previous change,
4971 by removing the "extern"s.
4972 * intervals.c (adjust_intervals_for_insertion)
4973 (adjust_intervals_for_deletion): Undo previous change,
4974 making these static again.
4975 (offset_intervals, temp_set_point_both, temp_set_point)
4976 (copy_intervals_to_string): No longer inline.
4977 * xdisp.c (window_text_bottom_y, window_box_width)
4978 (window_box_height, window_box_left_offset)
4979 (window_box_right_offset, window_box_left, window_box_right)
4980 (window_box): No longer inline.
4982 2011-11-08 Chong Yidong <cyd@gnu.org>
4984 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4985 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4986 Signal an error if not a live window.
4987 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4988 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4990 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4992 * lisp.h (syms_of_abbrev): Remove declaration.
4993 Reported by CHENG Gao <chenggao@royau.me>.
4995 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4997 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4998 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4999 of temacs in GUI mode.
5001 2011-11-07 Martin Rudalics <rudalics@gmx.at>
5003 * window.h: Declare delete_all_child_windows instead of
5004 delete_all_subwindows.
5005 * window.c (Fwindow_nest, Fset_window_nest)
5006 (Fset_window_new_total, Fset_window_new_normal)
5007 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5008 (delete_all_subwindows): Rename to delete_all_child_windows.
5009 (Fdelete_other_windows_internal, Fset_window_configuration):
5010 Call delete_all_child_windows instead of delete_all_subwindows.
5011 * frame.c (delete_frame): Call delete_all_child_windows instead
5012 of delete_all_subwindows.
5014 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5016 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5017 This is also needed for porting to any host where GC_MARK_STACK is
5018 not GC_MAKE_GCPROS_NOOPS.
5019 (which_symbols): Use it.
5021 2011-11-07 Kenichi Handa <handa@m17n.org>
5023 * coding.c (coding_set_destination): Check coding->src_pos only
5024 when coding->src_object is a buffer (bug#9910).
5026 * process.c (send_process): Set the member src_multibyte of coding
5027 to 0 (bug#9911) when sending a unibyte text.
5029 * callproc.c (Fcall_process): Set the member src_multibyte of
5030 process_coding to 0 (bug#9912).
5032 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5034 * xmenu.c (cleanup_widget_value_tree): New function.
5035 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5036 calling free_menubar_widget_value_tree directly (Bug#9830).
5038 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5040 Fix some portability problems with 'inline'.
5041 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5042 (window_box_width, window_box_left, window_box_left_offset)
5043 (window_box_right, window_box_right_offset): Declare extern.
5044 Otherwise, these inline functions do not conform to C99 and
5045 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5046 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5047 * intervals.c (adjust_intervals_for_insertion)
5048 (adjust_intervals_for_deletion): Now extern, because otherwise the
5049 extern inline functions 'offset_intervals' couldn't refer to it.
5050 (static_offset_intervals): Remove.
5051 (offset_intervals): Rewrite using the old contents of
5052 static_offset_intervals. The old version didn't conform to C99
5053 because an extern inline function contained a reference to an
5054 identifier with static linkage.
5056 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5058 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5061 2011-11-06 Eli Zaretskii <eliz@gnu.org>
5063 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5064 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5065 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5066 return Qleft_to_right.
5068 2011-11-06 Chong Yidong <cyd@gnu.org>
5070 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5071 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5072 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5073 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5074 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5075 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5076 (Fwindow_vscroll): Doc fix.
5077 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5078 argument, since it makes no sense to pass a live window and for
5079 consistency with window-child.
5081 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5083 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5086 2011-11-05 Jason Rumney <jasonr@gnu.org>
5088 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5089 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5091 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5092 bitwise arithmetic preventing use of unicode-sip and non-truetype
5095 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5097 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5100 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5101 initialization code to keep similarity to xfns.c after changes
5104 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5106 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5107 (unwind_create_frame): New function (Bug#9943).
5108 (Fx_create_frame): Restructure code to be more similar to the one in
5109 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5110 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5111 Move terminal->reference_count++ just before making the frame official
5114 * nsterm.m (x_free_frame_resources): New function.
5115 (x_destroy_window): Move code to x_free_frame_resources.
5117 * xfns.c (unwind_create_frame): Fix comment.
5118 (Fx_create_frame, x_create_tip_frame):
5119 Move terminal->reference_count++ just before making the frame
5120 official. Move initialization of image_cache_refcount and
5121 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5123 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5125 Support MSVC build with newer versions of Visual Studio.
5126 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5127 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5130 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5131 which are not supported by MSVC.
5132 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5133 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5135 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5137 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5139 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5141 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
5143 Support MSVC build with newer versions of Visual Studio.
5144 * w32.c: Don't include w32api.h for MSVC.
5145 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5147 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5148 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5149 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5150 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5152 (alloca) [_MSC_VER]: Define to _alloca.
5154 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5156 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5158 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5160 * xdisp.c (note_mouse_highlight): If either of
5161 previous/next-single-property-change returns nil, treat that as
5162 the beginning or the end of the buffer. (Bug#9955)
5164 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5166 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
5167 label is not null (Bug#9951).
5168 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5171 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5173 * window.c (Fwindow_body_size): Mention in the doc string that the
5174 return value is in frame's canonical units. (Bug#9949)
5176 2011-11-03 Eli Zaretskii <eliz@gnu.org>
5178 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5180 * w32fns.c (unwind_create_frame): If needed, free the glyph
5181 matrices of the partially constructed frame. (Bug#9943)
5182 * xfns.c (unwind_create_frame): Likewise.
5184 2011-11-01 Eli Zaretskii <eliz@gnu.org>
5186 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5187 Don't stop backward scan on the continuation glyph, even though
5188 its CHARPOS is positive.
5189 (mouse_face_from_buffer_pos, note_mouse_highlight):
5190 Rename cover_string to disp_string.
5192 2011-11-01 Martin Rudalics <rudalics@gmx.at>
5194 * window.c (temp_output_buffer_show): Don't use
5195 Vtemp_buffer_show_specifiers.
5196 (Vtemp_buffer_show_specifiers): Remove unused variable.
5198 2011-10-30 Eli Zaretskii <eliz@gnu.org>
5200 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5201 past the beginning of the current glyph matrix.
5203 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
5205 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5206 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5207 HAVE_GTK3 (Bug#9869).
5209 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5210 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5212 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5214 * xterm.c: Declare x_handle_net_wm_state to return int.
5215 (handle_one_xevent): Check if we are iconified but don't have
5216 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5217 (get_current_wm_state): Return non-zero if not hidden,
5218 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5219 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5220 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5221 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5223 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5225 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5226 so that this new function doesn't get optimized away by a
5227 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5229 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5231 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5233 2011-10-29 Eli Zaretskii <eliz@gnu.org>
5235 Fix the `xbytecode' command.
5236 * .gdbinit (xprintbytestr): New command.
5237 (xwhichsymbols): Rename from `which'; all callers changed.
5238 (xbytecode): Print the byte-code string as well.
5240 2011-10-29 Kim Storm <storm@cua.dk>
5242 * alloc.c (which_symbols): New function.
5244 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5246 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5249 2011-10-29 Glenn Morris <rgm@gnu.org>
5251 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5252 Not clear what it was for, and it causes various bugs. (Bug#9839)
5254 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5256 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5257 possible random value that matches one of those tested as
5258 condition to clear the mouse face.
5260 2011-10-28 Chong Yidong <cyd@gnu.org>
5262 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5264 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5266 * window.c (make_window): Initialize phys_cursor_on_p.
5268 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5270 * lisp.h (struct Lisp_Symbol): Update comments.
5272 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
5274 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5276 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5278 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5279 <oslsachem@gmail.com> for helping to debug this.
5281 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5282 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5283 (g_b_init_get_glyph_outline_w): New static variables.
5284 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5285 (GetGlyphOutlineW_Proc): New typedefs.
5286 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
5287 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5289 (w32font_open_internal, compute_metrics):
5290 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
5291 instead of calling the "wide" APIs directly.
5293 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5295 * w32.h (syms_of_w32font): Add prototype.
5297 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5299 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5300 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5301 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5302 (Fmove_to_window_line): Doc fix.
5304 2011-10-27 Chong Yidong <cyd@gnu.org>
5306 * process.c (make_process): Set gnutls_state to NULL.
5308 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5309 non-NULL, regardless of GNUTLS_INITSTAGE.
5310 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5311 an error. Set process slots as soon as we allocate them.
5313 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5315 2011-10-27 Chong Yidong <cyd@gnu.org>
5317 * gnutls.c (emacs_gnutls_deinit): New function.
5318 Deallocate credentials structures as well as calling gnutls_deinit.
5319 (Fgnutls_deinit, Fgnutls_boot): Use it.
5321 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5322 (deactivate_process): Call emacs_gnutls_deinit.
5324 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5326 * image.c (x_create_x_image_and_pixmap):
5327 * w32.c (sys_rename, w32_delayed_load):
5328 * w32font.c (fill_in_logfont):
5329 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5331 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
5333 * w32fns.c (w32_default_color_map): New function,
5334 extracted from Fw32_default_color_map.
5335 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5337 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5339 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5341 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5343 * keyboard.c (test_undefined): New function (bug#9751).
5344 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5346 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5348 * sysdep.c (init_sys_modes): Fix the check for the controlling
5349 terminal (Bug#6649).
5351 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5353 * dispextern.h (struct bidi_it): New member next_en_type.
5355 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5356 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5357 current character, check also for next_en_type being WEAK_EN.
5358 (bidi_resolve_weak): Don't enter the expensive loop if the current
5359 position is before next_en_pos. Record the bidi type of the first
5360 non-ET, non-BN character we find, in addition to its position.
5361 (bidi_level_of_next_char): Invalidate next_en_type when
5362 next_en_pos is over-stepped.
5364 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5366 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5367 * editfns.c: Rewrite current-time-zone so that it invokes
5368 the equivalent of (format-time-string "%Z") to get the time zone name.
5369 This fixes a bug when the time zone name contains characters that
5370 need converting from the system time locale to Emacs internal format.
5371 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5372 that patch fixed format-time-string to do the conversion, but
5373 I forgot to fix current-time-zone.
5374 (format_time_string): New function, containing most of
5375 what Fformat_time_string used to contain.
5376 (Fformat_time_string): Rewrite in terms of format_time_string.
5377 This doesn't change this function's behavior.
5378 (current-time-zone): Rewrite to use format_time_string.
5379 This fixes the bug reported by Michael Schierl in
5380 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5381 Jason Rumney's 2007-06-07 change worked around this bug, but
5383 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5385 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5387 * xdisp.c (start_display): If the character at POS is displayed
5388 via a display vector, reset IT->current.dpvec_index to zero.
5389 (try_window_reusing_current_matrix): If a line ends in a display
5390 vector or the next line starts in a display vector, continue
5391 redrawing the window even though the character position of
5392 start_row was reached.
5395 2011-10-18 Chong Yidong <cyd@gnu.org>
5397 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5398 with nobreak-char-display too.
5400 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5402 Fix part 3 of bug#9771.
5403 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5404 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5405 non-neutral characters if the current character is a paragraph
5406 separator (a.k.a. Newline). This avoids running the same
5407 expensive loop twice, once when we consume the preceding newline
5408 and the other time when the line actually needs to be displayed.
5409 Avoid the loop when we see neutrals on the base embedding level
5410 following a character whose directionality is the same as the
5411 paragraph's. This avoids running the expensive loop when a line
5412 ends in a long sequence of neutrals, like control characters.
5413 Add assertion against STRONG_AL type. Slightly rearrange code
5414 that determines the type of a neutral given the first non-neutral
5416 (bidi_level_of_next_char): Set next_en_pos to zero when
5417 invalidating its info.
5419 2011-10-17 Eli Zaretskii <eliz@gnu.org>
5421 * xdisp.c (push_display_prop): Determine whether to record string
5422 or buffer position by IT->string, not by IT->method. Allow
5423 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
5424 (move_it_vertically_backward): Don't look for character position
5425 immediately after the newline when in a continuation line.
5428 2011-10-15 Martin Rudalics <rudalics@gmx.at>
5430 * window.c (coordinates_in_window): Rewrite and delabelize
5431 vertical border check. (Bug#5357) (Bug#9618)
5433 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5435 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5436 errors in XSetWindowBorder (bug#9310).
5438 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5440 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5441 avoid crash when xmalloc overrun checking is enabled.
5443 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5445 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5446 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5447 cursor motion with <left> and <right> arrow keys.
5449 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5450 some callers set that themselves.
5452 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5454 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5455 display string and the previous row comes from the same string and
5456 is empty. (Bug#9739) (Bug#9738)
5458 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5460 * doc.c (get_doc_string): Encode file name (bug#9735).
5462 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5464 * bidi.c (bidi_level_of_next_char):
5465 * xdisp.c (get_visually_first_element): Remove old incorrect
5466 comments regarding the Unicode Line Separator character.
5468 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5470 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5472 * alloc.c (Fgc_status): Do not access beyond zombies array
5473 boundary if nzombies > MAX_ZOMBIES.
5474 * alloc.c (dump_zombies): Add missing format specifier.
5476 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5478 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5479 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5481 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5482 Some packages use them to denote characters with modifiers.
5484 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5486 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5487 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5488 matching a pp-number. Rename parameter var to var1.
5490 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5492 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5494 2011-10-08 Glenn Morris <rgm@gnu.org>
5496 * callint.c (Fcall_interactively): Give a more explicit error for the
5497 'c' case with a non-character input. (Bug#8479)
5499 2011-10-08 Eli Zaretskii <eliz@gnu.org>
5501 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5503 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5504 lines that are hscrolled on the left.
5506 * dispnew.c (buffer_posn_from_coords): Account for a possible
5507 presence of header-line. (Bug#4426)
5509 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5511 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5512 Don't advertise functionality which we discourage or doesn't work.
5514 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5516 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5517 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5518 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5519 this makes Emacs dump core during garbage collection on rare
5520 occasions. sizeof is obviously inferior to offsetof here, so
5521 stick with offsetof.
5522 (GC_POINTER_ALIGNMENT): New macro.
5523 (mark_memory): Omit 3rd (offset) arg; caller changed.
5524 Don't assume EMACS_INT alignment is the same as pointer alignment.
5526 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5528 * keyboard.c (read_key_sequence_remapped): New var.
5529 (read_key_sequence): Compute remapping in the right buffer.
5530 (command_loop_1): Use read_key_sequence's remapping directly.
5532 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5534 * dired.c (file_name_completion): Don't expand file name.
5535 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5536 before checking file name handler.
5538 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5539 they've been requested explicitly (bug#9591).
5541 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
5543 * keymap.c (Fsingle_key_description): Use make_specified_string
5544 instead of build_string to build string from push_key_description.
5547 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5549 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5550 This fixes a Y2038 bug on 64-bit hosts.
5551 * buffer.c (reset_buffer):
5552 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5553 (Fclear_buffer_auto_save_failure):
5554 Use 0, not -1, to represent an unset failure time, since time_t
5555 might not be signed.
5557 Remove dependency on glibc malloc internals.
5558 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5559 Move back here from lisp.h, but with their new implementations.
5560 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5561 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5562 * charset.c (charset_table_init): New static var.
5563 (syms_of_charset): Use it instead of xmalloc. This removes a
5564 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5565 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5566 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5567 Move back to alloc.c.
5568 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5569 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5571 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5573 * nsterm.m (windowDidResize): Call x_set_window_size only when
5574 ns_in_resize is true. Otherwise set pixelwidth/height and
5575 call change_frame_size (Bug#9628).
5577 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5579 Port --enable-checking=all to Fedora 14 x86-64.
5580 * charset.c (syms_of_charset): Also account for glibc malloc's
5581 internal overhead when calculating the initial malloc maximum.
5583 Port --enable-checking=all to Fedora 14 x86.
5584 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5586 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5587 (overrun_check_realloc, overrun_check_free):
5588 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5589 That way, xmalloc returns a properly-aligned pointer even if
5590 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5591 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5592 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5593 into account when calculating the initial malloc maximum.
5594 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5595 Move here from alloc.c, so that charset.c can use it too.
5596 Properly align; the old code wasn't right for common 32-bit hosts
5597 when configured with --enable-checking=all.
5598 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5599 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5601 2011-09-29 Eli Zaretskii <eliz@gnu.org>
5603 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
5606 2011-09-28 Eli Zaretskii <eliz@gnu.org>
5608 * xdisp.c (compute_display_string_end): If there's no display
5609 string at CHARPOS, return -1.
5611 * bidi.c (bidi_fetch_char): When compute_display_string_end
5612 returns a negative value, treat the character as a normal
5613 character not covered by a display string. (Bug#9624)
5615 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
5617 * lread.c (Fread_from_string): Fix typo in docstring.
5619 2011-09-27 Eli Zaretskii <eliz@gnu.org>
5621 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5622 newline, reseat the iterator instead of bidi-iterating there one
5623 character at a time. (Bug#9610)
5624 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5625 TO_CHARPOS if the bidi iterator is at base embedding level.
5627 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5629 * lread.c (readevalloop): Use correct code for NBSP.
5630 (read1): Likewise. (Bug#9608)
5632 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
5634 * dbusbind.c (Fdbus_register_signal): When service is not
5635 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5637 2011-09-25 Glenn Morris <rgm@gnu.org>
5639 * buffer.c (truncate-lines): Doc fix.
5641 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
5643 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5644 (Fset_window_next_buffers): Doc fix.
5646 2011-09-24 Glenn Morris <rgm@gnu.org>
5648 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5650 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5652 Fix minor problems found by static checking.
5653 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
5654 * indent.c (Fvertical_motion): Fix == vs = typo.
5656 2011-09-24 Eli Zaretskii <eliz@gnu.org>
5658 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5659 Default value is now t. Doc fix.
5661 * indent.c (Fvertical_motion): Compute and apply the overshoot
5662 logic when moving up, not only when moving down. Fix the
5663 confusing name and values of the it_overshoot_expected variable;
5664 logic changes accordingly. (Bug#9254) (Bug#9549)
5666 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5667 CHARPOS is covered by a display string which includes newlines.
5668 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5669 is covered by a display string with embedded newlines.
5671 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
5673 * dbusbind.c (Fdbus_register_signal): Add match rule to
5674 Vdbus_registered_objects_table. (Bug#9581)
5675 (Fdbus_register_method, Vdbus_registered_objects_table):
5678 2011-09-24 Jim Meyering <meyering@redhat.com>
5680 do not ignore write error for any output size
5681 The previous change was incomplete.
5682 While it makes emacs --batch detect the vast majority of stdout
5683 write failures, errors were still ignored whenever the output size is
5684 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5685 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5686 && echo FAIL: ignored write error
5687 FAIL: ignored write error
5688 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5689 && echo FAIL: ignored write error
5690 FAIL: ignored write error
5691 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5693 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5695 * emacs.c (Fkill_emacs): In noninteractive mode exit
5696 non-successfully if a write error occurred on stdout. (Bug#9574)
5698 2011-09-21 Eli Zaretskii <eliz@gnu.org>
5700 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5703 * dispextern.h (struct it): Update the comment documenting what
5706 2011-09-20 Eli Zaretskii <eliz@gnu.org>
5708 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5709 a display string, extend search for cursor position to end of row.
5710 (find_row_edges): If the row ends in a newline from a display
5711 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5712 Handle the case of a display string with multiple newlines.
5713 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5714 non-empty line. Fixes confusing cursor motion with arrow keys at
5715 the beginning of a line that starts with whitespace.
5717 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5719 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5722 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
5724 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5727 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5729 * xdisp.c (display_line): Record maximum and minimum buffer
5730 positions even if no glyphs were produced (e.g., by a zero-width
5731 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5732 buffer positions that will be removed from the glyph row because
5734 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5735 column is beyond frame width: don't subtract 1 "pixel" when
5736 computing width of the stretch.
5737 (reseat_at_next_visible_line_start): Undo the change made on
5738 2011-09-17 that saved paragraph information and restored it after
5739 the call to `reseat'. (Bug#9545)
5741 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5743 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5744 and turn window cursor on if cleared (Bug#9415).
5746 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
5748 * search.c (boyer_moore): Take unibyte characters from pattern
5749 literally. (Bug#9458)
5751 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5753 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5755 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5757 Fix minor problem found by static checking.
5758 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5759 initialized, to pacify gcc -Wuninitialized.
5761 * fileio.c: Report proper errno when syscall falls.
5762 (Finsert_file_contents): Save and restore errno,
5763 so that report_file_error outputs the correct diagnostic.
5764 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5766 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5768 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5770 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5772 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5773 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5775 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5777 * xdisp.c (reseat_at_next_visible_line_start): Keep information
5778 about the current paragraph and restore it after the call to reseat.
5780 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5781 (bidi_find_paragraph_start): Search back for paragraph beginning
5782 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5783 (bidi_move_to_visually_next): Only trigger paragraph-related
5784 computations when the last character is a newline or at EOB, not
5785 just any NEUTRAL_B. (Bug#9470)
5787 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5788 truncated lines if point is covered by a display string. (Bug#9524)
5790 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5792 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5793 (cons_to_x_long): New function.
5794 (lisp_data_to_selection_data): Use it. Correct the test for
5795 short-versus-long data; it was negated. Break out of vector
5796 loop, for efficiency, when a long datum is discovered.
5798 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5800 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5802 2011-09-16 Eli Zaretskii <eliz@gnu.org>
5804 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5805 GCC PR/17406) by declaring this function with external scope.
5807 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5809 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5810 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5812 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5814 * editfns.c (Fformat): Correctly handle text properties on "%%".
5816 2011-09-15 Eli Zaretskii <eliz@gnu.org>
5818 * xterm.c (x_draw_composite_glyph_string_foreground):
5819 * w32term.c (x_draw_composite_glyph_string_foreground):
5820 * term.c (encode_terminal_code):
5821 * composite.c (composition_update_it, get_composition_id):
5822 * xdisp.c (get_next_display_element)
5823 (fill_composite_glyph_string): Add comments about special meaning
5824 of TAB characters in a composition.
5826 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5828 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
5829 This occurs when processing a multibyte format.
5830 Problem reported by Wolfgang Jenker.
5832 2011-09-15 Johan Bockgård <bojohan@gnu.org>
5834 * xdisp.c (try_cursor_movement): Only check for exact match if
5835 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5837 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5839 Remove unused external symbols.
5840 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5841 * xdisp.c (calc_pixel_width_or_height): Now static.
5842 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5843 * indent.c (check_display_width):
5844 * w32term.c: Fix comment to match code.
5845 * xterm.c, xterm.h (x_catching_errors): Remove.
5847 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5849 * xselect.c: Use signed conversions more consistently (Bug#9498).
5850 (selection_data_to_lisp_data): Assume incoming selection data are
5851 signed integers, not unsigned. This is to be consistent with
5852 outgoing selection data, which was modified to use signed integers
5853 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5854 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5855 expects long, not unsigned long.
5857 2011-09-14 Eli Zaretskii <eliz@gnu.org>
5859 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5860 computation of loop end. Reported by Johan Bockgård
5863 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
5865 * frame.c (Fother_visible_frames_p): Function deleted.
5867 2011-09-12 Eli Zaretskii <eliz@gnu.org>
5869 * indent.c (compute_motion): Process display vector front to back
5870 rather than the other way around. (Bug#2496)
5872 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5874 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5876 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
5878 * minibuf.c (Fread_from_minibuffer): Doc fix.
5880 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5882 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5883 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5885 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5887 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5888 value for non-existent files.
5890 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5892 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5893 set its "size" to -1. This will set the modtime_size field of
5894 the corresponding buffer to -1, which is what
5895 verify-visited-file-modtime expects for files that do not exist.
5898 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5900 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5902 * lisp.h: ... from here. push_key_description is no longer
5903 defined in keyboard.c, so its declaration should not be in
5904 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5905 logically belongs with push_key_description.
5907 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5909 * buffer.h: Include <sys/types.h> instead of <time.h>.
5910 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5911 Problem reported by Herbert J. Skuhra.
5913 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5915 * xml.c (parse_region): Make the parsing work for
5916 non-comment-starting XML files again (bug#9144).
5918 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5920 * image.c (gif_load): Fix calculation of bottom and right corner.
5923 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5925 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5926 redisplay in small windows.
5928 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5930 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5932 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5934 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5935 Operate on live windows only.
5937 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5939 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5941 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5943 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5944 only under bidi iteration.
5946 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5948 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5950 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5952 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5953 Without this fix, the command to link temacs failed due to an
5954 undefined symbol __builtin_isnan. This is because
5955 /usr/include/iso/math_c99.h #defines isnan(x) to
5956 __builtin_isnan(x), but the bundled gcc, which identifies itself
5957 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5959 * floatfns.c (isnan): #undef, and then #define to a clone of
5961 (Fisnan): Always define, since it's always available now.
5962 (syms_of_floatfns): Always define isnan at the Lisp level.
5964 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5966 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5968 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5970 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5971 The previous code assumed that file offsets (off_t values) fit in
5972 EMACS_INT variables, which is not true on typical 32-bit hosts.
5973 The code messed up by falsely reporting buffer overflow in cases
5974 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5975 when "big" contains more than 2**29 bytes, even though this
5976 inserts just one byte and does not overflow the buffer.
5977 (Finsert_file_contents): Store file offsets as off_t
5978 values, not as EMACS_INT values. Check for overflow when
5979 converting between EMACS_INT and off_t. When checking for
5980 buffer overflow or for overlap, take the offsets into account.
5981 Don't use EMACS_INT for small values where int suffices.
5982 When checking for overlap, fix a typo: ZV was used where
5983 ZV_BYTE was intended.
5984 (Fwrite_region): Don't assume off_t fits into 'long'.
5985 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5987 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5989 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5991 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5993 sprintf-related integer and memory overflow issues (Bug#9412).
5995 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5996 (esprintf, exprintf, evxprintf): New functions.
5997 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5998 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5999 (modify_event_symbol): Do not assume that the length of
6000 name_alist_or_stem is safe to alloca and fits in int.
6001 (Fexecute_extended_command): Likewise for function name and binding.
6002 (Frecursion_depth): Wrap around reliably on integer overflow.
6003 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6004 since some callers pass EMACS_INT values.
6005 (Fsingle_key_description): Don't crash if symbol name contains more
6006 than MAX_ALLOCA bytes.
6007 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6008 (get_minibuffer): Arg is now EMACS_INT, not int.
6009 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
6010 (esprintf, exprintf, evxprintf): New decls.
6011 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6013 * dbusbind.c (signature_cat): New function.
6014 (xd_signature, Fdbus_register_signal):
6015 Do not overrun buffer; instead, report string overflow.
6017 * dispnew.c (add_window_display_history): Don't overrun buffer.
6018 Truncate instead; this is OK since it's just a log.
6020 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6021 even if the time zone offset is outlandishly large.
6022 Don't mishandle offset == INT_MIN.
6024 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6025 when creating daemon; the previous buffer-overflow check was incorrect.
6027 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6028 which has the guts of the old verror function.
6030 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6031 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6033 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6034 (font_unparse_xlfd): Don't blindly alloca long strings.
6035 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
6036 fits in int, when using sprintf. Use single snprintf to count
6037 length of string rather than counting it via multiple sprintfs;
6038 that's simpler and more reliable.
6039 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6040 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6041 sprintf, in case result does not fit in int.
6043 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6044 (fontset_from_font): Print it.
6046 * frame.c (tty_frame_count): Now printmax_t, not int.
6047 (make_terminal_frame, set_term_frame_name): Print it.
6048 (x_report_frame_params): In X, window IDs are unsigned long,
6049 not signed long, so print them as unsigned.
6050 (validate_x_resource_name): Check for implausibly long names,
6051 and don't assume name length fits in 'int'.
6052 (x_get_resource_string): Don't blindly alloca invocation name;
6053 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6056 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6057 (xg_check_special_colors, xg_set_geometry):
6058 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6060 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6061 Use esprintf, not sprintf, in case result does not fit in int.
6063 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6064 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6065 it as a large positive number.
6066 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6067 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6069 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6070 in case result does not fit in int.
6072 * print.c (float_to_string): Detect width overflow more reliably.
6073 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6074 buffer overrun. Don't assume list length fits in 'int'. Treat
6075 print length of 0 as 0, not as infinity; to be consistent with other
6076 uses of print length in this function. Don't overflow print length
6077 index. Don't assume hash table size fits in 'long', or that
6078 vectorlike size fits in 'unsigned long'.
6080 * process.c (make_process): Use printmax_t, not int, to format
6081 process-name gensyms.
6083 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6085 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6086 to avoid potential buffer overrun.
6088 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6089 if X resource line is longer than 512 bytes.
6091 * xfns.c (x_window): Make sprintf buffer a bit bigger
6092 to avoid potential buffer overrun.
6094 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6096 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6098 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6100 Integer overflow fixes for scrolling, etc.
6101 Without these, Emacs silently mishandles large integers sometimes.
6102 For example, "C-u 4294967297 M-x recenter" was treated as if
6103 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6105 * xdisp.c (try_window_id): Check Emacs fixnum range before
6106 converting to 'int'.
6108 * window.c (window_scroll_line_based, Frecenter):
6109 Check that an Emacs fixnum is in range before assigning it to 'int'.
6110 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6111 values converted from Emacs fixnums.
6112 (Frecenter): Don't wrap around a line count if it is out of 'int'
6113 range; instead, treat it as an extreme value.
6114 (Fset_window_configuration, compare_window_configurations):
6115 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6117 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6118 that can exceed INT_MAX. Check that EMACS_INT value is in range
6119 before assigning it to the (possibly-narrower) index.
6120 (match_limit): Don't assume that a fixnum can fit in 'int'.
6122 * print.c (print_object): Use ptrdiff_t, not int, for index that can
6125 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
6126 (Fvertical_motion): Don't wrap around LINES values that don't fit
6127 in 'int'. Instead, treat them as extreme values. This is good
6128 enough for windows, which can't have more than INT_MAX lines anyway.
6130 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6132 * Require libxml/parser.h to avoid compilation warning.
6134 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6136 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6137 since this reportedly can destroy thread storage.
6139 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
6141 * syntax.c (find_defun_start): Update all cache variables if
6142 exiting early (Bug#9401).
6144 2011-08-30 Eli Zaretskii <eliz@gnu.org>
6146 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6148 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6149 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6150 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6152 * term.c (tty_append_glyph): New function.
6153 (produce_stretch_glyph): Static function and its prototype deleted.
6155 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6158 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6160 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6161 when checking :margin (Bug#9390).
6162 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
6163 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
6164 so that the name doesn't mislead. All uses changed.
6166 2011-08-28 Johan Bockgård <bojohan@gnu.org>
6168 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6171 2011-08-27 Eli Zaretskii <eliz@gnu.org>
6173 * xdisp.c (move_it_to): Don't bail out early when reaching
6174 position beyond to_charpos, if we are scanning backwards.
6175 (move_it_vertically_backward): When DY == 0, make sure we get to
6176 the first character in the line after the newline.
6178 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6180 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6181 (ccl_driver): Do not generate an out-of-range pointer.
6182 (Fccl_execute_on_string): Remove unnecessary check for
6183 integer overflow, noted by Stefan Monnier in
6184 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6185 Remove a FIXME that didn't need fixing.
6186 Simplify the newly-introduced buffer reallocation code.
6188 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
6190 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6192 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
6194 Integer and memory overflow issues (Bug#9196).
6196 * doc.c (get_doc_string): Rework so that
6197 get_doc_string_buffer_size is the actual buffer size, rather than
6198 being 1 less than the actual buffer size; this makes xpalloc more
6201 * image.c (x_allocate_bitmap_record, cache_image):
6202 * xselect.c (Fx_register_dnd_atom):
6203 Simplify previous changes by using xpalloc.
6205 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6206 since either will do and ptrdiff_t is convenient with xpalloc.
6208 * charset.c (charset_table_size)
6209 (struct charset_sort_data.priority): Now ptrdiff_t.
6210 (charset_compare): Don't overflow if priorities differ greatly.
6211 (Fsort_charsets): Don't assume list length fits in int.
6212 Check for size-calculation overflow when allocating sort data.
6213 (syms_of_charset): Allocate an initial charset table that is
6214 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6216 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6218 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6219 The actual value is always <= INT_MAX, and leaving it unsigned made
6220 overflow checking harder.
6222 * dispextern.h (struct glyph_matrix.rows_allocated)
6223 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6224 with xpalloc. The values are still always <= INT_MAX.
6226 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6228 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6229 (SAFE_NALLOCA): New macro.
6231 * region-cache.c (struct boundary.pos, find_cache_boundary)
6232 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6233 (set_cache_region, invalidate_region_cache)
6234 (revalidate_region_cache, know_region_cache, region_cache_forward)
6235 (region_cache_backward, pp_cache):
6236 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6237 so that ptrdiff_t * can be passed to xpalloc.
6238 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6239 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6240 (pp_cache): Don't assume cache_len fits in int.
6241 * region-cache.h: Adjust extern decls to match.
6243 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6244 EMACS_INT, since either will do, for xpalloc.
6246 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6247 (xnmalloc, xnrealloc, xpalloc): New functions.
6249 * bidi.c (bidi_shelve_header_size): New constant.
6250 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6251 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6253 * bidi.c (bidi_cache_shrink):
6254 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6256 Don't update size of array until after memory allocation succeeds,
6257 because xmalloc/xrealloc may not return.
6258 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6259 now that we have proper integer overflow checking.
6260 (record_overlay_string, overlay_strings): Catch overflows when
6261 calculating size of overlay_str_buf.
6263 * callproc.c (Fcall_process): Check for size overflow when
6264 calculating size of args2.
6265 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6266 Normally we prefer signed values, but sticking with ptrdiff_t would
6267 require adding more-complicated checks.
6269 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6270 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6271 Redo buffer-overflow calculations to avoid integer overflow.
6272 Add a FIXME comment where memory seems to be over-allocated.
6274 * character.c (Fstring): Check for size-calculation overflow.
6276 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6277 unnecessary integer overflow. Check for size overflow.
6278 (encode_coding_object): Don't update size until xmalloc succeeds.
6280 * composite.c (get_composition_id): Check for overflow in glyph
6281 length calculations.
6283 Integer and memory overflow fixes for display code.
6284 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6285 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6286 (scrolling_window): Check for overflow in size calculations.
6287 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6288 Don't assume glyph table len fits in int.
6289 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6290 (row_table_size): Now ptrdiff_t, not int.
6291 (scrolling_window): Avoid overflow in size calculations.
6292 Don't update size until allocation succeeds.
6293 * fns.c (concat): Check for overflow in size calculations.
6294 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6295 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6296 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6298 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6299 (get_doc_string): Check for size calculation overflow.
6300 Don't update size until allocation succeeds.
6301 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6302 EMACS_INT, where ptrdiff_t will do.
6303 (Fsubstitute_command_keys): Check for string overflow.
6305 * editfns.c (set_time_zone_rule): Don't assume environment length
6307 (message_length): Now ptrdiff_t, not int.
6308 (Fmessage_box): Don't update size until allocation succeeds.
6309 Don't assume message length fits in int.
6310 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6312 * emacs.c (main): Do not reallocate argv, since there is a null at
6313 the end that can be overwritten, and this way there's no need to
6314 worry about size-calculation overflow.
6315 (sort_args): Check for size-calculation overflow.
6317 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6319 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6321 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6322 (x_set_scroll_bar_width, x_figure_window_size):
6323 Check for integer overflow.
6324 (x_set_alpha): Do not assume XINT fits in int.
6326 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6327 This is for the members text_lines, text_cols, total_lines, total_cols,
6328 where the system imposes an 'int' limit.
6330 * fringe.c (Fdefine_fringe_bitmap):
6331 Don't update size until alloc works.
6333 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6334 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6336 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6337 Check for size-calculation overflow.
6338 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6339 do, as we prefer signed integers.
6340 (id_to_widget.max_size, id_to_widget.used)
6341 (xg_store_widget_in_map, xg_remove_widget_from_map)
6342 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6343 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6344 Use and return ptrdiff_t, not int.
6345 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6346 * gtkutil.h: Change prototypes to match the above.
6348 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6349 are duplicate now that they've been promoted to lisp.h.
6350 (x_allocate_bitmap_record, x_alloc_image_color)
6351 (make_image_cache, cache_image, xpm_load):
6352 Don't update size until alloc is done.
6353 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6355 Check for size calculation overflow.
6356 (ct_colors_allocated_max): New constant.
6357 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6360 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6361 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6362 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6363 Use ptrdiff_t, not int, to count maps.
6364 (read_char_minibuf_menu_prompt): Check for overflow in size
6365 calculations. Don't update size until allocation succeeds.
6366 Redo calculations to avoid overflow.
6367 * keyboard.h: Change prototypes to match the above.
6369 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6371 (current_minor_maps): Check for size calculation overflow.
6372 * keymap.h: Change prototypes to match the above.
6374 * lread.c (read1, init_obarray): Don't update size until alloc done.
6376 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6377 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6379 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6380 Now ptrdiff_t, not int.
6381 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6382 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6384 * process.c (Fnetwork_interface_list): Check for overflow
6385 in size calculation.
6387 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6389 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6390 overflow. Don't bother calling xmalloc when xrealloc will do.
6392 * search.c (Freplace_match): Check for size calculation overflow.
6393 (Fset_match_data): Don't assume list lengths fit in 'int'.
6395 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6396 for command line length. Do not attempt to address one before the
6397 beginning of an array, as that's not portable.
6399 * term.c (max_frame_lines): Remove; unused.
6400 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6402 (encode_terminal_code, calculate_costs): Check for size
6403 calculation overflow.
6404 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6405 table lengths and related sizes. Don't update size until alloc
6406 done. Redo calculations to avoid overflow.
6407 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6409 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6410 subtracting pointers.
6411 (gobble_line): Check for overflow more carefully. Don't update size
6414 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6415 Don't update size until alloc done.
6416 Redo size calculations to avoid overflow.
6417 Check for size calculation overflow.
6418 (main) [DEBUG]: Fix typo in invoking tparam1.
6420 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6421 Use ptrdiff_t, not int, for sizes.
6422 (store_mode_line_noprop_char): Don't update size until alloc done.
6424 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6425 Use ptrdiff_t, not int, for sizes.
6426 (Finternal_make_lisp_face, cache_face):
6427 Check for size calculation overflow.
6428 (cache_face): Treat size calculation overflows as if they were
6429 memory exhaustion (the usual treatment), rather than aborting.
6431 * xfns.c (x_encode_text, x_set_name_internal)
6432 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6433 sizes, since they can exceed INT_MAX in size. Check for size
6434 calculation overflow.
6436 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6437 (xg_select): Check for size calculation overflow.
6438 Don't update size until alloc done.
6440 * xrdb.c (get_environ_db): Don't assume path length fits in int,
6441 as sprintf is limited to int lengths.
6443 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6444 (X_LONG_MIN): New macros.
6445 Use them to make the following changes clearer.
6446 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6447 This change doesn't affect the value now, but it may help remind
6448 future maintainers not to raise the value too much later.
6449 (SELECTION_QUANTUM): Remove, replacing with ...
6450 (selection_quantum): ... new function, which avoids overflow.
6452 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6453 assumption that selection length fits in 'int'.
6454 (x_reply_selection_request, x_handle_selection_request)
6455 (x_get_window_property, receive_incremental_selection)
6456 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6457 (lisp_data_to_selection_data, clean_local_selection_data):
6458 Use ptrdiff_t, not int, to record length of selection.
6459 (x_reply_selection_request, x_get_window_property)
6460 (receive_incremental_selection, x_property_data_to_lisp):
6461 Redo calculations to avoid overflow.
6462 (x_reply_selection_request): When sending hint, ceiling it at
6463 X_LONG_MAX rather than relying on wraparound overflow to send
6465 (x_get_window_property, receive_incremental_selection)
6466 (lisp_data_to_selection_data, x_property_data_to_lisp):
6467 Check for size-calculation overflow.
6468 (x_get_window_property, receive_incremental_selection)
6469 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6470 Don't store size until memory allocation succeeds.
6471 (x_get_window_property): Plug memory leak on memory exhaustion.
6472 Don't double-block input; malloc is safe here. Don't assume 2**34
6473 - 4 fits in unsigned long. Add an xassert to check
6474 XGetWindowProperty overflow. Be more careful about overflow
6475 calculations, and distinguish size from memory overflow better.
6476 (receive_incremental_selection): When tracing, don't assume
6477 unsigned int is less than INT_MAX.
6478 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6479 harmful) conversions of unsigned short to int.
6480 (lisp_data_to_selection_data): Don't assume that integers
6481 in the range -65535 through -1 fit in an X unsigned short.
6482 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6483 result parameters unless successful. Rely on cons_to_unsigned
6484 to report problems with elements; the old code wasn't right anyway.
6485 (x_check_property_data): Check for int overflow; we cannot use
6486 a wider type due to X limits.
6487 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6489 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
6491 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6492 (x_term_init): Check for size calculation overflow.
6493 (x_color_cells): Don't store size until memory allocation succeeds.
6494 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
6495 Don't assume alloca size is less than MAX_ALLOCA.
6496 (x_term_init): Don't assume length fits in int (sprintf is limited
6499 Use ptrdiff_t for composition IDs.
6500 * character.c (lisp_string_width):
6501 * composite.c (composition_table_size, n_compositions)
6502 (get_composition_id, composition_gstring_from_id):
6503 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6504 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6505 * window.c (Frecenter):
6506 Use ptrdiff_t, not int, for composition IDs.
6507 * composite.c (get_composition_id): Check for integer overflow.
6508 * composite.h: Adjust prototypes to match the above changes.
6510 Use ptrdiff_t for hash table indexes.
6511 * category.c (hash_get_category_set):
6512 * ccl.c (ccl_driver):
6513 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6514 * coding.c (coding_system_charset_list, detect_coding_system):
6515 * coding.h (struct coding_system.id):
6516 * composite.c (get_composition_id, gstring_lookup_cache):
6517 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6518 * image.c (xpm_get_color_table_h):
6519 * lisp.h (hash_lookup, hash_put):
6520 * minibuf.c (Ftest_completion):
6521 Use ptrdiff_t for hash table indexes, not int (which is too
6522 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6523 32-bit --with-wide-int hosts).
6525 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6526 Add a FIXME comment about memory leaks.
6527 (syms_of_charset): Don't assume xmalloc returns.
6529 Don't assume that stated character widths fit in int.
6530 * character.c (Fchar_width, c_string_width, lisp_string_width):
6531 * character.h (CHAR_WIDTH):
6532 * indent.c (MULTIBYTE_BYTES_WIDTH):
6533 Use sanitize_char_width to avoid undefined and/or bad behavior
6534 with outlandish widths.
6535 * character.h (sanitize_tab_width): Rename from sanitize_width,
6536 now that we have two such functions. All uses changed.
6537 (sanitize_char_width): New inline function.
6539 Don't assume that tab-width fits in int.
6540 * character.h (sanitize_width): New inline function.
6541 (SANE_TAB_WIDTH): New macro.
6542 (ASCII_CHAR_WIDTH): Use it.
6543 * indent.c (sane_tab_width): Remove. All uses replaced by
6544 SANE_TAB_WIDTH (current_buffer).
6545 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6547 * fileio.c: Integer overflow issues with file modes.
6548 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6550 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6551 Remove unreachable code.
6552 (read_hex, load_charset_map_from_file): Check for integer overflow.
6554 * xterm.c: Don't go over XClientMessageEvent limit.
6555 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6556 (x_send_scroll_bar_event): Likewise. Check that the size does not
6557 exceed limits imposed by XClientMessageEvent, as well as the usual
6558 ptrdiff_t and size_t limits.
6560 * keyboard.c: Overflow, signedness and related fixes.
6561 (make_lispy_movement): Use same integer type in forward decl
6562 that is used in the definition.
6563 (read_key_sequence, keyremap_step):
6564 Change bufsize argument back to int, undoing my 2011-03-30 change.
6565 We prefer signed types, and int is wide enough here.
6566 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6567 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6568 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6569 length, not size_t. Use ptrdiff_t for index, not int.
6570 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6571 possibility of integer overflow.
6573 Overflow, signedness and related fixes for images.
6575 * dispextern.h (struct it.stack[0].u.image.image_id)
6576 (struct_it.image_id, struct image.id, struct image_cache.size)
6577 (struct image_cache.used, struct image_cache.ref_count):
6578 * gtkutil.c (update_frame_tool_bar):
6579 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6580 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6581 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6582 * nsmenu.m (update_frame_tool_bar):
6583 * xdisp.c (calc_pixel_width_or_height):
6584 * xfns.c (image_cache_refcount):
6585 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6586 on typical 64-bit hosts.
6588 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6589 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6590 Omit unnecessary casts to int.
6591 (parse_image_spec): Check that integers fall into 'int' range
6592 when the callers expect that.
6593 (image_ascent): Redo ascent calculation to avoid int overflow.
6594 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6595 (lookup_image): Remove unnecessary tests.
6596 (xbm_image_p): Locals are now of int, not EMACS_INT,
6597 since parse_image_check makes sure they fit into int.
6598 (png_load, gif_load, svg_load_image):
6599 Prefer int to unsigned where either will do.
6600 (tiff_handler): New function, combining the cores of the
6601 old tiff_error_handler and tiff_warning_handler.
6602 This function is rewritten to use vsnprintf and thereby avoid
6603 stack buffer overflows. It uses only the features of vsnprintf
6604 that are common to both POSIX and native Microsoft.
6605 (tiff_error_handler, tiff_warning_handler): Use it.
6606 (tiff_load, gif_load, imagemagick_load_image):
6607 Don't assume :index value fits in 'int'.
6608 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6609 (imagemagick_load_image): Check that crop parameters fit into
6610 the integer types that MagickCropImage accepts. Don't assume
6611 Vimagemagick_render_type has a nonnegative value. Don't assume
6612 size_t fits in 'long'.
6613 (gs_load): Use printmax_t to print the widest integers possible.
6614 Check for integer overflow when computing image height and width.
6616 2011-08-26 Eli Zaretskii <eliz@gnu.org>
6618 * xdisp.c (redisplay_window): Don't force window start if point
6619 will be invisible in the resulting window. (Bug#9324)
6621 2011-08-25 Eli Zaretskii <eliz@gnu.org>
6623 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6624 the display spec is of the form `(space ...)'.
6625 (handle_display_spec): Return the value returned by
6626 handle_single_display_spec, not just 1 or zero.
6627 (handle_single_display_spec): If the display spec is of the form
6628 `(space ...)', and specifies display in the text area, return 2
6630 (try_cursor_movement): Check for the need to scroll more
6631 accurately, and prefer exact match for point under bidi.
6632 Don't advance `row' beyond the last row of the window.
6634 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6635 into disp_prop; all users changed.
6637 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6638 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6639 for the text covered by the display property.
6641 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
6643 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6644 Change return value to nil.
6645 (Frecord_buffer): Delete unused function.
6647 2011-08-24 Eli Zaretskii <eliz@gnu.org>
6649 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6650 buffers, return left-to-right.
6651 (set_cursor_from_row): Consider candidate row a win if its glyph
6652 represents a newline and point is on that newline. Fixes cursor
6653 positioning on the newline at EOL of R2L text within L2R
6654 paragraph, and vice versa.
6655 (try_cursor_movement): Check continued rows, in addition to
6656 continuation rows. Fixes unwarranted scroll when point enters a
6657 continued line of R2L text within an L2R paragraph, or vice versa.
6658 (cursor_row_p): Consider the case of point being equal to
6659 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6660 from the end of a short line to the beginning of a continued line
6661 of R2L text within L2R paragraph.
6662 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6663 composed characters.
6665 * bidi.c (bidi_check_type): Use xassert.
6666 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6669 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6671 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6674 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
6676 * nsfont.m (ns_otf_to_script): Fix typo.
6678 2011-08-22 Kenichi Handa <handa@m17n.org>
6680 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6681 extra slot even if the purpose is char-code-property-table.
6683 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6685 * xdisp.c (redisplay_window): When computing centering_position,
6686 account for the height of the header line. (Bug#8874)
6688 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6689 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6690 candidate is selected by the mouse, and that candidate has a
6691 composed character under the mouse.
6693 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6694 coordinates reported by pos-visible-in-window-p for a composed
6695 character in column zero.
6697 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6699 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6701 2011-08-22 Eli Zaretskii <eliz@gnu.org>
6703 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6704 consider it a hit if to_charpos is anywhere in the range of the
6705 composed buffer positions.
6707 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
6709 * image.c (gif_load): Don't assume that each subimage has the same
6710 dimensions as the base image. Handle disposal method that is
6711 "undefined" by the gif spec (Bug#9335).
6713 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
6715 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
6716 (Fcondition_case): Document `debug' symbol in error handler.
6718 2011-08-19 Eli Zaretskii <eliz@gnu.org>
6720 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6721 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6722 from an Org mode buffer to a Speedbar frame.
6724 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6725 a composition, take its buffer position from IT->cmp_it.charpos.
6726 Fixes cursor positioning at the beginning of a line that begins
6727 with a composed character.
6729 2011-08-18 Eli Zaretskii <eliz@gnu.org>
6731 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6732 character bidirectional type, use STRONG_L instead. Fixes crashes
6733 in a buffer produced by `describe-categories'.
6735 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6736 members before the level stack, so they would be saved and
6737 restored when copying iterator state. Fixes incorrect reordering
6738 around TABs covered by display properties.
6740 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6742 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
6744 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
6746 * eval.c (internal_condition_case, internal_condition_case_1)
6747 (internal_condition_case_2, internal_condition_case_n):
6748 Remove unnecessary aborts (Bug#9081).
6750 2011-08-17 Eli Zaretskii <eliz@gnu.org>
6752 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6753 has no `load' handler, try opening the file locally. (Bug#9311)
6755 2011-08-16 Ken Brown <kbrown@cornell.edu>
6757 * gmalloc.c: Expand comment.
6759 2011-08-16 Eli Zaretskii <eliz@gnu.org>
6761 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6762 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6764 2011-08-16 Ken Brown <kbrown@cornell.edu>
6766 Fix memory allocation problems in Cygwin build (Bug#9273).
6768 * unexcw.c ( __malloc_initialized): Declare external variable.
6769 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6771 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6773 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6775 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6777 [CYGWIN] (special_realloc): New function.
6778 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6779 requests to realloc storage in the static heap.
6781 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6783 * bidi.c (bidi_initialize): Remove unused local.
6785 2011-08-15 Eli Zaretskii <eliz@gnu.org>
6788 * biditype.h: Remove file.
6789 * makefile.w32-in ($(BLD)/bidi.$(O)):
6790 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
6792 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6794 * chartab.c: Improve commentary for the uniprop_table API.
6796 * bidi.c (bidi_paragraph_init): Support zero value of
6797 bidi_ignore_explicit_marks_for_paragraph_level.
6798 (bidi_initialize): Use uniprop_table instead of including
6799 biditype.h and bidimirror.h.
6801 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6802 coordinates of the iterator when restoring from ppos_it.
6805 2011-08-14 Kenichi Handa <handa@m17n.org>
6807 * process.c (create_process): Call setup_process_coding_systems
6808 after the pid of the process is set to -1 (Bug#8162).
6810 2011-08-14 Eli Zaretskii <eliz@gnu.org>
6812 * xdisp.c (move_it_in_display_line_to): Don't invoke
6813 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6814 ppos_it. Fixes vertical cursor motion when line beginning is
6815 covered by an image. (Bug#9296)
6817 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6819 * nsterm.h (ns_run_ascript): Declare.
6820 (NSAPP_DATA2_RUNASSCRIPT): Define.
6822 * nsfns.m (as_script, as_result, as_status): New static variables.
6823 (ns_run_ascript): New function.
6824 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
6825 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6826 the event loop. Get status from as_status (Bug#7276).
6828 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6829 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6830 the event loop (Bug#7276).
6832 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6834 * gnutls.c (QCgnutls_bootprop_priority)
6835 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6836 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6837 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6838 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6839 (QCgnutls_bootprop_verify_hostname_error)
6840 (QCgnutls_bootprop_callbacks_verify): Rename from
6841 Qgnutls_bootprop_..., all uses changed.
6843 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6846 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6848 * xfaces.c (Qframe_set_background_mode): Now static.
6849 * dispextern.h (Qframe_set_background_mode): Remove decl.
6851 * process.c (Fnetwork_interface_info): Declare local only if needed.
6853 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6855 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6856 (Fnetwork_interface_list): Allocate in increments of bytes instead
6857 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6858 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6860 (struct ifflag_def): notrailers is smart on OSX.
6861 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6862 Get hardware address with getifaddrs if available.
6864 2011-08-12 Eli Zaretskii <eliz@gnu.org>
6866 * xdisp.c (iterate_out_of_display_property): xassert that
6867 IT->position is set to within IT->object's boundaries. Break from
6868 the loop as soon as EOB is reached; avoids infloops in redisplay
6869 when IT->position is set up wrongly due to some bug.
6870 Set IT->current to match the bidi iterator unconditionally.
6871 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6872 entry. Force push_it to save on the stack the current
6873 buffer/string position, to be restored by pop_it. Fix flags in
6874 the iterator structure wrt the object coming from a display
6875 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6876 properties. (Bug#9284)
6878 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6880 * fontset.c (fontset_get_font_group): Add proper type checks.
6883 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6885 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6886 and LC_VERSION_MIN_MACOSX.
6887 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6888 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6890 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6892 * xdisp.c (forward_to_next_line_start): Allow to use the
6893 no-display-properties-and-no-overlays under bidi display.
6894 Set disp_pos in the bidi iterator to avoid searches for display
6895 properties and overlays.
6897 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6899 * editfns.c (Fset_time_zone_rule): Document relationship with the
6902 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6903 the font entity extracted from the cache (Bug#8109).
6905 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6907 * composite.c (autocmp_chars): Don't reset point. That is done by
6908 restore_point_unwind (Bug#5984).
6910 2011-08-07 Juri Linkov <juri@jurta.org>
6912 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6913 to show the arg `TIME' instead of `TIMEVAL'.
6915 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6917 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6918 display property strides EOL and includes a newline, as in
6919 longlines-mode. (Bug#9254)
6920 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6921 word-wrap under bidirectional display. (Bug#9224)
6923 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6924 is non-zero, even if the data buffer is NULL. Fixes a crash in
6925 vertical-motion with longlines-mode. (Bug#9254)
6927 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6929 * bidi.c <bidi_cache_total_alloc>: Now static.
6930 (bidi_initialize): Initialize bidi_cache_total_alloc.
6932 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6935 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6936 amount allocated this far in `bidi_cache_total_alloc'.
6937 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6938 non-zero, only free the data buffer without restoring the cache
6939 contents. All callers changed.
6941 * dispextern.h (bidi_unshelve_cache): Update prototype.
6943 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6944 (move_it_in_display_line, move_it_to)
6945 (move_it_vertically_backward, move_it_by_lines): Replace the call
6946 to xfree to an equivalent call to bidi_unshelve_cache.
6947 (move_it_in_display_line_to): Fix logic of returning
6948 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6950 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6952 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6953 came from a string character with a `cursor' property. (Bug#9229)
6955 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6957 * Makefile.in (LIB_PTHREAD): New variable.
6958 (LIBES): Add LIB_PTHREAD (Bug#9216).
6960 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6961 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6963 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6965 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6967 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6969 * xterm.c (x_find_topmost_parent): New function.
6970 (x_set_frame_alpha): Find topmost parent window with
6971 x_find_topmost_parent and set the property there also (bug#9181).
6972 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6974 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6976 * callproc.c (Fcall_process): Avoid vfork clobbering
6977 the local vars buffer, coding_systems, current_dir.
6979 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6981 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6983 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6985 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6986 so that it is not optimized away.
6988 * xdisp.c (compute_display_string_pos): Remove unused local.
6990 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6992 Fix slow cursor motion and scrolling in large buffers with
6993 selective display, like Org Mode buffers. (Bug#9218)
6995 * dispextern.h (struct bidi_it): New member disp_prop_p.
6997 * xdisp.c: Remove one-slot cache of display string positions.
6998 (compute_display_string_pos): Accept an additional argument
6999 DISP_PROP_P; callers changed. Scan at most 5K characters forward
7000 for a display string or property. If found, set DISP_PROP_P
7003 * bidi.c (bidi_fetch_char): Accept an additional argument
7004 DISP_PROP_P, and pass it to compute_display_string_pos.
7005 Only handle text covered by a display string if DISP_PROP_P is returned
7006 non-zero. All callers of bidi_fetch_char changed.
7008 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7010 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7012 2010-12-03 Don March <don@ohspite.net>
7014 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7015 last character M-[char] is translated to ESC [char] (bug#7541).
7017 2011-08-02 Kenichi Handa <handa@m17n.org>
7019 * lisp.h (uniprop_table): Extern it.
7021 * chartab.c (uniprop_table): Make it non-static.
7023 2011-08-01 Eli Zaretskii <eliz@gnu.org>
7025 * xdisp.c (forward_to_next_line_start): Accept additional argument
7026 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7028 (reseat_at_next_visible_line_start): Use the bidi iterator state
7029 returned by forward_to_next_line_start to restore the state of
7030 it->bidi_it after backing up to previous newline. (Bug#9212)
7032 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7034 * regex.c (re_comp): Protoize.
7035 (re_exec): Fix return type.
7036 (regexec): Fix type of `ret'. (Bug#9203)
7038 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7040 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7041 This is needed if max-image-size is a floating-point number.
7043 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7045 * print.c (print_object): Print empty symbol as ##.
7047 * lread.c (read1): Read ## as empty symbol.
7049 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7051 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7052 setting frame foreground color (Bug#9175).
7053 (x_set_background_color): Likewise.
7055 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7056 contents (Bug#9176).
7057 (EmacsTooltip -init): Remove bezels and add shadows to
7060 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7061 or scroll bar (Bug#8470).
7063 * nsfont.m (nsfont_open): Remove assignment to voffset and
7064 unnecessary vars hshink, expand, hd, full_height, min_height.
7065 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7067 * nsterm.h (nsfont_info): Remove voffset field.
7069 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7071 Implement strike-through and overline on NextStep (Bug#8863).
7073 * nsfont.m (nsfont_open): Use underline position provided by font,
7074 instead of hard-coded value of 2.
7075 (nsfont_draw): Call ns_draw_text_decoration instead.
7077 * nsterm.h: Add declaration for ns_draw_text_decoration.
7079 * nsterm.m (ns_draw_text_decoration): New function for drawing
7080 underline, overline, and strike-through.
7081 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7082 ns_draw_text_decoration. Change treatment of cursor drawing to
7083 accommodate underlining, etc.
7085 2011-07-28 Eli Zaretskii <eliz@gnu.org>
7087 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7090 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7092 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7093 Without this fix, if a signal arrives just after memory fills up,
7094 'malloc' might be invoked reentrantly.
7096 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7097 In other words, assume that every image size is allowed, on non-X
7098 hosts. This assumption is probably wrong, but it lets Emacs compile.
7100 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7102 * regex.c (re_iswctype): Convert return values to boolean.
7104 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7106 * xdisp.c (compute_display_string_pos): Don't use cached display
7107 string position if the buffer had its restriction changed.
7110 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7112 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7114 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7116 Integer signedness and overflow and related fixes. (Bug#9079)
7118 * bidi.c: Integer size and overflow fixes.
7119 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7120 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7121 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7122 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7123 (bidi_find_other_level_edge):
7124 Use ptrdiff_t instead of EMACS_INT where either will do.
7125 This works better on 32-bit hosts configured --with-wide-int.
7126 (bidi_cache_ensure_space): Check for size-calculation overflow.
7127 Use % rather than repeated addition, for better worst-case speed.
7128 Don't set bidi_cache_size until after xrealloc returns, because it
7130 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
7131 (bidi_cache_ensure_space): Also check that the bidi cache size
7132 does not exceed that of the largest Lisp string or buffer. See Eli
7133 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
7135 * alloc.c (__malloc_size_t): Remove.
7136 All uses replaced by size_t. See Andreas Schwab's note
7137 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7139 * image.c: Improve checking for integer overflow.
7140 (check_image_size): Assume that f is nonnull, since
7141 it is always nonnull in practice. This is one less thing to
7142 worry about when checking for integer overflow later.
7143 (x_check_image_size): New function, which checks for integer
7144 overflow issues inside X.
7145 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7146 This removes the need for a memory_full check.
7147 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7148 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7149 (xbm_read_bitmap_data): Change locals back to 'int', since
7150 their values must fit in 'int'.
7151 (xpm_load_image, png_load, tiff_load):
7152 Invoke x_create_x_image_and_pixmap earlier,
7153 to avoid much needless work if the image is too large.
7154 (tiff_load): Treat overly large images as if
7155 x_create_x_image_and_pixmap failed, not as malloc failures.
7156 (gs_load): Use x_check_image_size.
7158 * gtkutil.c: Omit integer casts.
7159 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7160 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7162 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7164 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7165 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7166 would wrongly return t on a 64-bit host.
7168 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7169 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7170 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7171 and therefore cause GCC to emit a bogus diagnostic in some cases.
7173 * image.c: Integer signedness and overflow and related fixes.
7174 This is not an exhaustive set of fixes, but it's time to
7175 record what I've got.
7176 (lookup_pixel_color, check_image_size): Remove redundant decls.
7177 (check_image_size): Don't assume that arbitrary EMACS_INT values
7178 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7179 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7180 (tiff_load, imagemagick_load_image):
7181 Check for overflow in size calculations.
7182 (x_create_x_image_and_pixmap): Remove unnecessary test for
7183 xmalloc returning NULL; that can't happen.
7184 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7185 (xpm_color_bucket): Use better integer hashing function.
7186 (xpm_cache_color): Don't possibly over-allocate memory.
7187 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7188 (gif_memory_source):
7189 Use ptrdiff_t, not int or size_t, to record sizes.
7190 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7191 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7192 either works, as we prefer signed integers.
7193 (tiff_read_from_memory, tiff_write_from_memory):
7194 Return tsize_t, not size_t, since that's what the TIFF API wants.
7195 (tiff_read_from_memory): Don't fail simply because the read would
7196 go past EOF; instead, return a short read.
7197 (tiff_load): Omit no-longer-needed casts.
7198 (Fimagemagick_types): Don't assume size fits into 'int'.
7200 Improve hashing quality when configured --with-wide-int.
7201 * fns.c (hash_string): New function, taken from sxhash_string.
7202 Do not discard information about ASCII character case; this
7203 discarding is no longer needed.
7204 (sxhash-string): Use it. Change sig to match it. Caller changed.
7205 * lisp.h: Declare it.
7206 * lread.c (hash_string): Remove, since we now use fns.c's version.
7207 The fns.c version returns a wider integer if --with-wide-int is
7208 specified, so this should help the quality of the hashing a bit.
7210 * emacs.c: Integer overflow minor fix.
7211 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7212 Define only if GNU_LINUX.
7213 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7215 * dispnew.c: Integer signedness and overflow fixes.
7216 Remove unnecessary forward decls, that were a maintenance hassle.
7217 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7219 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7220 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7221 (prepare_desired_row, line_draw_cost):
7222 Use int, not unsigned, where either works.
7223 (save_current_matrix, restore_current_matrix):
7224 Use ptrdiff_t, not size_t, where either works.
7225 (init_display): Check for overflow more accurately, and without
7226 relying on undefined behavior.
7228 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7229 Remove, replacing with the new symbols in lisp.h. All uses changed.
7230 * fileio.c (make_temp_name):
7231 * filelock.c (lock_file_1, lock_file):
7232 * xdisp.c (message_dolog):
7233 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7234 Use pMd etc. instead.
7235 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7236 replacing the pWIDE etc. symbols removed from editfns.c.
7238 * keyboard.h (num_input_events): Now uintmax_t.
7239 This is (very slightly) less likely to mess up due to wraparound.
7242 * buffer.c: Integer signedness fixes.
7243 (alloc_buffer_text, enlarge_buffer_text):
7244 Use ptrdiff_t rather than size_t when either will do, as we prefer
7247 * alloc.c: Integer signedness and overflow fixes.
7248 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7249 (__malloc_size_t): Default to size_t, not to int.
7250 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7251 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7252 Prefer ptrdiff_t to size_t when either would do, as we prefer
7254 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7255 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7256 Now const. Initialize with values that are in range even if char
7258 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7259 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7260 These functions do the right thing with sizes > 2**32.
7261 (check_depth): Now ptrdiff_t, not int.
7262 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7263 Adjust to new way of storing sizes. Check for size overflow bugs
7265 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7266 slightly wrong anyway, as it missed one instance of
7267 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7268 (refill_memory_reserve): Omit needless cast to size_t.
7269 (mark_object_loop_halt): Mark as externally visible.
7271 * xselect.c: Integer signedness and overflow fixes.
7272 (Fx_register_dnd_atom, x_handle_dnd_message):
7273 Use ptrdiff_t, not size_t, since we prefer signed.
7274 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7275 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7276 x_dnd_atoms_size and x_dnd_atoms_length.
7278 * doprnt.c: Prefer signed to unsigned when either works.
7280 * doprnt.c (doprnt):
7282 * xdisp.c (vmessage):
7283 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7284 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7285 prefer signed arithmetic to avoid comparison confusion.
7286 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7287 but is a bit tricky.
7289 Assume freestanding C89 headers, string.h, stdlib.h.
7290 * data.c, doprnt.c, floatfns.c, print.c:
7291 Include float.h unconditionally.
7292 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7293 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7294 * regex.c: Likewise for stddef.h, string.h.
7295 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7296 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7297 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7298 (STDC_HEADERS): Remove obsolete defines.
7299 * sysdep.c: Include limits.h unconditionally.
7301 Assume support for memcmp, memcpy, memmove, memset.
7302 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7303 * regex.c (memcmp, memcpy):
7304 Remove; we assume C89 now.
7306 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7307 (__malloc_safe_bcopy): Remove; no longer needed.
7309 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
7310 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7311 well either way, and we prefer signed to unsigned.
7313 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7315 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7316 closes the connection while we're reading (bug#9182).
7318 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
7320 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7321 are specified (Bug#9168).
7323 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7325 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7326 Found by GCC static checking and --with-wide-int on a 32-bit host.
7328 2011-07-25 Eli Zaretskii <eliz@gnu.org>
7330 * xdisp.c (compute_display_string_pos): Fix logic of caching
7331 previous display string position. Initialize cached_prev_pos to
7332 -1. Fixes slow-down at the beginning of a buffer.
7334 2011-07-24 Eli Zaretskii <eliz@gnu.org>
7336 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7337 for attrs[LFACE_FONTSET_INDEX].
7339 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7341 * xml.c (parse_region): Remove unused local
7342 that was recently introduced.
7344 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7346 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7347 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7349 * xdisp.c (move_it_in_display_line_to): Record the best matching
7350 position for TO_CHARPOS while scanning the line, and restore it on
7351 exit if none of the characters scanned was an exact match.
7352 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7353 when exact match is impossible due to invisible text, and the
7354 lines are truncated.
7356 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7358 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7361 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7363 Fix a significant slow-down of cursor motion with C-n, C-p,
7364 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7365 auto-repeat under bidi redisplay in fontified buffers.
7366 * xdisp.c (compute_stop_pos_backwards): New function.
7367 (next_element_from_buffer): Call compute_stop_pos_backwards to
7368 find a suitable prev_stop when we find ourselves before
7370 (reseat): Don't look for prev_stop, as that could mean a very long
7372 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7373 <cached_disp_overlay_modiff>: Cache for last found display string
7375 (compute_display_string_pos): Return the cached position if asked
7376 about the same buffer in the same area of character positions, and
7377 the buffer wasn't changed since the time the display string
7378 position was cached.
7380 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7382 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7383 is an integer, which is important for empty lines. (Bug#9149)
7385 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7387 * frame.c (Fmodify_frame_parameters): In tty case, update the
7388 default face if necessary (Bug#4238).
7390 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7392 * editfns.c (Fstring_to_char): No need to explain what a character
7393 is in the docstring (Bug#6576).
7395 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7397 * xml.c (parse_region): Make sure we always return a tree.
7399 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7401 * xml.c (parse_region): If a document contains only comments,
7404 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7406 * xml.c (make_dom): Return comments, too.
7408 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7411 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7412 and the surrounding thread.
7413 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7414 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7415 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7417 * s/openbsd.h (BROKEN_SIGIO): Define.
7418 * unexelf.c (unexec) [__OpenBSD__]:
7419 Don't update the .mdebug section of the Alpha COFF symbol table.
7421 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7423 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7426 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7428 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7429 This fixes some race conditions on the permissions of any newly
7432 * alloc.c (valid_pointer_p): Use pipe, not open.
7433 This fixes some permissions issues when debugging.
7435 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7436 If fchown fails to set both uid and gid, try to set just gid,
7437 as that is sometimes allowed. Adjust the file's mode to eliminate
7438 setuid or setgid bits that are inappropriate if fchown fails.
7440 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7442 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7443 to compare Lisp_Objects.
7444 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7445 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7446 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7448 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7450 * lread.c (read_integer): Unread even EOF character.
7451 (read1): Likewise. Properly record start position of symbol.
7453 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7454 symbol character follows.
7456 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7458 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7459 This works around a problem with the previous change to Fcopy_file.
7460 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7461 and without this change, GCC might complain about discarding
7462 fchown's return value.
7464 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
7466 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7468 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7470 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7472 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7474 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7475 it's used from the C level.
7477 * process.c: Use the same condition for POLL_FOR_INPUT in both
7478 keyboard.c and process.c (bug#1858).
7480 2011-07-09 Lawrence Mitchell <wence@gmx.li>
7482 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7483 (Fgnutls_boot): Use it.
7485 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7487 * doc.c (Fsubstitute_command_keys): Revert last change.
7489 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7491 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7492 quotes the next character, and doesn't affect other longer
7493 sequences (bug#8935).
7495 * lread.c (syms_of_lread): Clarify that is isn't only
7496 `eval-buffer' and `eval-defun' that's affected by
7497 `lexical-binding' (bug#8460).
7499 2011-07-15 Eli Zaretskii <eliz@gnu.org>
7501 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
7502 bidi redisplay when a line includes both an image and is truncated.
7504 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7506 Fix minor problems found by static checking.
7507 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7508 (elsz): Now a signed constant, not a size_t var. We prefer signed
7509 types to unsigned, to avoid integer comparison confusion. Without
7510 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7511 "cannot optimize loop, the loop counter may overflow", a symptom
7513 * indent.c (Fvertical_motion): Mark locals as initialized.
7514 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7516 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7518 * search.c (Fre_search_backward): Mention `case-fold-search' in
7519 all the re_search_* functions (bug#8138).
7521 * keyboard.c (Fopen_dribble_file): Document when the file is
7524 2011-07-14 Eli Zaretskii <eliz@gnu.org>
7526 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7529 Support bidi reordering of display and overlay strings.
7530 * xdisp.c (compute_display_string_pos)
7531 (compute_display_string_end): Accept additional argument STRING.
7532 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7533 (reseat_to_string): Initialize bidi_it->string.s and
7534 bidi_it->string.schars.
7535 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
7536 NULL (avoids a crash in bidi_paragraph_init).
7537 Initialize itb.string.lstring.
7538 (init_iterator): Call bidi_init_it only of a valid
7539 buffer position was specified. Initialize paragraph_embedding to
7541 (reseat_to_string): Initialize the bidi iterator.
7542 (display_string): If we need to ignore text properties of
7543 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7544 original value of -1 will not work with bidi.)
7545 (compute_display_string_pos): First arg is now struct
7546 `text_pos *'; all callers changed. Support display properties on
7548 (compute_display_string_end): Support display properties on Lisp
7550 (init_iterator, reseat_1, reseat_to_string): Initialize the
7551 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7552 when iterating on a string not from display properties).
7553 (compute_display_string_pos, compute_display_string_end):
7554 Fix calculation of the object to scan. Fixes an error when using
7556 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
7557 base_level_stop; instead, set base_level_stop to BEGV.
7558 Fixes crashes in vertical-motion.
7559 (next_element_from_buffer): Improve commentary for when
7560 the iterator is before prev_stop.
7561 (init_iterator): Initialize bidi_p from the default value of
7562 bidi-display-reordering, not from buffer-local value. Use the
7563 buffer-local value only if initializing for buffer iteration.
7564 (handle_invisible_prop): Support invisible properties on strings
7565 that are being bidi-reordered.
7566 (set_iterator_to_next): Support bidi reordering of C strings and
7568 (next_element_from_string): Support bidi reordering of Lisp
7570 (handle_stop_backwards): Support Lisp strings as well.
7571 (display_string): Support display of R2L glyph rows.
7572 Use IT_STRING_CHARPOS when displaying from a Lisp string.
7573 (init_iterator): Don't initialize it->bidi_p for strings
7575 (reseat_to_string): Initialize it->bidi_p for strings here.
7576 (next_element_from_string, next_element_from_c_string)
7577 (next_element_from_buffer): Add xassert's for correspondence
7578 between IT's object being iterated and it->bidi_it.string
7580 (face_before_or_after_it_pos): Support bidi iteration.
7581 (next_element_from_c_string): Handle the case of the first string
7582 character that is not the first one in the visual order.
7583 (get_visually_first_element): New function, refactored from common
7584 parts of next_element_from_buffer, next_element_from_string, and
7585 next_element_from_c_string.
7586 (tool_bar_lines_needed, redisplay_tool_bar)
7587 (display_menu_bar): Force left-to-right direction. Add a FIXME
7588 comment for making that be controlled by a user option.
7589 (push_it, pop_it): Save and restore the state of the
7590 bidi iterator. Save and restore the bidi_p flag.
7591 (pop_it): Iterate out of display property for string iteration as
7593 (iterate_out_of_display_property): Support iteration over strings.
7594 (handle_single_display_spec): Set up it->bidi_it for iteration
7595 over a display string, and call bidi_init_it.
7596 (handle_single_display_spec, next_overlay_string)
7597 (get_overlay_strings_1, push_display_prop): Set up the bidi
7598 iterator for displaying display or overlay strings.
7599 (forward_to_next_line_start): Don't use the shortcut if
7601 (back_to_previous_visible_line_start): If handle_display_prop
7602 pushed the iterator stack, restore the internal state of the bidi
7603 iterator by calling bidi_pop_it same number of times.
7604 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7605 and we are bidi-iterating, don't decrement the iterator position;
7606 instead, set the first_elt flag in the bidi iterator, to produce
7608 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7609 (push_display_prop): xassert that we are iterating a buffer.
7610 (push_it, pop_it): Save and restore paragraph_embedding member.
7611 (handle_single_display_spec, next_overlay_string)
7612 (get_overlay_strings_1, reseat_1, reseat_to_string)
7613 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7614 correctly. Don't assume unibyte strings are not bidi-reordered.
7615 (compute_display_string_pos)
7616 (compute_display_string_end): Fix handling the case of C string.
7617 (push_it, pop_it): Save and restore from_disp_prop_p.
7618 (handle_single_display_spec, push_display_prop): Set the
7619 from_disp_prop_p flag.
7620 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7621 (pop_it): Call iterate_out_of_display_property only if we are
7622 popping after iteration over a string that came from a display
7623 property. Fix a typo in popping stretch info. Add an assertion
7624 for verifying that the iterator position is in sync with the bidi
7626 (handle_single_display_spec, get_overlay_strings_1)
7627 (push_display_prop): Fix initialization of paragraph direction for
7628 string when that of the parent object is not yet determined.
7629 (reseat_1): Call bidi_init_it to resync the bidi
7630 iterator with IT's position. (Bug#7616)
7631 (find_row_edges): If ROW->start.pos gives position
7632 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7633 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7634 Reset the from_disp_prop_p flag.
7635 (SAVE_IT, RESTORE_IT): New macros.
7636 (pos_visible_p, face_before_or_after_it_pos)
7637 (back_to_previous_visible_line_start)
7638 (move_it_in_display_line_to, move_it_in_display_line)
7639 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7640 (try_scrolling, redisplay_window, display_line): Use them when
7641 saving a temporary copy of the iterator and restoring it back.
7642 (back_to_previous_visible_line_start, reseat_1)
7643 (init_iterator): Empty the bidi cache "stack".
7644 (move_it_in_display_line_to): If iterator ended up at
7645 EOL, but we never saw any buffer positions smaller than
7646 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7647 motion in bidi-reordered lines.
7648 (move_it_in_display_line_to): Record prev_method and prev_pos
7649 immediately before the call to set_iterator_to_next. Fixes cursor
7650 motion in bidi-reordered lines with stretch glyphs and strings
7651 displayed in margins. (Bug#8133) (Bug#8867)
7652 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7654 (pos_visible_p): Support positions in bidi-reordered lines.
7655 Save and restore bidi cache.
7657 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7658 (bidi_paragraph_info): Delete unused struct.
7659 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7660 (bidi_cache_start): New variable.
7661 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7663 (bidi_cache_fetch_state, bidi_cache_search)
7664 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7665 (bidi_cache_find, bidi_peek_at_next_level)
7666 (bidi_level_of_next_char, bidi_find_other_level_edge)
7667 (bidi_move_to_visually_next): Compare cache index with
7668 bidi_cache_start rather than with zero.
7669 (bidi_fetch_char): Accept new argument STRING; all callers
7670 changed. Support iteration over a string. Support strings with
7671 display properties. Support unibyte strings. Fix the type of
7672 `len' according to what STRING_CHAR_AND_LENGTH expects.
7673 (bidi_paragraph_init, bidi_resolve_explicit_1)
7674 (bidi_resolve_explicit, bidi_resolve_weak)
7675 (bidi_level_of_next_char, bidi_move_to_visually_next):
7676 Support iteration over a string.
7677 (bidi_set_sor_type, bidi_resolve_explicit_1)
7678 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7679 can now be zero (for strings); special values 0 and -1 were
7680 changed to -1 and -2, respectively.
7681 (bidi_char_at_pos): New function.
7682 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7683 Call it instead of FETCH_MULTIBYTE_CHAR.
7684 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7685 initialized to valid values.
7686 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7688 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7689 the test for valid cached positions. Fix the logic for looking up
7690 the sentinel state in the cache. GCPRO the Lisp string we are
7692 (bidi_push_it, bidi_pop_it): New functions.
7693 (bidi_initialize): Initialize the bidi cache start stack pointer.
7694 (bidi_cache_ensure_space): New function, refactored from part of
7695 bidi_cache_iterator_state. Don't assume the required size is just
7696 one BIDI_CACHE_CHUNK away.
7697 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7698 (bidi_count_bytes, bidi_char_at_pos): New functions.
7699 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7700 always valid if bidi_cache_idx is valid.
7701 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7702 is valid if it's going to be used.
7703 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7704 (bidi_cache_fetch_state, bidi_cache_search)
7705 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7706 (bidi_cache_iterator_state, bidi_cache_find)
7707 (bidi_find_other_level_edge, bidi_cache_start_stack):
7708 All variables related to cache indices are now EMACS_INT.
7710 * dispextern.h (struct bidi_string_data): New structure.
7711 (struct bidi_it): New member `string'. Make flag members be 1-bit
7712 fields, and put them last in the struct.
7713 (compute_display_string_pos, compute_display_string_end):
7715 (bidi_push_it, bidi_pop_it): Add prototypes.
7716 (struct iterator_stack_entry): New members bidi_p,
7717 paragraph_embedding, and from_disp_prop_p.
7718 (struct it): Member bidi_p is now a bit field 1 bit wide.
7719 (bidi_shelve_cache, bidi_unshelve_cache):
7722 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7723 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7724 and vector-like objects.
7726 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7727 cache around display iteration.
7729 * window.c (Fwindow_end, window_scroll_pixel_based)
7730 (displayed_window_lines, Frecenter): Save and restore the bidi
7731 cache around display iteration.
7733 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7735 * editfns.c (Fdelete_region): Clarify the use of the named
7736 parameters (bug#6788).
7738 2011-07-14 Martin Rudalics <rudalics@gmx.at>
7740 * indent.c (Fvertical_motion): Set and restore w->pointm when
7741 saving and restoring the window's buffer (Bug#9006).
7743 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7745 * editfns.c (Fstring_to_char): Clarify just what is returned
7746 (bug#6576). Text by Eli Zaretskii.
7748 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
7750 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7752 2011-07-13 Eli Zaretskii <eliz@gnu.org>
7754 * buffer.c (mmap_find): Fix a typo.
7756 2011-07-13 Johan Bockgård <bojohan@gnu.org>
7758 Fix execution of x selection hooks.
7759 * xselect.c (Qx_lost_selection_functions)
7760 (Qx_sent_selection_functions): New vars.
7761 (syms_of_xselect): DEFSYM them.
7762 (x_handle_selection_request): Pass Qx_sent_selection_functions
7763 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7764 (x_handle_selection_clear,x_clear_frame_selections):
7765 Pass Qx_lost_selection_functions rather than
7766 Vx_lost_selection_functions to Frun_hook_with_args.
7768 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7770 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
7771 The old code sometimes used this field without initializing it.
7773 * alloc.c (gc_sweep): Don't read past end of array.
7774 In theory, the old code could also have corrupted Emacs internals,
7775 though it'd be very unlikely.
7777 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7779 * character.c (Fcharacterp): Don't advertise optional ignored
7780 argument. (Bug#4026)
7782 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7784 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7787 * window.c (Fset_window_start): Doc fix (bug#4199).
7788 (Fset_window_hscroll): Ditto.
7790 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7792 Fix minor new problems caught by GCC 4.6.1.
7793 * term.c (init_tty): Remove unused local.
7794 * xsettings.c (store_monospaced_changed): Define this function only
7795 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
7798 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
7800 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7802 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7804 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7805 are the mini-buffer and the echo area (bug#3320).
7807 * term.c (init_tty): Remove support for supdup, c10 and perq
7808 terminals, which are no longer supported (bug#1482).
7810 2011-07-10 Johan Bockgård <bojohan@gnu.org>
7812 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7814 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7816 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7817 for non-popups (Bug#3642).
7819 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7821 * alloc.c (reset_malloc_hooks): Protoize.
7822 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
7823 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7824 * cm.c (losecursor): Likewise.
7825 * data.c (fmod): Likewise.
7826 * dispnew.c (swap_glyphs_in_rows): Likewise.
7827 * emacs.c (memory_warning_signal): Likewise.
7828 * floatfns.c (float_error): Likewise.
7829 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7830 (otf_open, font_otf_capability, generate_otf_features)
7831 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7833 * image.c (pbm_read_file): Likewise.
7834 * indent.c (string_display_width): Likewise.
7835 * intervals.c (check_for_interval, search_for_interval)
7836 (inc_interval_count, count_intervals, root_interval)
7837 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7838 * lread.c (defalias): Likewise.
7839 * ralloc.c (r_alloc_check): Likewise.
7840 * regex.c (set_image_of_range_1, set_image_of_range)
7841 (regex_grow_registers): Likewise.
7842 * sysdep.c (strerror): Likewise.
7843 * termcap.c (valid_filename_p, tprint, main): Likewise.
7844 * tparam.c (main): Likewise.
7845 * unexhp9k800.c (run_time_remap, save_data_space)
7846 (update_file_ptrs, read_header, write_header, calculate_checksum)
7847 (copy_file, copy_rest, display_header): Likewise.
7848 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7850 * xdisp.c (check_it): Likewise.
7851 * xfaces.c (register_color, unregister_color, unregister_colors):
7853 * xfns.c (print_fontset_result): Likewise.
7854 * xrdb.c (member, fatal, main): Likewise.
7856 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7858 Fix minor problems found by static checking (Bug#9031).
7859 * chartab.c (char_table_set_range, map_sub_char_table):
7860 Remove unused locals.
7861 (uniprop_table): Now static.
7862 * composite.c (_work_char): Remove unused static var.
7864 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
7866 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7868 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7870 * gtkutil.c (qttip_cb): Remove code without function.
7872 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7874 * w32.c (pthread_sigmask): New stub.
7876 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
7878 Use pthread_sigmask, not sigprocmask (Bug#9010).
7879 sigprocmask is portable only for single-threaded applications, and
7880 Emacs can be multi-threaded when it uses GTK.
7881 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7883 * callproc.c (Fcall_process):
7884 * process.c (create_process):
7885 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7886 Use pthread_sigmask, not sigprocmask.
7888 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7890 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7891 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7894 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7896 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7897 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7898 (xg_hide_tooltip): Fix comment.
7900 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7901 in registerServicesMenuSendTypes.
7902 (validRequestorForSendType): Don't check ns_return_types.
7904 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7907 2011-07-08 Jason Rumney <jasonr@gnu.org>
7909 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7910 SH_SHOW for hidden windows (Bug#5482).
7912 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7913 frame struct members of non-existent frames (Bug#6284).
7915 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7917 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7918 variable firstTime not needed on OSX >= 10.6.
7919 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7920 >= 10.5. Use setKnobProportion, setDoubleValue.
7922 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7923 (MAC_OS_X_VERSION_10_5): Define if not defined.
7924 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7925 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7926 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7928 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7929 cString and lossyCString on OSX >= 10.4.
7931 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7932 sizeToFit on OSX >= 10.2.
7934 * nsimage.m (allocInitFromFile): Don't use deprecated method
7935 bestRepresentationForDevice on OSX >= 10.6.
7937 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7940 * emacs.c: Declare unexec_init_emacs_zone.
7942 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7944 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7946 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7947 on svcsMenu (Bug#8842).
7949 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7951 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7953 * nsterm.m (QUTF8_STRING): Declare.
7954 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7955 (validRequestorForSendType): Return type is (id).
7956 Change indexOfObjectIdenticalTo to indexOfObject.
7957 Check if we have local selection before returning self (Bug#8842).
7958 (writeSelectionToPasteboard): Put local selection into paste board
7959 if we have a local selection (Bug#8842).
7960 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7962 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7963 (ns_get_local_selection): Declare.
7965 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7967 * keymap.c (describe_map_tree): Don't insert a double newline at
7968 the end of the buffer (bug#1169) and return whether we inserted
7971 * callint.c (Fcall_interactively): Change "reading args" to
7972 "providing args" to try to clarify what it does (bug#1010).
7974 2011-07-07 Kenichi Handa <handa@m17n.org>
7976 * composite.c (composition_compute_stop_pos): Ignore a static
7977 composition starting before CHARPOS (Bug#8915).
7979 * xdisp.c (handle_composition_prop): Likewise.
7981 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7983 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7986 2011-07-07 Kenichi Handa <handa@m17n.org>
7988 * character.h (unicode_category_t): New enum type.
7990 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7991 (Qchar_code_property_table): New variable.
7992 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7993 (UNIPROP_COMPRESSED_FORM_P): New macros.
7994 (char_table_ascii): Uncompress the compressed values.
7995 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7996 Uncompress the compressed values.
7997 (sub_char_table_ref_and_range): Likewise.
7998 (char_table_ref_and_range): Uncompress the compressed values.
7999 (sub_char_table_set): New arg is_uniprop. Callers changed.
8000 Uncompress the compressed values.
8001 (sub_char_table_set_range): Args changed. Callers changed.
8002 (char_table_set_range): Adjuted for the above change.
8003 (map_sub_char_table): Delete args default_val and parent. Add arg
8004 top. Give decoded values to a Lisp function.
8005 (map_char_table): Adjust for the above change. Give decoded
8006 values to a Lisp function. Gcpro more variables.
8007 (uniprop_table_uncompress)
8008 (uniprop_decode_value_run_length): New functions.
8009 (uniprop_decoder, uniprop_decoder_count): New variables.
8010 (uniprop_get_decoder, uniprop_encode_value_character)
8011 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8013 (uniprop_encoder, uniprop_encoder_count): New variables.
8014 (uniprop_get_encoder, uniprop_table)
8015 (Funicode_property_table_internal, Fget_unicode_property_internal)
8016 (Fput_unicode_property_internal): New functions.
8017 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8018 Sunicode_property_table_internal, Sget_unicode_property_internal,
8019 and Sput_unicode_property_internal. Defvar_lisp
8020 char-code-property-alist.
8022 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
8023 Vunicode_category_table.
8025 * font.c (font_range): Adjust for the change of
8026 Vunicode_category_table.
8028 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8030 * m/iris4d.h: Remove file, move contents ...
8031 * s/irix6-5.h: ... here.
8033 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8035 Remove unportable assumption about struct layout (Bug#8884).
8036 * alloc.c (mark_buffer):
8037 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8038 (clone_per_buffer_values): Don't assume that
8039 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8040 This isn't true in general, and it's particularly not true
8041 if Emacs is configured with --with-wide-int.
8042 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8043 New macros, used in the buffer.c change.
8045 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8047 * xsettings.c: Use both GConf and GSettings if both are available.
8048 (store_config_changed_event): Add comment.
8049 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8050 (store_tool_bar_style_changed): New functions.
8051 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
8052 (struct xsettings): Move font inside HAVE_XFT.
8053 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
8054 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
8055 Move inside HAVE_XFT.
8056 (something_changed_gsettingsCB): Rename from something_changedCB.
8057 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8059 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
8060 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
8061 (something_changed_gconfCB): Rename from something_changedCB.
8062 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8063 (parse_settings): Move check for font inside HAVE_XFT.
8064 (read_settings, apply_xft_settings): Add comment.
8065 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8066 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8067 call store_font_name_changed.
8068 (xft_settings_event): Add comment.
8069 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8070 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8071 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8072 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8073 (xsettings_initialize): Call init_gsettings last.
8074 (xsettings_get_system_font, xsettings_get_system_normal_font):
8077 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8079 Random fixes. E.g., (random) never returned negative values.
8080 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8081 subseconds part to the entropy, as that's a bit more random.
8082 Prefer signed to unsigned, since the signedness doesn't matter and
8083 in general we prefer signed. When given a limit, use a
8084 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8085 latter isn't right if USE_2_TAGS_FOR_INTS.
8086 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8087 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8089 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8091 * textprop.c (text_property_stickiness):
8092 Obey Vtext_property_default_nonsticky.
8093 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8094 * w32fns.c (syms_of_w32fns):
8095 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8097 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8099 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8100 This is more efficient than Ffile_directory_p and avoids a minor race.
8102 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8104 * buffer.c (Foverlay_put): Say what the return value is
8107 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8108 is a directory before asking whether to use the file name
8110 (barf_or_query_if_file_exists): Make the "File is a directory"
8111 error be more correct.
8113 * fns.c (Frequire): Remove the mention of the .gz files, since
8114 that's installation-specific, but keep the mention of
8115 `get-load-suffixes'.
8117 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8119 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8120 Report string overflow if the output is too long.
8122 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
8124 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8125 (syms_of_gnutls): Remove duplicate DEFSYM for
8126 Qgnutls_bootprop_verify_hostname_error, an error for
8127 Qgnutls_bootprop_verify_error (which is no longer used).
8129 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8130 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8131 Also (re)move comments that are misplaced or no longer relevant.
8133 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8135 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8137 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
8139 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8140 and background color parameters if they have been changed.
8142 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8144 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8146 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8148 * xsettings.c (SYSTEM_FONT): Define only when used.
8149 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8151 * keymap.c (access_keymap_1): Now static.
8153 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
8155 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8156 leave any prefix arg for the up event (Bug#1586).
8158 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8160 * lread.c (syms_of_lread): Mention single symbols defined by
8161 `defvar' or `defconst' (bug#7154).
8163 * fns.c (Frequire): Mention .el.gz files (bug#7314).
8164 (Frequire): Mention get-load-suffixes.
8166 2011-07-02 Martin Rudalics <rudalics@gmx.at>
8168 * window.h (window): Remove clone_number slot.
8169 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8171 (make_parent_window, make_window, saved_window)
8172 (Fset_window_configuration, save_window_save): Don't deal with
8174 * buffer.c (Qclone_number): Remove declaration.
8175 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8177 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8179 Add multiple inheritance to keymaps.
8180 * keymap.c (Fmake_composed_keymap): New function.
8181 (Fset_keymap_parent): Simplify.
8182 (fix_submap_inheritance): Remove.
8183 (access_keymap_1): New function extracted from access_keymap to handle
8184 embedded parents and handle lists of maps.
8185 (access_keymap): Use it.
8186 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8187 (Fcopy_keymap): Handle embedded parents.
8188 (Fcommand_remapping, define_as_prefix): Simplify.
8189 (Fkey_binding): Simplify.
8190 (syms_of_keymap): Move minibuffer-local-completion-map,
8191 minibuffer-local-filename-completion-map,
8192 minibuffer-local-must-match-map, and
8193 minibuffer-local-filename-must-match-map to Elisp.
8194 (syms_of_keymap): Defsubr make-composed-keymap.
8195 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8196 (parse_menu_item): Trivial simplification.
8198 2011-07-01 Glenn Morris <rgm@gnu.org>
8200 * Makefile.in (SETTINGS_LIBS): Fix typo.
8202 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8204 * coding.c (Fencode_coding_string): Record the last coding system
8205 used, as the function doc string says (bug#8738).
8207 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8209 * xsettings.c (store_monospaced_changed): Take new font as arg and
8210 check for change against current_mono_font.
8211 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8212 (emacs_settings_constructor, emacs_settings_get_property)
8213 (emacs_settings_set_property, emacs_settings_class_init)
8214 (emacs_settings_init, gsettings_obj): Remove.
8215 (something_changedCB): New function for HAVE_GSETTINGS.
8216 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8217 with value as argument.
8218 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8219 g_settings_new (Bug#8967). Do not create gsettings_obj.
8220 Remove calls to g_settings_bind. Connect something_changedCB to
8223 * xgselect.c: Add defined (HAVE_GSETTINGS).
8224 (xgselect_initialize): Ditto.
8226 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8227 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8230 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8232 * eval.c (struct backtrace): Simplify and port the data structure.
8233 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8234 signed bit field, as this assumption is not portable and it makes
8235 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8236 "char debug_on_exit : 1" as this is not portable either; instead,
8237 use the portable "unsigned int debug_on_exit : 1". Remove unused
8238 member evalargs. Remove obsolete comments about cc bombing out.
8240 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8242 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
8243 Let HAVE_GSETTINGS override HAVE_GCONF.
8244 (store_monospaced_changed): New function.
8245 (EMACS_SETTINGS): A new type derived from GObject to handle
8246 GSettings notifications.
8247 (emacs_settings_constructor, emacs_settings_get_property)
8248 (emacs_settings_set_property, emacs_settings_class_init):
8250 (gsettings_client, gsettings_obj): New variables.
8251 (GSETTINGS_SCHEMA): New define.
8252 (something_changedCB): Call store_monospaced_changed.
8253 (init_gsettings): New function.
8254 (xsettings_initialize): Call init_gsettings.
8255 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8258 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
8261 2011-06-29 Martin Rudalics <rudalics@gmx.at>
8263 * window.c (resize_root_window, grow_mini_window)
8264 (shrink_mini_window): Rename Qresize_root_window to
8265 Qwindow_resize_root_window and Qresize_root_window_vertically to
8266 Qwindow_resize_root_window_vertically.
8268 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8270 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8272 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
8274 * makefile.w32-in: Redesign dependencies so they reflect more
8275 clearly which files are directly included by each source file,
8276 and not through other includes.
8278 2011-06-27 Martin Rudalics <rudalics@gmx.at>
8280 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8281 (sort_overlays, overlay_strings): When an overlay's clone number
8282 matches the window's clone number process the overlay even if
8283 the overlay's window property doesn't match the current window.
8285 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8286 (Fwindow_hchild): Rename to Fwindow_left_child.
8287 (Fwindow_next): Rename to Fwindow_next_sibling.
8288 (Fwindow_prev): Rename to Fwindow_prev_sibling.
8289 (resize_window_check): Rename to window_resize_check.
8290 (resize_window_apply): Rename to window_resize_apply.
8291 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8292 (Fdelete_other_windows_internal, resize_frame_windows)
8293 (Fsplit_window_internal, Fdelete_window_internal)
8294 (grow_mini_window, shrink_mini_window)
8295 (Fresize_mini_window_internal): Fix callers accordingly.
8297 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8299 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8300 (emacs_fixed_set_min_size): Remove.
8301 (emacs_fixed_new): Take frame as argument.
8303 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8304 (_EmacsFixedPrivate): Remove minwidth/height.
8305 Add struct frame *f.
8306 (emacs_fixed_init): Initialize priv->f.
8307 (get_parent_class, emacs_fixed_set_min_size): Remove.
8308 (emacs_fixed_new): Set priv->f to argument.
8309 (emacs_fixed_get_preferred_width)
8310 (emacs_fixed_get_preferred_height): Use min_width/height from
8311 frames size_hint to set minimum and natural (Bug#8919).
8312 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8313 and use min_width/height from frames size_hint to set
8314 min_width/height (Bug#8919).
8316 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
8317 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8320 2011-06-26 Eli Zaretskii <eliz@gnu.org>
8322 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8323 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8326 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
8328 * process.c (wait_reading_process_output): Bypass select if
8329 waiting for a cell while ignoring keyboard input, and input is
8330 pending. Suggested by Jan Djärv (Bug#8869).
8332 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8334 Use gnulib's dup2 module instead of rolling our own.
8335 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8337 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8339 * dispnew.c (scrolling_window): Before scrolling, turn off a
8340 mouse-highlight in the window being scrolled.
8342 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8344 Move DEFSYM to lisp.h and use everywhere.
8346 * character.h (DEFSYM): Move declaration...
8347 * lisp.h (DEFSYM): ...here.
8353 * w32select.c: Don't include character.h.
8355 * alloc.c (syms_of_alloc):
8356 * buffer.c (syms_of_buffer):
8357 * bytecode.c (syms_of_bytecode):
8358 * callint.c (syms_of_callint):
8359 * casefiddle.c (syms_of_casefiddle):
8360 * casetab.c (init_casetab_once):
8361 * category.c (init_category_once, syms_of_category):
8362 * ccl.c (syms_of_ccl):
8363 * cmds.c (syms_of_cmds):
8364 * composite.c (syms_of_composite):
8365 * dbusbind.c (syms_of_dbusbind):
8366 * dired.c (syms_of_dired):
8367 * dispnew.c (syms_of_display):
8368 * doc.c (syms_of_doc):
8369 * editfns.c (syms_of_editfns):
8370 * emacs.c (syms_of_emacs):
8371 * eval.c (syms_of_eval):
8372 * fileio.c (syms_of_fileio):
8373 * fns.c (syms_of_fns):
8374 * frame.c (syms_of_frame):
8375 * fringe.c (syms_of_fringe):
8376 * insdel.c (syms_of_insdel):
8377 * keymap.c (syms_of_keymap):
8378 * lread.c (init_obarray, syms_of_lread):
8379 * macros.c (syms_of_macros):
8380 * msdos.c (syms_of_msdos):
8381 * print.c (syms_of_print):
8382 * process.c (syms_of_process):
8383 * search.c (syms_of_search):
8384 * sound.c (syms_of_sound):
8385 * syntax.c (init_syntax_once, syms_of_syntax):
8386 * terminal.c (syms_of_terminal):
8387 * textprop.c (syms_of_textprop):
8388 * undo.c (syms_of_undo):
8389 * w32.c (globals_of_w32):
8390 * window.c (syms_of_window):
8391 * xdisp.c (syms_of_xdisp):
8392 * xfaces.c (syms_of_xfaces):
8393 * xfns.c (syms_of_xfns):
8394 * xmenu.c (syms_of_xmenu):
8395 * xsettings.c (syms_of_xsettings):
8396 * xterm.c (syms_of_xterm): Use DEFSYM.
8398 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8400 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8402 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8404 Integer and buffer overflow fixes (Bug#8873).
8406 * print.c (printchar, strout): Check for string overflow.
8407 (PRINTPREPARE, printchar, strout):
8408 Don't set size unless allocation succeeds.
8410 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8411 for sizes. Check for string overflow more accurately.
8412 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8414 * macros.c: Integer and buffer overflow fixes.
8415 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8416 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8417 Use ptrdiff_t, not int, for sizes.
8418 Don't increment bufsize until after realloc succeeds.
8419 Check for size-calculation overflow.
8420 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8422 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8424 * lread.c: Integer overflow fixes.
8425 (read_integer): Radix is now EMACS_INT, not int,
8426 to improve quality of diagnostics for out-of-range radices.
8427 Calculate buffer size correctly for out-of-range radices.
8428 (read1): Check for integer overflow in radices, and in
8429 read-circle numbers.
8430 (read_escape): Avoid int overflow.
8431 (Fload, openp, read_buffer_size, read1)
8432 (substitute_object_recurse, read_vector, read_list, map_obarray):
8433 Use ptrdiff_t, not int, for sizes.
8434 (read1): Use EMACS_INT, not int, for sizes.
8435 Check for size overflow.
8437 * image.c (cache_image): Check for size arithmetic overflow.
8439 * lread.c: Integer overflow issues.
8440 (saved_doc_string_size, saved_doc_string_length)
8441 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8442 Now ptrdiff_t, not int.
8443 (read1): Don't assume doc string length fits in int. Check for
8444 out-of-range doc string lengths.
8445 (read_list): Don't assume file position fits in int.
8446 (read_escape): Check for hex character overflow.
8448 2011-06-22 Leo Liu <sdl.web@gmail.com>
8450 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8451 Move to minibuffer.el.
8453 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8455 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8456 The following patches are for when GLYPH_DEBUG && !XASSERT.
8457 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8458 * dispnew.c (flush_stdout):
8459 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8460 Mark as externally visible.
8461 * dispnew.c (check_window_matrix_pointers): Now static.
8462 * dispnew.c (window_to_frame_vpos):
8463 * xfns.c (unwind_create_frame):
8464 * xterm.c (x_check_font): Remove unused local.
8465 * scroll.c (CHECK_BOUNDS):
8466 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8467 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8468 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8469 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8470 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8472 (debug_method_add): Use va_list and vsprintf rather than relying
8473 on undefined behavior with wrong number of arguments.
8474 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8475 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8476 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8477 since we're not interested in debugging glyphs with old libraries.
8478 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8479 GCC 4.6.0's static checking.
8481 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8483 Integer overflow and signedness fixes (Bug#8873).
8484 A few related buffer overrun fixes, too.
8486 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8488 * dispextern.h (struct face.stipple):
8489 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8490 (x_bitmap_mask, x_allocate_bitmap_record)
8491 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8492 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8493 (x_create_bitmap_from_xpm_data):
8494 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8495 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8497 * xfaces.c (load_pixmap):
8498 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8499 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8500 (.bitmaps_last, struct x_output.icon_bitmap):
8501 Use ptrdiff_t, not int, for bitmap indexes.
8502 (x_allocate_bitmap_record): Check for size overflow.
8503 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8505 Use ptrdiff_t, not int, for overlay counts.
8506 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8507 * editfns.c (overlays_around, get_pos_property):
8508 * textprop.c (get_char_property_and_overlay):
8509 * xdisp.c (next_overlay_change, note_mouse_highlight):
8510 * xfaces.c (face_at_buffer_position):
8511 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8512 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8513 (Fnext_overlay_change, Fprevious_overlay_change)
8514 (mouse_face_overlay_overlaps, Foverlays_in):
8515 Use ptrdiff_t, not int, for sizes.
8516 (overlays_at, overlays_in): Check for size-calculation overflow.
8518 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8520 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8521 (x_session_initialize): Do not assume string length fits in int.
8523 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8524 This is unlikely, but can occur if DPI is outlandish.
8526 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
8527 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8529 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8530 * xrdb.c (magic_file_p, search_magic_path):
8531 Omit last arg SUFFIX; it was always 0. All callers changed.
8532 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8534 * xfont.c (xfont_match): Avoid need for strlen.
8536 * xfns.c: Don't assume strlen fits in int.
8537 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8539 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8540 not unsigned long, as we prefer signed integers. All callers changed.
8541 Detect integer overflow in repeat count.
8542 (message_dolog): Don't assume print length fits in 39 bytes.
8543 (display_mode_element): Don't assume strlen fits in int.
8545 * termcap.c: Don't assume sizes fit in int and never overflow.
8546 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8547 (gobble_line): Check for size-calculation overflow.
8549 * minibuf.c (Fread_buffer):
8550 * lread.c (intern, intern_c_string):
8551 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8552 Don't assume string length fits in int.
8554 * keyboard.c (parse_tool_bar_item):
8555 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8557 * font.c: Don't assume string length fits in int.
8558 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8559 Use ptrdiff_t, not int.
8560 (font_intern_prop): Don't assume string length fits in int.
8561 Don't assume integer property fits in fixnum.
8562 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
8564 * filelock.c: Fix some buffer overrun and integer overflow issues.
8565 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
8566 Reformulate so as not to need the command string.
8567 Invoke gzip -cd rather than gunzip, as it's more portable.
8568 (lock_info_type, lock_file_1, lock_file):
8569 Don't assume pid_t and time_t fit in unsigned long.
8570 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8571 (current_lock_owner): Prefer signed type for sizes.
8572 Use memcpy, not strncpy, where memcpy is what is really wanted.
8573 Don't assume (via atoi) that time_t and pid_t fit in int.
8574 Check for time_t and/or pid_t out of range, e.g., via a network share.
8575 Don't alloca where an auto var works fine.
8577 * fileio.c: Fix some integer overflow issues.
8578 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8579 Don't assume string length fits in int.
8580 (directory_file_name): Don't assume string length fits in long.
8581 (make_temp_name): Don't assume pid fits in int, or that its print
8582 length is less than 20.
8584 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8586 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8588 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8590 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8591 We prefer signed integers, even for size calculations.
8593 * emacs.c: Don't assume string length fits in 'int'.
8594 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8595 (main): Don't invoke strlen when not needed.
8597 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8598 (XD_DEBUG_MESSAGE): Don't waste a byte.
8600 * callproc.c (getenv_internal_1, getenv_internal)
8602 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8604 * lread.c (invalid_syntax): Omit length argument.
8605 All uses changed. This doesn't fix a bug, but it simplifies the
8606 code away from its former Hollerith-constant appearance, and it's
8607 one less 'int' to worry about when looking at integer-overflow issues.
8608 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
8610 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8611 This didn't break anything, but it didn't help either.
8612 It's confusing to put a bogus integer in a place where the actual
8613 value does not matter.
8614 (LIST_END_P): Remove unused macro and its bogus comment.
8615 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
8617 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8618 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8620 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8621 We prefer signed types, and the value cannot exceed the EMACS_INT
8622 range anyway (because otherwise the length would not be representable).
8623 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8624 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8625 This avoids a GCC warning when WIDE_EMACS_INT.
8627 * indent.c (sane_tab_width): New function.
8628 (current_column, scan_for_column, Findent_to, position_indentation)
8629 (compute_motion): Use it. This is just for clarity.
8630 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
8632 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
8634 * lisp.h (lint_assume): New macro.
8635 * composite.c (composition_gstring_put_cache):
8636 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8638 * editfns.c, insdel.c:
8639 Omit unnecessary forward decls, to simplify future changes.
8641 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8643 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8645 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
8646 Use much-faster test for byte-length change.
8647 Don't assume string byte-length fits in 'int'.
8648 Check that character arg fits in 'int'.
8649 (mapcar1): Declare byte as byte, for clarity.
8651 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8653 * fns.c (concat): Catch string overflow earlier.
8654 Do not rely on integer wraparound.
8656 * dispextern.h (struct it.overlay_strings_charpos)
8657 (struct it.selective): Now EMACS_INT, not int.
8658 * xdisp.c (forward_to_next_line_start)
8659 (back_to_previous_visible_line_start)
8660 (reseat_at_next_visible_line_start, next_element_from_buffer):
8661 Don't arbitrarily truncate the value of 'selective' to int.
8663 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8665 * composite.c: Don't truncate sizes to 'int'.
8666 (composition_gstring_p, composition_reseat_it)
8667 (composition_adjust_point): Use EMACS_INT, not int.
8668 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8669 not EMACS_UINT, for indexes.
8671 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8673 * buffer.c: Include <verify.h>.
8674 (struct sortvec.priority, struct sortstr.priority):
8675 Now EMACS_INT, not int.
8676 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
8677 (struct sortstr.size, record_overlay_string)
8678 (struct sortstrlist.size, struct sortlist.used):
8679 Don't truncate size to int.
8680 (record_overlay_string): Check for size-calculation overflow.
8681 (init_buffer_once): Check at compile-time, not run-time.
8683 2011-06-22 Jim Meyering <meyering@redhat.com>
8685 Don't leak an XBM-image-sized buffer
8686 * image.c (xbm_load): Free the image buffer after using it.
8688 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8691 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8692 that Sun C diagnosed.
8693 * fns.c (secure_hash): Fix pointer signedness issue.
8694 * intervals.c (static_offset_intervals): New function.
8695 (offset_intervals): Use it.
8697 2011-06-21 Leo Liu <sdl.web@gmail.com>
8700 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8703 * fns.c (secure_hash): Rename from crypto_hash_function and change
8704 the first arg to accept symbols.
8705 (Fsecure_hash): New primitive.
8706 (syms_of_fns): New symbols.
8708 2011-06-20 Deniz Dogan <deniz@dogan.se>
8710 * process.c (Fset_process_buffer): Clarify return value in
8713 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
8715 * dispnew.c (add_window_display_history): Use BVAR.
8717 * xdisp.c (debug_method_add): Use BVAR.
8718 (check_window_end, dump_glyph_matrix, dump_glyph)
8719 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8721 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8724 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8725 check till after the cache is created in init_frame_faces.
8727 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8729 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8731 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8733 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8734 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8735 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8737 Improve buffer-overflow checking (Bug#8873).
8738 * fileio.c (Finsert_file_contents):
8739 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8740 Remove the old (too-loose) buffer overflow checks.
8741 They weren't needed, since make_gap checks for buffer overflow.
8742 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8743 The old code merely checked for Emacs fixnum overflow, and relied
8744 on undefined (wraparound) behavior. The new code avoids undefined
8745 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8747 * editfns.c (Finsert_char): Don't dump core with very negative counts.
8748 Tune. Don't use wider integers than needed. Don't use alloca.
8749 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
8751 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8753 * insdel.c, lisp.h (buffer_overflow): New function.
8754 (insert_from_buffer_1, replace_range, replace_range_2):
8755 * insdel.c (make_gap_larger):
8756 * editfns.c (Finsert_char):
8757 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8759 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8761 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8763 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
8765 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8766 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8768 * fileio.c: Don't assume EMACS_INT fits in off_t.
8769 (emacs_lseek): New static function.
8770 (Finsert_file_contents, Fwrite_region): Use it.
8771 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8773 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8775 * fns.c: Don't overflow int when computing a list length.
8776 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8777 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8778 truncation on 64-bit hosts. Check for QUIT every
8779 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8780 faster and is responsive enough.
8781 (Flength): Report an error instead of overflowing an integer.
8782 (Fsafe_length): Return a float if the value is not representable
8783 as a fixnum. This shouldn't happen except in contrived situations.
8784 (Fnthcdr, Fsort): Don't assume list length fits in int.
8785 (Fcopy_sequence): Don't assume vector length fits in int.
8787 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8788 (header_size, word_size): New constants.
8789 (allocate_vectorlike): Don't check size overflow here.
8790 (allocate_vector): Check it here instead, since this is the only
8791 caller of allocate_vectorlike that could cause overflow.
8792 Check that the new vector's length is representable as a fixnum.
8794 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8795 The previous code was bogus. For example, next_almost_prime (32)
8796 returned 39, which is undesirable as it is a multiple of 3; and
8797 next_almost_prime (24) returned 25, which is a multiple of 5 so
8798 why was the code bothering to check for multiples of 7?
8800 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8802 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8804 Variadic C functions now count arguments with ptrdiff_t.
8805 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8806 Back then I didn't know that the Emacs coding style prefers signed int.
8807 Also, in the meantime I found a few more instances where arguments
8808 were being counted with int, which may truncate counts on 64-bit
8809 machines, or EMACS_INT, which may be unnecessarily wide.
8810 * lisp.h (struct Lisp_Subr.function.aMANY)
8811 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8812 Arg counts are now ptrdiff_t, not size_t.
8813 All variadic functions and their callers changed accordingly.
8814 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8815 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8816 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8817 * callint.c (Fcall_interactively): Check arg count for overflow,
8818 to avoid potential buffer overrun. Use signed char, not 'int',
8819 for 'varies' array, so that we needn't bother to check its size
8820 calculation for overflow.
8821 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8822 * eval.c (apply_lambda):
8823 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8824 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8825 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8827 * callint.c (Fcall_interactively): Don't use index var as event count.
8829 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8830 * mem-limits.h (SIZE): Remove; no longer used.
8832 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
8834 Remove unnecessary casts.
8835 * xterm.c (x_term_init):
8836 * xfns.c (x_set_border_pixel):
8837 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8838 These aren't needed now that we assume ANSI C.
8840 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8841 It's more likely to cause problems (due to unsigned overflow)
8844 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8846 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8848 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8850 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8852 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8854 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8856 GLYPH_CODE_FACE returns EMACS_INT, not int.
8857 * dispextern.h (merge_faces):
8858 * xfaces.c (merge_faces):
8859 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8860 Don't assume EMACS_INT fits in int.
8862 * character.h (CHAR_VALID_P): Remove unused parameter.
8863 * fontset.c, lisp.h, xdisp.c: All uses changed.
8865 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8867 * fns.c (concat): Minor tuning based on overflow analysis.
8868 This doesn't fix any bugs. Use int to hold character, instead
8869 of constantly refetching from Emacs object. Use XFASTINT, not
8870 XINT, for value known to be a character. Don't bother comparing
8871 a single byte to 0400, as it's always less.
8873 * floatfns.c (Fexpt):
8874 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8876 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8879 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8881 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8882 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8883 incorrectly succeed when S was a string, because 4294967386 was
8884 truncated before it was used.
8886 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8887 Otherwise, an out-of-range integer could cause undefined behavior
8890 * composite.c: Use int, not EMACS_INT, for characters.
8891 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8892 EMACS_INT, for values that are known to be in character range.
8893 This doesn't fix any bugs but is the usual style inside Emacs and
8894 may generate better code on 32-bit machines.
8896 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8897 This is for reasons similar to the recent CHAR_STRING fix.
8898 * charset.c (Fencode_char): Check that character arg is actually
8899 a character. Pass an int to ENCODE_CHAR.
8900 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8901 wider than 'int', as a compile-time check to prevent future regressions
8904 * character.c (char_string): Remove unnecessary casts.
8906 Make sure a 64-bit char is never passed to CHAR_STRING.
8907 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8908 by silently ignoring the top 32 bits, allowing some values
8909 that were far too large to be valid characters.
8910 * character.h: Include <verify.h>.
8911 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8912 arguments are no wider than unsigned, as a compile-time check
8913 to prevent future regressions in this area.
8915 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8916 (Fsubst_char_in_region):
8918 * xdisp.c (decode_mode_spec_coding):
8919 Adjust to CHAR_STRING's new requirement.
8920 * editfns.c (Finsert_char, Fsubst_char_in_region):
8921 * fns.c (concat): Check that character args are actually
8922 characters. Without this test, these functions did the wrong
8923 thing with wildly out-of-range values on 64-bit hosts.
8925 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8926 These casts should not be needed on 32-bit hosts, either.
8927 * keyboard.c (read_char):
8928 * lread.c (Fload): Remove casts to unsigned.
8930 * lisp.h (UNSIGNED_CMP): New macro.
8931 This fixes comparison bugs on 64-bit hosts.
8932 (ASCII_CHAR_P): Use it.
8933 * casefiddle.c (casify_object):
8934 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8935 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8936 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8937 * dispextern.h (FACE_FROM_ID):
8938 * keyboard.c (read_char): Use UNSIGNED_CMP.
8940 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8941 not to EMACS_INT, to avoid GCC warning.
8943 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8945 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8946 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8947 isn't needed on 32-bit machines.
8949 * buffer.c (Fgenerate_new_buffer_name):
8950 Use EMACS_INT for count, not int.
8951 (advance_to_char_boundary): Return EMACS_INT, not int.
8953 * data.c (Qcompiled_function): Now static.
8955 * window.c (window_body_lines): Now static.
8957 * image.c (gif_load): Rename local to avoid shadowing.
8959 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8960 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8961 * alloc.c (make_save_value): Integer argument is now of type
8963 (mark_object): Use ptrdiff_t, not int.
8964 * lisp.h (pD): New macro.
8965 * print.c (print_object): Use it.
8967 * alloc.c: Use EMACS_INT, not int, to count objects.
8968 (total_conses, total_markers, total_symbols, total_vector_size)
8969 (total_free_conses, total_free_markers, total_free_symbols)
8970 (total_free_floats, total_floats, total_free_intervals)
8971 (total_intervals, total_strings, total_free_strings):
8972 Now EMACS_INT, not int. All uses changed.
8973 (Fgarbage_collect): Compute overall total using a double, so that
8974 integer overflow is less likely to be a problem. Check for overflow
8975 when converting back to an integer.
8976 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8977 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8978 These were 'int' variables that could overflow on 64-bit hosts;
8979 they were never used, so remove them instead of repairing them.
8980 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8981 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8982 Previously, this ceilinged at INT_MAX, but that doesn't work on
8984 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8986 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8987 (allocate_vectorlike): Check for ptrdiff_t overflow.
8988 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8989 when a (possibly-narrower) signed value would do just as well.
8990 We prefer using signed arithmetic, to avoid comparison confusion.
8992 * alloc.c: Catch some string size overflows that we were missing.
8993 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8994 for convenience in STRING_BYTES_MAX.
8995 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8996 The definition here is exact; the one in lisp.h was approximate.
8997 (allocate_string_data): Check for string overflow. This catches
8998 some instances we weren't catching before. Also, it catches
8999 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9000 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9001 and ptrdiff_t and EMACS_INT are both 64 bits.
9003 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9004 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
9005 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
9007 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9009 * alloc.c (Fmake_string): Check for out-of-range init.
9011 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9013 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9015 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9017 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9018 xg_get_default_scrollbar_width.
9020 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9021 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9022 (style_changed_cb): Call update_theme_scrollbar_width and call
9023 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9024 all frames (Bug#8505).
9025 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9026 Call gtk_window_set_resizable if HAVE_GTK3.
9027 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9028 and height if HAVE_GTK3 (Bug#8505).
9029 (scroll_bar_width_for_theme): New variable.
9030 (update_theme_scrollbar_width): New function.
9031 (xg_get_default_scrollbar_width): Move code to
9032 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9033 (xg_initialize): Call update_theme_scrollbar_width.
9035 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9037 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9039 2011-06-12 Martin Rudalics <rudalics@gmx.at>
9041 * frame.c (make_frame): Call other_buffer_safely instead of
9044 * window.c (temp_output_buffer_show): Call display_buffer with
9045 second argument Vtemp_buffer_show_specifiers and reset latter
9046 immediately after the call.
9047 (Vtemp_buffer_show_specifiers): New variable.
9048 (auto_window_vscroll_p, next_screen_context_lines)
9049 (Vscroll_preserve_screen_position): Remove leading asterisks from
9052 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
9054 Fix minor problems found by GCC 4.6.0 static checking.
9055 * buffer.c (Qclone_number): Remove for now, as it's unused.
9056 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9057 (record_buffer): Remove unused local.
9058 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9059 (set_frame_buffer_list): Remove; unused.
9060 * frame.h (other_visible_frames): Remove decl.
9061 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9062 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9063 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9065 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9066 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9067 Define only if HAVE_GPM.
9068 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9069 (update_hints_inhibit): Remove; never set. All uses removed.
9070 * widgetprv.h (emacsFrameClassRec): Remove decl.
9071 * window.c (delete_deletable_window): Now returns void, since it
9072 wasn't returning anything.
9073 (compare_window_configurations): Remove unused locals.
9074 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9075 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
9076 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9077 the same widths as pointers. This follows up on the 2011-05-06 patch.
9078 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9079 * xterm.h: Likewise.
9080 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9082 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
9084 * makefile.w32-in: Update dependencies.
9085 (LISP_H): Add lib/intprops.h.
9087 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9089 * image.c (gif_load): Add animation frame delay to the metadata.
9090 (syms_of_image): Use DEFSYM. New symbol `delay'.
9092 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9094 * window.c (delete_deletable_window): Re-add.
9095 (Fset_window_configuration): Rewrite to handle dead buffers and
9096 consequently deletable windows.
9097 (window_tree, Fwindow_tree): Remove. Supply functionality in
9099 (compare_window_configurations): Simplify code.
9101 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9103 * image.c (imagemagick_load_image): Fix type mismatch.
9104 (Fimagemagick_types): Likewise.
9106 * window.h (replace_buffer_in_windows): Declare.
9108 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9110 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9111 Qclone_number. Remove external declaration of Qdelete_window.
9112 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9114 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9115 Run Qbuffer_list_update_hook if allowed.
9116 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9117 buffer list implementation.
9118 (other_buffer_safely): New function.
9119 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9120 calls to replace_buffer_in_windows and
9121 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9123 (record_buffer): Inhibit quitting and rewrite using quittable
9124 functions. Run Qbuffer_list_update_hook if allowed.
9125 (Frecord_buffer, Funrecord_buffer): New functions.
9126 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9127 Move switch-to-buffer to window.el.
9128 (bury-buffer): Move to window.el.
9129 (Vbuffer_list_update_hook): New variable.
9131 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9134 * window.h (resize_frame_windows): Move up in code.
9135 (Fwindow_frame): Remove EXFUN.
9136 (replace_buffer_in_all_windows): Remove prototype.
9137 (replace_buffer_in_windows_safely): Add prototype.
9139 * window.c: Declare Qdelete_window static again. Move down
9140 declaration of select_count.
9141 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9142 (Fother_window): Move to window.el.
9143 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9144 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9145 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9147 (replace_buffer_in_windows): Implement by calling
9148 Qreplace_buffer_in_windows.
9149 (replace_buffer_in_all_windows): Remove with some functionality
9150 moved into replace_buffer_in_windows_safely.
9151 (replace_buffer_in_windows_safely): New function.
9152 (select_window_norecord, select_frame_norecord): Move in front
9153 of run_window_configuration_change_hook. Remove now obsolete
9155 (Fset_window_buffer): Rewrite doc-string.
9156 Call Qrecord_window_buffer.
9157 (keys_of_window): Move binding for other-window to window.el.
9159 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9161 * dispextern.h (struct image): Replace data member, whose int_val
9162 and ptr_val fields were not used by anything, with a single
9165 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9166 (gif_clear_image, gif_load, imagemagick_load_image)
9167 (gs_clear_image, gs_load): Callers changed.
9169 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9171 * buffer.h: Include <time.h>, for time_t.
9172 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9174 Fix minor problems found by static checking.
9176 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9178 Make identifiers static if they are not used in other modules.
9179 * data.c (Qcompiled_function, Qframe, Qvector):
9180 * image.c (QimageMagick, Qsvg):
9181 * minibuf.c (Qmetadata):
9182 * window.c (resize_window_check, resize_root_window): Now static.
9183 * window.h (resize_window_check, resize_root_window): Remove decls.
9185 * window.c (window_deletion_count, delete_deletable_window):
9187 (window_body_lines): Now static.
9188 (Fdelete_other_windows_internal): Mark vars as initialized.
9189 Make sure 'resize_failed' is initialized.
9190 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9191 (resize_window_apply): Remove unused local.
9192 * window.h (delete_deletable_window): Remove decl.
9194 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
9195 (imagemagick_load_image): Fix pointer signedness problem by changing
9196 last arg from unsigned char * to char *. All uses changed.
9197 Also, fix a local for similar reasons.
9198 Remove unused locals. Remove locals to avoid shadowing.
9199 (fn_rsvg_handle_free): Remove; unused.
9200 (svg_load, svg_load_image): Fix pointer signedness problem.
9201 (imagemagick_load_image): Don't use garbage pointer image_wand.
9203 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9205 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
9207 * image.c (gif_load): Fix omitted cast error introduced by
9210 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9212 * window.h (resize_proportionally, orig_total_lines)
9213 (orig_top_line): Remove from window structure.
9214 (set_window_height, set_window_width, change_window_heights)
9215 (Fdelete_window): Remove prototypes.
9216 (resize_frame_windows): Remove duplicate declaration.
9218 2011-06-10 Eli Zaretskii <eliz@gnu.org>
9220 * window.h (resize_frame_windows, resize_window_check)
9221 (delete_deletable_window, resize_root_window)
9222 (resize_frame_windows): Declare prototypes.
9224 * window.c (resize_window_apply): Make definition be "static" to
9225 match the prototype.
9227 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9229 * window.c: Remove declarations of Qwindow_size_fixed,
9230 window_min_size_1, window_min_size_2, window_min_size,
9231 size_window, window_fixed_size_p, enlarge_window, delete_window.
9232 Remove static from declaration of Qdelete_window, it's
9233 temporarily needed by Fbury_buffer.
9234 (replace_window): Don't assign orig_top_line and
9236 (Fdelete_window, delete_window): Remove. Window deletion is
9237 handled by window.el.
9238 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9239 Replace Fdelete_window calls with calls to Qdelete_window.
9240 (Fdelete_other_windows): Remove. Deleting other windows is
9241 handled by window.el.
9242 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9243 handled in window.el.
9244 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9245 Window minimum sizes are handled in window.el.
9246 (shrink_windows, size_window, set_window_height)
9247 (set_window_width, change_window_heights, window_height)
9248 (window_width, CURBEG, CURSIZE, enlarge_window)
9249 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9250 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9251 handled in window.el.
9252 (make_dummy_parent): Rename to make_parent_window and give it a
9253 second argument horflag.
9254 (make_window): Don't set resize_proportionally any more.
9255 (Fsplit_window): Remove. Windows are split in window.el.
9256 (save_restore_action, save_restore_orig_size)
9257 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9258 Resize mini windows in window.el.
9259 (grow_mini_window, shrink_mini_window): Implement by calling
9260 Qresize_root_window_vertically, resize_window_check and
9261 resize_window_apply.
9262 (saved_window, Fset_window_configuration, save_window_save):
9263 Do not handle orig_top_line, orig_total_lines, and
9264 resize_proportionally.
9265 (window_min_height, window_min_width): Move to window.el.
9266 (keys_of_window): Move bindings for delete-other-windows,
9267 split-window, delete-window and enlarge-window to window.el.
9269 * buffer.c: Temporarily extern Qdelete_window.
9270 (Fbury_buffer): Temporarily call Qdelete_window instead of
9271 Fdelete_window (Fbury_buffer will move to window.el soon).
9273 * frame.c (set_menu_bar_lines_1): Remove code handling
9274 orig_top_line and orig_total_lines.
9276 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9277 set_window_height but set heights directly.
9278 (change_frame_size_1): Use resize_frame_windows.
9280 * xdisp.c (init_xdisp): Don't use set_window_height but set
9283 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9284 Use resize_frame_windows instead of change_window_heights and run
9285 run_window_configuration_change_hook.
9287 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9288 instead of change_window_heights and run
9289 run_window_configuration_change_hook.
9291 2011-06-09 Martin Rudalics <rudalics@gmx.at>
9293 * window.c (replace_window): Rename second argument REPLACEMENT to
9294 NEW. New third argument SETFLAG. Rewrite.
9295 (delete_window, make_dummy_parent): Call replace_window with
9297 (window_list_1): Move down in code.
9298 (run_window_configuration_change_hook): Move set_buffer part
9299 before select_frame_norecord part in order to unwind correctly.
9300 Rename count1 to count.
9301 (recombine_windows, delete_deletable_window, resize_root_window)
9302 (Fdelete_other_windows_internal)
9303 (Frun_window_configuration_change_hook, make_parent_window)
9304 (resize_window_check, resize_window_apply, Fresize_window_apply)
9305 (resize_frame_windows, Fsplit_window_internal)
9306 (Fdelete_window_internal, Fresize_mini_window_internal):
9308 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9310 2011-06-08 Martin Rudalics <rudalics@gmx.at>
9312 * window.h (window): Add some new members to window structure -
9313 normal_lines, normal_cols, new_total, new_normal, clone_number,
9314 splits, nest, prev_buffers, next_buffers.
9315 (WINDOW_TOTAL_SIZE): Move here from window.c.
9316 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
9318 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9320 (make_dummy_parent): Set new members of windows structure.
9321 (make_window): Move down in code. Handle new members of window
9323 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9324 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9325 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9326 (Fset_window_prev_buffers, Fwindow_next_buffers)
9327 (Fset_window_next_buffers, Fset_window_clone_number):
9329 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9330 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9332 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9333 Argument WINDOW can be now internal window too.
9334 (Fwindow_use_time): Move up in code.
9335 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9337 (Fset_window_configuration, saved_window)
9338 (Fcurrent_window_configuration, save_window_save): Handle new
9339 members of window structure.
9340 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9341 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9342 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9343 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9344 Qget_mru_window, Qresize_root_window,
9345 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9346 Qauto_buffer_name; staticpro them.
9348 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9350 * window.c (Fwindow_total_size, Fwindow_left_column)
9351 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9352 (Fwindow_list_1): New functions.
9353 (window_box_text_cols): Replace with window_body_cols.
9354 (Fwindow_width, Fscroll_left, Fscroll_right):
9355 Use window_body_cols instead of window_box_text_cols.
9356 (delete_window, Fset_window_configuration):
9357 Call delete_all_subwindows with window as argument.
9358 (delete_all_subwindows): Take a window as argument and not a
9360 (window_loop): Remove handling of GET_LRU_WINDOW and
9362 (Fget_lru_window, Fget_largest_window): Move to window.el.
9364 * window.h: Extern window_body_cols instead of
9365 window_box_text_cols. delete_all_subwindows now takes a
9366 Lisp_Object as argument.
9368 * indent.c (compute_motion, Fcompute_motion):
9369 Use window_body_cols instead of window_box_text_cols.
9371 * frame.c (delete_frame): Call delete_all_subwindows with root
9374 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9376 * fns.c (Fputhash): Document return value.
9378 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9380 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9382 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9384 Cons<->int and similar integer overflow fixes (Bug#8794).
9386 Check for overflow when converting integer to cons and back.
9387 * charset.c (Fdefine_charset_internal, Fdecode_char):
9388 Use cons_to_unsigned to catch overflow.
9389 (Fencode_char): Use INTEGER_TO_CONS.
9390 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9391 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9392 * data.c (long_to_cons, cons_to_long): Remove.
9393 (cons_to_unsigned, cons_to_signed): New functions.
9394 These signal an error for invalid or out-of-range values.
9395 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9396 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9397 * font.c (Ffont_variation_glyphs):
9398 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9399 * lisp.h: Include <intprops.h>.
9400 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9401 (cons_to_signed, cons_to_unsigned): New decls.
9402 (long_to_cons, cons_to_long): Remove decls.
9403 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9404 (Fprimitive_undo): Use CONS_TO_INTEGER.
9405 * xfns.c (Fx_window_property): Likewise.
9406 * xselect.c: Include <limits.h>.
9407 (x_own_selection, selection_data_to_lisp_data):
9408 Use INTEGER_TO_CONS.
9409 (x_handle_selection_request, x_handle_selection_clear)
9410 (x_get_foreign_selection, Fx_disown_selection_internal)
9411 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9412 (lisp_data_to_selection_data): Use cons_to_unsigned.
9413 (x_fill_property_data): Use cons_to_signed.
9414 Report values out of range.
9416 Check for buffer and string overflow more precisely.
9417 * buffer.h (BUF_BYTES_MAX): New macro.
9418 * lisp.h (STRING_BYTES_MAX): New macro.
9419 * alloc.c (Fmake_string):
9420 * character.c (string_escape_byte8):
9421 * coding.c (coding_alloc_by_realloc):
9422 * doprnt.c (doprnt):
9423 * editfns.c (Fformat):
9425 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9426 since they may not be the same number.
9427 * editfns.c (Finsert_char):
9428 * fileio.c (Finsert_file_contents):
9429 Likewise for BUF_BYTES_MAX.
9431 * image.c: Use ptrdiff_t, not int, for sizes.
9432 (slurp_file): Switch from int to ptrdiff_t.
9434 (slurp_file): Check that file size fits in both size_t (for
9435 malloc) and ptrdiff_t (for sanity and safety).
9437 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9438 if b->modtime has its maximal value.
9440 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9442 Don't assume time_t can fit into int.
9443 * buffer.h (struct buffer.modtime): Now time_t, not int.
9444 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9445 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9447 Minor fixes for signed vs unsigned integers.
9448 * character.h (MAYBE_UNIFY_CHAR):
9449 * charset.c (maybe_unify_char):
9450 * keyboard.c (read_char, reorder_modifiers):
9451 XINT -> XFASTINT, since the integer must be nonnegative.
9452 * ftfont.c (ftfont_spec_pattern):
9453 * keymap.c (access_keymap, silly_event_symbol_error):
9454 XUINT -> XFASTINT, since the integer must be nonnegative.
9455 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9456 since it makes no difference and we prefer signed.
9457 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9458 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9461 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9463 * window.h (Fwindow_frame): Declare.
9465 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9467 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9468 (SPARE_MEMORY): Always define.
9469 (LARGE_REQUEST): Remove.
9470 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9472 2011-06-06 Martin Rudalics <rudalics@gmx.at>
9474 * lisp.h: Move EXFUNS for Fframe_root_window,
9475 Fframe_first_window and Fset_frame_selected_window to window.h.
9477 * window.h: Move EXFUNS for Fframe_root_window,
9478 Fframe_first_window and Fset_frame_selected_window here from
9481 * frame.c (Fwindow_frame, Fframe_first_window)
9482 (Fframe_root_window, Fframe_selected_window)
9483 (Fset_frame_selected_window): Move to window.c.
9484 (Factive_minibuffer_window): Move to minibuf.c.
9485 (Fother_visible_frames_p): New function.
9487 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9489 * window.c (decode_window, decode_any_window): Move up in code.
9490 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9491 (inhibit_frame_unsplittable): Remove unused variable.
9492 (Fwindow_buffer): Move up and rewrite doc-string.
9493 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9494 (Fwindow_prev): New functions.
9495 (Fwindow_frame): Move here from frame.c. Accept any window as
9497 (Fframe_root_window, Fframe_first_window)
9498 (Fframe_selected_window): Move here from frame.c. Accept frame
9499 or arbitrary window as argument. Update doc-strings.
9500 (Fminibuffer_window): Move up in code.
9501 (Fwindow_minibuffer_p): Move up in code and simplify.
9502 (Fset_frame_selected_window): Move here from frame.c.
9504 (Fselected_window, select_window, Fselect_window): Move up in
9505 code. Minor doc-string fixes.
9507 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9509 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9510 Do not assume that spare memory exists; that assumption is valid
9511 only if SYSTEM_MALLOC.
9512 (LARGE_REQUEST): New macro, so that the issue of large requests
9513 is separated from the issue of spare memory.
9515 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9517 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9520 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9522 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9525 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9527 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9529 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9531 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9532 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9534 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
9536 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9538 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
9540 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9541 (x_clipboard_manager_save): Add return value.
9542 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9544 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9545 Obey Vx_select_enable_clipboard_manager. Catch errors in
9546 x_clipboard_manager_save (Bug#8779).
9547 (Vx_select_enable_clipboard_manager): New variable.
9548 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
9550 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
9552 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9554 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9556 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9557 in the current matrix if keep_current_p is non-zero.
9559 2011-06-04 Eli Zaretskii <eliz@gnu.org>
9561 * bidi.c (bidi_level_of_next_char): Fix last change.
9563 2011-06-03 Eli Zaretskii <eliz@gnu.org>
9565 Support bidi reordering of text covered by display properties.
9567 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9568 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9569 (bidi_cache_search, bidi_cache_iterator_state)
9570 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
9571 (bidi_level_of_next_char, bidi_move_to_visually_next):
9572 Support character positions inside a run of characters covered by a
9574 (bidi_paragraph_init, bidi_resolve_explicit_1)
9575 (bidi_level_of_next_char): Call bidi_fetch_char and
9576 bidi_fetch_char_advance instead of FETCH_CHAR and
9578 (bidi_init_it): Initialize new members.
9579 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9581 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9582 instead of using explicit *_CHAR codes.
9583 (bidi_resolve_explicit, bidi_resolve_weak):
9584 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
9585 bidirectional text is supported only in multibyte buffers.
9586 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9587 it to initialize the frame_window_p member of struct bidi_it.
9588 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9589 (bidi_resolve_explicit, bidi_resolve_weak)
9590 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9591 bidi_it->nchars is non-positive.
9592 (bidi_level_of_next_char): Don't try to lookup the cache for the
9593 next/previous character if nothing is cached there yet, or if we
9594 were just reseat()'ed to a new position.
9596 * xdisp.c (set_cursor_from_row): Set start and stop points
9597 according to the row's direction when priming the loop that looks
9598 for the glyph on which to display cursor.
9599 (single_display_spec_intangible_p): Function deleted.
9600 (display_prop_intangible_p): Reimplement to call
9601 handle_display_spec instead of single_display_spec_intangible_p.
9602 Accept 3 additional arguments needed by handle_display_spec.
9603 This fixes incorrect cursor motion across display property with complex
9604 values: lists, `(when COND...)' forms, etc.
9605 (single_display_spec_string_p): Support property values that are
9606 lists with the argument STRING its top-level element.
9607 (display_prop_string_p): Fix the condition for processing a
9608 property that is a list to be consistent with handle_display_spec.
9609 (handle_display_spec): New function, refactored from the
9610 last portion of handle_display_prop.
9611 (compute_display_string_pos): Accept additional argument
9612 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9613 value of a `display' property is a "replacing spec".
9614 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9615 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9616 the display property, but just return a value indicating whether
9617 the display property will replace the characters it covers.
9618 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9619 frame_window_p members of struct bidi_it.
9620 (compute_display_string_pos, compute_display_string_end):
9622 (push_it): Accept second argument POSITION, where pop_it should
9623 jump to continue iteration.
9624 (reseat_1): Initialize bidi_it.disp_pos.
9626 * keyboard.c (adjust_point_for_property): Adjust the call to
9627 display_prop_intangible_p to its new signature.
9629 * dispextern.h (struct bidi_it): New member frame_window_p.
9630 (bidi_init_it): Update prototypes.
9631 (display_prop_intangible_p): Update prototype.
9632 (compute_display_string_pos, compute_display_string_end):
9634 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9637 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
9639 Malloc failure behavior now depends on size of allocation.
9640 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9641 * lisp.h: Change signatures accordingly.
9642 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9643 All callers changed. (Bug#8762)
9645 * gnutls.c: Use Emacs's memory allocators.
9646 Without this change, the gnutls library would invoke malloc etc.
9647 directly, which causes problems on non-SYNC_INPUT hosts, and which
9648 runs afoul of improving memory_full behavior. (Bug#8761)
9649 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9650 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9651 xfree instead of the default malloc, realloc, free.
9652 (Fgnutls_boot): No need to check for memory allocation failure,
9653 since xmalloc does that for us.
9655 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
9656 * category.c (hash_get_category_set):
9657 * ccl.c (ccl_driver):
9658 * charset.c (Fdefine_charset_internal):
9659 * charset.h (struct charset.hash_index):
9660 * composite.c (get_composition_id, gstring_lookup_cache)
9661 (composition_gstring_put_cache):
9662 * composite.h (struct composition.hash_index):
9663 * dispextern.h (struct image.hash):
9664 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9665 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9666 (hashfn_equal, hashfn_user_defined, make_hash_table)
9667 (maybe_resize_hash_table, hash_lookup, hash_put)
9668 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9669 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9670 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9671 * image.c (make_image, search_image_cache, lookup_image)
9672 (xpm_put_color_table_h):
9673 * lisp.h (struct Lisp_Hash_Table):
9674 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
9675 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
9676 for hashes and hash indexes, instead of 'unsigned' and 'int'.
9677 * alloc.c (allocate_vectorlike):
9678 Check for overflow in vector size calculations.
9679 * ccl.c (ccl_driver):
9680 Check for overflow when converting EMACS_INT to int.
9681 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9682 need to be updated by these changes.
9683 * fns.c (make_hash_table, maybe_resize_hash_table):
9684 Check for integer overflow with large hash tables.
9685 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9686 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9687 (SXHASH_REDUCE): New macro.
9688 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9689 Use it instead of discarding useful hash info with large hash values.
9690 (sxhash_float): New function.
9691 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9692 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
9693 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9694 Rewrite to use FIXNUM_BITS, as this simplifies things.
9695 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9696 Adjust signatures to match updated version of code.
9697 (consing_since_gc): Now EMACS_INT, since a single hash table can
9698 use more than INT_MAX bytes.
9700 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9702 Make it possible to build with GCC-4.6+ -O2 -flto.
9704 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9706 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9708 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9709 Call minibuffer-inactive-mode.
9711 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
9713 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9714 Update dependencies.
9716 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9718 * data.c (init_data): Remove code for UTS, this system is not
9721 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9723 Don't force ./temacs to start in terminal mode.
9725 * frame.c (make_initial_frame): Initialize faces in all cases, not
9726 only when CANNOT_DUMP is defined.
9727 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9729 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9731 * dispnew.c (add_window_display_history): Use const for the string
9732 pointer. Remove declaration, not needed.
9734 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9736 Use 'inline', not 'INLINE'.
9737 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
9738 * alloc.c, fontset.c (INLINE): Remove.
9739 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9740 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9741 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9742 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9743 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9745 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9747 Make it possible to run ./temacs.
9749 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9750 syms_of_callproc does the same thing. Remove test for
9751 "initialized", do it in the caller.
9752 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9754 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9756 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9757 (read_minibuf): Use get_minibuffer.
9758 (syms_of_minibuf): Use DEFSYM.
9759 (Qmetadata): New var.
9760 * data.c (Qbuffer): Don't make it static.
9761 (syms_of_data): Use DEFSYM.
9763 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9765 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9766 (CCL_CODE_MIN): New macro.
9768 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9770 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9772 * eval.c (Qdebug): Now static.
9773 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9774 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9775 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9777 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9779 * image.c: Various fixes to ImageMagick code comments.
9780 (Fimagemagick_types): Doc fix.
9782 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9784 Minor fixes prompted by GCC 4.6.0 warnings.
9786 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9788 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9789 (x_clipboard_manager_save_all): Move extern decl to ...
9790 * xterm.h: ... here, so that it can be checked for consistency.
9792 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9794 * xselect.c (x_clipboard_manager_save_frame)
9795 (x_clipboard_manager_save_all): New functions.
9796 (Fx_clipboard_manager_save): Lisp function deleted.
9798 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9799 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9801 * xterm.h: Update prototype.
9803 2011-05-28 William Xu <william.xwl@gmail.com>
9805 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9808 2011-05-28 Jim Meyering <meyering@redhat.com>
9810 Avoid a sign-extension bug in crypto_hash_function.
9811 * fns.c (to_uchar): Define.
9812 (crypto_hash_function): Use it to convert some newly-signed
9813 variables to unsigned, to avoid sign-extension bugs. For example,
9814 without this change, (md5 "truc") would evaluate to
9815 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9816 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
9817 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
9819 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9821 Integer overflow fixes.
9823 * dbusbind.c: Serial number integer overflow fixes.
9824 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
9825 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9826 to hold a serial number that is too large for a fixnum.
9827 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9828 Check for serial numbers out of range. Decode any serial number
9829 that was so large that it became a float. (Bug#8722)
9831 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9832 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9833 Use XFASTINT rather than XUINT when numbers are nonnegative.
9834 (xd_append_arg, Fdbus_method_return_internal):
9835 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9836 arguments, check that Lisp number is nonnegative, rather than
9837 silently wrapping negative numbers around. (Bug#8722)
9838 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
9841 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9843 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9845 ccl: Add integer overflow checks.
9846 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9847 (IN_INT_RANGE): New macros.
9848 (ccl_driver): Use them to check for integer overflow when
9849 decoding a CCL program. Many of the new checks are whether XINT (x)
9850 fits in int; it doesn't always, on 64-bit hosts. The new version
9851 doesn't catch all possible integer overflows, but it's an
9852 improvement. (Bug#8719)
9854 * alloc.c (make_event_array): Use XINT, not XUINT.
9855 There's no need for unsigned here.
9857 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9858 This follows up to the 2011-05-06 change that substituted uintptr_t
9859 for EMACS_INT. This case wasn't caught back then.
9861 Rework Fformat to avoid integer overflow issues.
9862 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9863 now (part of C89). Include <verify.h>.
9864 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9865 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9866 (Fformat): Avoid the prepass trying to compute sizes; it was only
9867 approximate and thus did not catch overflow reliably. Instead, walk
9868 through the format just once, formatting and computing sizes as we go,
9869 checking for integer overflow at every step, and allocating a larger
9870 buffer as needed. Keep track separately whether the format is
9871 multibyte. Keep only the most-recently calculated precision, rather
9872 than them all. Record whether each argument has been converted to
9873 string. Use EMACS_INT, not int, for byte and char and arg counts.
9874 Support field widths and precisions larger than INT_MAX. Avoid
9875 sprintf's undefined behavior with conversion specifications such as %#d
9876 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9877 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9878 formatting out-of-range floating point numbers with int
9881 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9883 * data.c: Avoid integer truncation in expressions involving floats.
9884 * data.c: Include <intprops.h>.
9885 (arith_driver): When there's an integer overflow in an expression
9886 involving floating point, convert the integers to floating point
9887 so that the resulting value does not suffer from catastrophic
9888 integer truncation. For example, on a 64-bit host (* 4
9889 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9890 Do not rely on undefined behavior after integer overflow.
9892 merge count_size_as_multibyte, parse_str_to_multibyte
9893 * character.c, character.h (count_size_as_multibyte):
9894 Rename from parse_str_to_multibyte; all uses changed.
9895 Check for integer overflow.
9896 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9897 since it's now a duplicate of the other. This is more of
9898 a character than a buffer op, so better that it's in character.c.
9899 * fns.c, print.c: Adjust to above changes.
9901 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9903 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9905 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9907 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9908 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9909 (x_clipboard_manager_save): Now static.
9910 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9912 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9913 (crypto_hash_function): Now static.
9914 Fix pointer signedness problems. Avoid unnecessary initializations.
9916 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9918 * termhooks.h (Vselection_alist): Make it terminal-local.
9920 * terminal.c (create_terminal): Initialize it.
9922 * xselect.c: Support for clipboard managers.
9923 (Vselection_alist): Move to termhooks.h as terminal-local var.
9924 (LOCAL_SELECTION): New macro.
9925 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9926 (symbol_to_x_atom): Remove gratuitous arg.
9927 (x_handle_selection_request, lisp_data_to_selection_data)
9928 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9929 (x_own_selection, x_get_local_selection, x_convert_selection):
9930 New arg, specifying work frame. Use terminal-local Vselection_alist.
9931 (some_frame_on_display): Delete unused function.
9932 (Fx_own_selection_internal, Fx_get_selection_internal)
9933 (Fx_disown_selection_internal, Fx_selection_owner_p)
9934 (Fx_selection_exists_p): New optional frame arg.
9935 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9936 (x_handle_selection_clear): Don't treat other terminals with the
9937 same keyboard specially. Use the terminal-local Vselection_alist.
9938 (x_clear_frame_selections): Use Frun_hook_with_args.
9940 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9942 * xterm.h: Add support for those atoms.
9944 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9946 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9947 (converted_selections, conversion_fail_tag): New global variables.
9948 (x_selection_request_lisp_error): Free the above.
9949 (x_get_local_selection): Remove unnecessary code.
9950 (x_reply_selection_request): Args changed; handle arbitrary array
9951 of converted selections stored in converted_selections.
9952 Separate the XChangeProperty and SelectionNotify steps.
9953 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9954 (x_convert_selection): New function.
9955 (x_handle_selection_event): Simplify.
9956 (x_get_foreign_selection): Don't ignore incoming requests while
9957 waiting for an answer; this will fail when we implement
9958 SAVE_TARGETS, and seems unnecessary anyway.
9959 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9960 (Vx_sent_selection_functions): Doc fix.
9962 2011-05-26 Leo Liu <sdl.web@gmail.com>
9964 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9966 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9968 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9970 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9971 for fringe update if it has periodic bitmap.
9972 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
9973 and fringe_bitmap_periodic_p.
9975 * fringe.c (get_fringe_bitmap_data): New function.
9976 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9977 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9978 row. Mark glyph row for fringe update if periodicity changed.
9980 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9981 for fringe update unless it has periodic bitmap.
9983 2011-05-25 Kenichi Handa <handa@m17n.org>
9985 * xdisp.c (get_next_display_element): Set correct it->face_id for
9986 a static composition.
9988 2011-05-24 Leo Liu <sdl.web@gmail.com>
9991 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9993 * fns.c (crypto_hash_function, Fsha1): New function.
9994 (Fmd5): Use crypto_hash_function.
9995 (syms_of_fns): Add Ssha1.
9997 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9999 * gnutls.c: Remove unused macros.
10000 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10001 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10002 Remove macros that are defined and never used.
10003 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10005 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10007 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10008 (Fx_get_selection_internal): Minor cleanup.
10009 (Fx_own_selection_internal): Rename arguments for consistency with
10012 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10014 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10016 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10018 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10020 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10022 * dispnew.c (scrolling_window): Don't exclude the case that the
10023 last enabled row in the desired matrix touches the bottom boundary.
10025 2011-05-21 Glenn Morris <rgm@gnu.org>
10027 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
10028 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10029 and add some more files.
10031 2011-05-20 Eli Zaretskii <eliz@gnu.org>
10033 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10034 report_file_error introduced by the change from 2011-05-07.
10036 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10038 * systime.h (Time): Define only if emacs is defined.
10039 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10040 where the include path doesn't have X11/X.h by default. See
10041 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10043 2011-05-20 Kenichi Handa <handa@m17n.org>
10045 * composite.c (find_automatic_composition): Fix previous change.
10047 2011-05-20 Glenn Morris <rgm@gnu.org>
10049 * lisp.mk: New file, split from Makefile.in.
10050 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10051 (shortlisp): Remove.
10052 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10054 2011-05-19 Glenn Morris <rgm@gnu.org>
10056 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10057 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10058 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10059 (lisp): Set the order to that of loadup.el.
10060 (shortlisp): Make it a copy of $lisp.
10061 (SOME_MACHINE_LISP): Remove.
10062 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10063 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10065 2011-05-18 Kenichi Handa <handa@m17n.org>
10067 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10068 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10069 (find_automatic_composition): Mostly rewrite for efficiency.
10071 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
10073 * makefile.w32-in: Update dependencies.
10075 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10077 * menu.c: Include limits.h (fixes the MS-Windows build broken by
10078 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
10080 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
10082 Fix some integer overflow issues, such as string length overflow.
10084 * insdel.c (count_size_as_multibyte): Check for string overflow.
10086 * character.c (lisp_string_width): Check for string overflow.
10087 Use EMACS_INT, not int, for string indexes and lengths; in
10088 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10089 the resulting string length overflows an EMACS_INT; instead,
10090 report a string overflow if no precision given. When checking for
10091 precision exhaustion, use a check that cannot possibly have
10092 integer overflow. (Bug#8675)
10093 * character.h (lisp_string_width): Adjust to new signature.
10095 * alloc.c (string_overflow): New function.
10096 (Fmake_string): Use it. This doesn't change behavior, but saves
10097 a few bytes and will simplify future changes.
10098 * character.c (string_escape_byte8): Likewise.
10099 * lisp.h (string_overflow): New decl.
10101 Fixups, following up to the user-interface timestamp change.
10102 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10103 for UI timestamps, instead of unsigned long.
10104 * msdos.c (mouse_get_pos): Likewise.
10105 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
10106 * w32gui.h (Time): Define by including "systime.h" rather than by
10107 declaring it ourselves. (Bug#8664)
10109 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10110 * image.c (clear_image_cache): Likewise.
10112 * term.c (term_mouse_position): Don't assume time_t wraparound.
10114 Be more systematic about user-interface timestamps.
10115 Before, the code sometimes used 'Time', sometimes 'unsigned long',
10116 and sometimes 'EMACS_UINT', to represent these timestamps.
10117 This change causes it to use 'Time' uniformly, as that's what X uses.
10118 This makes the code easier to follow, and makes it easier to catch
10119 integer overflow bugs such as Bug#8664.
10120 * frame.c (Fmouse_position, Fmouse_pixel_position):
10121 Use Time, not unsigned long, for user-interface timestamps.
10122 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10123 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10124 * keyboard.h (last_event_timestamp): Likewise.
10125 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10126 * menu.h (xmenu_show): Likewise.
10127 * term.c (term_mouse_position): Likewise.
10128 * termhooks.h (struct input_event.timestamp): Likewise.
10129 (struct terminal.mouse_position_hook): Likewise.
10130 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10131 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10132 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10133 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10134 what it was before.
10135 * menu.h, termhooks.h: Include "systime.h", for Time.
10137 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10138 Don't assume that the difference between two unsigned long values
10139 can fit into an integer. At this point, we know button_down_time
10140 <= event->timestamp, so the difference must be nonnegative, so
10141 there's no need to cast the result if double-click-time is
10142 nonnegative, as it should be; check that it's nonnegative, just in
10143 case. This bug is triggered when events are more than 2**31 ms
10144 apart (about 25 days). (Bug#8664)
10146 * xselect.c (last_event_timestamp): Remove duplicate decl.
10147 (x_own_selection): Remove needless cast to unsigned long.
10149 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10150 that always fit in int. Use a sentinel instead of a counter, to
10151 avoid a temp and to allay GCC's concerns about possible int overflow.
10152 * frame.h (struct frame): Use int for menu_bar_items_used
10153 instead of EMACS_INT, since it always fits in int.
10155 * menu.c (grow_menu_items): Check for int overflow.
10157 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10159 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10160 Before, the code was not consistent. These values cannot exceed
10161 2**31 - 1 so there's no need to make them unsigned.
10162 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10163 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10164 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10166 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10168 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10169 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10170 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10171 presumably because the widths might not match.
10173 * window.c (size_window): Avoid needless test at loop start.
10175 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10177 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10179 2011-05-12 Drew Adams <drew.adams@oracle.com>
10181 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10183 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10185 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10186 `width' to `bar_area_x' and `bar_area_width', respectively.
10187 (x_scroll_run): Take account of fringe background extension.
10189 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10190 Rename local vars `left' and `width' to `bar_area_x' and
10191 `bar_area_width', respectively.
10192 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10193 background extension.
10195 2011-05-10 Jim Meyering <meyering@redhat.com>
10197 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10199 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
10201 * image.c (Finit_image_library): Return t for built-in image types,
10202 like pbm and xbm. (Bug#8640)
10204 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10206 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10208 2011-05-07 Eli Zaretskii <eliz@gnu.org>
10210 * w32console.c (Fset_screen_color): Doc fix.
10211 (Fget_screen_color): New function.
10212 (syms_of_ntterm): Defsubr it.
10214 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10215 unlink the temporary file if Fcall_process didn't create it in the
10217 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10218 child process will be redirected to a file specified with `:file'.
10219 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10220 cue to call_process_cleanup not to close that handle.
10222 2011-05-07 Ben Key <bkey76@gmail.com>
10224 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10225 one of two shell specific rules, either bootstrap-temacs-CMD or
10226 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10227 to the previous implementation of the bootstrap-temacs rule.
10228 The bootstrap-temacs-CMD rule is similar to the previous
10229 implementation of the bootstrap-temacs rule except that it
10230 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10233 These changes, along with some changes to nt/configure.bat,
10234 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10235 earlier fix to add support for --cflags and --ldflags options
10236 that include quotes so that it works whether make uses cmd or
10239 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
10241 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10242 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10244 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10245 a string. Handle both cases.
10246 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10247 (Fdbus_register_method): Use Qinvalid_function.
10249 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10251 * makefile.w32-in: Update dependencies.
10252 (LISP_H): Add inttypes.h and stdin.h.
10253 (PROCESS_H): Add unistd.h.
10255 2011-05-06 Eli Zaretskii <eliz@gnu.org>
10257 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10258 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10260 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
10262 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10264 * term.c (vfatal): Remove stray call to va_end.
10265 It's not needed and the C Standard doesn't allow it here anyway.
10267 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10268 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10270 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10273 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10275 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10277 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10279 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10281 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10283 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10284 * charset.c (Fdefine_charset_internal): Don't initialize
10285 charset.code_space[15]. The value was garbage, on hosts with
10286 32-bit int (Bug#8600).
10288 * lread.c (read_integer): Be more consistent with string-to-number.
10289 Use string_to_number to do the actual conversion; this avoids
10290 rounding errors and fixes some other screwups. Without this fix,
10291 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10292 (digit_to_number): Move earlier, for benefit of read_integer.
10293 Return -1 if the digit is out of range for the base, -2 if it is
10294 not a digit in any supported base. (Bug#8602)
10296 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10298 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10299 to match comment at start of function. This also removes a
10300 GCC warning about overflow in a 32+64-bit port.
10302 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10304 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10305 Reported by Stefan Monnier in
10306 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
10307 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10308 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
10310 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10311 (EMACS_UINTPTR): Likewise, with uintptr_t.
10313 * lisp.h: Prefer 64-bit EMACS_INT if available.
10314 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10315 on 32-bit hosts that have 64-bit int, so that they can access
10317 However, temporarily disable this change unless the temporary
10318 symbol WIDE_EMACS_INT is defined.
10320 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10322 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10323 This removes an assumption that EMACS_INT and long are the same
10324 width as pointers. The assumption is true for Emacs porting targets
10325 now, but we want to make other targets possible.
10326 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10327 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10328 In the rest of the code, change types of integers that hold casted
10329 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10330 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10331 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10332 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10333 No need to cast type when ORing.
10334 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10335 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10336 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10337 assume EMACS_INT is the same width as char *.
10338 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10339 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10340 Remove no-longer-needed casts.
10341 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10342 (xg_tool_bar_help_callback, xg_make_tool_item):
10343 Use EMACS_INTPTR to hold an integer
10344 that will be cast to void *; this can avoid a GCC warning
10345 if EMACS_INT is not the same width as void *.
10346 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10347 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10348 (current_message_1, set_message_1):
10349 Use a local to convert to proper width without a cast.
10350 * xmenu.c (dialog_selection_callback): Likewise.
10352 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10353 Also, don't assume VALBITS / RAND_BITS is less than 5,
10354 and don't rely on undefined behavior when shifting a 1 left into
10356 * lisp.h (get_random): Change signature to match.
10358 * lread.c (hash_string): Use size_t, not int, for hash computation.
10359 Normally we prefer signed values; but hashing is special, because
10360 it's better to use unsigned division on hash table sizes so that
10361 the remainder is nonnegative. Also, size_t is the natural width
10362 for hashing into memory. The previous code used 'int', which doesn't
10363 retain enough info to hash well into very large tables.
10364 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10366 * dbusbind.c: Don't possibly lose pointer info when converting.
10367 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10368 Use XPNTR rather than XHASH, so that the high-order bits of
10369 the pointer aren't lost when converting through void *.
10371 * eval.c (Fautoload): Don't double-shift a pointer.
10373 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10375 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10377 * gnutls.c (DEF_GNUTLS_FN):
10378 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10380 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10382 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10385 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10387 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10388 New version that can reserve upto 2GB of heap space.
10390 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10392 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10394 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10396 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10397 `gnutls_certificate_set_x509_key_file'.
10399 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10401 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10402 Update dependencies.
10404 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10406 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10407 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10408 Remove unused parameter `fildes'.
10409 * process.c (read_process_output, send_process): Don't pass it.
10411 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10413 Fix previous change: the library cache is defined in w32.c.
10414 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10415 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10417 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10419 Implement dynamic loading of GnuTLS on Windows.
10421 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10422 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10423 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10426 * gnutls.c (Qgnutls_dll): Define.
10427 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10428 (gnutls_*): Declare function pointers.
10429 (init_gnutls_functions): New function to initialize function pointers.
10430 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10431 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10432 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10433 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10434 (emacs_gnutls_write, emacs_gnutls_read)
10435 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10436 (Fgnutls_available_p): New function.
10437 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10438 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10439 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10441 * image.c: Include w32.h.
10442 (Vimage_type_cache): Delete.
10443 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10444 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10445 (w32_delayed_load): Move to w32.c.
10447 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10449 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10450 (w32_delayed_load): Move from image.c. When loading a library, record
10451 its filename in the :loaded-from property of the library id.
10452 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10453 Initialize and staticpro them.
10454 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10456 * process.c: Include lisp.h before w32.h, not after.
10457 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10458 instead of gnutls_record_check_pending.
10460 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10462 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10464 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10465 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10468 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10470 * xterm.c (x_set_frame_alpha): Do not set property on anything
10471 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10473 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10475 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10477 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10479 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10480 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10481 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10482 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10483 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10484 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10485 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10486 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10487 (Qgnutls_bootprop_callbacks_verify): Make static.
10489 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10491 * callproc.c: Indentation fixup.
10493 * sysdep.c (wait_for_termination_1): Make static.
10494 (wait_for_termination, interruptible_wait_for_termination):
10495 Move after wait_for_termination_1.
10497 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10499 * sysdep.c (interruptible_wait_for_termination): New function
10500 which is like wait_for_termination, but allows keyboard
10503 * callproc.c (Fcall_process): Add (:file "file") as an option for
10505 (Fcall_process_region): Ditto.
10507 2011-04-30 Eli Zaretskii <eliz@gnu.org>
10509 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10510 rather than `XVECTOR (FOO)->size'.
10512 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10513 inttypes.h, as a gnulib replacement is used if it not available in
10516 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10518 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10519 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10520 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10522 * coding.c (coding_alloc_by_realloc): Error out if destination
10523 will grow beyond MOST_POSITIVE_FIXNUM.
10524 (decode_coding_emacs_mule): Abort if there isn't enough place in
10525 charbuf for the composition carryover bytes. Reserve an extra
10526 space for up to 2 characters produced in a loop.
10527 (decode_coding_iso_2022): Abort if there isn't enough place in
10528 charbuf for the composition carryover bytes.
10530 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10532 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10533 aborting when %lld or %lll format is passed.
10534 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10535 %llo or %llx format is passed. (Bug#8545)
10537 * window.c (window_scroll_line_based): Use a marker instead of
10538 simple variables to record original value of point. (Bug#7952)
10540 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10541 produced by %s or %c overflows available buffer space. (Bug#8545)
10543 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10545 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
10546 (SIZE_MAX): Move defn after all includes, as they might #define it.
10548 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10550 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10552 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10554 * keyboard.c (Qdelayed_warnings_hook): Define.
10555 (command_loop_1): Run `delayed-warnings-hook'
10556 if Vdelayed_warnings_list is non-nil.
10557 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10558 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10560 2011-04-28 Eli Zaretskii <eliz@gnu.org>
10562 * doprnt.c (doprnt): Don't return value smaller than the buffer
10563 size if the message was truncated. (Bug#8545).
10565 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10567 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10568 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10570 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10572 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10574 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
10576 * makefile.w32-in: Update dependencies.
10578 2011-04-27 Eli Zaretskii <eliz@gnu.org>
10580 Improve `doprnt' and its usage. (Bug#8545)
10581 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10582 `format_end'. Remove support for %l as a conversion specifier.
10583 Don't use xrealloc. Improve diagnostics when the %l size modifier
10584 is used. Update the commentary.
10586 * eval.c (verror): Simplify calculation of size_t.
10588 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10591 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10593 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10596 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10598 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10599 This makes this file independent of the recent pseudovector change.
10601 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
10603 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10605 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
10606 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
10607 Remove unused local.
10608 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
10610 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
10611 GCC 4.6.0 optimizes based on type-based alias analysis.
10612 For example, if b is of type struct buffer * and v of type struct
10613 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10614 != &v->size, and therefore "v->size = 1; b->size = 2; return
10615 v->size;" must therefore return 1. This assumption is incorrect
10616 for Emacs, since it type-puns struct Lisp_Vector * with many other
10617 types. To fix this problem, this patch adds a new type struct
10618 vectorlike_header that documents the constraints on layout of vectors
10619 and pseudovectors, and helps optimizing compilers not get fooled
10620 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10621 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
10622 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10624 (XSETPVECTYPE): Rewrite in terms of new macro.
10625 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10626 This is a bit clearer, and further avoids the possibility of
10627 undesirable aliasing.
10628 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
10629 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
10630 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10631 since Lisp_Subr is a special case (no "next" field).
10632 (ASIZE): Now uses header.size rather than size.
10633 All previous uses of XVECTOR (foo)->size replaced to use this macro,
10634 to avoid the hassle of writing XVECTOR (foo)->header.size.
10635 (struct vectorlike_header): New type.
10636 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10637 object, to help avoid aliasing.
10638 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10639 (SUBRP): Likewise, since Lisp_Subr is a special case.
10640 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10641 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10642 (struct Lisp_Hash_Table): Combine first two members into a single
10643 struct vectorlike_header member. All uses of "size" and "next" members
10644 changed to be "header.size" and "header.next".
10645 * buffer.h (struct buffer): Likewise.
10646 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10647 * frame.h (struct frame): Likewise.
10648 * process.h (struct Lisp_Process): Likewise.
10649 * termhooks.h (struct terminal): Likewise.
10650 * window.c (struct save_window_data, struct saved_window): Likewise.
10651 * window.h (struct window): Likewise.
10652 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10653 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10654 * buffer.c (init_buffer_once): Likewise.
10655 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10657 * process.c (Fformat_network_address): Use local var for size,
10660 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10662 Make the Lisp reader and string-to-float more consistent (Bug#8525)
10663 * data.c (atof): Remove decl; no longer used or needed.
10664 (digit_to_number): Move to lread.c.
10665 (Fstring_to_number): Use new string_to_number function, to be
10666 consistent with how the Lisp reader treats infinities and NaNs.
10667 Do not assume that floating-point numbers represent EMACS_INT
10668 without losing information; this is not true on most 64-bit hosts.
10669 Avoid double-rounding errors, by insisting on integers when
10670 parsing non-base-10 numbers, as the documentation specifies.
10671 * lisp.h (string_to_number): New decl, replacing ...
10672 (isfloat_string): Remove.
10673 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
10674 (read1): Do not accept +. and -. as integers; this
10675 appears to have been a coding error. Similarly, do not accept
10676 strings like +-1e0 as floating point numbers. Do not report
10677 overflow for integer overflows unless the base is not 10 which
10678 means we have no simple and reliable way to continue.
10679 Break out the floating-point parsing into a new
10680 function string_to_number, so that Fstring_to_number parses
10681 floating point numbers consistently with the Lisp reader.
10682 (digit_to_number): Move here from data.c. Make it static inline.
10683 (E_CHAR, EXP_INT): Remove, replacing with ...
10684 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10685 (string_to_number): New function, replacing isfloat_string.
10686 This function checks for valid syntax and produces the resulting
10687 Lisp float number too. Rework it so that string-to-number
10688 no longer mishandles examples like "1.0e+". Use strtoumax,
10689 so that overflow for non-base-10 numbers is reported only when
10690 there's no portable and simple way to convert to floating point.
10692 * textprop.c (set_text_properties_1): Rewrite for clarity,
10693 and to avoid GCC warning about integer overflow.
10695 * intervals.h (struct interval): Use EMACS_INT for members
10696 where EMACS_UINT might cause problems. See
10697 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10698 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10699 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10701 (offset_intervals): Tell GCC not to worry about length overflow
10702 when negating a negative length.
10704 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10705 (overrun_check_free): Likewise.
10707 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10708 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10711 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10712 (gnutls_make_error): Rename local to avoid shadowing.
10713 (gnutls_emacs_global_deinit): ifdef out; not used.
10714 (Fgnutls_boot): Use const for pointer to readonly storage.
10715 Comment out unused local. Fix pointer signedness problems.
10717 * lread.c (openp): Don't stuff size_t into an 'int'.
10718 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10719 about possible signed overflow.
10721 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10722 (GDK_KEY_g): Don't define if already defined.
10723 (xg_prepare_tooltip): Avoid pointer signedness problem.
10724 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10726 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10727 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10729 * xfns.c (Fx_window_property): Simplify a bit,
10730 to make a bit faster and to avoid GCC 4.6.0 warning.
10731 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10733 * fns.c (internal_equal): Don't assume size_t fits in int.
10735 * alloc.c (compact_small_strings): Tighten assertion a little.
10737 Replace pEd with more-general pI, and fix some printf arg casts.
10738 * lisp.h (pI): New macro, generalizing old pEd macro to other
10739 conversion specifiers. For example, use "...%"pI"d..." rather
10740 than "...%"pEd"...".
10741 (pEd): Remove. All uses replaced with similar uses of pI.
10742 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
10743 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10744 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10745 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10746 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10747 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10748 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10750 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10751 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10752 * print.c (safe_debug_print, print_object): Likewise.
10753 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10755 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10756 avoiding the 0 flag, which is not portable.
10757 * process.c (Fmake_network_process): Use pI to avoid cast.
10758 * region-cache.c (pp_cache): Likewise.
10759 * xdisp.c (decode_mode_spec): Likewise.
10760 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10761 behavior on 64-bit hosts with printf arg.
10762 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
10763 (x_stop_queuing_selection_requests): Likewise.
10764 (x_get_window_property): Don't truncate byte count to an 'int'
10767 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10768 here, since it parses constructs like leading '-' and spaces,
10769 which are not wanted; and it overflows with large numbers.
10770 Instead, simply match F[0-9]+, which is what is wanted anyway.
10772 * alloc.c: Remove unportable assumptions about struct layout.
10773 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10774 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10775 (allocate_vectorlike, make_pure_vector): Use the new macros,
10776 plus offsetof, to remove unportable assumptions about struct layout.
10777 These assumptions hold on all porting targets that I know of, but
10778 they are not guaranteed, they're easy to remove, and removing them
10779 makes further changes easier.
10781 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10782 This doesn't fix a bug but makes the code clearer.
10783 (string_overrun_cookie): Now const. Use initializers that
10784 don't formally overflow signed char, to avoid warnings.
10785 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10786 can cause Emacs to crash when string overrun checking is enabled.
10787 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10788 multiple of sizeof (EMACS_INT); it need not be, if
10789 alignof(EMACS_INT) < sizeof (EMACS_INT).
10790 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
10792 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
10794 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10796 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10798 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
10799 supposed to be handshaking. (Bug#8556)
10800 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10802 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
10804 * lisp.h (Qdebug): List symbol.
10805 * eval.c (Qdebug): Restore global linkage.
10806 * keyboard.c (debug-on-event): New variable.
10807 (handle_user_signal): Break into debugger when debug-on-event
10808 matches the current signal symbol.
10810 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10812 * alloc.c (check_sblock, check_string_bytes)
10813 (check_string_free_list): Convert to standard C.
10815 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10817 * w32.c (emacs_gnutls_push): Fix typo.
10819 2011-04-25 Eli Zaretskii <eliz@gnu.org>
10821 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10822 "cast to pointer from integer of different size".
10824 Improve doprnt and its use in verror. (Bug#8545)
10825 * doprnt.c (doprnt): Document the set of format control sequences
10826 supported by the function. Use SAFE_ALLOCA instead of always
10829 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10830 is one byte too soon. Don't use xrealloc; instead xfree and
10833 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10835 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10838 * gnutls.c: Renamed global_initialized to
10839 gnutls_global_initialized. Added internals for the
10840 :verify-hostname-error, :verify-error, and :verify-flags
10841 parameters of `gnutls-boot' and documented those parameters in the
10842 docstring. Start callback support.
10843 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10844 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10845 on error. Return error code.
10846 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10847 (emacs_gnutls_read): Likewise.
10848 (Fgnutls_boot): Return handshake error code.
10849 (emacs_gnutls_handle_error): New function.
10850 (wsaerror_to_errno): Likewise.
10852 * w32.h (emacs_gnutls_pull): Add prototype.
10853 (emacs_gnutls_push): Likewise.
10855 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10856 (emacs_gnutls_push): Likewise.
10858 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10860 * process.c (wait_reading_process_output): Check if GnuTLS
10861 buffered some data internally if no FDs are set for TLS
10864 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10865 (LIBS): Link to USER_LIBS.
10866 ($(BLD)/gnutls.$(0)): New target.
10868 2011-04-24 Eli Zaretskii <eliz@gnu.org>
10870 * xdisp.c (handle_single_display_spec): Rename the
10871 display_replaced_before_p argument into display_replaced_p, to
10872 make it consistent with the commentary. Fix typos in the
10875 * textprop.c (syms_of_textprop): Remove dead code.
10876 (copy_text_properties): Delete obsolete commentary about an
10877 interface that was deleted long ago. Fix typos in the description
10880 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10881 to changes in oldXMenu/XMenu.h from 2011-04-16.
10882 <menu_help_message, prev_menu_help_message>: Constify.
10883 (IT_menu_make_room): menu->help_text is now `const char **';
10886 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10887 to changes in oldXMenu/XMenu.h from 2011-04-16.
10888 (struct XMenu): Declare `help_text' `const char **'.
10890 * xfaces.c <Qunspecified>: Make extern again.
10892 * syntax.c: Include sys/types.h before including regex.h, as
10895 * doc.c (get_doc_string): Improve the format passed to `error'.
10897 * doprnt.c (doprnt): Improve commentary.
10899 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10901 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10904 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10905 changes in globals.h immediately force recompilation.
10906 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10907 $(CURDIR)/s/ms-w32.h.
10908 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10910 * character.c (Fchar_direction): Function deleted.
10911 (syms_of_character): Don't defsubr it.
10912 <char-direction-table>: Deleted.
10914 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10916 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10917 * doprnt.c: Include limits.h.
10918 (SIZE_MAX): New macro.
10919 (doprnt): Return a size_t value. 2nd arg is now size_t.
10920 Many local variables are now size_t instead of int or unsigned.
10921 Improve overflow protection. Support `l' modifier for integer
10922 conversions. Support %l conversion. Don't assume an EMACS_INT
10923 argument for integer conversions and for %c.
10925 * lisp.h (doprnt): Restore prototype.
10927 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10928 $(SRC)/character.h.
10930 * Makefile.in (base_obj): Add back doprnt.o.
10932 * deps.mk (doprnt.o): Add back prerequisites.
10933 (callint.o): Depend on character.h.
10935 * eval.c (internal_lisp_condition_case): Include the handler
10936 representation in the error message.
10937 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10938 when breaking from the loop.
10940 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10942 * callint.c (Fcall_interactively): When displaying error message
10943 about invalid control letter, pass the character's codepoint, not
10944 a pointer to its multibyte form. Improve display of the character
10945 in octal and display also its hex code.
10947 * character.c (char_string): Use %x to display the (unsigned)
10948 codepoint of an invalid character, to avoid displaying a bogus
10951 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10952 `error', not SYMBOL_NAME itself.
10954 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10955 character arguments to `error'.
10957 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10958 to `error' in error message about FINAL_CHAR argument. Make sure
10959 FINAL_CHAR is a character, and use %c when it is passed as
10960 argument to `error'.
10962 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10964 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10966 * w32.c: Include <time.h>.
10967 (sys_localtime): New function.
10969 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10971 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10973 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
10975 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
10977 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10978 zombies (Bug#8467).
10980 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10982 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10983 gl_state.e_property when gl_state.object is Qt.
10985 * insdel.c (make_gap_larger): Remove limitation of buffer size
10988 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10990 * xdisp.c (lookup_glyphless_char_display)
10991 (produce_glyphless_glyph): Handle cons cell entry in
10992 glyphless-char-display.
10993 (Vglyphless_char_display): Document it.
10995 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10996 glyphless-char-display.
10998 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
11000 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11002 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11004 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11005 definition for no-X builds.
11007 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
11009 Static checks with GCC 4.6.0 and non-default toolkits.
11011 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11013 * process.c (keyboard_bit_set): Define only if SIGIO.
11014 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11015 (send_process): Repair possible setjmp clobbering.
11017 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11019 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11021 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11023 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11024 Define only if needed.
11026 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11027 by pacifying GCC about it. Maybe it's time to retire it?
11028 * xfaces.c (USG, __TIMEVAL__): Likewise.
11030 * dispextern.h (struct redisplay_interface): Rename param
11031 to avoid shadowing.
11032 * termhooks.h (struct terminal): Likewise.
11033 * xterm.c (xembed_send_message): Likewise.
11035 * insdel.c (make_gap_smaller): Define only if
11036 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11038 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11041 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11042 so that we aren't warned about unused symbols.
11044 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11046 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
11048 * xfns.c (x_real_positions): Mark locals as initialized.
11050 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11052 * xterm.c: Fix problems found by static analysis with other toolkits.
11053 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
11054 (x_dispatch_event): Declare static if USE_GTK, and
11055 define if USE_GTK || USE_X_TOOLKIT.
11056 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
11057 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
11058 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11059 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
11061 * xmenu.c (menu_help_callback): Pointer type fixes.
11062 Use const pointers when pointing at readonly data. Avoid pointer
11063 signedness clashes.
11064 (FALSE): Remove unused macro.
11065 (update_frame_menubar): Remove unused decl.
11067 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11069 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11070 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11071 (single_menu_item): Rename local to avoid shadowing.
11073 * keyboard.c (make_lispy_event): Remove unused local var.
11075 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11076 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11078 * bitmaps: Change bitmaps from unsigned char back to the X11
11079 compatible char. Avoid the old compiler warnings about
11080 out-of-range initializers by using, for example, '\xab' rather
11083 * xgselect.c (xgselect_initialize): Check vs interface
11084 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11086 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11088 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11089 to read-only memory.
11091 * fns.c (vector): Remove; this old hack is no longer needed.
11093 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
11095 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
11097 * xrdb.c (x_load_resources): Omit unused local.
11099 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
11100 (x_window): Rename locals to avoid shadowing.
11101 (USG): Use the kludged USG macro, to pacify gcc.
11103 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
11104 (x_term_init): Remove local to avoid shadowing.
11106 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
11108 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11109 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11111 2011-04-16 Eli Zaretskii <eliz@gnu.org>
11113 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11115 Fix regex.c, syntax.c and friends for buffers > 2GB.
11116 * syntax.h (struct gl_state_s): Declare character position members
11119 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11121 * textprop.c (verify_interval_modification, interval_of):
11122 Declare arguments EMACS_INT.
11124 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11127 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11129 * indent.c (Fvertical_motion): Local variable it_start is now
11132 * regex.c (re_match, re_match_2, re_match_2_internal)
11133 (bcmp_translate, regcomp, regexec, print_double_string)
11134 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11135 (re_compile_pattern, re_exec): Declare arguments and local
11136 variables `size_t' and `ssize_t' and return values `regoff_t', as
11138 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11139 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11140 <compile_stack_type>: `size' and `avail' are now `size_t'.
11142 * regex.h <regoff_t>: Use ssize_t, not int.
11143 (re_search, re_search_2, re_match, re_match_2): Arguments that
11144 specify buffer/string position and length are now ssize_t and
11145 size_t. Return type is regoff_t.
11147 2011-04-16 Ben Key <bkey76@gmail.com>
11149 * nsfont.m: Fixed bugs in ns_get_family and
11150 ns_descriptor_to_entity that were caused by using free to
11151 deallocate memory blocks that were allocated by xmalloc (via
11152 xstrdup). This caused Emacs to crash when compiled with
11153 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11154 --enable-checking=xmallocoverrun). xfree is now used to
11155 deallocate these memory blocks.
11157 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
11159 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11161 emacs_write: Accept and return EMACS_INT for sizes.
11162 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11164 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11165 Accept and return EMACS_INT.
11166 (emacs_gnutls_write): Return the number of bytes written on
11168 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
11169 (emacs_read, emacs_write): Remove check for negative size, as the
11170 Emacs source code has been audited now.
11171 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11172 (emacs_read, emacs_write): Use it.
11173 * process.c (send_process): Adjust to the new signatures of
11174 emacs_write and emacs_gnutls_write. Do not attempt to store
11175 a byte offset into an 'int'; it might overflow.
11176 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
11178 * sound.c: Don't assume sizes fit in 'int'.
11179 (struct sound_device.period_size, alsa_period_size):
11180 Return EMACS_INT, not int.
11181 (struct sound_device.write, vox_write, alsa_write):
11182 Accept EMACS_INT, not int.
11183 (wav_play, au_play): Use EMACS_INT to store sizes and to
11184 record read return values.
11186 2011-04-15 Ben Key <bkey76@gmail.com>
11188 * keyboard.c (Qundefined): Don't declare static since it is used
11190 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11191 static since they are used in nsfont.m.
11193 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11195 * process.c (Qprocessp): Don't declare static.
11196 * lisp.h (Qprocessp): Declare again.
11198 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
11200 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11202 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11204 Improve C-level modularity by making more things 'static'.
11206 Don't publish debugger-only interfaces to other modules.
11207 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11208 (verify_bytepos, count_markers): Move decls to the only modules
11210 * region-cache.h (pp_cache): Likewise.
11211 * window.h (check_all_windows): Likewise.
11212 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11214 * sysdep.c (croak): Now static, if
11215 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11216 * syssignal.h (croak): Declare only if not static.
11218 * alloc.c (refill_memory_reserve): Now static if
11219 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11220 * lisp.h (refill_memory_reserve): Declare only if not static.
11222 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11223 Define only if USE_LUCID.
11225 * xrdb.c (x_customization_string, x_rm_string): Now static.
11227 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11228 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11230 * xdisp.c (draw_row_with_mouse_face): Now static.
11231 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11233 * window.h (check_all_windows): Mark externally visible.
11235 * window.c (window_deletion_count): Now static.
11237 * undo.c: Make symbols static if they're not exported.
11238 (last_undo_buffer, last_boundary_position, pending_boundary):
11241 * textprop.c (interval_insert_behind_hooks): Now static.
11242 (interval_insert_in_front_hooks): Likewise.
11244 * term.c: Make symbols static if they're not exported.
11245 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11246 (max_frame_lines, tty_set_terminal_modes):
11247 (tty_reset_terminal_modes, tty_turn_off_highlight):
11248 (get_tty_terminal): Now static.
11249 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11250 * termhooks.h (term_mouse_moveto): Do not declare if
11251 HAVE_WINDOW_SYSTEM.
11252 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11253 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11255 * sysdep.c: Make symbols static if they're not exported.
11256 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11258 (sigprocmask_set, full_mask): Remove; unused.
11259 (wait_debugging): Mark as visible.
11260 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11261 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11263 * syntax.c (syntax_temp): Define only if !__GNUC__.
11265 * sound.c (current_sound_device, current_sound): Now static.
11267 * search.c (searchbufs, searchbuf_head): Now static.
11269 * scroll.c (scroll_cost): Remove; unused.
11270 * dispextern.h (scroll_cost): Remove decl.
11272 * region-cache.h (pp_cache): Mark as externally visible.
11274 * process.c: Make symbols static if they're not exported.
11275 (process_tick, update_tick, create_process, chan_process):
11276 (Vprocess_alist, proc_buffered_char, datagram_access):
11277 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11278 (deactivate_process): Mark defn as static, as well as decl.
11279 * lisp.h (create_process): Remove decl.
11280 * process.h (chan_process, Vprocess_alist): Remove decls.
11282 * print.c: Make symbols static if they're not exported.
11283 (print_depth, new_backquote_output, being_printed, print_buffer):
11284 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11285 (print_interval, print_number_index, initial_stderr_stream):
11287 * lisp.h (Fprinc): Remove decl.
11288 (debug_output_compilation_hack): Mark as externally visible.
11290 * sysdep.c (croak): Move decl from here to syssignal.h.
11291 * syssignal.h (croak): Put it here, so the API can be checked when
11292 'croak' is called from dissociate_if_controlling_tty.
11294 * minibuf.c: Make symbols static if they're not exported.
11295 (minibuf_save_list, choose_minibuf_frame): Now static.
11296 * lisp.h (choose_minibuf_frame): Remove decl.
11298 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11300 * lread.c: Make symbols static if they're not exported.
11301 (read_objects, initial_obarray, oblookup_last_bucket_number):
11303 (make_symbol): Remove; unused.
11304 * lisp.h (initial_obarray, make_symbol): Remove decls.
11306 * keyboard.c: Make symbols static if they're not exported.
11307 (single_kboard, recent_keys_index, total_keys, recent_keys):
11308 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11309 (this_single_command_key_start, echoing, last_auto_save):
11310 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11311 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11312 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11313 (Vlispy_mouse_stem, double_click_count):
11315 (force_auto_save_soon): Define only if SIGDANGER.
11316 (ignore_mouse_drag_p): Now static if
11317 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11318 (print_help): Remove; unused.
11319 (stop_character, last_timer_event): Mark as externally visible.
11320 * keyboard.h (ignore_mouse_drag_p): Declare only if
11321 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11322 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11323 * lisp.h (echoing): Remove decl.
11324 (force_auto_save_soon): Declare only if SIGDANGER.
11325 * xdisp.c (redisplay_window): Simplify code, to make it more
11326 obvious that ignore_mouse_drag_p is not accessed if !defined
11327 USE_GTK && !defined HAVE_NS.
11329 * intervals.c: Make symbols static if they're not exported.
11330 (merge_properties_sticky, merge_interval_right, delete_interval):
11332 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11334 * insdel.c: Make symbols static if they're not exported.
11335 However, leave prepare_to_modify_buffer alone. It's never
11336 called from outside this function, but that appears to be a bug.
11337 (combine_after_change_list, combine_after_change_buffer):
11338 (adjust_after_replace, signal_before_change): Now static.
11339 (adjust_after_replace_noundo): Remove; unused.
11340 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11341 (signal_before_change): Remove decls.
11343 * indent.c (val_compute_motion, val_vmotion): Now static.
11345 * image.c: Make symbols static if they're not exported.
11346 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11348 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11349 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11351 * fringe.c (standard_bitmaps): Now static.
11352 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11354 * frame.c: Make symbols static if they're not exported.
11355 (x_report_frame_params, make_terminal_frame): Now static.
11356 (get_frame_param): Now static, unless HAVE_NS.
11357 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11358 (x_get_resource_string): Remove; not used.
11359 * frame.h (make_terminal_frame, x_report_frame_params):
11360 (x_get_resource_string); Remove decls.
11361 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11362 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11364 * font.c, fontset.c: Make symbols static if they're not exported.
11365 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11366 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11367 * font.c (font_close_object): Now static.
11368 * font.h (font_close_object): Remove.
11369 * fontset.c (FONTSET_OBJLIST): Remove.
11370 (free_realized_fontset) #if-0 the body, which does nothing.
11371 (face_suitable_for_char_p): #if-0, as it's never called.
11372 * fontset.h (face_suitable_for_char_p): Remove decl.
11373 * xfaces.c (face_at_string_position):
11374 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11375 since 0 is always ASCII.
11377 * fns.c (weak_hash_tables): Now static.
11379 * fileio.c: Make symbols static if they're not exported.
11380 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11381 (Vwrite_region_annotation_buffers): Now static.
11383 * eval.c: Make symbols static if they're not exported.
11384 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11385 * lisp.h (backtrace_list): Remove decl.
11387 * emacs.c: Make symbols static if they're not exported.
11388 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11389 (fatal_error_code, fatal_error_signal_hook, standard_args):
11391 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11392 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11393 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11394 * lisp.h (fatal_error_signal_hook): Remove decl.
11395 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11397 * editfns.c: Move a (normally-unused) function to its only use.
11398 * editfns.c, lisp.h (get_operating_system_release): Remove.
11399 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11400 worth the hassle of breaking this out.
11402 * xterm.c: Make symbols static if they're not exported.
11403 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11404 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11405 (x_destroy_window, x_delete_display):
11407 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11408 (x_mouse_leave): Remove; unused.
11409 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11410 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11411 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11413 (x_mouse_leave): Declare only if WINDOWSNT.
11414 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11415 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11418 * ftxfont.c: Make symbols static if they're not exported.
11419 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11421 * font.h (ftxfont_driver): Likewise.
11423 * xfns.c: Make symbols static if they're not exported.
11424 (x_last_font_name, x_display_info_for_name):
11425 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11426 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11427 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11428 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11429 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11430 (last_show_tip_args): Now static.
11431 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11432 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11433 (x_screen_planes): Remove; unused.
11434 * dispextern.h (x_screen_planes): Remove decl.
11436 * dispnew.c: Make symbols static if they're not exported.
11437 * dispextern.h (redraw_garbaged_frames, scrolling):
11438 (increment_row_positions): Remove.
11439 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11440 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11442 (redraw_garbaged_frames): Remove; unused.
11444 * xfaces.c: Make symbols static if they're not exported.
11445 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11447 * xterm.h (defined_color): Remove decls.
11448 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11449 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11450 (menu_face_changed_default, defined_color, free_realized_face):
11451 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11452 (ascii_face_of_lisp_face): Remove; unused.
11454 * xdisp.c: Make symbols static if they're not exported.
11455 * dispextern.h (scratch_glyph_row, window_box_edges):
11456 (glyph_to_pixel_coords, set_cursor_from_row):
11457 (get_next_display_element, set_iterator_to_next):
11458 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11459 (show_mouse_face): Remove decls
11460 * frame.h (message_buf_print): Likewise.
11461 * lisp.h (pop_message, set_message, check_point_in_composition):
11463 * xterm.h (set_vertical_scroll_bar): Likewise.
11464 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11465 (message_buf_print, scratch_glyph_row, displayed_buffer):
11466 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11467 (get_next_display_element, show_mouse_face, window_box_edges):
11468 (frame_to_window_pixel_xy, check_point_in_composition):
11469 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11470 (glyph_to_pixel_coords): Remove; unused.
11472 * dired.c (file_name_completion): Now static.
11474 * dbusbind.c (xd_in_read_queued_messages): Now static.
11476 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11477 * data.c (circular_list_error): Remove.
11479 * commands.h (last_point_position, last_point_position_buffer):
11480 (last_point_position_window): Remove decls.
11481 * keyboard.c: Make these variables static.
11483 * coding.h (coding, code_convert_region, encode_coding_gap):
11485 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11486 (iso_code_class, detect_coding, code_convert_region): Now static.
11487 (encode_coding_gap): Remove; unused.
11489 * chartab.c (chartab_chars, chartab_bits): Now static.
11491 * charset.h (charset_iso_8859_1): Remove decl.
11492 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11495 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11496 * ccl.c (Vccl_program_table): Now static.
11497 (check_ccl_update): Remove; unused.
11499 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11500 * category.h: ... from here.
11501 * category.c (check_category_table, set_category_set): Now static.
11503 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11504 * lisp.h: Remove these decls.
11506 * buffer.c (buffer_count): Remove unused var.
11508 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11509 so that it's not optimized away.
11510 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11511 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11512 exported only to the debugger.
11514 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
11515 * atimer.h (run_all_atimers): Remove; not exported.
11517 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11518 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11519 was inaccessible from Lisp.
11520 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11521 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11523 alloc.c: Import and export fewer symbols, and remove unused items.
11524 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11526 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11527 it's not optimized away by whole-program optimization.
11528 (message_enable_multibyte, free_misc): Remove.
11529 (catchlist, handlerlist, mark_backtrace):
11530 Declare only if BYTE_MARK_STACK.
11531 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11532 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11533 (message_enable_multibyte): Remove decl.
11534 (free_misc, interval_free_list, float_block, float_block_index):
11535 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11536 (cons_free_list, last_marked_index):
11538 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11539 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11540 (mark_backtrace): Define only if BYTE_MARK_STACK.
11541 * xdisp.c (message_enable_multibyte): Now static.
11543 Declare Lisp_Object Q* variables to be 'static' if not exported.
11544 This makes it easier for human readers (and static analyzers)
11545 to see whether these variables are used from other modules.
11546 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11547 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11548 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11549 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11550 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11551 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11552 * xmenu.c, xselect.c:
11553 Declare Q* vars static if they are not used in other modules.
11554 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11555 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11556 Remove decls of unexported vars.
11557 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11559 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11561 Make Emacs functions such as Fatom 'static' by default.
11562 This makes it easier for human readers (and static analyzers)
11563 to see whether these functions can be called from other modules.
11564 DEFUN now defines a static function. To make the function external
11565 so that it can be used in other C modules, use the new macro DEFUE.
11566 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11567 (Finit_image_library):
11568 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11569 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11570 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11571 Remove decls, since these functions are now static.
11572 (Funintern, Fget_internal_run_time): New decls, since these functions
11573 were already external.
11575 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11576 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11577 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11578 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11579 * keyboard.c, keymap.c, lread.c:
11580 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11581 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11582 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11583 Mark functions with DEFUE instead of DEFUN,
11584 if they are used in other modules.
11585 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11586 decls for now-static functions.
11587 * buffer.h (Fdelete_overlay): Remove decl.
11588 * callproc.c (Fgetenv_internal): Mark as internal.
11589 * composite.c (Fremove_list_of_text_properties): Remove decl.
11590 (Fcomposition_get_gstring): New forward static decl.
11591 * composite.h (Fcomposite_get_gstring): Remove decl.
11592 * dired.c (Ffile_attributes): New forward static decl.
11593 * doc.c (Fdocumntation_property): New forward static decl.
11594 * eval.c (Ffetch_bytecode): New forward static decl.
11595 (Funintern): Remove extern decl; now in .h file where it belongs.
11596 * fileio.c (Fmake_symbolic_link): New forward static decl.
11597 * image.c (Finit_image_library): New forward static decl.
11598 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11599 * intervals.h (Fprevious_property_change):
11600 (Fremove_list_of_text_properties): Remove decls.
11601 * keyboard.c (Fthis_command_keys): Remove decl.
11602 (Fcommand_execute): New forward static decl.
11603 * keymap.c (Flookup_key): New forward static decl.
11604 (Fcopy_keymap): Now static.
11605 * keymap.h (Flookup_key): Remove decl.
11606 * process.c (Fget_process): New forward static decl.
11607 (Fprocess_datagram_address): Mark as internal.
11608 * syntax.c (Fsyntax_table_p): New forward static decl.
11609 (skip_chars): Remove duplicate decl.
11610 * textprop.c (Fprevious_property_change): New forward static decl.
11611 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11613 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11614 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11616 * editfns.c (Fformat): Remove unreachable code.
11618 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11620 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11623 2011-04-13 Eli Zaretskii <eliz@gnu.org>
11625 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11626 when at ZV. (Bug#8487)
11628 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11630 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11632 * keyboard.c (parse_tool_bar_item): Likewise.
11633 * sound.c (sound_cleanup, alsa_close): Likewise.
11634 * termcap.c (tgetent): Likewise.
11635 * xfns.c (x_default_font_parameter): Likewise.
11636 * xsettings.c (read_and_apply_settings): Likewise.
11638 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11639 (overrun_check_free): Protoize.
11641 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11643 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11644 since callers should never pass a negative size.
11645 Change the signature to match that of plain 'read' and 'write'; see
11646 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11647 * lisp.h: Update prototypes of emacs_write and emacs_read.
11649 2011-04-11 Eli Zaretskii <eliz@gnu.org>
11651 * xdisp.c (redisplay_window): Don't try to determine the character
11652 position of the scroll margin if the window start point w->startp
11653 is outside the buffer's accessible region. (Bug#8468)
11655 2011-04-10 Eli Zaretskii <eliz@gnu.org>
11657 Fix write-region and its subroutines for buffers > 2GB.
11658 * fileio.c (a_write, e_write): Modify declaration of arguments and
11659 local variables to support buffers larger than 2GB.
11660 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11662 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11663 argument, local variables, and return value.
11665 * lisp.h: Update prototypes of emacs_write and emacs_read.
11667 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11669 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
11671 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11673 Fix more problems found by GCC 4.6.0's static checks.
11675 * xdisp.c (vmessage): Use a better test for character truncation.
11677 * charset.c (load_charset_map): <, not <=, for optimization,
11678 and to avoid potential problems with integer overflow.
11679 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
11680 * casetab.c (set_identity, shuffle): Likewise.
11681 * editfns.c (Fformat): Likewise.
11682 * syntax.c (skip_chars): Likewise.
11684 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11685 This also lets GCC 4.6.0 generate slightly better loop code.
11687 * callint.c (Fcall_interactively): <, not <=, for optimization.
11688 (Fcall_interactively): Count the number of arguments produced,
11689 not the number of arguments given. This is simpler and lets GCC
11690 4.6.0 generate slightly better code.
11692 * ftfont.c: Distingish more carefully between FcChar8 and char.
11693 The previous code passed unsigned char * to a functions like
11694 strlen and xstrcasecmp that expect char *, which does not
11695 conform to the C standard.
11696 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11697 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11698 char * when the C standard requires it.
11700 * keyboard.c (read_char): Remove unused var.
11702 * eval.c: Port to Windows vsnprintf (Bug#8435).
11703 Include <limits.h>.
11704 (SIZE_MAX): Define if the headers do not.
11705 (verror): Do not give up if vsnprintf returns a negative count.
11706 Instead, grow the buffer. This ports to Windows vsnprintf, which
11707 does not conform to C99. Problem reported by Eli Zaretskii.
11708 Also, simplify the allocation scheme, by avoiding the need for
11709 calling realloc, and removing the ALLOCATED variable.
11711 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11713 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11714 But keep the doprint source code for now, as we might revamp it
11715 and use it again (Bug#8435).
11716 * lisp.h (doprnt): Remove.
11717 * Makefile.in (base_obj): Remove doprnt.o.
11718 * deps.mk (doprnt.o): Remove.
11720 error: Print 32- and 64-bit integers portably (Bug#8435).
11721 Without this change, on typical 64-bit hosts error ("...%d...", N)
11722 was used to print both 32- and 64-bit integers N, which relied on
11723 undefined behavior.
11724 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
11725 * lisp.h (error, verror): Mark as printf-like functions.
11726 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11727 Report overflow in size calculations when allocating printf buffer.
11728 Do not truncate output string at its first null byte.
11729 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11730 Truncate the output at a character boundary, since vsnprintf does not
11732 * charset.c (check_iso_charset_parameter): Convert internal
11733 character to string before calling 'error', since %c now has the
11735 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11736 overflow when computing char to be passed to 'error'. Do not
11737 pass Lisp_Object to 'error'; pass the integer instead.
11738 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11739 formatted with plain %d.
11741 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11743 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11745 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11747 * xterm.c (x_catch_errors): Remove duplicate declaration.
11749 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11751 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11753 2011-04-10 Jim Meyering <meyering@redhat.com>
11755 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11756 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11757 return ssize_t not "int", and use size_t as the buffer length.
11758 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11759 * gnutls.h: Update declarations.
11760 * process.c (read_process_output): Use ssize_t, to match.
11761 (send_process): Likewise.
11763 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11765 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11767 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11769 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11770 Use unsigned char, to match FcChar8 type definition.
11772 * xterm.c (handle_one_xevent):
11773 * xmenu.c (create_and_show_popup_menu):
11774 * xselect.c (x_decline_selection_request)
11775 (x_reply_selection_request): Avoid type-punned deref of X events.
11777 2011-04-09 Eli Zaretskii <eliz@gnu.org>
11779 Fix some uses of `int' instead of EMACS_INT.
11780 * search.c (string_match_1, fast_string_match)
11781 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11782 (scan_buffer, find_next_newline_no_quit)
11783 (find_before_next_newline, search_command, Freplace_match)
11784 (Fmatch_data): Make some `int' variables be EMACS_INT.
11786 * xdisp.c (display_count_lines): 3rd argument and return value now
11787 EMACS_INT. All callers changed.
11788 (pint2hrstr): Last argument is now EMACS_INT.
11790 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11791 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11792 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11793 (decode_coding_utf_16, decode_coding_emacs_mule)
11794 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11795 (decode_coding_ccl, decode_coding_charset)
11796 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11797 (decode_coding_iso_2022, decode_coding_emacs_mule)
11798 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11799 <char_offset, last_offset>: Declare EMACS_INT.
11800 (encode_coding_utf_8, encode_coding_utf_16)
11801 (encode_coding_emacs_mule, encode_invocation_designation)
11802 (encode_designation_at_bol, encode_coding_iso_2022)
11803 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11804 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11806 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11807 (encode_invocation_designation): Last argument P_NCHARS is now
11809 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11810 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11812 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11815 * ccl.c (Fccl_execute_on_string): Declare some variables
11818 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
11820 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11822 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11824 * process.c (Fformat_network_address): Doc fix.
11826 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11828 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
11830 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
11832 * keyboard.c (read_char): Call Lisp function help-form-show,
11833 instead of using internal_with_output_to_temp_buffer.
11834 (Qhelp_form_show): New var.
11835 (syms_of_keyboard): Use DEFSYM macro.
11837 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11839 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11841 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
11843 * process.c (Flist_processes): Remove to Lisp.
11844 (list_processes_1): Delete.
11846 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11848 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11850 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11852 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
11854 Fix more problems found by GCC 4.6.0's static checks.
11856 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11858 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11860 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
11862 * xdisp.c (vmessage): Mark as a printf-like function.
11864 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11866 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11868 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11869 printf-like functions.
11870 (tiff_load): Add casts to remove these marks before passing them
11871 to system-supplied API.
11873 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11875 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11876 This avoids several warnings with gcc -Wstrict-overflow.
11877 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11878 directly, rather than having caller test rule sign. This avoids
11879 some unnecessary tests.
11880 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11881 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11882 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11884 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11885 (xfont_open): Avoid unnecessary tests.
11887 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11889 * composite.h, composite.c (composition_gstring_put_cache):
11890 Use EMACS_INT, not int, for length.
11892 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11893 breaking out part of COMPOSITION_DECODE_RULE.
11894 (COMPOSITION_DECODE_RULE): Use it.
11895 * composite.c (get_composition_id): Remove unused local vars,
11896 by using the new macro.
11898 * textprop.c (set_text_properties_1): Change while to do-while,
11899 since the condition is always true at first.
11901 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11902 (interval_deletion_adjustment): Return unsigned value.
11905 * process.c (list_processes_1, create_pty, read_process_output):
11906 (exec_sentinel): Remove vars that were set but not used.
11907 (create_pty): Remove unnecessary "volatile"s.
11908 (Fnetwork_interface_info): Avoid possibility of int overflow.
11909 (read_process_output): Do adaptive read buffering even if carryover.
11910 (read_process_output): Simplify nbytes computation if buffered.
11912 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11914 * syntax.c (scan_words): Remove var that was set but not used.
11915 (update_syntax_table): Use unsigned instead of int.
11917 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11918 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11919 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11921 * print.c (print_error_message): Avoid int overflow.
11923 * font.c (font_list_entities): Redo for clarity,
11924 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11926 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11927 (font_score): Avoid potential overflow in diff calculation.
11929 * fns.c (substring_both): Remove var that is set but not used.
11930 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11932 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11934 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11935 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11936 can always succeed if overflow has undefined behavior.
11938 * search.c (boyer_moore, wordify): Remove vars set but not used.
11939 (wordify): Omit three unnecessary tests.
11941 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11942 All callers changed. This avoids the need for an unused var.
11944 * casefiddle.c (casify_region): Remove var that is set but not used.
11946 * dired.c (file_name_completion): Remove var that is set but not used.
11948 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11950 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11951 (Finsert_file_contents): Remove unnecessary code checking fd.
11953 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11954 Check for integer overflow on size calculations.
11956 * buffer.c (Fprevious_overlay_change): Remove var that is set
11959 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11960 Remove vars that are set but not used.
11961 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11962 (timer_check_2): Mark vars as initialized.
11964 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11966 * image.c (lookup_image): Remove var that is set but not used.
11967 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11969 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11970 that are set but not used.
11972 * xfns.c (make_invisible_cursor): Don't return garbage
11973 if XCreateBitmapFromData fails (Bug#8410).
11975 * xselect.c (x_get_local_selection, x_handle_property_notify):
11976 Remove vars that are set but not used.
11978 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11979 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11981 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11982 Remove var that is set but not used.
11983 (scroll_bar_windows_size): Now size_t, not int.
11984 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11985 Check for overflow.
11987 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11988 (map_tty_color) [!defined MSDOS]: Likewise.
11990 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11992 * coding.c: Remove vars that are set but not used.
11993 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11994 All callers changed.
11995 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11996 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11997 (decode_coding_charset): Remove vars that are set but not used.
11999 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12000 that is set but not used.
12002 * print.c (print_object): Remove var that is set but not used.
12004 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
12005 The gnulib version avoids calling malloc in the usual case,
12006 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12007 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12008 * filelock.c (current_lock_owner): Likewise.
12009 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12010 * sysdep.c: Include allocator.h, careadlinkat.h.
12011 (emacs_no_realloc_allocator): New static constant.
12012 (emacs_readlink): New function.
12013 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12014 ../lib/careadlinkat.h.
12016 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12018 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12019 first non-nil return value).
12021 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12023 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12024 if not defined (Bug#8403).
12026 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12028 * xdisp.c (display_count_lines): Remove parameter `start',
12029 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12030 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12031 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12032 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12033 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12034 and thereabouts. All callers changed.
12035 (get_per_char_metric): Remove parameter `f', unused since
12036 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12038 2011-04-02 Jim Meyering <meyering@redhat.com>
12040 do not dereference NULL upon failed strdup
12041 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12042 (ns_get_family): Likewise.
12044 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12046 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12048 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12050 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12053 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12055 Add lexical binding.
12057 * window.c (Ftemp_output_buffer_show): New fun.
12058 (Fsave_window_excursion):
12059 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12061 * lread.c (lisp_file_lexically_bound_p): New function.
12062 (Fload): Bind Qlexical_binding.
12063 (readevalloop): Remove `evalfun' arg.
12064 Bind Qinternal_interpreter_environment.
12065 (Feval_buffer): Bind Qlexical_binding.
12066 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12068 (syms_of_lread): Declare `lexical-binding'.
12070 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12072 * keyboard.c (eval_dyn): New fun.
12073 (menu_item_eval_property): Use it.
12075 * image.c (parse_image_spec): Use Ffunctionp.
12077 * fns.c (concat, mapcar1): Accept byte-code-functions.
12079 * eval.c (Fsetq): Handle lexical vars.
12080 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12081 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12082 (FletX, Flet): Obey lexical binding.
12083 (Fcommandp): Handle closures.
12084 (Feval): New `lexical' arg.
12085 (eval_sub): New function extracted from Feval. Use it almost
12086 everywhere where Feval was used. Look up vars in lexical env.
12088 (Ffunctionp): Move from subr.el.
12089 (Ffuncall): Handle closures.
12090 (apply_lambda): Remove `eval_flags'.
12091 (funcall_lambda): Handle closures and new byte-code-functions.
12092 (Fspecial_variable_p): New function.
12093 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12094 but without exporting it to Lisp.
12096 * doc.c (Fdocumentation, store_function_docstring):
12097 * data.c (Finteractive_form): Handle closures.
12099 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12102 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12104 (exec_byte_code): New function extracted from Fbyte_code to handle new
12105 calling convention for byte-code-functions. Add new byte-codes.
12107 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
12109 * alloc.c (Fmake_symbol): Init new `declared_special' field.
12111 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12113 * xdisp.c (redisplay_internal): Fix prototype.
12115 2011-03-31 Eli Zaretskii <eliz@gnu.org>
12117 * xdisp.c (SCROLL_LIMIT): New macro.
12118 (try_scrolling): Use it when setting scroll_limit.
12119 Limit scrolling to 100 screen lines.
12120 (redisplay_window): Even when falling back on "recentering",
12121 position point in the window according to scroll-conservatively,
12122 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12124 (try_scrolling): When point is above the window, allow searching
12125 as far as scroll_max, or one screenful, to compute vertical
12126 distance from PT to the scroll margin position. This prevents
12127 try_scrolling from unnecessarily failing when
12128 scroll-conservatively is set to a value slightly larger than the
12129 window height. Clean up the case of PT below the margin at bottom
12130 of window: scroll_max can no longer be INT_MAX. When aggressive
12131 scrolling is in use, don't let point enter the opposite scroll
12132 margin as result of the scroll.
12133 (syms_of_xdisp) <scroll-conservatively>: Document the
12134 threshold of 100 lines for never-recentering scrolling.
12136 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12138 * dispextern.h (move_it_by_lines):
12139 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12140 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12141 (message_log_check_duplicate): Remove parameters `prev_bol' and
12142 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12143 (redisplay_internal): Remove parameter `preserve_echo_area',
12144 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12146 * indent.c (Fvertical_motion):
12147 * window.c (window_scroll_pixel_based, Frecenter):
12148 Don't pass `need_y_p' to `move_it_by_lines'.
12150 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12152 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12153 steal a few bits to be more compact.
12154 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12155 Remove unneeded casts.
12157 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12159 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12161 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12162 binding" message (bug#7967).
12164 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12166 Fix more problems found by GCC 4.6.0's static checks.
12168 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12169 Remove unused local var.
12171 * editfns.c (Fmessage_box): Remove unused local var.
12173 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12174 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12175 Omit unused local vars.
12176 * window.c (shrink_windows): Omit unused local var.
12177 * menu.c (digest_single_submenu): Omit unused local var.
12178 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12179 Omit unused local var.
12181 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12182 Don't assume string length fits in int.
12183 (keyremap_step, read_key_sequence): Use size_t for sizes.
12184 (read_key_sequence): Don't check last_real_key_start redundantly.
12186 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12187 instead of alloca (Bug#8344).
12189 * eval.c (Fbacktrace): Don't assume nargs fits in int.
12190 (Fbacktrace_frame): Don't assume nframes fits in int.
12192 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12194 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12197 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12199 * cm.c (calccost): Turn while-do into do-while, for clarity.
12201 * keyboard.c (syms_of_keyboard): Use the same style as later
12202 in this function when indexing through an array. This also
12203 works around GCC bug 48267.
12205 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12207 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12209 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12210 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12212 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12213 This avoids undefined behavior on integer overflow, and is a bit
12214 more convenient anyway since it is compared to a size_t variable.
12216 Variadic C functions now count arguments with size_t, not int.
12217 This avoids an unnecessary limitation on 64-bit machines, which
12218 caused (substring ...) to crash on large vectors (Bug#8344).
12219 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12220 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
12221 All variadic functions and their callers changed accordingly.
12222 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12223 * data.c (arith_driver, float_arith_driver): Likewise.
12224 * editfns.c (general_insert_function): Likewise.
12225 * eval.c (struct backtrace.nargs, interactive_p)
12226 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12227 (funcall_lambda, mark_backtrace): Likewise.
12228 * fns.c (concat): Likewise.
12229 * frame.c (x_set_frame_parameters): Likewise.
12230 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12231 0 if not found, not -1. All callers changed.
12233 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12234 (stack_copy_size): Now size_t, not int.
12235 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12237 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12239 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12240 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12241 All callers changed.
12243 * lisp.h (multibyte_char_to_unibyte):
12244 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12245 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12246 * character.h (CHAR_TO_BYTE8):
12247 * cmds.c (internal_self_insert):
12248 * editfns.c (general_insert_function):
12249 * keymap.c (push_key_description):
12250 * search.c (Freplace_match):
12251 * xdisp.c (message_dolog, set_message_1): All callers changed.
12253 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12255 * keyboard.c (safe_run_hook_funcall): New function.
12256 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12257 don't set the hook to nil, but remove the offending function instead.
12258 (Qcommand_hook_internal): Remove, unused.
12259 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12260 Vcommand_hook_internal.
12262 * eval.c (enum run_hooks_condition): Remove.
12263 (funcall_nil, funcall_not): New functions.
12264 (run_hook_with_args): Call each function through a `funcall' argument.
12265 Remove `cond' argument, now redundant.
12266 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12267 (Frun_hook_with_args_until_failure): Adjust accordingly.
12268 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12270 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12272 * dispextern.h (string_buffer_position): Remove declaration.
12274 * print.c (strout): Remove parameter `multibyte', unused since
12275 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12277 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12278 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12279 All callers changed.
12281 * w32.c (_wsa_errlist): Use braces for struct initializers.
12283 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12284 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12285 All callers changed.
12286 (string_buffer_position): Likewise. Also, make static (it's never
12287 used outside xdisp.c).
12288 (cursor_row_p): Remove parameter `w', unused since
12289 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12290 (decode_mode_spec): Remove parameter `precision', introduced during
12291 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12292 All callers changed.
12294 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12296 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12298 2011-03-27 Anders Lindgren <andlind@gmail.com>
12300 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12301 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12302 (ns_update_auto_hide_menu_bar): New functions.
12303 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12304 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12305 ns_constrain_all_frames.
12306 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12307 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12309 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12311 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12313 2011-03-27 Glenn Morris <rgm@gnu.org>
12315 * syssignal.h: Replace RETSIGTYPE with void.
12316 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12317 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12318 Replace SIGTYPE with void everywhere.
12319 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12320 * s/template.h (SIGTYPE): Remove commented out definition.
12322 2011-03-26 Eli Zaretskii <eliz@gnu.org>
12324 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12325 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12327 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
12329 * w32.c (read_unc_volume): Use parameter `henum', instead of
12330 global variable `wget_enum_handle'.
12332 * keymap.c (describe_vector): Remove parameters `indices' and
12333 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12334 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12336 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12338 * keyboard.c (timer_check): Remove parameter `do_it_now',
12339 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12340 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12341 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12343 * keyboard.c (read_char):
12344 * w32menu.c (w32_menu_display_help):
12345 * xmenu.c (show_help_event, menu_help_callback):
12346 Adjust calls to `show_help_echo'.
12348 * gtkutil.c (xg_maybe_add_timer):
12349 * keyboard.c (readable_events):
12350 * process.c (wait_reading_process_output):
12351 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12353 * insdel.c (adjust_markers_gap_motion):
12354 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12355 (gap_left, gap_right): Don't call it.
12357 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12359 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12360 incurred during fontification.
12362 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12364 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12365 (DEFVAR_PER_BUFFER): Don't pass it.
12367 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12368 (scrolling_window): Don't pass it.
12370 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12372 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12374 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12376 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12377 of variables specific to SELinux and computation of `encoded_absname'.
12379 * image.c (XPutPixel): Remove unused variable `height'.
12381 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12383 * unexw32.c (get_section_info): Remove unused variable `section'.
12385 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12386 (system_process_attributes): Remove unused variable `sess'.
12387 (sys_read): Remove unused variable `err'.
12389 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12390 (w32_wnd_proc): Remove unused variable `isdead'.
12391 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12392 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12393 (x_create_tip_frame): Remove unused variable `tem'.
12395 * w32inevt.c (w32_console_read_socket):
12396 Remove unused variable `no_events'.
12398 * w32term.c (x_draw_composite_glyph_string_foreground):
12399 Remove unused variable `width'.
12401 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12403 * w32term.c (x_set_glyph_string_clipping):
12404 Don't pass uninitialized region to CombineRgn.
12406 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12408 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12409 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12410 (Fx_close_connection): Remove unused variable `i'.
12412 * w32font.c (w32font_draw): Return number of glyphs.
12413 (w32font_open_internal): Remove unused variable `i'.
12414 (w32font_driver): Add missing initializer.
12416 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12417 (fill_in_menu): Remove unused variable `items_added'.
12419 * w32term.c (last_mouse_press_frame): Remove static global variable.
12420 (w32_clip_to_row): Remove unused variable `f'.
12421 (x_delete_terminal): Remove unused variable `i'.
12423 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12424 (NOTHING): Remove unused static global variable.
12425 (uniscribe_check_otf): Remove unused variable `table'.
12426 (uniscribe_font_driver): Add missing initializers.
12428 2011-03-23 Julien Danjou <julien@danjou.info>
12430 * term.c (Fsuspend_tty, Fresume_tty):
12431 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12432 * window.c (temp_output_buffer_show):
12433 * insdel.c (signal_before_change):
12434 * frame.c (Fhandle_switch_frame):
12435 * fileio.c (Fdo_auto_save):
12436 * emacs.c (Fkill_emacs):
12437 * editfns.c (save_excursion_restore):
12438 * cmds.c (internal_self_insert):
12439 * callint.c (Fcall_interactively):
12440 * buffer.c (Fkill_all_local_variables):
12441 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12443 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12444 unconditionally since it does the check itself.
12446 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12448 Fix more problems found by GCC 4.5.2's static checks.
12450 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12451 the first time through the loop, since we know p0 < p1 then.
12452 This also avoids a gcc -Wstrict-overflow warning.
12454 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12455 leading to a memory leak, possible in functions like
12456 load_charset_map_from_file that can allocate an unbounded number
12457 of objects (Bug#8318).
12459 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12460 that could (at least in theory) be that large.
12462 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12463 This is less likely to overflow, and avoids undefined behavior if
12464 overflow does occur. All callers changed. Use strtoul to scan
12465 for the unsigned long integer.
12466 (pint2hrstr): Simplify and tune code slightly.
12467 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
12469 * scroll.c (do_scrolling): Work around GCC bug 48228.
12470 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12472 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12473 This also avoids a warning with gcc -Wstrict-overflow.
12474 (validate_x_resource_name): Simplify count usage.
12475 This also avoids a warning with gcc -Wstrict-overflow.
12477 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12480 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
12482 * process.c (Fmake_network_process): Use socklen_t, not int,
12483 where POSIX says socklen_t is required in portable programs.
12484 This fixes a porting bug on hosts like 64-bit HP-UX, where
12485 socklen_t is wider than int (Bug#8277).
12486 (Fmake_network_process, server_accept_connection):
12487 (wait_reading_process_output, read_process_output):
12490 * process.c: Rename or move locals to avoid shadowing.
12491 (list_processes_1, Fmake_network_process):
12492 (read_process_output_error_handler, exec_sentinel_error_handler):
12493 Rename or move locals.
12494 (Fmake_network_process): Define label "retry_connect" only if needed.
12495 (Fnetwork_interface_info): Fix pointer signedness.
12496 (process_send_signal): Add cast to avoid pointer signedness problem.
12497 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
12498 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
12500 Make tparam.h and terminfo.c consistent.
12501 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12502 Include tparam.h instead, since it declares them.
12503 * cm.h (PC): Remove extern decl; tparam.h now does this.
12504 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12505 * terminfo.c: Include tparam.h, to check interfaces.
12506 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12507 (tparam): Adjust signature to match interface in tparam.h;
12508 this removes some undefined behavior. Check that outstring and len
12509 are zero, which they always are with Emacs.
12510 * tparam.h (PC, BC, UP): New extern decls.
12512 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
12513 (xftfont_open): Rename locals to avoid shadowing.
12515 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
12516 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12517 (OTF_TAG_SYM): Omit macro if not needed.
12518 (ftfont_list): Remove unused local.
12519 (get_adstyle_property, ftfont_pattern_entity):
12520 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12521 Rename locals to avoid shadowing.
12523 * xfont.c (xfont_list_family): Mark var as initialized.
12525 * xml.c (make_dom): Now static.
12527 * composite.c (composition_compute_stop_pos): Rename local to
12529 (composition_reseat_it): Remove unused locals.
12530 (find_automatic_composition, composition_adjust_point): Likewise.
12531 (composition_update_it): Mark var as initialized.
12532 (find_automatic_composition): Mark vars as initialized,
12533 with a FIXME (Bug#8290).
12535 character.h: Rename locals to avoid shadowing.
12536 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12537 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12538 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12539 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12540 to avoid shadowing.
12542 * textprop.c (property_change_between_p): Remove; unused.
12544 * intervals.c (interval_start_pos): Now static.
12546 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12548 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12549 Rename locals to avoid shadowing.
12551 * sound.c (wav_play, au_play, Fplay_sound_internal):
12552 Fix pointer signedness.
12553 (alsa_choose_format): Remove unused local var.
12554 (wav_play): Initialize a variable to 0, to prevent undefined
12555 behavior (Bug#8278).
12557 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12559 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12561 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12562 clobbering (Bug#8298).
12563 * sysdep.c (sys_subshell): Likewise.
12564 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
12566 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12567 This should get cleaned up, so that child_setup has the
12568 same signature on all platforms.
12570 * callproc.c (call_process_cleanup): Now static.
12571 (relocate_fd): Rename locals to avoid shadowing.
12573 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
12575 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12576 not to be necessary, and produces flickering.
12578 2011-03-20 Glenn Morris <rgm@gnu.org>
12580 * config.in: Remove file.
12582 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
12584 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12585 are now in src/globals.h.
12586 (syms_of_minibuf): Remove spurious & from previous change.
12588 2011-03-20 Leo Liu <sdl.web@gmail.com>
12590 * minibuf.c (completing-read-function): New variable.
12591 (completing-read-default): Rename from completing-read.
12592 (completing-read): Call completing-read-function.
12594 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12596 * xfaces.c (Fx_load_color_file):
12597 Read color file from absolute filename (bug#8250).
12599 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12601 * makefile.w32-in: Update dependencies.
12603 2011-03-17 Eli Zaretskii <eliz@gnu.org>
12605 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12607 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12609 Fix more problems found by GCC 4.5.2's static checks.
12611 * process.c (make_serial_process_unwind, send_process_trap):
12612 (sigchld_handler): Now static.
12614 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12615 That way, the code declares only the vars that it needs.
12616 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12617 * s/cygwin.h (PTY_ITERATION): Likewise.
12618 * s/darwin.h (PTY_ITERATION): Likewise.
12619 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12621 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12622 * process.c (allocate_pty): Don't declare stb unless it's needed.
12624 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
12625 (CONSTANTLIM): Remove; unused.
12626 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12627 Define only if needed.
12629 * unexelf.c (unexec): Name an expression,
12630 to avoid gcc -Wbad-function-cast warning.
12631 Use a different way to cause a compilation error if anyone uses
12632 n rather than nn, a way that does not involve shadowing.
12633 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
12635 * deps.mk (unexalpha.o): Remove; unused.
12637 New file unexec.h, the (simple) interface for unexec (Bug#8267).
12638 * unexec.h: New file.
12639 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12640 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12641 Depend on unexec.h.
12642 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12643 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12644 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
12645 Change as necessary to match prototype in unexec.h.
12647 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12649 (back_comment, skip_chars): Mark vars as initialized.
12651 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12652 Rename locals to avoid shadowing.
12654 * lread.c (read1): Rewrite so as not to use empty "else".
12655 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
12657 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12659 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12660 warning when compiling print.c.
12662 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12663 instead of using an uninitialized var.
12664 (font_sort_entities): Mark var as initialized.
12666 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12668 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12669 pointers to constants.
12670 (font_parse_fcname): Remove unused vars.
12671 (font_delete_unmatched): Now static.
12672 (font_get_spec): Remove; unused.
12673 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12674 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12675 Rename or move locals to avoid shadowing.
12677 * fns.c (require_nesting_list, require_unwind): Now static.
12678 (Ffillarray): Rename locals to avoid shadowing.
12680 * floatfns.c (domain_error2): Define only if needed.
12681 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
12683 * alloc.c (mark_backtrace): Move decl from here ...
12684 * lisp.h: ... to here, so that it can be checked.
12686 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
12687 (Fdefvar): Rewrite so as not to use empty "else".
12688 (lisp_indirect_variable): Name an expression,
12689 to avoid gcc -Wbad-function-cast warning.
12690 (Fdefvar): Rename locals to avoid shadowing.
12692 * callint.c (quotify_arg, quotify_args): Now static.
12693 (Fcall_interactively): Rename locals to avoid shadowing.
12694 Use const pointer when appropriate.
12696 * lisp.h (get_system_name, get_operating_system_release):
12697 Move decls here, to check interfaces.
12698 * process.c (get_operating_system_release): Move decl to lisp.h.
12699 * xrdb.c (get_system_name): Likewise.
12700 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12701 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12702 some of which prompt warnings from gcc -Wbad-function-cast.
12703 (Fformat_time_string, Fencode_time, Finsert_char):
12704 (Ftranslate_region_internal, Fformat):
12705 Rename or remove local vars to avoid shadowing.
12706 (Ftranslate_region_internal): Mark var as initialized.
12708 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12711 * lisp.h (eassert): Check that the argument compiles, even if
12712 ENABLE_CHECKING is not defined.
12714 * data.c (Findirect_variable): Name an expression, to avoid
12715 gcc -Wbad-function-cast warning.
12716 (default_value, arithcompare, arith_driver, arith_error): Now static.
12717 (store_symval_forwarding): Rename local to avoid shadowing.
12718 (Fmake_variable_buffer_local, Fmake_local_variable):
12719 Mark variables as initialized.
12720 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
12722 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
12723 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12724 Rename locals to avoid shadowing.
12725 (mark_stack): Move local variables into the #ifdef region where
12727 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12728 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12730 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12731 (GC_STRING_CHARS): Remove; not used.
12732 (Fmemory_limit): Cast sbrk's returned value to char *.
12734 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12735 avoids undefined behavior in theory.
12737 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12739 Use functions, not macros, for up- and down-casing (Bug#8254).
12740 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12741 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12742 to use the following functions instead of these macros.
12743 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12744 EMACS_INT, since callers assume the returned value fits in int.
12745 (upcase1): Likewise, for UPCASE_TABLE.
12746 (uppercasep, lowercasep, upcase): New static inline functions.
12747 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
12748 the race-condition problem in the old DOWNCASE.
12750 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12751 Rename locals to avoid shadowing.
12752 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
12753 (regex_compile, re_search_2, re_match_2_internal):
12754 Remove unused local vars.
12755 (FREE_VAR): Rewrite so as not to use empty "else",
12756 which gcc can warn about.
12757 (regex_compile, re_match_2_internal): Mark locals as initialized.
12758 (RETALLOC_IF): Define only if needed.
12759 (WORDCHAR_P): Likewise. This one is never needed, but is used
12760 only in a comment talking about a compiler bug, so put inside
12761 the #if 0 of that comment.
12762 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12763 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12766 * search.c (boyer_moore): Rename locals to avoid shadowing.
12767 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12768 (PREV_CHAR_BOUNDARY): Likewise.
12770 * search.c (simple_search): Remove unused var.
12772 * dired.c (compile_pattern): Move decl from here ...
12773 * lisp.h: ... to here, so that it can be checked.
12774 (struct re_registers): New forward decl.
12776 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12778 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12780 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12781 Rename locals to avoid shadowing.
12782 (Fvertical_motion): Mark locals as initialized.
12784 * casefiddle.c (casify_object, casify_region): Now static.
12785 (casify_region): Mark local as initialized.
12787 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12789 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12790 New macros, so that the caller can use some names other than
12791 gcpro1, gcpro2, etc.
12792 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12794 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12795 argument, for consistency with GCPRO2_VAR, etc: it is now the
12796 prefix of the variable, not the variable itself. All uses
12798 * dired.c (directory_files_internal, file_name_completion):
12799 Rename locals to avoid shadowing.
12801 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12802 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12803 dired.c's scmp function, had undefined behavior.
12804 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12805 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12806 * buffer.h: ... to here, because these macros use current_buffer,
12807 and the new implementation with inline functions needs to have
12808 current_buffer in scope now, rather than later when the macros
12810 (downcase, upcase1): New static inline functions.
12811 (DOWNCASE, UPCASE1): Reimplement using these functions.
12812 This avoids undefined behavior in expressions like
12813 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12814 from race conditions in accessing the global variables
12815 case_temp1 and case_temp2.
12816 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12817 * lisp.h (case_temp1, case_temp2): Remove their decls.
12818 * character.h (ASCII_CHAR_P): Move from here ...
12819 * lisp.h: ... to here, so that the inline functions mentioned
12820 above can use them.
12822 * dired.c (directory_files_internal_unwind): Now static.
12824 * fileio.c (file_name_as_directory, directory_file_name):
12825 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12827 (file_name_as_directory): Use const pointers when appropriate.
12828 (Fexpand_file_name): Likewise. In particular, newdir might
12829 point at constant storage, so make it a const pointer.
12830 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
12831 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12833 (Fset_file_times, Finsert_file_contents, auto_save_error):
12834 Rename locals to avoid shadowing.
12836 * minibuf.c (choose_minibuf_frame_1): Now static.
12837 (Ftry_completion, Fall_completions): Rename or remove locals
12838 to avoid shadowing.
12840 * marker.c (bytepos_to_charpos): Remove; unused.
12842 * lisp.h (verify_bytepos, count_markers): New decls,
12843 so that gcc does not warn that these functions aren't declared.
12845 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12846 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12847 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
12848 (copy_text): Remove unused local var.
12850 * filelock.c (within_one_second): Now static.
12851 (lock_file_1): Rename local to avoid shadowing.
12853 * buffer.c (fix_overlays_before): Mark locals as initialized.
12854 (fix_start_end_in_overlays): Likewise. This function should be
12855 simplified by using pointers-to-pointers, but that's a different
12857 (switch_to_buffer_1): Now static.
12858 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12859 (report_overlay_modification): Rename locals to avoid shadowing.
12861 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
12862 Fix pointer signedness issue.
12863 (sys_subshell): Mark local as volatile if checking for lint,
12864 to suppress a gcc -Wclobbered warning that does not seem to be right.
12865 (MAXPATHLEN): Define only if needed.
12867 * process.c (serial_open, serial_configure): Move decls from here ...
12868 * systty.h: ... to here, so that they can be checked.
12870 * fns.c (get_random, seed_random): Move extern decls from here ...
12871 * lisp.h: ... to here, so that they can be checked.
12873 * sysdep.c (reset_io): Now static.
12874 (wait_for_termination_signal): Remove; unused.
12876 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12877 (copy_keymap_item, append_key, push_text_char_description):
12879 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12880 (DENSE_TABLE_SIZE): Remove; unused.
12881 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12882 (describe_map_tree):
12883 Rename locals to avoid shadowing.
12885 * keyboard.c: Declare functions static if they are not used elsewhere.
12886 (echo_char, echo_dash, cmd_error, top_level_2):
12887 (poll_for_input, handle_async_input): Now static.
12888 (read_char, kbd_buffer_get_event, make_lispy_position):
12889 (make_lispy_event, make_lispy_movement, apply_modifiers):
12890 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12891 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12892 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12893 (read_key_sequence, read_char): Mark locals as initialized.
12894 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12896 * keyboard.h (make_ctrl_char): New decl.
12897 (mark_kboards): Move decl here ...
12898 * alloc.c (mark_kboards): ... from here.
12900 * lisp.h (force_auto_save_soon): New decl.
12902 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12903 (DEFINE_DUMMY_FUNCTION): New macro.
12904 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12906 (main): Add casts to avoid warnings
12907 if GCC considers string literals to be constants.
12909 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12911 * dbusbind.c: Pointer signedness fixes.
12912 (xd_signature, xd_append_arg, xd_initialize):
12913 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12914 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12915 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12916 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12918 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12919 if GCC considers string literals to be constants.
12920 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12922 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12924 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12925 (print_preprocess, print_object): New macro to fix last change.
12927 * print.c (print_preprocess): Don't forget font objects.
12929 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12931 * emacs.c (USAGE3): Doc fixes.
12933 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12935 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12938 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12940 * lisp.h (VWindow_system, Qfile_name_history):
12941 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12942 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12943 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12945 * w32select.c: Don't #include "keyboard.h".
12946 (run_protected): Add extern declaration for waiting_for_input.
12948 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12949 * w32console.c (detect_input_pending, read_input_pending)
12950 (encode_terminal_code):
12951 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12952 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12953 (w32_system_caret_y, Qfile_name_history):
12954 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12955 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12956 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12957 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12958 * w32proc.c (Qlocal, report_file_error):
12959 * w32term.c (Vwindow_system, updating_frame):
12960 * w32uniscribe.c (initialized, uniscribe_font_driver):
12961 Remove unneeded extern declarations.
12963 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12965 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12967 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12969 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12970 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12971 These macros can no longer be used for assignment.
12973 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12974 Assign struct members directly, instead of using BUF_BEGV etc.
12975 (record_buffer_markers, fetch_buffer_markers): New functions for
12976 recording and fetching special buffer markers.
12977 (set_buffer_internal_1, set_buffer_temp): Use them.
12979 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12981 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12983 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12984 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12986 * xdisp.c (hscroll_window_tree):
12987 (reconsider_clip_changes): Use PT instead of BUF_PT.
12989 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12991 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12992 $(EMACS_ROOT)/lib/intprops.h.
12994 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12996 Fix more problems found by GCC 4.5.2's static checks.
12998 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12999 to unsigned char * to avoid compiler diagnostic.
13000 (xg_free_frame_widgets): Make it clear that a local variable is
13001 needed only if USE_GTK_TOOLTIP.
13002 (gdk_window_get_screen): Make it clear that this macro is needed
13003 only if USE_GTK_TOOLTIP.
13004 (int_gtk_range_get_value): New function, which avoids a diagnostic
13005 from gcc -Wbad-function-cast.
13006 (xg_set_toolkit_scroll_bar_thumb): Use it.
13007 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13008 diagnostic from gcc -Wbad-function-cast.
13009 (get_utf8_string, xg_get_file_with_chooser):
13010 Rename locals to avoid shadowing.
13011 (create_dialog): Move locals to avoid shadowing.
13013 * xgselect.c (xg_select): Remove unused var.
13015 * image.c (four_corners_best): Mark locals as initialized.
13016 (gif_load): Initialize transparent_p to zero (Bug#8238).
13017 Mark another local as initialized.
13018 (my_png_error, my_error_exit): Mark with NO_RETURN.
13020 * image.c (clear_image_cache): Now static.
13021 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
13022 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
13023 (x_edge_detection): Remove unnecessary cast that
13024 gcc -Wbad-function-cast diagnoses.
13025 (gif_load): Fix pointer signedness.
13026 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13027 (jpeg_load, gif_load): Rename locals to avoid shadowing.
13029 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
13031 Improve quality of tests for time stamp overflow.
13032 For example, without this patch (encode-time 0 0 0 1 1
13033 1152921504606846976) returns the obviously-bogus value (-948597
13034 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13035 reports time overflow. See
13036 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
13037 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13038 * editfns.c: Include limits.h and intprops.h.
13039 (TIME_T_MIN, TIME_T_MAX): New macros.
13040 (time_overflow): Move earlier, to before first use.
13041 (hi_time, lo_time): New functions, for an accurate test for
13042 out-of-range times.
13043 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13044 (Fget_internal_run_time): Don't assume time_t fits in int.
13045 (make_time): Use list2 instead of Fcons twice.
13046 (Fdecode_time): More accurate test for out-of-range times.
13047 (check_tm_member): New function.
13048 (Fencode_time): Use it, to test for out-of-range times.
13049 (lisp_time_argument): Don't rely on undefined left-shift and
13050 right-shift behavior when checking for time stamp overflow.
13052 * editfns.c (time_overflow): New function, refactoring common code.
13053 (Fformat_time_string, Fdecode_time, Fencode_time):
13054 (Fcurrent_time_string): Use it.
13056 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13057 * dired.c (make_time): Move to ...
13058 * editfns.c (make_time): ... here.
13059 * systime.h: Note the move.
13061 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13063 * fringe.c (update_window_fringes): Remove unused variables.
13065 * unexmacosx.c (copy_data_segment): Also copy __got section.
13068 2011-03-12 Eli Zaretskii <eliz@gnu.org>
13070 * termcap.c [MSDOS]: Include "msdos.h".
13071 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13072 Constify `char *' arguments and their references according to
13073 prototypes in tparam.h.
13075 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
13077 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13078 Adapt all references accordingly.
13080 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13082 2011-03-11 Tom Tromey <tromey@redhat.com>
13084 * buffer.c (syms_of_buffer): Remove obsolete comment.
13086 2011-03-11 Eli Zaretskii <eliz@gnu.org>
13088 * termhooks.h (encode_terminal_code): Declare prototype.
13090 * msdos.c (encode_terminal_code): Don't declare prototype.
13092 * term.c (encode_terminal_code): Now external again, used by
13093 w32console.c and msdos.c.
13095 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13096 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
13098 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
13100 Fix some minor problems found by GCC 4.5.2's static checks.
13102 * fringe.c (update_window_fringes): Mark locals as initialized
13104 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
13106 * alloc.c (mark_fringe_data): Move decl from here ...
13107 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13108 to check its interface.
13109 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13111 * fontset.c (free_realized_fontset): Now static.
13112 (Fset_fontset_font): Rename local to avoid shadowing.
13113 (fontset_font): Mark local as initialized.
13114 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
13116 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13118 * xselect.c (x_disown_buffer_selections): Remove; not used.
13119 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
13120 (x_own_selection, Fx_disown_selection_internal): Rename locals
13121 to avoid shadowing.
13122 (x_handle_dnd_message): Remove local to avoid shadowing.
13124 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13125 so that the caller can use some name other than gcpro1.
13126 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
13127 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13128 (Fx_backspace_delete_keys_p):
13129 Use them to avoid shadowing, and rename vars to avoid shadowing.
13130 (x_decode_color, x_set_name, x_window): Now static.
13131 (Fx_create_frame): Add braces to silence GCC warning.
13132 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
13133 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13134 Remove unused locals.
13135 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13136 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13137 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13140 * xterm.h (x_mouse_leave): New decl.
13142 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13143 Remove unused functions.
13144 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13145 (x_calc_absolute_position): Now static.
13146 (XTread_socket): Don't define label "out" unless it's used.
13147 Don't declare local "event" unless it's used.
13148 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13149 unless they are used.
13150 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13151 (x_fatal_error_signal): Remove; not used.
13152 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13153 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13154 (x_error_catcher, x_connection_closed, x_error_handler):
13155 (x_error_quitter, xembed_send_message, x_iconify_frame):
13156 (my_log_handler): Rename locals to avoid shadowing.
13157 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
13158 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
13160 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13161 Rename or move locals to avoid shadowing.
13162 (tty_defined_color, merge_face_heights): Now static.
13163 (free_realized_faces_for_fontset): Remove; not used.
13164 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13165 does not deduce is never used uninitialized.
13166 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13167 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
13169 * terminal.c (store_terminal_param): Now static.
13171 * xmenu.c (menu_highlight_callback): Now static.
13172 (set_frame_menubar): Remove unused local.
13173 (xmenu_show): Rename parameter to avoid shadowing.
13174 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13175 since they might point to immutable storage.
13176 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13177 since it's unused otherwise.
13179 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
13180 Add a FIXME, since the code still doesn't look right. (Bug#8215)
13181 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13182 avoids a gcc -Wuninitialized diagnostic.
13183 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
13184 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13185 does not deduce are never used uninitialized.
13187 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13189 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
13190 * window.c (window_loop, size_window):
13191 (run_window_configuration_change_hook, enlarge_window): Likewise.
13193 * window.c (display_buffer): Now static.
13194 (size_window): Mark variables that gcc -Wuninitialized
13195 does not deduce are never used uninitialized.
13196 * window.h (check_all_windows): New decl, to forestall
13197 gcc -Wmissing-prototypes diagnostic.
13198 * dispextern.h (bidi_dump_cached_states): Likewise.
13200 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13202 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
13203 Include <limits.h>.
13204 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13205 and to avoid gcc -Wuninitialized warning.
13206 (load_charset_map): Mark variables that gcc -Wuninitialized
13207 does not deduce are never used uninitialized.
13208 (load_charset): Abort instead of using uninitialized var (Bug#8229).
13210 * coding.c (coding_set_source, coding_set_destination):
13211 Use "else { /* comment */ }" rather than "else /* comment */;"
13212 for clarity, and to avoid gcc -Wempty-body warning.
13213 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13214 a block, when the outer 'i' will do.
13215 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13216 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13217 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13218 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13219 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13220 Rename locals to avoid shadowing.
13221 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
13222 * coding.c (emacs_mule_char, encode_invocation_designation):
13223 Now static, since they're not used elsewhere.
13224 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
13225 (decode_coding_object, encode_coding_object, detect_coding_system):
13226 (decode_coding_emacs_mule): Mark variables that gcc
13227 -Wuninitialized does not deduce are never used uninitialized.
13228 (detect_coding_iso_2022): Initialize a local variable that might
13229 be used uninitialized. Leave a FIXME because it's not clear that
13230 this initialization is needed. (Bug#8211)
13231 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13232 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13233 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13234 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13235 Remove unused macros.
13237 * category.c (hash_get_category_set): Remove unused local var.
13238 (copy_category_table): Now static, since it's not used elsewhere.
13239 * character.c (string_count_byte8): Likewise.
13241 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13242 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13244 * chartab.c (copy_sub_char_table): Now static, since it's not used
13246 (sub_char_table_ref_and_range, char_table_ref_and_range):
13247 Rename locals to avoid shadowing.
13248 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
13250 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
13251 (BIDI_BOB): Remove unused macro.
13253 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13254 deduce are never used uninitialized.
13255 * term.c (encode_terminal_code): Likewise.
13257 * term.c (encode_terminal_code): Now static. Remove unused local.
13259 * tparam.h: New file.
13260 * term.c, tparam.h: Include it.
13261 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13262 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13263 Move these decls to tparam.h, and make them agree with what
13264 is actually in tparam.c. The previous trick of using incompatible
13265 decls in different modules does not conform to the C standard.
13266 All callers of tparam changed to use tparam's actual API.
13267 * tparam.c (tparam1, tparam, tgoto):
13268 Use const pointers where appropriate.
13270 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13271 * cm.h (struct cm): Likewise.
13272 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13273 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13274 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13275 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13276 (turn_on_face, init_tty): Likewise.
13277 * termchar.h (struct tty_display_info): Likewise.
13279 * term.c (term_mouse_position): Rename local to avoid shadowing.
13281 * alloc.c (mark_ttys): Move decl from here ...
13282 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13284 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13286 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13288 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
13290 * search.c (compile_pattern_1): Remove argument regp, unused since
13291 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13292 (compile_pattern): Don't pass it.
13294 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13296 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13297 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13299 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13301 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13303 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13304 gdk_window_get_screen, gdk_window_get_geometry,
13305 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13306 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13307 (xg_get_pixbuf_from_pixmap): New function.
13308 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13309 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13310 Call xg_get_pixbuf_from_pixmap instead of
13311 gdk_pixbuf_get_from_drawable.
13312 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13313 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13314 (xg_check_special_colors): Use GtkStyleContext and its functions
13316 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13317 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13318 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
13319 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13320 Call gtk_widget_get_preferred_size.
13321 (xg_frame_resized): gdk_window_get_geometry only takes 5
13323 (xg_win_to_widget, xg_event_is_for_menubar):
13324 Call gdk_x11_window_lookup_for_display.
13325 (xg_set_widget_bg): New function.
13326 (delete_cb): New function.
13327 (xg_create_frame_widgets): Connect delete-event to delete_cb.
13328 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
13329 (xg_set_background_color): Call xg_set_widget_bg.
13330 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13331 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13332 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13333 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13335 (update_frame_tool_bar): Call gtk_widget_hide.
13336 (xg_initialize): Use GDK_KEY_g.
13338 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13340 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13342 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13343 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13344 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13346 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13348 * w32xfns.c (select_palette): Check success of RealizePalette against
13349 GDI_ERROR, not zero.
13351 See ChangeLog.11 for earlier changes.
13353 ;; Local Variables:
13357 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13359 This file is part of GNU Emacs.
13361 GNU Emacs is free software: you can redistribute it and/or modify
13362 it under the terms of the GNU General Public License as published by
13363 the Free Software Foundation, either version 3 of the License, or
13364 (at your option) any later version.
13366 GNU Emacs is distributed in the hope that it will be useful,
13367 but WITHOUT ANY WARRANTY; without even the implied warranty of
13368 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13369 GNU General Public License for more details.
13371 You should have received a copy of the GNU General Public License
13372 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.