* lisp/emacs-lisp/package.el (package-unpack): Load before compiling

[gnu-emacs] / test / automated / ert-tests.el

diff --git a/test/automated/ert-tests.el b/test/automated/ert-tests.el
index 181df8956f3240b00f4a6074b7423de5d193fe46..5382c400962fc806ea178cf7b5c72873a5c726d5 100644 (file)
--- a/test/automated/ert-tests.el
+++ b/test/automated/ert-tests.el
@@ -345,10 +345,15 @@ This macro is used to test if macroexpansion in `should' works."
         (should (equal actual-condition expected-condition)))))))
 
 (ert-deftest ert-test-deftest ()
+  ;; FIXME: These tests don't look very good.  What is their intent, i.e. what
+  ;; are they really testing?  The precise generated code shouldn't matter, so
+  ;; we should either test the behavior of the code, or else try to express the
+  ;; kind of efficiency guarantees we're looking for.
   (should (equal (macroexpand '(ert-deftest abc () "foo" :tags '(bar)))
                 '(progn
                    (ert-set-test 'abc
                                  (progn
+                                   "Constructor for objects of type `ert-test'."
                                    (vector 'cl-struct-ert-test 'abc "foo"
                                            #'(lambda nil)
                                            nil ':passed
@@ -363,6 +368,7 @@ This macro is used to test if macroexpansion in `should' works."
                 '(progn
                    (ert-set-test 'def
                                  (progn
+                                   "Constructor for objects of type `ert-test'."
                                    (vector 'cl-struct-ert-test 'def nil
                                            #'(lambda nil)
                                            nil ':passed 'nil)))