Revert "Bind `widget-button-click' to mouse-1/-2 instead of down-mouse-1/-2"

* lisp/wid-edit.el (widget-keymap): Bind `widget-button-click'
to mouse-1/-2 instead of down-mouse-1/-2.  Suggested by Stefan
Monnier.  (Bug#19185, Bug#20398)

This reverts commit 72166f2f3dba18f1217c666574032f5a0351ed65.

That commit did more harm than good (Bug#23571).

diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el
index 9ede9a5633f76c99eeb9066ad5003d1a241164a6..4ec14d6c8c252ec8433cb9aa9c4121c09940cdf2 100644 (file)
--- a/lisp/wid-edit.el
+++ b/lisp/wid-edit.el
@@ -852,8 +852,8 @@ button end points."
     (define-key map [(shift tab)] 'widget-backward)
     (put 'widget-backward :advertised-binding [(shift tab)])
     (define-key map [backtab] 'widget-backward)
-    (define-key map [mouse-2] 'widget-button-click)
-    (define-key map [mouse-1] 'widget-button-click)
+    (define-key map [down-mouse-2] 'widget-button-click)
+    (define-key map [down-mouse-1] 'widget-button-click)
     ;; The following definition needs to avoid using escape sequences that
     ;; might get converted to ^M when building loaddefs.el
     (define-key map [(control ?m)] 'widget-button-press)