* configure.ac: Port to hosts lacking gtk.

(PKG_CHECK_MODULES): Capture pkg-config diagnostics
better, in particular, problems in invoking pkg-config itself.
This is useful on hosts that don't have pkg-config.
(GTK_MODULES): Do not exit 'configure' simply because gtk3
and gtk2 are both missing.  Problem found on Solaris 8.

diff --git a/ChangeLog b/ChangeLog
index e46fbef711395e887f8d1f399838b9e8b3995bbf..b0f6ab6e9848565d628f1cd240c51a73f92f8885 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2012-09-14  Paul Eggert  <eggert@cs.ucla.edu>
+
+       * configure.ac: Port to hosts lacking gtk.
+       (PKG_CHECK_MODULES): Capture pkg-config diagnostics
+       better, in particular, problems in invoking pkg-config itself.
+       This is useful on hosts that don't have pkg-config.
+       (GTK_MODULES): Do not exit 'configure' simply because gtk3
+       and gtk2 are both missing.  Problem found on Solaris 8.
+
 2012-09-13  Jan Djärv  <jan.h.d@swipnet.se>
 
        * configure.ac: Reorder Xaw3d messages.

diff --git a/configure.ac b/configure.ac
index ce65f07522d9df2d7cb1771d2eafa936cdaeea0b..accbb68e7b0f0d1f0c59096ac685781251062c55 100644 (file)
--- a/configure.ac
+++ b/configure.ac
@@ -1189,9 +1189,10 @@ AC_DEFUN([PKG_CHECK_MODULES], [
             $1_CFLAGS=""
             $1_LIBS=""
             ## If we have a custom action on failure, don't print errors, but
-            ## do set a variable so people can do so.
-            $1_PKG_ERRORS=`$PKG_CONFIG --errors-to-stdout --print-errors "$2"`
-            ifelse([$4], ,echo $$1_PKG_ERRORS,)
+           ## do set a variable so people can do so.  Do it in a subshell
+           ## to capture any diagnostics in invoking pkg-config.
+           $1_PKG_ERRORS=`($PKG_CONFIG --print-errors "$2") 2>&1`
+           ifelse([$4], ,echo "$$1_PKG_ERRORS",)
         fi
 
         AC_SUBST($1_CFLAGS)
@@ -1934,10 +1935,10 @@ if test "${with_gtk2}" = "yes" || test "$check_gtk2" = "yes"; then
 
   dnl Checks for libraries.
   PKG_CHECK_MODULES(GTK, $GTK_MODULES, pkg_check_gtk=yes, pkg_check_gtk=no)
-  if test "$pkg_check_gtk" = "no"; then
-     if test "$USE_X_TOOLKIT" = "maybe" || test "$with_gtk" = "yes" || test "$with_gtk2" = "yes"; then
-       AC_MSG_ERROR($gtk3_pkg_errors$GTK_PKG_ERRORS)
-     fi
+  if test "$pkg_check_gtk" = "no" &&
+     { test "$with_gtk" = yes || test "$with_gtk2" = "yes"; }
+  then
+    AC_MSG_ERROR($gtk3_pkg_errors$GTK_PKG_ERRORS)
   fi
 fi