]> code.delx.au - pulseaudio/commitdiff
modules: Fix resource leak in tunnel-sink-new
authorPeter Meerwald <p.meerwald@bct-electronic.com>
Mon, 16 Dec 2013 15:40:03 +0000 (16:40 +0100)
committerPeter Meerwald <p.meerwald@bct-electronic.com>
Fri, 20 Dec 2013 11:54:19 +0000 (12:54 +0100)
https://scan7.coverity.com:8443/reports.htm#v10205/p10016/fileInstanceId=8770&defectInstanceId=3733&mergedDefectId=591270

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
src/modules/module-tunnel-sink-new.c

index 8d0409275c603dc1f440d76d9ad33dfa56825de2..484e538ae6550b687ccdcfcde9d7842ff705a544 100644 (file)
@@ -287,10 +287,12 @@ static void context_state_cb(pa_context *c, void *userdata) {
             pa_proplist *proplist;
             pa_buffer_attr bufferattr;
             pa_usec_t requested_latency;
-            const char *username = pa_get_user_name_malloc();
-            const char *hostname = pa_get_host_name_malloc();
+            char *username = pa_get_user_name_malloc();
+            char *hostname = pa_get_host_name_malloc();
             /* TODO: old tunnel put here the remote sink_name into stream name e.g. 'Null Output for lynxis@lazus' */
             char *stream_name = pa_sprintf_malloc(_("Tunnel for %s@%s"), username, hostname);
+            pa_xfree(hostname);
+            pa_xfree(username);
 
             pa_log_debug("Connection successful. Creating stream.");
             pa_assert(!u->stream);