]> code.delx.au - pulseaudio/commitdiff
modules: Fix resource leak in oss
authorPeter Meerwald <p.meerwald@bct-electronic.com>
Mon, 16 Dec 2013 15:31:20 +0000 (16:31 +0100)
committerPeter Meerwald <p.meerwald@bct-electronic.com>
Fri, 20 Dec 2013 11:54:18 +0000 (12:54 +0100)
https://scan7.coverity.com:8443/reports.htm#v10205/p10016/fileInstanceId=8824&defectInstanceId=3731&mergedDefectId=591267

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
src/modules/oss/module-oss.c

index 03e51c8790194d6841d8a036b19c160476f869ce..d661bdeb714d3444129ab689c903a8054ee25e52 100644 (file)
@@ -1329,6 +1329,7 @@ int pa__init(pa_module*m) {
         if (pa_modargs_get_proplist(ma, "source_properties", source_new_data.proplist, PA_UPDATE_REPLACE) < 0) {
             pa_log("Invalid properties");
             pa_source_new_data_done(&source_new_data);
+            pa_xfree(name_buf);
             goto fail;
         }
 
@@ -1397,6 +1398,7 @@ int pa__init(pa_module*m) {
         if (pa_modargs_get_proplist(ma, "sink_properties", sink_new_data.proplist, PA_UPDATE_REPLACE) < 0) {
             pa_log("Invalid properties");
             pa_sink_new_data_done(&sink_new_data);
+            pa_xfree(name_buf);
             goto fail;
         }